[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Yep! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...

2017-08-01 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Thanks for the review! Okay to merge @filmaj? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/26 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing

[GitHub] cordova-plugin-test-framework pull request #25: CB-12847: added `bugs` entry...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request #25: CB-12847: added `bugs` entry...

2017-05-25 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/25 CB-12847: added `bugs` entry to package.json. ### What does this PR do? Adds a bugs entry to the package.json. ### What testing has been done on this change

[GitHub] cordova-plugin-test-framework issue #24: Add important build step about pack...

2017-05-23 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/24 Ooo, also, could this PR be issued against the master branch? Next time we do a patch release, we will ensure to pull this commit from master into the release branch anyways

[GitHub] cordova-plugin-test-framework pull request #24: Add important build step abo...

2017-05-23 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/24#discussion_r118083583 --- Diff: README.md --- @@ -63,6 +64,8 @@ For example, the `cordova-plugin-device` plugin has this nested [`plugin.xml`](h

[GitHub] cordova-plugin-test-framework pull request #24: Add important build step abo...

2017-05-22 Thread davidschreiber
GitHub user davidschreiber opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/24 Add important build step about packages.json This step is necessary or tests won't build. The original issue that fixed this issue in all Cordova projects is was only

[GitHub] cordova-plugin-test-framework pull request #23: Fixing a few markdown render...

2017-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework issue #23: Fixing a few markdown rendering ite...

2017-04-12 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/23 Thanks for the pull request! Merged in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request #23: Fixing a few markdown render...

2017-04-11 Thread robrohan
GitHub user robrohan opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/23 Fixing a few markdown rendering items A few headings didn't have white space above them (due to the anchor tags). Just added the white space so the file renders correctly

[GitHub] cordova-plugin-test-framework pull request #21: CB-11917 - Remove pull reque...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request #22: chore: edit package.json lic...

2016-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request #22: chore: edit package.json lic...

2016-09-28 Thread t1st3
GitHub user t1st3 opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/22 chore: edit package.json license to match SPDX id ### Platforms affected All ### What does this PR do? Fix a typo in the license field of package.json

[GitHub] cordova-plugin-test-framework pull request #21: CB-11917 - Remove pull reque...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/21 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-test-framework pull request #13: CB-9071 Update test framewor...

2016-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-20 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212739167 Not exactly sure about that. I guess the iOS simulator had issues dealing with so many post calls and other platforms may be handled

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-20 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212679043 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request: CB-11124 Fixing cordov...

2016-04-20 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/20 CB-11124 Fixing cordova-ios build failure due to unnecessary post cal… …ls to couchdb and adding handlers to xhr call You can merge this pull request into a Git

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

2016-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

2016-04-14 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/19#issuecomment-210012817 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

2016-04-13 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/19 Add spec started/completed log This will help in debugging and provides a start/stop marker in native logs. You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-test-framework pull request: CB-10876 Enable inerti...

2016-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-10636 Add JSHint fo...

2016-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-10636 Add JSHint fo...

2016-03-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/17#issuecomment-190725941 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-test-framework pull request: CB-10636 Add JSHint fo...

2016-03-01 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/17 CB-10636 Add JSHint for plugins [Jira issue](https://issues.apache.org/jira/browse/CB-10636) ```javascript /* jshint -W097 */ 'use strict

[GitHub] cordova-plugin-test-framework pull request: CB-10318 Do not wrap t...

2016-01-11 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/16 CB-10318 Do not wrap test title https://issues.apache.org/jira/browse/CB-10318 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-plugin-test-framework pull request: CB-10318 Do not wrap t...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-10-22 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/15 CB-8973: Changed the functionality of making the log appear and disap… …pear Applies the UI fix for wp8 platform You can merge this pull request into a Git

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-10-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/14#issuecomment-149079635 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-10-17 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/14 CB-8973: Changed the functionality of making the log appear and disap… …pear Fixes a typo `classList.add` -> `classList.remove`. Adds JS logic to adj

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-30 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117386712 Code does work. I have been running my plugin tests with this change. For the Cordova mobile spec, I don't have an iOS device on me

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-30 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117172177 Just updating the Jasmine files. No custom changes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-30 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117282507 Ok, LGTM. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-30 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117333658 Due to some bugs with iOS, I'm unable to test this after the rebase on my machine. @marcuspridham have you verified that the code works

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117366652 Also, Marcus have you filed the Apache iCLA? If not please sign, scan and send one to secret...@apache.org: http://www.apache.org/licenses

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-29 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116774679 @dblotsky Can you take a look at this change? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-29 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116850705 On it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-29 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116949803 I've tested on iOS and it seems to work fine. @marcuspridham, did you make any custom changes, or is it just an update of the files that belong

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-05-25 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13 CB-9071 Update test framework plugin to use Jasmine 2.3.4 Updating Jasmine version from 2.2.0 to 2.3.4. You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-05-06 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/12 CB-8973: Changed the functionality of making the log appear and disappear When the log appears, it appears over the content area, which means (for example) on the Manual

[GitHub] cordova-plugin-test-framework pull request: CB-8528 Update test fr...

2015-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-04 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810379 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-04 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810268 @nikhilkh, addressed CR notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-04 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24069058 --- Diff: www/medic.js --- @@ -35,30 +35,27 @@ exports.log = function() { }; exports.load = function (callback

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-03 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24058292 --- Diff: www/medic.js --- @@ -35,30 +35,27 @@ exports.log = function() { }; exports.load = function (callback

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-02 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10 CB-8385 Ensure plugin-test-framework trigger tests only once https://issues.apache.org/jira/browse/CB-8385 Simplified medic config loading logic by making it synch

[GitHub] cordova-plugin-test-framework pull request: CB-8388 Prevent Window...

2015-01-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8388 Prevent Window...

2015-01-30 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/9 CB-8388 Prevent Windows app from crashing on test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech

[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...

2015-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8295 Enable CSP for...

2015-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...

2015-01-14 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968802 --- Diff: www/main.js --- @@ -215,6 +237,12 @@ function createEnablerList() { enablerList.appendChild(checkButtonBar

[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...

2015-01-14 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968690 --- Diff: www/main.js --- @@ -225,6 +253,43 @@ function createEnablerList

[GitHub] cordova-plugin-test-framework pull request: CB-8295 Enable CSP for...

2015-01-14 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/8 CB-8295 Enable CSP for mobile spec - Uses a javascript include file (provided by mobile spec app) to document.write a CSP tag on page - If hosted outside of mobile spec

[GitHub] cordova-plugin-test-framework pull request: CB-8070 MedicReporter ...

2014-12-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework pull request: CB-8070 MedicReporter ...

2014-11-25 Thread MariaBukharina
GitHub user MariaBukharina opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/7 CB-8070 MedicReporter incompatible with medic couch db structure. https://issues.apache.org/jira/browse/CB-8070 You can merge this pull request into a Git repository

[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...

2014-09-22 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/6 CB-7459 Add header to show number of enabled plugin tests It is not obvious if all/how many plugin tests are being run, given that: - Individual plugin tests can be enabled

[GitHub] cordova-plugin-test-framework pull request: CB-7459 Allow automati...

2014-09-10 Thread clambertus
Github user clambertus commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/4#issuecomment-55138873 test jira integration comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-test-framework pull request: CB-7459 Allow automati...

2014-09-10 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/4#issuecomment-55140469 Wow this is good, Thanks Jason. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-test-framework pull request: Updated test-framework...

2014-09-10 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/5 Updated test-framework docs Updated information about tests being stored as nested plugins, and changed 'test' directory to 'tests'. You can merge this pull request into a Git

[GitHub] cordova-plugin-test-framework pull request: Updated test-framework...

2014-09-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: plugin-test-framework PRs

2014-08-06 Thread Andrew Grieve
://github.com/apache/cordova-mobile-spec/pull/87 Vibration: https://github.com/apache/cordova-mobile-spec/pull/88 Also a few days ago, I created a PR against plugin-test-framework, just some little changes to the css, all details on the description: https://github.com/apache/cordova-plugin-test

Re: plugin-test-framework PRs

2014-08-06 Thread Jesse
AM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Hey Michal, I've followed up your instructions to easily integrate the test along with plugin-test-framework, as you can see I have spammed a little bit the dev list with PRs, anyway here's the list of PRs, that includes

Re: plugin-test-framework PRs

2014-08-06 Thread Michal Mocny
along with plugin-test-framework, as you can see I have spammed a little bit the dev list with PRs, anyway here's the list of PRs, that includes File, Media, Battery-Status and Vibration: https://github.com/apache/cordova-plugin-file/pull/62 https://github.com/apache

Re: plugin-test-framework PRs

2014-08-01 Thread Martin Gonzalez
Hey Michal, I've followed up your instructions to easily integrate the test along with plugin-test-framework, as you can see I have spammed a little bit the dev list with PRs, anyway here's the list of PRs, that includes File, Media, Battery-Status and Vibration: https://github.com/apache/cordova

Re: plugin-test-framework PRs

2014-08-01 Thread Staci Cooper
wrote: Hey Michal, I've followed up your instructions to easily integrate the test along with plugin-test-framework, as you can see I have spammed a little bit the dev list with PRs, anyway here's the list of PRs, that includes File, Media, Battery-Status and Vibration: https://github.com/apache

Re: plugin-test-framework PRs

2014-08-01 Thread Michal Mocny
, 2014 at 3:55 AM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Hey Michal, I've followed up your instructions to easily integrate the test along with plugin-test-framework, as you can see I have spammed a little bit the dev list with PRs, anyway here's the list of PRs

Re: plugin-test-framework PRs

2014-08-01 Thread purplecabbage
the porting process. Then when everything is done we can remove the links in a final PR. -Staci On Fri, Aug 1, 2014 at 3:55 AM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Hey Michal, I've followed up your instructions to easily integrate the test along with plugin-test-framework

Re: plugin-test-framework PRs

2014-07-30 Thread Staci Cooper
! -Michal On Wed, Jul 16, 2014 at 4:38 PM, Staci Cooper staci@gmail.com wrote: Hi all, Several of us at IBM have been working on porting tests from mobile-spec to the plugin-test-framework. I believe we have pull requests out for all of the automated tests; we also have

Re: plugin-test-framework PRs

2014-07-30 Thread Michal Mocny
PM, Staci Cooper staci@gmail.com wrote: Hi all, Several of us at IBM have been working on porting tests from mobile-spec to the plugin-test-framework. I believe we have pull requests out for all of the automated tests; we also have the manual tests ported and are just

Re: plugin-test-framework PRs

2014-07-30 Thread Staci Cooper
working on porting tests from mobile-spec to the plugin-test-framework. I believe we have pull requests out for all of the automated tests; we also have the manual tests ported and are just wrapping up testing on ios/android, so those additional pull requests should

Re: plugin-test-framework PRs

2014-07-22 Thread Michal Mocny
to committers. Thanks for your work here! -Michal On Wed, Jul 16, 2014 at 4:38 PM, Staci Cooper staci@gmail.com wrote: Hi all, Several of us at IBM have been working on porting tests from mobile-spec to the plugin-test-framework. I believe we have pull requests out for all

plugin-test-framework PRs

2014-07-16 Thread Staci Cooper
Hi all, Several of us at IBM have been working on porting tests from mobile-spec to the plugin-test-framework. I believe we have pull requests out for all of the automated tests; we also have the manual tests ported and are just wrapping up testing on ios/android, so those additional pull

Re: plugin-test-framework PRs

2014-07-16 Thread Michal Mocny
can just switch the start page with no change to committers. Thanks for your work here! -Michal On Wed, Jul 16, 2014 at 4:38 PM, Staci Cooper staci@gmail.com wrote: Hi all, Several of us at IBM have been working on porting tests from mobile-spec to the plugin-test-framework. I believe we

Re: plugin test framework

2014-07-08 Thread Martin Gonzalez
Great!! 2014-07-08 10:55 GMT-05:00 Michal Mocny mmo...@chromium.org: FYI filed ticket with INFRA to create cordova-plugin-test-framework: https://issues.apache.org/jira/browse/INFRA-8017 On Tue, Jun 24, 2014 at 8:22 PM, Andrew Grieve agri...@chromium.org wrote: On Tue, Jun 24, 2014

Re: plugin test framework

2014-06-24 Thread Martin Gonzalez
to the user/dev to run or emulate or both, emulator/device? -'cordova run/emulate --tests cdvtests/index.html' or 'cordova run/emulate --tests' ? there is any other useful arguments to improve the workflow? -plugin-test-framework, installed manually or automatically? Also Andrew points are good, improve

Re: plugin test framework

2014-06-24 Thread Andrew Grieve
cordova platform add android cordova plugin add http://git-wip-us.apache.org/repos/asf/cordova-labs.git# cdvtest:cordova-plugin-test-framework cordova plugin add ../cordova-plugin-file/ cordova plugin add ../cordova-plugin-file/test/ cordova run android --start cdvtests

Re: plugin test framework

2014-06-19 Thread Jesse
that in addition to processing the plugin.xml of the plugin, we would also process the plugin-test.xml file ( identical processing logic ) 4. have all plugin-test.xml files declare a dependency on cordova-plugin-test-framework The above suggestions could also be used in conjuction with the cordova run

Re: plugin test framework

2014-06-19 Thread Michal Mocny
elaborated my answer in the plugin FAQ ( https://github.com/apache/cordova-labs/blob/cdvtest/cordova-plugin-test-framework/README.md#faq ): FAQ - Q: Should I add org.apache.cordova.test-harness as a dependancy of my plugin? - A: No. The end-user should decide if they want to install

Re: plugin test framework

2014-06-19 Thread Jesse
plugin, say because it uses huge assets, I elaborated my answer in the plugin FAQ ( https://github.com/apache/cordova-labs/blob/cdvtest/cordova-plugin-test-framework/README.md#faq ): FAQ - Q: Should I add org.apache.cordova.test-harness as a dependancy of my plugin

Re: plugin test framework

2014-06-19 Thread Michal Mocny
are just always installed alongside plugins. If that is not a good idea for some particular plugin, say because it uses huge assets, I elaborated my answer in the plugin FAQ ( https://github.com/apache/cordova-labs/blob/cdvtest/cordova-plugin-test-framework/README.md#faq ): FAQ

Re: plugin test framework

2014-06-19 Thread Jesse
assets, I elaborated my answer in the plugin FAQ ( https://github.com/apache/cordova-labs/blob/cdvtest/cordova-plugin-test-framework/README.md#faq ): FAQ - Q: Should I add org.apache.cordova.test-harness as a dependancy of my plugin? - A: No. The end

Re: plugin test framework

2014-06-19 Thread Jesse
My ultimate would be this: cordova create TestFilePlugin cd TestFilePlugin cordova platform add android cordova plugin add http://git-wip-us.apache.org/repos/asf/cordova-labs.git#cdvtest:cordova-plugin-test-framework cordova plugin add ../cordova-plugin-file/ cordova plugin add ../cordova-plugin

Re: plugin test framework

2014-06-19 Thread Michal Mocny
-plugin-test-framework cordova plugin add ../cordova-plugin-file/ cordova plugin add ../cordova-plugin-file/test/ cordova run android --start cdvtests/index.html Then do this for each plugin, and for each platform Then do this for all combinations of plugins ... Note the run --start does

Re: plugin test framework

2014-06-19 Thread purplecabbage
TestFilePlugin cordova platform add android cordova plugin add http://git-wip-us.apache.org/repos/asf/cordova-labs.git#cdvtest:cordova-plugin-test-framework cordova plugin add ../cordova-plugin-file/ cordova plugin add ../cordova-plugin-file/test/ cordova run android --start cdvtests

Re: plugin test framework

2014-06-19 Thread Piotr Zalewa
On Thu, Jun 19, 2014 at 7:48 PM, Jesse purplecabb...@gmail.com wrote: My ultimate would be this: cordova create TestFilePlugin cd TestFilePlugin cordova platform add android cordova plugin add http://git-wip-us.apache.org/repos/asf/cordova-labs.git#cdvtest:cordova-plugin-test-framework

Re: plugin test framework

2014-06-17 Thread Piotr Zalewa
like any help. -Michal On Mon, Jun 16, 2014 at 3:25 PM, Marcel Kinard cmarc...@gmail.com wrote: Hi, after some discussions here with IBM management, we’re going to bring in a couple extra interns for a week to jumpstart the migration of the tests out of mobile-spec into the new plugin test

Re: plugin test framework

2014-06-17 Thread Michal Mocny
interns for a week to jumpstart the migration of the tests out of mobile-spec into the new plugin test framework. Staci Cooper will be leading this effort, and Martin Gonzalez will be a part of it. So if you see a bunch of pull requests, this is what it is for. We’ll get the interns to submit

Re: plugin test framework

2014-06-17 Thread Piotr Zalewa
: Hi, after some discussions here with IBM management, we’re going to bring in a couple extra interns for a week to jumpstart the migration of the tests out of mobile-spec into the new plugin test framework. Staci Cooper will be leading this effort, and Martin Gonzalez will be a part of it. So if you

Re: plugin test framework

2014-06-17 Thread Martin Gonzalez
This is the Cordova Plugin Test Framework readme.md, you can catch up with the functionality by reading some of the content: Repository: https://github.com/apache/cordova-labs Docs: https://github.com/apache/cordova-labs/blob/master/README.md https://github.com/apache/cordova-labs/blob/cdvtest

Re: plugin test framework

2014-06-17 Thread Michal Mocny
Martin, thanks for posting those links. And I'll look into the INFRA tickets I need to file to set up a repo for that plugin, since its ready to come out of labs. On Tue, Jun 17, 2014 at 2:06 PM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: This is the Cordova Plugin Test Framework

Re: plugin test framework

2014-06-17 Thread Piotr Zalewa
a repo for that plugin, since its ready to come out of labs. On Tue, Jun 17, 2014 at 2:06 PM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: This is the Cordova Plugin Test Framework readme.md, you can catch up with the functionality by reading some of the content: Repository: https

Re: plugin test framework

2014-06-17 Thread Martin Gonzalez
of labs. On Tue, Jun 17, 2014 at 2:06 PM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: This is the Cordova Plugin Test Framework readme.md, you can catch up with the functionality by reading some of the content: Repository: https://github.com/apache/cordova-labs Docs: https

Re: plugin test framework

2014-06-17 Thread Piotr Zalewa
Framework readme.md, you can catch up with the functionality by reading some of the content: Repository: https://github.com/apache/cordova-labs Docs: https://github.com/apache/cordova-labs/blob/master/README.md https://github.com/apache/cordova-labs/blob/cdvtest/ cordova-plugin-test-framework

  1   2   >