Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-27 Thread Nikita Vetoshkin
On Jan. 27, 2014, 7:53 a.m., Ian Downes wrote: What about supporting environment variables specific to the child process? This is necessary for distinct environments between different subprocesses and the parent. This could be done by prepending the command with 'env' but it'll be

question about hadoop on mesos

2014-01-27 Thread HUO Jing
Hi, I ran a map-only job on hadoop. But on every tasktracker, it had only 7 map slots running. How to let it be 8 map slots?

Re: question about hadoop on mesos

2014-01-27 Thread HUO Jing
Hi, I ran a map-only job on hadoop. Every node has 8 cores, but on every tasktracker, it had only 7 map slots running. How to let tasktracker run 8 map slots on every node? Thank you

Re: question about hadoop on mesos

2014-01-27 Thread HUO Jing
Another question, The tasktracker can not stop after the hadoop job is done. Why? -原始邮件- 发件人: HUO Jing huoj...@ihep.ac.cn 发送时间: 2014年1月27日 星期一 收件人: dev@mesos.apache.org 抄送: Brenden Matthews bren...@diddyinc.com 主题: Re: question about hadoop on mesos Hi, I ran a map-only job on

Re: Review Request 17343: Exposed coordinator demotion.

2014-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17343/#review32782 --- Ship it! src/log/coordinator.hpp

Re: Please Help me about hadoop on Mesos

2014-01-27 Thread Vinod Kone
I have some questions about running hadoop on top of Mesos, please help me. 1. when a tasktracker is launched, if n cpu core are allocated to it, it can only launch n-1 map tasks. Could someone tell me why? And, if I want to run map-only job, what should I do to run n map tasks on a n cpu

[jira] [Resolved] (MESOS-799) Mesos python egg is faulty on OS X Mavericks

2014-01-27 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen resolved MESOS-799. -- Resolution: Fixed Fix Version/s: 0.17.0 Python issues should be resolved

[jira] [Commented] (MESOS-798) ExamplesTest.PythonFramework failing

2014-01-27 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883017#comment-13883017 ] Niklas Quarfot Nielsen commented on MESOS-798: -- Bernardo, can we mark this are

[jira] [Resolved] (MESOS-775) expose count of running tasks

2014-01-27 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen resolved MESOS-775. -- Resolution: Duplicate Duplicate of MESOS-772 expose count of running tasks

Re: Review Request 17345: Replaced Log::Writer constructor with explicit Log::Writer::start.

2014-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17345/#review32851 --- src/java/jni/org_apache_mesos_Log.cpp

Re: Review Request 17346: Exposed coordinator demotion in Log.

2014-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17346/#review32858 --- src/java/jni/org_apache_mesos_Log.cpp

[jira] [Created] (MESOS-948) Docs for Java interfaces

2014-01-27 Thread Connor Doyle (JIRA)
Connor Doyle created MESOS-948: -- Summary: Docs for Java interfaces Key: MESOS-948 URL: https://issues.apache.org/jira/browse/MESOS-948 Project: Mesos Issue Type: Documentation

[jira] [Created] (MESOS-949) slave should wipe meta directory on startup if bootid changes

2014-01-27 Thread Kevin Sweeney (JIRA)
Kevin Sweeney created MESOS-949: --- Summary: slave should wipe meta directory on startup if bootid changes Key: MESOS-949 URL: https://issues.apache.org/jira/browse/MESOS-949 Project: Mesos

Re: Re: Please Help me about hadoop on Mesos

2014-01-27 Thread Vinod Kone
On Mon, Jan 27, 2014 at 10:07 AM, HUO Jing huoj...@ihep.ac.cn wrote: So, at the very beginning, if all the resource are assigned to hadoop, and after that, there are always enough jobs in jobtracker, is that meanning that the other framework will never get resource? Is it fair to do so ?

[jira] [Resolved] (MESOS-949) slave should wipe meta directory on startup if bootid changes

2014-01-27 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone resolved MESOS-949. -- Resolution: Duplicate Assignee: Benjamin Mahler slave should wipe meta directory on startup if

[jira] [Updated] (MESOS-948) Docs for Java interfaces

2014-01-27 Thread Connor Doyle (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Connor Doyle updated MESOS-948: --- Description: There is some great user documentation embedded in the Java API sources (see:

Review Request 17423: Added log implementation for state storage.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17423/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git

Review Request 17424: Refactored LogStoragProcess for C++03.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17424/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git

Re: Review Request 17423: Added log implementation for state storage.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17423/ --- (Updated Jan. 27, 2014, 9:33 p.m.) Review request for mesos, Ben Mahler and

[jira] [Commented] (MESOS-950) Add LLDB helpers

2014-01-27 Thread Benjamin Hindman (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883371#comment-13883371 ] Benjamin Hindman commented on MESOS-950: YES PLEASE YES PLEASE YES PLEASE! Do you

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Ben Mahler
On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote: src/launcher/executor.cpp, line 298 https://reviews.apache.org/r/17305/diff/1/?file=447761#file447761line298 I think it makes sense to have a global reaper just like we do with statistics. Having multiple libprocess processes

[jira] [Commented] (MESOS-950) Add LLDB helpers

2014-01-27 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883416#comment-13883416 ] Niklas Quarfot Nielsen commented on MESOS-950: -- Do you think we should put

[jira] [Closed] (MESOS-829) Switch website CMS from Jekyll to Middleman

2014-01-27 Thread Dave Lester (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Lester closed MESOS-829. - Resolution: Fixed Fixed. Thanks for your help, [~jfarrell]! Switch website CMS from Jekyll to Middleman

Review Request 17427: Handled EINTR in os::close.

2014-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17427/ --- Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-27 Thread Ben Mahler
On Jan. 24, 2014, 6:16 p.m., Ian Downes wrote: 3rdparty/libprocess/include/process/subprocess.hpp, line 120 https://reviews.apache.org/r/17306/diff/1/?file=447773#file447773line120 should we check their exit codes since dup2 can fail even with valid descriptors. I've handled

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-27 Thread Ben Mahler
On Jan. 24, 2014, 8:12 p.m., Jie Yu wrote: 3rdparty/libprocess/include/process/subprocess.hpp, lines 163-165 https://reviews.apache.org/r/17306/diff/1/?file=447773#file447773line163 Instead of killing the subprocess when 'status' is discarded, what about having an explicit

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-27 Thread Ben Mahler
On Jan. 27, 2014, 7:53 a.m., Ian Downes wrote: What about supporting environment variables specific to the child process? This is necessary for distinct environments between different subprocesses and the parent. This could be done by prepending the command with 'env' but it'll be

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-27 Thread Ben Mahler
On Jan. 24, 2014, 10:39 p.m., Ian Downes wrote: 3rdparty/libprocess/include/process/subprocess.hpp, line 133 https://reviews.apache.org/r/17306/diff/1/?file=447773#file447773line133 I don't think strlen() is async-signal-safe. I'd like to use it for convenience, my rationale is

Re: Review Request 17306: Added an asynchronous subprocess utility.

2014-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/ --- (Updated Jan. 27, 2014, 10:42 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Benjamin Hindman
On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote: src/launcher/executor.cpp, line 298 https://reviews.apache.org/r/17305/diff/1/?file=447761#file447761line298 I think it makes sense to have a global reaper just like we do with statistics. Having multiple libprocess processes

[jira] [Updated] (MESOS-496) Refactor the MasterDetector (with 'bool contend' option) into new MasterDetector and MasterContender.

2014-01-27 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-496: - Fix Version/s: 0.16.0 Refactor the MasterDetector (with 'bool contend' option) into new MasterDetector

[jira] [Updated] (MESOS-496) Refactor the MasterDetector (with 'bool contend' option) into new MasterDetector and MasterContender.

2014-01-27 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-496: - Issue Type: Story (was: Improvement) Refactor the MasterDetector (with 'bool contend' option) into new

Re: Review Request 17427: Handled EINTR in os::close.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17427/#review32908 --- Ship it! Ship It! - Benjamin Hindman On Jan. 27, 2014, 10:16

Re: Review Request 17304: Added a child Reaper utility in libprocess.

2014-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/ --- (Updated Jan. 27, 2014, 11:25 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/ --- (Updated Jan. 27, 2014, 11:25 p.m.) Review request for mesos, Benjamin Hindman

[jira] [Commented] (MESOS-930) Provide slave-executor protocol

2014-01-27 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883520#comment-13883520 ] Benjamin Mahler commented on MESOS-930: --- I think we should step back a bit and think

Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- Review request for mesos. Repository: mesos-git Description --- Enabled

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 27, 2014, 11:47 p.m.) Review request for mesos. Repository:

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 27, 2014, 11:50 p.m.) Review request for mesos. Repository:

Re: Review Request 17427: Handled EINTR in os::close.

2014-01-27 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17427/#review32914 --- According to Linus the file descriptor has been closed even if

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 27, 2014, 11:55 p.m.) Review request for mesos and Ross Allen.

Re: Review Request 17427: Handled EINTR in os::close.

2014-01-27 Thread Ian Downes
On Jan. 27, 2014, 11:54 p.m., Ian Downes wrote: According to Linus the file descriptor has been closed even if EINTR is returned and it should not be closed again. Later in the thread he explicitly says that the glibc macro is incorrect.

Re: Review Request 17427: Handled EINTR in os::close.

2014-01-27 Thread Ben Mahler
On Jan. 27, 2014, 11:54 p.m., Ian Downes wrote: According to Linus the file descriptor has been closed even if EINTR is returned and it should not be closed again. Later in the thread he explicitly says that the glibc macro is incorrect.

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32919 --- src/webui/master/static/config.html

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32921 --- src/webui/master/static/config.html

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32922 --- src/webui/master/static/index.html

[jira] [Created] (MESOS-951) Build failure: in log/catchup.cpp on Clang

2014-01-27 Thread Bernd Mathiske (JIRA)
Bernd Mathiske created MESOS-951: Summary: Build failure: in log/catchup.cpp on Clang Key: MESOS-951 URL: https://issues.apache.org/jira/browse/MESOS-951 Project: Mesos Issue Type: Bug

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32924 --- src/webui/master/static/config.html

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 12:34 a.m.) Review request for mesos and Ross Allen.

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32925 --- src/webui/master/static/js/app.js

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32927 --- Screenshots? :) If we were to have a way to spin up the webui

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 12:52 a.m.) Review request for mesos and Ross Allen.

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 12:53 a.m.) Review request for mesos and Ross Allen.

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
On Jan. 28, 2014, 12:45 a.m., Ben Mahler wrote: Screenshots? :) If we were to have a way to spin up the webui standalone, perhaps that's the only time we would want to expose this? I suspect that you're right. The impetus for the feature is having the UI be standalone at least. In

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Ben Mahler
On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote: src/launcher/executor.cpp, line 298 https://reviews.apache.org/r/17305/diff/1/?file=447761#file447761line298 I think it makes sense to have a global reaper just like we do with statistics. Having multiple libprocess processes

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
On Jan. 28, 2014, 12:45 a.m., Ben Mahler wrote: Screenshots? :) If we were to have a way to spin up the webui standalone, perhaps that's the only time we would want to expose this? Thomas Rampelberg wrote: I suspect that you're right. The impetus for the feature is having the

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32931 --- src/webui/master/static/index.html

Review Request 17435: Changed catchup.cpp to make it compilable with clang and C++11.

2014-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17435/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32932 --- src/webui/master/static/js/controllers.js

Re: Review Request 17435: Changed catchup.cpp to make it compilable with clang and C++11.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17435/#review32933 --- Ship it! Ship It! - Benjamin Hindman On Jan. 28, 2014, 1:14

Re: Review Request 17435: Changed catchup.cpp to make it compilable with clang and C++11.

2014-01-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17435/ --- (Updated Jan. 28, 2014, 1:16 a.m.) Review request for mesos and Benjamin

[jira] [Commented] (MESOS-951) Build failure: in log/catchup.cpp on Clang

2014-01-27 Thread Benjamin Hindman (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883609#comment-13883609 ] Benjamin Hindman commented on MESOS-951: Thanks for reporting Bernd! Build

[jira] [Resolved] (MESOS-951) Build failure: in log/catchup.cpp on Clang

2014-01-27 Thread Benjamin Hindman (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Hindman resolved MESOS-951. Resolution: Fixed Fix Version/s: 0.17.0 Assignee: Jie Yu

[jira] [Resolved] (MESOS-948) Docs for Java interfaces

2014-01-27 Thread Connor Doyle (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Connor Doyle resolved MESOS-948. Resolution: Duplicate Docs for Java interfaces Key:

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 1:44 a.m.) Review request for mesos and Ross Allen.

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Ross Allen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32935 --- src/Makefile.am https://reviews.apache.org/r/17431/#comment61972

[jira] [Created] (MESOS-952) Clock::resume should adjust timeouts that were created in a paused/advanced Clock context.

2014-01-27 Thread Benjamin Mahler (JIRA)
Benjamin Mahler created MESOS-952: - Summary: Clock::resume should adjust timeouts that were created in a paused/advanced Clock context. Key: MESOS-952 URL: https://issues.apache.org/jira/browse/MESOS-952

Re: Review Request 16432: Containerizer - cgroup isolators (part 4)

2014-01-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16432/#review32889 --- Ship it! Looks good, just some minor nits.

Re: Review Request 17431: Enabled configuration of the mesos master from the UI.

2014-01-27 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 1:48 a.m.) Review request for mesos and Ross Allen.

Review Request 17440: Removed an unnecessary intermediate ZooKeeper event handler (WatcherProcess) which has a bug in ensuring the lifecycles of WatcherProcess and Watcher match each other thus causin

2014-01-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17440/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs:

[jira] [Comment Edited] (MESOS-937) Fix pure virtual method called bug in zookeeper::ProcessWatcher

2014-01-27 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13880178#comment-13880178 ] Yan Xu edited comment on MESOS-937 at 1/28/14 1:59 AM: ---

Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, David Robinson, and

[jira] [Assigned] (MESOS-772) expose count of running tasks

2014-01-27 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone reassigned MESOS-772: Assignee: Vinod Kone https://reviews.apache.org/r/17442/ expose count of running tasks

Re: Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/#review32942 --- Ship it! Looks great! Thanks src/master/http.cpp

Re: Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/ --- (Updated Jan. 28, 2014, 2:59 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 17443: Added queued and launched tasks to slave stats.

2014-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17443/ --- Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, David Robinson,

Re: Review Request 17443: Added queued and launched tasks to slave stats.

2014-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17443/ --- (Updated Jan. 28, 2014, 3:02 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 17443: Added queued and launched tasks to slave stats.

2014-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17443/ --- (Updated Jan. 28, 2014, 3:02 a.m.) Review request for mesos, Adam B, Benjamin

[jira] [Comment Edited] (MESOS-772) expose count of running tasks

2014-01-27 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883664#comment-13883664 ] Vinod Kone edited comment on MESOS-772 at 1/28/14 3:02 AM: ---

Review Request 17445: Added LLDB convenience scripts.

2014-01-27 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17445/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs:

[jira] [Commented] (MESOS-950) Add LLDB helpers

2014-01-27 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883713#comment-13883713 ] Niklas Quarfot Nielsen commented on MESOS-950: -- Added in

Re: Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/#review32952 --- Ship it! I hope the past vs present tense will be enough to not

Re: Review Request 16724: Added completed frameworks/tasks to slave re-registration.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review32949 --- Ship it! src/master/master.cpp

Re: Review Request 17445: Added LLDB convenience scripts.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17445/#review32954 --- Ship it! Ship It! - Benjamin Hindman On Jan. 28, 2014, 3:41

Re: Review Request 17440: Removed an unnecessary intermediate ZooKeeper event handler (WatcherProcess) which has a bug in ensuring the lifecycles of WatcherProcess and Watcher match each other thus ca

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17440/#review32956 --- src/state/zookeeper.cpp

Re: Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/#review32962 --- Ship it! src/master/http.cpp

Re: Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread David Robinson
On Jan. 28, 2014, 4:55 a.m., Ben Mahler wrote: I hope the past vs present tense will be enough to not make the monotonic vs instantaneous stats confusing for those consuming this data. I'd find it confusing. active_tasks_gauge is preferrable. - David

Re: Review Request 17443: Added queued and launched tasks to slave stats.

2014-01-27 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17443/#review32964 --- Ship it! src/slave/http.cpp

Re: Review Request 16724: Added completed frameworks/tasks to slave re-registration.

2014-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review32961 --- Can we add a test for this please? src/master/master.cpp

Re: Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread Vinod Kone
On Jan. 28, 2014, 6:31 a.m., David Robinson wrote: src/master/http.cpp, line 349 https://reviews.apache.org/r/17442/diff/2/?file=452628#file452628line349 s/launched_tasks/launched_tasks_gauge/ ? (or active_tasks_gauge, please yourself) All the other *_tasks are

Re: Review Request 17442: Added 'active_tasks' stat to master stats endpoint.

2014-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/ --- (Updated Jan. 28, 2014, 6:57 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17443: Added queued and launched tasks to slave stats.

2014-01-27 Thread Vinod Kone
On Jan. 28, 2014, 5:08 a.m., Benjamin Hindman wrote: src/slave/http.cpp, line 309 https://reviews.apache.org/r/17443/diff/1/?file=452630#file452630line309 Any reason not to use 'active_tasks' here instead of 'launched_tasks' too? I went back and forth on the naming. This is my