---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/
---
(Updated April 3, 2015, 6:29 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32820/
---
Review request for mesos, Ben Mahler and Ian Downes.
Repository: mesos
On March 30, 2015, 3:28 a.m., Adam B wrote:
src/hook/manager.cpp, line 130
https://reviews.apache.org/r/30962/diff/5/?file=894741#file894741line130
And if (result.isNone()), is that really supposed to mean that this
hook didn't want to modify the env, so the HookManager can leave
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/#review78816
---
Bad patch!
Reviews applied: [32654]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32805/
---
(Updated April 3, 2015, 5:11 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32805/#review78801
---
Ship it!
src/linux/perf.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32805/#review78809
---
Patch looks great!
Reviews applied: [32820, 32805]
All tests
On April 3, 2015, 3:46 p.m., Benjamin Hindman wrote:
src/slave/containerizer/docker.cpp, line 1230
https://reviews.apache.org/r/32797/diff/1/?file=914221#file914221line1230
Why kill the executor before doing Docker::stop? Can you comment here
why you do it in this order versus
On April 3, 2015, 3:38 p.m., Benjamin Hindman wrote:
src/tests/docker_containerizer_tests.cpp, lines 2625-2627
https://reviews.apache.org/r/32798/diff/1/?file=914222#file914222line2625
My only question here is how do you know the executor is properly
killed and cleaned up? Is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/#review78825
---
Patch looks great!
Reviews applied: [32654]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32832/#review78831
---
Ship it!
Ship It!
- Timothy Chen
On April 3, 2015, 8:43 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32820/#review78832
---
Ship it!
Ship It!
- Ian Downes
On April 3, 2015, 10:01 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32832/
---
(Updated April 3, 2015, 3:30 p.m.)
Review request for mesos, Ben Mahler and
Hi everyone,
I think we have everything for the point release now:
https://docs.google.com/a/mesosphere.io/spreadsheets/d/1OzAWNjAL4zKtI-jOJqaQUcDNlnrNik2Dd7dHhwFLKcI/edit#gid=0
We planned on making an RC today. So with that in mind, if you have any
urgent issues that needs to go into 0.22.1,
On April 3, 2015, 8:34 p.m., Ben Mahler wrote:
src/linux/perf.cpp, lines 46-51
https://reviews.apache.org/r/32820/diff/1/?file=914812#file914812line46
char[]
Also noticed many of our other constants are not static, we may want
to do a sweep?
Done. I'll do the sweep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/
---
(Updated April 3, 2015, 10:36 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32833/#review78836
---
Ship it!
Ship It!
- Vinod Kone
On April 3, 2015, 9:28 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/
---
(Updated April 3, 2015, 9:55 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32805/
---
(Updated April 3, 2015, 9:29 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32805/
---
(Updated April 3, 2015, 9:29 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32820/#review78829
---
Ship it!
Feel free to split out the proces namespace change.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32832/
---
Review request for mesos, Ben Mahler and Timothy Chen.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---
(Updated April 3, 2015, 9:58 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---
(Updated April 3, 2015, 10:36 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/
---
(Updated April 3, 2015, 7:19 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32832/#review78835
---
Patch looks great!
Reviews applied: [32832]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32833/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32834/
---
Review request for mesos, Adam B, Cody Maloney, and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---
(Updated April 3, 2015, 10:17 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32507/
---
(Updated April 3, 2015, 11:47 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32844/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-1127
On March 31, 2015, 11:38 p.m., Ben Mahler wrote:
Can we punt on version for the initial HTTP API beta release? I say this
because:
(1) The protobuf objects seems like the wrong place to place a version. If
a backwards-incompatible change occurs, we may not be able to parse the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32834/#review78846
---
Patch looks great!
Reviews applied: [32834]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32843/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-1127
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/#review78852
---
src/slave/containerizer/isolators/network/port_mapping.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/
---
(Updated April 3, 2015, 11:42 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32832/#review78851
---
Ship it!
Ship It!
- Adam B
On April 3, 2015, 3:58 p.m., Niklas
On March 31, 2015, 10:51 p.m., Ben Mahler wrote:
Instead of having a separate /scheduler/events endpoint with a top level
Subscribe protobuf, could we just have one /scheduler/call endpoint and
have a SUBSCRIBE Call?
I prefer this because:
(1) There is a single endpoint / Call
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---
(Updated April 4, 2015, 12:39 a.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32505/
---
(Updated April 3, 2015, 11:38 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32509/
---
(Updated April 3, 2015, 11:55 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32845/#review78869
---
Patch looks great!
Reviews applied: [32500, 32501, 32502, 32504,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review78876
---
Patch looks great!
Reviews applied: [32850]
All tests passed.
-
On April 1, 2015, 12:20 a.m., Ben Mahler wrote:
Modulo comments.
I noticed you added SlaveID on Shutdown, can you add it to Kill as well?
Yup. Will send a patch for it as well.
On April 1, 2015, 12:20 a.m., Ben Mahler wrote:
include/mesos/scheduler/scheduler.proto, line 127
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32509/#review78874
---
Patch looks great!
Reviews applied: [32500, 32501, 32502, 32504,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
---
Review request for mesos, Joris Van Remoortere and switched to 'mcypark'.
Based on input from Vinod and Adam; I will reduce the scope on the point
release to focus on MESOS-1795 and MESOS-2583.
I will move the other tickets back to 0.23.0 if you don't have any
objections - let me know if you have any tickets which were regressions in
0.22.0.
Also, this will probably
On March 31, 2015, 9:49 p.m., Ben Mahler wrote:
There is another nice aspect of requiring SlaveID in Reconcile and in Kill,
we can make SlaveID in TaskStatus required. Are you planning to add a TODO
for that? Will we be ever be able to make it required?
Added a TODO. The only way we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32502/
---
(Updated April 3, 2015, 11:36 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/#review78861
---
src/slave/containerizer/mesos/containerizer.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32845/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-1127
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32832/#review78854
---
Patch looks great!
Reviews applied: [32832]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32583/
---
(Updated April 3, 2015, 10:05 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32796/#review78780
---
Ship it!
Ship It!
- Benjamin Hindman
On April 2, 2015, 11:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32797/#review78781
---
Ship it!
Ship It!
- Benjamin Hindman
On April 2, 2015, 11:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32798/#review78783
---
Ship it!
src/tests/docker_containerizer_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32797/#review78785
---
Ship it!
I had another thought after my first review, see below
57 matches
Mail list logo
