March 15th, 2018 Mesos Developer Meeting

We'll have a developer meeting this Thursday at 3 PM PT. You'll find the agenda here: https://docs.google.com/document/d/ 153CUCj5LOJCFAVpdDZC7COJDwKh9RDjxaTA0S7lzwDA/edit If folks have anything they'd like to add to the agenda please add it and ping Jie (cc'ed) who will run this week's meeting.

MesosCon 2018

Fellow Mesos Community Members, Many of you have probably seen the announcement for Mesosphere Advance, a conference co-located at CloudNativeCon. Given the deep involvement that Mesosphere has had with past MesosCons, this has left many of you asking us if Mesosphere Advance replaces MesosCon. N

Reminder: Share your thoughts in our Apache Mesos Survey

We're close to shipping the next Mesos release (1.5.0) and after a great set of MesosCons in Beijing, LA, and Prague in 2017 we're also starting to think about 2018 conferences. It's exciting! One of the ways we help improve the project is with input from folks in our user and developer communiti

2018/01/18 Mesos Developer Meeting

We'll have a developer meeting tomorrow at 3 PM PT. You'll find the agenda here: https://docs.google.com/document/d/153CUCj5LOJCFAVpdDZC7COJDwKh9RDjxaTA0S7lzwDA/edit Some highlights from the agenda are discussions about 1.5.0 features and some recent performance improvements! You can join the mee

Re: ClangTidy for Mesos is here!

MPark, this is so awesome to see; everyone in the community is indebted to you for continuing to push on this! Thank you!!! On Sat, Nov 4, 2017 at 3:18 PM Michael Park wrote: > We've had ClangTidy for Mesos, called MesosTidy for a while checked > into the codebase, but we hadn't actually enable

Re: organizing a "docathon"

Please see this doc <https://docs.google.com/document/d/1-biNAKITW5mFpYlAE0gH-ycReTHVOv7pak_NTNL17x4/edit> for more details as well as ideas for documentation. Please add more yourself! On Wed, Oct 4, 2017 at 6:19 PM Benjamin Hindman wrote: > We've decided on Thursday 10/12!

Re: organizing a "docathon"

We've decided on Thursday 10/12! If you're interested in joining us in person in San Francisco please reply just to me. Stay tuned for more details. Looking forward! On Mon, Oct 2, 2017 at 6:05 PM Benjamin Hindman wrote: > Pinging this thread just to remind folks to sign up, than

Re: organizing a "docathon"

Pinging this thread just to remind folks to sign up, thank you! On Mon, Sep 25, 2017 at 4:09 PM Benjamin Hindman wrote: > Some folks have expressed interest in an organized documentation > hackathon, aka "docathon". > > We'll make this something people can partici

organizing a "docathon"

Some folks have expressed interest in an organized documentation hackathon, aka "docathon". We'll make this something people can participate in remotely, but we'll also provide space (TBD, most likely at Mesosphere in San Francisco) for the first one of these for anyone that would like to join in

Re: Adding process::Executor::execute()

or std::function( > )>()().onAny(...) > > Would it make sense to add another `execute()` function to directly return > a `Future`? > > - Chun-Hung > > -- Benjamin Hindman Founder of Mesosphere and Co-Creator of Apache Mesos Mesosphere Inc. <http://www.mesosphere.io/> Follow us on Twitter: @mesosphere <http://twitter.com/mesosphere>  

08/31 community meeting agenda

Please see the doc for an up to date agenda and Hangouts links. tl;dr; In addition to going over the community kanban board we'll also discuss some upcoming changes and proposals around li

Re: C++14 Upgrade

+1 We care about RHEL 6 / 7, anyone out there that has used a GCC 5 on these can help MPark out? On Thu, Jul 20, 2017 at 5:23 PM Michael Park wrote: > I've added Fedora 23 and OS X Sierra to the spreadsheet. > I've also successfully compiled and ran `make check` with the following > distros: >

Apache Mesos Survey

Share your thoughts in our Apache Mesos Survey Apache Mesos has seen tremendous growth since its introduction in 2009, and has been running in production at some of the largest Internet companies like Twitter, Netflix, and NASA JPL for many years now. Mesosphere is running a short survey to under

Re: [VOTE] Release Apache Mesos 1.0.0 (rc4)

I agree with Vinod that we should go with option 1. I think redirect is a valuable feature but it's not imperative for the operation of the cluster. On Tue, Jul 26, 2016 at 5:39 PM, Vinod Kone wrote: > We've the ASF press wire and other community blog posts lined up to be > posted tomorrow, so i

New Stack Survey

The New Stack is doing research into what container orchestration entails and what systems are used for container orchestration, and we want the Mesos community properly represented. Please represent the Mesos community and fill out their survey . Th

Re: Precision of scalar resources

SGTM, thanks Neil! On Fri, Feb 12, 2016 at 2:25 PM, Neil Conway wrote: > tl;dr: > > If you use resource values with more than three decimal digits of > precision (e.g., you are launching a task that uses 2.5001 CPUs), > please speak up! > > > > Mesos uses floating point to represent scalar

Re: `F()` vs `F(void)`

+1! On Sun, Dec 13, 2015 at 10:46 AM, Michael Park wrote: > Hello, > > In the C++ world, the *void* parameter is considered to be only there for C > compatibility reasons. > > We do a good job of not using *void *parameters in function declarations, > e.g., *void F();*. On the other hand, we're

Re: Mesos Developer Community Design Discussions

in > attendance. > > Best, > Dave > > On Mon, Aug 10, 2015, at 02:52 PM, Benjamin Hindman wrote: > > We've had great developer community meetings over Google Hangouts, but > > MesosCon is right around the corner and we'd like to do it in person! > >

Mesos Developer Community Design Discussions

We've had great developer community meetings over Google Hangouts, but MesosCon is right around the corner and we'd like to do it in person! I'd like to invite everyone to attend an in person developer community meeting on Tuesday, August 18th in Seattle. The focus will be for Mesos committers and

Re: [VOTE] Release Apache Mesos 0.23.0 (rc4)

+1 (binding) On Ubuntu 14.04: $ make check ... all tests pass ... $ sudo make check ... tests with known issues fail, but ignoring because these have all been resolved and are issues with the tests alone ... Thanks Adam. On Fri, Jul 17, 2015 at 4:42 PM Adam Bordelon wrote: > Hello Mesos commu

Re: Doxygen / Javadoc changes

We're only using non-javadoc comments for APIs, which are mostly in headers. We're still using // based C++ comments in implementations and places we don't want to be picked up via doxygen. On Thu, Jul 9, 2015 at 5:23 PM Benjamin Mahler wrote: > A couple of thoughts: > > (1) When introducing jav

Re: synchronized

One more thing I'd like to point out here that MPark neglected because he's too humble: *the latest implementation of the synchronized macro enables us to use a return statement within the block without having to add the 'UNREACHABLE();' statement after the block!* I haven't seen it done in other

Re: Mesos Jira workflow

+1 This sounds great to me Marco. I love eliminating Reopened, as well as simplifying (constraining) other transitions. I couple of quick questions: Why does stoping progress go from In Progress back to Open instead of Accepted? Seems like it's still an Accepted issue just not being worked on. Ca

Re: soliciting shepherds for auto tools changes

you thank you thank you for reaching out for a shepherd too! On Thu, Jun 4, 2015 at 7:00 AM Benjamin Hindman wrote: > I just took a look and shipped the reviews associated with MESOS-2659. > I'll take a look at MESOS-2666 next. Thanks for the contributions James! > > > On T

Re: soliciting shepherds for auto tools changes

I just took a look and shipped the reviews associated with MESOS-2659. I'll take a look at MESOS-2666 next. Thanks for the contributions James! On Thu, Jun 4, 2015 at 5:54 AM Jake Farrell wrote: > I can only help review, not a Mesos committer > > -Jake > > > > On Wed, Jun 3, 2015 at 11:47 PM, J

Re: [Style Proposal] Mesos Header Include Order: Follow Google Style Guide completely

And yes, in this case, unlike the s/> >/>>/ let's go ahead and do a global cleanup. On Sat, May 2, 2015 at 5:19 PM, Benjamin Hindman wrote: > I'm a definite +1 on this too! > > On Fri, May 1, 2015 at 2:13 PM, Benjamin Mahler > wrote: > >> I'm a

Re: [Style Proposal] Mesos Header Include Order: Follow Google Style Guide completely

xamples for this are outlined in the Jira here: >> https://issues.apache.org/jira/browse/MESOS-2673 >> >> Please feel free to comment here on the dev-list, but also consider to >> comment on the Review Request directly! >> >> Thanks for your feedback, >> Jö

C++11 lambdas have landed!

Please check out the style guide, and start using them! As we run into any issues let's get the style guide updated please! Long time coming!

Re: [2/2] mesos git commit: Warn if g++ < 4.8 or a C++ standard library is too old for Mesos.

That would be great James! We took an MVP approach for now, but it would be great if we could give even better error messages or warning messages for compilers that we don't regularly test or work with. On Sun, Apr 26, 2015 at 11:51 AM, James Peach wrote: > On Apr 25, 2015, at 4:24 PM, b...@apac

builds now require gcc 4.8+ or clang 3.5+

I'm happy to announce that we've committed the updates to configure.ac that require gcc 4.8+ and clang 3.5+! See this thread for the discussion. Stay tuned fo

JIRA backlog grooming

Folks, We're trying to do some backlog grooming in JIRA! You can all help us: *Do you have an issue that is assigned to you but still in the 'Open' state?* Please either (1) unassign this ticket or (2) move this issue into 'Accepted' or better 'In Progress' if you're actually working on this issu

Re: Review Request 33318: Fix docker containerizer usage and test.

lf). In the mean time, we should have a better comment and even: if (task.isSome()) { CHECK(executor.resources() >= task.get().resources()); } - Benjamin Hindman On April 17, 2015, 6:21 p.m., Timothy Chen wrote: > > ---

Re: Review Request 32961: Allow framework re-registeration to update master http fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32961/#review80214 --- Ship it! Ship It! - Benjamin Hindman On April 14, 2015, 4:30

Re: Suggestion: Mesos 0.22.1 point release

Tue, Apr 14, 2015 at 9:55 PM, Benjamin Hindman > wrote: > > > We are going to include MESOS-2614 (it's a really trivial fix). > > > > Jie, where did you get MESOS-2601 from? That's definitely not in the > > spreadsheet. > > > > On Tue, Apr

Re: Suggestion: Mesos 0.22.1 point release

We are going to include MESOS-2614 (it's a really trivial fix). Jie, where did you get MESOS-2601 from? That's definitely not in the spreadsheet. On Tue, Apr 14, 2015 at 7:40 PM, Jie Yu wrote: > Also, this one: > https://issues.apache.org/jira/browse/MESOS-2601 > > This sounds like a non trivia

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

--- > > (Updated April 7, 2015, 12:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Bugs: MESOS-2592 > https://issues.apache.org/jira/browse/MESOS-2592 > > > Repository: mesos > > >

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

pache.org/r/32911/#comment128224> Why don't you need to check the taskInfo? Is it because we should have set the executorInfo's 'user' appropriately? If so, let's comment as much, even going as far

Re: Review Request 32797: Kill the executor when docker container is destroyed.

please! src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/32797/#comment127813> Why kill the executor before doing Docker::stop? Can you comment here why you do it in this order versus the other order and the ramifications that has? - Benjamin Hindman On April 2, 2015,

Re: Review Request 32798: Add test to verify executor clean up in docker containerizer.

.empty() or something like that? - Benjamin Hindman On April 2, 2015, 11:38 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 32797: Kill the executor when docker container is destroyed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32797/#review78781 --- Ship it! Ship It! - Benjamin Hindman On April 2, 2015, 11:38

Re: Review Request 32796: Only update docker container when resources differs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32796/#review78780 --- Ship it! Ship It! - Benjamin Hindman On April 2, 2015, 11:37

Re: Suggestion: Mesos 0.22.1 point release

Obviously a +1, this is a stability fix we should get to our users as soon as possible. On Mon, Mar 30, 2015 at 9:01 PM, Niklas Nielsen wrote: > Hi all, > > Joris and Ben H recently located and fixed a resident bug in the state > abstraction which caused many crashes in the JVM (mostly in conjun

Re: Review Request 32151: Add MESOS_{MAJOR|MINOR|PATCH}_VERSION to libmesos.

ated/org/apache/mesos/MesosNativeLibrary.java.in <https://reviews.apache.org/r/32151/#comment126491> Let's make this a RuntimeException instead. Why? This provides similar semantics to if we attempted to call a native method and haven't first called MesosNativeLibrary.load().

Re: Review Request 32152: Fix memory corruption in AbstractState JNI bindings. MESOS-2161.

ment126520> Can kill the 'try' once we change MesosNativeLibrary.LibraryNotLoadedException to RuntimeException. Here and below. - Benjamin Hindman On March 27, 2015, 12:02 a.m., Joris Van Remoortere wrote: > > --

Re: Review Request 32550: Add major, minor, and patch accessors to stout's Version.

/version.hpp <https://reviews.apache.org/r/32550/#comment126483> These are const, let's just expose them as fields (without the _), like we do for os::Release. - Benjamin Hindman On March 27, 2015, 12:01 a.m., Joris Van Remoo

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

turn string(buffer); (3) return Result(buffer); (4) return Result(string(buffer)); And please add TODOs in result.hpp if (1) does not compile! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/30032/#comment126244> Result time = Path(response.path).mtim

Re: Review Request 26147: Remove non-variadic strings::format() implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review77910 --- Ship it! Ship It! - Benjamin Hindman On March 25, 2015, 8:02

Re: Review Request 31930: Introduced an http::Pipe abstraction to simplify streaming HTTP Responses.

3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/31930/#comment123819> Let's still keep this as /pipe for now! ;-) Here and below in this test. - Benjamin Hindman On March 11, 2015, 7:41 a.m., Ben Mahler wrote: > > -

Re: Review Request 31992: Added a TODO for readability reviews.

ed e-mail. To reply, visit: https://reviews.apache.org/r/31992/#review76271 ------- On March 12, 2015, 3:59 p.m., Benjamin Hindman wrote: > > --- > This is an a

Re: Review Request 31993: Corrected constant naming rule in the style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31993/#review76253 --- Ship it! Ship It! - Benjamin Hindman On March 12, 2015, 4:11

Review Request 31992: Added a TODO for readability reviews.

Description --- See summary. Diffs - readability/TODO PRE-CREATION Diff: https://reviews.apache.org/r/31992/diff/ Testing --- N/A Thanks, Benjamin Hindman

Review Request 31990: Added initial readability code review/comments.

e. Diffs - readability/naming_comments.cpp PRE-CREATION readability/naming_review.cpp PRE-CREATION Diff: https://reviews.apache.org/r/31990/diff/ Testing --- None yet, Bernd is going to handle this for me! Thanks Bernd. ;-) Thanks, Benjamin Hindman

Re: Review Request 30774: Fetcher Cache

hould do recovery on the fetcher itself: Try recover = fetcher->recover(flags, slaveId); It seems very weird to have a static generic Fetcher recover functionality that implies that we can't have multiple Fetcher

Review Request 31614: Added a comment about uses of FetcherProcess::cache withotu 'defer'.

slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 Diff: https://reviews.apache.org/r/31614/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31613: Added a comment to help suss out potential bug.

. Diffs - src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 Diff: https://reviews.apache.org/r/31613/diff/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 31613: Added a comment to help suss out potential bug.

. Repository: mesos Description --- See summary. Diffs - src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 Diff: https://reviews.apache.org/r/31613/diff/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 31612: Release a failed cache entry's space properly.

://reviews.apache.org/r/31612/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31612: Release a failed cache entry's space properly.

check Thanks, Benjamin Hindman

Review Request 31610: Simplified 'cleanupCache' by adjusting cache sizes earlier.

reviews.apache.org/r/31610/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31611: Store the cache directory within each Cache::Entry.

://reviews.apache.org/r/31611/diff/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 31609: Simplifying FetcherProcess::cleanupCache.

--- make check Thanks, Benjamin Hindman

Re: Review Request 31603: Cleaned up a few style issues.

. Repository: mesos Description --- See summary. Diffs - src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 Diff: https://reviews.apache.org/r/31603/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31609: Simplifying FetcherProcess::cleanupCache.

--- See summary. Diffs - src/slave/containerizer/fetcher.hpp 1db0eaf002c8d0eaf4e0391858e61e0912b35829 src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 Diff: https://reviews.apache.org/r/31609/diff/ Testing --- make check Thanks, Benjamin

Review Request 31603: Cleaned up a few style issues.

--- See summary. Diffs - src/slave/containerizer/fetcher.cpp 9e9e9d0eb6b0801d53dec3baea32a4cd4acdd5e2 Diff: https://reviews.apache.org/r/31603/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31602: Changes necessary for building with gcc 4.4.

/ Testing --- make check Thanks, Benjamin Hindman

Re: Scaling Proposal: MAINTAINERS Files

I had chatted with BenM and Vinod pretty extensively about this and am a +1. BenM: can you confirm how this interacts with the Apache by-laws? On Sat, Feb 14, 2015 at 10:25 AM, Till Toenshoff wrote: > +1 — thanks for this Ben! > > > On Feb 10, 2015, at 8:56 PM, Cody Maloney wrote: > > > > +1 >

Re: Review Request 31236: Re-introduce "internal" namespace for src/*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31236/#review73509 --- Ship it! Ship It! - Benjamin Hindman On Feb. 22, 2015, 9:39 p.m

Re: Review Request 31279: Enclosed tests in "mesos::internal::tests" namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31279/#review73510 --- Ship it! Ship It! - Benjamin Hindman On Feb. 22, 2015, 9:39 p.m

Re: Review Request 31288: Fixed bug in tests from 'internal' revert.

Niklas Nielsen. Repository: mesos Description --- I'm not sure how the tests were ever passing? Diffs - src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96 Diff: https://reviews.apache.org/r/31288/diff/ Testing --- make check Thanks, Ben

Re: Review Request 31287: Removed unnecessary 'mesos::' qualifier.

Niklas Nielsen. Repository: mesos Description --- See summary. Diffs - src/module/manager.hpp f071678aca0729c14147b16f00a6f1e0daf9094e Diff: https://reviews.apache.org/r/31287/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31288: Fixed bug in tests from 'internal' revert.

Description --- I'm not sure how the tests were ever passing? Diffs - src/tests/rate_limiting_tests.cpp 784ac76ee81918466de44196f5adc2b88adfee96 Diff: https://reviews.apache.org/r/31288/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31287: Removed unnecessary 'mesos::' qualifier.

Description --- See summary. Diffs - src/module/manager.hpp f071678aca0729c14147b16f00a6f1e0daf9094e Diff: https://reviews.apache.org/r/31287/diff/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 31286: Removed all 'namespace slave {' and 'namespace master {' from tests.

src/tests/slave_recovery_tests.cpp 24c28af7ff0425920cb5c0bf430e21962de2b12d Diff: https://reviews.apache.org/r/31286/diff/ Testing --- make check Thanks, Benjamin Hindman

Review Request 31286: Removed all 'namespace slave {' and 'namespace master {' from tests.

24c28af7ff0425920cb5c0bf430e21962de2b12d Diff: https://reviews.apache.org/r/31286/diff/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 31236: Re-introduce "internal" namespace for src/*.

236/#comment119800> Was this in the code pre-30295 that way? - Benjamin Hindman On Feb. 22, 2015, 9:39 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 31218: MESOS-2377: Fix leak in libevent EventLoop::handle_delay.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31218/#review73254 --- Ship it! Did someone come across this bug? - Benjamin Hindman

Re: Review Request 30971: Introduced explicit status update acknowledgements on the driver.

reviews.apache.org/r/30971/#comment119524> Rather than 'abort()' we should use ABORT() << "message"; - Benjamin Hindman On Feb. 18, 2015, 11:43 p.m., Ben Mahler wrote: > > --- > This is an automa

Re: Review Request 31162: Backout change 30300 (Move internal protos from mesos::internal to mesos namespace)

> On Feb. 19, 2015, 2:28 a.m., Jie Yu wrote: > > src/tests/state_tests.cpp, lines 86-87 > > > > > > typedef Registry::Slaves Slaves; > > typedef Registry::Slave Slave; This reverts the code to it's original state w

Re: Review Request 31145: Fixed a CPU-intensive bug in libprocess' clock.

is okay, it should cause 'tick' to fire immediately. - Benjamin Hindman On Feb. 18, 2015, 3:12 a.m., Ben Mahler wrote: > > --- > This is an automatically

Re: Review Request 31141: Fixed a clock bug in next().

le that work on this code as possible. 3rdparty/libprocess/src/clock.cpp <https://reviews.apache.org/r/31141/#comment119009> Please add a comment just above this that explains we're passing NULL to be explicit about getting the global clock value, thanks

MesosCon 2015

bruary 14th, don't miss out! Looking forward to seeing you all in Seattle this August! Benjamin Hindman.

Re: Review Request 30884: Removed non-POD static function object in clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30884/#review71994 --- Ship it! Ship It! - Benjamin Hindman On Feb. 11, 2015, 6:40 p.m

Re: Review Request 30587: Additional logging in libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30587/#review71941 --- Ship it! Ship It! - Benjamin Hindman On Feb. 4, 2015, 12:06 a.m

Re: Review Request 30194: Parse file:// arguments in

> On Feb. 11, 2015, 7:16 a.m., Benjamin Hindman wrote: > > Took care of the minor issue and committed. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30194/#re

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

this committed. docs/upgrades.md <https://reviews.apache.org/r/30195/#comment117852> s/mesos/Mesos/ src/zookeeper/url.hpp <https://reviews.apache.org/r/30195/#comment117851> Newline between these two please. - Benjamin Hindman On Feb. 9, 2015, 12:43 a.m., C

Re: Review Request 30194: Parse file:// arguments in

/flags.hpp <https://reviews.apache.org/r/30194/#comment117850> Doesn't look like you needed to remove the 'const' from here. - Benjamin Hindman On Feb. 9, 2015, 12:43 a.m., Cody Maloney wrote: > > ---

Re: Review Request 30792: Additonal use case for "auto" in C++ style guide: shared pointer creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review71923 --- Ship it! I think this is a great use of auto! - Benjamin Hindman

Re: Review Request 30774: Fetcher Cache

sk takes 1 CPU (so maybe 2 tasks run in parallel but not all of them?). Why not be more explicit in the tests, even if it's more code, so that we're convinced we're testing the things we want to test? My guess is

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

. src/zookeeper/url.hpp <https://reviews.apache.org/r/30195/#comment117316> s/char */char* / And please move '{' to newline. - Benjamin Hindman On Feb. 7, 2015, 12:34 a.m., Cody Maloney wrote: > > ---

Re: Review Request 30588: etcd api wrapper

588/#comment117150> And this can be const & now! src/etcd/etcd.cpp <https://reviews.apache.org/r/30588/#comment117151> And this can be const & now! - Benjamin Hindman On Feb. 4, 2015, 12:10 a.m., Cody Maloney wrote: > > --

Re: Review Request 30588: etcd api wrapper

t take the first address and give it a default port if necessary. Address address = resolve.get().front(); address.port = address.port == 0 ? 4001; addresses.push_back(address); src/etcd/url.cpp <https://reviews.apache.org/r/30588/#comment117149> if (!strings::startsWi

Re: Review Request 30589: etcd master contender + detector

.cpp <https://reviews.apache.org/r/30589/#comment117130> No period implies incomplete comment ... looks pretty incomplete to me! ;-) src/master/detector.cpp <https://reviews.apache.org/r/30589/#comment117128> What is this line doing!? - Benjamin Hindman On Feb. 4, 2015, 1

Re: Review Request 30591: Specify replicated log machines to coordinate with at the command line

0 ? 5050 : port)); src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117104> Newline above and below this log line pleae! src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117105> s/.// - Benjamin Hindman On Feb. 4, 2015, 12:12 a.m., Cody Mal

Re: Review Request 30590: Add --etcd to match --zk.

> On Feb. 6, 2015, 4:01 a.m., Benjamin Hindman wrote: > > src/master/main.cpp, line 158 > > <https://reviews.apache.org/r/30590/diff/1/?file=846786#file846786line158> > > > > Why do we do determine this here? This should be determined down just >

Re: Review Request 30590: Add --etcd to match --zk.

ease do me a favor and add = None(); here and other places you come across that don't define a value for an Option, thanks! src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117078> = None(); - Benjamin Hindman On

Re: Review Request 30590: Add --etcd to match --zk.

main.cpp <https://reviews.apache.org/r/30590/#comment117070> Kill newline please. src/master/main.cpp <https://reviews.apache.org/r/30590/#comment117072> s/.// - Benjamin Hindman On Feb. 4, 2015, 12:11 a.m., Cody Maloney wrote: > > --

Re: Review Request 30036: Introduced caching fields to command URI and fetcher parameter protobufs

views.apache.org/r/30036/#comment116900> Lets explain why we aren't nesting this in the work directory, i.e., it's not an automatic flag: (1) it's probably not meant to be backed up (that's a lot of data to back up) and (2) you might want to put it on a different disk. - Benjami

Re: Review Request 30034: Unified fetcher testing, removed stderr/out redirection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30034/#review71227 --- Ship it! Ship It! - Benjamin Hindman On Jan. 20, 2015, 8:33 a.m

Re: Review Request 30033: Removed fetcher env tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30033/#review71225 --- Ship it! Ship It! - Benjamin Hindman On Jan. 19, 2015, 3:45 p.m

Re: Review Request 28697: Added ReservationType for dynamic reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/#review70706 --- Ship it! Ship It! - Benjamin Hindman On Jan. 29, 2015, 6:10 a.m

  1   2   3   4   5   6   7   8   9   10   >