Is this going to be combined with the logic to do the same thing in
https://github.com/apache/mesos/blob/master/support/verify_reviews.py which
is used for the Jenkins Mesos CI? They are doing about the same thing now
in "download a whole set of reviews in order". Be nice to just have one.
On
I would note for that though that a default configuration of Mesos allows
anyone at any time to launch a container with no isolation / no meaningful
isolation from the base machines, and run arbitrary commands inside that
container as root on the box. Locking other things down by default /
leaving
CentOS 5 and 6 don't come out of the box with a new enough version of GCC
to compile Mesos. Already they need to upgrade that to compile Mesos. I
don't see how adding another upgrade when they have to do GCC is overly
onerous / should require lots of compatibility hacks to make unnecessary.
On
On Thu, Jun 25, 2015 at 5:01 PM Paul Brett pbr...@twitter.com.invalid
wrote:
As Kapil has pointed out on MESOS-2927, all the library files should be
identified by '#include ...' and all the project files should use
'#include ...' - i don't know yet if we have been consistent about this.
They
I'm on vacation for the next two weeks starting tomorrow. I did do some
initial talking / review with James about the patches previously
(Specifically the ones that make --disable* work).
On Mon, May 18, 2015 at 10:52 AM, Vinod Kone vinodk...@apache.org wrote:
Tim and Cody. Do any of you have
On Fri, May 8, 2015 at 2:32 PM, Adam Bordelon a...@mesosphere.io wrote:
Colin, these /ec2 scripts haven't seen much love in a while, and we may
want to move them out of the main repo.
I'm not sure if it's worth keeping these up, but if you figure them out,
feel free to submit a patch.
The
Note that we will want to keep the library checks in addition. This should
ideally just update / replace all the Check for what compiler it is,
which we use when setting the various needed additional compiler flags
(-Wno-unused-local-typedef{s} primarily).
On Mon, Apr 27, 2015 at 9:37 AM, James
, Cody Maloney c...@mesosphere.io wrote:
It's not header only.
I think we actually need a general discussion around upgrading all the
libraries mesos depends upon (Using a plain up-stream boost, etc).
Note that some portions of stout already require callers to link against
specific
It's not header only.
I think we actually need a general discussion around upgrading all the
libraries mesos depends upon (Using a plain up-stream boost, etc).
Note that some portions of stout already require callers to link against
specific libraries for them to actually work, so I don't think
. Current status (as of April 21, 2015):
+1 (Binding)
--
Vinod Kone
Timothy Chen
Yan Xu
Brenden Matthews
+1 (Non-binding)
--
Cody Maloney
Joris Van Remoortere
Jeff Schroeder
Jörg Schad
Elizabeth Lingg
Alexander Rojas
Alex
Could you update the community page with the new lists?
http://mesos.apache.org/community/
On Mon, Apr 20, 2015 at 4:34 PM, Vinod Kone vinodk...@gmail.com wrote:
OK, we have got the following email lists setup (h/t Jake Farrell).
revi...@mesos.apache.org -- By wednesday (04/22) all emails
, Apr 16, 2015 at 2:48 PM, Cody Maloney (JIRA) j...@apache.org
wrote:
[
https://issues.apache.org/jira/browse/MESOS-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498789#comment-14498789
]
Cody Maloney commented on MESOS-2144
-
3rdparty/libprocess/3rdparty/libev-4.15.patch
2b94532634bf4fb69523cdfa26254de6c537d689
Diff: https://reviews.apache.org/r/32747/diff/
Testing
---
See last in series: #32749
Thanks,
Cody Maloney
patches.
`make check` on ArchLinux with GCC 4.9
../configure
`make distcheck` on CentOS 7 (GCC 4.8)
../configure
`make distcheck` with OS X (Clang 3.5). Verified no '-Wno-unused-local-typedef'.
Thanks,
Cody Maloney
2b94532634bf4fb69523cdfa26254de6c537d689
Diff: https://reviews.apache.org/r/32747/diff/
Testing
---
See last in series: #32749
Thanks,
Cody Maloney
/#review79954
---
On April 13, 2015, 9:01 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32749
the ROOT/Cgroups ones
which auto-disables tests known not to work inside of docker containers.
- Cody Maloney
On April 10, 2015, 9:31 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32939/#review79546
---
Ship it!
Ship It!
- Cody Maloney
On April 7, 2015, 9:48 p.m
3da71afad38ae41adefab979dbed2ae0b10a98ef
src/slave/flags.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/32558/diff/
Testing
---
make check on ArchLinux with GCC 4.9.2
make distcheck CentOS 7
Thanks,
Cody Maloney
As discussed in the last community meeting, we'd like to bump the minimum
required compiler version from GCC 4.4 to GCC 4.8.
The overall goals are to make Mesos development safer, faster, and reduce
the maintenance burden. Currently a lot of stout has different codepaths
for Pre-C++11 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32558/#review78703
---
On April 9, 2015, 6:27 p.m., Cody Maloney wrote
On March 27, 2015, 4:41 p.m., Timothy Chen wrote:
src/slave/flags.cpp, line 29
https://reviews.apache.org/r/32558/diff/3/?file=907340#file907340line29
How about keeping the same style with namespaces? Just to be consistent
with everywhere else in the code base.
Cody Maloney
to detect
this, but definitely not a blocker.
- Cody Maloney
On March 30, 2015, 5:47 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32630
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32558/#review78071
---
On March 27, 2015, 1:21 a.m., Cody Maloney wrote
There is a fairly comprehensive overview of what compilers do / don't do
for RVO + NRVO at:
http://www.byte-physics.de/index.php?eID=tx_nawsecuredlu=0g=0t=1427845187hash=d85e8402f1e5b835e3ff4f266a0a7256516ea57efile=fileadmin/user_upload/kundenbereich/copy-elision-revisited-v1.0.pdf
Move
On March 27, 2015, 4:41 p.m., Timothy Chen wrote:
src/slave/flags.cpp, line 29
https://reviews.apache.org/r/32558/diff/3/?file=907340#file907340line29
How about keeping the same style with namespaces? Just to be consistent
with everywhere else in the code base.
Cody Maloney
---
On March 27, 2015, 1:21 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32558
3da71afad38ae41adefab979dbed2ae0b10a98ef
src/slave/flags.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/32558/diff/
Testing
---
make check on ArchLinux with GCC 4.9.2
make distcheck CentOS 7
Thanks,
Cody Maloney
://reviews.apache.org/r/32558/diff/
Testing
---
make check on ArchLinux with GCC 4.9.2
make distcheck CentOS 7
Thanks,
Cody Maloney
3da71afad38ae41adefab979dbed2ae0b10a98ef
src/slave/flags.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/32558/diff/
Testing
---
make check on ArchLinux with GCC 4.9.2
make distcheck CentOS 7
Thanks,
Cody Maloney
-
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp
58ab7424c9645fd04d6aea2e4ff56c1ff9815953
Diff: https://reviews.apache.org/r/26147/diff/
Testing
---
Make distcheck ubuntu 14.04
Compiled with gcc 4.4
Thanks,
Cody Maloney
On March 24, 2015, 4:10 p.m., Alexander Rukletsov wrote:
src/master/http.cpp, line 470
https://reviews.apache.org/r/32419/diff/1/?file=903657#file903657line470
Are you sure the outer `object` is not shadowed? Even if it's not, let
us maybe leave the original naming to avoid name
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28254/#review77073
---
On Nov. 20, 2014, 12:54 a.m., Cody Maloney wrote
/libprocess/3rdparty/stout/include/stout/format.hpp
58ab7424c9645fd04d6aea2e4ff56c1ff9815953
Diff: https://reviews.apache.org/r/26147/diff/
Testing (updated)
---
Make distcheck ubuntu 14.04
Compiled with gcc 4.4
Thanks,
Cody Maloney
. | grep -v '$(LDADD)'` that all the program-specific LDADD
flags now include the global LDADD.
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76438
---
On March 13, 2015, 7:55 p.m., Cody Maloney wrote
On March 13, 2015, 9:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
Cody Maloney wrote:
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the
binaries of the tests
---
make check on Ubuntu 14.04 with `--with-glog`, `--with-protobuf` and
`--with-boost`.
As a sanity check that all isntances of _LDADD are updated, I ran the grep:
`grep -r _LDADD . | grep -v '$(LDADD)'` that all the program-specific LDADD
flags now include the global LDADD.
Thanks,
Cody
://reviews.apache.org/r/31997/diff/
Testing
---
`GLOG_v=1 make check` on ArchLinux, log messages don't show up for waiter (just
metrics).
Thanks,
Cody Maloney
---
On March 12, 2015, 6:34 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31997/
---
(Updated March 12, 2015, 6
of _LDADD are updated, I ran the grep:
`grep -r _LDADD . | grep -v '$(LDADD)'` that all the program-specific LDADD
flags now include the global LDADD.
Thanks,
Cody Maloney
/.
But everything more complex than `.reserve()` should be benchmarked, on
all official supported compilers if possible. I'll play with this when I have
some free cycles.
Cody Maloney wrote:
From writing my own JSON code, the std::move here is definitely necessary
to do this as quickly
On March 11, 2015, 9:38 p.m., Ben Mahler wrote:
src/master/http.cpp, line 471
https://reviews.apache.org/r/31700/diff/2/?file=888170#file888170line471
Do you know if a move is helpful here or if the compiler is already
optimizing this?
```
object.values[slaves]
/slave.cpp
https://reviews.apache.org/r/31539/#comment122700
Checkpointing of slaves is always enabled.
- Cody Maloney
On March 6, 2015, 2:22 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 2, 2015, 9:36 p.m., Timothy Chen wrote:
docs/mesos-developers-guide.md, line 58
https://reviews.apache.org/r/31638/diff/1/?file=882317#file882317line58
You can actually create a .reviewboardrc that contains your
credentials, then you don't need to login at all.
Then you
://reviews.apache.org/r/30587/#review72676
---
On Feb. 4, 2015, 12:06 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
+1
It would be nice if there was way to specify things like build system
changes which are different than just adding/removing a single file. But
probably that level of enforcement isn't worth the effort it would take to
add.
On Tue, Feb 10, 2015 at 8:56 AM, James DeFelice
/#comment117576
Since this will fail if the box fails to download the etcd binary (requires
network), we should automatically disable this test if the etcd binary doesn't
exist, similar to what we do for the ROOT_ tests
- Cody Maloney
On Feb. 4, 2015, 12:13 a.m., Cody Maloney wrote
Diff: https://reviews.apache.org/r/30194/diff/
Testing
---
make distcheck when #30195 has been applied
Thanks,
Cody Maloney
16e711c5c0bc29b1967a20f0827238f8a7b0deaf
Diff: https://reviews.apache.org/r/30195/diff/
Testing
---
make distcheck
- Tests not hitting the file:// handling which were replaced with CHECK()
statements.
Thanks,
Cody Maloney
16e711c5c0bc29b1967a20f0827238f8a7b0deaf
Diff: https://reviews.apache.org/r/30195/diff/
Testing (updated)
---
make distcheck
- Tests not hitting the file:// handling which were replaced with CHECK()
statements.
gcc 4.4 + gcc 4.8
Thanks,
Cody Maloney
()
statements.
Thanks,
Cody Maloney
/diff/
Testing
---
make distcheck when #30195 has been applied
Thanks,
Cody Maloney
2a1586e92e1765edba28b89240d4eb44ce67840f
src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf
Diff: https://reviews.apache.org/r/30195/diff/
Testing
---
make distcheck
- Tests not hitting the file:// handling which were replaced with CHECK()
statements.
gcc 4.4 + gcc 4.8
Thanks,
Cody
, visit:
https://reviews.apache.org/r/30195/#review71559
---
On Feb. 9, 2015, 12:43 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/flags_tests.cpp
3b60ff824bada441cd657e10ca01762085a6d099
Diff: https://reviews.apache.org/r/30194/diff/
Testing
---
make distcheck when #30195 has been applied
Thanks,
Cody Maloney
()
statements.
Thanks,
Cody Maloney
---
make distcheck
- Tests not hitting the file:// handling which were replaced with CHECK()
statements.
Thanks,
Cody Maloney
e-mail. To reply, visit:
https://reviews.apache.org/r/29595/
---
(Updated Jan. 13, 2015, 6:47 p.m.)
Review request for mesos, Cody Maloney, Niklas Nielsen, Till Toenshoff,
Timothy Chen, and Timothy St. Clair.
Repository: mesos
()
statements.
Thanks,
Cody Maloney
---
Thanks,
Cody Maloney
: https://reviews.apache.org/r/30591/diff/
Testing
---
Thanks,
Cody Maloney
/diff/
Testing
---
make distcheck on CentOS 7 of patch series.
Thanks,
Cody Maloney
Diff: https://reviews.apache.org/r/30587/diff/
Testing
---
Thanks,
Cody Maloney
/#review70206
---
On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30394
/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
Diff: https://reviews.apache.org/r/30588/diff/
Testing
---
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30394/#review70210
---
On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote:
---
This is an automatically
22f9e3db7b0e1691018de5fe3dfea3cb908de4b9
src/master/main.cpp e5e76ce16646eb0244227104038efeae5f2b
src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa
Diff: https://reviews.apache.org/r/30590/diff/
Testing
---
Thanks,
Cody Maloney
---
On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30396
---
Thanks,
Cody Maloney
check for this:
if compiler == clang libc++ is installed:
use libc++
Will make clang just work more of the times. libstdc++ has a habit lately
of breaking clang with new releases.
- Cody Maloney
On Jan. 29, 2015, 9:53 p.m., Dominic Hamon wrote
On Jan. 29, 2015, 9:59 p.m., Cody Maloney wrote:
.travis.yml, line 30
https://reviews.apache.org/r/30426/diff/1/?file=840481#file840481line30
--enable-debug / --enable-release don't do anything currently when
CXXFLAGS has an initial value since linux distribution build systems
On Jan. 29, 2015, 9:59 p.m., Cody Maloney wrote:
.travis.yml, line 30
https://reviews.apache.org/r/30426/diff/1/?file=840481#file840481line30
--enable-debug / --enable-release don't do anything currently when
CXXFLAGS has an initial value since linux distribution build systems
14.04
Thanks,
Cody Maloney
869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/tests/http_tests.cpp
c71a91d516214d20d3df4c220e4a39a070db3260
Diff: https://reviews.apache.org/r/30441/diff/
Testing
---
make distcheck on Ubuntu 14.04 for the series
Thanks,
Cody Maloney
PRE-CREATION
src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
Diff: https://reviews.apache.org/r/30394/diff/
Testing
---
Thanks,
Cody Maloney
c1bf82b621d6b46afe001acafe9ee53336726406
src/master/detector.hpp 2905e2b3536e14e9df3570da172603e6ed81aae1
src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
Diff: https://reviews.apache.org/r/30395/diff/
Testing
---
Thanks,
Cody Maloney
Diff: https://reviews.apache.org/r/30393/diff/
Testing
---
Thanks,
Cody Maloney
/30398/diff/
Testing
---
Thanks,
Cody Maloney
Diff: https://reviews.apache.org/r/30397/diff/
Testing
---
Thanks,
Cody Maloney
/configuration.md 22f9e3db7b0e1691018de5fe3dfea3cb908de4b9
src/master/main.cpp e5e76ce16646eb0244227104038efeae5f2b
src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa
Diff: https://reviews.apache.org/r/30396/diff/
Testing
---
Thanks,
Cody Maloney
://reviews.apache.org/r/29533/#comment114747
This file needs to be added to
`3rdparty/libprocess/3rdparty/stout/include/Makefile.am`
Otherwise `make distcheck` fails.
- Cody Maloney
On Jan. 21, 2015, 5:44 p.m., Benjamin Hindman wrote
16e711c5c0bc29b1967a20f0827238f8a7b0deaf
Diff: https://reviews.apache.org/r/30195/diff/
Testing (updated)
---
make distcheck
- Tests not hitting the file:// handling which were replaced with CHECK()
statements.
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30195/#review69835
---
On Jan. 27, 2015, 11:39 p.m., Cody Maloney wrote
---
make distcheck
- Tests not hitting the file:// handling which was replaced with assert()
statements.
Thanks,
Cody Maloney
I want to note that if there was any change in behavior around this change
that would likely indicate a serious compiler bug. Namespaces are something
that is purely programmer visible in C++, the symbol names will change
slightly for things that were internal, but nothing else. Things need to be
not hitting the file:// handling which was replaced with assert()
statements.
Thanks,
Cody Maloney
/stout/include/stout/flags/parse.hpp
120946909cd19653ae5f71d401b5c9ea6d8228cd
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
3b60ff824bada441cd657e10ca01762085a6d099
Diff: https://reviews.apache.org/r/30194/diff/
Testing
---
Thanks,
Cody Maloney
distcheck when #30195 has been applied
Thanks,
Cody Maloney
/29533/#comment114061
This is actually incorrect URL encoding if key or value contain '' (which
is legal). See the long thread in https://reviews.apache.org/r/28253/
- Cody Maloney
On Jan. 21, 2015, 5:44 p.m., Benjamin Hindman wrote
to cpplint
(Also gives a baseline to go against for converting header include guards
across).
- Cody Maloney
On Jan. 20, 2015, 11:58 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Jan. 21, 2015, 8:31 p.m., Cody Maloney wrote:
Would it be possible to get a patch which adds pragma once checking to
cpplint (Also gives a baseline to go against for converting header include
guards across).
Dominic Hamon wrote:
we'd need to do that after the mass change
on ubuntu 14.04 with gcc.
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29996/#review68531
---
Ship it!
- Cody Maloney
On Jan. 16, 2015, 11:39 p.m., Ben Mahler
will occur in a series
of following commits.
Diffs
-
src/slave/flags.hpp 16f0cc2
Diff: https://reviews.apache.org/r/26275/diff/
Testing
---
make check on ubuntu 14.04 with gcc.
Thanks,
Cody Maloney
On Jan. 9, 2015, 12:12 a.m., Ben Mahler wrote:
Keep in mind Cody was planning to re-add the variadic version (MESOS-1878),
not sure where that stuff stands.
This looks good to me for now. The variadic as we found out last time is
surprisingly difficult.
Waiting for some time to work on
as the librocess tests
with testing?
The changes look visually good, I haven't verified locally they work yet though.
- Cody Maloney
On Jan. 3, 2015, 12:15 a.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review1
---
Ship it!
- Cody Maloney
On Jan. 3, 2015, 12:15 a.m., Kapil Arya
.)
Review request for mesos and Cody Maloney.
Repository: mesos-git
Description
---
'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.
Diffs
-
Makefile.am
://reviews.apache.org/r/28052/#comment105706
The type_info::name() is (on linux, x86_64 using the standard ABI) defined
to be the symbol name.
See: https://mentorembedded.github.io/cxx-abi/abi.html#typeid
Other platforms don't have the same ABI spec though.
- Cody Maloney
On Nov. 20
1 - 100 of 301 matches
Mail list logo
