Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/2438
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2409
@HeartSaVioR there is not one major project that does not require
contributors to merge commits. It takes a few minutes and it makes a world of
difference in terms of making the git log easy to
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2451
+1
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2428#discussion_r155909342
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -359,7 +356,7 @@ private Builder(Builder builder
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
@srdo aiming to getting this PR merged more quickly I created a
[PR](https://github.com/srdo/storm/pull/1) with a suggested fix off your
branch. If you agree with the fix, can you please incorporate it
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156208523
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -186,12 +182,13 @@ private void initialize(Collection
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156208684
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -223,29 +220,24 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156220249
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -395,7 +387,7 @@ private boolean emitOrRetryTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156223919
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -186,12 +182,13 @@ private void initialize(Collection
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r156224126
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -395,7 +387,7 @@ private boolean emitOrRetryTuple
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
@srdo although some of these methods have been deprecated for 2.0,
customers that are currently in a 1.x.y version will likely use this version
for a few years. We will have to maintain this codebase
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156450849
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -625,4 +619,15 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156234691
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -625,4 +619,15 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156234755
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -625,4 +619,15 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156455782
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -625,4 +619,15 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156499862
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -625,4 +620,21 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156470144
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -230,14 +230,14 @@ public void nextTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156496925
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -257,23 +258,24 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156518312
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -230,14 +230,14 @@ public void nextTuple
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2453#discussion_r156519020
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -625,4 +620,21 @@ public String toString
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2453
+1. Can you please squash such that I can merge it in. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
+1. Can you please squash. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2453
@srdo do you know when you will get the chance to create the PR for 1.x?
Not to rush, but I was hoping we could start converging towards getting 1.2.0
out. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
@srdo don't worry about the authorship. It was just a code review for which
I created a PR to make it easier to discuss.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r157061077
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -442,10 +435,13 @@ private boolean isEmitTuple(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r157104947
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -442,10 +435,13 @@ private boolean isEmitTuple(List
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2454
@srdo Can you explain how can the drawback scenario you describe in your
[comment](https://github.com/apache/storm/pull/2454#issuecomment-351428500)
happen? When activate happens, refresh partitions
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2460
+1
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2454
+1. @srdo can you please squash.
---
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2465
STORM-2844: KafkaSpout Throws IllegalStateException After Committing to
Kafka When First Poll Strategy Set to EARLIEST
- Serialize KafkaSpoutMessageId to JSON and add it as part of
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo can you please do a first pass review. In the meantime I will address
the 2 or 3 TODO with minor cleanups. The following tests are also failing. I am
working on fixing them, but if you know from
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347281
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347380
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347412
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutRebalanceTest.java
---
@@ -181,16 +181,16 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157347438
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I plan on submitting a patch to master, but why does the patch need
to go on master first? For example, there could be bugs in 1.x that no longer
exist in master because of other changes, and in
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349852
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349857
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349862
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -399,14 +429,16 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349864
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutMessageId.java
---
@@ -18,36 +18,88 @@
package
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349870
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I created the PR here because some topologies with latest master were
not working for me and I worked off 1.x-branch to be able to make progress. I
will submit a PR for master as well.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I am working on making unit tests pass and then will squash and
create master PR. Can you take another look in the meantime. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374387
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +243,25 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374754
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +243,25 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374831
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -140,10 +140,16 @@ public
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374891
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -636,4 +675,45 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374885
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -134,7 +134,12 @@ public KafkaSpoutConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374894
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -636,4 +675,45 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374892
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -636,4 +675,45 @@ public String toString
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157375663
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -134,7 +134,12 @@ public KafkaSpoutConfig
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo once I get +1 I will create the PR for master.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2466
Master PR
---
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2466
STORM-2844: KafkaSpout Throws IllegalStateException After Committing â¦
â¦to Kafka When First Poll Strategy Set to EARLIEST
- Check if commits to Kafka were committed by this topology
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157537115
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +243,25 @@ private long doSeek(TopicPartition
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157537266
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -140,10 +140,16 @@ public
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157610099
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -225,6 +237,23 @@ private long doSeek(TopicPartition
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo it should be good now. Can you please take a look. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157809222
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -115,26 +115,30 @@ public KafkaSpoutConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157831049
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -115,26 +115,30 @@ public KafkaSpoutConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157831079
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -115,26 +115,30 @@ public KafkaSpoutConfig
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157831266
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -204,33 +226,70 @@ private void initialize(Collection
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157842966
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/internal/OffsetManagerTest.java
---
@@ -55,12 +58,12 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157930210
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157930206
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157930231
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/MaxUncommittedOffsetTest.java
---
@@ -71,6 +75,10 @@
1
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo can you please do one last review. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2466
@srdo this is the master version.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
These two changes address your comment: "_test that when you call
findNextCommitOffset, it returns the metadata you put in)_"
https://github.com/hmcl/storm-a
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2464#discussion_r158205889
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutReactivationTest.java
---
@@ -0,0 +1,145
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2464
Can you please squash the commits. You can merge after.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2464
@srdo do you think we can get this PR and
https://github.com/apache/storm/pull/2465 merged in today? Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158336381
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -185,29 +188,25 @@ public long commit
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158337077
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutEmitTest.java
---
@@ -100,6 +103,8 @@ public void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158337061
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/MaxUncommittedOffsetTest.java
---
@@ -71,6 +76,9 @@
1
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2464
@srdo OK, I am wrapping up #2466. Hopefully we can still get this done
today. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo can you pls take a look. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158562543
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutAbstractTest.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158562646
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutAbstractTest.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158563441
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutAbstractTest.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158564183
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158564196
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158569401
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158569479
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158569881
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158571418
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutAbstractTest.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158572508
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158573100
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutAbstractTest.java
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo It should be OK now. If you have further requests lest's file a
refactoring JIRA and include in it refactoring some of the unit tests for
better code reuse.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo done. Pls check and I will squash the commits right away. I would
like to try to merge this in today. I will update the master PR with everything
squashed already. Thanks.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2466
@srdo these are all the changes in 1.x-branch already squashed. It is ready
to merge.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo I would like to merge this patch asap. Can you please take a quick
look such that I can squash and merge it in. Thanks.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158656447
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/KafkaUtils.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2465
@srdo Thanks for the review. I have squashed the commits and it is ready to
merge.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2466
@srdo Thanks for the review. I have addressed the last few things and
squashed the commits right away. It is ready to merge.
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119878
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119896
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119938
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159120311
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -88,9 +92,11 @@ private int capacity() {
@Override
601 - 700 of 813 matches
Mail list logo
