The attached patch extracts a configuration API for use by
RemoteServiceProxy. This semantic API allows developers to override
RPC proxy behavior based on intent, rather than interpreting the
status of a RequestBuilder after the fact.
Diffstat:
client/rpc/RpcRequestBuilder.java | 212
Committed to trunk at r5045 with a test added per Ray Ryan's comments
at http://gwt-code-reviews.appspot.com/13804/show.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~-
On Wed, Mar 18, 2009 at 7:44 PM, Ray Cromwell wrote:
> My only criticism of this design is that it only captures a part of the use
> cases where the transport mechanism needs override. That is, it helps in
> cases where one is making HTTP requests, and needs to modify HTTP request
> parameters or
The original idea was to have some kind of "ReachabilityOracle" that
could tell a Linker if some Java method were still contained in the
compiled JS output. The Generator would create a task-list of
resources to add to the compiled output, and it would be the Linker's
responsibility to add that r
On Wed, Mar 25, 2009 at 11:44 AM, wrote:
>
> Author: sco...@google.com
> Date: Wed Mar 25 11:12:37 2009
> New Revision: 5080
>
> Modified:
> trunk/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
>
> Log:
> Removes the PermutationWorkerFactory.lazyFactories cache.
LGTM
--
Bob
After 16+ months of on-and-off development, ClientBundle (nee
ImmutableResourceBundle) is moving to GWT trunk.
$ find user/src/com/google/gwt/resources/
user/test/com/google/gwt/resources/ -name *.java | xargs wc | grep
total
9871 34391 317990 total
The com.google.gwt.resources.Resources
On Wed, Mar 25, 2009 at 7:57 PM, Ray Cromwell wrote:
> Awesome. With regards to StyleInjector, one feature I'd ask for is the
> ability to control where in the cascade it injects. For example, I use IRB
> in Chronoscope to inject GWT widget Themes, but what happens is, this
> overrides any themes
The attached patch re-adds image de-duplication to ClientBundle's
ImageBundleBuilder. (It was there at some point, but disappeared along
the way). The patch also ensures that the ImageResource test is run
in a no-inlining permutation, which would have allowed me to see this
error on my mac.
Diffs
On Fri, Mar 27, 2009 at 12:00 PM, Ray Ryan wrote:
> Kindly enable my tooling dependency:
http://gwt-code-reviews.appspot.com/15802
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~-
Reviewers: rjrjr,
Description:
This version of StyleInjector improves upon the incubator version by
extending the IE6 version to include a workaround to limit the number of
times createStyleSheet is called. It also adds injectStyleSheetAfter()
and injectStyleSheetBefore() to allow for greater co
Reviewers: scottb, rjrjr,
Description:
This patch changes class literal setup to pass the class's seed function
into createForClass when a seed function is available for the type. The
behavior of Class.getName() in -XdisableClassMetadata mode is changed to
return "Class$" for instantiable types
Reviewers: jat, scottb,
Description:
This patch fixes a compiler exception relating to SingleJsoImpl types
that have array return types. The bug stems from the fact that
JArrayType extends JClassType, but JArrayType.isClass() returns null.
The fix is to add an explicit check for array types to
C
On Tue, Mar 31, 2009 at 8:12 PM, Scott Blum wrote:
> This seems kinda hacky since you could recompute the seed func name at
> compile time during GenerateJavaScriptAST?
I thought about that, but discounted it because
GenerateJavaScriptAST would have to take a look at the pruned /
mangled / opt
Committed at r5142.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/15803/diff/1/4
File user/src/com/google/gwt/dom/client/StyleInjector.java (right):
http://gwt-code-reviews.appspot.com/15803/diff/1/4#newcode42
Line 42: return injectStyleSheet(contents);
On 2009/04/01 20:05:03, rjrjr wrote:
> Your public api implies promises
[+Ray Cromwell]
@RayC,
What was the exact problem that you were having without an
insertBefore/After method? These methods are somewhat problematic to
implement in a least-surprise way on IE owing to the pigeonhole
principle unless the API is changed to return some kind of token instead
of a
On Tue, Mar 31, 2009 at 9:09 PM, BobV wrote:
> On Tue, Mar 31, 2009 at 8:12 PM, Scott Blum wrote:
>> This seems kinda hacky since you could recompute the seed func name at
>> compile time during GenerateJavaScriptAST?
>
> I thought about that, but discounted it because
&g
> Here is the patch which does what Scott suggested. Any objections?
LGTM
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
StyleInjector committed to trunk at r5185.
@RayC,
I added an assertion that there is a head tag.
@RayR,
The line lengths seem to be ok according to the eclipse formatting
rules checked into trunk.
I added notes to the Javadoc indicating that not all StyleElements
returned are necessarily u
I'm in the process of migrating ClientBundle into trunk and it
occurred to me that even if you remove the use of all deprecated types
from your code, your module might still inherit an otherwise-unused
module.
What do you think about adding another tag to gwt.xml as follows?
http://google.com
On Mon, Apr 6, 2009 at 1:28 PM, Bruce Johnson wrote:
> Sounds pretty useful. We should lock its behavior down more, though. Maybe
Locking it down is just going to get in the way because we can't cover
all of the types of messages that you'd necessarily want to be able to
convey in tag attributes
> I don't think that handles the most common use case, though. Wouldn't the
> most common thing be, "Don't use this; use "? Most people will go to
> the absolute minimum trouble necessary, so it's unlikely people would be
> included to create an actual URL to point to. (IMHO)
I'm thinking of the
> How does that manifest as XML?
http://google.com/something"; />
where both attributes are optional. The URL will be presented by
using the AbstractTreeLogger.log() method that takes a HelpInfo
object.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~---
On Tue, Apr 7, 2009 at 1:35 PM, Eric Ayers wrote:
> [ERROR] The specified property 'name' is not of the correct type; found
> 'ConfigurationProperty' expecting 'BindingProperty'
ModuleDefSchema line 794 is producing a bad error message, that should
have included the name of the property, not the
ky RPCSuite failure is what we think it
> is.
>
> Review by: bobv (TBR)
LGTM
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: spoon, scottb,
Description:
Some user-agents return status code 0 when operating off of file: URLs.
This patch gets Showcase working from local files.
Please review this at http://gwt-code-reviews.appspot.com/20801
Affected files:
user/src/com/google/gwt/core/client/AsyncFragmentL
On Mon, Apr 13, 2009 at 11:38 AM, Scott Blum wrote:
> LGTM.
Thanks. Committed at r5215.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~
Reviewers: bruce, scottb, knorton, spoon,
Description:
This patch will alter the encoding of the initial fragment so that the
browser will evaluate it in chunks. Chunking the evaluation has
beneficial usability effects because the browser will periodically
unblock the event loop and this helps t
On Mon, Apr 13, 2009 at 2:40 PM, wrote:
> The code LG, one high-level comment about the design. Assuming we're ok
> with the design implications, this seems good.
The never-fail way to do this would be to have JsSourceGeneration
visitor indicate offset values of top-level statements in the str
On Mon, Apr 13, 2009 at 2:55 PM, Scott Blum wrote:
> Actually, I am going to have to torpedo this (sorry!). It just occurred to
> me that while comments are only a hypothetical problem, string literals are
> a real, actual problem that could cause problems today. A string literal
> with mismatc
I've deprecated the public ImmutableResourceBundle interfaces in the
incubator project to encourage users to migrate to the ClientBundle
series of interfaces that are now part of GWT trunk. The IRB code in
the incubator project will not be removed for the foreseeable future,
but all future develo
On Tue, Apr 14, 2009 at 9:02 AM, dflorey wrote:
> Good news! Are there plans to consolidate ClientBundle and i18n
> messages & constants?
> It would be very nice to have a single bundle for all resources of a
> widget to streamline the widget cusomization.
As an interim step, look at GwtCreateRe
Here's my original email to Freeland:
"""
What does this mean for generators that are sensitive to the
user.agent property (or any other property that may be extended)?
Imagine that a common component has a CssResource with an "@if
user.agent safari" rule. The end-developer comes along and exte
On Wed, May 6, 2009 at 4:15 PM, Alex Epshteyn
wrote:
> Yes, we discussed it some time ago. How is that coming along?
The symbol maps are emitted into the -aux directory.
@Alex, what technique are you using?
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--
On Wed, May 6, 2009 at 4:49 PM, Alex Epshteyn
wrote:
> I'm using static code rewriting at the Java source level to maintain a
> virtual stack. It's actually working out very well so far. Getting
> surprisingly good results for code size, efficiency, and correctness.
Could you provide some numb
Reviewers: ,
Description:
This patch adds an @external directive to the CSS system to allow for
selective non-obfuscation of identifiers and to bypass strict-mode
checks.
Please review this at http://gwt-code-reviews.appspot.com/33827
Affected files:
user/src/com/google/gwt/resources/client/
Reviewers: rjrjr, jgw,
Description:
This patch adds support for bundling ClientBundle resources into a
single mhtml document to reduce the total number of round trips required
in IE6. It furthermore enables the use of data: urls for IE8.
Specifics:
- The mhtml format is defined in rfc 2557;
Reviewers: ,
Description:
This patch improves the correctness of SingleJso types by following all
super-interfaces when calculating singleJso data. Additionally, casts
to singleJso interfaces will trigger a rescue of the concrete JSO type.
Please review this at http://gwt-code-reviews.appspot.
http://gwt-code-reviews.appspot.com/34820/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right):
http://gwt-code-reviews.appspot.com/34820/diff/1/2#newcode262
Line 262: public ComplexityEstimator() { }
Unnecessary constructor.
http://gwt-code-reviews.appspot.com/34820/diff/1/2
Reviewers: rjrjr,
Message:
Take 2 at sending email message.
Description:
Add a @NotStrict annotation.
Warn unless one of @Strict or @NotStrict annotation is present or the
CssResource.strictAccessors module property is set.
Update tests to compile without warnings.
Please review this at http:
Reviewers: scottb,
Message:
Incorporated your comments.
http://gwt-code-reviews.appspot.com/34822/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/ast/JClassLiteral.java (right):
http://gwt-code-reviews.appspot.com/34822/diff/1/2#newcode68
Line 68: if (type instanceof JClassType && !(type ins
New patch with feedback.
http://gwt-code-reviews.appspot.com/34824/diff/1/3
File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/34824/diff/1/3#newcode221
Line 221: + "using an @external declaration for unobfuscated classes.");
Done.
LGTM, just some nits.
http://gwt-code-reviews.appspot.com/33835/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardClassMember.java
(right):
http://gwt-code-reviews.appspot.com/33835/diff/1/2#newcode44
Line 44: private SortedSet overridesView = null;
The explicit initializatio
LGTM
http://gwt-code-reviews.appspot.com/33839
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
An even-crazier setup would be that the locally-installed plugin is
just a sled for downloading the actual plugin guts from the server.
This way, a single plugin installation could work with different
versions of the OOPHM host code.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~
Wouldn't this break existing code, such as?
JsArray noGenericParams = ;
SomeJso jso = noGenericParams.get(i).cast();
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~
LGTM
http://gwt-code-reviews.appspot.com/33846
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
The one thing that really stands out is that this has an
optimization-dependent failure mode where a runAsync call could get
optimized out of a method.
http://gwt-code-reviews.appspot.com/33848/diff/1/4
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(right):
http://
LGTM.
http://gwt-code-reviews.appspot.com/40801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/40801/diff/1/2#newcode76
Line 76: * being compiled.
"containing all resources in the module's source paths"
That it's from the
On Mon, Jun 15, 2009 at 7:26 AM, Joel Webber wrote:
> I'm assuming we'd have to rewrite new and field access operators to these
> classes in the hosted-mode classloader, right? I haven't messed with the
> hosted-mode classloader in a *very* long time, so we may be doing this
> already for all I kn
LGTM
http://gwt-code-reviews.appspot.com/33848/diff/4002/4005
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
(right):
http://gwt-code-reviews.appspot.com/33848/diff/4002/4005#newcode68
Line 68: String location = splitPointMap.get(sp);
assert location != null
http:/
Reviewers: scottb,
Message:
Requesting review
Description:
This patch would allow user-provided code to escape from the
CompilingClassLoader sandbox.
Use case:
- Create a type that should be used only in hosted mode which lives
somewhere in the classpath
- Create a web-mode implementation
Reviewers: Dan Rice,
Message:
Requesting review
Description:
This change speeds up the ClientBundle and CssResource generators.
- Use the compiler's ResourceOracle instead of the ClassLoader to find
resources
- Add a caching mechanism to ClientBundle's ResourceContext to allow
ResourceGenerator
On Tue, Jun 16, 2009 at 12:46 AM, Freeland Abbott wrote:
> Ping. Bob, I think you had special interest in this one. ;-)
ant clear dist-dev && cd user && ant test
does the right thing.
LGTM.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://gr
Thanks for the review. Committed at r5566.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
@Scott,
Per our IM conversation, I've renamed the new concept to
"GwtScriptOnly". Could you check this over once more before I commit it?
@John,
Thanks for the review.
http://gwt-code-reviews.appspot.com/34836
--~--~-~--~~~---~--~~
http://groups.google.com
LGTM
http://gwt-code-reviews.appspot.com/34819
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: scottb,
Message:
Requesting review.
http://gwt-code-reviews.appspot.com/42801/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right):
http://gwt-code-reviews.appspot.com/42801/diff/1/2#newcode877
Line 877: blacklist.add(f);
This is the main fix.
http://gwt-code-rev
On Thu, Jun 18, 2009 at 1:10 AM, wrote:
> LGTM
Thanks. I renamed the local variable and committed it at r5585.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~---
On Wed, Jun 17, 2009 at 10:38 PM, wrote:
> Has this/is this going anywhere? Has actual work been done on the
> implementation?
Glad you asked:
http://google-web-toolkit.googlecode.com/svn/changes/bobv/derpc/
I'm working on getting the initial version merged into trunk to get
mo
The fix looks good, but I don't think that any tests beyond the first
are validating that the load sequence is working correctly.
http://gwt-code-reviews.appspot.com/43802/diff/1/4
File user/test/com/google/gwt/dev/jjs/InitialLoadSequence.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/438
Reviewers: Lex, scottb,
Message:
Requesting review
Description:
This change adds an additional method to the linker SymbolData API to
export typeids. This data will be used by the derpc code.
Please review this at http://gwt-code-reviews.appspot.com/41802
Affected files:
M dev/core/src/com
Reviewers: Lex, scottb,
Message:
Review requested
Description:
I keep writing the same utility method in my Generator types to create a
JSNI reference to a given JMethod.
Please review this at http://gwt-code-reviews.appspot.com/44802
Affected files:
M dev/core/src/com/google/gwt/core/ext/t
Thanks, John. Committed at r5595.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: scottb, Lex,
Message:
Request review.
http://gwt-code-reviews.appspot.com/44803/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right):
http://gwt-code-reviews.appspot.com/44803/diff/1/2#newcode916
Line 916: }
Actual changes are above. From here to the next comment
Reviewers: scottb,
Message:
Requesting review.
@Scott, if you're still tied up from last week, let me know and I'll
kick this over to Lex, but I think that you might remember some of the
design details from the in-person chat we had about it.
Description:
The ArtificialRescue annotation is used
Reviewers: scottb,
Message:
Review requested.
Description:
Adds an Impl.getNameOf() method which ReplaceRebinds will replace with a
JNameOf node.
The JNameOf node is currently used internally to provide class literals
with meaningful names when class metadata has been compiled out of the
module
LGTM
http://gwt-code-reviews.appspot.com/44804
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Please extract the expando work to the gwt.core.client package and add
test cases for it, as it's a generally-useful facility to offer.
Needs tests of the JDO testcases.
@Cromwellian,
The expando field just reserves a bit of the Object-field namespace
since it's lazily initialized.
http://g
Ping
http://gwt-code-reviews.appspot.com/46802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Ping
http://gwt-code-reviews.appspot.com/46801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/47807/diff/1/9
File user/src/com/google/gwt/user/client/rpc/WeakMapping.java (right):
http://gwt-code-reviews.appspot.com/47807/diff/1/9#newcode31
Line 31: public static Object get(Object instance, String key) {
On 2009/06/29 15:34:02, Dan Rice wrote:
> I'm no
Thanks for the review; the JSNI lookup logic had already been extracted
into JsniRefLookup by Lex some number of weeks ago.
Committed at r5640.
http://gwt-code-reviews.appspot.com/46802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contr
I think the following scenario should be made to work.
my.css:
@def shadow #abc
.shadow { color: shadow; }
my.java
MyCss implements CssResource {
String shadow();
@ClassName("shadow")
String shadowClass();
}
http://gwt-code-reviews.appspot.com/50804/diff/1/5
File user/src/com/goo
On 2009/06/29 13:40:16, bobv wrote:
> Ping
Ping.
http://gwt-code-reviews.appspot.com/46801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jat,
Message:
Requesting review.
Description:
Splits UnicodeEscapingTest.testClientToServerBMP() into two methods so
that failures are correctly reported. The current implementation will
call finishTest() twice, which will desynchronize the junit framework,
making failures harder to p
http://gwt-code-reviews.appspot.com/48806
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Updated.
http://gwt-code-reviews.appspot.com/46801/diff/1041/24
File dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java
(right):
http://gwt-code-reviews.appspot.com/46801/diff/1041/24#newcode282
Line 282: return "Cannot refer to fields on " + "array or primitive
types";
On 2009/
Ignore patch set 5; the change to JProgram.traverse() is necessary.
http://gwt-code-reviews.appspot.com/46801/diff/5008/4010
File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right):
http://gwt-code-reviews.appspot.com/46801/diff/5008/4010#newcode1087
Line 1087: visitor.accept(new Arr
Thanks for taking a look. I've updated my client.
I think the dev/ comments have been subsumed by the latest version of
the patch at:
http://gwt-code-reviews.appspot.com/46801/show
> bad indent in DynaTable.gwt.xml
Fixed.
> CustomFieldSerializerValidator looks like checkstyle fixing; separa
> I won't kick and scream about Pair, but it does suggest this is a general
> class that may be a larger issue for a more interesting example.
I agree; I'll be in Atlanta tomorrow through Friday. Let's have a
chat with Scott about maybe rearranging the various collection types
used in the compi
LGTM; Sorry for the delay.
http://gwt-code-reviews.appspot.com/47806/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (right):
http://gwt-code-reviews.appspot.com/47806/diff/1/3#newcode413
Line 413: private static void installInitialLoadSequenceField(JProgram
program,
Ad
Reviewers: scottb,
Message:
Request review.
Description:
This patch ensures that a after an will
correctly replace the previously-defined implementation.
Please review this at http://gwt-code-reviews.appspot.com/47813
Affected files:
M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
I've changed ModuleDef to track the string names internally. This makes
all of the added code in defineLinker() sanity-checking code.
http://gwt-code-reviews.appspot.com/47813/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
http://gwt-code-reviews.appspot.com/47813/di
Reviewers: scottb, Lex,
Message:
Review requested.
http://gwt-code-reviews.appspot.com/47816/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):
http://gwt-code-reviews.appspot.com/47816/diff/1/4#newcode2125
Line 2125: jsProgram.setIndexedFunctions(indexe
Ping.
http://gwt-code-reviews.appspot.com/47816
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: Lex, scottb,
Message:
Review requested.
Description:
JTypeOracle.computeSingleJsoImplData() was using an incorrect test to
determine if an interface is a tag interface. It was looking at the
number of methods declared on the interface type without looking at the
interface's supertype
Thanks.
The extra test types were incorporated into singlejso.TypeHierarchyTest.
Committed at r5756.
http://gwt-code-reviews.appspot.com/51805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--
Reviewers: amitmanjhi,
Message:
Request review.
Description:
This patch fixes three small issues:
1) Canonicalization of inner array type names
2) Ensuring that primitive return types for service methods cause
their boxed counterparts to be rescued since return types are boxed over
the wir
Committed at r5762.
http://gwt-code-reviews.appspot.com/54801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Implementation changes LGTM. The internals of the compiler really need
more documentation so other developers have a chance in hell of getting
the zen of the current implementation when implementing new features.
http://gwt-code-reviews.appspot.com/54802/diff/1/2
File dev/core/src/com/google/gw
I don't think getting this thing wrapped up will take too much more
work.
http://gwt-code-reviews.appspot.com/47816/diff/1/5
File dev/core/src/com/google/gwt/dev/js/JsStackEmulator.java (right):
http://gwt-code-reviews.appspot.com/47816/diff/1/5#newcode132
Line 132: // $stack[$stackDepth = stac
Ready for another look. Major changes:
- No special handling for throw statements.
- Force all try/finally to be try/catch/finally to ensure that a
caught JavaScriptException would have the correct stack data as well as
code running in the finally block.
- Locations always record when ex
LGTM.
http://gwt-code-reviews.appspot.com/54803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Should running a web-mode test case always turn on the emulated stack
trace code?
You would get stack traces entries like:
Unknown.bx(YourClass.java:1234) regardless of which browser you're on
and the type of exception, Java-derived or native. The cost is code
bloat: 64k versus 108k for the Core
> Would "always on" mean that it generates code even for browsers that have
> native stack traces (i.e. FF)?
Yes, for the purpose of giving you consistency between browsers.
> Generally, as much as I hate to say it, it seems we'd want variations of the
> tests both with and without stack trace c
> Technically, wouldn't it just mean we should not pin down the value of the
> deferred binding property that controls it? It would double the number of
> permutations, tho.
But wouldn't we actually want to run the instrumented code, to make
sure that the instrumentation itself doesn't break some
On Thu, Jul 23, 2009 at 1:25 PM, Bruce Johnson wrote:
> Yes, I think we would want to. My point is that we also would want to run
> the non-instrumented code. I have to think there could be subtle downstream
> behavioral differences (e.g. compiler optimizations that do/don't happen)
> based on whe
@Bruce,
Per our phone conversation, JUnit will turn on the emulated stack
trace code for browsers that do not provide stack data for native
exceptions.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolki
Here's a null-pointer deref in Safari. The location data here is
accurate, you can call up RequestBuilder.java and see on line 396 that
it's firing onResponseReceived.
The offending Java code is: ((String) null).charAt(55);
The exception reported through the JUnit console is
com.google.gwt.c
1 - 100 of 832 matches
Mail list logo
