Re: [PATCH 1/2] mn88473: fix chip id check on probe

99a6c ("[media] mn88473: finalize driver") Cc: # v4.8+ Signed-off-by: Antti Palosaari I can confirm that I saw something with regards to this one time before. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the bo

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

On 11/11/2016 02:55 PM, Mauro Carvalho Chehab wrote: Em Thu, 10 Nov 2016 12:15:39 +0100 Benjamin, Could you please test it? Thanks! Mauro Hi, I the device is in use now. Can't test it with a new tree. I am using an old tree for it. MvH Benjamin Larsson -- To unsubscribe from this

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

other drivers I touched. Regards, Mauro Just for reference I got the following call trace a week ago. I looks like this confirms that other drivers are affected also. MvH Benjamin Larsson dvb-usb: found a 'Mygica T230 DVB-T/T2/C' in warm state. BUG: unable to handle kernel NULL poin

Re: [BUG] non working drivers with current linuxtv git on Ubuntu 16.04.1 LTS

On 10/30/2016 01:22 PM, Benjamin Larsson wrote: I got this for my anysee card: dvb_usb_anysee: disagrees about version of symbol dvb_ca_en50221_init dvb_usb_anysee: Unknown symbol dvb_ca_en50221_init (err -22) dvb_usb_anysee: disagrees about version of symbol dvb_ca_en50221_release

[BUG] non working drivers with current linuxtv git on Ubuntu 16.04.1 LTS

eb 1f 49 c7 45 00 02 00 00 00 4c 89 e7 RIP [] __mutex_lock_slowpath+0x98/0x130 RSP CR2: ---[ end trace b28b9190ee8e4917 ]--- MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.ke

Re: [PATCH] [media] dw2102: Add support for Terratec Cinergy S2 USB BOX

On 07/18/2016 01:59 PM, Mauro Carvalho Chehab wrote: It would be nice if both Philipp and Benjamin test such patch, for us to be sure that it would work for both. Regards, Mauro I added it to the dvbsky driver so I guess that Philipp has to do the testing. MvH Benjamin Larsson -- To

Re: [PATCHv2] rtl28xxu: increase failed I2C msg repeat count to 3

On 2016-06-07 09:52, Antti Palosaari wrote: 1 and 2 wasn't enough for mn88472 chip on Astrometa device, so increase it to 3. Signed-off-by: Antti Palosaari ACK MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a me

Re: [PATCH] rtl2832: add support for slave ts pid filter

On 05/21/2016 10:38 PM, Benjamin Larsson wrote: The rtl2832 demod has 2 sets of PID filters. This patch enables the filter support when using a slave demod. Ignore this patch for now. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" i

[PATCH] rtl2832: add support for slave ts pid filter

The rtl2832 demod has 2 sets of PID filters. This patch enables the filter support when using a slave demod. Signed-off-by: Benjamin Larsson --- drivers/media/dvb-frontends/rtl2832.c | 21 ++--- drivers/media/dvb-frontends/rtl2832_priv.h | 1 + 2 files changed, 19

Re: [PATCH 1/3] rtl28xxu: increase failed I2C msg repeat count to 2

thing else ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] mn88472: add work around for failing firmware loading

n the mn88473 version of this hardware also. I just haven't had the time to test it. But I will postpone that until the tests on the other bridges are done. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to major

Re: [PATCH 1/3] rtl2832: add support for slave ts pid filter

On 12/21/2015 03:42 AM, Antti Palosaari wrote: Patch looks acceptable, but it is broken in a mean it does not apply :( I'll rebase on git://linuxtv.org/anttip/media_tree.git rtl2832u_pull. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-med

Re: [PATCH 3/3] rtl28xxu: change Astrometa DVB-T2 to always use hardware pid filters

filters need to be forced. The only reason would be that I suspected that high rates would not be possible over the bridge and that this was the default mode for the binary driver but as you proved that the bridge is able to support the rate this patch can be nacked. regards Antti MvH Benjamin

Re: AF9035 with no tuner?

On 12/12/2015 10:25 PM, Jiri Slaby wrote: On 12/12/2015, 10:12 PM, Benjamin Larsson wrote: On 12/12/2015 10:08 PM, Jiri Slaby wrote: Hello, I have a USB device which digitizes composite video into a MPEG-2 stream (I think). It is an AF9035 device according to windows. But it has no tuner. Is

Re: AF9035 with no tuner?

pictures of the pcb and the chips. After that it might be possible to identify what kind of device it is. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: Dear TV card experts - I need you help

form factor that would fit in rack-mounted servers. You need high density and that is the only way to get that. So I would say skip trying to find something cheap, get something that is reliable and maintainable. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubsc

Re: Dear TV card experts - I need you help

e mux s2 card I could find cost ca $60. So $50/mux is probably what you have to pay for this component if you buy from a reseller. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More ma

[PATCH 1/3] rtl2832: add support for slave ts pid filter

Signed-off-by: Benjamin Larsson --- drivers/media/dvb-frontends/rtl2832.c | 21 ++--- drivers/media/dvb-frontends/rtl2832_priv.h | 1 + 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends

[PATCH 3/3] rtl28xxu: change Astrometa DVB-T2 to always use hardware pid filters

Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 35 - 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index 5a503a6..74201ec 100644 --- a

[PATCH 2/3] mn88472: add work around for failing firmware loading

: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index cf2e96b..80c5807 100644 --- a/drivers/staging/media/mn88472/mn88472.c

[PATCH 1/2] Add Terratec Cinergy S2 usb id's

Signed-off-by: Benjamin Larsson --- drivers/media/dvb-core/dvb-usb-ids.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/dvb-core/dvb-usb-ids.h b/drivers/media/dvb-core/dvb-usb-ids.h index 1c1c298..d62ac1f 100644 --- a/drivers/media/dvb-core/dvb-usb-ids.h +++ b/drivers

[PATCH 2/2] Add support for Terratec Cinergy S2 Rev.4

Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c index 1dd9625..2d922b9 100644 --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c +++ b/drivers

Re: PID filter testing

ready available tool for that. Adding pid selection to dvbv5-zap in monitor mode looks to be the best way forward. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: PID filter testing

On 11/20/2015 02:27 PM, Honza Petrouš wrote: 2015-11-20 12:00 GMT+01:00 Benjamin Larsson : Hi, what tools can I use to test pid filter support in the drivers ? Zap utility from dvbapps seems to be some simpler way - you can pass them the fixed pids and record filtered data by simple command

PID filter testing

Hi, what tools can I use to test pid filter support in the drivers ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rtl28xxu: fix control message flaws

3-01.fw' [ 359.115582] mn88473 19-0018: firmware parity check succeeded=0x20 MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] mn88472: Fix possible leak in mn88472_init()

etected by Coverity CID 1295989. Signed-off-by: Christian Engelmayer ACK MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/12] rtl2832: add support for GoTView MasterHD 3 USB tuner

rking rfc patch you could base it on. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

ssing register I/O checks left ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

On 03/21/2015 12:25 AM, Antti Palosaari wrote: On 03/21/2015 01:13 AM, Benjamin Larsson wrote: On 03/19/2015 03:44 PM, Antti Palosaari wrote: Bad news. It does lock for DVB-C now, but DVB-T nor DVB-T2 does not lock. regards Antti I'm getting tired :/. Had the time to test now and the c

Re: [PATCH 1/1] mn88473: implement lock for all delivery systems

stock dvbv5-scan crashes on ubuntu 14.04 and I can't unload the mn88473 module I will confirm this when I have an actual working version of dvbv5-scan and Ubuntu. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a messa

Re: [PATCH 10/10] mn88473: implement lock for all delivery systems

On 03/18/2015 10:13 PM, Antti Palosaari wrote: On 03/17/2015 01:10 AM, Benjamin Larsson wrote: On 03/16/2015 11:44 PM, Antti Palosaari wrote: On 03/16/2015 11:47 PM, Antti Palosaari wrote: On 03/16/2015 12:57 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson Applied. I found

[PATCH 1/1] mn88473: implement lock for all delivery systems

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88473/mn88473.c | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c index a23e59e..196fcd6 100644

Re: [RFC][PATCH] rtl2832: PID filter support for slave demod

On 03/16/2015 11:57 PM, Antti Palosaari wrote: On 03/17/2015 12:12 AM, Benjamin Larsson wrote: Is this structure ok for the slave pid implementation? Or should there be only one filters parameter? Will the overlaying pid filter framework properly "flush" the set pid filters ? Note

Re: [PATCH 10/10] mn88473: implement lock for all delivery systems

On 03/16/2015 11:44 PM, Antti Palosaari wrote: On 03/16/2015 11:47 PM, Antti Palosaari wrote: On 03/16/2015 12:57 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson Applied. I found this does not work at least for DVB-C. After playing with modulator I find reg 0x85 on bank 1 is

[RFC][PATCH] rtl2832: PID filter support for slave demod

Is this structure ok for the slave pid implementation? Or should there be only one filters parameter? Will the overlaying pid filter framework properly "flush" the set pid filters ? Note that this code currently is only compile tested. MvH Benjamin Lar

Re: [PATCH 04/10] rtl28xxu: swap frontend order for slave demods

On 03/16/2015 10:04 PM, Antti Palosaari wrote: On 03/16/2015 10:44 PM, Benjamin Larsson wrote: On 03/15/2015 11:57 PM, Benjamin Larsson wrote: Some devices have 2 demodulators, when this is the case make the slave demod be listed first. Enumerating the slave first will help legacy applications

Re: [PATCH 04/10] rtl28xxu: swap frontend order for slave demods

On 03/15/2015 11:57 PM, Benjamin Larsson wrote: Some devices have 2 demodulators, when this is the case make the slave demod be listed first. Enumerating the slave first will help legacy applications to use the hardware. Ignore this patch for now. Stuff gets broken if applied. /Benjamin

[PATCH 10/10] mn88473: implement lock for all delivery systems

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88473/mn88473.c | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c index a23e59e..ba39614 100644

[PATCH 06/10] mn88472: implement firmware parity check

Signed-off-by: Benjamin Larsson Reviewed-by: Antti Palosaari Signed-off-by: Antti Palosaari --- drivers/staging/media/mn88472/mn88472.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index

[PATCH 07/10] mn88473: implement firmware parity check

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88473/mn88473.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c index 84bd4fa..607ce4d 100644 --- a/drivers/staging/media/mn88473

[PATCH 09/10] mn88472: check if firmware is already running before loading it

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 4a00a4d..c041fbf 100644 --- a/drivers

[PATCH 08/10] mn88473: check if firmware is already running before loading it

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88473/mn88473.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c index 607ce4d..a23e59e 100644 --- a/drivers/staging

[PATCH 05/10] mn88472: implement lock for all delivery systems

The increase of the lock timeout is needed for dvb-t2. Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media

[PATCH 04/10] rtl28xxu: swap frontend order for slave demods

Some devices have 2 demodulators, when this is the case make the slave demod be listed first. Enumerating the slave first will help legacy applications to use the hardware. Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 18 -- 1 file changed, 12

[PATCH 02/10] r820t: change read_gain() code to match register layout

Signed-off-by: Benjamin Larsson --- drivers/media/tuners/r820t.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index 639c220..eaaf1dc 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c

[PATCH 03/10] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors

The Astrometa device has issues with i2c transfers. Lowering the poll time somehow makes these errors disappear. Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2

[PATCH 01/10] r820t: add DVBC profile in sysfreq_sel

This will make the Astrometa DVB-T/T2/C usb stick be able to pick up muxes around 290-314 MHz. Signed-off-by: Benjamin Larsson --- drivers/media/tuners/r820t.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index

Re: [PATCH] Basic support for the Elgato EyeTV Hybrid INT 2008 USB Stick

352.h" #include "mt352_priv.h" /* FIXME */ #include "tda1002x.h" -#include "drx39xyj/drx39xxj.h" +#include "drx39xxj.h" This change looks unrelated. The rest looks ok. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsu

Re: Linux TV support Elgato EyeTV hybrid

On 02/23/2015 11:54 PM, Gilles Risch wrote: On 02/23/2015 09:36 PM, Benjamin Larsson wrote: On 02/23/2015 09:24 PM, Gilles Risch wrote: On 02/22/2015 10:29 PM, Antti Palosaari wrote: On 02/22/2015 10:04 PM, Benjamin Larsson wrote: On 02/22/2015 02:47 PM, Gilles Risch wrote: [...] Not sure

Re: Linux TV support Elgato EyeTV hybrid

On 02/23/2015 09:24 PM, Gilles Risch wrote: On 02/22/2015 10:29 PM, Antti Palosaari wrote: On 02/22/2015 10:04 PM, Benjamin Larsson wrote: On 02/22/2015 02:47 PM, Gilles Risch wrote: [...] [ 141.423608] WARNING: You are using an experimental version of the media stack. [ 141.423609] As

Re: Linux TV support Elgato EyeTV hybrid

hat USB stick? The TerraTec H5 has a TDA18271 tuner. Regards, Gilles So most likely the Elgato EyeTV hybrid is one of these combinations. And it should quite feasible to add support for someone who knows the Empia EM2884. MvH Benjamin Larsson -- To unsubscribe from this list: send t

Re: [RFC PATCH] mn88472: reduce firmware download chunk size

On 2015-02-19 11:21, Antti Seppälä wrote: On 19 February 2015 at 11:43, Benjamin Larsson wrote: On 2015-02-19 10:13, Antti Seppälä wrote: It seems that currently the firmware download on the mn88472 is somehow wrong for my Astrometa HD-901T2. Reducing the download chunk size

Re: [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors

On 2014-12-06 01:25, Benjamin Larsson wrote: The Astrometa device has issues with i2c transfers. Lowering the poll time somehow makes these errors disappear. Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [RFC PATCH] mn88472: reduce firmware download chunk size

workaround patch I sent for this. [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors I now see that it hasn't been merged. But I have been running with this patch for a few months now without any major issues. MvH Benjamin Larsson -- To unsubscribe from this list: send the

Re: [PATCH] r820t: add DVBC profile in sysfreq_sel

) should be working fine. DVB-T2 needs working pid filters before it can work properly. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH] r820t: add DVBC profile in sysfreq_sel

Signed-off-by: Benjamin Larsson --- drivers/media/tuners/r820t.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index 8e040cf..639c220 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c

Re: Sundtek Media Pro III Europe switching off

t in the Sundtek forums. http://support.sundtek.com/ MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] mn88472: make sure the private data struct is nulled after free

On 01/19/2015 02:15 PM, Hans Verkuil wrote: On 12/06/2014 09:26 PM, Benjamin Larsson wrote: Well I guess I am biased as I have spent lots of time finding a bug that probably wouldn't exist if the policy was that drivers always should set their memory to zero before it is free'd. Ju

[PATCH 1/2] mn88473: calculate the IF register values

Add xtal as a configuration parameter so it can be used in the IF register value calculation. If not set in the configuration then use a default value. Signed-off-by: Benjamin Larsson --- drivers/media/dvb-frontends/mn88473.h| 6 ++ drivers/staging/media/mn88473/mn88473.c | 26

[PATCH 2/2] mn88473: simplify bandwidth registers setting code

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88473/mn88473.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c index b65e519..994294c 100644 --- a

[PATCH 2/2] r820t: add settings for SYS_DVBC_ANNEX_C standard

Signed-off-by: Benjamin Larsson --- drivers/media/tuners/r820t.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index c94c6a3..b4c85ba 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c

[PATCH 1/2] r820t: enable flt_ext_wide for SYS_DVBC_ANNEX_A standard

Signed-off-by: Benjamin Larsson --- drivers/media/tuners/r820t.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index 8e040cf..c94c6a3 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c

[PATCH] mn88472: simplify bandwidth registers setting code

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 41 +++-- 1 file changed, 14 insertions(+), 27 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 33604dc..ee933c3 100644

[PATCH 1/1] rtl28xxu: swap frontend order for devices with slave demodulators

Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index ab48b5f..37f8825 100644 --- a

Re: [RFC][PATCH] mn88472: add support for the mn88473 demod

milar enough. The code that could be shared is not enough to give any advantage over 2 drivers. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [PATCH 48/66] rtl28xxu: use master I2C adapter for slave demods

really long time to get them). If I reload the rtl28xxu driver 2 times it starts working again. Could this change be related to such errors ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kerne

Re: [RFC][PATCH] mn88472: add support for the mn88473 demod

to the xtal parameter. So does the mn88473 support look ok and should the driver figure out what demod is connected ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo inf

[RFC][PATCH] mn88472: add support for the mn88473 demod

Factor out the bw_val data to a table and load data from it depending on the configured demod. Signed-off-by: Benjamin Larsson --- drivers/media/dvb-frontends/mn88472.h| 30 + drivers/staging/media/mn88472/mn88472.c | 66 ++-- drivers/staging

Re: [PATCH] mn88472: implement lock for all delivery systems

Hello. On 12/16/2014 04:34 AM, Antti Palosaari wrote: Moikka! On 12/16/2014 01:40 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2] mn88472: implement lock for all delivery systems

The increase of the lock timeout is needed for dvb-t2. Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media

[PATCH] mn88472: implement lock for all delivery systems

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 68f5036..426f0ed 100644 --- a/drivers

Re: [PATCH 16/18] rtl28xxu: add support for RTL2831U/RTL2830 PID filter

On 12/14/2014 09:28 AM, Antti Palosaari wrote: RTL2830 demod integrated to RTL2831U has PID filter. PID filtering is provided by rtl2830 demod driver. Add support for it. Do you plan on adding this for the RTL2832 demod also ? MvH Benjamin Larsson -- To unsubscribe from this list: send the

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

demod_i2c_adapter, &rtl2832u_r828d_config); adap->fe[0]->ops.read_signal_strength = adap->fe[0]->ops.tuner_ops.get_rf_strength; I must have had that change still active in my tree. Does that make any sense? MvH Benjamin Larsson -- To unsubscribe from this list:

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

patibility with old software. This isn't strictly needed so consider the patch dropped. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] mn88472: implement dvb-t signal lock

On 12/13/2014 04:52 AM, Antti Palosaari wrote: That breaks DVB-C lock check as old "utmp = 0x08" was set according to DVB-C lock check, right? Antti I have a dvb-c setup now. I will respin this patch with dvb-c support tested properly. MvH Benjamin Larsson -- To unsubscribe from

Re: [PATCH 4/4] mn88472: implemented ber reporting

On 12/13/2014 05:15 AM, Antti Palosaari wrote: On 12/13/2014 02:18 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson Reviewed-by: Antti Palosaari Even I could accept that, as a staging driver, I see there some issues: * missing commit message (ok, it is trivial and patch

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

't remember any patch changing it to 0. I look my tree FE ID is 0. Do you have some unpublished hacks? No hacks, it works for me that way. Antti MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majo

[PATCH 3/4] mn88472: elaborate debug printout

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 4d80046..746cc94 100644 --- a/drivers/staging/media

[PATCH 1/4] mn88472: implement dvb-t signal lock

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 107552a..4d80046 100644 --- a/drivers/staging/media

[PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index ab48b5f..cdc342a 100644 --- a/drivers/media/usb/dvb-usb

[PATCH 4/4] mn88472: implemented ber reporting

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 746cc94..8b35639 100644 --- a/drivers/staging

Re: [PATCH 1/2] mn88472: fix firmware downloading

adapter which cannot write even 17 bytes. 2nd thing is to add comment mn88472.h to specify that max limit and that's all. regards Antti Ok, I'll do that. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of

[PATCH 1/2] mn88472: fix firmware downloading

The max amount of payload bytes in each i2c transfer when loading the demodulator firmware is 16 bytes. Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c

[PATCH 2/2] mn88472: implement firmware parity check

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index df7dbe9..1df85a7 100644 --- a/drivers/staging/media/mn88472

Re: [PATCH 2/2] mn88472: fix firmware loading

ity check of the firmware and all the times the check succeeded but the demodulator didn't deliver data. So I guess that the parity checker is before the 16 byte buffer and if you write more the data is just ignored. I will send an updated patch based on this. MvH Benjamin Larsson -- To

Re: [PATCH 2/2] mn88472: fix firmware loading

On 12/07/2014 11:36 PM, Antti Palosaari wrote: On 12/08/2014 12:10 AM, Benjamin Larsson wrote: The firmware must be loaded one byte at a time via the 0xf6 register. I don't think so. Currently it downloads firmware in 22 byte chunks and it seems to work, at least for me, both mn8847

Re: [PATCH 2/2] mn88472: fix firmware loading

On 12/07/2014 11:36 PM, Antti Palosaari wrote: On 12/08/2014 12:10 AM, Benjamin Larsson wrote: The firmware must be loaded one byte at a time via the 0xf6 register. I don't think so. Currently it downloads firmware in 22 byte chunks and it seems to work, at least for me, both mn8847

[PATCH 2/2] mn88472: fix firmware loading

The firmware must be loaded one byte at a time via the 0xf6 register. Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging

[PATCH 1/2] mn88472: load demodulator register defaults

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 21 + drivers/staging/media/mn88472/mn88472_priv.h | 558 +++ 2 files changed, 579 insertions(+) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472

[PATCH] mn88472: add 5MHz dvb-t2 bandwitdh support

Signed-off-by: Benjamin Larsson --- drivers/staging/media/mn88472/mn88472.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index c6895ee..be8a6d5 100644 --- a/drivers/staging/media/mn88472

Re: [PATCH 2/3] mn88472: make sure the private data struct is nulled after free

at drivers always should set their memory to zero before it is free'd. Maybe we should have a compile time override so that all free calls zeroes the memory before the actual free? Maybe there already is this kind of feature? MvH Benjamin Larsson -- To unsubscribe from this list: send the li

Re: [PATCH 2/3] mn88472: make sure the private data struct is nulled after free

s bug. The current dvb framework contain several other cases where pointers are feed'd but not nulled. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors

least when the card is set in dvb mode, for sdr mode this might not be an issue. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] mn88472: add ts mode and ts clock to driver

Signed-off-by: Benjamin Larsson --- drivers/media/dvb-frontends/mn88472.h| 12 +++ drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 ++ drivers/staging/media/mn88472/mn88472.c | 30 ++-- drivers/staging/media/mn88472/mn88472_priv.h | 2 ++ 4 files

[PATCH 2/3] mn88472: make sure the private data struct is nulled after free

Using this driver with the attach dvb model might trigger a use after free when unloading the driver. With this change the driver will always fail on unload instead of randomly crash depending on if the memory has been reused or not. Signed-off-by: Benjamin Larsson --- drivers/staging/media

[PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors

The Astrometa device has issues with i2c transfers. Lowering the poll time somehow makes these errors disappear. Signed-off-by: Benjamin Larsson --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2

Re: [PATCH 1/3] rtl2832: convert driver to I2C binding

On 12/02/2014 03:31 PM, Antti Palosaari wrote: Convert that driver to I2C driver model. Legacy DVB binding is left also for later removal... Signed-off-by: Antti Palosaari Works fine. Thanks for the quick fix. Tested-by: Benjamin Larsson MvH Benjamin Larsson -- To unsubscribe from this

Re: Random memory corruption of fe[1]->dvb pointer

MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Random memory corruption of fe[1]->dvb pointer

ashing the subsystem and the driver is still in staging for a reason. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   >