Re: [Cvslog] r16830 - in /lyx-devel/trunk/src: BufferView.C insets/ins...

2007-01-26 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: I am sorry that I did not answer in time. To try to compensate, here is a patch showing what I mean. The idea is to use the complete symmetry between accept and reject: - accept: remove DELETED chunks, keep INSERTED chunks - reject: remove INSERTED chunks, keep DEL

DEPM question

2007-01-25 Thread Michael Gerz
Question of the day: Why don't we strip leading spaces in DEPM() if there is only one paragraph? // don't delete anything if this is the ONLY paragraph! if (old.lastpit() == 0) return false; if (oldpar.empty() || (oldpar.size() == 1 &&

Re: [Cvslog] r16589 - in /lyx-devel/trunk: lib/bind/cua.bind lib/bind/...

2007-01-25 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: bpeng Date: Sun Jan 7 23:41:54 2007 New Revision: 16589 URL: http://www.lyx.org/trac/changeset/16589 Log: Fix bug 3062, bookmark-goto x crashes lyx for invalid bookmark * src/session.C: check validity of temp bookmark * src/lyxfunc.C: check val

Re: lyx installer

2007-01-25 Thread Michael Gerz
Joost Verburg schrieb: I'm not using the Aspell 0.60.x releases because of their broken Windows support. Currently in use is a Windows port of a recent Aspell CVS version. I'll prepare a new pre-compiled Qt4 when there is agreement about the installers. 0.60.5 was released after you grabbed you

Re: r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
Abdel, Jean-Marc, here is my first attempt to incorporate a simple & efficient DEPM into accept/reject change. I think this code will be even smarter if accept/rejectChange() become members of LyXText. Unfortunately, I ran out of time today... Anyway, please provide comments on the existing

Re: lyx installer

2007-01-24 Thread Michael Gerz
Joost Verburg schrieb: Edwin Leuven wrote: lyx is nearing it's first beta for the 1.5 release and we could use some help with the installer. we were hoping you could free some time for this. BTW: Do you have any plans to update lyx-windows-deps-msvc-qt4.zip? There are new versions of both qt

Re: r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
Abdelrazak Younes schrieb: Michael Gerz wrote: Abdelrazak Younes schrieb: Why? These are definitely operations on insettext insets. Because you are just touching the ParagraphList which is a member of LyXText? Hmmm. I may move the code to LyXText but we still need wrappers in Insettext

Re: r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
Abdelrazak Younes schrieb: Why? These are definitely operations on insettext insets. Because you are just touching the ParagraphList which is a member of LyXText? Hmmm. I may move the code to LyXText but we still need wrappers in Insettext. Note that there are also acceptChange() and rejec

Re: [Cvslog] r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
Abdelrazak Younes schrieb: Couldn't you just call deleteEmptyParagraphMechanism() each time you accept or reject a change? No. A change may span multiple paragraphs, including nested insets. Moreover, DEPM also removes duplicate spaces. Do you want me to iterate through the whole selection,

Re: r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
Abdelrazak Younes schrieb: Michael Gerz wrote: Michael Gerz schrieb: Michael, I think you should transfer the paragraph manipulation code in those two functions to LyXText. Why? These are definitely operations on insettext insets. Michael G... you corrupted my code! pars.size() is

Re: r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
Michael Gerz schrieb: Michael, I think you should transfer the paragraph manipulation code in those two functions to LyXText. Why? These are definitely operations on insettext insets. Michael G... you corrupted my code! pars.size() is not fixed in this method. I will revert your

Re: [Cvslog] r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: // FIXME: finally, invoke the DEPM + // This cannot be done here but at a higher calling level + // because we need BufferView::checkDepm(). } I know that cannot do it - otherwise I would called DEPM :-) (And that's why I added a FIXME) Michael

Re: [Cvslog] r16830 - in /lyx-devel/trunk/src: BufferView.C insets/ins...

2007-01-24 Thread Michael Gerz
Abdelrazak Younes schrieb: Michael Gerz wrote: Hi, this patch should fix most problems related to accept/reject-change. I tested it briefly (given the limited time resources). I don't understand where InsetText::acceptChanges() and InsetText::rejectChanges() are used. I only see

Re: r16838 - /lyx-devel/trunk/src/insets/insettext.C

2007-01-24 Thread Michael Gerz
Abdelrazak Younes schrieb: [EMAIL PROTECTED] wrote: Author: younes Date: Wed Jan 24 18:19:56 2007 New Revision: 16838 URL: http://www.lyx.org/trac/changeset/16838 Log: Small formatting and comment cleanup. Modified: lyx-devel/trunk/src/insets/insettext.C Modified: lyx-devel/trunk/src/inse

Re: [Cvslog] r16830 - in /lyx-devel/trunk/src: BufferView.C insets/ins...

2007-01-24 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: * src/lyxtext.h: * src/BufferView.C: * src/text3.C: * src/text.C: merge methods acceptChange() and rejectChange() to acceptOrRejectChange() because they share a lot of tricky code I think you could have kept acceptChange and rejectChanges as trivial wrapper

Re: Lyx-1.5.0svn: more bugs

2007-01-23 Thread Michael Gerz
John McCabe-Dansted schrieb: This email discusses how to replicate 3 bugs: * "Show changes in Output", does not highlight text (LyX isn't running ~/bin/dvipost) - This bug also exists in lyx 1.4 Works for me (latest 1.5.0svn) Create a new file, turn on change tracking. Enter the following fo

Re: [Cvslog] r16830 - in /lyx-devel/trunk/src: BufferView.C insets/ins...

2007-01-23 Thread Michael Gerz
Hi, this patch should fix most problems related to accept/reject-change. I tested it briefly (given the limited time resources). Remaining items on my agenda: - invoke DEPM after accept/reject-change (high prio, take 1 evening) - implement accept/reject-all-changes as an atomic operation (1/2

Re: Converters and encodings

2007-01-23 Thread Michael Gerz
José Matos schrieb: On Tuesday 23 January 2007 7:30:10 pm Michael Gerz wrote: Jose, please wait for a day or two. I have some important CT patches. I am searching for feedback, so no problem, I will wait. :-) I just want to give a subtle sign that we should prepare for a beta

Joost (Re: Mail delivery failed)

2007-01-23 Thread Michael Gerz
Hello, someone else should try to contact him... Michael Mail Delivery System schrieb: This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. The following addresses failed: <[EMAIL PROTECTED]> SM

Re: Converters and encodings

2007-01-23 Thread Michael Gerz
Enrico Forestieri schrieb: [Personal note: Trying to understand what needs to be done before declaring a freeze period before beta release.] I hope this is not to late ;-) Jose, please wait for a day or two. I have some important CT patches. Michael

Re: Do we have to have both Installer and LyxWinInstaller?

2007-01-23 Thread Michael Gerz
Uwe Stöhr schrieb: > But what are the differences between the two installers? My impression > is that Joost's installer is techniquely advanced, and Uwe's installer > takes care of lot of issues of third-party applications. I listed the differences here: http://wiki.lyx.org/Windows/LyXWinInstall

Re: Regarding Installer and LyxWinInstaller: Add

2007-01-23 Thread Michael Gerz
Andreas K. schrieb: Using the latest LyX150svn from 15-01-2007 for Windows made available by Uwe, I noted that he had included JabRef as an external software installed together with LyX. I think it is a really good idea, and it should be included in the official installer too. Would it be pos

Re: Loading 1.5 file with LyX 1.4.4.

2007-01-23 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: When I do that, I stumble on this message: Alert::error(_("Conversion script failed"), bformat(_("%1$s is from an earlier version" " of LyX, but the lyx2lyx script" " failed t

Re: Do we have to have both Installer and LyxWinInstaller?

2007-01-23 Thread Michael Gerz
Bo Peng schrieb: Joost and Uwe, Could you please try to merge the two windows installers? It is definitely confusing to have two installers so please at least put a README file explaining the differences between them. If you guys can not reach an agreement on some issues, please bring them up an

Re: getting rid of lyx.bat - Aiksaurus problem

2007-01-23 Thread Michael Gerz
Uwe Stöhr schrieb: Now I implemented in the installer that Aiksaurus is registered as standalone program. The installer sets the needed environment variable. What do you mean by "standalone" program? Aiksaurus is used as a library and it should stay as such! Michael

BufferParams & Font Settings

2007-01-23 Thread Michael Gerz
Hello, why do we need the buffer parameters if we want to move some characters from one paragraph to another? I see that it has to do with font settings but isn't there a simpler way? The fact that we need the buffer parameters for moving item means that I have to pass them through all accep

Re: [Cvslog] r16823 - in /lyx-devel/trunk/src: frontends/Alert.C front...

2007-01-23 Thread Michael Gerz
Abdelrazak Younes schrieb: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: This would be a regression. Abdelrazak> batch mode is only for export up to now. Here there is no Abdelrazak> regression as the export function don't need any dialog. So whe

Re: text2lyx does not link

2007-01-23 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> Abdel, due to your recent changes, tex2lyx does no longer Michael> link. Great! Now we are going to make it a full blown qt app. To be frank, everybody has been drea

text2lyx does not link

2007-01-23 Thread Michael Gerz
Abdel, due to your recent changes, tex2lyx does no longer link. Michael

Re: [Cvslog] r16801 - /lyx-devel/trunk/src/text.C

2007-01-22 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: baum Date: Sun Jan 21 22:52:01 2007 New Revision: 16801 URL: http://www.lyx.org/trac/changeset/16801 Log: Compile fix. Michael, I guess that you need to retest this code, since the old one did obviously not do what you intended. Oh, what a shame! Oh, what a

Re: [Cvslog] r16799 - /lyx-devel/trunk/src/text.C

2007-01-21 Thread Michael Gerz
Hello everybody, this patch should cure all crashes related to accepting a change. I will provide a similar patch for reject-change tomorrow (hopefully). One thing that I am not very happy about is the invocation of DEPM, because the latter makes use of cursors, calls the undo mechanism, etc.

Re: Problem stripLeadingSpaces()

2007-01-21 Thread Michael Gerz
Abdelrazak Younes schrieb: Right now, stripLeadingSpaces() returns the number of _physically_ deleted spaces. I can change this to return the number of physically and logically characters. Yes, I guess we should do that. Ok, the patch will be committed in a few minutes. Michael

Re: Problem stripLeadingSpaces()

2007-01-21 Thread Michael Gerz
Abdelrazak Younes schrieb: OK, IIUC, then you will have two deleted space then, right? Again, IIUC, the paragraph contents should still contain the two spaces but isDeleted(0) and (1) would return true, right? Yes & Yes. If yes, then as I said, there is a problem even before the screen update

Re: [Cvslog] r16795 - in /lyx-devel/trunk: lib/ui/stdtoolbars.inc po/b...

2007-01-21 Thread Michael Gerz
;[EMAIL PROTECTED]>\n" "Language-Team: Danish <[EMAIL PROTECTED]>\n" @@ -9213,7 +9213,7 @@ #: lib/ui/stdtoolbars.inc:166 #, fuzzy -msgid "View/Update Document" +msgid "View/Update" msgstr "Gem dokument" #: lib/ui/stdtoolbars.inc:167 Modifi

Re: [Cvslog] r16792 - /lyx-devel/trunk/lib/ui/stdtoolbars.inc

2007-01-21 Thread Michael Gerz
Uwe, I made a couple of minor change for the sake of consistency. Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sun Jan 21 11:20:39 2007 New Revision: 16792 URL: http://www.lyx.org/trac/changeset/16792 Log: * lib/ui/stdtoolbars.inc: fix typo; use Capitals in toolbar name; remov

Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-21 Thread Michael Gerz
Angus Leeming schrieb: - docstring const abst = _("Abstract: "); + docstring const abst = _("Abstract") + from_ascii(": "); Not all languages will use ':' in the same way as the English and in RtL languages the thing won't go to the right of the word either... Hpmf $&§#!

log messages missing

2007-01-21 Thread Michael Gerz
Lars, Uwe has committed two patches yesterday but I didn't receive corresponding [EMAIL PROTECTED] emails. I guess Uwe is not listed in one of the server scripts. Could you please check? Michael

Re: [Cvslog] r16788 - /lyx-devel/trunk/src/MenuBackend.C

2007-01-21 Thread Michael Gerz
Again, FYI. Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 19:38:06 2007 New Revision: 16788 URL: http://www.lyx.org/trac/changeset/16788 Log: * src/MenuBackend.C: Import plain text: align labels with menu entries in stdmenus.inc Modified: lyx-devel/tr

Re: [Cvslog] r16787 - /lyx-devel/trunk/lib/ui/classic.ui

2007-01-21 Thread Michael Gerz
FYI. Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 19:35:27 2007 New Revision: 16787 URL: http://www.lyx.org/trac/changeset/16787 Log: * lib/ui/classic.ui: "Plain Text, Join Lines" - align with menu entries in stdmenus.ui Modified: lyx-devel/trunk/lib/

Re: [Cvslog] r16785 - /lyx-devel/trunk/src/paragraph_pimpl.C

2007-01-20 Thread Michael Gerz
Sure? Looks like 4. Michael [EMAIL PROTECTED] schrieb: Author: baum Date: Sat Jan 20 18:21:52 2007 New Revision: 16785 URL: http://www.lyx.org/trac/changeset/16785 Log: count correctly Modified: lyx-devel/trunk/src/paragraph_pimpl.C Modified: lyx-devel/trunk/src/paragraph_pimpl.C URL:

Re: Problem stripLeadingSpaces()

2007-01-20 Thread Michael Gerz
Abdelrazak Younes schrieb: Michael Gerz wrote: Abdelrazak Younes schrieb: Michael Gerz wrote: Abdelrazak Younes schrieb: I don't understand, why the space in the first line should be deleted? means a space that was marked as deleted. Use the attached lyx file. Press return after &

Re: [Cvslog] r16783 - /lyx-devel/trunk/src/text.C

2007-01-20 Thread Michael Gerz
Next bug fix... this time regarding change tracking. Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 17:59:13 2007 New Revision: 16783 URL: http://www.lyx.org/trac/changeset/16783 Log: * src/text.C: move forward when logically deleting character (previously

Re: [Cvslog] r16782 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Michael Gerz
Up to now, max line length hasn't really been max line length. This plain text output code is just scary Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 17:38:58 2007 New Revision: 16782 URL: http://www.lyx.org/trac/changeset/16782 Log: * src/output_plaintext.C

Re: [Cvslog] r16781 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Michael Gerz
Another bug in plain text output. Has anybody ever used this feature? (This is not the last commit!) Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 17:25:52 2007 New Revision: 16781 URL: http://www.lyx.org/trac/changeset/16781 Log: * src/output_plaintext.C: remove

Re: [Cvslog] r16780 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Michael Gerz
The implications of this fix are marginal. I don't see any difference in a typical document. Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 17:14:39 2007 New Revision: 16780 URL: http://www.lyx.org/trac/changeset/16780 Log: * src/output_plaintext.C: save two *.po ent

Re: [Cvslog] r16779 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-20 Thread Michael Gerz
The plain text bug fixing continues... Michael [EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 16:35:39 2007 New Revision: 16779 URL: http://www.lyx.org/trac/changeset/16779 Log: * src/output_plaintext.C: fix line breaks in plain text output; add a line break at t

Re: [Cvslog] r16778 - /lyx-devel/trunk/src/paragraph_pimpl.C

2007-01-20 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: schmitt Date: Sat Jan 20 16:07:20 2007 New Revision: 16778 URL: http://www.lyx.org/trac/changeset/16778 Log: * src/paragraph_pimpl.C: check for linelen == 0 in LaTeX output; otherwise, every word in printed on a separate line Modified: lyx-

Mac problems resolved?

2007-01-20 Thread Michael Gerz
Bennett, Status.15x is full of Mac/performance-specific problems. Could you please tell me, whether some of them have been resolved in the mean-time? Thanks, Michael

Bugzilla broken

2007-01-20 Thread Michael Gerz
Lars, I get some error message (security warning) when adding a new bug to our bugzilla system. Something is wrong with bugzilla's post-bug script. Have you changed the perl/python/whatever settings or made an update to them? Please have a look. Thanks in advance! Michael

Re: [Cvslog] r16765 - /lyx-devel/trunk/src/output_plaintext.C

2007-01-19 Thread Michael Gerz
I can't believe it! Plain text output was seriously broken for ages without anyone noticing it. And then Jean-Marc comes back and he fixes exactly the same bug that I fixed two days ago but failed to commit due to time constraints... Michael PS: I think the fix is not complete. I will provid

Re: Another small 1.5 bug

2007-01-19 Thread Michael Gerz
killermike schrieb: If I start a new document and try to 'save as...' the file save dialogue opens up in my home dir (/home/killermike/). The filter for .lyx files is set by default. This means that no directories are shown. Selecting *.* as the filter and then selecting *.lyx again shows .lyx

Re: More 1.5.0svn bugs

2007-01-18 Thread Michael Gerz
Hi Killermike, When I launch the application from the command line, it fills the terminal with screenfulls of: Locale en_GB could not be set Also, there are no tooltips when I hover over the toolbars. A given icon will highlight when hovered over but there is no tooltip. I don't seem to be

Re: 3 bugs left before the beta

2007-01-18 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: As I have told before I agree, I have been working with 1.5.0 and I am quite happy with it. More yet than I was with 1.4.0 at the same stage, but then it may be my memory playing tricks on me. ;-) I will leave tomorrow (early) morning Dublin, and I will be back to

Re: 6 bugs left before a beta can happen!

2007-01-17 Thread Michael Gerz
Edwin Leuven schrieb: what is the status wrt change tracking? (merging a change that involves a par break crashes lyx here...) Folks, Breaking news: Unless I will be hit by a truck, change tracking will be (more or less) ready by the end of the week!!! I also have some important fixes to p

Re: Plain text import & export

2007-01-15 Thread Michael Gerz
Hi Georg, this is strange - I can read your answer at gmane but I didn't receive your email directly (via internet provider) Ok, if we don't fix the LFUNs now, we will never do it. I will document the changes somewhere... Michael

Plain text import & export

2007-01-15 Thread Michael Gerz
Hi, AFAICS, we no longer read and write ASCII files but UTF-8 files. Therefore, I think it is time to rename the corresponding lyxrc entries, LFUNs, and C++ methods (see attached patch). Ok to commit? (If yes, I will update the documentation accordingly afterwards). Michael Index: src/LyXA

Re: Bugzilla cleanup - results - conclusions

2007-01-14 Thread Michael Gerz
Uwe Stöhr schrieb: We either introduced in LyX 1.4.0 much more bugs than in previous releases or our user base has grown and so we get more bug reports. I assume the latter is the case. 1.4.0 wasn't ready when it was released. Many bugs in 1.4.X cannot even be fixed today because the code base

Re: Last step in compiling with Scons - location of .exe file?

2007-01-14 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Unfortunately no success quite yet. The file LyXWinBuildDLLs.zip doesn't contain all the required DLLs. It contains: Aiksaurus.dll aspell.dll iconv.dll intl.dll but I'm missing 'QtCore4.dll' and 'QtGui4.dll'. So I searched for them and found

Re: Last step in compiling with Scons - location of .exe file?

2007-01-14 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: The last step according to INSTALL.Win32 is the 'First start of LyX' and the instructions are as follows: To start the just compiled lyx.exe, it is necessary to copy the following files to the folder where the just compiled "lyx.exe" is: Aiksaurus.dll

Re: Compiling with Scons - where is the command prompt?

2007-01-14 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: On Sun, 14 Jan 2007, [EMAIL PROTECTED] wrote: I forgot... if I tried to execute 'build_msvc.bat' from for instance c:\lyx-devel\, I got an error message about being unable to change to ..\..\scons\. Apparently the script assumes it starts in the directory developmen

Re: Problem stripLeadingSpaces()

2007-01-14 Thread Michael Gerz
Abdelrazak Younes schrieb: Yes, this is exactly it. The problem is that the first (and unique) row of the first ParagraphMetrics has one more character than what is in the Paragraph. The Paragraph content does not seem to reflect the deleted characters. In the following loop, the position of t

Extended-Insets.lyx

2007-01-14 Thread Michael Gerz
Uwe, I am sorry but I have to step on your toes :-( Your recent Extended-Inset commit has some minor problems: - Extended-Insets.lyx violates our document naming conventions. (I renamed it to ExtendedInsets.lyx) - es_ExtendedInsets.lyx was missing in some build scripts - Menu entry "Extended-

Re: Compiling with Scons - where is the command prompt?

2007-01-14 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: I'll probably switch to CMAKE, but I thought I'd follow the instructions in INSTALL.Win32 to see if it works first. I'm now at step 7 (Compile) which says: From MS Visual Studio command prompt (not the regular cmd.exe), run development\Win32\packaging

Re: Problem stripLeadingSpaces()

2007-01-14 Thread Michael Gerz
Abdelrazak Younes schrieb: Michael Gerz wrote: Abdelrazak Younes schrieb: I don't understand, why the space in the first line should be deleted? means a space that was marked as deleted. Use the attached lyx file. Press return after "hello". The leading spaces are marked

Re: Problem stripLeadingSpaces()

2007-01-14 Thread Michael Gerz
Abdelrazak Younes schrieb: I don't understand, why the space in the first line should be deleted? means a space that was marked as deleted. Use the attached lyx file. Press return after "hello". The leading spaces are marked as deleted but the screen is not updated. Michael strip.lyx Des

Re: [PATCH] put Gui language definition in lyxrc

2007-01-14 Thread Michael Gerz
Lars Gullik Bjønnes schrieb: Yes. I think this will result in surprising behaviour. 1. Set languag inside lyx to "swedish" (why not?) - save and exit 2. run lyx with LANG=no_NO ./lyx - get a nice swedish lyx I think that the ui language should not be settable from inside lyx. Well, w

Re: FS Encoding error

2007-01-14 Thread Michael Gerz
Enrico Forestieri schrieb: On Sat, Jan 13, 2007 at 07:25:51PM +0100, Michael Gerz wrote: this patch fixes the encoding problem in the same way as Georg's patch. However, I also fixed a potential problem that may occur if no backup can be made successfully and I used proper variable

Re: [PATCH] put Gui language definition in lyxrc

2007-01-14 Thread Michael Gerz
Abdelrazak Younes schrieb: Hello, The attached patch allow to set the language used in the GUI via the the lyxrc mechanism. If the new 'gui_language' setting is empty or non present, the language will be taken from the environment variables as usual. With this patch it is now possible the G

Problem stripLeadingSpaces()

2007-01-14 Thread Michael Gerz
Hi, I rethought the logic of stripLeadingSpaces() and came to the conclusion that it is not a good idea to remove the spaces in change tracking mode: imagine that your co-author inserts a par break that you don't like. If you revert his par break (revert = reject change, not undo!), you would

Re: FS Encoding error

2007-01-14 Thread Michael Gerz
Michael Gerz schrieb: Hi, this patch fixes the encoding problem in the same way as Georg's patch. However, I also fixed a potential problem that may occur if no backup can be made successfully and I used proper variable names. Folks, could someone please check this on Linux? A s

accept/reject all changes & undo

2007-01-13 Thread Michael Gerz
Hi, invoking "accept/reject all changes" accidentally can be a nightmare, because you have to run "undo" as often as there are different changes in the document. The technical reason for this is that these LFUNs iteratively look for the next change in the document and accept/reject each of t

Re: FS Encoding error

2007-01-13 Thread Michael Gerz
fine, too (maybe someone who uses French accents in path names?). Michael Georg Baum schrieb: Michael Gerz wrote: Georg, Enrico, something is wrong with the file encoding in Buffer::save(). If I save changes to an (existing) file which is located in a path containing German Umlauts (Wi

Re: FS Encoding error

2007-01-13 Thread Michael Gerz
Georg, I am working on an alternative patch right now that fixes this and another bug (regarding backup failure). Give me some time to polish it. Michael Georg Baum schrieb: Michael Gerz wrote: Georg, Enrico, something is wrong with the file encoding in Buffer::save(). If I save

FS Encoding error

2007-01-13 Thread Michael Gerz
Georg, Enrico, something is wrong with the file encoding in Buffer::save(). If I save changes to an (existing) file which is located in a path containing German Umlauts (Windows), an exception is thrown. The exception message isn't very useful. I says that the copy operation failed :-( The v

Re: [Cvslog] r16658 - /lyx-devel/trunk/src/counters.C

2007-01-11 Thread Michael Gerz
Abdel, be careful with these micro-optimization. Eventually, you will shoot yourself in the foot! Are you sure that these optimization are really that beneficial? @@ -277,29 +277,32 @@ docstring Counters::labelItem(docstring const & ctr, docstring const & numb

Re: "Show Changes in Output" causing invalid LaTeX in LyX 1.4.4svn

2007-01-11 Thread Michael Gerz
John McCabe-Dansted schrieb: On 1/11/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Yes, please. However, change tracking is seriously broken in 1.4.X. It would be nice if you checked 1.5.0svn instead. I have rewritten major parts of the code (attention: accept/reject-change is still partly

AW: Re: Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-09 Thread michael . gerz
>> I agree that a stack of bookmarks has limited use, because the poor user has >no idea of what boomark #5 actually is at a given time (a moving target). > >That is why I display filename of a bookmark. Previously, the poor >user has to face ice-cold bookmark 1/2/3/4/5. Well, I guess many people

AW: Re: SVN changeset 16589: remove shortcuts to bookmark-save 2/3/4/5

2007-01-09 Thread michael . gerz
>I do know that the new bookmark code has plenty of advantages. What >this does not tell me is why bookmarks have to be a stack instead of a >vector. > >Bo> I can not see a way to implement dynamic bookmark menu items >Bo> without this stack (regression). > >So tell us, why? I agree that a stack

AW: Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread michael . gerz
>> - Copy some text in the editor of your choice. >> - If you paste "Plain text as Lines", each line in the clipboard >> becomes a separate paragraph in LyX >> - If you paste "Plain text as Paragraphs", all lines in the clipboard >> are put in the _same_ paragraph in LyX. >> >> => This doesn'

Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread Michael Gerz
Bo Peng schrieb: why do you use the term "Paste" for the last two entries but not for the first two entries. This looks inconsistent. After replacing clipboard with plain text, I somehow feel 'paste selection' emphasizes what these menu items do because there is no contrast between clipboard an

Re: slow opening of docs

2007-01-08 Thread Michael Gerz
Edwin, is there any need to further optimize things? I still see some change tracking-related stuff on top of the reports but I wonder whether it really matters... Michael

Re: [Cvslog] r16590 - /lyx-devel/trunk/lib/ui/stdmenus.inc

2007-01-08 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: bpeng Date: Sun Jan 7 23:52:04 2007 New Revision: 16590 URL: http://www.lyx.org/trac/changeset/16590 Log: lib/ui/stdmenus.inc: change 'Clipboard as xxx' to 'Plain Text as xxx'. I still think we should remove 'Selection as xxx'. Modified: lyx-devel/trunk/

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-07 Thread Michael Gerz
Bo Peng schrieb: It is clear now. :-) I guess there is no need to change the lfuns since they are needed. I see: Bo: + Michael: + Edwin: + Georg: -, but do not have a strong opinion Michael, will you change your mind? I support any solution that is acceptable to Georg (because he wrote the co

Re: slow opening of docs

2007-01-07 Thread Michael Gerz
Edwin Leuven schrieb: Michael Gerz wrote: Edwin, could you please check whether the attached patch saves any time in lyx::Changes::lookup(int) const and lyx::Changes::merge() during opening/saving a file? this is open (save below): Each sample counts as 0.01 seconds. % cumulative

Re: slow opening of docs

2007-01-07 Thread Michael Gerz
Edwin, could you please check whether the attached patch saves any time in lyx::Changes::lookup(int) const and lyx::Changes::merge() during opening/saving a file? Michael Index: changes.C === --- changes.C (Revision 16573) +++

Re: slow opening of docs

2007-01-07 Thread Michael Gerz
Edwin Leuven schrieb: Michael Gerz wrote: was wondering why lyx::Changes::set(lyx::Change const&, int, int) is called... Every time you insert a character, the corresponding change has to be set (even if it is unchanged, because it may be inserted in a region of deleted/inserted text).

Re: [Cvslog] r16572 - in /lyx-devel/trunk/src: BufferView.C CutAndPast...

2007-01-07 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: baum Date: Sun Jan 7 15:44:44 2007 New Revision: 16572 Modified: lyx-devel/trunk/src/cursor.C URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/cursor.C?rev=16572 == --- lyx-devel/

Re: slow opening of docs

2007-01-07 Thread Michael Gerz
Edwin Leuven schrieb: the following is the profile i get when opening the user guide: (full profile here: http://leuven.ecodip.net/lyx/profile.zip) was wondering why lyx::Changes::set(lyx::Change const&, int, int) is called... Flat profile: Each sample counts as 0.01 seconds. % cumulativ

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-07 Thread Michael Gerz
Georg Baum schrieb: I agree that the interface should be kept clean, and we should definitely not introduce any checkbox, I agree. Let's not make things more complicated than necessary. in any case we wouldn't want to clutter the interface with it and i suggest to get rid of these menu ent

Re: We are making progress!

2007-01-07 Thread Michael Gerz
Peter Kümmel schrieb: Michael Gerz wrote: Cool! Only 533 bugs left :-) It depends: If there were 1500 bugs yesterday then it is indeed a progress. :) Oh, we are indeed making progress. We were able to close 23 bugs in the last 7 days! Personally, I am quite happy with the way

We are making progress!

2007-01-07 Thread Michael Gerz
Cool! Only 533 bugs left :-) http://tinyurl.com/y7hdzc (= unconfirmed/new/assigned/reopened + no enhancement + no 1.6.0 target + not 'fixedintrunk') Michael (who is desperately & hopelessly struggling with cursors, DEPM, par breaks, etc. in acceptChanges()) (and who may ask for assista

Re: [PATCH] Gives a sane behaviour to the scrollbar.

2007-01-07 Thread Michael Gerz
Abdelrazak Younes schrieb: Abdelrazak Younes wrote: Hello, I had an idea: if clicking in the scrollbar should behave like PageDown or PageUp, why not using the same LFUNs as the one used by the keyboard action? This patch is doing just that ;-). It is so simple that I wonder why it has not

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-07 Thread Michael Gerz
Bo Peng schrieb: - paste - Paste Clipboard as Lines - Paste Clipboard as ParagraphsSelection as Paragraphs - Paste Selection as Lines - Paste Selection as Paragraphs I propose that we remove "paste special -> paste selection as lines" and "paste special -> paste selection as paragraph", du

Re: unreachable code

2007-01-07 Thread Michael Gerz
Michael Gerz schrieb: Peter Kümmel schrieb: bool Paragraph::hfillExpansion(Row const & row, pos_type pos) const { if (!isHfill(pos)) return false; // at the end of a row it does not count // unless another hfill exists on the line if (pos >= row.endpos()) {

[Fwd: [Cvslog] r16564 - /lyx-devel/trunk/development/Win32/packaging/bui...]

2007-01-07 Thread Michael Gerz
Uwe, Win32 developers, I added a new build script. Michael --- Begin Message --- Author: schmitt Date: Sun Jan 7 10:53:04 2007 New Revision: 16564 URL: http://www.lyx.org/trac/changeset/16564 Log: * development/Win32/packaging/build_msvs_debug.bat: add new build script for debug mode & msvs p

Re: unreachable code

2007-01-06 Thread Michael Gerz
Peter Kümmel schrieb: bool Paragraph::hfillExpansion(Row const & row, pos_type pos) const { if (!isHfill(pos)) return false; // at the end of a row it does not count // unless another hfill exists on the line if (pos >= row.endpos()) {

Re: unreachable code

2007-01-06 Thread Michael Gerz
Peter Kümmel schrieb: bool Paragraph::hfillExpansion(Row const & row, pos_type pos) const { if (!isHfill(pos)) return false; // at the end of a row it does not count // unless another hfill exists on the line if (pos >= row.endpos()) {

MS Word Export

2007-01-06 Thread Michael Gerz
Hartmut Haase pointed out that File->Export->MS Word (HTML) is a bit confusing, because we do not generate a *.doc/*.rtf file. He suggests changing the item into File->Export->HTML (MS Word) Since he is the German doc translator and a nice guy, I am going to change the menu iterm :-) Mi

Re: [Cvslog] r16516 - /lyx-devel/trunk/lib/ui/stdmenus.ui

2007-01-06 Thread Michael Gerz
Abdelrazak Younes schrieb: Georg Baum wrote: It gives a hint what "as paragraph" means. I think we should keep it (it is in a submenu that is rarely used), but have no strong opinion. I also think that we should move the shortcut C-M-v from "primary-selection-paste" to "clipboard-paste paragra

Re: [Cvslog] r16543 - in /lyx-devel/trunk/src: BufferView.C ParagraphM...

2007-01-06 Thread Michael Gerz
Abdelrazak Younes schrieb: Yes because a position change will trigger a full metrics change anyway. I even think that this crc signature is too much and not needed. Ideally, we should just verify beginning and end of row and verify that the Paragraph contents has not changed. I agree. I never u

<    1   2   3   4   5   6   7   8   9   10   >