On Sat, 10 Feb 2024 17:24:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Mon, 12 Feb 2024 16:15:03 GMT, Andy Goryachev wrote:
> It looks like the original intent was to have one monospaced (Monaco) and one
> proportional (Tahoma) font. Perhaps we could come up with a list of
> candidates and pick a font to use based on availability?
These would all have to be
On Sat, 10 Feb 2024 17:24:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Mon, 12 Feb 2024 10:00:57 GMT, Karthik P K wrote:
> I ran the tests in my Mac system with macOS 14.3 and found 2 tests are
> failing with following error:
I see the same two failures on our CI macOS 13.x and macOS 14.x test machines.
On our Linux systems, all tests are skipped (meaning
On Sat, 10 Feb 2024 17:24:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 17:33:04 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Sat, 10 Feb 2024 14:40:45 GMT, Kevin Rushforth wrote:
>>> And on Linux I get similar failures to my Windows system due to no Monaco
>>> font.
>>
>> Was the Tahoma font available there (you can see from the `TextLayoutTest >
>> fail()` test) ?
>>
>> If so, I could rewrite most of the tests
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Sat, 10 Feb 2024 03:58:24 GMT, John Hendrikx wrote:
> > And on Linux I get similar failures to my Windows system due to no Monaco
> > font.
>
> Was the Tahoma font available there (you can see from the `TextLayoutTest >
> fail()` test) ?
It doesn't look like it:
On Sat, 10 Feb 2024 00:40:41 GMT, Kevin Rushforth wrote:
> And on Linux I get similar failures to my Windows system due to no Monaco
> font.
Was the Tahoma font available there (you can see from the `TextLayoutTest >
fail()` test) ?
If so, I could rewrite most of the tests to use the Tahoma
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Sat, 10 Feb 2024 00:32:18 GMT, John Hendrikx wrote:
> That's interesting, your local Windows 11 system does not have the Monaco
> font (it is falling back to System Regular it seems). I guess I installed it
> on mine at some point.
Probably so. I just verified that I don't have Monaco on
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Sat, 10 Feb 2024 00:16:33 GMT, John Hendrikx wrote:
> Also I think the `TextLayoutTest` isn't really headful, it never displays
> anything (no stages, uses no `Node`s), but it does need a real `PrismFont` --
> it may be difficult to get that to work though
Yeah, without a proper headless
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Sat, 10 Feb 2024 00:10:33 GMT, Kevin Rushforth wrote:
> That's intentional. We can only run headless tests in the GHA build. We do
> the same thing in our (Oracle's) CI build system.
I was already pleasantly surprised that the three environments all had the
correct Monaco and Tahoma
On Sat, 10 Feb 2024 00:02:38 GMT, John Hendrikx wrote:
> Okay, so I'm getting the impression that the system tests are not run during
> the build (ie. `TextLayoutTest`). Is that an oversight or intended, or is my
> test somehow not qualifying?
>
> clarification: I meant during the Github CI
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 23:37:16 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Fri, 9 Feb 2024 23:37:16 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 22:44:07 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 21:46:46 GMT, John Hendrikx wrote:
>> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line
>> 414:
>>
>>> 412: 12.0f, 4.001953f
>>> 413: ));
>>> 414:
>>
>> should we add tests for leading/trailing tabs and milti-line strings, and
On Fri, 9 Feb 2024 21:51:15 GMT, John Hendrikx wrote:
> I think it is easy enough for a user to sanitize the strings they deliver a
> bit, while it would be impossible for the user to do so at the soft wrap
> locations.
I agree.
-
PR Comment:
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 17:48:09 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Fri, 9 Feb 2024 21:36:03 GMT, John Hendrikx wrote:
>> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line
>> 58:
>>
>>> 56: private final PrismTextLayout layout = new PrismTextLayout();
>>> 57: private final PGFont font = (PGFont)
>>>
On Fri, 9 Feb 2024 17:38:16 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Fri, 9 Feb 2024 17:36:04 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Thu, 8 Feb 2024 16:06:39 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>>
On Fri, 9 Feb 2024 01:33:20 GMT, John Hendrikx wrote:
> My theory is now that how the wrap width of the `Text` node is updated is not
> entirely legal (I posted on the mailinglist to see if anyone can remember how
> this is supposed to work when you update a value (that may cause layout
>
On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Wed, 7 Feb 2024 23:31:43 GMT, Andy Goryachev wrote:
> > so I think that the 2nd line is incorrect.
>
> interesting: I would think the second line is correct. Could you check what a
> browser does in this situation?
Tested with `pre-wrap` which I think is the closest match there is for
On Wed, 7 Feb 2024 23:28:12 GMT, John Hendrikx wrote:
> so I think that the 2nd line is incorrect.
interesting: I would think the second line is correct. Could you check what a
browser does in this situation?
-
PR Comment:
On Wed, 7 Feb 2024 15:57:35 GMT, John Hendrikx wrote:
>> one thing: you may sync up with the latest master branch, that's the
>> configuration I am testing.
>
> @andy-goryachev-oracle
>
> I'm not quite seeing what you are seeing. Here is a screenshots of `LOGICAL`
> setting with the text
On Wed, 7 Feb 2024 15:57:35 GMT, John Hendrikx wrote:
>> one thing: you may sync up with the latest master branch, that's the
>> configuration I am testing.
>
> @andy-goryachev-oracle
>
> I'm not quite seeing what you are seeing. Here is a screenshots of `LOGICAL`
> setting with the text
On Tue, 6 Feb 2024 23:32:25 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix test comment
>
> one thing: you may sync up with the latest master branch, that's the
> configuration I am
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Tue, 6 Feb 2024 21:38:41 GMT, Andy Goryachev wrote:
> > specific to strike though
>
> I don't think so. I can turn it off and nothing changes, same for underline.
> I am not sure why it all suddenly started to fail - I did a clean build
> twice...
Can you see if the new `TextLayoutTest`
On Tue, 6 Feb 2024 21:35:43 GMT, John Hendrikx wrote:
> specific to strike though
I don't think so. I can turn it off and nothing changes, same for underline.
I am not sure why it all suddenly started to fail - I did a clean build twice...
-
PR Comment:
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Tue, 30 Jan 2024 00:35:24 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bug which confused char index with glyph index
>
> I think that it may be wise to do some clean-up of the code
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Mon, 29 Jan 2024 16:35:05 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move test that needs QuantumToolkit to system tests
>
>
On Tue, 30 Jan 2024 00:12:52 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Mon, 29 Jan 2024 16:22:56 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move test that needs QuantumToolkit to system tests
>
> MonkeyTester won't start:
>
>
> Exception in thread
On Mon, 29 Jan 2024 14:38:20 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Mon, 29 Jan 2024 16:10:01 GMT, Andy Goryachev wrote:
> > ancient test case that was disabled (see
> > https://bugs.openjdk.org/browse/JDK-8087615).
>
> should the old ticket be added to this PR?
If this fixes all tests that are `@Ignore`d with this old bug ID, then yes. I
still see a
On Mon, 29 Jan 2024 14:38:20 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Sun, 28 Jan 2024 23:30:56 GMT, John Hendrikx wrote:
> ancient test case that was disabled (see
> https://bugs.openjdk.org/browse/JDK-8087615).
should the old ticket be added to this PR?
-
PR Comment: https://git.openjdk.org/jfx/pull/1236#issuecomment-1915034433
On Mon, 29 Jan 2024 14:38:20 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Mon, 29 Jan 2024 15:40:28 GMT, Andy Goryachev wrote:
> > The justify calculation only looks at regular white spaces (0x20), but I
> > think it should really be looking at all types...
>
> maybe extract that into a separate issue (and link this one?)
>
> Are there any other places where we
On Sat, 27 Jan 2024 08:33:47 GMT, John Hendrikx wrote:
> The justify calculation only looks at regular white spaces (0x20), but I
> think it should really be looking at all types...
maybe extract that into a separate issue (and link this one?)
Are there any other places where we should be
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Sun, 28 Jan 2024 23:29:49 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Fri, 26 Jan 2024 18:45:29 GMT, Andy Goryachev wrote:
> I see some weird behavior with the text string copied from
https://github.com/openjdk/jfx/pull/1236#issuecomment-1910538102
@andy-goryachev-oracle I had two checks for white space in the
`computeTrailingSpaceWidth` code but only fixed
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Fri, 26 Jan 2024 18:51:30 GMT, Andy Goryachev wrote:
> Also, the description of this PR mentions two other tickets
>
> https://bugs.openjdk.org/browse/JDK-8145496
> https://bugs.openjdk.org/browse/JDK-8129014
>
> are these duplicates or do they describe similar, but legally different
>
On Fri, 26 Jan 2024 01:27:50 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 26 Jan 2024 01:25:14 GMT, John Hendrikx wrote:
>> thank you @hjohn ! this PR has been out for a while, could you sync it up
>> with the master please?
>
> @andy-goryachev-oracle thanks for testing this, what you discovered was a bug
> in the `computeTrailingWhiteSpace` code that went
On Fri, 26 Jan 2024 01:27:50 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Thu, 25 Jan 2024 23:44:06 GMT, Andy Goryachev wrote:
>>> Regarding other whitespace characters. Using \u2003 em space, pasting the
>>> following text
>>
>> I think we can use `Character.isWhitespace`. For the most part it aligns
>> with "is this a breaking space". It's not perfect, but we
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Thu, 25 Jan 2024 23:23:42 GMT, John Hendrikx wrote:
>> Regarding other whitespace characters.
>> Using \u2003 em space, pasting the following text
>>
>> AAABBBCCC
>>
>>
>> the results as seen with MS Word 16.78 (23100802) on macOS 14.2.1 indicate
>> that it treats em space as
On Thu, 25 Jan 2024 16:18:37 GMT, Andy Goryachev wrote:
> Regarding other whitespace characters. Using \u2003 em space, pasting the
> following text
I think we can use `Character.isWhitespace`. For the most part it aligns with
"is this a breaking space". It's not perfect, but we can do more
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Mon, 30 Oct 2023 19:00:08 GMT, Andy Goryachev wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Mon, 30 Oct 2023 19:09:17 GMT, Michael Strauß wrote:
> It seems there's no browser equivalent to your proposed behavior, either.
> pre-line does not preserve spaces, but your proposal does; it merely doesn't
> preserve end-of-line spaces.
Yeah, I missed that somehow. `pre-line` looks
On Mon, 30 Oct 2023 08:52:27 GMT, John Hendrikx wrote:
> > I've tested `AAA BBB CCC` in Chrome, and the text is rendered pretty much
> > exactly as your "before" version:
>
> For the current rendering that JavaFX does, there is no browser equivalent,
> although `pre-wrap` comes close, JavaFX
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Mon, 30 Oct 2023 05:34:54 GMT, Michael Strauß wrote:
> I've tested `AAA BBB CCC` in Chrome, and the text is rendered pretty much
> exactly as your "before" version:
For the current rendering that JavaFX does, there is no browser equivalent,
although `pre-wrap` comes close, JavaFX will take
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that
On Sat, 23 Sep 2023 14:36:09 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
>> line 965:
>>
>>> 963:
>>> 964: for (int i = length + startOffset - 1; i >= startOffset; i--) {
>>> 965: if (chars[i] != ' ') {
>>
>>
On Thu, 14 Sep 2023 22:41:20 GMT, Andy Goryachev wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
1 - 100 of 104 matches
Mail list logo
