Hi Vu,
Thanks for your questions and comment. I answers the questions below:
1) I will update the comment.
2) I haven't thought of this case yet. I will test and update later.
3) Client just added to client_down_list_head when client hasn't been
initialized and does not exists in database client
Hi Thuan,
Thanks for your time to review. I will update solution according to your
idea.
Best Regards,
ThienHuynh
-Original Message-
From: Tran Thuan
Sent: Tuesday, October 8, 2019 10:14 AM
To: 'thien.m.huynh' ;
vu.m.ngu...@dektech.com.au; minh.c...@dektech.com.au
Cc: opensaf-devel@lis
Hi Vu,
Thanks for your time to review the patch.
Best Regards,
ThienHuynh
-Original Message-
From: Nguyen Minh Vu
Sent: Wednesday, October 9, 2019 11:15 AM
To: thien.m.huynh ; thuan.t...@dektech.com.au;
minh.c...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PAT
Hi Minh,
Thanks for your comment.
In case, agent down before clientAdded() then SearchAndSetClientsDownFlag()
does not work.
Best Regards,
ThienHuynh
-Original Message-
From: Minh Hon Chau
Sent: Thursday, October 10, 2019 1:50 AM
To: Thien Minh Huynh ; 'Nguyen Minh Vu'
Hi Vu,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Nguyen Minh Vu
Sent: Wednesday, October 23, 2019 9:58 AM
To: thien.m.huynh ; thuan.t...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] nid: Remove the absolute path of ti
Hi Thuan,
When i run with "if [ $? -ne 0 ]; then" , the test_shellcheck is failed. So
I use ret_val.
Best Regards,
ThienHuynh
-Original Message-
From: Tran Thuan
Sent: Friday, November 8, 2019 9:11 AM
To: 'thien.m.huynh' ;
vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.
Hi Vu,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Nguyen Minh Vu
Sent: Friday, November 8, 2019 9:53 AM
To: thien.m.huynh ; thuan.t...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] nid: Change the path of TIPC_MODULE [
Hi Thắng,
Thanks for your time to review. I will update later.
Best Regards,
ThienHuynh
-Original Message-
From: Thang
Sent: Friday, December 20, 2019 5:17 PM
To: 'thien.m.huynh' ; vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] imm:
Hi Thuan,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Tran Thuan
Sent: Monday, December 23, 2019 2:08 PM
To: 'thien.m.huynh' ;
vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] imm: fix non-local user can
Hi all,
Please ignore this email.
Thanks.
Best Regards,
ThienHuynh
-Original Message-
From: thien.m.huynh
Sent: Thursday, January 16, 2020 9:19 AM
To: Nguyen Minh Vu
Cc: opensaf-devel@lists.sourceforge.net; thien.m.huynh
Subject: [PATCH 1/1] log: make fixed facility ID configurable [
Hi Vu,
Thanks for your suggest. I will update.
Best Regards,
ThienHuynh
From: Nguyen Minh Vu
Sent: Thursday, January 16, 2020 5:11 PM
To: thien.m.huynh
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 3/3] log: update README file for make facility id
configurable [#3131]
Hi Vu,
Thanks for your spent time to review my patch. I will update.
Best Regards,
ThienHuynh
-Original Message-
From: Nguyen Minh Vu
Sent: Friday, January 17, 2020 10:46 AM
To: thien.m.huynh
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/3] log: make facility ID config
Hi Thang,
Thanks for your comments.
Best Regards,
Thienhuynh
-Original Message-
From: Thang
Sent: Friday, January 17, 2020 3:19 PM
To: 'Nguyen Minh Vu' ; 'thien.m.huynh'
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/3] log: make facility ID configurable [#3131
Hi Thang,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Thang
Sent: Tuesday, January 21, 2020 12:06 PM
To: 'thien.m.huynh' ; 'Nguyen Minh Vu'
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/3] log: make facility ID configurable [#313
Hi Vu,
Thanks you for your spent time to review. I will update.
Best Regards,
ThienHuynh
-Original Message-
From: Nguyen Minh Vu
Sent: Monday, February 3, 2020 4:15 PM
To: thien.m.huynh
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/3] log: make facility ID configurable
Hi Thanh,
Thanks for your spent time to review. I will update and send later.
Best Regard,
ThienHuynh
-Original Message-
From: Thanh Nguyen
Sent: Friday, February 7, 2020 9:28 AM
To: 'Thien Minh Huynh' ; 'Gary Lee'
; 'Minh Chau'
Cc: opensaf-devel@lis
Summary: imm: fix non-local user cannot access IMM when accessControlMode is in
ENFORCED [#3043]
Review request for Ticket(s): 3043
Peer Reviewer(s): Thuan, Vu
Pull request to: Vu
Affected branch(es): develop
Development branch: ticket-3043
Base revision: 7e3720c628ca33e76ddcc9b89cac1f01ad69e04d
P
---
src/base/osaf_secutil.c | 78 +++
src/base/osaf_secutil.h | 9 +
src/imm/immnd/immnd_evt.c | 4 +-
3 files changed, 90 insertions(+), 1 deletion(-)
diff --git a/src/base/osaf_secutil.c b/src/base/osaf_secutil.c
index 0e175c915..a899c1a7f 100644
--
Hi Vu,
Thanks for your spent time to review. I will update your comments.
Best Regards,
ThienHuynh
From: Vu Minh Nguyen
Sent: Monday, February 24, 2020 10:26 AM
To: Thien Minh Huynh ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] imm: fix non-local user cannot
Hi Thuan and Vu,
Thanks for your comment. I will update it.
Best Regards,
ThienHuynh
From: Vu Minh Nguyen
Sent: Tuesday, April 7, 2020 2:43 PM
To: Thien Minh Huynh ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] log: log content is placed in a file of
Hi Thuan,
Thanks for your comment.
Best Regards,
ThienHuynh
-Original Message-
From: Thuan Tran
Sent: Tuesday, April 7, 2020 6:51 PM
To: Vu Minh Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] log: log content is placed in a file of another
Message-
From: Thang Duc Nguyen
Sent: Monday, April 13, 2020 11:00 AM
To: Thien Minh Huynh ; Thuan Tran
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] log: log content is placed in a file of
another stream [#3175]
Hi Thien,
Just a minor comment
Hi Vu,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Vu Minh Nguyen
Sent: Monday, May 11, 2020 2:30 PM
To: Thien Minh Huynh ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] lgs: fix data CkptPushAsync equals with encode cold
Hi Thuan,
Thanks for your idea. Your idea can solve the issue. I will send V2.
Best Regards,
ThienHuynh
From: Thuan Tran
Sent: Tuesday, May 12, 2020 8:24 AM
To: Thien Minh Huynh ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] lgs: fix data CkptPushAsync
Hi Thuan,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Thuan Tran
Sent: Wednesday, May 13, 2020 3:40 PM
To: Thien Minh Huynh ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] log: increase sleep 2s to make sure all
Hi Vu,
Thanks for your comments.
Best Regards,
ThienHuynh
From: Vu Minh Nguyen
Sent: Monday, July 13, 2020 10:37 AM
To: Thien Minh Huynh ; Thuan Tran
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] saflogger: correct wait time of saflogger in
resilience
Hi Thuan,
Thanks for your comments. I will update in V3.
Best Regards,
ThienHuynh
-Original Message-
From: Thuan Tran
Sent: Tuesday, July 14, 2020 2:05 PM
To: Thien Minh Huynh ; Vu Minh Nguyen
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1
Hi Thuan,
Thanks for your comments. See a comment inline.
Best Regards,
ThienHuynh
-Original Message-
From: Thuan Tran
Sent: Tuesday, July 28, 2020 4:59 PM
To: Thien Minh Huynh ; Thang Duc Nguyen
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1
Hi Thuan,
I will update in V2.
Best Regards,
ThienHuynh
From: Thuan Tran
Sent: Tuesday, July 28, 2020 6:31 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1] clm: fix memory leak reeported by
Hi Thang,
Thanks for your comment. I will update description for that.
Best Regards,
ThienHuynh
-Original Message-
From: Thang Duc Nguyen
Sent: Wednesday, July 29, 2020 1:37 PM
To: Thuan Tran ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] clm
Hi Thang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, January 18, 2021 10:32 AM
To: Thanh Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] smd: avoid smf stucked during admin op in
Hi Thang,
Thanks for your comment. I will update the comment in v2.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Wednesday, February 3, 2021 2:05 PM
To: Thien Minh Huynh ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] clm: clean
Hi Thang,
ACK with a minor comment.
-%{_bindir}/test_objexist
+#%{_bindir}/test_objexist
I think should be remove instead of comment this line.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, March 23, 2021 9:20 AM
To: Thanh Nguyen ; Thien Minh Huynh
Cc
Hi Surbhi,
ACK from me with a minor comment.
The short commit message should describe the changeset in commit.
You can refer :
https://sourceforge.net/p/opensaf/staging/ci/default/tree/tools/devel/review/commit.template
Best Regards,
Thien
-Original Message-
From: ztrisur
Sent: Wednes
Hi Surbhi,
I have tested with imm test. The patch working well.
ACK from me.
Best Regards,
Thien
-Original Message-
From: ztrisur
Sent: Monday, March 22, 2021 6:30 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] imm: valgri
has reached
> IMMSV_DEFAULT_FEVS_MAX_PENDING. This means that *this*
Should add a description of the environment variable "IMMSV_FEVS_MAX_PENDING"
to file immnd.conf for ease of use.
Best Regards,
Thien
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, May 12, 2021 7:58 AM
To: Thien Minh Huynh
Hi Thang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, August 9, 2021 7:22 AM
To: Minh Hon Chau ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] pyosaf: correct retry on failed operation
Hi Huu,
See comment inline.
Best Regards,
Thien
-Original Message-
From: Huu The Truong
Sent: Thursday, September 23, 2021 4:32 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh ;
Surbhi Tripathi
Cc: opensaf-devel@lists.sourceforge.net; Huu The Truong
Subject: [PATCH 1/1
: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh ;
Surbhi Tripathi
Cc: opensaf-devel@lists.sourceforge.net; Huu The Truong
Subject: [PATCH 1/1] immd: failed to find candidate for new immnd coordinator
[#3284]
Some cases, standby SC cannot promote to be coordinator, since isOnController
Hi Surbhi,
See comment inline.
-Original Message-
From: Surbhi Tripathi
Sent: Wednesday, September 29, 2021 9:06 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Surbhi Tripathi
Subject: [PATCH 1/1] osaf: fixed redefinition of
ACK
-Original Message-
From: Surbhi Tripathi
Sent: Wednesday, September 29, 2021 9:06 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Surbhi Tripathi
Subject: [PATCH 1/1] osaf: fixed redefinition of typedef 'SaConstStringT
Hi Thang,
ACK from me with no comments.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, September 30, 2021 4:44 PM
To: Thanh Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] smf: make more
Hi Thang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Friday, October 8, 2021 8:28 AM
To: Thien Minh Huynh ; Thanh Nguyen
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] smf: correct merge bundle
Hi Hieu,
ACK with no comment from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Friday, October 22, 2021 8:00 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] log
Hieu Hong Hoang
Sent: Friday, November 26, 2021 3:30 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 0/3] Review Request for log: shutdown log agent when not in use
[#3291]
Summary: log: Introduce the initial
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Wednesday, December 8, 2021 12:38 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 0/3] Review Request for
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Tuesday, December 14, 2021 6:05 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] log: Correct condition
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Tuesday, December 28, 2021 1:22 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] log: Stop all threads
Hi Hoang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hoang Minh Vu
Sent: Wednesday, January 26, 2022 5:44 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hoang Minh Vu
Subject: [PATCH 1/1] dtm: fix osaflog tool to
Hi Hieu,
See my comment inline [Thien].
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Thursday, March 10, 2022 10:59 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] log
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Friday, March 11, 2022 3:48 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] log: Increase the log
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Friday, March 18, 2022 3:06 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] log: The log director
/staging/ci/default/tree/tools/devel/review/commit.template
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Friday, April 15, 2022 12:38 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1
Hi Hoang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hoang Minh Vu
Sent: Thursday, April 28, 2022 5:30 AM
To: Thien Minh Huynh ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Hoang Minh Vu
Subject: [PATCH 1/1] imm: fix PBE logging inconsistent [#3311
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Tuesday, May 10, 2022 1:34 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] imm: Remove dead admin owner
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Wednesday, May 4, 2022 8:23 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] imm: Fix pbe deadlock
Hi Dat,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Dat Tran Quoc Phan
Sent: Thursday, June 2, 2022 6:56 PM
To: Hieu Hong Hoang ; Huu The Truong
; Minh Hon Chau ; Thang
Duc Nguyen ; Thien Minh Huynh
; Hoang Minh Vu
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Wednesday, July 20, 2022 1:21 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] ntf: Process the
Hi Thang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, August 1, 2022 11:49 AM
To: Hieu Hong Hoang ; Thien Minh Huynh
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] base: remove others
Hi Hieu,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Hieu Hong Hoang
Sent: Monday, November 21, 2022 10:24 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 0/3] Review Request for log
Hi Mohan,
Thank you for taking the time to review.
Best Regards,
Thien
-Original Message-
From: Mohan Kanakam
Sent: Friday, November 25, 2022 9:07 PM
To: Thien Minh Huynh ; Hieu Hong Hoang
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 0/1
Hi Dat,
See my comments start with [Thien]
Best Regards,
Thien
-Original Message-
From: Dat Tran Quoc Phan
Sent: Monday, February 13, 2023 3:21 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
Subject: [PATCH 1/1] imm: Wait for
Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
Subject: [PATCH 1/1] imm: Make NFS state consistent among nodes [#3330]
There is a case that the ccb apply not run on some nodes due to NFS
unavailable. Then it causes the mismatch state in complete ack.
Solu
Hi Thang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, March 7, 2023 11:42 AM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] build: fix HIGH severity in
Hi Dat,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Dat Tran Quoc Phan
Sent: Monday, March 20, 2023 1:15 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
Subject: [PATCH 1/1] amf: Fix errors reported by valgrind
Hi Dat,
See my comments.
Best Regards,
Thien
-Original Message-
From: Dat Tran Quoc Phan
Sent: Tuesday, March 28, 2023 10:44 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
Subject: [PATCH 1/1] rde: fix errors reported by
Hi Dat,
ACK from me with no comment.
Best Regards,
Thien
-Original Message-
From: Dat Tran Quoc Phan
Sent: Friday, April 14, 2023 7:01 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
Subject: [PATCH 1/1] rde: fix errors
Hi Khanh,
ACK from me
Best Regards,
Thien
-Original Message-
From: Khanh Q Nguyen
Sent: Monday, April 17, 2023 2:10 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Khanh Q Nguyen
Subject: [PATCH 1/2] rde: fix pointer used after free [#3332
Sent: Wednesday, April 26, 2023 5:12 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net ;
Dat Tran Quoc Phan
Subject: [PATCH 1/1] mds: fix coredump when run mdstest using mds q_ownership
[#3337]
This fix will remove a wrong freeing when mds recevies message.
M
Hi Khanh,
ACK from me.
Best Regards,
Thien
From: Khanh Q Nguyen
Sent: Monday, May 22, 2023 4:42 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net ;
Khanh Q Nguyen
Subject: [PATCH 1/1] pyosaf: type conversion before converting
Hi Thang,
See my comment inline [Thien].
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, July 13, 2023 6:13 AM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] smf: Fix handling
ien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amf: fix mismatch message id during sc fail-over [#3342]
When SC fail-overs, the new AMFD active will send AVSV_D2N_DATA_VERIFY_MSG
message event to AMFND.
When AMFND processes t
Hi Thang,
ACK from me.
Best Regards,
Thien
From: Thang Duc Nguyen
Sent: Monday, January 15, 2024 5:42 PM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net ;
Thang Duc Nguyen
Subject: [PATCH 1/1] osaf: supports compile/build
Hi Tai,
Please check my comments [Thien].
Best Regards,
Thien
From: Tai Huynh Nguyen
Sent: Wednesday, February 28, 2024 6:02 PM
To: Dat Tran Quoc Phan ; Thang Duc Nguyen
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net ;
Tai Huynh Nguyen
Subject
Hi Dat,
See my comments inline [Thien].
Best Regards,
Thien
From: Dat Tran Quoc Phan
Sent: Monday, March 25, 2024 8:52 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net ;
Dat Tran Quoc Phan
Subject: [PATCH 1/1] ntf: ntfd
From: Dat Tran Quoc Phan
Sent: Friday, March 29, 2024 8:06 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Tai Huynh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Dat Tran Quoc Phan
Subject: [PATCH 1/1] ntf: ntfd cannot handle notification when logd overload
[#3349]
When AMF
Hi Dat,
Ack from me.
Best Regards,
Thien
From: Dat Tran Quoc Phan
Sent: Tuesday, April 2, 2024 8:47 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Tai Huynh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Dat Tran Quoc Phan
Subject: [PATCH 0/2] Review Request
Hi Dat,
See my comment inline.
Best Regards,
Thien
From: Dat Tran Quoc Phan
Sent: Monday, April 15, 2024 9:38 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Tai Huynh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Dat Tran Quoc Phan
Subject: [PATCH 1/1
Hi Dat,
ACK from me.
Best Regards,
Thien
From: Dat Tran Quoc Phan
Sent: Monday, April 15, 2024 5:10 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Tai Huynh Nguyen
Cc: opensaf-devel@lists.sourceforge.net ;
Dat Tran Quoc Phan
Subject: [PATCH 1/1] ntf: check
Hi Thang,
Thanks for your review. I will update in the next patch.
Best Regards,
Thien
From: Thang Duc Nguyen
Sent: Thursday, April 25, 2024 7:50 AM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1
Hi Thang,
I see my comment inline [Thien].
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, May 6, 2024 7:48 PM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] osaf: supports build
Hi Thang,
ACK with 4 minor comments.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Saturday, May 25, 2024 6:21 PM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] clm: fix error printed
Hi Thang,
ACK from me.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, June 25, 2024 8:56 AM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] smf: fix one step upgrade failed
Hi Thang,
ACK with a comment.
Best Regards,
Thien
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, June 27, 2024 7:27 PM
To: Thien Minh Huynh ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amf: handle
84 matches
Mail list logo