[kudu-CR] KUDU-798 (part 1) - Unify leader/follower mvcc behavior

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#6). Change subject: KUDU-798 (part 1) - Unify leader/follower mvcc behavior .. KUDU-

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5056 to look at the new patch set (#2). Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests .

[kudu-CR] KUDU-768 (part 1) - Unify leader/follower mvcc behavior

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#5). Change subject: KUDU-768 (part 1) - Unify leader/follower mvcc behavior .. KUDU-

[kudu-CR] KUDU-768 (part 1) - Move timestamp assignement out of Tablet

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#4). Change subject: KUDU-768 (part 1) - Move timestamp assignement out of Tablet ..

[kudu-CR] KUDU-768 (part 1) - Move timestamp assignement out of Tablet

2016-11-12 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#3). Change subject: KUDU-768 (part 1) - Move timestamp assignement out of Tablet ..

[kudu-CR] KUDU-768 (part 1) - Move timestamp assignement out of Tablet

2016-11-12 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#2). Change subject: KUDU-768 (part 1) - Move timestamp assignement out of Tablet ..

[kudu-CR] WIP KUDU-738 (part 3) Remove automatic safe time adjustment from mvcc

2016-11-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5057 Change subject: WIP KUDU-738 (part 3) Remove automatic safe time adjustment from mvcc .. WIP KUDU-738 (part 3) Remove automatic sa

[kudu-CR] WIP: KUDU-738 (part 2) Always use pre-assigned timestamps in tablet tests

2016-11-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5056 Change subject: WIP: KUDU-738 (part 2) Always use pre-assigned timestamps in tablet tests .. WIP: KUDU-738 (part 2) Always use pre

[kudu-CR] KUDU-768 (part 1) - Move timestamp assignement out of Tablet

2016-11-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5055 Change subject: KUDU-768 (part 1) - Move timestamp assignement out of Tablet .. KUDU-768 (part 1) - Move timestamp assignement out

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add Reinserts to tablet_history_gc-itest .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4997/8/src/kudu/integration-tests/tablet_history_

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4586 To unsubscribe, visit http

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page .. Patch Set 6: Code-Review+2 (1 comment) Feel free to address the nit, +2 yourself and push http://gerrit.clo

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Rename LogicalClock::NowForMetrics() to GetCurrentTime() This renames this method and

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Improve debuggability of the delta/compaction path .. Improve debuggability of the delta/compaction path This adds/modifies some log statements on

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Consolidate Row/CompactionInputRow printing on compaction We are duplicating row prin

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4586/3/docs/developing.adoc File docs/developi

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 8: Verified+1 Unrelated flake -- To view, visit http://gerrit.cloudera.org:8080/4996 To unsubscribe, visit

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-10 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#11). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#10). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#9). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. K

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#8). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. K

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compactio

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4988 to look at the new patch set (#6). Change subject: Consolidate Row/CompactionInputRow printing on compaction ..

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro to LOG and return on a non-OK status We often see the following pattern: Status s

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 8: Code-Review+2 just a rebase, keepin

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 6: Code-Review+2 just a rebase, keeping +2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#6). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. K

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4993 to look at the new patch set (#4). Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4988 to look at the new patch set (#5). Change subject: Consolidate Row/CompactionInputRow printing on compaction ..

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compacti

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 5: Code-Review+2 Just a rebase, keeping alexey's +2 -- To view, visit http://gerrit.cloud

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4988 to look at the new patch set (#4). Change subject: Consolidate Row/CompactionInputRow printing on compaction ..

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 5: (1 comment) http://gerrit.cloudera

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4989 to look at the new patch set (#4). Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() ...

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4930 to look at the new patch set (#5). Change subject: Improve debuggability of the delta/compaction path ...

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#13). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#7). Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Make RowChangeListDecoder::RemoveColumnIdsFromChang

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4927/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#6). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4993 to look at the new patch set (#3). Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#5). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. K

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#12). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] Release notes for the Java client in 1.1

2016-11-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5002 To unsubscribe, visit http:/

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4930/3//COMMIT_MSG Commit Message: PS

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4930 to look at the new patch set (#4). Change subject: Improve debuggability of the delta/compaction path .. Improve de

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4988 to look at the new patch set (#3). Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Con

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#5). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/2/src/kudu/tablet/compactio

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4927/4/src/kudu/util/status.h File src/ku

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Unbreak the build: Pull RowChangelistEncoder::get_type() Misordered push of 3c68deacc0

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Unbreak the build: Pull RowChangelistEncoder::get_type() Misordered push of 3c68deacc05f6b5a9b825

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5013 Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Unbreak the build: Pull RowChangelistEncoder::get_type(

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Patch Set 2: Dinesh: Yeah I saw that and I pondered what you are suggesting. Ended up not doin

[kudu-CR] Account for REINSERTs in delta stats

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Account for REINSERTs in delta stats .. Account for REINSERTs in delta stats This makes DeltaStats also account for REINSERTs. This is not actuall

[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Enforce that REINSERTs are not supported in DeltaMemStores .. Enforce that REINSERTs are not supported in DeltaMemStores We never really supported

[kudu-CR] [c++ client] implemented session operations stats

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4974/3//COMMIT_MSG Commit Message: PS3

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc File docs/release_

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 11: (3 comments) only nits and one possible patch split. Could you address the tidy bot nits? Thank

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#4). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. K

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#3). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-i

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#2). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-i

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4997 to look at the new patch set (#2). Change subject: Add Reinserts to tablet_history_gc-itest .. Add Reinserts to tab

[kudu-CR] WIP: Don't output unobservable rows from the MemRowset

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#2). Change subject: WIP: Don't output unobservable rows from the MemRowset .. WIP: D

[kudu-CR] Account for REINSERTs in delta stats

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4932 to look at the new patch set (#3). Change subject: Account for REINSERTs in delta stats .. Account for REINSERTs in

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#2). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. K

[kudu-CR] KUDU-1735. Fix crash when aborting a skipped config change round

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1735. Fix crash when aborting a skipped config change round .. Patch Set 3: Code-Review+2 (2 comments) Just nits. ignore/don't ignore, you choose :)

[kudu-CR] NOT FOR REVIEW - Make DeltaStore::CheckRowDeleted() return an enum

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4929 to look at the new patch set (#4). Change subject: NOT FOR REVIEW - Make DeltaStore::CheckRowDeleted() return an enum .

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT deltas in delta files .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4819 To unsubscribe, visit http:

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT deltas in delta files .. Patch Set 7: (10 comments) Abandoning this. Will review if I missed some comments t

[kudu-CR] KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus() .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4931 To unsubscri

[kudu-CR] WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum .. Patch Set 3: This will be updated but is no longer part of the REINSERT seque

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4993 Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Don't do UNDO garbage collection unt

[kudu-CR] WIP: Don't output unobservable rows from the MemRowset

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4994 Change subject: WIP: Don't output unobservable rows from the MemRowset .. WIP: Don't output unobservable rows from the MemRowset I

[kudu-CR] Account for REINSERTs in delta stats

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4932 to look at the new patch set (#2). Change subject: Account for REINSERTs in delta stats .. Account for REINSERTs in

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4995 Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. KUDU-237 (part 2) - Add support for REINSERT in delt

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4997 Change subject: Add Reinserts to tablet_history_gc-itest .. Add Reinserts to tablet_history_gc-itest This adds Reinserts as a new

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4996 Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-itest This adds a new operation to fuzz-itest: snap

[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4991 Change subject: Enforce that REINSERTs are not supported in DeltaMemStores .. Enforce that REINSERTs are not supported in DeltaMemS

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 5: Verified+1 Unrelated flake -- To

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4930/2/src/kudu/tablet/delta_store.cc

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4930 to look at the new patch set (#3). Change subject: Improve debuggability of the delta/compaction path .. Improve de

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4988 to look at the new patch set (#2). Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Con

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4989 Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Rename LogicalClock::NowForMetrics() to GetCurrentTime(

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4988 Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Consolidate Row/CompactionInputRow printing on compact

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#4). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#3). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4927/2//COMMIT_MSG Commit Message: > Ni

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#10). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4929 to look at the new patch set (#3). Change subject: WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum ..

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#9). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .

[kudu-CR] WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4929 to look at the new patch set (#2). Change subject: WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum ..

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#8). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4928 Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Make Row

[kudu-CR] KUDU-237 (part 4) - Account for reinserts in delta stats

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4932 Change subject: KUDU-237 (part 4) - Account for reinserts in delta stats .. KUDU-237 (part 4) - Account for reinserts in delta stat

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#7). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .

[kudu-CR] WIP: KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4929 Change subject: WIP: KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum .. WIP: KUDU-237 (part 2) - Make DeltaS

[kudu-CR] KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4931 Change subject: KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus() .. KUDU-237 (part 3) - Transform

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4927 Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro to LOG and return on a non-OK status We often see

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4930 Change subject: Improve debuggability of the delta/compaction path .. Improve debuggability of the delta/compaction path This adds

[kudu-CR] KUDU-1611 - [python] Enable setting scanner selection policy

2016-10-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1611 - [python] Enable setting scanner selection policy .. KUDU-1611 - [python] Enable setting scanner selection policy Currently the python

<    10   11   12   13   14   15   16   17   18   >