Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r234177079
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -17,17
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21838#discussion_r234099158
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala
---
@@ -0,0 +1,175
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215376132
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -82,7 +83,7 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215216011
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215215098
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -754,6 +754,54 @@ class HiveDDLSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215213849
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r215214259
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -82,7 +83,7 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144932
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215145065
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144732
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215145351
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -831,13 +831,21 @@ class DataFrameSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22332#discussion_r215144982
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2226,16 +2226,18 @@ class Dataset[T] private[sql](
* `column`'s
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215138305
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -29,7 +29,7 @@ package org.apache.spark.ml.source.image
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215138635
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageOptions.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215138476
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -45,6 +45,8 @@ package org.apache.spark.ml.source.image
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215038606
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215037240
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215039097
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -567,6 +567,7 @@ object DataSource extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215036263
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215037968
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22328#discussion_r215036643
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/22332
Why not `select($"*", newColumnHere)` or `select(newColumnHere, $"*")`?
Somehow I don't think the use case merits ove
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22316#discussion_r214752855
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -416,7 +426,7 @@ class RelationalGroupedDataset
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22318#discussion_r214752480
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -295,4 +295,14 @@ class DataFrameJoinSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751309
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214750815
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751930
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -754,6 +754,47 @@ class HiveDDLSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751219
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751023
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751748
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -63,7 +63,7 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22320#discussion_r214751169
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -805,6 +805,80 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22238#discussion_r213264912
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -868,7 +870,9 @@ object SQLConf {
.internal
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22238#discussion_r213264786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -266,7 +266,9 @@ object SQLConf
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/22238#discussion_r213063267
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -2812,6 +2812,12 @@ See [Input Sources](#input-sources) and [Output
Sinks](#output
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21858#discussion_r210681673
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala
---
@@ -80,7 +80,5 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21858#discussion_r205058875
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1150,16 +1150,48 @@ object functions {
/**
* A column
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/21858
[SPARK-24899][SQL][DOC] Add example of monotonically_increasing_id standard
function to scaladoc
## What changes were proposed in this pull request?
Example
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r204098057
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -270,7 +270,7 @@ case class FileSourceScanExec
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203666346
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203665574
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -270,7 +270,7 @@ case class FileSourceScanExec
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203666893
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203666125
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203667943
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203664621
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -166,10 +166,10 @@ case class FileSourceScanExec
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203665187
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -199,7 +199,7 @@ case class FileSourceScanExec
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/12119
Use u...@spark.apache.org mailing list to ask questions (see
http://spark.apache.org/community.html#mailing-lists
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21510#discussion_r194632125
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -88,41 +90,41 @@ private[spark] abstract class WebUI(
handlers
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/21510
@kiszk @jerryshao @srowen Added `s` (and even more scaladoc). Thanks for
reviewing (and hopefully merging right after
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/21510
May I ask for some help merging it? /cc @srowen @holdenk @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/21510
[SPARK-24490][WebUI] Use WebUI.addStaticHandler in web UIs
`WebUI` defines `addStaticHandler` that web UIs don't use (and simply
introduce duplication). Let's clean them up and remove
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/21448
It is such a small change that I don't think it's going to take long to get
merged. Reaching out to friendly folks to reach a consensus on it :) /cc
@srowen @holdenk
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/21448
[SPARK-24408][SQL][DOC] Move abs, bitwiseNOT, isnan, nanvl functions to
math_funcs group
## What changes were proposed in this pull request?
A few math functions (`abs
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21316#discussion_r187899299
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1607,7 +1607,9 @@ class Dataset[T] private[sql
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/20856
BTW, I've just realized that even without the issue it's clear that
creating a new `FileSourceScanExec` will end up with a NPE from the
`supportsBatch` field
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/20856
I spent over 2 days applying different modifications to the query hoping I
could cut the number of `CASE WHEN`s and other projections, but noticed no
correlation between the number
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/20856
[SPARK-23731][SQL] FileSourceScanExec throws NullPointerException in
subexpression elimination
## What changes were proposed in this pull request?
Avoids ("
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/20855
[SPARK-23731][SQL] FileSourceScanExec throws NullPointerException in
subexpression elimination
## What changes were proposed in this pull request?
Avoids (not necessarily fixes
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/20855
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20832#discussion_r174700327
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -1208,85 +1208,172 @@ class ColumnName(name: String) extends
Column(name
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20832#discussion_r174699743
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -1208,85 +1208,172 @@ class ColumnName(name: String) extends
Column(name
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/20550
I'll try to add more typos from other modules. I didn't mean to "pollute" a
minor change and make it bigger (and possibly qu
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/20550
[MINOR][HIVE] Typo fixes
## What changes were proposed in this pull request?
Typo fixes (with expanding a Hive property)
## How was this patch tested?
local build
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164728359
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
---
@@ -87,7 +87,7 @@ public static CalendarInterval
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729684
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729086
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729429
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164729250
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -235,10 +237,30 @@ public MapData getMap(int ordinal
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20405#discussion_r164267100
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1216,7 +1216,7 @@ class Dataset[T] private[sql
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/20405
Looks like the tests failed due to _"java.io.IOException: Failed to delete:
/home/jenkins/workspace/SparkPullRequestBuilder/target/tmp/spark-5a9b5811-306d-4ba0-8bfb-9e263dd
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20405#discussion_r164191381
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1216,7 +1216,7 @@ class Dataset[T] private[sql
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/20405
/cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/20405
[SPARK-23229][SQL] Dataset.hint should use planWithBarrier logical plan
## What changes were proposed in this pull request?
Every time `Dataset.hint` is used it triggers execution
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20368#discussion_r163376001
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala
---
@@ -126,6 +126,22 @@ class BroadcastJoinSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20368#discussion_r163375534
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala
---
@@ -126,6 +126,22 @@ class BroadcastJoinSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20368#discussion_r163375216
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -77,7 +77,7 @@ case class InMemoryRelation
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/20344
The builds failed due to a change in one of the error messages that the
tests assert (!) Fixing...
---
-
To unsubscribe
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/20344
[MINOR] Typo fixes
## What changes were proposed in this pull request?
Typo fixes
## How was this patch tested?
Local build / Doc-only changes
You can merge
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20076#discussion_r159142765
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -323,11 +323,13 @@ object SQLConf
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20076#discussion_r159142783
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -364,7 +366,9 @@ object SQLConf
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20076#discussion_r159142760
--- Diff: docs/sql-programming-guide.md ---
@@ -953,8 +953,10 @@ Configuration of Parquet can be done using the
`setConf` method on `SparkSession
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19774#discussion_r151838625
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -689,6 +689,11 @@ case class DescribeColumnCommand
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19407#discussion_r151838606
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -267,11 +267,12 @@ final class DataStreamWriter[T
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19725#discussion_r151741374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/InjectPlaceholderExchange.scala
---
@@ -0,0 +1,69
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r151739773
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -318,16 +318,28 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r151740225
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1459,6 +1459,11 @@ abstract class DDLSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r151739604
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -318,16 +318,28 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19774#discussion_r151737674
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -689,6 +689,11 @@ case class DescribeColumnCommand
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/kafka/pull/4038
[KAFKA-4818][FOLLOW-UP] Include isolationLevel in toString of FetchRequest
Include `isolationLevel` in `toString` of `FetchRequest`
This is a follow-up to https://issues.apache.org
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19407#discussion_r142022819
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -269,7 +269,7 @@ final class DataStreamWriter[T
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/19261
OK I feel convinced that you feel convinced Spark SQL should not offer this
as part of the public API. Thanks for being with me for so long and patient to
explain the things. Thanks
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/19261
@rxin @gatorsmile Let me ask you a very similar question then, why does
`CurrentDate` operator has the optional timezone parameter? What's the purpose?
Wouldn't that answer your questions
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/19261
@gatorsmile Dunno, but the logical operator does.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19261#discussion_r139309272
--- Diff: python/pyspark/sql/functions.py ---
@@ -793,12 +793,12 @@ def ntile(n):
# -- Date/Timestamp functions
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19261#discussion_r139309246
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2508,6 +2508,14 @@ object functions {
def current_date
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19261#discussion_r139309261
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2508,6 +2508,14 @@ object functions {
def current_date
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/19112
Hey @HyukjinKwon, as the only committer who's been involved in this PR,
could you review it again and possibly merge to master? Thanks
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19112#discussion_r136750244
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
@@ -200,7 +202,7 @@ class SourceProgress protected[sql
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19112#discussion_r136726445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
@@ -177,11 +179,11 @@ class SourceProgress protected[sql
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/19112#discussion_r136726289
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
@@ -200,7 +202,7 @@ class SourceProgress protected[sql
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/19112
[SPARK-21901][SS] Define toString for StateOperatorProgress
## What changes were proposed in this pull request?
Just `StateOperatorProgress.toString` + few formatting fixes
1 - 100 of 590 matches
Mail list logo
