Re: Test cases for Category Navigation
I think you can include the number of products should display under one category, number of subcategories display under category. In case list of products have multiple pages then it should work properly. Also on how we can validate if a product/category is under specific category then how can be we sure that those products or catgories should come under the browsed category. Some links like product link, other category swithing links, catgory tree should be working etc should be there in the test case. I could recall only these, may be others from community could help more. -- Rishi Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Dec 17, 2016 at 4:59 PM, Ayushi Gupta < ayushi.gu...@hotwaxsystems.com> wrote: > Hello All, > > I want to write test cases for category navigation functionality of OFBiz. > I have listed out some test cases as follows: > > - Rendering of categories/sub-categories > - Rendering of products through categories/sub-categories > - Product with basic informations > > Please suggest any other possible test cases related to category navigation > in OFBiz. > > -- > > Thanks with regards, > > Aayushi Gupta >
Re: Suggestion for Use Cases of Product Search in Ofbiz Ecommerce
- Rendering of products through the keyword passed in search context. - Advance search feature should run on the other parameters. - Product with basic informations. - Pagination. - Also on how we can validate if a product is searchable on specific keyword then how can be we sure that those products should come in a particular category. Some links like product link, other search pages related links etc should be there in the test case. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Dec 17, 2016 at 5:38 PM, Shubham Agrawal < shubham.agra...@hotwaxsystems.com> wrote: > Hello All, > > I am writing use cases of Product Search in OFBiz ecommerce, I would need > help of the community to find out all the possible scenarios those should > be taken in consideration. > > So please suggest me the use cases for the same. > > > *Thanks and Regards,* > *Shubham Agrawal* >
User Acceptance Test Cases For Ecommerce 14.12
Devs, We have started working on few user stories mentioned at Ecommerce-14.12 <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and adding user acceptance test (UAT) cases for them. For now we have added test cases for two user stories as follows; - Login Page - Login and Update Personal Information We have updated the document with the identified UATs so that can get feedback from community on them. - For now we have added the UATs just below the user stories in the document. Please let us know if we are fine with this location? - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned two user stories. Please review and let us know your thoughts on it, so that we can follow one common pattern. Any other feedback in UATs are most welcome to improve the quality. Going forward we would follow the same practice. Thanks to Aman Mishra for providing the UATs for both stories. Best Regards, -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com
Re: User Acceptance Test Cases For Ecommerce 14.12
Please use this link to access the mentioned page in original email - Ecommerce-14.12 <https://cwiki.apache.org/confluence/display/OFBIZ/E-commerce+14.12> Thanks! -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Jan 21, 2017 at 9:21 PM, Rishi Solanki wrote: > Devs, > > We have started working on few user stories mentioned at Ecommerce-14.12 > <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and > adding user acceptance test (UAT) cases for them. For now we have added > test cases for two user stories as follows; > - Login Page > - Login and Update Personal Information > > We have updated the document with the identified UATs so that can get > feedback from community on them. > > - For now we have added the UATs just below the user stories in the > document. Please let us know if we are fine with this location? > - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned > two user stories. Please review and let us know your thoughts on it, so > that we can follow one common pattern. > > Any other feedback in UATs are most welcome to improve the quality. Going > forward we would follow the same practice. > > Thanks to Aman Mishra for providing the UATs for both stories. > > > Best Regards, > -- > Rishi Solanki > Sr. Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com >
Re: User Acceptance Test Cases For Ecommerce 14.12
Thanks Jacques for your reply and raising concerns. It seems that, I was not clear enough. Let me try to rephrase what we are doing. If you observe then Pranay has created new hierachy for each release like 14.12, 15.12 ... so on. For each release we have the user stories, and we are adding UATs for each user story. For each user story we are discussing the cases we should test manually and also try them to dicuss on the mailing list (user/dev). Once we are sure, we document and test the cases (manually) and put the results in the Actual results and Pass/Fail. Please note that, before documenting anything as Pass or Fail we are really running that scenario. The intention of doing this, we can say that the released branches of OFBiz are tested on certain scenarios and all get passed. After completing this activity, we as a community can say 14.12 branch tested for say 1000 user acceptance test cases and out of them 950 get passed and 50 are reported and fail for that branch. Once we complete this activity, we could start fixing them. For the same we have started multiple email threads to get the feedback from community, so that we could get more cases for the user stories. In other words, we have automated tests with us, but this time we are trying to add documents for the manual tests user could see and increase in faith on each relase. I hope I'm clear this time :-). And yes I agree on the fact that we should think on automating these tests to run them frequently. And I think for that we again need what to tests get documented. We can assume it as first step towards automation. PS: Team, please add more details if I miss something. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sun, Jan 22, 2017 at 5:00 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Rishi, > > This is interesting, do you envision a mean to automate these tests and > run them frequently? > > Say either on each build (using BuildBot for instance), or on another > frequency if they happens to be at term longer than our commit frequency > would support. > > So the question is do you plan to use a tool for that? I say that because > it seems to me that Cucumber (MIT license) could be used for that... > > Jacques > > > Le 21/01/2017 à 16:51, Rishi Solanki a écrit : > >> Devs, >> >> We have started working on few user stories mentioned at Ecommerce-14.12 >> <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and >> adding user acceptance test (UAT) cases for them. For now we have added >> test cases for two user stories as follows; >> - Login Page >> - Login and Update Personal Information >> >> We have updated the document with the identified UATs so that can get >> feedback from community on them. >> >> - For now we have added the UATs just below the user stories in the >> document. Please let us know if we are fine with this location? >> - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned two >> user stories. Please review and let us know your thoughts on it, so that >> we >> can follow one common pattern. >> >> Any other feedback in UATs are most welcome to improve the quality. Going >> forward we would follow the same practice. >> >> Thanks to Aman Mishra for providing the UATs for both stories. >> >> >> Best Regards, >> -- >> Rishi Solanki >> Sr. Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> >
Re: Does the deleteWorkEffort really always works?
Agree on all points shared by Scott, Paul and Nicolas. Also valid concern raised in this thread by Jacques. Thanks! As described by Nicolas, that work_effort is complex entity and we should consider the functional context for it, if we wnat to delete a work_effort. Still I think, until business or dba not force we should maintain the historical data. I mean to say, we have date fileds and status fields in the work_effort the maintain/filter them. Also on closing/cancelling the workeffort case by case basis system clear them out from the system. So we need a delete service for work_effort which requires extra handling for date fields, status field with some better algorithm so that once business decided to remove it, system should always remove instead of sending exception on dependencies. Thanks! Kind Regards, -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jan 23, 2017 at 4:25 PM, Nicolas Malin wrote: > WorkEffort is a complexe entity as much technical aspect as functional > cover :) > > On the Jacques's case, the workEffort is used to follow jobSandox activity > after user command and in logical delete all older workEffort to minimize > the history (like jenkins with his scheduler). > > After your remarks, I think call deleteWorkEffort isn't logical without > functional context. If we want delete a WorkEffort, we need to understand > the this context and in this case prepare the deletion by a dedicate > service (remove all potential FK and so one) before call the standard > service. > > Nicolas > > > Le 23/01/2017 à 11:10, Paul Foxworthy a écrit : > >> Hi Jacques and Scott, >> >> On 23 January 2017 at 09:08, Scott Gray >> wrote: >> >> >> I can't think of any *good* reasons to remove a WorkEffort record. >>> >> >> Hear, hear. In general, OFBiz expires an entity by setting the thruDate. >> What's so special about WorkEffort? >> >> Cheers >> >> Paul >> >> >
Re: Welcome Swapnil Shah as a New Committer!
Congratulations Swapnil !! :-) Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Feb 15, 2017 at 2:51 PM, Aman Mishra wrote: > Many Congratulations Swapnil.! > > Thanks & Regards > -- > Aman Mishra > > On Wed, Feb 15, 2017 at 1:50 PM, Yashwant Dhakad < > yashwant.dha...@hotwaxsystems.com> wrote: > > > Many congratulations Swapnil! > > > > Thanks & Regards > > -- > > Yashwant Dhakad > > HotWax Systems > > http://www.hotwaxsystems.com/ > > > > On Wed, Feb 15, 2017 at 1:14 PM, Chandan Khandelwal < > > chandan.khandel...@hotwaxsystems.com> wrote: > > > > > Many congratulations Swapnil...! > > > > > > > > > -- > > > Chandan Khandelwal > > > > > > > > > > > > On Wed, Feb 15, 2017 at 11:59 AM, Deepak Dixit < > > > deepak.di...@hotwaxsystems.com> wrote: > > > > > > > Many Congrats Swapnil... > > > > > > > > Thanks & Regards > > > > -- > > > > Deepak Dixit > > > > www.hotwaxsystems.com > > > > > > > > On Wed, Feb 15, 2017 at 10:41 AM, Akash Jain < > > > akash.j...@hotwaxsystems.com > > > > > > > > > wrote: > > > > > > > > > Many congratulations Swapnil! > > > > > > > > > > Thanks and Regards > > > > > -- > > > > > Akash Jain > > > > > > > > > > On Tue, Feb 14, 2017 at 4:30 PM, Sharan Foga > > > wrote: > > > > > > > > > > > The OFBiz PMC has invited Swapnil Shah to become a new committer > > and > > > > are > > > > > > happy to announce that he has accepted. > > > > > > > > > > > > Swapnil has been involved in OFBiz for a few years and has been > > > active > > > > on > > > > > > both the development and user mailing lists responding to some > > quite > > > > > > technical functional questions. > > > > > > > > > > > > Some of the key factors considered for inviting him were as > > follows: > > > > > > > > > > > > - He has very good functional knowledge about OFBiz and this is a > > > > > valuable > > > > > > skill that is useful to developers and users > > > > > > - He is polite, positive, friendly and collaborative when dealing > > the > > > > > > community discussions on the mailings lists or Jira > > > > > > - He has raised Jiras, performed testing on patches and new other > > > > > > functionality > > > > > > - The PMC would like to see a wide range of people from the > > community > > > > > > (developers and non-developers) recognised for their > contributions > > to > > > > the > > > > > > project. > > > > > > > > > > > > Please join me in welcoming and congratulating Swapnil. > > > > > > > > > > > > Thanks > > > > > > Sharan > > > > > > > > > > > > > > > > > > > > >
Re: Improve FindGeneric on webtools
+1
Rishi Solanki
Sr. Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Thu, Feb 16, 2017 at 3:31 PM, Nicolas Malin
wrote:
> Hello, I want just sharing a small improvement realized yesterday.
>
> During a travel, I was bored on the train I tried to replace the old ftl
> FindGeneric screen to display and search all entity by an xml form with
> auto-attribute-entity.
> The main problem came from it's impossible to create a xml file with use
> dynamiclay an entityName for the element (for
> cache/performance reason) so I tried to generate on the fly by groovy the
> xml flow, and call without cache the rendering, like this :
> *
> String dynamicAutoEntityFieldForm = ' encoding="UTF-8"?>http://www.w3.org/
> 2001/XMLSchema-instance" <http://www.w3.org/2001/XMLSchema-instance>
> xmlns="http://ofbiz.apache.org/Widget-Form";
> <http://ofbiz.apache.org/Widget-Form>
> xsi:schemaLocation="http://ofbiz.apache.org/Widget-Form
> http://ofbiz.apache.org/dtds/widget-form.xsd";
> <http://ofbiz.apache.org/Widget-Formhttp://ofbiz.apache.org/dtds/widget-form.xsd>>'
>
> '' +
> ' default-field-type="find"/>' +
> '' +
> '' +
> ' "FormFieldTitle_searchButton", locale) + '">' +
> ''
> Document dynamicAutoEntityFieldFormXml =
> UtilXml.readXmlDocument(dynamicAutoEntityFieldForm,
> true, true)
> [...]
> dynamicAutoEntitySearchFormRenderer.render(writer, context)
>
> and on the ftl
>
> ${dynamicAutoEntitySearchForm?string}
>
> I realized this on the search and list form so now I can use complex
> search operator and the performFind for all entity. What do you thinks
> about that ?
>
> I will open an issue.
>
> Nicolas
>
>
> --
> [image: logoNrd] <https://nereide.fr/>
> Nicolas Malin
> The apache way <http://theapacheway.com/> : *Openness* Technical
> decisions are made publicly
> informat...@nereide.fr
> 8 rue des Déportés 37000 TOURS, 02 47 50 30 54
> Apache OFBiz <http://ofbiz.apache.org/>|The Apache Way
> <http://theapacheway.com/>|ofbiz-fr <http://www.ofbiz-fr.org/>|réseau LE
> <http://www.libre-entreprise.org/>
>
Re: User Acceptance Test Cases For Ecommerce 14.12
Folks, Added two more UAT as Category Navigation and Product Search <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12>. I observe some scope of improvements like UAT writing aren't following common patterns, I'll review and fix them soon. Soon we would add remaining in the ecommerce area, looking for your feedback and suggestions on it. Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Jan 24, 2017 at 7:01 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Rishi, > > Indeed I needed a clarification, sorry for that. > > It's a great initiative, OFBiz will then really be at professional > standards, and that's great! > > I agree that we have first to create and document these UAT and then think > about a tool to run them. > Cucumber seems the best tool for that to me. I also know that Gil > (Portenseigne) from Néréide has begun to use Cucumber for a custom project, > hence my haste :) > > Jacques > > > > Le 23/01/2017 à 08:05, Rishi Solanki a écrit : > >> Thanks Jacques for your reply and raising concerns. It seems that, I was >> not clear enough. Let me try to rephrase what we are doing. If you observe >> then Pranay has created new hierachy for each release like 14.12, 15.12 >> ... >> so on. >> >> For each release we have the user stories, and we are adding UATs for each >> user story. For each user story we are discussing the cases we should test >> manually and also try them to dicuss on the mailing list (user/dev). Once >> we are sure, we document and test the cases (manually) and put the results >> in the Actual results and Pass/Fail. >> >> Please note that, before documenting anything as Pass or Fail we are >> really >> running that scenario. The intention of doing this, we can say that the >> released branches of OFBiz are tested on certain scenarios and all get >> passed. After completing this activity, we as a community can say 14.12 >> branch tested for say 1000 user acceptance test cases and out of them 950 >> get passed and 50 are reported and fail for that branch. Once we complete >> this activity, we could start fixing them. >> >> For the same we have started multiple email threads to get the feedback >> from community, so that we could get more cases for the user stories. In >> other words, we have automated tests with us, but this time we are trying >> to add documents for the manual tests user could see and increase in faith >> on each relase. >> >> I hope I'm clear this time :-). And yes I agree on the fact that we should >> think on automating these tests to run them frequently. And I think for >> that we again need what to tests get documented. We can assume it as first >> step towards automation. >> >> PS: Team, please add more details if I miss something. >> >> >> Rishi Solanki >> Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Sun, Jan 22, 2017 at 5:00 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Thanks Rishi, >>> >>> This is interesting, do you envision a mean to automate these tests and >>> run them frequently? >>> >>> Say either on each build (using BuildBot for instance), or on another >>> frequency if they happens to be at term longer than our commit frequency >>> would support. >>> >>> So the question is do you plan to use a tool for that? I say that because >>> it seems to me that Cucumber (MIT license) could be used for that... >>> >>> Jacques >>> >>> >>> Le 21/01/2017 à 16:51, Rishi Solanki a écrit : >>> >>> Devs, >>>> >>>> We have started working on few user stories mentioned at Ecommerce-14.12 >>>> <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12> and >>>> adding user acceptance test (UAT) cases for them. For now we have added >>>> test cases for two user stories as follows; >>>> - Login Page >>>> - Login and Update Personal Information >>>> >>>> We have updated the document with the identified UATs so that can get >>>> feedback from community on them. >>>> >>>> - For now we have added the UATs just below the user stories in the >>>> document. Please let us know if we are fine with this location? >>>> - We are using *EC-LP* and *EC-LUPI *as prefix for the above mentioned >>>> two >>>> user stories. Please review and let us know your thoughts on it, so that >>>> we >>>> can follow one common pattern. >>>> >>>> Any other feedback in UATs are most welcome to improve the quality. >>>> Going >>>> forward we would follow the same practice. >>>> >>>> Thanks to Aman Mishra for providing the UATs for both stories. >>>> >>>> >>>> Best Regards, >>>> -- >>>> Rishi Solanki >>>> Sr. Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> >>>> >>>> >
Re: Welcome Deepak Dixit as a new PMC member
Congratulations Deepak!! :-) Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Feb 24, 2017 at 7:42 PM, Julien NICOLAS wrote: > Good news, congrats Deepak ! > > Julien. > > > > On 24/02/2017 14:08, Jacques Le Roux wrote: > >> The OFBiz PMC has invited Deepak Dixit to become a new member of the >> committee; and the committee members are happy to announce that he has >> accepted. >> >> Deepak has been involved in OFBiz for a long time now, and is a respected >> committer for 2 years. >> >> We are sure Deepak will help us to take good decisions in favour of a >> bright future for OFBiz! >> >> Please join me in welcoming and congratulating Deepak. >> >> Thanks >> >> Jacques >> PS: Deepak, I let you change your status on the wiki PMC page :) >> >> >> >
Re: OFBIZ-3972
Interesting related blog - LINK <https://blog.sqlauthority.com/2014/02/14/mysql-when-to-use-timestamp-or-datetime-difference-between-timestamp-or-datetime/> One more conversation - http://stackoverflow.com/questions/5989539/when-to-use-datetime-or-timestamp It says it depends on the context of the field for which it is used. DATETIME seems to be good choice as we will be updating field type, and it may applicable to many places. Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Feb 24, 2017 at 3:37 PM, Taher Alkhateeb wrote: > I think I would prefer DATETIME. Some reasons are found here -> > http://stackoverflow.com/questions/409286/should-i-use- > field-datetime-or-timestamp. > Given that OFBiz takes care of conversions, DATETIME seems like a more > appropriate choice > > On Fri, Feb 24, 2017 at 12:13 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi, > > > > At OFBIZ-3972 Deepak suggested > > > > < > As we have only DATETIME set as sql type and this does not support > > Milliseconds, we need to use DATETIME(3) or DATETIME(6).>> > > > > I suggested > > > > <https://dev.mysql.com/doc/ > refman/5.6/en/datetime.html > > >> > > > > Deepak rightly mentioned that in both cases we need to create an entry in > > "data migration" wiki page > > > > << we need to run alter query manually (if someone want to upgrade custom > > solution to latest)>> > > > > Please let know your thoughts and suggestions if any > > > > Jacques > > > > >
Re: [PROPOSAL] deprecate mini lang
+1 Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Tue, Feb 28, 2017 at 2:53 PM, Julien NICOLAS wrote: > +1 > > > > On 27/02/2017 13:44, Nicolas Malin wrote: > >> +1 >> >> I also agree to replace the minilang by groovy dsl for service. >> >> For screen a prefer wait a good equivalent solution for simple case. >> >> Nicolas >> >> >> Le 18/02/2017 à 10:17, Michael Brohl a écrit : >> >>> Hi everyone, >>> >>> we are currently working hard to make OFBiz a modern, quality, robust >>> and easy to use framework. >>> There are several ongoing initiatives like refactoring the core, UX, >>> changing the build and plugin system and cleaning up the javadocs, only to >>> mention a few. >>> >>> In mini lang I see another part of our project which needs a >>> refactoring/change. Here are some reasons: >>> >>> - Programming in XML is hard to deal with when it comes to refactoring. >>> >>> - The "code" cannot be debugged and is hard to review and maintain. >>> >>> - It is slower because of the overhead of parsing and processing XML >>> documents >>> >>> - It is highly verbose, even so more than Java! >>> >>> - It is difficult to reason about because everything appears as a string >>> (variables, maps, objects, etc ...) which makes it very difficult to know >>> where something was declared or modified >>> >>> - It is highly error prone and brittle (again due to string declarations) >>> >>> - It is not a full programming language (unlike groovy, or any other >>> language that supports a DSL). Thus it has many limitations that forces the >>> developer to write many more lines of code to achieve the same result. >>> >>> - The code is not reusable (limitation of the DSL) >>> >>> - The code is not composable (limitation of the DSL) >>> >>> - Minilang depends on a lot of Java constructs (implementations, not >>> interfaces) that require refactoring, making any improvements to the core >>> API more challenging >>> >>> - Minilang is used inconsistently (different DSL in widgets, services >>> and entities). Hence, we need to keep only a minimal DSL to declare things >>> only. >>> >>> >>> We already have Java based implementations for services and events and >>> there are ideas to implement a Groovy DSL which can be used as easy (or >>> easier) as mini lang and does not have the above mentioned flaws. >>> >>> I therefore like to propose to deprecate the mini lang implementation >>> which means: >>> >>> 1. there will be no new implementations based on mini lang accepted to >>> go into the code base. >>> >>> 2. mini lang and mini lang code will be maintained with bug and security >>> fixes for backwards compatibility and to support existing adopters relying >>> on mini lang. >>>There will be no new features though. >>> >>> 3. we will continously replace the mini lang implementations with Java >>> and/or Groovy code. This will be another good opportunity for contributors >>> to engage in the project. >>> >>> >>> This will certainly be a longer process and we will not stop support for >>> mini lang but I think we should avoid to add more mini lang implementations >>> to the project. >>> >>> What do you think? >>> >>> Regards, >>> >>> Michael >>> >>> >>> >>> >> >> >
Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()
+1 for using the GenericEntityException, we did similar effort in
OFBIZ-7539.
Also agree on Jacques concern that, we should also fix the NPE for
delegator coming from HtmlFormMacroLibrary.ftl. So I think for now the fix
provided in the mentioned ticket is fine OFBIZ-9230 and we should also use
the GenericEntityException. Later we should try to figure out why and when
system lose the delegator which causes the NPE. Once we would fix the
reason we should remove the fix added in the EntityUtilProperties class
method.
New fix proposal:
Change method WidgetWorker.getDelegator with following code;
public static Delegator getDelegator(Map context) {
Delegator delegator = (Delegator) context.get("delegator");
if (delegator == null) {
delegator = DelegatorFactory.getDelegator(delegatorName);
}
return delegator;
}
Please see if this proposal looks fine then we could try and see if it
works to fix the original issue reported in the ticket.
Thanks!
Rishi Solanki
Sr. Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Tue, Feb 28, 2017 at 1:49 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Thanks Wei,
>
> Please All, refer to OFBIZ-9230 to see how I temporarily handled the issue.
>
> I also agree that using GenericEntityException is better than just a
> permissive Exception
>
> But I believe we should rather fix the underlying issue I reported there.
> So I was hesitant to agree with Wei though it's maybe a better way to get
> to really fix the issue because it shows it at the UI level and non only in
> logs.
>
> Jacques
>
>
>
> Le 28/02/2017 à 03:35, Wei Zhang a écrit :
>
>> Hi,
>>
>> I found there is a try/catch block to catch Exception in
>> EntityUtilProperties.getSystemPropertyValue(). Which will catche a NPE
>> (delegator is null) when this method is called in
>> framework/widget/templates/HtmlFormMacroLibrary.ftl but we only get a
>> waring
>> message in the log file.
>>
>> So I think we should catch GenericEntityException rather than Exception
>> here
>> to expose NPE or other runtime exceptions.
>>
>> Thanks,
>>
>> Wei
>>
>>
>>
>> -
>> 程序羊
>> --
>> View this message in context: http://ofbiz.135035.n4.nabble.
>> com/Should-not-catch-Exception-in-EntityUtilProperties-getSy
>> stemPropertyValue-tp4702833.html
>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>
>>
>>
>
Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()
Thank you Wei, Jacques for your reply. What I was proposing to change method of WidgetWorker.getDelegator() method. I see whenever any form render the fields and requires delegator then it always tries to get delegator from WidgetWorker's mentioned method. Please refer MacroFormRenederer class as mentioned in the OFBIZ-9230 by Jacques. If we fix that method, then I think we should be fine and while rendering system will always have the delegator and this issue should not appear. In that case we won't required extra delegaor checks in the EntityUtilProperties class for this particular issue. In case we requied this check from other place then we need to make sure delegator always passed to EntityUtilProperties methods, instead of adding condition in the EntityUtilProperties methods. Because many methods in that class uses the delegator as parameter. Finally we should catch the GenericEntityException instead of Exception. In a way #1 and #3 needs to be work on and for #2 we should let it be as is so that in future system will report if somewhere we are losing the delegator then we could take care. That means what Jacques did in his last fix should be fine, simply log delegator is missing on console. This is what I'm proposing, but I'm okay if we want to fix delegator issue in the EntityUtilProperties class, if so then I would say to fix it for all methods which uses delegator as parameter. Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Thu, Mar 2, 2017 at 8:02 AM, Wei Zhang wrote: > I think we need to do 3 things. > > 1. Catch GenericEntityException in > EntityUtilProperties.getSystemPropertyValue() > 2. Create a new Delegator if it is null in > EntityUtilProperties.getSystemPropertyValue() > 3. Find out how to get a delegator instance in > framework/widget/templates/HtmlFormMacroLibrary.ftl > > > > > - > 程序羊 > -- > View this message in context: http://ofbiz.135035.n4.nabble. > com/Should-not-catch-Exception-in-EntityUtilProperties- > getSystemPropertyValue-tp4702833p4702909.html > Sent from the OFBiz - Dev mailing list archive at Nabble.com. >
Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()
Thanks!
Rishi Solanki
Sr. Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Thu, Mar 2, 2017 at 3:10 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
>
>
> Le 02/03/2017 à 08:00, Rishi Solanki a écrit :
>
>> Thank you Wei, Jacques for your reply.
>>
>> What I was proposing to change method of WidgetWorker.getDelegator()
>> method. I see whenever any form render the fields and requires delegator
>> then it always tries to get delegator from WidgetWorker's mentioned
>> method.
>> Please refer MacroFormRenederer class as mentioned in the OFBIZ-9230 by
>> Jacques.
>>
>> If we fix that method, then I think we should be fine and while rendering
>> system will always have the delegator and this issue should not appear. In
>> that case we won't required extra delegaor checks in the
>> EntityUtilProperties class for this particular issue.
>>
> Actually no. EntityUtilProperties.getSystemPropertyValueI() I change in
> my patch is only used by EntityUtilProperties methods (getMessage, 2
> getPropertyValue, propertyValueEqualsIgnoreCase)
> But those are widely used in OFBiz, not only in the context of widget
>
>> In case we requied this check from other place then we need to make sure
>> delegator always
>> passed to EntityUtilProperties methods, instead of adding condition in the
>> EntityUtilProperties methods. Because many methods in that class uses the
>> delegator as parameter.
>>
> The EntityUtilProperties methods which needs a delegator are actually
> those above because they call getSystemPropertyValue() which needs the
> delegator, not for other reasons.
>
>> Finally we should catch the GenericEntityException instead of Exception.
>> In
>> a way #1 and #3 needs to be work on and for #2 we should
>> let it be as is so that in future system will report if somewhere we are
>> losing the delegator then we could take care. That means what Jacques did
>> in his last fix should be fine, simply log delegator is missing on
>> console.
>>
>
> So you propose not to use the "default" delegator but simply log the
> error. I agree this is better.
> But we will face issues in the UI like the one reported by 程序羊 in log (try
> replacing Exception by GenericEntityException and then get to
> https://localhost:8443/partymgr/control/main)
> And I don't see a simple and quick fix for the missing delegator :/
>
>> This is what I'm proposing, but I'm okay if we want to fix delegator issue
>> in the EntityUtilProperties class, if so then I would say to fix it for
>> all
>> methods which uses delegator as parameter.
>>
>
> If you mean EntityUtilProperties methods then my workaround is "OK".
> Actually there are 1 other places where we use
> delegator = DelegatorFactory.getDelegator("default");
> checkRhsType()
> (also one in tests with delegatorCreationUsingFactoryGetDelegator() that
> we can neglect)
>
> I attach in the Jira the patch I finally propose and we should continue to
> discuss there IMO
>
> Thanks
>
> Jacques
>
>
>
>
>> Thanks!
>>
>>
>>
>>
>>
>> Rishi Solanki
>> Sr. Manager, Enterprise Software Development
>> HotWax Systems Pvt. Ltd.
>> Direct: +91-9893287847
>> http://www.hotwaxsystems.com
>>
>> On Thu, Mar 2, 2017 at 8:02 AM, Wei Zhang
>> wrote:
>>
>> I think we need to do 3 things.
>>>
>>> 1. Catch GenericEntityException in
>>> EntityUtilProperties.getSystemPropertyValue()
>>> 2. Create a new Delegator if it is null in
>>> EntityUtilProperties.getSystemPropertyValue()
>>> 3. Find out how to get a delegator instance in
>>> framework/widget/templates/HtmlFormMacroLibrary.ftl
>>>
>>>
>>>
>>>
>>> -
>>> 程序羊
>>> --
>>> View this message in context: http://ofbiz.135035.n4.nabble.
>>> com/Should-not-catch-Exception-in-EntityUtilProperties-
>>> getSystemPropertyValue-tp4702833p4702909.html
>>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>>
>>>
>>
>
Re: Should be keep the multitenant feature even if broken?
I dig into the issue and proposed one solution in the same Jira ticket OFBIZ-9230. Please see if it looks fine or may be we can proceed in that direction. Quick Reference from ticket: "In the template/FTL context or in the screen context whenever we get the delegator as null we can use this delegatorName first from session and if it is empty then we could try to use default delegator." Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Mar 4, 2017 at 1:13 AM, Taher Alkhateeb wrote: > All good points Michael. Replacing is neither short term nor easy as many > places in the code base depend on this feature, not to mention the need for > community approval too. I just mentioned this as an alternative solution > from a technical standpoint. > > So our best bet is to fix the issue mentioned by Jacques. > > On Mar 3, 2017 9:16 PM, "Michael Brohl" wrote: > > > Hi Taher, > > > > I don't think that this is a valid short-term approach. > > > > As far as I know, there are users and also service providers relying on > > the multi-tenant feature and we should have a mid- to long-term roadmap > for > > a migration to other solutions. > > > > It would be really helpful to have some opinions by users of the > > multi-tenancy feature. > > > > Best regards, > > > > Michael > > > > > > Am 03.03.17 um 13:22 schrieb Taher Alkhateeb: > > > >> In my opinion, the multi-tenancy feature can be reasonably replaced with > >> non-java databases like mysql and postgres combined with docker. Both > >> instances share the same code base but with two different runtime > volumes > >> and two databases. This would actually reduce the complexity of the code > >> base, especially the entity engine. > >> > >> On Mar 3, 2017 10:39 AM, "Jacques Le Roux" < > jacques.le.r...@les7arts.com> > >> wrote: > >> > >> Hi, > >>> > >>> After my analysis at https://s.apache.org/hvR9 if we don't fix the > >>> issues > >>> reported there I wonder if we don't need to remove the multitenant > >>> feature, > >>> better not to propose a broken solution! > >>> > >>> Jacques > >>> > >>> > >>> > > > > >
Re: Should be keep the multitenant feature even if broken?
Thanks Jacques! -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Mar 8, 2017 at 3:37 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks for your ideas Rishi, > > Fixed with OFBIZ-9230 > > I had a look at checkRhsType() but that's another beast. Because AFAIK the > delegator only misses when checkRhsType is called indirectly from the > JobPoller. > > It begins to miss in this line in selectCountByCondition() > > makeConditionWhereString(sqlBuffer, " WHERE ", modelEntity, > whereEntityCondition, viewWhereConditions, whereEntityConditionParams); > > I have created OFBIZ-9249, it's minor but not trivial! > > Jacques > > > > Le 04/03/2017 à 15:07, Rishi Solanki a écrit : > >> I dig into the issue and proposed one solution in the same Jira ticket >> OFBIZ-9230. Please see if it looks fine or may be we can proceed in that >> direction. >> >> Quick Reference from ticket: "In the template/FTL context or in the screen >> context whenever we get the delegator as null we can use this >> delegatorName >> first from session and if it is empty then we could try to use default >> delegator." >> >> Thanks! >> >> >> Rishi Solanki >> Sr. Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Sat, Mar 4, 2017 at 1:13 AM, Taher Alkhateeb < >> slidingfilame...@gmail.com> >> wrote: >> >> All good points Michael. Replacing is neither short term nor easy as many >>> places in the code base depend on this feature, not to mention the need >>> for >>> community approval too. I just mentioned this as an alternative solution >>> from a technical standpoint. >>> >>> So our best bet is to fix the issue mentioned by Jacques. >>> >>> On Mar 3, 2017 9:16 PM, "Michael Brohl" >>> wrote: >>> >>> Hi Taher, >>>> >>>> I don't think that this is a valid short-term approach. >>>> >>>> As far as I know, there are users and also service providers relying on >>>> the multi-tenant feature and we should have a mid- to long-term roadmap >>>> >>> for >>> >>>> a migration to other solutions. >>>> >>>> It would be really helpful to have some opinions by users of the >>>> multi-tenancy feature. >>>> >>>> Best regards, >>>> >>>> Michael >>>> >>>> >>>> Am 03.03.17 um 13:22 schrieb Taher Alkhateeb: >>>> >>>> In my opinion, the multi-tenancy feature can be reasonably replaced with >>>>> non-java databases like mysql and postgres combined with docker. Both >>>>> instances share the same code base but with two different runtime >>>>> >>>> volumes >>> >>>> and two databases. This would actually reduce the complexity of the code >>>>> base, especially the entity engine. >>>>> >>>>> On Mar 3, 2017 10:39 AM, "Jacques Le Roux" < >>>>> >>>> jacques.le.r...@les7arts.com> >>> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>>> After my analysis at https://s.apache.org/hvR9 if we don't fix the >>>>>> issues >>>>>> reported there I wonder if we don't need to remove the multitenant >>>>>> feature, >>>>>> better not to propose a broken solution! >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> >>>>>> >>>> >
Re: Documentation by Release / Version
See if this effort can be part of - https://cwiki.apache.org/confluence/display/OFBIZ/Business+Process+Stories+and+Use+Cases+Library For more details please refer the email thread - ofbiz.markmail.org/search/?q=User+Acceptance+Test+Cases+For+Ecommerce+14.12 Or you would like to do it as completely separate effort and document will target completely different audiance/purpose? Thanks! Regards, -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Mar 10, 2017 at 4:05 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > Jacques > > > Le 10/03/2017 à 02:45, james yong a écrit : > >> Hi Jacques, >> >> I like your approach too. I propose creating a Tour page in Confluence. >> This tour page will have a direct child page for the recent OFBiz >> releases, >> like the following menu structure: >> >> Tour >> -> Release 13.7 >> -> Release 16.11 >> >> Each of the Release xx.x page is a Table of Content that links to other >> existing pages. >> The tour is meant for beginner and they are expected to go through the >> topics from top to bottom. >> With this approach, there will not be direct child page under each >> Release >> xx.x page. Existing documentation isn’t affected. >> >> Regards, >> James >> >> >> >> Jacques Le Roux wrote >> >> Hi James, >>> >>> I'm all for it. >>> >>> Note that I already used another strategy by referring to the history of >>> few major pages[1] while documenting the Gradle from Ant. It though was a >>> more an expedient than a structured way as you are proposing. But it >>> could >>> still be used when referring to old pages... >>> >>> [1] These pages contain the sentence "the pre-Gradle documentation is >>> here", eg >>> https://cwiki.apache.org/confluence/display/OFBIZ/Demo+and+ >>> Test+Setup+Guide >>> >>> Jacques >>> >>> >>> Le 08/03/2017 à 18:05, james yong a écrit : >>> >>>> Hi all, >>>> >>>> I am planning to add some new documentation in Confluence but will have >>>> them >>>> placed/linked under the affected OFBiz release / version. For a user >>>> navigating the documentation, the user can click on a particular OFBiz >>>> release on the menu tree to display the list of topic for that OFBiz >>>> version. >>>> >>>> What do you think of this approach? Are there better ways to structure >>>> the >>>> menu items? >>>> >>>> Cheers, >>>> James Yong >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://ofbiz.135035.n4.nabble.com/Documentation-by-Release-V >>>> ersion-tp4703069.html >>>> Sent from the OFBiz - Dev mailing list archive at Nabble.com. >>>> >>>> >> >> >> >> -- >> View this message in context: http://ofbiz.135035.n4.nabble. >> com/Documentation-by-Release-Version-tp4703069p4703111.html >> Sent from the OFBiz - Dev mailing list archive at Nabble.com. >> >> >> >
Re: User Acceptance Test Cases For Ecommerce 14.12
Folks, We have completed the first draft of the document for the Ecommerce Component <https://cwiki.apache.org/confluence/display/OFBIZ/E-commerce+14.12> and added UATs for all the user stories. Also we have follow the pattern to use h4 h5 and h6 headings in the documents so that user can easily navigate to the user story/ user acceptance test she wants. As a first draft we tried to cover all known possible tests, but it might be possible we missed something. We would like to get feedback from community so that we can make it better in terms of usability, readability and number of items we have tested. Please review and share your feedback on each item, like language we use, document formation, use cases we covered etc. We would try to cover them in our next draft and improve the document. And once finalize we would start using that pattern going forward for all such documents. Thanks! Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Feb 18, 2017 at 9:49 PM, Rishi Solanki wrote: > Folks, > > Added two more UAT as Category Navigation and Product Search > <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12>. I > observe some scope of improvements like UAT writing aren't following common > patterns, I'll review and fix them soon. > > Soon we would add remaining in the ecommerce area, looking for your > feedback and suggestions on it. > > > Rishi Solanki > Sr. Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > > On Tue, Jan 24, 2017 at 7:01 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Thanks Rishi, >> >> Indeed I needed a clarification, sorry for that. >> >> It's a great initiative, OFBiz will then really be at professional >> standards, and that's great! >> >> I agree that we have first to create and document these UAT and then >> think about a tool to run them. >> Cucumber seems the best tool for that to me. I also know that Gil >> (Portenseigne) from Néréide has begun to use Cucumber for a custom project, >> hence my haste :) >> >> Jacques >> >> >> >> Le 23/01/2017 à 08:05, Rishi Solanki a écrit : >> >>> Thanks Jacques for your reply and raising concerns. It seems that, I was >>> not clear enough. Let me try to rephrase what we are doing. If you >>> observe >>> then Pranay has created new hierachy for each release like 14.12, 15.12 >>> ... >>> so on. >>> >>> For each release we have the user stories, and we are adding UATs for >>> each >>> user story. For each user story we are discussing the cases we should >>> test >>> manually and also try them to dicuss on the mailing list (user/dev). Once >>> we are sure, we document and test the cases (manually) and put the >>> results >>> in the Actual results and Pass/Fail. >>> >>> Please note that, before documenting anything as Pass or Fail we are >>> really >>> running that scenario. The intention of doing this, we can say that the >>> released branches of OFBiz are tested on certain scenarios and all get >>> passed. After completing this activity, we as a community can say 14.12 >>> branch tested for say 1000 user acceptance test cases and out of them 950 >>> get passed and 50 are reported and fail for that branch. Once we complete >>> this activity, we could start fixing them. >>> >>> For the same we have started multiple email threads to get the feedback >>> from community, so that we could get more cases for the user stories. In >>> other words, we have automated tests with us, but this time we are trying >>> to add documents for the manual tests user could see and increase in >>> faith >>> on each relase. >>> >>> I hope I'm clear this time :-). And yes I agree on the fact that we >>> should >>> think on automating these tests to run them frequently. And I think for >>> that we again need what to tests get documented. We can assume it as >>> first >>> step towards automation. >>> >>> PS: Team, please add more details if I miss something. >>> >>> >>> Rishi Solanki >>> Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> >>> On Sun, Jan 22, 2017 at 5:00 PM, Jacques Le Roux < >>> jacques.le.r...@les7arts
Re: User Acceptance Test Cases For Ecommerce 14.12
Thanks Taher, Yes Jacques also push the similar idea in this thread, and we do agree with him to add automated tests to run them frequently. Adding UATs requires focus on the process with passion. Again I do agree here to add the selenium, soon we would try to plan this effort. Thanks again, Community please review and share your feedback so that we can improve and follow the practice in all other component documents. Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Apr 15, 2017 at 9:22 PM, Taher Alkhateeb wrote: > Great work Rishi, keep them coming! > > I wonder if you can also create some selenium scripts to automate some of > these tests and add them to the wiki? > > On Sat, Apr 15, 2017 at 6:30 PM, Rishi Solanki > wrote: > > > Folks, > > > > We have completed the first draft of the document for the Ecommerce > > Component > > <https://cwiki.apache.org/confluence/display/OFBIZ/E-commerce+14.12> and > > added UATs for all the user stories. Also we have follow the pattern to > use > > h4 h5 and h6 headings in the documents so that user can easily navigate > to > > the user story/ user acceptance test she wants. > > > > As a first draft we tried to cover all known possible tests, but it might > > be possible we missed something. We would like to get feedback from > > community so that we can make it better in terms of usability, > readability > > and number of items we have tested. > > > > Please review and share your feedback on each item, like language we use, > > document formation, use cases we covered etc. We would try to cover them > in > > our next draft and improve the document. And once finalize we would start > > using that pattern going forward for all such documents. > > > > Thanks! > > > > > > Rishi Solanki > > Sr. Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > > > On Sat, Feb 18, 2017 at 9:49 PM, Rishi Solanki > > wrote: > > > > > Folks, > > > > > > Added two more UAT as Category Navigation and Product Search > > > <https://cwiki.apache.org/confluence/display/OFBIZ/Ecommerce+14.12>. I > > > observe some scope of improvements like UAT writing aren't following > > common > > > patterns, I'll review and fix them soon. > > > > > > Soon we would add remaining in the ecommerce area, looking for your > > > feedback and suggestions on it. > > > > > > > > > Rishi Solanki > > > Sr. Manager, Enterprise Software Development > > > HotWax Systems Pvt. Ltd. > > > Direct: +91-9893287847 > > > http://www.hotwaxsystems.com > > > > > > On Tue, Jan 24, 2017 at 7:01 PM, Jacques Le Roux < > > > jacques.le.r...@les7arts.com> wrote: > > > > > >> Thanks Rishi, > > >> > > >> Indeed I needed a clarification, sorry for that. > > >> > > >> It's a great initiative, OFBiz will then really be at professional > > >> standards, and that's great! > > >> > > >> I agree that we have first to create and document these UAT and then > > >> think about a tool to run them. > > >> Cucumber seems the best tool for that to me. I also know that Gil > > >> (Portenseigne) from Néréide has begun to use Cucumber for a custom > > project, > > >> hence my haste :) > > >> > > >> Jacques > > >> > > >> > > >> > > >> Le 23/01/2017 à 08:05, Rishi Solanki a écrit : > > >> > > >>> Thanks Jacques for your reply and raising concerns. It seems that, I > > was > > >>> not clear enough. Let me try to rephrase what we are doing. If you > > >>> observe > > >>> then Pranay has created new hierachy for each release like 14.12, > 15.12 > > >>> ... > > >>> so on. > > >>> > > >>> For each release we have the user stories, and we are adding UATs for > > >>> each > > >>> user story. For each user story we are discussing the cases we should > > >>> test > > >>> manually and also try them to dicuss on the mailing list (user/dev). > > Once > > >>> we are sure, we document and test the cases (manually) and put the > > >>> results > > >>> in the Actual results and Pass/Fail.
Re: [Order] - Sales Food
+1 for using user list for such questions. For your question please look around the OrderItemShipGroup.maySplit and related code should be helpful. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Jun 23, 2017 at 1:54 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > Please use rather user ML for such questions, see why here > http://ofbiz.apache.org/mailing-lists.html > You will get a better support and it's more fair to share with everybody > > The wider the audience the better the answers you might get > > Thanks > > Jacques > > > > Le 23/06/2017 à 04:04, Trà Đá Một Mình a écrit : > >> Hi all, >> >> I face this case: we want to sales product like meat, fruit, rice, >> (Food)... which measuring by weight (weight_uom). As i knew, in >> orderItem >> we need create selectedAmount = weight we want to sales. Ex: We has 10kg >> beef need to sales. I created an orderItem with quantity = 1, and >> selectedAmount = 10. But, when we picking inventory, we found has only >> 8kg. >> I don't know how to completed this order. Because all of work process >> using >> quantity to check orderItem completed or not yet. >> And in extended case: I want to picking more than one time. Ex: with 10kg >> beef, we picking 2 time, 8kg today and 2kg in tomorrow. How to do that? >> >> Thanks! >> >> >
Document Location
Hi Pierre Smits/All, I just gone thru the the blog post by Pierre Smits, Brewing with OFBiz at a small or medium sized brewery <https://cwiki.apache.org/confluence/x/64HoAg> I see this is good case study thanks Pierre for that. The only concern I have is this is under the 'Business Process Stories and Use Cases Library' as parent. I would propose new location for the document. Current Location: Document > Business Process Stories and Use Cases Library > Brewing with OFBiz at a small or medium sized brewery Proposed Location: Document > Case Study > Brewing with OFBiz at a small or medium sized brewery Proposing this so that in case other wanted to add case study then all can be found at one place. If everyone agree then we can move this to new location. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com
Re: OFBiz Sanity Test Document
Thanks Sanjay for great effort, Moving this thread to dev list for better handling of feedback. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sun, Jul 9, 2017 at 3:46 PM, Sanjay Yadav wrote: > Hello Everyone, > > I've created OFBiz Sanity Test document at below location - > > <http://goog_291272848> > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test > > Please have a look and let me know your feedback. Thanks! > > > Best Regards, > > *Sanjay Yadav* | Manager, Enterprise Quality Assurance > HotWax Commerce <http://www.hotwax.co/> by HotWax Systems > <http://www.hotwaxsystems.com/> > 80, Scheme No. 78, Part II, Indore, M.P. 452010, India > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav > <https://www.linkedin.com/in/sanjay-yadav/> > > HotWax Systems recently received 8 mentions in *The Gartner Digital > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT > research and advisory company. Learn more about our research here > <https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html> > . > [image: Inline image 1] > > >
Re: Document Location
Thanks all, in case no objection in a day or two we will do the changes in structure. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 10, 2017 at 11:10 AM, Sanjay Yadav < sanjay.ya...@hotwaxsystems.com> wrote: > +1 > > Best Regards, > > *Sanjay Yadav* | Manager, Enterprise Quality Assurance > HotWax Commerce <http://www.hotwax.co/> by HotWax Systems > <http://www.hotwaxsystems.com/> > 80, Scheme No. 78, Part II, Indore, M.P. 452010, India > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav > <https://www.linkedin.com/in/sanjay-yadav/> > > HotWax Systems recently received 8 mentions in *The Gartner Digital > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT > research and advisory company. Learn more about our research here > <https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html> > . > [image: Inline image 1] > > > > On Mon, Jul 10, 2017 at 10:52 AM, Pranay Pandey < > pranay.pan...@hotwaxsystems.com> wrote: > >> +1 >> >> Best regards, >> Pranay Pandey >> www.hotwaxsystems.com >> >> >> On Sun, Jul 9, 2017 at 2:33 PM, Rishi Solanki >> wrote: >> >> > Hi Pierre Smits/All, >> > >> > I just gone thru the the blog post by Pierre Smits, Brewing with OFBiz >> at a >> > small or medium sized brewery <https://cwiki.apache.org/ >> > confluence/x/64HoAg> >> > >> > I see this is good case study thanks Pierre for that. The only concern I >> > have is this is under the 'Business Process Stories and Use Cases >> Library' >> > as parent. I would propose new location for the document. >> > >> > Current Location: Document > Business Process Stories and Use Cases >> Library >> > > Brewing with OFBiz at a small or medium sized brewery >> > >> > Proposed Location: Document > Case Study > Brewing with OFBiz at a >> small or >> > medium sized brewery >> > >> > >> > Proposing this so that in case other wanted to add case study then all >> can >> > be found at one place. >> > >> > If everyone agree then we can move this to new location. >> > >> > >> > Thanks! >> > >> > Rishi Solanki >> > Sr Manager, Enterprise Software Development >> > HotWax Systems Pvt. Ltd. >> > Direct: +91-9893287847 >> > http://www.hotwaxsystems.com >> > >> > >
Re: [Discussion] Failing the build if data loading fails
I'm good to go with option #3 and continue-on-failure. Just wanted to mention one thing here; for which type of data we will be failing build. That means, we have several options seed, ext, demo. Do we need to discuss these points or we are fine for all type of data. Like demo data fails only affect a process for that data set only, and for that failing build is okay or not (as on data load we get logs if any file didn't load). Btw, I'm good with the proposal, just sharing a thought in case we should discuss or may be we can simply ignore if we are good with that. Thaks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > > Historically the data loader boolean props are false if ommitted and the > > code expects that, but you have a point about the double negative. We can > > instead call it "continue-on-failure" for example. > > > > +1 continue-on-failure with default value false > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > > > > > > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" wrote: > > > > Hi all, > > > > I agree with option 3. I recall in my own work I once needed to add a > throw > > where there was none to track down a problem. > > > > However ignore-failure leads to a double negative. How about > > "stop-on-failure", default value true? > > > > Cheers > > > > Paul Foxworthy > > > > > > On 10 July 2017 at 05:27, Taher Alkhateeb > > wrote: > > > > > Correction: on item (2) in my post: fail immediately, not after > > > loading all files, otherwise there's no point. > > > > > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb > > > wrote: > > > > Hello Everyone, > > > > > > > > For a long time I was annoyed by something in OFBiz: the build system > > > > does not fail if data loading fails for some files. I spend hours > > > > hunting bugs only to discover that the data simply did not load. > > > > > > > > Given that I'm working on refactoring the data loading container, I > > > > believe this issue should resolved. However, I'm not sure if the > > > > community is interested in making such a change. > > > > > > > > So I list below 3 options to select from: > > > > > > > > 1- Leave it as is, do not fail the build if some files do not load > > > > 2- Continue loading until all files are done and then fail the build > > > > 3- Provide a flag e.g. ignore-failure that tells the system whether > to > > > > fail or not with a default value of "false". > > > > > > > > My personal preference is for (3) > > > > > > > > WDYT? > > > > > > > > > > > -- > > Coherent Software Australia Pty Ltd > > PO Box 2773 > > Cheltenham Vic 3192 > > Australia > > > > Phone: +61 3 9585 6788 > > Web: http://www.coherentsoftware.com.au/ > > Email: i...@coherentsoftware.com.au > > >
Re: [Discussion] Failing the build if data loading fails
Thanks Taher for your reply. I was just pushing the types to set some type of data as in ignoring. But, now I am completely agree with you on point "The data will automatically get cleaned by committers because no failing data will be committed to the code base". Again +1 for #3 with option continue-on-failure with default false, with no confusion in thread from my side. :-) -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb wrote: > Hi Rishi, > > So my suggestion is that if anything does not load, then immediately fail. > > Why am I suggesting this? > - You have to intentionally ignore data failure after being aware of > it (it does not slip between the cracks) > - The data will automatically get cleaned by committers because no > failing data will be committed to the code base. > > I suspect we will actually catch some data loading failures that exist > in the code base and we are maybe unaware of. > > On Mon, Jul 10, 2017 at 12:04 PM, Rishi Solanki > wrote: > > I'm good to go with option #3 and continue-on-failure. > > > > Just wanted to mention one thing here; for which type of data we will be > > failing build. That means, we have several options seed, ext, demo. Do we > > need to discuss these points or we are fine for all type of data. Like > demo > > data fails only affect a process for that data set only, and for that > > failing build is okay or not (as on data load we get logs if any file > > didn't load). > > > > > > Btw, I'm good with the proposal, just sharing a thought in case we should > > discuss or may be we can simply ignore if we are good with that. > > > > Thaks! > > > > > > > > Rishi Solanki > > Sr Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > > > On Mon, Jul 10, 2017 at 2:15 PM, Deepak Dixit < > > deepak.di...@hotwaxsystems.com> wrote: > > > >> > Historically the data loader boolean props are false if ommitted and > the > >> > code expects that, but you have a point about the double negative. We > can > >> > instead call it "continue-on-failure" for example. > >> > > >> > >> +1 continue-on-failure with default value false > >> > >> Thanks & Regards > >> -- > >> Deepak Dixit > >> www.hotwaxsystems.com > >> www.hotwax.co > >> > >> > >> > >> > > >> > On Jul 10, 2017 3:48 AM, "Paul Foxworthy" > wrote: > >> > > >> > Hi all, > >> > > >> > I agree with option 3. I recall in my own work I once needed to add a > >> throw > >> > where there was none to track down a problem. > >> > > >> > However ignore-failure leads to a double negative. How about > >> > "stop-on-failure", default value true? > >> > > >> > Cheers > >> > > >> > Paul Foxworthy > >> > > >> > > >> > On 10 July 2017 at 05:27, Taher Alkhateeb > > >> > wrote: > >> > > >> > > Correction: on item (2) in my post: fail immediately, not after > >> > > loading all files, otherwise there's no point. > >> > > > >> > > On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb > >> > > wrote: > >> > > > Hello Everyone, > >> > > > > >> > > > For a long time I was annoyed by something in OFBiz: the build > system > >> > > > does not fail if data loading fails for some files. I spend hours > >> > > > hunting bugs only to discover that the data simply did not load. > >> > > > > >> > > > Given that I'm working on refactoring the data loading container, > I > >> > > > believe this issue should resolved. However, I'm not sure if the > >> > > > community is interested in making such a change. > >> > > > > >> > > > So I list below 3 options to select from: > >> > > > > >> > > > 1- Leave it as is, do not fail the build if some files do not load > >> > > > 2- Continue loading until all files are done and then fail the > build > >> > > > 3- Provide a flag e.g. ignore-failure that tells the system > whether > >> to > >> > > > fail or not with a default value of "false". > >> > > > > >> > > > My personal preference is for (3) > >> > > > > >> > > > WDYT? > >> > > > >> > > >> > > >> > > >> > -- > >> > Coherent Software Australia Pty Ltd > >> > PO Box 2773 > >> > Cheltenham Vic 3192 > >> > Australia > >> > > >> > Phone: +61 3 9585 6788 > >> > Web: http://www.coherentsoftware.com.au/ > >> > Email: i...@coherentsoftware.com.au > >> > > >> >
Re: Document Location
Thanks Michael, Just to be super clear you are proposing; Instead of moving to here: Document > Case Studies > Brewing with OFBiz at a small or medium sized brewery Better place is: Community/ References/ Case Studies > Brewing with OFBiz at a small or medium sized brewery And in case anyone want to contribute more case studies then she can add her own page under Case Studies parallel to Brewing with OFBiz at a small or medium sized brewery +1 from my side and will do this change in a day or two in case no objection/concerns/suggestion. Thanks! -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 10, 2017 at 3:29 PM, Michael Brohl wrote: > Hi Rishi, > > it's a good idea to move this out of the Uses Cases Library. I think that > it does not belong in the documentation section at all. > > The documentation section should, after the restructure, only contain > documentation which belongs to the core OFBiz system. > > I propose to move this to Community/ References/ Case Studies (new page), > which seems to be a more appropriate place to me. > > Best regards, > > Michael Brohl > ecomify GmbH > www.ecomify.de > > > Am 10.07.17 um 08:17 schrieb Rishi Solanki: > >> Thanks all, in case no objection in a day or two we will do the changes in >> structure. >> >> >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Mon, Jul 10, 2017 at 11:10 AM, Sanjay Yadav < >> sanjay.ya...@hotwaxsystems.com> wrote: >> >> +1 >>> >>> Best Regards, >>> >>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance >>> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems >>> <http://www.hotwaxsystems.com/> >>> 80, Scheme No. 78, Part II, Indore, M.P. 452010, India >>> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav >>> <https://www.linkedin.com/in/sanjay-yadav/> >>> >>> HotWax Systems recently received 8 mentions in *The Gartner Digital >>> Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT >>> research and advisory company. Learn more about our research here >>> <https://www.gartner.com/technology/media-products/newslette >>> rs/HotWax/1-2UVLP6M/index.html> >>> >>> . >>> [image: Inline image 1] >>> >>> >>> >>> On Mon, Jul 10, 2017 at 10:52 AM, Pranay Pandey < >>> pranay.pan...@hotwaxsystems.com> wrote: >>> >>> +1 >>>> >>>> Best regards, >>>> Pranay Pandey >>>> www.hotwaxsystems.com >>>> >>>> >>>> On Sun, Jul 9, 2017 at 2:33 PM, Rishi Solanki >>>> wrote: >>>> >>>> Hi Pierre Smits/All, >>>>> >>>>> I just gone thru the the blog post by Pierre Smits, Brewing with OFBiz >>>>> >>>> at a >>>> >>>>> small or medium sized brewery <https://cwiki.apache.org/ >>>>> confluence/x/64HoAg> >>>>> >>>>> I see this is good case study thanks Pierre for that. The only concern >>>>> I >>>>> have is this is under the 'Business Process Stories and Use Cases >>>>> >>>> Library' >>>> >>>>> as parent. I would propose new location for the document. >>>>> >>>>> Current Location: Document > Business Process Stories and Use Cases >>>>> >>>> Library >>>> >>>>> Brewing with OFBiz at a small or medium sized brewery >>>>>> >>>>> Proposed Location: Document > Case Study > Brewing with OFBiz at a >>>>> >>>> small or >>>> >>>>> medium sized brewery >>>>> >>>>> >>>>> Proposing this so that in case other wanted to add case study then all >>>>> >>>> can >>>> >>>>> be found at one place. >>>>> >>>>> If everyone agree then we can move this to new location. >>>>> >>>>> >>>>> Thanks! >>>>> >>>>> Rishi Solanki >>>>> Sr Manager, Enterprise Software Development >>>>> HotWax Systems Pvt. Ltd. >>>>> Direct: +91-9893287847 >>>>> http://www.hotwaxsystems.com >>>>> >>>>> >>> > >
Re: Naming Conventions
Technically we use following terminology; 1. Application Menu 2. Pre Body (as we may render something other than sub menu like page title only or may be left empty) 4. Body For #3 some times it is part of prebody and sometimes it will be part of body. No logical break done for this so far in the decorator patter OFBiz uses. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Jul 19, 2017 at 8:43 AM, Craig Parker wrote: > This may be nit-picky, but I'm thinking it might be important down the > road as docs get a makeover. What are these areas officially called that > I've numbered in the screenshot? There looks to be an equivalent in > whatever theme I'm using. > > 1. Menu > 2. Sub menu? (flies out in one theme) > 3. Links area? > 4. Work area? > >
Re: analyse the user permission
Browse to the URL shared by Viqar, you will see the list of security groups
and each group contains the permissions associated with it.
For example:
https://demo-trunk-ofbiz.apache.org:8443/partymgr/control/EditSecurityGroupPermissions?groupId=MYPORTAL_EMPLOYEE
Also component level permission configured in the component level
ofbiz-compnent.xml
HTH!
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Thu, Jul 20, 2017 at 3:49 PM, Ismail Al Kouz wrote:
> Thank you , But I mean permission to URL " https://127.0.0.1:8443/
> accounting/control/main "
> How I can analyze /accounting or /humanres 'example' based on userlogin
> or party id
>
> Best Regards,
>
> Ismail Alkouz
> Java Developer
>
>
>
>
>
>
> P.O.Box 3516 Amman, 11821
> The Hashemite Kingdom of Jordan
> Tel. +962 (6) 556 2620
> Mob (Jordan). +962 79 282 2098
>
>
> /biict
> @biict
>
>
> -Original Message-
> From: Deepak Nigam [mailto:deepak.ni...@hotwaxsystems.com]
> Sent: Wednesday, July 19, 2017 2:58 PM
> To: dev@ofbiz.apache.org
> Subject: Re: analyse the user permission
>
> Hi Ismail,
>
> You can refer the following set of data (copied from HumanResDemoData.xml)
>
> currentPassword="{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a"
> requirePasswordChange="N" partyId="DemoEmployee"/>
>
>
>
> permissionId="EMPLOYEE_VIEW"/>
>
> permissionId="EMPLOYEE_VIEW"/>
>
> userLoginId="demoemployee" fromDate="2001-01-01 12:00:00.0"/>
>
>
>
> Thanks & Regards
> --
> Deepak Nigam
> Technical Consultant/Team Lead
> Hotwax Systems
> www.hotwaxsystems.com
>
> On Wed, Jul 19, 2017 at 5:03 PM, Ismail Al Kouz
> wrote:
>
> > Hello Guys.
> >
> >
> >
> > How I can analyze the user permission based on userLoginId or PartyId
> >
> >
> >
> > thanks
> >
> >
> >
> > *Best Regards,*
> >
> >
> >
> > *Ismail Alkouz*
> >
> > Java Developer
> >
> >
> >
> > [image: Description: Logo for Office-4]
> >
> >
> >
> > [image: Description: bi email-3-02]
> >
> >
> >
> > P.O.Box 3516 Amman, 11821
> >
> > The Hashemite Kingdom of Jordan
> >
> > *Tel.* +962 (6) 556 2620
> >
> > *Mob (Jordan).* +962 79 282 2098
> >
> > [image: Description: bi email-3-04]
> >
> > [image: Description: bi email-3-05]
> >
> > /biict
> >
> > @biict
> >
> >
> >
> >
> >
>
Re: Usage of setServiceFields method in ServiceUtil.java file.
I think, what Ujjawal wants to propose is where ever applicable we should use ServiceUtil.setServiceFields() method to prepare the service context to call the service. Also I look at the other proposal by Deepak to use makeValidContext() of DispatchContext, but I cross check the service util method proposed by Ujjawal internally call the same. So I think, where applicable we should use the ServiceUtil method proposed by Ujjawal. It will surely reduce the code lines if we use this utility method. Big +1 on the caution mentioned by Deepak to use it correctly with extra care. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sat, Jul 22, 2017 at 6:28 PM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > I think Ujjawal is proposing to use ServiceUtil.setServiceFields method to > prepare service in context. > Instead of creating map and set values hardcoded, > > I think instead of using setServiceField we can use makeValidContext() > of DispatchContext > class file. > And be clear while using these method as it set all the service in param in > context, either you want to set it or not. > Need to make sure that we use it correctly. > > > > > > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Sat, Jul 22, 2017 at 6:16 PM, Taher Alkhateeb < > slidingfilame...@gmail.com > > wrote: > > > Hi Ujjawal, > > > > Sorry maybe I lost track, but what are you recommending? > > > > On Sat, Jul 22, 2017 at 3:26 PM, Ujjawal Solanki > > wrote: > > > Hello all, > > > I was going through ServiceUtil.java and found that there is a method > > > called setServiceFields ( whose purpose is to take in in parameter of a > > > service and returns the out parameter using modalService ) which can be > > > used in many other part of code as there are many instance ( code > blocks > > ) > > > where same code is written as in this setServiceFields method. > > > > > > Just for example if we see the compDocService.java file, we have same > > code > > > for modelService as present in the setServiceFields. So i think we can > > make > > > use of setServiceFields in such cases. > > > > > > Please share your opinion on the same. > > > > > > Thanks & Regards, > > > *Ujjawal Solanki* > > >
Re: [Discussion] Xml definition file for theme
Hi Nicolas, Before putting any view on the proposal, I would like to thank you for nice proposal with very nice details. Also before making any view, I would like to confirm my understanding on the proposal with some questions. - Here we would like to replace the existing theme setup which is database driven. Then how we are going to change the themes on the fly as we do currently. Are we going to use content model. Please help me here. - Are we going to replace the theme related properties files and/or db entries. - Also it seems to me the handlers we add in the controller xml file will be removed. Is it correct understanding? I'm asking these question to understand how we are going to change the themes when server is running. I'll go thru the current rendering and get back on this asap. One quick comment, please see if it make sense. But I'll surely get back with more details on overall topic. - As mentioned the extend is child element in the structure. Can we change it to 'extends' just to follow the practice we have in java, form-widget and service definitions also uses the implements. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Sun, Jul 23, 2017 at 5:10 AM, Nicolas Malin wrote: > Hello, > > With the common-theme and my idea to implement a specific model to explain > a theme, I would be sharing my recent think: > > This is an example of xml definition for the common-theme, I set a small > description to explain each block > > ## > > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ > widget-theme.xsd"> > > > > > > default-view-size="10" > default-min-lenght="2" > default-delay="300" > display-return-field="true"/> > position="topleft" > width="640" > height="500"/> > width="800" > height="600"/> > > > > type="String"/> > > > > > > > encoding="none" encoder="html" compress="false"> > > > > > > encoding="none" encoder="xml"> > > > > > content-type="application/vnd.ms-excel" encoding="none" encoder="html"> > > > > > content-type="application/pdf" encoding="none"> > > > > > encoding="none"> > > > > > encoding="none" encoder="xml"> > > > > > > > > > > > > > > > > > > > > > > > > > > > ### > > Now if I want create my specific theme with only some particularity on > html rendering et some decorator I just define this : > > ### > > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ > widget-theme.xsd"> > > > > > > > > > encoding="none" encoder="html" compress="false"> > > > > > > location="component://mytheme/widget/MyDecoratorScreens.xml"/> > > > > > > > > ### > > With the extend elemet, mytheme resolve all information from common-theme > and surchage only what is define on his xml definition file. > > I think with this type of structure we can have : > > * a base de define a screen API for homogenise the IHM > * permit to a theme to surcharge only what he want (template rendering, > widget properties, screen present on API) > * remove all theme resource information and load it direclty on the > decorator (this slim the decorator complexity, slim data to load and make > more easier to follow what implement a theme) > > If you have a few time to sharing your remark, It's the last big point to > continue and maybe load the common-theme on trunk :) > > Nicolas > > -- > logoNrd <https://nereide.fr/> > Nicolas Malin > The apache way <http://theapacheway.com/> : *Openness* Technical > decisions are made publicly > informat...@nereide.fr > 8 rue des Déportés 37000 TOURS, 02 47 50 30 54 > > Apache OFBiz <http://ofbiz.apache.org/>|The Apache Way < > http://theapacheway.com/>|ofbiz-fr <http://www.ofbiz-fr.org/>|réseau LE < > http://www.libre-entreprise.org/> >
Re: Proper record maintenance in marketing component
Suraj, I would say, MarketingCampaignPrice and MarketingCampaignPromo are the intersection entities and its parent entities will have the capabilities to run the things in the date range. I mean, in business MarketingCampaign will run in specific time window of hours or may be of few days or few months. Also in general I couldn't think of case if Marketing Campaign is over then business would require to add any other price rules or promos with that. After date if same (or better to say similar) marketing campaign requires new rules/promos then it should consider as new marketing campaign with new rules/promos. The current model is capable of handling all the business requirements. But from the data model point of view maintaining the association history seems logical to me. +1 for the adding the date fields in both entities from my side with concerns shared above. If we could identify business use cases it may be applicable would be the best way to proceed. I'm asking to identify business use cases because I know other intersection entities won't have the from date and thru date. If we add date fields with these entities then we should consider them as well. Quickly I can recall few OrderHeaderWorkEffort, MarketingCampaignRole, PartyRole, OrderRole etc. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Jul 31, 2017 at 5:20 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Hello all, > > Currently, I noticed some entities related to *marketing* in OFBiz that > doesn't keep proper record of data such as MarketingCampaignPrice, > MarketingCampaignPromo etc. > I think we can introduce fromDate and thruDate in such entities. as this is > good for history maintenance purpose. > Please let me know your thoughts on this. > > -- > Thanks and Regards, > *Suraj Khurana* | Sr. Enterprise Software Engineer > HotWax Commerce <http://www.hotwax.co/> by HotWax Systems > <http://www.hotwaxsystems.com/> > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > <https://about.me/surajkhurana?promo=email_sig> >
Re: Remove as much as possible delete and remove services
+1 for the proposal with some caution (as suggested by Paul) on picking an entity as candidate which won't have the delete service with it. Some basic steps I could think of we should follow in the effort. Please feel free to add more check points. 1) Identify such entities, where we have to remove the delete/remove services. 1.1) To make an entity as candidate to fall under this, it should maintain the status or manage from date and thru date. Like Party and WorkEffort will have enable/disable flag and statuses. So we can consider them to follow the pattern mentioned in this thread. May be other entities which won't have these attributes could fall, but I think it is easiest way to count any entity IN. 2) Check all occurrences and check what could be the side effect in the process/workflow and how we can handle them. 3) Once we remove/change all occurrences, remove/change the delete/remove service for the entity. Just FYI all, Related discussion started by Suraj in other thread as "Proper record maintenance in marketing component" which tells we should add from date and thru date in some entities. So if community agree on that point then we could consider those entities as well for improvement. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Aug 2, 2017 at 11:33 AM, Swapnil Mane < swapnil.m...@hotwaxsystems.com> wrote: > +1 for using 'expire' service for all the possible places. > > IMO, In ERP systems, we should not delete any information/data. Because > data is the real asset for the any organization. Helping in taking the > business decision. > > Thanks, Jacques and Deepak for sharing this. > > > - Best Regards, > Swapnil M Mane > www.hotwaxsystems.com > www.hotwax.co > > On Tue, Aug 1, 2017 at 8:04 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi, > > > > After a 1st discussion with Deepak at OFBIZ-9185, we had another at > > OFBIZ-9543. > > > > We claim that we should not remove entities records because of auditing. > > But we have at 157 services with names starting with "remove" and 538 > > starting with "delete" > > > > I suggest that we remove as much as possible of these services and have > > only expire services for those which support expire (ie have from and > thru > > dates). > > > > For instance I was curious about deleteParty, but what it currently does > > is only returning the "partyservices.cannot_delete_ > party_not_implemented" > > label. This is pre Apache era (ie there for 10+ years)! > > > > In OFBIZ-9543 Deepak rightly suggested that we keep delete services for > > Assoc kind of entities. But definitely remove delete service for entity > > like Party, WorkEffort, Product, etc those have n number of foreign key > > constraints... > > > > What do you think, other ideas? > > > > Jacques > > > > >
Re: Remove as much as possible delete and remove services
Taher, Are you proposing to move only crud services or crud and basic services or all. Asking this to understand the exact proposal. +1 Deepak to keep the work independent. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Aug 2, 2017 at 2:22 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > Jacques > > > > Le 02/08/2017 à 10:44, Deepak Dixit a écrit : > >> Hi Taher, >> >> I think we can keep both work independent, as it will be very messy if we >> do renaming/cleaning and movement in single shot. >> >> Thanks & Regards >> -- >> Deepak Dixit >> www.hotwaxsystems.com >> www.hotwax.co >> >> On Wed, Aug 2, 2017 at 1:44 PM, Taher Alkhateeb < >> slidingfilame...@gmail.com> >> wrote: >> >> Hi Paul, no what I meant is a new single component where move all >>> services to it. The reason I suggested that is to reduce "mass >>> operations" and make them into one. >>> >>> Our services require a lot of cleanup, renaming, fixing, etc ... so I >>> guess I just rushed an email which I wanted to carefully write in a >>> more comprehensive thread, but I'm just not sure if people are >>> interested in going that route >>> >>> On Wed, Aug 2, 2017 at 10:24 AM, Paul Foxworthy >>> wrote: >>> >>>> On 2 August 2017 at 16:37, Taher Alkhateeb >>>> wrote: >>>> >>>> If you are willing to make the effort towards >>>>> naming all these services then you might as well consider unifying >>>>> them. >>>>> >>>> >>>> Hi Taher, >>>> >>>> Are you proposing one expire service for all entities, which sets the >>>> thruDate attribute? >>>> >>>> If I understand you right, what would we do for entities without a >>>> thruDate? How would we define the expected paramaters, when primary keys >>>> vary between the different entities? >>>> >>>> Cheers >>>> >>>> Paul >>>> >>>> -- >>>> Coherent Software Australia Pty Ltd >>>> PO Box 2773 >>>> Cheltenham Vic 3192 >>>> Australia >>>> >>>> Phone: +61 3 9585 6788 >>>> Web: http://www.coherentsoftware.com.au/ >>>> Email: i...@coherentsoftware.com.au >>>> >>> >
Re: Welcome Akash Jain as a New Committer!
Congratulations Akash! :-) Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Aug 11, 2017 at 1:01 PM, Michael Brohl wrote: > Welcome to the team, Akash! > > Regards, > > Michael > > Am 09.08.17 um 10:58 schrieb Sharan Foga: > > The OFBiz PMC has invited Akash Jain to become a new committer and are >> happy to announce that he has accepted. >> >> Some of the key factors considered for inviting him were as follows: >> >> - He has been involved with the OFBiz project for quite a while which >> shows his dedication and commitment >> - He has a lot of good knowledge (both functional and technical) that he >> is happy to share which shows he is a good team player >> - He is very active, positive and respectful to others in the community >> - He has contributed patches and shows a willingness to learn which is >> really important as the project continues to go through changes >> >> Please join me in welcoming and congratulating Akash. >> >> Thanks >> Sharan >> > > >
Re: Welcome Rishi Solanki as a New Committer!
Thanks to all for the wonderful wishes and support. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Aug 11, 2017 at 1:01 PM, Michael Brohl wrote: > Welcome to the team, Rishi! > > Regards, > > Michael > > Am 09.08.17 um 10:56 schrieb Sharan Foga: > > The OFBiz PMC has invited Rishi Solanki to become a new committer and are >> happy to announce that he has accepted. >> >> Some of the key factors considered for inviting him were as follows: >> >> - He has been involved with the OFBiz project for quite a while which >> shows dedication and commitment >> - He has a lot of good knowledge that he is happy to share which shows he >> is a good team player >> - His work is consistent, has good code quality and he has provided a >> range of patches >> - He is friendly, respectful and keen to help out others in the community >> >> Please join me in welcoming and congratulating Rishi! >> >> Thanks >> Sharan >> > > >
Re: OrderHeader And WebSite Relationship
Ratnesh, I think we can add this relationship, if websiteId is in order header then it must have fk constraints as well. Not sure but I think somehow OrderHeader entity extension goes wrong at sometime. OFBIZ-9457 is an good example, and I think this website issue won't be an intentional change. Looks like mistakenly missed relationship as per my understanding. Should be fixed. +1 for the fix. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Aug 24, 2017 at 7:50 PM, Ratnesh Upadhyay < upadhyay.ratn...@gmail.com> wrote: > Hello Devs, > > I just walked though from OrderHeader entity and noticed that we have > webSiteId field there but we don't have any FK constraint for it from > OrderHeader.webSiteId to WebSite.webSiteId. I was expecting that it must be > there. > > So just curious to know why it was not there, was it intentional? Please > let me know if anyone have any information on it else I would provide a > patch to get it fixed. > > Thanks!! > > Regards, > Ratnesh Upadhyay > HotWax Systems | www.hotwaxsystems.com >
Re: Document Location
Michael, Walk thru the same conversation and found that the page was still at the same place. So I have moved it to appropriate place. https://cwiki.apache.org/confluence/display/OFBIZ/Case+Studies Now we have common place to put all case studies. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Jul 10, 2017 at 4:43 PM, Michael Brohl wrote: > Rishi, > > yes, that's what I am proposing. > > I'll create the page, it should serve as an Index page for the case > > It would be cool if we can collect some more cases studies here. > > Thanks, > > Michael Brohl > ecomify GmbH > www.ecomify.de > > > Am 10.07.17 um 12:46 schrieb Rishi Solanki: > > Thanks Michael, >> >> Just to be super clear you are proposing; >> >> >> Instead of moving to here: Document > Case Studies > Brewing with OFBiz at >> a small or medium sized brewery >> Better place is: Community/ References/ Case Studies > Brewing with OFBiz >> at a small or medium sized brewery >> >> And in case anyone want to contribute more case studies then she can add >> her own page under Case Studies parallel to Brewing with OFBiz at a small >> or medium sized brewery >> >> +1 from my side and will do this change in a day or two in case no >> objection/concerns/suggestion. >> >> Thanks! >> >> >> -- >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> >> On Mon, Jul 10, 2017 at 3:29 PM, Michael Brohl >> wrote: >> >> Hi Rishi, >>> >>> it's a good idea to move this out of the Uses Cases Library. I think that >>> it does not belong in the documentation section at all. >>> >>> The documentation section should, after the restructure, only contain >>> documentation which belongs to the core OFBiz system. >>> >>> I propose to move this to Community/ References/ Case Studies (new page), >>> which seems to be a more appropriate place to me. >>> >>> Best regards, >>> >>> Michael Brohl >>> ecomify GmbH >>> www.ecomify.de >>> >>> >>> Am 10.07.17 um 08:17 schrieb Rishi Solanki: >>> >>> Thanks all, in case no objection in a day or two we will do the changes >>>> in >>>> structure. >>>> >>>> >>>> Rishi Solanki >>>> Sr Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> >>>> On Mon, Jul 10, 2017 at 11:10 AM, Sanjay Yadav < >>>> sanjay.ya...@hotwaxsystems.com> wrote: >>>> >>>> +1 >>>> >>>>> Best Regards, >>>>> >>>>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance >>>>> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems >>>>> <http://www.hotwaxsystems.com/> >>>>> 80, Scheme No. 78, Part II, Indore, M.P. 452010, India >>>>> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav >>>>> <https://www.linkedin.com/in/sanjay-yadav/> >>>>> >>>>> HotWax Systems recently received 8 mentions in *The Gartner Digital >>>>> Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT >>>>> research and advisory company. Learn more about our research here >>>>> <https://www.gartner.com/technology/media-products/newslette >>>>> rs/HotWax/1-2UVLP6M/index.html> >>>>> >>>>> . >>>>> [image: Inline image 1] >>>>> >>>>> >>>>> >>>>> On Mon, Jul 10, 2017 at 10:52 AM, Pranay Pandey < >>>>> pranay.pan...@hotwaxsystems.com> wrote: >>>>> >>>>> +1 >>>>> >>>>>> Best regards, >>>>>> Pranay Pandey >>>>>> www.hotwaxsystems.com >>>>>> >>>>>> >>>>>> On Sun, Jul 9, 2017 at 2:33 PM, Rishi Solanki < >>>>>> rishisolan...@gmail.com> >>>>>> wrote: >>>>>> >>>>>> Hi Pierre Smits/All, >>>>>> >>>>>>> I just gone thru the the blog post by Pierre Smits, Brewing with >>>>>>> OFBiz >>>>>>> >>>>>>> at a >>>>>> >>>>>> small or medium sized brewery <https://cwiki.apache.org/ >>>>>>> confluence/x/64HoAg> >>>>>>> >>>>>>> I see this is good case study thanks Pierre for that. The only >>>>>>> concern >>>>>>> I >>>>>>> have is this is under the 'Business Process Stories and Use Cases >>>>>>> >>>>>>> Library' >>>>>> >>>>>> as parent. I would propose new location for the document. >>>>>>> >>>>>>> Current Location: Document > Business Process Stories and Use Cases >>>>>>> >>>>>>> Library >>>>>> >>>>>> Brewing with OFBiz at a small or medium sized brewery >>>>>>> Proposed Location: Document > Case Study > Brewing with OFBiz at a >>>>>>> >>>>>>> small or >>>>>> >>>>>> medium sized brewery >>>>>>> >>>>>>> >>>>>>> Proposing this so that in case other wanted to add case study then >>>>>>> all >>>>>>> >>>>>>> can >>>>>> >>>>>> be found at one place. >>>>>>> >>>>>>> If everyone agree then we can move this to new location. >>>>>>> >>>>>>> >>>>>>> Thanks! >>>>>>> >>>>>>> Rishi Solanki >>>>>>> Sr Manager, Enterprise Software Development >>>>>>> HotWax Systems Pvt. Ltd. >>>>>>> Direct: +91-9893287847 >>>>>>> http://www.hotwaxsystems.com >>>>>>> >>>>>>> >>>>>>> >>> > >
Re: Updating our OFBiz Blog Template
+1. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Aug 25, 2017 at 2:37 PM, Swapnil Mane < swapnil.m...@hotwaxsystems.com> wrote: > +1, thanks Sharan and Kenneth. > > > > - Best Regards, > Swapnil M Mane > > On Thu, Aug 24, 2017 at 10:16 PM, Sharan Foga > wrote: > > > Hi Everyone > > > > I've received some feedback (and a link) from Kenneth for an initial > > design for a new blog format based on the style of the new website. > > > > https://codepen.io/kennethp/full/OjEvaJ/ > > > > Please can you take a look and let me have your comments and feedback. > > > > Thanks > > Sharan > > > > > > Forwarded Message > > Subject:Re: Movement on the New OFBiz Website :-) > > Date: Wed, 23 Aug 2017 21:05:39 + > > From: Kenneth Paskett > > To: Mike Bates , Sharan Foga < > > sharan.f...@gmail.com> > > > > > > > > Hi Sharan - > > > > I've had some time to review the OFBiz blog. Updating only the CSS, I've > > been able to come up with something that is much more similar to the > design > > of the new site. This is what I've come up with: > > https://codepen.io/kennethp/full/OjEvaJ/ > > > > I could make it much better if I'm able to edit some of the HTML content > > as well. Looking at the code, there are empty anchor tags, and overall > the > > code just looks kind of messy. I'd love to do some additional work and > > structuring of the HTML for better flow and organization, so let me know > if > > edits to the HTML are possible or not. > > > > Also, please provide any comments or feedback you have on the current > > direction of the design (remembering there are things I'd like to do if I > > can add some edits to the HTML, mostly layout). > > > > With regards to the SVN code of the new site, I'm not quite sure how to > > access those files. However, I was able to update the index.html file on > my > > local instance, and have the Slider Block looking a bit better with > > transparent screenshots images (attached). I've also attached the HTML > > file, so you can see the updates (Lines 125 - 200) See if you can > implement > > those and let me know if you run into any issues. > > > > Thanks so much! > > > > ~Kenneth > > > > >
Re: svn commit: r1806258 - in /ofbiz/ofbiz-framework/trunk: ./ applications/content/data/ applications/datamodel/ applications/datamodel/data/seed/ framework/common/config/ framework/entity/config/ fr
Team, Commit contains local changes. I'm reverting shortly. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Aug 26, 2017 at 11:24 AM, wrote: > Author: rishi > Date: Sat Aug 26 05:54:15 2017 > New Revision: 1806258 > > URL: http://svn.apache.org/viewvc?rev=1806258&view=rev > Log: > Improvement: Move all data in applications to the datamodel component. > (OFBIZ-9501) > Moved the data which belongs to content with seed reader. > Thanks Saurabh Dixit for your contribution. > > Added: > > ofbiz/ofbiz-framework/trunk/applications/datamodel/data/seed/ContentSeedData.xml > (with props) > Modified: > ofbiz/ofbiz-framework/trunk/applications/content/data/ > ContentTypeData.xml > ofbiz/ofbiz-framework/trunk/applications/datamodel/ofbiz-component.xml > ofbiz/ofbiz-framework/trunk/build.gradle > ofbiz/ofbiz-framework/trunk/framework/common/config/general.properties > ofbiz/ofbiz-framework/trunk/framework/entity/config/entityengine.xml > ofbiz/ofbiz-framework/trunk/framework/webtools/template/Main.ftl > > Modified: ofbiz/ofbiz-framework/trunk/applications/content/data/ > ContentTypeData.xml > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ > applications/content/data/ContentTypeData.xml?rev= > 1806258&r1=1806257&r2=1806258&view=diff > > == > --- ofbiz/ofbiz-framework/trunk/applications/content/data/ContentTypeData.xml > (original) > +++ ofbiz/ofbiz-framework/trunk/applications/content/data/ContentTypeData.xml > Sat Aug 26 05:54:15 2017 > @@ -27,77 +27,6 @@ under the License. > hasTable="N" description="Content User"/> > hasTable="N" description="Content Guest"/> > > - description="Template Member"/> > - description="Document Structure Definition"/> > - description="Transformation Definition"/> > - > - > - > - description="Alternate Locale"/> > - description="Alternate Role"/> > - description="Response"/> > - description="Sub-Content"/> > - > - description="Description"/> > - > - > - description="Department"/> > - description="Related content"/> > - description="Publish link"/> > - description="Attribute"/> > - > - > - > - description="Composite Document Part"/> > - > - description="Alternative URL"/> > - > - description="The object is a member of the subject."/> > - description="The object defines the subject."/> > - description="The object extends the subject."/> > - description="The object is related to the subject."/> > - description="The object references the subject."/> > - > - description="Topifies"/> > - description="Categorizes"/> > - > - description="Name of the author or creator of the subject."/> > - description="eMail address of the author or creator of the subject."/> > - > - description="The location where subject event took place."/> > - description="The name of a person involved in the subject event."/> > - > - hasTable="N" parentTypeId=""/> > - hasTable="N" parentTypeId=""/> > - hasTable="N" parentTypeId="TEMPLATE"/> > - hasTable="N" parentTypeId=""/> > - > - > - hasTable="N" parentTypeId="DOCUMENT"/> > - hasTable="N" parentTypeId="DOCUMENT"/> > - hasTable="N" parentTypeId="DOCUMENT"/> > - > - hasTable="N" parentTypeId=""/> > - hasTable="N" parentTypeId=""/> > - hasTable="N" parentTypeId=""/> > - > - > - > - > - > - > - parentTypeId="PLACEHOLDER" hasTable="Y" description="Web Site Publish > Point"/> > - hasTable="N" description="Forum Root"/> > - hasTable="N" description="Blog Root"/> > - hasTable="N" description="FAQ Root"/> > - parentTypeId="PLACEHOLDER"/> > - parent
Re: svn commit: r1806259 - in /ofbiz/ofbiz-framework/trunk/framework: common/config/general.properties entity/config/entityengine.xml webtools/template/Main.ftl
Thanks Deepak done in -r1806260.
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co
On Sat, Aug 26, 2017 at 11:39 AM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:
> Hi Rishi,
>
> Need to revert build.gradle changes as well.
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Sat, Aug 26, 2017 at 11:35 AM, wrote:
>
> > Author: rishi
> > Date: Sat Aug 26 06:05:15 2017
> > New Revision: 1806259
> >
> > URL: http://svn.apache.org/viewvc?rev=1806259&view=rev
> > Log:
> > Reverted: Local changes mistakenly committed in revision 1806258
> >
> > Modified:
> > ofbiz/ofbiz-framework/trunk/framework/common/config/
> general.properties
> > ofbiz/ofbiz-framework/trunk/framework/entity/config/entityengine.xml
> > ofbiz/ofbiz-framework/trunk/framework/webtools/template/Main.ftl
> >
> > Modified: ofbiz/ofbiz-framework/trunk/framework/common/config/
> > general.properties
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > framework/common/config/general.properties?rev=
> > 1806259&r1=1806258&r2=1806259&view=diff
> >
> > ==
> > --- ofbiz/ofbiz-framework/trunk/framework/common/config/
> general.properties
> > (original)
> > +++ ofbiz/ofbiz-framework/trunk/framework/common/config/
> general.properties
> > Sat Aug 26 06:05:15 2017
> > @@ -80,10 +80,10 @@ defaultFromEmailAddress=ofbiztest@exampl
> > # as 'baseUrl' and 'baseSecureUrl' are set in the url.properties file.
> >
> > # -- mail notifications enabled (Y|N)
> > -mail.notifications.enabled=Y
> > +mail.notifications.enabled=N
> >
> > # -- redirect all mail notifications to this address for testing
> > -mail.notifications.redirectTo=rishisolan...@gmail.com
> > +#mail.notifications.redirectTo=
> >
> > # -- the default mail server to use
> > mail.smtp.relay.host=localhost
> >
> > Modified: ofbiz/ofbiz-framework/trunk/framework/entity/config/
> > entityengine.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > framework/entity/config/entityengine.xml?rev=1806259&
> > r1=1806258&r2=1806259&view=diff
> >
> > ==
> > --- ofbiz/ofbiz-framework/trunk/framework/entity/config/entityengine.xml
> > (original)
> > +++ ofbiz/ofbiz-framework/trunk/framework/entity/config/entityengine.xml
> > Sat Aug 26 06:05:15 2017
> > @@ -52,19 +52,19 @@ access. For a detailed description see t
> >
> >
> > > entity-group-reader="main" entity-eca-reader="main"
> distributed-cache-clear-
> > enabled="false">
> > -
> > + > datasource-name="localderby"/>
> >
> > datasource-name="
> > localderbytenant"/>
> >
> > > entity-group-reader="main" entity-eca-reader="main"
> > entity-eca-enabled="false" distributed-cache-clear-enabled="false">
> > -
> > + > datasource-name="localderby"/>
> >
> > datasource-name="
> > localderbytenant"/>
> >
> >
> >
> > > entity-group-reader="main" entity-eca-reader="main">
> > -
> > + > datasource-name="localderby"/>
> >
> > datasource-name="
> > localderbytenant"/>
> >
> > @@ -483,9 +483,9 @@ access. For a detailed description see t
> >
> > > jdbc-driver="org.postgresql.Driver"
> > -jdbc-uri="jdbc:postgresql://127.0.0.1/plain_ofbiz_test"
> > -jdbc-username="rishi"
> > -jdbc-password="123456"
> > +jdbc-uri="jdbc:postgresql://127.0.0.1/ofbiz"
> > +jdbc-username="ofbiz"
> > +jdbc-password="ofbiz"
> > isolation-level="ReadCommitted"
> > pool-minsize="2"
> > pool-maxsize="250"
> >
> > Modified: ofbiz/ofbiz-framework/trunk/framework/webtools/template/
> Main.ftl
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > framework/webtools/template/Main.ftl?rev=1806259&r1=
> > 1806258&r2=1806259&view=diff
> >
> > ==
> > --- ofbiz/ofbiz-framework/trunk/framework/webtools/template/Main.ftl
> > (original)
> > +++ ofbiz/ofbiz-framework/trunk/framework/webtools/template/Main.ftl Sat
> > Aug 26 06:05:15 2017
> > @@ -17,10 +17,6 @@ specific language governing permissions
> > under the License.
> > -->
> >
> > -<#assign test=Static["java.lang.String"].format("http://example.com/
> > page?a=1&b=2") >
> > -result1=${test}
> > -result2=${test?url('utf-8')}
> > -
> >
> >
> >${uiLabelMap.WebtoolsMainPage}
> >
> >
> >
>
Re: buildbot exception in on ofbiz-trunk-framework
Thanks Jacques, fixed in revision 1806279. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Aug 26, 2017 at 2:15 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Actually I just tested locally and found this error while trying to do > "svn up && gradlew cleanAll eclipse loadAll testIntegration" > > 2017-08-26 10:33:41,546 |main |GenericDelegator |E| Failure > in create operation for entity [WorkEffortType]: > org.apache.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:WorkEffortType][createdStamp,2017-08-26 > 10:33:41.539(java.sql.Timestamp)][createdTxStamp,2017-08-26 > 10:33:41.287(java.sql.Timestamp)][description,Business > Travel(java.lang.String)][hasTable,N( > java.lang.String)][lastUpdatedStamp,2017-08-26 > 10:33:41.539(java.sql.Timestamp)][lastUpdatedTxStamp,2017-08-26 > 10:33:41.287(java.sql.Timestamp)][parentTypeId,EVENT(java. > lang.String)][workEffortTypeId,BUSINESS > _TRAVEL(java.lang.String)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.WORK_EFFORT_TYPE (WORK_EFFORT_TYPE_ID, > PARENT_TYPE_ID, HAS_TABLE, DESCRIPTION, LAST_UPDATED_STAMP, > LAST_UPDATED_TX_STA > MP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) > (INSERT on table 'WORK_EFFORT_TYPE' caused a violation of foreign key > constraint 'WK_EFFRT_TYPE_PAR' for key (EVENT). The statement has be > en rolled back.)). Rolling back transaction. > > Please check (I must go) > > Jacques > > > > Le 26/08/2017 à 10:03, Jacques Le Roux a écrit : > >> Hi, >> >> Buildbot seems quite busy and is wrong there >> https://ci.apache.org/builders/ofbiz-trunk-framework- >> plugins/builds/405/steps/upload_1/logs/err.html >> Just let's wait ;) >> >> Jacques >> >> Le 26/08/2017 à 09:53, build...@apache.org a écrit : >> >>> The Buildbot has detected a build exception on builder >>> ofbiz-trunk-framework while building . Full details are available at: >>> https://ci.apache.org/builders/ofbiz-trunk-framework/builds/431 >>> >>> Buildbot URL: https://ci.apache.org/ >>> >>> Buildslave for this Build: orcus_ubuntu >>> >>> Build Reason: The AnyBranchScheduler scheduler named >>> 'on-ofbiz-framework-commit' triggered this build >>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1806265 >>> Blamelist: rishi >>> >>> BUILD FAILED: exception shell_1 upload >>> >>> Sincerely, >>> -The Buildbot >>> >>> >>> >>> >>> >> >> >
Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration
+1 Pritam. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Aug 26, 2017 at 5:48 PM, Swapnil Mane < swapnil.m...@hotwaxsystems.com> wrote: > Big +1 Pritam! > > > - Best Regards, > Swapnil M Mane > > On Sat, Aug 26, 2017 at 5:01 PM, Pritam Kute < > pritam.k...@hotwaxsystems.com> > wrote: > > > Hi Devs, > > > > Many e-commerce businesses (especially operating in Asian countries) > > nowadays use short messaging service (SMS) in mobile phones to notify and > > update customers about order details, shipment statuses etc. > > > > I would like to propose an SMS Gateway Integration in Ofbiz. I will share > > proposed design details with you all soon. Till then, I would like to > know > > your thoughts on this idea. > > > > Thanks and Regards > > -- > > Pritam Kute > > >
Re: OrderHeader And WebSite Relationship
Ratnesh/Chandan, I would suggest to consider "one-nofk" relationship in such cases, because in this way we could maintain the relationship and also use the existing model as is. This is only suggestion, as I'm not very sure and it is applicable case to case. Others from community may help on this point. In either case to maintain the relationship my preference would be adding OrderEntry website record. +1 for adding website entity record. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Aug 26, 2017 at 6:27 PM, Chandan Khandelwal < chandan.khandel...@hotwaxsystems.com> wrote: > Hi Ratnesh, > > I have found missing FK constraint in multiple entity definitions > (e.g. shoppingListId in OrderItem etc). So I think we need to verify and > improve this throughout the application. > > -- > Thanks & Regards, > Chandan Khandelwal > HotWax Systems > Direct: +91-9893481076 > http://www.hotwaxsystems.com/ > > On Sat, Aug 26, 2017 at 1:08 PM, Ratnesh Upadhyay < > upadhyay.ratn...@gmail.com> wrote: > > > Thanks everyone for your inputs. > > Here is the jira ticket : https://issues.apache.org/ > jira/browse/OFBIZ-9647 > > > > Regards, > > Ratnesh Upadhyay > > HotWax System | www.hotwaxsystems.com > > > > On Sat, Aug 26, 2017 at 11:54 AM, Arun Patidar < > > arun.pati...@hotwaxsystems.com> wrote: > > > > > Nice catch Ratnesh, we can take this as an improvement. > > > > > > > > > > > > -- > > > Thanks & Regards > > > --- > > > Arun Patidar > > > Manager, Enterprise Software Development > > > > > > > > > HotWax Systems Pvt Ltd.www.hotwaxsystems.com > > > > > > > > > On Thu, Aug 24, 2017 at 7:50 PM, Ratnesh Upadhyay < > > > upadhyay.ratn...@gmail.com> wrote: > > > > > > > Hello Devs, > > > > > > > > I just walked though from OrderHeader entity and noticed that we have > > > > webSiteId field there but we don't have any FK constraint for it from > > > > OrderHeader.webSiteId to WebSite.webSiteId. I was expecting that it > > must > > > be > > > > there. > > > > > > > > So just curious to know why it was not there, was it intentional? > > Please > > > > let me know if anyone have any information on it else I would > provide a > > > > patch to get it fixed. > > > > > > > > Thanks!! > > > > > > > > Regards, > > > > Ratnesh Upadhyay > > > > HotWax Systems | www.hotwaxsystems.com > > > > > > > > > >
Re: Remove Order data model dependency for POS sales
Arun, I'm not sure about the idea would work or not. But yes if the following list pass then we could think of doing so. - Suppose we have 2 POS stores and will get orders from both pos stores. And if we remove the order data model dependency then; -- How we will see the sales from both pos. Invoices? -- How to track the sales being done by the each pos store. -- Do we have any alternative way to check inventory of each pos store. We may like to see the count of sold items and remaining items on each store. -- Do we have any way to track the customer's purchasing and on the basis of purchasing can we add them to some marketing campaign. May be to give the discount coupon or offers. - Also you are taking an example POS won't send the shipping or billing information but if some store is only selling to registered user then how we are going to handle that? - How to manage the loyalty points if POS stores issuing one, and how it will redeem those points without having orders in the system. I could think of the above points only, will share if come up with more. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Aug 29, 2017 at 4:58 PM, Arun Patidar < arun.pati...@hotwaxsystems.com> wrote: > Hello All, > > In POS system, order immediately fulfill and come directly in 'Completed' > status. Also, there is no shipping address, billing address, shipping > method requires in POS. And even no inventory reservation takes place, only > items issuance is done. > > IMO, In the current system, the POS order detail is stored for the > following reasons > >- To manage inventory issuance information >- To store the customer information >- To track the total sales amount > > > I am thinking to remove the dependency of POS sales with Order data model. > Alternatively, we can simply create Invoice and item issuance record only. > This will reduce the system load for managing POS sales. > > It is possible that I am missing any important scenario that needs Order > data model. Please let me know your thoughts on this. > > > > -- > Thanks & Regards > --- > Arun Patidar > Manager, Enterprise Software Development > > HotWax Systems Pvt Ltd. > > www.hotwaxsystems.com >
Re: Remove Order data model dependency for POS sales
Thanks @Scott and @Jacques for putting these for brainstorming. I couldn't share right examples for recommendation that sales data is necessary to have in the system, when we are actually doing the sales in business. I believe whenever doing sales, logging should be there. It might be possible that, for some reason the data not seems useful for certain situation. Thanks again! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Aug 31, 2017 at 1:42 PM, Scott Gray wrote: > It's also used for pricing rule and promotion capabilities. > Laybys/layaways, rainchecks and purchases on account also would benefit > from the order model. > > If POS were extended to hospitality that would also rely on an order model. > > Regards > Scott > > On 29/08/2017 23:29, "Arun Patidar" > wrote: > > > Hello All, > > > > In POS system, order immediately fulfill and come directly in 'Completed' > > status. Also, there is no shipping address, billing address, shipping > > method requires in POS. And even no inventory reservation takes place, > only > > items issuance is done. > > > > IMO, In the current system, the POS order detail is stored for the > > following reasons > > > >- To manage inventory issuance information > >- To store the customer information > >- To track the total sales amount > > > > > > I am thinking to remove the dependency of POS sales with Order data > model. > > Alternatively, we can simply create Invoice and item issuance record > only. > > This will reduce the system load for managing POS sales. > > > > It is possible that I am missing any important scenario that needs Order > > data model. Please let me know your thoughts on this. > > > > > > > > -- > > Thanks & Regards > > --- > > Arun Patidar > > Manager, Enterprise Software Development > > > > HotWax Systems Pvt Ltd. > > > > www.hotwaxsystems.com > > >
Re: Improper permission check on screens
Suraj, Thanks for the detailed description, and it would be nice to have this change. +1 for the proposal, with caution below; We have actions as VIEW, CREATE, UPDATE, DELETE and ADMIN. And all actions from left to right override others, so while doing so we should try to manage the same. I mean to say that, if we go for ADMIN then other permission checks will be pushed aside by the permission services. Same behavior should be maintain when we do this change. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Aug 31, 2017 at 4:17 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Hello all, > > We use * of logged in party. > There are two supported attributes as well in which *permission *is > mandatory and *action *is optional. > If action is not passed then it looks for specific permission. > > *For Example: * > > It should be like action="_VIEW"/> > >- Now if someone has LABEL_MANAGER_ADMIN permission, then that >user won't be granted permission. It should check for _ADMIN permission > as >well. > > > This is properly handled when you pass action attribute, it checks for > specific permission passed and _ADMIN permission as well. > > Proposed solution: > > We must use permission and action attributes at every such code occurrences > to avoid this situation. > > -- > Best Regards, > *Suraj Khurana* | Sr. Enterprise Software Engineer > HotWax Commerce by HotWax Systems > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >
Re: Extend type entities to add name of detail entity where hasTable is true.
I'm not sure this one is best practice or not, but it should be follow. We should try to name the type same as entity name. Other examples; - PartyTpe >> PERSON and PARTY_GROUP - PaymentMethodType >> CREDIT_CARD, FIN_ACCOUNT, EFT_ACCOUNT, GIFT_CARD etc. IMO, best practice is to have the hasTable attribute in the entity. Also if its entity exists then value must be Y. I see ShipmentGatewayConfigType and PaymentGatewayConfigType not setting value to Y for the types system having the entities. Also PaymentMethodType does not have the hasTable attribute. So I think we should fix both these and no need to have the extra field. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Sep 1, 2017 at 4:48 PM, Arun Patidar wrote: > Hello All, > > 'hasTable' field of 'Type' entities is used to give an idea that detail > entity exists or not. We generally get the name of detail entity on the > basis of typeId field value. > > For example : > > ContactMechType,contactMechTypeId = "POSTAL_ADDRESS" then we go to > PostalAddress for detail. > > similarly, > ContactMechType,contactMechTypeId = "TELECOM_NUMBER" then we go to > TelecomNumber for detail. > > is it a best practice to identify the name of detail entity on the basis of > typeId value? > > If yes, then there are some entities that are not following the pattern. > Some of them are: >- ShipmentGatewayConfigType >- PaymentGatewayConfigType > > if not, then we can add a field in Type entities to mention the name of > detail entity. > > > Please let me know your thoughts. > > > -- > Thanks & Regards > --- > Arun Patidar > Manager, Enterprise Software Development > > HotWax Systems Pvt Ltd. > > www.hotwaxsystems.com >
Re: Extend type entities to add name of detail entity where hasTable is true.
Thanks Jacques! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Sep 1, 2017 at 5:46 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > It's described here https://cwiki.apache.org/confl > uence/display/OFBIZ/General+Entity+Overview#GeneralEntityO > verview-ExtensibilityPattern > > What is the problem with ShipmentGatewayConfigType and > PaymentGatewayConfigType (did not check)? > > Jacques > > > > Le 01/09/2017 à 13:18, Arun Patidar a écrit : > >> Hello All, >> >> 'hasTable' field of 'Type' entities is used to give an idea that detail >> entity exists or not. We generally get the name of detail entity on the >> basis of typeId field value. >> >> For example : >> >> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS" then we go to >> PostalAddress for detail. >> >> similarly, >> ContactMechType,contactMechTypeId = "TELECOM_NUMBER" then we go to >> TelecomNumber for detail. >> >> is it a best practice to identify the name of detail entity on the basis >> of >> typeId value? >> >> If yes, then there are some entities that are not following the pattern. >> Some of them are: >> - ShipmentGatewayConfigType >> - PaymentGatewayConfigType >> >> if not, then we can add a field in Type entities to mention the name of >> detail entity. >> >> >> Please let me know your thoughts. >> >> >> >
Re: Extend type entities to add name of detail entity where hasTable is true.
Here is the part related to this thread, from the document shared. "If a table is associated with a given EntityType instance that has the same name as the entityTypeId field value then the hasTable field should have the value 'Y', otherwise it should have the value 'N'. A description field is provided for a short description of an EntityType instance." After this, we should try to match id as much as possible and description field should be use for entity description. Thanks again Jacques for the link. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Sep 1, 2017 at 5:55 PM, Rishi Solanki wrote: > Thanks Jacques! > > Rishi Solanki > Sr Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > www.hotwax.co > > On Fri, Sep 1, 2017 at 5:46 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> It's described here https://cwiki.apache.org/confl >> uence/display/OFBIZ/General+Entity+Overview#GeneralEntityOve >> rview-ExtensibilityPattern >> >> What is the problem with ShipmentGatewayConfigType and >> PaymentGatewayConfigType (did not check)? >> >> Jacques >> >> >> >> Le 01/09/2017 à 13:18, Arun Patidar a écrit : >> >>> Hello All, >>> >>> 'hasTable' field of 'Type' entities is used to give an idea that detail >>> entity exists or not. We generally get the name of detail entity on the >>> basis of typeId field value. >>> >>> For example : >>> >>> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS" then we go to >>> PostalAddress for detail. >>> >>> similarly, >>> ContactMechType,contactMechTypeId = "TELECOM_NUMBER" then we go to >>> TelecomNumber for detail. >>> >>> is it a best practice to identify the name of detail entity on the basis >>> of >>> typeId value? >>> >>> If yes, then there are some entities that are not following the pattern. >>> Some of them are: >>> - ShipmentGatewayConfigType >>> - PaymentGatewayConfigType >>> >>> if not, then we can add a field in Type entities to mention the name of >>> detail entity. >>> >>> >>> Please let me know your thoughts. >>> >>> >>> >> >
Re: Extending a form which uses auto-fields-service
As far as I remember this is not fixed till now. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Sep 4, 2017 at 4:34 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Before I open a Jira for that, please raise a hand if you know this > problem is somehow solved > > Thanks > > Jacques > > > Le 27/06/2010 à 11:00, Ravindra Mandre a écrit : > >> Yes , you are right but the problem is not of position, the problem is >> that >> , when I use the tag then fields are arranged in the >> way in which they are declared in entity , and if I want to give them >> position then fields are not arranged in the required position , (you can >> take the example of updatePerson service ). >> >> >> Regards >> Ravi >> >> On Sat, Jun 26, 2010 at 1:50 PM, Vikas Mayur > >wrote: >> >> To position some of the fields in a separate column you would need to >>> explicitly define those fields and with a position attribute on it. >>> >>> Regards >>> Vikas >>> >>> >>> On Jun 24, 2010, at 7:16 PM, Ravindra Mandre wrote: >>> >>> Yes , I also tried the sort-order but this does not fulfill the >>> >>>> requirement >>>> , as suppose I want to arrange two fields in a horizontal way , then >>>> this >>>> does not work . for example : >>>> A) >>>> firstName lastName >>>> >>>> >>>> >>>> but sort-order does like this >>>> B) >>>> firstName >>>> lastName >>>> >>>> , if there is any other way for doing case A please let me know . >>>> >>>> Ravi >>>> >>>> On Thu, Jun 24, 2010 at 5:47 PM, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com> wrote: >>>> >>>> Did you try also sort-order? >>>> >>>>> Jacques >>>>> >>>>> From: "Ravindra Mandre" >>>>> >>>>> Yes , when we use auto-fields-service in a form then, this does not >>>>> allow >>>>> >>>>> us >>>>>> to arrange the fields as we want , means position tag inside the field >>>>>> becomes useless . >>>>>> >>>>>> Ravi >>>>>> >>>>>> >>>>>> On Tue, Jun 22, 2010 at 9:58 PM, Jacques Le Roux < >>>>>> jacques.le.r...@les7arts.com> wrote: >>>>>> >>>>>> Sorry, it's not related to auto-fields-service. I was able to extend >>>>>> >>>>>> another form which uses auto-fields-service >>>>>>> I will dig in when I will get time... >>>>>>> >>>>>>> Forget it >>>>>>> >>>>>>> Jacques >>>>>>> >>>>>>> From: "Jacques Le Roux" >>>>>>> >>>>>>> Looks like extending a form which uses auto-fields-service does not >>>>>>> work >>>>>>> >>>>>>> properly. Has someone some experience witht that? >>>>>>> >>>>>>>> Thanks >>>>>>>> >>>>>>>> Jacques >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >
Re: [Proposal] Create separate Permission Service for security checks
Chinmay, Thank you for the details and service references with your proposal. I have gone thru the shopping list services and below is my observation; The inline checks uses the single permission check and return error as per requirement. And if permission service is not available for certain cases then developer go for inline permission checks to return error she wants. In the service definition we have the required-permissions and permission-service tags. Only the permission-service service will return custom fail/error messages if user won't have permission. I see no way to return fail/error custom message from required-permissions >> check-permission. In addition to your proposal I would like to propose that, the check-permission tag should also have ability to return errors. This should work in the same way work with in the service definition. By doing so we will be able to replace the permission services with service calls in the service definition. And has permission with check permission. If community agree and you (or anyone) are willing to work on it, I would be happy to help. Big +1 for separating the security and business logic. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Sep 9, 2017 at 5:06 PM, Chinmay Patidar < chinmay.pati...@hotwaxsystems.com> wrote: > Hello Devs, > > Recently, I came across the CRUD operation services for ShoppingList and > ShoppingListItem entities. The security related checks are present inline > in these services which violate the best practice of keeping security > implementation different from the business logic. > > I would like to propose creating security services for such operations and > to call them as a permission-service from the CRUD operation > services definition. This will also enable users to easily modify the > security checks for their custom implementation. ill then, I would like to > know your thoughts on this idea. > > Thanks, > *Chinmay Patidar* >
Re: svn commit: r1807908 - /ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofbiz/service/engine/EntityAutoEngine.java
I have reverted the changes due to buildbot failure report. I ran the test
integration failed at my local. I'll review it further but it looks like
some test expecting success always and failing due to this commit.
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co
On Sat, Sep 9, 2017 at 7:41 PM, wrote:
> Author: rishi
> Date: Sat Sep 9 14:11:51 2017
> New Revision: 1807908
>
> URL: http://svn.apache.org/viewvc?rev=1807908&view=rev
> Log:
> Fixed: Can enter empty content for product facility (OFBIZ-8323). A
> Generic Issue with EntityAutoEngine in which success message is appended to
> result after invoking create, update, delete, expire methods. Now engine
> would return success or error from invoking method and won't prepare the
> message its own.
> Thanks to Lalit Dashora for your contribution.
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/service/src/main/
> java/org/apache/ofbiz/service/engine/EntityAutoEngine.java
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/service/src/main/
> java/org/apache/ofbiz/service/engine/EntityAutoEngine.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/service/src/main/java/org/apache/ofbiz/service/
> engine/EntityAutoEngine.java?rev=1807908&r1=1807907&r2=1807908&view=diff
>
> ==
> --- ofbiz/ofbiz-framework/trunk/framework/service/src/main/
> java/org/apache/ofbiz/service/engine/EntityAutoEngine.java (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/service/src/main/
> java/org/apache/ofbiz/service/engine/EntityAutoEngine.java Sat Sep 9
> 14:11:51 2017
> @@ -112,22 +112,18 @@ public final class EntityAutoEngine exte
> switch (modelService.invoke) {
> case "create":
> result = invokeCreate(dctx, parameters, modelService,
> modelEntity, allPksInOnly, pkFieldNameOutOnly);
> -result.put(ModelService.SUCCESS_MESSAGE,
> UtilProperties.getMessage("ServiceUiLabels", "EntityCreatedSuccessfully",
> UtilMisc.toMap("entityName", modelEntity.getEntityName()), locale));
> break;
> case "update":
> result = invokeUpdate(dctx, parameters, modelService,
> modelEntity, allPksInOnly);
> -result.put(ModelService.SUCCESS_MESSAGE,
> UtilProperties.getMessage("ServiceUiLabels", "EntityUpdatedSuccessfully",
> UtilMisc.toMap("entityName", modelEntity.getEntityName()), locale));
> break;
> case "delete":
> result = invokeDelete(dctx, parameters, modelService,
> modelEntity, allPksInOnly);
> -result.put(ModelService.SUCCESS_MESSAGE,
> UtilProperties.getMessage("ServiceUiLabels", "EntityDeletedSuccessfully",
> UtilMisc.toMap("entityName", modelEntity.getEntityName()), locale));
> break;
> case "expire":
> result = invokeExpire(dctx, parameters, modelService,
> modelEntity, allPksInOnly);
> if (ServiceUtil.isSuccess(result)) {
> result = invokeUpdate(dctx, parameters, modelService,
> modelEntity, allPksInOnly);
> }
> -result.put(ModelService.SUCCESS_MESSAGE,
> UtilProperties.getMessage("ServiceUiLabels", "EntityExpiredSuccessfully",
> UtilMisc.toMap("entityName", modelEntity.getEntityName()), locale));
> break;
> default:
> break;
> @@ -148,7 +144,6 @@ public final class EntityAutoEngine exte
> private static Map invokeCreate(DispatchContext dctx,
> Map parameters, ModelService modelService, ModelEntity
> modelEntity, boolean allPksInOnly, List pkFieldNameOutOnly)
> throws GeneralException {
> Locale locale = (Locale) parameters.get("locale");
> -Map result = ServiceUtil.returnSuccess();
>
> GenericValue newEntity = dctx.getDelegator().makeValue(
> modelEntity.getEntityName());
>
> @@ -360,6 +355,7 @@ public final class EntityAutoEngine exte
> }
> }
> newEntity.create();
> +Map result = ServiceUtil.returnSuccess(
> UtilProperties.getMessage("ServiceUiLabels", "EntityCreatedSuccessfully",
> UtilMisc.toMap("entityName", modelEntity.getEntityName()), locale));
> result.put("crudValue", newEntity);
> return result;
> }
>
Re: OFBiz Core Dependency on Plugins
I don't see any reason to keep these referneces in core components.
+1 for fixing the references.
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co
On Sat, Sep 9, 2017 at 8:40 PM, Ratnesh Upadhyay wrote:
> Devs,
>
> While reviewing email services, I noticed that we are still having
> references of plugins component (ecommerce) in core components.
>
> Here is the quick references : (order/data/DemoProduct.xml)
> emailType="PRDS_ODR_CONFIRM"
> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#
> OrderConfirmNotice"
> xslfoAttachScreenLocation="component://ecommerce/widget/
> EmailOrderScreens.xml#OrderConfirmNoticePdf"
> subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
> ofbizt...@example.com" fromAddress="ofbizt...@example.com"/>
>
> There are some more occurrences (in controller, screens, menus), I'll log a
> Jira ticket and share all the details there to resolve all such
> dependencies.
> I'm pretty sure that it's not intentional as the community did big effort
> to resolve dependencies while creating plugins but still Its good to get
> confirmation from the community.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>
Re: Extend type entities to add name of detail entity where hasTable is true.
Thanks Michael, I'm also in favor of using id and description fields suggest the entity name. Existing model is capable to to resolve the reported issue if we follow the conventions. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sun, Sep 10, 2017 at 4:59 PM, Michael Brohl wrote: > -1 from my side, I think we can solve this by convention instead of > introducing a new field. > > Thanks, > > Michael > > > Am 01.09.17 um 15:53 schrieb Vaibhav Jain: > > +1 for introducing new attribute "tableName". >> >> >> >> Vaibhav Jain >> Hotwax Systems, >> vaibhav.j...@hotwaxsystems.com >> >> On Fri, Sep 1, 2017 at 5:16 PM, Rishi Solanki >> wrote: >> >> I'm not sure this one is best practice or not, but it should be follow. We >>> should try to name the type same as entity name. >>> Other examples; >>> - PartyTpe >> PERSON and PARTY_GROUP >>> - PaymentMethodType >> CREDIT_CARD, FIN_ACCOUNT, EFT_ACCOUNT, GIFT_CARD >>> etc. >>> >>> IMO, best practice is to have the hasTable attribute in the entity. Also >>> if >>> its entity exists then value must be Y. >>> >>> I see ShipmentGatewayConfigType and PaymentGatewayConfigType not setting >>> value to Y for the types system having the entities. Also >>> PaymentMethodType >>> does not have the hasTable attribute. >>> >>> So I think we should fix both these and no need to have the extra field. >>> >>> >>> >>> Rishi Solanki >>> Sr Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> www.hotwax.co >>> >>> On Fri, Sep 1, 2017 at 4:48 PM, Arun Patidar >> com >>> >>>> wrote: >>>> Hello All, >>>> >>>> 'hasTable' field of 'Type' entities is used to give an idea that detail >>>> entity exists or not. We generally get the name of detail entity on the >>>> basis of typeId field value. >>>> >>>> For example : >>>> >>>> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS" then we go to >>>> PostalAddress for detail. >>>> >>>> similarly, >>>> ContactMechType,contactMechTypeId = "TELECOM_NUMBER" then we go to >>>> TelecomNumber for detail. >>>> >>>> is it a best practice to identify the name of detail entity on the basis >>>> >>> of >>> >>>> typeId value? >>>> >>>> If yes, then there are some entities that are not following the pattern. >>>> Some of them are: >>>> - ShipmentGatewayConfigType >>>> - PaymentGatewayConfigType >>>> >>>> if not, then we can add a field in Type entities to mention the name of >>>> detail entity. >>>> >>>> >>>> Please let me know your thoughts. >>>> >>>> >>>> -- >>>> Thanks & Regards >>>> --- >>>> Arun Patidar >>>> Manager, Enterprise Software Development >>>> >>>> HotWax Systems Pvt Ltd. >>>> >>>> www.hotwaxsystems.com >>>> >>>> > >
Re: Services with no definition and usage
+1 Jacques, Scott, we should keep the mentioned services and enable them by adding the service definition. Similar services already in system for party, facility, order, with contact mech (postal address/telecom number) creation. The code is simply created the work effort with postal address/telecom number, which seems to be genetic use case for intersection relations. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Sep 12, 2017 at 3:02 AM, Scott Gray wrote: > I'm in favor of keeping them and adding the service definitions. As Taher > mentions, these are CRUD services and IMO if we have the table, we should > have the set of services allowing management of the data. > > These implementations are quite synonymous with the FacilityContactMech > services, they're only gathering dust because we don't have very advanced > work effort management screens and in cases where we do, the work effort is > usually bound to a facility where the work will take place so the contact > mechs from the facility are used. > > The moment somebody wants to start doing some event management with OFBiz, > these services would become useful. What we have here is a gap in the work > effort management screens, not a code bloat problem. > > Regards > Scott > > On 11 September 2017 at 00:15, Jacques Le Roux < > jacques.le.r...@les7arts.com > > wrote: > > > Here, it's not about Minilang but only service definitions > > > > Jacques > > > > > > > > Le 10/09/2017 à 13:23, Michael Brohl a écrit : > > > >> I think if we have code which is not used or planned to be used, it > >> should be removed. > >> > >> Since we agreed on deprecating minilang, no code is allowed to be > >> commited using minilang with the exception of a bug fix. We shoul be > very > >> restrictive in this case. > >> > >> I agree that we should first provide a test or convert a mini lang test > >> and provide it along with the converted code. This will be an > imporvement > >> on the test coverage and also prove that the converted code works the > same > >> as the minilang version. > >> > >> Thanks, > >> > >> Michael > >> > >> > >> Am 01.09.17 um 11:34 schrieb Jacques Le Roux: > >> > >>> There will be years before we rewrite all the Minilang services. It's > >>> just an hour to revive these services, I can do it > >>> > >>> It will then be easy to rewrite them with all the others. > >>> > >>> BTW I fear this moment of massive regressions if we don't put ALL the > >>> required tests before doing the rewriting. > >>> > >>> Jacques > >>> > >>> > >>> Le 01/09/2017 à 11:23, Taher Alkhateeb a écrit : > >>> > >>>> Well .. according to you, the thoughts were put in these services > before > >>>> the apache era! I'm not sure if we want such _very_ old code revived. > I > >>>> also think the community is capable enough of rewriting basic CRUD > >>>> services. There is no magic or incredibly sophisticated algorithms in > >>>> this > >>>> code. Juat another CRUD. > >>>> > >>>> On Sep 1, 2017 12:16 PM, "Jacques Le Roux" < > >>>> jacques.le.r...@les7arts.com> > >>>> wrote: > >>>> > >>>> I disagree, some thoughts were put in these services. They are in > >>>> Minilang > >>>> admittedly, but we can still keep them and transform them later and > >>>> anway > >>>> we have tons of Minilang services. > >>>> > >>>> I'm not sure if I found them all but they seem to start from > >>>> updateWorkEffortContactMech and end at updateWorkEffortEmailAddress. > >>>> They > >>>> all use updateWorkEffortContactMech which is only used by them and has > >>>> also > >>>> no definition. > >>>> > >>>> It's 168 lines of Minilang > >>>> > >>>> Jacques > >>>> > >>>> > >>>> > >>>> Le 01/09/2017 à 10:47, Taher Alkhateeb a écrit : > >>>> > >>>> I agree, we need to remove from the pile not add to it. Deleting is > the > >>>>> best course of action IMHO. Heck even some of the defined
Re: Extend type entities to add name of detail entity where hasTable is true.
Yes! Thank you Arun for bringing/reporting this and summarize. Agree with you on we may need to update the existing entities/data as per convention. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Sep 12, 2017 at 6:42 PM, Arun Patidar < arun.pati...@hotwaxsystems.com> wrote: > Thanks Michael and Rishi for your feedback. If we follow the proper > convention with TypeId and entity name then there is no issue. But the case > is that there is some inconsistency in existing entities. We will have to > fix some of the existing entities as per convention. > > -- > Thanks & Regards > --- > Arun Patidar > Manager, Enterprise Software Development > > HotWax Systems Pvt Ltd. > > www.hotwaxsystems.com > > > On Tue, Sep 12, 2017 at 1:37 PM, Rishi Solanki > wrote: > > > Thanks Michael, > > > > I'm also in favor of using id and description fields suggest the entity > > name. Existing model is capable to to resolve the reported issue if we > > follow the conventions. > > > > Rishi Solanki > > Sr Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > www.hotwax.co > > > > On Sun, Sep 10, 2017 at 4:59 PM, Michael Brohl > > > wrote: > > > > > -1 from my side, I think we can solve this by convention instead of > > > introducing a new field. > > > > > > Thanks, > > > > > > Michael > > > > > > > > > Am 01.09.17 um 15:53 schrieb Vaibhav Jain: > > > > > > +1 for introducing new attribute "tableName". > > >> > > >> > > >> > > >> Vaibhav Jain > > >> Hotwax Systems, > > >> vaibhav.j...@hotwaxsystems.com > > >> > > >> On Fri, Sep 1, 2017 at 5:16 PM, Rishi Solanki < > rishisolan...@gmail.com> > > >> wrote: > > >> > > >> I'm not sure this one is best practice or not, but it should be > follow. > > We > > >>> should try to name the type same as entity name. > > >>> Other examples; > > >>> - PartyTpe >> PERSON and PARTY_GROUP > > >>> - PaymentMethodType >> CREDIT_CARD, FIN_ACCOUNT, EFT_ACCOUNT, > GIFT_CARD > > >>> etc. > > >>> > > >>> IMO, best practice is to have the hasTable attribute in the entity. > > Also > > >>> if > > >>> its entity exists then value must be Y. > > >>> > > >>> I see ShipmentGatewayConfigType and PaymentGatewayConfigType not > > setting > > >>> value to Y for the types system having the entities. Also > > >>> PaymentMethodType > > >>> does not have the hasTable attribute. > > >>> > > >>> So I think we should fix both these and no need to have the extra > > field. > > >>> > > >>> > > >>> > > >>> Rishi Solanki > > >>> Sr Manager, Enterprise Software Development > > >>> HotWax Systems Pvt. Ltd. > > >>> Direct: +91-9893287847 > > >>> http://www.hotwaxsystems.com > > >>> www.hotwax.co > > >>> > > >>> On Fri, Sep 1, 2017 at 4:48 PM, Arun Patidar > > > >>> com > > >>> > > >>>> wrote: > > >>>> Hello All, > > >>>> > > >>>> 'hasTable' field of 'Type' entities is used to give an idea that > > detail > > >>>> entity exists or not. We generally get the name of detail entity on > > the > > >>>> basis of typeId field value. > > >>>> > > >>>> For example : > > >>>> > > >>>> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS" then we go to > > >>>> PostalAddress for detail. > > >>>> > > >>>> similarly, > > >>>> ContactMechType,contactMechTypeId = "TELECOM_NUMBER" then we go to > > >>>> TelecomNumber for detail. > > >>>> > > >>>> is it a best practice to identify the name of detail entity on the > > basis > > >>>> > > >>> of > > >>> > > >>>> typeId value? > > >>>> > > >>>> If yes, then there are some entities that are not following the > > pattern. > > >>>> Some of them are: > > >>>> - ShipmentGatewayConfigType > > >>>> - PaymentGatewayConfigType > > >>>> > > >>>> if not, then we can add a field in Type entities to mention the name > > of > > >>>> detail entity. > > >>>> > > >>>> > > >>>> Please let me know your thoughts. > > >>>> > > >>>> > > >>>> -- > > >>>> Thanks & Regards > > >>>> --- > > >>>> Arun Patidar > > >>>> Manager, Enterprise Software Development > > >>>> > > >>>> HotWax Systems Pvt Ltd. > > >>>> > > >>>> www.hotwaxsystems.com > > >>>> > > >>>> > > > > > > > > >
Re: [Proposal] Ability to Record Return Communication
+1 for the proposal, I'll be happy to discuss and finalizing the things. Assuming that you have already consider ProductStoreEmailSetting and EmailTemplateSetting for sending the different notification for return. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Sep 23, 2017 at 3:44 PM, Ratnesh Upadhyay < upadhyay.ratn...@gmail.com> wrote: > Hi Devs, > > In OOTB we are having the ability to record order specific communication in > *CommunicationEventOrder* and the user can retrieve/review them from party > > communications screen but we don't have such support for return > communications. So It would be great to have an ability to record return > specific communication in the system. > > We have to implement following items to establish this feature : > > *Data Model Details:* > - We will have to create new entity *CommunicationEventReturn* to record > return communication. It should have returnId and communicationEventId > along with other necessary fields. > - We have to implement following view *CommunicationEventAndReturn* to > fetch return communications over screens as needed. > > *New Implementation Details:* > - We have to add *CRUD* services for the new entity. > > *Existing Implementation Details:* > - We have to extend *createCommunicationEvent* service definition with > retunId field and extend the existing implementation to create the record > in *CommunicationEventReturn* based on supplied returnId parameter. > - Also, we have to extend return related email services to provide returnId > in service context. > > *User Interface Details:* > - In the current system we have Party > Communications > Find Communication > By Order screen, in the same way, we can add another screen to find > communication by return. > - We can add return communication screenlet over Order Manager > Return > > Return History screen or we can add communication tab under Order > Return > screen, this is just a thought still thinking on it. > - We can also provide communication tab in order component as well. > > Please have a look at details and let me know your inputs. I'll log Jira > ticket to implement this feature soon. > > Thanks!! > > Regards, > Ratnesh Upadhyay > HotWax Systems | www.hotwaxsystems.com >
Re: [Proposal] Ability to Record Return Communication
+1 for both the points, first introduce the feature with design proposal shared by Ratnesh. And in a separate discussion/effort we can discuss and finalize the generic data model approach. Even this thread is also good start for discussing the generic data model proposal. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sun, Sep 24, 2017 at 2:05 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 23/09/2017 à 16:29, Ratnesh Upadhyay a écrit : > >> Hi Jacques, >> >> Thanks for the response. I was thinking that retrieval gets slow down when >> we have a lot of data in communication event entity. Actually, I've >> prepared this proposal based on the current implementation of >> CommunicationEventOrder on this assumption that it's an approved feature >> that's its there in the system. >> > Thanks Ratnesh, I see your point now > > I am also in agreement with you and Deepak to use the existing (generic) >> data model to achieve this. I'll give it another thought and further >> analyze it to fit in existing data model. >> > I finally think we can go with your proposition, following the same way > than CommunicationEventOrder, if it eases the introduction of the feature > > Jacques > > >> Thanks!! >> >> Regards, >> Ratnesh Upadhyay >> HotWax Systems | www.hotwaxsystems.com >> >> On Sat, Sep 23, 2017 at 5:37 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Le 23/09/2017 à 13:14, Ratnesh Upadhyay a écrit : >>> >>> Imagine if we use the generic data model to record each kind of >>>> communication and when the system tries to pull a specific email or >>>> specific type email communication from this model then system has to >>>> browse >>>> a lot of data and due to this most of the time, it gets ended up with >>>> slow >>>> query/browsing issue. So to avoid such performance issue instead of >>>> extending CommunicationEvent entity, I proposed to make a separate >>>> entity. >>>> >>>> Hi Ratnesh, >>> >>> Are you sure about that? What would the bottleneck? If you think the DB >>> would slow down I don't think it's an issue. >>> >>> My take is that I prefer a generic data model rather than sacrificing for >>> hypothetical performance and end up with data model like competitors with >>> thousands of entities (OFBiz is currently still around 800+) >>> >>> Jacques >>> >>> >
Re: svn commit: r1809749 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/entitydef/order-entitymodel.xml order/data/DemoOrderTestData.xml order/servicedef/secas.xml order/testdef/data/OrderT
Deepak/Jacques, Thanks for the review and feedback. I propose the same in the email thread where this issue was discussed. Also we have consider the empty website case as well. Verified and Tested, we can create order header with empty values. There are many similar relations uses the one relationship. Even with Order Header we have product store id, order type id, sales channel enum id etc and we can set all these values as empty while creating the Order Header record. I propose the 'one-nofk' in email thread so that we can keep the data of orders will have the incorrect website id, and now we have decided to remove all incorrect data and ECAs conditions. Let me know if I missed something you guys wanted to point out. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Sep 27, 2017 at 12:36 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Good catch Deepak! > > Jacques > > > > Le 27/09/2017 à 08:07, Deepak Dixit a écrit : > >> Hi Rishi/Ratnesh, >> >> IMO relationship should be one-nofk, as website can be empty. >> >> Thanks & Regards >> -- >> Deepak Dixit >> www.hotwaxsystems.com >> www.hotwax.co >> >> On Tue, Sep 26, 2017 at 8:03 PM, wrote: >> >> Author: rishi >>> Date: Tue Sep 26 14:33:05 2017 >>> New Revision: 1809749 >>> >>> URL: http://svn.apache.org/viewvc?rev=1809749&view=rev >>> Log: >>> Improvement: Missing Relationship from OrderHeader to WebSite >>> (OFBIZ-9647). Added relationship from order header to website entity. And >>> removed wrong data. >>> Applied patch from (OFBIZ-9647). Thanks Ratnesh Upadhyay for your >>> contribution. >>> >>> Modified: >>> ofbiz/ofbiz-framework/trunk/applications/datamodel/ >>> entitydef/order-entitymodel.xml >>> ofbiz/ofbiz-framework/trunk/applications/order/data/ >>> DemoOrderTestData.xml >>> ofbiz/ofbiz-framework/trunk/applications/order/servicedef/secas.xml >>> ofbiz/ofbiz-framework/trunk/applications/order/testdef/ >>> data/OrderTestData.xml >>> >>> Modified: ofbiz/ofbiz-framework/trunk/applications/datamodel/ >>> entitydef/order-entitymodel.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ >>> applications/datamodel/entitydef/order-entitymodel. >>> xml?rev=1809749&r1=1809748&r2=1809749&view=diff >>> >>> == >>> --- ofbiz/ofbiz-framework/trunk/applications/datamodel/ >>> entitydef/order-entitymodel.xml (original) >>> +++ ofbiz/ofbiz-framework/trunk/applications/datamodel/ >>> entitydef/order-entitymodel.xml Tue Sep 26 14:33:05 2017 >>> @@ -432,6 +432,9 @@ under the License. >>> >> rel-entity-name="Uom"> >>> >>> >>> + >> rel-entity-name="WebSite"> >>> + >>> + >>> >>> >>> >>> >>> Modified: ofbiz/ofbiz-framework/trunk/applications/order/data/ >>> DemoOrderTestData.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ >>> applications/order/data/DemoOrderTestData.xml?rev= >>> 1809749&r1=1809748&r2=1809749&view=diff >>> >>> == >>> --- ofbiz/ofbiz-framework/trunk/applications/order/data/DemoOrde >>> rTestData.xml >>> (original) >>> +++ ofbiz/ofbiz-framework/trunk/applications/order/data/DemoOrde >>> rTestData.xml >>> Tue Sep 26 14:33:05 2017 >>> @@ -20,7 +20,7 @@ under the License. >>> >>> >>> >>> ->> orderName="" salesChannelEnumId="WEB_SALES_CHANNEL" >>> orderDate="2008-04-23 >>> 16:49:27.392" entryDate="2008-04-23 16:49:27.392" priority="2" >>> visitId="10002" statusId="ORDER_APPROVED" createdBy="admin" >>> currencyUom="USD" webSiteId="OrderEntry" productStoreId="9000" >>> remainingSubTotal="38.40" grandTotal="50.85" invoicePerShipment="Y"/> >>> +>> orderName="" salesChannelEnumId="WEB_SALES_CHANNEL" >>> orderDate="2008-04-23 >>> 16:49:27.392" entryDa
Re: svn commit: r1809749 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/entitydef/order-entitymodel.xml order/data/DemoOrderTestData.xml order/servicedef/secas.xml order/testdef/data/OrderT
Thank you Deepak for the reference link, and yes it matches with my understanding of one and one-nofk relations. With respect to same information, we found website is eligible candidate for maintaining the indexes and fks for order header. So concluded to use one relation for the field. I think we can consider website as candidate to have 'one' relation with order. Thanks! Best Regards, Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Sep 27, 2017 at 1:59 PM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > On Wed, Sep 27, 2017 at 1:24 PM, Rishi Solanki > wrote: > > > Deepak/Jacques, > > > > Thanks for the review and feedback. > > > > I propose the same in the email thread where this issue was discussed. > Also > > we have consider the empty website case as well. Verified and Tested, we > > can create order header with empty values. There are many similar > relations > > uses the one relationship. > > > > Even with Order Header we have product store id, order type id, sales > > channel enum id etc and we can set all these values as empty while > creating > > the Order Header record. > > > > > Hi Rishi, > > > https://cwiki.apache.org/confluence/display/OFBIZ/Entity+Engine+Guide > > *Foreign keys and indexes on foreign keys can be created automatically by > the Entity Engine. This is only done for type 'one' relations, not for > 'one-nofk' or 'many' type relations.* > > > > > > > I propose the 'one-nofk' in email thread so that we can keep the data of > > orders will have the incorrect website id, and now we have decided to > > remove all incorrect data and ECAs conditions. > > Let me know if I missed something you guys wanted to point out. Thanks! > > > > > > Rishi Solanki > > Sr Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > www.hotwax.co > > > > On Wed, Sep 27, 2017 at 12:36 PM, Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > > > Good catch Deepak! > > > > > > Jacques > > > > > > > > > > > > Le 27/09/2017 à 08:07, Deepak Dixit a écrit : > > > > > >> Hi Rishi/Ratnesh, > > >> > > >> IMO relationship should be one-nofk, as website can be empty. > > >> > > >> Thanks & Regards > > >> -- > > >> Deepak Dixit > > >> www.hotwaxsystems.com > > >> www.hotwax.co > > >> > > >> On Tue, Sep 26, 2017 at 8:03 PM, wrote: > > >> > > >> Author: rishi > > >>> Date: Tue Sep 26 14:33:05 2017 > > >>> New Revision: 1809749 > > >>> > > >>> URL: http://svn.apache.org/viewvc?rev=1809749&view=rev > > >>> Log: > > >>> Improvement: Missing Relationship from OrderHeader to WebSite > > >>> (OFBIZ-9647). Added relationship from order header to website entity. > > And > > >>> removed wrong data. > > >>> Applied patch from (OFBIZ-9647). Thanks Ratnesh Upadhyay for your > > >>> contribution. > > >>> > > >>> Modified: > > >>> ofbiz/ofbiz-framework/trunk/applications/datamodel/ > > >>> entitydef/order-entitymodel.xml > > >>> ofbiz/ofbiz-framework/trunk/applications/order/data/ > > >>> DemoOrderTestData.xml > > >>> ofbiz/ofbiz-framework/trunk/applications/order/servicedef/ > > secas.xml > > >>> ofbiz/ofbiz-framework/trunk/applications/order/testdef/ > > >>> data/OrderTestData.xml > > >>> > > >>> Modified: ofbiz/ofbiz-framework/trunk/applications/datamodel/ > > >>> entitydef/order-entitymodel.xml > > >>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ > > >>> applications/datamodel/entitydef/order-entitymodel. > > >>> xml?rev=1809749&r1=1809748&r2=1809749&view=diff > > >>> > > >>> == > > >>> --- ofbiz/ofbiz-framework/trunk/applications/datamodel/ > > >>> entitydef/order-entitymodel.xml (original) > > >>> +++ ofbiz/ofbiz-framework/trunk/applications/datamodel/ > > >>> entitydef/order-entitymodel.xml
Re: Security group permission association must have date range
+1 Suraj! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Sep 28, 2017 at 1:37 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > I see no reasons why we could not add them > > Of course an update of https://cwiki.apache.org/confl > uence/display/OFBIZ/Revisions+Requiring+Data+Migration+-+upgrade+ofbiz > would be necessary > > Jacques > > > > Le 28/09/2017 à 10:05, Suraj Khurana a écrit : > >> Hello, >> >> There might be many scenarios in the real business that you need to >> maintain specific permission to a specific group for some specified time >> only. Like at the time of business expansion, permission related work >> allotment to current employees, so maintaining history becomes important >> here. >> >> IMO, there should be *fromDate* and *thruDate* fields on >> *SecurityGroupPermission* entity as well with *fromDate* as part of >> primary >> key. >> >> Please let me know your thoughts on this. >> >> -- >> Thanks and Regards, >> *Suraj Khurana* | Sr. Enterprise Software Engineer >> *HotWax Commerce* by *HotWax Systems* >> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >> >> >
Re: Missing/Incomplete View Order Image Feature
Devanshu, First look your proposal looks promising, +1 for that. I'll try to give another look to your proposal and see If I have something to add then I'll get back. Just one quick thought, we can use OrderContent entity and in the seqId we would put NA for header level content. -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Sep 29, 2017 at 2:14 PM, Devanshu Vyas wrote: > Hello Devs, > > I found (View Image) buttons on order view page on demo instance > <https://demo-trunk.ofbiz.apache.org/ordermgr/control/ > orderview?orderId=WSCO1>, > and I was curious to find no such UI in the application to associate an > image to order. I explored the button history and tried to find the purpose > behind this, and didn't find any way to add an image(content) to the order > except via Webtools. > FYI, I also found a ticket in JIRA for this button, OFBIZ-7257 > <https://issues.apache.org/jira/browse/OFBIZ-7257>, and here also the > button functionality is found broken. > > I would like to propose making this feature generic, i.e. a feature where a > user will be able to add different types of content(image, document, URL, > etc.) to an order. Also, the order image feature is not exactly available > in the order workflow, so we can improve it this way. > > I would like to know your thoughts on it and tell me if I missed anything > here. > Waiting for your replies. > > > Thanks & Regards, > Devanshu Vyas. >
Re: Token Based Authentication with Apache OfBiz
Jacques, I think you can go with your solution, as no updates on this since long. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Oct 5, 2017 at 1:49 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rahul, > > Did you finally implement this? If yes could you contribute or share? > > I'm currently working on such a solution and would prefer to share before > contributing my own > > Jacques > > > Le 18/06/2016 à 15:01, Rahul Bhooteshwar a écrit : > >> Hello All, >> Recently felt the need of Token Based Authentication process in Apache >> OfBiz while using OfBiz's business process offerings with standalone >> clients like Mobile Apps, Angular JS based apps running outside Apache >> OfBiz etc. >> >> What currently we are having in OfBiz is session based authentication >> process which is *stateful*. But while dealing with the independently >> running remote clients stateful authentication is not gonna work as we >> will >> not be using *server-browser session* anymore in those cases. >> >> Following are the initial draft & supporting documents to proceed further: >> >> - Token Based Authentication in Apache OfBiz >> <https://docs.google.com/document/d/1xbpjNWGZp8B_79YJmPxmSJq >> kx7Qo_EI7u_PE0WNt3B4/edit#heading=h.g14rrmsoijiv> >> - Token Based Authentication >> <https://docs.google.com/document/d/15QBV87vMD42QppCaHpxgcef >> cg_ac7HFeSQQnF_S50nk/edit#heading=h.mdriqalojfy4> >> - JSON Web Tokens >> <https://docs.google.com/document/d/1wLfv8h_Kkd4iHBxW4Gkx987 >> Q7KBocWAGvss2p4N4fIM/edit> >> - IETF's (Internet Engineering Task Force) Documentation for JSON Web >> Tokens >> <https://drive.google.com/file/d/0BzXOhs4-o0n9cHVGckgwUndsUG >> c/view?pref=2&pli=1> >> >> I would like to propose a requirement to implement this in OfBiz, & invite >> you all to provide valuable inputs to conclude the requirements & >> implementation plans. >> >> Thanks and Regards >> *Rahul Bhooteshwar* >> Enterprise Software Engineer >> HotWax Systems <http://www.hotwaxsystems.com/> - *Global leader in >> innovative enterprise commerce solutions **powered by Apache OFBiz.* >> >> >
Re: buildbot failure in on ofbiz-trunk-framework
I have already fixed this in my next commit. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Oct 30, 2017 at 11:34 AM, wrote: > The Buildbot has detected a new failure on builder ofbiz-trunk-framework > while building . Full details are available at: > https://ci.apache.org/builders/ofbiz-trunk-framework/builds/638 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: lares_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'on-ofbiz-framework-commit' triggered this build > Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1813724 > Blamelist: rishi > > BUILD FAILED: failed shell_2 > > Sincerely, > -The Buildbot > > > >
Re: svn commit: r1813726 - in /ofbiz/ofbiz-framework/trunk/applications: content/data/ party/data/ securityext/data/ workeffort/data/
Thanks Maichale for the note. I tried to follow the pattern mentioned, but some how I did not notice this. I'll change the commit log and take care of this in future. Thanks again! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Oct 30, 2017 at 3:44 PM, Michael Brohl wrote: > Hi Rishi, > > thanks for your contributions! > > Can you please do me a favor and stick to the commit message template (see > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+ > commit+message+template)? > > In case of the last commits, it would be "Improved" instead of > "Improvement" and "(OFBIZ-)" instead of "OFBIZ-". > > You can save us lots of manual work when we produce the monthly blog > development details. > > Please amend your commit messages if you have time. > > Thank you and best regards, > > Michael > > > Am 30.10.17 um 06:57 schrieb ri...@apache.org: > > Author: rishi >> Date: Mon Oct 30 05:57:21 2017 >> New Revision: 1813726 >> >> URL: http://svn.apache.org/viewvc?rev=1813726&view=rev >> Log: >> Improvement: Remove unused files and added additional files to maintain >> all component data. >> OFBIZ-9501 >> >> Removed: >> ofbiz/ofbiz-framework/trunk/applications/content/data/BlogS >> eedData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Conte >> ntHelpData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Conte >> ntHttpErrorData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Conte >> ntOperationData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Conte >> ntPortletData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Conte >> ntSecurityPermissionSeedData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Conte >> ntTypeData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/DataC >> ategoryData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/MimeT >> ypeData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/MimeT >> ypeTemplate.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/MiscData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Party >> HelpData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Templ >> ateData.xml >> ofbiz/ofbiz-framework/trunk/applications/content/data/Webto >> olsHelpData.xml >> ofbiz/ofbiz-framework/trunk/applications/party/data/PartyPo >> rtletData.xml >> ofbiz/ofbiz-framework/trunk/applications/party/data/PartySe >> curityPermissionSeedData.xml >> ofbiz/ofbiz-framework/trunk/applications/party/data/Schedul >> edJobs.xml >> ofbiz/ofbiz-framework/trunk/applications/securityext/data/S >> ecurityPermissionSeedData.xml >> ofbiz/ofbiz-framework/trunk/applications/workeffort/data/Wo >> rkEffortPortletData.xml >> ofbiz/ofbiz-framework/trunk/applications/workeffort/data/Wo >> rkEffortSecurityPermissionSeedData.xml >> ofbiz/ofbiz-framework/trunk/applications/workeffort/data/Wo >> rkEffortSystemPropertyData.xml >> >> > >
Re: [DISCUSSION] How far are willing to go with diluting the Party component to be diluted with business domain specific functions
+1. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sun, Nov 26, 2017 at 2:57 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 25/11/2017 à 21:31, Taher Alkhateeb a écrit : > >> With that being said, I think the party component is relatively stable >> and not getting constantly diluted. But yeah maybe it's carrying too >> much probably for historical reasons. >> > Hi Pierre, Taher, > > I agree with both of you. I just wanted to say that the party component > has not been constantly diluted pertaining to party creation. > IIRW, it exits as is since I know it (2004) and I was able to verify at > least with R09.04 tonight (so 8 years ago, R4.0 seems not to work with Java > 8, R09 does, at least not too badly) > As Taher said, this does not mean that we can't put some effort in > redesigning its UI, maybe not the top priority though... > > Jacques > >
Re: Planning for the creation of the new 17.xx branch(es)
Jacopo, Thanks for heads-up, I have OFBIZ-9501 with me, and I think it should be part of new release. As the data movement will impact on ease of debugging and maintenance. I'm planning to move most seed and seed-initial data by this weekend. This should not impact the release date, because If community allow to commit after release cut then we can migrate the changes to new release after that as well. I'm saying this because I have already move few components data to data model component like party, content and work effort. So for the release the data consistency should be there at least for seed and seed-initial data. If community not allowing to move data after release cut then I would say to hold for few days, so that we can make the data pattern consistent. Also may be others may have more tickets/bugs with them. Kind Regards, -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Nov 28, 2017 at 9:12 PM, Jacopo Cappellato wrote: > It's the end of November and we are close to the deadline for the creation > of the 17.11 branches: how do we feel about it? > Let me know if you want me to proceed, otherwise we will create the > branches in December and they will be named 17.12 > > Regards, > > Jacopo > > On Thu, Oct 12, 2017 at 6:09 PM, Nicolas Malin > wrote: > > > Hi, > > > > Agree to create the release 17.11 with a separate products framework & > > plugins. > > > > It's woulb be nice to create this release one week after the next > > community days :) > > > > Nicolas > > > > > > > > Le 10/10/2017 à 09:35, Jacopo Cappellato a écrit : > > > >> Hi all, > >> > >> I think it is time to start thinking about if, when, how we should > create > >> the new release branch out of the trunk. Actually, for the first time, > we > >> should probably create two branches: one for the framework and one for > the > >> plugins. > >> What do you think? > >> > >> In my opinion we could try to get all the changes we want to have in the > >> trunk to be included in the branch by end of November: this means that > the > >> the creation of the branch could happen at the end of November. > >> If this is the case then the names could be: > >> release17.11-framework > >> release17.11-plugins > >> > >> The above is for the release *branches* only, not for the actual > releases. > >> We could decide at a later point if the actual releases will be shipped > as > >> two separate products (e.g. "Apache OFBiz Framework 17.11.01" and > "Apache > >> OFBiz Plugins 17.11.01") or merged into one (e.g. "Apache OFBiz > >> 17.11.01"). > >> > >> Best regards, > >> > >> Jacopo > >> > >> > > >
Re: Permission overrides auth parameter of service
If an service implements and do checks for the permissions then it must have the auth set as true. If any occurrences found then it should be by mistake and service definition should be fix to match. So I think the behavior we have is correct, whenever we want to check the permission it should have the user in context. Suraj, Any scenario you have in mind where we only require permission service without user? Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Nov 29, 2017 at 1:39 PM, Scott Gray wrote: > auth="false" and a permission service are completely incompatible > scenarios. In what situation could you possibly have no userLogin and > successfully run a permission service? > > What would you expect to happen instead of the current behavior? > > Regards > Scott > > On 3 November 2017 at 17:35, Suraj Khurana com> > wrote: > > > Hello team, > > > > I noticed that in any service definition if auth is set to false and > > permission service is also the service definition, it overrides the auth > > parameter to true by itself. > > > > For quick reference, it is written at *createPermission* method of > > *ModelServiceReader* class. > > Can someone please elaborate this behavior. IMO, this should not happen. > > > > -- > > Thanks and Regards, > > *Suraj Khurana* | Sr. Enterprise Software Engineer > > *HotWax* *Commerce* by *HotWax Systems* > > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > > >
Re: buildbot failure in on ofbiz-trunk-framework-plugins
I'm checking with this one. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Dec 5, 2017 at 9:55 AM, wrote: > The Buildbot has detected a new failure on builder > ofbiz-trunk-framework-plugins while building . Full details are available > at: > https://ci.apache.org/builders/ofbiz-trunk- > framework-plugins/builds/796 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: silvanus_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'on-ofbiz-framework-commit' triggered this build > Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1817151 > Blamelist: rishi > > BUILD FAILED: failed shell_4 > > Sincerely, > -The Buildbot > > > >
Re: buildbot failure in on ofbiz-trunk-framework-plugins
I ran the cleanAll loadAll testIntegration and got build success with no issues. I think we are good. Best Regards, -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Dec 5, 2017 at 10:00 AM, Rishi Solanki wrote: > I'm checking with this one. > > Thanks! > > Rishi Solanki > Sr Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > www.hotwax.co > > On Tue, Dec 5, 2017 at 9:55 AM, wrote: > >> The Buildbot has detected a new failure on builder >> ofbiz-trunk-framework-plugins while building . Full details are available >> at: >> https://ci.apache.org/builders/ofbiz-trunk-framework- >> plugins/builds/796 >> >> Buildbot URL: https://ci.apache.org/ >> >> Buildslave for this Build: silvanus_ubuntu >> >> Build Reason: The AnyBranchScheduler scheduler named >> 'on-ofbiz-framework-commit' triggered this build >> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1817151 >> Blamelist: rishi >> >> BUILD FAILED: failed shell_4 >> >> Sincerely, >> -The Buildbot >> >> >> >> >
Re: buildbot failure in on ofbiz-trunk-framework-plugins
Thanks Jacques! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Dec 5, 2017 at 12:34 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > It's OK here too, I relaunch Buildbot to (hopefully) clean that > > Jacques > > > Le 05/12/2017 à 06:51, Rishi Solanki a écrit : > >> I ran the cleanAll loadAll testIntegration and got build success with no >> issues. >> >> I think we are good. >> >> Best Regards, >> -- >> >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> www.hotwax.co >> >> On Tue, Dec 5, 2017 at 10:00 AM, Rishi Solanki >> wrote: >> >> I'm checking with this one. >>> >>> Thanks! >>> >>> Rishi Solanki >>> Sr Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> www.hotwax.co >>> >>> On Tue, Dec 5, 2017 at 9:55 AM, wrote: >>> >>> The Buildbot has detected a new failure on builder >>>> ofbiz-trunk-framework-plugins while building . Full details are >>>> available >>>> at: >>>> https://ci.apache.org/builders/ofbiz-trunk-framework- >>>> plugins/builds/796 >>>> >>>> Buildbot URL: https://ci.apache.org/ >>>> >>>> Buildslave for this Build: silvanus_ubuntu >>>> >>>> Build Reason: The AnyBranchScheduler scheduler named >>>> 'on-ofbiz-framework-commit' triggered this build >>>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1817151 >>>> Blamelist: rishi >>>> >>>> BUILD FAILED: failed shell_4 >>>> >>>> Sincerely, >>>> -The Buildbot >>>> >>>> >>>> >>>> >>>> >
Re: Extending a form which uses auto-fields-service
Jacques, IMO, we can discard this thread for now. I'll check once I'll finish by in-progress work and get back on this if found anything. Thanks! -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Dec 8, 2017 at 10:01 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, Ravindra, > > I just checked and I don't see any issues here. > > Thanks > > Jacques > > > > Le 05/09/2017 à 17:18, Jacques Le Roux a écrit : > >> Thanks Rishi, >> >> I'll create a Jira soon... >> >> Jacques >> >> >> Le 05/09/2017 à 16:23, Rishi Solanki a écrit : >> >>> As far as I remember this is not fixed till now. >>> >>> Rishi Solanki >>> Sr Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> www.hotwax.co >>> >>> On Mon, Sep 4, 2017 at 4:34 PM, Jacques Le Roux < >>> jacques.le.r...@les7arts.com> wrote: >>> >>> Before I open a Jira for that, please raise a hand if you know this >>>> problem is somehow solved >>>> >>>> Thanks >>>> >>>> Jacques >>>> >>>> >>>> Le 27/06/2010 à 11:00, Ravindra Mandre a écrit : >>>> >>>> Yes , you are right but the problem is not of position, the problem is >>>>> that >>>>> , when I use the tag then fields are arranged in >>>>> the >>>>> way in which they are declared in entity , and if I want to give them >>>>> position then fields are not arranged in the required position , (you >>>>> can >>>>> take the example of updatePerson service ). >>>>> >>>>> >>>>> Regards >>>>> Ravi >>>>> >>>>> On Sat, Jun 26, 2010 at 1:50 PM, Vikas Mayur < >>>>> vikas.ma...@hotwaxmedia.com >>>>> >>>>>> wrote: >>>>>> >>>>> To position some of the fields in a separate column you would need to >>>>> >>>>>> explicitly define those fields and with a position attribute on it. >>>>>> >>>>>> Regards >>>>>> Vikas >>>>>> >>>>>> >>>>>> On Jun 24, 2010, at 7:16 PM, Ravindra Mandre wrote: >>>>>> >>>>>>Yes , I also tried the sort-order but this does not fulfill the >>>>>> >>>>>> requirement >>>>>>> , as suppose I want to arrange two fields in a horizontal way , then >>>>>>> this >>>>>>> does not work . for example : >>>>>>> A) >>>>>>> firstName >>>>>>> lastName >>>>>>> >>>>>>> >>>>>>> >>>>>>> but sort-order does like this >>>>>>> B) >>>>>>> firstName >>>>>>> lastName >>>>>>> >>>>>>> , if there is any other way for doing case A please let me know . >>>>>>> >>>>>>> Ravi >>>>>>> >>>>>>> On Thu, Jun 24, 2010 at 5:47 PM, Jacques Le Roux < >>>>>>> jacques.le.r...@les7arts.com> wrote: >>>>>>> >>>>>>>Did you try also sort-order? >>>>>>> >>>>>>> Jacques >>>>>>>> >>>>>>>> From: "Ravindra Mandre" >>>>>>>> >>>>>>>> Yes , when we use auto-fields-service in a form then, this does not >>>>>>>> allow >>>>>>>> >>>>>>>> us >>>>>>>> >>>>>>>>> to arrange the fields as we want , means position tag inside the >>>>>>>>> field >>>>>>>>> becomes useless . >>>>>>>>> >>>>>>>>> Ravi >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Jun 22, 2010 at 9:58 PM, Jacques Le Roux < >>>>>>>>> jacques.le.r...@les7arts.com> wrote: >>>>>>>>> >>>>>>>>> Sorry, it's not related to auto-fields-service. I was able to >>>>>>>>> extend >>>>>>>>> >>>>>>>>> another form which uses auto-fields-service >>>>>>>>> >>>>>>>>>> I will dig in when I will get time... >>>>>>>>>> >>>>>>>>>> Forget it >>>>>>>>>> >>>>>>>>>> Jacques >>>>>>>>>> >>>>>>>>>> From: "Jacques Le Roux" >>>>>>>>>> >>>>>>>>>> Looks like extending a form which uses auto-fields-service does >>>>>>>>>> not >>>>>>>>>> work >>>>>>>>>> >>>>>>>>>>properly. Has someone some experience witht that? >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>>> >>>>>>>>>>> Jacques >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >> >
Re: [DISCUSSION] Review ProductPromo action and condition process
+1 for the proposal, Nicolas!
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co
On Mon, Dec 11, 2017 at 7:20 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Ha I see, you speak about
>
> enumTypeId="PROD_PROMO" hasTable="N" parentTypeId=""/>
> enumTypeId="PROD_PROMO_IN_PARAM" hasTable="N" parentTypeId="PROD_PROMO"/>
> enumTypeId="PROD_PROMO_COND" hasTable="N" parentTypeId="PROD_PROMO"/>
>
> Then yes I understand and I think a POC would be welcome :)
>
> Jacques
>
>
> Le 11/12/2017 à 13:08, Jacques Le Roux a écrit :
>
>> Hi Nicolas,
>>
>> I don't see why you speak about enumeration for ProductPromoCond and
>> ProductPromoAction which are plain entities.
>>
>> Jacques
>>
>>
>> Le 08/12/2017 à 14:14, Nicolas Malin a écrit :
>>
>>> Hello,
>>>
>>> Yesterday during a boring time in the come back home train, I read the
>>> ofbiz demo data review that the condition and action method are listed
>>> through enumeration like :
>>>
>>> >> productPromoActionEnumId="PROMO_GWP"
>>> .../>
>>> >> inputParamEnumId="PPIP_PRODUCT_TOTAL"
>>> operatorEnumId="PPC_GTE" condValue="1"/>
>>>
>>> and liked to the code by java hard code (ProductPromoWorker.java)
>>>
>>> condition :
>>> } else if ("PPIP_PRODUCT_TOTAL".equals(inputParamEnumId)) {
>>> // this type of condition allows items involved to be
>>> involved in other quantity consuming cond/action, and does pro-rate the
>>> price
>>>
>>>
>>> action :
>>> } else if ("PROMO_GWP".equals(productPromoActionEnumId)) {
>>> ...
>>>
>>> This isn't really useful to manage and extend it but an idea raise in my
>>> mind :)
>>>
>>> Why not replace the enumeration by a customMethod. We can define a
>>> interface service one for action and one for condition, with the related
>>> customMethodType. Each hard coded enumeration would be convert to service.
>>>
>>> Like this we can surcharge the current rules easily and create new one
>>> for customer site without modify the core.
>>> The main strategy point would be the interface service to pass the good
>>> parameters.
>>>
>>> >> .../>
>>> >> operatorEnumId="PPC_GTE" condValue="1"/>
>>>
>>> This is easily to improve on java code, screen and data.
>>> What do you thinks ? Do you have an other idea to improve this ?
>>>
>>> Cheers,
>>> Nicolas
>>>
>>>
>>
>>
>
Re: Are we ready to publish a new release (16.11.04)?
+1. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Dec 20, 2017 at 2:15 AM, Michael Brohl wrote: > +1 > > Thanks, > > Michael > > > Am 19.12.17 um 16:43 schrieb Jacopo Cappellato: > > Hi all, >> >> we have published our last release mostly 6 months ago and since then we >> have merged several bug fixes to our 16.11 branch: I think it is time to >> publish a new one! >> >> If there are no objections I am going to prepare the release files in the >> next few days and then we will start the release vote: if you think we >> should backport fixes to that branch this is the right time to do it >> before >> we start the release process. >> >> Kind regards, >> >> Jacopo >> >> > >
Re: Splitter
I would say, most UI requirement can be achieve thru right combination of section and sub sections. Can you please help us in understanding what do you want to achieve with your proposal. Please refer partymgr >> viewprofile it contains all possible combination. Still something is not exists as per your needs then please share what you like to achieve. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Dec 27, 2017 at 10:12 AM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > Hi James, > > I am a bit unclear on this proposal. You define in the actions of some > parent section a splitter between two sub-sections? What's the purpose? How > does it translate to html? And how is it related to headers, footers or > scrollbars? > > On Dec 26, 2017 6:41 PM, "James Yong" wrote: > > Hi All, > > Would like to implement a splitter tag for the Widgets. This new tag can be > used in the Actions tags to add a splitter between 2 sections. This is > useful when you want to > 1) keep the header, footer always visible; or > 2) put different sections together; each section has their own scrollbars. > Thus minimizing empty spaces on the pages. > > Any feedback would be greatly appreciated > > Regards, > James Yong >
Re: Planning for the creation of the new 17.xx branch(es)
Thanks Jacopo and all who participated in this release. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Dec 28, 2017 at 4:41 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > We have now the release branches: > > https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/ > branches/release17.12/ > https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/ > branches/release17.12/ > > Please review them and make any adjustments required; we should also update > our website: > https://ofbiz.apache.org/source-repositories.html > > ... the community has now a new toy to play with :-) > > Jacopo >
Re: Use getCombinedMap instead of getParameter
+1 Michael. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Dec 29, 2017 at 6:21 PM, Michael Brohl wrote: > Hi Suraj, > > I think we should use different ways of getting parameters, attributes > etc. depending on what is needed in the business logic. > > For example, if you only want to use request parameters in an event and > don't need the overriding mechanism, using UtilHttp.getCombinedMap is > unnecessary overhead. > > I might make sense to refactor code where the business logic first gets > the parameters and checks for session/request attributes later to override > them or use them if parameters are missing. > > So I think refactoring is a good idea but using it generally throughout > the codebase should be avoided. > > Thanks, > > Michael > > > Am 29.12.17 um 12:33 schrieb Suraj Khurana: > > Hello team, >> >> I noticed in current codebase, at many places we use >> *request.getParameter *which >> only searches in parameters map. Instead of it, it is recommended to use >> *UtilHttp.getCombinedMap(request)* that will create a single map from the >> session, attribute, parameter and servlet context map. >> >> This could be a good improvement in the current code base. Please let me >> know your thoughts about this. >> >> -- >> Thanks and Regards, >> *Suraj Khurana* | Sr. Enterprise Software Engineer >> *HotWax Commerce* by *HotWax Systems* >> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 >> >> > >
Re: [DISCUSSION] The Simple Map Processor Mini-Language
Jacques, As far as I remember when you raised this in past, and no proposal on how to replace it. As simple map processor is used for mapping and validation, So I think we should take a pause on it and let the remaining minilang to groovy complete. >From my side having simple map processor in minilang (we could also use XML) should be fine for now. And we can discuss/think/propose on the alternative ways of doing the same once solution is in place and we agree, then we can decide weather to remove old way or keep it. I see similar approach in other projects and they keep supporting both ways to invoke validation methods for a while. Best, Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Feb 7, 2018 at 2:57 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > I recently see some activity to replace the minilang by Groovy and that's > great. > > There is though a question I asked 2 times[1][2] without any answers. It's > about the Simple Map Processor Mini-Language: > > https://cwiki.apache.org/confluence/pages/viewpage.action? > pageId=50233697#Mini-LanguageGuide(Version1-Deprecated)-TheS > impleMapProcessorMini-Language > > Shall we keep it as is or replace it, and then by what? Is there already a > plan for that? I saw none I'm not wrong. > > [1] http://markmail.org/message/z63ff7s7hgm4rb3e > [2] https://s.apache.org/Nm9B > > Jacques > > >
Re: [DISCUSSION] The Simple Map Processor Mini-Language
+1 Taher, I also proposed to take pause and go slow on conversion. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Feb 8, 2018 at 12:40 AM, Michael Brohl wrote: > +1 > Regards, > Michael > > > > > Am 07.02.2018 um 10:13 schrieb Taher Alkhateeb < > slidingfilame...@gmail.com>: > > > > I propose a feature freeze on anything related to minilang. Let's just > fix > > bugs and try to slowly move out. > > > >> On Feb 7, 2018 11:36 AM, "Rishi Solanki" > wrote: > >> > >> Jacques, > >> As far as I remember when you raised this in past, and no proposal on > how > >> to replace it. > >> As simple map processor is used for mapping and validation, So I think > we > >> should take a pause on it and let the remaining minilang to groovy > >> complete. > >> > >> From my side having simple map processor in minilang (we could also use > >> XML) should be fine for now. And we can discuss/think/propose on the > >> alternative ways of doing the same once solution is in place and we > agree, > >> then we can decide weather to remove old way or keep it. > >> > >> I see similar approach in other projects and they keep supporting both > ways > >> to invoke validation methods for a while. > >> > >> Best, > >> > >> > >> Rishi Solanki > >> Sr Manager, Enterprise Software Development > >> HotWax Systems Pvt. Ltd. > >> Direct: +91-9893287847 > >> http://www.hotwaxsystems.com > >> www.hotwax.co > >> > >> On Wed, Feb 7, 2018 at 2:57 AM, Jacques Le Roux < > >> jacques.le.r...@les7arts.com> wrote: > >> > >>> Hi, > >>> > >>> I recently see some activity to replace the minilang by Groovy and > that's > >>> great. > >>> > >>> There is though a question I asked 2 times[1][2] without any answers. > >> It's > >>> about the Simple Map Processor Mini-Language: > >>> > >>> https://cwiki.apache.org/confluence/pages/viewpage.action? > >>> pageId=50233697#Mini-LanguageGuide(Version1-Deprecated)-TheS > >>> impleMapProcessorMini-Language > >>> > >>> Shall we keep it as is or replace it, and then by what? Is there > already > >> a > >>> plan for that? I saw none I'm not wrong. > >>> > >>> [1] http://markmail.org/message/z63ff7s7hgm4rb3e > >>> [2] https://s.apache.org/Nm9B > >>> > >>> Jacques > >>> > >>> > >>> > >> > >
Re: Overriding eca definition
Suraj/Nicolas, IMO, There is no need to extend/override an ECA rule. ECA like we want to trigger something conditionally and it happens once we establish the rule. We can change the rule, and we are doing that frequently as per our custom requirement and we have calls to disable sometimes when required. +1 for having condition-service tag, it should be useful for adding more proper conditions for running EECAs. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Feb 10, 2018 at 6:12 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Hi Nicolas, > > I think there is a confusion here. > I am trying to find the reason why condition-service have not been > implemented for ecas? > I there is no such reason, I propose we should have a similar concept for > ecas as well. > So that we can write something like: > > > value="ORDER_COMPLETED"/> > value="Y"/> > > > > > Here, checkForSomeCondition service must return true to proceed for > issueImmediatelyFulfilledOrder. > HTH. > > -- > Thanks and Regards, > *Suraj Khurana* | Sr. Enterprise Software Engineer > *HotWax Commerce* by *HotWax Systems* > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > > On Sat, Feb 10, 2018 at 1:35 PM, Nicolas Malin > wrote: > > > Hello Suraj, > > > > Currently I see no possibility to override an eca because definitions are > > all loaded and we can have exactly two identical definition with > different > > action. In this case difficult to spot the eca to disable/improve. > > > > So before try to override an eca I suggest to implement an identification > > like : > > > > > package="org.apache.ofbiz.accounting" > id="FinAccountTransBalanceUpda > > te"> > > > value="FINACT_TRNS_APPROVED"/> > > mode="sync"/> > > > > > > and after we would implement a new element as flying idea : > > > id="FinAccountTransBalanceUpdate"> > > > > > value="LOVE"/> > > > > > > or > > > id="FinAccountTransBalanceUpdate"> > > or > > > id="FinAccountTransBalanceUpdate"> > > > > > value="LOVE"/> > > > > > > > > > > Nicolas > > > > > > > > On 09/02/2018 14:01, Suraj Khurana wrote: > > > >> Hello, > >> > >> What is the best way to override entity eca definition? > >> Suppose you need to add a condition-service as well in eca, as far as I > >> can > >> check, currently, there is no way to handle condition service in eca > rule. > >> > >> IMO, this could be interesting to have this thing, is it intentional > that > >> we do this only for seca rules and not for eca's? > >> > >> Please share your thoughts on this. > >> -- > >> Thanks and Regards, > >> *Suraj Khurana* | Omnichannel OMS Technical Expert > >> *HotWax Commerce* by *HotWax Systems* > >> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > >> > >> > > >
Re: updatePostalAddress, updateTelecomNumber (contactMechs) missnamed ?
+1 Deepak!! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sat, Feb 24, 2018 at 11:44 AM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > Yes it may confuse but I think its correct, the basic rule is if you want > to update postal address (ContactMech) it will expire old one and create > new one with update. So Ideally PostalAddress is an immutable object where > you can;t do modification in it. > > if you want to update you need to clone it and do update. > > I think we can add this in entity auto engine so that it will be part of > entity auto framework. > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Fri, Feb 23, 2018 at 8:11 PM, gil portenseigne < > gil.portensei...@nereide.fr> wrote: > > > Hello, > > > > While working on a new contactMech type (no spoiler yet, that will come > in > > some days ;)), I wanted to develop the CRUD services , and stumbled upon > > something that bother me. > > > > Actually, when we update a contactMech in OFBiz, the service keep history > > of it, to keep reference for related entity (like communicationEvent and > > such). Thanks to that, old communication event/invoice/etc. refer to the > > old contact mechanism. > > > > That's fine with me, but what is bothering me is that updatePostalAddress > > (and others) service is named like every auto-entity CRUD services within > > OFBiz, that could be misleading for newcomers > > > > I feel like we have to change the naming of these services. No good idea > > yet about a new name... Am I the only one wondering about that ? Is that > > fine to keep "udpate" in this context ? > > > > WDYT ? > > > > Gil > > > > > > -- > > logoNrd <http://nereide.fr/> > > Gil PORTENSEIGNE > > Intégrateur Apache-OFBiz, ERP en logiciel Libre > > informat...@nereide.fr > > 8 rue des Déportés 37000 TOURS > > 02 47 50 30 54 > > > > | Réseau Libre Entreprise <http://www.libre-entreprise.org/> > > > > >
Re: orderSkipInvoice, complete an order without generating an invoice
Antoine, In general I observe that for a party business may want to send invoice at the end of month. But for that as well I think its okay to generate the invoice at the time of order completion and send all invoices once. Also what Taher suggested looks promising to me. That means use invoice status, lets say all invoices in Pending status until some user come and approve it. Then use statuses to consider invoices for business use etc. So I think what you expect for your requirement actually OFBiz offers, you can use the status workflow for that. Most probably no custom changes. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Feb 26, 2018 at 4:24 PM, Taher Alkhateeb wrote: > Hi Antoine, > > Thank you for your work and I hope we get to work with you more often. > I have a few comments / questions: > > - First of all, you added a postgres dependency to the build file > (probably by mistake?). > - perhaps others can pitch in but I'm not sure if it is useful to > introduce? Is this a common need or more of a specific custom > requirement? > - Also, why an indicator? Why not for example just a different status > workflow instead? > > On Mon, Feb 26, 2018 at 1:40 PM, Antoine Ouvrard > wrote: > > Hello, > > > > I would like to introduce you a improvement. > > > > In some case, we need to delay billing at the end of the month for > > example. > > > > But to complete the order we need to disable triggering the > > invoice generation. > > > > Here's my proposal https://issues.apache.org/jira/browse/OFBIZ-10241 > > > > Antoine >
Re: orderSkipInvoice, complete an order without generating an invoice
Nicolas, Thank you for the detailed information. I agree on setting the trigger value on on store level so that each store may behaves as per business need, in case of multiple stores. Just one question here, orderHeader will also have the same field or it is intended to override some default behavior of store level setting. Could you please help us here bit more, when you get chance. Thanks! Best Regards, Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Feb 27, 2018 at 10:30 PM, Nicolas Malin wrote: > Hi Rishi > > On 26/02/2018 15:11, Rishi Solanki wrote: > >> Antoine, >> >> In general I observe that for a party business may want to send invoice at >> the end of month. But for that as well I think its okay to generate the >> invoice at the time of order completion and send all invoices once. >> >> Also what Taher suggested looks promising to me. That means use invoice >> status, lets say all invoices in Pending status until some user come and >> > It's a little more complicated from own different business context. In > Europe the generate invoice date it's really important for payment term and > order sequence of invoice ids. Theses problematic exclude all ideas to pre > generate invoice before sent it. > > Currently on the standard we have only the possibility to say for an order > that we bill it when a shipment is completed or the order is completed. But > we can't stop the invoice generation. > > And to complicate the picture we have some site with billing agreement > where some order can bill at the shipment, some other at the end of month > and some other related to the incoterm. It's really a pain :) > > I already exchanged with Antoine with the first implementation, because we > implement this quickly. I'm not in favor to invoicePerOrder and also to > remove invoicePerShipment to replace them by an enumeration on the > ProductStore and the OrderHeader like productStore.billingOrderProcessEnumId > and orderHeader.billingOrderProcessEnumId clearly identify where we can > implement on standard and offer the possibility to define more for custom > billing process. > > With this we can define how a product store manage them orders and if > necessary we can manage some exception by order. > > Cheers, > Nicolas > > > approve it. Then use statuses to consider invoices for business use etc. >> >> So I think what you expect for your requirement actually OFBiz offers, you >> can use the status workflow for that. Most probably no custom changes. >> >> >> >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> www.hotwax.co >> >> On Mon, Feb 26, 2018 at 4:24 PM, Taher Alkhateeb < >> slidingfilame...@gmail.com >> >>> wrote: >>> Hi Antoine, >>> >>> Thank you for your work and I hope we get to work with you more often. >>> I have a few comments / questions: >>> >>> - First of all, you added a postgres dependency to the build file >>> (probably by mistake?). >>> - perhaps others can pitch in but I'm not sure if it is useful to >>> introduce? Is this a common need or more of a specific custom >>> requirement? >>> - Also, why an indicator? Why not for example just a different status >>> workflow instead? >>> >>> On Mon, Feb 26, 2018 at 1:40 PM, Antoine Ouvrard >>> wrote: >>> >>>> Hello, >>>> >>>> I would like to introduce you a improvement. >>>> >>>> In some case, we need to delay billing at the end of the month for >>>> example. >>>> >>>> But to complete the order we need to disable triggering the >>>> invoice generation. >>>> >>>> Here's my proposal https://issues.apache.org/jira/browse/OFBIZ-10241 >>>> >>>> Antoine >>>> >>> >
Re: orderSkipInvoice, complete an order without generating an invoice
Nicolas, I have some concerns like how to override the enumeration at order level and overriding it at order level is okay, may be people from community advise here. But yes a POC would be of help to understand the exact use cases, which may clear my most concerns. Please consider one suggestion to keep the existing flow as is with the demo data, so that default OFBiz behaves as is. Thanks! -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Mar 1, 2018 at 1:43 PM, Nicolas Malin wrote: > Hello Rishi > > On 28/02/2018 11:43, Rishi Solanki wrote: > >> Nicolas, >> >> Thank you for the detailed information. I agree on setting the trigger >> value on on store level so that each store may behaves as per business >> need, in case of multiple stores. Just one question here, orderHeader will >> also have the same field or it is intended to override some default >> behavior of store level setting. >> > Yes, set the same field on the orderHeader would be increase the > granularity rule. > By default your store generate an invoice for each shipment but for a > "specific big customer" you bill these orders by one invoice by month. > With a surcharge on the order you can implement a seca on your plugin to > analyze the customer when you create an order and change the billing > process value for this order. > > I exchanged also with Pierre Gaudin, he has been implemented for a > customer a process to generate a invoice per month on some specific case, > we will see if we can adapt this with enumeration idea. > If you are agree I propose to try a POC with 4 cases : > * bill on shipment > * bill on order completed > * bill on demand > * no billed > > Thanks Rishi for your look > Cheers, > Nicolas > > >> Could you please help us here bit more, when you get chance. Thanks! >> >> >> Best Regards, >> >> >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> www.hotwax.co >> >> On Tue, Feb 27, 2018 at 10:30 PM, Nicolas Malin > > >> wrote: >> >> Hi Rishi >>> >>> On 26/02/2018 15:11, Rishi Solanki wrote: >>> >>> Antoine, >>>> >>>> In general I observe that for a party business may want to send invoice >>>> at >>>> the end of month. But for that as well I think its okay to generate the >>>> invoice at the time of order completion and send all invoices once. >>>> >>>> Also what Taher suggested looks promising to me. That means use invoice >>>> status, lets say all invoices in Pending status until some user come and >>>> >>>> It's a little more complicated from own different business context. In >>> Europe the generate invoice date it's really important for payment term >>> and >>> order sequence of invoice ids. Theses problematic exclude all ideas to >>> pre >>> generate invoice before sent it. >>> >>> Currently on the standard we have only the possibility to say for an >>> order >>> that we bill it when a shipment is completed or the order is completed. >>> But >>> we can't stop the invoice generation. >>> >>> And to complicate the picture we have some site with billing agreement >>> where some order can bill at the shipment, some other at the end of month >>> and some other related to the incoterm. It's really a pain :) >>> >>> I already exchanged with Antoine with the first implementation, because >>> we >>> implement this quickly. I'm not in favor to invoicePerOrder and also to >>> remove invoicePerShipment to replace them by an enumeration on the >>> ProductStore and the OrderHeader like productStore.billingOrderProce >>> ssEnumId >>> and orderHeader.billingOrderProcessEnumId clearly identify where we can >>> implement on standard and offer the possibility to define more for custom >>> billing process. >>> >>> With this we can define how a product store manage them orders and if >>> necessary we can manage some exception by order. >>> >>> Cheers, >>> Nicolas >>> >>> >>> approve it. Then use statuses to consider invoices for business use etc. >>> >>>> So I think what you expect for your requirement actually OFBiz offers, >>>> you >>>> can us
Re: [Discussion] Creating a unified service-library component
+1 for the idea for having services at top and then use them whenever required, the only thing comes in my mind (also mentioned by Paul in the thread) what to do with the cross component services. Also once the services moved then how to customize them as per requirements. But we can finalize the things as we move. We can go slowly and move the items in following sequence to be on safer side (better advise from community most welcome); 1) Entity Auto Services and service interfaces (with dependency check) 2) Other Crud Services 3) Other services in order of component-load In most cases we don't have to worry about the order of services load, but it would be good to follow some practice to work independently for components. The best thing I can see here, once we have everything comes out as Map we can use any UI technology to work with OFBiz and can have our own UI independent on OFBiz other components. So again big +1. I would like to help/work on this effort, LMK. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Mar 5, 2018 at 10:57 AM, Taher Alkhateeb wrote: > Hi Paul, Good points and questions. Inline ... > > On Mar 5, 2018 2:36 AM, "Paul Foxworthy" wrote: > > On 5 March 2018 at 00:45, Taher Alkhateeb > wrote: > > > > I think If you look at both the "data model" and "services" in OFBiz > > you will notice the following: > > > > - They are highly coupled and everything is connected to everything > > (orders, parties, work efforts, contents, etc ...) > > - Some services and entity models are component-specific and do not > > belong to the generic data models and services. > > > > So what does that mean? It means in order to achieve real flexibility > > and a clean architecture, perhaps we need to separate our data model > > and services from the rest of the components in the system, and we > > already did this with the datamodel component. > > > > So I propose creating a new component, perhaps calling it > > "service-library" that houses all "generic" services that operate on > > the "generic" data model. I propose we implement this new component as > > follows: > > > > - Slowly move services (one at a time) from components to this central > > library, cleaning and refactoring as we move. > > - Migrate any minilang services to another engine while moving > > (groovy, entityauto, etc ...) > > - Keep any services that are component-specific and do not operate on > > the generic data model in the component > > > > What do you think? Do you agree with the general idea? Can we do this > > in a better way? Anyone interested in helping out? > > > > Hi Taher, > > It is the nature of a business process to cross many functional areas. To > fulfil an order, we might need to commission manufacturing involving people > and equipment, order from suppliers, manage inventory, schedule shipments > and create accounting records. > > What proportion of services do you think would turn out to be generic? > > Perhaps most of them. What I mean by generic is that they act on the > datamodel or apply wide scoped logic. > In other words, any service that does not need to exist if you delete a > component would be tightly coupled to that component and should probably > stay there. > > > Any OFBiz implementor can add SECAs which cross component boundaries, when > the original design of a service did not anticipate that. Do we still want > to allow that? If so, the split between "generic" and "component-specific" > is only approximate, and adding SECAs will blur the distinction. > > I think perhaps most SECAs could move too. After all SECAs are just forming > a call graph indirectly. And if you call any service from any component the > SECAs would always apply no? > > > If most services move to be generic, there will be one component with many > tightly-coupled services, and we'll have lost some partitioning and > organisation. So will we have gained anything? > Could we think of services as being partitioned into components only for > the purpose of rough categorisation and human understanding, and for no > technical or communication reason? > > Well, just like in the data model component, we can have directories to > split the services by category. > > > If a component-specific service is modified to be slightly more complex or > general, so it now interacts with generic services or services in other > components, does that mean it should move to be generic? As we extend OFBiz > to be more capable,
Re: buildbot failure in on ofbizTrunkFramework
I have reverted my commit for now, not sure what went wrong with commit as I have tested the functionality before commit. I'll check and get back on this. Also I'll reopen the ticket. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Mar 13, 2018 at 6:55 PM, wrote: > The Buildbot has detected a new failure on builder ofbizTrunkFramework > while building . Full details are available at: > https://ci.apache.org/builders/ofbizTrunkFramework/builds/128 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: lares_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkFrameworkCommit' triggered this build > Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1826627 > Blamelist: rishi > > BUILD FAILED: failed shell_2 > > Sincerely, > -The Buildbot > > > >
Re: svn commit: r1826633 - /ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml
Thanks Deepak! I have updated the commit log. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Mar 14, 2018 at 11:03 AM, Deepak Dixit < deepak.di...@hotwaxsystems.com> wrote: > Hi Rishi, > > Could you please update commit log and use "Reverted: as prefix? > https://cwiki.apache.org/confluence/x/TxjtAw > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Tue, Mar 13, 2018 at 7:19 PM, wrote: > > > Author: rishi > > Date: Tue Mar 13 13:49:23 2018 > > New Revision: 1826633 > > > > URL: http://svn.apache.org/viewvc?rev=1826633&view=rev > > Log: > > Improved: Improve GeneralLedgerServices to set transaction date as > > payment's effective date. Reverting my commit due to buildbot failure > > message will check and commit it back. > > (OFBIZ-10239) > > > > Modified: > > ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/ > > GeneralLedgerServices.xml > > > > Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/ > > minilang/ledger/GeneralLedgerServices.xml > > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ > > applications/accounting/minilang/ledger/GeneralLedgerServices.xml?rev= > > 1826633&r1=1826632&r2=1826633&view=diff > > > > == > > --- ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/ > GeneralLedgerServices.xml > > (original) > > +++ ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/ > GeneralLedgerServices.xml > > Tue Mar 13 13:49:23 2018 > > @@ -2404,7 +2404,6 @@ under the License. > > > value="OUTGOING_PAYMENT"/> > > > from-field="partyId"/> > > > from-field="payment.paymentId"/> > > - > from-field="payment.effectiveDate"/> > > > from-field="acctgTransEntries"/> > > > in-map-name="createAcctgTransAndEntriesInMap"> > > > > @@ -2649,7 +2648,6 @@ under the License. > > > from-field="acctgTransEntries"/> > > > value="PAYMENT_APPL"/> > > > value="ACTUAL"/> > > - > from-field="payment.effectiveDate"/> > > > from-field="paymentApplication.paymentId"/> > > > from-field="paymentApplication.invoiceId"/> > > > value="true"> > > > > > > >
Re: buildbot failure in on ofbizTrunkFramework
Jacques, I did not receive any error at my end. I'm retesting the improvement locally and get back on this. Thanks! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Wed, Mar 14, 2018 at 2:46 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Yep thanks Scott, I did that too much so got an aversion about it, > especially when there are lot of false errors/failures. > > Rishi, Do you confirm you get also this error locally? > > Jacques > > > > Le 13/03/2018 à 21:42, Scott Gray a écrit : > >> It's easy to just search the log output for "JUNIT (failure)", which >> reports this test failed: >> >> 2018-03-13 13:18:52,725 |main |TestRunContainer >>|W| [JUNIT (failure)] - >> auto-accounting-transaction-tests-purchase.testAcctgTransOnP >> aymentSentToSupplier >> : Assertion failed: [acctgTrans.glJournalId=ERROR_JOURNAL] not-equals >> ERROR_JOURNAL as >> >> Regards >> Scott >> >> On 14 March 2018 at 03:34, Jacques Le Roux >> wrote: >> >> Hi Rishi, >>> >>> Sorry I did not check the tests at https://ci.apache.org/projects >>> /ofbiz/logs/trunk/framework/html/ as I use to do in such cases. So now >>> they show nothing abnormal. >>> >>> Sometimes BuildBot (actually the machines under it, which are under very >>> heavy load, actually like 100% on all parts I guess, because they always >>> have something on their plates) have some hiccups, and then the tests >>> fail >>> when they should not. >>> >>> If tests pass locally, please commit again to see if the same happen. If >>> the same happen then if possible check with a team mate locally again or >>> ask for the same here :) >>> >>> HTH >>> >>> Jacques >>> >>> >>> >>> Le 13/03/2018 à 14:50, Rishi Solanki a écrit : >>> >>> I have reverted my commit for now, not sure what went wrong with commit >>>> as >>>> I have tested the functionality before commit. I'll check and get back >>>> on >>>> this. >>>> >>>> Also I'll reopen the ticket. >>>> >>>> Rishi Solanki >>>> Sr Manager, Enterprise Software Development >>>> HotWax Systems Pvt. Ltd. >>>> Direct: +91-9893287847 >>>> http://www.hotwaxsystems.com >>>> www.hotwax.co >>>> >>>> On Tue, Mar 13, 2018 at 6:55 PM, wrote: >>>> >>>> The Buildbot has detected a new failure on builder ofbizTrunkFramework >>>> >>>>> while building . Full details are available at: >>>>> https://ci.apache.org/builders/ofbizTrunkFramework/builds/128 >>>>> >>>>> Buildbot URL: https://ci.apache.org/ >>>>> >>>>> Buildslave for this Build: lares_ubuntu >>>>> >>>>> Build Reason: The AnyBranchScheduler scheduler named >>>>> 'onTrunkFrameworkCommit' triggered this build >>>>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1826627 >>>>> Blamelist: rishi >>>>> >>>>> BUILD FAILED: failed shell_2 >>>>> >>>>> Sincerely, >>>>>-The Buildbot >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >
Demo Trunk Break
Devs, On browsing - https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Party Received following exception, Any one facing the similar issue with demo please share. I'm looking into it and get back if find the root cause for the same. Thanks! Here is the error received on UI ERROR rendering error page [/error/error.jsp], but here is the error text: java.lang.IllegalArgumentException: Error running script at location [component://webtools/groovyScripts/entity/FindGeneric.groovy]: org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed: General error during class generation: java.lang.NoClassDefFoundError: Unable to load class org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer due to missing dependency org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink java.lang.RuntimeException: java.lang.NoClassDefFoundError: Unable to load class org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer due to missing dependency org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink at org.codehaus.groovy.control.CompilationUnit.convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101) at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1079) at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:603) at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:581) at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:558) at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298) at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268) at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:254) at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:211) at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.java:195) at org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLocation(GroovyUtil.java:159) at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:206) at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) at ==== Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co
Re: Demo Trunk Break
It seems something specific with deployment/data at demo instance, locally It is working. No issue with latest trunk fresh data. Best, Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki wrote: > Devs, > On browsing - https://demo-trunk.ofbiz.apache.org/webtools/control/ > FindGeneric?entityName=Party > > Received following exception, Any one facing the similar issue with demo > please share. I'm looking into it and get back if find the root cause for > the same. > > > Thanks! > > > Here is the error received on UI > > > ERROR rendering error page [/error/error.jsp], but here is the error text: > java.lang.IllegalArgumentException: Error running script at location > [component://webtools/groovyScripts/entity/FindGeneric.groovy]: > org.codehaus.groovy.control.MultipleCompilationErrorsException: startup > failed: General error during class generation: java.lang.NoClassDefFoundError: > Unable to load class org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer > due to missing dependency > org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink > java.lang.RuntimeException: java.lang.NoClassDefFoundError: Unable to > load class org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer due > to missing dependency > org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink > at org.codehaus.groovy.control.CompilationUnit. > convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101) at > org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1079) > at > org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:603) > at > org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:581) > at > org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:558) > at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298) > at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268) > at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:254) > at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:211) > at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.java:195) > at > org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLocation(GroovyUtil.java:159) > at > org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:206) > at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) > at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) > at > > > > Rishi Solanki > Sr Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > www.hotwax.co >
Re: Demo Trunk Break
Jacques, No worries, thanks for the information. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Mar 15, 2018 at 1:54 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Rishi, > > It was me currently "playing" with the trunk demo. > > I just restarted it and it's OK > > Sorry for the disturbance, I have no other ways to test one thing > > Jacques > > > > Le 15/03/2018 à 08:59, Rishi Solanki a écrit : > >> It seems something specific with deployment/data at demo instance, locally >> It is working. No issue with latest trunk fresh data. >> >> Best, >> >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> www.hotwax.co >> >> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki >> wrote: >> >> Devs, >>> On browsing - https://demo-trunk.ofbiz.apache.org/webtools/control/ >>> FindGeneric?entityName=Party >>> >>> Received following exception, Any one facing the similar issue with demo >>> please share. I'm looking into it and get back if find the root cause for >>> the same. >>> >>> >>> Thanks! >>> >>> >>> Here is the error received on UI >>> >>> >>> ERROR rendering error page [/error/error.jsp], but here is the error >>> text: >>> java.lang.IllegalArgumentException: Error running script at location >>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]: >>> org.codehaus.groovy.control.MultipleCompilationErrorsException: startup >>> failed: General error during class generation: >>> java.lang.NoClassDefFoundError: >>> Unable to load class org.apache.ofbiz.widget.render >>> er.macro.MacroFormRenderer >>> due to missing dependency org/apache/ofbiz/widget/model/ >>> ModelFormField$SubHyperlink >>> java.lang.RuntimeException: java.lang.NoClassDefFoundError: Unable to >>> load class org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer due >>> to missing dependency org/apache/ofbiz/widget/model/ >>> ModelFormField$SubHyperlink >>> at org.codehaus.groovy.control.CompilationUnit. >>> convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101) at >>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl >>> assNodes(CompilationUnit.java:1079) >>> at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation >>> (CompilationUnit.java:603) >>> at org.codehaus.groovy.control.CompilationUnit.processPhaseOper >>> ations(CompilationUnit.java:581) >>> at org.codehaus.groovy.control.CompilationUnit.compile(Compilat >>> ionUnit.java:558) >>> at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader >>> .java:298) >>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268) >>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:254) >>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:211) >>> at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.java:195) >>> at org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca >>> tion(GroovyUtil.java:159) >>> at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr >>> oovyUtil.java:206) >>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt >>> il.java:342) >>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt >>> il.java:324) >>> at >>> >>> >>> >>> Rishi Solanki >>> Sr Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> www.hotwax.co >>> >>> >
Re: Separation database for inventory module
Hi Jayachandra, Register new group in entityengine.xml with new name and data resource; Add new data resource entry in the entityengine.xml like we have many. In your case entityengine will contains two entry as localmysql and localmysql2 (or any name you prefer). Now register all the entities with "your.group.name" in entity-group.xml. Refer and related entries for more details. HTH! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Mar 20, 2018 at 3:45 PM, Rajesh Mallah wrote: > Hi Jaya , > > thanks for sharing the interesting details . Pls allow some time for > detailed reply > which database do you use btw? > > regds > Mallah. > > On Tue, Mar 20, 2018 at 2:40 PM, jayachandr...@gmail.com < > jayachandr...@gmail.com> wrote: > > > > > > > On 2018/03/19 15:23:07, Rajesh Mallah wrote: > > > Hello Jaya , > > > > > > Could you consider hinting why you would want certain entities in a > > > separate database? > > > What are you trying to achieve? > > > > > > regds > > > mallah. > > > > > > > > > On Mon, Mar 19, 2018 at 8:23 PM, jayachandr...@gmail.com < > > > jayachandr...@gmail.com> wrote: > > > > > > > Hi All, > > > > > > > > In Ofbiz I want to create separate database for inventory module > with > > > > dependency tables like InentoryItem & so on. I don't see any issue > > foreign > > > > key relations between dependency tables(like product, order related) > > but i > > > > see the view entities are using many places in application hence some > > of > > > > the inventory process may breaks. > > > > > > > > Appreciate the response/solution for this. Thanks for advance. > > > > > > > > Below are the tables list and view entity list. > > > > > > > > Inventory Entities > > > > --- > > > > > > > > InventoryItem > > > > InventoryItemDetail > > > > InventoryItemAttribute > > > > InventoryItemStatus > > > > InventoryItemTempRes > > > > InventoryItemType > > > > InventoryItemTypeAttr > > > > InventoryItemVariance > > > > InventoryTransfer > > > > OldOrderItemInventoryRes > > > > PhysicalInventory > > > > InventoryItemLabel > > > > InventoryItemLabelAppl > > > > InventoryItemLabelType > > > > OrderItemShipGrpInvRes > > > > > > > > > > > > View Entity with depenndencies > > > > > > > > > > > > OrderHeaderItemAndInv(Not in use) > > > > MemberEntity > > > > - > > > > OrderHeader > > > > OrderItem > > > > OrderItemShipGrpInvRes > > > > OrderHeaderItemAndInvRoles(Not in use) > > > > MemberEntity > > > > - > > > > OrderHeader > > > > OrderItem > > > > OrderRole > > > > OrderItemShipGrpInvRes > > > > > > > > OrderItemAndShipGrpInvResAndItem - Using to calculation time of > > inventory > > > > MemberEntity > > > > > > > > OrderItem > > > > OrderItemShipGrpInvRes > > > > InventoryItem > > > > > > > > OrderItemAndShipGrpInvResAndItemSum - Packing time using in ofbiz > > > > MemberEntity > > > > > > > > OrderItem > > > > OrderItemShipGrpInvRes > > > > InventoryItem > > > > > > > > OrderItemShipGrpInvResAndItem - Reserve time usage in ofbiz > > > > MemberEntity > > > > > > > > InventoryItem > > > > OrderItemShipGrpInvRes > > > > > > > > ProductInventoryItem - Prouction usage > > > > MemberEntity > > > > > > > > Product > > > > InventoryItem > > > > > > > > ProductInventoryItemAndItemIssuance > > > > MemberEntity > > > > > > > > Product > &
Re: Welcome Paul Foxworthy as a new PMC member
Congratulation Paul!!! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Mar 23, 2018 at 10:57 AM, Sanjeev Gupta wrote: > Heartiest Congratulations Paul !! > > > > - > Rgds > Sanjeev Gupta > -- > Sent from: http://ofbiz.135035.n4.nabble.com/OFBiz-Dev-f165671.html >
Re: Separation database for inventory module
Paul, Thank you for your reply and more insights. I was just trying to tell the group OFBiz capabilities that how quickly entities can be separated among databases if required (not to everyone but to those who are newer). And yes in that case CRUD would be slower and only gains is in reads. If we talk about FKs, I did this in past and in case of mysql it maintain the FKs the referential integrity among different db. I do agree with you on the fact that, this is not good idea to have more database, instead OFBiz supports many ways to retrieve the data way faster rather separating the database. So rather that using the separate database, considering the flat information storage would be better idea IMO for faster read. Best Regards, Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Sun, Mar 25, 2018 at 7:12 AM, Paul Foxworthy wrote: > On 25 March 2018 at 01:58, Rishi Solanki wrote: > > > > Register new group in entityengine.xml with new name and data resource; > > > > > datasource-name="yourDataResourceName"/> > > > > Add new data resource entry in the entityengine.xml like we have many. In > > your case entityengine will contains two entry as localmysql and > > localmysql2 (or any name you prefer). > > Now register all the entities with "your.group.name" in > entity-group.xml. > > > > Refer > datasource-name="localderbytenant"/> and related entries for more > details. > > > > Thanks Rishi. > > If you do define a new group, does that mean: > > - any transaction that modifies entities in two different groups will be > slower as the transaction must be a distributed transaction with two-phase > commit? To put it another way, with good design decisions, entity groups > may well give you faster reads, but writes very likely won't be? > - Foreign key constraints and thus guaranteed referential integrity might > not be possible between groups because not all DBMSes support FKs that > refer to another database? > > Thanks > > Paul Foxworthy > > -- > Coherent Software Australia Pty Ltd > PO Box 2773 > Cheltenham Vic 3192 > Australia > > Phone: +61 3 9585 6788 > Web: http://www.coherentsoftware.com.au/ > Email: i...@coherentsoftware.com.au >
Re: Separation database for inventory module
Jaya, How do you register the group under delegator? If it is under same delegator then it shouldn't be problem ideally. And if it is different then you should try to register all groups under the same delegator then it should work. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Mar 26, 2018 at 12:29 PM, jayachandr...@gmail.com < jayachandr...@gmail.com> wrote: > > > On 2018/03/26 05:00:58, Rishi Solanki wrote: > > Paul, > > > > Thank you for your reply and more insights. I was just trying to tell the > > group OFBiz capabilities that how quickly entities can be separated among > > databases if required (not to everyone but to those who are newer). And > yes > > in that case CRUD would be slower and only gains is in reads. > > > > If we talk about FKs, I did this in past and in case of mysql it maintain > > the FKs the referential integrity among different db. I do agree with you > > on the fact that, this is not good idea to have more database, instead > > OFBiz supports many ways to retrieve the data way faster rather > separating > > the database. > > > > So rather that using the separate database, considering the flat > > information storage would be better idea IMO for faster read. > > > > Best Regards, > > > > > > Rishi Solanki > > Sr Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > www.hotwax.co > > > > On Sun, Mar 25, 2018 at 7:12 AM, Paul Foxworthy > wrote: > > > > > On 25 March 2018 at 01:58, Rishi Solanki > wrote: > > > > > > > > > > Register new group in entityengine.xml with new name and data > resource; > > > > > > > > > > > datasource-name="yourDataResourceName"/> > > > > > > > > Add new data resource entry in the entityengine.xml like we have > many. In > > > > your case entityengine will contains two entry as localmysql and > > > > localmysql2 (or any name you prefer). > > > > Now register all the entities with "your.group.name" in > > > entity-group.xml. > > > > > > > > Refer > > > datasource-name="localderbytenant"/> and related entries for more > > > details. > > > > > > > > > > Thanks Rishi. > > > > > > If you do define a new group, does that mean: > > > > > > - any transaction that modifies entities in two different groups will > be > > > slower as the transaction must be a distributed transaction with > two-phase > > > commit? To put it another way, with good design decisions, entity > groups > > > may well give you faster reads, but writes very likely won't be? > > > - Foreign key constraints and thus guaranteed referential integrity > might > > > not be possible between groups because not all DBMSes support FKs that > > > refer to another database? > > > > > > Thanks > > > > > > Paul Foxworthy > > > > > > -- > > > Coherent Software Australia Pty Ltd > > > PO Box 2773 > > > Cheltenham Vic 3192 > > > Australia > > > > > > Phone: +61 3 9585 6788 > > > Web: http://www.coherentsoftware.com.au/ > > > Email: i...@coherentsoftware.com.au > > > > > > > > Hi Rishi, > > Thanks for your reply on this. > > As i said different entity groups allow us to make different database > with set of entities. And we have done successfully for communication event > related tables. > > As you said about FKs thats absolutely right about referential integrity > among different db in mysql. > > Coming to the CRUD operations with different groups : ofbiz will create DB > datasource for each group and maintain the connection pool and perform the > CRUD operations. While performing ofbiz delegator uses the group related > datasource connection perform the actions and its depend on the DB how > quickly respond. > > With CommunicationEvent related group in our case was performing good and > not have the issue with writing how ever it's totally different process > from order/product info. > > Now issue is when we want read data from view entity(tables are in > differents groups(databases)) then ofbiz only uses primary db connection > and throwing another table not available error. > > > Like communication event to different for inventory we have so many > dependent view entities in ofbiz. > > So looking for solution to maintain this facility data as separtion from > the actual process. > > > Thanks & Regards > Jaya > > > > >
Re: buildbot exception in on ofbizTrunkFramework
Not sure why this failure, my recent commit passes all the tests locally and working fine. I will be surely monitor the upcoming builds and act accordingly. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Mar 27, 2018 at 4:10 PM, wrote: > The Buildbot has detected a build exception on builder ofbizTrunkFramework > while building . Full details are available at: > https://ci.apache.org/builders/ofbizTrunkFramework/builds/171 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: orcus_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkFrameworkCommit' triggered this build > Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1827827 > Blamelist: rishi > > BUILD FAILED: exception shell upload > > Sincerely, > -The Buildbot > > > >
Re: buildbot exception in on ofbizTrunkFramework
Tested again, no test failure. So not reverting the changes and will close the ticket soon. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Mar 27, 2018 at 4:15 PM, Rishi Solanki wrote: > Not sure why this failure, my recent commit passes all the tests locally > and working fine. I will be surely monitor the upcoming builds and act > accordingly. > > Rishi Solanki > Sr Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com > www.hotwax.co > > On Tue, Mar 27, 2018 at 4:10 PM, wrote: > >> The Buildbot has detected a build exception on builder >> ofbizTrunkFramework while building . Full details are available at: >> https://ci.apache.org/builders/ofbizTrunkFramework/builds/171 >> >> Buildbot URL: https://ci.apache.org/ >> >> Buildslave for this Build: orcus_ubuntu >> >> Build Reason: The AnyBranchScheduler scheduler named >> 'onTrunkFrameworkCommit' triggered this build >> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1827827 >> Blamelist: rishi >> >> BUILD FAILED: exception shell upload >> >> Sincerely, >> -The Buildbot >> >> >> >> >
Re: buildbot exception in on ofbizTrunkFramework
Great! Thank you Michael! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Tue, Mar 27, 2018 at 5:54 PM, Michael Brohl wrote: > Hi Rishi, > > no worries, this seems to be a connection problem to jcenter: > > FAILURE: Build failed with an exception. * What went wrong: A problem > occurred configuring root project 'ofbiz'. > Could not resolve all > dependencies for configuration ':classpath'. > Could not resolve > at.bxm.gradleplugins:gradle-svntools-plugin:latest.release. Required by: > project : > Could not resolve > at.bxm.gradleplugins:gradle-svntools-plugin:latest.release. > > Failed to list versions for at.bxm.gradleplugins:gradle-svntools-plugin. > > Unable to load Maven meta-data from https://jcenter.bintray.com/at > /bxm/gradleplugins/gradle-svntools-plugin/maven-metadata.xml. > Could not > GET 'https://jcenter.bintray.com/at/bxm/gradleplugins/gradle-svn > tools-plugin/maven-metadata.xml'. Received status code 502 from server: > Bad Gateway > > I guess it has nothing to do with your commit. > > Regards, > > Michael > > > Am 27.03.18 um 13:41 schrieb Rishi Solanki: > > Tested again, no test failure. So not reverting the changes and will close >> the ticket soon. >> >> Rishi Solanki >> Sr Manager, Enterprise Software Development >> HotWax Systems Pvt. Ltd. >> Direct: +91-9893287847 >> http://www.hotwaxsystems.com >> www.hotwax.co >> >> On Tue, Mar 27, 2018 at 4:15 PM, Rishi Solanki >> wrote: >> >> Not sure why this failure, my recent commit passes all the tests locally >>> and working fine. I will be surely monitor the upcoming builds and act >>> accordingly. >>> >>> Rishi Solanki >>> Sr Manager, Enterprise Software Development >>> HotWax Systems Pvt. Ltd. >>> Direct: +91-9893287847 >>> http://www.hotwaxsystems.com >>> www.hotwax.co >>> >>> On Tue, Mar 27, 2018 at 4:10 PM, wrote: >>> >>> The Buildbot has detected a build exception on builder >>>> ofbizTrunkFramework while building . Full details are available at: >>>> https://ci.apache.org/builders/ofbizTrunkFramework/builds/171 >>>> >>>> Buildbot URL: https://ci.apache.org/ >>>> >>>> Buildslave for this Build: orcus_ubuntu >>>> >>>> Build Reason: The AnyBranchScheduler scheduler named >>>> 'onTrunkFrameworkCommit' triggered this build >>>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1827827 >>>> Blamelist: rishi >>>> >>>> BUILD FAILED: exception shell upload >>>> >>>> Sincerely, >>>> -The Buildbot >>>> >>>> >>>> >>>> >>>> > >
Re: why some fields are set to enable-audit-log true by default?
+1 for removal. +1 to Scott for having an example in the system ... Example entities seems right place as mentioned. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Apr 5, 2018 at 5:38 AM, Scott Gray wrote: > It would be good to leave it on somewhere in the system like the example > entities maybe > > On Wed, 4 Apr 2018, 22:13 Jacques Le Roux, > wrote: > > > Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit : > > > I'm not sure about the field in the entity component though! it > > > might be needed in some unit tests? > > Yes > > > > Jacques > > > > >
