[Impala-ASF-CR] IMPALA-11658: Implement Iceberg manifest caching config for Impala

2023-01-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19423 ) Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala .. Patch Set 2: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-11658: Implement Iceberg manifest caching config for Impala

2023-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19423 ) Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala .. Patch Set 1: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables

2023-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 ) Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables .. Patch Set 6: (14 comments) Thanks

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-01-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set 1:

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set 1:

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 3: (13

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, lipeng...@apache.org, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19419 to look at the new patch set (#3). Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 5: Code-Review+2 Thanks for fixing this! --

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@apache.org, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19419 to look at the new patch set (#2). Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19419 Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. IMPALA-11826: Avoid

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: Code-Review+2 LGTM since the existing

[Impala-ASF-CR] IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables

2023-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 ) Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables .. Patch Set 4: (3 comments) Went

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 5: Code-Review+2 LGTM and nice tests! --

[Impala-ASF-CR] IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash

2023-01-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19410 ) Change subject: IMPALA-11834: Fix Iceberg LOAD DATA hdfsDelete JVM crash .. Patch Set 1: The change LGTM. Is it possible to add

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 2: (5 comments) Left a few nit comments,

[Impala-ASF-CR] IMPALA-11620: Enable setting 'write.format.default'

2023-01-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19221 ) Change subject: IMPALA-11620: Enable setting 'write.format.default' .. Patch Set 3: Code-Review+1 I can upgrade my vote to +2

[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results

2023-01-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 ) Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 5: (6 comments) Left a few comments,

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 5: (1 comment) Did a quick first

[Impala-ASF-CR] IMPALA-11811: Avoid storing unregistered predicate objects in a Map

2023-01-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19390 ) Change subject: IMPALA-11811: Avoid storing unregistered predicate objects in a Map .. Patch Set 1: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19354 to look at the new patch set (#4). Change subject: IMPALA-11787, IMPALA-11516: Cardinality estimate

[Impala-ASF-CR] IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 ) Change subject: IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

[Impala-ASF-CR] IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19354 to look at the new patch set (#2). Change subject: IMPALA-11787, IMPALA-11516: Cardinality estimate

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. Patch Set 8: Code-Review+2 (1 comment) One tiny nit,

[Impala-ASF-CR] IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19354 Change subject: IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498

2022-12-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19331 ) Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498 .. IMPALA-11777: Bump CDP_BUILD_NUMBER to get

[Impala-ASF-CR] IMPALA-11784: Don't call Iceberg's planFiles redundantly during table load

2022-12-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19334 ) Change subject: IMPALA-11784: Don't call Iceberg's planFiles redundantly during table load .. IMPALA-11784: Don't call

[Impala-ASF-CR] IMPALA-11779: Fix crash in TopNNode due to slots in null type

2022-12-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19336 ) Change subject: IMPALA-11779: Fix crash in TopNNode due to slots in null type .. Patch Set 3: Code-Review+2 Thanks for fixing

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. Patch Set 6: (11 comments) Left a couple of comments,

[Impala-ASF-CR] IMPALA-11784: Don't call Iceberg's planFiles redundantly during table load

2022-12-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19334 Change subject: IMPALA-11784: Don't call Iceberg's planFiles redundantly during table load .. IMPALA-11784: Don't call Iceberg's

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ..

[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19331 Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498 .. IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19330 ) Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. Patch Set 2: Code-Review+2 Thanks for fixing this! -- To view,

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#8). Change subject: IMPALA-11780: Wrong FILE__POSITION values for

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#7). Change subject: IMPALA-11780: Wrong FILE__POSITION values for

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#6). Change subject: IMPALA-11780: Wrong FILE__POSITION values for

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#4). Change subject: IMPALA-11780: Wrong FILE__POSITION values for

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#3). Change subject: IMPALA-11780: Wrong FILE__POSITION values for

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#2). Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19328 Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ..

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 13: Code-Review+2 LGTM! -- To

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-12-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 3:

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-12-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 2:

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-12-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 10: (5 comments) Left some minor

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 7: Code-Review+2 LGTM! -- To

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 1: (4

[Impala-ASF-CR] IMPALA-11753: CatalogD OOMkilled due to natively allocated memory

2022-11-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19282 ) Change subject: IMPALA-11753: CatalogD OOMkilled due to natively allocated memory .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-11753: CatalogD OOMkilled due to natively allocated memory

2022-11-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Gergely Fürnstáhl, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19282 to look at the new patch set (#2). Change subject: IMPALA-11753: CatalogD OOMkilled due to natively allocated

[Impala-ASF-CR] IMPALA-11753: CatalogD OOMkilled due to natively allocated memory

2022-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19282 Change subject: IMPALA-11753: CatalogD OOMkilled due to natively allocated memory .. IMPALA-11753: CatalogD OOMkilled due to

[Impala-ASF-CR] IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19270 ) Change subject: IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19270 ) Change subject: IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables .. IMPALA-11739: Skip

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19274 ) Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied .. Patch Set

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-24 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19274 to look at the new patch set (#2). Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime

[Impala-ASF-CR] IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied

2022-11-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19274 Change subject: IMPALA-11740: Incorrect results for partitioned Iceberg V2 tables when runtime filters are applied ..

[Impala-ASF-CR] IMPALA-11734: TestIcebergTable.test compute stats fails in RELEASE builds

2022-11-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19260 ) Change subject: IMPALA-11734: TestIcebergTable.test_compute_stats fails in RELEASE builds .. Patch Set 2: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11676: Prettify asf-site docs

2022-11-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19242 ) Change subject: IMPALA-11676: Prettify asf-site docs .. Patch Set 2: Code-Review+2 Thanks for this work! -- To view, visit

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19145 ) Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement .. Patch Set 3: (7 comments) Thanks for working on this.

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19234 ) Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Qifan Chen, Riza Suminto, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19234 to look at the new patch set (#3). Change subject: IMPALA-11721: Impala query keep being retried over

[Impala-ASF-CR] IMPALA-11676: Prettify asf-site docs

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19242 ) Change subject: IMPALA-11676: Prettify asf-site docs .. Patch Set 1: Code-Review+1 (1 comment) Thanks for working on this! The

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19234 ) Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Qifan Chen, Riza Suminto, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19234 to look at the new patch set (#2). Change subject: IMPALA-11721: Impala query keep being retried over

[Impala-ASF-CR] IMPALA-11721: Impala query keep being retried over frequently updated iceberg table

2022-11-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19234 Change subject: IMPALA-11721: Impala query keep being retried over frequently updated iceberg table .. IMPALA-11721: Impala query

[Impala-ASF-CR] IMPALA-11711: Virtual columns should be skipped in 'FileMetadataUtils::AddIcebergColumns'

2022-11-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19223 ) Change subject: IMPALA-11711: Virtual columns should be skipped in 'FileMetadataUtils::AddIcebergColumns' .. Patch Set 1:

[Impala-ASF-CR] IMPALA-9488: Add metrics for EC reads

2022-11-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19178 ) Change subject: IMPALA-9488: Add metrics for EC reads .. Patch Set 15: Code-Review+2 Thanks for adding these metrics, LGTM! --

[Impala-ASF-CR] IMPALA-11681: Set table stats for the Iceberg table by it's partition stats

2022-11-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19168 ) Change subject: IMPALA-11681: Set table stats for the Iceberg table by it's partition stats .. Patch Set 10: Code-Review+2 --

[Impala-ASF-CR] IMPALA-9488: Add metrics for EC reads

2022-11-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19178 ) Change subject: IMPALA-9488: Add metrics for EC reads .. Patch Set 13: Code-Review+1 (2 comments) Thanks for working on this,

[Impala-ASF-CR] IMPALA-11681: Set table stats for the Iceberg table by it's partition stats

2022-11-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19168 ) Change subject: IMPALA-11681: Set table stats for the Iceberg table by it's partition stats .. Patch Set 8: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11681: Set table stats for the Iceberg table by it's partition stats

2022-11-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19168 ) Change subject: IMPALA-11681: Set table stats for the Iceberg table by it's partition stats .. Patch Set 6: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 9: Thanks everyone for the review! -- To

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 7: (4 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#8). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11680: Fix test krpc datastream sender shuffle

2022-10-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19161 ) Change subject: IMPALA-11680: Fix test_krpc_datastream_sender_shuffle .. Patch Set 2: Code-Review+2 Thanks for fixing this! --

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 6: I struggled reproducing the issue in

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#6). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 5: PS4 fixes the failing tests. PS5 is a

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#5). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#4). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11682: Add tests for minor compacted insert only ACID tables

2022-10-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19164 ) Change subject: IMPALA-11682: Add tests for minor compacted insert only ACID tables .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables

2022-10-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19114 ) Change subject: IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables .. Patch Set 11: Code-Review+2

[Impala-ASF-CR] IMPALA-11608: Fix SHOW TABLE STATS iceberg tbl shows wrong number of files

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 ) Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files .. Patch Set 3: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11608: Fix SHOW TABLE STATS iceberg tbl shows wrong number of files

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 ) Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files .. Patch Set 2: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19114 ) Change subject: IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-11666: Modify the warning message when table statistics may be corrupt

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19148 ) Change subject: IMPALA-11666: Modify the warning message when table statistics may be corrupt .. Patch Set 4: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-11674: Fix timeout detection for TSSLSocket

2022-10-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19157 ) Change subject: IMPALA-11674: Fix timeout detection for TSSLSocket .. Patch Set 4: Code-Review+2 Thanks for fixing this! The

[Impala-ASF-CR] IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables

2022-10-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19114 ) Change subject: IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-11608: Fix SHOW TABLE STATS iceberg tbl shows wrong number of files

2022-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19150 ) Change subject: IMPALA-11608: Fix SHOW TABLE STATS iceberg_tbl shows wrong number of files .. Patch Set 1: (3 comments) Thanks

[Impala-ASF-CR] IMPALA-11581: ALTER TABLE RENAME TO doesn't update transient lastDdlTime

2022-10-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19137 ) Change subject: IMPALA-11581: ALTER TABLE RENAME TO doesn't update transient_lastDdlTime .. Patch Set 3: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 3: (7 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-17 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19043 to look at the new patch set (#3). Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

2022-10-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 ) Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default .. Patch Set 2: (3 comments) Thanks for

<    2   3   4   5   6   7   8   9   10   11   >