Re: Review Request 26069: Introduce ClangFormat to Mesos.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---

(Updated Sept. 29, 2014, 9:10 a.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and 
Timothy Chen.


Changes
---

Removed `.clang-format` from `.gitignore-template`.


Bugs: MESOS-1291
https://issues.apache.org/jira/browse/MESOS-1291


Repository: mesos-git


Description
---

We spend way too much of our time formatting, not to mention the amount of time 
wasted during the review cycle to address style issues. Let’s get ClangFormat 
to help us!

If you don't know what ClangFormat is or how it works, take a look at the 
Chandler Carruth's [live 
demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 33m 
27s.

Further details and analysis are available 
[here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).


Diffs (updated)
-

  .clang-format PRE-CREATION 
  support/clang-format PRE-CREATION 

Diff: https://reviews.apache.org/r/26069/diff/


Testing
---

Refer to the __Sample Diff__ section in the [Google 
Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)


Thanks,

Michael Park

Review Request 26133: Modify configure.ac to fix --with-sasl.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26133/
---

Review request for mesos, Cody Maloney, Dominic Hamon, and Timothy Chen.


Bugs: MESOS-1839
https://issues.apache.org/jira/browse/MESOS-1839


Repository: mesos-git


Description
---

Fixes MESOS-1839.


Diffs
-

  configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 

Diff: https://reviews.apache.org/r/26133/diff/


Testing
---

Built `mesos` with a custom `libsasl2` directory.


Thanks,

Michael Park

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26133/
---

(Updated Sept. 29, 2014, 9:50 a.m.)


Review request for mesos, Cody Maloney, Dominic Hamon, and Timothy Chen.


Changes
---

Need to fix `CPPFLAGS` propagation to actually build `mesos`.


Bugs: MESOS-1839
https://issues.apache.org/jira/browse/MESOS-1839


Repository: mesos-git


Description
---

Fixes MESOS-1839.


Diffs
-

  configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 

Diff: https://reviews.apache.org/r/26133/diff/


Testing (updated)
---

Configured `mesos` with a custom `libsasl2` directory.


Thanks,

Michael Park

Re: Review Request 26069: Introduce ClangFormat to Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54796
---


Patch looks great!

Reviews applied: [26069]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 9:10 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> ---
> 
> (Updated Sept. 29, 2014, 9:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We spend way too much of our time formatting, not to mention the amount of 
> time wasted during the review cycle to address style issues. Let’s get 
> ClangFormat to help us!
> 
> If you don't know what ClangFormat is or how it works, take a look at the 
> Chandler Carruth's [live 
> demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 
> 33m 27s.
> 
> Further details and analysis are available 
> [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
> 
> 
> Diffs
> -
> 
>   .clang-format PRE-CREATION 
>   support/clang-format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26069/diff/
> 
> 
> Testing
> ---
> 
> Refer to the __Sample Diff__ section in the [Google 
> Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26133/#review54800
---


Patch looks great!

Reviews applied: [26133]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 9:50 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26133/
> ---
> 
> (Updated Sept. 29, 2014, 9:50 a.m.)
> 
> 
> Review request for mesos, Cody Maloney, Dominic Hamon, and Timothy Chen.
> 
> 
> Bugs: MESOS-1839
> https://issues.apache.org/jira/browse/MESOS-1839
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes MESOS-1839.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
> 
> Diff: https://reviews.apache.org/r/26133/diff/
> 
> 
> Testing
> ---
> 
> Configured `mesos` with a custom `libsasl2` directory.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2130

[Apache Jenkins Server]

See 


Changes:

[tnachen] Added docker container prefix to docker docs.

--
[...truncated 3279 lines...]
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/reflection.py to 
reflection.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/__init__.py to 
__init__.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/descriptor_pb2.py 
to descriptor_pb2.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/text_format.py to 
text_format.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/api_implementation.py to 
api_implementation.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/enum_type_wrapper.py to 
enum_type_wrapper.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/type_checkers.py to 
type_checkers.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/decoder.py 
to decoder.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/message_listener.py to 
message_listener.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/cpp_message.py to 
cpp_message.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/__init__.py to 
__init__.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/containers.py to 
containers.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/encoder.py 
to encoder.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/wire_format.py to 
wire_format.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/python_message.py to 
python_message.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/descriptor.py to 
descriptor.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/descriptor_database.py to 
descriptor_database.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/message.py to 
message.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/descriptor_pool.py 
to descriptor_pool.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/dependency_links.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/namespace_packages.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/requires.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/top_level.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
zip_safe flag not set; analyzing archive contents...
creating dist
creating 'dist/protobuf-2.5.0-py2.7.egg' and adding 
'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
running bdist_egg
running egg_info
creating src/mesos.egg-info
writing requirements to src/mesos.egg-info/requires.txt
writing src/mesos.egg-info/PKG-INFO
writing namespace_packages to src/mesos.egg-info/namespace_packages.txt
writing top-level names to src/mesos.egg-info/top_level.txt
writing dependency_links to src/mesos.egg-info/dependency_links.txt
writing requirements to src/mesos.egg-info/requires.txt
writing src/mesos.egg-info/PKG-INFO
writing namespace_packages to src/mesos.egg-info/namespace_packages.txt
writing top-level names to src/mesos.egg-info/top_level.txt
writing dependency_links to src/mesos.egg-info/dependency_links.txt
writing manifest file 'src/mesos.egg-info/SOURCES.txt'
reading manifest file 'src/mesos.egg-info/SOURCES.txt'
writing manifest file 'src/mesos.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/mesos
copying src/mesos/__init__.py -> build/lib.linux-x86_64-2.7/mesos
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/egg
creating build/bdist.linux-x86_64/egg/mesos
copying build/lib.linux-x86_64-2.7/mesos/__init__.py -> 
build/bdist.linux-x86_64/egg/mesos
byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/dependency_links.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/namespace_packages.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/requires.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/top_level.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
zip_safe flag not set; analyzing archive contents...
mesos.__init__: module references __path__
creating dist
creating 'dist/mesos-0.21.0-py2.7.egg' 

Re: Regarding adding as a contributor in apache mesos group

[namrata singh]

hello dev , ,
thanks for adding me to the contributors list, can you help me with
https://issues.apache.org/jira/browse/MESOS-1622 , so that i can start
working on moving code from .hpp to .cpp file. Can you please tell me where
can I find the source code so that I can start making changes and try their
validity ?
please give a response to this mail.
waiting for a soon and positive response.

thanks and regards
namrata singh chauhan

On Sun, Sep 28, 2014 at 2:54 PM, namrata singh 
wrote:

> respected sir ,
> I would like to introduce myself as Namrata Singh chauhan, a student of
> IIIT Allahabad, India and a want-to-be a OPW contributor for mesos group ,
> sir I would like to work under your project regarding Getting started page.
> To start with my application process , I would like you to add me to
> contributors list so that I can make some small contributions .
>
> I shall be highly oblige to you.
>
> Thanks and Regards
> Namrata Singh Chauhan
>

Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24535/
---

(Updated Sept. 29, 2014, 12:23 p.m.)


Review request for mesos, Connor Doyle and Tobi Knaup.


Changes
---

Rebased.


Repository: mesos-git


Description
---

See summary.

Note that this hard codes the location of the subversion and Apache Portable 
Runtime (APR) headers.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
bd1dc8df0259a318a9171a9c045a223800e64f47 
  3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/24535/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 24341: Added Java replicated log implementation of State.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24341/
---

(Updated Sept. 29, 2014, 12:23 p.m.)


Review request for mesos, Connor Doyle and Tobi Knaup.


Changes
---

Rebased.


Repository: mesos-git


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
  src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION 
  src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION 

Diff: https://reviews.apache.org/r/24341/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24536/
---

(Updated Sept. 29, 2014, 12:24 p.m.)


Review request for mesos, Connor Doyle and Tobi Knaup.


Changes
---

Rebased.


Repository: mesos-git


Description
---

See summary.

Note that this hard codes the location of the subversion and Apache Portable 
Runtime (APR) headers.


Diffs (updated)
-

  src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
  src/messages/state.proto 59276e55fcbebdb754c20d39b13b402fd11c3dad 
  src/state/log.cpp fd8b28a0b5d14f5ba3e6fde4695f6d09acf9c56a 

Diff: https://reviews.apache.org/r/24536/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed time.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/
---

(Updated Sept. 29, 2014, 12:24 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebased.


Repository: mesos-git


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/include/process/metrics/timer.hpp 
dfd7dd951f0997689dc08fed02a6e621c8d4683f 

Diff: https://reviews.apache.org/r/24537/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 24341: Added Java replicated log implementation of State.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24341/
---

(Updated Sept. 29, 2014, 12:44 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
  src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION 
  src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION 

Diff: https://reviews.apache.org/r/24341/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24535/
---

(Updated Sept. 29, 2014, 12:45 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Repository: mesos-git


Description
---

See summary.

Note that this hard codes the location of the subversion and Apache Portable 
Runtime (APR) headers.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
bd1dc8df0259a318a9171a9c045a223800e64f47 
  3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/24535/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24536/
---

(Updated Sept. 29, 2014, 12:45 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Repository: mesos-git


Description
---

See summary.

Note that this hard codes the location of the subversion and Apache Portable 
Runtime (APR) headers.


Diffs
-

  src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
  src/messages/state.proto 59276e55fcbebdb754c20d39b13b402fd11c3dad 
  src/state/log.cpp fd8b28a0b5d14f5ba3e6fde4695f6d09acf9c56a 

Diff: https://reviews.apache.org/r/24536/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Auto usage in mesos

[Benjamin Hindman]

>
> (Perhaps you're thinking about: auto f(...) -> return_type { ... })
>

Yes, I was referring to the use of auto as the return type in the function
declaration, not (yet) for automatic deduction. Thanks for the
clarification.

Re: Review Request 26069: Introduce ClangFormat to Mesos.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54806
---


How much fine-tuning can we apply here? Between this and cpplint.py will we 
"cover" out style completely? Looking forward to helping make folks more 
productive but don't want to frustrate people that use this and then still get 
comments on their reviews about needing to make changes to be consistent with 
our style. :-/


support/clang-format


This is actually not "good", since the '{' is not on a newline. I guess 
this is just for checking the access modifier offset, but it could be 
counter-intuitive for people.



support/clang-format


We haven't had a hard rule about this, so if someone manually aligns them 
where that might make sense will ClangFormat un-align them?



support/clang-format


Can ClangFormat differentiate when to do:

allocator->resourcesRecovered(
frameworkId,
slaveId,
resources,
filters);

instead of:

allocator->resourcesRecovered(frameworkId,
  slaveId,
  resources,
  filters);



support/clang-format


Can we fine-tune this? We break for function, class, struct, etc, but not 
for namespaces.


- Benjamin Hindman


On Sept. 29, 2014, 9:10 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> ---
> 
> (Updated Sept. 29, 2014, 9:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We spend way too much of our time formatting, not to mention the amount of 
> time wasted during the review cycle to address style issues. Let’s get 
> ClangFormat to help us!
> 
> If you don't know what ClangFormat is or how it works, take a look at the 
> Chandler Carruth's [live 
> demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 
> 33m 27s.
> 
> Further details and analysis are available 
> [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
> 
> 
> Diffs
> -
> 
>   .clang-format PRE-CREATION 
>   support/clang-format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26069/diff/
> 
> 
> Testing
> ---
> 
> Refer to the __Sample Diff__ section in the [Google 
> Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 25848: Introducing mesos modules.

[Timothy St. Clair]

> On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote:
> > src/module/manager.cpp, line 173
> > 
> >
> > You could probably stick the json parsing into a separate sub-class.  
> > I'm all for breaking out a small JIRA tree from the comments.
> 
> Niklas Nielsen wrote:
> Is it so we can discuss the format further or because we should address 
> this in different patches?
> 
> Kapil Arya wrote:
> I have created a new private function that does all the parsing. 
> Hopefully, that is more readable now.

+1.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54425
---


On Sept. 26, 2014, 11:26 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 26, 2014, 11:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
>   include/mesos/module.hpp.in PRE-CREATION 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/examples/test_module_impl2.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25848: Introducing mesos modules.

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54811
---

Ship it!


I still think there will be revisions, but I'm good for phase 1.  Thanks for 
all the work guys! 

We can open new JIRA's where needed.

- Timothy St. Clair


On Sept. 26, 2014, 11:26 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 26, 2014, 11:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
>   include/mesos/module.hpp.in PRE-CREATION 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/examples/test_module_impl2.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 24341: Added Java replicated log implementation of State.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24341/#review54813
---


Patch looks great!

Reviews applied: [24341]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 12:44 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24341/
> ---
> 
> (Updated Sept. 29, 2014, 12:44 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION 
>   src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24341/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed time.

[Dominic Hamon]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24537/#review54821
---


Could you add to the tests to cover this change in API?

- Dominic Hamon


On Sept. 29, 2014, 5:24 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24537/
> ---
> 
> (Updated Sept. 29, 2014, 5:24 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/metrics/timer.hpp 
> dfd7dd951f0997689dc08fed02a6e621c8d4683f 
> 
> Diff: https://reviews.apache.org/r/24537/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 26101: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

[Dominic Hamon]

> On Sept. 26, 2014, 6:18 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [26100, 26101]
> > 
> > Failed command: git apply --index 26101.patch
> > 
> > Error:
> >  error: patch failed: 3rdparty/libprocess/src/process.cpp:1946
> > error: 3rdparty/libprocess/src/process.cpp: patch does not apply
> > error: patch failed: 3rdparty/libprocess/src/subprocess.cpp:94
> > error: 3rdparty/libprocess/src/subprocess.cpp: patch does not apply
> > error: patch failed: src/log/leveldb.cpp:54
> > error: src/log/leveldb.cpp: patch does not apply
> > error: patch failed: src/log/network.hpp:303
> > error: src/log/network.hpp: patch does not apply
> > error: patch failed: src/slave/containerizer/mesos/launch.cpp:244
> > error: src/slave/containerizer/mesos/launch.cpp: patch does not apply
> > error: patch failed: src/tests/routing_tests.cpp:287
> > error: src/tests/routing_tests.cpp: patch does not apply
> > error: patch failed: src/zookeeper/zookeeper.cpp:686
> > error: src/zookeeper/zookeeper.cpp: patch does not apply

looks like this needs rebasing to 26100


- Dominic


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26101/#review54757
---


On Sept. 26, 2014, 2:40 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26101/
> ---
> 
> (Updated Sept. 26, 2014, 2:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1744
> https://issues.apache.org/jira/browse/MESOS-1744
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Use compiler intrinsics for unreachable, exit, and abort
> Makes the functions not need to pretend to return something while
> still silencing the compiler warnings.
> 
> Replaces 25192
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> e46e6b136c594cad5fa00fb7a5ff268e352753ce 
>   3rdparty/libprocess/src/subprocess.cpp 
> 5b92200050df071190ab2d36abff050a7a077442 
>   src/log/leveldb.cpp 2967a1f7c6ff35c1280299c3d73aaa951ab89273 
>   src/log/network.hpp 7d6b59292c2f5cf9cb99045fcd0960cab67c7e51 
>   src/slave/containerizer/mesos/launch.cpp 
> 981938149060fb16467df4c65d729f76583b8c0f 
>   src/tests/routing_tests.cpp 35bdf8f69b9ffebc1cae2b8f42c5fea169f23a97 
>   src/zookeeper/zookeeper.cpp 72c9fc36648ea225876c06cd7559cb0ffc95dfe7 
> 
> Diff: https://reviews.apache.org/r/26101/diff/
> 
> 
> Testing
> ---
> 
> make distcheck of this and the two associated patches using gcc
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/#review54824
---

Ship it!


Looks great! A few style nits. Please update the review and I'll commit this.


src/slave/containerizer/isolators/network/port_mapping.hpp


Reorder s and containerId



src/slave/containerizer/isolators/network/port_mapping.hpp


Adjust the comment. s/usage/statistics/



src/slave/containerizer/isolators/network/port_mapping.cpp


Remove extra space before %.



src/slave/containerizer/isolators/network/port_mapping.cpp


Add a NOTE:



src/slave/containerizer/isolators/network/port_mapping.cpp


Add a blank line above.



src/slave/containerizer/isolators/network/port_mapping.cpp


Add a TODO here.



src/slave/containerizer/isolators/network/port_mapping.cpp


This fits in one line?


- Jie Yu


On Sept. 27, 2014, 12:34 a.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26090/
> ---
> 
> (Updated Sept. 27, 2014, 12:34 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: mesos-1808
> https://issues.apache.org/jira/browse/mesos-1808
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto be45494 
>   src/slave/containerizer/isolators/network/helper.cpp 6cbcb33 
>   src/slave/containerizer/isolators/network/port_mapping.hpp b624c4d 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00 
> 
> Diff: https://reviews.apache.org/r/26090/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 26101: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

[Cody Maloney]

> On Sept. 27, 2014, 1:18 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [26100, 26101]
> > 
> > Failed command: git apply --index 26101.patch
> > 
> > Error:
> >  error: patch failed: 3rdparty/libprocess/src/process.cpp:1946
> > error: 3rdparty/libprocess/src/process.cpp: patch does not apply
> > error: patch failed: 3rdparty/libprocess/src/subprocess.cpp:94
> > error: 3rdparty/libprocess/src/subprocess.cpp: patch does not apply
> > error: patch failed: src/log/leveldb.cpp:54
> > error: src/log/leveldb.cpp: patch does not apply
> > error: patch failed: src/log/network.hpp:303
> > error: src/log/network.hpp: patch does not apply
> > error: patch failed: src/slave/containerizer/mesos/launch.cpp:244
> > error: src/slave/containerizer/mesos/launch.cpp: patch does not apply
> > error: patch failed: src/tests/routing_tests.cpp:287
> > error: src/tests/routing_tests.cpp: patch does not apply
> > error: patch failed: src/zookeeper/zookeeper.cpp:686
> > error: src/zookeeper/zookeeper.cpp: patch does not apply
> 
> Dominic Hamon wrote:
> looks like this needs rebasing to 26100

The patches shouldn't overlap at all. Looks like I accidentally got more files 
than I meant into the libprocess and stout patches. Cleaning up, updating the 
patches.


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26101/#review54757
---


On Sept. 26, 2014, 9:40 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26101/
> ---
> 
> (Updated Sept. 26, 2014, 9:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1744
> https://issues.apache.org/jira/browse/MESOS-1744
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Use compiler intrinsics for unreachable, exit, and abort
> Makes the functions not need to pretend to return something while
> still silencing the compiler warnings.
> 
> Replaces 25192
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> e46e6b136c594cad5fa00fb7a5ff268e352753ce 
>   3rdparty/libprocess/src/subprocess.cpp 
> 5b92200050df071190ab2d36abff050a7a077442 
>   src/log/leveldb.cpp 2967a1f7c6ff35c1280299c3d73aaa951ab89273 
>   src/log/network.hpp 7d6b59292c2f5cf9cb99045fcd0960cab67c7e51 
>   src/slave/containerizer/mesos/launch.cpp 
> 981938149060fb16467df4c65d729f76583b8c0f 
>   src/tests/routing_tests.cpp 35bdf8f69b9ffebc1cae2b8f42c5fea169f23a97 
>   src/zookeeper/zookeeper.cpp 72c9fc36648ea225876c06cd7559cb0ffc95dfe7 
> 
> Diff: https://reviews.apache.org/r/26101/diff/
> 
> 
> Testing
> ---
> 
> make distcheck of this and the two associated patches using gcc
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26100: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26100/
---

(Updated Sept. 29, 2014, 5:22 p.m.)


Review request for mesos, Ben Mahler and Dominic Hamon.


Changes
---

Reduce to just the stout changes, as was intended.


Bugs: MESOS-1744
https://issues.apache.org/jira/browse/MESOS-1744


Repository: mesos-git


Description
---

Use compiler intrinsics for unreachable, exit, and abort
Makes the functions not need to pretend to return something while
still silencing the compiler warnings.

Replaces 25191 (I originally authored the patch, but Patrick was managing it 
for various reasons). Incorporates the fix suggested by Ben Mahler. Fixes 
Dominic's build issue.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
f20feeac11f62785cd00511e1d4fc53baf752123 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
aaccbb4dbe8e2e771ed2198ab2232bbd5361f319 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
23628a4686203e3edd0d8bb6e57060cdf4aec745 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
5607896d489f4c5eced9c0aa77b190a955644580 
  3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 
3568886ba983fad85e74d2a3ade0178997fcb55c 

Diff: https://reviews.apache.org/r/26100/diff/


Testing
---

make distcheck of this and the two associated patches using gcc


Thanks,

Cody Maloney

Re: Review Request 26101: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26101/
---

(Updated Sept. 29, 2014, 5:23 p.m.)


Review request for mesos, Ben Mahler and Dominic Hamon.


Changes
---

Reduce to just the libprocess changes, as was intended.


Bugs: MESOS-1744
https://issues.apache.org/jira/browse/MESOS-1744


Repository: mesos-git


Description
---

Use compiler intrinsics for unreachable, exit, and abort
Makes the functions not need to pretend to return something while
still silencing the compiler warnings.

Replaces 25192


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp e46e6b136c594cad5fa00fb7a5ff268e352753ce 
  3rdparty/libprocess/src/subprocess.cpp 
5b92200050df071190ab2d36abff050a7a077442 

Diff: https://reviews.apache.org/r/26101/diff/


Testing
---

make distcheck of this and the two associated patches using gcc


Thanks,

Cody Maloney

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26090/#review54828
---


Can you add a test that (at least) confirms the RTT values are non-zero?


include/mesos/mesos.proto


Explain (expand) what RTT is, where it's sourced from and what it means?



src/slave/containerizer/isolators/network/port_mapping.cpp


All this output to cerr just gets redirected to /dev/null by the caller - 
perhaps revisit that decision?



src/slave/containerizer/isolators/network/port_mapping.cpp


Why the change in log message, it does't make sense now? e.g., "The 
launcher for updating container abc123 1"



src/slave/containerizer/isolators/network/port_mapping.cpp


You modify the argument but also return the modified version. Make this 
const, then create a copy in the function that you modify and return?



src/slave/containerizer/isolators/network/port_mapping.cpp


"launch the launcher" is confusing. Can you re-word to something like 
"Failed to run command to obtain..."



src/slave/containerizer/isolators/network/port_mapping.cpp


Ditto, using launcher is confusing.



src/slave/containerizer/isolators/network/port_mapping.cpp


ditto



src/slave/containerizer/isolators/network/port_mapping.cpp


ditto


- Ian Downes


On Sept. 26, 2014, 5:34 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26090/
> ---
> 
> (Updated Sept. 26, 2014, 5:34 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: mesos-1808
> https://issues.apache.org/jira/browse/mesos-1808
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto be45494 
>   src/slave/containerizer/isolators/network/helper.cpp 6cbcb33 
>   src/slave/containerizer/isolators/network/port_mapping.hpp b624c4d 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00 
> 
> Diff: https://reviews.apache.org/r/26090/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 26100: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

[Cody Maloney]

> On Sept. 26, 2014, 9:54 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp, line 33
> > 
> >
> > these should be ok not inline as they're member methods.

Fixed in the latest patch


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26100/#review54740
---


On Sept. 29, 2014, 5:22 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26100/
> ---
> 
> (Updated Sept. 29, 2014, 5:22 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Dominic Hamon.
> 
> 
> Bugs: MESOS-1744
> https://issues.apache.org/jira/browse/MESOS-1744
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Use compiler intrinsics for unreachable, exit, and abort
> Makes the functions not need to pretend to return something while
> still silencing the compiler warnings.
> 
> Replaces 25191 (I originally authored the patch, but Patrick was managing it 
> for various reasons). Incorporates the fix suggested by Ben Mahler. Fixes 
> Dominic's build issue.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
> f20feeac11f62785cd00511e1d4fc53baf752123 
>   3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
> aaccbb4dbe8e2e771ed2198ab2232bbd5361f319 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 23628a4686203e3edd0d8bb6e57060cdf4aec745 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
> 5607896d489f4c5eced9c0aa77b190a955644580 
>   3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 
> 3568886ba983fad85e74d2a3ade0178997fcb55c 
> 
> Diff: https://reviews.apache.org/r/26100/diff/
> 
> 
> Testing
> ---
> 
> make distcheck of this and the two associated patches using gcc
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 25818: Switch path::join() to be variadic

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---

(Updated Sept. 29, 2014, 6:01 p.m.)


Review request for mesos, Adam B and Dominic Hamon.


Changes
---

Address Adam's comments


Repository: mesos-git


Description
---

Switch path::join() to be variadic.

Updated now that 25789 has landed


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d 
  3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0b 
  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a 
  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 14567f1 
  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/25818/diff/


Testing
---

make check


Thanks,

Cody Maloney

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2397

[Benjamin Mahler]

Looks like a stall of the disk FWICT, I will bump the store timeout up from
5 seconds to 10 seconds to match the rest of our tests.

On Sun, Sep 28, 2014 at 1:05 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> See <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2397/changes
> >
>
> Changes:
>
> [dlester] Adds The Factory to PoweredByMesos documentation.
>
> --
> [...truncated 61072 lines...]
> I0928 20:04:37.307884 26518 log.cpp:656] Attempting to start the writer
> I0928 20:04:37.308300 26527 replica.cpp:474] Replica received implicit
> promise request with proposal 1
> I0928 20:04:37.308449 26527 leveldb.cpp:306] Persisting metadata (8 bytes)
> to leveldb took 127841ns
> I0928 20:04:37.308461 26527 replica.cpp:342] Persisted promised to 1
> I0928 20:04:37.308681 26522 coordinator.cpp:230] Coordinator attemping to
> fill missing position
> I0928 20:04:37.309213 26528 replica.cpp:375] Replica received explicit
> promise request for position 0 with proposal 2
> I0928 20:04:37.309626 26528 leveldb.cpp:343] Persisting action (8 bytes)
> to leveldb took 394822ns
> I0928 20:04:37.309639 26528 replica.cpp:676] Persisted action at 0
> I0928 20:04:37.309979 26518 replica.cpp:508] Replica received write
> request for position 0
> I0928 20:04:37.310006 26518 leveldb.cpp:438] Reading position from leveldb
> took 10121ns
> I0928 20:04:37.310104 26518 leveldb.cpp:343] Persisting action (14 bytes)
> to leveldb took 82821ns
> I0928 20:04:37.310118 26518 replica.cpp:676] Persisted action at 0
> I0928 20:04:37.310312 26527 replica.cpp:655] Replica received learned
> notice for position 0
> I0928 20:04:37.310470 26527 leveldb.cpp:343] Persisting action (16 bytes)
> to leveldb took 142143ns
> I0928 20:04:37.310483 26527 replica.cpp:676] Persisted action at 0
> I0928 20:04:37.310490 26527 replica.cpp:661] Replica learned NOP action at
> position 0
> I0928 20:04:37.310662 26525 log.cpp:672] Writer started with ending
> position 0
> I0928 20:04:37.310973 26523 leveldb.cpp:438] Reading position from leveldb
> took 9803ns
> I0928 20:04:37.311913 26522 registrar.cpp:346] Successfully fetched the
> registry (0B)
> I0928 20:04:37.311939 26522 registrar.cpp:422] Attempting to update the
> 'registry'
> I0928 20:04:37.312876 26526 log.cpp:680] Attempting to append 140 bytes to
> the log
> I0928 20:04:37.312926 26527 coordinator.cpp:340] Coordinator attempting to
> write APPEND action at position 1
> I0928 20:04:37.313186 26526 replica.cpp:508] Replica received write
> request for position 1
> I0928 20:04:37.313585 26526 leveldb.cpp:343] Persisting action (159 bytes)
> to leveldb took 379673ns
> I0928 20:04:37.313598 26526 replica.cpp:676] Persisted action at 1
> I0928 20:04:37.313812 26524 replica.cpp:655] Replica received learned
> notice for position 1
> I0928 20:04:37.313971 26524 leveldb.cpp:343] Persisting action (161 bytes)
> to leveldb took 142290ns
> I0928 20:04:37.313983 26524 replica.cpp:676] Persisted action at 1
> I0928 20:04:37.313990 26524 replica.cpp:661] Replica learned APPEND action
> at position 1
> I0928 20:04:37.314231 26527 registrar.cpp:479] Successfully updated
> 'registry'
> I0928 20:04:37.314276 26527 registrar.cpp:372] Successfully recovered
> registrar
> I0928 20:04:37.314303 26529 log.cpp:699] Attempting to truncate the log to
> 1
> I0928 20:04:37.314398 26522 coordinator.cpp:340] Coordinator attempting to
> write TRUNCATE action at position 2
> I0928 20:04:37.314395 26521 master.cpp:1099] Recovered 0 slaves from the
> Registry (102B) ; allowing 10mins for slaves to re-register
> I0928 20:04:37.314690 26524 replica.cpp:508] Replica received write
> request for position 2
> I0928 20:04:37.314857 26524 leveldb.cpp:343] Persisting action (16 bytes)
> to leveldb took 150726ns
> I0928 20:04:37.314868 26524 replica.cpp:676] Persisted action at 2
> I0928 20:04:37.315090 26519 replica.cpp:655] Replica received learned
> notice for position 2
> I0928 20:04:37.315249 26519 leveldb.cpp:343] Persisting action (18 bytes)
> to leveldb took 142403ns
> I0928 20:04:37.315273 26519 leveldb.cpp:401] Deleting ~1 keys from leveldb
> took 10483ns
> I0928 20:04:37.315280 26519 replica.cpp:676] Persisted action at 2
> I0928 20:04:37.315287 26519 replica.cpp:661] Replica learned TRUNCATE
> action at position 2
> I0928 20:04:37.326342 26516 slave.cpp:169] Slave started on 211)@
> 67.195.81.186:55213
> I0928 20:04:37.326365 26516 credentials.hpp:84] Loading credential for
> authentication from
> '/tmp/MasterAuthorizationTest_SlaveDisconnected_uJ9uO5/credential'
> I0928 20:04:37.326436 26516 slave.cpp:276] Slave using credential for:
> test-principal
> I0928 20:04:37.326509 26516 slave.cpp:289] Slave resources: cpus(*):2;
> mem(*):1024; disk(*):1024; ports(*):[31000-32000]
> I0928 20:04:37.326560 26516 slave.cpp:317] Slave hostname:
> penates.apache.org
> I0928 20:04:37.326567 26516 slave.cpp:318] Slave checkpoint: t

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

[Ben Mahler]

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
> > docs/mesos-c++-style-guide.md, lines 96-99
> > 
> >
> > Why would the iterator be called `containerizer`?
> > 
> > s/containerizer/iterator/ ?
> 
> Dominic Hamon wrote:
> -1
> 
> naming a variable after a type is never a good idea. in this case, you're 
> getting a containerizer (iterator) from the container of containerizers so 
> the name 'containerizer' makes sense.
> 
> Ben Mahler wrote:
> Sounds confusing.
> 
> Ben Mahler wrote:
> If 'auto' was not used here, would we call this 'containerizer'? In a 
> loop, this would typically be called `iterator`, no?
> 
> ```
> for (auto iterator = containerizers.begin(); iterator != 
> containerizers.end(); ++iterator) {
>   Containerizer* containerizer = *iterator;
> }
> ```
> 
> Why do something differently when auto is used?
> 
> If the iterator was being "de-referenced" then `containerizer` makes 
> sense:
> 
> ```
>   Containerizer* containerizer = *(containerizers.begin());
> ```
> 
> Alexander Rukletsov wrote:
> I agree with Dominic: it's more important what is stored in the container 
> and not how we access it (iterator, reference, etc.). Actually, the example 
> is taken from our code base, see `src/slave/containerizer/composing.cpp:394`
> 
> Ben Mahler wrote:
> Ok, since this example uses `containerizer` as a reference to the 
> `Containerizer*`, as opposed to an iterator, your points make sense. But in 
> general I don't think this is a pattern we'll want in our code because of the 
> masquerading types now hidden with 'auto'.
> 
> Iterators are not as simple as a pointer or reference. What I find 
> unfortunate is that we wouldn't apply the same naming scheme as soon as we 
> change the container type, which affects the iterator type:
> 
> ```
> map containerizers;
> auto containerizer = containerizers.begin(); // Wouldn't do this.
> ```
> 
> How about a different example here with .find() as opposed to .begin()? 
> Take a look at cache.hpp as an example:
> 
> ```
>   // Evict the least-recently used element from the cache.
>   void evict()
>   {
> const typename map::iterator& i = values.find(keys.front());
> CHECK(i != values.end());
> values.erase(i);
> keys.pop_front();
>   }
> ```
> 
> Here we definitely care about the iterator, as opposed to the value, and 
> would name 'i' accordingly.
> 
> Alexander Rukletsov wrote:
> I see. So you would like to be able to 1) distinguish between iterator 
> type and element type, and 2) be able to reason about the iterator type 
> somehow (possible from the variable name). I think, that makes sense.
> 
> Using `auto` hides the actual type, and this can be both good and bad. We 
> should use it in places where we don't care (or shouldn't care) about the 
> actual type. Do we care about the container and iterator types when 
> enumerating all elements? I tend to say no, but you are absolutely right that 
> iterators of different containers are used in different ways.
> 
> Regarding naming, we can choose something general, like "element" or 
> "item". It will be clear from the context, what this element is about and 
> implies neither value nor iterator and can be used for both.
> 
> Benjamin Hindman wrote:
> To the best of my knowledge we've (or at least I've) used two different 
> naming schemes for working with iterators in the code base:
> 
> (1) When doing a 'find' we've named the variable the "thing" we're trying 
> to actually use, for example:
> 
> auto containerizer = containerizers.find("docker");
> 
> (2) When doing a 'begin' we've named the variable something that makes it 
> clear it's an iterator, for example:
> 
> auto it = containerizers.begin();
> auto iterator = containerizers.begin();
> 
> Why? Because for (1) it's highly likely that you'll want to do things 
> like:
> 
> containerizer->launch(...);
> containerizers.erase(containerizer);
> 
> But not:
> 
> ++containerizer;
> 
> Which can be harder to read, especially when initially declared using 
> 'auto'. Whereas for (2) it's highly likely that we _will_ want to do:
> 
> ++iterator
> 
> Which when named 'iterator' is easy to understand what you're doing.
> 
> That's my suggestion for suggesting a naming scheme for this guide.
> 
> Alexander Rukletsov wrote:
> Makes sense, especially `++containerizer`. To make the example less 
> confusing, I change it to `.find()`.
> 
> Ben Mahler wrote:
> Great, Alexander and I chatted off thread as well to go with an example 
> of .find().
> 
> Ben: If your example (1) is calling map::find (vector::find does not 
> exist), then you're actuall

Review Request 26141: Increased the store timeout for the Registrar tests.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26141/
---

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
---

Increased the store timeout for the Registrar tests.


Diffs
-

  src/tests/registrar_tests.cpp cd83bf09313db1ee1825c30bb5e07e386622e668 

Diff: https://reviews.apache.org/r/26141/diff/


Testing
---

make check


Thanks,

Ben Mahler

Re: Review Request 26141: Increased the store timeout for the Registrar tests.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26141/#review54843
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 29, 2014, 6:30 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26141/
> ---
> 
> (Updated Sept. 29, 2014, 6:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Increased the store timeout for the Registrar tests.
> 
> 
> Diffs
> -
> 
>   src/tests/registrar_tests.cpp cd83bf09313db1ee1825c30bb5e07e386622e668 
> 
> Diff: https://reviews.apache.org/r/26141/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2397

[Benjamin Mahler]

https://reviews.apache.org/r/26141/

On Mon, Sep 29, 2014 at 11:14 AM, Benjamin Mahler  wrote:

> Looks like a stall of the disk FWICT, I will bump the store timeout up
> from 5 seconds to 10 seconds to match the rest of our tests.
>
> On Sun, Sep 28, 2014 at 1:05 PM, Apache Jenkins Server <
> jenk...@builds.apache.org> wrote:
>
>> See <
>> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2397/changes
>> >
>>
>> Changes:
>>
>> [dlester] Adds The Factory to PoweredByMesos documentation.
>>
>> --
>> [...truncated 61072 lines...]
>> I0928 20:04:37.307884 26518 log.cpp:656] Attempting to start the writer
>> I0928 20:04:37.308300 26527 replica.cpp:474] Replica received implicit
>> promise request with proposal 1
>> I0928 20:04:37.308449 26527 leveldb.cpp:306] Persisting metadata (8
>> bytes) to leveldb took 127841ns
>> I0928 20:04:37.308461 26527 replica.cpp:342] Persisted promised to 1
>> I0928 20:04:37.308681 26522 coordinator.cpp:230] Coordinator attemping to
>> fill missing position
>> I0928 20:04:37.309213 26528 replica.cpp:375] Replica received explicit
>> promise request for position 0 with proposal 2
>> I0928 20:04:37.309626 26528 leveldb.cpp:343] Persisting action (8 bytes)
>> to leveldb took 394822ns
>> I0928 20:04:37.309639 26528 replica.cpp:676] Persisted action at 0
>> I0928 20:04:37.309979 26518 replica.cpp:508] Replica received write
>> request for position 0
>> I0928 20:04:37.310006 26518 leveldb.cpp:438] Reading position from
>> leveldb took 10121ns
>> I0928 20:04:37.310104 26518 leveldb.cpp:343] Persisting action (14 bytes)
>> to leveldb took 82821ns
>> I0928 20:04:37.310118 26518 replica.cpp:676] Persisted action at 0
>> I0928 20:04:37.310312 26527 replica.cpp:655] Replica received learned
>> notice for position 0
>> I0928 20:04:37.310470 26527 leveldb.cpp:343] Persisting action (16 bytes)
>> to leveldb took 142143ns
>> I0928 20:04:37.310483 26527 replica.cpp:676] Persisted action at 0
>> I0928 20:04:37.310490 26527 replica.cpp:661] Replica learned NOP action
>> at position 0
>> I0928 20:04:37.310662 26525 log.cpp:672] Writer started with ending
>> position 0
>> I0928 20:04:37.310973 26523 leveldb.cpp:438] Reading position from
>> leveldb took 9803ns
>> I0928 20:04:37.311913 26522 registrar.cpp:346] Successfully fetched the
>> registry (0B)
>> I0928 20:04:37.311939 26522 registrar.cpp:422] Attempting to update the
>> 'registry'
>> I0928 20:04:37.312876 26526 log.cpp:680] Attempting to append 140 bytes
>> to the log
>> I0928 20:04:37.312926 26527 coordinator.cpp:340] Coordinator attempting
>> to write APPEND action at position 1
>> I0928 20:04:37.313186 26526 replica.cpp:508] Replica received write
>> request for position 1
>> I0928 20:04:37.313585 26526 leveldb.cpp:343] Persisting action (159
>> bytes) to leveldb took 379673ns
>> I0928 20:04:37.313598 26526 replica.cpp:676] Persisted action at 1
>> I0928 20:04:37.313812 26524 replica.cpp:655] Replica received learned
>> notice for position 1
>> I0928 20:04:37.313971 26524 leveldb.cpp:343] Persisting action (161
>> bytes) to leveldb took 142290ns
>> I0928 20:04:37.313983 26524 replica.cpp:676] Persisted action at 1
>> I0928 20:04:37.313990 26524 replica.cpp:661] Replica learned APPEND
>> action at position 1
>> I0928 20:04:37.314231 26527 registrar.cpp:479] Successfully updated
>> 'registry'
>> I0928 20:04:37.314276 26527 registrar.cpp:372] Successfully recovered
>> registrar
>> I0928 20:04:37.314303 26529 log.cpp:699] Attempting to truncate the log
>> to 1
>> I0928 20:04:37.314398 26522 coordinator.cpp:340] Coordinator attempting
>> to write TRUNCATE action at position 2
>> I0928 20:04:37.314395 26521 master.cpp:1099] Recovered 0 slaves from the
>> Registry (102B) ; allowing 10mins for slaves to re-register
>> I0928 20:04:37.314690 26524 replica.cpp:508] Replica received write
>> request for position 2
>> I0928 20:04:37.314857 26524 leveldb.cpp:343] Persisting action (16 bytes)
>> to leveldb took 150726ns
>> I0928 20:04:37.314868 26524 replica.cpp:676] Persisted action at 2
>> I0928 20:04:37.315090 26519 replica.cpp:655] Replica received learned
>> notice for position 2
>> I0928 20:04:37.315249 26519 leveldb.cpp:343] Persisting action (18 bytes)
>> to leveldb took 142403ns
>> I0928 20:04:37.315273 26519 leveldb.cpp:401] Deleting ~1 keys from
>> leveldb took 10483ns
>> I0928 20:04:37.315280 26519 replica.cpp:676] Persisted action at 2
>> I0928 20:04:37.315287 26519 replica.cpp:661] Replica learned TRUNCATE
>> action at position 2
>> I0928 20:04:37.326342 26516 slave.cpp:169] Slave started on 211)@
>> 67.195.81.186:55213
>> I0928 20:04:37.326365 26516 credentials.hpp:84] Loading credential for
>> authentication from
>> '/tmp/MasterAuthorizationTest_SlaveDisconnected_uJ9uO5/credential'
>> I0928 20:04:37.326436 26516 slave.cpp:276] Slave using credential for:
>> test-principal
>> I0928 20:04:37.326509 26516 slave.cpp:289] Slave resources: cpus(*):2;

Re: Review Request 26069: Introduce ClangFormat to Mesos.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---

(Updated Sept. 29, 2014, 6:33 p.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and 
Timothy Chen.


Changes
---

Fixed `Good`/`Bad` code samples.


Bugs: MESOS-1291
https://issues.apache.org/jira/browse/MESOS-1291


Repository: mesos-git


Description
---

We spend way too much of our time formatting, not to mention the amount of time 
wasted during the review cycle to address style issues. Let’s get ClangFormat 
to help us!

If you don't know what ClangFormat is or how it works, take a look at the 
Chandler Carruth's [live 
demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 33m 
27s.

Further details and analysis are available 
[here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).


Diffs (updated)
-

  .clang-format PRE-CREATION 
  support/clang-format PRE-CREATION 

Diff: https://reviews.apache.org/r/26069/diff/


Testing
---

Refer to the __Sample Diff__ section in the [Google 
Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)


Thanks,

Michael Park

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

[Alexander Rukletsov]

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
> > docs/mesos-c++-style-guide.md, lines 96-99
> > 
> >
> > Why would the iterator be called `containerizer`?
> > 
> > s/containerizer/iterator/ ?
> 
> Dominic Hamon wrote:
> -1
> 
> naming a variable after a type is never a good idea. in this case, you're 
> getting a containerizer (iterator) from the container of containerizers so 
> the name 'containerizer' makes sense.
> 
> Ben Mahler wrote:
> Sounds confusing.
> 
> Ben Mahler wrote:
> If 'auto' was not used here, would we call this 'containerizer'? In a 
> loop, this would typically be called `iterator`, no?
> 
> ```
> for (auto iterator = containerizers.begin(); iterator != 
> containerizers.end(); ++iterator) {
>   Containerizer* containerizer = *iterator;
> }
> ```
> 
> Why do something differently when auto is used?
> 
> If the iterator was being "de-referenced" then `containerizer` makes 
> sense:
> 
> ```
>   Containerizer* containerizer = *(containerizers.begin());
> ```
> 
> Alexander Rukletsov wrote:
> I agree with Dominic: it's more important what is stored in the container 
> and not how we access it (iterator, reference, etc.). Actually, the example 
> is taken from our code base, see `src/slave/containerizer/composing.cpp:394`
> 
> Ben Mahler wrote:
> Ok, since this example uses `containerizer` as a reference to the 
> `Containerizer*`, as opposed to an iterator, your points make sense. But in 
> general I don't think this is a pattern we'll want in our code because of the 
> masquerading types now hidden with 'auto'.
> 
> Iterators are not as simple as a pointer or reference. What I find 
> unfortunate is that we wouldn't apply the same naming scheme as soon as we 
> change the container type, which affects the iterator type:
> 
> ```
> map containerizers;
> auto containerizer = containerizers.begin(); // Wouldn't do this.
> ```
> 
> How about a different example here with .find() as opposed to .begin()? 
> Take a look at cache.hpp as an example:
> 
> ```
>   // Evict the least-recently used element from the cache.
>   void evict()
>   {
> const typename map::iterator& i = values.find(keys.front());
> CHECK(i != values.end());
> values.erase(i);
> keys.pop_front();
>   }
> ```
> 
> Here we definitely care about the iterator, as opposed to the value, and 
> would name 'i' accordingly.
> 
> Alexander Rukletsov wrote:
> I see. So you would like to be able to 1) distinguish between iterator 
> type and element type, and 2) be able to reason about the iterator type 
> somehow (possible from the variable name). I think, that makes sense.
> 
> Using `auto` hides the actual type, and this can be both good and bad. We 
> should use it in places where we don't care (or shouldn't care) about the 
> actual type. Do we care about the container and iterator types when 
> enumerating all elements? I tend to say no, but you are absolutely right that 
> iterators of different containers are used in different ways.
> 
> Regarding naming, we can choose something general, like "element" or 
> "item". It will be clear from the context, what this element is about and 
> implies neither value nor iterator and can be used for both.
> 
> Benjamin Hindman wrote:
> To the best of my knowledge we've (or at least I've) used two different 
> naming schemes for working with iterators in the code base:
> 
> (1) When doing a 'find' we've named the variable the "thing" we're trying 
> to actually use, for example:
> 
> auto containerizer = containerizers.find("docker");
> 
> (2) When doing a 'begin' we've named the variable something that makes it 
> clear it's an iterator, for example:
> 
> auto it = containerizers.begin();
> auto iterator = containerizers.begin();
> 
> Why? Because for (1) it's highly likely that you'll want to do things 
> like:
> 
> containerizer->launch(...);
> containerizers.erase(containerizer);
> 
> But not:
> 
> ++containerizer;
> 
> Which can be harder to read, especially when initially declared using 
> 'auto'. Whereas for (2) it's highly likely that we _will_ want to do:
> 
> ++iterator
> 
> Which when named 'iterator' is easy to understand what you're doing.
> 
> That's my suggestion for suggesting a naming scheme for this guide.
> 
> Alexander Rukletsov wrote:
> Makes sense, especially `++containerizer`. To make the example less 
> confusing, I change it to `.find()`.
> 
> Ben Mahler wrote:
> Great, Alexander and I chatted off thread as well to go with an example 
> of .find().
> 
> Ben: If your example (1) is calling map::find (vector::find does not 
> exist), then you're actuall

Fwd: Regarding OPW mesos project

[Vinod Kone]

Hi prospective OPW interns,

I've been contacted by quite a few of you regarding "Mesos Getting Started
& Documentation" OPW project. So, wanted to send out a list of starter
tickets that you can work on.

https://issues.apache.org/jira/browse/MESOS-1647
https://issues.apache.org/jira/browse/MESOS-1552
https://issues.apache.org/jira/browse/MESOS-1506
https://issues.apache.org/jira/browse/MESOS-1521

If you would like to be added as a contributor to the project, please
respond to this email with your JIRA username and I'll add you.

Hope this helps,

Vinod

Mesos OPW project

[Vinod Kone]

Hi prospective OPW interns,

I've been contacted by quite a few of you regarding "Mesos Getting Started
& Documentation" OPW project. So, wanted to send out a list of starter
tickets that you can work on.

https://issues.apache.org/jira/browse/MESOS-1647
https://issues.apache.org/jira/browse/MESOS-1552
https://issues.apache.org/jira/browse/MESOS-1506
https://issues.apache.org/jira/browse/MESOS-1521

If you would like to be added as a contributor to the project, please
respond to this email with your JIRA username and I'll add you.

Hope this helps,

Vinod

Re: Review Request 26069: Introduce ClangFormat to Mesos.

[Michael Park]

> On Sept. 29, 2014, 1:17 p.m., Benjamin Hindman wrote:
> > support/clang-format, line 6
> > 
> >
> > This is actually not "good", since the '{' is not on a newline. I guess 
> > this is just for checking the access modifier offset, but it could be 
> > counter-intuitive for people.

Thanks for noticing this, I've updated the style and naming convention issues 
in the code samples.


> On Sept. 29, 2014, 1:17 p.m., Benjamin Hindman wrote:
> > support/clang-format, line 33
> > 
> >
> > We haven't had a hard rule about this, so if someone manually aligns 
> > them where that might make sense will ClangFormat un-align them?

Yes, ClangFormat will unalign them if asked. If we run `clang-format -i 
filename`, then ClangFormat formats the entire file. Since there are cases like 
this where we may want/need to format code manually, the recommended usage 
would be to integrate ClangFormat into your editor. With ClangFormat integrated 
into your editor, you can select parts of the code that you wish to format.


> On Sept. 29, 2014, 1:17 p.m., Benjamin Hindman wrote:
> > support/clang-format, line 56
> > 
> >
> > Can we fine-tune this? We break for function, class, struct, etc, but 
> > not for namespaces.

This is one of the 4 limitations I've outlined in the [Google 
Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
 There's no option to fine-tune this in the current version of clang, but I 
have a [fork of clang](https://github.com/mpark/clang/tree/mesos) which 
supports `Mesos` as one of the `BreakBeforeBraces` options. It also covers 2 
other limitations:

1. Arguments should be indented by 4 spaces rather than 2 spaces.
2. Overloaded operators should be padded with spaces.

The one I don't have implemented is the one you mentioned above, which is 
avoiding "jaggedness" in the code. I don't think it makes sense to expect 
people to run a custom clang-format. Having said that, I use the custom 
clang-format myself and am happy to help others get it working if they're 
interested.


> On Sept. 29, 2014, 1:17 p.m., Benjamin Hindman wrote:
> > support/clang-format, line 51
> > 
> >
> > Can ClangFormat differentiate when to do:
> > 
> > allocator->resourcesRecovered(
> > frameworkId,
> > slaveId,
> > resources,
> > filters);
> > 
> > instead of:
> > 
> > allocator->resourcesRecovered(frameworkId,
> >   slaveId,
> >   resources,
> >   filters);

No, I don't believe so :(


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54806
---


On Sept. 29, 2014, 6:33 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> ---
> 
> (Updated Sept. 29, 2014, 6:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We spend way too much of our time formatting, not to mention the amount of 
> time wasted during the review cycle to address style issues. Let’s get 
> ClangFormat to help us!
> 
> If you don't know what ClangFormat is or how it works, take a look at the 
> Chandler Carruth's [live 
> demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 
> 33m 27s.
> 
> Further details and analysis are available 
> [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
> 
> 
> Diffs
> -
> 
>   .clang-format PRE-CREATION 
>   support/clang-format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26069/diff/
> 
> 
> Testing
> ---
> 
> Refer to the __Sample Diff__ section in the [Google 
> Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 25818: Switch path::join() to be variadic

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review54852
---


Patch looks great!

Reviews applied: [25818]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 6:01 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25818/
> ---
> 
> (Updated Sept. 29, 2014, 6:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Switch path::join() to be variadic.
> 
> Updated now that 25789 has landed
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 14567f1 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25818/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26069: Introduce ClangFormat to Mesos.

[Dominic Hamon]

> On Sept. 29, 2014, 6:17 a.m., Benjamin Hindman wrote:
> > How much fine-tuning can we apply here? Between this and cpplint.py will we 
> > "cover" out style completely? Looking forward to helping make folks more 
> > productive but don't want to frustrate people that use this and then still 
> > get comments on their reviews about needing to make changes to be 
> > consistent with our style. :-/

one thing that i've seen happen in the past, is that any comments about style 
in reviews can be trivially dismissed as a bug against the clang-format 
specification. ie, reviews stop being about style nits at all but focus is 
instead on making clang-format more compliant (or allowing our style guide to 
mutate to match the clang-format one, alternatively).

every version of clang-format adds more tweakable items, but it is worth 
considering keeping our exceptions limited to ease people coming from other 
code-bases.


- Dominic


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54806
---


On Sept. 29, 2014, 11:33 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> ---
> 
> (Updated Sept. 29, 2014, 11:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We spend way too much of our time formatting, not to mention the amount of 
> time wasted during the review cycle to address style issues. Let’s get 
> ClangFormat to help us!
> 
> If you don't know what ClangFormat is or how it works, take a look at the 
> Chandler Carruth's [live 
> demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 
> 33m 27s.
> 
> Further details and analysis are available 
> [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
> 
> 
> Diffs
> -
> 
>   .clang-format PRE-CREATION 
>   support/clang-format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26069/diff/
> 
> 
> Testing
> ---
> 
> Refer to the __Sample Diff__ section in the [Google 
> Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 25818: Switch path::join() to be variadic

[Cody Maloney]

> On Sept. 29, 2014, 5:21 a.m., Adam B wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, line 34
> > 
> >
> > Excuse my ignorance of variadic templates, but could one write 
> > path::join("/") or path::join("")? If those would compile, they would be 
> > easy edge cases.

path::join("/"); doesn't compile (Although I could make it if we want). 

It would require another specialization of strings::join() which takes only one 
argument (The string to join by), or an explicit specialization of path::join() 
to deal with the single element case (Take a string and just return it).


> On Sept. 29, 2014, 5:21 a.m., Adam B wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, lines 27-29
> > 
> >
> > Aren't two of these lines the same? Am I missing something?

The two identical lines are indeed. Removed the second one.


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review54793
---


On Sept. 29, 2014, 6:01 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25818/
> ---
> 
> (Updated Sept. 29, 2014, 6:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Switch path::join() to be variadic.
> 
> Updated now that 25789 has landed
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 14567f1 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25818/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 24341: Added Java replicated log implementation of State.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24341/#review54845
---

Ship it!



src/java/jni/org_apache_mesos_state_LogState.cpp


This signature doesn't seem to be correct.



src/java/src/org/apache/mesos/state/LogState.java


Fix indent.


- Jie Yu


On Sept. 29, 2014, 12:44 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24341/
> ---
> 
> (Updated Sept. 29, 2014, 12:44 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION 
>   src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24341/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Review Request 26144: Fixed AllocatorTest.FrameworkExited test.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26144/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-1782
https://issues.apache.org/jira/browse/MESOS-1782


Repository: mesos-git


Description
---

The test had 2 expectations on resourcesAllocated() at the end, but didn't wait 
for the first one to be satisifed before setting up the more generic second 
one. As a result, the 2nd one can end up capturing all the resourcesAllocated() 
dispatches starving the 1st one.


Diffs
-

  src/tests/allocator_tests.cpp 9cd5da36daf144ba1c759003bc1376ce74833245 

Diff: https://reviews.apache.org/r/26144/diff/


Testing
---

Ran the test 500 times in repetition.


Thanks,

Vinod Kone

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2131

[Apache Jenkins Server]

] New master detected 
at master@67.195.81.189:39093
I0929 19:27:33.712152  6617 slave.cpp:651] Detecting new master
I0929 19:27:33.712177  6625 authenticatee.hpp:128] Creating new client SASL 
connection
I0929 19:27:33.712275  6610 master.cpp:3737] Authenticating 
slave(46)@67.195.81.189:39093
I0929 19:27:33.712368  6617 authenticator.hpp:156] Creating new server SASL 
connection
I0929 19:27:33.712460  6619 authenticatee.hpp:219] Received SASL authentication 
mechanisms: CRAM-MD5
I0929 19:27:33.712486  6619 authenticatee.hpp:245] Attempting to authenticate 
with mechanism 'CRAM-MD5'
I0929 19:27:33.712530  6619 authenticator.hpp:262] Received SASL authentication 
start
I0929 19:27:33.712574  6619 authenticator.hpp:384] Authentication requires more 
steps
I0929 19:27:33.712641  6613 authenticatee.hpp:265] Received SASL authentication 
step
I0929 19:27:33.712708  6613 authenticator.hpp:290] Received SASL authentication 
step
I0929 19:27:33.712738  6613 auxprop.cpp:81] Request to lookup properties for 
user: 'test-principal' realm: 'proserpina.apache.org' server FQDN: 
'proserpina.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false 
SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false 
I0929 19:27:33.712749  6613 auxprop.cpp:153] Looking up auxiliary property 
'*userPassword'
I0929 19:27:33.712761  6613 auxprop.cpp:153] Looking up auxiliary property 
'*cmusaslsecretCRAM-MD5'
I0929 19:27:33.712774  6613 auxprop.cpp:81] Request to lookup properties for 
user: 'test-principal' realm: 'proserpina.apache.org' server FQDN: 
'proserpina.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false 
SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true 
I0929 19:27:33.712787  6613 auxprop.cpp:103] Skipping auxiliary property 
'*userPassword' since SASL_AUXPROP_AUTHZID == true
I0929 19:27:33.712801  6613 auxprop.cpp:103] Skipping auxiliary property 
'*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true
I0929 19:27:33.712818  6613 authenticator.hpp:376] Authentication success
I0929 19:27:33.712877  6614 authenticatee.hpp:305] Authentication success
I0929 19:27:33.712890  6613 master.cpp:3777] Successfully authenticated 
principal 'test-principal' at slave(46)@67.195.81.189:39093
I0929 19:27:33.713059  6614 slave.cpp:735] Successfully authenticated with 
master master@67.195.81.189:39093
I0929 19:27:33.713119  6614 slave.cpp:998] Will retry registration in 19361ns 
if necessary
I0929 19:27:33.713223  6619 master.cpp:2930] Registering slave at 
slave(46)@67.195.81.189:39093 (proserpina.apache.org) with id 
20140929-192733-3176252227-39093-6596-0
I0929 19:27:33.713335  6615 slave.cpp:998] Will retry registration in 
4.227055ms if necessary
I0929 19:27:33.713359  6611 registrar.cpp:422] Attempting to update the 
'registry'
I0929 19:27:33.713367  6619 master.cpp:2918] Ignoring register slave message 
from slave(46)@67.195.81.189:39093 (proserpina.apache.org) as admission is 
already in progress
I0929 19:27:33.714776  6615 log.cpp:680] Attempting to append 344 bytes to the 
log
I0929 19:27:33.714859  6618 coordinator.cpp:340] Coordinator attempting to 
write APPEND action at position 3
I0929 19:27:33.715200  6613 replica.cpp:508] Replica received write request for 
position 3
I0929 19:27:33.715421  6613 leveldb.cpp:343] Persisting action (363 bytes) to 
leveldb took 194931ns
I0929 19:27:33.715440  6613 replica.cpp:676] Persisted action at 3
I0929 19:27:33.715760  6623 replica.cpp:655] Replica received learned notice 
for position 3
I0929 19:27:33.716230  6623 leveldb.cpp:343] Persisting action (365 bytes) to 
leveldb took 444917ns
I0929 19:27:33.716250  6623 replica.cpp:676] Persisted action at 3
I0929 19:27:33.716262  6623 replica.cpp:661] Replica learned APPEND action at 
position 3
I0929 19:27:33.716580  6620 registrar.cpp:479] Successfully updated 'registry'
I0929 19:27:33.716696  6618 master.cpp:2970] Registered slave 
20140929-192733-3176252227-39093-6596-0 at slave(46)@67.195.81.189:39093 
(proserpina.apache.org)
I0929 19:27:33.716704  6613 log.cpp:699] Attempting to truncate the log to 3
I0929 19:27:33.716725  6618 master.cpp:4180] Adding slave 
20140929-192733-3176252227-39093-6596-0 at slave(46)@67.195.81.189:39093 
(proserpina.apache.org) with cpus(*):2; mem(*):1024; disk(*):1024; 
ports(*):[31000-32000]
I0929 19:27:33.716799  6622 coordinator.cpp:340] Coordinator attempting to 
write TRUNCATE action at position 4
I0929 19:27:33.716914  6611 slave.cpp:769] Registered with master 
master@67.195.81.189:39093; given slave ID 
20140929-192733-3176252227-39093-6596-0
I0929 19:27:33.716976  6611 slave.cpp:2351] Received ping from 
slave-observer(48)@67.195.81.189:39093
I0929 19:27:33.717036  6623 hierarchical_allocator_process.hpp:442] Added slave 
20140929-192733-3176252227-39093-6596-0 (proserpina.apache.org) with cpus(*):2; 
mem(*):1024; disk(*):1024; ports(*):[31000-32000] (and cp

Review Request 26147: Remove non-variadic strings::format() implementation

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26147/
---

Review request for mesos and Dominic Hamon.


Repository: mesos-git


Description
---

Variadic templates are required in configure, so we don't need to be condtional 
around their use in strings::format


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
58ab7424c9645fd04d6aea2e4ff56c1ff9815953 

Diff: https://reviews.apache.org/r/26147/diff/


Testing
---

Make check on Ubuntu 14.04


Thanks,

Cody Maloney

Review Request 26149: Remove depreacted webui_hostname and webui_port fields

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26149/
---

Review request for mesos, Adam B and Vinod Kone.


Repository: mesos-git


Description
---

These have been deprecated since November 2013, at least Mesos 0.16. Should be 
safe to remove at this point (People will have to upgrade pre-0.16 to something 
between 0.16 and 0.20.1 inclusive, before upgrading past 0.20.1).

commit 03b94076caddceda4c0a6a03aa44ebe4d64f1acc
Author: Benjamin Hindman 
Date:   Mon Nov 4 11:51:05 2013 -1000

Re-deprecated 'webui_hostname' as optional (from required).

We still need to set the 'webui_hostname' field for now in order for
interoperating with code that expects it to be required (e.g., a slave
on an older release). After another deprecation cycle we can either
remove this field entirely or just keep it around as an artifact so
that we don't reuse the ID.

Review: https://reviews.apache.org/r/15214



Diffs
-

  include/mesos/mesos.proto be45494b2c2f5c1295409889b70004462c6eba49 
  src/common/type_utils.cpp e55b1f9beb4c1b7aba2076ce2b15072fd8eec4e3 
  src/master/registrar.cpp 3f9b9cf8ecc70e51fe41d3ac3993da1398571846 
  src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed 

Diff: https://reviews.apache.org/r/26149/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

Cody Maloney

Re: Review Request 26144: Fixed AllocatorTest.FrameworkExited test.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26144/#review54875
---

Ship it!



src/tests/allocator_tests.cpp


Can you include a comment like the one above?

// The framework does not use all the resources.


- Ben Mahler


On Sept. 29, 2014, 7:28 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26144/
> ---
> 
> (Updated Sept. 29, 2014, 7:28 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1782
> https://issues.apache.org/jira/browse/MESOS-1782
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The test had 2 expectations on resourcesAllocated() at the end, but didn't 
> wait for the first one to be satisifed before setting up the more generic 
> second one. As a result, the 2nd one can end up capturing all the 
> resourcesAllocated() dispatches starving the 1st one.
> 
> 
> Diffs
> -
> 
>   src/tests/allocator_tests.cpp 9cd5da36daf144ba1c759003bc1376ce74833245 
> 
> Diff: https://reviews.apache.org/r/26144/diff/
> 
> 
> Testing
> ---
> 
> Ran the test 500 times in repetition.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 26147: Remove non-variadic strings::format() implementation

[Dominic Hamon]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26147/#review54876
---


we check in configure in mesos, not in stout. we'd have to bubble those c++11 
checks down the stack through libprocess and into stout before we can 
responsibly deprecate this (and other) c++11 guards.

- Dominic Hamon


On Sept. 29, 2014, 1:47 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26147/
> ---
> 
> (Updated Sept. 29, 2014, 1:47 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Variadic templates are required in configure, so we don't need to be 
> condtional around their use in strings::format
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 58ab7424c9645fd04d6aea2e4ff56c1ff9815953 
> 
> Diff: https://reviews.apache.org/r/26147/diff/
> 
> 
> Testing
> ---
> 
> Make check on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 25848: Introducing mesos modules.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---

(Updated Sept. 29, 2014, 5:16 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and 
Timothy St. Clair.


Changes
---

Some style fixes.


Bugs: MESOS-1384
https://issues.apache.org/jira/browse/MESOS-1384


Repository: mesos-git


Description
---

Adding a first class primitive, abstraction and process for dynamic library 
writing and loading can make it easier to extend inner workings of Mesos. 
Making it possible to have dynamic loadable resource allocators, isolators, 
containerizes, authenticators and much more.


Diffs (updated)
-

  configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
  include/mesos/module.hpp.in PRE-CREATION 
  src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
  src/examples/test_module.hpp PRE-CREATION 
  src/examples/test_module_impl.cpp PRE-CREATION 
  src/examples/test_module_impl2.cpp PRE-CREATION 
  src/module/manager.hpp PRE-CREATION 
  src/module/manager.cpp PRE-CREATION 
  src/tests/module_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/25848/diff/


Testing
---

Ran make check with added tests for verifying library/module loading and simple 
version check.


Thanks,

Kapil Arya

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26133/
---

(Updated Sept. 29, 2014, 9:17 p.m.)


Review request for mesos, Cody Maloney, Dominic Hamon, and Timothy Chen.


Changes
---

Turns out the `CPPFLAGS` propagation issue is specific to `--with-curl`. 
Related, but separate issue.


Bugs: MESOS-1839
https://issues.apache.org/jira/browse/MESOS-1839


Repository: mesos-git


Description
---

Fixes MESOS-1839.


Diffs
-

  configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 

Diff: https://reviews.apache.org/r/26133/diff/


Testing (updated)
---

Built `mesos` with a custom `libsasl2` directory.


Thanks,

Michael Park

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26133/
---

(Updated Sept. 29, 2014, 2:22 p.m.)


Review request for mesos, Cody Maloney, Timothy Chen, and Vinod Kone.


Changes
---

i don't know enough about the bundled/non-bundled library stuff in configure to 
comment. s/dhamon/vinodkone/


Bugs: MESOS-1839
https://issues.apache.org/jira/browse/MESOS-1839


Repository: mesos-git


Description
---

Fixes MESOS-1839.


Diffs
-

  configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 

Diff: https://reviews.apache.org/r/26133/diff/


Testing
---

Built `mesos` with a custom `libsasl2` directory.


Thanks,

Michael Park

Re: Review Request 26147: Remove non-variadic strings::format() implementation

[Cody Maloney]

> On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote:
> > we check in configure in mesos, not in stout. we'd have to bubble those 
> > c++11 checks down the stack through libprocess and into stout before we can 
> > responsibly deprecate this (and other) c++11 guards.

We already use them in stout unconditionally at this point given 
https://reviews.apache.org/r/25789/


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26147/#review54876
---


On Sept. 29, 2014, 8:47 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26147/
> ---
> 
> (Updated Sept. 29, 2014, 8:47 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Variadic templates are required in configure, so we don't need to be 
> condtional around their use in strings::format
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 58ab7424c9645fd04d6aea2e4ff56c1ff9815953 
> 
> Diff: https://reviews.apache.org/r/26147/diff/
> 
> 
> Testing
> ---
> 
> Make check on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26149: Remove depreacted webui_hostname and webui_port fields

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26149/#review54882
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 29, 2014, 9:01 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26149/
> ---
> 
> (Updated Sept. 29, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> These have been deprecated since November 2013, at least Mesos 0.16. Should 
> be safe to remove at this point (People will have to upgrade pre-0.16 to 
> something between 0.16 and 0.20.1 inclusive, before upgrading past 0.20.1).
> 
> commit 03b94076caddceda4c0a6a03aa44ebe4d64f1acc
> Author: Benjamin Hindman 
> Date:   Mon Nov 4 11:51:05 2013 -1000
> 
> Re-deprecated 'webui_hostname' as optional (from required).
> 
> We still need to set the 'webui_hostname' field for now in order for
> interoperating with code that expects it to be required (e.g., a slave
> on an older release). After another deprecation cycle we can either
> remove this field entirely or just keep it around as an artifact so
> that we don't reuse the ID.
> 
> Review: https://reviews.apache.org/r/15214
> 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto be45494b2c2f5c1295409889b70004462c6eba49 
>   src/common/type_utils.cpp e55b1f9beb4c1b7aba2076ce2b15072fd8eec4e3 
>   src/master/registrar.cpp 3f9b9cf8ecc70e51fe41d3ac3993da1398571846 
>   src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed 
> 
> Diff: https://reviews.apache.org/r/26149/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26147: Remove non-variadic strings::format() implementation

[Dominic Hamon]

On Mon, Sep 29, 2014 at 2:24 PM, Cody Maloney  wrote:

>
>
> > On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote:
> > > we check in configure in mesos, not in stout. we'd have to bubble
> those c++11 checks down the stack through libprocess and into stout before
> we can responsibly deprecate this (and other) c++11 guards.
>
> We already use them in stout unconditionally at this point given
> https://reviews.apache.org/r/25789/


​That doesn't make it right, just means that that review shouldn't have
shipped without the configure change in stout :)

So this time, let's do it right and make sure people configuring stout have
the right compiler.​



>
>
>
> - Cody
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26147/#review54876
> ---
>
>
> On Sept. 29, 2014, 8:47 p.m., Cody Maloney wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/26147/
> > ---
> >
> > (Updated Sept. 29, 2014, 8:47 p.m.)
> >
> >
> > Review request for mesos and Dominic Hamon.
> >
> >
> > Repository: mesos-git
> >
> >
> > Description
> > ---
> >
> > Variadic templates are required in configure, so we don't need to be
> condtional around their use in strings::format
> >
> >
> > Diffs
> > -
> >
> >   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp
> 58ab7424c9645fd04d6aea2e4ff56c1ff9815953
> >
> > Diff: https://reviews.apache.org/r/26147/diff/
> >
> >
> > Testing
> > ---
> >
> > Make check on Ubuntu 14.04
> >
> >
> > Thanks,
> >
> > Cody Maloney
> >
> >
>
>


-- 
Dominic Hamon | @mrdo | Twitter
*There are no bad ideas; only good ideas that go horribly wrong.*

Re: Review Request 26147: Remove non-variadic strings::format() implementation

[Cody Maloney]

> On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote:
> > we check in configure in mesos, not in stout. we'd have to bubble those 
> > c++11 checks down the stack through libprocess and into stout before we can 
> > responsibly deprecate this (and other) c++11 guards.
> 
> Cody Maloney wrote:
> We already use them in stout unconditionally at this point given 
> https://reviews.apache.org/r/25789/

We also have been using libstdc++/libc++ tuples which depend on variadic 
templates in their implementatinos for quite a while inside libprocess.


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26147/#review54876
---


On Sept. 29, 2014, 8:47 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26147/
> ---
> 
> (Updated Sept. 29, 2014, 8:47 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Variadic templates are required in configure, so we don't need to be 
> condtional around their use in strings::format
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 58ab7424c9645fd04d6aea2e4ff56c1ff9815953 
> 
> Diff: https://reviews.apache.org/r/26147/diff/
> 
> 
> Testing
> ---
> 
> Make check on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26069: Introduce ClangFormat to Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54884
---


Patch looks great!

Reviews applied: [26069]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 6:33 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> ---
> 
> (Updated Sept. 29, 2014, 6:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-1291
> https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We spend way too much of our time formatting, not to mention the amount of 
> time wasted during the review cycle to address style issues. Let’s get 
> ClangFormat to help us!
> 
> If you don't know what ClangFormat is or how it works, take a look at the 
> Chandler Carruth's [live 
> demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 
> 33m 27s.
> 
> Further details and analysis are available 
> [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
> 
> 
> Diffs
> -
> 
>   .clang-format PRE-CREATION 
>   support/clang-format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26069/diff/
> 
> 
> Testing
> ---
> 
> Refer to the __Sample Diff__ section in the [Google 
> Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Mesos OPW project

[Evelina Dumitrescu]

evelinad

Review Request 26150: Libprocess Benchmark

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/
---

Review request for mesos and Niklas Nielsen.


Bugs: MESOS-1840
https://issues.apache.org/jira/browse/MESOS-1840


Repository: mesos-git


Description
---

A benchmark for libprocess.
It forks num_proc times and launched num_threads "libprocess" processes in each 
child. They are aware of the "master"'s (parent) address and all play ping pong 
with it.
This benchmark measures throughput in terms of the number of RPCs handled per 
second using persistent (linked) connections.

A new test file (benchmarks) is introduced because we want to fork before 
libprocess is initialized. This allows us to prevent short-circuiting of 
message passing between processes under the same ProcessManager. This way we 
force the execution path of the underlying event management system.


Diffs
-

  3rdparty/libprocess/Makefile.am 616618e 
  3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/26150/diff/


Testing
---

make check in 3rdparty/libprocess
support/mesos-style.py


Thanks,

Joris Van Remoortere

Re: Review Request 26147: Remove non-variadic strings::format() implementation

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26147/
---

(Updated Sept. 29, 2014, 9:40 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Repository: mesos-git


Description
---

Variadic templates are required in configure, so we don't need to be condtional 
around their use in strings::format


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
58ab7424c9645fd04d6aea2e4ff56c1ff9815953 

Diff: https://reviews.apache.org/r/26147/diff/


Testing
---

Make check on Ubuntu 14.04


Thanks,

Cody Maloney

Re: Review Request 26150: Libprocess Benchmark

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/#review54886
---



3rdparty/libprocess/src/tests/benchmarks.cpp


I'd like to start using all the nice C++11 features, but not sure if we 
want to start introducing them in our benchmark code?


- Timothy Chen


On Sept. 29, 2014, 9:38 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26150/
> ---
> 
> (Updated Sept. 29, 2014, 9:38 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1840
> https://issues.apache.org/jira/browse/MESOS-1840
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> A benchmark for libprocess.
> It forks num_proc times and launched num_threads "libprocess" processes in 
> each child. They are aware of the "master"'s (parent) address and all play 
> ping pong with it.
> This benchmark measures throughput in terms of the number of RPCs handled per 
> second using persistent (linked) connections.
> 
> A new test file (benchmarks) is introduced because we want to fork before 
> libprocess is initialized. This allows us to prevent short-circuiting of 
> message passing between processes under the same ProcessManager. This way we 
> force the execution path of the underlying event management system.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 616618e 
>   3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26150/diff/
> 
> 
> Testing
> ---
> 
> make check in 3rdparty/libprocess
> support/mesos-style.py
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 26147: Remove non-variadic strings::format() implementation

[Dominic Hamon]

> On Sept. 29, 2014, 2:13 p.m., Dominic Hamon wrote:
> > we check in configure in mesos, not in stout. we'd have to bubble those 
> > c++11 checks down the stack through libprocess and into stout before we can 
> > responsibly deprecate this (and other) c++11 guards.
> 
> Cody Maloney wrote:
> We already use them in stout unconditionally at this point given 
> https://reviews.apache.org/r/25789/
> 
> Cody Maloney wrote:
> We also have been using libstdc++/libc++ tuples which depend on variadic 
> templates in their implementatinos for quite a while inside libprocess.

That's unfortunate, but we should go back and fix that bad state.


- Dominic


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26147/#review54876
---


On Sept. 29, 2014, 2:40 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26147/
> ---
> 
> (Updated Sept. 29, 2014, 2:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Variadic templates are required in configure, so we don't need to be 
> condtional around their use in strings::format
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 58ab7424c9645fd04d6aea2e4ff56c1ff9815953 
> 
> Diff: https://reviews.apache.org/r/26147/diff/
> 
> 
> Testing
> ---
> 
> Make check on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26150: Libprocess Benchmark

[Dominic Hamon]

> On Sept. 29, 2014, 2:41 p.m., Timothy Chen wrote:
> > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 139
> > 
> >
> > I'd like to start using all the nice C++11 features, but not sure if we 
> > want to start introducing them in our benchmark code?

as long as we're checking for support in configure, it should be fine.


- Dominic


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/#review54886
---


On Sept. 29, 2014, 2:38 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26150/
> ---
> 
> (Updated Sept. 29, 2014, 2:38 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1840
> https://issues.apache.org/jira/browse/MESOS-1840
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> A benchmark for libprocess.
> It forks num_proc times and launched num_threads "libprocess" processes in 
> each child. They are aware of the "master"'s (parent) address and all play 
> ping pong with it.
> This benchmark measures throughput in terms of the number of RPCs handled per 
> second using persistent (linked) connections.
> 
> A new test file (benchmarks) is introduced because we want to fork before 
> libprocess is initialized. This allows us to prevent short-circuiting of 
> message passing between processes under the same ProcessManager. This way we 
> force the execution path of the underlying event management system.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 616618e 
>   3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26150/diff/
> 
> 
> Testing
> ---
> 
> make check in 3rdparty/libprocess
> support/mesos-style.py
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 26150: Libprocess Benchmark

[Timothy Chen]

> On Sept. 29, 2014, 9:41 p.m., Timothy Chen wrote:
> > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 139
> > 
> >
> > I'd like to start using all the nice C++11 features, but not sure if we 
> > want to start introducing them in our benchmark code?
> 
> Dominic Hamon wrote:
> as long as we're checking for support in configure, it should be fine.

I'm not sure if I didn't get the message, but if that's the case we should be 
notifying everyone that what C++11 features we can be using right? I only get 
the auto parameter email, but not the other ones that's in this rb.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/#review54886
---


On Sept. 29, 2014, 9:38 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26150/
> ---
> 
> (Updated Sept. 29, 2014, 9:38 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1840
> https://issues.apache.org/jira/browse/MESOS-1840
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> A benchmark for libprocess.
> It forks num_proc times and launched num_threads "libprocess" processes in 
> each child. They are aware of the "master"'s (parent) address and all play 
> ping pong with it.
> This benchmark measures throughput in terms of the number of RPCs handled per 
> second using persistent (linked) connections.
> 
> A new test file (benchmarks) is introduced because we want to fork before 
> libprocess is initialized. This allows us to prevent short-circuiting of 
> message passing between processes under the same ProcessManager. This way we 
> force the execution path of the underlying event management system.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 616618e 
>   3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26150/diff/
> 
> 
> Testing
> ---
> 
> make check in 3rdparty/libprocess
> support/mesos-style.py
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 26152: Remove unused stout tuples/ folder

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26152/
---

Review request for mesos, Ben Mahler, Dominic Hamon, and Till Toenshoff.


Repository: mesos-git


Description
---

None of these are included by anything in the codebase. They don't seem to have 
been used since at least MESOS-1026 or so when we switched to  and 
 .


Diffs
-

  3rdparty/libprocess/include/process/tuples/details.hpp f198f0e 
  3rdparty/libprocess/include/process/tuples/tuples.hpp f993b01 

Diff: https://reviews.apache.org/r/26152/diff/


Testing
---

make check


Thanks,

Cody Maloney

Re: Review Request 25848: Introducing mesos modules.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54879
---


Style review.

One high-level comment: the additional fields for authoring doesn't seem to 
scale well - how about introducing a struct for that payload. In other words, 
let's try to limit the use of macros to a bare minimum.


include/mesos/module.hpp.in


Can we use existing boost helpers for this? Something like 
http://www.boost.org/doc/libs/1_56_0/libs/preprocessor/doc/ref/cat.html



include/mesos/module.hpp.in


You can wrap all the functions in extern "C" {}



src/Makefile.am


Kill spaces - hard tabs in makefiles



src/examples/test_module.hpp


{ on new line



src/examples/test_module_impl.cpp


newline between includes from mesos, stout, ...



src/examples/test_module_impl.cpp


Wrap according to 
http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/



src/examples/test_module_impl2.cpp


Newline between the includes



src/examples/test_module_impl2.cpp


Can we avoid complex types in global scope?

And/or have const strings at least?



src/examples/test_module_impl2.cpp


You can mark the whole block (all the MESOS_ macros) as extern "C" to 
avoid duplication:

extern "C" {
...
}

Opposed to extern "C" every time



src/module/manager.hpp


Any particular reason for both using hashmap and maps?



src/module/manager.hpp


const string&? Here and below



src/module/manager.hpp


can we have const strings as keys?



src/module/manager.cpp


If we wanted to be pedantic from the start, how about setting all to 
MESOS_VERSION (like we discussed in the dev@ mailing thread) until we get 
comforatble with the api's stability?



src/module/manager.cpp


Mind indent according to 
http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/ ?

Bring down on newline and 4 space indent



src/module/manager.cpp


Same here



src/module/manager.cpp


Two newlines.



src/module/manager.cpp


Still a bit too dense - can we break up and comment on how it applies to 
the format defined in the header?



src/module/manager.cpp


Two newlines.



src/module/manager.cpp


can we have the key in libraryToModules be a const string instead?



src/tests/module_tests.cpp


Newline between the two



src/tests/module_tests.cpp


Two newlines between implementing functions



src/tests/module_tests.cpp


Can we have it return a const string?



src/tests/module_tests.cpp


bring this down on newline and indent 2



src/tests/module_tests.cpp


See above - let's work a bit on constness of the strings here and below.



src/tests/module_tests.cpp


const string version?



src/tests/module_tests.cpp


const strings?


- Niklas Nielsen


On Sept. 29, 2014, 2:16 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 29, 2014, 2:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mes

MESOS-1739 Design Document: Allow slave reconfiguration on restart

[Cody Maloney]

I've been working on: MESOS-1739 [1]. Vinod requested that I write up a
design document for the changes that will be needed [2]. I'd appreciate any
additional comments / review.

Cody

[1] https://issues.apache.org/jira/browse/MESOS-1739
[2]
https://docs.google.com/document/d/1PWv7YIdV3nN2l1oUW7Nybm4KdnxZ7Px2JGc5UM-PKoQ/edit?usp=sharing

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---

(Updated Sept. 29, 2014, 11:26 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod 
Kone.


Changes
---

Update for latest changes in master


Bugs: MESOS-1739
https://issues.apache.org/jira/browse/MESOS-1739


Repository: mesos-git


Description
---

Allows attributes and resources to be set to a superset of what they were 
previously on a slave restart.

Incorporates all comments from: 
https://issues.apache.org/jira/browse/MESOS-1739
and the former review request:
https://reviews.apache.org/r/25111/


Diffs (updated)
-

  src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
  src/common/attributes.hpp 0a043d5b5dca804c6dd215cabd2704f24df71a33 
  src/common/attributes.cpp aab114e1a5932e3f218b850e1afc7f2ef0f10e21 
  src/common/slaveinfo_utils.hpp PRE-CREATION 
  src/common/slaveinfo_utils.cpp PRE-CREATION 
  src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f 
  src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 
  src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 
  src/tests/attributes_tests.cpp 240a8cac18ac12178cf73e8eeb88bd50e3fcc03b 
  src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4 

Diff: https://reviews.apache.org/r/25525/diff/


Testing
---

make check on localhost


Thanks,

Cody Maloney

Re: Review Request 26147: Remove non-variadic strings::format() implementation

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26147/#review54920
---


Patch looks great!

Reviews applied: [26147]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 9:40 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26147/
> ---
> 
> (Updated Sept. 29, 2014, 9:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Variadic templates are required in configure, so we don't need to be 
> condtional around their use in strings::format
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 58ab7424c9645fd04d6aea2e4ff56c1ff9815953 
> 
> Diff: https://reviews.apache.org/r/26147/diff/
> 
> 
> Testing
> ---
> 
> Make check on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2132

[Apache Jenkins Server]

See 


Changes:

[bmahler] Increased the store timeout for the Registrar tests.

[dhamon] Switch [stout] to using compiler intrinsics for unreachable, exit, and 
abort

[dhamon] Switch [libprocess] to using compiler intrinsics for unreachable, 
exit, and abort

[dhamon] Switch [mesos] to using compiler intrinsics for unreachable, exit, and 
abort

--
[...truncated 2915 lines...]
[INFO] Building mesos 0.21.0
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ mesos ---
[INFO] 
[INFO] --- build-helper-maven-plugin:1.8:add-source (default) @ mesos ---
[INFO] Source directory: 

 added.
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ mesos ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ mesos ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ mesos ---
[INFO] Compiling 16 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
mesos ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
mesos ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ mesos ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mesos ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ mesos 
---
[INFO] 
[INFO] --- maven-javadoc-plugin:2.8.1:jar (build-and-attach-javadocs) @ mesos 
---
[INFO] 
Loading source files for package org.apache.mesos...
Loading source files for package org.apache.mesos.state...
Loading source files for package org.apache.mesos.containerizer...
Constructing Javadoc information...
Standard Doclet version 1.6.0_20
Building tree for all the packages and classes...
Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2131

[Vinod Kone]

 6615 slave.cpp:318] Slave checkpoint: false
> I0929 19:27:33.711467  6617 state.cpp:33] Recovering state from
> '/tmp/GarbageCollectorIntegrationTest_DiskUsage_5meoSi/meta'
> I0929 19:27:33.711596  6617 status_update_manager.cpp:193] Recovering
> status update manager
> I0929 19:27:33.711730  6622 slave.cpp:3277] Finished recovery
> I0929 19:27:33.712009  6617 slave.cpp:604] New master detected at
> master@67.195.81.189:39093
> I0929 19:27:33.712050  6617 slave.cpp:678] Authenticating with master
> master@67.195.81.189:39093
> I0929 19:27:33.712081  6610 status_update_manager.cpp:167] New master
> detected at master@67.195.81.189:39093
> I0929 19:27:33.712152  6617 slave.cpp:651] Detecting new master
> I0929 19:27:33.712177  6625 authenticatee.hpp:128] Creating new client
> SASL connection
> I0929 19:27:33.712275  6610 master.cpp:3737] Authenticating slave(46)@
> 67.195.81.189:39093
> I0929 19:27:33.712368 6617 authenticator.hpp:156] Creating new server
> SASL connection
> I0929 19:27:33.712460  6619 authenticatee.hpp:219] Received SASL
> authentication mechanisms: CRAM-MD5
> I0929 19:27:33.712486  6619 authenticatee.hpp:245] Attempting to
> authenticate with mechanism 'CRAM-MD5'
> I0929 19:27:33.712530  6619 authenticator.hpp:262] Received SASL
> authentication start
> I0929 19:27:33.712574  6619 authenticator.hpp:384] Authentication requires
> more steps
> I0929 19:27:33.712641  6613 authenticatee.hpp:265] Received SASL
> authentication step
> I0929 19:27:33.712708  6613 authenticator.hpp:290] Received SASL
> authentication step
> I0929 19:27:33.712738  6613 auxprop.cpp:81] Request to lookup properties
> for user: 'test-principal' realm: 'proserpina.apache.org' server FQDN: '
> proserpina.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false
> SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false
> I0929 19:27:33.712749 6613 auxprop.cpp:153] Looking up auxiliary property
> '*userPassword'
> I0929 19:27:33.712761  6613 auxprop.cpp:153] Looking up auxiliary property
> '*cmusaslsecretCRAM-MD5'
> I0929 19:27:33.712774  6613 auxprop.cpp:81] Request to lookup properties
> for user: 'test-principal' realm: 'proserpina.apache.org' server FQDN: '
> proserpina.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false
> SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true
> I0929 19:27:33.712787 6613 auxprop.cpp:103] Skipping auxiliary property
> '*userPassword' since SASL_AUXPROP_AUTHZID == true
> I0929 19:27:33.712801  6613 auxprop.cpp:103] Skipping auxiliary property
> '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true
> I0929 19:27:33.712818  6613 authenticator.hpp:376] Authentication success
> I0929 19:27:33.712877  6614 authenticatee.hpp:305] Authentication success
> I0929 19:27:33.712890  6613 master.cpp:3777] Successfully authenticated
> principal 'test-principal' at slave(46)@67.195.81.189:39093
> I0929 19:27:33.713059  6614 slave.cpp:735] Successfully authenticated with
> master master@67.195.81.189:39093
> I0929 19:27:33.713119  6614 slave.cpp:998] Will retry registration in
> 19361ns if necessary
> I0929 19:27:33.713223  6619 master.cpp:2930] Registering slave at
> slave(46)@67.195.81.189:39093 (proserpina.apache.org) with id
> 20140929-192733-3176252227-39093-6596-0
> I0929 19:27:33.713335 6615 slave.cpp:998] Will retry registration in
> 4.227055ms if necessary
> I0929 19:27:33.713359  6611 registrar.cpp:422] Attempting to update the
> 'registry'
> I0929 19:27:33.713367  6619 master.cpp:2918] Ignoring register slave
> message from slave(46)@67.195.81.189:39093 (proserpina.apache.org) as
> admission is already in progress
> I0929 19:27:33.714776 6615 log.cpp:680] Attempting to append 344 bytes to
> the log
> I0929 19:27:33.714859  6618 coordinator.cpp:340] Coordinator attempting to
> write APPEND action at position 3
> I0929 19:27:33.715200  6613 replica.cpp:508] Replica received write
> request for position 3
> I0929 19:27:33.715421  6613 leveldb.cpp:343] Persisting action (363 bytes)
> to leveldb took 194931ns
> I0929 19:27:33.715440  6613 replica.cpp:676] Persisted action at 3
> I0929 19:27:33.715760  6623 replica.cpp:655] Replica received learned
> notice for position 3
> I0929 19:27:33.716230  6623 leveldb.cpp:343] Persisting action (365 bytes)
> to leveldb took 444917ns
> I0929 19:27:33.716250  6623 replica.cpp:676] Persisted action at 3
> I0929 19:27:33.716262  6623 replica.cpp:661] Replica learned APPEND action
> at position 3
> I0929 19:27:33.716580  6620 registrar.cpp:479] Successfully updated
> 'registry'
> I0929 19:27:33.716696  6618 master.cpp:2970] Registered slave
> 20140929-192733-31762522

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2132

[Vinod Kone]

bumped up the inactive timeout from 10min to 30 min to account for build
slowness.

On Mon, Sep 29, 2014 at 4:48 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> See <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2132/changes
> >
>
> Changes:
>
> [bmahler] Increased the store timeout for the Registrar tests.
>
> [dhamon] Switch [stout] to using compiler intrinsics for unreachable,
> exit, and abort
>
> [dhamon] Switch [libprocess] to using compiler intrinsics for unreachable,
> exit, and abort
>
> [dhamon] Switch [mesos] to using compiler intrinsics for unreachable,
> exit, and abort
>
> --
> [...truncated 2915 lines...]
> [INFO] Building mesos 0.21.0
> [INFO]
> 
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ mesos ---
> [INFO]
> [INFO] --- build-helper-maven-plugin:1.8:add-source (default) @ mesos ---
> [INFO] Source directory: <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/generated>
> added.
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ mesos ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @
> mesos ---
> [debug] execute contextualize
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/classes
> >
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ mesos
> ---
> [INFO] Compiling 16 source files to <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/classes
> >
> [INFO]
> [INFO] --- maven-resources-plugin:2.5:testResources
> (default-testResources) @ mesos ---
> [debug] execute contextualize
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/src/test/resources
> >
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @
> mesos ---
> [INFO] No sources to compile
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ mesos ---
> [INFO] Tests are skipped.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mesos ---
> [INFO] Building jar: <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/mesos-0.21.0.jar
> >
> [INFO]
> [INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @
> mesos ---
> [INFO]
> [INFO] --- maven-javadoc-plugin:2.8.1:jar (build-and-attach-javadocs) @
> mesos ---
> [INFO]
> Loading source files for package org.apache.mesos...
> Loading source files for package org.apache.mesos.state...
> Loading source files for package org.apache.mesos.containerizer...
> Constructing Javadoc information...
> Standard Doclet version 1.6.0_20
> Building tree for all the packages and classes...
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Executor.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//ExecutorDriver.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Entry.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.OperationFailedException.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Position.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Reader.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Writer.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.WriterFailedException.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//MesosExecutorDriver.html..
> .>
> Generating <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//MesosSchedulerDriver.html..
> .>
> Generati

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

[Cody Maloney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26133/#review54925
---


The changes all look good to me structurally. Leaving Ship It's for committers.

- Cody Maloney


On Sept. 29, 2014, 9:22 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26133/
> ---
> 
> (Updated Sept. 29, 2014, 9:22 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1839
> https://issues.apache.org/jira/browse/MESOS-1839
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes MESOS-1839.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
> 
> Diff: https://reviews.apache.org/r/26133/diff/
> 
> 
> Testing
> ---
> 
> Built `mesos` with a custom `libsasl2` directory.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2133

[Apache Jenkins Server]

See 


Changes:

[vinodkone] Fixed AllocatorTest.FrameworkExited test.

[vinodkone] Remove depreacted webui_hostname and webui_port fields from 
SlaveInfo.

--
[...truncated 3016 lines...]
../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. 
--java_out=java/generated ../include/mesos/containerizer/containerizer.proto
/bin/mkdir -p python/interface/src/mesos/interface
../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include/mesos
\
-I../include -I. 
--python_out=python/interface/src/mesos/interface ../include/mesos/mesos.proto
/bin/mkdir -p python/interface/src/mesos/interface
../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc 
-I../include/mesos/containerizer  \
-I../include -I.
\
--python_out=python/interface/src/mesos/interface 
../include/mesos/containerizer/containerizer.proto
sed -e 's/mesos\.mesos_pb2/mesos_pb2/' 
python/interface/src/mesos/interface/containerizer_pb2.py
/bin/mkdir -p messages
../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. 
--cpp_out=. messages/messages.proto
/bin/mkdir -p messages
../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. 
--cpp_out=. messages/log.proto
/bin/mkdir -p messages
../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. 
--cpp_out=. messages/state.proto
/bin/mkdir -p master
../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. 
--cpp_out=. master/registry.proto
Building mesos-0.21.0.jar ...
[INFO] Scanning for projects...
[INFO] 
[INFO] Using the builder 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder
 with a thread count of 1
[INFO] 
[INFO] 
[INFO] Building mesos 0.21.0
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ mesos ---
[INFO] 
[INFO] --- build-helper-maven-plugin:1.8:add-source (default) @ mesos ---
[INFO] Source directory: 

 added.
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ mesos ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ mesos ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ mesos ---
[INFO] Compiling 16 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
mesos ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
mesos ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ mesos ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mesos ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ mesos 
---
[INFO] 
[INFO] --- maven-javadoc-plugin:2.8.1:jar (build-and-attach-javadocs) @ mesos 
---
[INFO] 
Loading source files for package org.apache.mesos...
Loading source files for package org.apache.mesos.state...
Loading source files for package org.apache.mesos.containerizer...
Constructing Javadoc information...
Standard Doclet version 1.6.0_20
Building tree for all the packages and classes...
Generating 

Generating 

Generating 

Generating 

scheduler.killExecutor()

[Tom Arnfeld]

Hi,

I've been making some modifications to the Hadoop framework recently and
have come up against a brick wall. I'm wondering if the concept of killing
an executor from a framework has been discussed before?

Currently we are launching two tasks for each Hadoop TaskTracker, one that
has a bit of CPU and all the memory, and then another with the rest of the
CPU. In total this equals the amount of resources we want to give each
TaskTracker. This is *kind of* how spark works, ish.

The reason we do this is to be able to free up CPU resources and remove
slots from a TaskTracker (killing it half dead) but keeping the executor
alive. At some undefined point in the future we then want to kill the
executor, this happens by killing the other "control" task.

This approach doesn't work very well in practice as a result of
https://issues.apache.org/jira/browse/MESOS-1812 which means tasks are not
launched in order on the slave, so there is no way to guarantee the control
task comes up first, which leads to all sorts of interesting races.

Is this is bad road to go down? I can't use framework messages as I don't
believe those are a reliable way of sending signals, so not sure where else
to turn.

Cheers,

Tom.

Re: Review Request 26150: Libprocess Benchmark

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150/#review54927
---


Patch looks great!

Reviews applied: [26150]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 9:38 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26150/
> ---
> 
> (Updated Sept. 29, 2014, 9:38 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1840
> https://issues.apache.org/jira/browse/MESOS-1840
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> A benchmark for libprocess.
> It forks num_proc times and launched num_threads "libprocess" processes in 
> each child. They are aware of the "master"'s (parent) address and all play 
> ping pong with it.
> This benchmark measures throughput in terms of the number of RPCs handled per 
> second using persistent (linked) connections.
> 
> A new test file (benchmarks) is introduced because we want to fork before 
> libprocess is initialized. This allows us to prevent short-circuiting of 
> message passing between processes under the same ProcessManager. This way we 
> force the execution path of the underlying event management system.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am 616618e 
>   3rdparty/libprocess/src/tests/benchmarks.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26150/diff/
> 
> 
> Testing
> ---
> 
> make check in 3rdparty/libprocess
> support/mesos-style.py
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: scheduler.killExecutor()

[Vinod Kone]

Adding a shutdownExecutor() driver call has been discussed before.
https://issues.apache.org/jira/browse/MESOS-330

As a work around, have you considered sending a special "kill" task as a
signal to the executor to commit suicide?



On Mon, Sep 29, 2014 at 5:27 PM, Tom Arnfeld  wrote:

> Hi,
>
> I've been making some modifications to the Hadoop framework recently and
> have come up against a brick wall. I'm wondering if the concept of killing
> an executor from a framework has been discussed before?
>
> Currently we are launching two tasks for each Hadoop TaskTracker, one that
> has a bit of CPU and all the memory, and then another with the rest of the
> CPU. In total this equals the amount of resources we want to give each
> TaskTracker. This is *kind of* how spark works, ish.
>
> The reason we do this is to be able to free up CPU resources and remove
> slots from a TaskTracker (killing it half dead) but keeping the executor
> alive. At some undefined point in the future we then want to kill the
> executor, this happens by killing the other "control" task.
>
> This approach doesn't work very well in practice as a result of
> https://issues.apache.org/jira/browse/MESOS-1812 which means tasks are not
> launched in order on the slave, so there is no way to guarantee the control
> task comes up first, which leads to all sorts of interesting races.
>
> Is this is bad road to go down? I can't use framework messages as I don't
> believe those are a reliable way of sending signals, so not sure where else
> to turn.
>
> Cheers,
>
> Tom.
>

Review Request 26159: Fixed framework logging in master.cpp.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26159/
---

Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
---

Like we did for slave, wanted to standardize how we log about a framework in 
master.cpp. Included framework.name() because I think it's more useful for 
debugging in a multi-framework world.

No semantic changes.


Diffs
-

  src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f 
  src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 

Diff: https://reviews.apache.org/r/26159/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 26152: Remove unused stout tuples/ folder

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26152/#review54933
---


Patch looks great!

Reviews applied: [26152]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2014, 9:55 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26152/
> ---
> 
> (Updated Sept. 29, 2014, 9:55 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Till Toenshoff.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> None of these are included by anything in the codebase. They don't seem to 
> have been used since at least MESOS-1026 or so when we switched to  
> and  .
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/tuples/details.hpp f198f0e 
>   3rdparty/libprocess/include/process/tuples/tuples.hpp f993b01 
> 
> Diff: https://reviews.apache.org/r/26152/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 26152: Remove unused stout tuples/ folder

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26152/#review54936
---

Ship it!


Thank you. The subject threw me off a bit since it says stout (which are 
actually used), but this is for libprocess.

- Ben Mahler


On Sept. 29, 2014, 9:55 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26152/
> ---
> 
> (Updated Sept. 29, 2014, 9:55 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Till Toenshoff.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> None of these are included by anything in the codebase. They don't seem to 
> have been used since at least MESOS-1026 or so when we switched to  
> and  .
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/tuples/details.hpp f198f0e 
>   3rdparty/libprocess/include/process/tuples/tuples.hpp f993b01 
> 
> Diff: https://reviews.apache.org/r/26152/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review54937
---


Bad patch!

Reviews applied: [25261]

Failed command: git apply --index 25261.patch

Error:
 error: patch failed: docs/mesos-c++-style-guide.md:82
error: docs/mesos-c++-style-guide.md: patch does not apply
error: patch failed: m4/ax_cxx_compile_stdcxx_11.m4:36
error: m4/ax_cxx_compile_stdcxx_11.m4: patch does not apply

- Mesos ReviewBot


On Sept. 29, 2014, 11:26 p.m., Cody Maloney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25525/
> ---
> 
> (Updated Sept. 29, 2014, 11:26 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-1739
> https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Allows attributes and resources to be set to a superset of what they were 
> previously on a slave restart.
> 
> Incorporates all comments from: 
> https://issues.apache.org/jira/browse/MESOS-1739
> and the former review request:
> https://reviews.apache.org/r/25111/
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/common/attributes.hpp 0a043d5b5dca804c6dd215cabd2704f24df71a33 
>   src/common/attributes.cpp aab114e1a5932e3f218b850e1afc7f2ef0f10e21 
>   src/common/slaveinfo_utils.hpp PRE-CREATION 
>   src/common/slaveinfo_utils.cpp PRE-CREATION 
>   src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f 
>   src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 
>   src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 
>   src/tests/attributes_tests.cpp 240a8cac18ac12178cf73e8eeb88bd50e3fcc03b 
>   src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4 
> 
> Diff: https://reviews.apache.org/r/25525/diff/
> 
> 
> Testing
> ---
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>

Review Request 26163: Fixed AllocatorTest.SlaveLost test.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26163/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-1844
https://issues.apache.org/jira/browse/MESOS-1844


Repository: mesos-git


Description
---

Similar to https://issues.apache.org/jira/browse/MESOS-1782 the expectation for 
'resourcesRecovered' was not waited for before setting further expectations on 
it.


Diffs
-

  src/tests/allocator_tests.cpp b824f77a0e941ecb623d1e64c2cdebea7871b71a 

Diff: https://reviews.apache.org/r/26163/diff/


Testing
---

Ran the test in a loop ~500 times.


Thanks,

Vinod Kone

Re: Review Request 26159: Fixed framework logging in master.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26159/#review54943
---


Patch looks great!

Reviews applied: [26159]

All tests passed.

- Mesos ReviewBot


On Sept. 30, 2014, 1:13 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26159/
> ---
> 
> (Updated Sept. 30, 2014, 1:13 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Like we did for slave, wanted to standardize how we log about a framework in 
> master.cpp. Included framework.name() because I think it's more useful for 
> debugging in a multi-framework world.
> 
> No semantic changes.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f 
>   src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 
> 
> Diff: https://reviews.apache.org/r/26159/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 26163: Fixed AllocatorTest.SlaveLost test.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26163/#review54947
---

Ship it!


Ship It!

- Ben Mahler


On Sept. 30, 2014, 2:46 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26163/
> ---
> 
> (Updated Sept. 30, 2014, 2:46 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1844
> https://issues.apache.org/jira/browse/MESOS-1844
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Similar to https://issues.apache.org/jira/browse/MESOS-1782 the expectation 
> for 'resourcesRecovered' was not waited for before setting further 
> expectations on it.
> 
> 
> Diffs
> -
> 
>   src/tests/allocator_tests.cpp b824f77a0e941ecb623d1e64c2cdebea7871b71a 
> 
> Diff: https://reviews.apache.org/r/26163/diff/
> 
> 
> Testing
> ---
> 
> Ran the test in a loop ~500 times.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 26163: Fixed AllocatorTest.SlaveLost test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26163/#review54948
---


Patch looks great!

Reviews applied: [26163]

All tests passed.

- Mesos ReviewBot


On Sept. 30, 2014, 2:46 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26163/
> ---
> 
> (Updated Sept. 30, 2014, 2:46 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1844
> https://issues.apache.org/jira/browse/MESOS-1844
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Similar to https://issues.apache.org/jira/browse/MESOS-1782 the expectation 
> for 'resourcesRecovered' was not waited for before setting further 
> expectations on it.
> 
> 
> Diffs
> -
> 
>   src/tests/allocator_tests.cpp b824f77a0e941ecb623d1e64c2cdebea7871b71a 
> 
> Diff: https://reviews.apache.org/r/26163/diff/
> 
> 
> Testing
> ---
> 
> Ran the test in a loop ~500 times.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Jenkins build is back to normal : mesos-reviewbot #1770

[Apache Jenkins Server]

See 

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #366

[Apache Jenkins Server]

See 

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2135

[Apache Jenkins Server]

See 

Re: Review Request 25848: Introducing mesos modules.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54955
---



include/mesos/module.hpp.in


MESOS_GET_AUTHOR_NAME -> MESOS_MODULE_AUTHOR_NAME
Same for the next two items.



src/module/manager.cpp


Good thinking. MESOS_VERSION should be the default.


- Bernd Mathiske


On Sept. 29, 2014, 2:16 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25848/
> ---
> 
> (Updated Sept. 29, 2014, 2:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, 
> and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1384
> https://issues.apache.org/jira/browse/MESOS-1384
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Adding a first class primitive, abstraction and process for dynamic library 
> writing and loading can make it easier to extend inner workings of Mesos. 
> Making it possible to have dynamic loadable resource allocators, isolators, 
> containerizes, authenticators and much more.
> 
> 
> Diffs
> -
> 
>   configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567 
>   include/mesos/module.hpp.in PRE-CREATION 
>   src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b 
>   src/examples/test_module.hpp PRE-CREATION 
>   src/examples/test_module_impl.cpp PRE-CREATION 
>   src/examples/test_module_impl2.cpp PRE-CREATION 
>   src/module/manager.hpp PRE-CREATION 
>   src/module/manager.cpp PRE-CREATION 
>   src/tests/module_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25848/diff/
> 
> 
> Testing
> ---
> 
> Ran make check with added tests for verifying library/module loading and 
> simple version check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>