Re: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and > was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, > Chris Plummer, Alexey Semenyuk and Phil Race. > > Thanks! Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19713#pullrequestreview-2117085705
[jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update
Hi all, This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race. Thanks! - Commit messages: - Backport c4702ca8c026e2d265aca0126fd3fb7bc5bb392a Changes: https://git.openjdk.org/jdk/pull/19713/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19713&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333827 Stats: 237 lines in 38 files changed: 133 ins; 57 del; 47 mod Patch: https://git.openjdk.org/jdk/pull/19713.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19713/head:pull/19713 PR: https://git.openjdk.org/jdk/pull/19713
Re: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and > was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, > Chris Plummer, Alexey Semenyuk and Phil Race. > > Thanks! Clean backport of L10n resource drop required for JDK23 - Marked as reviewed by jlu (Committer). PR Review: https://git.openjdk.org/jdk/pull/19713#pullrequestreview-2117082417
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]
On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons wrote: >> @jonathan-gibbons I just realized that this change to the German file >> matches the file with the Japanese and Chinese localized files. By that I >> mean the "backwards" translations are also present for the Japanese and >> Chinese files. >> >> However, the previous versions of the Japanese and Chinese files don't have >> these bits translated. So in summary, I can revert the German file back to >> German but the Japanese and Chinese files will still be English for these >> parts because I wouldn't know what to revert them to in their local language. >> >> As a result, I actually think it might be better to change this German file >> as shown in the current version of the PR just to remain consistent with the >> other localized versions of this file. We can still bring this up to the go >> team as an issue, but I think this is the best solution now for this drop at >> least. > > No one else except people reading this PR will spot inconsistencies between > translations in different languages. So inconsistencies across languages will > not be obvious to end users. > > But anyone (end-user) using the tool in any one of these languages is likely > to spot inconsistencies in the translations for that one language. @jonathan-gibbons I have gone back and manually undid some of the English translations back to its former German word. Most occurrences of this are `` to ``, but some others were changed back as well. Could you re-review this? - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1637092298
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Undo translation for some words - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files - new: https://git.openjdk.org/jdk/pull/19609/files/e9e0bcea..8c22d1db Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert updated translation Marked as reviewed by jlu (Committer). - PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2114131181
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert updated translation Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2114049394
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some for Japanese), but > looks good overall. > It's great to see diffs in native languages, rather than those cryptic > `\u` notation! > An interesting note after looking at Phil's comment on the > serviceui.properties change is that there is no Japanese update for that > file. The translations on > [here](https://github.com/openjdk/jdk/commit/c7d2a5c1c4e86955100f4c40170dc25222abd07f#diff-38c26a463e174224c6b9fc5007f3058482e533dc0f60f3275e21f9f2fc9acf8e) > from the output bins update look good to me but maybe @naotoj should double > check in case? I can confirm that English "Out&put trays:" to "出力トレイ(&P):" is OK - PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161765683
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some for Japanese), but > looks good overall. > It's great to see diffs in native languages, rather than those cryptic > `\u` notation! An interesting note after looking at Phil's comment on the serviceui.properties change is that there is no Japanese update for that file. The translations on [here](https://github.com/openjdk/jdk/commit/c7d2a5c1c4e86955100f4c40170dc25222abd07f#diff-38c26a463e174224c6b9fc5007f3058482e533dc0f60f3275e21f9f2fc9acf8e) from the output bins update look good to me but maybe @naotoj should double check in case? - PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161748245
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties >> line 32: >> >>> 30: border.jobattributes=作业属性 >>> 31: border.media=介质 >>> 32: border.output=出纸 >> >> What triggered this ? Just someone noticing it and deciding there's a better >> translation ? >> What does it say ? > > In the past, it was brought up in review that some of the words were > translated to localized words that didn't exactly mean what the original > English word meant. I believe Weijun Wang caught some of these in Chinese > files in the past. I'm assuming these are cases where the go team is > improving the translation, but I also can't exactly tell. We do suggest > changes to the go team, so maybe this is evidence of them improving their > tool. It was changed from "paper output" to just "output". Since the original English doesn't specify anything about paper, I guess the new translation is more general and fitting in this case. The original inclusion of the border.output field was actually part of the output bin update on [JDK-8314070](https://bugs.openjdk.org/browse/JDK-8314070) so it was actually not initially translated by the translation team. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635559474
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert updated translation LGTM - Marked as reviewed by achung (Committer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2111576337
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert updated translation Marked as reviewed by asemenyuk (Reviewer). jpackage changes look good - PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2111344874 PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161509207
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert updated translation - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files - new: https://git.openjdk.org/jdk/pull/19609/files/32d69e89..e9e0bcea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote: >> "Ausgabefächer" is the best German translation here. > > The reason for going with "Bereich (area)" instead of "Fach (compartment)" is > that an area is more general compared to a compartment. At least in German: > every "Fach" is a "Bereich", but every "Bereich" is NOT a "Fach". Thanks for the input @sormuras! - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635369067
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove double quotes jdk.jconsole and jdk.jdi changes look fine. - Marked as reviewed by cjplummer (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-208012
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote: >> Yeah, I believe you're right. Noted as something else to file against the >> translation tool. > > Just out of curiosity, do we know why `\t` was attached in the first place? I > don't think it is with the original English properties. I can see that in 2012, the original did not have `\t` while the translated files did. (Did not search before then). Seems like this discrepancy originates from awhile ago. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635242656
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
>> line 278:
>>
>>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements
>>> "{0}" verweist auf das nicht deklarierte Element "{1}".
>>> 277: UniqueNotationName = Deklaration für die Notation "{0}" ist
>>> nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren
>>> Notationsdeklarationen deklariert werden.
>>> 278: ENTITYFailedInitializeGrammar = ENTITYDatatype-Validator:
>>> Nicht erfolgreich. Initialisierungsmethode muss mit einer gültigen
>>> Grammatikreferenz aufgerufen werden. \t
>>
>> It looks like the _zh_CN_ file should also have the `\t` removed, but such
>> changes are done by the translation tool. I think in this case, we should
>> manually remove it, and then file a bug against the translation tool.
>
> Yeah, I believe you're right. Noted as something else to file against the
> translation tool.
Just out of curiosity, do we know why `\t` was attached in the first place? I
don't think it is with the original English properties.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635231459
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove double quotes I was asked to have a look at this PR elsewhere. I cannot verify correctness of translation, but I can review this PR generally for `jdk.javadoc`. >From what I can see, the changes are only to the property files, which is >expected from the PR title. The keys from English files 1-1 match the keys >from non-English files: there are no missing or extra keys. >From that point of view, the changes to `jdk.javadoc` look good. - Marked as reviewed by prappo (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2110098592
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Sun, 9 Jun 2024 19:35:04 GMT, Justin Lu wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties > line 285: > >> 283: VIRTUAL_MACHINE=Virtuelle Maschine >> 284: VM_ARGUMENTS=VM-Argumente >> 285: VMINTERNAL_FRAME_ACCESSIBLE_DESCRIPTION=Innerer Frame für das >> Monitoring einer Java Virtual Machine > > This one-off change is consistent with the change in > _src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java_. Consistently changed to be "[Denglisch](https://en.wikipedia.org/wiki/Denglisch)" instead of German. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634249847
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 20:34:10 GMT, Damon Nguyen wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties >> line 409: >> >>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl >>> ein nicht bedingtes Muster als auch ein Standardlabel >>> 408: >>> 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch >>> umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster >> >> Here and elsewhere in this file and other translations, I'm surprised >> `switch` is not being translated, and is being capitalized. In the English >> form, it is not being used as a keyword, although could maybe be seen as a >> short form of `switch' statement, in which case `switch` should be treated >> as a keyword and not translated or capitalized. > > Good catch. Seems to be across all files and I'm assuming it's for the reason > you suggested. I'll bring this up to the go team. I have no way to fix this > since I can't rely on google translate. This can be caught in a future update > if the go team can successfully differentiate the difference between the word > `switch` and a `switch keyword`. Yes. "Switch ..." is the short form for "Das Switch-Statement ..." or "Das `switch` Statement ..." and all other longer forms that match the context. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634244985
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Tue, 11 Jun 2024 05:43:12 GMT, Christian Stein wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties >> line 66: >> >>> 64: label.size=G&röße: >>> 65: label.source=&Quelle: >>> 66: label.outputbins=A&usgabefächer: >> >> How confident are we in this ? >> google translate says that the old text referred to 'compartments' and the >> new one to 'areas' and I wonder why that is better ? >> >> https://translate.google.com/?sl=auto&tl=en&text=Ausgabebereiche%0AAusgebefacher&op=translate > > "Ausgabefächer" is the best German translation here. The reason for going with "Bereich (area)" instead of "Fach (compartment)" is that an area is more general compared to a compartment. At least in German: every "Fach" is a "Bereich", but every "Bereich" is NOT a "Fach". - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634240847
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 22:48:13 GMT, Damon Nguyen wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
>> line 325:
>>
>>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>>> 324: {"unknown", "unbekannt"},
>>> 325: {"Unmonitoring", "Monitoring von {0} aufheben"},
>>
>> The English entry is:
>>
>> {"Unmonitoring", "Unmonitoring {0} "},
>>
>> But the German entry now says "Monitoring". I'm sure what the original
>> "\u00DCberwachung" translates to, other than berwachung is monitoring. Now
>> this resource is partly in English, and is the incorrect English.
>
> I don't know German, but when plugging `"Monitoring von {0} aufheben"` into
> google translate, I get `Unmonitoring` as well. Maybe `Monitoring` is a word
> that could also be used in German? No clue. The translation tool decided to
> make this change.
>
> @sormuras do you have any input on this?
It's correct.
The "Un" of "Unmonitoring" is moved to the associated verb in German:
"aufheben". which in this context translates to "cancel" or "revoke". This
seems to be one of the few cases where there's no commonly used single word in
German for "Unmonitoring".
> Now this resource is partly in English, and is the incorrect English.
That's how Tech-German often works - take a word from English and use it as-is,
sometimes missing the original meaning. Such words or phrases are then referred
to as: Denglisch.
In this case "Überwachung" was German, "Monitoring" is Denglisch. I'd revert
that to `\u00DCberwachung` - but both are okay.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634236406
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 20:19:51 GMT, Phil Race wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties > line 66: > >> 64: label.size=G&röße: >> 65: label.source=&Quelle: >> 66: label.outputbins=A&usgabefächer: > > How confident are we in this ? > google translate says that the old text referred to 'compartments' and the > new one to 'areas' and I wonder why that is better ? > > https://translate.google.com/?sl=auto&tl=en&text=Ausgabebereiche%0AAusgebefacher&op=translate "Ausgabefächer" is the best German translation here. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634221518
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:38:18 GMT, Damon Nguyen wrote: >> While we do not translate Java keywords (when used as such, e.g. "`class` >> not allowed here"), and option names (e.g. `--class-path`) we have typically >> translated other text that is not mandated by the language or tools, (e.g. >> `the name of this class`, ``, ``. >> >> This change seems to be going backwards. >> >> Whatever the policy we use for translating (or not translating) parts of a >> message, we should be consistent across all tools and documents. > > @jonathan-gibbons I just realized that this change to the German file matches > the file with the Japanese and Chinese localized files. By that I mean the > "backwards" translations are also present for the Japanese and Chinese files. > > However, the previous versions of the Japanese and Chinese files don't have > these bits translated. So in summary, I can revert the German file back to > German but the Japanese and Chinese files will still be English for these > parts because I wouldn't know what to revert them to in their local language. > > As a result, I actually think it might be better to change this German file > as shown in the current version of the PR just to remain consistent with the > other localized versions of this file. We can still bring this up to the go > team as an issue, but I think this is the best solution now for this drop at > least. No one else except people reading this PR will spot inconsistencies between translations in different languages. So inconsistencies across languages will not be obvious to end users. But anyone (end-user) using the tool in any one of these languages is likely to spot inconsistencies in the translations for that one language. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633937355
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 22:19:49 GMT, Chris Plummer wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
> line 325:
>
>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>> 324: {"unknown", "unbekannt"},
>> 325: {"Unmonitoring", "Monitoring von {0} aufheben"},
>
> The English entry is:
>
> {"Unmonitoring", "Unmonitoring {0} "},
>
> But the German entry now says "Monitoring". I'm sure what the original
> "\u00DCberwachung" translates to, other than berwachung is monitoring. Now
> this resource is partly in English, and is the incorrect English.
I don't know German, but when plugging `"Monitoring von {0} aufheben"` into
google translate, I get `Unmonitoring` as well. Maybe `Monitoring` is a word
that could also be used in German? No clue. The translation tool decided to
make this change.
@sormuras do you have any input on this?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633925334
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The translation tool adjusted some definitions, which causes some changes in
>> localized files where the source file had no changes. This causes some words
>> being reverted from localized languages to English, and some had its
>> definitions changed.
>>
>> Alternatively, the diffs are viewable here and was generated using Jonathan
>> Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove double quotes
src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
line 325:
> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
> 324: {"unknown", "unbekannt"},
> 325: {"Unmonitoring", "Monitoring von {0} aufheben"},
The English entry is:
{"Unmonitoring", "Unmonitoring {0} "},
But the German entry now says "Monitoring". I'm sure what the original
"\u00DCberwachung" translates to, other than berwachung is monitoring. Now this
resource is partly in English, and is the incorrect English.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633902362
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Remove double quotes - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files - new: https://git.openjdk.org/jdk/pull/19609/files/9125337b..32d69e89 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ One minor comment, otherwise the java.xml changes look good. src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties line 331: > 329: > 330: # Implementation Property DTD > 331: JDK_DTD_DENY = JAXP00010008: DOCTYPE ist nicht zulässig, wenn > die DTD-Eigenschaft auf "Ablehnen" gesetzt wurde. Weitere Informationen: > Eigenschaft jdk.xml.dtd.support in java.xml/module-summary. either drop the double quote in "Ablehnen" or use the literal without translation, that is, "deny". - Marked as reviewed by joehw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2108813421 PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633870136
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option names (e.g. `--class-path`) we have typically > translated other text that is not mandated by the language or tools, (e.g. > `the name of this class`, ``, ``. > > This change seems to be going backwards. > > Whatever the policy we use for translating (or not translating) parts of a > message, we should be consistent across all tools and documents. @jonathan-gibbons I just realized that this change to the German file matches the file with the Japanese and Chinese localized files. By that I mean the "backwards" translations are also present for the Japanese and Chinese files. However, the previous versions of the Japanese and Chinese files don't have these bits translated. So in summary, I can revert the German file back to German but the Japanese and Chinese files will still be English for these parts because I wouldn't know what to revert them to in their local language. As a result, I actually think it might be better to change this German file as shown in the current version of the PR just to remain consistent with the other localized versions of this file. We can still bring this up to the go team as an issue, but I think this is the best solution now for this drop at least. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633859027
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: > Did not look at each for translation accuracy (did some for Japanese), but > looks good overall. It's great to see diffs in native languages, rather than > those cryptic `\u` notation! Justin's tool is responsible for this. Made the process quicker/simpler as well once everything was setup properly and working. - PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2159331304
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Did not look at each for translation accuracy (did some for Japanese), but looks good overall. It's great to see diffs in native languages, rather than those cryptic `\u` notation! - Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2108722631
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:20:52 GMT, Phil Race wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties > line 32: > >> 30: border.jobattributes=作业属性 >> 31: border.media=介质 >> 32: border.output=出纸 > > What triggered this ? Just someone noticing it and deciding there's a better > translation ? > What does it say ? In the past, it was brought up in review that some of the words were translated to localized words that didn't exactly mean what the original English word meant. I believe Weijun Wang caught some of these in Chinese files in the past. I'm assuming these are cases where the go team is improving the translation, but I also can't exactly tell. We do suggest changes to the go team, so maybe this is evidence of them improving their tool. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633801033
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option names (e.g. `--class-path`) we have typically > translated other text that is not mandated by the language or tools, (e.g. > `the name of this class`, ``, ``. > > This change seems to be going backwards. > > Whatever the policy we use for translating (or not translating) parts of a > message, we should be consistent across all tools and documents. The go translation team dictates which of these segments within a file actually get updated. I can manually revert the segments if preferred, but these changes will continue appearing for future drops with the current system. I can potentially try to communicate to the other team to differentiate between keywords & option names versus some of these other words, but let me know how you'd like me to proceed with this. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633794362
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Mon, 10 Jun 2024 20:20:26 GMT, Jonathan Gibbons wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The translation tool adjusted some definitions, which causes some changes in >> localized files where the source file had no changes. This causes some words >> being reverted from localized languages to English, and some had its >> definitions changed. >> >> Alternatively, the diffs are viewable here and was generated using Jonathan >> Gibbons' diff tool for l10n: >> https://cr.openjdk.org/~dnguyen/output2/ > > src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties > line 409: > >> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl >> ein nicht bedingtes Muster als auch ein Standardlabel >> 408: >> 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch >> umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster > > Here and elsewhere in this file and other translations, I'm surprised > `switch` is not being translated, and is being capitalized. In the English > form, it is not being used as a keyword, although could maybe be seen as a > short form of `switch' statement, in which case `switch` should be treated as > a keyword and not translated or capitalized. Good catch. Seems to be across all files and I'm assuming it's for the reason you suggested. I'll bring this up to the go team. I have no way to fix this since I can't rely on google translate. This can be caught in a future update if the go team can successfully differentiate the difference between the word `switch` and a `switch keyword`. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633796771
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties line 409: > 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl ein > nicht bedingtes Muster als auch ein Standardlabel > 408: > 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch > umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster Here and elsewhere in this file and other translations, I'm surprised `switch` is not being translated, and is being capitalized. In the English form, it is not being used as a keyword, although could maybe be seen as a short form of `switch' statement, in which case `switch` should be treated as a keyword and not translated or capitalized. - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633782242
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties line 66: > 64: label.size=G&röße: > 65: label.source=&Quelle: > 66: label.outputbins=A&usgabefächer: How confident are we in this ? google translate says that the old text referred to 'compartments' and the new one to 'areas' and I wonder why that is better ? https://translate.google.com/?sl=auto&tl=en&text=Ausgabebereiche%0AAusgebefacher&op=translate src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties line 32: > 30: border.jobattributes=作业属性 > 31: border.media=介质 > 32: border.output=出纸 What triggered this ? Just someone noticing it and deciding there's a better translation ? What does it say ? - PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633781646 PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633782742
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Sun, 9 Jun 2024 22:07:44 GMT, Damon Nguyen wrote:
>> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties
>> line 183:
>>
>>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach
>>> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur
>>> Variablenerstellung oder "M" zur Methodenerstellung.\nWeitere Informationen
>>> finden Sie unter:\n/help shortcuts
>>> 182:
>>> 183: help.usage = Verwendung: jshell ... ...\nMögliche
>>> Optionen:\n--class-pathGibt an, wo die Benutzerklassendateien
>>> gespeichert sind\n--module-path Gibt an, wo die
>>> Anwendungsmodule gespeichert sind\n--add-modules (,)*\n
>>> Gibt aufzulösende Module oder alle Module im\n
>>>Modulpfad an, wenn ALL-MODULE-PATHs
>>> lautet\n--enable-native-access\n Ermöglicht
>>> Ausführung eingeschränkter nativer Methoden durch Code\n
>>> --enable-preview Code kann Vorschaufeatures in diesem Release nutzen\n
>>>--startup Ersetzung der Startdefinitionen mit einer
>>> Ausführung\n--no-startup Startdefinitionen werden nicht
>>> ausgeführt\n--feedback Gibt den anfänglichen Feedbackmodus
>>> an. Der Modus kann\nvordefiniert (Silent,
>>> Concise, Normal oder Verbose) oder\n
vorab benutzerdefiniert sein\n-qStilles Feedback.
Identisch mit: --feedback concise\n-sÄußerst stilles
Feedback. Identisch mit: --feedback silent\n-v
Verbose-Feedback. Identisch mit: --feedback verbose\n-J
Übergibt an das Laufzeitsystem, hat aber keine Auswirkungen\n
auf die Ausführung von Code-Snippets. Um Kennzeichen
anzugeben,\ndie die Ausführung von Code-Snippets
beeinflussen, verwenden Sie\n-R. Verwenden
Sie alternativ dazu -J mit\n--execution
local.\n-R Übergibt nur dann an das
Laufzeitsystem, wenn\nCode-Snippets ausgeführt
werden. Beispiel: -R-Dfoo=bar\nbedeutet, dass die
Ausführung des Snippets\nSystem.getProperty("foo")
"bar" zurück
gibt.\n-C Übergibt an den Java-Compiler in
JShell.\nBeispiel: -C-Xlint aktiviert alle
empfohlenen\n...
>
> This is what I've determined as well. I planned to leave these untranslated
> to reduce noise between drops as well.
While we do not translate Java keywords (when used as such, e.g. "`class` not
allowed here"), and option names (e.g. `--class-path`) we have typically
translated other text that is not mandated by the language or tools, (e.g. `the
name of this class`, ``, ``.
This change seems to be going backwards.
Whatever the policy we use for translating (or not translating) parts of a
message, we should be consistent across all tools and documents.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633774912
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Sun, 9 Jun 2024 22:49:11 GMT, Justin Lu wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The translation tool adjusted some definitions, which causes some changes in
>> localized files where the source file had no changes. This causes some words
>> being reverted from localized languages to English, and some had its
>> definitions changed.
>>
>> Alternatively, the diffs are viewable here and was generated using John
>> Gibbon's diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties
> line 1:
>
>> 1: #
>
> It looks like these .properties files need to have their copyright years
> bumped. I believe since the original was not bumped, the translation tool did
> not reflect the correct year in the localized versions.
Right, the source file has the copyright year of 2019, and these translated
files reflect that, so I believe this is OK.
> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties
> line 66:
>
>> 64: label.size=大小(&Z):
>> 65: label.source=来源(&C):
>> 66: label.outputbins=输出托盘(&P)：
>
> Looks like the translation tool changed this from a colon (U+003A) to a full
> width colon (U+FF1A). There are l10n rules when it comes to punctuation, I am
> not sure if this is a result of that. It looks like the surrounding
> key/values are simply using (U+003A) colons. If we decide to revert this
> colon change, we need to also probably file a bug against the translation
> tool.
Right, I agree. I'm OK with either decision too, but I'm leaning towards
reverting this to standardize the colons since the rest are (U+003A). Maybe a
reviewer from desktop can chime in once this PR is undrafted.
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
> line 278:
>
>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements
>> "{0}" verweist auf das nicht deklarierte Element "{1}".
>> 277: UniqueNotationName = Deklaration für die Notation "{0}" ist
>> nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren
>> Notationsdeklarationen deklariert werden.
>> 278: ENTITYFailedInitializeGrammar = ENTITYDatatype-Validator:
>> Nicht erfolgreich. Initialisierungsmethode muss mit einer gültigen
>> Grammatikreferenz aufgerufen werden. \t
>
> It looks like the _zh_CN_ file should also have the `\t` removed, but such
> changes are done by the translation tool. I think in this case, we should
> manually remove it, and then file a bug against the translation tool.
Yeah, I believe you're right. Noted as something else to file against the
translation tool.
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties
> line 183:
>
>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach
>> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur
>> Variablenerstellung oder "M" zur Methodenerstellung.\nWeitere Informationen
>> finden Sie unter:\n/help shortcuts
>> 182:
>> 183: help.usage = Verwendung: jshell ... ...\nMögliche
>> Optionen:\n--class-pathGibt an, wo die Benutzerklassendateien
>> gespeichert sind\n--module-path Gibt an, wo die Anwendungsmodule
>> gespeichert sind\n--add-modules (,)*\n
>>Gibt aufzulösende Module oder alle Module im\n
>> Modulpfad an, wenn ALL-MODULE-PATHs lautet\n
>> --enable-native-access\n Ermöglicht Ausführung
>> eingeschränkter nativer Methoden durch Code\n--enable-preview Code
>> kann Vorschaufeatures in diesem Release nutzen\n--startup
>> Ersetzung der Startdefinitionen mit einer Ausführung\n--no-startup
>>Startdefinitionen werden nicht ausgeführt\n--feedback
>> Gibt den anfänglichen Feedbackmodus an. Der Modus kann\n
>>vordefiniert (Silent, Concise, Normal oder Verbose) oder\n
>>
vorab benutzerdefiniert sein\n-qStilles Feedback.
Identisch mit: --feedback concise\n-sÄußerst stilles
Feedback. Identisch mit: --feedback silent\n-v
Verbose-Feedback. Identisch mit: --feedback verbose\n-J
Übergibt an das Laufzeitsystem, hat aber keine Auswirkungen\n
auf die Ausführung von Code-Snippets. Um Kennzeichen
anzugeben,\ndie die Ausführung von Code-Snippets
beeinflussen, verwenden Sie\n-R. Verwenden
Sie alternativ dazu -J mit\n--execution
local.\n-R Übergibt nur dann an das
Laufzeitsystem, wenn\nCode-
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translation tool adjusted some definitions, which causes some changes in
> localized files where the source file had no changes. This causes some words
> being reverted from localized languages to English, and some had its
> definitions changed.
>
> Alternatively, the diffs are viewable here and was generated using John
> Gibbon's diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/
Cannot speak to the translations themselves, but in general the changes LGTM
pending the comments.
src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties line
1:
> 1: #
It looks like these .properties files need to have their copyright years
bumped. I believe since the original was not bumped, the translation tool did
not reflect the correct year in the localized versions.
src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties
line 66:
> 64: label.size=大小(&Z):
> 65: label.source=来源(&C):
> 66: label.outputbins=输出托盘(&P)：
Looks like the translation tool changed this from a colon (U+003A) to a full
width colon (U+FF1A). There are l10n rules when it comes to punctuation, I am
not sure if this is a result of that. It looks like the surrounding key/values
are simply using (U+003A) colons. If we decide to revert this colon change, we
need to also probably file a bug against the translation tool.
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
line 278:
> 276: UndeclaredElementInContentSpec = Contentmodell des Elements
> "{0}" verweist auf das nicht deklarierte Element "{1}".
> 277: UniqueNotationName = Deklaration für die Notation "{0}" ist
> nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren
> Notationsdeklarationen deklariert werden.
> 278: ENTITYFailedInitializeGrammar = ENTITYDatatype-Validator: Nicht
> erfolgreich. Initialisierungsmethode muss mit einer gültigen
> Grammatikreferenz aufgerufen werden. \t
It looks like the _zh_CN_ file should also have the `\t` removed, but such
changes are done by the translation tool. I think in this case, we should
manually remove it, and then file a bug against the translation tool.
src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties
line 285:
> 283: VIRTUAL_MACHINE=Virtuelle Maschine
> 284: VM_ARGUMENTS=VM-Argumente
> 285: VMINTERNAL_FRAME_ACCESSIBLE_DESCRIPTION=Innerer Frame für das Monitoring
> einer Java Virtual Machine
This one-off change is consistent with the change in
_src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java_.
src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties
line 183:
> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach
> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur
> Variablenerstellung oder "M" zur Methodenerstellung.\nWeitere Informationen
> finden Sie unter:\n/help shortcuts
> 182:
> 183: help.usage = Verwendung: jshell ... ...\nMögliche
> Optionen:\n--class-pathGibt an, wo die Benutzerklassendateien
> gespeichert sind\n--module-path Gibt an, wo die Anwendungsmodule
> gespeichert sind\n--add-modules (,)*\n
> Gibt aufzulösende Module oder alle Module im\n
> Modulpfad an, wenn ALL-MODULE-PATHs lautet\n
> --enable-native-access\n Ermöglicht Ausführung
> eingeschränkter nativer Methoden durch Code\n--enable-preview Code
> kann Vorschaufeatures in diesem Release nutzen\n--startup
> Ersetzung der Startdefinitionen mit einer Ausführung\n--no-startup
> Startdefinitionen werden nicht ausgeführt\n--feedback Gibt
> den anfänglichen Feedbackmodus an. Der Modus kann\n
> vordefiniert (Silent, Concise, Normal oder Verbose) oder\n
> v
orab benutzerdefiniert sein\n-qStilles Feedback.
Identisch mit: --feedback concise\n-sÄußerst stilles
Feedback. Identisch mit: --feedback silent\n-v
Verbose-Feedback. Identisch mit: --feedback verbose\n-J
Übergibt an das Laufzeitsystem, hat aber keine Auswirkungen\n
auf die Ausführung von Code-Snippets. Um Kennzeichen
anzugeben,\ndie die Ausführung von Code-Snippets
beeinflussen, verwenden Sie\n-R. Verwenden
Sie alternativ dazu -J mit\n--execution
local.\n-R Übergibt nur dann an das
Laufzeitsystem, wenn\nCode-Snippets a
RFR: 8333827: JDK 23 RDP1 L10n resource files update
This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed. Alternatively, the diffs are viewable here and was generated using John Gibbon's diff tool for l10n: https://cr.openjdk.org/~dnguyen/output2/ - Commit messages: - Review comment edits - Initial localization changes Changes: https://git.openjdk.org/jdk/pull/19609/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333827 Stats: 239 lines in 39 files changed: 133 ins; 57 del; 49 mod Patch: https://git.openjdk.org/jdk/pull/19609.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609 PR: https://git.openjdk.org/jdk/pull/19609
Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. > > Alternatively, the diffs are viewable here and was generated using John > Gibbon's diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Just a question about the reverted translations, otherwise LGTM > The translation tool adjusted some definitions, which causes some changes in > localized files where the source file had no changes. This causes some words > being reverted from localized languages to English, and some had its > definitions changed. Any particular reason you know that the tool had the definitions adjusted? I see some of the changes look like like command line options not being translated, but it's a bit hard to tell. Do you know if the reverted words should be translated (and possibly will be re-translated in future drops?) or should they be left untranslated? - PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2105526180 PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2155723513
