On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in
On Tue, 2 Aug 2022 07:36:11 GMT, Ambarish Rapte wrote:
>> Yes, in `PsMath.h::computeLight`, there is a check if the light requests
>> attenuation. In general, this is done only for directional lights (that are
>> not attenuated), but in this case we know that this point light is not
>>
oved the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psMath`
> * Moved the shader variant constants (`#ifndef`)
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
I'm don't think that this is the right approach with the apps. I think that
each app should be its own project. See the branch I linked in the previous PR.
I
But that has no effect on previous JavaFX builds, I don't see a retroactive
value here.
>
oved the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psMath`
> * Moved the shader variant constants (`#ifndef`)
On Fri, 29 Jul 2022 21:48:00 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-p
On Fri, 17 Jun 2022 14:27:58 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/mai
On Fri, 17 Jun 2022 09:04:41 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/nativ
Now that we are using JDK 17, the SecurityManager is deprecated for
removal. JDK-8264139 [1] already suppressed the warnings, but we should
probably start looking at replacements as there are ~200 affected files.
What is the plan going forward?
[1] https://bugs.openjdk.org/browse/JDK-8264139
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions,
>> for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8289397: review
On Fri, 8 Jul 2022 19:00:25 GMT, Andy Goryachev wrote:
> Fixes warnings generated by the latest Eclipse:
> method is overriding a synchronized method without being synchronized
I'm not familiar with the code here, but it should be checked if the overriding
method should actually be
In my opinion, each JDK version should be evaluated according to its
benefits to JavaFX and not according to LTS, which is a foreign concept to
OpenJDK.
The JDK moved to a 6 months release plan so it can innovate faster without
waiting several years to release an important feature, and if we go
Why is the bump to JDK 17 and not 18? In 18 the feature for Code Snippets
in Java API Documentation was added and it could be useful for any new API.
Is the plan to continue to pump the minimum version with every release or
once in several? Does it depend on the benefit the new features add?
On
On Mon, 11 Jul 2022 22:44:41 GMT, Andy Goryachev wrote:
>> - added missing hashCode() methods
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8289389: minimize the impact of collision
Except for one case, looks good. I
On Mon, 11 Jul 2022 22:40:29 GMT, Andy Goryachev wrote:
>> In order to reduce collisions, the hash of each component is typically added
>> to `h * 31` even when that hash is 0, whereas you skip the `h = 31 * h` in
>> the case of null. It might not be a problem in practice, since value and
>>
On Mon, 18 Jul 2022 21:50:00 GMT, Andy Goryachev wrote:
>> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE.
>>
>> This warning should be reclassified as an error, as it catches bugs missed
>> by javac. In this case, the following places seem to contain bugs:
>> -
On Fri, 8 Jul 2022 20:31:31 GMT, Andy Goryachev wrote:
> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE.
>
> This warning should be reclassified as an error, as it catches bugs missed by
> javac. In this case, the following places seem to contain bugs:
> -
>
On Sat, 16 Jul 2022 13:24:22 GMT, John Hendrikx wrote:
> Fix small error in flatmap docs
If we bump to Java 18 we would be able to use [JEP 413: Code Snippets in Java
API Documentation](https://openjdk.org/jeps/413) and avoid these errors :)
-
PR:
naged to reproduce the runtime error by using an application that
uses fonts. If you know what the Mac/Linux-specific folders are, I will add
them to my classpath and see if everything works for me.
On Fri, Jul 15, 2022 at 10:34 PM Nir Lisker wrote:
> Ah, I missed that it's during runtime. When I rev
;1. The classes in build/gensrc/ generate a runtime exception, not a
>build error. I wonder if perhaps we should add an entry to the library
>path instead. Let me check on this.
>
>
>
>1. Again, Jeanette’s report was about runtime error. I wonder though
>if w
I am not in favor of this change. There are platform-specific parts of the
> build, so IDEs should be able to adapt to this.
>
> -- Kevin
>
>
>
>
>
> What do you think?
>
>
>
> -andy
>
>
>
>
>
>
>
> *From: *openjfx-dev
> on behalf of
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue
On Thu, 14 Jul 2022 23:55:52 GMT, Kevin Rushforth wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue
What resource is the error on?
On Fri, Jul 15, 2022 at 1:19 PM Jeanette Winzenburg
wrote:
>
> Zitat von Nir Lisker :
>
> Hi Nir,
>
> thanks for the explanation - though I have no idea why Eclipse wants
> them (see them again after re-adding as source folders and al
the source
folders list in the build path, so I don't know why you would get this
error. Nothing in the "main" source folders references these in compile- or
build-time.
On Fri, Jul 15, 2022 at 12:51 PM Nir Lisker wrote:
> The Eclipse project files were updated recently in
> https://github
The Eclipse project files were updated recently in
https://github.com/openjdk/jfx/pull/804. The OS-specific folders were
removed. I tested it and I had no issue after this change. On what resource
are you getting this error?
On Fri, Jul 15, 2022 at 12:44 PM Jeanette Winzenburg <
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I personally disabled the "does not override method in a different package"
warning. The synthetic methods
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I turned on errors on missing `@Override` annotations. I got over 1k errors. I
think it's worth fixing it in
On Wed, 13 Jul 2022 07:35:06 GMT, John Hendrikx wrote:
> These compiler warning settings are more than likely just a left over from
> the days before `@Override` existed.
My thoughts as well. `@Override` was added in 1.5. I think this warning was
added prior.
-
PR:
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I've finished an analysis of a few of the cases here. After checking the
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
I haven't had time to look at this one yet. Will do so later today or tomorrow.
-
PR:
On Wed, 6 Jul 2022 18:52:08 GMT, Andy Goryachev wrote:
> - fixed varargs
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/816
Hi,
Is it intended for this issue to go into 19? If so, we need to figure out
the new memory management model quickly. If not, I take it that we are
happy for now with the unspecified behaviors and specify them later.
Nir
There was a previous implementation discussion that touched on some of the
points here in https://github.com/openjdk/jfx/pull/108
I think there are a few (semi-)independent points here:
1. Order of listeners: as John said, there is no specification of the order
of listeners, but the
On Fri, 8 Jul 2022 22:27:52 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>>
>> the list of eclipse projects that do compile in Eclipse as a result of this
>> PR are:
>> - base
>> - controls
>> - fxml
On Fri, 8 Jul 2022 23:45:58 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8289389: toExternalForm()
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CalculatedValue.java
> line
On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev wrote:
> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private
modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/BaseShaderGraphics.java
line 92:
> 90:
On Mon, 27 Jun 2022 23:47:21 GMT, Kevin Rushforth wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>>
>> the list of eclipse projects that do compile in Eclipse as a result of this
>> PR are:
>> - base
>> - controls
>> - fxml
On Fri, 8 Jul 2022 18:47:49 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>>
>> the list of eclipse projects that do compile in Eclipse as a result of this
>> PR are:
>> - base
>> - controls
>> - fxml
On Fri, 8 Jul 2022 20:11:22 GMT, Andy Goryachev wrote:
> trivial change, removed unnecessary code.
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/822
Vote: YES
On Fri, Jul 8, 2022 at 8:37 PM Kevin Rushforth
wrote:
> I hereby nominate Marius Hanl [1] to OpenJFX Committer.
>
> Marius is an OpenJFX community member, who has contributed 22 commits
> [2] to OpenJFX.
>
> Votes are due by July 22, 2022 at 13:00 UTC.
>
> Only current OpenJFX
Vote: YES
On Fri, Jul 8, 2022 at 8:39 PM Kevin Rushforth
wrote:
> I hereby nominate Michael Strauß [1] to OpenJFX Committer.
>
> Michael is an OpenJFX community member, who has contributed 16 commits
> [2] to OpenJFX.
>
> Votes are due by July 22, 2022 at 13:00 UTC.
>
> Only current OpenJFX
On Thu, 7 Jul 2022 22:26:17 GMT, Andy Goryachev wrote:
> No, my workspace (jfx) was imported as a gradle project. I think it created a
> bunch of .project and .classpath files that never worked - I could not get
> them to compile. I had to reset all of them
That's what I wrote in the
On Thu, 7 Jul 2022 02:31:54 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 27 addi
On Thu, 7 Jul 2022 20:37:29 GMT, Andy Goryachev wrote:
> This PR does not fix apps/ project. In fact, I think .project in apps/ should
> be removed, and instead we should create individual projects, either for a
> group (i.e. samples, toys), or for each application (i.e. Robot, 3DViewer).
>
>
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Thu, 7 Jul 2022 20:47:41 GMT, Andy Goryachev wrote:
> Let me see what it would take to create individual projects for toys and such.
You can look at my branch, it does exactly that, and I added all the module
reads/exports (unless something changed).
-
PR:
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 6 Jul 2022 21:38:36 GMT, Andy Goryachev wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 6 Jul 2022 18:12:42 GMT, Andy Goryachev wrote:
> - removed unused method
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/814
On Wed, 6 Jul 2022 18:16:02 GMT, Andy Goryachev wrote:
> - changed initialization sequence
Marked as reviewed by nlisker (Reviewer).
-
PR: https://git.openjdk.org/jfx/pull/815
On Fri, 1 Jul 2022 15:16:24 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>
On Tue, 5 Jul 2022 18:49:40 GMT, Andy Goryachev wrote:
>> 1. The way the apps are structured is that each app is its own project,
>> which means that there are many new projects to create and configure. It can
>> be a bit of work, though I have done it in my branch already. If you want to
>>
On Tue, 5 Jul 2022 19:02:20 GMT, Andy Goryachev wrote:
>> FWIW, the only test in `modules/javafx.swing/src/test/java` was removed by
>> [JDK-8234110](https://bugs.openjdk.org/browse/JDK-8234110). While we could
>> put in a dummy test class, the nature of the javafx.swing module is that
>>
On Sat, 12 Mar 2022 04:57:37 GMT, Michael Strauß wrote:
> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
> some edge cases.
>
> 1. `removeAll(c)`:
> This is a no-op if 'c' is empty.
> For `ObservableListWrapper`, returning early skips an object allocation. For
>
On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev wrote:
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
I found my branch that was dealing with the Eclipse files update:
On Fri, 1 Jul 2022 12:16:36 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does
On Tue, 28 Jun 2022 15:29:41 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does
On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev wrote:
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
I scheduled to review this today or tomorrow.
-
PR: https://git.openjdk.org/jfx/pull/804
On Tue, 28 Jun 2022 00:13:40 GMT, Andy Goryachev wrote:
> I would definitely volunteer to review the remaining changes (once I
> accumulate enough karma).
Maybe that's the trick. If I make the changes, it requires another Reviewer to
allow me to merge, and there were (are?) no volunteers. If
On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev wrote:
> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files
> - fixed gradlew to use UTF-8 encoding
There is already an open issue for this in
On Tue, 28 Jun 2022 16:56:27 GMT, Marius Hanl wrote:
>> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line
>> 351:
>>
>>> 349: public static ObservableList observableArrayList(E...
>>> items) {
>>> 350: ArrayList backingList = new
On Tue, 28 Jun 2022 15:29:41 GMT, Marius Hanl wrote:
>> This simple PR optimizes the observable `ArrayList` creation by using the
>> ArrayList constructor/array size so that the underlying array will be
>> initialized at the correct size which will speed up the creation as the
>> array does
[
https://issues.apache.org/jira/browse/SUREFIRE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nir Lisker updated SUREFIRE-2093:
-
Description:
pom:
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://w
Nir Lisker created SUREFIRE-2093:
Summary: --enable-preview is not recognized
Key: SUREFIRE-2093
URL: https://issues.apache.org/jira/browse/SUREFIRE-2093
Project: Maven Surefire
Issue Type
[
https://issues.apache.org/jira/browse/SUREFIRE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nir Lisker updated SUREFIRE-2093:
-
Description:
pom:
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://w
gt; It's not binary compatible, as changing the return type results in a
> >> new method that compiled code won't be able to find.
> >>
> >> See also "change result type (including void)" here:
> >>
> https://wiki.eclipse.org/Evolving_Java-based_
Hi,
Picking up an old issue, JDK-8091393 [1], I went ahead and looked at the
work needed to implement it.
keySet() and entrySet() can both be made to return ObservableSet rather
easily. values() will probably require an ObservableCollection type.
Before discussing these details, my question is:
On Fri, 6 May 2022 14:13:55 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-pri
On Mon, 25 Apr 2022 11:47:45 GMT, Nir Lisker wrote:
> Update the the test utility. Includes:
> * Refactoring since there is no more need the split pre- and post-attenuation
> and light types.
> * Added customizable material to the `Boxes` to test the interaction between
> light
On Fri, 6 May 2022 14:09:13 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/nativ
On Fri, 6 May 2022 14:21:58 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-p
moved the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump?).
> * `Mtl1PS` and `psMath`
> * Moved the shader variant constants (`#ifndef`)
Refactoring and renaming changes to some of the D3D pipeline files and a few
changes on the Java side. These are various "leftovers" from previous issues
that we didn't want to touch at the time in order to confine the scope of the
changes. They will make future work easier.
Since there are
here
> > already.
> >
> >
> https://bugs.openjdk.java.net/browse/JDK-8090548?focusedCommentId=13771150=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13771150
> >
> > On Tue, Apr 26, 2022 at 4:25 AM Nir Lisker wrote:
> >
> >> Hi,
> >>
> &
changed.
>
> Note that GitHub decided to count the removal of the `AttenLightingSample`
> and addition of the `Controls` file as renaming. The sample is now run now
> only through `LightingSample`.
Nir Lisker has updated the pull request incrementally with one additional
commit sin
changed.
>
> Note that GitHub decided to count the removal of the `AttenLightingSample`
> and addition of the `Controls` file as renaming. The sample is now run now
> only through `LightingSample`.
Nir Lisker has updated the pull request incrementally with one additional
commit s
On Wed, 27 Apr 2022 14:01:06 GMT, Nir Lisker wrote:
> Updated the README link to match the CONTRIBUTING link.
This pull request has now been integrated.
Changeset: d69a498c
Author: Nir Lisker
URL:
https://git.openjdk.java.net/jfx/commit/d69a498c2cde73339bc99e6c02c0d47fe4b1b650
St
Updated the README link to match the CONTRIBUTING link.
-
Commit messages:
- Fixed link
Changes: https://git.openjdk.java.net/jfx/pull/788/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=788=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8285725
Stats: 1 line in 1
me filtered list of issues that
> CONTRIBUTING.md links to.
>
> -- Kevin
>
>
> On 4/26/2022 8:54 PM, Nir Lisker wrote:
> > In the README.md, under Issue Tracking, the link to "issues list" leads
> to
> > the JBS homepage. In CONTRIBUTING.md under Bug Report,
In the README.md, under Issue Tracking, the link to "issues list" leads to
the JBS homepage. In CONTRIBUTING.md under Bug Report, the (almost) same
paragraph links to the JavaFX filter in JBS, which is a lot more helpful.
Shouldn't the link in README also link to the filtered issues list?
- Nir
#comment-13771150
On Tue, Apr 26, 2022 at 4:25 AM Nir Lisker wrote:
> Hi,
>
> Using the updated lighting test sample [1], I found some odd behavior with
> regards to PhongMaterial:
>
> 1. The effect of the opacity (alpha channel) of a self-illumination map is
> not documented, b
Hi,
Using the updated lighting test sample [1], I found some odd behavior with
regards to PhongMaterial:
1. The effect of the opacity (alpha channel) of a self-illumination map is
not documented, but lowering its value makes the object darker. I looked at
the pixel shader [2] and only the rgb
Update the the test utility. Includes:
* Refactoring since there is no more need the split pre- and post-attenuation
and light types.
* Added customizable material to the `Boxes` to test the interaction between
lights and materials..
* Light colors can now be changed.
Note that GitHub decided
On Thu, 18 Nov 2021 21:38:28 GMT, Kevin Rushforth wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>
On Mon, 21 Mar 2022 08:59:34 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>
On Fri, 18 Mar 2022 09:55:30 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 146:
>>
>>> 144: * Creates an {@code ObservableValue} that holds the result of
>>> applying a
>>> 145: * mapping on this {@code
On Fri, 18 Mar 2022 23:55:36 GMT, Michael Strauß wrote:
>> I've changed this to use your wording as I think it does read much better.
>>
>> Perhaps also possible:
>>
>> Creates a new {@code ObservableValue} that holds the value of a nested
>> {@code ObservableValue} supplied
>> by
On Fri, 18 Mar 2022 09:32:18 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/FlatMappedBinding.java
>> line 68:
>>
>>> 66: };
>>> 67: }
>>> 68: }
>>
>> Several files are missing newlines after the last closing brace. Do we
>> enforce this?
>>
>>
On Fri, 18 Mar 2022 09:48:39 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/Subscription.java
>> line 67:
>>
>>> 65: */
>>> 66: default Subscription and(Subscription other) {
>>> 67: Objects.requireNonNull(other);
>>
>> This exception
On Thu, 10 Mar 2022 17:49:38 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>
On Thu, 10 Mar 2022 05:44:35 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>
On Tue, 8 Mar 2022 21:03:12 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix wrong test values
>
> modules/javafx.base/src/tes
On Thu, 27 Jan 2022 21:49:07 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>
action.
>
> -- Kevin
>
>
> On 2/9/2022 7:11 AM, Nir Lisker wrote:
> > Hi,
> >
> > When reviewing the docs changes to TabPane, I saw that some properties
> > mention the CSS that is related to them. I was wondering if we could
> > standardize it thro
601 - 700 of 1528 matches
Mail list logo
