Re: Review Request 25848: Introducing mesos modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54955 --- include/mesos/module.hpp.in

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2135

See

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #366

See

Jenkins build is back to normal : mesos-reviewbot #1770

See

Re: Review Request 26163: Fixed AllocatorTest.SlaveLost test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26163/#review54948 --- Patch looks great! Reviews applied: [26163] All tests passed. - M

Re: Review Request 26163: Fixed AllocatorTest.SlaveLost test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26163/#review54947 --- Ship it! Ship It! - Ben Mahler On Sept. 30, 2014, 2:46 a.m., Vin

Re: Review Request 26159: Fixed framework logging in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26159/#review54943 --- Patch looks great! Reviews applied: [26159] All tests passed. - M

Review Request 26163: Fixed AllocatorTest.SlaveLost test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26163/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1844 https://issues.ap

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review54937 --- Bad patch! Reviews applied: [25261] Failed command: git apply --in

Re: Review Request 26152: Remove unused stout tuples/ folder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26152/#review54936 --- Ship it! Thank you. The subject threw me off a bit since it says st

Re: Review Request 26152: Remove unused stout tuples/ folder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26152/#review54933 --- Patch looks great! Reviews applied: [26152] All tests passed. - M

Review Request 26159: Fixed framework logging in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26159/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

Re: scheduler.killExecutor()

Adding a shutdownExecutor() driver call has been discussed before. https://issues.apache.org/jira/browse/MESOS-330 As a work around, have you considered sending a special "kill" task as a signal to the executor to commit suicide? On Mon, Sep 29, 2014 at 5:27 PM, Tom Arnfeld wrote: > Hi, > > I

Re: Review Request 26150: Libprocess Benchmark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/#review54927 --- Patch looks great! Reviews applied: [26150] All tests passed. - M

scheduler.killExecutor()

Hi, I've been making some modifications to the Hadoop framework recently and have come up against a brick wall. I'm wondering if the concept of killing an executor from a framework has been discussed before? Currently we are launching two tasks for each Hadoop TaskTracker, one that has a bit of C

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2133

See Changes: [vinodkone] Fixed AllocatorTest.FrameworkExited test. [vinodkone] Remove depreacted webui_hostname and webui_port fields from SlaveInfo. -- [...trunc

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26133/#review54925 --- The changes all look good to me structurally. Leaving Ship It's for

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2132

bumped up the inactive timeout from 10min to 30 min to account for build slowness. On Mon, Sep 29, 2014 at 4:48 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2132/changes > > > > Changes: > > [bm

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2131

OP_AUTHZID == true > I0929 19:27:33.712818 6613 authenticator.hpp:376] Authentication success > I0929 19:27:33.712877 6614 authenticatee.hpp:305] Authentication success > I0929 19:27:33.712890 6613 master.cpp:3777] Successfully authenticated > principal 'test-principal' at

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2132

See Changes: [bmahler] Increased the store timeout for the Registrar tests. [dhamon] Switch [stout] to using compiler intrinsics for unreachable, exit, and abort [dhamon] Switch [libprocess] to using co

Re: Review Request 26147: Remove non-variadic strings::format() implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review54920 --- Patch looks great! Reviews applied: [26147] All tests passed. - M

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/ --- (Updated Sept. 29, 2014, 11:26 p.m.) Review request for mesos, Adam B, Benjamin

MESOS-1739 Design Document: Allow slave reconfiguration on restart

I've been working on: MESOS-1739 [1]. Vinod requested that I write up a design document for the changes that will be needed [2]. I'd appreciate any additional comments / review. Cody [1] https://issues.apache.org/jira/browse/MESOS-1739 [2] https://docs.google.com/document/d/1PWv7YIdV3nN2l1oUW7Nyb

Re: Review Request 25848: Introducing mesos modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54879 --- Style review. One high-level comment: the additional fields for aut

Review Request 26152: Remove unused stout tuples/ folder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26152/ --- Review request for mesos, Ben Mahler, Dominic Hamon, and Till Toenshoff. Reposi

Re: Review Request 26150: Libprocess Benchmark

> On Sept. 29, 2014, 9:41 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 139 > > > > > > I'd like to start using all the nice C++11 features, but not sure if we > > want to start intr

Re: Review Request 26150: Libprocess Benchmark

> On Sept. 29, 2014, 2:41 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, line 139 > > > > > > I'd like to start using all the nice C++11 features, but not sure if we > > want to start intr

Re: Review Request 26147: Remove non-variadic strings::format() implementation

> On Sept. 29, 2014, 2:13 p.m., Dominic Hamon wrote: > > we check in configure in mesos, not in stout. we'd have to bubble those > > c++11 checks down the stack through libprocess and into stout before we can > > responsibly deprecate this (and other) c++11 guards. > > Cody Maloney wrote: >

Re: Review Request 26150: Libprocess Benchmark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/#review54886 --- 3rdparty/libprocess/src/tests/benchmarks.cpp

Re: Review Request 26147: Remove non-variadic strings::format() implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/ --- (Updated Sept. 29, 2014, 9:40 p.m.) Review request for mesos, Benjamin Hindman

Review Request 26150: Libprocess Benchmark

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26150/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-1840 https://issue

Mesos OPW project

evelinad

Re: Review Request 26069: Introduce ClangFormat to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26069/#review54884 --- Patch looks great! Reviews applied: [26069] All tests passed. - M

Re: Review Request 26147: Remove non-variadic strings::format() implementation

> On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote: > > we check in configure in mesos, not in stout. we'd have to bubble those > > c++11 checks down the stack through libprocess and into stout before we can > > responsibly deprecate this (and other) c++11 guards. > > Cody Maloney wrote: >

Re: Review Request 26147: Remove non-variadic strings::format() implementation

On Mon, Sep 29, 2014 at 2:24 PM, Cody Maloney wrote: > > > > On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote: > > > we check in configure in mesos, not in stout. we'd have to bubble > those c++11 checks down the stack through libprocess and into stout before > we can responsibly deprecate this

Re: Review Request 26149: Remove depreacted webui_hostname and webui_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26149/#review54882 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2014, 9:01 p.m., Cod

Re: Review Request 26147: Remove non-variadic strings::format() implementation

> On Sept. 29, 2014, 9:13 p.m., Dominic Hamon wrote: > > we check in configure in mesos, not in stout. we'd have to bubble those > > c++11 checks down the stack through libprocess and into stout before we can > > responsibly deprecate this (and other) c++11 guards. We already use them in stout

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26133/ --- (Updated Sept. 29, 2014, 2:22 p.m.) Review request for mesos, Cody Maloney, Tim

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26133/ --- (Updated Sept. 29, 2014, 9:17 p.m.) Review request for mesos, Cody Maloney, Dom

Re: Review Request 25848: Introducing mesos modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/ --- (Updated Sept. 29, 2014, 5:16 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 26147: Remove non-variadic strings::format() implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/#review54876 --- we check in configure in mesos, not in stout. we'd have to bubble th

Re: Review Request 26144: Fixed AllocatorTest.FrameworkExited test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26144/#review54875 --- Ship it! src/tests/allocator_tests.cpp

Review Request 26149: Remove depreacted webui_hostname and webui_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26149/ --- Review request for mesos, Adam B and Vinod Kone. Repository: mesos-git Descri

Review Request 26147: Remove non-variadic strings::format() implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26147/ --- Review request for mesos and Dominic Hamon. Repository: mesos-git Description

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2131

890 6613 master.cpp:3777] Successfully authenticated principal 'test-principal' at slave(46)@67.195.81.189:39093 I0929 19:27:33.713059 6614 slave.cpp:735] Successfully authenticated with master master@67.195.81.189:39093 I0929 19:27:33.713119 6614 slave.cpp:998] Will retry registrati

Review Request 26144: Fixed AllocatorTest.FrameworkExited test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26144/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1782 https://issues.ap

Re: Review Request 24341: Added Java replicated log implementation of State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24341/#review54845 --- Ship it! src/java/jni/org_apache_mesos_state_LogState.cpp

Re: Review Request 25818: Switch path::join() to be variadic

> On Sept. 29, 2014, 5:21 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, line 34 > > > > > > Excuse my ignorance of variadic templates, but could one write > > path::join("/") or path:

Re: Review Request 26069: Introduce ClangFormat to Mesos.

> On Sept. 29, 2014, 6:17 a.m., Benjamin Hindman wrote: > > How much fine-tuning can we apply here? Between this and cpplint.py will we > > "cover" out style completely? Looking forward to helping make folks more > > productive but don't want to frustrate people that use this and then still >

Re: Review Request 25818: Switch path::join() to be variadic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review54852 --- Patch looks great! Reviews applied: [25818] All tests passed. - M

Re: Review Request 26069: Introduce ClangFormat to Mesos.

> On Sept. 29, 2014, 1:17 p.m., Benjamin Hindman wrote: > > support/clang-format, line 6 > > > > > > This is actually not "good", since the '{' is not on a newline. I guess > > this is just for checking the access modif

Mesos OPW project

Hi prospective OPW interns, I've been contacted by quite a few of you regarding "Mesos Getting Started & Documentation" OPW project. So, wanted to send out a list of starter tickets that you can work on. https://issues.apache.org/jira/browse/MESOS-1647 https://issues.apache.org/jira/browse/MESOS-

Fwd: Regarding OPW mesos project

Hi prospective OPW interns, I've been contacted by quite a few of you regarding "Mesos Getting Started & Documentation" OPW project. So, wanted to send out a list of starter tickets that you can work on. https://issues.apache.org/jira/browse/MESOS-1647 https://issues.apache.org/jira/browse/MESOS-

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 96-99 > > > > > > Why would the iterator be called `containerizer`? > > > > s/containerizer/iterator/ ? > > Dominic Ha

Re: Review Request 26069: Introduce ClangFormat to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26069/ --- (Updated Sept. 29, 2014, 6:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2397

https://reviews.apache.org/r/26141/ On Mon, Sep 29, 2014 at 11:14 AM, Benjamin Mahler wrote: > Looks like a stall of the disk FWICT, I will bump the store timeout up > from 5 seconds to 10 seconds to match the rest of our tests. > > On Sun, Sep 28, 2014 at 1:05 PM, Apache Jenkins Server < > jenk

Re: Review Request 26141: Increased the store timeout for the Registrar tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26141/#review54843 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2014, 6:30 p.m., Ben

Review Request 26141: Increased the store timeout for the Registrar tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26141/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 96-99 > > > > > > Why would the iterator be called `containerizer`? > > > > s/containerizer/iterator/ ? > > Dominic Ha

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2397

Looks like a stall of the disk FWICT, I will bump the store timeout up from 5 seconds to 10 seconds to match the rest of our tests. On Sun, Sep 28, 2014 at 1:05 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Sr

Re: Review Request 25818: Switch path::join() to be variadic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/ --- (Updated Sept. 29, 2014, 6:01 p.m.) Review request for mesos, Adam B and Domini

Re: Review Request 26100: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

> On Sept. 26, 2014, 9:54 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp, line 33 > > > > > > these should be ok not inline as they're member methods. Fixed in the latest patch

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/#review54828 --- Can you add a test that (at least) confirms the RTT values are non-z

Re: Review Request 26101: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26101/ --- (Updated Sept. 29, 2014, 5:23 p.m.) Review request for mesos, Ben Mahler and Do

Re: Review Request 26100: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26100/ --- (Updated Sept. 29, 2014, 5:22 p.m.) Review request for mesos, Ben Mahler and Do

Re: Review Request 26101: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

> On Sept. 27, 2014, 1:18 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [26100, 26101] > > > > Failed command: git apply --index 26101.patch > > > > Error: > > error: patch failed: 3rdparty/libprocess/src/process.cpp:1946 > > error: 3rdparty/libprocess/src/process.cpp:

Re: Review Request 26090: PortMappingIsolator: added support to include RTT and RTTvar in the statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26090/#review54824 --- Ship it! Looks great! A few style nits. Please update the review an

Re: Review Request 26101: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

> On Sept. 26, 2014, 6:18 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [26100, 26101] > > > > Failed command: git apply --index 26101.patch > > > > Error: > > error: patch failed: 3rdparty/libprocess/src/process.cpp:1946 > > error: 3rdparty/libprocess/src/process.cpp:

Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24537/#review54821 --- Could you add to the tests to cover this change in API? - Dominic H

Re: Review Request 24341: Added Java replicated log implementation of State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24341/#review54813 --- Patch looks great! Reviews applied: [24341] All tests passed. - M

Re: Review Request 25848: Introducing mesos modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54811 --- Ship it! I still think there will be revisions, but I'm good for ph

Re: Review Request 25848: Introducing mesos modules.

> On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote: > > src/module/manager.cpp, line 173 > > > > > > You could probably stick the json parsing into a separate sub-class. > > I'm all for breaking out a small JIRA

Re: Review Request 26069: Introduce ClangFormat to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26069/#review54806 --- How much fine-tuning can we apply here? Between this and cpplint.py

Re: Auto usage in mesos

> > (Perhaps you're thinking about: auto f(...) -> return_type { ... }) > Yes, I was referring to the use of auto as the return type in the function declaration, not (yet) for automatic deduction. Thanks for the clarification.

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/ --- (Updated Sept. 29, 2014, 12:45 p.m.) Review request for mesos, Ben Mahler and J

Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/ --- (Updated Sept. 29, 2014, 12:45 p.m.) Review request for mesos, Ben Mahler and J

Re: Review Request 24341: Added Java replicated log implementation of State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24341/ --- (Updated Sept. 29, 2014, 12:44 p.m.) Review request for mesos, Ben Mahler and J

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/ --- (Updated Sept. 29, 2014, 12:24 p.m.) Review request for mesos, Connor Doyle and

Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24537/ --- (Updated Sept. 29, 2014, 12:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 24341: Added Java replicated log implementation of State.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24341/ --- (Updated Sept. 29, 2014, 12:23 p.m.) Review request for mesos, Connor Doyle and

Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/ --- (Updated Sept. 29, 2014, 12:23 p.m.) Review request for mesos, Connor Doyle and

Re: Regarding adding as a contributor in apache mesos group

hello dev , , thanks for adding me to the contributors list, can you help me with https://issues.apache.org/jira/browse/MESOS-1622 , so that i can start working on moving code from .hpp to .cpp file. Can you please tell me where can I find the source code so that I can start making changes and try

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2130

See Changes: [tnachen] Added docker container prefix to docker docs. -- [...truncated 3279 lines...] byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/ref

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26133/#review54800 --- Patch looks great! Reviews applied: [26133] All tests passed. - M

Re: Review Request 26069: Introduce ClangFormat to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26069/#review54796 --- Patch looks great! Reviews applied: [26069] All tests passed. - M

Re: Review Request 26133: Modify configure.ac to fix --with-sasl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26133/ --- (Updated Sept. 29, 2014, 9:50 a.m.) Review request for mesos, Cody Maloney, Dom

Review Request 26133: Modify configure.ac to fix --with-sasl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26133/ --- Review request for mesos, Cody Maloney, Dominic Hamon, and Timothy Chen. Bugs:

Re: Review Request 26069: Introduce ClangFormat to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26069/ --- (Updated Sept. 29, 2014, 9:10 a.m.) Review request for mesos, Benjamin Hindman,