Re: git commit: Added text line coded and related unit tests

2013-04-07 Thread Emmanuel Lécharny
org.junit.Test; > + > +/** > + * A {@link TextLineDecoder} test. > + * > + * @author http://mina.apache.org";>Apache MINA Project > + */ > +public class WindowsTextLineDecoderTest { > + > +@Test > +public void testThatEmptyBufferReturnsEmptyResult() { > +TextLineDecoder decoder = new TextLineDecoder(LineDelimiter.WINDOWS); > +Context context = decoder.createDecoderState(); > +String[] results = decoder.decode(ByteBuffer.allocate(0), context); > +assertNotNull(results); > +assertEquals(0, results.length); > +} > + > +@Test > +public void testThatNonLineTerminatedStringReturnsEmptyResult() { > +TextLineDecoder decoder = new TextLineDecoder(LineDelimiter.WINDOWS); > +Context context = decoder.createDecoderState(); > +String[] results = decoder.decode(ByteBuffer.wrap("a > string".getBytes()), context); > +assertNotNull(results); > +assertEquals(0, results.length); > +assertEquals(8, context.getBuffer().position()); > +} > + > +@Test > +public void testThatUnixLineTerminatedStringReturnsEmptyResult() { > +TextLineDecoder decoder = new TextLineDecoder(LineDelimiter.WINDOWS); > +Context context = decoder.createDecoderState(); > +String[] results = decoder.decode(ByteBuffer.wrap("a > string\n".getBytes()), context); > +assertNotNull(results); > +assertEquals(0, results.length); > +assertEquals(9, context.getBuffer().position()); > +} > + > +@Test > +public void testThatWindowsLineTerminatedStringReturnsNonEmptyResult() { > +TextLineDecoder decoder = new TextLineDecoder(LineDelimiter.WINDOWS); > +Context context = decoder.createDecoderState(); > +String[] results = decoder.decode(ByteBuffer.wrap("a > string\r\n".getBytes()), context); > +assertNotNull(results); > +assertEquals(1, results.length); > +assertEquals("a string", results[0]); > +assertEquals(0, context.getBuffer().position()); > +} > + > +@Test > +public void testThatContextIsMaintainedBetweenMessages() { > +TextLineDecoder decoder = new TextLineDecoder(LineDelimiter.WINDOWS); > +Context context = decoder.createDecoderState(); > +String[] results = decoder.decode(ByteBuffer.wrap("a > string\r\na".getBytes()), context); > +assertNotNull(results); > +assertEquals(1, results.length); > +assertEquals("a string", results[0]); > +assertEquals(1, context.getBuffer().position()); > +results = decoder.decode(ByteBuffer.wrap(" string\r\n".getBytes()), > context); > +assertNotNull(results); > +assertEquals(1, results.length); > +assertEquals("a string", results[0]); > +assertEquals(0, context.getBuffer().position()); > +} > + > +@Test > +public void testThatUnixLineTerminatedLongStringReturnsEmptyResult() { > +TextLineDecoder decoder = new TextLineDecoder(LineDelimiter.WINDOWS); > +Context context = decoder.createDecoderState(); > +StringBuffer sb = new StringBuffer(); > +for(int i=0; i < 100;++i) { > +sb.append("a string"); > +} > +String[] results = decoder.decode(ByteBuffer.wrap((sb.toString() + > "\n").getBytes()), context); > +assertNotNull(results); > +assertEquals(0, results.length); > +assertEquals(801, context.getBuffer().position()); > +} > + > +@Test > +public void > testThatWindowsLineTerminatedLongStringReturnsNonEmptyResult() { > +TextLineDecoder decoder = new TextLineDecoder(LineDelimiter.WINDOWS); > +Context context = decoder.createDecoderState(); > +StringBuffer sb = new StringBuffer(); > +for(int i=0; i < 100;++i) { > +sb.append("a string"); > +} > +String[] results = decoder.decode(ByteBuffer.wrap((sb.toString() + > "\r\n").getBytes()), context); > +assertNotNull(results); > +assertEquals(1, results.length); > +assertEquals(sb.toString(), results[0]); > +assertEquals(0, context.getBuffer().position()); > +} > +} > -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] Some points

2013-04-08 Thread Emmanuel Lécharny
behavior. Would the Builder pattern more accurate ? Not sure. The session might change, as we store attributes into it.Jeff -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] Some points

2013-04-08 Thread Emmanuel Lécharny
Le 4/8/13 6:20 PM, Jeff MAURY a écrit : > On Mon, Apr 8, 2013 at 6:04 PM, Emmanuel Lécharny wrote: > >> Le 4/8/13 5:46 PM, Jeff MAURY a écrit : >> >>> 2) Session objects are not immutable >>> I noticed that session objects (assigned to clients and servers

Re: Request for the tutorial link

2013-04-09 Thread Emmanuel Lécharny
Le 4/9/13 11:10 AM, Pramila V a écrit : > Hi, > > I need a tutorial link to test the SSHD server & client. Easy. http://mina.apache.org/sshd-project/documentation.html -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Request for the tutorial link

2013-04-09 Thread Emmanuel Lécharny
Le 4/9/13 11:54 AM, Pramila V a écrit : > Hi, > > I would like to download the below source. > > https://github.com/apache/mina-sshd > > request you to provide the exact link to download. This is the exact link to download the source. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Request for the tutorial link

2013-04-09 Thread Emmanuel Lécharny
rdingFilter forwardingFilter) > { > ^ > > Request you to help us how to proceed. This is a bug in trunk. Due to the way Windows handles file on disk (ie, case insensitive), we comitted some classes which names were in lower case, when Java is expecting UpperCase. That will be fixed soon. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Request for the tutorial link

2013-04-09 Thread Emmanuel Lécharny
u should check on the web site before asking here... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Request for the tutorial link

2013-04-09 Thread Emmanuel Lécharny
Le 4/9/13 3:33 PM, Emmanuel Lécharny a écrit : > Le 4/9/13 11:40 AM, Pramila V a écrit : >> Hi, >> Thanks for the reply. I have downloaded the SshServer.java, SshClient.java. >> I downloaded all the respective lib files. I configured the port in >> SshServer.java file &a

Re: Avoiding git merge commit

2013-04-10 Thread Emmanuel Lécharny
Le 4/10/13 4:04 PM, Andrew Cagney a écrit : > git config --global branch.autosetuprebase always > > is meant to act as a safety net I start to regret the migration to git ;-) -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-04-18 Thread Emmanuel Lécharny
Le 4/18/13 10:19 AM, Julien Vermillard a écrit : > Hi, > > Since udp support landed in mina 3, what would be be the missing bits > before starting a M1 vote ? We need to implement the UDP client. This is probably the missing bit. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-04-18 Thread Emmanuel Lécharny
fore M1. I think we have made some progress last week, but we need better tests and most certainly some code review. Lack of time on my side this week... We can also consider that SSL is for M2 at this point. Milestone are just a way to make baby steps toward the first RC. -- Regards, Cordial

Re: [MINA3] M1?

2013-04-18 Thread Emmanuel Lécharny
Le 4/18/13 11:54 AM, Alex Karasulu a écrit : > On Thu, Apr 18, 2013 at 11:36 AM, Emmanuel Lécharny > wrote: > >> Le 4/18/13 10:19 AM, Julien Vermillard a écrit : >>> Hi, >>> >>> Since udp support landed in mina 3, what would be be the missing bits >

Re: [MINA3] M1?

2013-04-18 Thread Emmanuel Lécharny
s would be full TCP and UDP support on both sides (client and server). Of course, it will be a milstone, so don't have any expectation on the API stability or whatever... My 2cts... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-04-18 Thread Emmanuel Lécharny
Le 4/18/13 2:24 PM, Julien Vermillard a écrit : > Hi, > > On Thu, Apr 18, 2013 at 1:04 PM, Emmanuel Lécharny wrote: > >> Le 4/18/13 11:04 AM, Julien Vermillard a écrit : >>> So a M1 could be : a UDP client and some more test ? >> I would not phrase it this way. We

[MINA 3] SSL and fragmentation

2013-05-03 Thread Emmanuel Lécharny
Hi guys, the way we handle incomming SSL data on the server will not work if the data are fragmented. Let's say we are receiving some Handshake data. This is typically a few hundreds of bytes, that usually comes in one block. In this case, we are all good. But if those data aren't read in one blo

Re: [MINA 3] SSL and fragmentation

2013-05-03 Thread Emmanuel Lécharny
the newly read data. In any case, we have some copy... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA 3] SSL and fragmentation

2013-05-03 Thread Emmanuel Lécharny
Le 5/3/13 4:45 PM, Jeff MAURY a écrit : > On Fri, May 3, 2013 at 3:47 PM, Emmanuel Lécharny wrote: > >> Le 5/3/13 3:40 PM, Jeff MAURY a écrit : >>> +1 >>> >>> I think we shall rewrite the code and let be driven by the underlying >>> SSLengine status

Re: MINA 3.0 Thrift and Protobuf support

2013-05-04 Thread Emmanuel Lécharny
us a bit of time to review the code. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: commit

2013-05-04 Thread Emmanuel Lécharny
pukk request to the JIRA. Thanks ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [3.0] Would we need CumulativeProtocolDecoder?

2013-05-04 Thread Emmanuel Lécharny
could be used upfront by the application (see [MINA 3] codec api discussion). Does it fits what you need ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: MINA 3.0 Thrift and Protobuf support

2013-05-05 Thread Emmanuel Lécharny
f (and "vice versa"). Absoluty. This deserves 2 modules. > > I would be definitively better than the current java serialization > codec bothering everybody on android ! The current Mina 2.0 serialization codec is a hack anyway... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [3.0] Would we need CumulativeProtocolDecoder?

2013-05-05 Thread Emmanuel Lécharny
for LDAP, Kerberos, DHCP, DNS, NTP...) I would not be too concerned about that as soon as we have a decent documentation for MINA 3 (and looking back to what we offered in MINA 1 and 2, that would be a great change !). -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

[MINA 3] SSL working session : a feedback

2013-05-05 Thread Emmanuel Lécharny
ean-François, did I summarized the discussion we had accurately ? Thanks ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Emmanuel Lécharny
ssion, so anything being sent should go through the SslEngine. Until the handshake is processing, we should wait and not send any data. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Emmanuel Lécharny
o the specification : " Zero-length fragments of Application data MAY be sent as they are potentially useful as a traffic analysis countermeasure." (http://www.rfc-editor.org/rfc/rfc5246.txt, 6.2.1, paragraph before the last one) -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Emmanuel Lécharny
encrypt the encypted part, as the remote peer is already expecting some more data (BUFFER_UNDERFLOW) as the TLS data packet has not been completely received. The remaining part of message1 though will be encypted using cipher2. At least, this is how I interpret the specification. -- Regards, Co

Re: CoAP

2013-05-07 Thread Emmanuel Lécharny
w mina/coap module, I'm not sure of the > vast audience for here this code, but it can make a nice UDP test case > for mina. Go for it. Q : did you had to write an UDP client ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: MINA 3.0 Thrift and Protobuf support

2013-05-09 Thread Emmanuel Lécharny
Le 5/9/13 5:17 PM, Julien Vermillard a écrit : > What do you think of having the two modules (thrift and protobuff) > dicrectly at the root of the project and not in a serialization > intermediate module ? > That would reduce pom hierarchy/maintenance. My +1 -- Regards, Cordialeme

Re: DefaultAttributeContainer locks ?

2013-05-11 Thread Emmanuel Lécharny
which is way too high in most of the case). I would initialize the ConcurrentHashMap with a concurrencyLevel equal to the number of threads used to process the incoming data. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: eclipsecon france mina hackaton ?

2013-05-13 Thread Emmanuel Lécharny
and want to join us for a beer or coding some mina > stuff you are welcome. What if I decide to join you for the 2 days, will I get a place to get some Thread.sleep(14400) ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Secured/Unsecured events ?

2013-05-14 Thread Emmanuel Lécharny
in case of re-handshake, the application can now be > notified. That's a good use case. > By the way, do you know how the critical flag is given back by the > SLLEngine ? My understanding is that the close alert results in the SSLEngine to change the SSLEngineResult status to CLOSED. -

Re: Secured/Unsecured events ?

2013-05-14 Thread Emmanuel Lécharny
Le 5/14/13 11:35 AM, Jeff MAURY a écrit : > On Tue, May 14, 2013 at 9:47 AM, Emmanuel Lécharny wrote: > >> Le 5/13/13 10:30 PM, Jeff MAURY a écrit : >>> Hi, >>> >>> As I'm reading the TLS specs, I noticed that the processing of the close >>&

Re: [MINA3] M1?

2013-05-19 Thread Emmanuel Lécharny
o deliver a BioUdpServer and a BioTcpServer anyway. (and the client too). That would be a great addition to a first milestone, but if it's not ready, we can add it for M2. Thanks Julien ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-05-19 Thread Emmanuel Lécharny
na3]ClientVs[Netty4|Netty3|Mina3]Server[Tcp|Udp]BenchmarkBinaryTest. Those new classes just have to reference the correct type defined in the BenchmarkFactory. Thanks a lot of the help ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-05-19 Thread Emmanuel Lécharny
Le 5/19/13 6:48 PM, Emmanuel Lécharny a écrit : > Le 5/19/13 6:27 PM, Norman Maurer a écrit : >> If you explain me how to do I can even take care ;) > This is pretty simple :) > > The code is in http://svn.apache.org/repos/asf/mina/mina/trunk/benchmarks/ > > we have benchma

Re: [MINA3] M1?

2013-05-19 Thread Emmanuel Lécharny
Le 5/19/13 6:48 PM, Julien Vermillard a écrit : > I mean the Mina UDP test which use Netty as client and replace it by the > Mina client. We need both anyway... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: MINA 3.0 JDK7+ only ?

2013-05-20 Thread Emmanuel Lécharny
is EOL since last year. However, many people are still using it. I wonder if we should create 2 versions of MINA, one which support Java 6 and the other one that supports Java 7 ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Sonar

2013-05-20 Thread Emmanuel Lécharny
lt; 8) | ((input.get() & 0xff)); where input is a ByteBuffer can be replaced with : return input.getInt() (in RawInt32) -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Dubious code in SslHelper...

2013-05-20 Thread Emmanuel Lécharny
rap method and increase the buffer size accordingly instead. Thoughts ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-05-21 Thread Emmanuel Lécharny
Le 5/21/13 11:01 AM, Jeff MAURY a écrit : > I think that Netty 4 is not yet releases (4.0.0.CR3 and not 4.0.0.Final). > So I think we should keep Netty3 tests. We should keep them, but add some Netty4 tests. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Dubious code in SslHelper...

2013-05-21 Thread Emmanuel Lécharny
Le 5/21/13 1:19 PM, Jeff MAURY a écrit : > Which branch are you talking about ? trunk or ssl-experiment ? Trunk. ssl-experiment is a dead branch. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Dubious code in SslHelper...

2013-05-21 Thread Emmanuel Lécharny
Le 5/21/13 1:32 PM, Jeff MAURY a écrit : > For me, SSL code in trunk is just garbage and we should merge > ssl-experiment into trunk A... Ok, just do that then ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: NIO UDP server, does it make sense at all ?

2013-05-24 Thread Emmanuel Lécharny
ce for him (through some configuration, like we default to BIO for both TCP and UDP, unless the user explicitely requests to use NIO). Does it sounds sane ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

[MINA 3] UDP benchmarks feedback

2013-05-28 Thread Emmanuel Lécharny
itten, for the pain of the users :/ Working on it. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA 3] UDP benchmarks feedback

2013-05-28 Thread Emmanuel Lécharny
Sorry, one slight mistake I tested with 1M messages, not 1G ! Le 5/28/13 3:55 PM, Emmanuel Lécharny a écrit : > Hi guys, > > as Juien has coded the UDP client, I was able to run the benchmarks, so > here are the results (dne on an old linux ox with a Java 7 jdk) > > All the t

Re: [MINA 3] UDP benchmarks feedback

2013-05-28 Thread Emmanuel Lécharny
Le 5/28/13 4:50 PM, Jeff MAURY a écrit : > Emmanuel, > > are the Linux tests run on a VM or on a native Linux box ? Native box : Ubunty 12.04, Intel Pentium 3Ghz, 1Gb, 6 years old computer. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: NIO UDP server, does it make sense at all ?

2013-05-30 Thread Emmanuel Lécharny
Le 5/30/13 9:30 PM, Julien Vermillard a écrit : > lazy consensus ? :) Well, right now, I would rather keep it. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Minackathon feedback

2013-06-08 Thread Emmanuel Lécharny
with a BIO based server. I'm not sure that we have a big performance penalty with Java 7. Java 7 is way better than Java 6 in the way it handles buffers too. There is no reason to use Java 6 those days, it's dead anyway. It would be interesting to benchmark Java 8 to see what it brin

Re: Minackathon feedback

2013-06-09 Thread Emmanuel Lécharny
Note that the message size does not make any difference here, even with 10 bytes messages we get the system CPU jumpning to 85%. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-06-09 Thread Emmanuel Lécharny
Le 6/9/13 6:50 PM, Jeff MAURY a écrit : > Yes, > > > ​New ssl handshake code has been merged Sure, we can. We will have to prepare the module that generates the package though. Let me give it a try tonite. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: CCC support in FTP Server requires changes to Mina's SslFilter?

2013-06-11 Thread Emmanuel Lécharny
nd suggestions, whether > or not I'm way off track, and if this is something that can be fully > integrated into Mina and the FTP server. Many thanks for thsoe suggestions ! It's funny because we have had a long discussion last week about how to handle SSL closure, as we are working on the SSL handling for MINA 3. I guess we have to spend some time on this aspect for MINA 2 too... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: mina receive

2013-06-14 Thread Emmanuel Lécharny
bit more information aboyt what is your problem ? Your description is extremely light... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Codecs and CumulativeByteBuffer

2013-06-16 Thread Emmanuel Lécharny
tween p0 and p1. Then it > becomes a bit complicated to define the behaviour of position(int) > when a call to position(p0) is done. We just need to implement the slice() method in the IoBuffer to offer the kind of features you expect. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Codecs and CumulativeByteBuffer

2013-06-17 Thread Emmanuel Lécharny
mall thing to consider though : the length might be split, too... So all in all, whatever use case, it seems to me that IoBuffer covers all the needs. Do I missed something ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Codecs and CumulativeByteBuffer

2013-06-17 Thread Emmanuel Lécharny
Le 6/17/13 1:47 PM, Emmanuel Lécharny a écrit : > Le 6/17/13 1:32 PM, Raphaël Barazzutti a écrit : >> Hi Emmanuel, >> >> Thanks for your comments! >> >> I imagine that slice() method would have a behaviour similar to the >> one of ByteBuffer. As in Byte

Re: [MINA3] M1?

2013-06-20 Thread Emmanuel Lécharny
Le 6/20/13 10:25 PM, Julien Vermillard a écrit : > I commited the distribution module, bsicly it's hte one from MINA2. > > I think we are good ? I hope so ... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: MINA 3.0 JDK7+ only ?

2013-06-29 Thread Emmanuel Lécharny
re to add a warning in the header to tell the coders that this portion of code must remain Java 6 compatible. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Vysper Github repos out of date

2013-07-04 Thread Emmanuel Lécharny
Le 7/4/13 9:41 AM, Bernd Fondermann a écrit : > Hi, > > does anyone know why Vysper's Github repos is so outdated? No idea. OTOH, I never use GitHub. > Is there anything to do to sync it? May be asking Infra ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] M1?

2013-07-08 Thread Emmanuel Lécharny
ould expect that the libs we are using already do the job. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [VOTE] release Apache MINA 3.0.0-M1

2013-07-10 Thread Emmanuel Lécharny
st them all. > > So (if true) the only missing is netty used for benchmark which is > just tests no ? slf4j is not an Apache project, AFAICT. We are also using junit and mockito... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

[MINA3] NOTICE content (was Re: [VOTE] release Apache MINA 3.0.0-M1)

2013-07-11 Thread Emmanuel Lécharny
Jul 11, 2013 at 12:59 AM, Emmanuel Lécharny > wrote: >> Le 7/10/13 9:03 PM, Julien Vermillard a écrit : >>> I heard (from Emmanuel I think) we don't need to put notice files for >>> apache products (thrift and log4j). >> Yes. The are apache projects, covered

Re: [MINA3] NOTICE content (was Re: [VOTE] release Apache MINA 3.0.0-M1)

2013-07-16 Thread Emmanuel Lécharny
uld be a dependency of another jar than slf4j, I just picked this one because I know that slf4j depends on this jar). -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Contents of VOTE emails

2013-07-16 Thread Emmanuel Lécharny
___ The only missing part is the reference to the KEYS file, which will be added in the next vote. I suggest we create a template file and store it into the root of MINA. WDYT ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: MINA 3.0 JDK7+ only ?

2013-07-16 Thread Emmanuel Lécharny
Le 7/16/13 2:34 AM, sebb a écrit : > On 29 June 2013 21:41, Emmanuel Lécharny wrote: >> Le 6/29/13 7:35 PM, Julien Vermillard a écrit : >>> I think having the codec module java 6 compatible would help to use it >>> with MINA2 or other framework. >>> WDYT ? >

Re: MINA 3.0 JDK7+ only ?

2013-07-16 Thread Emmanuel Lécharny
MINA to face the same problem that commons-collection is facing : 9 years after the addition of generics in Java, we still don't have a library supporting them... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Sonar

2013-07-16 Thread Emmanuel Lécharny
Le 7/16/13 3:02 AM, sebb a écrit : > On 20 May 2013 10:06, Julien Vermillard wrote: >> Hi, >> comments inline >> On Mon, May 20, 2013 at 10:59 AM, Emmanuel Lécharny >> wrote: >>> Le 5/19/13 11:18 PM, Raphaël Barazzutti a écrit : >>>> I'm

Re: MINA 3.0 JDK7+ only ?

2013-07-16 Thread Emmanuel Lécharny
e case for Java 7) > > btw: is there a current roadmap or target for MINA 3? Julien is trying hard to cut a first milstone, and is struggling with N&L files... I feel for him :-) -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Contents of VOTE emails

2013-07-16 Thread Emmanuel Lécharny
Le 7/16/13 11:48 AM, sebb a écrit : > On 16 July 2013 08:59, Emmanuel Lécharny wrote: >> I suggest we create a template file and store it into the root of MINA. > Belongs with developer info, e.g. > > http://mina.apache.org/mina-project/developper-guide.html I disagree. Having

Re: [MINA3] NOTICE content (was Re: [VOTE] release Apache MINA 3.0.0-M1)

2013-07-16 Thread Emmanuel Lécharny
Le 7/16/13 12:08 PM, sebb a écrit : > On 16 July 2013 08:41, Emmanuel Lécharny wrote: >> Le 7/16/13 1:14 AM, sebb a écrit : >>> Have you seen this? >>> >>> http://www.apache.org/dev/licensing-howto.html#mod-notice >>> >>> It suggests that a

Re: MINA 3.0 JDK7+ only ?

2013-07-16 Thread Emmanuel Lécharny
f tme constraints (ie, removing the need to keep a compatibility with an already EOL version of Java), we spare this previous time delivering some package in a (soemhow) better timing, not leaving our users with the alternative of using a semi-OSS component like guava. In other words, "Time is of the essence" -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

N&L files fic

2013-07-16 Thread Emmanuel Lécharny
protobuf) - The LICENSE-bin file will be renamed to LICENSE in the binary package The distribution poms (bin.xml and src.xml) have been modified to correctly embed the required N&L files. I hope I haven't missed anything... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [1/2] git commit: Fixed the N&L files. Renamed them to NOTICE, LICENSE and LICENSE-bin. Fixed the distribution poms

2013-07-16 Thread Emmanuel Lécharny
easier identification within third-party archives. Copyright [] [name of copyright owner] Obvioysly, as teh date and copyright owner may change in the future, they have been substituted with and a comment. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] NOTICE content (was Re: [VOTE] release Apache MINA 3.0.0-M1)

2013-07-16 Thread Emmanuel Lécharny
again an extremely time consumming task, and I can't believe >> that it has not already been done on one of the 100 projects at the ASF, >> and gathered in a common place... > Sorry, what is time consuming? Searching for every transitive dependencies for dependencies we include into our packages. > > The N&L files only depend on what is in the archives. > It's just a question of checking that everything that is included in > the bundles is covered in the N&L files. > The contents should be obvious from the assembly files; if not, just > build the bundles and see what they contain. Sorry, but I don't see what's your point is here... Why should I build a bundle for a dependency I'm downloading from maven ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Contents of VOTE emails

2013-07-16 Thread Emmanuel Lécharny
Le 7/16/13 6:51 PM, sebb a écrit : > On 16 July 2013 13:31, Emmanuel Lécharny wrote: >> Le 7/16/13 11:48 AM, sebb a écrit : >>> On 16 July 2013 08:59, Emmanuel Lécharny wrote: >>>> I suggest we create a template file and store it into the root of MINA. >&g

Re: MINA 3.0 JDK7+ only ?

2013-07-16 Thread Emmanuel Lécharny
me active committers on the project !!! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] NOTICE content (was Re: [VOTE] release Apache MINA 3.0.0-M1)

2013-07-16 Thread Emmanuel Lécharny
Le 7/16/13 11:34 PM, sebb a écrit : > On 16 July 2013 18:34, Emmanuel Lécharny wrote: >> >> The N&L files only depend on what is in the archives. >> It's just a question of checking that everything that is included in >> the bundles is covered in the N&L

Re: [VOTE] MINA 3.0.0-M1 take 2

2013-07-16 Thread Emmanuel Lécharny
nt for everyone - and most certainly for non-committers- to have a direct reference to this link, otherwise you have to go find it on the site... This URL is likely to change in the near future, as soon as infra is going to say that git is not anymore a 'wip'... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [VOTE] MINA 3.0.0-M1 take 2

2013-07-16 Thread Emmanuel Lécharny
ackup in the bin package... Also the plugin-version.sh, deps-versions.sh, ImprovedJavaConventions.xml, release.properties plus all the sub-modules should not be present in the binary package. IMO, the binary release is FU... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [MINA3] NOTICE content (was Re: [VOTE] release Apache MINA 3.0.0-M1)

2013-07-17 Thread Emmanuel Lécharny
Le 7/17/13 1:11 AM, sebb a écrit : > On 16 July 2013 23:09, Emmanuel Lécharny wrote: >> Le 7/16/13 11:34 PM, sebb a écrit : >>> On 16 July 2013 18:34, Emmanuel Lécharny wrote: >>>> The N&L files only depend on what is in the archives. >>>> It's

Cancelled was [VOTE] MINA 3.0.0-M1 take 2

2013-07-17 Thread Emmanuel Lécharny
heck whether all the expected files are > present, and then close the staging directory. > It will then be available for the vote. > > Without that, I am voting -1 as the data for the vote is not complete. I have to -1 too this release, as the binary package contains sources. I just fixed the cause (bin.xml was incorrect). I will try to cut a new release today. Note that there is nothing wrong with cancelling releases : we are testing the first release for 3.0-M1, with git, and it's not easy to tune the various knobs that make it a valid release ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: git commit: Revert "[maven-release-plugin] prepare for next development iteration"

2013-07-17 Thread Emmanuel Lécharny
0d04eba4525ca85886c4a03acc20b444ff69a52d. > However trunk is now in an incorrect state, as all the versions are > missing the -SNAPSHOT suffix. The trunk will be fix when the perform will be done. (Actually, it should be the case). -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

[VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
us repository: https://repository.apache.org/content/repositories/orgapachemina-158/ Let us vote : [ ] +1 | Release MINA 3.0.0-M1 [ ] +/- | Abstain [ ] -1 | Do *NOT* release MINA 3.0.0-M1 Thanks ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: git commit: Fixed the pom version to SNAPSHOT, otherwise the release will fal

2013-07-17 Thread Emmanuel Lécharny
e is having lunch between the release:prepare and the release:perform ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: git commit: Revert "[maven-release-plugin] prepare for next development iteration"

2013-07-17 Thread Emmanuel Lécharny
Le 7/17/13 3:00 PM, sebb a écrit : > On 17 July 2013 13:26, Emmanuel Lécharny wrote: >> Le 7/17/13 2:21 PM, sebb a écrit : >>> On 17 July 2013 10:56, wrote: >>>> Updated Branches: >>>> refs/heads/trunk 0d04eba45 -> 84b2003fc >>>>

Re: git commit: Revert "[maven-release-plugin] prepare for next development iteration"

2013-07-17 Thread Emmanuel Lécharny
Le 7/17/13 5:53 PM, sebb a écrit : > On 17 July 2013 15:19, Emmanuel Lécharny wrote: >> Le 7/17/13 3:00 PM, sebb a écrit : >>> On 17 July 2013 13:26, Emmanuel Lécharny wrote: >>>> Le 7/17/13 2:21 PM, sebb a écrit : >>>>> On 17 July 2013 10:56,

Re: git commit: Revert "[maven-release-plugin] prepare for next development iteration"

2013-07-17 Thread Emmanuel Lécharny
Le 7/17/13 6:15 PM, sebb a écrit : > On 17 July 2013 17:00, Emmanuel Lécharny wrote: >> Le 7/17/13 5:53 PM, sebb a écrit : >>> On 17 July 2013 15:19, Emmanuel Lécharny wrote: >>> With SVN the way I do it is: >> We don't use SVN anymore. > I realise that

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
Le 7/17/13 2:33 PM, Emmanuel Lécharny a écrit : > Hi, > > 3rd attempt to cut a release. The binary package now contains just what is > needed, and the Nexus repository now contains the release. > > > A temporary tag has been created (it can be removed if the vote is not &

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
and cut it again (the release will take one hour). So far the pbs are : - presence of pom.xml.releasebackup in the src package - benchmarks moduel aren't correct. Should we cancel this release ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: git commit: Revert "[maven-release-plugin] prepare for next development iteration"

2013-07-17 Thread Emmanuel Lécharny
gt; tag to be used for the release vote. Yes, and this is why I thought that pushing the release into a branch is the way to go (if maven allows that) -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
se: > > benchmarks/pom.xml > benchmarks2/pom.xml > > Looks like the release plugin did not work properly, or the poms are > not configured correctly. No, as I said, this is my mistake : those poms are belonging to modules taht are activated by a profile, and I forgot to use it.

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
Le 7/18/13 1:12 AM, sebb a écrit : > On 18 July 2013 00:10, Emmanuel Lécharny wrote: >> Le 7/18/13 12:42 AM, sebb a écrit : >>> On 17 July 2013 23:21, Jeff MAURY wrote: >>>> Build also except if the benchmarks profile is activated: build fails >>>> becau

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
Le 7/18/13 1:44 AM, sebb a écrit : > On 17 July 2013 22:16, Emmanuel Lécharny wrote: >> Le 7/17/13 2:33 PM, Emmanuel Lécharny a écrit : >>> Hi, >>> >>> 3rd attempt to cut a release. The binary package now contains just what is >>> needed, and

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
Le 7/18/13 2:39 AM, Emmanuel Lécharny a écrit : > Le 7/18/13 1:44 AM, sebb a écrit : > This is the third thing to fix for the next release. And the forth one is the Java 7 enforcer that need to be added. And the fifth one is the Benchmark module that have to be included into the source t

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
t sure I grk what you say here... Can you tell me exactly which NOTICE file is incorrect, and what it contains that it should not ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-17 Thread Emmanuel Lécharny
Le 7/18/13 3:20 AM, sebb a écrit : > On 18 July 2013 02:10, Emmanuel Lécharny wrote: >> Le 7/18/13 3:04 AM, sebb a écrit : >>> Also the NOTICE files in the jars are wrong. >>> >>> For example, coap starts: >>> >>> Apache MINA CoAP (constra

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-18 Thread Emmanuel Lécharny
Le 7/17/13 2:33 PM, Emmanuel Lécharny a écrit : > Hi, > > 3rd attempt to cut a release. The binary package now contains just what is > needed, and the Nexus repository now contains the release. > > > A temporary tag has been created (it can be removed if the vote is not &

Re: [VOTE] MINA 3.0.0-M1 take 3

2013-07-19 Thread Emmanuel Lécharny
Guys, we need at least one more binding vote... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Result (was [VOTE] MINA 3.0.0-M1 take 3)

2013-07-19 Thread Emmanuel Lécharny
, Cordialement, Emmanuel Lécharny www.iktek.com

Post 3.0.0-M1 tasks

2013-07-19 Thread Emmanuel Lécharny
week, I'd like to cut a M2 asap. Thanks ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Sonar Analysis

2013-07-25 Thread Emmanuel Lécharny
Le 7/25/13 3:13 PM, Ashish a écrit : > Does anyone know when Sonar analysis kicks-off? > > Last MINA 3.0 analysis ran on Jun 17, 2013 > > https://analysis.apache.org/dashboard/index/24437 I think it's started every day. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

<    1   2   3   4   5   6   7   8   9   10   >