Re: OFBIZ-4872: webdriver integration

2012-12-31 Thread Jacopo Cappellato
On Dec 11, 2012, at 2:09 PM, Erwan de FERRIERES wrote: BTW, Jacopo, I have resolved all the issues you were having in the previous patch, and I'm waiting for your comments. Are there still some issues ? I apologize for the late reply. First of all a premise: I have already expressed my

Re: OFBIZ-4872: webdriver integration

2012-12-11 Thread Jacopo Cappellato
On Dec 10, 2012, at 8:34 PM, Olivier Heintz wrote: I'm just disappointed that with 25 commiters, there is not enough time for review. It's not a blame, it's only a fact and we should do with it. I think you got plenty of reviews recently; the problem is that, when the contributor doesn't

Re: OFBIZ-4872: webdriver integration

2012-12-11 Thread Jacopo Cappellato
On Dec 10, 2012, at 8:34 PM, Olivier Heintz wrote: I don't want to say all I do is correct, but for ofbiz addon 1) I have start by a situation status on my mail OFBiz Plugin Management, status and propositions 18th March 2) as proposed by Jacopo, work in OFBiz extra to be able to prepare

Re: OFBIZ-4872: webdriver integration

2012-12-11 Thread Jacques Le Roux
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 10, 2012, at 8:34 PM, Olivier Heintz wrote: I don't want to say all I do is correct, but for ofbiz addon 1) I have start by a situation status on my mail OFBiz Plugin Management, status and propositions 18th March 2) as

Re: OFBIZ-4872: webdriver integration

2012-12-11 Thread Erwan de FERRIERES
Please use another thread.. This one is for the webdriver integration, not the addon system. BTW, Jacopo, I have resolved all the issues you were having in the previous patch, and I'm waiting for your comments. Are there still some issues ? Thanks, 2012/12/11 Jacques Le Roux

Re: OFBIZ-4872: webdriver integration

2012-12-10 Thread Olivier Heintz
Le 06/12/2012 16:40, Erwan de FERRIERES a écrit : 2012/12/6 Jacques Le Roux jacques.le.r...@les7arts.com From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 5, 2012, at 2:54 PM, Jacques Le Roux wrote: ../.. All that said, I want to clarify that I am not feeling any pressure and

Re: OFBIZ-4872: webdriver integration

2012-12-10 Thread Olivier Heintz
Le 06/12/2012 17:20, Jacques Le Roux a écrit : From: Scott Gray scott.g...@hotwaxmedia.com On 7/12/2012, at 12:43 AM, Jacopo Cappellato wrote: On Dec 6, 2012, at 12:29 PM, Olivier Heintz wrote: If I correctly understand the commiter groups roles, it's to coordinate, animate and help the

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Olivier Heintz
Le 05/12/2012 11:29, Jacopo Cappellato a écrit : On Dec 5, 2012, at 8:54 AM, Jacques Le Roux wrote: Note: I intentionally used the verb reject, because it seems it how some contributors are now feeling the way the OFBiz project is doing with their proposed contributions I understand that

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacopo Cappellato
On Dec 6, 2012, at 12:07 PM, Olivier Heintz wrote: So attack him on this subject seems inappropriate. Olivier, I am not *attacking* anyone, we are discussing and not fighting so please do your best to keep the conversation in the right mood. Jacopo

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Olivier Heintz
Le 05/12/2012 11:52, Jacopo Cappellato a écrit : On Dec 5, 2012, at 8:54 AM, Jacques Le Roux wrote: Sounds indeed logical to have embedded a mean to test the UI available to all user OOTB. Why embedded? All users already have a mechanism to test the UI: test the UI is one of the important

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacopo Cappellato
On Dec 6, 2012, at 12:29 PM, Olivier Heintz wrote: If I correctly understand the commiter groups roles, it's to coordinate, animate and help the community to enhance (technically, functions, quality, ...) the project, not to force or constrain to work only on a short list of subject.

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Olivier Heintz
Le 06/12/2012 08:07, Jacopo Cappellato a écrit : On Dec 5, 2012, at 2:54 PM, Jacques Le Roux wrote: I must say I don't. The Neogia team is. And they are an important part of the OFBiz ecosystem. Their efforts should not be neglected. Erwan is no longer part of the Neogia team but he is

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Scott Gray
On 7/12/2012, at 12:43 AM, Jacopo Cappellato wrote: On Dec 6, 2012, at 12:29 PM, Olivier Heintz wrote: If I correctly understand the commiter groups roles, it's to coordinate, animate and help the community to enhance (technically, functions, quality, ...) the project, not to force or

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Tom Burns
: Nelly Burns From: Scott Gray scott.g...@hotwaxmedia.com To: dev@ofbiz.apache.org Sent: Thursday, December 6, 2012 7:13 AM Subject: Re: OFBIZ-4872: webdriver integration On 7/12/2012, at 12:43 AM, Jacopo Cappellato wrote: On Dec 6, 2012, at 12:29 PM, Olivier

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Ean Schuessler
Maybe more of this work needs to be done in feature branches? You can make the argument that SVN (at least as far as I know) encourages an everything goes in the central repository work flow because it doesn't have the GIT distributed workflow. We certainly don't want to discourage new and

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacques Le Roux
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 5, 2012, at 2:54 PM, Jacques Le Roux wrote: I must say I don't. The Neogia team is. And they are an important part of the OFBiz ecosystem. Their efforts should not be neglected. Erwan is no longer part of the Neogia team but

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Erwan de FERRIERES
2012/12/6 Jacques Le Roux jacques.le.r...@les7arts.com From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 5, 2012, at 2:54 PM, Jacques Le Roux wrote: ../.. All that said, I want to clarify that I am not feeling any pressure and no one at Neogia tried to put pressure on

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacques Le Roux
From: Scott Gray scott.g...@hotwaxmedia.com On 7/12/2012, at 12:43 AM, Jacopo Cappellato wrote: On Dec 6, 2012, at 12:29 PM, Olivier Heintz wrote: If I correctly understand the commiter groups roles, it's to coordinate, animate and help the community to enhance (technically, functions,

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacques Le Roux
From: Erwan de FERRIERES erwan.deferrie...@gmail.com 2012/12/6 Jacques Le Roux jacques.le.r...@les7arts.com From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 5, 2012, at 2:54 PM, Jacques Le Roux wrote: ../.. All that said, I want to clarify that I am not feeling any

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacques Le Roux
From: Ean Schuessler e...@brainfood.com Maybe more of this work needs to be done in feature branches? You can make the argument that SVN (at least as far as I know) encourages an everything goes in the central repository work flow because it doesn't have the GIT distributed workflow. We

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread lemine youssef
Hi every body, I feel the duty to participate to this discussion even that I think that e-amil may not be the best way for discussion like this one and that distance get things more complicated. If anyone find that some words are inappropriate, non constructive or hurtful, be sure that is

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacques Le Roux
From: lemine youssef youssef.m-lem...@nereide.biz Hi every body, I feel the duty to participate to this discussion even that I think that e-amil may not be the best way for discussion like this one and that distance get things more complicated. If anyone find that some words are

Re: OFBIZ-4872: webdriver integration

2012-12-06 Thread Jacopo Cappellato
Hi Youssef, please see inline: On Dec 6, 2012, at 11:00 PM, lemine youssef wrote: I personally have the feeling that ofbiz PCM get more and more isolated and disconnected form the reality for some reasons : -Jacopo argue a contribution refusal because non one of the community ! does he

Re: OFBIZ-4872: webdriver integration

2012-12-05 Thread Jacopo Cappellato
On Dec 5, 2012, at 8:54 AM, Jacques Le Roux wrote: Note: I intentionally used the verb reject, because it seems it how some contributors are now feeling the way the OFBiz project is doing with their proposed contributions I understand that this feeling could indeed happen but unfortunately

Re: OFBIZ-4872: webdriver integration

2012-12-05 Thread Jacopo Cappellato
On Dec 5, 2012, at 8:54 AM, Jacques Le Roux wrote: Sounds indeed logical to have embedded a mean to test the UI available to all user OOTB. Why embedded? All users already have a mechanism to test the UI: they can use Selenium or any other similar tool of their preference. We should not

Re: OFBIZ-4872: webdriver integration

2012-12-05 Thread Jacques Le Roux
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 5, 2012, at 8:54 AM, Jacques Le Roux wrote: Sounds indeed logical to have embedded a mean to test the UI available to all user OOTB. Why embedded? All users already have a mechanism to test the UI: they can use Selenium or

Re: OFBIZ-4872: webdriver integration

2012-12-05 Thread Jacques Le Roux
Yes, but I have also this feeling, may I? I have even a feeling that OFBiz is currently fossilising :/ This is my opinion Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 5, 2012, at 8:54 AM, Jacques Le Roux wrote: Note: I intentionally used the verb reject,

Re: OFBIZ-4872: webdriver integration

2012-12-05 Thread Erwan de FERRIERES
2012/12/5 Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Dec 5, 2012, at 8:54 AM, Jacques Le Roux wrote: Sounds indeed logical to have embedded a mean to test the UI available to all user OOTB. Why embedded? All users already have a mechanism to test the UI: they can use Selenium

Re: OFBIZ-4872: webdriver integration

2012-12-05 Thread Jacopo Cappellato
On Dec 5, 2012, at 2:54 PM, Jacques Le Roux wrote: I must say I don't. The Neogia team is. And they are an important part of the OFBiz ecosystem. Their efforts should not be neglected. Erwan is no longer part of the Neogia team but he is still in contact with them. At least AFAIK... This

Re: OFBIZ-4872: webdriver integration

2012-12-04 Thread Jacques Le Roux
Sounds indeed logical to have embedded a mean to test the UI available to all user OOTB. Even if not all users will use it, some have already their own way. At least something would exist and I don't see any objective reasons to reject it out of OFBiz. Note: I intentionally used the verb

Re: OFBIZ-4872: webdriver integration

2012-12-03 Thread lemine youssef
Hi every one, At Nereide, we were using selenium four our functional test for two years at lest but Selenium staff was integrated as a maven sub project which is not very simple to use and does not meet our needs and expectations. Two month ago, I started using the patch proposed by Erwan

Re: OFBIZ-4872: webdriver integration

2012-11-15 Thread Jacopo Cappellato
Isn't it a good candidate for an external component (i.e. not bundled in OFBiz and maintained by the OFBiz community)? I think we have already discussed this topic some time ago and we concluded that I also cursorily reviewed the patch and I have seen a series of issues (e.g. hardcoded

Re: OFBIZ-4872: webdriver integration

2012-11-15 Thread Erwan de FERRIERES
I don't think this should be seen as an external component. The new implementation is made to be part of OFBiz, like the junit tests we have. The main issue for selenium integration was the license, there was some components not consistent with the ASL2. I used ivy to download the jars only if

Re: OFBIZ-4872: webdriver integration

2012-11-15 Thread Jacopo Cappellato
Thank you Erwan, but the information below doesn't help me to change my point of view: the fact that the contribution was made to be part of the trunk and that we already have Junit tests integrated doesn't necessarily imply that we have to add this new one. What do other think about this

Re: OFBIZ-4872: webdriver integration

2012-11-15 Thread Erwan de FERRIERES
Jacopo, using localhost is the way it should be. Like you are running unit tests on your local instance, you are running functional tests on your local instance. This patch is only adding a new testing type which is not existing today. It's why it is designed to be part of OFBiz as a new

OFBIZ-4872: webdriver integration

2012-11-14 Thread Erwan de FERRIERES
Hi all, I'm planning on committing the patch in OFBIZ-4872 which will add webdriver testing in OFBiz this week-end. Is that OK for everyone, or are there some issues with this ? Thanks, -- Erwan de FERRIERES

Re: OFBIZ-4872: webdriver integration

2012-11-14 Thread Jacques Le Roux
I have not tested you last patch, but for what I have already seen this sounds good to me Jacques From: Erwan de FERRIERES erwan.deferrie...@gmail.com Hi all, I'm planning on committing the patch in OFBIZ-4872 which will add webdriver testing in OFBiz this week-end. Is that OK for