Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57364814
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTable.java
---
@@ -341,4 +345,13 @@ public static LinkType fromSerializedValue(byte
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57364562
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -825,9 +825,27 @@ protected static void ensureTableCreated(String url
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57363423
--- Diff: phoenix-protocol/src/main/MetaDataService.proto ---
@@ -72,6 +79,12 @@ message GetFunctionsRequest {
optional int32 clientVersion = 5
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57343095
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/NamespaceSchemaMappingIT.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57341237
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java ---
@@ -94,6 +99,8 @@ public void testCreateTable() throws Exception
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57340354
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateSchemaIT.java ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/149#discussion_r50730159
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/cache/JodaTimezoneCache.java ---
@@ -27,10 +27,14 @@
import
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/149#issuecomment-174604614
@zeeshanasghar - patch looks fine to me. There are formatting issues in
almost all the files though. See my comments on
org/apache/phoenix/cache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/149#discussion_r50730215
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/cache/JodaTimezoneCache.java ---
@@ -27,10 +27,14 @@
import
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677015
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/TestLocalTableState.java
---
@@ -23,9 +23,10 @@
import java.util.List
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677707
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
---
@@ -209,13 +212,34 @@ private static boolean isEmptyKeyValue(PTable
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45678083
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45681971
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45683372
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1137,7 +1181,7 @@ public MutationState createIndex
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45683493
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1268,19 +1312,19 @@ public MutationState
createIndex
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45677553
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/ServerUtil.java ---
@@ -66,7 +67,9 @@ public static IOException createIOException(String
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45679601
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableRef.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45682143
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,8 +115,10 @@ public boolean equals(Object obj
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/133#issuecomment-159119469
+1. This is fantastic work, Thomas! Other than a few minor nits and
comments, this looks great!
---
If your project is set up for it, you can reply to this email
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538575
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java ---
@@ -51,6 +51,7 @@
import
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538848
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -153,6 +344,15 @@ public void join(MutationState
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538874
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ---
@@ -301,28 +476,80 @@ public void remove
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/131#discussion_r45538919
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTableInterface.java
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/130#issuecomment-158249482
The check in TableRef.equals() isn't complete. It should be something like
this:
if (((table.getName() == null && other.table.getName()
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/130#discussion_r45427160
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -415,24 +425,47 @@ private long getClientTimeStamp
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45289517
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45289488
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -135,230 +154,282 @@ public void tearDown
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45308074
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45308492
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
---
@@ -99,18 +105,38 @@
private PMetaData
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307631
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/PhoenixMetricsSink.java ---
@@ -175,7 +176,9 @@ private void createTable(Connection conn
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307901
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -111,6 +115,7 @@ public boolean equals(Object obj
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/129#discussion_r45307861
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
@@ -101,7 +105,7 @@ else if (SchemaUtil.isPKColumn(column
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853305
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/TxWriteFailureIT.java
---
@@ -0,0 +1,198 @@
+package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853313
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/transactions/RecreateTableIT.java
---
@@ -0,0 +1,45 @@
+package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853408
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/tx/TxPointInTimeQueryIT.java ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853409
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/UpdateCacheIT.java
---
@@ -0,0 +1,122 @@
+package org.apache.phoenix.tx;
--- End diff
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853201
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/txn/MutableRollbackIT.java
---
@@ -0,0 +1,506 @@
+package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853014
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -1936,29 +2278,32 @@ public Void call() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853354
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/TransactionIT.java
---
@@ -0,0 +1,478 @@
+/*
--- End diff --
Minor nit
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853088
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsCollectorWithSplitsAndMultiCFIT.java
---
@@ -176,7 +176,7 @@ public void
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44853416
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/UpdateCacheIT.java
---
@@ -0,0 +1,122 @@
+package org.apache.phoenix.tx;
+
+import
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/104#discussion_r36558453
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MultiTenantTableIT.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/104#discussion_r36558264
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MultiTenantTableIT.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/104#discussion_r36558412
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MultiTenantTableIT.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32847228
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/WriteParams.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848810
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ScenarioResult.java
---
@@ -18,31 +18,31 @@
package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848394
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/QuerySetResult.java
---
@@ -18,31 +18,30 @@
package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32847079
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -146,49 +173,77 @@ public void run() throws Exception
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32847303
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/WriteParams.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848343
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/DataModelResult.java
---
@@ -18,61 +18,57 @@
package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32849038
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/DataModelResult.java
---
@@ -18,61 +18,57 @@
package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32847785
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -51,13 +58,11 @@
private volatile boolean
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848076
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -135,10 +155,8 @@ public synchronized boolean shouldStop
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848761
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/RunTime.java ---
@@ -18,104 +18,91 @@
package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32850605
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WriteWorkload.java
---
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32849281
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/RunTime.java ---
@@ -18,104 +18,91 @@
package
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32850123
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WriteWorkload.java
---
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32850466
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WriteWorkload.java
---
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32764170
--- Diff:
phoenix-pherf/src/it/java/org/apache/phoenix/pherf/DataIngestIT.java ---
@@ -18,70 +18,122 @@
package org.apache.phoenix.pherf
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32765259
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -135,10 +154,7 @@ public synchronized boolean shouldStop
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32764360
--- Diff:
phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java ---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098096
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -700,6 +1007,29 @@ private PTable loadTable
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96133889
Almost there Rajesh. Just some minor nits and questions, otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098070
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -383,6 +448,85 @@ protected TableRef createTableRef
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098063
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098050
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/cache/GlobalCache.java ---
@@ -157,4 +159,18 @@ public TenantCache
getChildTenantCache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098203
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java ---
@@ -289,24 +289,6 @@ public void testNegativeCountStar() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098156
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28524298
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1098,8 +1098,10 @@ public String toStringLiteral(byte[] b
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28526230
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/68#discussion_r28526475
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PhoenixArray.java ---
@@ -561,6 +666,23 @@ public int estimateByteSize(int pos
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/68#issuecomment-93872039
+1, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/42#issuecomment-87022884
@gabrielreid - does this look good for commit now? We are planning on
cutting the RC for 4.3.1 pretty soon.
---
If your project is set up for it, you can reply
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/42#issuecomment-87109980
Tests ran fine for me locally so I went ahead and committed the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26244969
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/41#issuecomment-78348649
This is fantastic @codymarcel and @mujtabachohan. Just a few concurrency
issues to be ironed out, otherwise looking good!
---
If your project is set up for it, you
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239385
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Scenario.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241118
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26341741
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26341134
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26341117
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238739
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239616
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241357
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239164
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Query.java
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26242921
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238794
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239550
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243501
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243640
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238858
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/5#discussion_r15389352
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/trace/DisableableMetricsWriter.java
---
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache
101 - 192 of 192 matches
Mail list logo
