,
Alexander Kolbasov
sit:
https://reviews.apache.org/r/62112/#review184689
---
On Sept. 6, 2017, 7:19 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To
> On Sept. 6, 2017, 3:46 p.m., Sergio Pena wrote:
> > Should we do the same change on PermImageRetriever as well? It is doing the
> > same thing as PathImageRetriever.
>
> Alexander Kolbasov wrote:
> Possibly, but I think it is much less important - it is usual to
> On Sept. 6, 2017, 3:46 p.m., Sergio Pena wrote:
> > Should we do the same change on PermImageRetriever as well? It is doing the
> > same thing as PathImageRetriever.
>
> Alexander Kolbasov wrote:
> Possibly, but I think it is much less important - it is usual to
; Should we keep these metrics here?
>
> Alexander Kolbasov wrote:
> I'll take a look at adding these metrics back
This is a bit non-trivial due to package dependencies, I'll add a different
metric later.
- Alexander
---
---
Thanks,
Alexander Kolbasov
sit:
https://reviews.apache.org/r/62112/#review184689
---
On Sept. 6, 2017, 6:48 p.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To re
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62112/#review184713
---
On Sept. 6, 2017, 6:48 p.m., Alexander Kolbasov wrote:
>
-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Line 191 (original), 191 (patched)
<https://reviews.apache.org/r/62136/#comment260957>
Since we are not doing anything fancy now, should we just remove this and
have a simple catch-all?
- Alexander Kolbasov
On S
/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
Diff: https://reviews.apache.org/r/62146/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62136/#review184771
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 7, 2017, 1
d4feb380fa0f3bd5f237609a107295a2d23eae3b
Diff: https://reviews.apache.org/r/62146/diff/2/
Changes: https://reviews.apache.org/r/62146/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
ate a helper singleton class where parties can register (by name) and say -
hey, I am busy, hey, I am available - using a simple map from name to atomic
value. This way we do not require all these plumbing changes (which may be
useful for other purposes but that's another story).
- Alexande
isit:
https://reviews.apache.org/r/62146/#review184795
---
On Sept. 7, 2017, 7:06 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generate
93afb614d0916c60ca416f8904331e78dd1b85d2
Diff: https://reviews.apache.org/r/62146/diff/3/
Changes: https://reviews.apache.org/r/62146/diff/2-3/
Testing
---
Thanks,
Alexander Kolbasov
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184824
---
On Sept. 7, 2017, 8:06 a.m., Alexander Kolbasov wrote:
>
> ---
> This is
/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java
Lines 89 (patched)
<https://reviews.apache.org/r/62177/#comment261099>
Nit: why do we need to set it if the value is the same? So shouldn't it be
`<=` ?
- Alexander Kolbasov
On Sept. 7, 2017, 10:23 p.m., Ser
y-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
Lines 53 (patched)
<https://reviews.apache.org/r/62107/#comment261162>
This part isn;t thread safe since it does non-atomic read/modify/write
- Alexander
/sentry/provider/db/service/model/package.jdo
Line 122 (original)
<https://reviews.apache.org/r/61793/#comment261165>
This change makes package.jdo inconsistent with sql scripts which do use
these fields as keys and the goal was to make these consistent.
- Alexander Kolbasov
On Sept. 1, 2
.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
Line 323 (original), 323 (patched)
<https://reviews.apache.org/r/62195/#comment261255>
Why do we need work SENTRY? It is completely redundand - just remove it
- Alexander Kolbaso
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62195/#review185023
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 8, 2017, 9
n/java/org/apache/sentry/hdfs/HMSPaths.java
Line 704 (original), 703 (patched)
<https://reviews.apache.org/r/62192/#comment261258>
Remove isDebugEnabled()
- Alexander Kolbasov
On Sept. 8, 2017, 9:19 p.m., Arjun Mishra wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62192/#review185033
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 8, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62194/#review185034
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 8, 2017, 9
/62202/#comment261272>
Still makes sense to call counterWait.update(eventId)
- Alexander Kolbasov
On Sept. 9, 2017, 4:09 a.m., Vamsee Yarlagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62219/#review185089
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 11, 2017, 2
va
Line 313 (original), 314 (patched)
<https://reviews.apache.org/r/62221/#comment261310>
Here it is not persisted, so the message is wrong.
- Alexander Kolbasov
On Sept. 11, 2017, 3:32 p.m., Arjun Mishra wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62221/#review185100
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 11, 2017, 6
/org/apache/sentry/service/thrift/TestCounterWait.java
e4846d9aea5ef9882fc655de9ec38c5795bde896
Diff: https://reviews.apache.org/r/62229/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62231/#review185131
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 12, 2017, 1
/apache/sentry/provider/db/service/persistent/SentryStore.java
01a7c830f548d41062fb3bbd0a81f71514585aa5
Diff: https://reviews.apache.org/r/62261/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62261/#review185252
-------
On Sept. 12, 2017, 11:26 p.m., Alexander Kolbasov wrote:
>
> --
0339#file1820339line1800>
> >
> > Looks like in the old code, 'groupName == null' was supported, and
> > getAllRoles(pm) was returned in that case. I don't think it happening here
> > anymore?
>
> Alexander Kolbasov wrote:
> We never call it w
/62261/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
---
Thanks,
Alexander Kolbasov
0339#file1820339line1800>
> >
> > Looks like in the old code, 'groupName == null' was supported, and
> > getAllRoles(pm) was returned in that case. I don't think it happening here
> > anymore?
>
> Alexander Kolbasov wrote:
> We never call it with g
it successfully processed one message but not
the rest? How would this message help someone?
- Alexander Kolbasov
On Sept. 13, 2017, 2:26 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62261/#review185339
---
On Sept. 13, 2017, 3:49 a.m., Alex
kes us
> hard to backport, but we haven't had any problem with JDK8 at all.
>
> On Thu, Aug 31, 2017 at 6:19 PM, Alexander Kolbasov
> wrote:
>
> > Sergio, can you share Apache Hive experience with this issue?
> >
> > Thanks,
> >
> > - Alex
> >
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62393/#review185630
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 18, 2017
try-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 335 (patched)
<https://reviews.apache.org/r/62409/#comment262050>
I think it makes sense to ignore exception during cleanup.
- Alexander Kolbasov
On Sept. 19, 2017, 2:51 p.m.,
already taking a
big hit for taking it, so I wondering if we should consider doing this as part
of our existing cleanup thread.
- Alexander Kolbasov
On Sept. 19, 2017, 2:51 p.m., Sergio Pena wrote:
>
> ---
> This is an auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62450/#review185808
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 20, 2017, 5
/sentry/binding/metastore/SentryMetastorePostEventListener.java
Lines 22 (patched)
<https://reviews.apache.org/r/62411/#comment262127>
This class isn't used in 2.0 so there is no need to do anything special
with it.
- Alexander Kolbasov
On Sept. 19, 2017, 3:10 p.m., Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62411/#review185922
---
Ship it!
Ship It!
- Alexander Kolbasov
On Sept. 21, 2017
/62496/diff/1/
Testing
---
New unit test written
Thanks,
Alexander Kolbasov
/service/thrift/TestSentryMetrics.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62496/diff/2/
Changes: https://reviews.apache.org/r/62496/diff/1-2/
Testing
---
New unit test written
Thanks,
Alexander Kolbasov
/3/
Changes: https://reviews.apache.org/r/62496/diff/2-3/
Testing
---
New unit test written
Thanks,
Alexander Kolbasov
I put current code for sentry CLI into akolb-cli branch. So far it supports
Hive privileges only. It would be great of some can add support for
Solr/Kafka privilege model as well. Any volunteers?
- Alex
prefix as well to be clear what this file is.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62496/#review185997
---
On Sept
ache.org/r/62496/#review186848
---
On Sept. 22, 2017, 6:28 p.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
Sravya used to have meetings over hangout, it was attended by Colin Ma and
some other folks. It is definitely a good idea if there is an interest.
Also a reminder that we have a slack room for discussions.
On Tue, Oct 3, 2017 at 2:50 PM, Sergio Pena
wrote:
> Hi All,
>
> Did we have any kind of
in/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java
Lines 117 (patched)
<https://reviews.apache.org/r/62745/#comment263989>
Ditto.
- Alexander Kolbasov
On Oct. 3, 2017, 10:41 a.m., Colm O hEigeartaigh wrote:
>
> --
; Colm.
>
> On Wed, Oct 4, 2017 at 1:15 AM, Alexander Kolbasov
> wrote:
>
>> Sravya used to have meetings over hangout, it was attended by Colin Ma and
>> some other folks. It is definitely a good idea if there is an interest.
>>
>> Also a reminder that we have a
add this information about Slack rooms here and how to
> request an invitation?
> http://sentry.apache.org/community/get_involved.html
>
> On Wed, Oct 4, 2017 at 5:19 PM, Alexander Kolbasov
> wrote:
>
>> It is https://apache-sentry.slack.com <https://apache-sentry.slack.com
Interesting - both were introduced by Colin Ma. I definitely agree that we
do not need two duplicates of the same similar functionality. The exception
part is interesting - the validator throws unchecked exceptions.
The version in SentryServiceUtil is used only in import policy code path
where val
be better to move it there long-term.
>
> Colm.
>
> On Wed, Oct 4, 2017 at 11:22 PM, Alexander Kolbasov
> wrote:
>
> > I don’t want to make it too official yet - this is experimental thing
> > using my private slack account - and so far it isn’t very active. Let’s
>
he URI case? This looks a bit dodgy to me as it would override the
> value parsed via PRIVILEGE_ACTION_NAME.
>
> Colm.
>
> On Wed, Oct 4, 2017 at 11:37 PM, Alexander Kolbasov
> wrote:
>
> > Interesting - both were introduced by Colin Ma. I definitely agree that
> w
The major reason why we wanted to move to Sentry 2.0 was the dependency on
Hive version. Sentry HA completely relies on HMS notifications which are
not available in Hive 1, more over it relies on fixes that are only
available in Hive 2.4. Sentry 1 should work with Hive 1, so we can't make
Sentry HA
> -Kalyan
>
>
>
>
> -Kalyan
>
> On Thu, Oct 5, 2017 at 3:02 PM, Alexander Kolbasov
> wrote:
>
> > The major reason why we wanted to move to Sentry 2.0 was the dependency
> on
> > Hive version. Sentry HA completely relies on HMS notifications which are
> &
> On Thu, Oct 5, 2017 at 5:52 PM, Alexander Kolbasov
> wrote:
>
> > Sergio - what is the state of HMS notifications in Hive1? Do they even
> > exist there?
> >
> > Kalyan - I am not sure that the new Sentry architecture which is based on
> > HMS notifications can
I'd like to get a feel on when and how Apache Sentry is used outside of
Cloudera distribution, so if anyone is using Apache Sentry not within the
CDH ecosystem, I would appreciate if you share your experience.
Thanks,
- ALex
com> wrote:
> Sasha,
>
> You got me wrong. I'm proposed to go with Hive 2.0 using authv1 for sentry
> 1.9.0 release.
>
> -Kalyan
>
> -Kalyan
>
> On Thu, Oct 5, 2017 at 5:52 PM, Alexander Kolbasov
> wrote:
>
> > Sergio - what is the state of HMS
- Alexander Kolbasov
On Oct. 12, 2017, 6:16 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62950/#review187863
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 12, 2017, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62953/#review187896
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 12, 2017, 10
Kalyan,
Thank you for pushing forward 2.0 release!
> On Oct 13, 2017, at 7:20 AM, Kalyan Kumar Kalvagadda
> wrote:
>
> Hello all,
>
> We need to release sentry HA functionality so that community can start
> using it. In this regard I proposed to have a sentry 1.9.0 release as there
> were som
tially
expensive and should be removed.
- Alexander Kolbasov
On Oct. 13, 2017, 6:10 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62942/#review188032
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 13, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62990/#review188046
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 13, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62992/#review188047
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 13, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/#review188141
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 16, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63026/#review188187
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 16, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63047/#review188220
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 16, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63048/#review188221
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 16, 2017, 9
It is my pleasure to announce a new Apache Sentry PMC member Sergio Pena who is
well known to this mailing list.
Thanks for all your contributions Sergio!
- Alex Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63086/#review188432
---
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 17, 2017, 7
Hi Chen,
Apache Sentry goal is to provide security features for other Apache
products - mainly Apache {Hive, Impala, Solr, Kafka}. It doesn't provide
HDFS access protections.
- Alex.
On Wed, Oct 18, 2017 at 12:05 PM, Chen Song wrote:
> I have a few questions on Sentry. I have some thoughts in
Hi Chen,
Apache Sentry goal is to provide security features for other Apache
products - mainly Apache {Hive, Impala, Solr, Kafka}. It doesn't provide
HDFS access protections.
- Alex.
On Wed, Oct 18, 2017 at 12:05 PM, Chen Song wrote:
> I have a few questions on Sentry. I have some thoughts in
ache-sentry
> slack to this official apache slack.
>
> On Mon, Oct 16, 2017 at 3:14 AM, Colm O hEigeartaigh
> wrote:
>
>> I believe you can sign up here: https://the-asf.slack.com/
>>
>> Colm.
>>
>> On Thu, Oct 5, 2017 at 8:51 PM, Alexander Kolbasov
>
d question?
>
> Chen
>
> On Wed, Oct 18, 2017 at 10:59 PM Alexander Kolbasov
> wrote:
>
>> Hi Chen,
>>
>> Apache Sentry goal is to provide security features for other Apache
>> products - mainly Apache {Hive, Impala, Solr, Kafka}. It doesn't provide
&
set it in constructor?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java
Lines 40 (patched)
<https://reviews.apache.org/r/63415/#comment266852>
Please do not use lambdas for
Hello,
I noticed that recently our commit messages became veru inconsistent:
The format we used to have:
SENTRY-2014: incorrect handling of HDFS paths with multiple forward slashes
(Vadim Spector, reviewed by Sergio Pena and Arjun Mishra)
SENTRY-2015 - Refactor Command implementations
- R
Looks like master is broken now which blocks anyone from doing anything. Do
we know what commit broke it? Do we know how this commit managed to get
through?
Once we know the commit it should be reverted ASAP.
- Alex.
> > Sasha,
> >
> > I agree we should have consistent format. It is better to include author,
> > then followed by reviewer. So we can have all information at a glance.
> >
> > Lina
> >
> > On Wed, Nov 1, 2017 at 8:04 PM, Alexander Kolbasov
> &
/service/thrift/SentryMetrics.java
86cae64fd4bbab162a09a1ca27a6d3887bfc2dc1
Diff: https://reviews.apache.org/r/63646/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
/db/service/thrift/SentryPolicyStoreProcessor.java
71eb9c1b6d02326fc9a7b702652253bd9b57d725
Diff: https://reviews.apache.org/r/63647/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
/sentry/provider/db/service/persistent/TestSentryStore.java
Lines 3469 (patched)
<https://reviews.apache.org/r/63645/#comment267763>
While this may be a useful test, it is better to write specific unit test
for the String manipulation functions directly.
- Alexander Kolbasov
On Nov. 7, 2
don't need to replace all since we do path.split("/+"). We only need to
remove leading slashes, so this check should be changed to startsWith("/")
- Alexander Kolbasov
On Nov. 7, 2017, 9:16 p.m., Arjun Mishra wrote:
>
> ---
GenericPrivilegeConverter.java
Line 173 (original), 157 (patched)
<https://reviews.apache.org/r/63415/#comment267960>
Looks like this method is never used
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
Line 182
ey and value to the canonical case
in constructor?
- Alexander Kolbasov
On Nov. 8, 2017, 11:43 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
What do you think about providing a ‘sentry service as a library’ which is a
wrapper that can run inside HMS and other consumers that will talk to the
underlying database, understand schemas, etc and provide all information to a
client without going through Thrift interface to the server?
- Ale
On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63647/
>
ause ID shouldn't be used by clients in case of
errors.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63647/#review190613
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/#review190635
---
Ship it!
Ship It!
- Alexander Kolbasov
On Nov. 9, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63667/#review190651
---
Ship it!
Ship It!
- Alexander Kolbasov
On Nov. 8, 2017, 3
-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
Lines 35 (patched)
<https://reviews.apache.org/r/63687/#comment268200>
Can you add Javadoc to the class explaining that by contract keys are
always case-insensitive?
- Alexander Kolbasov
On Nov. 9, 2017, 11:44 p.m.,
I added you to the contributors group - please let me know if this isnt
working for you.
On Tue, Nov 14, 2017 at 11:46 AM, Xinran Yu Tinney
wrote:
> Hi,
>I would like to become Sentry contributor and my Apache Jira username is
> xyu2017.
>
> Thanks!
>
> Xinran Tinney
>
Added you as a contributor in JIRA
On Tue, Nov 14, 2017 at 2:52 PM, Liam Sargent
wrote:
> Hello all,
>
> I would like to request the contributor role on issues.apache.org for the
> SENTRY project. My apache username is "liamsargent"
>
> Thank you in advance,
> Liam Sargent
>
Agreed, this would be a very useful thing to do. I remember spending a lot
of time trying to make Sentry work with DataNucleus 4 - the problem was
that e2e tests combine Sentry with Hive in the same JVM and this created a
conflict on the DataNucleus libraries and test failures.
Looking at the HBas
101 - 200 of 950 matches
Mail list logo
