Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/880#issuecomment-220689981
Huge ð for tests and test notebooks.
Looks great to me modulo minor comments above.
---
If your project is set up for it, you can reply to this
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217450451
@onkarshedge it's perfectly fine, you did very well and thank you for
taking a stab!
Shall we continue with original plan of submitting a PR to
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-217057001
@ravicodder thank you for prompt responce!
Looks great to me, modulo style nitpicks above. Let's merge as soon as
those are addressed!
---
If
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/873#issuecomment-217056217
Hi @onkarshedge thank you for submitting a fix!
In case of fixing a bug in any code, first thing to do is to try adding
some kind of (unit-)test to the
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/871#issuecomment-217054939
Thanks for review, this is the first step on making webapp build more
stable.
Merging if there is no more discussion. Will keep JIRA open for some time,
in
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/871
CI: debug flaky webapp build
### What is this PR for?
Debug flaky webapp builds
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-836
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216457974
[ZEPPELIN-836](https://issues.apache.org/jira/browse/ZEPPELIN-836) was
created to address CI issues
---
If your project is set up for it, you can reply to this
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216432006
ð Looks great, thank you for hotfixing!
It looks like it's flaky webapp build somehow.
```
olve@1.1.7, fileset@0.2.1, escodegen@
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-216413231
@ravicodder looks great, thank you for double-checking!
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-216088248
@hriviere thank you, great work!
Couple of small things:
- could you please make sure that all code and `pom.xml` formatting is
consistent
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/859#issuecomment-216086558
ð for adding a new test-case for the search API on a new behavoir
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-216084962
Looks great, thank you for taking care.
I have one more question: in case of no auth configured, can somebody
please help me to understand what is the
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-215624790
Looks great to me!
Merging if there is no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/833#issuecomment-214283701
@ravicodder thank you for fixing it.
Could you also please make sure that coded formatting is consistent
[project's style
guide](https://githu
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/850#issuecomment-213201586
Test failure looks quite strange
```
[INFO] Building Zeppelin: Server 0.6.0-incubating-SNAPSHOT
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/847#issuecomment-213200489
Zeppelin by default includes `Welcome to Zeppelin` tutorial notebook, which
is expected to be a part of the source tree\release as it is very convenient
for a
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/841#issuecomment-212004770
Not sure if it is ready for review yet, but I second @jeffsteinmetz on
having 2 separate PRs.
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/835#issuecomment-211250806
@jongyoul thank you for an awesome update - static interpreter registration
was a hack and it's great to see a better, testeble way to do it.
Coul
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/825#issuecomment-209710352
Looks great to me! Merging if there is no other discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-208199903
Great progress! Looking forward some tests and docs for new interpreter
implementation!
Just a nitpick, but I think you might need to double-check the
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207194646
Thank you for reviews!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207143423
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-206639157
This is fixes 2 CI https://travis-ci.org/bzz/incubator-zeppelin and
https://travis-ci.org/apache/incubator-zeppelin and is ready to be merged.
\cc
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/819#issuecomment-206638366
@jersub could you elaborate on the purpose of this PR please?
AFAIK there were no plans to do any further Zeppelin releases from 0.5.6
branch
---
If your
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-206450666
\cc @felixcheung for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/821#issuecomment-206285461
Thanks for a prompt responce guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/821
Fix 2 minor non-code style issues
### What is this PR for?
2 minor non-code style improvements.
HT @anthonycorbacho
### What type of PR is it?
Improvement
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/820#issuecomment-206260666
Thank you @khalidhuseynov !
Merging as this is a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/820#issuecomment-206221167
\cc @Leemoonsoo for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/820
Re-apply #815 - resolve SparkR implementation conflict 815
### What is this PR for?
Somehow squashed merge commit for #815 -
fb8e77bfd7296a08106b44fd834e4cf0d6950a70 does not include 2
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-206187328
@johnnyws thank you for explanation. I think there is value in this PR not
to changing the default behaviour that users already have for the 'root'
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/818
ZEPPELIN-783: fix Spark download on CI
### What is this PR for?
Fix Spark download on CI
### What type of PR is it?
Hot Fix
### What is the Jira issue
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/815#issuecomment-205831036
Looks great to me, let's merge asap as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/815#issuecomment-205770225
@Leemoonsoo thank you for taking care of CI failure on short notice!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-205703035
Looks great to me. Let's merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-205554908
@jeffsteinmetz thank you for kind notice! I think it has been reviewed by
PPMC already but I'll be glad to make a final pass today and post back the
re
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/811#issuecomment-205303221
Yup, let's just keep track of those under ZEPPELIN-786 What I meant is - I
think it should not block this PR.
---
If your project is set up for it
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205298832
Looks good to me. thank you for the efforts.
I think it is ready to be merged, and if there is no more discussion - I
will merge it tomorrow.
---
If
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/813#issuecomment-205185962
CI failure looks not relevant for this code, but @minahlee could you please
create an issue for that in JIRA and label it with `flaky-test` and attach a
link to
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-205158934
After at least 2 more PRs failed on downloading Spark distr again I have
re-open [ZEPPELIN-783](https://issues.apache.org/jira/browse/ZEPPELIN-783) and
thinking
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205103615
@elbamos everything looks good, except one last thing - BSD license text
need to be removed from `r/src/main/scala/scala/Console.scala` header as well,
as it
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-205102482
@johnnyws rebasing the branch on top of the latest master should get rid of
current CI.
Let me think a bit about validation though, I'm a bit con
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/804#issuecomment-205101825
Rebasing this on latest master should let current CI failure go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205101417
@mwkang CI is failing now, you probably need to check in `zeppelin-webapp`
what does `./grunt jshint` complain about.
---
If your project is set up for it
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-205094815
@elbamos awesome, thank you! Please, let me do a final pass and I'll post
back ASAP.
Just FYI - I'm still working on fixing random CI fail
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/811#issuecomment-205083977
CI failure is not relevant here and is due to spark download failure.
I have re-opened
[ZEPPELIN-786](https://issues.apache.org/jira/browse/ZEPPELIN-786) to
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204846957
Looks awesome! I think there are just 2 minor licence issue that are left
in the ..
Copied them here for convenience
---
If your project is set up
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-204675812
[ZEPPELIN-786](https://issues.apache.org/jira/browse/ZEPPELIN-786) was
created for caching `.m2`
Looks like current CI on master is failing to populate
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204675506
I believe that rebase to latest master must eliminate most of CI issues.
Did one more round of reviews and updated
https://github.com/apache/incubator
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-204668582
Merging, as this is a hotfix and there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204665058
@elbamos I have switched to the containerized sudo-less method of R
installation + dependencies in elbamos/Zeppelin-With-R#12 it works, let me
rebase and we
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-204659044
@felixcheung feedback addressed in 039513b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-204424456
@echarles So true. I plan to take care of that as a next step under a
separate PR, after dealing with Spark downloads here first.
---
If your project is set up
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/810#issuecomment-204388627
Ready to be merged \cc @felixcheung @jongyoul @Leemoonsoo for a review
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-204351155
@ankurmitujjain please refer
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203834473
for things that need to be taken care of before
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/810
ZEPPELIN-783 fix CI failure on Spark download
### What is this PR for?
Improves CI by hard-ending spark download failures that are responsible for
recent CI red on `master
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/808#issuecomment-204220261
ready to be merged
\cc @felixcheung @Leemoonsoo for a review
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/808
ZEPPELIN-776: force CI to always use container-based infra
### What is this PR for?
It forces travis CI to use container-based infra for everything, not only
`master`.
It will
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203834473
@elbamos thank you, it looks great now.
Could you please take care of the last step - updating `LICENSE` files,
while I'll focus on
[ZEPPELIN-776](
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/807#issuecomment-203761293
Looks great to me :shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203753693
@elbamos I'm sorry for a confusion! I was basically asking you to post same
replies that you did before, but in the places where I have posted the
ques
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203749879
@elbamos :+1: for keeping the docs update! Yes, I believe licenses for each
contributed file are clear now, but what I was asking you for is just to follow
each
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203730593
@elbamos got it, but could you please post your answers in the comments
that I have made, and linked from the list, so we have full conversation
history online
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203726149
@elbamos sure, now I have updated list in
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203673589
could you please clarify few question
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203721628
@elbamos I have create file list and updated comment above to track our
progress
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203673589
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203718108
On RException - then please feel free to remove `//Originally by David Dahl
and released under the BSD license` if that is your contribution
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203693548
@elbamos right, I'm looking into licenses and will post back soon.
Meanwhile can you please help providing the list of such files to save the time
identi
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203673589
Great!
Here is the list of things that need to be done in order to merge this PR:
- [x] ~~master and this branch have diverged: we need to either
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203251582
I do not see how this words help. Please ping me when any of the issues
above are solved and you want me to spend time reviewing this PR again.
---
If your
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203248777
I'm not sure I understand you, but please feel free to use whatever place
you consider right for the any discussion you feel necessary (I would suggest
sta
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203240469
So you suggest to keep CI work in this branch is try to fix current issues
first and then get back to `ZeppelinSparkClusterTest.java` - it's fine wi
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203234120
@elbamos It is possible to do exactly so, but then we will need to create a
new PR from that feature branch to master, in order to get it merged, right?
And
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203224008
@elbamos I see. The problem is that such intentions (removing not
permanently) are not obvious for a reviewers, as they just do not know and
assume that current
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203206273
@elbamos removing test that do not pass under b848d98 is not an acceptable
way to make CI green.
It is not going to be possible to merge it without
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202695901
Things that left to be done in order to merge this PR:
- [x] ~~master and this branch have diverged: we need to either merge
master in here, or rebase
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-202217468
From what I can see - same three issue I have listed above still hold for
this PR from being merged.
Updates on my help with CI are tracked under
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/798#issuecomment-202171192
Looks good to me.
Merging if there is no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/789#issuecomment-202170740
@Leemoonsoo code looks good and rationale for customizing at least JVM
properties now and leaving ui for env vars for further improvements makes
sense
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/796#issuecomment-201212072
@johnnyws thank you for stepping up and bringing this back to life.
CI is failing on web application build, so may be you should check what
`./grunt
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/791#issuecomment-201146477
Somehow CI is failing =\
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194061392
\cc @felizbear for a reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194059787
@zhongneu thank you for taking a stab at bringing that feature to life
again!
:+1: for screenshots, but could you please also updated PR description a
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-193688762
@elbamos it's totally up to you, as an author weather to do it or not. As a
PPMC member I have just listed for you the requirements that project has for
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-193619433
@elbamos sorry for slow re, the only things that are left:
- [ ] master and this branch have diverged: we need to either merge master
in here, or rebase it
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-189140201
@elbamos please ping me if you need any help adding a profile for R in
order to avoid failing default Zeppelin build for users who do not need R.
---
If your
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-189099153
@runyontr thanks for standing up!
> Given that I can fix the list above, how do I update this pull request
with my repository?
It's no
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188663789
CI failure is due to
```
Unapproved licenses:
.github/PULL_REQUEST_TEMPLATE
***
```
.. but you got
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188663097
Looks great to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/413#issuecomment-188511648
@fireboy1919 thank you for contribution!
The approach you take looks interesting, please help me to understand how
much would that affect other existing
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-188464303
@sourav-mazumder this is not changing the final convenience binary for the
release - as we will update release script too, to include this profile (+ docs
for
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-188252250
Guys, please correct me if I'm wrong but current R interpreter
implementation, in order to be compiled, requires R installed on user's machine
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-188151976
Great progress, @elbamos thank for quick updates! @hsaputra and
@jeffsteinmetz thank you very much for your help!
I was able to reproduce same build
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-186613590
@elbamos got it, about BSD licence files. Let me double-check everything
and get back to you with it by Monday
---
If your project is set up for it, you can
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-186613513
@btiernay @zhiboz thank you for feedback, if you could please express it on
the [dev@ mailing list](http://zeppelin.incubator.apache.org/community.html)
that
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-185150683
Great progress @elbamos thank you! @jongyoul thank you for keeping an eye
Please excuse me, most of comments above are on issues 5-7 and may be
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-184692116
I have reviewed and commented inline.
Generally it looks great, but I have the feeling that we could dramatically
speed merging it up by reducing the
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-184128878
Sounds great, I'm looking forward.
Right now I do not see anything specific that need to be taken into account.
---
If your project is set up for it
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-184076341
Thank you so much for taking care!
Merging this guy if there is no more discussion.
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/640#issuecomment-183982372
@AhyoungRyu thank you for a thoughtful review!
If you have a spare moment and could contribute those 2 changes, please do,
as it might really speed merging
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-182916680
Guys, thank you for the feedback!
To pursue our plan I have summarize it after the discussion and took the
liberty of mentioning those who volunteered to
1 - 100 of 451 matches
Mail list logo
