Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jacob Carlborg
On 2012-01-02 00:14, Jonathan M Davis wrote: On Sunday, January 01, 2012 15:35:00 Jacob Carlborg wrote: Ok, if you would rather have all this in the language I would say no do that. But I know other people in the community that usually prefer to do a library solution if possible. If all we're

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jacob Carlborg
On 2012-01-02 00:28, Jonathan M Davis wrote: On Sunday, January 01, 2012 15:31:18 Jacob Carlborg wrote: What's wrong with being able to run the unit tests from your editor, have the unit test framework output HTML (or similar), displayed in your editor and then you can click on links in the stac

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jonathan M Davis
On Sunday, January 01, 2012 15:31:18 Jacob Carlborg wrote: > What's wrong with being able to run the unit tests from your editor, > have the unit test framework output HTML (or similar), displayed in your > editor and then you can click on links in the stack trace to get to the > source code. If yo

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jonathan M Davis
On Sunday, January 01, 2012 15:32:34 Jacob Carlborg wrote: > On 2011-12-31 21:57, Jonathan M Davis wrote: > > On Saturday, December 31, 2011 15:48:16 Jacob Carlborg wrote: > >> Yes but what happens when there are many failed tests, i.e. may > >> AssertErrors that have been thrown? It will just prin

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jonathan M Davis
On Sunday, January 01, 2012 15:35:00 Jacob Carlborg wrote: > Ok, if you would rather have all this in the language I would say no do > that. But I know other people in the community that usually prefer to do > a library solution if possible. If all we're talking about is named unit tests and runni

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jacob Carlborg
On 2012-01-01 01:57, Andrew Wiley wrote: On Sat, Dec 31, 2011 at 2:56 PM, Jonathan M Davis wrote: On Saturday, December 31, 2011 16:06:49 Jacob Carlborg wrote: On 2011-12-31 11:37, Jonathan M Davis wrote: On Saturday, December 31, 2011 11:05:58 Tobias Pankrath wrote: I think that the AssertE

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jacob Carlborg
On 2011-12-31 22:01, Jonathan M Davis wrote: On Saturday, December 31, 2011 16:04:12 Jacob Carlborg wrote: It would be possible to implement named unit tests only in library code. It would not have as nice syntax as if it was implemented in the language but still possible. In Ruby on Rails I ru

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jacob Carlborg
On 2011-12-31 21:57, Jonathan M Davis wrote: On Saturday, December 31, 2011 15:48:16 Jacob Carlborg wrote: Yes but what happens when there are many failed tests, i.e. may AssertErrors that have been thrown? It will just print all after each other and you have to count them yourself if you want t

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Jacob Carlborg
On 2011-12-31 21:56, Jonathan M Davis wrote: On Saturday, December 31, 2011 16:06:49 Jacob Carlborg wrote: BTW, what would be so wrong if the unit tests for the standard library displayed a nice report when finished? My primary issue here is that I don't think that we should be adding stuff to

Re: CURL Wrapper: Congratulations Next up: std.serialize

2012-01-01 Thread Tobias Pankrath
Jonathan M Davis wrote: > I think > that on some level, the unit test framework in the language has failed if > we have to add library solutions on top of it to get such basic > functionality. That's what we are saying: The unit test framework fails for us and a library solution is perfectly pos

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jonathan M Davis
On Saturday, December 31, 2011 18:57:14 Andrew Wiley wrote: > On Sat, Dec 31, 2011 at 2:56 PM, Jonathan M Davis wrote: > > On Saturday, December 31, 2011 16:06:49 Jacob Carlborg wrote: > >> On 2011-12-31 11:37, Jonathan M Davis wrote: > >> > On Saturday, December 31, 2011 11:05:58 Tobias Pankrath

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Andrew Wiley
On Sat, Dec 31, 2011 at 2:56 PM, Jonathan M Davis wrote: > On Saturday, December 31, 2011 16:06:49 Jacob Carlborg wrote: >> On 2011-12-31 11:37, Jonathan M Davis wrote: >> > On Saturday, December 31, 2011 11:05:58 Tobias Pankrath wrote: >> >>> I think that the AssertError's message (which includes

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jonathan M Davis
On Saturday, December 31, 2011 16:04:12 Jacob Carlborg wrote: > It would be possible to implement named unit tests only in library code. > It would not have as nice syntax as if it was implemented in the > language but still possible. > > In Ruby on Rails I run single unit tests all the time. Why

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jonathan M Davis
On Saturday, December 31, 2011 15:48:16 Jacob Carlborg wrote: > Yes but what happens when there are many failed tests, i.e. may > AssertErrors that have been thrown? It will just print all after each > other and you have to count them yourself if you want to know how many > failed tests there are?

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jonathan M Davis
On Saturday, December 31, 2011 16:06:49 Jacob Carlborg wrote: > On 2011-12-31 11:37, Jonathan M Davis wrote: > > On Saturday, December 31, 2011 11:05:58 Tobias Pankrath wrote: > >>> I think that the AssertError's message (which includes the file and > >>> line number of the failure) and its stack t

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jacob Carlborg
On 2011-12-31 11:37, Jonathan M Davis wrote: On Saturday, December 31, 2011 11:05:58 Tobias Pankrath wrote: I think that the AssertError's message (which includes the file and line number of the failure) and its stack trace are plenty. It's exactly what you need and nothing else. - Jonathan M D

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jacob Carlborg
On 2011-12-31 11:37, Jonathan M Davis wrote: On Saturday, December 31, 2011 11:05:58 Tobias Pankrath wrote: I think that the AssertError's message (which includes the file and line number of the failure) and its stack trace are plenty. It's exactly what you need and nothing else. - Jonathan M D

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jacob Carlborg
On 2011-12-31 04:35, Jonathan M Davis wrote: On Friday, December 30, 2011 21:38:07 Jacob Carlborg wrote: On 2011-12-30 19:49, Jonathan M Davis wrote: On Friday, December 30, 2011 13:41:37 Tobias Pankrath wrote: I really think it is and will use one for my D code. Since both worlds could live t

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Tobias Pankrath
Jonathan M Davis wrote: > On Saturday, December 31, 2011 11:05:58 Tobias Pankrath wrote: >> > I think that the AssertError's message (which includes the file and >> > line number of the failure) and its stack trace are plenty. It's >> > exactly what you need and nothing else. >> > >> > - Jonathan

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Jonathan M Davis
On Saturday, December 31, 2011 11:05:58 Tobias Pankrath wrote: > > I think that the AssertError's message (which includes the file and line > > number of the failure) and its stack trace are plenty. It's exactly what > > you need and nothing else. > > > > - Jonathan M Davis > > I want to have suc

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-31 Thread Tobias Pankrath
> > I think that the AssertError's message (which includes the file and line > number of the failure) and its stack trace are plenty. It's exactly what > you need and nothing else. > > - Jonathan M Davis I want to have such a summary. What's about running only certain unittests?

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-30 Thread Jonathan M Davis
On Friday, December 30, 2011 21:38:07 Jacob Carlborg wrote: > On 2011-12-30 19:49, Jonathan M Davis wrote: > > On Friday, December 30, 2011 13:41:37 Tobias Pankrath wrote: > >> I really think it is and will use one for my D code. Since both worlds > >> could live together peacefully there is absolu

Re: Second Round CURL Wrapper Review

2011-12-30 Thread jdrewsen
On Saturday, 17 December 2011 at 22:25:07 UTC, Andrei Alexandrescu wrote: On 12/2/11 10:26 PM, dsimcha wrote: I volunteered ages ago to manage the review for the second round of Jonas Drewsen's CURL wrapper. After the first round it was decided that, after a large number of minor issues

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-30 Thread Jacob Carlborg
On 2011-12-30 19:49, Jonathan M Davis wrote: On Friday, December 30, 2011 13:41:37 Tobias Pankrath wrote: I really think it is and will use one for my D code. Since both worlds could live together peacefully there is absolutely no reason not to include one in phobos. It's one thing to use a fa

Re: Second Round CURL Wrapper Review

2011-12-30 Thread jdrewsen
On Monday, 19 December 2011 at 18:14:29 UTC, Somedude wrote: Le 19/12/2011 19:05, Somedude a écrit : Le 03/12/2011 05:26, dsimcha a écrit : I volunteered ages ago to manage the review for the second round of Jonas Drewsen's CURL wrapper. After the first round it was decided that, af

Re: Second Round CURL Wrapper Review

2011-12-30 Thread jdrewsen
On Saturday, 17 December 2011 at 20:01:04 UTC, Jakob Ovrum wrote: The docs for onReceiveHeader, http://freeze.steamwinter.com/D/web/phobos/etc_curl.html#onReceiveHeader explicitly says that the const string parameters are not valid after the function returns. This is all well and good; but a

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-30 Thread Jonathan M Davis
On Friday, December 30, 2011 13:41:37 Tobias Pankrath wrote: > When I first came to D, I read "unittest support" and thought that would > be nice. But after I tried it, I realized it sucks and wrote something > similar to Jacobs unittest framework. > > > I'm against it. I think that the compiler/r

Re: Second Round CURL Wrapper Review

2011-12-30 Thread jdrewsen
copy.clear(option); You should be able to cut down on the number of lines by doing that (_especially_ if you're actually clearing all of them and can use EnumMembers!CurlOption). Nice. I actually found out that you can do: with (CurlOption) foreach(option; TypeTuple!(file, writefunction

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-30 Thread Tobias Pankrath
When I first came to D, I read "unittest support" and thought that would be nice. But after I tried it, I realized it sucks and wrote something similar to Jacobs unittest framework. > I'm against it. I think that the compiler/runtime should be fixed so that > each unit test block is run in a modu

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-29 Thread Jacob Carlborg
On 2011-12-29 13:59, Jakob Ovrum wrote: On Thursday, 29 December 2011 at 12:49:55 UTC, Jacob Carlborg wrote: For example: import orange.test.UnitTester; int sum (int x, int y) { return x * y; } unittest () { describe("sum") in { it("should return the sum of the two given arguments") in { asse

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-29 Thread Jakob Ovrum
On Thursday, 29 December 2011 at 12:49:55 UTC, Jacob Carlborg wrote: For example: import orange.test.UnitTester; int sum (int x, int y) { return x * y; } unittest () { describe("sum") in { it("should return the sum of the two given arguments") in { assert(sum(1, 2)

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-29 Thread Jacob Carlborg
On 2011-12-27 03:01, dsimcha wrote: By a vote of 14-0, Jonas Drewsen's CURL wrapper (std.net.curl) has been accepted into Phobos. Thanks to Jonas for his hard work and his persistence through the multiple rounds of review that it took to get this module up to Phobos's high and increasi

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-29 Thread Jacob Carlborg
On 2011-12-29 06:11, Jonathan M Davis wrote: On Wednesday, December 28, 2011 23:07:51 Jacob Carlborg wrote: I think it is, don't know what others think. What it does is it catches AssertErrors so other unit tests can continue to run and then gives a nice report at the end. I'm against it. I th

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-29 Thread jdrewsen
On Wednesday, 28 December 2011 at 22:21:09 UTC, Jacob Carlborg wrote: On 2011-12-28 22:19, jdrewsen wrote: On Wednesday, 28 December 2011 at 16:01:50 UTC, Jacob Carlborg wrote: On 2011-12-27 03:01, dsimcha wrote: By a vote of 14-0, Jonas Drewsen's CURL wrapper (std.net.curl) has been acc

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread Jonathan M Davis
On Thursday, December 29, 2011 00:06:57 Brad Anderson wrote: > Forgive me if this is a silly question but a conversation in IRC got me > wondering if compiler could check for shared/__gshared use (and any other > thread unsafe operation) in each unittest and run those that aren't using > them concu

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread Jakob Ovrum
On Thursday, 29 December 2011 at 07:07:10 UTC, Brad Anderson wrote: Forgive me if this is a silly question but a conversation in IRC got me wondering if compiler could check for shared/__gshared use (and any other thread unsafe operation) in each unittest and run those that aren't using them co

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread Brad Anderson
On Wed, Dec 28, 2011 at 10:11 PM, Jonathan M Davis wrote: > On Wednesday, December 28, 2011 23:07:51 Jacob Carlborg wrote: > > I think it is, don't know what others think. What it does is it catches > > AssertErrors so other unit tests can continue to run and then gives a > > nice report at the en

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread Jonathan M Davis
On Wednesday, December 28, 2011 23:07:51 Jacob Carlborg wrote: > I think it is, don't know what others think. What it does is it catches > AssertErrors so other unit tests can continue to run and then gives a > nice report at the end. I'm against it. I think that the compiler/runtime should be fix

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread Jacob Carlborg
On 2011-12-28 22:19, jdrewsen wrote: On Wednesday, 28 December 2011 at 16:01:50 UTC, Jacob Carlborg wrote: On 2011-12-27 03:01, dsimcha wrote: By a vote of 14-0, Jonas Drewsen's CURL wrapper (std.net.curl) has been accepted into Phobos. Thanks to Jonas for his hard work and his persis

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread Jacob Carlborg
On 2011-12-28 19:43, dsimcha wrote: On Wednesday, 28 December 2011 at 16:01:50 UTC, Jacob Carlborg wrote: Running the unit tests: ./unittest.sh Use "make" to compile the library or create an executable using rdmd. A few things to think about that need to be resolved: * This is quite a large l

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread jdrewsen
On Wednesday, 28 December 2011 at 16:01:50 UTC, Jacob Carlborg wrote: On 2011-12-27 03:01, dsimcha wrote: By a vote of 14-0, Jonas Drewsen's CURL wrapper (std.net.curl) has been accepted into Phobos. Thanks to Jonas for his hard work and his persistence through the multiple rounds of r

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread dsimcha
On Wednesday, 28 December 2011 at 16:01:50 UTC, Jacob Carlborg wrote: Running the unit tests: ./unittest.sh Use "make" to compile the library or create an executable using rdmd. A few things to think about that need to be resolved: * This is quite a large library and I really don't want to p

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-28 Thread Jacob Carlborg
On 2011-12-27 03:01, dsimcha wrote: By a vote of 14-0, Jonas Drewsen's CURL wrapper (std.net.curl) has been accepted into Phobos. Thanks to Jonas for his hard work and his persistence through the multiple rounds of review that it took to get this module up to Phobos's high and increasi

Re: CURL Wrapper: Congratulations Next up: std.serialize

2011-12-27 Thread jdrewsen
On Tuesday, 27 December 2011 at 02:01:51 UTC, dsimcha wrote: By a vote of 14-0, Jonas Drewsen's CURL wrapper (std.net.curl) has been accepted into Phobos. Thanks to Jonas for his hard work and his persistence through the multiple rounds of review that it took to get this module up to Pho

CURL Wrapper: Congratulations Next up: std.serialize

2011-12-26 Thread dsimcha
By a vote of 14-0, Jonas Drewsen's CURL wrapper (std.net.curl) has been accepted into Phobos. Thanks to Jonas for his hard work and his persistence through the multiple rounds of review that it took to get this module up to Phobos's high and increasing quality standard. Keep the

Re: CURL Wrapper: Vote Thread

2011-12-20 Thread Sean Kelly
Yes. Sent from my iPhone On Dec 20, 2011, at 1:49 AM, "Bernard Helyer" wrote: > Yes.

Re: CURL Wrapper: Vote Thread

2011-12-20 Thread Masahiro Nakagawa
Yes! Masahiro On Sun, 18 Dec 2011 04:36:15 +0900, dsimcha wrote: The time has come to vote on the inclusion of Jonas Drewsen's CURL wrapper in Phobos. Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d Docs: http://freeze.steamwinter.com/D/web/phobos/etc_curl.html

Re: CURL Wrapper: Vote Thread

2011-12-20 Thread Bernard Helyer
Yes.

Re: Second Round CURL Wrapper Review

2011-12-19 Thread Somedude
Le 19/12/2011 19:05, Somedude a écrit : > Le 03/12/2011 05:26, dsimcha a écrit : >> I volunteered ages ago to manage the review for the second round of >> Jonas Drewsen's CURL wrapper. After the first round it was decided >> that, after a large number of minor issues

Re: Second Round CURL Wrapper Review

2011-12-19 Thread Somedude
Le 03/12/2011 05:26, dsimcha a écrit : > I volunteered ages ago to manage the review for the second round of > Jonas Drewsen's CURL wrapper. After the first round it was decided > that, after a large number of minor issues were fixed, a second round > would be necessary. >

Re: Second Round CURL Wrapper Review

2011-12-18 Thread Jonathan M Davis
On Sunday, December 18, 2011 21:49:16 jdrewsen wrote: > A static ternary operator wouldn't work in this case since > isFtpUrl(url) cannot be evaluated at compile time. Ah. That would be true. Still, it's the sort of thing which begs for a ternary operator but which just can't use it due to techni

Re: Second Round CURL Wrapper Review

2011-12-18 Thread jdrewsen
On Sunday, 18 December 2011 at 01:27:45 UTC, Jonathan M Davis wrote: On Saturday, December 17, 2011 23:10:00 jdrewsen wrote: On Thursday, 15 December 2011 at 08:51:29 UTC, Jonathan M Davis wrote: > Line# 235 is identical to line# 239. Shouldn't line# 235 be > creating an Http object, not an Ftp

Re: CURL Wrapper: Vote Thread

2011-12-18 Thread Mike Wey
Yes. -- Mike Wey

Re: CURL Wrapper: Vote Thread

2011-12-18 Thread Alix Pexton
On 17/12/2011 19:36, dsimcha wrote: The time has come to vote on the inclusion of Jonas Drewsen's CURL wrapper in Phobos. Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d Docs: http://freeze.steamwinter.com/D/web/phobos/etc_curl.html For those of you on Windows, a li

Re: Second Round CURL Wrapper Review

2011-12-18 Thread jdrewsen
On Sunday, 18 December 2011 at 01:30:10 UTC, Jonathan M Davis wrote: On Saturday, December 17, 2011 09:21:42 Justin C Calvarese wrote: On Sat, Dec 17, 2011 at 5:56 AM, jdrewsen wrote: > On Thursday, 15 December 2011 at 07:46:56 UTC, Jonathan M > Davis wrote: >>> ... > > I'd argue that the ac

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread Jonathan M Davis
On Saturday, December 17, 2011 14:36:15 dsimcha wrote: > The time has come to vote on the inclusion of Jonas Drewsen's CURL > wrapper in Phobos. > > > Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d > Docs: http://freeze.steamwinter.com/D/web/phobos/et

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Jonathan M Davis
On Saturday, December 17, 2011 09:21:42 Justin C Calvarese wrote: > On Sat, Dec 17, 2011 at 5:56 AM, jdrewsen wrote: > > On Thursday, 15 December 2011 at 07:46:56 UTC, Jonathan M Davis wrote: > >>> ... > > > > I'd argue that the acronyms should be in all caps if camelcasing would > > > >> req

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Jonathan M Davis
On Saturday, December 17, 2011 23:51:08 Jakob Ovrum wrote: > On Saturday, 17 December 2011 at 22:25:10 UTC, jdrewsen wrote: > > On Saturday, 17 December 2011 at 20:38:46 UTC, Jakob Ovrum > > > > wrote: > >> On Saturday, 17 December 2011 at 11:56:04 UTC, jdrewsen wrote: > >>> AutoConnect sounds lik

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Jonathan M Davis
On Saturday, December 17, 2011 23:10:00 jdrewsen wrote: > On Thursday, 15 December 2011 at 08:51:29 UTC, Jonathan M Davis > > wrote: > > Line# 235 is identical to line# 239. Shouldn't line# 235 be > > creating an Http object, not an Ftp object? That mistake > > definitely makes it look like downlo

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Jonathan M Davis
On Saturday, December 17, 2011 12:56:02 jdrewsen wrote: > On Thursday, 15 December 2011 at 07:46:56 UTC, Jonathan M Davis > > > I'd argue that the acronyms should be in all caps if > > camelcasing would require that the first letter of the acronym > > be capitalized and all lower case if camelcasi

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread Jesse Phillips
On Sat, 17 Dec 2011 14:36:15 -0500, dsimcha wrote: > The time has come to vote on the inclusion of Jonas Drewsen's CURL > wrapper in Phobos. > > > Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d Docs: > http://freeze.steamwinter.com/D/web/phobos/etc_curl

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread Jimmy Cao
YES! Finally an easy way to do SMTP.

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Jakob Ovrum
On Saturday, 17 December 2011 at 22:25:10 UTC, jdrewsen wrote: On Saturday, 17 December 2011 at 20:38:46 UTC, Jakob Ovrum wrote: On Saturday, 17 December 2011 at 11:56:04 UTC, jdrewsen wrote: AutoConnect sounds like a command to connection automatically which might be confusing since that is no

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread maarten van damme
yes

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread Andrei Alexandrescu
On 12/17/11 1:36 PM, dsimcha wrote: The time has come to vote on the inclusion of Jonas Drewsen's CURL wrapper in Phobos. Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d Docs: http://freeze.steamwinter.com/D/web/phobos/etc_curl.html For those of you on Windows, a li

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread Damian Ziemba
Yes

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Andrei Alexandrescu
On 12/2/11 10:26 PM, dsimcha wrote: I volunteered ages ago to manage the review for the second round of Jonas Drewsen's CURL wrapper. After the first round it was decided that, after a large number of minor issues were fixed, a second round would be necessary. Significant open issue

Re: Second Round CURL Wrapper Review

2011-12-17 Thread jdrewsen
On Saturday, 17 December 2011 at 20:38:46 UTC, Jakob Ovrum wrote: On Saturday, 17 December 2011 at 11:56:04 UTC, jdrewsen wrote: AutoConnect sounds like a command to connection automatically which might be confusing since that is not what it does. Therefore I went with AutoConnection which I st

Re: Second Round CURL Wrapper Review

2011-12-17 Thread jdrewsen
On Thursday, 15 December 2011 at 08:51:29 UTC, Jonathan M Davis wrote: Line# 235 is identical to line# 239. Shouldn't line# 235 be creating an Http object, not an Ftp object? That mistake definitely makes it look like download hasn't been properly tested. It has been tested as you can see by

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread Mirko Pilger
The time has come to vote on the inclusion of Jonas Drewsen's CURL wrapper in Phobos. yes.

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread Max Klyga
On 2011-12-17 22:36:15 +0300, dsimcha said: The time has come to vote on the inclusion of Jonas Drewsen's CURL wrapper in Phobos. Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d Docs: http://freeze.steamwinter.com/D/web/phobos/etc_curl.html For those of you on Windo

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Jakob Ovrum
On Saturday, 17 December 2011 at 11:56:04 UTC, jdrewsen wrote: AutoConnect sounds like a command to connection automatically which might be confusing since that is not what it does. Therefore I went with AutoConnection which I still believe is better. How about something completely different

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Jakob Ovrum
The docs for onReceiveHeader, http://freeze.steamwinter.com/D/web/phobos/etc_curl.html#onReceiveHeader explicitly says that the const string parameters are not valid after the function returns. This is all well and good; but a minor improvement would be to change the signature to: @property

Re: CURL Wrapper: Vote Thread

2011-12-17 Thread dsimcha
On 12/17/2011 2:36 PM, dsimcha wrote: The time has come to vote on the inclusion of Jonas Drewsen's CURL wrapper in Phobos. Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d Docs: http://freeze.steamwinter.com/D/web/phobos/etc_curl.html For those of you on Windows, a li

CURL Wrapper: Vote Thread

2011-12-17 Thread dsimcha
The time has come to vote on the inclusion of Jonas Drewsen's CURL wrapper in Phobos. Code: https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d Docs: http://freeze.steamwinter.com/D/web/phobos/etc_curl.html For those of you on Windows, a libcurl binary built by DMC is availabl

D Style Guide (was Re: Second Round CURL Wrapper Review )

2011-12-17 Thread Justin C Calvarese
== Quote from jdrewsen (jdrew...@nospam.com)'s article > On Thursday, 15 December 2011 at 07:46:56 UTC, Jonathan M Davis > wrote: ... > > I'd argue that the acronyms should be in all caps if > > camelcasing would require that the first letter of the acronym > > be capitalized and all lower case if

D Style Guide (was Re: Second Round CURL Wrapper Review )

2011-12-17 Thread Justin C Calvarese
== Quote from jdrewsen (jdrew...@nospam.com)'s article > On Thursday, 15 December 2011 at 07:46:56 UTC, Jonathan M Davis > wrote: ... > > I'd argue that the acronyms should be in all caps if > > camelcasing would require that the first letter of the acronym > > be capitalized and all lower case if

Re: Second Round CURL Wrapper Review

2011-12-17 Thread Justin C Calvarese
On Sat, Dec 17, 2011 at 5:56 AM, jdrewsen wrote: > On Thursday, 15 December 2011 at 07:46:56 UTC, Jonathan M Davis wrote: > >> >>> ... > > I'd argue that the acronyms should be in all caps if camelcasing would >> require that the first letter of the acronym be capitalized and all lower >> case

Re: Second Round CURL Wrapper Review

2011-12-17 Thread jdrewsen
On Thursday, 15 December 2011 at 07:46:56 UTC, Jonathan M Davis wrote: On Friday, December 02, 2011 23:26:10 dsimcha wrote: I volunteered ages ago to manage the review for the second round of Jonas Drewsen's CURL wrapper. After the first round it was decided that, after a large numb

Re: Second Round CURL Wrapper Review

2011-12-16 Thread Jonathan M Davis
Please make sure that you remove trailing whitespace from the file. A lot of the lines have trailing whitespace. Also, make sure that you don't have any tabs in the file. There are a few places where you used tabs. Line# 916 claims that the code there won't work and that it needs to be fixed, s

Re: Second Round CURL Wrapper Review

2011-12-15 Thread Jonathan M Davis
Line# 235 is identical to line# 239. Shouldn't line# 235 be creating an Http object, not an Ftp object? That mistake definitely makes it look like download hasn't been properly tested. You should create template similar to template isCurlConn(Conn) { auto isCurlConn = is(Conn : Http) || is(

Re: Second Round CURL Wrapper Review

2011-12-14 Thread Jonathan M Davis
On Monday, December 12, 2011 01:53:13 dsimcha wrote: > Actually, that leads to another question: Should this module > really be named etc.curl/std.curl/std.net.curl, or should the > fact that it currently uses Curl as a backend be relegated to an > implementation detail? It's too specific to curl

Re: Second Round CURL Wrapper Review

2011-12-14 Thread Jonathan M Davis
On Friday, December 02, 2011 23:26:10 dsimcha wrote: > I volunteered ages ago to manage the review for the second round of > Jonas Drewsen's CURL wrapper. After the first round it was decided > that, after a large number of minor issues were fixed, a second round > w

Re: Second Round CURL Wrapper Review

2011-12-13 Thread jdrewsen
On Tuesday, 13 December 2011 at 00:47:26 UTC, David Nadlinger wrote: On 12/12/11 1:18 PM, jdrewsen wrote: On Monday, 12 December 2011 at 10:26:52 UTC, Somedude wrote: Just an idea: would it be possible/useful to use the signals/slots mechanism for this kind of synch ? This would be most usef

Re: Second Round CURL Wrapper Review

2011-12-13 Thread jdrewsen
On Monday, 12 December 2011 at 14:42:17 UTC, Andrei Alexandrescu wrote: On 12/12/11 6:25 AM, jdrewsen wrote: On Monday, 12 December 2011 at 01:05:25 UTC, Jonathan M Davis wrote: On Sunday, December 11, 2011 19:55:28 dsimcha wrote: On 12/11/2011 7:53 PM, dsimcha wrote: > Should the protocol det

Re: Second Round CURL Wrapper Review

2011-12-12 Thread dsimcha
On Tuesday, 13 December 2011 at 00:47:26 UTC, David Nadlinger wrote: I don't know if you already have a solution in the works, but maybe the future interface I did for Thrift is similar to what you are looking for: http://klickverbot.at/code/gsoc/thrift/docs/thrift.util.future.html David Do

Re: Second Round CURL Wrapper Review

2011-12-12 Thread David Nadlinger
On 12/12/11 1:18 PM, jdrewsen wrote: On Monday, 12 December 2011 at 10:26:52 UTC, Somedude wrote: Just an idea: would it be possible/useful to use the signals/slots mechanism for this kind of synch ? This would be most useful if there were some kind of main loop. This is needed because the req

Re: Second Round CURL Wrapper Review

2011-12-12 Thread Andrei Alexandrescu
On 12/12/11 6:25 AM, jdrewsen wrote: On Monday, 12 December 2011 at 01:05:25 UTC, Jonathan M Davis wrote: On Sunday, December 11, 2011 19:55:28 dsimcha wrote: On 12/11/2011 7:53 PM, dsimcha wrote: > Should the protocol detection be case-insensitive, i.e. > "ftp://"; == > "FTP://"? Oh, one more

Re: Second Round CURL Wrapper Review

2011-12-12 Thread Jakob Ovrum
On Monday, 12 December 2011 at 12:24:26 UTC, jdrewsen wrote: I think it should have curl in the name. I do not believe that a native D network library should have the same API as this module. It is limited by the design of libcurl and should be improved by a native D net library. I agree with

Re: Second Round CURL Wrapper Review

2011-12-12 Thread Jacob Carlborg
On 2011-12-12 01:53, dsimcha wrote: Here's my review. Remember, review ends on December 16. What is the use case for exposing struct Curl? I prefer if this were unexposed because we'll obviously be unable to provide a replacement if/when the backend to this library is rewritten in pure D. Actua

Re: Second Round CURL Wrapper Review

2011-12-12 Thread jdrewsen
On Monday, 12 December 2011 at 01:05:25 UTC, Jonathan M Davis wrote: On Sunday, December 11, 2011 19:55:28 dsimcha wrote: On 12/11/2011 7:53 PM, dsimcha wrote: > Should the protocol detection be case-insensitive, i.e. > "ftp://"; == > "FTP://"? Oh, one more thing: Factor the protocol detecti

Re: Second Round CURL Wrapper Review

2011-12-12 Thread jdrewsen
On Monday, 12 December 2011 at 00:53:14 UTC, dsimcha wrote: Here's my review. Remember, review ends on December 16. Overall, this library has massively improved due to the rounds of review it's been put through. I only found a few minor nitpicks. However, a recurring pattern is minor grammar

Re: Second Round CURL Wrapper Review

2011-12-12 Thread jdrewsen
On Monday, 12 December 2011 at 10:26:52 UTC, Somedude wrote: Le 05/12/2011 22:36, Jonas Drewsen a écrit : Anyway - I _have_ said that I will add a data availability poll functionality so I guess your initial concern is also covered. /Jonas Just an idea: would it be possible/useful to use the

Re: Second Round CURL Wrapper Review

2011-12-12 Thread bearophile
Somedude: > > 1. Should libcurl be bundled with DMD on Windows? > > Yes. This is a must. I agree it's better to have this battery included. Bye, bearophile

Re: Second Round CURL Wrapper Review

2011-12-12 Thread Somedude
Le 03/12/2011 05:26, dsimcha a écrit : > I volunteered ages ago to manage the review for the second round of > Jonas Drewsen's CURL wrapper. After the first round it was decided > that, after a large number of minor issues were fixed, a second round > would be necessary. >

Re: Second Round CURL Wrapper Review

2011-12-12 Thread Somedude
Le 12/12/2011 01:53, dsimcha a écrit : > Actually, that leads to another question: Should this module really be > named etc.curl/std.curl/std.net.curl, or should the fact that it > currently uses Curl as a backend be relegated to an implementation detail? > I think it's good to remind that this

Re: Second Round CURL Wrapper Review

2011-12-12 Thread Somedude
Le 05/12/2011 22:36, Jonas Drewsen a écrit : > > Anyway - I _have_ said that I will add a data availability poll > functionality so I guess your initial concern is also covered. > > /Jonas Just an idea: would it be possible/useful to use the signals/slots mechanism for this kind of synch ?

Re: Second Round CURL Wrapper Review

2011-12-11 Thread Jonathan M Davis
On Sunday, December 11, 2011 19:55:28 dsimcha wrote: > On 12/11/2011 7:53 PM, dsimcha wrote: > > Should the protocol detection be case-insensitive, i.e. "ftp://"; == > > "FTP://"? > > Oh, one more thing: Factor the protocol detection out into a function. > You have the same expression cut and p

Re: Second Round CURL Wrapper Review

2011-12-11 Thread dsimcha
On 12/11/2011 7:53 PM, dsimcha wrote: Should the protocol detection be case-insensitive, i.e. "ftp://"; == "FTP://"? Oh, one more thing: Factor the protocol detection out into a function. You have the same expression cut and pasted everywhere: if(url.startsWith("ftp://";) || url.startsWith

Re: Second Round CURL Wrapper Review

2011-12-11 Thread dsimcha
Here's my review. Remember, review ends on December 16. Overall, this library has massively improved due to the rounds of review it's been put through. I only found a few minor nitpicks. However, a recurring pattern is minor grammar mistakes in the documentation. Please proofread all docum

  1   2   3   >