Alexey thanks for question, because I'm intereseted in this too
As I understand from your discession, for example suport class
modules\awt\src\test\api\java\common\java\awt\geom\ShapeTestCase.java
should be moved to
I have two old verified and unassigned issues
http://issues.apache.org/jira/browse/HARMONY-1419
http://issues.apache.org/jira/browse/HARMONY-1175
Could anybody close them?
Thanks
2006/10/25, Alex Blewitt [EMAIL PROTECTED]:
The other possibiltiy is to fork an 'nslookup' or 'host' command
(depending on platform) to find out what the platform thinks is the
local host name, and then comparing it to Java's result.
On this WinServer2003 nslookup localhost and nslookup
the test.
Paulex,
This is your patch. What do you think?
With best regards,
Alexei Fedotov,
Intel Java XML Engineering
-Original Message-
From: Denis Kishenko [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 19, 2006 3:44 PM
To: harmony-dev@incubator.apache.org
Mark, I have just tried your tool. It's really helpful, thanks a lot!
It's so pitty that script doesn't fix issues by itself =)
2006/10/25, Geir Magnusson Jr. [EMAIL PROTECTED]:
Mark Hindess wrote:
On 25 October 2006 at 7:41, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
Cool - but why not
Hi all
I can't run tests for concurrent module. By default the test task is
switched off (see modules\concurrent\build.xml), so I uncommented task
but it didn't help. Sources are located in
modules\concurrent\standard\src instead of modules\concurrent\src and
script runs tests from wrong place.
Sorry, I skiped this mail, too long topic name =)
It's ok to rollback.
Actually concurrent module has a lot of warnings and I have started
fix them. I have some suggestion about generic warnings. Is Doug Lea
subscribed on dev list?
2006/10/20, Mark Hindess [EMAIL PROTECTED]:
On 20 October
I have found answer on my question in thread
svn commit: r466154 - in
/incubator/harmony/standard/classlib/trunk/modules/concurrent/src/main/java/java/util/concurrent:
./ locks/
2006/10/24, Denis Kishenko [EMAIL PROTECTED]:
Hi all
I can't run tests for concurrent module. By default the test
2006/10/24, Fedotov, Alexei A [EMAIL PROTECTED]:
I wonder about the first option. Is there any way to check that symbolic
name corresponds to the local computer? I can imagine the following
condition to check this.
InetAddress.getByName(InetAddress.getByName(127.0.0.1).getHostName()).
.
-Nathan
On 10/24/06, Denis Kishenko [EMAIL PROTECTED] wrote:
Sorry, I skiped this mail, too long topic name =)
It's ok to rollback.
Actually concurrent module has a lot of warnings and I have started
fix them. I have some suggestion about generic warnings. Is Doug Lea
subscribed on dev list
code
* missing @Override - methods that override other methods are
annotated for safety
-Nathan
On 10/19/06, Tim Ellison [EMAIL PROTECTED] wrote:
Nathan has turned off all warnings. I suggest that we start to turn
them back on incrementally and fix the warnings we see.
Regards,
Tim
Denis
regards,
Alexei Fedotov,
Intel Java XML Engineering
-Original Message-
From: Denis Kishenko [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 19, 2006 3:44 PM
To: harmony-dev@incubator.apache.org
Subject: [classlib][test] Configuration dependent test of
InetAddress.getHostName
I have
Alex thanks for answer.
2006/10/20, Alex Blewitt [EMAIL PROTECTED]:
Isn't this just because in your /etc/hosts file (or
c:/windows/system32/drivers/etc/hosts) you have a mapping
127.0.0.1 ntsdrlew31/10.125.122.60 localhost
hosts (on nstdrlew21) consists from a single string
127.0.0.1
2006/10/20, Ivanov, Alexey A [EMAIL PROTECTED]:
And https://issues.apache.org/jira/browse/HARMONY-1892 to make all
Windows users happier. :)
Great thanks for this =)
-
Terms of use :
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
2006/10/20, Tim Ellison [EMAIL PROTECTED]:
Denis Kishenko wrote:
I have made fix[1] for unused category (only java code). If nobody
has
2006/10/20, Alexei Zakharov [EMAIL PROTECTED]:
Hi Denis,
InetAddressTest.test_getHostName (see H-1664) failed on WinServer
because InetAddress.getByName(127.0.0.1).getHostName() returned
nstdrlew21.ins.intel.com while localhost expected. So this test
According to the test's output you've
Added patch for SUID wanings to the same issue.H-1926
2006/10/20, Tim Ellison [EMAIL PROTECTED]:
Denis Kishenko wrote:
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
Thanks Denis!
Regards
I have researched issue H-1664 and found one more difference with RI.
I run simple test on Windows Server 2003 SP1
=== Test =
import java.net.InetAddress;
import java.net.UnknownHostException;
public class Test {
public static void main(String[] args) throws
I also worried about a lot of warnings and I think warnings like these
can be fixed
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
[javac] (at line 26)
[javac] import java.io.ObjectInputStream;
[javac]
Mark, I have updated patch as you suggested week ago. Did you try it?
2006/10/10, Mark Hindess [EMAIL PROTECTED]:
On 10 October 2006 at 19:00, Denis Kishenko [EMAIL PROTECTED] wrote:
Hi committers
Could someone look at this issue. Because I am going to make another
fix which is depend
Andrew, patch was applied and verified.
Could you check, does it fix problem?
2006/10/16, Andrew Zhang [EMAIL PROTECTED]:
On 10/16/06, Denis Kishenko [EMAIL PROTECTED] wrote:
This issue has been filed and patched three weeks ago but wasn't
applied yet (as many others).
Thanks Denis! Look
This issue has been filed and patched three weeks ago but wasn't
applied yet (as many others). See
http://issues.apache.org/jira/browse/HARMONY-1585
2006/10/15, Andrew Zhang [EMAIL PROTECTED]:
PolePosition(actually JFreeChat) throws IllegalPathStateException when
generating test report.The
Hi committers
Could someone look at this issue. Because I am going to make another
fix which is depend on this patch.
Thanks.
2006/10/10, Denis Kishenko (JIRA) [EMAIL PROTECTED]:
[classlib][awt][test] java.awt test resources are located in wrong place
You are not alone
2006/10/4, Tim Ellison [EMAIL PROTECTED]:
First time running the AWT/Swing tests for a while. On r452910 I see
the following (one and only) failure on IA32 WinXP:
java.lang.NullPointerException at
.
So I will fix this issue.
2006/10/3, Andrew Zhang [EMAIL PROTECTED]:
On 10/2/06, Denis Kishenko [EMAIL PROTECTED] wrote:
Seems this is RI bug.
Apparently, RI doesn't comply with spec this time. But I think
IllealArgumentException is also acceptable. Therefore, I suggest to follow
RI and mark
Thanks a lot.
P.S. It would be good to add this instruction to conventsion.
2006/9/29, Paulex Yang [EMAIL PROTECTED]:
Denis Kishenko wrote:
I am going to fix some commented tests from java.awt.geom package. I
have several organizational questions before start to do.
1. Where is the best
Alexey, thanks it will be very useful
2006/10/2, Alexey Petrenko [EMAIL PROTECTED]:
2006/9/29, Paulex Yang [EMAIL PROTECTED]:
Denis Kishenko wrote:
I am going to fix some commented tests from java.awt.geom package. I
have several organizational questions before start to do.
1. Where
just
has another implementation.
In all cases it's more logical to throw IllegalArgumentException or
RasterFormatException instead of NegativeArraySizeException.
Any comments?
2006/10/2, Denis Kishenko (JIRA) [EMAIL PROTECTED]:
[classlib][awt] BufferedImage constructor throws different
to do what the
development community conclude is the logical thing...
So we have 1 vote for non-bug and 1 vote for bug.
2006/9/28, Richard Liang [EMAIL PROTECTED]:
On 9/27/06, Denis Kishenko [EMAIL PROTECTED] wrote:
Hi all
RI implementation of AffineTransform of transform(float[], int,
float
I am going to fix some commented tests from java.awt.geom package. I
have several organizational questions before start to do.
1. Where is the best place to put test resource files (golden files)?
Testing conventions [1] keep silence about this. There are many such
files located near the tests,
OK, thanks a lot.
P.S. I have found your discussion about separate patches.
2006/9/27, Nathan Beyer [EMAIL PROTECTED]:
-Original Message-
From: Tim Ellison [mailto:[EMAIL PROTECTED]
Geir Magnusson Jr. wrote:
On Sep 26, 2006, at 10:23 AM, Denis Kishenko wrote:
Geir, thanks
Vladimir, my congratulations!
2006/9/27, Vladimir Ivanov [EMAIL PROTECTED]:
Thanks :)
On 9/26/06, Tim Ellison [EMAIL PROTECTED] wrote:
Here's a badge for you to cut out and wear g
+-+
| Harmony |
| Champion! |
+-+
Keep up the good work!
Regards,
Tim
do you wear such one =)
2006/9/27, Geir Magnusson Jr. [EMAIL PROTECTED]:
you can wear it too if you want. either share with Vladimir, or make
your own copy :)
On Sep 27, 2006, at 8:39 AM, Denis Kishenko wrote:
Vladimir, my congratulations!
2006/9/27, Vladimir Ivanov [EMAIL PROTECTED
I should guess
2006/9/27, Geir Magnusson Jr. [EMAIL PROTECTED]:
I have a tattoo.
geir
On Sep 27, 2006, at 8:52 AM, Denis Kishenko wrote:
do you wear such one =)
2006/9/27, Geir Magnusson Jr. [EMAIL PROTECTED]:
you can wear it too if you want. either share with Vladimir, or make
your
nothing w/o exceptions.
2. Follow RI. In this case we have to add checks like this
if (srcOff src.length || dstOff dst.length) {
throw new ArrayIndexOutOfBoundsException(...);
}
it looks a bit strange from my point of view.
I vote for non-bug.
Comments?
2006/9/27, Denis Kishenko (JIRA) [EMAIL
OK, I will ask committers to change bug status to non-bug.
2006/9/26, Ilya Okomin [EMAIL PROTECTED]:
On 9/26/06, Ilya Okomin [EMAIL PROTECTED] wrote:
On 9/26/06, Denis Kishenko [EMAIL PROTECTED] wrote:
Ilya, so do you vote for non-bug status?
You are right that Shape doesn't follow
Sometime I make two different diff files (source and test patches),
sometime I make the single one. Does it make sense for committers?
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail:
, show it's gone (and then screw up and not commit all the code
in the patch ;)
Tim was neutral, but didn't care, so there's no opposition to asking
for two.
geir
On Sep 26, 2006, at 9:29 AM, Denis Kishenko wrote:
Sometime I make two different diff files (source and test patches),
sometime I
2006/9/25, Ilya Okomin [EMAIL PROTECTED]:
To follow RI I would suggest to add check (if the bounds2D is null) to the
contains() method, in this case just to return false.
Yep, to follow RI we can check if the bounds2D is null but why you
suggest return false? I think in this case we have to
these bounds, hence
contains() just should return false.
Regards,
Ilya.
On 9/26/06, Denis Kishenko [EMAIL PROTECTED] wrote:
2006/9/25, Ilya Okomin [EMAIL PROTECTED]:
To follow RI I would suggest to add check (if the bounds2D is null) to
the
contains() method, in this case just to return false
if shape
returns null bounds but such shapes are drawn well (run the test).
Comments?
2006/9/22, Denis Kishenko (JIRA) [EMAIL PROTECTED]:
[classlib][awt] Successor of CubicCurve2D throws NPE in contains() if
getBounds2D() returns null
and height meen that rectangle is empty too
I have marked this issue as non-bug difference.
Any comments?
2006/9/25, Denis Kishenko (JIRA) [EMAIL PROTECTED]:
[classlibl][awt] RI considers that negative rectangle is contained inside empty
GeneralPath
If I am going to work with whole module then Harmony class library
development status[1] page is useful but if I want to work with
several classes, for example fix some JAPI issues or make serious
changes, then existing wiki page can't be used.
I agree with creating JIRA issue and sending
, Mikhail Loenko [EMAIL PROTECTED]:
Hi Denis,
thanks for you patch!
could you please add some comments, why you think this change is necessary?
Thanks,
Mikhail
2006/9/12, Denis Kishenko (JIRA) [EMAIL PROTECTED]:
[
http://issues.apache.org/jira/browse/HARMONY-1439?page=comments#action_12434133
Most of wiki module pages were updated last time several months ago.
Do they have actual information?
2006/9/13, Paulex Yang [EMAIL PROTECTED]:
Discussion on dev-list is generally first choice, I totally agree with
that. Wiki is just supplement to record somewhat significant work needs
longer
AFAIK some of tests wrongly release resources which are necessary for
the next one. So each single test passes, but if you run series - it
fails. Using flag forkmode=perTest allows avoid this.
2006/9/13, Mikhail Loenko [EMAIL PROTECTED]:
I've committed the changes to exclude list. Now the tests
2006/9/13, Andrew Zhang [EMAIL PROTECTED]:
I suggest that if the bug was fixed for some reason, we should change the
component too, i.e, classlib instead of non-bug difference from RI.
+1
Another question is for those real non-bug difference from RI JIRAs, what
should be the final status,
java.lang.ArrayIndexOutOfBoundsException
at java.awt.Polygon.addPoint(Polygon.java:262)
at Test.main(Test.java:8)
=== Harmony
nothing
Comments?
2006/9/12, Denis Kishenko (JIRA) [EMAIL PROTECTED]:
[classlib][awt] RI Polygon.add(int,int) throws exception after Polygon(new
int[2
Boris thank you for your question. I asked myself the same question
and choose the same answer as you. Unfortunately as people wrote above
we were wrong and they are reasonable.
I have already written patch for HARMONY-1120 to follow RI behavior.
2006/9/5, Stepan Mishura [EMAIL PROTECTED]:
On
By the way, people what do you think about HARMONY-1110?
Problem is we have to reproduce behavior of pattern parser without
specification. There is only one example in Java doc which doesn't
allow understand when pattern is incorrect.
2006/9/5, Denis Kishenko [EMAIL PROTECTED]:
Boris thank you
People what do you think about HARMONY-1110?
Problem is we have to reproduce behavior of ChoiceFormat pattern parser without
specification. There is only one example in Java doc which doesn't
allow understand when RI assumes that pattern is incorrect.
Thanks
--
Denis M. Kishenko
Intel
#
[1] 1.0|1.0|1.0|1.0
Harmony
[|||]
[2#a|||]
[1]
2006/9/5, Richard Liang [EMAIL PROTECTED]:
On 9/5/06, Denis Kishenko [EMAIL PROTECTED] wrote:
People what do you think about HARMONY-1110?
Problem is we have to reproduce behavior of ChoiceFormat pattern parser
without
specification
It's a good idea to add Patch available status
+1
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
as well.
geir
Mark Hindess wrote:
On 28 August 2006 at 16:14, Denis Kishenko [EMAIL PROTECTED] wrote:
2006/8/25, Mark Hindess [EMAIL PROTECTED]:
Thanks for helping by looking at these. If you spot others and send
messages and/or add comments in JIRA I'll take a look at them.
Mark
2006/8/25, Mark Hindess [EMAIL PROTECTED]:
Thanks for helping by looking at these. If you spot others and send
messages and/or add comments in JIRA I'll take a look at them.
Mark
There are a lot of unassigned issues with patches in JIRA. For example
most of issues listed bellow were created
2006/8/14, Alexey Petrenko [EMAIL PROTECTED]:
2. Harmony implementation of BufferedWriter.write(char[], int, int) throws
ArrayIndexOutOfBoundsException while RI throws IndexOutOfBoundsException.
I think that this is not a problem since
ArrayIndexOutOfBoundsException is a subclass of
: Harmony
Issue Type: Bug
Components: Non-bug differences from RI
Reporter: Denis Kishenko
RI returns 0 for java.text.Bidi.getLength() if object was created via Bidi(String
paragraph, int flags) with flag61 like below:
Bidi bd = new Bidi(Java is the best, 62);
From
anything about any exceptions. I filed this issue
as non-bug difference.
Does anybody have objections?
2006/8/9, Denis Kishenko (JIRA) [EMAIL PROTECTED]:
[class][security] MessageDigest.update(byte[], int, int) incompatible with RI
exceptions
Key: HARMONY-1033
URL: http://issues.apache.org/jira/browse/HARMONY-1033
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Denis Kishenko
Assigned To: Nathan Beyer
Attachments: Character.patch
2006/8/2, Andrew Zhang [EMAIL PROTECTED]:
Does following exception check code work?
if (index 0 || index = limit || limit 0 || limit seq.length)
{
throw new IndexOutOfBoundsException();
}
The above code also throws NullPointerException if seq is null, and the
order
Let's discuss compatibility issue.
Test
-
import java.math.BigDecimal;
public class Test {
public static void main(String args[] ) {
BigDecimal.valueOf(0L, -22).shortValueExact();
}
}
Results
[EMAIL PROTECTED]:
2006/7/27, Denis Kishenko [EMAIL PROTECTED]:
2006/7/27, Nathan Beyer [EMAIL PROTECTED]:
The serialized form is part of the public contract and we strive to meet all
parts of the public contract, so if you know of specific cases, please log
some issues about them
28 Jul 2006 16:03:33 +0700, Egor Pasko [EMAIL PROTECTED]:
On the 0x1B3 day of Apache Harmony Anton Luht wrote:
On 7/27/06, Ilya Okomin [EMAIL PROTECTED] wrote:
Sounds great to have a page with algorithms tricks used in Harmony project!
Maybe it's worth to put information about algorithms to
2006/7/28, Alexey Petrenko [EMAIL PROTECTED]:
2006/7/27, Denis Kishenko [EMAIL PROTECTED]:
Unfortunately
1. class can has temporary private fields (see BasicStroke.java)
We can mark such fields as transient. As for serialization.
2. class can has final fields which take part in hash code
2006/7/26, Alex Blewitt [EMAIL PROTECTED]:
There are other approaches that could be used instead of this. For
example, the value of the hashCode could be cached in a private
variable and then invalidated when any setValue() methods are called.
One could even imagine a superclass performing this
2006/7/27, Nathan Beyer [EMAIL PROTECTED]:
The serialized form is part of the public contract and we strive to meet all
parts of the public contract, so if you know of specific cases, please log
some issues about them. There are a few exceptional cases, like TimeZone,
that may be incompatible,
2006/7/27, Ivanov, Alexey A [EMAIL PROTECTED]:
It can handle Objects and uses object.hashCode().
Yep, HashCode has been already doing this.
combine() performs the calculations. append() is a convenience method
that returns the object it was called upon, so that your example can be
re-written
Igor
You suggest optimize rendering on BufferedImage, don't you?
You have decision but it has problem, isn't it?
I don't clearly understand the problem you have, may be some pictures
help us to help you. Could you please explain how
Graphics2D.drawLine() will work using new rendering?
Thanks
2006/7/27, Igor Stolyarov [EMAIL PROTECTED]:
Denis I hope you understand that I discuss BufferedImage rendering. First of
all I offer draw all primitive for example on the DirectDrawSurface which
will be cache of BufferedImage and then blit this Surface to the
PrimarySurface (Screen). When we
+1
2006/7/27, Anton Luht [EMAIL PROTECTED]:
On 7/27/06, Ilya Okomin [EMAIL PROTECTED] wrote:
Sounds great to have a page with algorithms tricks used in Harmony project!
Maybe it's worth to put information about algorithms to Wiki :
http://wiki.apache.org/harmony/ ?
--
Regards,
Anton Luht,
2006/7/27, Ilya Okomin [EMAIL PROTECTED]:
As for this thread I would suggest next tactics: to state issue here (thread
is a kind of a list of issues) and initiate issue discussion in separated
thread if it is worthy of it. Otherwise one unfinished trick discussion will
get lost behind the more
2006/7/27, Stefano Mazzocchi [EMAIL PROTECTED]:
Keep in mind that most of java people (and most people around here) are
server side people. At the very best, they have written one swing
application in their life. If you're very lucky, they have written their
own swing components (me, for
Hi all
There are a lot of algorithmic tricks in graphics module (awt, geom). But as
I understand this module hasn't been integrated yet completely. By the way
does anybody there has experience and is interested in graphics algorithms?
I do =)
I can recommend
I have watched over 100 hashCode implementations.
Frequently hash code is a sum of several other hashes. Such implementation
kill hash idea, it's terrible.
Here is some examples
public int hashCode() {
int result = 0;
IteratorMap.EntryK, V it = entrySet().iterator();
.
So if you have tests, I'm +1
On 7/26/06, Denis Kishenko [EMAIL PROTECTED] wrote:
Any comments?
--
Mikhail Fursov
--
Denis M. Kishenko
Intel Middleware Products Division
2006/7/26, Krzysztof Sobolewski [EMAIL PROTECTED]:
How about
return Arrays.hashCode(new Object[] {x, y, name});
?
Short, concise, a bit allocation-heavy (esp. for primitives (boxing)), but
for non-critical hashes should be fine.
/lurker-mode-off
Yep, good and simple way.I have already thought
2006/7/13, Tim Ellison [EMAIL PROTECTED]:
When you load the messages using a ResourceBundle they also get loaded
all at once though, right?
Ops, you are right.
So question is which method is better?
message = Messages.getString(key.one);
or
message = Messages.key_one;
We have to do
2006/7/19, Alexey Petrenko [EMAIL PROTECTED]:
2006/7/19, Denis Kishenko [EMAIL PROTECTED]:
2006/7/13, Tim Ellison [EMAIL PROTECTED]:
When you load the messages using a ResourceBundle they also get loaded
all at once though, right?
Ops, you are right.
Yes, but do not forget
Hi all !
I would like to take part in internationalization discussion.
I agree with Alexey Petrenko that traditional way is better for work with
exception messages.
Yes, Eclipse method has much faster access but needs to load ALL module
messages at once. Exception messages are used rarely, so
79 matches
Mail list logo
