Re: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Naoto Sato
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

[jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Damon Nguyen
Hi all, This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was

Re: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Justin Lu
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons wrote: >> @jonathan-gibbons I just realized that this change to the German file >> matches the file with the Japanese and Chinese localized files. By that I >> mean the "backwards" translations are also present for the Japanese and >> Chinese

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-12 Thread Justin Lu
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-12 Thread Phil Race
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Naoto Sato
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some for Japanese), but > looks good

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alisen Chung
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some for Japanese), but > looks good

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alisen Chung
On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties >> line 32: >> >>> 30: border.jobattributes=作业属性 >>> 31: border.media=介质 >>> 32: border.output=出纸 >> >> What triggered this ? Just someone noticing it and

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alisen Chung
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alexey Semenyuk
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Damon Nguyen
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Damon Nguyen
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote: >> "Ausgabefächer" is the best German translation here. > > The reason for going with "Bereich (area)" instead of "Fach (compartment)" is > that an area is more general compared to a compartment. At least in German: > every "Fach" is a

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Chris Plummer
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Justin Lu
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote: >> Yeah, I believe you're right. Noted as something else to file against the >> translation tool. > > Just out of curiosity, do we know why `\t` was attached in the first place? I > don't think it is with the original English properties. I

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Naoto Sato
On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen wrote: >> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties >> line 278: >> >>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements >>> "{0}" verweist auf das nicht deklarierte

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Pavel Rappo
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Sun, 9 Jun 2024 19:35:04 GMT, Justin Lu wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties > line 285: >

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Mon, 10 Jun 2024 20:34:10 GMT, Damon Nguyen wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties >> line 409: >> >>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl >>> ein nicht bedingtes Muster als auch ein Standardlabel

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Tue, 11 Jun 2024 05:43:12 GMT, Christian Stein wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties >> line 66: >> >>> 64: label.size=Göße: >>> 65: label.source=: >>> 66: label.outputbins=Aächer: >> >> How confident are we in this ? >> google translate says

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Mon, 10 Jun 2024 22:48:13 GMT, Damon Nguyen wrote: >> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java >> line 325: >> >>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"}, >>> 324: {"unknown", "unbekannt"}, >>> 325:

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Christian Stein
On Mon, 10 Jun 2024 20:19:51 GMT, Phil Race wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties > line 66: > >> 64:

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Jonathan Gibbons
On Mon, 10 Jun 2024 21:38:18 GMT, Damon Nguyen wrote: >> While we do not translate Java keywords (when used as such, e.g. "`class` >> not allowed here"), and option names (e.g. `--class-path`) we have typically >> translated other text that is not mandated by the language or tools, (e.g. >>

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 22:19:49 GMT, Chris Plummer wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java > line 325:

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Chris Plummer
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Damon Nguyen
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Joe Wang
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: > Did not look at each for translation accuracy (did some for Japanese), but > looks good overall. It's great to see diffs in native languages, rather than > those cryptic `\u` notation! Justin's tool is responsible for this. Made the

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Naoto Sato
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:20:52 GMT, Phil Race wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:20:26 GMT, Jonathan Gibbons wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >>

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Jonathan Gibbons
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Phil Race
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Jonathan Gibbons
On Sun, 9 Jun 2024 22:07:44 GMT, Damon Nguyen wrote: >> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties >> line 183: >> >>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach >>> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur >>>

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Sun, 9 Jun 2024 22:49:11 GMT, Justin Lu wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Justin Lu
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The

RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. The translation tool adjusted some definitions, which causes some changes in

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Alisen Chung
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The