Re: [Tigervnc-devel] TigerVNC + noVNC: Security options?

2011-12-02 Thread Martin Koegler
On Fri, Dec 02, 2011 at 10:35:31AM -0500, Brian Hinz wrote: > The missing parameters is an easy fix, I'll commit those changes for the > java viewer tonight (FYI, the Fltk viewer does not currently have those > parameters so if you need that functionality you should submit a feature > request to ge

Re: [Tigervnc-devel] TigerVNC + noVNC: Security options?

2011-12-02 Thread Martin Koegler
On Fri, Dec 02, 2011 at 02:45:45PM +, Dan Garton wrote: > > I'm not aware of any transparent signon. TigerVNC only allows: > > * No authentification > > * Classic VNC authentification > > * Authentification with username/password (default authentification > > provider > > is the system authenti

Re: [Tigervnc-devel] TigerVNC + noVNC: Security options?

2011-11-30 Thread Martin Koegler
On Wed, Nov 30, 2011 at 02:20:04PM -0500, Brian Hinz wrote: > I've noticed recently that both the Java client and Fltk viewers report > that the VeNCrypt SecType is being selected even when the server doesn't > offer it or even when it has been disabled altogether. I basically ported > what was i

Re: [Tigervnc-devel] TigerVNC + noVNC: Security options?

2011-11-30 Thread Martin Koegler
On Wed, Nov 30, 2011 at 06:03:36PM +, Dan Garton wrote: > I have kind of answered my own question. An option seems to be to run with > > "-SecurityTypes=VNCAuth,TLSVnc" > > This mandates a minimum of a secure authentication stage, and then the > client can be configured (but not forced) to en

Re: [Tigervnc-devel] Security for multiple client types

2011-11-23 Thread Martin Koegler
On Tue, Nov 22, 2011 at 04:26:44PM -0600, DRC wrote: > Android would be an easier target. I don't think it already has GnuTLS, > so it would probably be necessary to build those libraries and > statically link against them, but the Android Market does allow GPL'ed > software, so it would be theore

Re: [Tigervnc-devel] Security for multiple client types

2011-11-22 Thread Martin Koegler
On Tue, Nov 22, 2011 at 05:39:54PM +, Dan Garton wrote: > I'm still in the process of developing an integrated remote desktop system > for a specialist user base, and am using TigerVNC to great effect so far. > > I would like to enable client connections from standard Win/Mac/Lin > desktops (u

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-31 Thread Martin Koegler
On Wed, Aug 31, 2011 at 10:15:34AM +0200, Peter ?strand wrote: > On Tue, 30 Aug 2011, DRC wrote: > > >On 8/30/11 5:33 AM, Pierre Ossman wrote: > >>You seem to be providing good stuff, so I'd vote for you getting > >>commit rights. Adam? DRC? Any objections? > > > >No objections here-- just standar

[Tigervnc-devel] [PATCH] Support more menu keys

2011-08-30 Thread Martin Koegler
de = getMenuKeyCode(); // Need to repopulate the context menu as it contains references to // the menu key diff --git a/vncviewer/menukey.cxx b/vncviewer/menukey.cxx new file mode 100644 index 000..2e3a568 --- /dev/null +++ b/vncviewer/menukey.cxx @@ -0,0 +1,71 @@ +/* Copyright 2011 Ma

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-26 Thread Martin Koegler
ng a menu key command line parameter (X11 key symbols) - I tried to keep the interface the same. > What does everyone else think? Which interface is most important? > Should we perhaps have three columns to cater to both needs? The three column approach would proably be the best. Regards,

[Tigervnc-devel] [PATCH] Support more menu keys

2011-08-25 Thread Martin Koegler
to repopulate the context menu as it contains references to // the menu key diff --git a/vncviewer/keysyms.cxx b/vncviewer/keysyms.cxx new file mode 100644 index 000..240a522 --- /dev/null +++ b/vncviewer/keysyms.cxx @@ -0,0 +1,71 @@ +/* Copyright 2011 Martin Koegler + * Copyright 2011 Pier

Re: [Tigervnc-devel] xserver / cmake issues

2011-08-25 Thread Martin Koegler
ted to use something low - in the final version, I'll change this. Regards, Martin Koegler -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified manage

Re: [Tigervnc-devel] xserver / cmake issues

2011-08-24 Thread Martin Koegler
On Wed, Aug 24, 2011 at 11:06:06AM -0500, DRC wrote: > At any rate, I was able to reproduce the original issue after that, and > I checked in your patch to fix it. Just one more issue, the new build system install the man-pages to $prefix/man instead of $prefix/share/man - as used in all major di

Re: [Tigervnc-devel] xserver / cmake issues

2011-08-24 Thread Martin Koegler
On Tue, Aug 23, 2011 at 12:50:52PM -0500, DRC wrote: > On 8/17/11 4:01 PM, Martin Koegler wrote: > > First of all, Makefile.am is missing some include path, so that a out of > > source tree build fails (xserver 1.7): > > --- tigervnc-1.0.1.svn0.orig/unix/xserv

Re: [Tigervnc-devel] [Tigervnc-commits] SF.net SVN: tigervnc:[4645] trunk/common

2011-08-23 Thread Martin Koegler
it? Libtool builds to version automatically: One with -fPIC and one without. While linking, libtool selectes the correct version automatically. Regards, Martin Koegler -- EMC VNX: the world's simplest storage, startin

[Tigervnc-devel] xserver / cmake issues

2011-08-17 Thread Martin Koegler
erver leads to an linker error, because cmake only generates non-PIC object files (eg libnetwork). autotools+libtool did this automatically. Regards, Martin Koegler -- Get a FREE DOWNLOAD! and learn more about uberSVN ric

Re: [Tigervnc-devel] Testing with the 1.2 Alpha version

2011-07-20 Thread Martin Koegler
On Tue, Jul 19, 2011 at 06:01:47PM -0400, Robert Goley wrote: > The first issue is with the security types. I am specifying " > -SecurityTypes TLSVnc,VncAuth" on the server. When I connect with > all client options enabled, it uses TLSVnc. When I connect with ALL > TLS options unchecked, it stil

[Tigervnc-devel] Java Makefile

2011-05-31 Thread Martin Koegler
java/src/com/tigervnc/vncviewer/Makefile: | install: $(CLASSES) $(ARCHIVE) | $(CP) $(CLASSES) $(ARCHIVE) $(PAGES) $(INSTALL_DIR) Wouldn't be the following better: install: $(PAGES) $(ARCHIVE) $(CP) $(ARCHIVE) $(PAGES) $(INSTALL_DIR) I don't understand, why it installs the class fi

Re: [Tigervnc-devel] New portable vncviewer

2011-05-15 Thread Martin Koegler
On Fri, May 13, 2011 at 05:56:53PM -0400, Brian Hinz wrote: > Awesome! Thanks for making the class changes, that's been on my TODO list > since we discussed this last... You should look at the character encoding handling too: InStream.readString interprets input data as ISO-8859-1. CMsgReader.r

Re: [Tigervnc-devel] potential vulnerability in TLS secType?

2011-05-05 Thread Martin Koegler
On Thu, May 05, 2011 at 07:01:49AM -0400, Brian Hinz wrote: > Wouldn't this (also untested) work as well, and have the advantage of > relying on gnutls to verify that the handshake was completed? > > diff -Nr -C 6 rfb.unix/CSecurityTLS.cxx.bak rfb.unix/CSecurityTLS.cxx > *** rfb.unix/CSecurityTLS.

Re: [Tigervnc-devel] potential vulnerability in TLS secType?

2011-05-04 Thread Martin Koegler
On Wed, May 04, 2011 at 10:51:06PM -0400, Brian Hinz wrote: > I think that I just stumbled onto a possible security vulnerability in > CSecurityTLS. It seems as though CSecurityTLS::processMsg returns true > before the handshake has completed (possibly due to the "if (is.readU8() == > 0)" test on

Re: [Tigervnc-devel] New portable vncviewer

2011-03-15 Thread Martin Koegler
On Tue, Mar 15, 2011 at 01:34:42PM -0500, DRC wrote: > Our current Java viewer is based on the RealVNC code, not the > TightVNC-based viewer. In fact, it still says "RealVNC" whenever you > run it. :) It's on my long-term list of things to do to merge in a > bunch of features from the TurboVNC J

Re: [Tigervnc-devel] New pre-beta build uploaded

2011-03-11 Thread Martin Koegler
On Fri, Mar 11, 2011 at 02:56:51PM -0500, Robert Goley wrote: > You have been more fortunate then. My users always seem to find > those unknown or unlikely crashes or closes. We have used KDE/GNOME > in the past but they are kind of "heavy" and slow down the VNC > session performance when using

Re: [Tigervnc-devel] New pre-beta build uploaded

2011-03-11 Thread Martin Koegler
On Fri, Mar 11, 2011 at 04:05:00PM +0100, Adam Tkac wrote: > On Fri, Mar 11, 2011 at 08:41:02AM -0600, DRC wrote: > > Just so I fully understand the issue, what would you normally do if the WM > > crashes? Is there a reasonable way to recover in that case? > > When WM crashes then applications wh

Re: [Tigervnc-devel] Improvements for Windows installer

2011-03-09 Thread Martin Koegler
On Tue, Mar 08, 2011 at 08:33:20PM -0600, DRC wrote: > Windows is still suffering from the TLS refresh issue described earlier. > It affects VirtualGL as well (you have to move the mouse to see the 3D > application change frames.) I don't have the time to look into this at > the moment, but IMHO,

Re: [Tigervnc-devel] Security types on server

2011-03-02 Thread Martin Koegler
On Tue, Mar 01, 2011 at 08:53:27PM -0600, DRC wrote: > Is there a good reason why only VncAuth and TLSVnc are enabled on the > server by default? Would it be reasonable to enable the other secure > types as well? X509* make no sense without specifing certificates. *None and Plain should not be en

Re: [Tigervnc-devel] [PATCH] vncserver checks ~/.vnc/passwd when not needed and -TermOnLogout option

2011-03-02 Thread Martin Koegler
On Tue, Mar 01, 2011 at 05:13:33AM -0600, DRC wrote: > TurboVNC implements this more simply as a "vncserver -fg" switch, which > means "run in the foreground". It does the same thing you are doing > below, except that it uses the built-in kill() function, which is safer > than trying to invoke ano

Re: [Tigervnc-devel] Peculiar Refresh Issue with TLS

2011-02-26 Thread Martin Koegler
On Fri, Feb 25, 2011 at 07:06:39PM -0500, Robert Goley wrote: > Here are the results from using the different encodings: > > OpenBox Window Manager: > ZLRE: 11428 kbs (Server has a little load at the moment, > this was around 2 when tested earlier...)Has freezing issue > in TLS >

Re: [Tigervnc-devel] Peculiar Refresh Issue with TLS

2011-02-25 Thread Martin Koegler
On Fri, Feb 25, 2011 at 03:35:39PM -0600, DRC wrote: > Are you using a compositing window manager by chance? I noticed a > similar issue with my installation of Gnome, and I think it was related > to me having tried to get it working with compiz earlier. I didn't have > time to look into it, so I

Re: [Tigervnc-devel] PAM only works for local stored passwords

2011-02-25 Thread Martin Koegler
On Thu, Feb 24, 2011 at 09:44:20PM +0100, Sebastiaan Breedveld wrote: > I am testing the 1.1 pre-beta (2/21/11) 64 bit Linux binary on an Ubuntu > Natty machine. According to previous posts, I start the VNC server as: > ./Xvnc :4 -SecurityTypes=VeNCrypt,Plain -PlainUsers=sebastiaan > pam_service=

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-23 Thread Martin Koegler
On Sun, Feb 20, 2011 at 06:27:02PM +0100, Martin Koegler wrote: > I did some profiling: > > With TLS, the vncviewer hot spots are: > * ~23% in libgcrypt > * ~14% in the jpeg code > * ~14% again in the jpeg code > > With TLS, the Xvnc hot spots are: > * 17.4% in zli

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-20 Thread Martin Koegler
On Sat, Feb 19, 2011 at 04:17:14PM -0600, DRC wrote: > On 2/18/11 4:55 AM, Adam Tkac wrote: > Definite improvement. Here's what I now see with VirtualGL: > > Machine 1: Pentium 4 Xeon 2.8 GHz single core > Machine 2: AMD X2 5050e 2.6 GHz dual core > > 1-->2 > - >

Re: [Tigervnc-devel] Changing default security types

2011-02-18 Thread Martin Koegler
On Thu, Feb 17, 2011 at 04:09:36PM -0600, DRC wrote: > On 2/17/11 3:38 PM, Martin Koegler wrote: > > This decision has been commited by Adam in rev 4093 and 4094. > > > > He has ripped out the support switching between Client and Server > > security type order an

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-18 Thread Martin Koegler
On Thu, Feb 17, 2011 at 09:06:33AM +0100, Martin Koegler wrote: > On Wed, Feb 16, 2011 at 03:21:38AM -0600, DRC wrote: > > However, I did discover that playing the 1920x1080 version of Big Buck > > Bunny from the beginning using VLC in full-screen mode makes a good 2D > > benc

Re: [Tigervnc-devel] Changing default security types

2011-02-17 Thread Martin Koegler
On Thu, Feb 17, 2011 at 01:36:30PM -0600, DRC wrote: > If I set the types as you describe below, it doesn't work how I would > expect. The client will always use VncAuth if the server supports it, > regardless of the preferred order on the server. That's not what I > want. I want the client to t

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-17 Thread Martin Koegler
On Wed, Feb 16, 2011 at 03:21:38AM -0600, DRC wrote: > However, I did discover that playing the 1920x1080 version of Big Buck > Bunny from the beginning using VLC in full-screen mode makes a good 2D > benchmark. The beginning of this movie has full-scene motion on almost > every frame, so if you s

Re: [Tigervnc-devel] Patch to integrate libssh

2011-02-16 Thread Martin Koegler
On Tue, Feb 15, 2011 at 04:42:32PM -0600, DRC wrote: > On 2/15/11 3:11 PM, Martin Koegler wrote: > > Making the vncviewer ssh into the server as the user, detecting all > > running VNC servers of the user and finally let the user select to > > connect to one instance or sta

Re: [Tigervnc-devel] Patch to integrate libssh

2011-02-15 Thread Martin Koegler
On Tue, Feb 15, 2011 at 08:22:15AM -0700, Mike Fisk wrote: > 1. Complete session management functionality including flexible > authentication, strong encryption, spawning new sessions, reconnecting > to existing sessions, etc. I lump a lot of things together that do > not have to be part of the

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-14 Thread Martin Koegler
On Mon, Feb 14, 2011 at 02:35:42PM -0600, DRC wrote: > On 2/14/11 2:25 AM, Martin Koegler wrote: > I disagree. I think there is something system-specific that is > occurring and that you would be observing this problem very plainly if > you were using my system. Others on different

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-14 Thread Martin Koegler
On Sun, Feb 13, 2011 at 04:32:46PM -0600, DRC wrote: > So what exactly is a "default" Linux installation? I don't think anyone > can reasonably conclude that what is true for their Linux installation > is true for all Linux installations. The performance problems are triggered by running running

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-13 Thread Martin Koegler
On Fri, Feb 11, 2011 at 10:53:48AM -0600, DRC wrote: > I would still be interested in knowing whether it would be feasible to > use the auth extensions without GnuTLS. The main question is: How much more fragementation should be added to the VNC world? qemu has eg. implemented VeNCrypt: http://

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-13 Thread Martin Koegler
On Sat, Feb 12, 2011 at 03:19:48PM -0600, DRC wrote: > You have to run glxspheres with vglrun. Otherwise, it will use the > software OpenGL renderer in TigerVNC, and that will be the bottleneck, > not TigerVNC's image pipeline. > > Also realize that the methodology is not just running GLXspheres

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-12 Thread Martin Koegler
On Fri, Feb 11, 2011 at 10:53:48AM -0600, DRC wrote: > On 2/11/11 2:17 AM, Martin Koegler wrote: > >> What do you mean "still get 20 Mbit"? You mean Megapixels/second? Or > >> do you mean Megabits/second of throughput? Because without VeNCrypt, my > > >

Re: [Tigervnc-devel] Patch to integrate libssh

2011-02-11 Thread Martin Koegler
On Fri, Feb 11, 2011 at 02:22:04PM -0600, DRC wrote: > Well, yes and no. libssh requires OpenSSL, right? That means we have > to statically link with OpenSSL in order to produce cross-compatible > binaries. Static linking with OpenSSL is, I can tell you from > experience, not my favorite pastime

Re: [Tigervnc-devel] Integration work completed

2011-02-11 Thread Martin Koegler
On Thu, Feb 10, 2011 at 09:45:22PM -0600, DRC wrote: > In the course of this work, I've discovered much about how to build > GnuTLS (and how not to.) I'm not sure how people are currently using > that technology on Windows, but there doesn't seem to be a sane way to > build static libraries for Gn

Re: [Tigervnc-devel] The 1_1 branch and 1.1 beta release

2011-02-11 Thread Martin Koegler
On Fri, Feb 11, 2011 at 12:09:17PM -0600, DRC wrote: > On 2/11/11 2:24 AM, Martin Koegler wrote: > > It should be possible (HAVE_GNUTLS not defined). In that case, > > VeNCrypt + Plain are still available. > > > Right you are. I built without GnuTLS, and Plain defi

Re: [Tigervnc-devel] The 1_1 branch and 1.1 beta release

2011-02-11 Thread Martin Koegler
On Thu, Feb 10, 2011 at 04:18:52PM -0600, DRC wrote: > On 2/10/11 4:00 PM, Martin Koegler wrote: > > Please don't mix up Encryption with VeNCrypt. VeNCrypt consists of two > > parts: > > > > 1) An extended chooser, which has enough available security type

Re: [Tigervnc-devel] The 1_1 branch and 1.1 beta release

2011-02-11 Thread Martin Koegler
On Thu, Feb 10, 2011 at 04:11:08PM -0600, DRC wrote: > On 2/10/11 3:39 PM, Robert Goley wrote: > You also have to create a new PAM service called "vnc". I did this by > copying /etc/pam.d/passwd to /etc/pam.d/vnc, but different systems do > this differently. Some systems may use a pam.conf file,

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-11 Thread Martin Koegler
On Thu, Feb 10, 2011 at 04:40:13AM -0600, DRC wrote: > On 2/10/11 2:24 AM, Martin Koegler wrote: > >> I really wonder how useful of a feature built-in session encryption is > >> if it's this slow. Without encryption, I can get approximately 20 > >> Megapixels/se

Re: [Tigervnc-devel] The 1_1 branch and 1.1 beta release

2011-02-10 Thread Martin Koegler
On Thu, Feb 10, 2011 at 03:46:17PM -0600, DRC wrote: > On 2/10/11 3:35 PM, Martin Koegler wrote: > >> We could always port over an authentication method that supports > >> username/password without the full encryption framework. I don't have > >> any object

Re: [Tigervnc-devel] The 1_1 branch and 1.1 beta release

2011-02-10 Thread Martin Koegler
On Thu, Feb 10, 2011 at 04:01:26AM -0600, DRC wrote: > We had one-- the Tight Security Extension. :) I signed off on removing > it before I fully understood the ramifications. Please don't mix up Encryption with VeNCrypt. VeNCrypt consists of two parts: 1) An extended chooser, which has enough

Re: [Tigervnc-devel] The 1_1 branch and 1.1 beta release

2011-02-10 Thread Martin Koegler
On Thu, Feb 10, 2011 at 10:27:33AM +0100, Pierre Ossman wrote: > On Wed, 09 Feb 2011 03:15:14 -0600 > DRC wrote: > > > > > I could write a book on the difficulties I've had with GnuTLS. I am > > ultimately finding that I have to pretty much build it from source on > > all of the platforms. Hon

Re: [Tigervnc-devel] Severe performance problem and possible Zlib issue with r4280

2011-02-10 Thread Martin Koegler
On Wed, Feb 09, 2011 at 10:09:25PM -0600, DRC wrote: > > An unrelated issue is that whenever I try to use the vncviewer GUI to > > set the Zlib level to something other than the default, the server > > crashes (the log says "ZlibOutStream: deflate failed".) In my self compiled windows viewer, I ca

[Tigervnc-devel] Compiling under Windows using CMake

2011-01-25 Thread Martin Koegler
There has been checked in some GNUTLS support for cmake recently, so I wanted to try it: Installing VC Express, the newst binary of CMake and GNUTLS for Windows was easy. Calling cmake on a clean tigervnc checkout yields to an (warning?) message, while determining the build date [Only on the firs

Re: [Tigervnc-devel] Exporting only one window via TigerVNC

2010-12-18 Thread Martin Koegler
On Sat, Dec 18, 2010 at 06:47:08PM +0100, Gabriele Tedeschi wrote: > is it possible to export only one window via TigerVNC server, running on > Windows 7 64 bit ? As far as I know, vnc only exports the whole desktop. Regards, Martin Kögler ---

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-11 Thread Martin Koegler
Two general comments: * This patch will probably break the windows build, as it adds an msg!=NULL assert without setting the variable on Windows. The best solution would be to add the windows implementation too. * CSecurityTLS is only available, if tigervnc is built with GNUTLS. So it should brea

Re: [Tigervnc-devel] [PATCH 00/10] VeNCrypt java support

2010-11-11 Thread Martin Koegler
On Thu, Nov 11, 2010 at 03:42:39PM +0100, Adam Tkac wrote: > > 6. Implment TLS security type > > 7. Implement X509 Security types > > Just a design question. Wouldn't be better to merge TLSTunnel, > TLSTunnelBase and X509Tunnel classes to the one class as I did it in > common/rfb/CSecurityTLS.*?

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-10 Thread Martin Koegler
On Wed, Nov 10, 2010 at 01:24:35PM +0100, Guillaume Destuynder wrote: > No difference for me, I did as recommended on the IRC channel. I can put > it directly there, too. If there's already a patch for this however I > don't mind if it's used instead, in fact, it would be great too. My implementio

Re: [Tigervnc-devel] [PATCH 00/10] VeNCrypt java support

2010-11-07 Thread Martin Koegler
On Sun, Nov 07, 2010 at 12:52:54PM -0600, DRC wrote: > TurboVNC 1.0 uses the Tight security type to implement its auth > extensions, and it relies upon the ability to advertise capabilities to > the client using that mechanism. Whether or not the Tight security type > actually does anything in our

[Tigervnc-devel] [PATCH 03/10] Support asking for a user name

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/AuthPanel.java | 13 +++-- java/src/com/tigervnc/vncviewer/VncViewer.java | 31 +++- 2 files changed, 40 insertions(+), 4 deletions(-) diff --git a/java/src/com/tigervnc/vncviewer/AuthPanel.java b

[Tigervnc-devel] [PATCH 08/10] Disable TightVNC security type

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/SConnection.cxx|2 +- java/src/com/tigervnc/vncviewer/RfbProto.java |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/rfb/SConnection.cxx b/common/rfb/SConnection.cxx index bc4c982..fdd8da9 100644

[Tigervnc-devel] [PATCH 06/10] Implment TLS security type

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/Makefile |4 +- java/src/com/tigervnc/vncviewer/RfbProto.java | 13 +++ java/src/com/tigervnc/vncviewer/TLSTunnel.java | 51 java/src/com/tigervnc/vncviewer/TLSTunnelBase.java | 86

[Tigervnc-devel] [PATCH 02/10] Implement VeNCrypt chooser

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/RfbProto.java | 33 +- java/src/com/tigervnc/vncviewer/VncViewer.java | 43 ++- 2 files changed, 58 insertions(+), 18 deletions(-) diff --git a/java/src/com/tigervnc/vncviewer

[Tigervnc-devel] [PATCH 09/10] Remove TightVNC security type from server

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/ConnParams.cxx |2 +- common/rfb/ConnParams.h|1 - common/rfb/SConnection.cxx | 170 common/rfb/SConnection.h |9 --- 4 files changed, 1 insertions(+), 181 deletions(-) diff --git a

[Tigervnc-devel] [PATCH 07/10] Implement X509 Security types

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/Makefile|4 +- java/src/com/tigervnc/vncviewer/RfbProto.java |8 ++ java/src/com/tigervnc/vncviewer/VncViewer.java | 15 java/src/com/tigervnc/vncviewer/X509Tunnel.java | 103 +++ 4

[Tigervnc-devel] [PATCH 00/10] VeNCrypt java support

2010-11-07 Thread Martin Koegler
vnc with precompiled, GNUTLS enabled windows binaries and the VeNCrypt project can be declared as superseded. Regards, Maritn Kögler Martin Koegler (10): 1. Add VeNCrypt security types 2. Implement VeNCrypt chooser 3. Support asking for a user name 4. Implement Plain Security type 5. Add simple Mes

[Tigervnc-devel] [PATCH 05/10] Add simple Message Box implementation

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/Dialog.java | 80 ++ java/src/com/tigervnc/vncviewer/Makefile|6 +- java/src/com/tigervnc/vncviewer/MessageBox.java | 82 +++ 3 files changed, 166 insertions(+), 2

[Tigervnc-devel] [PATCH 04/10] Implement Plain Security type

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/RfbProto.java | 12 java/src/com/tigervnc/vncviewer/VncViewer.java |8 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/java/src/com/tigervnc/vncviewer/RfbProto.java b/java/src/com

[Tigervnc-devel] [PATCH 10/10] Remove Tightvnc Security type from java client

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/RfbProto.java | 145 java/src/com/tigervnc/vncviewer/VncViewer.java | 10 +-- 2 files changed, 1 insertions(+), 154 deletions(-) diff --git a/java/src/com/tigervnc/vncviewer/RfbProto.java b/java/src

[Tigervnc-devel] [PATCH 01/10] Add VeNCrypt security types

2010-11-07 Thread Martin Koegler
Signed-off-by: Martin Koegler --- java/src/com/tigervnc/vncviewer/RfbProto.java | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/java/src/com/tigervnc/vncviewer/RfbProto.java b/java/src/com/tigervnc/vncviewer/RfbProto.java index 22cc113..dc7aa2e 100644

[Tigervnc-devel] Updated debian source packages

2010-11-03 Thread Martin Koegler
I have updated the tigervnc debian packages for squeeze based (on a current svn snapshoot) for myself. If somebody is interessted: http://e9925248.users.sourceforge.net/tigervnc To build them, install build-essential, extract with dpkg-source -x <.dsc file> and build with dpkg-buildpackage -rfa

[Tigervnc-devel] [PATCH] Win Password validator

2010-11-02 Thread Martin Koegler
--git a/common/rfb/WinPasswdValidator.cxx b/common/rfb/WinPasswdValidator.cxx new file mode 100644 index 000..9d6dafb --- /dev/null +++ b/common/rfb/WinPasswdValidator.cxx @@ -0,0 +1,49 @@ +/* Copyright (C) 2005-2006 Martin Koegler + * Copyright (C) 2006 OCCAM Financial Technology + * + * This

[Tigervnc-devel] [PATCH] Use correct settings for 24 bit color depth

2010-11-02 Thread Martin Koegler
Signed-off-by: Martin Koegler --- unix/xserver/hw/vnc/xvnc.cc |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/unix/xserver/hw/vnc/xvnc.cc b/unix/xserver/hw/vnc/xvnc.cc index 5ce6163..5e63b34 100644 --- a/unix/xserver/hw/vnc/xvnc.cc +++ b/unix/xserver/hw/vnc/xvnc.cc

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-10-27 Thread Martin Koegler
0; > +} So it only stores the last used certificate. Users with more than one vnc server can take no advantage, as the certificate is overwritten again and again. > // CConnection callback methods > > Index: common/rfb/CSecurityTLS.cxx > ======= > --- common/rfb/CSecurityT

Re: [Tigervnc-devel] build-xorg improvements

2010-10-01 Thread Martin Koegler
On Fri, Oct 01, 2010 at 02:38:53PM -0500, DRC wrote: > I agree. SourceForge has mediawiki pre-installed, so projects such as > ours can choose to use that for our web site instead of a static page. Last time I looked at mediawiki offered by SoureForge, edit rights must be granted by the wiki admi

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-30 Thread Martin Koegler
On Wed, Sep 29, 2010 at 05:37:14PM -0500, DRC wrote: > On 9/20/10 3:42 AM, Adam Tkac wrote: > > Which version of autoconf are you using? > > The version that ships with RHEL 4 (2.59). > > The attached patch seems to make things work properly. Question for > Martin: Is the "while(0)" really nece

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-18 Thread Martin Koegler
On Thu, Sep 16, 2010 at 03:00:26AM -0500, DRC wrote: > On 9/9/10 2:11 AM, Martin Koegler wrote: > Yes, here is what is added to my config.h: > > > /* Is gnutls_set_global_errno present */ > /* #undef gnutls_transport_set_global_errno */(A) > > > so that is indeed the

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-09 Thread Martin Koegler
On Wed, Sep 08, 2010 at 02:14:55AM -0500, DRC wrote: > However, when I attempted to apply the patch to work around this, I got > a worse build error: > > gcc4 -DHAVE_CONFIG_H -I. -I/home/drc/worksrc/tigervnc/common/os -I../.. > -I/home/drc/worksrc/tigervnc/common -O3 -static-libgcc -fPIC -Wall -M

Re: [Tigervnc-devel] File missing from build?

2010-09-06 Thread Martin Koegler
On Mon, Sep 06, 2010 at 01:00:01PM -0500, DRC wrote: > It seems as if we're missing common/rfb/UnixPasswordValidator.h, which > is needed to build the Plain sec. type. The commit adding the server side PAM code is missing some files. Regards, Martin Kögler ---

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-03 Thread Martin Koegler
On Fri, Sep 03, 2010 at 07:50:07AM -0600, DRC wrote: > On 9/3/10 12:00 AM, Martin Koegler wrote: > >The client side honors the Security Type order of the server - code > >for using the client side order was removed with "Remove unused > >CConnection::setClientSecTypeOrde

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-02 Thread Martin Koegler
On Thu, Sep 02, 2010 at 08:48:47PM -0600, DRC wrote: > On 9/2/10 9:50 AM, Adam Tkac wrote: > > This type is, by default, disabled on the server. It must be enabled > > via commandline parameter (-SecurityTypes). Client has it disabled as > > well but if user specify he wants to use it (and server h

Re: [Tigervnc-devel] [PATCH] Pam based Plain implementation

2010-09-02 Thread Martin Koegler
On Thu, Sep 02, 2010 at 04:14:20PM +0200, Adam Tkac wrote: > On Thu, Sep 02, 2010 at 09:05:54AM +0200, Martin Koegler wrote: > > Signed-off-by: Martin Koegler > > --- > > > > Windows password validator is contained in the VeNCrypt sources. > > Ok, I will

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-02 Thread Martin Koegler
On Thu, Sep 02, 2010 at 10:42:17AM +0200, Adam Tkac wrote: > On Thu, Sep 02, 2010 at 09:05:52AM +0200, Martin Koegler wrote: > > Signed-off-by: Martin Koegler > > --- > > configure.ac |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > May I a

[Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-02 Thread Martin Koegler
Signed-off-by: Martin Koegler --- configure.ac |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 5acd762..f6dfc10 100644 --- a/configure.ac +++ b/configure.ac @@ -78,6 +78,8 @@ if test "x$enable_gnutls" = xyes; then AC

[Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-02 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/CSecurityPlain.cxx | 46 + common/rfb/CSecurityPlain.h | 36 common/rfb/Makefile.am|4 +- common/rfb/Security.cxx | 10 - 4 files changed, 93

[Tigervnc-devel] [PATCH] Pam based Plain implementation

2010-09-02 Thread Martin Koegler
Signed-off-by: Martin Koegler --- Windows password validator is contained in the VeNCrypt sources. common/rfb/Makefile.am |5 ++ common/rfb/Security.cxx | 21 +++ common/rfb/Security.h|3 + common/rfb/UnixPasswordValidator.cxx | 42

Re: [Tigervnc-devel] VeNCrypt related GUI improvements in UNIX client

2010-08-27 Thread Martin Koegler
On Fri, Aug 27, 2010 at 02:13:07PM +0200, Adam Tkac wrote: > Hello, > > I've just finished UNIX vncviewer GUI improvements. With attached > patches user can specify security parameters in the "Options" window. > > I've also uploaded screenshot of new GUI to > http://atkac.fedorapeople.org/2010-08

Re: [Tigervnc-devel] VeNCrypt related GUI improvements in UNIX client

2010-08-27 Thread Martin Koegler
On Fri, Aug 27, 2010 at 12:30:36PM -0500, DRC wrote: > Can you refresh my memory as to the fallback order of both the > encryption and auth options on the server end, as well as how a user > could configure the server to use only certain encrypt/auth options? A server command line option determine

Re: [Tigervnc-devel] [PATCH] Provide default pixel format for depth 32

2010-08-25 Thread Martin Koegler
On Wed, Aug 25, 2010 at 03:40:29PM +0200, Adam Tkac wrote: > On Tue, Aug 24, 2010 at 08:05:38AM +0200, Martin Koegler wrote: > > Libraries like qt segfault, if reader is enabled but this information > > is not set > > Commited with little modifications as r4124. Thanks for t

[Tigervnc-devel] [PATCH] Properly report transport errors to GNUTLS

2010-08-23 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rdr/TLSInStream.cxx | 27 --- common/rdr/TLSOutStream.cxx | 14 ++ 2 files changed, 26 insertions(+), 15 deletions(-) diff --git a/common/rdr/TLSInStream.cxx b/common/rdr/TLSInStream.cxx index f6bf334..7a9859e

[Tigervnc-devel] [PATCH] Provide default pixel format for depth 32

2010-08-23 Thread Martin Koegler
Libraries like qt segfault, if reader is enabled but this information is not set Signed-off-by: Martin Koegler --- unix/xserver/hw/vnc/xvnc.cc |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/unix/xserver/hw/vnc/xvnc.cc b/unix/xserver/hw/vnc/xvnc.cc index 15235e1

Re: [Tigervnc-devel] [PATCH 00/13] SecurityType handling

2010-07-23 Thread Martin Koegler
On Thu, Jul 22, 2010 at 04:02:52PM -0500, DRC wrote: > This makes the use of extended authentication types somewhat useless > from the point of view of a SysAdmin, though. If there is not a way for > them to enforce, or at least strongly encourage, the use of secure > authentication on a system-wi

Re: [Tigervnc-devel] [PATCH 00/13] SecurityType handling

2010-07-21 Thread Martin Koegler
On Wed, Jul 21, 2010 at 10:16:59AM +0200, Adam Tkac wrote: > > | bool SSecurityFactoryTLS::isSecTypeSupported(rdr::U32 secType) { > > | switch (secType) { > > | #ifdef HAVE_GNUTLS > > | case secTypePlain: > > | case secTypeTLSNone: > > | case secTypeTLSVnc: > > | case secTypeTLSPlain: > >

Re: [Tigervnc-devel] [PATCH 00/13] SecurityType handling

2010-07-21 Thread Martin Koegler
On Wed, Jul 21, 2010 at 12:48:05PM -0500, DRC wrote: > On 7/21/10 3:16 AM, Adam Tkac wrote: > > This is a valid argument but I would like to see feedback from other > > TigerVNC developers to decide which types should be enabled by > > default. I will open a separate thread for this. > > I am join

Re: [Tigervnc-devel] [PATCH 00/13] SecurityType handling

2010-07-20 Thread Martin Koegler
On Tue, Jul 20, 2010 at 05:25:16PM +0200, Adam Tkac wrote: Thank you for your effort. > On Sat, Jul 17, 2010 at 04:47:22PM +0200, Martin Koegler wrote: > > 2-4 fixes the security type parameter in the vncviewer. The viewer has the > > problem, that > > the handshake phase

[Tigervnc-devel] [PATCH 13/13] Move x509 certificate parameters

2010-07-17 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/SSecurityVeNCrypt.cxx | 10 -- common/rfb/SSecurityVeNCrypt.h |2 -- common/rfb/Security.cxx | 12 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/common/rfb/SSecurityVeNCrypt.cxx b/common/rfb

[Tigervnc-devel] [PATCH 09/13] Add logging code

2010-07-17 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/CSecurityVeNCrypt.cxx |7 +++ common/rfb/SSecurityVeNCrypt.cxx |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/common/rfb/CSecurityVeNCrypt.cxx b/common/rfb/CSecurityVeNCrypt.cxx index 12eed8f..d07df53 100644 --- a

[Tigervnc-devel] [PATCH 10/13] Pass Security instance to VeNCrypt security

2010-07-17 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/CSecurityVeNCrypt.cxx |2 +- common/rfb/CSecurityVeNCrypt.h |3 ++- common/rfb/SSecurityVeNCrypt.cxx |2 +- common/rfb/SSecurityVeNCrypt.h |3 ++- common/rfb/Security.cxx |4 ++-- 5 files changed, 8 insertions(+), 6

[Tigervnc-devel] [PATCH 11/13] Use SecurityType also as configuration for VeNCrypt

2010-07-17 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/CSecurityVeNCrypt.cxx | 19 +--- common/rfb/SSecurityVeNCrypt.cxx | 89 + common/rfb/SSecurityVeNCrypt.h |7 +--- common/rfb/Security.cxx |8 +++- 4 files changed, 13 insertions(+), 110

[Tigervnc-devel] [PATCH 07/13] Use U32 as internal SecurityType type

2010-07-17 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/Security.cxx | 34 +++--- common/rfb/Security.h | 21 +++-- 2 files changed, 34 insertions(+), 21 deletions(-) diff --git a/common/rfb/Security.cxx b/common/rfb/Security.cxx index 8ea7572..ad51f1b

[Tigervnc-devel] [PATCH 08/13] Support VeNCrypt Security types in normal security type parser

2010-07-17 Thread Martin Koegler
Signed-off-by: Martin Koegler --- common/rfb/Security.cxx | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/common/rfb/Security.cxx b/common/rfb/Security.cxx index ad51f1b..86328b3 100644 --- a/common/rfb/Security.cxx +++ b/common/rfb/Security.cxx

  1   2   >