Review Request 45221: Add a test run to exclude slow and not thread safe tests. It could be used for pre-commit jobs

2016-03-23 Thread Anne Yu
6m47.195s; Thanks, Anne Yu

Re: Sonar build

2016-03-25 Thread Anne Yu
Hi Colm, Could it be possible to have code coverage enabled from Sonar? Searched through the linked pages, couldn't find any. It would be very helpful to have sonar report with coverage numbers. Thanks in advance, Anne On Wed, Dec 16, 2015 at 9:02 AM, Colm O hEigeartaigh wrote: > Hi all, > > S

Re: Sonar build

2016-03-29 Thread Anne Yu
it would > be useful. Perhaps drop INFRA a mail to ask them if it possible to enable > it? > > Colm. > > On Fri, Mar 25, 2016 at 11:31 PM, Anne Yu wrote: > > > Hi Colm, > > > > Could it be possible to have code coverage enabled from Sonar? Searched > > th

Review Request 45502: SENTRY-1164: fix one e2e test failure on a real cluster; improved concurrent tests to be able to run locally.

2016-03-30 Thread Anne Yu
b96175797dfc8bf238722b6177a7800d569b7e8a sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java 7d3db2b135d3239410bb664dbf7aed5817ee01c0 Diff: https://reviews.apache.org/r/45502/diff/ Testing --- Passed precommit build. Thanks, Anne Yu

Re: [jira] [Commented] (SENTRY-514) Enable e2e tests for authorization V2

2016-03-30 Thread Anne Yu
Ic, we need to think of a way to align tests with checkins instead of running everthing. But this is not the scope of this jira. And it's good to know by default we are not running v2 tests. On Mar 30, 2016 6:27 PM, "Dapeng Sun (JIRA)" wrote: > > [ > https://issues.apache.org/jira/browse/SENT

Re: Review Request 45502: SENTRY-1164: fix one e2e test failure on a real cluster; improved concurrent tests to be able to run locally.

2016-03-31 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45502/#review126407 --- On March 30, 2016, 7:20 p.m., Anne Yu wrote: > > -

Re: Review Request 45502: SENTRY-1164: fix one e2e test failure on a real cluster; improved concurrent tests to be able to run locally.

2016-03-31 Thread Anne Yu
/diff/ Testing --- Passed precommit build. Thanks, Anne Yu

Re: Review Request 45221: Add a test run to exclude slow and not thread safe tests. It could be used for pre-commit jobs

2016-03-31 Thread Anne Yu
iff: https://reviews.apache.org/r/45221/diff/ Testing --- Test the running time on an ec2 cluster (large). Run mvn clean install first then mvn test. Full suite: 2039 tests, 92m58.727s; skipSlowAndNotThreadSafeTests run: 1027 tests, 6m47.195s; Thanks, Anne Yu

Re: Review Request 45153: SENTRY-1155: Add waiting time for getMetastoreClient for avoiding metastore isn't ready

2016-04-04 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45153/#review126957 --- Ship it! Ship It! - Anne Yu On March 22, 2016, 10:55 a.m

Re: Review Request 45152: SENTRY-1156: TestDbColumnLevelMetaDataOps should add `use database` for user session created

2016-04-04 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45152/#review126976 --- Ship it! Ship It! - Anne Yu On March 22, 2016, 7:38 a.m

Re: Sentry download links are all invalid

2016-04-06 Thread Anne Yu
Hi Tuong, Can you list the invalid links? We are in the process of moving from incubator to TLP. Thanks for reporting the issue, Anne On Wed, Apr 6, 2016 at 8:27 AM, Tuong Truong wrote: > Hi, > > Just notice that all the links for downloading various release of Sentry > are invalids including

PreCommit-SENTRY-Build still compiles incubating codes

2016-04-08 Thread Anne Yu
Hi, Just found out "PreCommit-SENTRY-Build" still compiling incubator-sentry repo so keep getting compiling errors. Can someone help fix it? https://builds.apache.org/job/PreCommit-SENTRY-Build/1437/artifact/test-output/install.txt [INFO] Installing /home/jenkins/jenkins-slave/workspace/PreCommi

Re: Review Request 45221: Add a test run to exclude slow and not thread safe tests. It could be used for pre-commit jobs

2016-04-11 Thread Anne Yu
share with other JVM processes. As far as why, need to dig more. - Anne --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45221/#review127956 --

Re: Review Request 45221: Add a test run to exclude slow and not thread safe tests. It could be used for pre-commit jobs

2016-04-12 Thread Anne Yu
mvn clean install first then mvn test. Full suite: 2039 tests, 92m58.727s; skipSlowAndNotThreadSafeTests run: 1027 tests, 6m47.195s; Thanks, Anne Yu

RE: Proposal for Apr Monthly Hangout

2016-04-13 Thread Anne Yu
Hi Team, On Thursday either after 8pm or 10am works for me. 6pm will be late for commuting home. Thanks, Anne On Apr 13, 2016 12:49 AM, "Ma, Junjie" wrote: > Hi Hao, > > 9:00 am or later is ok for me if possible, thanks for understanding. > > Best regards, > > Colin Ma(Ma Jun Jie) > > -Orig

Re: FAQs?

2016-04-21 Thread Anne Yu
Hi Bhooshan, Thanks for reporting this issue. If you have clear idea of what's going on, since you've spent time debugging the code, please feel free to create a jira (https://issues.apache.org/jira/browse/SENTRY/) then post a fix. Committers will be very happy to do the code review. Best, Anne

Re: FAQs?

2016-04-21 Thread Anne Yu
e there is one on wiki - so its at least > discoverable when someone does a search for this error with Sentry. > > - > Bhooshan > > On Thu, Apr 21, 2016 at 10:27 AM, Anne Yu wrote: > > > Hi Bhooshan, > > > > Thanks for reporting this issue. If you have

Review Request 46542: SENTRY-583: Add boundary condition test coverage to HDFS synchronization test suite around max #of groups

2016-04-21 Thread Anne Yu
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.615 sec - in org.apache.sentry.tests.e2e.hdfs.TestDbHdfsMaxGroups Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Thanks, Anne Yu

Re: Review Request 46542: SENTRY-583: Add boundary condition test coverage to HDFS synchronization test suite around max #of groups

2016-04-21 Thread Anne Yu
org.apache.sentry.tests.e2e.hdfs.TestDbHdfsMaxGroups Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Thanks, Anne Yu

Re: Review Request 46542: SENTRY-583: Add boundary condition test coverage to HDFS synchronization test suite around max #of groups

2016-04-26 Thread Anne Yu
> > How about test for external table outside of prefix? To check the ACLs > > are not changed by Sentry? You meant negative test? Could add one for sure. Will do it in the next patch. - Anne --- This is an auto

Re: Review Request 46542: SENTRY-583: Add boundary condition test coverage to HDFS synchronization test suite around max #of groups

2016-04-29 Thread Anne Yu
org.apache.sentry.tests.e2e.hdfs.TestDbHdfsMaxGroups Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.615 sec - in org.apache.sentry.tests.e2e.hdfs.TestDbHdfsMaxGroups Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Thanks, Anne Yu

Re: Review Request 46957: Sentry-1234: JDO exception for list_sentry_privileges_by_authorizable

2016-05-04 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46957/#review131741 --- Ship it! Ship It! - Anne Yu On May 4, 2016, 1:58 a.m., Hao

Re: Review Request 46542: SENTRY-583: Add boundary condition test coverage to HDFS synchronization test suite around max #of groups

2016-05-04 Thread Anne Yu
//reviews.apache.org/r/46542/#review131601 ------- On April 29, 2016, 8:44 p.m., Anne Yu wrote: > > --- > This is an automatically generated e-mail. To

Re: [ANNOUNCE] New Sentry Committers - Li Li and Colm O hEigeartaigh

2016-05-06 Thread Anne Yu
Congrats Lili and Colm. On May 6, 2016 10:26 AM, "Lenni Kuff" wrote: > I'm excited to announce that the Apache Sentry PMC has voted to invite Li > Li and Colm O hEigeartaigh as committers on the Apache Sentry project. > > Please join me in congratulating Li and Colm! > > Thanks, > Lenni >

Re: [DISCUSS] Wiki updates on "How to integrate with Sentry"

2016-05-07 Thread Anne Yu
Hi Bhooshan, https://cwiki.apache.org/confluence/display/SENTRY/Integrating+with+Sentry+New+Universal+Authorization+Model Thanks, Anne On Wed, Mar 9, 2016 at 12:35 PM, Bhooshan Mogal wrote: > Happy to review when the doc is available too. May have some feedback from > the work we're currently

Re: Review Request 45550: Fix some "major" issues identified by Sonarqube

2016-05-07 Thread Anne Yu
c/main/java/org/apache/sentry/hdfs/HMSPaths.java (line 45) <https://reviews.apache.org/r/45550/#comment196216> White spaces and all the following places which needs trimming. - Anne Yu On May 6, 2016, 10:28 a.m., Colm O hEigeartaigh wrote: > > ---

Review Request 47682: SENTRY-1230: Add filesystem tests to test Sentry with user data storage on S3. The tests can also be run on other types of fileSystems (ms azure, hdfs). Just ensure pass correct

2016-05-20 Thread Anne Yu
[INFO] Finished at: Fri May 20 17:09:38 PDT 2016 [INFO] Final Memory: 60M/825M [INFO] Thanks, Anne Yu

Re: Review Request 47682: SENTRY-1230: Add filesystem tests to test Sentry with user data storage on S3. The tests can also be run on other types of fileSystems (ms azure, hdfs). Just ensure pass corr

2016-05-21 Thread Anne Yu
add some test for location URI without scheme and authority? ok, will add one. - Anne --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47682/#review134234 --------

Re: Review Request 47682: SENTRY-1230: Add filesystem tests to test Sentry with user data storage on S3. The tests can also be run on other types of fileSystems (ms azure, hdfs). Just ensure pass corr

2016-05-21 Thread Anne Yu
Could you add some test for location URI without scheme and authority? > > Anne Yu wrote: > ok, will add one. Just be noted, with current support s3a at runtime instead of defaultFS, this will actually test hdfs filesystem. - Anne

Re: Review Request 47682: SENTRY-1230: Add filesystem tests to test Sentry with user data storage on S3. The tests can also be run on other types of fileSystems (ms azure, hdfs). Just ensure pass corr

2016-05-23 Thread Anne Yu
, Anne Yu

FYI SENTRY-872 - Apache Sentry High Availability Active/Standby Redesig

2016-05-27 Thread Anne Yu
Colin posted "Apache Sentry High Availability Active/Standby Redesign". If you feel interested, please take a look. -- Thanks, Anne

Re: Review Request 47937: SENTRY-1134: Add user defined udf test case.

2016-05-27 Thread Anne Yu
yudfs.java then let compiler compiles it, once create myudfs.jar will be put into target dir; your test can have access from there. So no need to check in myudfs.jar. Not sure if your compiled version will work on different systems or not (jdk7, 8 etc.) - Anne Yu On May 27, 2

Re: Review Request 47937: SENTRY-1134: Add user defined udf test case.

2016-06-03 Thread Anne Yu
reviewers' comments. - Anne Yu On June 1, 2016, 2:09 a.m., Ke Jia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 48111: SENTRY-950?add column level test cases for select ... group by, order by and where

2016-06-03 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48111/#review136149 --- Ship it! Ship It! - Anne Yu On June 1, 2016, 5:40 a.m., Ke

Re: postpone monthly meeting

2016-06-08 Thread Anne Yu
+1 for haohao's suggestion. On Jun 7, 2016 6:35 PM, "Hao Hao" wrote: > Next Thursday looks good to me. Happy holidays! > > Best, > Hao > > On Tue, Jun 7, 2016 at 6:24 PM, Ma, Junjie wrote: > > > Hi all, > > > > For the Chinese dragon boat festival, I can't join the monthly meeting > > this wee

Re: Review Request 48515: SENTRY-1320 : truncate table db_name.table_name fails

2016-06-09 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48515/#review136918 --- Ship it! Ship It! - Anne Yu On June 9, 2016, 9:39 p.m

Re: Review Request 48660: SENTRY-1319:Add metrics for isActive and isHA

2016-06-13 Thread Anne Yu
cdh5-1.5.1/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestDbHdfsExtMaxGroups.java. In that case, can sort of understanding how on unmanaged cluster, client gets to know the information. - Anne Yu On June 13, 2016, 6:52 p.m., R

Re: [VOTE] Release Sentry version 1.7.0

2016-06-15 Thread Anne Yu
+1. Verified seems correct to me. On Tue, Jun 7, 2016 at 11:58 PM, Hao Hao wrote: > Thanks a lot Colm for pointing out. I will add this to the release guide. > > Best, > Hao > > On Tue, Jun 7, 2016 at 11:01 PM, Sravya Tirukkovalur > wrote: > > > Good catch Colm! I had Hao's public key locally a

Re: fixVersion for Resolved JIRA

2016-06-16 Thread Anne Yu
Yeah it will help analyze jira and categorize issues later on. On Jun 16, 2016 5:02 PM, "Hao Hao" wrote: > Hi all, > > While doing 1.7.0 release, I noticed some resolved Jiras do not have > fixVersion. I feel it would be good to require a fixVersion once the Jira > is resolved. So I filed a Infra

Re: Review Request 48770: SENTRY-1325: Store HMSPaths in Sentry DB to allow fast failover

2016-06-21 Thread Anne Yu
ntry/provider/db/service/persistent/TestSentryStore.java (line 2084) <https://reviews.apache.org/r/48770/#comment204076> Just curious, in this case, will the below two cases are the same? hdfs://nameservice/user/hive/warehouse/db1.db/table1 and db1.db/table1? whether the s

RE: fixVersion for Resolved JIRA

2016-06-22 Thread Anne Yu
affectVersion? > > Regards > Dapeng > > -Original Message- > From: Anne Yu [mailto:ann...@cloudera.com] > Sent: Friday, June 17, 2016 8:54 AM > To: sentry > Subject: Re: fixVersion for Resolved JIRA > > Yeah it will help analyze jira and categorize issues lat

Re: sentry git commit: SENTRY-1348: Move HA related class from sentry-provider-db to sentry-service-common(Colin Ma, reviewed by Dapeng Sun)

2016-06-22 Thread Anne Yu
Hi Colin and Team, We are implementing Sentry-ha redesign in the branch *redesign-sentry-ha*, do you think this commit need also go into that branch. From now on, we might want to check in ha fixes in both trunk and branch. Thanks, Anne On Jun 21, 2016 10:27 PM, wrote: > Repository: sentry > Up

Re: sentry git commit: SENTRY-1348: Move HA related class from sentry-provider-db to sentry-service-common(Colin Ma, reviewed by Dapeng Sun)

2016-06-22 Thread Anne Yu
to focus on getting our branch done, and then worry about > merging back to master. > > People move stuff around all the time, and following the latest churn > takes time. > > Colin > > On Wed, Jun 22, 2016 at 9:45 AM, Anne Yu wrote: > >> Hi Colin and Team, >&g

Re: meeting minutes for monthly call (2016/06/16)

2016-06-23 Thread Anne Yu
Regarding 5, Record Service has an infra implemented to pull sentry/hive binaries, configure environments, and start services. (Sample code ). If you have any other questions

Re: Review Request 48770: SENTRY-1325: Store HMSPaths in Sentry DB to allow fast failover

2016-06-23 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48770/#review139290 --- Ship it! LGTM. - Anne Yu On June 23, 2016, 1:30 a.m., Hao

Re: Review Request 49290: SENTRY-1368: Test Alter table rename for managed/unmanaged, with/without partitions

2016-06-28 Thread Anne Yu
large, can put into a seperate test class. So ensure each test class runs no more than (10m). - Anne Yu On June 28, 2016, 12:27 a.m., Sravya Tirukkovalur wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

2016-07-01 Thread Anne Yu
tb1.id, db_2.tb1.num, db_2.tb2.val from db_1.tb1, db_2.tb1, db_2.tb2; (the syntax might be incorrect please modify as needed) - Anne Yu On July 1, 2016, 5:15 a.m., Ke Jia wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

2016-07-01 Thread Anne Yu
> On July 1, 2016, 5:31 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java, > > line 633 > > <https://reviews.apache.org/r/49491/diff/1/?file=1434660#file1434660line633> > > > >

Re: Review Request 49526: SENTRY-1365

2016-07-01 Thread Anne Yu
PING(AUTHZ_OBJ_ID, PATH_ID); and corresponding foreign keys. - Anne Yu On July 1, 2016, 6:20 p.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 49526: SENTRY-1365

2016-07-08 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/#review141303 --- Ship it! Ship It! - Anne Yu On July 5, 2016, 11:54 p.m

Re: Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

2016-07-08 Thread Anne Yu
> On July 1, 2016, 5:31 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java, > > line 633 > > <https://reviews.apache.org/r/49491/diff/1/?file=1434660#file1434660line633> > > > >

Re: Review Request 49491: SENTRY-1334 test and add test for CTAS and Create View AS SELECT (cross databases cases)

2016-07-10 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49491/#review141639 --- Ship it! - Anne Yu On July 11, 2016, 1:26 a.m., Ke Jia wrote

Re: Review Request 49526: SENTRY-1365

2016-07-11 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/#review141695 --- Ship it! Ship It! - Anne Yu On July 11, 2016, 7:36 a.m

Re: Review Request 50264: SENTRY-1331: Add a kerberos end to end test case to access isActive and isHa metrics.

2016-07-20 Thread Anne Yu
/reviews.apache.org/r/50264/#comment208687> To me isXXX natuarally returns TRUE or FALSE. Seems mp.isActive().getBooleanValue() also validate boolean results. Not sure why here return JsonNode obj. - Anne Yu On July 20, 2016,

Re: Review Request 50264: SENTRY-1331: Add a kerberos end to end test case to access isActive and isHa metrics.

2016-07-25 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50264/#review143477 --- Ship it! Ship It! - Anne Yu On July 22, 2016, 8:36 p.m

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-26 Thread Anne Yu
g mode; 3. ensure passive server to become active; meaning the new active server is the previous passive one; - Anne Yu On July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-26 Thread Anne Yu
/tests/e2e/ha/TestFailover.java (line 47) <https://reviews.apache.org/r/50404/#comment209413> Will it be possible to have more than 2 servers? - Anne Yu On July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > ---

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Anne Yu
> On July 26, 2016, 6:39 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java, > > line 42 > > <https://reviews.apache.org/r/50404/diff/2/?file=1452126#file1452126line42> > > &

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Anne Yu
> On July 26, 2016, 7:16 p.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > <https://reviews.apache.org/r/50404/diff/2/?file=1452127#file1452127line47> > > > >

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Anne Yu
))) { enableSentryHA = true; } - Anne Yu On July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-27 Thread Anne Yu
July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50404/ > --- > > (Updated July 26, 2016,

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-28 Thread Anne Yu
e you making that configurable anywhere, like number of servers to be > > used? . If yes, then if you commit that code, I can change this case. > > Anne Yu wrote: > Yeah, I am going to make it configurable passing from maven; default > value will still be 2. In this cas

Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
dac11517f36a743dff8730465fbf2397ebf16c88 Diff: https://reviews.apache.org/r/50611/diff/ Testing --- Thanks, Anne Yu

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Anne Yu
/reviews.apache.org/r/50474/#comment210152> Not sure if the other group/user's rwx should be set by sentry privileges or just hard set by test? - Anne Yu On July 26, 2016, 11:41 p.m., Hao Hao wrote: > > --- >

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review144144 ------- On July 29, 2016, 5:27 p.m., Anne Yu wrote: > > --- > This is a

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-07-29 Thread Anne Yu
https://reviews.apache.org/r/50611/diff/ Testing --- Thanks, Anne Yu

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50474/#review144171 --- Ship it! Ship It! - Anne Yu On July 29, 2016, 7:41 p.m

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-07-29 Thread Anne Yu
/sentry/hdfs/SentryAuthorizationConstants.java (line 55) <https://reviews.apache.org/r/50474/#comment210187> Missing one white space. - Anne Yu On July 29, 2016, 7:41 p.m., Hao Hao wrote: > > --- > This is an automati

Re: Review Request 50474: SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs

2016-08-04 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50474/#review144810 --- Ship it! Ship It! - Anne Yu On Aug. 2, 2016, 8:36 p.m., Hao

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-16 Thread Anne Yu
, Anne Yu

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-17 Thread Anne Yu
.org/r/50611/diff/3/?file=1475619#file1475619line254> > > > > Nit: Better to add try catch block here. Will do so. - Anne --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 50611: Sentry HA Test: programmatic failover, validate privileges before and afterwards.

2016-08-18 Thread Anne Yu
since I don't see it gets configured in AbstractTestWithStaticConfiguration. - Anne --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50611/#review146061 ------- On Aug. 16, 2016, 6:17 p.m.,

Review Request 51353: SENTRY-1447: fix a couple of e2e test failures on real clusters.

2016-08-23 Thread Anne Yu
mportPrivileges.java b38eaaf35ec97978fef06fe91e3e5f5e391d4cc3 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperationsPart2.java 7186f1af8159c30064e5ae3b5b1900d4556e1e4a Diff: https://reviews.apache.org/r/51353/diff/ Testing --- On a test cluster. Thanks, Anne Yu

Re: Review Request 51353: SENTRY-1447: fix a couple of e2e test failures on real clusters.

2016-08-24 Thread Anne Yu
enerated e-mail. To reply, visit: https://reviews.apache.org/r/51353/#review146605 --- On Aug. 23, 2016, 11:42 p.m., Anne Yu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51353: SENTRY-1447: fix a couple of e2e test failures on real clusters.

2016-08-24 Thread Anne Yu
ae3b5b1900d4556e1e4a Diff: https://reviews.apache.org/r/51353/diff/ Testing --- On a test cluster. Thanks, Anne Yu

Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-26 Thread Anne Yu
://reviews.apache.org/r/51471/diff/ Testing --- Local. Thanks, Anne Yu

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-26 Thread Anne Yu
/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java be6d0822ea56509ae9171d2b79026b1c952c2ec9 Diff: https://reviews.apache.org/r/51471/diff/ Testing --- Local. Thanks, Anne Yu

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-26 Thread Anne Yu
eply, visit: https://reviews.apache.org/r/51471/#review147048 --- On Aug. 27, 2016, 12:13 a.m., Anne Yu wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-26 Thread Anne Yu
> > > > > So this is the new improvement right? > > Anne Yu wrote: > Thanks for reviewing. Correct, to ensure for each test external dirs can > be re-created without correct properties. Typo, "ensure for each test external di

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-26 Thread Anne Yu
sert. - Anne --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51471/#review147050 --- On Aug. 27, 2016, 12:13 a.m., Anne Yu wrote:

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-26 Thread Anne Yu
/hdfs/TestHDFSIntegrationWithHA.java be6d0822ea56509ae9171d2b79026b1c952c2ec9 Diff: https://reviews.apache.org/r/51471/diff/ Testing --- Local. Thanks, Anne Yu

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-26 Thread Anne Yu
visit: https://reviews.apache.org/r/51471/#review147055 ------- On Aug. 27, 2016, 12:42 a.m., Anne Yu wrote: > > --- > This is an automatically generat

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-29 Thread Anne Yu
hanks, Anne Yu

Re: Review Request 51471: SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration and unblock post-commit job.

2016-08-29 Thread Anne Yu
ps://reviews.apache.org/r/51471/#review147180 ------- On Aug. 29, 2016, 6:41 p.m., Anne Yu wrote: > > --- > This is an automatically generated e-mail.

Review Request 51773: Simple fix for org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterPartitionLocationPrivileges

2016-09-09 Thread Anne Yu
/e2e/hive/hiveserver/UnmanagedHiveServer.java d5c5db40a9d42140c1f55d3665fd152151d7285e Diff: https://reviews.apache.org/r/51773/diff/ Testing --- On a real cluster. Thanks, Anne Yu

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Anne Yu
this patch, server.isActive() will also be disabled? In that case, how can one programmatically disabe any active server(s) and get the status of any server(s)? It seems a userful tool for future and internal testing/debugging. Thanks. - Anne Yu On Sept. 22, 2016, 5:27 a.m., Li Li wrote

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Anne Yu
cally generated e-mail. To reply, visit: > https://reviews.apache.org/r/52150/ > --- > > (Updated Sept. 22, 2016, 5:27 a.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya > Tirukkovalur. > > > R

Review Request 52582: SENTRY-1489: Categorize e2e tests into slow and regular tests, so that can adapt the timeout and etc.

2016-10-05 Thread Anne Yu
/hive/SlowE2ETest.java PRE-CREATION Diff: https://reviews.apache.org/r/52582/diff/ Testing --- Thanks, Anne Yu

Re: Review Request 45859: SENTRY-1120: Show role / privileges info in Sentry Service Webpage

2016-10-07 Thread Anne Yu
https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/common/FileUtils.java - Anne Yu On Oct. 7, 2016, 12:38 a.m., Li Li wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 45859: SENTRY-1120: Show role / privileges info in Sentry Service Webpage

2016-10-07 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45859/#review151834 --- Ship it! Thanks Lili for your patch. - Anne Yu On Oct. 7

Re: Review Request 52582: SENTRY-1489: Categorize e2e tests into slow and regular tests, so that can adapt the timeout and etc.

2016-10-07 Thread Anne Yu
> use final static var for all the timeout? will add. - Anne --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52582/#review151832

Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-09 Thread Anne Yu
://reviews.apache.org/r/52675/diff/ Testing --- Thanks, Anne Yu

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-10 Thread Anne Yu
-tests/sentry-tests-hive/src/test/scripts/scale-test/create-many-dbs-tables.sh dcdddeb95a896ca8470d0b994f5460531e34d113 Diff: https://reviews.apache.org/r/52675/diff/ Testing --- Thanks, Anne Yu

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-10 Thread Anne Yu
iew152076 --- On Oct. 10, 2016, 6:14 a.m., Anne Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-10 Thread Anne Yu
nstant number. will add condition to check it. - Anne --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52675/#review152076 --- On Oct. 10

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-10 Thread Anne Yu
-many-dbs-tables.sh dcdddeb95a896ca8470d0b994f5460531e34d113 Diff: https://reviews.apache.org/r/52675/diff/ Testing --- Thanks, Anne Yu

Re: [DISCUSS] Add marker for Sentry server log

2016-10-11 Thread Anne Yu
Hi HaoHao, Could you elaborate more about what is looking for here? Differentiate error, exception, failure, warning on server, client side, or system level. What we want to archive from using marker, the current logger has issues to indicate problem? Maybe by understanding these requirements can

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-18 Thread Anne Yu
) Thanks, Anne Yu

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-18 Thread Anne Yu
privileges(299), table privileges(824), view privileges(503), partition privileges(204), column privileges(299), uri privileges(204); roles(1000), groups(500); failed threads(1), running time(725 secs) Thanks, Anne Yu

Re: Review Request 52675: Create a sentry scale test tool to add various objects and privileges into Sentry and HMS.

2016-10-19 Thread Anne Yu
t; > <https://reviews.apache.org/r/52675/diff/3/?file=1530273#file1530273line68> > > > > do we need to add 'else' for all other cases (print help)? Added in the latest patch. - Anne -------

  1   2   >