subject:"Re\: Lucene\/Solr 7.2"

Re: Lucene/Solr 7.2

2017-12-18 Thread Cassandra Targett

The Ref Guide is pretty much ready also. I'm going to commit a few more
little typos/fixes and try to spin an RC for that by the end of the day
today. I'm traveling mid-week but would be able to do the release at the
end of the week (or respin if it comes to that).

Cassandra

On Wed, Dec 13, 2017 at 11:08 AM, Adrien Grand  wrote:

> https://issues.apache.org/jira/browse/LUCENE-8090 and
> https://issues.apache.org/jira/browse/SOLR-11740 are now resolved, so as
> far as I know there are no more blockers. I will build a RC tomorrow.
>
> Le lun. 11 déc. 2017 à 11:33, Adrien Grand  a écrit :
>
>> We have another blocker: https://issues.apache.org/
>> jira/browse/LUCENE-8090.
>>
>> Could someone help Varun investigate https://issues.apache.org/
>> jira/browse/SOLR-11740? I just made it a blocker as well until we know
>> more about it.
>>
>> Le sam. 9 déc. 2017 à 08:57, Varun Thacker  a écrit :
>>
>>> This fails for me every single time : https://issues.apache.org/
>>> jira/browse/SOLR-11740
>>>
>>> Can someone with more knowledge of the bin/solr script confirm if this
>>> effects the "-e cloud" command only or is it more widespread .
>>> That might help determine if we want to fix this before the release.
>>>
>>> On Fri, Dec 8, 2017 at 10:41 AM, Adrien Grand  wrote:
>>>
 FYI we are backporting SOLR-11423
  to 7.2 so I'll
 build a RC on Monday (assuming it will have been backported by then).

 Le jeu. 7 déc. 2017 à 20:17, Adrien Grand  a écrit :

> OK, it looks like all changes that we wanted to be included are now
> in? Please let me know if there is still something left to include in 7.2
> before building a RC.
>
> I noticed SOLR-11423 is in a weird state, it is included in the
> changelog in 7.1 but has only been committed to master. Did we forget to
> backport it?
>
> Le mer. 6 déc. 2017 à 21:13, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> a écrit :
>
>> On 6 Dec 2017, at 18:45, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>> I attached the patch to SOLR-11714, which disables the ‘searchRate’
>> trigger - if there are no objections I’ll commit it shortly to 
>> branch_7.2.
>>
>>
>>
>> This has been committed now to branch_7_2 and I don’t have any other
>> open issues for 7.2. Thanks!
>>
>>
>>
>> On 6 Dec 2017, at 15:51, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>>
>> On 6 Dec 2017, at 15:35, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>> SOLR-11458 is committed and resolved - thanks for the patience.
>>
>>
>>
>> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a
>> new feature (searchRate autoscaling trigger). It’s probably best to 
>> disable
>> this feature in 7.2 rather than releasing a broken version, so I’d like 
>> to
>> commit a patch that disables it (plus a note in CHANGES.txt).
>>
>>
>>
>>
>> On 6 Dec 2017, at 14:02, Adrien Grand  wrote:
>>
>> Thanks for the heads up, Anshum.
>>
>> This leaves us with only SOLR-11458 to wait for before building a RC
>> (which might be ready but just not marked as resolved).
>>
>>
>>
>> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>>
>>> Hi Adrien,
>>> I'm planning to skip SOLR-11624 for this release (as per my last
>>> comment https://issues.apache.org/jira/browse/SOLR-11624?
>>> focusedCommentId=16280121=com.atlassian.jira.
>>> plugin.system.issuetabpanels:comment-tabpanel#comment-16280121). If
>>> someone has an objection, please let me know; otherwise, please feel 
>>> free
>>> to proceed with the release.
>>> I'll continue working on it anyway, and shall try to have it ready
>>> for the next release.
>>> Thanks,
>>> Ishan
>>>
>>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand 
>>> wrote:
>>>
 FYI I created the new branch for 7.2, so you will have to backport
 to this branch. No hurry though, I mostly created the branch so that 
 it's
 fine to cherry-pick changes that may wait for 7.3 to be released.

 Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a
 écrit :

> Sorry to hear that Ishan, I hope you are doing better now. +1 to
> get SOLR-11624 in.
>
> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>
>> I was a bit unwell over the weekend and yesterday; I'm working on
>> a very targeted fix for SOLR-11624 right now; I expect it to take 
>>

Re: Lucene/Solr 7.2

2017-12-13 Thread Adrien Grand

https://issues.apache.org/jira/browse/LUCENE-8090 and
https://issues.apache.org/jira/browse/SOLR-11740 are now resolved, so as
far as I know there are no more blockers. I will build a RC tomorrow.

Le lun. 11 déc. 2017 à 11:33, Adrien Grand  a écrit :

> We have another blocker: https://issues.apache.org/jira/browse/LUCENE-8090
> .
>
> Could someone help Varun investigate
> https://issues.apache.org/jira/browse/SOLR-11740? I just made it a
> blocker as well until we know more about it.
>
> Le sam. 9 déc. 2017 à 08:57, Varun Thacker  a écrit :
>
>> This fails for me every single time :
>> https://issues.apache.org/jira/browse/SOLR-11740
>>
>> Can someone with more knowledge of the bin/solr script confirm if this
>> effects the "-e cloud" command only or is it more widespread .
>> That might help determine if we want to fix this before the release.
>>
>> On Fri, Dec 8, 2017 at 10:41 AM, Adrien Grand  wrote:
>>
>>> FYI we are backporting SOLR-11423
>>>  to 7.2 so I'll build
>>> a RC on Monday (assuming it will have been backported by then).
>>>
>>> Le jeu. 7 déc. 2017 à 20:17, Adrien Grand  a écrit :
>>>
 OK, it looks like all changes that we wanted to be included are now in?
 Please let me know if there is still something left to include in 7.2
 before building a RC.

 I noticed SOLR-11423 is in a weird state, it is included in the
 changelog in 7.1 but has only been committed to master. Did we forget to
 backport it?

 Le mer. 6 déc. 2017 à 21:13, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> a écrit :

> On 6 Dec 2017, at 18:45, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> wrote:
>
> I attached the patch to SOLR-11714, which disables the ‘searchRate’
> trigger - if there are no objections I’ll commit it shortly to branch_7.2.
>
>
>
> This has been committed now to branch_7_2 and I don’t have any other
> open issues for 7.2. Thanks!
>
>
>
> On 6 Dec 2017, at 15:51, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> wrote:
>
>
> On 6 Dec 2017, at 15:35, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> wrote:
>
> SOLR-11458 is committed and resolved - thanks for the patience.
>
>
>
> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a
> new feature (searchRate autoscaling trigger). It’s probably best to 
> disable
> this feature in 7.2 rather than releasing a broken version, so I’d like to
> commit a patch that disables it (plus a note in CHANGES.txt).
>
>
>
>
> On 6 Dec 2017, at 14:02, Adrien Grand  wrote:
>
> Thanks for the heads up, Anshum.
>
> This leaves us with only SOLR-11458 to wait for before building a RC
> (which might be ready but just not marked as resolved).
>
>
>
> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>
>> Hi Adrien,
>> I'm planning to skip SOLR-11624 for this release (as per my last
>> comment
>> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
>> If someone has an objection, please let me know; otherwise, please feel
>> free to proceed with the release.
>> I'll continue working on it anyway, and shall try to have it ready
>> for the next release.
>> Thanks,
>> Ishan
>>
>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand 
>> wrote:
>>
>>> FYI I created the new branch for 7.2, so you will have to backport
>>> to this branch. No hurry though, I mostly created the branch so that 
>>> it's
>>> fine to cherry-pick changes that may wait for 7.3 to be released.
>>>
>>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a
>>> écrit :
>>>
 Sorry to hear that Ishan, I hope you are doing better now. +1 to
 get SOLR-11624 in.

 Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
 ichattopadhy...@gmail.com> a écrit :

> I was a bit unwell over the weekend and yesterday; I'm working on
> a very targeted fix for SOLR-11624 right now; I expect it to take 
> another
> 5-6 hours.
> Is that fine with you, Adrien? If not, please go ahead with the
> release, and I'll volunteer later for a bugfix release for this after 
> 7.2
> is out.
>
> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand 
> wrote:
>
>> Fine with me.
>>
>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
>> écrit :
>>
>>> Hi Adrien,
>>>
>>>

Re: Lucene/Solr 7.2

2017-12-11 Thread Adrien Grand

We have another blocker: https://issues.apache.org/jira/browse/LUCENE-8090.

Could someone help Varun investigate
https://issues.apache.org/jira/browse/SOLR-11740? I just made it a blocker
as well until we know more about it.

Le sam. 9 déc. 2017 à 08:57, Varun Thacker  a écrit :

> This fails for me every single time :
> https://issues.apache.org/jira/browse/SOLR-11740
>
> Can someone with more knowledge of the bin/solr script confirm if this
> effects the "-e cloud" command only or is it more widespread .
> That might help determine if we want to fix this before the release.
>
> On Fri, Dec 8, 2017 at 10:41 AM, Adrien Grand  wrote:
>
>> FYI we are backporting SOLR-11423
>>  to 7.2 so I'll build
>> a RC on Monday (assuming it will have been backported by then).
>>
>> Le jeu. 7 déc. 2017 à 20:17, Adrien Grand  a écrit :
>>
>>> OK, it looks like all changes that we wanted to be included are now in?
>>> Please let me know if there is still something left to include in 7.2
>>> before building a RC.
>>>
>>> I noticed SOLR-11423 is in a weird state, it is included in the
>>> changelog in 7.1 but has only been committed to master. Did we forget to
>>> backport it?
>>>
>>> Le mer. 6 déc. 2017 à 21:13, Andrzej Białecki <
>>> andrzej.biale...@lucidworks.com> a écrit :
>>>
 On 6 Dec 2017, at 18:45, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> wrote:

 I attached the patch to SOLR-11714, which disables the ‘searchRate’
 trigger - if there are no objections I’ll commit it shortly to branch_7.2.



 This has been committed now to branch_7_2 and I don’t have any other
 open issues for 7.2. Thanks!



 On 6 Dec 2017, at 15:51, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> wrote:


 On 6 Dec 2017, at 15:35, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> wrote:

 SOLR-11458 is committed and resolved - thanks for the patience.



 Actually, one more thing … ;) SOLR-11714 is a more serious bug in a new
 feature (searchRate autoscaling trigger). It’s probably best to disable
 this feature in 7.2 rather than releasing a broken version, so I’d like to
 commit a patch that disables it (plus a note in CHANGES.txt).




 On 6 Dec 2017, at 14:02, Adrien Grand  wrote:

 Thanks for the heads up, Anshum.

 This leaves us with only SOLR-11458 to wait for before building a RC
 (which might be ready but just not marked as resolved).



 Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <
 ichattopadhy...@gmail.com> a écrit :

> Hi Adrien,
> I'm planning to skip SOLR-11624 for this release (as per my last
> comment
> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
> If someone has an objection, please let me know; otherwise, please feel
> free to proceed with the release.
> I'll continue working on it anyway, and shall try to have it ready for
> the next release.
> Thanks,
> Ishan
>
> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand 
> wrote:
>
>> FYI I created the new branch for 7.2, so you will have to backport to
>> this branch. No hurry though, I mostly created the branch so that it's 
>> fine
>> to cherry-pick changes that may wait for 7.3 to be released.
>>
>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a
>> écrit :
>>
>>> Sorry to hear that Ishan, I hope you are doing better now. +1 to get
>>> SOLR-11624 in.
>>>
>>> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
>>> ichattopadhy...@gmail.com> a écrit :
>>>
 I was a bit unwell over the weekend and yesterday; I'm working on a
 very targeted fix for SOLR-11624 right now; I expect it to take 
 another 5-6
 hours.
 Is that fine with you, Adrien? If not, please go ahead with the
 release, and I'll volunteer later for a bugfix release for this after 
 7.2
 is out.

 On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand 
 wrote:

> Fine with me.
>
> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
> écrit :
>
>> Hi Adrien,
>>
>> I'd like to commit SOLR-11590 . The issue had a patch couple of
>> weeks ago and has been reviewed but never got committed. I've run 
>> all the
>> tests twice as well to verify.
>>
>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>>>
>>> On 5 Dec 2017, at 18:05, Adrien Grand

Re: Lucene/Solr 7.2

2017-12-08 Thread Varun Thacker

This fails for me every single time :
https://issues.apache.org/jira/browse/SOLR-11740

Can someone with more knowledge of the bin/solr script confirm if this
effects the "-e cloud" command only or is it more widespread .
That might help determine if we want to fix this before the release.

On Fri, Dec 8, 2017 at 10:41 AM, Adrien Grand  wrote:

> FYI we are backporting SOLR-11423
>  to 7.2 so I'll build a
> RC on Monday (assuming it will have been backported by then).
>
> Le jeu. 7 déc. 2017 à 20:17, Adrien Grand  a écrit :
>
>> OK, it looks like all changes that we wanted to be included are now in?
>> Please let me know if there is still something left to include in 7.2
>> before building a RC.
>>
>> I noticed SOLR-11423 is in a weird state, it is included in the changelog
>> in 7.1 but has only been committed to master. Did we forget to backport it?
>>
>> Le mer. 6 déc. 2017 à 21:13, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> a écrit :
>>
>>> On 6 Dec 2017, at 18:45, Andrzej Białecki >> com> wrote:
>>>
>>> I attached the patch to SOLR-11714, which disables the ‘searchRate’
>>> trigger - if there are no objections I’ll commit it shortly to branch_7.2.
>>>
>>>
>>>
>>> This has been committed now to branch_7_2 and I don’t have any other
>>> open issues for 7.2. Thanks!
>>>
>>>
>>>
>>> On 6 Dec 2017, at 15:51, Andrzej Białecki >> com> wrote:
>>>
>>>
>>> On 6 Dec 2017, at 15:35, Andrzej Białecki >> com> wrote:
>>>
>>> SOLR-11458 is committed and resolved - thanks for the patience.
>>>
>>>
>>>
>>> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a new
>>> feature (searchRate autoscaling trigger). It’s probably best to disable
>>> this feature in 7.2 rather than releasing a broken version, so I’d like to
>>> commit a patch that disables it (plus a note in CHANGES.txt).
>>>
>>>
>>>
>>>
>>> On 6 Dec 2017, at 14:02, Adrien Grand  wrote:
>>>
>>> Thanks for the heads up, Anshum.
>>>
>>> This leaves us with only SOLR-11458 to wait for before building a RC
>>> (which might be ready but just not marked as resolved).
>>>
>>>
>>>
>>> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <
>>> ichattopadhy...@gmail.com> a écrit :
>>>
 Hi Adrien,
 I'm planning to skip SOLR-11624 for this release (as per my last
 comment https://issues.apache.org/jira/browse/SOLR-11624?
 focusedCommentId=16280121=com.atlassian.jira.
 plugin.system.issuetabpanels:comment-tabpanel#comment-16280121). If
 someone has an objection, please let me know; otherwise, please feel free
 to proceed with the release.
 I'll continue working on it anyway, and shall try to have it ready for
 the next release.
 Thanks,
 Ishan

 On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  wrote:

> FYI I created the new branch for 7.2, so you will have to backport to
> this branch. No hurry though, I mostly created the branch so that it's 
> fine
> to cherry-pick changes that may wait for 7.3 to be released.
>
> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a
> écrit :
>
>> Sorry to hear that Ishan, I hope you are doing better now. +1 to get
>> SOLR-11624 in.
>>
>> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>>
>>> I was a bit unwell over the weekend and yesterday; I'm working on a
>>> very targeted fix for SOLR-11624 right now; I expect it to take another 
>>> 5-6
>>> hours.
>>> Is that fine with you, Adrien? If not, please go ahead with the
>>> release, and I'll volunteer later for a bugfix release for this after 
>>> 7.2
>>> is out.
>>>
>>> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand 
>>> wrote:
>>>
 Fine with me.

 Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
 écrit :

> Hi Adrien,
>
> I'd like to commit SOLR-11590 . The issue had a patch couple of
> weeks ago and has been reviewed but never got committed. I've run all 
> the
> tests twice as well to verify.
>
> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> wrote:
>
>>
>> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>>
>> Andrzej, ok to merge since it is a bug fix. Since we're close to
>> the RC build, maybe try to get someone familiar with the code to 
>> review it
>> to make sure it doesn't have unexpected side-effects?
>>
>>
>> Sure I’ll do this - thanks!
>>
>>
>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
>>

Re: Lucene/Solr 7.2

2017-12-08 Thread Adrien Grand

FYI we are backporting SOLR-11423
 to 7.2 so I'll build a
RC on Monday (assuming it will have been backported by then).

Le jeu. 7 déc. 2017 à 20:17, Adrien Grand  a écrit :

> OK, it looks like all changes that we wanted to be included are now in?
> Please let me know if there is still something left to include in 7.2
> before building a RC.
>
> I noticed SOLR-11423 is in a weird state, it is included in the changelog
> in 7.1 but has only been committed to master. Did we forget to backport it?
>
> Le mer. 6 déc. 2017 à 21:13, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> a écrit :
>
>> On 6 Dec 2017, at 18:45, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>> I attached the patch to SOLR-11714, which disables the ‘searchRate’
>> trigger - if there are no objections I’ll commit it shortly to branch_7.2.
>>
>>
>>
>> This has been committed now to branch_7_2 and I don’t have any other open
>> issues for 7.2. Thanks!
>>
>>
>>
>> On 6 Dec 2017, at 15:51, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>>
>> On 6 Dec 2017, at 15:35, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>> SOLR-11458 is committed and resolved - thanks for the patience.
>>
>>
>>
>> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a new
>> feature (searchRate autoscaling trigger). It’s probably best to disable
>> this feature in 7.2 rather than releasing a broken version, so I’d like to
>> commit a patch that disables it (plus a note in CHANGES.txt).
>>
>>
>>
>>
>> On 6 Dec 2017, at 14:02, Adrien Grand  wrote:
>>
>> Thanks for the heads up, Anshum.
>>
>> This leaves us with only SOLR-11458 to wait for before building a RC
>> (which might be ready but just not marked as resolved).
>>
>>
>>
>> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>>
>>> Hi Adrien,
>>> I'm planning to skip SOLR-11624 for this release (as per my last comment
>>> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
>>> If someone has an objection, please let me know; otherwise, please feel
>>> free to proceed with the release.
>>> I'll continue working on it anyway, and shall try to have it ready for
>>> the next release.
>>> Thanks,
>>> Ishan
>>>
>>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  wrote:
>>>
 FYI I created the new branch for 7.2, so you will have to backport to
 this branch. No hurry though, I mostly created the branch so that it's fine
 to cherry-pick changes that may wait for 7.3 to be released.

 Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a écrit :

> Sorry to hear that Ishan, I hope you are doing better now. +1 to get
> SOLR-11624 in.
>
> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>
>> I was a bit unwell over the weekend and yesterday; I'm working on a
>> very targeted fix for SOLR-11624 right now; I expect it to take another 
>> 5-6
>> hours.
>> Is that fine with you, Adrien? If not, please go ahead with the
>> release, and I'll volunteer later for a bugfix release for this after 7.2
>> is out.
>>
>> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand 
>> wrote:
>>
>>> Fine with me.
>>>
>>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
>>> écrit :
>>>
 Hi Adrien,

 I'd like to commit SOLR-11590 . The issue had a patch couple of
 weeks ago and has been reviewed but never got committed. I've run all 
 the
 tests twice as well to verify.

 On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> wrote:

>
> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>
> Andrzej, ok to merge since it is a bug fix. Since we're close to
> the RC build, maybe try to get someone familiar with the code to 
> review it
> to make sure it doesn't have unexpected side-effects?
>
>
> Sure I’ll do this - thanks!
>
>
> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> a écrit :
>
>> Adrien,
>>
>> If it’s ok I would also like to merge SOLR-11458, this
>> significantly reduces the chance of accidental data loss when using
>> MoveReplicaCmd.
>>
>> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>>
>> Quick update:
>>
>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been
>> merged, they will be in 7.2.
>>
>> LUCENE-8048 and

Re: Lucene/Solr 7.2

2017-12-07 Thread Adrien Grand

OK, it looks like all changes that we wanted to be included are now in?
Please let me know if there is still something left to include in 7.2
before building a RC.

I noticed SOLR-11423 is in a weird state, it is included in the changelog
in 7.1 but has only been committed to master. Did we forget to backport it?

Le mer. 6 déc. 2017 à 21:13, Andrzej Białecki <
andrzej.biale...@lucidworks.com> a écrit :

> On 6 Dec 2017, at 18:45, Andrzej Białecki 
> wrote:
>
> I attached the patch to SOLR-11714, which disables the ‘searchRate’
> trigger - if there are no objections I’ll commit it shortly to branch_7.2.
>
>
>
> This has been committed now to branch_7_2 and I don’t have any other open
> issues for 7.2. Thanks!
>
>
>
> On 6 Dec 2017, at 15:51, Andrzej Białecki 
> wrote:
>
>
> On 6 Dec 2017, at 15:35, Andrzej Białecki 
> wrote:
>
> SOLR-11458 is committed and resolved - thanks for the patience.
>
>
>
> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a new
> feature (searchRate autoscaling trigger). It’s probably best to disable
> this feature in 7.2 rather than releasing a broken version, so I’d like to
> commit a patch that disables it (plus a note in CHANGES.txt).
>
>
>
>
> On 6 Dec 2017, at 14:02, Adrien Grand  wrote:
>
> Thanks for the heads up, Anshum.
>
> This leaves us with only SOLR-11458 to wait for before building a RC
> (which might be ready but just not marked as resolved).
>
>
>
> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>
>> Hi Adrien,
>> I'm planning to skip SOLR-11624 for this release (as per my last comment
>> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
>> If someone has an objection, please let me know; otherwise, please feel
>> free to proceed with the release.
>> I'll continue working on it anyway, and shall try to have it ready for
>> the next release.
>> Thanks,
>> Ishan
>>
>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  wrote:
>>
>>> FYI I created the new branch for 7.2, so you will have to backport to
>>> this branch. No hurry though, I mostly created the branch so that it's fine
>>> to cherry-pick changes that may wait for 7.3 to be released.
>>>
>>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a écrit :
>>>
 Sorry to hear that Ishan, I hope you are doing better now. +1 to get
 SOLR-11624 in.

 Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
 ichattopadhy...@gmail.com> a écrit :

> I was a bit unwell over the weekend and yesterday; I'm working on a
> very targeted fix for SOLR-11624 right now; I expect it to take another 
> 5-6
> hours.
> Is that fine with you, Adrien? If not, please go ahead with the
> release, and I'll volunteer later for a bugfix release for this after 7.2
> is out.
>
> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand 
> wrote:
>
>> Fine with me.
>>
>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
>> écrit :
>>
>>> Hi Adrien,
>>>
>>> I'd like to commit SOLR-11590 . The issue had a patch couple of
>>> weeks ago and has been reviewed but never got committed. I've run all 
>>> the
>>> tests twice as well to verify.
>>>
>>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
>>> andrzej.biale...@lucidworks.com> wrote:
>>>

 On 5 Dec 2017, at 18:05, Adrien Grand  wrote:

 Andrzej, ok to merge since it is a bug fix. Since we're close to
 the RC build, maybe try to get someone familiar with the code to 
 review it
 to make sure it doesn't have unexpected side-effects?


 Sure I’ll do this - thanks!


 Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> a écrit :

> Adrien,
>
> If it’s ok I would also like to merge SOLR-11458, this
> significantly reduces the chance of accidental data loss when using
> MoveReplicaCmd.
>
> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>
> Quick update:
>
> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been
> merged, they will be in 7.2.
>
> LUCENE-8048 and SOLR-11624 are still open.
>
> LUCENE-8048 looks like it could make things better in some cases
> but I don't think it is required for 7.2, so I don't plan to hold the
> release on it.
>
> SOLR-11624 looks bad, I'll wait for it.
>
> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a
> écrit :
>

Re: Lucene/Solr 7.2

2017-12-06 Thread Andrzej Białecki


> On 6 Dec 2017, at 18:45, Andrzej Białecki  
> wrote:
> 
> I attached the patch to SOLR-11714, which disables the ‘searchRate’ trigger - 
> if there are no objections I’ll commit it shortly to branch_7.2.


This has been committed now to branch_7_2 and I don’t have any other open 
issues for 7.2. Thanks!


> 
>> On 6 Dec 2017, at 15:51, Andrzej Białecki > > wrote:
>> 
>> 
>>> On 6 Dec 2017, at 15:35, Andrzej Białecki >> > wrote:
>>> 
>>> SOLR-11458 is committed and resolved - thanks for the patience.
>> 
>> 
>> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a new 
>> feature (searchRate autoscaling trigger). It’s probably best to disable this 
>> feature in 7.2 rather than releasing a broken version, so I’d like to commit 
>> a patch that disables it (plus a note in CHANGES.txt).
>> 
>> 
>>> 
>>> 
>>> 
 On 6 Dec 2017, at 14:02, Adrien Grand > wrote:
 
 Thanks for the heads up, Anshum.
 
 This leaves us with only SOLR-11458 to wait for before building a RC 
 (which might be ready but just not marked as resolved).
>>> 
 
 
 Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya 
 > a écrit :
 Hi Adrien,
 I'm planning to skip SOLR-11624 for this release (as per my last comment 
 https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121
  
 ).
  If someone has an objection, please let me know; otherwise, please feel 
 free to proceed with the release.
 I'll continue working on it anyway, and shall try to have it ready for the 
 next release.
 Thanks,
 Ishan
 
 On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand > wrote:
 FYI I created the new branch for 7.2, so you will have to backport to this 
 branch. No hurry though, I mostly created the branch so that it's fine to 
 cherry-pick changes that may wait for 7.3 to be released.
 
 Le mer. 6 déc. 2017 à 08:53, Adrien Grand > a écrit :
 Sorry to hear that Ishan, I hope you are doing better now. +1 to get 
 SOLR-11624 in.
 
 Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya 
 > a écrit :
 I was a bit unwell over the weekend and yesterday; I'm working on a very 
 targeted fix for SOLR-11624 right now; I expect it to take another 5-6 
 hours.
 Is that fine with you, Adrien? If not, please go ahead with the release, 
 and I'll volunteer later for a bugfix release for this after 7.2 is out.
 
 On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand > wrote:
 Fine with me.
 
 
 Le mar. 5 déc. 2017 à 22:34, Varun Thacker > a écrit :
 Hi Adrien,
 
 I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago 
 and has been reviewed but never got committed. I've run all the tests 
 twice as well to verify.
 
 On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki 
 > 
 wrote:
 
> On 5 Dec 2017, at 18:05, Adrien Grand  > wrote:
> 
> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC 
> build, maybe try to get someone familiar with the code to review it to 
> make sure it doesn't have unexpected side-effects?
 
 Sure I’ll do this - thanks!
 
> 
> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki 
>  > a écrit :
> Adrien,
> 
> If it’s ok I would also like to merge SOLR-11458, this significantly 
> reduces the chance of accidental data loss when using MoveReplicaCmd.
> 
>> On 5 Dec 2017, at 14:44, Adrien Grand > > wrote:
>> 
>> Quick update:
>> 
>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they 
>> will be in 7.2.
>> 
>> LUCENE-8048 and SOLR-11624 are still open. 
>> 
>> LUCENE-8048 looks like it could make things better in some cases but I 
>> don't think it is required for 7.2, so I don't plan to hold the release 
>> on it.
>> 
>> SOLR-11624

Re: Lucene/Solr 7.2

2017-12-06 Thread Christine Poerschke (BLOOMBERG/ LONDON)

No worries :)

At the risk of causing further confusion, I've added another note to SOLR-9743 
but am not sure how one would most easily move forward with the problem, 
perhaps there is no easy way?

From: dev@lucene.apache.org At: 12/06/17 19:42:30To:  dev@lucene.apache.org
Subject: Re: Lucene/Solr 7.2

Woah, twice the same mistake with different people. Sorry about that!

Le mer. 6 déc. 2017 à 20:28, Anshum Gupta <ansh...@apple.com> a écrit :

You meant Ishan here, right ? :) 

-Anshum

On Dec 6, 2017, at 5:02 AM, Adrien Grand <jpou...@gmail.com> wrote:
Thanks for the heads up, Anshum.

This leaves us with only SOLR-11458 to wait for before building a RC (which 
might be ready but just not marked as resolved).

Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <ichattopadhy...@gmail.com> a 
écrit :

Hi Adrien,
I'm planning to skip SOLR-11624 for this release (as per my last comment 
https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
 If someone has an objection, please let me know; otherwise, please feel free 
to proceed with the release.
I'll continue working on it anyway, and shall try to have it ready for the next 
release.
Thanks,
Ishan

On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand <jpou...@gmail.com> wrote:

FYI I created the new branch for 7.2, so you will have to backport to this 
branch. No hurry though, I mostly created the branch so that it's fine to 
cherry-pick changes that may wait for 7.3 to be released.

Le mer. 6 déc. 2017 à 08:53, Adrien Grand <jpou...@gmail.com> a écrit :

Sorry to hear that Ishan, I hope you are doing better now. +1 to get SOLR-11624 
in.

Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <ichattopadhy...@gmail.com> a 
écrit :

I was a bit unwell over the weekend and yesterday; I'm working on a very 
targeted fix for SOLR-11624 right now; I expect it to take another 5-6 hours.
Is that fine with you, Adrien? If not, please go ahead with the release, and 
I'll volunteer later for a bugfix release for this after 7.2 is out.

On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand <jpou...@gmail.com> wrote:

Fine with me. 

Le mar. 5 déc. 2017 à 22:34, Varun Thacker <va...@vthacker.in> a écrit :

Hi Adrien,

I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago and 
has been reviewed but never got committed. I've run all the tests twice as well 
to verify.

On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki 
<andrzej.biale...@lucidworks.com> wrote:

On 5 Dec 2017, at 18:05, Adrien Grand <jpou...@gmail.com> wrote:
Andrzej, ok to merge since it is a bug fix. Since we're close to the RC build, 
maybe try to get someone familiar with the code to review it to make sure it 
doesn't have unexpected side-effects?

Sure I’ll do this - thanks!

Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <andrzej.biale...@lucidworks.com> 
a écrit :

Adrien,

If it’s ok I would also like to merge SOLR-11458, this significantly reduces 
the chance of accidental data loss when using MoveReplicaCmd.

On 5 Dec 2017, at 14:44, Adrien Grand <jpou...@gmail.com> wrote:
Quick update:

LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they will 
be in 7.2.

LUCENE-8048 and SOLR-11624 are still open. 

LUCENE-8048 looks like it could make things better in some cases but I don't 
think it is required for 7.2, so I don't plan to hold the release on it.

SOLR-11624 looks bad, I'll wait for it.

Le mar. 5 déc. 2017 à 07:45, Noble Paul <noble.p...@gmail.com> a écrit :

+1 this is over due

On Dec 4, 2017 16:38, "Varun Thacker" <va...@vthacker.in> wrote:

+1 Adrien ! Thanks for taking it up

On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) 
<cpoersc...@bloomberg.net> wrote:

I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 included in the 
release. Hoping to commit it on/by Tuesday.

Christine

From: dev@lucene.apache.org At: 12/01/17 10:11:59To:  dev@lucene.apache.org
Subject: Lucene/Solr 7.2

Hello,

It's been more than 6 weeks since we released 7.1 and we accumulated a good set 
of changes, so I think we should release Lucene/Solr 7.2.0.

There is one change that I would like to have before building a RC: 
LUCENE-8043[1], which looks like it is almost ready to be merged. Please let me 
know if there are any other changes that should make it to the release.

I volunteer to be the release manager. I'm currently thinking of building the 
first release candidate next wednesday, December 6th.

[1] https://issues.apache.org/jira/browse/LUCENE-8043

Re: Lucene/Solr 7.2

2017-12-06 Thread Adrien Grand

Woah, twice the same mistake with different people. Sorry about that!

Le mer. 6 déc. 2017 à 20:28, Anshum Gupta  a écrit :

> You meant Ishan here, right ? :)
>
> -Anshum
>
>
>
> On Dec 6, 2017, at 5:02 AM, Adrien Grand  wrote:
>
> Thanks for the heads up, Anshum.
>
> This leaves us with only SOLR-11458 to wait for before building a RC
> (which might be ready but just not marked as resolved).
>
>
> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>
>> Hi Adrien,
>> I'm planning to skip SOLR-11624 for this release (as per my last comment
>> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
>> If someone has an objection, please let me know; otherwise, please feel
>> free to proceed with the release.
>> I'll continue working on it anyway, and shall try to have it ready for
>> the next release.
>> Thanks,
>> Ishan
>>
>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  wrote:
>>
>>> FYI I created the new branch for 7.2, so you will have to backport to
>>> this branch. No hurry though, I mostly created the branch so that it's fine
>>> to cherry-pick changes that may wait for 7.3 to be released.
>>>
>>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a écrit :
>>>
 Sorry to hear that Ishan, I hope you are doing better now. +1 to get
 SOLR-11624 in.

 Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
 ichattopadhy...@gmail.com> a écrit :

> I was a bit unwell over the weekend and yesterday; I'm working on a
> very targeted fix for SOLR-11624 right now; I expect it to take another 
> 5-6
> hours.
> Is that fine with you, Adrien? If not, please go ahead with the
> release, and I'll volunteer later for a bugfix release for this after 7.2
> is out.
>
> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand 
> wrote:
>
>> Fine with me.
>>
>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
>> écrit :
>>
>>> Hi Adrien,
>>>
>>> I'd like to commit SOLR-11590 . The issue had a patch couple of
>>> weeks ago and has been reviewed but never got committed. I've run all 
>>> the
>>> tests twice as well to verify.
>>>
>>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
>>> andrzej.biale...@lucidworks.com> wrote:
>>>

 On 5 Dec 2017, at 18:05, Adrien Grand  wrote:

 Andrzej, ok to merge since it is a bug fix. Since we're close to
 the RC build, maybe try to get someone familiar with the code to 
 review it
 to make sure it doesn't have unexpected side-effects?


 Sure I’ll do this - thanks!


 Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> a écrit :

> Adrien,
>
> If it’s ok I would also like to merge SOLR-11458, this
> significantly reduces the chance of accidental data loss when using
> MoveReplicaCmd.
>
> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>
> Quick update:
>
> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been
> merged, they will be in 7.2.
>
> LUCENE-8048 and SOLR-11624 are still open.
>
> LUCENE-8048 looks like it could make things better in some cases
> but I don't think it is required for 7.2, so I don't plan to hold the
> release on it.
>
> SOLR-11624 looks bad, I'll wait for it.
>
> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a
> écrit :
>
>> +1 this is over due
>>
>> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>>
>> +1 Adrien ! Thanks for taking it up
>>
>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/
>> QUEEN VIC)  wrote:
>>
>>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
>>> included in the release. Hoping to commit it on/by Tuesday.
>>>
>>> Christine
>>>
>>> From: dev@lucene.apache.org At: 12/01/17 10:11:59
>>> To: dev@lucene.apache.org
>>> Subject: Lucene/Solr 7.2
>>>
>>> Hello,
>>>
>>> It's been more than 6 weeks since we released 7.1 and we
>>> accumulated a good set of changes, so I think we should release 
>>> Lucene/Solr
>>> 7.2.0.
>>>
>>> There is one change that I would like to have before building a
>>> RC: LUCENE-8043[1], which looks like it is almost ready to be 
>>> merged.
>>> Please let me know if

Re: Lucene/Solr 7.2

2017-12-06 Thread Anshum Gupta

You meant Ishan here, right ? :)

-Anshum



> On Dec 6, 2017, at 5:02 AM, Adrien Grand  wrote:
> 
> Thanks for the heads up, Anshum.
> 
> This leaves us with only SOLR-11458 to wait for before building a RC (which 
> might be ready but just not marked as resolved).
> 
> 
> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya  > a écrit :
> Hi Adrien,
> I'm planning to skip SOLR-11624 for this release (as per my last comment 
> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121
>  
> ).
>  If someone has an objection, please let me know; otherwise, please feel free 
> to proceed with the release.
> I'll continue working on it anyway, and shall try to have it ready for the 
> next release.
> Thanks,
> Ishan
> 
> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  > wrote:
> FYI I created the new branch for 7.2, so you will have to backport to this 
> branch. No hurry though, I mostly created the branch so that it's fine to 
> cherry-pick changes that may wait for 7.3 to be released.
> 
> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  > a écrit :
> Sorry to hear that Ishan, I hope you are doing better now. +1 to get 
> SOLR-11624 in.
> 
> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya  > a écrit :
> I was a bit unwell over the weekend and yesterday; I'm working on a very 
> targeted fix for SOLR-11624 right now; I expect it to take another 5-6 hours.
> Is that fine with you, Adrien? If not, please go ahead with the release, and 
> I'll volunteer later for a bugfix release for this after 7.2 is out.
> 
> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand  > wrote:
> Fine with me.
> 
> 
> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  > a écrit :
> Hi Adrien,
> 
> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago and 
> has been reviewed but never got committed. I've run all the tests twice as 
> well to verify.
> 
> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki 
> > 
> wrote:
> 
>> On 5 Dec 2017, at 18:05, Adrien Grand > > wrote:
>> 
>> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC 
>> build, maybe try to get someone familiar with the code to review it to make 
>> sure it doesn't have unexpected side-effects?
> 
> Sure I’ll do this - thanks!
> 
>> 
>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki 
>> > a 
>> écrit :
>> Adrien,
>> 
>> If it’s ok I would also like to merge SOLR-11458, this significantly reduces 
>> the chance of accidental data loss when using MoveReplicaCmd.
>> 
>>> On 5 Dec 2017, at 14:44, Adrien Grand >> > wrote:
>>> 
>>> Quick update:
>>> 
>>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they 
>>> will be in 7.2.
>>> 
>>> LUCENE-8048 and SOLR-11624 are still open.
>>> 
>>> LUCENE-8048 looks like it could make things better in some cases but I 
>>> don't think it is required for 7.2, so I don't plan to hold the release on 
>>> it.
>>> 
>>> SOLR-11624 looks bad, I'll wait for it.
>>> 
>>> Le mar. 5 déc. 2017 à 07:45, Noble Paul >> > a écrit :
>>> +1 this is over due
>>> 
>>> On Dec 4, 2017 16:38, "Varun Thacker" >> > wrote:
>>> +1 Adrien ! Thanks for taking it up
>>> 
>>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) 
>>> > wrote:
>>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 
>>>  included in the release. 
>>> Hoping to commit it on/by Tuesday.
>>> 
>>> Christine
>>> 
>>> From: dev@lucene.apache.org  At: 12/01/17 
>>> 10:11:59
>>> To:  dev@lucene.apache.org 
>>> Subject: Lucene/Solr 7.2
>>> Hello,
>>> 
>>> It's been more than 6 weeks since we released 7.1 and we accumulated a good 
>>> set of changes, so I think we should release Lucene/Solr 7.2.0.
>>> 
>>> There is one change that I would like to have before building a RC: 
>>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please 
>>> let me know if there are any other changes that should make it to the 
>>> release.
>>> 
>>> I

Re: Lucene/Solr 7.2

2017-12-06 Thread Andrzej Białecki

I attached the patch to SOLR-11714, which disables the ‘searchRate’ trigger - 
if there are no objections I’ll commit it shortly to branch_7.2.

> On 6 Dec 2017, at 15:51, Andrzej Białecki  
> wrote:
> 
> 
>> On 6 Dec 2017, at 15:35, Andrzej Białecki > > wrote:
>> 
>> SOLR-11458 is committed and resolved - thanks for the patience.
> 
> 
> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a new 
> feature (searchRate autoscaling trigger). It’s probably best to disable this 
> feature in 7.2 rather than releasing a broken version, so I’d like to commit 
> a patch that disables it (plus a note in CHANGES.txt).
> 
> 
>> 
>> 
>> 
>>> On 6 Dec 2017, at 14:02, Adrien Grand >> > wrote:
>>> 
>>> Thanks for the heads up, Anshum.
>>> 
>>> This leaves us with only SOLR-11458 to wait for before building a RC (which 
>>> might be ready but just not marked as resolved).
>> 
>>> 
>>> 
>>> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya 
>>> > a écrit :
>>> Hi Adrien,
>>> I'm planning to skip SOLR-11624 for this release (as per my last comment 
>>> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121
>>>  
>>> ).
>>>  If someone has an objection, please let me know; otherwise, please feel 
>>> free to proceed with the release.
>>> I'll continue working on it anyway, and shall try to have it ready for the 
>>> next release.
>>> Thanks,
>>> Ishan
>>> 
>>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand >> > wrote:
>>> FYI I created the new branch for 7.2, so you will have to backport to this 
>>> branch. No hurry though, I mostly created the branch so that it's fine to 
>>> cherry-pick changes that may wait for 7.3 to be released.
>>> 
>>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand >> > a écrit :
>>> Sorry to hear that Ishan, I hope you are doing better now. +1 to get 
>>> SOLR-11624 in.
>>> 
>>> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya 
>>> > a écrit :
>>> I was a bit unwell over the weekend and yesterday; I'm working on a very 
>>> targeted fix for SOLR-11624 right now; I expect it to take another 5-6 
>>> hours.
>>> Is that fine with you, Adrien? If not, please go ahead with the release, 
>>> and I'll volunteer later for a bugfix release for this after 7.2 is out.
>>> 
>>> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand >> > wrote:
>>> Fine with me.
>>> 
>>> 
>>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker >> > a écrit :
>>> Hi Adrien,
>>> 
>>> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago 
>>> and has been reviewed but never got committed. I've run all the tests twice 
>>> as well to verify.
>>> 
>>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki 
>>> > 
>>> wrote:
>>> 
 On 5 Dec 2017, at 18:05, Adrien Grand > wrote:
 
 Andrzej, ok to merge since it is a bug fix. Since we're close to the RC 
 build, maybe try to get someone familiar with the code to review it to 
 make sure it doesn't have unexpected side-effects?
>>> 
>>> Sure I’ll do this - thanks!
>>> 
 
 Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki 
 > 
 a écrit :
 Adrien,
 
 If it’s ok I would also like to merge SOLR-11458, this significantly 
 reduces the chance of accidental data loss when using MoveReplicaCmd.
 
> On 5 Dec 2017, at 14:44, Adrien Grand  > wrote:
> 
> Quick update:
> 
> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they 
> will be in 7.2.
> 
> LUCENE-8048 and SOLR-11624 are still open. 
> 
> LUCENE-8048 looks like it could make things better in some cases but I 
> don't think it is required for 7.2, so I don't plan to hold the release 
> on it.
> 
> SOLR-11624 looks bad, I'll wait for it.
> 
> Le mar. 5 déc. 2017 à 07:45, Noble Paul  > a écrit :
> +1 this is over due
> 
> On Dec 4, 2017 16:38, "Varun Thacker"  > wrote:
> +1 Adrien ! Thanks for taking it up
> 
> On Fri, Dec

Re: Lucene/Solr 7.2

2017-12-06 Thread Andrzej Białecki


> On 6 Dec 2017, at 15:35, Andrzej Białecki  
> wrote:
> 
> SOLR-11458 is committed and resolved - thanks for the patience.


Actually, one more thing … ;) SOLR-11714 is a more serious bug in a new feature 
(searchRate autoscaling trigger). It’s probably best to disable this feature in 
7.2 rather than releasing a broken version, so I’d like to commit a patch that 
disables it (plus a note in CHANGES.txt).


> 
> 
> 
>> On 6 Dec 2017, at 14:02, Adrien Grand > > wrote:
>> 
>> Thanks for the heads up, Anshum.
>> 
>> This leaves us with only SOLR-11458 to wait for before building a RC (which 
>> might be ready but just not marked as resolved).
> 
>> 
>> 
>> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya > > a écrit :
>> Hi Adrien,
>> I'm planning to skip SOLR-11624 for this release (as per my last comment 
>> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121
>>  
>> ).
>>  If someone has an objection, please let me know; otherwise, please feel 
>> free to proceed with the release.
>> I'll continue working on it anyway, and shall try to have it ready for the 
>> next release.
>> Thanks,
>> Ishan
>> 
>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand > > wrote:
>> FYI I created the new branch for 7.2, so you will have to backport to this 
>> branch. No hurry though, I mostly created the branch so that it's fine to 
>> cherry-pick changes that may wait for 7.3 to be released.
>> 
>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand > > a écrit :
>> Sorry to hear that Ishan, I hope you are doing better now. +1 to get 
>> SOLR-11624 in.
>> 
>> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya > > a écrit :
>> I was a bit unwell over the weekend and yesterday; I'm working on a very 
>> targeted fix for SOLR-11624 right now; I expect it to take another 5-6 hours.
>> Is that fine with you, Adrien? If not, please go ahead with the release, and 
>> I'll volunteer later for a bugfix release for this after 7.2 is out.
>> 
>> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand > > wrote:
>> Fine with me.
>> 
>> 
>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker > > a écrit :
>> Hi Adrien,
>> 
>> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago 
>> and has been reviewed but never got committed. I've run all the tests twice 
>> as well to verify.
>> 
>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki 
>> > 
>> wrote:
>> 
>>> On 5 Dec 2017, at 18:05, Adrien Grand >> > wrote:
>>> 
>>> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC 
>>> build, maybe try to get someone familiar with the code to review it to make 
>>> sure it doesn't have unexpected side-effects?
>> 
>> Sure I’ll do this - thanks!
>> 
>>> 
>>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki 
>>> > 
>>> a écrit :
>>> Adrien,
>>> 
>>> If it’s ok I would also like to merge SOLR-11458, this significantly 
>>> reduces the chance of accidental data loss when using MoveReplicaCmd.
>>> 
 On 5 Dec 2017, at 14:44, Adrien Grand > wrote:
 
 Quick update:
 
 LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they 
 will be in 7.2.
 
 LUCENE-8048 and SOLR-11624 are still open. 
 
 LUCENE-8048 looks like it could make things better in some cases but I 
 don't think it is required for 7.2, so I don't plan to hold the release on 
 it.
 
 SOLR-11624 looks bad, I'll wait for it.
 
 Le mar. 5 déc. 2017 à 07:45, Noble Paul > a écrit :
 +1 this is over due
 
 On Dec 4, 2017 16:38, "Varun Thacker" > wrote:
 +1 Adrien ! Thanks for taking it up
 
 On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) 
 > wrote:
 I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 
  included in the release. 
 Hoping to commit it on/by Tuesday.
 
 Christine
 
 From: dev@lucene.apache.org

Re: Lucene/Solr 7.2

2017-12-06 Thread Andrzej Białecki

SOLR-11458 is committed and resolved - thanks for the patience.



> On 6 Dec 2017, at 14:02, Adrien Grand  wrote:
> 
> Thanks for the heads up, Anshum.
> 
> This leaves us with only SOLR-11458 to wait for before building a RC (which 
> might be ready but just not marked as resolved).

> 
> 
> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya  > a écrit :
> Hi Adrien,
> I'm planning to skip SOLR-11624 for this release (as per my last comment 
> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121
>  
> ).
>  If someone has an objection, please let me know; otherwise, please feel free 
> to proceed with the release.
> I'll continue working on it anyway, and shall try to have it ready for the 
> next release.
> Thanks,
> Ishan
> 
> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  > wrote:
> FYI I created the new branch for 7.2, so you will have to backport to this 
> branch. No hurry though, I mostly created the branch so that it's fine to 
> cherry-pick changes that may wait for 7.3 to be released.
> 
> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  > a écrit :
> Sorry to hear that Ishan, I hope you are doing better now. +1 to get 
> SOLR-11624 in.
> 
> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya  > a écrit :
> I was a bit unwell over the weekend and yesterday; I'm working on a very 
> targeted fix for SOLR-11624 right now; I expect it to take another 5-6 hours.
> Is that fine with you, Adrien? If not, please go ahead with the release, and 
> I'll volunteer later for a bugfix release for this after 7.2 is out.
> 
> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand  > wrote:
> Fine with me.
> 
> 
> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  > a écrit :
> Hi Adrien,
> 
> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago and 
> has been reviewed but never got committed. I've run all the tests twice as 
> well to verify.
> 
> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki 
> > 
> wrote:
> 
>> On 5 Dec 2017, at 18:05, Adrien Grand > > wrote:
>> 
>> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC 
>> build, maybe try to get someone familiar with the code to review it to make 
>> sure it doesn't have unexpected side-effects?
> 
> Sure I’ll do this - thanks!
> 
>> 
>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki 
>> > a 
>> écrit :
>> Adrien,
>> 
>> If it’s ok I would also like to merge SOLR-11458, this significantly reduces 
>> the chance of accidental data loss when using MoveReplicaCmd.
>> 
>>> On 5 Dec 2017, at 14:44, Adrien Grand >> > wrote:
>>> 
>>> Quick update:
>>> 
>>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they 
>>> will be in 7.2.
>>> 
>>> LUCENE-8048 and SOLR-11624 are still open. 
>>> 
>>> LUCENE-8048 looks like it could make things better in some cases but I 
>>> don't think it is required for 7.2, so I don't plan to hold the release on 
>>> it.
>>> 
>>> SOLR-11624 looks bad, I'll wait for it.
>>> 
>>> Le mar. 5 déc. 2017 à 07:45, Noble Paul >> > a écrit :
>>> +1 this is over due
>>> 
>>> On Dec 4, 2017 16:38, "Varun Thacker" >> > wrote:
>>> +1 Adrien ! Thanks for taking it up
>>> 
>>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) 
>>> > wrote:
>>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 
>>>  included in the release. 
>>> Hoping to commit it on/by Tuesday.
>>> 
>>> Christine
>>> 
>>> From: dev@lucene.apache.org  At: 12/01/17 
>>> 10:11:59
>>> To:  dev@lucene.apache.org 
>>> Subject: Lucene/Solr 7.2
>>> Hello,
>>> 
>>> It's been more than 6 weeks since we released 7.1 and we accumulated a good 
>>> set of changes, so I think we should release Lucene/Solr 7.2.0.
>>> 
>>> There is one change that I would like to have before building a RC: 
>>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please 
>>> let me know if there are any other changes that should make it to the 
>>>

Re: Lucene/Solr 7.2

2017-12-06 Thread Christine Poerschke (BLOOMBERG/ LONDON 3Q)

Hi Adrien,

One more potential ticket for the pre-RC list: SOLR-9743 seems to need some 
sort of follow-up w.r.t. solr/CHANGES.txt edits. I stumbled across it yesterday 
but beyond adding a note haven't had bandwidth to help out with the follow-up.

Christine

From: dev@lucene.apache.org At: 12/06/17 13:03:32To:  dev@lucene.apache.org
Subject: Re: Lucene/Solr 7.2

Thanks for the heads up, Anshum.

This leaves us with only SOLR-11458 to wait for before building a RC (which 
might be ready but just not marked as resolved).

Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya <ichattopadhy...@gmail.com> a 
écrit :

Hi Adrien,
I'm planning to skip SOLR-11624 for this release (as per my last comment 
https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
 If someone has an objection, please let me know; otherwise, please feel free 
to proceed with the release.
I'll continue working on it anyway, and shall try to have it ready for the next 
release.
Thanks,
Ishan

On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand <jpou...@gmail.com> wrote:

FYI I created the new branch for 7.2, so you will have to backport to this 
branch. No hurry though, I mostly created the branch so that it's fine to 
cherry-pick changes that may wait for 7.3 to be released.

Le mer. 6 déc. 2017 à 08:53, Adrien Grand <jpou...@gmail.com> a écrit :

Sorry to hear that Ishan, I hope you are doing better now. +1 to get SOLR-11624 
in.

Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <ichattopadhy...@gmail.com> a 
écrit :

I was a bit unwell over the weekend and yesterday; I'm working on a very 
targeted fix for SOLR-11624 right now; I expect it to take another 5-6 hours.
Is that fine with you, Adrien? If not, please go ahead with the release, and 
I'll volunteer later for a bugfix release for this after 7.2 is out.

On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand <jpou...@gmail.com> wrote:

Fine with me. 

Le mar. 5 déc. 2017 à 22:34, Varun Thacker <va...@vthacker.in> a écrit :

Hi Adrien,

I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago and 
has been reviewed but never got committed. I've run all the tests twice as well 
to verify.

On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki 
<andrzej.biale...@lucidworks.com> wrote:

On 5 Dec 2017, at 18:05, Adrien Grand <jpou...@gmail.com> wrote:
Andrzej, ok to merge since it is a bug fix. Since we're close to the RC build, 
maybe try to get someone familiar with the code to review it to make sure it 
doesn't have unexpected side-effects?

Sure I’ll do this - thanks!

Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <andrzej.biale...@lucidworks.com> 
a écrit :

Adrien,

If it’s ok I would also like to merge SOLR-11458, this significantly reduces 
the chance of accidental data loss when using MoveReplicaCmd.

On 5 Dec 2017, at 14:44, Adrien Grand <jpou...@gmail.com> wrote:
Quick update:

LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they will 
be in 7.2.

LUCENE-8048 and SOLR-11624 are still open. 

LUCENE-8048 looks like it could make things better in some cases but I don't 
think it is required for 7.2, so I don't plan to hold the release on it.

SOLR-11624 looks bad, I'll wait for it.

Le mar. 5 déc. 2017 à 07:45, Noble Paul <noble.p...@gmail.com> a écrit :

+1 this is over due

On Dec 4, 2017 16:38, "Varun Thacker" <va...@vthacker.in> wrote:

+1 Adrien ! Thanks for taking it up

On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) 
<cpoersc...@bloomberg.net> wrote:

I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 included in the 
release. Hoping to commit it on/by Tuesday.

Christine

From: dev@lucene.apache.org At: 12/01/17 10:11:59To:  dev@lucene.apache.org
Subject: Lucene/Solr 7.2

Hello,

It's been more than 6 weeks since we released 7.1 and we accumulated a good set 
of changes, so I think we should release Lucene/Solr 7.2.0.

There is one change that I would like to have before building a RC: 
LUCENE-8043[1], which looks like it is almost ready to be merged. Please let me 
know if there are any other changes that should make it to the release.

I volunteer to be the release manager. I'm currently thinking of building the 
first release candidate next wednesday, December 6th.

[1] https://issues.apache.org/jira/browse/LUCENE-8043

Re: Lucene/Solr 7.2

2017-12-06 Thread Adrien Grand

Thanks for the heads up, Anshum.

This leaves us with only SOLR-11458 to wait for before building a RC (which
might be ready but just not marked as resolved).


Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya 
a écrit :

> Hi Adrien,
> I'm planning to skip SOLR-11624 for this release (as per my last comment
> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
> If someone has an objection, please let me know; otherwise, please feel
> free to proceed with the release.
> I'll continue working on it anyway, and shall try to have it ready for the
> next release.
> Thanks,
> Ishan
>
> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  wrote:
>
>> FYI I created the new branch for 7.2, so you will have to backport to
>> this branch. No hurry though, I mostly created the branch so that it's fine
>> to cherry-pick changes that may wait for 7.3 to be released.
>>
>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a écrit :
>>
>>> Sorry to hear that Ishan, I hope you are doing better now. +1 to get
>>> SOLR-11624 in.
>>>
>>> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
>>> ichattopadhy...@gmail.com> a écrit :
>>>
 I was a bit unwell over the weekend and yesterday; I'm working on a
 very targeted fix for SOLR-11624 right now; I expect it to take another 5-6
 hours.
 Is that fine with you, Adrien? If not, please go ahead with the
 release, and I'll volunteer later for a bugfix release for this after 7.2
 is out.

 On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand  wrote:

> Fine with me.
>
> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
> écrit :
>
>> Hi Adrien,
>>
>> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks
>> ago and has been reviewed but never got committed. I've run all the tests
>> twice as well to verify.
>>
>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>>>
>>> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>>>
>>> Andrzej, ok to merge since it is a bug fix. Since we're close to the
>>> RC build, maybe try to get someone familiar with the code to review it 
>>> to
>>> make sure it doesn't have unexpected side-effects?
>>>
>>>
>>> Sure I’ll do this - thanks!
>>>
>>>
>>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
>>> andrzej.biale...@lucidworks.com> a écrit :
>>>
 Adrien,

 If it’s ok I would also like to merge SOLR-11458, this
 significantly reduces the chance of accidental data loss when using
 MoveReplicaCmd.

 On 5 Dec 2017, at 14:44, Adrien Grand  wrote:

 Quick update:

 LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged,
 they will be in 7.2.

 LUCENE-8048 and SOLR-11624 are still open.

 LUCENE-8048 looks like it could make things better in some cases
 but I don't think it is required for 7.2, so I don't plan to hold the
 release on it.

 SOLR-11624 looks bad, I'll wait for it.

 Le mar. 5 déc. 2017 à 07:45, Noble Paul  a
 écrit :

> +1 this is over due
>
> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>
> +1 Adrien ! Thanks for taking it up
>
> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/
> QUEEN VIC)  wrote:
>
>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
>> included in the release. Hoping to commit it on/by Tuesday.
>>
>> Christine
>>
>> From: dev@lucene.apache.org At: 12/01/17 10:11:59
>> To: dev@lucene.apache.org
>> Subject: Lucene/Solr 7.2
>>
>> Hello,
>>
>> It's been more than 6 weeks since we released 7.1 and we
>> accumulated a good set of changes, so I think we should release 
>> Lucene/Solr
>> 7.2.0.
>>
>> There is one change that I would like to have before building a
>> RC: LUCENE-8043[1], which looks like it is almost ready to be merged.
>> Please let me know if there are any other changes that should make 
>> it to
>> the release.
>>
>> I volunteer to be the release manager. I'm currently thinking of
>> building the first release candidate next wednesday, December 6th.
>>
>> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>
>>
>
>

>>>
>>

>

Re: Lucene/Solr 7.2

2017-12-06 Thread Ishan Chattopadhyaya

Hi Adrien,
I'm planning to skip SOLR-11624 for this release (as per my last comment
https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121).
If someone has an objection, please let me know; otherwise, please feel
free to proceed with the release.
I'll continue working on it anyway, and shall try to have it ready for the
next release.
Thanks,
Ishan

On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand  wrote:

> FYI I created the new branch for 7.2, so you will have to backport to this
> branch. No hurry though, I mostly created the branch so that it's fine to
> cherry-pick changes that may wait for 7.3 to be released.
>
> Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a écrit :
>
>> Sorry to hear that Ishan, I hope you are doing better now. +1 to get
>> SOLR-11624 in.
>>
>> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>>
>>> I was a bit unwell over the weekend and yesterday; I'm working on a very
>>> targeted fix for SOLR-11624 right now; I expect it to take another 5-6
>>> hours.
>>> Is that fine with you, Adrien? If not, please go ahead with the release,
>>> and I'll volunteer later for a bugfix release for this after 7.2 is out.
>>>
>>> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand  wrote:
>>>
 Fine with me.

 Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a
 écrit :

> Hi Adrien,
>
> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks
> ago and has been reviewed but never got committed. I've run all the tests
> twice as well to verify.
>
> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> wrote:
>
>>
>> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>>
>> Andrzej, ok to merge since it is a bug fix. Since we're close to the
>> RC build, maybe try to get someone familiar with the code to review it to
>> make sure it doesn't have unexpected side-effects?
>>
>>
>> Sure I’ll do this - thanks!
>>
>>
>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> a écrit :
>>
>>> Adrien,
>>>
>>> If it’s ok I would also like to merge SOLR-11458, this significantly
>>> reduces the chance of accidental data loss when using MoveReplicaCmd.
>>>
>>> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>>>
>>> Quick update:
>>>
>>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged,
>>> they will be in 7.2.
>>>
>>> LUCENE-8048 and SOLR-11624 are still open.
>>>
>>> LUCENE-8048 looks like it could make things better in some cases but
>>> I don't think it is required for 7.2, so I don't plan to hold the 
>>> release
>>> on it.
>>>
>>> SOLR-11624 looks bad, I'll wait for it.
>>>
>>> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a
>>> écrit :
>>>
 +1 this is over due

 On Dec 4, 2017 16:38, "Varun Thacker"  wrote:

 +1 Adrien ! Thanks for taking it up

 On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/
 QUEEN VIC)  wrote:

> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
> included in the release. Hoping to commit it on/by Tuesday.
>
> Christine
>
> From: dev@lucene.apache.org At: 12/01/17 10:11:59
> To: dev@lucene.apache.org
> Subject: Lucene/Solr 7.2
>
> Hello,
>
> It's been more than 6 weeks since we released 7.1 and we
> accumulated a good set of changes, so I think we should release 
> Lucene/Solr
> 7.2.0.
>
> There is one change that I would like to have before building a
> RC: LUCENE-8043[1], which looks like it is almost ready to be merged.
> Please let me know if there are any other changes that should make it 
> to
> the release.
>
> I volunteer to be the release manager. I'm currently thinking of
> building the first release candidate next wednesday, December 6th.
>
> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>
>


>>>
>>
>
>>>

Re: Lucene/Solr 7.2

2017-12-06 Thread Adrien Grand

FYI I created the new branch for 7.2, so you will have to backport to this
branch. No hurry though, I mostly created the branch so that it's fine to
cherry-pick changes that may wait for 7.3 to be released.

Le mer. 6 déc. 2017 à 08:53, Adrien Grand  a écrit :

> Sorry to hear that Ishan, I hope you are doing better now. +1 to get
> SOLR-11624 in.
>
> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>
>> I was a bit unwell over the weekend and yesterday; I'm working on a very
>> targeted fix for SOLR-11624 right now; I expect it to take another 5-6
>> hours.
>> Is that fine with you, Adrien? If not, please go ahead with the release,
>> and I'll volunteer later for a bugfix release for this after 7.2 is out.
>>
>> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand  wrote:
>>
>>> Fine with me.
>>>
>>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a écrit :
>>>
 Hi Adrien,

 I'd like to commit SOLR-11590 . The issue had a patch couple of weeks
 ago and has been reviewed but never got committed. I've run all the tests
 twice as well to verify.

 On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> wrote:

>
> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>
> Andrzej, ok to merge since it is a bug fix. Since we're close to the
> RC build, maybe try to get someone familiar with the code to review it to
> make sure it doesn't have unexpected side-effects?
>
>
> Sure I’ll do this - thanks!
>
>
> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> a écrit :
>
>> Adrien,
>>
>> If it’s ok I would also like to merge SOLR-11458, this significantly
>> reduces the chance of accidental data loss when using MoveReplicaCmd.
>>
>> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>>
>> Quick update:
>>
>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged,
>> they will be in 7.2.
>>
>> LUCENE-8048 and SOLR-11624 are still open.
>>
>> LUCENE-8048 looks like it could make things better in some cases but
>> I don't think it is required for 7.2, so I don't plan to hold the release
>> on it.
>>
>> SOLR-11624 looks bad, I'll wait for it.
>>
>> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a
>> écrit :
>>
>>> +1 this is over due
>>>
>>> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>>>
>>> +1 Adrien ! Thanks for taking it up
>>>
>>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/
>>> QUEEN VIC)  wrote:
>>>
 I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
 included in the release. Hoping to commit it on/by Tuesday.

 Christine

 From: dev@lucene.apache.org At: 12/01/17 10:11:59
 To: dev@lucene.apache.org
 Subject: Lucene/Solr 7.2

 Hello,

 It's been more than 6 weeks since we released 7.1 and we
 accumulated a good set of changes, so I think we should release 
 Lucene/Solr
 7.2.0.

 There is one change that I would like to have before building a RC:
 LUCENE-8043[1], which looks like it is almost ready to be merged. 
 Please
 let me know if there are any other changes that should make it to the
 release.

 I volunteer to be the release manager. I'm currently thinking of
 building the first release candidate next wednesday, December 6th.

 [1] https://issues.apache.org/jira/browse/LUCENE-8043


>>>
>>>
>>
>

>>

Re: Lucene/Solr 7.2

2017-12-05 Thread Adrien Grand

Sorry to hear that Ishan, I hope you are doing better now. +1 to get
SOLR-11624 in.

Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya 
a écrit :

> I was a bit unwell over the weekend and yesterday; I'm working on a very
> targeted fix for SOLR-11624 right now; I expect it to take another 5-6
> hours.
> Is that fine with you, Adrien? If not, please go ahead with the release,
> and I'll volunteer later for a bugfix release for this after 7.2 is out.
>
> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand  wrote:
>
>> Fine with me.
>>
>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a écrit :
>>
>>> Hi Adrien,
>>>
>>> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks
>>> ago and has been reviewed but never got committed. I've run all the tests
>>> twice as well to verify.
>>>
>>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
>>> andrzej.biale...@lucidworks.com> wrote:
>>>

 On 5 Dec 2017, at 18:05, Adrien Grand  wrote:

 Andrzej, ok to merge since it is a bug fix. Since we're close to the RC
 build, maybe try to get someone familiar with the code to review it to make
 sure it doesn't have unexpected side-effects?


 Sure I’ll do this - thanks!


 Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
 andrzej.biale...@lucidworks.com> a écrit :

> Adrien,
>
> If it’s ok I would also like to merge SOLR-11458, this significantly
> reduces the chance of accidental data loss when using MoveReplicaCmd.
>
> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>
> Quick update:
>
> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged,
> they will be in 7.2.
>
> LUCENE-8048 and SOLR-11624 are still open.
>
> LUCENE-8048 looks like it could make things better in some cases but I
> don't think it is required for 7.2, so I don't plan to hold the release on
> it.
>
> SOLR-11624 looks bad, I'll wait for it.
>
> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a
> écrit :
>
>> +1 this is over due
>>
>> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>>
>> +1 Adrien ! Thanks for taking it up
>>
>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN
>> VIC)  wrote:
>>
>>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
>>> included in the release. Hoping to commit it on/by Tuesday.
>>>
>>> Christine
>>>
>>> From: dev@lucene.apache.org At: 12/01/17 10:11:59
>>> To: dev@lucene.apache.org
>>> Subject: Lucene/Solr 7.2
>>>
>>> Hello,
>>>
>>> It's been more than 6 weeks since we released 7.1 and we accumulated
>>> a good set of changes, so I think we should release Lucene/Solr 7.2.0.
>>>
>>> There is one change that I would like to have before building a RC:
>>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
>>> let me know if there are any other changes that should make it to the
>>> release.
>>>
>>> I volunteer to be the release manager. I'm currently thinking of
>>> building the first release candidate next wednesday, December 6th.
>>>
>>> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>>
>>>
>>
>>
>

>>>
>

Re: Lucene/Solr 7.2

2017-12-05 Thread Ishan Chattopadhyaya

I was a bit unwell over the weekend and yesterday; I'm working on a very
targeted fix for SOLR-11624 right now; I expect it to take another 5-6
hours.
Is that fine with you, Adrien? If not, please go ahead with the release,
and I'll volunteer later for a bugfix release for this after 7.2 is out.

On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand  wrote:

> Fine with me.
>
> Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a écrit :
>
>> Hi Adrien,
>>
>> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago
>> and has been reviewed but never got committed. I've run all the tests twice
>> as well to verify.
>>
>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> wrote:
>>
>>>
>>> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>>>
>>> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC
>>> build, maybe try to get someone familiar with the code to review it to make
>>> sure it doesn't have unexpected side-effects?
>>>
>>>
>>> Sure I’ll do this - thanks!
>>>
>>>
>>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
>>> andrzej.biale...@lucidworks.com> a écrit :
>>>
 Adrien,

 If it’s ok I would also like to merge SOLR-11458, this significantly
 reduces the chance of accidental data loss when using MoveReplicaCmd.

 On 5 Dec 2017, at 14:44, Adrien Grand  wrote:

 Quick update:

 LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged,
 they will be in 7.2.

 LUCENE-8048 and SOLR-11624 are still open.

 LUCENE-8048 looks like it could make things better in some cases but I
 don't think it is required for 7.2, so I don't plan to hold the release on
 it.

 SOLR-11624 looks bad, I'll wait for it.

 Le mar. 5 déc. 2017 à 07:45, Noble Paul  a
 écrit :

> +1 this is over due
>
> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>
> +1 Adrien ! Thanks for taking it up
>
> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN
> VIC)  wrote:
>
>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
>> included in the release. Hoping to commit it on/by Tuesday.
>>
>> Christine
>>
>> From: dev@lucene.apache.org At: 12/01/17 10:11:59
>> To: dev@lucene.apache.org
>> Subject: Lucene/Solr 7.2
>>
>> Hello,
>>
>> It's been more than 6 weeks since we released 7.1 and we accumulated
>> a good set of changes, so I think we should release Lucene/Solr 7.2.0.
>>
>> There is one change that I would like to have before building a RC:
>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
>> let me know if there are any other changes that should make it to the
>> release.
>>
>> I volunteer to be the release manager. I'm currently thinking of
>> building the first release candidate next wednesday, December 6th.
>>
>> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>
>>
>
>

>>>
>>

Re: Lucene/Solr 7.2

2017-12-05 Thread Adrien Grand

Fine with me.

Le mar. 5 déc. 2017 à 22:34, Varun Thacker  a écrit :

> Hi Adrien,
>
> I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago
> and has been reviewed but never got committed. I've run all the tests twice
> as well to verify.
>
> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> wrote:
>
>>
>> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>>
>> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC
>> build, maybe try to get someone familiar with the code to review it to make
>> sure it doesn't have unexpected side-effects?
>>
>>
>> Sure I’ll do this - thanks!
>>
>>
>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
>> andrzej.biale...@lucidworks.com> a écrit :
>>
>>> Adrien,
>>>
>>> If it’s ok I would also like to merge SOLR-11458, this significantly
>>> reduces the chance of accidental data loss when using MoveReplicaCmd.
>>>
>>> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>>>
>>> Quick update:
>>>
>>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they
>>> will be in 7.2.
>>>
>>> LUCENE-8048 and SOLR-11624 are still open.
>>>
>>> LUCENE-8048 looks like it could make things better in some cases but I
>>> don't think it is required for 7.2, so I don't plan to hold the release on
>>> it.
>>>
>>> SOLR-11624 looks bad, I'll wait for it.
>>>
>>> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a écrit :
>>>
 +1 this is over due

 On Dec 4, 2017 16:38, "Varun Thacker"  wrote:

 +1 Adrien ! Thanks for taking it up

 On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN
 VIC)  wrote:

> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
> included in the release. Hoping to commit it on/by Tuesday.
>
> Christine
>
> From: dev@lucene.apache.org At: 12/01/17 10:11:59
> To: dev@lucene.apache.org
> Subject: Lucene/Solr 7.2
>
> Hello,
>
> It's been more than 6 weeks since we released 7.1 and we accumulated a
> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>
> There is one change that I would like to have before building a RC:
> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
> let me know if there are any other changes that should make it to the
> release.
>
> I volunteer to be the release manager. I'm currently thinking of
> building the first release candidate next wednesday, December 6th.
>
> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>
>


>>>
>>
>

Re: Lucene/Solr 7.2

2017-12-05 Thread Varun Thacker

Hi Adrien,

I'd like to commit SOLR-11590 . The issue had a patch couple of weeks ago
and has been reviewed but never got committed. I've run all the tests twice
as well to verify.

On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki <
andrzej.biale...@lucidworks.com> wrote:

>
> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
>
> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC
> build, maybe try to get someone familiar with the code to review it to make
> sure it doesn't have unexpected side-effects?
>
>
> Sure I’ll do this - thanks!
>
>
> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
> andrzej.biale...@lucidworks.com> a écrit :
>
>> Adrien,
>>
>> If it’s ok I would also like to merge SOLR-11458, this significantly
>> reduces the chance of accidental data loss when using MoveReplicaCmd.
>>
>> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>>
>> Quick update:
>>
>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they
>> will be in 7.2.
>>
>> LUCENE-8048 and SOLR-11624 are still open.
>>
>> LUCENE-8048 looks like it could make things better in some cases but I
>> don't think it is required for 7.2, so I don't plan to hold the release on
>> it.
>>
>> SOLR-11624 looks bad, I'll wait for it.
>>
>> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a écrit :
>>
>>> +1 this is over due
>>>
>>> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>>>
>>> +1 Adrien ! Thanks for taking it up
>>>
>>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN
>>> VIC)  wrote:
>>>
 I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
 included in the release. Hoping to commit it on/by Tuesday.

 Christine

 From: dev@lucene.apache.org At: 12/01/17 10:11:59
 To: dev@lucene.apache.org
 Subject: Lucene/Solr 7.2

 Hello,

 It's been more than 6 weeks since we released 7.1 and we accumulated a
 good set of changes, so I think we should release Lucene/Solr 7.2.0.

 There is one change that I would like to have before building a RC:
 LUCENE-8043[1], which looks like it is almost ready to be merged. Please
 let me know if there are any other changes that should make it to the
 release.

 I volunteer to be the release manager. I'm currently thinking of
 building the first release candidate next wednesday, December 6th.

 [1] https://issues.apache.org/jira/browse/LUCENE-8043


>>>
>>>
>>
>

Re: Lucene/Solr 7.2

2017-12-05 Thread Andrzej Białecki


> On 5 Dec 2017, at 18:05, Adrien Grand  wrote:
> 
> Andrzej, ok to merge since it is a bug fix. Since we're close to the RC 
> build, maybe try to get someone familiar with the code to review it to make 
> sure it doesn't have unexpected side-effects?

Sure I’ll do this - thanks!

> 
> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki 
> > a 
> écrit :
> Adrien,
> 
> If it’s ok I would also like to merge SOLR-11458, this significantly reduces 
> the chance of accidental data loss when using MoveReplicaCmd.
> 
>> On 5 Dec 2017, at 14:44, Adrien Grand > > wrote:
>> 
>> Quick update:
>> 
>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they 
>> will be in 7.2.
>> 
>> LUCENE-8048 and SOLR-11624 are still open. 
>> 
>> LUCENE-8048 looks like it could make things better in some cases but I don't 
>> think it is required for 7.2, so I don't plan to hold the release on it.
>> 
>> SOLR-11624 looks bad, I'll wait for it.
>> 
>> Le mar. 5 déc. 2017 à 07:45, Noble Paul > > a écrit :
>> +1 this is over due
>> 
>> On Dec 4, 2017 16:38, "Varun Thacker" > > wrote:
>> +1 Adrien ! Thanks for taking it up
>> 
>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) 
>> > wrote:
>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 
>>  included in the release. 
>> Hoping to commit it on/by Tuesday.
>> 
>> Christine
>> 
>> From: dev@lucene.apache.org  At: 12/01/17 
>> 10:11:59
>> To:  dev@lucene.apache.org 
>> Subject: Lucene/Solr 7.2
>> Hello,
>> 
>> It's been more than 6 weeks since we released 7.1 and we accumulated a good 
>> set of changes, so I think we should release Lucene/Solr 7.2.0.
>> 
>> There is one change that I would like to have before building a RC: 
>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please let 
>> me know if there are any other changes that should make it to the release.
>> 
>> I volunteer to be the release manager. I'm currently thinking of building 
>> the first release candidate next wednesday, December 6th.
>> 
>> [1] https://issues.apache.org/jira/browse/LUCENE-8043 
>> 
>> 
>

Re: Lucene/Solr 7.2

2017-12-05 Thread Adrien Grand

Andrzej, ok to merge since it is a bug fix. Since we're close to the RC
build, maybe try to get someone familiar with the code to review it to make
sure it doesn't have unexpected side-effects?

Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki <
andrzej.biale...@lucidworks.com> a écrit :

> Adrien,
>
> If it’s ok I would also like to merge SOLR-11458, this significantly
> reduces the chance of accidental data loss when using MoveReplicaCmd.
>
> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
>
> Quick update:
>
> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they
> will be in 7.2.
>
> LUCENE-8048 and SOLR-11624 are still open.
>
> LUCENE-8048 looks like it could make things better in some cases but I
> don't think it is required for 7.2, so I don't plan to hold the release on
> it.
>
> SOLR-11624 looks bad, I'll wait for it.
>
> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a écrit :
>
>> +1 this is over due
>>
>> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>>
>> +1 Adrien ! Thanks for taking it up
>>
>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN
>> VIC)  wrote:
>>
>>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137
>>> included in the release. Hoping to commit it on/by Tuesday.
>>>
>>> Christine
>>>
>>> From: dev@lucene.apache.org At: 12/01/17 10:11:59
>>> To: dev@lucene.apache.org
>>> Subject: Lucene/Solr 7.2
>>>
>>> Hello,
>>>
>>> It's been more than 6 weeks since we released 7.1 and we accumulated a
>>> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>>>
>>> There is one change that I would like to have before building a RC:
>>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
>>> let me know if there are any other changes that should make it to the
>>> release.
>>>
>>> I volunteer to be the release manager. I'm currently thinking of
>>> building the first release candidate next wednesday, December 6th.
>>>
>>> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>>
>>>
>>
>>
>

Re: Lucene/Solr 7.2

2017-12-05 Thread Andrzej Białecki

Adrien,

If it’s ok I would also like to merge SOLR-11458, this significantly reduces 
the chance of accidental data loss when using MoveReplicaCmd.

> On 5 Dec 2017, at 14:44, Adrien Grand  wrote:
> 
> Quick update:
> 
> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they will 
> be in 7.2.
> 
> LUCENE-8048 and SOLR-11624 are still open. 
> 
> LUCENE-8048 looks like it could make things better in some cases but I don't 
> think it is required for 7.2, so I don't plan to hold the release on it.
> 
> SOLR-11624 looks bad, I'll wait for it.
> 
> Le mar. 5 déc. 2017 à 07:45, Noble Paul  > a écrit :
> +1 this is over due
> 
> On Dec 4, 2017 16:38, "Varun Thacker"  > wrote:
> +1 Adrien ! Thanks for taking it up
> 
> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) 
> > wrote:
> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 
>  included in the release. 
> Hoping to commit it on/by Tuesday.
> 
> Christine
> 
> From: dev@lucene.apache.org  At: 12/01/17 
> 10:11:59
> To:  dev@lucene.apache.org 
> Subject: Lucene/Solr 7.2
> Hello,
> 
> It's been more than 6 weeks since we released 7.1 and we accumulated a good 
> set of changes, so I think we should release Lucene/Solr 7.2.0.
> 
> There is one change that I would like to have before building a RC: 
> LUCENE-8043[1], which looks like it is almost ready to be merged. Please let 
> me know if there are any other changes that should make it to the release.
> 
> I volunteer to be the release manager. I'm currently thinking of building the 
> first release candidate next wednesday, December 6th.
> 
> [1] https://issues.apache.org/jira/browse/LUCENE-8043 
> 
>

Re: Lucene/Solr 7.2

2017-12-05 Thread Erick Erickson

I'll be committing LUCENE-8048 in the next couple of hours. Ran 1,000
beasts of the failing test last night (thanks Simon!) so I'm pretty
confident now.

SOLR-11624 has been there since 7.0, I've pinged the others on that
JIRA about whether we should move forward with it for 7.2, I certainly
won't have time.

Erick

On Tue, Dec 5, 2017 at 6:03 AM, Yonik Seeley  wrote:
> I'm working on the very serious
> https://issues.apache.org/jira/browse/SOLR-11664 and hope to have it
> fixed today.
>
> -Yonik
>
>
> On Tue, Dec 5, 2017 at 8:44 AM, Adrien Grand  wrote:
>> Quick update:
>>
>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they
>> will be in 7.2.
>>
>> LUCENE-8048 and SOLR-11624 are still open.
>>
>> LUCENE-8048 looks like it could make things better in some cases but I don't
>> think it is required for 7.2, so I don't plan to hold the release on it.
>>
>> SOLR-11624 looks bad, I'll wait for it.
>>
>> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a écrit :
>>>
>>> +1 this is over due
>>>
>>> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>>>
>>> +1 Adrien ! Thanks for taking it up
>>>
>>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC)
>>>  wrote:

 I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 included
 in the release. Hoping to commit it on/by Tuesday.

 Christine

 From: dev@lucene.apache.org At: 12/01/17 10:11:59
 To: dev@lucene.apache.org
 Subject: Lucene/Solr 7.2

 Hello,

 It's been more than 6 weeks since we released 7.1 and we accumulated a
 good set of changes, so I think we should release Lucene/Solr 7.2.0.

 There is one change that I would like to have before building a RC:
 LUCENE-8043[1], which looks like it is almost ready to be merged. Please 
 let
 me know if there are any other changes that should make it to the release.

 I volunteer to be the release manager. I'm currently thinking of building
 the first release candidate next wednesday, December 6th.

 [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>>
>>>
>>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Lucene/Solr 7.2

2017-12-05 Thread Yonik Seeley

I'm working on the very serious
https://issues.apache.org/jira/browse/SOLR-11664 and hope to have it
fixed today.

-Yonik


On Tue, Dec 5, 2017 at 8:44 AM, Adrien Grand  wrote:
> Quick update:
>
> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they
> will be in 7.2.
>
> LUCENE-8048 and SOLR-11624 are still open.
>
> LUCENE-8048 looks like it could make things better in some cases but I don't
> think it is required for 7.2, so I don't plan to hold the release on it.
>
> SOLR-11624 looks bad, I'll wait for it.
>
> Le mar. 5 déc. 2017 à 07:45, Noble Paul  a écrit :
>>
>> +1 this is over due
>>
>> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>>
>> +1 Adrien ! Thanks for taking it up
>>
>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC)
>>  wrote:
>>>
>>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 included
>>> in the release. Hoping to commit it on/by Tuesday.
>>>
>>> Christine
>>>
>>> From: dev@lucene.apache.org At: 12/01/17 10:11:59
>>> To: dev@lucene.apache.org
>>> Subject: Lucene/Solr 7.2
>>>
>>> Hello,
>>>
>>> It's been more than 6 weeks since we released 7.1 and we accumulated a
>>> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>>>
>>> There is one change that I would like to have before building a RC:
>>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please let
>>> me know if there are any other changes that should make it to the release.
>>>
>>> I volunteer to be the release manager. I'm currently thinking of building
>>> the first release candidate next wednesday, December 6th.
>>>
>>> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>
>>
>>
>

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Lucene/Solr 7.2

2017-12-05 Thread Adrien Grand

Quick update:

LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been merged, they
will be in 7.2.

LUCENE-8048 and SOLR-11624 are still open.

LUCENE-8048 looks like it could make things better in some cases but I
don't think it is required for 7.2, so I don't plan to hold the release on
it.

SOLR-11624 looks bad, I'll wait for it.

Le mar. 5 déc. 2017 à 07:45, Noble Paul  a écrit :

> +1 this is over due
>
> On Dec 4, 2017 16:38, "Varun Thacker"  wrote:
>
> +1 Adrien ! Thanks for taking it up
>
> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC)
>  wrote:
>
>> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 included
>> in the release. Hoping to commit it on/by Tuesday.
>>
>> Christine
>>
>> From: dev@lucene.apache.org At: 12/01/17 10:11:59
>> To: dev@lucene.apache.org
>> Subject: Lucene/Solr 7.2
>>
>> Hello,
>>
>> It's been more than 6 weeks since we released 7.1 and we accumulated a
>> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>>
>> There is one change that I would like to have before building a RC:
>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
>> let me know if there are any other changes that should make it to the
>> release.
>>
>> I volunteer to be the release manager. I'm currently thinking of building
>> the first release candidate next wednesday, December 6th.
>>
>> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>
>>
>
>

Re: Lucene/Solr 7.2

2017-12-05 Thread David Smiley

Yes, I meant SOLR-11662 and *not* SOLR-11698.  Sorry for any confusion.

On Tue, Dec 5, 2017 at 5:55 AM Adrien Grand  wrote:

> David,
>
> Did you mean SOLR-11662 rather than SOLR-11698? SOLR-11698 looks like a
> big change that isn't nearly ready yet.
>
>
> Le ven. 1 déc. 2017 à 16:59, David Smiley  a
> écrit :
>
>> Doug's issue SOLR-11698 needs my final code review (probably final any
>> way) and I plan to commit that as late as Monday if it goes well.
>>
>> Erick... IMO:
>> * LUCENE-8048 probably needs some "bake" time IMO, plus it's not clear if
>> it's committable yet (waiting for other input).
>> * SOLR-11687 definitely include
>>
>>
>> On Fri, Dec 1, 2017 at 10:41 AM Erick Erickson 
>> wrote:
>>
>>> SOLR-11687 and LUCENE-8048 are ones I'd like to consider getting in to
>>> 7.2, should they have longer to bake though? Any opinions?
>>>
>>> On Fri, Dec 1, 2017 at 7:26 AM, Joel Bernstein 
>>> wrote:
>>> > +1. I have a couple of tickets that I should have wrapped up by Monday.
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>>
>>> --
>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
>> http://www.solrenterprisesearchserver.com
>>
> --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com

Re: Lucene/Solr 7.2

2017-12-05 Thread Adrien Grand

David,

Did you mean SOLR-11662 rather than SOLR-11698? SOLR-11698 looks like a big
change that isn't nearly ready yet.

Le ven. 1 déc. 2017 à 16:59, David Smiley  a
écrit :

> Doug's issue SOLR-11698 needs my final code review (probably final any
> way) and I plan to commit that as late as Monday if it goes well.
>
> Erick... IMO:
> * LUCENE-8048 probably needs some "bake" time IMO, plus it's not clear if
> it's committable yet (waiting for other input).
> * SOLR-11687 definitely include
>
>
> On Fri, Dec 1, 2017 at 10:41 AM Erick Erickson 
> wrote:
>
>> SOLR-11687 and LUCENE-8048 are ones I'd like to consider getting in to
>> 7.2, should they have longer to bake though? Any opinions?
>>
>> On Fri, Dec 1, 2017 at 7:26 AM, Joel Bernstein 
>> wrote:
>> > +1. I have a couple of tickets that I should have wrapped up by Monday.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>
>> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com
>

Re: Lucene/Solr 7.2

2017-12-04 Thread Noble Paul

+1 this is over due

On Dec 4, 2017 16:38, "Varun Thacker"  wrote:

+1 Adrien ! Thanks for taking it up

On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) <
cpoersc...@bloomberg.net> wrote:

> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 included
> in the release. Hoping to commit it on/by Tuesday.
>
> Christine
>
> From: dev@lucene.apache.org At: 12/01/17 10:11:59
> To: dev@lucene.apache.org
> Subject: Lucene/Solr 7.2
>
> Hello,
>
> It's been more than 6 weeks since we released 7.1 and we accumulated a
> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>
> There is one change that I would like to have before building a RC:
> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
> let me know if there are any other changes that should make it to the
> release.
>
> I volunteer to be the release manager. I'm currently thinking of building
> the first release candidate next wednesday, December 6th.
>
> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>
>

Re: Lucene/Solr 7.2

2017-12-03 Thread Varun Thacker

+1 Adrien ! Thanks for taking it up

On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke (BLOOMBERG/ QUEEN VIC) <
cpoersc...@bloomberg.net> wrote:

> I'd like to see https://issues.apache.org/jira/browse/SOLR-9137 included
> in the release. Hoping to commit it on/by Tuesday.
>
> Christine
>
> From: dev@lucene.apache.org At: 12/01/17 10:11:59
> To: dev@lucene.apache.org
> Subject: Lucene/Solr 7.2
>
> Hello,
>
> It's been more than 6 weeks since we released 7.1 and we accumulated a
> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>
> There is one change that I would like to have before building a RC:
> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
> let me know if there are any other changes that should make it to the
> release.
>
> I volunteer to be the release manager. I'm currently thinking of building
> the first release candidate next wednesday, December 6th.
>
> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>
>

Re: Lucene/Solr 7.2

2017-12-01 Thread Erick Erickson

David:

Well, I can make LUCENE-8048 committable in about 30 seconds ;) On a
more serious note, I've already delayed 2 weeks to give people time to
respond but nobody has. I'll put some time into digging at why the
test failures happened and if they're a test artifact rather than a
fundamental problem I'll be more inclined to push forward on it. We'll
see what I can find in the next day or two.


On Fri, Dec 1, 2017 at 7:59 AM, David Smiley  wrote:
> Doug's issue SOLR-11698 needs my final code review (probably final any way)
> and I plan to commit that as late as Monday if it goes well.
>
> Erick... IMO:
> * LUCENE-8048 probably needs some "bake" time IMO, plus it's not clear if
> it's committable yet (waiting for other input).
> * SOLR-11687 definitely include
>
>
> On Fri, Dec 1, 2017 at 10:41 AM Erick Erickson 
> wrote:
>>
>> SOLR-11687 and LUCENE-8048 are ones I'd like to consider getting in to
>> 7.2, should they have longer to bake though? Any opinions?
>>
>> On Fri, Dec 1, 2017 at 7:26 AM, Joel Bernstein  wrote:
>> > +1. I have a couple of tickets that I should have wrapped up by Monday.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Lucene/Solr 7.2

2017-12-01 Thread David Smiley

Doug's issue SOLR-11698 needs my final code review (probably final any way)
and I plan to commit that as late as Monday if it goes well.

Erick... IMO:
* LUCENE-8048 probably needs some "bake" time IMO, plus it's not clear if
it's committable yet (waiting for other input).
* SOLR-11687 definitely include

On Fri, Dec 1, 2017 at 10:41 AM Erick Erickson 
wrote:

> SOLR-11687 and LUCENE-8048 are ones I'd like to consider getting in to
> 7.2, should they have longer to bake though? Any opinions?
>
> On Fri, Dec 1, 2017 at 7:26 AM, Joel Bernstein  wrote:
> > +1. I have a couple of tickets that I should have wrapped up by Monday.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
> --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com

Re: Lucene/Solr 7.2

2017-12-01 Thread Erick Erickson

SOLR-11687 and LUCENE-8048 are ones I'd like to consider getting in to
7.2, should they have longer to bake though? Any opinions?

On Fri, Dec 1, 2017 at 7:26 AM, Joel Bernstein  wrote:
> +1. I have a couple of tickets that I should have wrapped up by Monday.

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Lucene/Solr 7.2

2017-12-01 Thread Joel Bernstein

+1. I have a couple of tickets that I should have wrapped up by Monday.

Re: Lucene/Solr 7.2

2017-12-01 Thread Adrien Grand

It is not too time-consuming. The whole process takes a lot of time, but
most of the time is actually spent waiting (for other people to vote, that
javadocs upload, that mirrors replicate, etc.). You can have a look at
https://wiki.apache.org/lucene-java/ReleaseTodo to see what kind of things
need to be done as part of the release process. If you'd like to give it a
try but you're not sure how much time you can allocate to it, it might be
easier to start with a bugfix release, which usually has fewer chances of
being respun since the set of chances is usually more contained.

Le ven. 1 déc. 2017 à 15:48, David Smiley  a
écrit :

> Adrien,
>
> Thanks for doing this release.  Just curious, how much time would you
> estimate is involved in being the RM?  I've never done it before.  I'm not
> offering to take over this release but maybe I'll do a future one.
>
> ~ David
>
>
> On Fri, Dec 1, 2017 at 5:11 AM Adrien Grand  wrote:
>
>> Hello,
>>
>> It's been more than 6 weeks since we released 7.1 and we accumulated a
>> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>>
>> There is one change that I would like to have before building a RC:
>> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
>> let me know if there are any other changes that should make it to the
>> release.
>>
>> I volunteer to be the release manager. I'm currently thinking of building
>> the first release candidate next wednesday, December 6th.
>>
>> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>>
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com
>

Re: Lucene/Solr 7.2

2017-12-01 Thread David Smiley

Adrien,

Thanks for doing this release.  Just curious, how much time would you
estimate is involved in being the RM?  I've never done it before.  I'm not
offering to take over this release but maybe I'll do a future one.

~ David

On Fri, Dec 1, 2017 at 5:11 AM Adrien Grand  wrote:

> Hello,
>
> It's been more than 6 weeks since we released 7.1 and we accumulated a
> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>
> There is one change that I would like to have before building a RC:
> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
> let me know if there are any other changes that should make it to the
> release.
>
> I volunteer to be the release manager. I'm currently thinking of building
> the first release candidate next wednesday, December 6th.
>
> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>
-- 
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com

Re: Lucene/Solr 7.2

2017-12-01 Thread Ishan Chattopadhyaya

There's SOLR-11624 that I want to get in; I'm planning to have it in by
Monday/Tuesday.

On Fri, Dec 1, 2017 at 3:41 PM, Adrien Grand  wrote:

> Hello,
>
> It's been more than 6 weeks since we released 7.1 and we accumulated a
> good set of changes, so I think we should release Lucene/Solr 7.2.0.
>
> There is one change that I would like to have before building a RC:
> LUCENE-8043[1], which looks like it is almost ready to be merged. Please
> let me know if there are any other changes that should make it to the
> release.
>
> I volunteer to be the release manager. I'm currently thinking of building
> the first release candidate next wednesday, December 6th.
>
> [1] https://issues.apache.org/jira/browse/LUCENE-8043
>

38 matches

Mail list logo