Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-07 Thread Jan Høydahl
Thanks Mayya. I took a stab at summarizing Solr highlights in 
https://cwiki.apache.org/confluence/display/SOLR/ReleaseNote89 

Jan

> 6. jun. 2021 kl. 16:43 skrev Mayya Sharipova 
> :
> 
> Hello everyone, I would appreciate help with with following for 8.9 release:
> Release Highlights. I gave it a try for Lucene (but I don't have experience 
> to judge what qualifies as a release highlight, so please edit/remove/add). 
> Edits can be done here: Lucene Release Note 8.9 
> ,  Solr 
> Release Note 8.9 
> . 
>  Resolve failures in Lucene-Solr-SmokeRelease-8.9 
> ,  currently fails with an error:
>[smoker]   File 
> "/home/jenkins/jenkins-slave/workspace/Lucene/Lucene-Solr-SmokeRelease-8.9/dev-tools/scripts/smokeTestRelease.py",
>  line 125, in noJavaPackageClasses
>[smoker] raise RuntimeError('%s contains sheisty class "%s"' %  (desc, 
> name2))
>[smoker] RuntimeError: JAR file 
> "/home/jenkins/jenkins-slave/workspace/Lucene/Lucene-Solr-SmokeRelease-8.9/lucene/build/smokeTestRelease/tmp/unpack/solr-8.9.0/contrib/gcs-repository/lib/jsr305-3.0.2.jar"
>  contains sheisty class "javax/annotation/CheckForNull.class"
> 
> Thank you in advance.
> 
> On Fri, Jun 4, 2021 at 9:40 AM Jan Høydahl  > wrote:
> SOLR-15316 / PR 2502 is now merged to branch_8_9
> 
> Jan
> 
>> 3. jun. 2021 kl. 20:53 skrev Mayya Sharipova 
>> > >:
>> 
>> I can wait till this PR 2502 is backported (hopefully by tomorrow? and 
>> hopefully will be the last item to wait for).
>> And tomorrow I will try to build a RC.
>> 
>> 
>> 
>> On Thu, Jun 3, 2021 at 8:57 AM Cassandra Targett > > wrote:
>> It’s OK with me, but I’m not really in a position to understand the changes 
>> and/or test it. And while we have a branch, I’m not clear on when the first 
>> RC is planned, so Mayya should weigh in I think.
>> 
>> Cassandra
>> On Jun 3, 2021, 5:49 AM -0500, Jan Høydahl > >, wrote:
>>> Mayya, Cassandra, I'd like to merge the Jetty upgrade, SOLR-15316 to 
>>> branch_8x and branch_8_9. See backport PR 
>>> https://github.com/apache/lucene-solr/pull/2502 
>>> 
>>> Is that ok?
>>> 
>>> Jan
>>> 
 2. jun. 2021 kl. 01:00 skrev Jan Høydahl >>> >:
 
 Cassandra,
 
 Thanks for spotting the Jetty JIRA (SOLR-15316 
 ). I put up a quck PR 
  for upgrading Jetty to 
 9.4.41.v20210516. Currently running all tests.
 Due to the CVEs I think there should not be a new Solr release without 
 this upgrade. I set fixVersion to 8.9 and kept the blocker. If anyone 
 disagrees, speak out.
 
 There's always a risk of a new Jetty version introducing new bugs, but 
 this is a minor version upgrade with (almost) exclusively bug fixes since 
 9.4.36, so I'm willing to take the risk if tests look good. Perhaps 
 Jenkins gets a few test spins on main before the 8.9 release too. Whyt 
 Mayya?
 
 Jan
 
> 1. jun. 2021 kl. 23:04 skrev Cassandra Targett  >:
> 
> I got a question this morning about some Jetty CVEs that look to be fixed 
> with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no 
> version) to upgrade to that version. Is there time to do that for 8.9? Or 
> is it too high risk or would take too long? 
> https://issues.apache.org/jira/browse/SOLR-15316 
> 
> 
> Sorry, I’m way behind on mailing lists and didn’t see the branch had been 
> cut already!
> 
> Cassandra
> On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl  >, wrote:
>> Let's not hold up the release due to this incomplete PR. It obviously 
>> needs more time for completion and there is always a new train to catch.
>> As far as I understand, Circuit breakers are pluggable, so anyone can 
>> configure their own implementation in the meantime?
>> 
>> Jan
>> 
>>> 1. jun. 2021 kl. 22:13 skrev Atri Sharma >> >:
>>> 
>>> I appreciate you fixing this and adding the new circuit breaker and 
>>> look forward to having it in the hands of our users soon.
>>> 
>>> However, the current state of PR, with significant API churn for a 
>>> single change and overlapping code is not yet ready.
>>> 
>>> If this is too much of a rework, I am happy to take the existing PR and 
>>> do the changes, post which I believe the PR should be close to 
>>> completion. 
>>> 
>>> Let me know if you need me to help, 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-06 Thread Mayya Sharipova
Hello everyone, I would appreciate help with with following for 8.9 release:

   1. *Release Highlights*. I gave it a try for Lucene (but I don't have
   experience to judge what qualifies as a release highlight, so please
   edit/remove/add). Edits can be done here: Lucene Release Note 8.9
   ,
   Solr Release Note 8.9
   .
   2.  Resolve failures in Lucene-Solr-SmokeRelease-8.9,  currently fails
   with an error:

   [smoker]   File
"/home/jenkins/jenkins-slave/workspace/Lucene/Lucene-Solr-SmokeRelease-8.9/dev-tools/scripts/smokeTestRelease.py",
line 125, in noJavaPackageClasses
   [smoker] raise RuntimeError('%s contains sheisty class "%s"' %
(desc, name2))
   [smoker] RuntimeError: JAR file
"/home/jenkins/jenkins-slave/workspace/Lucene/Lucene-Solr-SmokeRelease-8.9/lucene/build/smokeTestRelease/tmp/unpack/solr-8.9.0/contrib/gcs-repository/lib/jsr305-3.0.2.jar"
contains sheisty class "javax/annotation/CheckForNull.class"


Thank you in advance.

On Fri, Jun 4, 2021 at 9:40 AM Jan Høydahl  wrote:

> SOLR-15316 / PR 2502 is now merged to branch_8_9
>
> Jan
>
> 3. jun. 2021 kl. 20:53 skrev Mayya Sharipova <
> mayya.sharip...@elastic.co.INVALID>:
>
> I can wait till this PR 2502 is backported (hopefully by tomorrow? and
> hopefully will be the last item to wait for).
> And tomorrow I will try to build a RC.
>
>
>
> On Thu, Jun 3, 2021 at 8:57 AM Cassandra Targett 
> wrote:
>
>> It’s OK with me, but I’m not really in a position to understand the
>> changes and/or test it. And while we have a branch, I’m not clear on when
>> the first RC is planned, so Mayya should weigh in I think.
>>
>> Cassandra
>> On Jun 3, 2021, 5:49 AM -0500, Jan Høydahl ,
>> wrote:
>>
>> Mayya, Cassandra, I'd like to merge the Jetty upgrade, SOLR-15316 to
>> branch_8x and branch_8_9. See backport PR
>> https://github.com/apache/lucene-solr/pull/2502
>> Is that ok?
>>
>> Jan
>>
>> 2. jun. 2021 kl. 01:00 skrev Jan Høydahl :
>>
>> Cassandra,
>>
>> Thanks for spotting the Jetty JIRA (SOLR-15316
>> ). I put up a quck PR
>>  for upgrading Jetty
>> to 9.4.41.v20210516. Currently running all tests.
>> Due to the CVEs I think there should not be a new Solr release without
>> this upgrade. I set fixVersion to 8.9 and kept the blocker. If anyone
>> disagrees, speak out.
>>
>> There's always a risk of a new Jetty version introducing new bugs, but
>> this is a minor version upgrade with (almost) exclusively bug fixes since
>> 9.4.36, so I'm willing to take the risk if tests look good. Perhaps Jenkins
>> gets a few test spins on main before the 8.9 release too. Whyt Mayya?
>>
>> Jan
>>
>> 1. jun. 2021 kl. 23:04 skrev Cassandra Targett :
>>
>> I got a question this morning about some Jetty CVEs that look to be fixed
>> with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no
>> version) to upgrade to that version. Is there time to do that for 8.9? Or
>> is it too high risk or would take too long?
>> https://issues.apache.org/jira/browse/SOLR-15316
>>
>> Sorry, I’m way behind on mailing lists and didn’t see the branch had been
>> cut already!
>>
>> Cassandra
>> On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl ,
>> wrote:
>>
>> Let's not hold up the release due to this incomplete PR. It obviously
>> needs more time for completion and there is always a new train to catch.
>> As far as I understand, Circuit breakers are pluggable, so anyone can
>> configure their own implementation in the meantime?
>>
>> Jan
>>
>> 1. jun. 2021 kl. 22:13 skrev Atri Sharma :
>>
>> I appreciate you fixing this and adding the new circuit breaker and look
>> forward to having it in the hands of our users soon.
>>
>> However, the current state of PR, with significant API churn for a single
>> change and overlapping code is not yet ready.
>>
>> If this is too much of a rework, I am happy to take the existing PR and
>> do the changes, post which I believe the PR should be close to completion.
>>
>> Let me know if you need me to help, but unfortunately, the two objections
>> I raised are blockers, atleast until we establish that they cannot be done
>> away with.
>>
>>
>> On Wed, 2 Jun 2021, 01:37 Walter Underwood, 
>> wrote:
>>
>>> I would appreciate a second opinion on the pull request. Substantive
>>> issues have been resolved. At this point, the discussion is about code
>>> style and coding standards. I don’t have detailed knowledge about the Solr
>>> coding style, so I’d appreciate another set of eyes.
>>>
>>> The current behavior is buggy, and we are not able to use it at Chegg.
>>> The patch fixes those bugs.
>>>
>>> https://github.com/apache/solr/pull/96
>>>
>>> wunder
>>> Walter Underwood
>>> wun...@wunderwood.org
>>> http://observer.wunderwood.org/  (my blog)
>>>
>>> On Jun 1, 2021, at 12:27 PM, Walter Underwood 
>>> wrote:
>>>
>>> I answered 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-04 Thread Jan Høydahl
SOLR-15316 / PR 2502 is now merged to branch_8_9

Jan

> 3. jun. 2021 kl. 20:53 skrev Mayya Sharipova 
> :
> 
> I can wait till this PR 2502 is backported (hopefully by tomorrow? and 
> hopefully will be the last item to wait for).
> And tomorrow I will try to build a RC.
> 
> 
> 
> On Thu, Jun 3, 2021 at 8:57 AM Cassandra Targett  > wrote:
> It’s OK with me, but I’m not really in a position to understand the changes 
> and/or test it. And while we have a branch, I’m not clear on when the first 
> RC is planned, so Mayya should weigh in I think.
> 
> Cassandra
> On Jun 3, 2021, 5:49 AM -0500, Jan Høydahl  >, wrote:
>> Mayya, Cassandra, I'd like to merge the Jetty upgrade, SOLR-15316 to 
>> branch_8x and branch_8_9. See backport PR 
>> https://github.com/apache/lucene-solr/pull/2502 
>> 
>> Is that ok?
>> 
>> Jan
>> 
>>> 2. jun. 2021 kl. 01:00 skrev Jan Høydahl >> >:
>>> 
>>> Cassandra,
>>> 
>>> Thanks for spotting the Jetty JIRA (SOLR-15316 
>>> ). I put up a quck PR 
>>>  for upgrading Jetty to 
>>> 9.4.41.v20210516. Currently running all tests.
>>> Due to the CVEs I think there should not be a new Solr release without this 
>>> upgrade. I set fixVersion to 8.9 and kept the blocker. If anyone disagrees, 
>>> speak out.
>>> 
>>> There's always a risk of a new Jetty version introducing new bugs, but this 
>>> is a minor version upgrade with (almost) exclusively bug fixes since 
>>> 9.4.36, so I'm willing to take the risk if tests look good. Perhaps Jenkins 
>>> gets a few test spins on main before the 8.9 release too. Whyt Mayya?
>>> 
>>> Jan
>>> 
 1. jun. 2021 kl. 23:04 skrev Cassandra Targett >>> >:
 
 I got a question this morning about some Jetty CVEs that look to be fixed 
 with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no 
 version) to upgrade to that version. Is there time to do that for 8.9? Or 
 is it too high risk or would take too long? 
 https://issues.apache.org/jira/browse/SOLR-15316 
 
 
 Sorry, I’m way behind on mailing lists and didn’t see the branch had been 
 cut already!
 
 Cassandra
 On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl >>> >, wrote:
> Let's not hold up the release due to this incomplete PR. It obviously 
> needs more time for completion and there is always a new train to catch.
> As far as I understand, Circuit breakers are pluggable, so anyone can 
> configure their own implementation in the meantime?
> 
> Jan
> 
>> 1. jun. 2021 kl. 22:13 skrev Atri Sharma > >:
>> 
>> I appreciate you fixing this and adding the new circuit breaker and look 
>> forward to having it in the hands of our users soon.
>> 
>> However, the current state of PR, with significant API churn for a 
>> single change and overlapping code is not yet ready.
>> 
>> If this is too much of a rework, I am happy to take the existing PR and 
>> do the changes, post which I believe the PR should be close to 
>> completion. 
>> 
>> Let me know if you need me to help, but unfortunately, the two 
>> objections I raised are blockers, atleast until we establish that they 
>> cannot be done away with. 
>> 
>> 
>> On Wed, 2 Jun 2021, 01:37 Walter Underwood, > > wrote:
>> I would appreciate a second opinion on the pull request. Substantive 
>> issues have been resolved. At this point, the discussion is about code 
>> style and coding standards. I don’t have detailed knowledge about the 
>> Solr coding style, so I’d appreciate another set of eyes.
>> 
>> The current behavior is buggy, and we are not able to use it at Chegg. 
>> The patch fixes those bugs.
>> 
>> https://github.com/apache/solr/pull/96 
>> 
>> 
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org 
>> http://observer.wunderwood.org/   (my 
>> blog)
>> 
>>> On Jun 1, 2021, at 12:27 PM, Walter Underwood >> > wrote:
>>> 
>>> I answered the comments. I don’t see those answers on github, oddly.
>>> 
>>> I’ll re-answer them. Most of your questions are already answered in the 
>>> discussion on Jira.
>>> 
>>> I central issues is that load average is not always a CPU measure. In 
>>> some systems, it includes threads in iowait. So it is potentially 
>>> misleading to label it as CPU and document it as CPU. The updated 
>>> documentation makes that clear, so 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-03 Thread Mayya Sharipova
I can wait till this PR 2502 is backported (hopefully by tomorrow? and
hopefully will be the last item to wait for).
And tomorrow I will try to build a RC.



On Thu, Jun 3, 2021 at 8:57 AM Cassandra Targett 
wrote:

> It’s OK with me, but I’m not really in a position to understand the
> changes and/or test it. And while we have a branch, I’m not clear on when
> the first RC is planned, so Mayya should weigh in I think.
>
> Cassandra
> On Jun 3, 2021, 5:49 AM -0500, Jan Høydahl , wrote:
>
> Mayya, Cassandra, I'd like to merge the Jetty upgrade, SOLR-15316 to
> branch_8x and branch_8_9. See backport PR
> https://github.com/apache/lucene-solr/pull/2502
> Is that ok?
>
> Jan
>
> 2. jun. 2021 kl. 01:00 skrev Jan Høydahl :
>
> Cassandra,
>
> Thanks for spotting the Jetty JIRA (SOLR-15316
> ). I put up a quck PR
>  for upgrading Jetty
> to 9.4.41.v20210516. Currently running all tests.
> Due to the CVEs I think there should not be a new Solr release without
> this upgrade. I set fixVersion to 8.9 and kept the blocker. If anyone
> disagrees, speak out.
>
> There's always a risk of a new Jetty version introducing new bugs, but
> this is a minor version upgrade with (almost) exclusively bug fixes since
> 9.4.36, so I'm willing to take the risk if tests look good. Perhaps Jenkins
> gets a few test spins on main before the 8.9 release too. Whyt Mayya?
>
> Jan
>
> 1. jun. 2021 kl. 23:04 skrev Cassandra Targett :
>
> I got a question this morning about some Jetty CVEs that look to be fixed
> with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no
> version) to upgrade to that version. Is there time to do that for 8.9? Or
> is it too high risk or would take too long?
> https://issues.apache.org/jira/browse/SOLR-15316
>
> Sorry, I’m way behind on mailing lists and didn’t see the branch had been
> cut already!
>
> Cassandra
> On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl , wrote:
>
> Let's not hold up the release due to this incomplete PR. It obviously
> needs more time for completion and there is always a new train to catch.
> As far as I understand, Circuit breakers are pluggable, so anyone can
> configure their own implementation in the meantime?
>
> Jan
>
> 1. jun. 2021 kl. 22:13 skrev Atri Sharma :
>
> I appreciate you fixing this and adding the new circuit breaker and look
> forward to having it in the hands of our users soon.
>
> However, the current state of PR, with significant API churn for a single
> change and overlapping code is not yet ready.
>
> If this is too much of a rework, I am happy to take the existing PR and do
> the changes, post which I believe the PR should be close to completion.
>
> Let me know if you need me to help, but unfortunately, the two objections
> I raised are blockers, atleast until we establish that they cannot be done
> away with.
>
>
> On Wed, 2 Jun 2021, 01:37 Walter Underwood,  wrote:
>
>> I would appreciate a second opinion on the pull request. Substantive
>> issues have been resolved. At this point, the discussion is about code
>> style and coding standards. I don’t have detailed knowledge about the Solr
>> coding style, so I’d appreciate another set of eyes.
>>
>> The current behavior is buggy, and we are not able to use it at Chegg.
>> The patch fixes those bugs.
>>
>> https://github.com/apache/solr/pull/96
>>
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org
>> http://observer.wunderwood.org/  (my blog)
>>
>> On Jun 1, 2021, at 12:27 PM, Walter Underwood 
>> wrote:
>>
>> I answered the comments. I don’t see those answers on github, oddly.
>>
>> I’ll re-answer them. Most of your questions are already answered in the
>> discussion on Jira.
>>
>> I central issues is that load average is not always a CPU measure. In
>> some systems, it includes threads in iowait. So it is potentially
>> misleading to label it as CPU and document it as CPU. The updated
>> documentation makes that clear, so that should have already answered your
>> comment. that is why it is important to rename the existing circuit breaker.
>>
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org
>> http://observer.wunderwood.org/  (my blog)
>>
>> On Jun 1, 2021, at 12:20 PM, Atri Sharma  wrote:
>>
>> I tool a look at the PR and gave comments for SOLR-15056, and the last I
>> checked, my comments were not addressed?
>>
>> On Wed, 2 Jun 2021, 00:31 Walter Underwood, 
>> wrote:
>>
>>> Could someone else please take a look at SOLR-15056? This is a small
>>> blast radius change that improves the circuit breakers. It includes unit
>>> tests and documentation and has been ready since January.
>>>
>>> https://github.com/apache/solr/pull/96/files
>>> https://issues.apache.org/jira/browse/SOLR-15056
>>>
>>> wunder
>>> Walter Underwood
>>> wun...@wunderwood.org
>>> http://observer.wunderwood.org/  (my blog)
>>>
>>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova <
>>> mayya.sharip...@elastic.co.INVALID> wrote:
>>>
>>> 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-03 Thread Cassandra Targett
It’s OK with me, but I’m not really in a position to understand the changes 
and/or test it. And while we have a branch, I’m not clear on when the first RC 
is planned, so Mayya should weigh in I think.

Cassandra
On Jun 3, 2021, 5:49 AM -0500, Jan Høydahl , wrote:
> Mayya, Cassandra, I'd like to merge the Jetty upgrade, SOLR-15316 to 
> branch_8x and branch_8_9. See backport PR 
> https://github.com/apache/lucene-solr/pull/2502
> Is that ok?
>
> Jan
>
> > 2. jun. 2021 kl. 01:00 skrev Jan Høydahl :
> >
> > Cassandra,
> >
> > Thanks for spotting the Jetty JIRA (SOLR-15316). I put up a quck PR for 
> > upgrading Jetty to 9.4.41.v20210516. Currently running all tests.
> > Due to the CVEs I think there should not be a new Solr release without this 
> > upgrade. I set fixVersion to 8.9 and kept the blocker. If anyone disagrees, 
> > speak out.
> >
> > There's always a risk of a new Jetty version introducing new bugs, but this 
> > is a minor version upgrade with (almost) exclusively bug fixes since 
> > 9.4.36, so I'm willing to take the risk if tests look good. Perhaps Jenkins 
> > gets a few test spins on main before the 8.9 release too. Whyt Mayya?
> >
> > Jan
> >
> > > 1. jun. 2021 kl. 23:04 skrev Cassandra Targett :
> > >
> > > I got a question this morning about some Jetty CVEs that look to be fixed 
> > > with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no 
> > > version) to upgrade to that version. Is there time to do that for 8.9? Or 
> > > is it too high risk or would take too long? 
> > > https://issues.apache.org/jira/browse/SOLR-15316
> > >
> > > Sorry, I’m way behind on mailing lists and didn’t see the branch had been 
> > > cut already!
> > >
> > > Cassandra
> > > On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl , wrote:
> > > > Let's not hold up the release due to this incomplete PR. It obviously 
> > > > needs more time for completion and there is always a new train to catch.
> > > > As far as I understand, Circuit breakers are pluggable, so anyone can 
> > > > configure their own implementation in the meantime?
> > > >
> > > > Jan
> > > >
> > > > > 1. jun. 2021 kl. 22:13 skrev Atri Sharma :
> > > > >
> > > > > I appreciate you fixing this and adding the new circuit breaker and 
> > > > > look forward to having it in the hands of our users soon.
> > > > >
> > > > > However, the current state of PR, with significant API churn for a 
> > > > > single change and overlapping code is not yet ready.
> > > > >
> > > > > If this is too much of a rework, I am happy to take the existing PR 
> > > > > and do the changes, post which I believe the PR should be close to 
> > > > > completion.
> > > > >
> > > > > Let me know if you need me to help, but unfortunately, the two 
> > > > > objections I raised are blockers, atleast until we establish that 
> > > > > they cannot be done away with.
> > > > >
> > > > >
> > > > > > On Wed, 2 Jun 2021, 01:37 Walter Underwood,  
> > > > > > wrote:
> > > > > > > I would appreciate a second opinion on the pull request. 
> > > > > > > Substantive issues have been resolved. At this point, the 
> > > > > > > discussion is about code style and coding standards. I don’t have 
> > > > > > > detailed knowledge about the Solr coding style, so I’d appreciate 
> > > > > > > another set of eyes.
> > > > > > >
> > > > > > > The current behavior is buggy, and we are not able to use it at 
> > > > > > > Chegg. The patch fixes those bugs.
> > > > > > >
> > > > > > > https://github.com/apache/solr/pull/96
> > > > > > >
> > > > > > > wunder
> > > > > > > Walter Underwood
> > > > > > > wun...@wunderwood.org
> > > > > > > http://observer.wunderwood.org/  (my blog)
> > > > > > >
> > > > > > > > On Jun 1, 2021, at 12:27 PM, Walter Underwood 
> > > > > > > >  wrote:
> > > > > > > >
> > > > > > > > I answered the comments. I don’t see those answers on github, 
> > > > > > > > oddly.
> > > > > > > >
> > > > > > > > I’ll re-answer them. Most of your questions are already 
> > > > > > > > answered in the discussion on Jira.
> > > > > > > >
> > > > > > > > I central issues is that load average is not always a CPU 
> > > > > > > > measure. In some systems, it includes threads in iowait. So it 
> > > > > > > > is potentially misleading to label it as CPU and document it as 
> > > > > > > > CPU. The updated documentation makes that clear, so that should 
> > > > > > > > have already answered your comment. that is why it is important 
> > > > > > > > to rename the existing circuit breaker.
> > > > > > > >
> > > > > > > > wunder
> > > > > > > > Walter Underwood
> > > > > > > > wun...@wunderwood.org
> > > > > > > > http://observer.wunderwood.org/  (my blog)
> > > > > > > >
> > > > > > > > > On Jun 1, 2021, at 12:20 PM, Atri Sharma  
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > I tool a look at the PR and gave comments for SOLR-15056, and 
> > > > > > > > > the last I checked, my comments were not addressed?
> > > > > > > > >
> > > > > > > > > > On Wed, 2 Jun 2021, 00:31 Walter 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-03 Thread Jan Høydahl
Mayya, Cassandra, I'd like to merge the Jetty upgrade, SOLR-15316 to branch_8x 
and branch_8_9. See backport PR https://github.com/apache/lucene-solr/pull/2502
Is that ok?

Jan

> 2. jun. 2021 kl. 01:00 skrev Jan Høydahl :
> 
> Cassandra,
> 
> Thanks for spotting the Jetty JIRA (SOLR-15316 
> ). I put up a quck PR 
>  for upgrading Jetty to 
> 9.4.41.v20210516. Currently running all tests.
> Due to the CVEs I think there should not be a new Solr release without this 
> upgrade. I set fixVersion to 8.9 and kept the blocker. If anyone disagrees, 
> speak out.
> 
> There's always a risk of a new Jetty version introducing new bugs, but this 
> is a minor version upgrade with (almost) exclusively bug fixes since 9.4.36, 
> so I'm willing to take the risk if tests look good. Perhaps Jenkins gets a 
> few test spins on main before the 8.9 release too. Whyt Mayya?
> 
> Jan
> 
>> 1. jun. 2021 kl. 23:04 skrev Cassandra Targett > >:
>> 
>> I got a question this morning about some Jetty CVEs that look to be fixed 
>> with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no 
>> version) to upgrade to that version. Is there time to do that for 8.9? Or is 
>> it too high risk or would take too long? 
>> https://issues.apache.org/jira/browse/SOLR-15316 
>> 
>> 
>> Sorry, I’m way behind on mailing lists and didn’t see the branch had been 
>> cut already!
>> 
>> Cassandra
>> On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl > >, wrote:
>>> Let's not hold up the release due to this incomplete PR. It obviously needs 
>>> more time for completion and there is always a new train to catch.
>>> As far as I understand, Circuit breakers are pluggable, so anyone can 
>>> configure their own implementation in the meantime?
>>> 
>>> Jan
>>> 
 1. jun. 2021 kl. 22:13 skrev Atri Sharma >>> >:
 
 I appreciate you fixing this and adding the new circuit breaker and look 
 forward to having it in the hands of our users soon.
 
 However, the current state of PR, with significant API churn for a single 
 change and overlapping code is not yet ready.
 
 If this is too much of a rework, I am happy to take the existing PR and do 
 the changes, post which I believe the PR should be close to completion. 
 
 Let me know if you need me to help, but unfortunately, the two objections 
 I raised are blockers, atleast until we establish that they cannot be done 
 away with. 
 
 
 On Wed, 2 Jun 2021, 01:37 Walter Underwood, >>> > wrote:
 I would appreciate a second opinion on the pull request. Substantive 
 issues have been resolved. At this point, the discussion is about code 
 style and coding standards. I don’t have detailed knowledge about the Solr 
 coding style, so I’d appreciate another set of eyes.
 
 The current behavior is buggy, and we are not able to use it at Chegg. The 
 patch fixes those bugs.
 
 https://github.com/apache/solr/pull/96 
 
 
 wunder
 Walter Underwood
 wun...@wunderwood.org 
 http://observer.wunderwood.org/   (my 
 blog)
 
> On Jun 1, 2021, at 12:27 PM, Walter Underwood  > wrote:
> 
> I answered the comments. I don’t see those answers on github, oddly.
> 
> I’ll re-answer them. Most of your questions are already answered in the 
> discussion on Jira.
> 
> I central issues is that load average is not always a CPU measure. In 
> some systems, it includes threads in iowait. So it is potentially 
> misleading to label it as CPU and document it as CPU. The updated 
> documentation makes that clear, so that should have already answered your 
> comment. that is why it is important to rename the existing circuit 
> breaker.
> 
> wunder
> Walter Underwood
> wun...@wunderwood.org 
> http://observer.wunderwood.org/   (my 
> blog)
> 
>> On Jun 1, 2021, at 12:20 PM, Atri Sharma > > wrote:
>> 
>> I tool a look at the PR and gave comments for SOLR-15056, and the last I 
>> checked, my comments were not addressed?
>> 
>> On Wed, 2 Jun 2021, 00:31 Walter Underwood, > > wrote:
>> Could someone else please take a look at SOLR-15056? This is a small 
>> blast radius change that improves the circuit breakers. It includes unit 
>> tests and documentation and has been ready since January.
>> 
>> https://github.com/apache/solr/pull/96/files 
>> 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread 戴晓彬
I think jetty 9.4.40.v20210413 wouldbe better,because I found 
https://github.com/eclipse/jetty.project/issues/6121 may result a search 
response error.


-- Original --
From: Cassandra Targett https://issues.apache.org/jira/browse/SOLR-15316
 
 Sorry, I’m way behind on mailing lists and didn’t see the branch had been cut 
already!
 
 
 Cassandra
 
 On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl https://github.com/apache/solr/pull/96
 
  wunder
 Walter Underwood
 wun...@wunderwood.org
 http://observer.wunderwood.org/;(myblog)
 
 
  On Jun 1, 2021, at 12:27 PM, Walter Underwood http://observer.wunderwood.org/;(myblog)
 
 
  On Jun 1, 2021, at 12:20 PM, Atri Sharma https://github.com/apache/solr/pull/96/files
 https://issues.apache.org/jira/browse/SOLR-15056
 
  wunder
 Walter Underwood
 wun...@wunderwood.org
 http://observer.wunderwood.org/;(myblog)
 
 
  On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
http://www.linkedin.com/in/davidwsmiley
 
 
 
 

 
 
  On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova 
https://issues.apache.org/jira/browse/SOLR-15378 should 
be investigated before 8.9, maybe make it a blocker?
 
  On Thu, May 13, 2021 at 1:35 AM Robert Muir https://github.com/apache/lucene-solr/pull/2495
 
  Personally, I felt that merging non-trivial changes from main 
branch
  to 8.x has some additional risks when cherry-picking:
  * structural changes in main branch making merging more 
difficult
  (e.g. LUCENE-9705 reorganization of codec versioning, great 
change
  moving forwards though)
  * there are many style changes due to spotless in main branch 
which
  add noise to merging against old code.
  * In the specific case of LUCENE-9827, the usual additional 
tricky
  backwards compatibility for 8.x must be added in the backport 
(due to
  minor version bumps there) which can go wrong.
 
  I still think that particular change is worth considering for 
8.9, it
  isn't just a performance bug but also a huge improvement to 
test
  coverage that helps combat risks.
 
  But we should still take some precautions when releasing an 
8.x IMO:
  * be mindful of what we are backporting and the risks 
involved: it is harder.
  * try to let jenkins bake changes in 8.x branches for longer 
than
  usual? even a few days really helps.
 
  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
  https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x. I've 
recently completed the back port of 2/3 of the lucene tickets that are related, 
and hope to work on the third tomorrow
  
   I had some feedback there, but I think folks were 
waiting for the version integrated with the final form of the Lucene tickets 
before delving further. Hopefully this week I can start on a patch that does 
that.
  
   On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
http://www.needhamsoftware.com (work)
   http://www.the111shift.com (play)
 
  
-
  To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
  For additional commands, e-mail: dev-h...@lucene.apache.org
 
 
 
  --
  http://www.needhamsoftware.com (work)
  http://www.the111shift.com (play)
 
 
 
 --
 -
 Noble Paul
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
 For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Jan Høydahl
Cassandra,

Thanks for spotting the Jetty JIRA (SOLR-15316 
). I put up a quck PR 
 for upgrading Jetty to 
9.4.41.v20210516. Currently running all tests.
Due to the CVEs I think there should not be a new Solr release without this 
upgrade. I set fixVersion to 8.9 and kept the blocker. If anyone disagrees, 
speak out.

There's always a risk of a new Jetty version introducing new bugs, but this is 
a minor version upgrade with (almost) exclusively bug fixes since 9.4.36, so 
I'm willing to take the risk if tests look good. Perhaps Jenkins gets a few 
test spins on main before the 8.9 release too. Whyt Mayya?

Jan

> 1. jun. 2021 kl. 23:04 skrev Cassandra Targett :
> 
> I got a question this morning about some Jetty CVEs that look to be fixed 
> with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no version) 
> to upgrade to that version. Is there time to do that for 8.9? Or is it too 
> high risk or would take too long? 
> https://issues.apache.org/jira/browse/SOLR-15316 
> 
> 
> Sorry, I’m way behind on mailing lists and didn’t see the branch had been cut 
> already!
> 
> Cassandra
> On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl , wrote:
>> Let's not hold up the release due to this incomplete PR. It obviously needs 
>> more time for completion and there is always a new train to catch.
>> As far as I understand, Circuit breakers are pluggable, so anyone can 
>> configure their own implementation in the meantime?
>> 
>> Jan
>> 
>>> 1. jun. 2021 kl. 22:13 skrev Atri Sharma >> >:
>>> 
>>> I appreciate you fixing this and adding the new circuit breaker and look 
>>> forward to having it in the hands of our users soon.
>>> 
>>> However, the current state of PR, with significant API churn for a single 
>>> change and overlapping code is not yet ready.
>>> 
>>> If this is too much of a rework, I am happy to take the existing PR and do 
>>> the changes, post which I believe the PR should be close to completion. 
>>> 
>>> Let me know if you need me to help, but unfortunately, the two objections I 
>>> raised are blockers, atleast until we establish that they cannot be done 
>>> away with. 
>>> 
>>> 
>>> On Wed, 2 Jun 2021, 01:37 Walter Underwood, >> > wrote:
>>> I would appreciate a second opinion on the pull request. Substantive issues 
>>> have been resolved. At this point, the discussion is about code style and 
>>> coding standards. I don’t have detailed knowledge about the Solr coding 
>>> style, so I’d appreciate another set of eyes.
>>> 
>>> The current behavior is buggy, and we are not able to use it at Chegg. The 
>>> patch fixes those bugs.
>>> 
>>> https://github.com/apache/solr/pull/96 
>>> 
>>> 
>>> wunder
>>> Walter Underwood
>>> wun...@wunderwood.org 
>>> http://observer.wunderwood.org/   (my blog)
>>> 
 On Jun 1, 2021, at 12:27 PM, Walter Underwood >>> > wrote:
 
 I answered the comments. I don’t see those answers on github, oddly.
 
 I’ll re-answer them. Most of your questions are already answered in the 
 discussion on Jira.
 
 I central issues is that load average is not always a CPU measure. In some 
 systems, it includes threads in iowait. So it is potentially misleading to 
 label it as CPU and document it as CPU. The updated documentation makes 
 that clear, so that should have already answered your comment. that is why 
 it is important to rename the existing circuit breaker.
 
 wunder
 Walter Underwood
 wun...@wunderwood.org 
 http://observer.wunderwood.org/   (my 
 blog)
 
> On Jun 1, 2021, at 12:20 PM, Atri Sharma  > wrote:
> 
> I tool a look at the PR and gave comments for SOLR-15056, and the last I 
> checked, my comments were not addressed?
> 
> On Wed, 2 Jun 2021, 00:31 Walter Underwood,  > wrote:
> Could someone else please take a look at SOLR-15056? This is a small 
> blast radius change that improves the circuit breakers. It includes unit 
> tests and documentation and has been ready since January.
> 
> https://github.com/apache/solr/pull/96/files 
> 
> https://issues.apache.org/jira/browse/SOLR-15056 
> 
> 
> wunder
> Walter Underwood
> wun...@wunderwood.org 
> http://observer.wunderwood.org/   (my 
> blog)
> 
>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
>> > 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Walter Underwood
This is really frustrating. We have a feature that never should have been 
committed. The behavior and documentation don’t match and the inputs are 
limited to values that make it unusable. The documentation contains a 
nonfunctional link.

I contribute a patch that implements both the original behavior and the 
documented behavior, with unit tests and detailed documentation.

What else am I supposed to do? This seems like we’ve lost the spirit of Yonik’s 
Law of Patches and perfection has become the enemy of progress.

wunder
Walter Underwood
wun...@wunderwood.org
http://observer.wunderwood.org/  (my blog)

> On Jun 1, 2021, at 2:01 PM, David Smiley  wrote:
> 
> +1 to Jan's comment; no need to hold up the release.
> 
> I also think we should be open to more releases in the future for 8.x.
> 
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley 
> 
> 
> On Tue, Jun 1, 2021 at 4:55 PM Jan Høydahl  > wrote:
> Let's not hold up the release due to this incomplete PR. It obviously needs 
> more time for completion and there is always a new train to catch.
> As far as I understand, Circuit breakers are pluggable, so anyone can 
> configure their own implementation in the meantime?
> 
> Jan
> 
>> 1. jun. 2021 kl. 22:13 skrev Atri Sharma > >:
>> 
>> I appreciate you fixing this and adding the new circuit breaker and look 
>> forward to having it in the hands of our users soon.
>> 
>> However, the current state of PR, with significant API churn for a single 
>> change and overlapping code is not yet ready.
>> 
>> If this is too much of a rework, I am happy to take the existing PR and do 
>> the changes, post which I believe the PR should be close to completion. 
>> 
>> Let me know if you need me to help, but unfortunately, the two objections I 
>> raised are blockers, atleast until we establish that they cannot be done 
>> away with. 
>> 
>> 
>> On Wed, 2 Jun 2021, 01:37 Walter Underwood, > > wrote:
>> I would appreciate a second opinion on the pull request. Substantive issues 
>> have been resolved. At this point, the discussion is about code style and 
>> coding standards. I don’t have detailed knowledge about the Solr coding 
>> style, so I’d appreciate another set of eyes.
>> 
>> The current behavior is buggy, and we are not able to use it at Chegg. The 
>> patch fixes those bugs.
>> 
>> https://github.com/apache/solr/pull/96 
>> 
>> 
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org 
>> http://observer.wunderwood.org/   (my blog)
>> 
>>> On Jun 1, 2021, at 12:27 PM, Walter Underwood >> > wrote:
>>> 
>>> I answered the comments. I don’t see those answers on github, oddly.
>>> 
>>> I’ll re-answer them. Most of your questions are already answered in the 
>>> discussion on Jira.
>>> 
>>> I central issues is that load average is not always a CPU measure. In some 
>>> systems, it includes threads in iowait. So it is potentially misleading to 
>>> label it as CPU and document it as CPU. The updated documentation makes 
>>> that clear, so that should have already answered your comment. that is why 
>>> it is important to rename the existing circuit breaker.
>>> 
>>> wunder
>>> Walter Underwood
>>> wun...@wunderwood.org 
>>> http://observer.wunderwood.org/   (my blog)
>>> 
 On Jun 1, 2021, at 12:20 PM, Atri Sharma >>> > wrote:
 
 I tool a look at the PR and gave comments for SOLR-15056, and the last I 
 checked, my comments were not addressed?
 
 On Wed, 2 Jun 2021, 00:31 Walter Underwood, >>> > wrote:
 Could someone else please take a look at SOLR-15056? This is a small blast 
 radius change that improves the circuit breakers. It includes unit tests 
 and documentation and has been ready since January.
 
 https://github.com/apache/solr/pull/96/files 
 
 https://issues.apache.org/jira/browse/SOLR-15056 
 
 
 wunder
 Walter Underwood
 wun...@wunderwood.org 
 http://observer.wunderwood.org/   (my 
 blog)
 
> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
>  > wrote:
> 
> Thank you for the update, Houston.
> 
> I've started the release process, the branch 8.9 is now cut.
> 
> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman  > wrote:
> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
> 
> - Houston
> 
> On Thu, May 27, 2021 at 11:42 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Cassandra Targett
I got a question this morning about some Jetty CVEs that look to be fixed with 
Jetty 9.4.39, and there’s an issue marked as a Blocker (with no version) to 
upgrade to that version. Is there time to do that for 8.9? Or is it too high 
risk or would take too long? https://issues.apache.org/jira/browse/SOLR-15316

Sorry, I’m way behind on mailing lists and didn’t see the branch had been cut 
already!

Cassandra
On Jun 1, 2021, 3:54 PM -0500, Jan Høydahl , wrote:
> Let's not hold up the release due to this incomplete PR. It obviously needs 
> more time for completion and there is always a new train to catch.
> As far as I understand, Circuit breakers are pluggable, so anyone can 
> configure their own implementation in the meantime?
>
> Jan
>
> > 1. jun. 2021 kl. 22:13 skrev Atri Sharma :
> >
> > I appreciate you fixing this and adding the new circuit breaker and look 
> > forward to having it in the hands of our users soon.
> >
> > However, the current state of PR, with significant API churn for a single 
> > change and overlapping code is not yet ready.
> >
> > If this is too much of a rework, I am happy to take the existing PR and do 
> > the changes, post which I believe the PR should be close to completion.
> >
> > Let me know if you need me to help, but unfortunately, the two objections I 
> > raised are blockers, atleast until we establish that they cannot be done 
> > away with.
> >
> >
> > > On Wed, 2 Jun 2021, 01:37 Walter Underwood,  wrote:
> > > > I would appreciate a second opinion on the pull request. Substantive 
> > > > issues have been resolved. At this point, the discussion is about code 
> > > > style and coding standards. I don’t have detailed knowledge about the 
> > > > Solr coding style, so I’d appreciate another set of eyes.
> > > >
> > > > The current behavior is buggy, and we are not able to use it at Chegg. 
> > > > The patch fixes those bugs.
> > > >
> > > > https://github.com/apache/solr/pull/96
> > > >
> > > > wunder
> > > > Walter Underwood
> > > > wun...@wunderwood.org
> > > > http://observer.wunderwood.org/  (my blog)
> > > >
> > > > > On Jun 1, 2021, at 12:27 PM, Walter Underwood  
> > > > > wrote:
> > > > >
> > > > > I answered the comments. I don’t see those answers on github, oddly.
> > > > >
> > > > > I’ll re-answer them. Most of your questions are already answered in 
> > > > > the discussion on Jira.
> > > > >
> > > > > I central issues is that load average is not always a CPU measure. In 
> > > > > some systems, it includes threads in iowait. So it is potentially 
> > > > > misleading to label it as CPU and document it as CPU. The updated 
> > > > > documentation makes that clear, so that should have already answered 
> > > > > your comment. that is why it is important to rename the existing 
> > > > > circuit breaker.
> > > > >
> > > > > wunder
> > > > > Walter Underwood
> > > > > wun...@wunderwood.org
> > > > > http://observer.wunderwood.org/  (my blog)
> > > > >
> > > > > > On Jun 1, 2021, at 12:20 PM, Atri Sharma  wrote:
> > > > > >
> > > > > > I tool a look at the PR and gave comments for SOLR-15056, and the 
> > > > > > last I checked, my comments were not addressed?
> > > > > >
> > > > > > > On Wed, 2 Jun 2021, 00:31 Walter Underwood, 
> > > > > > >  wrote:
> > > > > > > > Could someone else please take a look at SOLR-15056? This is a 
> > > > > > > > small blast radius change that improves the circuit breakers. 
> > > > > > > > It includes unit tests and documentation and has been ready 
> > > > > > > > since January.
> > > > > > > >
> > > > > > > > https://github.com/apache/solr/pull/96/files
> > > > > > > > https://issues.apache.org/jira/browse/SOLR-15056
> > > > > > > >
> > > > > > > > wunder
> > > > > > > > Walter Underwood
> > > > > > > > wun...@wunderwood.org
> > > > > > > > http://observer.wunderwood.org/  (my blog)
> > > > > > > >
> > > > > > > > > On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
> > > > > > > > >  wrote:
> > > > > > > > >
> > > > > > > > > Thank you for the update, Houston.
> > > > > > > > >
> > > > > > > > > I've started the release process, the branch 8.9 is now cut.
> > > > > > > > >
> > > > > > > > > > On Tue, Jun 1, 2021 at 11:21 AM Houston Putman 
> > > > > > > > > >  wrote:
> > > > > > > > > > > Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
> > > > > > > > > > >
> > > > > > > > > > > - Houston
> > > > > > > > > > >
> > > > > > > > > > > > On Thu, May 27, 2021 at 11:42 PM David Smiley 
> > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > SOLR-15412 is rather serious as the title suggests.  
> > > > > > > > > > > > > I haven't been tracking the progress so if it's 
> > > > > > > > > > > > > already resolved, that's unknown to me and isn't 
> > > > > > > > > > > > > reflected in JIRA.
> > > > > > > > > > > > >
> > > > > > > > > > > > > ~ David Smiley
> > > > > > > > > > > > > Apache Lucene/Solr Search Developer
> > > > > > > > > > > > > http://www.linkedin.com/in/davidwsmiley
> > > > > > > > > > > > >
> > > > > > > > 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread David Smiley
+1 to Jan's comment; no need to hold up the release.

I also think we should be open to more releases in the future for 8.x.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley


On Tue, Jun 1, 2021 at 4:55 PM Jan Høydahl  wrote:

> Let's not hold up the release due to this incomplete PR. It obviously
> needs more time for completion and there is always a new train to catch.
> As far as I understand, Circuit breakers are pluggable, so anyone can
> configure their own implementation in the meantime?
>
> Jan
>
> 1. jun. 2021 kl. 22:13 skrev Atri Sharma :
>
> I appreciate you fixing this and adding the new circuit breaker and look
> forward to having it in the hands of our users soon.
>
> However, the current state of PR, with significant API churn for a single
> change and overlapping code is not yet ready.
>
> If this is too much of a rework, I am happy to take the existing PR and do
> the changes, post which I believe the PR should be close to completion.
>
> Let me know if you need me to help, but unfortunately, the two objections
> I raised are blockers, atleast until we establish that they cannot be done
> away with.
>
>
> On Wed, 2 Jun 2021, 01:37 Walter Underwood,  wrote:
>
>> I would appreciate a second opinion on the pull request. Substantive
>> issues have been resolved. At this point, the discussion is about code
>> style and coding standards. I don’t have detailed knowledge about the Solr
>> coding style, so I’d appreciate another set of eyes.
>>
>> The current behavior is buggy, and we are not able to use it at Chegg.
>> The patch fixes those bugs.
>>
>> https://github.com/apache/solr/pull/96
>>
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org
>> http://observer.wunderwood.org/  (my blog)
>>
>> On Jun 1, 2021, at 12:27 PM, Walter Underwood 
>> wrote:
>>
>> I answered the comments. I don’t see those answers on github, oddly.
>>
>> I’ll re-answer them. Most of your questions are already answered in the
>> discussion on Jira.
>>
>> I central issues is that load average is not always a CPU measure. In
>> some systems, it includes threads in iowait. So it is potentially
>> misleading to label it as CPU and document it as CPU. The updated
>> documentation makes that clear, so that should have already answered your
>> comment. that is why it is important to rename the existing circuit breaker.
>>
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org
>> http://observer.wunderwood.org/  (my blog)
>>
>> On Jun 1, 2021, at 12:20 PM, Atri Sharma  wrote:
>>
>> I tool a look at the PR and gave comments for SOLR-15056, and the last I
>> checked, my comments were not addressed?
>>
>> On Wed, 2 Jun 2021, 00:31 Walter Underwood, 
>> wrote:
>>
>>> Could someone else please take a look at SOLR-15056? This is a small
>>> blast radius change that improves the circuit breakers. It includes unit
>>> tests and documentation and has been ready since January.
>>>
>>> https://github.com/apache/solr/pull/96/files
>>> https://issues.apache.org/jira/browse/SOLR-15056
>>>
>>> wunder
>>> Walter Underwood
>>> wun...@wunderwood.org
>>> http://observer.wunderwood.org/  (my blog)
>>>
>>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova <
>>> mayya.sharip...@elastic.co.INVALID> wrote:
>>>
>>> Thank you for the update, Houston.
>>>
>>> I've started the release process, the branch 8.9 is now cut.
>>>
>>> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman 
>>> wrote:
>>>
 Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.

 - Houston

 On Thu, May 27, 2021 at 11:42 PM David Smiley 
 wrote:

> SOLR-15412 is rather serious as the title suggests.  I haven't been
> tracking the progress so if it's already resolved, that's unknown to me 
> and
> isn't reflected in JIRA.
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>
>
> On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova <
> mayya.sharip...@elastic.co.invalid> wrote:
>
>> Hello everyone,
>> I wonder if everyone is ok for May 31st (Monday) as the date for the
>> feature freeze date and branch cut?
>> I've noticed that `releaseWizard.py` is also asking for the length of
>> feature freeze. What is the custom length to put there?
>>
>> Looks like Lucene
>> 
>> doesn't have any unresolved issues for 8.9.
>> SOLR 
>>  has:
>> -  SOLR-15412  Strict validation on Replica metadata can cause
>> complete outage  (Looks like it may be resolved already?)
>> - SOLR-15410 GC log is directed to console when starting Solr with
>> Java 11 Open J9 on Windows
>> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not
>> Unix load average
>>
>> Are we ok to postpone these issues to later releases if they are not
>> 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Jan Høydahl
Let's not hold up the release due to this incomplete PR. It obviously needs 
more time for completion and there is always a new train to catch.
As far as I understand, Circuit breakers are pluggable, so anyone can configure 
their own implementation in the meantime?

Jan

> 1. jun. 2021 kl. 22:13 skrev Atri Sharma :
> 
> I appreciate you fixing this and adding the new circuit breaker and look 
> forward to having it in the hands of our users soon.
> 
> However, the current state of PR, with significant API churn for a single 
> change and overlapping code is not yet ready.
> 
> If this is too much of a rework, I am happy to take the existing PR and do 
> the changes, post which I believe the PR should be close to completion. 
> 
> Let me know if you need me to help, but unfortunately, the two objections I 
> raised are blockers, atleast until we establish that they cannot be done away 
> with. 
> 
> 
> On Wed, 2 Jun 2021, 01:37 Walter Underwood,  > wrote:
> I would appreciate a second opinion on the pull request. Substantive issues 
> have been resolved. At this point, the discussion is about code style and 
> coding standards. I don’t have detailed knowledge about the Solr coding 
> style, so I’d appreciate another set of eyes.
> 
> The current behavior is buggy, and we are not able to use it at Chegg. The 
> patch fixes those bugs.
> 
> https://github.com/apache/solr/pull/96 
> 
> 
> wunder
> Walter Underwood
> wun...@wunderwood.org 
> http://observer.wunderwood.org/   (my blog)
> 
>> On Jun 1, 2021, at 12:27 PM, Walter Underwood > > wrote:
>> 
>> I answered the comments. I don’t see those answers on github, oddly.
>> 
>> I’ll re-answer them. Most of your questions are already answered in the 
>> discussion on Jira.
>> 
>> I central issues is that load average is not always a CPU measure. In some 
>> systems, it includes threads in iowait. So it is potentially misleading to 
>> label it as CPU and document it as CPU. The updated documentation makes that 
>> clear, so that should have already answered your comment. that is why it is 
>> important to rename the existing circuit breaker.
>> 
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org 
>> http://observer.wunderwood.org/   (my blog)
>> 
>>> On Jun 1, 2021, at 12:20 PM, Atri Sharma >> > wrote:
>>> 
>>> I tool a look at the PR and gave comments for SOLR-15056, and the last I 
>>> checked, my comments were not addressed?
>>> 
>>> On Wed, 2 Jun 2021, 00:31 Walter Underwood, >> > wrote:
>>> Could someone else please take a look at SOLR-15056? This is a small blast 
>>> radius change that improves the circuit breakers. It includes unit tests 
>>> and documentation and has been ready since January.
>>> 
>>> https://github.com/apache/solr/pull/96/files 
>>> 
>>> https://issues.apache.org/jira/browse/SOLR-15056 
>>> 
>>> 
>>> wunder
>>> Walter Underwood
>>> wun...@wunderwood.org 
>>> http://observer.wunderwood.org/   (my blog)
>>> 
 On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
 >>> > wrote:
 
 Thank you for the update, Houston.
 
 I've started the release process, the branch 8.9 is now cut.
 
 On Tue, Jun 1, 2021 at 11:21 AM Houston Putman >>> > wrote:
 Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
 
 - Houston
 
 On Thu, May 27, 2021 at 11:42 PM David Smiley >>> > wrote:
 SOLR-15412 is rather serious as the title suggests.  I haven't been 
 tracking the progress so if it's already resolved, that's unknown to me 
 and isn't reflected in JIRA.
 
 ~ David Smiley
 Apache Lucene/Solr Search Developer
 http://www.linkedin.com/in/davidwsmiley 
 
 
 On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova 
 >>> > wrote:
 Hello everyone,
 I wonder if everyone is ok for May 31st (Monday) as the date for the 
 feature freeze date and branch cut?
 I've noticed that `releaseWizard.py` is also asking for the length of 
 feature freeze. What is the custom length to put there?
 
 Looks like Lucene 
  doesn't 
 have any unresolved issues for 8.9.
 SOLR  has:
 -  SOLR-15412  Strict validation on Replica metadata can cause complete 
 outage  (Looks like it may be resolved already?)
 - 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Atri Sharma
I appreciate you fixing this and adding the new circuit breaker and look
forward to having it in the hands of our users soon.

However, the current state of PR, with significant API churn for a single
change and overlapping code is not yet ready.

If this is too much of a rework, I am happy to take the existing PR and do
the changes, post which I believe the PR should be close to completion.

Let me know if you need me to help, but unfortunately, the two objections I
raised are blockers, atleast until we establish that they cannot be done
away with.


On Wed, 2 Jun 2021, 01:37 Walter Underwood,  wrote:

> I would appreciate a second opinion on the pull request. Substantive
> issues have been resolved. At this point, the discussion is about code
> style and coding standards. I don’t have detailed knowledge about the Solr
> coding style, so I’d appreciate another set of eyes.
>
> The current behavior is buggy, and we are not able to use it at Chegg. The
> patch fixes those bugs.
>
> https://github.com/apache/solr/pull/96
>
> wunder
> Walter Underwood
> wun...@wunderwood.org
> http://observer.wunderwood.org/  (my blog)
>
> On Jun 1, 2021, at 12:27 PM, Walter Underwood 
> wrote:
>
> I answered the comments. I don’t see those answers on github, oddly.
>
> I’ll re-answer them. Most of your questions are already answered in the
> discussion on Jira.
>
> I central issues is that load average is not always a CPU measure. In some
> systems, it includes threads in iowait. So it is potentially misleading to
> label it as CPU and document it as CPU. The updated documentation makes
> that clear, so that should have already answered your comment. that is why
> it is important to rename the existing circuit breaker.
>
> wunder
> Walter Underwood
> wun...@wunderwood.org
> http://observer.wunderwood.org/  (my blog)
>
> On Jun 1, 2021, at 12:20 PM, Atri Sharma  wrote:
>
> I tool a look at the PR and gave comments for SOLR-15056, and the last I
> checked, my comments were not addressed?
>
> On Wed, 2 Jun 2021, 00:31 Walter Underwood,  wrote:
>
>> Could someone else please take a look at SOLR-15056? This is a small
>> blast radius change that improves the circuit breakers. It includes unit
>> tests and documentation and has been ready since January.
>>
>> https://github.com/apache/solr/pull/96/files
>> https://issues.apache.org/jira/browse/SOLR-15056
>>
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org
>> http://observer.wunderwood.org/  (my blog)
>>
>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova <
>> mayya.sharip...@elastic.co.INVALID> wrote:
>>
>> Thank you for the update, Houston.
>>
>> I've started the release process, the branch 8.9 is now cut.
>>
>> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman 
>> wrote:
>>
>>> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
>>>
>>> - Houston
>>>
>>> On Thu, May 27, 2021 at 11:42 PM David Smiley 
>>> wrote:
>>>
 SOLR-15412 is rather serious as the title suggests.  I haven't been
 tracking the progress so if it's already resolved, that's unknown to me and
 isn't reflected in JIRA.

 ~ David Smiley
 Apache Lucene/Solr Search Developer
 http://www.linkedin.com/in/davidwsmiley


 On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova <
 mayya.sharip...@elastic.co.invalid> wrote:

> Hello everyone,
> I wonder if everyone is ok for May 31st (Monday) as the date for the
> feature freeze date and branch cut?
> I've noticed that `releaseWizard.py` is also asking for the length of
> feature freeze. What is the custom length to put there?
>
> Looks like Lucene
> 
> doesn't have any unresolved issues for 8.9.
> SOLR 
>  has:
> -  SOLR-15412  Strict validation on Replica metadata can cause
> complete outage  (Looks like it may be resolved already?)
> - SOLR-15410 GC log is directed to console when starting Solr with
> Java 11 Open J9 on Windows
> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not
> Unix load average
>
> Are we ok to postpone these issues to later releases if they are not
> resolved and merged before feature freeze?
>
> Thank you.
>
>
>
>
>
>
> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie <
> colvin.cowie@gmail.com> wrote:
>
>> Hello,
>> Eric was going to have a look at the PR.
>> But if it isn't done in time then I don't think it needs to block the
>> release
>>
>> Thanks
>>
>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova <
>> mayya.sharip...@elastic.co.invalid> wrote:
>>
>>> Hello Colvin,
>>> I am wondering if you still want to merge SOLR-15410 for the
>>> Lucene/Solr 8.9 release?
>>> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>>>
>>> Thank you.
>>>
>>> On 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Walter Underwood
I would appreciate a second opinion on the pull request. Substantive issues 
have been resolved. At this point, the discussion is about code style and 
coding standards. I don’t have detailed knowledge about the Solr coding style, 
so I’d appreciate another set of eyes.

The current behavior is buggy, and we are not able to use it at Chegg. The 
patch fixes those bugs.

https://github.com/apache/solr/pull/96

wunder
Walter Underwood
wun...@wunderwood.org
http://observer.wunderwood.org/  (my blog)

> On Jun 1, 2021, at 12:27 PM, Walter Underwood  wrote:
> 
> I answered the comments. I don’t see those answers on github, oddly.
> 
> I’ll re-answer them. Most of your questions are already answered in the 
> discussion on Jira.
> 
> I central issues is that load average is not always a CPU measure. In some 
> systems, it includes threads in iowait. So it is potentially misleading to 
> label it as CPU and document it as CPU. The updated documentation makes that 
> clear, so that should have already answered your comment. that is why it is 
> important to rename the existing circuit breaker.
> 
> wunder
> Walter Underwood
> wun...@wunderwood.org 
> http://observer.wunderwood.org/  (my blog)
> 
>> On Jun 1, 2021, at 12:20 PM, Atri Sharma > > wrote:
>> 
>> I tool a look at the PR and gave comments for SOLR-15056, and the last I 
>> checked, my comments were not addressed?
>> 
>> On Wed, 2 Jun 2021, 00:31 Walter Underwood, > > wrote:
>> Could someone else please take a look at SOLR-15056? This is a small blast 
>> radius change that improves the circuit breakers. It includes unit tests and 
>> documentation and has been ready since January.
>> 
>> https://github.com/apache/solr/pull/96/files 
>> 
>> https://issues.apache.org/jira/browse/SOLR-15056 
>> 
>> 
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org 
>> http://observer.wunderwood.org/   (my blog)
>> 
>>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
>>> >> > wrote:
>>> 
>>> Thank you for the update, Houston.
>>> 
>>> I've started the release process, the branch 8.9 is now cut.
>>> 
>>> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman >> > wrote:
>>> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
>>> 
>>> - Houston
>>> 
>>> On Thu, May 27, 2021 at 11:42 PM David Smiley >> > wrote:
>>> SOLR-15412 is rather serious as the title suggests.  I haven't been 
>>> tracking the progress so if it's already resolved, that's unknown to me and 
>>> isn't reflected in JIRA.
>>> 
>>> ~ David Smiley
>>> Apache Lucene/Solr Search Developer
>>> http://www.linkedin.com/in/davidwsmiley 
>>> 
>>> 
>>> On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova 
>>> >> > wrote:
>>> Hello everyone,
>>> I wonder if everyone is ok for May 31st (Monday) as the date for the 
>>> feature freeze date and branch cut?
>>> I've noticed that `releaseWizard.py` is also asking for the length of 
>>> feature freeze. What is the custom length to put there?
>>> 
>>> Looks like Lucene 
>>>  doesn't 
>>> have any unresolved issues for 8.9.
>>> SOLR  has:
>>> -  SOLR-15412  Strict validation on Replica metadata can cause complete 
>>> outage  (Looks like it may be resolved already?)
>>> - SOLR-15410 GC log is directed to console when starting Solr with Java 11 
>>> Open J9 on Windows
>>> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix 
>>> load average
>>> 
>>> Are we ok to postpone these issues to later releases if they are not 
>>> resolved and merged before feature freeze?
>>> 
>>> Thank you.
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie >> > wrote:
>>> Hello,
>>> Eric was going to have a look at the PR.
>>> But if it isn't done in time then I don't think it needs to block the 
>>> release
>>> 
>>> Thanks
>>> 
>>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova 
>>> >> > wrote:
>>> Hello Colvin,
>>> I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr 
>>> 8.9 release?  
>>> Should we have a deadline for feature freeze? Say May 30th (Sunday)? 
>>> 
>>> Thank you.
>>> 
>>> On Tue, May 18, 2021 at 8:49 AM Noble Paul >> > wrote:
>>> +1
>>> 
>>> 
>>> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie >> > wrote:
>>> >
>>> > Hello,
>>> >
>>> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging 
>>> > when using new versions of 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Atri Sharma
As I mentioned in the PR, my two main objections are:

1. Introduction of SolrCore to CircuitBreakerManager. It causes a
significant API churn and is not needed by any other circuit breaker.

2. Duplication of code -- there is a significant overlap between the code
for the two circuit breakers. Please abstract them to common classes and
define interfaces.

Naming is an auxiliary discussion that is not a blocker to this PR.


On Wed, 2 Jun 2021, 00:58 Walter Underwood,  wrote:

> I answered the comments. I don’t see those answers on github, oddly.
>
> I’ll re-answer them. Most of your questions are already answered in the
> discussion on Jira.
>
> I central issues is that load average is not always a CPU measure. In some
> systems, it includes threads in iowait. So it is potentially misleading to
> label it as CPU and document it as CPU. The updated documentation makes
> that clear, so that should have already answered your comment. that is why
> it is important to rename the existing circuit breaker.
>
> wunder
> Walter Underwood
> wun...@wunderwood.org
> http://observer.wunderwood.org/  (my blog)
>
> On Jun 1, 2021, at 12:20 PM, Atri Sharma  wrote:
>
> I tool a look at the PR and gave comments for SOLR-15056, and the last I
> checked, my comments were not addressed?
>
> On Wed, 2 Jun 2021, 00:31 Walter Underwood,  wrote:
>
>> Could someone else please take a look at SOLR-15056? This is a small
>> blast radius change that improves the circuit breakers. It includes unit
>> tests and documentation and has been ready since January.
>>
>> https://github.com/apache/solr/pull/96/files
>> https://issues.apache.org/jira/browse/SOLR-15056
>>
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org
>> http://observer.wunderwood.org/  (my blog)
>>
>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova <
>> mayya.sharip...@elastic.co.INVALID> wrote:
>>
>> Thank you for the update, Houston.
>>
>> I've started the release process, the branch 8.9 is now cut.
>>
>> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman 
>> wrote:
>>
>>> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
>>>
>>> - Houston
>>>
>>> On Thu, May 27, 2021 at 11:42 PM David Smiley 
>>> wrote:
>>>
 SOLR-15412 is rather serious as the title suggests.  I haven't been
 tracking the progress so if it's already resolved, that's unknown to me and
 isn't reflected in JIRA.

 ~ David Smiley
 Apache Lucene/Solr Search Developer
 http://www.linkedin.com/in/davidwsmiley


 On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova <
 mayya.sharip...@elastic.co.invalid> wrote:

> Hello everyone,
> I wonder if everyone is ok for May 31st (Monday) as the date for the
> feature freeze date and branch cut?
> I've noticed that `releaseWizard.py` is also asking for the length of
> feature freeze. What is the custom length to put there?
>
> Looks like Lucene
> 
> doesn't have any unresolved issues for 8.9.
> SOLR 
>  has:
> -  SOLR-15412  Strict validation on Replica metadata can cause
> complete outage  (Looks like it may be resolved already?)
> - SOLR-15410 GC log is directed to console when starting Solr with
> Java 11 Open J9 on Windows
> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not
> Unix load average
>
> Are we ok to postpone these issues to later releases if they are not
> resolved and merged before feature freeze?
>
> Thank you.
>
>
>
>
>
>
> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie <
> colvin.cowie@gmail.com> wrote:
>
>> Hello,
>> Eric was going to have a look at the PR.
>> But if it isn't done in time then I don't think it needs to block the
>> release
>>
>> Thanks
>>
>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova <
>> mayya.sharip...@elastic.co.invalid> wrote:
>>
>>> Hello Colvin,
>>> I am wondering if you still want to merge SOLR-15410 for the
>>> Lucene/Solr 8.9 release?
>>> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>>>
>>> Thank you.
>>>
>>> On Tue, May 18, 2021 at 8:49 AM Noble Paul 
>>> wrote:
>>>
 +1


 On Tue, May 18, 2021 at 9:30 PM Colvin Cowie <
 colvin.cowie@gmail.com> wrote:
 >
 > Hello,
 >
 > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
 logging when using new versions of OpenJ9. It's small, so if somebody 
 could
 have a look at it in time for 8.9 that would be great
 >
 > Thanks,
 > Colvin
 >
 > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
 > 
 wrote:
 >>
 >> Hi Mayya,
 >>
 >> I would like to backport LUCENE-9935, which 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Walter Underwood
I answered the comments. I don’t see those answers on github, oddly.

I’ll re-answer them. Most of your questions are already answered in the 
discussion on Jira.

I central issues is that load average is not always a CPU measure. In some 
systems, it includes threads in iowait. So it is potentially misleading to 
label it as CPU and document it as CPU. The updated documentation makes that 
clear, so that should have already answered your comment. that is why it is 
important to rename the existing circuit breaker.

wunder
Walter Underwood
wun...@wunderwood.org
http://observer.wunderwood.org/  (my blog)

> On Jun 1, 2021, at 12:20 PM, Atri Sharma  wrote:
> 
> I tool a look at the PR and gave comments for SOLR-15056, and the last I 
> checked, my comments were not addressed?
> 
> On Wed, 2 Jun 2021, 00:31 Walter Underwood,  > wrote:
> Could someone else please take a look at SOLR-15056? This is a small blast 
> radius change that improves the circuit breakers. It includes unit tests and 
> documentation and has been ready since January.
> 
> https://github.com/apache/solr/pull/96/files 
> 
> https://issues.apache.org/jira/browse/SOLR-15056 
> 
> 
> wunder
> Walter Underwood
> wun...@wunderwood.org 
> http://observer.wunderwood.org/   (my blog)
> 
>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
>> > > wrote:
>> 
>> Thank you for the update, Houston.
>> 
>> I've started the release process, the branch 8.9 is now cut.
>> 
>> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman > > wrote:
>> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
>> 
>> - Houston
>> 
>> On Thu, May 27, 2021 at 11:42 PM David Smiley > > wrote:
>> SOLR-15412 is rather serious as the title suggests.  I haven't been tracking 
>> the progress so if it's already resolved, that's unknown to me and isn't 
>> reflected in JIRA.
>> 
>> ~ David Smiley
>> Apache Lucene/Solr Search Developer
>> http://www.linkedin.com/in/davidwsmiley 
>> 
>> 
>> On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova 
>> > > wrote:
>> Hello everyone,
>> I wonder if everyone is ok for May 31st (Monday) as the date for the feature 
>> freeze date and branch cut?
>> I've noticed that `releaseWizard.py` is also asking for the length of 
>> feature freeze. What is the custom length to put there?
>> 
>> Looks like Lucene 
>>  doesn't 
>> have any unresolved issues for 8.9.
>> SOLR  has:
>> -  SOLR-15412  Strict validation on Replica metadata can cause complete 
>> outage  (Looks like it may be resolved already?)
>> - SOLR-15410 GC log is directed to console when starting Solr with Java 11 
>> Open J9 on Windows
>> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix 
>> load average
>> 
>> Are we ok to postpone these issues to later releases if they are not 
>> resolved and merged before feature freeze?
>> 
>> Thank you.
>> 
>> 
>> 
>> 
>> 
>> 
>> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie > > wrote:
>> Hello,
>> Eric was going to have a look at the PR.
>> But if it isn't done in time then I don't think it needs to block the release
>> 
>> Thanks
>> 
>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova 
>> > > wrote:
>> Hello Colvin,
>> I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr 8.9 
>> release?  
>> Should we have a deadline for feature freeze? Say May 30th (Sunday)? 
>> 
>> Thank you.
>> 
>> On Tue, May 18, 2021 at 8:49 AM Noble Paul > > wrote:
>> +1
>> 
>> 
>> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie > > wrote:
>> >
>> > Hello,
>> >
>> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging 
>> > when using new versions of OpenJ9. It's small, so if somebody could have a 
>> > look at it in time for 8.9 that would be great
>> >
>> > Thanks,
>> > Colvin
>> >
>> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen > > .invalid> wrote:
>> >>
>> >> Hi Mayya,
>> >>
>> >> I would like to backport LUCENE-9935, which enables bulk-merge for stored 
>> >> fields with index sort, to 8.x this weekend. The patch is ready, but we 
>> >> prefer to give CI some cycles before backporting. Please let me know if 
>> >> it's okay with the release plan.
>> >>
>> >> Thanks,
>> >> Nhat
>> >>
>> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck > >> > wrote:
>> >>>
>> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 
>> >>> 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Mayya Sharipova
Sorry, Walter, that I rushed to create a new branch.
Please let me know when your changes are merged to 8.x and 8.9 ( I guess
you need to backport to the new 8.9 branch as well),
and I will continue the release process from there.

On Tue, Jun 1, 2021 at 3:21 PM Atri Sharma  wrote:

> I tool a look at the PR and gave comments for SOLR-15056, and the last I
> checked, my comments were not addressed?
>
> On Wed, 2 Jun 2021, 00:31 Walter Underwood,  wrote:
>
>> Could someone else please take a look at SOLR-15056? This is a small
>> blast radius change that improves the circuit breakers. It includes unit
>> tests and documentation and has been ready since January.
>>
>> https://github.com/apache/solr/pull/96/files
>> https://issues.apache.org/jira/browse/SOLR-15056
>>
>> wunder
>> Walter Underwood
>> wun...@wunderwood.org
>> http://observer.wunderwood.org/  (my blog)
>>
>> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova <
>> mayya.sharip...@elastic.co.INVALID> wrote:
>>
>> Thank you for the update, Houston.
>>
>> I've started the release process, the branch 8.9 is now cut.
>>
>> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman 
>> wrote:
>>
>>> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
>>>
>>> - Houston
>>>
>>> On Thu, May 27, 2021 at 11:42 PM David Smiley 
>>> wrote:
>>>
 SOLR-15412 is rather serious as the title suggests.  I haven't been
 tracking the progress so if it's already resolved, that's unknown to me and
 isn't reflected in JIRA.

 ~ David Smiley
 Apache Lucene/Solr Search Developer
 http://www.linkedin.com/in/davidwsmiley


 On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova <
 mayya.sharip...@elastic.co.invalid> wrote:

> Hello everyone,
> I wonder if everyone is ok for May 31st (Monday) as the date for the
> feature freeze date and branch cut?
> I've noticed that `releaseWizard.py` is also asking for the length of
> feature freeze. What is the custom length to put there?
>
> Looks like Lucene
> 
> doesn't have any unresolved issues for 8.9.
> SOLR 
>  has:
> -  SOLR-15412  Strict validation on Replica metadata can cause
> complete outage  (Looks like it may be resolved already?)
> - SOLR-15410 GC log is directed to console when starting Solr with
> Java 11 Open J9 on Windows
> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not
> Unix load average
>
> Are we ok to postpone these issues to later releases if they are not
> resolved and merged before feature freeze?
>
> Thank you.
>
>
>
>
>
>
> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie <
> colvin.cowie@gmail.com> wrote:
>
>> Hello,
>> Eric was going to have a look at the PR.
>> But if it isn't done in time then I don't think it needs to block the
>> release
>>
>> Thanks
>>
>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova <
>> mayya.sharip...@elastic.co.invalid> wrote:
>>
>>> Hello Colvin,
>>> I am wondering if you still want to merge SOLR-15410 for the
>>> Lucene/Solr 8.9 release?
>>> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>>>
>>> Thank you.
>>>
>>> On Tue, May 18, 2021 at 8:49 AM Noble Paul 
>>> wrote:
>>>
 +1


 On Tue, May 18, 2021 at 9:30 PM Colvin Cowie <
 colvin.cowie@gmail.com> wrote:
 >
 > Hello,
 >
 > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
 logging when using new versions of OpenJ9. It's small, so if somebody 
 could
 have a look at it in time for 8.9 that would be great
 >
 > Thanks,
 > Colvin
 >
 > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
 > 
 wrote:
 >>
 >> Hi Mayya,
 >>
 >> I would like to backport LUCENE-9935, which enables bulk-merge
 for stored fields with index sort, to 8.x this weekend. The patch is 
 ready,
 but we prefer to give CI some cycles before backporting. Please let me 
 know
 if it's okay with the release plan.
 >>
 >> Thanks,
 >> Nhat
 >>
 >> On Thu, May 13, 2021 at 12:44 PM Gus Heck 
 wrote:
 >>>
 >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378
 should be investigated before 8.9, maybe make it a blocker?
 >>>
 >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir 
 wrote:
 
  Mayya, I created backport for Adrien's issue here, to try to
 help out:
  https://github.com/apache/lucene-solr/pull/2495
 
  Personally, I felt that merging non-trivial changes from main

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Atri Sharma
I tool a look at the PR and gave comments for SOLR-15056, and the last I
checked, my comments were not addressed?

On Wed, 2 Jun 2021, 00:31 Walter Underwood,  wrote:

> Could someone else please take a look at SOLR-15056? This is a small blast
> radius change that improves the circuit breakers. It includes unit tests
> and documentation and has been ready since January.
>
> https://github.com/apache/solr/pull/96/files
> https://issues.apache.org/jira/browse/SOLR-15056
>
> wunder
> Walter Underwood
> wun...@wunderwood.org
> http://observer.wunderwood.org/  (my blog)
>
> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova <
> mayya.sharip...@elastic.co.INVALID> wrote:
>
> Thank you for the update, Houston.
>
> I've started the release process, the branch 8.9 is now cut.
>
> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman  wrote:
>
>> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
>>
>> - Houston
>>
>> On Thu, May 27, 2021 at 11:42 PM David Smiley  wrote:
>>
>>> SOLR-15412 is rather serious as the title suggests.  I haven't been
>>> tracking the progress so if it's already resolved, that's unknown to me and
>>> isn't reflected in JIRA.
>>>
>>> ~ David Smiley
>>> Apache Lucene/Solr Search Developer
>>> http://www.linkedin.com/in/davidwsmiley
>>>
>>>
>>> On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova <
>>> mayya.sharip...@elastic.co.invalid> wrote:
>>>
 Hello everyone,
 I wonder if everyone is ok for May 31st (Monday) as the date for the
 feature freeze date and branch cut?
 I've noticed that `releaseWizard.py` is also asking for the length of
 feature freeze. What is the custom length to put there?

 Looks like Lucene
 
 doesn't have any unresolved issues for 8.9.
 SOLR 
  has:
 -  SOLR-15412  Strict validation on Replica metadata can cause complete
 outage  (Looks like it may be resolved already?)
 - SOLR-15410 GC log is directed to console when starting Solr with Java
 11 Open J9 on Windows
 - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not
 Unix load average

 Are we ok to postpone these issues to later releases if they are not
 resolved and merged before feature freeze?

 Thank you.






 On Tue, May 25, 2021 at 12:41 PM Colvin Cowie <
 colvin.cowie@gmail.com> wrote:

> Hello,
> Eric was going to have a look at the PR.
> But if it isn't done in time then I don't think it needs to block the
> release
>
> Thanks
>
> On Tue, 25 May 2021 at 15:50, Mayya Sharipova <
> mayya.sharip...@elastic.co.invalid> wrote:
>
>> Hello Colvin,
>> I am wondering if you still want to merge SOLR-15410 for the
>> Lucene/Solr 8.9 release?
>> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>>
>> Thank you.
>>
>> On Tue, May 18, 2021 at 8:49 AM Noble Paul 
>> wrote:
>>
>>> +1
>>>
>>>
>>> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie <
>>> colvin.cowie@gmail.com> wrote:
>>> >
>>> > Hello,
>>> >
>>> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
>>> logging when using new versions of OpenJ9. It's small, so if somebody 
>>> could
>>> have a look at it in time for 8.9 that would be great
>>> >
>>> > Thanks,
>>> > Colvin
>>> >
>>> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
>>> > 
>>> wrote:
>>> >>
>>> >> Hi Mayya,
>>> >>
>>> >> I would like to backport LUCENE-9935, which enables bulk-merge
>>> for stored fields with index sort, to 8.x this weekend. The patch is 
>>> ready,
>>> but we prefer to give CI some cycles before backporting. Please let me 
>>> know
>>> if it's okay with the release plan.
>>> >>
>>> >> Thanks,
>>> >> Nhat
>>> >>
>>> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck 
>>> wrote:
>>> >>>
>>> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should
>>> be investigated before 8.9, maybe make it a blocker?
>>> >>>
>>> >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir 
>>> wrote:
>>> 
>>>  Mayya, I created backport for Adrien's issue here, to try to
>>> help out:
>>>  https://github.com/apache/lucene-solr/pull/2495
>>> 
>>>  Personally, I felt that merging non-trivial changes from main
>>> branch
>>>  to 8.x has some additional risks when cherry-picking:
>>>  * structural changes in main branch making merging more
>>> difficult
>>>  (e.g. LUCENE-9705 reorganization of codec versioning, great
>>> change
>>>  moving forwards though)
>>>  * there are many style changes due to spotless in main branch
>>> which
>>>  add noise to merging against old code.

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Walter Underwood
Could someone else please take a look at SOLR-15056? This is a small blast 
radius change that improves the circuit breakers. It includes unit tests and 
documentation and has been ready since January.

https://github.com/apache/solr/pull/96/files 

https://issues.apache.org/jira/browse/SOLR-15056 


wunder
Walter Underwood
wun...@wunderwood.org
http://observer.wunderwood.org/  (my blog)

> On Jun 1, 2021, at 11:53 AM, Mayya Sharipova 
>  wrote:
> 
> Thank you for the update, Houston.
> 
> I've started the release process, the branch 8.9 is now cut.
> 
> On Tue, Jun 1, 2021 at 11:21 AM Houston Putman  > wrote:
> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
> 
> - Houston
> 
> On Thu, May 27, 2021 at 11:42 PM David Smiley  > wrote:
> SOLR-15412 is rather serious as the title suggests.  I haven't been tracking 
> the progress so if it's already resolved, that's unknown to me and isn't 
> reflected in JIRA.
> 
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley 
> 
> 
> On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova 
>  wrote:
> Hello everyone,
> I wonder if everyone is ok for May 31st (Monday) as the date for the feature 
> freeze date and branch cut?
> I've noticed that `releaseWizard.py` is also asking for the length of feature 
> freeze. What is the custom length to put there?
> 
> Looks like Lucene 
>  doesn't 
> have any unresolved issues for 8.9.
> SOLR  has:
> -  SOLR-15412  Strict validation on Replica metadata can cause complete 
> outage  (Looks like it may be resolved already?)
> - SOLR-15410 GC log is directed to console when starting Solr with Java 11 
> Open J9 on Windows
> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix load 
> average
> 
> Are we ok to postpone these issues to later releases if they are not resolved 
> and merged before feature freeze?
> 
> Thank you.
> 
> 
> 
> 
> 
> 
> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie  > wrote:
> Hello,
> Eric was going to have a look at the PR.
> But if it isn't done in time then I don't think it needs to block the release
> 
> Thanks
> 
> On Tue, 25 May 2021 at 15:50, Mayya Sharipova 
>  wrote:
> Hello Colvin,
> I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr 8.9 
> release?  
> Should we have a deadline for feature freeze? Say May 30th (Sunday)? 
> 
> Thank you.
> 
> On Tue, May 18, 2021 at 8:49 AM Noble Paul  > wrote:
> +1
> 
> 
> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie  > wrote:
> >
> > Hello,
> >
> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging 
> > when using new versions of OpenJ9. It's small, so if somebody could have a 
> > look at it in time for 8.9 that would be great
> >
> > Thanks,
> > Colvin
> >
> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen  > .invalid> wrote:
> >>
> >> Hi Mayya,
> >>
> >> I would like to backport LUCENE-9935, which enables bulk-merge for stored 
> >> fields with index sort, to 8.x this weekend. The patch is ready, but we 
> >> prefer to give CI some cycles before backporting. Please let me know if 
> >> it's okay with the release plan.
> >>
> >> Thanks,
> >> Nhat
> >>
> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck  >> > wrote:
> >>>
> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 
> >>>  should be investigated 
> >>> before 8.9, maybe make it a blocker?
> >>>
> >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir  >>> > wrote:
> 
>  Mayya, I created backport for Adrien's issue here, to try to help out:
>  https://github.com/apache/lucene-solr/pull/2495 
>  
> 
>  Personally, I felt that merging non-trivial changes from main branch
>  to 8.x has some additional risks when cherry-picking:
>  * structural changes in main branch making merging more difficult
>  (e.g. LUCENE-9705 reorganization of codec versioning, great change
>  moving forwards though)
>  * there are many style changes due to spotless in main branch which
>  add noise to merging against old code.
>  * In the specific case of LUCENE-9827, the usual additional tricky
>  backwards compatibility for 8.x must be added in the backport (due to
>  minor version bumps there) which can go wrong.
> 
>  I still think that particular change is worth considering for 8.9, it
>  isn't just a performance bug but also a huge improvement to test
>  

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Mayya Sharipova
Thank you for the update, Houston.

I've started the release process, the branch 8.9 is now cut.

On Tue, Jun 1, 2021 at 11:21 AM Houston Putman  wrote:

> Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.
>
> - Houston
>
> On Thu, May 27, 2021 at 11:42 PM David Smiley  wrote:
>
>> SOLR-15412 is rather serious as the title suggests.  I haven't been
>> tracking the progress so if it's already resolved, that's unknown to me and
>> isn't reflected in JIRA.
>>
>> ~ David Smiley
>> Apache Lucene/Solr Search Developer
>> http://www.linkedin.com/in/davidwsmiley
>>
>>
>> On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova
>>  wrote:
>>
>>> Hello everyone,
>>> I wonder if everyone is ok for May 31st (Monday) as the date for the
>>> feature freeze date and branch cut?
>>> I've noticed that `releaseWizard.py` is also asking for the length of
>>> feature freeze. What is the custom length to put there?
>>>
>>> Looks like Lucene
>>> 
>>> doesn't have any unresolved issues for 8.9.
>>> SOLR 
>>>  has:
>>> -  SOLR-15412  Strict validation on Replica metadata can cause complete
>>> outage  (Looks like it may be resolved already?)
>>> - SOLR-15410 GC log is directed to console when starting Solr with Java
>>> 11 Open J9 on Windows
>>> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix
>>> load average
>>>
>>> Are we ok to postpone these issues to later releases if they are not
>>> resolved and merged before feature freeze?
>>>
>>> Thank you.
>>>
>>>
>>>
>>>
>>>
>>>
>>> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie <
>>> colvin.cowie@gmail.com> wrote:
>>>
 Hello,
 Eric was going to have a look at the PR.
 But if it isn't done in time then I don't think it needs to block the
 release

 Thanks

 On Tue, 25 May 2021 at 15:50, Mayya Sharipova
  wrote:

> Hello Colvin,
> I am wondering if you still want to merge SOLR-15410 for the
> Lucene/Solr 8.9 release?
> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>
> Thank you.
>
> On Tue, May 18, 2021 at 8:49 AM Noble Paul 
> wrote:
>
>> +1
>>
>>
>> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie <
>> colvin.cowie@gmail.com> wrote:
>> >
>> > Hello,
>> >
>> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
>> logging when using new versions of OpenJ9. It's small, so if somebody 
>> could
>> have a look at it in time for 8.9 that would be great
>> >
>> > Thanks,
>> > Colvin
>> >
>> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
>> > 
>> wrote:
>> >>
>> >> Hi Mayya,
>> >>
>> >> I would like to backport LUCENE-9935, which enables bulk-merge for
>> stored fields with index sort, to 8.x this weekend. The patch is ready, 
>> but
>> we prefer to give CI some cycles before backporting. Please let me know 
>> if
>> it's okay with the release plan.
>> >>
>> >> Thanks,
>> >> Nhat
>> >>
>> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck 
>> wrote:
>> >>>
>> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should
>> be investigated before 8.9, maybe make it a blocker?
>> >>>
>> >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir 
>> wrote:
>> 
>>  Mayya, I created backport for Adrien's issue here, to try to
>> help out:
>>  https://github.com/apache/lucene-solr/pull/2495
>> 
>>  Personally, I felt that merging non-trivial changes from main
>> branch
>>  to 8.x has some additional risks when cherry-picking:
>>  * structural changes in main branch making merging more difficult
>>  (e.g. LUCENE-9705 reorganization of codec versioning, great
>> change
>>  moving forwards though)
>>  * there are many style changes due to spotless in main branch
>> which
>>  add noise to merging against old code.
>>  * In the specific case of LUCENE-9827, the usual additional
>> tricky
>>  backwards compatibility for 8.x must be added in the backport
>> (due to
>>  minor version bumps there) which can go wrong.
>> 
>>  I still think that particular change is worth considering for
>> 8.9, it
>>  isn't just a performance bug but also a huge improvement to test
>>  coverage that helps combat risks.
>> 
>>  But we should still take some precautions when releasing an 8.x
>> IMO:
>>  * be mindful of what we are backporting and the risks involved:
>> it is harder.
>>  * try to let jenkins bake changes in 8.x branches for longer than
>>  usual? even a few days really helps.
>> 
>>  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>>   wrote:
>>  >

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-06-01 Thread Houston Putman
Mayya, SOLR-14978 is now in 8.x. So no longer a blocker.

- Houston

On Thu, May 27, 2021 at 11:42 PM David Smiley  wrote:

> SOLR-15412 is rather serious as the title suggests.  I haven't been
> tracking the progress so if it's already resolved, that's unknown to me and
> isn't reflected in JIRA.
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>
>
> On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova
>  wrote:
>
>> Hello everyone,
>> I wonder if everyone is ok for May 31st (Monday) as the date for the
>> feature freeze date and branch cut?
>> I've noticed that `releaseWizard.py` is also asking for the length of
>> feature freeze. What is the custom length to put there?
>>
>> Looks like Lucene
>> 
>> doesn't have any unresolved issues for 8.9.
>> SOLR 
>>  has:
>> -  SOLR-15412  Strict validation on Replica metadata can cause complete
>> outage  (Looks like it may be resolved already?)
>> - SOLR-15410 GC log is directed to console when starting Solr with Java
>> 11 Open J9 on Windows
>> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix
>> load average
>>
>> Are we ok to postpone these issues to later releases if they are not
>> resolved and merged before feature freeze?
>>
>> Thank you.
>>
>>
>>
>>
>>
>>
>> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie 
>> wrote:
>>
>>> Hello,
>>> Eric was going to have a look at the PR.
>>> But if it isn't done in time then I don't think it needs to block the
>>> release
>>>
>>> Thanks
>>>
>>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova
>>>  wrote:
>>>
 Hello Colvin,
 I am wondering if you still want to merge SOLR-15410 for the
 Lucene/Solr 8.9 release?
 Should we have a deadline for feature freeze? Say May 30th (Sunday)?

 Thank you.

 On Tue, May 18, 2021 at 8:49 AM Noble Paul 
 wrote:

> +1
>
>
> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie <
> colvin.cowie@gmail.com> wrote:
> >
> > Hello,
> >
> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
> logging when using new versions of OpenJ9. It's small, so if somebody 
> could
> have a look at it in time for 8.9 that would be great
> >
> > Thanks,
> > Colvin
> >
> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
> > 
> wrote:
> >>
> >> Hi Mayya,
> >>
> >> I would like to backport LUCENE-9935, which enables bulk-merge for
> stored fields with index sort, to 8.x this weekend. The patch is ready, 
> but
> we prefer to give CI some cycles before backporting. Please let me know if
> it's okay with the release plan.
> >>
> >> Thanks,
> >> Nhat
> >>
> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck 
> wrote:
> >>>
> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should
> be investigated before 8.9, maybe make it a blocker?
> >>>
> >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir 
> wrote:
> 
>  Mayya, I created backport for Adrien's issue here, to try to help
> out:
>  https://github.com/apache/lucene-solr/pull/2495
> 
>  Personally, I felt that merging non-trivial changes from main
> branch
>  to 8.x has some additional risks when cherry-picking:
>  * structural changes in main branch making merging more difficult
>  (e.g. LUCENE-9705 reorganization of codec versioning, great change
>  moving forwards though)
>  * there are many style changes due to spotless in main branch
> which
>  add noise to merging against old code.
>  * In the specific case of LUCENE-9827, the usual additional tricky
>  backwards compatibility for 8.x must be added in the backport
> (due to
>  minor version bumps there) which can go wrong.
> 
>  I still think that particular change is worth considering for
> 8.9, it
>  isn't just a performance bug but also a huge improvement to test
>  coverage that helps combat risks.
> 
>  But we should still take some precautions when releasing an 8.x
> IMO:
>  * be mindful of what we are backporting and the risks involved:
> it is harder.
>  * try to let jenkins bake changes in 8.x branches for longer than
>  usual? even a few days really helps.
> 
>  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>   wrote:
>  >
>  > Thanks everyone,
>  >
>  > Adrien, I  am happy to try to be a release manager for this
> release.
>  >
>  > Adrien, and Gus, please let me know when your changes are
> merged to 8.x
>  >
>  >
>  >
>  > On Tue, May 11, 2021 at 10:38 AM Gus Heck 
> wrote:
>  

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-27 Thread David Smiley
SOLR-15412 is rather serious as the title suggests.  I haven't been
tracking the progress so if it's already resolved, that's unknown to me and
isn't reflected in JIRA.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley


On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova
 wrote:

> Hello everyone,
> I wonder if everyone is ok for May 31st (Monday) as the date for the
> feature freeze date and branch cut?
> I've noticed that `releaseWizard.py` is also asking for the length of
> feature freeze. What is the custom length to put there?
>
> Looks like Lucene
> 
> doesn't have any unresolved issues for 8.9.
> SOLR  has:
> -  SOLR-15412  Strict validation on Replica metadata can cause complete
> outage  (Looks like it may be resolved already?)
> - SOLR-15410 GC log is directed to console when starting Solr with Java 11
> Open J9 on Windows
> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix
> load average
>
> Are we ok to postpone these issues to later releases if they are not
> resolved and merged before feature freeze?
>
> Thank you.
>
>
>
>
>
>
> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie 
> wrote:
>
>> Hello,
>> Eric was going to have a look at the PR.
>> But if it isn't done in time then I don't think it needs to block the
>> release
>>
>> Thanks
>>
>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova
>>  wrote:
>>
>>> Hello Colvin,
>>> I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr
>>> 8.9 release?
>>> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>>>
>>> Thank you.
>>>
>>> On Tue, May 18, 2021 at 8:49 AM Noble Paul  wrote:
>>>
 +1


 On Tue, May 18, 2021 at 9:30 PM Colvin Cowie <
 colvin.cowie@gmail.com> wrote:
 >
 > Hello,
 >
 > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
 logging when using new versions of OpenJ9. It's small, so if somebody could
 have a look at it in time for 8.9 that would be great
 >
 > Thanks,
 > Colvin
 >
 > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
 > 
 wrote:
 >>
 >> Hi Mayya,
 >>
 >> I would like to backport LUCENE-9935, which enables bulk-merge for
 stored fields with index sort, to 8.x this weekend. The patch is ready, but
 we prefer to give CI some cycles before backporting. Please let me know if
 it's okay with the release plan.
 >>
 >> Thanks,
 >> Nhat
 >>
 >> On Thu, May 13, 2021 at 12:44 PM Gus Heck 
 wrote:
 >>>
 >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
 investigated before 8.9, maybe make it a blocker?
 >>>
 >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir 
 wrote:
 
  Mayya, I created backport for Adrien's issue here, to try to help
 out:
  https://github.com/apache/lucene-solr/pull/2495
 
  Personally, I felt that merging non-trivial changes from main
 branch
  to 8.x has some additional risks when cherry-picking:
  * structural changes in main branch making merging more difficult
  (e.g. LUCENE-9705 reorganization of codec versioning, great change
  moving forwards though)
  * there are many style changes due to spotless in main branch which
  add noise to merging against old code.
  * In the specific case of LUCENE-9827, the usual additional tricky
  backwards compatibility for 8.x must be added in the backport (due
 to
  minor version bumps there) which can go wrong.
 
  I still think that particular change is worth considering for 8.9,
 it
  isn't just a performance bug but also a huge improvement to test
  coverage that helps combat risks.
 
  But we should still take some precautions when releasing an 8.x
 IMO:
  * be mindful of what we are backporting and the risks involved: it
 is harder.
  * try to let jenkins bake changes in 8.x branches for longer than
  usual? even a few days really helps.
 
  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
   wrote:
  >
  > Thanks everyone,
  >
  > Adrien, I  am happy to try to be a release manager for this
 release.
  >
  > Adrien, and Gus, please let me know when your changes are merged
 to 8.x
  >
  >
  >
  > On Tue, May 11, 2021 at 10:38 AM Gus Heck 
 wrote:
  >>
  >> I'm also looking to find time to get
 https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
 I've recently completed the back port of 2/3 of the lucene tickets that are
 related, and hope to work on the third tomorrow
  >>
  >> I had some 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-27 Thread Houston Putman
Hey Mayya, would you mind to wait until at least Tuesday (6/1)?

We are trying to backport SOLR-14978 to 8.x, and would really like it
included in 8.9.

- Houston

On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova
 wrote:

> Hello everyone,
> I wonder if everyone is ok for May 31st (Monday) as the date for the
> feature freeze date and branch cut?
> I've noticed that `releaseWizard.py` is also asking for the length of
> feature freeze. What is the custom length to put there?
>
> Looks like Lucene
> 
> doesn't have any unresolved issues for 8.9.
> SOLR  has:
> -  SOLR-15412  Strict validation on Replica metadata can cause complete
> outage  (Looks like it may be resolved already?)
> - SOLR-15410 GC log is directed to console when starting Solr with Java 11
> Open J9 on Windows
> - SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix
> load average
>
> Are we ok to postpone these issues to later releases if they are not
> resolved and merged before feature freeze?
>
> Thank you.
>
>
>
>
>
>
> On Tue, May 25, 2021 at 12:41 PM Colvin Cowie 
> wrote:
>
>> Hello,
>> Eric was going to have a look at the PR.
>> But if it isn't done in time then I don't think it needs to block the
>> release
>>
>> Thanks
>>
>> On Tue, 25 May 2021 at 15:50, Mayya Sharipova
>>  wrote:
>>
>>> Hello Colvin,
>>> I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr
>>> 8.9 release?
>>> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>>>
>>> Thank you.
>>>
>>> On Tue, May 18, 2021 at 8:49 AM Noble Paul  wrote:
>>>
 +1


 On Tue, May 18, 2021 at 9:30 PM Colvin Cowie <
 colvin.cowie@gmail.com> wrote:
 >
 > Hello,
 >
 > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
 logging when using new versions of OpenJ9. It's small, so if somebody could
 have a look at it in time for 8.9 that would be great
 >
 > Thanks,
 > Colvin
 >
 > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
 > 
 wrote:
 >>
 >> Hi Mayya,
 >>
 >> I would like to backport LUCENE-9935, which enables bulk-merge for
 stored fields with index sort, to 8.x this weekend. The patch is ready, but
 we prefer to give CI some cycles before backporting. Please let me know if
 it's okay with the release plan.
 >>
 >> Thanks,
 >> Nhat
 >>
 >> On Thu, May 13, 2021 at 12:44 PM Gus Heck 
 wrote:
 >>>
 >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
 investigated before 8.9, maybe make it a blocker?
 >>>
 >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir 
 wrote:
 
  Mayya, I created backport for Adrien's issue here, to try to help
 out:
  https://github.com/apache/lucene-solr/pull/2495
 
  Personally, I felt that merging non-trivial changes from main
 branch
  to 8.x has some additional risks when cherry-picking:
  * structural changes in main branch making merging more difficult
  (e.g. LUCENE-9705 reorganization of codec versioning, great change
  moving forwards though)
  * there are many style changes due to spotless in main branch which
  add noise to merging against old code.
  * In the specific case of LUCENE-9827, the usual additional tricky
  backwards compatibility for 8.x must be added in the backport (due
 to
  minor version bumps there) which can go wrong.
 
  I still think that particular change is worth considering for 8.9,
 it
  isn't just a performance bug but also a huge improvement to test
  coverage that helps combat risks.
 
  But we should still take some precautions when releasing an 8.x
 IMO:
  * be mindful of what we are backporting and the risks involved: it
 is harder.
  * try to let jenkins bake changes in 8.x branches for longer than
  usual? even a few days really helps.
 
  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
   wrote:
  >
  > Thanks everyone,
  >
  > Adrien, I  am happy to try to be a release manager for this
 release.
  >
  > Adrien, and Gus, please let me know when your changes are merged
 to 8.x
  >
  >
  >
  > On Tue, May 11, 2021 at 10:38 AM Gus Heck 
 wrote:
  >>
  >> I'm also looking to find time to get
 https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
 I've recently completed the back port of 2/3 of the lucene tickets that are
 related, and hope to work on the third tomorrow
  >>
  >> I had some feedback there, but I think folks were waiting for
 the version integrated with the final form 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-27 Thread Mayya Sharipova
Hello everyone,
I wonder if everyone is ok for May 31st (Monday) as the date for the
feature freeze date and branch cut?
I've noticed that `releaseWizard.py` is also asking for the length of
feature freeze. What is the custom length to put there?

Looks like Lucene
 doesn't
have any unresolved issues for 8.9.
SOLR  has:
-  SOLR-15412  Strict validation on Replica metadata can cause complete
outage  (Looks like it may be resolved already?)
- SOLR-15410 GC log is directed to console when starting Solr with Java 11
Open J9 on Windows
- SOLR-15056  CPU circuit breaker needs to use CPU utilization, not Unix
load average

Are we ok to postpone these issues to later releases if they are not
resolved and merged before feature freeze?

Thank you.






On Tue, May 25, 2021 at 12:41 PM Colvin Cowie 
wrote:

> Hello,
> Eric was going to have a look at the PR.
> But if it isn't done in time then I don't think it needs to block the
> release
>
> Thanks
>
> On Tue, 25 May 2021 at 15:50, Mayya Sharipova
>  wrote:
>
>> Hello Colvin,
>> I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr
>> 8.9 release?
>> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>>
>> Thank you.
>>
>> On Tue, May 18, 2021 at 8:49 AM Noble Paul  wrote:
>>
>>> +1
>>>
>>>
>>> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie 
>>> wrote:
>>> >
>>> > Hello,
>>> >
>>> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC
>>> logging when using new versions of OpenJ9. It's small, so if somebody could
>>> have a look at it in time for 8.9 that would be great
>>> >
>>> > Thanks,
>>> > Colvin
>>> >
>>> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
>>> wrote:
>>> >>
>>> >> Hi Mayya,
>>> >>
>>> >> I would like to backport LUCENE-9935, which enables bulk-merge for
>>> stored fields with index sort, to 8.x this weekend. The patch is ready, but
>>> we prefer to give CI some cycles before backporting. Please let me know if
>>> it's okay with the release plan.
>>> >>
>>> >> Thanks,
>>> >> Nhat
>>> >>
>>> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck  wrote:
>>> >>>
>>> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
>>> investigated before 8.9, maybe make it a blocker?
>>> >>>
>>> >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir 
>>> wrote:
>>> 
>>>  Mayya, I created backport for Adrien's issue here, to try to help
>>> out:
>>>  https://github.com/apache/lucene-solr/pull/2495
>>> 
>>>  Personally, I felt that merging non-trivial changes from main branch
>>>  to 8.x has some additional risks when cherry-picking:
>>>  * structural changes in main branch making merging more difficult
>>>  (e.g. LUCENE-9705 reorganization of codec versioning, great change
>>>  moving forwards though)
>>>  * there are many style changes due to spotless in main branch which
>>>  add noise to merging against old code.
>>>  * In the specific case of LUCENE-9827, the usual additional tricky
>>>  backwards compatibility for 8.x must be added in the backport (due
>>> to
>>>  minor version bumps there) which can go wrong.
>>> 
>>>  I still think that particular change is worth considering for 8.9,
>>> it
>>>  isn't just a performance bug but also a huge improvement to test
>>>  coverage that helps combat risks.
>>> 
>>>  But we should still take some precautions when releasing an 8.x IMO:
>>>  * be mindful of what we are backporting and the risks involved: it
>>> is harder.
>>>  * try to let jenkins bake changes in 8.x branches for longer than
>>>  usual? even a few days really helps.
>>> 
>>>  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>>>   wrote:
>>>  >
>>>  > Thanks everyone,
>>>  >
>>>  > Adrien, I  am happy to try to be a release manager for this
>>> release.
>>>  >
>>>  > Adrien, and Gus, please let me know when your changes are merged
>>> to 8.x
>>>  >
>>>  >
>>>  >
>>>  > On Tue, May 11, 2021 at 10:38 AM Gus Heck 
>>> wrote:
>>>  >>
>>>  >> I'm also looking to find time to get
>>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
>>> I've recently completed the back port of 2/3 of the lucene tickets that are
>>> related, and hope to work on the third tomorrow
>>>  >>
>>>  >> I had some feedback there, but I think folks were waiting for
>>> the version integrated with the final form of the Lucene tickets before
>>> delving further. Hopefully this week I can start on a patch that does that.
>>>  >>
>>>  >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
>>> wrote:
>>>  >>>
>>>  >>> I would like to backport LUCENE-9827 before we release 8.9, a
>>> performance regression to stored fields merges. I'll work on this as soon
>>> as possible.
>>>  >>>
>>>  >>> On Thu, May 6, 2021 at 10:28 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-25 Thread Colvin Cowie
Hello,
Eric was going to have a look at the PR.
But if it isn't done in time then I don't think it needs to block the
release

Thanks

On Tue, 25 May 2021 at 15:50, Mayya Sharipova
 wrote:

> Hello Colvin,
> I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr
> 8.9 release?
> Should we have a deadline for feature freeze? Say May 30th (Sunday)?
>
> Thank you.
>
> On Tue, May 18, 2021 at 8:49 AM Noble Paul  wrote:
>
>> +1
>>
>>
>> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie 
>> wrote:
>> >
>> > Hello,
>> >
>> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging
>> when using new versions of OpenJ9. It's small, so if somebody could have a
>> look at it in time for 8.9 that would be great
>> >
>> > Thanks,
>> > Colvin
>> >
>> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
>> wrote:
>> >>
>> >> Hi Mayya,
>> >>
>> >> I would like to backport LUCENE-9935, which enables bulk-merge for
>> stored fields with index sort, to 8.x this weekend. The patch is ready, but
>> we prefer to give CI some cycles before backporting. Please let me know if
>> it's okay with the release plan.
>> >>
>> >> Thanks,
>> >> Nhat
>> >>
>> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck  wrote:
>> >>>
>> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
>> investigated before 8.9, maybe make it a blocker?
>> >>>
>> >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:
>> 
>>  Mayya, I created backport for Adrien's issue here, to try to help
>> out:
>>  https://github.com/apache/lucene-solr/pull/2495
>> 
>>  Personally, I felt that merging non-trivial changes from main branch
>>  to 8.x has some additional risks when cherry-picking:
>>  * structural changes in main branch making merging more difficult
>>  (e.g. LUCENE-9705 reorganization of codec versioning, great change
>>  moving forwards though)
>>  * there are many style changes due to spotless in main branch which
>>  add noise to merging against old code.
>>  * In the specific case of LUCENE-9827, the usual additional tricky
>>  backwards compatibility for 8.x must be added in the backport (due to
>>  minor version bumps there) which can go wrong.
>> 
>>  I still think that particular change is worth considering for 8.9, it
>>  isn't just a performance bug but also a huge improvement to test
>>  coverage that helps combat risks.
>> 
>>  But we should still take some precautions when releasing an 8.x IMO:
>>  * be mindful of what we are backporting and the risks involved: it
>> is harder.
>>  * try to let jenkins bake changes in 8.x branches for longer than
>>  usual? even a few days really helps.
>> 
>>  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>>   wrote:
>>  >
>>  > Thanks everyone,
>>  >
>>  > Adrien, I  am happy to try to be a release manager for this
>> release.
>>  >
>>  > Adrien, and Gus, please let me know when your changes are merged
>> to 8.x
>>  >
>>  >
>>  >
>>  > On Tue, May 11, 2021 at 10:38 AM Gus Heck 
>> wrote:
>>  >>
>>  >> I'm also looking to find time to get
>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
>> I've recently completed the back port of 2/3 of the lucene tickets that are
>> related, and hope to work on the third tomorrow
>>  >>
>>  >> I had some feedback there, but I think folks were waiting for the
>> version integrated with the final form of the Lucene tickets before delving
>> further. Hopefully this week I can start on a patch that does that.
>>  >>
>>  >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
>> wrote:
>>  >>>
>>  >>> I would like to backport LUCENE-9827 before we release 8.9, a
>> performance regression to stored fields merges. I'll work on this as soon
>> as possible.
>>  >>>
>>  >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand 
>> wrote:
>>  
>>   +1
>>  
>>   Mayya, are you volunteering to be the release manager?
>>  
>>   Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>>  >
>>  > +1
>>  >
>>  > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova <
>> mayya.sharip...@elastic.co.invalid> wrote:
>>  >>
>>  >> Hello everyone,
>>  >> I was wondering if we can have a 8.9.0 release. It has been
>> more than 3 months since 8.8.0 was released.
>>  >> 8.9.0 doesn't need to be the last release in the 8.x series.
>>  >>
>>  >> Thanks.
>>  >>>
>>  >>>
>>  >>>
>>  >>> --
>>  >>> Adrien
>>  >>
>>  >>
>>  >>
>>  >> --
>>  >> http://www.needhamsoftware.com (work)
>>  >> http://www.the111shift.com (play)
>> 
>>  -
>>  To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>>  For 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-25 Thread Mayya Sharipova
Hello Colvin,
I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr
8.9 release?
Should we have a deadline for feature freeze? Say May 30th (Sunday)?

Thank you.

On Tue, May 18, 2021 at 8:49 AM Noble Paul  wrote:

> +1
>
>
> On Tue, May 18, 2021 at 9:30 PM Colvin Cowie 
> wrote:
> >
> > Hello,
> >
> > I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging
> when using new versions of OpenJ9. It's small, so if somebody could have a
> look at it in time for 8.9 that would be great
> >
> > Thanks,
> > Colvin
> >
> > On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
> wrote:
> >>
> >> Hi Mayya,
> >>
> >> I would like to backport LUCENE-9935, which enables bulk-merge for
> stored fields with index sort, to 8.x this weekend. The patch is ready, but
> we prefer to give CI some cycles before backporting. Please let me know if
> it's okay with the release plan.
> >>
> >> Thanks,
> >> Nhat
> >>
> >> On Thu, May 13, 2021 at 12:44 PM Gus Heck  wrote:
> >>>
> >>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
> investigated before 8.9, maybe make it a blocker?
> >>>
> >>> On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:
> 
>  Mayya, I created backport for Adrien's issue here, to try to help out:
>  https://github.com/apache/lucene-solr/pull/2495
> 
>  Personally, I felt that merging non-trivial changes from main branch
>  to 8.x has some additional risks when cherry-picking:
>  * structural changes in main branch making merging more difficult
>  (e.g. LUCENE-9705 reorganization of codec versioning, great change
>  moving forwards though)
>  * there are many style changes due to spotless in main branch which
>  add noise to merging against old code.
>  * In the specific case of LUCENE-9827, the usual additional tricky
>  backwards compatibility for 8.x must be added in the backport (due to
>  minor version bumps there) which can go wrong.
> 
>  I still think that particular change is worth considering for 8.9, it
>  isn't just a performance bug but also a huge improvement to test
>  coverage that helps combat risks.
> 
>  But we should still take some precautions when releasing an 8.x IMO:
>  * be mindful of what we are backporting and the risks involved: it is
> harder.
>  * try to let jenkins bake changes in 8.x branches for longer than
>  usual? even a few days really helps.
> 
>  On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>   wrote:
>  >
>  > Thanks everyone,
>  >
>  > Adrien, I  am happy to try to be a release manager for this release.
>  >
>  > Adrien, and Gus, please let me know when your changes are merged to
> 8.x
>  >
>  >
>  >
>  > On Tue, May 11, 2021 at 10:38 AM Gus Heck 
> wrote:
>  >>
>  >> I'm also looking to find time to get
> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
> I've recently completed the back port of 2/3 of the lucene tickets that are
> related, and hope to work on the third tomorrow
>  >>
>  >> I had some feedback there, but I think folks were waiting for the
> version integrated with the final form of the Lucene tickets before delving
> further. Hopefully this week I can start on a patch that does that.
>  >>
>  >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
> wrote:
>  >>>
>  >>> I would like to backport LUCENE-9827 before we release 8.9, a
> performance regression to stored fields merges. I'll work on this as soon
> as possible.
>  >>>
>  >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand 
> wrote:
>  
>   +1
>  
>   Mayya, are you volunteering to be the release manager?
>  
>   Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>  >
>  > +1
>  >
>  > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova <
> mayya.sharip...@elastic.co.invalid> wrote:
>  >>
>  >> Hello everyone,
>  >> I was wondering if we can have a 8.9.0 release. It has been
> more than 3 months since 8.8.0 was released.
>  >> 8.9.0 doesn't need to be the last release in the 8.x series.
>  >>
>  >> Thanks.
>  >>>
>  >>>
>  >>>
>  >>> --
>  >>> Adrien
>  >>
>  >>
>  >>
>  >> --
>  >> http://www.needhamsoftware.com (work)
>  >> http://www.the111shift.com (play)
> 
>  -
>  To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>  For additional commands, e-mail: dev-h...@lucene.apache.org
> 
> >>>
> >>>
> >>> --
> >>> http://www.needhamsoftware.com (work)
> >>> http://www.the111shift.com (play)
>
>
>
> --
> -
> Noble Paul
>
> -
> To unsubscribe, 

Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-18 Thread Noble Paul
+1


On Tue, May 18, 2021 at 9:30 PM Colvin Cowie  wrote:
>
> Hello,
>
> I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging when 
> using new versions of OpenJ9. It's small, so if somebody could have a look at 
> it in time for 8.9 that would be great
>
> Thanks,
> Colvin
>
> On Thu, 13 May 2021 at 17:52, Nhat Nguyen  
> wrote:
>>
>> Hi Mayya,
>>
>> I would like to backport LUCENE-9935, which enables bulk-merge for stored 
>> fields with index sort, to 8.x this weekend. The patch is ready, but we 
>> prefer to give CI some cycles before backporting. Please let me know if it's 
>> okay with the release plan.
>>
>> Thanks,
>> Nhat
>>
>> On Thu, May 13, 2021 at 12:44 PM Gus Heck  wrote:
>>>
>>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be 
>>> investigated before 8.9, maybe make it a blocker?
>>>
>>> On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:

 Mayya, I created backport for Adrien's issue here, to try to help out:
 https://github.com/apache/lucene-solr/pull/2495

 Personally, I felt that merging non-trivial changes from main branch
 to 8.x has some additional risks when cherry-picking:
 * structural changes in main branch making merging more difficult
 (e.g. LUCENE-9705 reorganization of codec versioning, great change
 moving forwards though)
 * there are many style changes due to spotless in main branch which
 add noise to merging against old code.
 * In the specific case of LUCENE-9827, the usual additional tricky
 backwards compatibility for 8.x must be added in the backport (due to
 minor version bumps there) which can go wrong.

 I still think that particular change is worth considering for 8.9, it
 isn't just a performance bug but also a huge improvement to test
 coverage that helps combat risks.

 But we should still take some precautions when releasing an 8.x IMO:
 * be mindful of what we are backporting and the risks involved: it is 
 harder.
 * try to let jenkins bake changes in 8.x branches for longer than
 usual? even a few days really helps.

 On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
  wrote:
 >
 > Thanks everyone,
 >
 > Adrien, I  am happy to try to be a release manager for this release.
 >
 > Adrien, and Gus, please let me know when your changes are merged to 8.x
 >
 >
 >
 > On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
 >>
 >> I'm also looking to find time to get 
 >> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x. 
 >> I've recently completed the back port of 2/3 of the lucene tickets that 
 >> are related, and hope to work on the third tomorrow
 >>
 >> I had some feedback there, but I think folks were waiting for the 
 >> version integrated with the final form of the Lucene tickets before 
 >> delving further. Hopefully this week I can start on a patch that does 
 >> that.
 >>
 >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand  wrote:
 >>>
 >>> I would like to backport LUCENE-9827 before we release 8.9, a 
 >>> performance regression to stored fields merges. I'll work on this as 
 >>> soon as possible.
 >>>
 >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand  wrote:
 
  +1
 
  Mayya, are you volunteering to be the release manager?
 
  Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya 
   a écrit :
 >
 > +1
 >
 > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova 
 >  wrote:
 >>
 >> Hello everyone,
 >> I was wondering if we can have a 8.9.0 release. It has been more 
 >> than 3 months since 8.8.0 was released.
 >> 8.9.0 doesn't need to be the last release in the 8.x series.
 >>
 >> Thanks.
 >>>
 >>>
 >>>
 >>> --
 >>> Adrien
 >>
 >>
 >>
 >> --
 >> http://www.needhamsoftware.com (work)
 >> http://www.the111shift.com (play)

 -
 To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
 For additional commands, e-mail: dev-h...@lucene.apache.org

>>>
>>>
>>> --
>>> http://www.needhamsoftware.com (work)
>>> http://www.the111shift.com (play)



-- 
-
Noble Paul

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-18 Thread Colvin Cowie
Hello,

I raised SOLR-15410 
yesterday with a PR to fix an issue with GC logging when using new versions
of OpenJ9. It's small, so if somebody could have a look at it in time for
8.9 that would be great

Thanks,
Colvin

On Thu, 13 May 2021 at 17:52, Nhat Nguyen 
wrote:

> Hi Mayya,
>
> I would like to backport LUCENE-9935
> , which enables
> bulk-merge for stored fields with index sort, to 8.x this weekend. The
> patch is ready , but we
> prefer to give CI some cycles before backporting. Please let me know if
> it's okay with the release plan.
>
> Thanks,
> Nhat
>
> On Thu, May 13, 2021 at 12:44 PM Gus Heck  wrote:
>
>> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
>> investigated before 8.9, maybe make it a blocker?
>>
>> On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:
>>
>>> Mayya, I created backport for Adrien's issue here, to try to help out:
>>> https://github.com/apache/lucene-solr/pull/2495
>>>
>>> Personally, I felt that merging non-trivial changes from main branch
>>> to 8.x has some additional risks when cherry-picking:
>>> * structural changes in main branch making merging more difficult
>>> (e.g. LUCENE-9705 reorganization of codec versioning, great change
>>> moving forwards though)
>>> * there are many style changes due to spotless in main branch which
>>> add noise to merging against old code.
>>> * In the specific case of LUCENE-9827, the usual additional tricky
>>> backwards compatibility for 8.x must be added in the backport (due to
>>> minor version bumps there) which can go wrong.
>>>
>>> I still think that particular change is worth considering for 8.9, it
>>> isn't just a performance bug but also a huge improvement to test
>>> coverage that helps combat risks.
>>>
>>> But we should still take some precautions when releasing an 8.x IMO:
>>> * be mindful of what we are backporting and the risks involved: it is
>>> harder.
>>> * try to let jenkins bake changes in 8.x branches for longer than
>>> usual? even a few days really helps.
>>>
>>> On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>>>  wrote:
>>> >
>>> > Thanks everyone,
>>> >
>>> > Adrien, I  am happy to try to be a release manager for this release.
>>> >
>>> > Adrien, and Gus, please let me know when your changes are merged to 8.x
>>> >
>>> >
>>> >
>>> > On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
>>> >>
>>> >> I'm also looking to find time to get
>>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
>>> I've recently completed the back port of 2/3 of the lucene tickets that are
>>> related, and hope to work on the third tomorrow
>>> >>
>>> >> I had some feedback there, but I think folks were waiting for the
>>> version integrated with the final form of the Lucene tickets before delving
>>> further. Hopefully this week I can start on a patch that does that.
>>> >>
>>> >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
>>> wrote:
>>> >>>
>>> >>> I would like to backport LUCENE-9827 before we release 8.9, a
>>> performance regression to stored fields merges. I'll work on this as soon
>>> as possible.
>>> >>>
>>> >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand 
>>> wrote:
>>> 
>>>  +1
>>> 
>>>  Mayya, are you volunteering to be the release manager?
>>> 
>>>  Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
>>> ichattopadhy...@gmail.com> a écrit :
>>> >
>>> > +1
>>> >
>>> > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova <
>>> mayya.sharip...@elastic.co.invalid> wrote:
>>> >>
>>> >> Hello everyone,
>>> >> I was wondering if we can have a 8.9.0 release. It has been more
>>> than 3 months since 8.8.0 was released.
>>> >> 8.9.0 doesn't need to be the last release in the 8.x series.
>>> >>
>>> >> Thanks.
>>> >>>
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Adrien
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> http://www.needhamsoftware.com (work)
>>> >> http://www.the111shift.com (play)
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>>
>>>
>>
>> --
>> http://www.needhamsoftware.com (work)
>> http://www.the111shift.com (play)
>>
>


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-13 Thread Nhat Nguyen
Hi Mayya,

I would like to backport LUCENE-9935
, which enables
bulk-merge for stored fields with index sort, to 8.x this weekend. The
patch is ready , but we
prefer to give CI some cycles before backporting. Please let me know if
it's okay with the release plan.

Thanks,
Nhat

On Thu, May 13, 2021 at 12:44 PM Gus Heck  wrote:

> Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
> investigated before 8.9, maybe make it a blocker?
>
> On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:
>
>> Mayya, I created backport for Adrien's issue here, to try to help out:
>> https://github.com/apache/lucene-solr/pull/2495
>>
>> Personally, I felt that merging non-trivial changes from main branch
>> to 8.x has some additional risks when cherry-picking:
>> * structural changes in main branch making merging more difficult
>> (e.g. LUCENE-9705 reorganization of codec versioning, great change
>> moving forwards though)
>> * there are many style changes due to spotless in main branch which
>> add noise to merging against old code.
>> * In the specific case of LUCENE-9827, the usual additional tricky
>> backwards compatibility for 8.x must be added in the backport (due to
>> minor version bumps there) which can go wrong.
>>
>> I still think that particular change is worth considering for 8.9, it
>> isn't just a performance bug but also a huge improvement to test
>> coverage that helps combat risks.
>>
>> But we should still take some precautions when releasing an 8.x IMO:
>> * be mindful of what we are backporting and the risks involved: it is
>> harder.
>> * try to let jenkins bake changes in 8.x branches for longer than
>> usual? even a few days really helps.
>>
>> On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>>  wrote:
>> >
>> > Thanks everyone,
>> >
>> > Adrien, I  am happy to try to be a release manager for this release.
>> >
>> > Adrien, and Gus, please let me know when your changes are merged to 8.x
>> >
>> >
>> >
>> > On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
>> >>
>> >> I'm also looking to find time to get
>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
>> I've recently completed the back port of 2/3 of the lucene tickets that are
>> related, and hope to work on the third tomorrow
>> >>
>> >> I had some feedback there, but I think folks were waiting for the
>> version integrated with the final form of the Lucene tickets before delving
>> further. Hopefully this week I can start on a patch that does that.
>> >>
>> >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
>> wrote:
>> >>>
>> >>> I would like to backport LUCENE-9827 before we release 8.9, a
>> performance regression to stored fields merges. I'll work on this as soon
>> as possible.
>> >>>
>> >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand 
>> wrote:
>> 
>>  +1
>> 
>>  Mayya, are you volunteering to be the release manager?
>> 
>>  Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>> >
>> > +1
>> >
>> > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova <
>> mayya.sharip...@elastic.co.invalid> wrote:
>> >>
>> >> Hello everyone,
>> >> I was wondering if we can have a 8.9.0 release. It has been more
>> than 3 months since 8.8.0 was released.
>> >> 8.9.0 doesn't need to be the last release in the 8.x series.
>> >>
>> >> Thanks.
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Adrien
>> >>
>> >>
>> >>
>> >> --
>> >> http://www.needhamsoftware.com (work)
>> >> http://www.the111shift.com (play)
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>
>>
>
> --
> http://www.needhamsoftware.com (work)
> http://www.the111shift.com (play)
>


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-13 Thread Gus Heck
Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be
investigated before 8.9, maybe make it a blocker?

On Thu, May 13, 2021 at 1:35 AM Robert Muir  wrote:

> Mayya, I created backport for Adrien's issue here, to try to help out:
> https://github.com/apache/lucene-solr/pull/2495
>
> Personally, I felt that merging non-trivial changes from main branch
> to 8.x has some additional risks when cherry-picking:
> * structural changes in main branch making merging more difficult
> (e.g. LUCENE-9705 reorganization of codec versioning, great change
> moving forwards though)
> * there are many style changes due to spotless in main branch which
> add noise to merging against old code.
> * In the specific case of LUCENE-9827, the usual additional tricky
> backwards compatibility for 8.x must be added in the backport (due to
> minor version bumps there) which can go wrong.
>
> I still think that particular change is worth considering for 8.9, it
> isn't just a performance bug but also a huge improvement to test
> coverage that helps combat risks.
>
> But we should still take some precautions when releasing an 8.x IMO:
> * be mindful of what we are backporting and the risks involved: it is
> harder.
> * try to let jenkins bake changes in 8.x branches for longer than
> usual? even a few days really helps.
>
> On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
>  wrote:
> >
> > Thanks everyone,
> >
> > Adrien, I  am happy to try to be a release manager for this release.
> >
> > Adrien, and Gus, please let me know when your changes are merged to 8.x
> >
> >
> >
> > On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
> >>
> >> I'm also looking to find time to get
> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
> I've recently completed the back port of 2/3 of the lucene tickets that are
> related, and hope to work on the third tomorrow
> >>
> >> I had some feedback there, but I think folks were waiting for the
> version integrated with the final form of the Lucene tickets before delving
> further. Hopefully this week I can start on a patch that does that.
> >>
> >> On Tue, May 11, 2021 at 10:25 AM Adrien Grand 
> wrote:
> >>>
> >>> I would like to backport LUCENE-9827 before we release 8.9, a
> performance regression to stored fields merges. I'll work on this as soon
> as possible.
> >>>
> >>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand 
> wrote:
> 
>  +1
> 
>  Mayya, are you volunteering to be the release manager?
> 
>  Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
> >
> > +1
> >
> > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova <
> mayya.sharip...@elastic.co.invalid> wrote:
> >>
> >> Hello everyone,
> >> I was wondering if we can have a 8.9.0 release. It has been more
> than 3 months since 8.8.0 was released.
> >> 8.9.0 doesn't need to be the last release in the 8.x series.
> >>
> >> Thanks.
> >>>
> >>>
> >>>
> >>> --
> >>> Adrien
> >>
> >>
> >>
> >> --
> >> http://www.needhamsoftware.com (work)
> >> http://www.the111shift.com (play)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>

-- 
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-12 Thread Robert Muir
Mayya, I created backport for Adrien's issue here, to try to help out:
https://github.com/apache/lucene-solr/pull/2495

Personally, I felt that merging non-trivial changes from main branch
to 8.x has some additional risks when cherry-picking:
* structural changes in main branch making merging more difficult
(e.g. LUCENE-9705 reorganization of codec versioning, great change
moving forwards though)
* there are many style changes due to spotless in main branch which
add noise to merging against old code.
* In the specific case of LUCENE-9827, the usual additional tricky
backwards compatibility for 8.x must be added in the backport (due to
minor version bumps there) which can go wrong.

I still think that particular change is worth considering for 8.9, it
isn't just a performance bug but also a huge improvement to test
coverage that helps combat risks.

But we should still take some precautions when releasing an 8.x IMO:
* be mindful of what we are backporting and the risks involved: it is harder.
* try to let jenkins bake changes in 8.x branches for longer than
usual? even a few days really helps.

On Tue, May 11, 2021 at 1:29 PM Mayya Sharipova
 wrote:
>
> Thanks everyone,
>
> Adrien, I  am happy to try to be a release manager for this release.
>
> Adrien, and Gus, please let me know when your changes are merged to 8.x
>
>
>
> On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
>>
>> I'm also looking to find time to get 
>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x. I've 
>> recently completed the back port of 2/3 of the lucene tickets that are 
>> related, and hope to work on the third tomorrow
>>
>> I had some feedback there, but I think folks were waiting for the version 
>> integrated with the final form of the Lucene tickets before delving further. 
>> Hopefully this week I can start on a patch that does that.
>>
>> On Tue, May 11, 2021 at 10:25 AM Adrien Grand  wrote:
>>>
>>> I would like to backport LUCENE-9827 before we release 8.9, a performance 
>>> regression to stored fields merges. I'll work on this as soon as possible.
>>>
>>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand  wrote:

 +1

 Mayya, are you volunteering to be the release manager?

 Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya 
  a écrit :
>
> +1
>
> On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova 
>  wrote:
>>
>> Hello everyone,
>> I was wondering if we can have a 8.9.0 release. It has been more than 3 
>> months since 8.8.0 was released.
>> 8.9.0 doesn't need to be the last release in the 8.x series.
>>
>> Thanks.
>>>
>>>
>>>
>>> --
>>> Adrien
>>
>>
>>
>> --
>> http://www.needhamsoftware.com (work)
>> http://www.the111shift.com (play)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



RE: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-12 Thread Uwe Schindler
Hi,

 

all fine also from my side. Thanks to Smoketester I fixed a bug in the Maven 
Metadata. This is the first 8.x release where the Maven Checks were running 
correctly. As far from my side this had no impact on users of Lucene/Solr from 
Maven Central, but due to the change to HTTPS-only for Maven Central our Checks 
were not working anymore – the Maven build itsself was broken, too.

 

We now only publish metadata on Maven Central and no build logic anymore. But 
all is checked and dependency versions are fixed like with Palantir in main 
branch.

 

Nevertheless, it would be a good idea to build you own Solr plugin / Lucene 
project pointing to the snapshot artifacts 8.9-SNAPSHOT just as a test. I did 
it for several of my projects and they passed.

 

Uwe

 

-

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: u...@thetaphi.de

 

From: Jan Høydahl  
Sent: Wednesday, May 12, 2021 10:21 AM
To: dev@lucene.apache.org
Subject: Re: Release Lucene/Solr 8.9.0 should we have it soon

 

+1 to a 8.9 release

 

I'm working on a few Solr backports that will land soon.

 

Jan





12. mai 2021 kl. 09:46 skrev Peter Gromov mailto:peter.gro...@jetbrains.com.INVALID> >:

 

I can try backporting Hunspell improvements 
(https://issues.apache.org/jira/browse/LUCENE-9687) to 8.x, unless you think 
it's too large a change.

 

On Tue, May 11, 2021 at 7:29 PM Mayya Sharipova 
mailto:mayya.sharip...@elastic.co.invalid> 
> wrote:

Thanks everyone,

 

Adrien, I  am happy to try to be a release manager for this release.

 

Adrien, and Gus, please let me know when your changes are merged to 8.x

 

 

 

On Tue, May 11, 2021 at 10:38 AM Gus Heck mailto:gus.h...@gmail.com> > wrote:

I'm also looking to find time to get 
https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x. I've 
recently completed the back port of 2/3 of the lucene tickets that are related, 
and hope to work on the third tomorrow 

 

I had some feedback there, but I think folks were waiting for the version 
integrated with the final form of the Lucene tickets before delving further. 
Hopefully this week I can start on a patch that does that.

 

On Tue, May 11, 2021 at 10:25 AM Adrien Grand mailto:jpou...@gmail.com> > wrote:

I would like to backport LUCENE-9827 
<https://issues.apache.org/jira/browse/LUCENE-9827>  before we release 8.9, a 
performance regression to stored fields merges. I'll work on this as soon as 
possible.

 

On Thu, May 6, 2021 at 10:28 PM Adrien Grand mailto:jpou...@gmail.com> > wrote:

+1

 

Mayya, are you volunteering to be the release manager?

Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya mailto:ichattopadhy...@gmail.com> > a écrit :

+1

 

On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova 
mailto:mayya.sharip...@elastic.co.invalid> 
> wrote:

Hello everyone,

I was wondering if we can have a 8.9.0 release. It has been more than 3 months 
since 8.8.0 was released.

8.9.0 doesn't need to be the last release in the 8.x series.

 

Thanks.




 

-- 

Adrien




 

-- 

http://www.needhamsoftware.com <http://www.needhamsoftware.com/>  (work)

http://www.the111shift.com <http://www.the111shift.com/>  (play)

 



Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-12 Thread Jan Høydahl
+1 to a 8.9 release

I'm working on a few Solr backports that will land soon.

Jan

> 12. mai 2021 kl. 09:46 skrev Peter Gromov 
> :
> 
> I can try backporting Hunspell improvements 
> (https://issues.apache.org/jira/browse/LUCENE-9687 
> ) to 8.x, unless you think 
> it's too large a change.
> 
> On Tue, May 11, 2021 at 7:29 PM Mayya Sharipova 
>  wrote:
> Thanks everyone,
> 
> Adrien, I  am happy to try to be a release manager for this release.
> 
> Adrien, and Gus, please let me know when your changes are merged to 8.x
> 
> 
> 
> On Tue, May 11, 2021 at 10:38 AM Gus Heck  > wrote:
> I'm also looking to find time to get 
> https://issues.apache.org/jira/browse/SOLR-14597 
>  into some sort of 8x. I've 
> recently completed the back port of 2/3 of the lucene tickets that are 
> related, and hope to work on the third tomorrow 
> 
> I had some feedback there, but I think folks were waiting for the version 
> integrated with the final form of the Lucene tickets before delving further. 
> Hopefully this week I can start on a patch that does that.
> 
> On Tue, May 11, 2021 at 10:25 AM Adrien Grand  > wrote:
> I would like to backport LUCENE-9827 
>  before we release 8.9, a 
> performance regression to stored fields merges. I'll work on this as soon as 
> possible.
> 
> On Thu, May 6, 2021 at 10:28 PM Adrien Grand  > wrote:
> +1
> 
> Mayya, are you volunteering to be the release manager?
> 
> Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya  > a écrit :
> +1
> 
> On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova 
>  wrote:
> Hello everyone,
> I was wondering if we can have a 8.9.0 release. It has been more than 3 
> months since 8.8.0 was released.
> 8.9.0 doesn't need to be the last release in the 8.x series.
> 
> Thanks.
> 
> 
> -- 
> Adrien
> 
> 
> -- 
> http://www.needhamsoftware.com  (work)
> http://www.the111shift.com  (play)



Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-12 Thread Peter Gromov
I can try backporting Hunspell improvements (
https://issues.apache.org/jira/browse/LUCENE-9687) to 8.x, unless you think
it's too large a change.

On Tue, May 11, 2021 at 7:29 PM Mayya Sharipova
 wrote:

> Thanks everyone,
>
> Adrien, I  am happy to try to be a release manager for this release.
>
> Adrien, and Gus, please let me know when your changes are merged to 8.x
>
>
>
> On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
>
>> I'm also looking to find time to get
>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
>> I've recently completed the back port of 2/3 of the lucene tickets that are
>> related, and hope to work on the third tomorrow
>>
>> I had some feedback there, but I think folks were waiting for the version
>> integrated with the final form of the Lucene tickets before delving
>> further. Hopefully this week I can start on a patch that does that.
>>
>> On Tue, May 11, 2021 at 10:25 AM Adrien Grand  wrote:
>>
>>> I would like to backport LUCENE-9827
>>>  before we release
>>> 8.9, a performance regression to stored fields merges. I'll work on this as
>>> soon as possible.
>>>
>>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand  wrote:
>>>
 +1

 Mayya, are you volunteering to be the release manager?

 Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
 ichattopadhy...@gmail.com> a écrit :

> +1
>
> On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova
>  wrote:
>
>> Hello everyone,
>> I was wondering if we can have a 8.9.0 release. It has been more than
>> 3 months since 8.8.0 was released.
>> 8.9.0 doesn't need to be the last release in the 8.x series.
>>
>> Thanks.
>>
>
>>>
>>> --
>>> Adrien
>>>
>>
>>
>> --
>> http://www.needhamsoftware.com (work)
>> http://www.the111shift.com (play)
>>
>


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-11 Thread Ishan Chattopadhyaya
Hi Mayya,
How much time would you give us for this release (until feature freeze)? I
have some package manager related changes (that might take a week to fully
build and test) that need to get into 8x so that users can seamlessly
upgrade to 9x. Based on your proposed timeline, I'll work on it immediately
(if there's time), or later (for a potential 8.10 or 8.9.1). A bit caught
up in the covid situation, and AFK (so can't find the JIRA).
Thanks for volunteering,
Ishan

On Tue, May 11, 2021 at 10:59 PM Mayya Sharipova
 wrote:

> Thanks everyone,
>
> Adrien, I  am happy to try to be a release manager for this release.
>
> Adrien, and Gus, please let me know when your changes are merged to 8.x
>
>
>
> On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:
>
>> I'm also looking to find time to get
>> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
>> I've recently completed the back port of 2/3 of the lucene tickets that are
>> related, and hope to work on the third tomorrow
>>
>> I had some feedback there, but I think folks were waiting for the version
>> integrated with the final form of the Lucene tickets before delving
>> further. Hopefully this week I can start on a patch that does that.
>>
>> On Tue, May 11, 2021 at 10:25 AM Adrien Grand  wrote:
>>
>>> I would like to backport LUCENE-9827
>>>  before we release
>>> 8.9, a performance regression to stored fields merges. I'll work on this as
>>> soon as possible.
>>>
>>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand  wrote:
>>>
 +1

 Mayya, are you volunteering to be the release manager?

 Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
 ichattopadhy...@gmail.com> a écrit :

> +1
>
> On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova
>  wrote:
>
>> Hello everyone,
>> I was wondering if we can have a 8.9.0 release. It has been more than
>> 3 months since 8.8.0 was released.
>> 8.9.0 doesn't need to be the last release in the 8.x series.
>>
>> Thanks.
>>
>
>>>
>>> --
>>> Adrien
>>>
>>
>>
>> --
>> http://www.needhamsoftware.com (work)
>> http://www.the111shift.com (play)
>>
>


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-11 Thread Mayya Sharipova
Thanks everyone,

Adrien, I  am happy to try to be a release manager for this release.

Adrien, and Gus, please let me know when your changes are merged to 8.x



On Tue, May 11, 2021 at 10:38 AM Gus Heck  wrote:

> I'm also looking to find time to get
> https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x.
> I've recently completed the back port of 2/3 of the lucene tickets that are
> related, and hope to work on the third tomorrow
>
> I had some feedback there, but I think folks were waiting for the version
> integrated with the final form of the Lucene tickets before delving
> further. Hopefully this week I can start on a patch that does that.
>
> On Tue, May 11, 2021 at 10:25 AM Adrien Grand  wrote:
>
>> I would like to backport LUCENE-9827
>>  before we release
>> 8.9, a performance regression to stored fields merges. I'll work on this as
>> soon as possible.
>>
>> On Thu, May 6, 2021 at 10:28 PM Adrien Grand  wrote:
>>
>>> +1
>>>
>>> Mayya, are you volunteering to be the release manager?
>>>
>>> Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
>>> ichattopadhy...@gmail.com> a écrit :
>>>
 +1

 On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova
  wrote:

> Hello everyone,
> I was wondering if we can have a 8.9.0 release. It has been more than
> 3 months since 8.8.0 was released.
> 8.9.0 doesn't need to be the last release in the 8.x series.
>
> Thanks.
>

>>
>> --
>> Adrien
>>
>
>
> --
> http://www.needhamsoftware.com (work)
> http://www.the111shift.com (play)
>


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-11 Thread Gus Heck
I'm also looking to find time to get
https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x. I've
recently completed the back port of 2/3 of the lucene tickets that are
related, and hope to work on the third tomorrow

I had some feedback there, but I think folks were waiting for the version
integrated with the final form of the Lucene tickets before delving
further. Hopefully this week I can start on a patch that does that.

On Tue, May 11, 2021 at 10:25 AM Adrien Grand  wrote:

> I would like to backport LUCENE-9827
>  before we release
> 8.9, a performance regression to stored fields merges. I'll work on this as
> soon as possible.
>
> On Thu, May 6, 2021 at 10:28 PM Adrien Grand  wrote:
>
>> +1
>>
>> Mayya, are you volunteering to be the release manager?
>>
>> Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com> a écrit :
>>
>>> +1
>>>
>>> On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova
>>>  wrote:
>>>
 Hello everyone,
 I was wondering if we can have a 8.9.0 release. It has been more than 3
 months since 8.8.0 was released.
 8.9.0 doesn't need to be the last release in the 8.x series.

 Thanks.

>>>
>
> --
> Adrien
>


-- 
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-11 Thread Adrien Grand
I would like to backport LUCENE-9827
 before we release 8.9,
a performance regression to stored fields merges. I'll work on this as soon
as possible.

On Thu, May 6, 2021 at 10:28 PM Adrien Grand  wrote:

> +1
>
> Mayya, are you volunteering to be the release manager?
>
> Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> a écrit :
>
>> +1
>>
>> On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova
>>  wrote:
>>
>>> Hello everyone,
>>> I was wondering if we can have a 8.9.0 release. It has been more than 3
>>> months since 8.8.0 was released.
>>> 8.9.0 doesn't need to be the last release in the 8.x series.
>>>
>>> Thanks.
>>>
>>

-- 
Adrien


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-06 Thread Adrien Grand
+1

Mayya, are you volunteering to be the release manager?

Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya 
a écrit :

> +1
>
> On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova
>  wrote:
>
>> Hello everyone,
>> I was wondering if we can have a 8.9.0 release. It has been more than 3
>> months since 8.8.0 was released.
>> 8.9.0 doesn't need to be the last release in the 8.x series.
>>
>> Thanks.
>>
>


Re: Release Lucene/Solr 8.9.0 should we have it soon

2021-05-06 Thread Ishan Chattopadhyaya
+1

On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova
 wrote:

> Hello everyone,
> I was wondering if we can have a 8.9.0 release. It has been more than 3
> months since 8.8.0 was released.
> 8.9.0 doesn't need to be the last release in the 8.x series.
>
> Thanks.
>