[nant-dev] Fileset / task change
Hi Matthew, I've had another look at how our task is working right now, and the more I think of it, the more I'm convinced that we should change it to match the Ant task. Right now, we remove all directories that are matched by the fileset. But this does not respect any excludes. When you have the following directory structure : \ test\ web.config subdir\ web.config And you'd execute the following task : Then the \test\subdir would be completely removed (although, there's a web.config file in there that should not be deleted), as that directory is returned in the DirectoryNames collection of the fileset, and alls path returned in that collection are completely removed by the task. Instead, it might be better to first remove all matching files, and then remove all matching directories that are empty (and do this only if "includeemptydirs" is set to true). What do you think ? Gert --- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset scanning speed-ups in CVS
Scott Hernandez wrote: Good work. That is one that needed to be optimized :) Do you have profiler stats/results on other most called, or time most spent in, functions? It would be good to list them so anyone out there could step up to challenge themselves with optimizing those functions. Just an idea... Unfortunately, I haven't hooked up the "copy to clipboard" functionality in nprof, so all I can provide is a screenshot. ;) I can probably summarize the trouble spots by hand- the NAnt-bootstrap build would be a good candidate. My goal right now is to catch the low-hanging fruit for a general build to match (or exceed) VS.NET's compilation speed wherever possible. Matt. - Original Message - From: "Matthew Mastracci" <[EMAIL PROTECTED]> I just checked in a change to fileset scanning that eliminates a large chunk of time (checked via profiling) during many of the common NAnt operations. One of the biggest losers on the profiling run was Regex.Match(), called many, many times during a build. The new code replaces a good proportion of these with CompareInfo.Compare() calls, reducing the overhead dramatically. Instead of converting all includes to regexes, the new code will only convert those that actually contain wildcards. begin:vcard fn:Matthew Mastracci n:Mastracci;Matthew org:aclaro Softworks, inc. adr:;;1900 a - 11 St. SE;Calgary;Alberta;T2H 3G2;Canada email;internet:[EMAIL PROTECTED] title:Software Developer tel;work:(403) 299-6612 x-mozilla-html:FALSE url:http://www.aclaro.com version:2.1 end:vcard
Re: [nant-dev] Fileset scanning speed-ups in CVS
Good work. That is one that needed to be optimized :) Do you have profiler stats/results on other most called, or time most spent in, functions? It would be good to list them so anyone out there could step up to challenge themselves with optimizing those functions. Just an idea... - Original Message - From: "Matthew Mastracci" <[EMAIL PROTECTED]> > I just checked in a change to fileset scanning that eliminates a large > chunk of time (checked via profiling) during many of the common NAnt > operations. > > One of the biggest losers on the profiling run was Regex.Match(), called > many, many times during a build. The new code replaces a good > proportion of these with CompareInfo.Compare() calls, reducing the > overhead dramatically. > > Instead of converting all includes to regexes, the new code > will only convert those that actually contain wildcards. --- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] Fileset scanning speed-ups in CVS
I just checked in a change to fileset scanning that eliminates a large chunk of time (checked via profiling) during many of the common NAnt operations. One of the biggest losers on the profiling run was Regex.Match(), called many, many times during a build. The new code replaces a good proportion of these with CompareInfo.Compare() calls, reducing the overhead dramatically. Instead of converting all includes to regexes, the new code will only convert those that actually contain wildcards. Matt. --- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet attribute
Hi, * Gert Driesen wrote on 07.06.2004 (12:37): > Are you using a very recent version of NAnt, as the element was > only recently added. You might want to try the element : Is 25.05.2005 recent enough? But I tried (and got deprecated messages). Nothing changed. I've overseen that the ftpup task runs. And I do not see a difference in handling the fileset. I uploaded the actual code on http://www.livingit.de/downloads/nant-tasks.zip if you want to take a look in it. By the way, I would take responsibility for the ftp task in 0.9 if nobody has already started or any other reasons. My ideas for further changes to the task: * Integrate the both existing tasks (ftpup and ftpdown) to one task. Currently I'm thinking of something like this: * create a script task ftpscript that enables to execute ftp command directly: Just a short question: Can a complete task be marked as obsolete (recognized by NAnt)? -sa -- sa at programmers-world dot com http://www.livingit.de Internet sites: http://www.not2long.net - Make long links short Boomarks online: http://www.mobile-bookmarks.info --- This SF.Net email is sponsored by: GNOME Foundation Hackers Unite! GUADEC: The world's #1 Open Source Desktop Event. GNOME Users and Developers European Conference, 28-30th June in Norway http://2004/guadec.org ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet attribute
Sascha,
Are you using a very recent version of NAnt, as the element was
only recently added. You might want to try the element :
Gert
- Original Message -
From: "Sascha Andres" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Sunday, June 06, 2004 12:01 PM
Subject: Re: [nant-dev] FileSet attribute
> Hi,
>
> currently my code looks like this:
>
> // the binaries property
>
> [BuildElement("binaries")]
> public FileSet binaries {
> get {
> return _binaryFileset;
> } set {
> _binaryFileset = value;
> }
> } // BinaryFileset
>
> The usage:
>
> if (null != _binaryFileset) {
> foreach(string binaryFile in _binaryFileset.FileNames) {
> // ftp transfer
> } // foreach
> } // if
>
> Well, _binaryFileset.Count equals always 0, my buildfile
> looks like this:
>
>
>
>
>
>
>
>
> Besides this, the transfer seems to run smoothly. I decided
> to crete a ftpscript task that works like the script task, a
> code section executed line by line (well, that differs from
> the script task ;)).
>
> -sa
>
> --
> sa at programmers-world dot com http://www.livingit.de
> Internet sites:
> http://www.not2long.net - Make long links short
> Boomarks online: http://www.mobile-bookmarks.info
>
>
> ---
> This SF.Net email is sponsored by the new InstallShield X.
> From Windows to Linux, servers to mobile, InstallShield X is the one
> installation-authoring solution that does it all. Learn more and
> evaluate today! http://www.installshield.com/Dev2Dev/0504
> ___
> nant-developers mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/nant-developers
>
---
This SF.Net email is sponsored by the new InstallShield X.
>From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet attribute
Hi,
currently my code looks like this:
// the binaries property
[BuildElement("binaries")]
public FileSet binaries {
get {
return _binaryFileset;
} set {
_binaryFileset = value;
}
} // BinaryFileset
The usage:
if (null != _binaryFileset) {
foreach(string binaryFile in _binaryFileset.FileNames) {
// ftp transfer
} // foreach
} // if
Well, _binaryFileset.Count equals always 0, my buildfile
looks like this:
Besides this, the transfer seems to run smoothly. I decided
to crete a ftpscript task that works like the script task, a
code section executed line by line (well, that differs from
the script task ;)).
-sa
--
sa at programmers-world dot com http://www.livingit.de
Internet sites:
http://www.not2long.net - Make long links short
Boomarks online: http://www.mobile-bookmarks.info
---
This SF.Net email is sponsored by the new InstallShield X.
>From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet attribute
Sascha,
You should use the BuildElement attribute :
[BuildElement("binaries")]
public FileSet binaries {
get {
return _binaryFileset;
}
set {
_binaryFileset = value;
}
}
Hope this helps,
Gert
- Original Message -
From: "Sascha Andres" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, June 04, 2004 3:32 PM
Subject: [nant-dev] FileSet attribute
> Hi,
>
> for my ftp tasks I try to introduce two fileset attributes,
> but had no real success until now. Here's how I tried:
>
> // variable:
> private FileSet _binaryFileset = new FileSet();
>
> // property:
> [TaskAttribute("binaries")]
> public FileSet binaries {
> get {
> return _binaryFileset;
> } set {
> _binaryFileset = value;
> }
> } // BinaryFileset
>
> My test file looks like this:
>
>
>
>
>
>
>
> If I set binaries to required, nant says that there is no
> binaries attribute in the ftpup task.
>
> I'm stuck in the code, I mean I see no difference in what is
> done in the touch task. Any hints appreciated,
>
> Sascha
>
> --
> sa at programmers-world dot com http://www.livingit.de
> Internet sites:
> http://www.not2long.net - Make long links short
> Boomarks online: http://www.mobile-bookmarks.info
>
>
> ---
> This SF.Net email is sponsored by the new InstallShield X.
> From Windows to Linux, servers to mobile, InstallShield X is the one
> installation-authoring solution that does it all. Learn more and
> evaluate today! http://www.installshield.com/Dev2Dev/0504
> ___
> nant-developers mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/nant-developers
>
---
This SF.Net email is sponsored by the new InstallShield X.
>From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] FileSet attribute
Hi,
for my ftp tasks I try to introduce two fileset attributes,
but had no real success until now. Here's how I tried:
// variable:
private FileSet _binaryFileset = new FileSet();
// property:
[TaskAttribute("binaries")]
public FileSet binaries {
get {
return _binaryFileset;
} set {
_binaryFileset = value;
}
} // BinaryFileset
My test file looks like this:
If I set binaries to required, nant says that there is no
binaries attribute in the ftpup task.
I'm stuck in the code, I mean I see no difference in what is
done in the touch task. Any hints appreciated,
Sascha
--
sa at programmers-world dot com http://www.livingit.de
Internet sites:
http://www.not2long.net - Make long links short
Boomarks online: http://www.mobile-bookmarks.info
---
This SF.Net email is sponsored by the new InstallShield X.
>From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
- Original Message - From: "Ian MacLean" <[EMAIL PROTECTED]> To: "Gert Driesen" <[EMAIL PROTECTED]> Cc: "Scott Hernandez" <[EMAIL PROTECTED]>; "Clayton Harbour" <[EMAIL PROTECTED]>; "Nant-Developers (E-Mail)" <[EMAIL PROTECTED]> Sent: Monday, May 17, 2004 11:49 AM Subject: Re: [nant-dev] fileset deprecations > Gert Driesen wrote: > > >>>A lot of tasks (I think) override InitializeTask to just perform checks > >>> > >>> > >... > > > > > >>> <> > >>> We could ofcourse add a virtual method called ValidateTask method > >>> that tasks > >>> should use for performing additional checks, that would be more > >>> clear ... > >> > I'm pretty sure that was the purpose of the InitializeTask method. What > would be the benefit of the extra method and how would it InitializeTask is being passed the XML node used to initialize the task, and I don't think this is a good idea ...Unless overrriding this method would override the initialization of the task, but that isn't the case ... So the name hasn't been chosen wel (in my opinion, ... I think ;-)) ... > its just a proposal - I put it out there to see what people think. Don't > worry I'm not going to go and commit it in the next few minutes :) I know, and I wasn't worried about that I know you better than that ;) Gert --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
Gert Driesen wrote:
A lot of tasks (I think) override InitializeTask to just perform checks
...
<>
We could ofcourse add a virtual method called ValidateTask method
that tasks
should use for performing additional checks, that would be more
clear ...
I'm pretty sure that was the purpose of the InitializeTask method. What
would be the benefit of the extra method and how would it
<>This method would be called by the Execute method (so it would also be
called when constructing task instances in code)
I don't have time to think about this right now and we should definitely
think it through thoroughly before making API changes ...
sure - thats a given.
<>
Ok then. How about other attributes that would go on classes that have
customised checking.
[CustomElements("foo,bar")]
[CustomAttributes("x,y,y")]
and the scanner would know to flag an error if there are
elements/attributes not specified in those attributes.
So on the ndoc task would have:
[CustomElements("documenters")]
[TaskName("ndoc")]
public class NDocTask : Task {
Yeah, could be interesting, but lets give it some more thought first ...
its just a proposal - I put it out there to see what people think. Don't
worry I'm not going to go and commit it in the next few minutes :)
Ian
---
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
- Original Message -
From: "Ian MacLean" <[EMAIL PROTECTED]>
To: "Gert Driesen" <[EMAIL PROTECTED]>
Cc: "Scott Hernandez" <[EMAIL PROTECTED]>; "Clayton Harbour"
<[EMAIL PROTECTED]>; "Nant-Developers (E-Mail)"
<[EMAIL PROTECTED]>
Sent: Monday, May 17, 2004 9:35 AM
Subject: Re: [nant-dev] fileset deprecations
> Gert Driesen wrote:
>
> >>We could just not do strict checking for any Task/Element that overrides
> >>the InitializeTask method.
> >>
> >>
> >
> >A lot of tasks (I think) override InitializeTask to just perform checks
...
> >
> >
We could ofcourse add a virtual method called ValidateTask method that tasks
should use for performing additional checks, that would be more clear ...
This method would be called by the Execute method (so it would also be
called when constructing task instances in code)
I don't have time to think about this right now and we should definitely
think it through thoroughly before making API changes ...
> Ok then. How about other attributes that would go on classes that have
> customised checking.
>
> [CustomElements("foo,bar")]
> [CustomAttributes("x,y,y")]
>
> and the scanner would know to flag an error if there are
> elements/attributes not specified in those attributes.
> So on the ndoc task would have:
>
> [CustomElements("documenters")]
> [TaskName("ndoc")]
> public class NDocTask : Task {
Yeah, could be interesting, but lets give it some more thought first ...
Gert
---
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
- Original Message - From: "Ian MacLean" <[EMAIL PROTECTED]> To: "Gert Driesen" <[EMAIL PROTECTED]> Cc: "Scott Hernandez" <[EMAIL PROTECTED]>; "Clayton Harbour" <[EMAIL PROTECTED]>; "Nant-Developers (E-Mail)" <[EMAIL PROTECTED]> Sent: Monday, May 17, 2004 9:37 AM Subject: Re: [nant-dev] fileset deprecations > Gert Driesen wrote: > > > > >Not for extra attributes/elements, no ... > > > > > >>Another option is to have a > >>dedicated switch -strict or -failoninvalidelements ( horrifically long > >>) that will fail only on invalid structure warnings - ie > >>elements/attributes that aren't valid. > >> > >> > > > >Maybe yes, but I think we could also use the warnaserror for both purposes > >... > > > > > > > Fine by me - but I thought you weren't sure that warnaserror was even a > good idea ? Yes, that's true, I'm still not sure how we should implement this ... Does this mean that logging a message with level Error should cause the build to fail ... don't think so ... so we also can't have a build fail when logging a message with level Warning and warnaserror is true ... Gert --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
- Original Message - From: "Ian MacLean" <[EMAIL PROTECTED]> To: "Gert Driesen" <[EMAIL PROTECTED]> Cc: "Scott Hernandez" <[EMAIL PROTECTED]>; "Clayton Harbour" <[EMAIL PROTECTED]>; "Nant-Developers (E-Mail)" <[EMAIL PROTECTED]> Sent: Monday, May 17, 2004 9:08 AM Subject: Re: [nant-dev] fileset deprecations > Gert Driesen wrote: > > > > >I was also thinking about a "warnaserror" switch, similar to what the MS > >compilers have ... But I'm not sure that's a good idea, as every warning > >that is logged would cause a build failure, and we currently even log errors > >without causing a build failure ... Guess we'll have to think about this > >some more ... > > > > > sure but thats what you expect when you use such a switch. yes, definitely ... > We don't even display warnings at the moment do we ? Not for extra attributes/elements, no ... > Another option is to have a > dedicated switch -strict or -failoninvalidelements ( horrifically long > ) that will fail only on invalid structure warnings - ie > elements/attributes that aren't valid. Maybe yes, but I think we could also use the warnaserror for both purposes ... > >It would ofcourse be great to actually output a summary at the end of the > >build, something like : > > > >Build succeeded, with 5 warnings. > > > > > > > +1. Shouldn't be too hard to maintain a collection of warnings. No definitely not ... > >>But I would suggest that you go through and run > >>a lot of tests before you do this. There are still some tasks/types that > >>correctly do their own process that this method may flag as > >>errors. As I remember. I went through a cleanup a lot of them a year ago, > >>but much has changed since then. > >> > >> > > > >the NDoc task would be one of those ... I think you added a ProcessXml > >property or something right ? > > > > > > > We could just not do strict checking for any Task/Element that overrides > the InitializeTask method. A lot of tasks (I think) override InitializeTask to just perform checks ... Gert --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
Gert Driesen wrote:
We could just not do strict checking for any Task/Element that overrides
the InitializeTask method.
A lot of tasks (I think) override InitializeTask to just perform checks ...
Ok then. How about other attributes that would go on classes that have
customised checking.
[CustomElements("foo,bar")]
[CustomAttributes("x,y,y")]
and the scanner would know to flag an error if there are
elements/attributes not specified in those attributes.
So on the ndoc task would have:
[CustomElements("documenters")]
[TaskName("ndoc")]
public class NDocTask : Task {
Ian
--
Ian MacLean, Developer,
ActiveState, a division of Sophos
http://www.ActiveState.com
---
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
___
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
Gert Driesen wrote: Not for extra attributes/elements, no ... Another option is to have a dedicated switch -strict or -failoninvalidelements ( horrifically long ) that will fail only on invalid structure warnings - ie elements/attributes that aren't valid. Maybe yes, but I think we could also use the warnaserror for both purposes ... Fine by me - but I thought you weren't sure that warnaserror was even a good idea ? Ian --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
Gert Driesen wrote: I was also thinking about a "warnaserror" switch, similar to what the MS compilers have ... But I'm not sure that's a good idea, as every warning that is logged would cause a build failure, and we currently even log errors without causing a build failure ... Guess we'll have to think about this some more ... sure but thats what you expect when you use such a switch. We don't even display warnings at the moment do we ? Another option is to have a dedicated switch -strict or -failoninvalidelements ( horrifically long ) that will fail only on invalid structure warnings - ie elements/attributes that aren't valid. It would ofcourse be great to actually output a summary at the end of the build, something like : Build succeeded, with 5 warnings. +1. Shouldn't be too hard to maintain a collection of warnings. But I would suggest that you go through and run a lot of tests before you do this. There are still some tasks/types that correctly do their own process that this method may flag as errors. As I remember. I went through a cleanup a lot of them a year ago, but much has changed since then. the NDoc task would be one of those ... I think you added a ProcessXml property or something right ? We could just not do strict checking for any Task/Element that overrides the InitializeTask method. Ian --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
- Original Message - From: "Scott Hernandez" <[EMAIL PROTECTED]> To: "Clayton Harbour" <[EMAIL PROTECTED]> Cc: "Nant-Developers (E-Mail)" <[EMAIL PROTECTED]> Sent: Sunday, May 16, 2004 11:15 PM Subject: Re: [nant-dev] fileset deprecations > +1 on co-existence, of include+includes, for a release or two, but totally > removal by 1.0. I agree > > As for the "strict" enforcement of only declared elements and properties for > tasks/types, I had done some work on that a long time ago. Take a look at > the Element.AttributeConfigurator.InitilizeElement() code at the end of the > method. You will see a section that say "#region Check Tracking Collections > for Attribute and Element use" that emits the warnings. You could change > those to fail with a switch. I was also thinking about a "warnaserror" switch, similar to what the MS compilers have ... But I'm not sure that's a good idea, as every warning that is logged would cause a build failure, and we currently even log errors without causing a build failure ... Guess we'll have to think about this some more ... It would ofcourse be great to actually output a summary at the end of the build, something like : Build succeeded, with 5 warnings. > But I would suggest that you go through and run > a lot of tests before you do this. There are still some tasks/types that > correctly do their own process that this method may flag as > errors. As I remember. I went through a cleanup a lot of them a year ago, > but much has changed since then. the NDoc task would be one of those ... I think you added a ProcessXml property or something right ? Gert --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
+1 on co-existence, of include+includes, for a release or two, but totally removal by 1.0. As for the "strict" enforcement of only declared elements and properties for tasks/types, I had done some work on that a long time ago. Take a look at the Element.AttributeConfigurator.InitilizeElement() code at the end of the method. You will see a section that say "#region Check Tracking Collections for Attribute and Element use" that emits the warnings. You could change those to fail with a switch. But I would suggest that you go through and run a lot of tests before you do this. There are still some tasks/types that correctly do their own process that this method may flag as errors. As I remember. I went through a cleanup a lot of them a year ago, but much has changed since then. For now, you can run with warnings logged and see what is caught. > From: "Clayton Harbour" [EMAIL PROTECTED] > Hi, > > > the naming is clearer I suppose but there is a certain amount of > > > inertia > > > - there are a lot of build files out there wil the current naming. > > > > I know, that why I'm asking ... we'll see how others respond > > ... we could ofcourse have both of them coexist, and then > > deprecate includes/excludes later ... > > I would prefer it if the two co-existed for a release (or two even), > with the element deprecated (and warnings during the build > process). It gives people fair enough warning before their build files > stop working. > > Also, there was also talk about adding a "strict" switch to the > commandline awhile back which. This might be a good notification > feature when this goes away. Has anyone done any work on this? I could > probably take a stab at it if someone gave me a high level on the > project load process. --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] fileset deprecations
Hi, > > the naming is clearer I suppose but there is a certain amount of > > inertia > > - there are a lot of build files out there wil the current naming. > > I know, that why I'm asking ... we'll see how others respond > ... we could ofcourse have both of them coexist, and then > deprecate includes/excludes later ... I would prefer it if the two co-existed for a release (or two even), with the element deprecated (and warnings during the build process). It gives people fair enough warning before their build files stop working. Also, there was also talk about adding a "strict" switch to the commandline awhile back which. This might be a good notification feature when this goes away. Has anyone done any work on this? I could probably take a stab at it if someone gave me a high level on the project load process. Cheers, Clayton --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id%62&alloc_ida84&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
- Original Message - From: "Ian MacLean" <[EMAIL PROTECTED]> To: "Gert Driesen" <[EMAIL PROTECTED]> Cc: "Nant-Developers (E-Mail)" <[EMAIL PROTECTED]> Sent: Sunday, May 16, 2004 11:15 AM Subject: Re: [nant-dev] fileset deprecations > Gert Driesen wrote: > > >Hi, > > > >What do you think about deprecating the following fileset elements : > > > > > > > > > >and replacing them by > > > > > > > > > > > the naming is clearer I suppose but there is a certain amount of inertia > - there are a lot of build files out there wil the current naming. I know, that why I'm asking ... we'll see how others respond ... we could ofcourse have both of them coexist, and then deprecate includes/excludes later ... > >and adding excludes and includes attributes on the fileset element (to allow > >a list of patterns to be stored in a property). > > > > > > > how would these interact with the nested child elements ? would the > contents of the 'includes' attribute just be added to the > child element ? yeps, just like and just add to the includes list (not the element though, the elements are not stored at all in the fileset) Gert --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset deprecations
Gert Driesen wrote: Hi, What do you think about deprecating the following fileset elements : and replacing them by the naming is clearer I suppose but there is a certain amount of inertia - there are a lot of build files out there wil the current naming. and adding excludes and includes attributes on the fileset element (to allow a list of patterns to be stored in a property). how would these interact with the nested child elements ? would the contents of the 'includes' attribute just be added to the child element ? Ian --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] fileset deprecations
Hi, What do you think about deprecating the following fileset elements : and replacing them by and adding excludes and includes attributes on the fileset element (to allow a list of patterns to be stored in a property). Note: these deprecated elements would still work as they do today, however a message will be output in the build log. That way our fileset would also better match that of Ant (not that this is a goal as such). I already deprecated and replaced it with a element to have it match our naming conventions (and Ant). Gert --- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] Fileset include required WAS: problem with ASIS attribute on source file list in CSC task
Yeah, now the only problems is to implement it. :) (remember, it needs to efficient too) We are accepting patches on this one! Will someone step up to the plate? I've moved this into the dev list. - Original Message - From: "Hearn, Bruce" <[EMAIL PROTECTED]> > Scott, > > I think you nailed it. The addition of a "failonmissing" attribute > would be quite helpful. > > If you try to build using the VS.NET IDE, the build will fail if a file > is missing. In an automated build process I want to be able to > implement the same behavior. This allows the build to be more > consistent between the IDE and NANT. I've seen from practice that when > there are subtle differences between 2 build environments, many hours > can be lost in tracking down an issue. > > Thanks, > > Bruce > > -Original Message- > From: Scott Hernandez [mailto:[EMAIL PROTECTED] > Sent: Saturday, May 01, 2004 11:15 AM > To: Gert Driesen > Cc: Hearn, Bruce; [EMAIL PROTECTED] > Subject: Re: [Nant-users] RE: problem with ASIS attribute on source file > list in CSC task > > It would definitely be a nice feature to say that a certain > is > required and should throw an error if no match on the filesystem is > found. > But no, this should not be the default behavior. The problem in the past > has > been with wildcard expressions and the fileset implementation not easily > allowing for a check that a wildcard statement results in filesystem > hit. > Adding the 'failonempty' attribute to the seems like a > stop-gap > measure to ensure this kind of checking. > > I think this is where Bruce is coming from. Bruce? > > Here is an example: > > > > > > > > > - Original Message - > From: "Gert Driesen" <[EMAIL PROTECTED]> > > > - Original Message - > > > From: "Hearn, Bruce" <[EMAIL PROTECTED]> > > > Hi Gert, > > > a) if a non-existent file is included in the source list, it > compiles > > > anyway without error or warning. > > > > The sources to compile are specific using a fileset, which actually > uses > > pattern matching and scanning to determine the matching files. A file > that > > doesn't exist will therefor not be part of the resulting matches. I > don't > > think we will be changing this. Ian, Scott : what do you think ? > Should > we > > throw a build error when the includes name does not contain a wildcard > > pattern, and does not exist ? --- This SF.Net email is sponsored by Sleepycat Software Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to deliver higher performing products faster, at low TCO. http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] fileset and
Hello, I have been trying to put a fileset with an id into a separate build file and include it without success. In the main build file it can find the fileset by ID using refid but it seems the fileset is empty. If I copy the fileset into the main build file, it works correctly. I am using the nightly build from 2/4/04. Main build file: Included excludedprojects.xml Thanks. -Brandon --- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet
It is also possibility. I like this feature becouse it enables this: -first build list of files somehow. e.g. by iterating by foreach and add it to string -use this string as input to fileset. ... Maybe this could be done in easier/different way? Martin - Original Message - From: "Gert Driesen" <[EMAIL PROTECTED]> To: "Martin Aliger" <[EMAIL PROTECTED]>; "! nant" <[EMAIL PROTECTED]> Sent: Tuesday, September 09, 2003 6:04 PM Subject: Re: [nant-dev] FileSet > Just my personal opinion, but I'm not sure I like this ... > > It is just a personal preference, I do know Ant supports it (but I don't > think it's used much) ... > > I prefer using multiple elements, that way it's easier to add xml > comments to each elements. > > I would rather fix this in the docs ... Ian, what do you think ? > > Gert > > > - Original Message - > From: "Martin Aliger" <[EMAIL PROTECTED]> > To: "! nant" <[EMAIL PROTECTED]> > Sent: Tuesday, September 09, 2003 5:27 PM > Subject: [nant-dev] FileSet > > > > There is patch to support very nice feature as it is described in docs: > > > > FileSet. includes: comma-separated list of patterns of files that > must > > be included > > > > Martin > > > > > --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet
Just my personal opinion, but I'm not sure I like this ... It is just a personal preference, I do know Ant supports it (but I don't think it's used much) ... I prefer using multiple elements, that way it's easier to add xml comments to each elements. I would rather fix this in the docs ... Ian, what do you think ? Gert - Original Message - From: "Martin Aliger" <[EMAIL PROTECTED]> To: "! nant" <[EMAIL PROTECTED]> Sent: Tuesday, September 09, 2003 5:27 PM Subject: [nant-dev] FileSet > There is patch to support very nice feature as it is described in docs: > > FileSet. includes: comma-separated list of patterns of files that must > be included > > Martin > --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] FileSet
There is patch to support very nice feature as it is described in docs: FileSet. includes: comma-separated list of patterns of files that must be included Martin fileset.patch Description: Binary data
RE: [nant-dev] Fileset references
> I forgot to make the filest in zip task settable - shold be fixed now. You added a unit test for this before fixing it, right? :) John C Barstow --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset references
Gius, I forgot to make the filest in zip task settable - shold be fixed now. Ian Ian, I've a target like the following that simply initializes a file set: ... ... ... and then another target that uses it: ... Well, the resulting zip archive is empty. Am I missing something? Gius_. --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] Fileset references
Ian, I've a target like the following that simply initializes a file set: ... ... ... and then another target that uses it: ... Well, the resulting zip archive is empty. Am I missing something? Gius_. -- Giuseppe Greco ::agamura:: phone: +41 (0)91 604 67 65 mobile: +41 (0)76 390 60 32 email: [EMAIL PROTECTED] web:www.agamura.com --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset references
On Sat, 2003-06-28 at 16:30, Ian MacLean wrote: > cool. I'm just adding support for target level now. Its pretty > straightforward. Super! Please, as soon as you commit this into CVS, let me know... Gius_. > > Ian > > >On Sat, 2003-06-28 at 16:15, Ian MacLean wrote: > > > > > >>windows or linux ? - is your fileset definition at the project level ? > >>fileset definitions at target level are not supported right now. > >> > >> > > > >A-ha, that's the problem... I'm trying to use fileset definitions at > >target level... > > > >Gius_. > > > > > > > >>Ian > >> > >> > >> > >>>On Sat, 2003-06-28 at 16:10, Ian MacLean wrote: > >>> > >>> > >>> > >>> > Its definately in cvs. I've done a clean check out into a seperate > directory and the example below works fine. Are you seeing errors ? What > isn't working ? > > > > > >>>NAnt simply says "Unknown task ". > >>> > >>>Gius_. > >>> > >>> > >>> > >>> > >>> > Ian > > > > > > >Ian, > > > >On Tue, 2003-06-24 at 11:35, Ian MacLean wrote: > > > > > > > > > > > > > >>fileset references are done. I still need to add some unit tests and > >>polish a few things but its all working. > >> > >>try somthing like the following : > >> > >> > >> > >> > >> > >> > >> > >> > >> > >>There is now a general framework for referencable types. Its only > >>implemented for filesets right now. > >> > >> > >> > >> > >> > >> > >Is that on CVS? > >It doesn't seem so... > > > >Gius_. > > > > > > > > > > > > > > > >>Ian > >> > >> > >> > >> > >>--- > >>This SF.Net email is sponsored by: INetU > >>Attention Web Developers & Consultants: Become An INetU Hosting Partner. > >>Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! > >>INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php > >>___ > >>Nant-developers mailing list > >>[EMAIL PROTECTED] > >>https://lists.sourceforge.net/lists/listinfo/nant-developers > >> > >> > >> > >> > >> > >> -- Giuseppe Greco ::agamura:: phone: +41 (0)91 604 67 65 mobile: +41 (0)76 390 60 32 email: [EMAIL PROTECTED] web:www.agamura.com --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset references
cool. I'm just adding support for target level now. Its pretty straightforward. Ian On Sat, 2003-06-28 at 16:15, Ian MacLean wrote: windows or linux ? - is your fileset definition at the project level ? fileset definitions at target level are not supported right now. A-ha, that's the problem... I'm trying to use fileset definitions at target level... Gius_. Ian On Sat, 2003-06-28 at 16:10, Ian MacLean wrote: Its definately in cvs. I've done a clean check out into a seperate directory and the example below works fine. Are you seeing errors ? What isn't working ? NAnt simply says "Unknown task ". Gius_. Ian Ian, On Tue, 2003-06-24 at 11:35, Ian MacLean wrote: fileset references are done. I still need to add some unit tests and polish a few things but its all working. try somthing like the following : There is now a general framework for referencable types. Its only implemented for filesets right now. Is that on CVS? It doesn't seem so... Gius_. Ian --- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset references
On Sat, 2003-06-28 at 16:15, Ian MacLean wrote: > windows or linux ? - is your fileset definition at the project level ? > fileset definitions at target level are not supported right now. A-ha, that's the problem... I'm trying to use fileset definitions at target level... Gius_. > > Ian > > >On Sat, 2003-06-28 at 16:10, Ian MacLean wrote: > > > > > >>Its definately in cvs. I've done a clean check out into a seperate > >>directory and the example below works fine. Are you seeing errors ? What > >>isn't working ? > >> > >> > > > >NAnt simply says "Unknown task ". > > > >Gius_. > > > > > > > >>Ian > >> > >> > >> > >>>Ian, > >>> > >>>On Tue, 2003-06-24 at 11:35, Ian MacLean wrote: > >>> > >>> > >>> > >>> > fileset references are done. I still need to add some unit tests and > polish a few things but its all working. > > try somthing like the following : > > > > > > > > > > There is now a general framework for referencable types. Its only > implemented for filesets right now. > > > > > >>>Is that on CVS? > >>>It doesn't seem so... > >>> > >>>Gius_. > >>> > >>> > >>> > >>> > >>> > Ian > > > > > --- > This SF.Net email is sponsored by: INetU > Attention Web Developers & Consultants: Become An INetU Hosting Partner. > Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! > INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php > ___ > Nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers > > > > -- Giuseppe Greco ::agamura:: phone: +41 (0)91 604 67 65 mobile: +41 (0)76 390 60 32 email: [EMAIL PROTECTED] web:www.agamura.com --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset references
windows or linux ? - is your fileset definition at the project level ? fileset definitions at target level are not supported right now. Ian On Sat, 2003-06-28 at 16:10, Ian MacLean wrote: Its definately in cvs. I've done a clean check out into a seperate directory and the example below works fine. Are you seeing errors ? What isn't working ? NAnt simply says "Unknown task ". Gius_. Ian Ian, On Tue, 2003-06-24 at 11:35, Ian MacLean wrote: fileset references are done. I still need to add some unit tests and polish a few things but its all working. try somthing like the following : There is now a general framework for referencable types. Its only implemented for filesets right now. Is that on CVS? It doesn't seem so... Gius_. Ian --- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset references
On Sat, 2003-06-28 at 16:10, Ian MacLean wrote: > Its definately in cvs. I've done a clean check out into a seperate > directory and the example below works fine. Are you seeing errors ? What > isn't working ? NAnt simply says "Unknown task ". Gius_. > Ian > > >Ian, > > > >On Tue, 2003-06-24 at 11:35, Ian MacLean wrote: > > > > > >>fileset references are done. I still need to add some unit tests and > >>polish a few things but its all working. > >> > >>try somthing like the following : > >> > >> > >> > >> > >> > >> > >> > >> > >> > >>There is now a general framework for referencable types. Its only > >>implemented for filesets right now. > >> > >> > > > >Is that on CVS? > >It doesn't seem so... > > > >Gius_. > > > > > > > >>Ian > >> > >> > >> > >> > >>--- > >>This SF.Net email is sponsored by: INetU > >>Attention Web Developers & Consultants: Become An INetU Hosting Partner. > >>Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! > >>INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php > >>___ > >>Nant-developers mailing list > >>[EMAIL PROTECTED] > >>https://lists.sourceforge.net/lists/listinfo/nant-developers > >> > >> -- Giuseppe Greco ::agamura:: phone: +41 (0)91 604 67 65 mobile: +41 (0)76 390 60 32 email: [EMAIL PROTECTED] web:www.agamura.com --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset references
Its definately in cvs. I've done a clean check out into a seperate directory and the example below works fine. Are you seeing errors ? What isn't working ? Ian Ian, On Tue, 2003-06-24 at 11:35, Ian MacLean wrote: fileset references are done. I still need to add some unit tests and polish a few things but its all working. try somthing like the following : There is now a general framework for referencable types. Its only implemented for filesets right now. Is that on CVS? It doesn't seem so... Gius_. Ian --- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] fileset references
Ian, On Tue, 2003-06-24 at 11:35, Ian MacLean wrote: > fileset references are done. I still need to add some unit tests and > polish a few things but its all working. > > try somthing like the following : > > > > > > > > > > There is now a general framework for referencable types. Its only > implemented for filesets right now. Is that on CVS? It doesn't seem so... Gius_. > > Ian > > > > > --- > This SF.Net email is sponsored by: INetU > Attention Web Developers & Consultants: Become An INetU Hosting Partner. > Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! > INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php > ___ > Nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers -- Giuseppe Greco ::agamura:: phone: +41 (0)91 604 67 65 mobile: +41 (0)76 390 60 32 email: [EMAIL PROTECTED] web:www.agamura.com --- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa0016ave/direct;at.asp_061203_01/01 ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] fileset references
Oh way cool !!! Thank you Ian ! - Ants | -Original Message- | From: [EMAIL PROTECTED] | [mailto:[EMAIL PROTECTED] On | Behalf Of Giuseppe Greco | Sent: Tuesday, 24 June, 2003 21:43 | To: Ian MacLean; [EMAIL PROTECTED] | Subject: RE: [nant-dev] fileset references | | | | >-- Original Message -- | >From: Ian MacLean <[EMAIL PROTECTED]> | >To: [EMAIL PROTECTED] | >Subject: [nant-dev] fileset references | >Date: Tue, 24 Jun 2003 18:35:04 +0900 | > | > | >fileset references are done. I still need to add some unit tests and | >polish a few things but its all working. | > | >try somthing like the following : | > | > | > | > | > | > | > | > | > | >There is now a general framework for referencable types. Its only | >implemented for filesets right now. | | Wow, I'll try it immediately! | Thanks, | | Gius_. | | > | >Ian | > | > | > | > | >--- | >This SF.Net email is sponsored by: INetU | >Attention Web Developers & Consultants: Become An INetU Hosting | >Partner. Refer Dedicated Servers. We Manage Them. You Get | 10% Monthly | >Commission! INetU Dedicated Managed Hosting | >http://www.inetu.net/partner/index.php | >___ | >Nant-developers mailing list | >[EMAIL PROTECTED] | >https://lists.sourceforge.net/lists/listinfo/nant-developers | | | | --- | This SF.Net email is sponsored by: INetU | Attention Web Developers & Consultants: Become An INetU | Hosting Partner. Refer Dedicated Servers. We Manage Them. You | Get 10% Monthly Commission! INetU Dedicated Managed Hosting | http://www.inetu.net/partner/index.php | | ___ | nant-developers mailing list [EMAIL PROTECTED] | https://lists.sourceforge.net/lists/listinfo/nant-developers | --- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] fileset references
>-- Original Message -- >From: Ian MacLean <[EMAIL PROTECTED]> >To: [EMAIL PROTECTED] >Subject: [nant-dev] fileset references >Date: Tue, 24 Jun 2003 18:35:04 +0900 > > >fileset references are done. I still need to add some unit tests and >polish a few things but its all working. > >try somthing like the following : > > > > > > > > > >There is now a general framework for referencable types. Its only >implemented for filesets right now. Wow, I'll try it immediately! Thanks, Gius_. > >Ian > > > > >--- >This SF.Net email is sponsored by: INetU >Attention Web Developers & Consultants: Become An INetU Hosting Partner. >Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! >INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php >___ >Nant-developers mailing list >[EMAIL PROTECTED] >https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] fileset references
fileset references are done. I still need to add some unit tests and polish a few things but its all working. try somthing like the following : There is now a general framework for referencable types. Its only implemented for filesets right now. Ian --- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset references
Sorry about the delay Guis - I'm getting to it this week. Ian Hi all, does anybody know how far is the implementation of fileset refereces? (see www.mail-archive.com/[EMAIL PROTECTED]/msg01418.html for more info) Gius_. Giuseppe Greco T-Systems CS AG Birkenstrasse 21 8306 Brüttisellen Phone: +41 (0) 1 805 57 20 Fax: +41 (0) 1 805 55 45 Email: [EMAIL PROTECTED] Web: www.t-systems.ch --- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] Fileset references
Title: Fileset references Hi all, does anybody know how far is the implementation of fileset refereces? (see www.mail-archive.com/[EMAIL PROTECTED]/msg01418.html for more info) Gius_. Giuseppe Greco T-Systems CS AG Birkenstrasse 21 8306 Brüttisellen Phone: +41 (0) 1 805 57 20 Fax: +41 (0) 1 805 55 45 Email: [EMAIL PROTECTED] Web: www.t-systems.ch
Re: [nant-dev] Fileset references
+1 for this. This would be really sweet. brant ... From: Philip Nelson <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: [nant-dev] Fileset references Date: Thu, 20 Mar 2003 11:15:20 -0800 (PST) > So the two valid forms would be: > 1.) (how things work now) > > > > 2.) > > > > > > What I would love to see is: in addition to the more verbose sorts... Fileset references are something ant had a long time ago and would really reduce the size of my build files tremendously. --- This SF.net email is sponsored by: Tablet PC. Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail --- This SF.net email is sponsored by: Tablet PC. Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset references
I agree - I've been using text files and includesList (just a raw list of asis files) for now, but I think it would be cool to include a build file that had a fileset definition with the set of files you wanted - this could be included at the top of each build file. It should also increase performance for recursive fileset definitions used over and over. Philip Nelson wrote: So the two valid forms would be: 1.) (how things work now) 2.) What I would love to see is: in addition to the more verbose sorts... Fileset references are something ant had a long time ago and would really reduce the size of my build files tremendously. --- This SF.net email is sponsored by: Tablet PC. Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.net email is sponsored by: Tablet PC. Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] Fileset references
> So the two valid forms would be: > 1.) (how things work now) > > > > 2.) > > > > > > What I would love to see is: in addition to the more verbose sorts... Fileset references are something ant had a long time ago and would really reduce the size of my build files tremendously. --- This SF.net email is sponsored by: Tablet PC. Does your code think in ink? You could win a Tablet PC. Get a free Tablet PC hat just for playing. What are you waiting for? http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] FileSet bugs?
I think there might be problems with the fileset functionality: A couple of examples: 1) In a directory "c:\build\pn\bin" I have three dlls: SciLexer.dll, libexpat.dll and libexpatw.dll This task produces this output: zip: [zip] Zipping 6 files to C:\build\pn\test.zip And places two copies of each file in the directory of the zip file (which I didn't think was valid behaviour for zip files anyway?). Using the task with a basedir attribute, however, seems to work: zip: [zip] Zipping 3 files to C:\build\pn\test.zip 2) With the same directory, this task: Produces: clean: [delete] Deleting 6 files Oh oh, there are only three files so this of course throws up errors about not being able to delete files. Strangely, earlier when I ran this the build file refused to find any dlls, or any files at all more to the point - which is what I was about to report here. Now it seems to be finding double the number I expected. Most worrying. Switching to the basedir attribute does fix this. I'm concerned that earlier I was seeing: [delete] Deleting 0 files And with no changes to the script or directory contents this has started working. Most probably my fault, but I can't imagine why. Anyway, it still looks like there are problems with the FileSet stuff, anyone else seen this? -- Simon Steele Research Engineer - Softel Ltd. tel: +44 118 984 2151 / web: http://www.softel.co.uk/ __ This message has been checked for all known viruses by Star Internet delivered through the MessageLabs Virus Scanning Service. --- This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. The most comprehensive and flexible code editor you can use. Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial. www.slickedit.com/sourceforge ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset change
Hi Gerry, > > I'm wary of using whitespace as a delimiter. > > Right now target names are delimited by white space. OK, I should've seen that one coming :) I should've been more specific: I don't like line separators (whatever you defined them as) as delimiters for this kind of thing. > If you need to have a string with spaces you need to use a different method > (ie, the style). See, that's one of the things I don't like, precisly. If the whole intention is to make it easier for people to read and write buildfiles, having to do things in two different ways depending on such a simple thing doesn't make it easier at all... only more confusing, in my mind. But it does bring two questions I haven't seen addressed in your posts: - Would you consider keeping supporting the ? As long as that's there, I'd be happy, as I probably wouldn't use the other one :) - If people had the "strings with spaces" issue, what would be the supported way to address it? There are a few options I see: - Make every entry in the fileset use the syntax - Allow mixed content in the fileset element (yuck!) - Allow you to split the fileset in two elements (yuck, too) -- Tomas Restrepo [EMAIL PROTECTED] --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Fileset change
> I'm wary of using whitespace as a delimiter.
Right now target names are delimited by white space. Should we move to this
format?
I'm joking btw.
What I was proposing (though didn't state very well is that we adopt a clear
well defined way of handling whitespace in elements and attributes). Other
tasks use whitespace delimiters as well , ie, the task.
I was thinking that we could use this algorithm to parse white space:
StringCollection ParseWhiteSpaceSeperatedValues(string elementValue) {
StringCollection values = new StringCollection();
String[] tokens = elementValue.Split();
foreach (string s in tokens) {
string trimmed = s.Trim();
if (trimmed.Length > 0) {
values.Add(trimmed);
}
}
return values;
}
If you need to have a string with spaces you need to use a different method
(ie, the style).
I understand that this going against the everything XML DOM parseable but
please keep in mind that many different types of people have to read, edit
and understand these files. What I'm proposing is a consistent way of
handling whitespace separated tokens in element and attribute values in an
effort to make the files more human readable while at the same time not
hindering their machine parseability. This would become a standard for all
attributes and elements used by NAnt.
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset change
Hi Gerry, > What do people think of this addition to the format of filesets? Humm... I must admit I'm not crazy about it either, and I don't feel it is all that much intuitive compared to what we have now. Ian's reasons sound pretty important to me, too. -- Tomas Restrepo [EMAIL PROTECTED] --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset change
I agree with Ian on this one. Keeping the elements as
parsable XML that can be manipulated via XSLT or the
DOM seems like a good goal to maintain.
--- Ian MacLean <[EMAIL PROTECTED]> wrote:
> Gerry,
>
> This new format is much more readable and easier to
> type than before.
> The major downside I see is for people writing tools
> to read and write
> the build file - or using xslt to transform it. You
> can no longer rely
> on just the Xml api;s to read and write the build
> file. There now needs
> to be custom code that is aware of the /n seperation
> for the file list
> and every piece of code that reads a build file will
> need to include it.
> I'm wary of using whitespace as a delimiter. /n
> seems less error prone.
> Significant whitespace in makefiles is one of the
> reasons I started
> using Ant/NAnt.
>
> my .02c
>
> Ian
>
> Shaw, Gerry wrote:
>
> >What do people think of this addition to the format
> of filesets? Look at
> >the element of the task. The
> task is my own
> >private task. I thought it would be better to
> include the entire buildfile
> >in full so that if people could come up with a
> better syntax they could edit
> >the file.
> >
> >Basically I'm trying to make this file as human
> readable as possible so
> >people that aren't familiar with XML can see what
> is going on and add/remove
> >some files from a project for a specific platform.
> >
> >The files are delimited by whitespace. If your
> file has a space character
> >you should use the format.
> Another option is to
> >delimit the filesnames by \n so that spaces could
> occur in the filename (or
> >path if the full path was used to include the
> file).
> >
> >-- included build file --
> >
> >
> >
> >
> >
> >
> >${platform}
> >cmn
> >
> >
> >
> > name="${platform}/*.cpp"/>
> >
> >
> >
> >win/*.cpp
> >cmn/detectself.cpp
> >cmn/emms.cpp
> >cmn/lowtimer.cpp
> >cmn/setenv.cpp
> >cmn/startup.cpp
> >cmn/systemlock.cpp
> >
> >
> >
> >ps2/*.cpp
> >cmn/setkbdstate.cpp
> >cmn/startup.cpp
> >cmn/systemlock.cpp
> >
> >
> >
> >xbox/*.cpp
> >cmn/setenv.cpp
> >cmn/setkbdstate.cpp
> >cmn/startup.cpp
> >cmn/systemlock.cpp
> >
> >
> >
> >
> >
> >
> >
> >
> >
>
>---
> >In remembrance
> >www.osdn.com/911/
> >___
> >Nant-developers mailing list
> >[EMAIL PROTECTED]
>
>https://lists.sourceforge.net/lists/listinfo/nant-developers
> >
> >
> >
> >
>
>
>
>
>
---
> This SF.NET email is sponsored by: AMD - Your access
> to the experts
> on Hammer Technology! Open Source & Linux
> Developers, register now
> for the AMD Developer Symposium. Code: EX8664
> http://www.developwithamd.com/developerlab
> ___
> Nant-developers mailing list
> [EMAIL PROTECTED]
>
https://lists.sourceforge.net/lists/listinfo/nant-developers
__
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Fileset change
Gerry,
This new format is much more readable and easier to type than before.
The major downside I see is for people writing tools to read and write
the build file - or using xslt to transform it. You can no longer rely
on just the Xml api;s to read and write the build file. There now needs
to be custom code that is aware of the /n seperation for the file list
and every piece of code that reads a build file will need to include it.
I'm wary of using whitespace as a delimiter. /n seems less error prone.
Significant whitespace in makefiles is one of the reasons I started
using Ant/NAnt.
my .02c
Ian
Shaw, Gerry wrote:
>What do people think of this addition to the format of filesets? Look at
>the element of the task. The task is my own
>private task. I thought it would be better to include the entire buildfile
>in full so that if people could come up with a better syntax they could edit
>the file.
>
>Basically I'm trying to make this file as human readable as possible so
>people that aren't familiar with XML can see what is going on and add/remove
>some files from a project for a specific platform.
>
>The files are delimited by whitespace. If your file has a space character
>you should use the format. Another option is to
>delimit the filesnames by \n so that spaces could occur in the filename (or
>path if the full path was used to include the file).
>
>-- included build file --
>
>
>
>
>
>
>${platform}
>cmn
>
>
>
>
>
>
>
>win/*.cpp
>cmn/detectself.cpp
>cmn/emms.cpp
>cmn/lowtimer.cpp
>cmn/setenv.cpp
>cmn/startup.cpp
>cmn/systemlock.cpp
>
>
>
>ps2/*.cpp
>cmn/setkbdstate.cpp
>cmn/startup.cpp
>cmn/systemlock.cpp
>
>
>
>xbox/*.cpp
>cmn/setenv.cpp
>cmn/setkbdstate.cpp
>cmn/startup.cpp
>cmn/systemlock.cpp
>
>
>
>
>
>
>
>
>
>---
>In remembrance
>www.osdn.com/911/
>___
>Nant-developers mailing list
>[EMAIL PROTECTED]
>https://lists.sourceforge.net/lists/listinfo/nant-developers
>
>
>
>
---
This SF.NET email is sponsored by: AMD - Your access to the experts
on Hammer Technology! Open Source & Linux Developers, register now
for the AMD Developer Symposium. Code: EX8664
http://www.developwithamd.com/developerlab
___
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] Fileset change
What do people think of this addition to the format of filesets? Look at
the element of the task. The task is my own
private task. I thought it would be better to include the entire buildfile
in full so that if people could come up with a better syntax they could edit
the file.
Basically I'm trying to make this file as human readable as possible so
people that aren't familiar with XML can see what is going on and add/remove
some files from a project for a specific platform.
The files are delimited by whitespace. If your file has a space character
you should use the format. Another option is to
delimit the filesnames by \n so that spaces could occur in the filename (or
path if the full path was used to include the file).
-- included build file --
${platform}
cmn
win/*.cpp
cmn/detectself.cpp
cmn/emms.cpp
cmn/lowtimer.cpp
cmn/setenv.cpp
cmn/startup.cpp
cmn/systemlock.cpp
ps2/*.cpp
cmn/setkbdstate.cpp
cmn/startup.cpp
cmn/systemlock.cpp
xbox/*.cpp
cmn/setenv.cpp
cmn/setkbdstate.cpp
cmn/startup.cpp
cmn/systemlock.cpp
---
In remembrance
www.osdn.com/911/
___
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] FileSet Newbie
I am working on a NAntContrib task for doing StarTeam source control integration. I want to add a FileSet like capability to checkin/outs. The primary difference is that it seems a FileSet is all about files local to the system. Communications to the source server are expensive so the idea of pre-scanning the repository for files to include or exclude is out of the question. However I would like to utilize (and follow the spirit of) pattern matching used by filesets. It seems the support for this is in DirectoryScanner.cs. It is however tied to DirectoryInfo to resolve (cannonize) paths. This does not work for me as those paths may not yet be local. Does anyone have an idea how this code could be refactored for use with other pattern matching tasks or elements. Kevin Miller --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] FileSet includes question
What you've described may not be how I described it but was how I meant to. * refid'ed elements get cloned from the original id'ed. The cloning copies unexpanded properties. * you can't refid an element that hasn't executed. For the record I'm not in favor of a lazy forward looking init scheme. Ian and I dumped the initial code that did something similar for a JIT initialize. It made the code simplier, likely removed bugs and made it conceptually easier to understand IMO. --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet includes question
Ian,
> I think so. Right now property expansion doesn't happen until just
> before task execution so that would kinda mandate define before
> reference semantics. The other issue is property expansion itself. If
> you're using a referenced Fileset that has a number of ${property} 's -
> do you use the value of ${property} as it was when the Fileset was
> defined or what it is now - where its referenced. I'm thinking you'd
> probably want to re-evaluate the properties.
Good point! That one hadn't occurred to me before. From all of this, I think
Scott might be in the right track, in the sense that doing the double Xml
initialization seems like the easiest way to get the right semantics
going...
--
Tomas Restrepo
[EMAIL PROTECTED]
---
Sponsored by:
ThinkGeek at http://www.ThinkGeek.com/
___
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] FileSet includes question
As far as I can tell from ant things work a little differently from what we are talking about. Ant defines a Reference object that DataType(s) holds onto. Then the FileSet (derived from DataType) looks at the Reference object and uses it, in combination of its own xml to do the job. This would require each refid'd task would have to know how to deal with a Reference. I'm much more of the opinion that should do the xml merging, or double xml initialization. See the rest of my comments below. > -Original Message- > From: Tomas Restrepo > Subject: Re: [nant-dev] FileSet includes question > > Hi Gerry, > > > > > > > humm... For tasks with simple attributes, this makes quite a bit of sense, > and it's semantically simple. However, what would be the semantics for > more > complex elements, say, a FileSet? This does become a little more complicated. > For example, consider this: > > > > > > > > > > > What would the semantics be? Should the second FileSet excludes/includes > element be "merged" with the original FileSet's filelist? Or should the > list > be replaced? I think the correct solution would be to Merge them (iow, in If you wanted to replace things, you could just start over with a new fileset, without the ref. > the example above, you'd end up with a fileset with two includes and one > exclude. However, I'm not sure this would be the best solution in all > cases. Merged would be my first response. It would also require that the fileset(task) know that it may be init'd more than once. > A second thing I have been considering is that during reinitialization > what > you really want is to copy the original element instance. IOW, elements > should be clonable. Why? Well, if you always made changes on the same > object > that was initialized when the element with the id attribute was found. I'd say that we should just use the xml that was used to init that element, not the element itself. BTW. Element does have a copy ctor but doesn't support ICloneable, or Copy(). > Otherwise when you refid'd a single element more than once later in the > buildfile, there's no way you could predict exactly what that element > would > contain. For example, if I created yet another fileset referencing > Fileset1 > above, what would it be referencing? A FileSet with two includes, or a > FileSet with two-includes and one excludes? I think the first behavior is > what the user would expect, and it's the easier to deal with in complex > buildfiles... What do you guys think? I'd be inclined to make the rule something like this. --If extra xml is defined in the ref'd element, do the double xml init. Results in something like this for ref'd one And 2 fileset objects being created, which are not connected. --If no extra xml is defined in the ref'd element, use a object ref. Results 1 fileset object and both fileset xml decls using them. > Finally, am I right in assuming that given NAnt's current behavior when > loading the buildfiles, this would require that an element can only be > refid'd _after_ the original element with such _id_ appears? IOW, in a > sortta-programming-language-like way, elements can only be referenced > after > they have been defined? Yes, this is currently a problem. I've been thinking about supporting lazy init'n so that all id/names are resolved, then the tasks/elements are evaluated during Execute. The scheme I've described above should fit well with a lazy init scheme. It would make sure that name resolution working independently of where you defined the link. Order would not be a problem as it is now. The other thing to keep in mind is that with this scheme we would probably use an XPath expression like //fileset[id='foo'] to find the source element. This would require a full document traversal to find the element. So once you use a ref, you could incur some performance penalties. I'm wondering if there is some general XML technology that could help us out during xml reading. I don't expect this to be too big a deal, but I just brought it up for an FYI. --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] FileSet includes question
Oops, I suggested the exact same thing before I had read this. Serves me right for not reading the whole thread before replying. In looking through the Ant code, the only tricky thing they do is to ensure that there isn't a circular reference. Not a hard check to do, but an important one. --- Gerry Shaw <[EMAIL PROTECTED]> wrote: > > > I was thinking about the id'ed FileSet's. Here > is what would need > > > changing: > > > > > > * Add an Id property to the FileSet class > > > > I'm kind of curious about why implement it this > way it > > seems to me, that everything in the buildfile > should be able > > to be referenced by an ID, so I'd think a more > interesting > > idea would be to add the Id property to the > Element base > > class, and instead get the Project class to keep a > collection > > of Elements... of course, for larger buildfiles > this would > > imply a fairly heavy runtime memory cost, but > perhaps that > > could be avoided as well (particularly if we don't > mind > > parsing an element twice and "executing" it in > different instances... > > > > What do you guys think? I admit I have no clue as > to what Ant > > does in this context, though > > Great idea! Also you shouldn't get a big runtime > cost if you only > stored elements that specified an id. If an element > included a refid > field then the element could initialize itself from > the Project's copy > and then apply any changes also specified in the > buildfile. > > That sounds pretty simple from a user's point of > view while still being > pretty easy to implement. > > Example: > > > > > > > > > > > > Opinions on this would be useful. > > > > --- > Sponsored by: > ThinkGeek at http://www.ThinkGeek.com/ > ___ > Nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers __ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet includes question
>of course, for larger buildfiles this would imply a >fairly heavy runtime memory cost We could mitigate the cost by making the ID optional. That is, if they don't set an ID on an element, don't add it to the collection. >I admit I have no clue as to what Ant does in this > context, though Ant's project class maintains a hashtable that is used to store references (simple name to object mapping). Only fileset-y type things are referenceable, I think (FileSets, DirSets, FileLists, etc). --- Tomas Restrepo <[EMAIL PROTECTED]> wrote: > > > > I was thinking about the id'ed FileSet's. Here is > what would need > > changing: > > > > * Add an Id property to the FileSet class > > I'm kind of curious about why implement it this > way it seems to me, that > everything in the buildfile should be able to be > referenced by an ID, so I'd > think a more interesting idea would be to add the Id > property to the Element > base class, and instead get the Project class to > keep a collection of > Elements... of course, for larger buildfiles this > would imply a fairly heavy > runtime memory cost, but perhaps that could be > avoided as well (particularly > if we don't mind parsing an element twice and > "executing" it in different > instances... > > What do you guys think? I admit I have no clue as to > what Ant does in this > context, though > -- > Tomas Restrepo > [EMAIL PROTECTED] > > > > --- > Sponsored by: > ThinkGeek at http://www.ThinkGeek.com/ > ___ > Nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers __ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet includes question
Tomas Restrepo wrote
Finally, am I right in assuming that given NAnt's current behavior when
>loading the buildfiles, this would require that an element can only be
>refid'd _after_ the original element with such _id_ appears? IOW, in a
>sortta-programming-language-like way, elements can only be referenced after
>they have been defined?
>
>
>
I think so. Right now property expansion doesn't happen until just
before task execution so that would kinda mandate define before
reference semantics. The other issue is property expansion itself. If
you're using a referenced Fileset that has a number of ${property} 's -
do you use the value of ${property} as it was when the Fileset was
defined or what it is now - where its referenced. I'm thinking you'd
probably want to re-evaluate the properties.
Ian
>
>
---
Sponsored by:
ThinkGeek at http://www.ThinkGeek.com/
___
Nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet includes question
Hi Gerry, > > humm... For tasks with simple attributes, this makes quite a bit of sense, and it's semantically simple. However, what would be the semantics for more complex elements, say, a FileSet? For example, consider this: What would the semantics be? Should the second FileSet excludes/includes element be "merged" with the original FileSet's filelist? Or should the list be replaced? I think the correct solution would be to Merge them (iow, in the example above, you'd end up with a fileset with two includes and one exclude. However, I'm not sure this would be the best solution in all cases. A second thing I have been considering is that during reinitialization what you really want is to copy the original element instance. IOW, elements should be clonable. Why? Well, if you always made changes on the same object that was initialized when the element with the id attribute was found. Otherwise when you refid'd a single element more than once later in the buildfile, there's no way you could predict exactly what that element would contain. For example, if I created yet another fileset referencing Fileset1 above, what would it be referencing? A FileSet with two includes, or a FileSet with two-includes and one excludes? I think the first behavior is what the user would expect, and it's the easier to deal with in complex buildfiles... What do you guys think? Finally, am I right in assuming that given NAnt's current behavior when loading the buildfiles, this would require that an element can only be refid'd _after_ the original element with such _id_ appears? IOW, in a sortta-programming-language-like way, elements can only be referenced after they have been defined? -- Tomas Restrepo [EMAIL PROTECTED] --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] FileSet includes question
> > I was thinking about the id'ed FileSet's. Here is what would need > > changing: > > > > * Add an Id property to the FileSet class > > I'm kind of curious about why implement it this way it > seems to me, that everything in the buildfile should be able > to be referenced by an ID, so I'd think a more interesting > idea would be to add the Id property to the Element base > class, and instead get the Project class to keep a collection > of Elements... of course, for larger buildfiles this would > imply a fairly heavy runtime memory cost, but perhaps that > could be avoided as well (particularly if we don't mind > parsing an element twice and "executing" it in different instances... > > What do you guys think? I admit I have no clue as to what Ant > does in this context, though Great idea! Also you shouldn't get a big runtime cost if you only stored elements that specified an id. If an element included a refid field then the element could initialize itself from the Project's copy and then apply any changes also specified in the buildfile. That sounds pretty simple from a user's point of view while still being pretty easy to implement. Example: Opinions on this would be useful. --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] FileSet includes question
> I was thinking about the id'ed FileSet's. Here is what would need > changing: > > * Add an Id property to the FileSet class I'm kind of curious about why implement it this way it seems to me, that everything in the buildfile should be able to be referenced by an ID, so I'd think a more interesting idea would be to add the Id property to the Element base class, and instead get the Project class to keep a collection of Elements... of course, for larger buildfiles this would imply a fairly heavy runtime memory cost, but perhaps that could be avoided as well (particularly if we don't mind parsing an element twice and "executing" it in different instances... What do you guys think? I admit I have no clue as to what Ant does in this context, though -- Tomas Restrepo [EMAIL PROTECTED] --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] FileSet includes question
I was thinking about the id'ed FileSet's. Here is what would need changing: * Add an Id property to the FileSet class * Add a collection of FileSet's to the Project class * Change how a FileSet initializes by doing what it currently does OR by specifying an Id. If the id is given, look up the FileSet in the Project's collection of FileSets. * Provide a FileSetTask that adds FileSet's to the Project's collection. On the surface it *seems* pretty easy. If it works out we could use the same strategy for other reusable collections (ie, Tomas's OptionSet). I encourage you do think about solving your problem this way rather than the comma seperated include pattern. > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]] On > Behalf Of Kevin Dente > Sent: Sun, June 23, 2002 6:12 PM > To: Gerry Shaw; 'Nant developer's list' > Subject: RE: [nant-dev] FileSet includes question > > > Yeah, I kinda figured that out while reviewing the Ant > docs. :) > > The reason I say it make be useful is that it allows > non-trivial FileSets to be specified through property expansion. > > You see, I'm working on replacing a fairly complex > build system (built using NMake) with NAnt. The > original system let you create a very simple make file > (on the order of a few lines), and an included > "master" makefile contained as much of the build logic > as possible. For a build system with dozens of > projects, that makes it a lot easier to control things > without having to edit a ton of invididual make files > when you need to make a change. > > NAnt lets me do a lot with the include task, but there > currently isn't really a clean way to include a fileset > defined elsewhere (at least, not one with more than a single > include spec). By allowing a comma-delimited list of > patterns, a complex fileset could be passed around as a property. > > I understand the clarity issues that such a change > would introduces, though. A similar thing could be > accomplished (although not quite as richly) using > ids/refids, as I asked about it my other e-mail. > > --- Gerry Shaw <[EMAIL PROTECTED]> wrote: > > The docs are wrong. I shamelessly compied from > > directly from Ant :) and > > I must have missed that. > > > > I'm not sure it adds anything that you could already > > do with multiple > > tags. I perfer things to be really > > obvious at the expense of > > more typing since you only have type stuff once but > > it will be read many > > times. > > > > > -Original Message- > > > From: [EMAIL PROTECTED] > > > > > [mailto:[EMAIL PROTECTED]] > > On > > > Behalf Of Kevin Dente > > > Sent: Thu, June 20, 2002 11:31 AM > > > To: Nant developer's list > > > Subject: [nant-dev] FileSet includes question > > > > > > > > > The (now out of date) Nant documentation on the > > > sourceforge site for the FileSet says the > > following > > > about the includes element: > > > > > > "comma-separated list of patterns of files that > > must > > > be included" > > > > > > I read this to mean that a single tag > > can > > > have multiple, comma-separated files/patterns in a > > > single includes element, ala > name="file1, > > > file2, file3". However, it doesn't appear that the > > > code works that way. Am I misinterpreting the > > docs? > > > Are the docs wrong? Is it intended to work that > > way, > > > but just doesn't yet? > > > > > > FWIW, I think it would be a nice feature. > > > > > > __ > > > Do You Yahoo!? > > > Yahoo! - Official partner of 2002 FIFA World Cup > > > http://fifaworldcup.yahoo.com > > > > > > > > > > > > > > > --- > > > Sponsored by: > > > ThinkGeek at http://www.ThinkGeek.com/ > > > ___ > > > Nant-developers mailing list > > [EMAIL PROTECTED] > > > > > > https://lists.sourceforge.net/lists/listinfo/nant-developers > > > > > > > > > > > > --- > > Sponsored by: > > ThinkGeek at http://www.ThinkGeek.com/ > > ___ > > Nant-developers mailing list [EMAIL PROTE
RE: [nant-dev] FileSet includes question
Yeah, I kinda figured that out while reviewing the Ant docs. :) The reason I say it make be useful is that it allows non-trivial FileSets to be specified through property expansion. You see, I'm working on replacing a fairly complex build system (built using NMake) with NAnt. The original system let you create a very simple make file (on the order of a few lines), and an included "master" makefile contained as much of the build logic as possible. For a build system with dozens of projects, that makes it a lot easier to control things without having to edit a ton of invididual make files when you need to make a change. NAnt lets me do a lot with the include task, but there currently isn't really a clean way to include a fileset defined elsewhere (at least, not one with more than a single include spec). By allowing a comma-delimited list of patterns, a complex fileset could be passed around as a property. I understand the clarity issues that such a change would introduces, though. A similar thing could be accomplished (although not quite as richly) using ids/refids, as I asked about it my other e-mail. --- Gerry Shaw <[EMAIL PROTECTED]> wrote: > The docs are wrong. I shamelessly compied from > directly from Ant :) and > I must have missed that. > > I'm not sure it adds anything that you could already > do with multiple > tags. I perfer things to be really > obvious at the expense of > more typing since you only have type stuff once but > it will be read many > times. > > > -Original Message- > > From: [EMAIL PROTECTED] > > > [mailto:[EMAIL PROTECTED]] > On > > Behalf Of Kevin Dente > > Sent: Thu, June 20, 2002 11:31 AM > > To: Nant developer's list > > Subject: [nant-dev] FileSet includes question > > > > > > The (now out of date) Nant documentation on the > > sourceforge site for the FileSet says the > following > > about the includes element: > > > > "comma-separated list of patterns of files that > must > > be included" > > > > I read this to mean that a single tag > can > > have multiple, comma-separated files/patterns in a > > single includes element, ala name="file1, > > file2, file3". However, it doesn't appear that the > > code works that way. Am I misinterpreting the > docs? > > Are the docs wrong? Is it intended to work that > way, > > but just doesn't yet? > > > > FWIW, I think it would be a nice feature. > > > > __ > > Do You Yahoo!? > > Yahoo! - Official partner of 2002 FIFA World Cup > > http://fifaworldcup.yahoo.com > > > > > > > > > --- > > Sponsored by: > > ThinkGeek at http://www.ThinkGeek.com/ > > ___ > > Nant-developers mailing list > [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/nant-developers > > > > > > --- > Sponsored by: > ThinkGeek at http://www.ThinkGeek.com/ > ___ > Nant-developers mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers __ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] FileSet includes question
The docs are wrong. I shamelessly compied from directly from Ant :) and I must have missed that. I'm not sure it adds anything that you could already do with multiple tags. I perfer things to be really obvious at the expense of more typing since you only have type stuff once but it will be read many times. > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]] On > Behalf Of Kevin Dente > Sent: Thu, June 20, 2002 11:31 AM > To: Nant developer's list > Subject: [nant-dev] FileSet includes question > > > The (now out of date) Nant documentation on the > sourceforge site for the FileSet says the following > about the includes element: > > "comma-separated list of patterns of files that must > be included" > > I read this to mean that a single tag can > have multiple, comma-separated files/patterns in a > single includes element, ala code works that way. Am I misinterpreting the docs? > Are the docs wrong? Is it intended to work that way, > but just doesn't yet? > > FWIW, I think it would be a nice feature. > > __ > Do You Yahoo!? > Yahoo! - Official partner of 2002 FIFA World Cup > http://fifaworldcup.yahoo.com > > > > --- > Sponsored by: > ThinkGeek at http://www.ThinkGeek.com/ > ___ > Nant-developers mailing list [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/nant-developers > --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] FileSet includes question
The (now out of date) Nant documentation on the sourceforge site for the FileSet says the following about the includes element: "comma-separated list of patterns of files that must be included" I read this to mean that a single tag can have multiple, comma-separated files/patterns in a single includes element, ala http://fifaworldcup.yahoo.com --- Sponsored by: ThinkGeek at http://www.ThinkGeek.com/ ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
