Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

On Mon, Jan 18, 2010 at 4:54 PM, Dirk Pranke wrote: > So, you then get the following algorithm: > > 1) if there is a ':' in the URI, you split the URI into scheme and > scheme-specific part. > > 2) If there is a scheme: > > 2.1) If the scheme is a recognized/supported one, dispatch the URL > as

Re: [chromium-dev] WebKitApi (test_shell) and DevTools, JS debugging

On Mon, Jan 18, 2010 at 9:16 AM, vridosh wrote: > As far as I > understand, that's why Debugger tab was not available in test_shell in > early Chromium builds. Probably the real reason is because test_shell isn't meant to be a reference implementation of everything and we never bothered to spen

Re: [chromium-dev] Re: Two Students Looking to work on Chromium for a Semester-Long Class Project (and beyond)

On Sat, Jan 16, 2010 at 2:25 AM, Alex Gartrell wrote: > I've decided to try to tackle crbug.com/20005 (thanks Peter for the > list). I'll dive into it more tomorrow. I don't know if there's an > 'assignee' role or something on the bug tracker, but I'm currently > working under the assumption tha

Re: [chromium-dev] [LTTF] Finders Pool Drained, Under 300 Failures on Win XP Release

Dimitri, the LTTF, and anyone else involved, you are awesome, and I consider your work to have the largest "importance / (satisfaction + recognition)" value on the team. This is a thankless task. You have given me hope that someday we could conceivably reach 0 failures. PK -- Chromium Developer

Re: [chromium-dev] Re: Two Students Looking to work on Chromium for a Semester-Long Class Project (and beyond)

On Fri, Jan 15, 2010 at 12:35 PM, Alex Gartrell wrote: > Pam's right in that we're looking for a 'Chromium mentor'. Right. I understood that, and might be willing to do it; I was more concerned with what you were actually interested in working on (in terms of size and style) to get an idea of w

Re: [chromium-dev] Ajax maximum response size

Ever think of using Web Sockets? PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Two Students Looking to work on Chromium for a Semester-Long Class Project (and beyond)

On Thu, Jan 14, 2010 at 9:54 PM, Alex Gartrell wrote: > - We both submitted patches that were accepted to Mozilla as part of > the prerequisite course to this one (So we know about dvcs, the patch > submission process, etc.) > One thing to note is that Chromium uses neither a distributed VC syste

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

On Thu, Jan 14, 2010 at 2:05 PM, Peter Kasting wrote: > I don't think Victor's objections have merit. > (For public benefit) Partly because you can't put ':' in a filename on Windows, which is the OS where local files aren't resolved. On the Mac opening

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

On Thu, Jan 14, 2010 at 1:55 PM, Scott Hess wrote: > If you try to open a > relative path and it doesn't work, you go "Oh, right, relative path". > No, actually, what I say every time is "What the heck, why did it try to open this as a hostname?" and then I laboriously navigate through twenty fo

Re: [chromium-dev] Date of M5 drop?

On Thu, Jan 14, 2010 at 4:48 AM, OwenCM wrote: > Hi, I've been scouring the groups and can't find the answer anywhere, > what time scale are we looking at until the dev branch hits m5? > What do you mean by "hits m5"? Do you mean, the major version stamp gets changed from 4 to 5? If so, the ti

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

On Thu, Jan 14, 2010 at 9:19 AM, Scott Hess wrote: > [BTW, don't take my argument as support for allowing relative paths on > the command-line. It's such a low-volume use-case that I'd be > perfectly fine requiring explicit fully-qualified URLs and be done > with it. :( This lack-of-feature ha

Re: [chromium-dev] RFC: Extensions Incognito

On Wed, Jan 13, 2010 at 2:28 PM, wrote: > I've shared Extensions > Incognito > * > * > The idea of having the ability to do both read-only and read-write access to the main profile is one that's mirror

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

On Wed, Jan 13, 2010 at 12:07 PM, Craig Schlenter wrote: > > Do we have other aliasing problems? If so my opinion changes. > > There are some aliasing issues still in play. Off the top of my head: > > 1. unit_tests has what might be an issue in stl_tree.h or a compiler issue > (bug filed with g

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

On Wed, Jan 13, 2010 at 11:28 AM, Evan Martin wrote: > PS: I'd be willing to flip the flag just after we do the next beta > channel push and see how many more problems we get because of it. > But in general, if it doesn't buy us any performance and it does cause > hard-to-track-down crashes, I do

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

On Wed, Jan 13, 2010 at 11:22 AM, Craig Schlenter < craig.schlen...@chromium.org> wrote: > Other than the immediate gain of "hiding" crbug.com/28749, > Which you have a patch (actually two, but one with r+) for, right? > I think the biggest > benefit is that end users relying on 4.4 builds are

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

On Wed, Jan 13, 2010 at 10:53 AM, Craig Schlenter wrote: > I'm one try-server run away from possibly turning -fno-strict-aliasing on > for > all linux/bsd gcc: http://codereview.chromium.org/519034 > > From a "process" standpoint, given that there is some disagreement here > is someone going to c

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

On Wed, Jan 13, 2010 at 9:42 AM, Evan Martin wrote: > At the code level I think it's not too hard for us to be aliasing > correct (people like Craig have already fixed all of the places where > we were wrong, and we have tools like bit_cast<> in basictypes.h to > make it not too painful), so I'm

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

On Tue, Jan 12, 2010 at 10:37 PM, Craig Schlenter < craig.schlen...@chromium.org> wrote: > That makes the compiler toss an aliasing error immediately: > > cc1plus: warnings being treated as errors > base/rand_util_posix.cc: In function ‘uint64 base::RandUint64()’: > base/rand_util_posix.cc:32: err

Re: [chromium-dev] on not displaying the home page in a new tab or window

On Mon, Jan 11, 2010 at 7:20 PM, Dirk Pranke wrote: > Is it by design that if I click on a new tab or a new window, and I > have my preference set to "open this page" on the home page rather > than "use the new tab page", we still show the new tab page? > Yes. Note that the option is "on startu

Re: [chromium-dev] Can we use a DOM ui page for ftp:/// and file:/// directory listings?

On Sun, Jan 10, 2010 at 7:15 AM, Pierre-Antoine LaFayette < pierre.lafaye...@gmail.com> wrote: > Is it illegal for the WebKit glue layer to send synchronous messages to the > browser requesting the icon data URI? I don't know, but in general sync messages suck. Why couldn't you use an async mes

Re: [chromium-dev] How can I tell if a Renderer process finishes loading a page

On Sat, Jan 9, 2010 at 12:15 AM, hap 497 wrote: > So how does renderer process knows the whole page is loaded completely > and tell the browser process to stop the spinning icons and shows the > favicon of the page? Sounds like you should start by looking in the browser for what controls the th

Re: [chromium-dev] svn question about line-endings

On Fri, Jan 8, 2010 at 10:25 AM, Alok Priyadarshi wrote: > Yes thats what I did to fix line-endings: svn pset svn:eol-style LF. > > But this CL contains other changes as well in addition to fixing > line-endings. Should I do them in separate CLs? > Yes, I would do them in separate CLs, since not

Re: [chromium-dev] svn question about line-endings

On Thu, Jan 7, 2010 at 7:42 PM, alokp wrote: > SVN Gurus, > > I have a question about my CL - http://codereview.chromium.org/527016/show > . > Mac and Linux trybots are failing at the patch stage due to line > endings. The files in my cl were originally submitted with wrong line- > endings. My CL

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

On Thu, Jan 7, 2010 at 8:00 PM, Michael Nordman wrote: > Where as It looks like GURL::EmptyGURL() may be a tad less costly than > GURL(). > Not if you ever need to initialize another GURL with it (since the compiler can't collapse the copy). Which is true much of the time that EmptyGURL() can b

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

On Thu, Jan 7, 2010 at 3:45 PM, Aaron Boodman wrote: > Out of curiosity, what is wrong with using EmptyString() in those > cases? Is there a correctness problem? Unnecessary inclusion of > string_util.h? There are a couple reasons. Code clarity and consistency is a primary one; using EmptyStri

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

On Thu, Jan 7, 2010 at 2:50 PM, Albert Wong (王重傑) wrote: > Is there something wrong with returning by copy, and relying on the > compiler to execute a return value optimization? > I'm not totally sure what your comment is saying. If you are saying that everywhere in the code can return by value

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

On Thu, Jan 7, 2010 at 1:50 PM, Jeremy Orlow wrote: > What about renaming the function? EmptyStringHACK() or something? It's not a hack. It's a perfectly legitimate thing to use, and not something we're going to get rid of, unlike ToWStringHack(). Darin suggested we could make these return c

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

On Thu, Jan 7, 2010 at 1:43 PM, Jeremy Orlow wrote: > You ignored the second half of my suggestion. > The second half of your suggestion leaks memory. When we have easy and elegant ways to avoid memory leaks, it behooves us to use them. It also seems like a poor idea to me to suggest that, pot

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

On Thu, Jan 7, 2010 at 1:34 PM, Jeremy Orlow wrote: > (As discussed during lunch...) Why not just do this in this case and > remove EmptyString() altogether? > > const std::string& MyClass::foo() const { > static std::string empty = EmptyString(); > return (everything == OK) ? member_string

Re: [chromium-dev] Replicated State among tabs in Chromium

On Thu, Jan 7, 2010 at 1:30 PM, Fady Samuel wrote: > What about allowing the renderer to run asynchronously with the > script? Right now you're either producing the view or you're running script > but never both concurrently, correct? Parallelizing them should not > introduce issues I think (as

[chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

If you have ever used any of the EmptyXXX() functions, or ever will, please read on. These functions (in string_util.h and gurl.h) are meant for a single, specific use case: const std::string& MyClass::foo() const { return (everything == OK) ? member_string : EmptyString(); } Here you cannot r

[chromium-dev] Core Principles: A refresher (especially for newer contributors/team members)

A while ago, Ben Goodger (our fearless tech lead) wrote up a set of core principles around Chromium. If you have not read and pondered these, please do: http://dev.chromium.org/developers/core-principles In particular, as we've had more contributors both inside and outside Google over the past y

Re: [chromium-dev] Replicated State among tabs in Chromium

On Mon, Jan 4, 2010 at 6:55 PM, Fady Samuel wrote: > So a script cannot execute concurrently with the traversal of the DOM tree? > Could this be a performance bottleneck? Pretty much nothing in the renderer can execute concurrently with other things in the renderer. There have been academic pa

Re: [chromium-dev] Replicated State among tabs in Chromium

On Mon, Jan 4, 2010 at 6:32 PM, Fady Samuel wrote: > I know I'm asking you a lot of questions here. > And you keep removing chromium-dev. Why? I'm not the knowledgeable person about much of this stuff, I'm just trying to be helpful. Alex mentioned the Webkit DOM tree, indicating that making t

Re: [chromium-dev] Replicated State among tabs in Chromium

(re-adding chromium-dev) On Mon, Jan 4, 2010 at 5:58 PM, Fady Samuel wrote: > Was this done to reduce memory overhead? No, it was done because the newly opened pages and the original pages can script each other. From what I understand, making sites in different processes able to script each o

Re: [chromium-dev] Replicated State among tabs in Chromium

On Mon, Jan 4, 2010 at 5:48 PM, Fady Samuel wrote: > So as Peter said a lot of this cache state will not be used in multiple > tabs because many of these tabs will be different webpages. That's not to > say that one doesn't open multiple pages from a single site however, in > which case the image

Re: [chromium-dev] Replicated State among tabs in Chromium

On Mon, Jan 4, 2010 at 5:17 PM, Fady Samuel wrote: > I'm also interested in looking into state that is already shared but makes > excessive use of locking and may be hindering performance. > I'm not aware of anything that really falls into this category. We share the visited link state but use

Re: [chromium-dev] Replicated State among tabs in Chromium

On Mon, Jan 4, 2010 at 4:58 PM, Darin Fisher wrote: > There are some caches in webkit (the resource cache in particular, but > there are others) that would be nice to share between processes. If you look into this, note that there are major tricky issues here around synchronization if you start

Re: [chromium-dev] chromium crash when load flash plugin

On Mon, Jan 4, 2010 at 3:35 PM, if-ifone wrote: > Hi: > I build a Release chromium from latest trunk code.my Chromium always > crash when page > contain flash elements. > > on ubuntu 9.10 > intel 32 > build command > make BUILDTYPE=Release > and make chrome BUILDTYPE=Release > Pl

Re: [chromium-dev] adding and saving preferences

On Sat, Jan 2, 2010 at 2:07 PM, Andy Ames wrote: > I have added a preference to pref_names.h/cc. > > In chrome/browser/browser.cc, I added the regisration of the user > preference to ths static Browser::RegisterUserPrefs(PrefService* > prefs) function: > > prefs->RegisterDictionaryPrefs(prefs::kP

Re: [chromium-dev] suppressing print dialog in kiosk mode

On Thu, Dec 31, 2009 at 2:32 AM, Andy Ames wrote: > I am considering using a separate switch such as --supress-print- > dialog, since kiosk mode and suppressing the print dialog are > orthogonal features. > They don't seem orthogonal, since in kiosk mode it doesn't seem like you would ever want

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

On Wed, Dec 30, 2009 at 3:56 PM, Jeremy Orlow wrote: > 2) Info bar. This seems like one of the more popular options at the >>> moment. >>> >> >> This is a bad idea, we shouldn't do it. It's not as annoying as a modal >> dialog, it has problems with clashing with other infobars on start. >> Bas

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

On Wed, Dec 30, 2009 at 3:22 PM, Jeremy Orlow wrote: > I just got back from vacation and would like to take action on this. I > read through the thread, but I don't see any sort of consensus on what to > do. Here are the options as I see them: > > 1) Modal dialog box. Bad for debugging, will p

Re: [chromium-dev] linux printing support and PrintingContext::AskUserForSettings

On Wed, Dec 23, 2009 at 10:39 AM, Andy Ames wrote: > Does anyone have suggestions on where to put the suppress print dialog > setting? In Firefox, this is done in about:config. Since it's typically a > developer feature, I want to hide it from the casual user. > Unless mhm never landed it, we al

Re: [chromium-dev] Command Line switches persisted in Preferences

On Fri, Dec 25, 2009 at 12:21 AM, PhistucK wrote: > My multi profile case, for example, is to separate the Chromium Google > account from my regular Google account. > Chromium and Google Chrome use different profile paths by default. You don't need to manually differentiate them. PK -- Chrom

Re: [chromium-dev] Command Line switches persisted in Preferences

On Thu, Dec 24, 2009 at 7:25 PM, Mohamed Mansour wrote: > The options that many people tend to use that I have seen in the forums are > (or group of people that is): > --incognito (they always want to browse invincible) > We definitely don't want to encourage this one, because it breaks so many

Re: [chromium-dev] Command Line switches persisted in Preferences

On Thu, Dec 24, 2009 at 3:29 PM, Evan Martin wrote: > You must use switches for a pretty common pattern ("separate profile > that goes through my work proxy") and I believe that's been wontfixed > in the past, so I'm not entirely unsympathetic to Mohamed's > suggestion, but I think Peter is right

Re: [chromium-dev] Command Line switches persisted in Preferences

On Thu, Dec 24, 2009 at 10:28 AM, Mohamed Mansour wrote: > Is their any argument not allowing command line options to be persisted in > the Preferences file? > Yes: It allows/encourages people to use more command-line switches. The switches we have are generally for exceptional cases. If peopl

Re: [chromium-dev] Strange key conflict on Windows versions of Chrome, F1 with P, F2 with Q, F3 with R, F4 with S

Please don't also copy chromium-dev on bugs you file, especially when they're for esoteric cases like "there is a problem when I hack the DLL to try and modify the keybindings". PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubsc

Re: [chromium-dev] Recovering from browser crashes

On Tue, Dec 22, 2009 at 1:59 PM, Evan Martin wrote: > For example close to my heart: my last stab at refactoring the way we > query plugins ended up running into subtle issues with how the metrics > service shuts down relative to the UI and IO loops. These pieces need > to talk to one another bu

Re: [chromium-dev] Looking for a chrome developer with skia-fu

On Mon, Dec 21, 2009 at 3:42 PM, James Hawkins wrote: > Hey guys, > > I'm trying to triage bug 9589, which is a UMR in skia. Who would be > good to help triage a skia bug? r...@google.com, bre...@chromium.org, senorbla...@chromium.org PK -- Chromium Developers mailing list: chromium-dev@goog

Re: [chromium-dev] Setting global preferences/settings in code

On Sat, Dec 19, 2009 at 12:59 AM, PhistucK wrote: > Though, I think, currently, there is no way to inject bookmarks. > I believe there is, or will be, because I believe we've had this request before. PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change

Re: [chromium-dev] Setting global preferences/settings in code

We have at least some capabilities here since our installer can set some of these values. I'm not sure what all the capabilities are. Make sure you don't get confused by discussions about about:config and similar. Generally those are about either "add more prefs" or "add a way to get at more pre

Re: [chromium-dev] Re: Different or same cookies storage in different tabs?

On Fri, Dec 18, 2009 at 8:57 AM, Sergio Tudela Romero < sergiotudelarom...@gmail.com> wrote: > The fact is that every time a cookie is saved the "key" to this is the > domain where it was created (is this the problme for me). Thus I could > never have 2 cookies in a single domain since both have t

Re: [chromium-dev] Recovering from browser crashes

On Fri, Dec 18, 2009 at 9:13 AM, Adam Barth wrote: > At a high level, imagine we had a watchdog process that kept track, > essentially, of the tab model and the navigation controllers. When > the browser process crashes, we could use this information to do > something like session restore, but i

Re: [chromium-dev] Different or same cookies storage in different tabs?

Chromium code has the concept of a "Profile". All renderers are associated with a profile. There is one cookie store per profile. By default, renderers are all given the same profile. When you use Incognito mode, for the purposes of cookies you can think of it like creating a new profile which

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline "-open-in-new-window" switch

On Tue, Dec 15, 2009 at 4:45 PM, Evan Stade wrote: > > To put it a different way, the cost of supporting these now is basically >> indistinguishable from the cost of just adding --new-window. >> > > in terms of code, I don't think that's true. The current patch is extremely > light weight. > And

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline "-open-in-new-window" switch

On Mon, Dec 14, 2009 at 4:47 PM, Evan Stade wrote: > we have had a lot of bug reports asking for NEW_WINDOW, but none for these > two dispositions. What use cases do you envisage? > Wanting to open pages in either of these ways? Firefox used to have options to control this and I was sad when th

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline "-open-in-new-window" switch

On Mon, Dec 14, 2009 at 4:34 PM, Evan Stade wrote: > I think adding a --disposition= field is overkill and will be harder to > maintain (which is the worst part about command line flags). If a new > disposition is added to webkit, one is renamed, or one is deleted, are you > willing to either mai

Re: [chromium-dev] Re: [chromium-reviews] Add the cmdline "-open-in-new-window" switch

On Mon, Dec 14, 2009 at 10:33 AM, Darin Fisher wrote: > I think for parity with other apps, we should provide a command line switch > to force the WindowOpenDisposition to NEW_WINDOW. For bonus points, > we could expose other dispositions. > Given mdm's explanation, I agree. And I agree that i

[chromium-dev] Re: [chromium-reviews] Add the cmdline "-open-in-new-window" switch

On Sat, Dec 12, 2009 at 12:54 AM, Clemens Fruhwirth wrote: > http://codereview.chromium.org/464060 adds the small one-line feature > to open an URL in a new window from commandline > > Can any review these changes? > Please read http://dev.chromium.org/developers/contributing-code . In particula

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

On Fri, Dec 11, 2009 at 11:01 AM, PhistucK wrote: > But, as I understand, some people do use it due to issues with the sandbox, > real issues, system incompatibilities. > That would be really unfair towards them. > Most issues should be fixable. We need to hear about problems the sandbox causes

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

On Fri, Dec 11, 2009 at 1:57 AM, Jeremy Orlow wrote: > As for the info bar/modal dialog: I've been thinking for a bit, and I'm > not sure this is enough. We have plenty of data that shows users often > leave browsers open for a very long time. The main risk is that someone > sets the flag, sta

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

On Thu, Dec 10, 2009 at 9:38 PM, John Abd-El-Malek wrote: > We disable --single-process and --in-process-plugins on release Google > Chrome builds to avoid the support headache that it causes. I think we > should do the same for --no-sandbox. There are legit reasons we have asked users to try

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

On Thu, Dec 10, 2009 at 8:22 PM, Darin Fisher wrote: > Perhaps --enable-webgl should instead implicitly disable the sandbox today > I think this is better than having users manually disable it. They'll be running without a sandbox either way, but this (a) makes the enabling process less error-p

Re: [chromium-dev] Extensions and the Mac

On Thu, Dec 10, 2009 at 5:02 PM, Avi Drissman wrote: > Q: Can't we have the extensions gallery warn that it won't work? > A: Sorry, we can't do that in an automated fashion. The extensions author > should mention it. Too bad they don't. > But we explicitly review patches with binary components.

Re: [chromium-dev] Thoughts on "// NOLINT"?

On Thu, Dec 10, 2009 at 11:20 AM, Jacob Mandelson wrote: > If something extra in an expression is a common case, I've sometimes > seen it done like: >return DoWork(&foo) POSIX_ONLY(&& DoWork(&posix_specific)); > where POSIX_ONLY will expand to nothing or its argument. > It's ugly, but compact.

Re: [chromium-dev] Thoughts on "// NOLINT"?

On Thu, Dec 10, 2009 at 10:45 AM, Jonathan Dixon wrote: > In essence: > > return DoWork(&foo) > #if defined(OS_POSIX) > && DoWork(&posix_specific) > #endif > ; // <-- Lint complains about this guy > I'd prefer this: #if defined(OS_POSIX) return DoWork(&foo) && DoWork(&posix_specific)

Re: [chromium-dev] Thoughts on "// NOLINT"?

On Wed, Dec 9, 2009 at 3:48 PM, John Abd-El-Malek wrote: > Lately I've been seeing more and more // NOLINT added to the code. It's > great that people are running lint to make sure that they're following the > guidelines, but I personally find adding comments or gibberish to our code > for tools

Re: [chromium-dev] Re: Visualizing painting

On Wed, Dec 9, 2009 at 5:30 AM, MAD wrote: > Thanks pkasting@ for trying this with > http://src.chromium.org/viewvc/chrome?view=rev&revision=34108 > > But as the page cyclers dashboard seem to confirm, this is still a > issue... :-( > http://build.chromium.org/buildbot/perf/xp-release-dual-core/m

Re: [chromium-dev] Height of Personal Stuff tab in Options window

On Tue, Dec 8, 2009 at 4:59 PM, Evan Stade wrote: > > this makes the assumption that there is some "best" setting for each WM, > which is false. What's best for me on metacity is not what's best for you on > metacity. > Unfortunately, if you really believe that, then for one of us the default is

Re: [chromium-dev] Height of Personal Stuff tab in Options window

On Tue, Dec 8, 2009 at 4:55 PM, Ben Goodger (Google) wrote: > BTW I think the "Use Gtk Theme" button should be replaced by a special > theme that triggers this mode, much like the "default" theme we have > in the theme gallery. This would make the selection of this mode vs. > others feel more natu

Re: [chromium-dev] Height of Personal Stuff tab in Options window

On Tue, Dec 8, 2009 at 4:25 PM, Evan Stade wrote: > On Tue, Dec 8, 2009 at 4:18 PM, Peter Kasting wrote: > >> * We have crazy word wrapping. The bookmark sync text could fit on one >> line. Why does it wrap? etc. elsewhere >> > > yes, we can save two lines in

Re: [chromium-dev] Height of Personal Stuff tab in Options window

On Tue, Dec 8, 2009 at 4:11 PM, Evan Stade wrote: > proposals on which of these options (again, see original attachment) to > "rip out" are welcome and within the scope of this thread. > Off the top of my head: * We have crazy word wrapping. The bookmark sync text could fit on one line. Why do

Re: [chromium-dev] Height of Personal Stuff tab in Options window

On Tue, Dec 8, 2009 at 4:03 PM, Ian Fette wrote: > Putting on my individual contributor hat here, I have to say that Ben's > solution would seem very non-intuitive to me. I'm not aware of any app that > works that way, and I would probably think that the dialog was just cut off > (as is currently

Re: [chromium-dev] Visualizing painting

On Mon, Dec 7, 2009 at 8:15 PM, Darin Fisher wrote: > Chrome now supports a handy command line flag that'll show you the regions > of the > page that are being re-painted. This can be helpful if you are tracking > down repaint > issues. > > $ chrome --show-paint-rects > > It's interesting to see

Re: [chromium-dev] Re: Plugin Manager UI Proposal

Sigh, resending now that I have re-added my address to Groups after it got auto-removed :( On Mon, Dec 7, 2009 at 12:25 PM, Peter Kasting wrote: > On Mon, Dec 7, 2009 at 11:45 AM, Panayiotis Mavrommatis < > panayio...@google.com> wrote: > >> I'm not sure if my em

Re: [chromium-dev] Profiles + SharedWorkers

On Mon, Dec 7, 2009 at 11:37 AM, Drew Wilson wrote: > I currently am special-casing incognito windows, so incognito windows don't > share workers with non-incognito workers, but I don't do anything to deal > with profiles in general (so if you were running with separate profiles, > those profiles

Re: [chromium-dev] NaCl related build error

On Mon, Nov 30, 2009 at 10:01 PM, Antony Sargent wrote: > I just updated to revision 33425, and a clean build (manually deleted Debug > directory before opening .sln file) gives the following error in > service_runtime_x86. I'm running Visual Studio 2008 on Vista x64. Anyone > else seeing this, or

Re: [chromium-dev] [MEMORY] CreateDIBSection: memory usage for bitmaps in Windows

On Fri, Nov 27, 2009 at 5:43 PM, Kenneth Russell wrote: > While investigating > http://code.google.com/p/chromium/issues/detail?id=21921 I observed > that on Windows that when the Chrome window is resized, a Skia canvas > the size of the entire window is allocated and discarded in order to > pain

Re: [chromium-dev] PrefsService shared with OffTheRecordProfile

On Wed, Nov 25, 2009 at 11:38 AM, John Gregg wrote: > if you whitelist an origin for popups while in incognito mode, that origin > is whitelisted permanently even when you go back to normal mode. > On further reflection I'm convinced persisting these changes is wrong. I have now posted a patch

Re: [chromium-dev] PrefsService shared with OffTheRecordProfile

On Wed, Nov 25, 2009 at 12:49 PM, John Gregg wrote: > On Wed, Nov 25, 2009 at 12:26 PM, Peter Kasting wrote: > >> This is the sort of thing for which Profile::ServiceAccessType was >> invented. Ideally, things like recording whitelisted popup hosts should >> reques

Re: [chromium-dev] PrefsService shared with OffTheRecordProfile

On Wed, Nov 25, 2009 at 12:14 PM, Adam Barth wrote: > On Wed, Nov 25, 2009 at 11:38 AM, John Gregg wrote: > > if you whitelist an > > origin for popups while in incognito mode, that origin is whitelisted > > permanently even when you go back to normal mode. And in my case, it > > behaves likewi

Re: [chromium-dev] Core Text

On Mon, Nov 23, 2009 at 2:51 PM, Dirk Pranke wrote: > As an aside, have we looked at using DirectWrite() on Windows? crbug.com/25541 ("No") PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.c

Re: [chromium-dev] UI Jank Task Force Status Update

On Mon, Nov 23, 2009 at 2:58 PM, Glenn Wilson wrote: > Investigating using a flat file for safebrowsing instead of SQLite (need to > recreate bloom filter and watch disk I/O) jam crunched some numbers here. During the bloom filter recreation process we read about 50 MB and write about 40 MB.

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

On Sun, Nov 22, 2009 at 4:28 PM, Mike Belshe wrote: > I think we should have a list of low-level functionality which we just > never cleanup. > > For the items you listed, I think you should leak them all. Trying to > cleanup these items creates complicated code and ultimately won't run any > be

Re: [chromium-dev] whitlisting compilers for -Werror

On Sat, Nov 21, 2009 at 12:06 PM, Evan Martin wrote: > This works for warnings we know about now, but not warnings that will > occur in the future, which is the larger problem. > I'd say we break the automated Ubuntu builds every couple of weeks > (and get an additional report from users at about

Re: [chromium-dev] whitlisting compilers for -Werror

On Sat, Nov 21, 2009 at 10:19 AM, Evan Martin wrote: > I have been particularly frustrated with gcc warning bugs that have > been fixed in newer versions of gcc. In older gccs, the following > code produces a "variable may be used uninitialized" warning depending > on your optimization settings.

Re: [chromium-dev] Re: class has virtual method but non-virtual destructor

You did note that we're in the process of enforcing precisely what you want enforced, right? PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] class has virtual method but non-virtual destructor

On Fri, Nov 20, 2009 at 3:06 PM, James Robinson wrote: > I'd also favor just going with virtual d'tors rather than protected > non-virtual ones. Protected virtual if you want to enforce that the object > is never deleted via a ptr to the base class. > I have no opinion here so I'll let you guys

Re: [chromium-dev] class has virtual method but non-virtual destructor

On Fri, Nov 20, 2009 at 3:01 PM, Jacob Mandelson wrote: > I had the impression that at the end of the discussion you were still > against. Can you LG 201100 and 200106 ? Done. I didn't bother looking at the patch, I assume you did the right thing and followed relevant style rules. Let me know

Re: [chromium-dev] class has virtual method but non-virtual destructor

On Fri, Nov 20, 2009 at 2:53 PM, Jacob Mandelson wrote: > http://codereview.chromium.org/201100/show > Yes, that caused a large subsequent discussion at which it seemed like it was determined that this was fine. I was surprised to hear this issue come up again because I'd assumed you'd already c

Re: [chromium-dev] class has virtual method but non-virtual destructor

On Fri, Nov 20, 2009 at 1:31 PM, James Robinson wrote: > On Fri, Nov 20, 2009 at 12:59 PM, Peter Kasting wrote: > >> For a concrete example, take AutocompleteEditController, which is declared >> in autocomplete_edit.h. This is an abstract base class that names several >>

Re: [chromium-dev] class has virtual method but non-virtual destructor

On Fri, Nov 20, 2009 at 12:42 PM, Mark Mentovai wrote: > As Evan points out, there are some cases when it's not absolutely > necessary to have a base or interface class declare a virtual > destructor. For a concrete example, take AutocompleteEditController, which is declared in autocomplete_edi

[chromium-dev] Re: Memory purger available for testing

Jeremy noted yet another omission: I also clear the memory backing the LocalStorage sqlite DBs in the browser. PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] user-contributed translations

On Thu, Nov 19, 2009 at 2:17 PM, Evan Martin wrote: > Also, another option for these users is to write their own > translations and let downstream (Chromium distributors) ship them. I do think it would be nice to document somewhere how someone could build a Chromium with their own translation i

[chromium-dev] Re: Memory purger available for testing

On Wed, Nov 18, 2009 at 1:16 PM, Peter Kasting wrote: > *Currently purged: > Browser process: History backend, "Web data" backend (search keywords > etc.), Proxy resolver JS heaps, Safe Browsing backend, TCMalloc free pages > Chase noted I forgot to list one other th

[chromium-dev] Memory purger available for testing

This morning I checked in the central bits of the MemoryPurger. This allows you to start Chrome with "--purge-memory-button", which will add a button to the Task Manager called "Purge Memory". Pressing this button will attempt to free as much memory as possible* from the browser and renderer proc

Re: [chromium-dev] Linting chrome/ in pre-submit checks

On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin wrote: > Since we're talking about style, I'll note that this pattern is no > good (and I've seen it explicitly called out somewhere before). > > The problem is that your assertions are not helpful. You get > "expected 'foo', got 'bar' on line 80" bu

Re: [chromium-dev] Linting chrome/ in pre-submit checks

On Tue, Nov 17, 2009 at 11:16 AM, Elliot Glaysher (Chromium) < e...@chromium.org> wrote: > Currently, it only runs it at (gcl/git cl) > upload time and only generates warnings. In the future, it should > error at commit time, but I want to put this through a trial period so > please pay attention

  1   2   3   4   5   6   >