On Mon, 10 Jun 2024 20:19:51 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties
> line 66:
>
>> 64:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the
> This patch changes the algorithm of `Node::dominates` to make the result more
> precise, and allows the iterators of `ConcurrentHashMap` to be scalar
> replaced.
>
> The previous algorithm will return a conservative result when encountering a
> dead control flow, and only try the first two
On Mon, 10 Jun 2024 13:36:06 GMT, Robert Toyonaga wrote:
> But what about when an int is passed to isspace?
The current casts to int are incorrect as a negative value would be
sign-extended and then fail the range check. I think we have to cast to
unsigned char in all cases in the caller,
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote:
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks up the unpublished
On Mon, 10 Jun 2024 17:27:18 GMT, Iris Clark wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Regenerated after merge
>
> Marked as reviewed by iris (Reviewer).
Thanks for the review @irisclark .
I've merged in
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks up the unpublished changes from:
>
> - JDK-8330807: Update Manpage for
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks up the unpublished changes from:
>
> - JDK-8330807: Update Manpage for
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
> distributions are supported is still to be clarified, as
On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen wrote:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods
On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen wrote:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods
On Mon, 10 Jun 2024 21:38:18 GMT, Damon Nguyen wrote:
>> While we do not translate Java keywords (when used as such, e.g. "`class`
>> not allowed here"), and option names (e.g. `--class-path`) we have typically
>> translated other text that is not mandated by the language or tools, (e.g.
>>
On Mon, 10 Jun 2024 14:32:46 GMT, Emanuel Peter wrote:
>> # 1. Compare with unsafe branch
>>
>> 1. current (`5e815`)
>> https://github.com/wenshao/jdk/tree/optim_str_builder_append_202406
>> 2. unsafe (`adc220`)
>> https://github.com/wenshao/jdk/tree/optim_str_builder_append_202406_unsafe
>>
On Mon, 10 Jun 2024 22:19:49 GMT, Chris Plummer wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
> line 325:
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translation tool adjusted some definitions, which causes some
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote:
>> This is what I've determined as well. I planned to leave these untranslated
>> to reduce noise between drops as well.
>
> While we do not translate Java keywords (when used as such, e.g. "`class` not
> allowed here"), and option
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote:
> Did not look at each for translation accuracy (did some for Japanese), but
> looks good overall. It's great to see diffs in native languages, rather than
> those cryptic `\u` notation!
Justin's tool is responsible for this. Made the
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The
On Mon, 10 Jun 2024 20:20:52 GMT, Phil Race wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote:
>> This is what I've determined as well. I planned to leave these untranslated
>> to reduce noise between drops as well.
>
> While we do not translate Java keywords (when used as such, e.g. "`class` not
> allowed here"), and option
On Mon, 10 Jun 2024 20:20:26 GMT, Jonathan Gibbons wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>>
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The
On Sun, 9 Jun 2024 22:07:44 GMT, Damon Nguyen wrote:
>> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties
>> line 183:
>>
>>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach
>>> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur
>>>
On Sun, 9 Jun 2024 22:49:11 GMT, Justin Lu wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The
This issue is responsible for updating the translations of all the
localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP
1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
The translation tool adjusted some definitions, which causes some changes in
On Mon, 10 Jun 2024 12:29:32 GMT, Pavel Rappo wrote:
> Please review this fix for an intermittent test failure.
>
> On some configurations, the default `expect` timeout of 10 seconds is
> insufficient. It is increased to 20; it's hard to imagine a configuration for
> which that new value
On Mon, 10 Jun 2024 16:28:39 GMT, Daniel Jeliński wrote:
>> `GetExitCodeProcess` method is not reliable for checking if a process exited
>> already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
>> the same value is returned when the process exited with code 259. In order
On Mon, 10 Jun 2024 16:24:27 GMT, Daniel Jeliński wrote:
>> Another reason to retain the checking of GetThreadInterruptEvent is to be
>> belt and suspenders against the Java code changing and opening up a
>> potential error. At the moment, the reaper thread is encapsulated and not
>> likely
> Misc small doc updates and addition of `@Overrides` annotations.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains two additional commits
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote:
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks up the unpublished
On Fri, 7 Jun 2024 21:05:33 GMT, Joe Darcy wrote:
> Use the value tag to make the javadoc for various format-related constants
> more informative to readers. Currently the information is available by
> following the "Constant Field Values" link.
>
> I'll reflow the paragraphs before a push.
On Mon, 10 Jun 2024 17:09:27 GMT, Jorn Vernee wrote:
> The term 'subset' doesn't feel right to me here, since we're only talking
> about a single memory region (not a set of memory region**s**). I suggest
> 'sub-region' instead.
Actually, nvm, that doesn't work for `reinterpret` since the
On Mon, 10 Jun 2024 15:45:07 GMT, Per Minborg wrote:
> This PR proposes to explicitly state that returned segments form the
> `asSlice` and `reinterpret` method share memory regions with `this` memory
> segment.
>
> Note: The term "subset" means a true subset or the same set.
The term
> Use the value tag to make the javadoc for various format-related constants
> more informative to readers. Currently the information is available by
> following the "Constant Field Values" link.
>
> I'll reflow the paragraphs before a push.
Joe Darcy has updated the pull request incrementally
On Fri, 7 Jun 2024 22:16:36 GMT, Joe Darcy wrote:
>> Use the value tag to make the javadoc for various format-related constants
>> more informative to readers. Currently the information is available by
>> following the "Constant Field Values" link.
>>
>> I'll reflow the paragraphs before a
On Mon, 10 Jun 2024 15:30:39 GMT, Per Minborg wrote:
>> This PR proposes to retain the read-only state when any of the
>> `MemorySegment::reinterpret` methods is called.
>>
>> Previously, the read-only state was lost and the returned `MemorySegment`
>> was always writable regardless of the
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated
On Fri, 10 Nov 2023 08:17:22 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and
On Mon, 10 Jun 2024 13:48:08 GMT, Roger Riggs wrote:
>> I don't have a test or counter example and don't have a detailed
>> understanding of the blocking needs of Hotspot.
>
> Another reason to retain the checking of GetThreadInterruptEvent is to be
> belt and suspenders against the Java code
> `GetExitCodeProcess` method is not reliable for checking if a process exited
> already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
> the same value is returned when the process exited with code 259. In order to
> check if the process exited, we need to check if its
On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen wrote:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods
This PR proposes to explicitly state that returned segments form the `asSlice`
and `reinterpret` method share memory regions with `this` memory segment.
Note: The term "subset" means a true subset or the same set.
-
Commit messages:
- Add segments share the same backing store in
On Mon, 10 Jun 2024 14:28:25 GMT, Alan Bateman wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>>
On Fri, 7 Jun 2024 00:23:10 GMT, Stuart Marks wrote:
>> A documentation-only change to match the original intent and the implemented
>> behavior.
>
> Oh, this needs a CSR too, since it's a change to a normative assertion.
> Should be pretty simple though.
@stuart-marks A
> This PR proposes to retain the read-only state when any of the
> `MemorySegment::reinterpret` methods is called.
>
> Previously, the read-only state was lost and the returned `MemorySegment` was
> always writable regardless of the original segment's read-only state.
Per Minborg has updated
On Mon, 10 Jun 2024 15:12:59 GMT, Per Minborg wrote:
> > Note that `asSlice` methods also lacks a similar guarantee on read-only
> > (but the impl works fine there)
>
> Even though not mentioned in the original issue, we could add documentation
> for this here as well. Or maybe via
>
On Mon, 10 Jun 2024 13:45:16 GMT, Maurizio Cimadamore
wrote:
> Note that `asSlice` methods also lacks a similar guarantee on read-only (but
> the impl works fine there)
Even though not mentioned in the original issue, we could add documentation for
this here as well. Or maybe via
On Mon, 10 Jun 2024 14:59:42 GMT, Per Minborg wrote:
>> This PR proposes to retain the read-only state when any of the
>> `MemorySegment::reinterpret` methods is called.
>>
>> Previously, the read-only state was lost and the returned `MemorySegment`
>> was always writable regardless of the
> This PR proposes to retain the read-only state when any of the
> `MemorySegment::reinterpret` methods is called.
>
> Previously, the read-only state was lost and the returned `MemorySegment` was
> always writable regardless of the original segment's read-only state.
Per Minborg has updated
On Mon, 10 Jun 2024 13:04:08 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two
On Mon, 10 Jun 2024 11:28:28 GMT, Kevin Walls wrote:
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
>
On Mon, 10 Jun 2024 11:28:28 GMT, Kevin Walls wrote:
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
>
JMX uses APIs related to the Security Mananger which are deprecated. Use of
AccessControlContext will be removed when Security Manager is removed.
Until then, updates are needed to not require setting
-Djava.security.manager=allow to use JMX authentication.
-
Commit messages:
-
On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen wrote:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods
On Mon, 10 Jun 2024 03:51:40 GMT, Glavo wrote:
>> Things have changed since https://github.com/openjdk/jdk/pull/14636 was
>> closed, so let me reopen it.
>>
>> https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE
>> caused a startup regression. In order to not have any
On Fri, 7 Jun 2024 21:13:56 GMT, Roger Riggs wrote:
>> Interesting. Could you point me to a related bug / documentation / evidence?
>> I tested the WaitForSingleObject version (commit
>> 6524747a5ebc51c760b14e90309c5f18b58b20e2) on Windows 11, and I didn't
>> observe any problems with
On Mon, 10 Jun 2024 13:18:43 GMT, Per Minborg wrote:
> This PR proposes to retain the read-only state when any of the
> `MemorySegment::reinterpret` methods is called.
>
> Previously, the read-only state was lost and the returned `MemorySegment` was
> always writable regardless of the
On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen wrote:
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods
After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
primitive arrays by combining values into larger stores.
This PR rewrites the code of appendNull and append(boolean) methods so that
these two methods can be optimized by C2.
-
Commit messages:
-
On Fri, Jun 7, 2024 at 1:19 PM Ron Pressler wrote:
>
> > On 6 Jun 2024, at 18:37, David Lloyd wrote:
> >
> > Just bumping this one more time. I intend to start by opening a JIRA to
> add the two proposed methods to `ReflectionFactory`, and go from there. I
> guess that we might need a JEP for
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote:
> ### Summary
> This change ensures we don't get undefined behavior when
> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
> `isspace` accepts an `int` argument that "the application shall
This PR proposes to retain the read-only state when any of the
`MemorySegment::reinterpret` methods is called.
Previously, the read-only state was lost and the returned `MemorySegment` was
always writable regardless of the original segment's read-only state.
-
Commit messages:
-
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
> distributions are supported is still to be clarified, as
On Mon, 10 Jun 2024 04:08:41 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible
>> package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such
Please review this fix for an intermittent test failure.
On some configurations, the default `expect` timeout of 10 seconds is
insufficient. It is increased to 20; it's hard to imagine a configuration for
which that new value would still be insufficient, but we'll see.
Aside from that,
On Mon, 10 Jun 2024 04:08:41 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible
>> package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such
On Mon, 10 Jun 2024 04:08:41 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible
>> package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such
On Thu, 6 Jun 2024 12:46:36 GMT, jengebr wrote:
>> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
>> cloning of Object[0] instances. This cloning is intended to prevent callers
>> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
>> to
On Thu, 6 Jun 2024 14:29:46 GMT, Aleksey Shipilev wrote:
>> `clone()` performs a shallow copy, so there is currently no `Object[]`
>> allocated and therefore nothing to optimize. I don't think there's any work
>> to do here.
>>
>> @DougLea @viktorklang-ora can you confirm?
>
>> clone()
On Tue, 16 Apr 2024 11:47:23 GMT, Per Minborg wrote:
> # Stable Values & Collections (Internal)
>
> ## Summary
> This PR proposes to introduce an internal _Stable Values & Collections_ API,
> which provides immutable value holders where elements are initialized _at
> most once_. Stable Values
On Fri, 17 May 2024 09:31:33 GMT, Per Minborg wrote:
>> # Stable Values & Collections (Internal)
>>
>> ## Summary
>> This PR proposes to introduce an internal _Stable Values & Collections_ API,
>> which provides immutable value holders where elements are initialized _at
>> most once_. Stable
> Can I please get a review for this patch which proposes to implement the
> enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970?
>
> The commit in this PR introduces the `-o` and `--output-dir` option to the
> `jar` command. The option takes a path to a destination
On Fri, 7 Jun 2024 18:58:36 GMT, Claes Redestad wrote:
>> This PR refactors type matching in BootstrapMethodInvoker and adds a few
>> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
>> in particular the ProxyGenerator condys generated for e.g. annotation
>>
> This PR refactors type matching in BootstrapMethodInvoker and adds a few
> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
> in particular the ProxyGenerator condys generated for e.g. annotation proxies
> since
On Mon, 10 Jun 2024 08:30:59 GMT, Claes Redestad wrote:
> Trivially removing the a leftover, unused `ClassValue` from
> `java.lang.invoke.VarHandle`
This pull request has now been integrated.
Changeset: 7b43a8cd
Author:Claes Redestad
URL:
On Mon, 10 Jun 2024 08:57:23 GMT, Maurizio Cimadamore
wrote:
> Good catch!
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/19620#issuecomment-2157910277
On Fri, 7 Jun 2024 18:58:36 GMT, Claes Redestad wrote:
>> This PR refactors type matching in BootstrapMethodInvoker and adds a few
>> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
>> in particular the ProxyGenerator condys generated for e.g. annotation
>>
On Fri, 7 Jun 2024 18:58:36 GMT, Claes Redestad wrote:
>> This PR refactors type matching in BootstrapMethodInvoker and adds a few
>> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
>> in particular the ProxyGenerator condys generated for e.g. annotation
>>
On Mon, 10 Jun 2024 07:56:03 GMT, Claes Redestad wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adress review comments, add ConstantBootstraps#invoke to list of
>> recognized type signatures
>
> Sure. If you
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote:
> ### Summary
> This change ensures we don't get undefined behavior when
> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
> `isspace` accepts an `int` argument that "the application shall
On Mon, 10 Jun 2024 08:30:59 GMT, Claes Redestad wrote:
> Trivially removing the a leftover, unused `ClassValue` from
> `java.lang.invoke.VarHandle`
Good catch!
-
Marked as reviewed by mcimadamore (Reviewer).
PR Review:
On Mon, 10 Jun 2024 08:20:38 GMT, David Holmes wrote:
> > "To use these functions safely with plain chars (or signed chars), the
> > argument should first be converted to unsigned char"
>
> @tstuefe wow! Okay. That is a surprise to me. A cast to unsigned char doesn't
> actually do anything.
Trivially removing the a leftover, unused `ClassValue` from
`java.lang.invoke.VarHandle`
-
Commit messages:
- 8333824: Unused ClassValue in VarHandles
Changes: https://git.openjdk.org/jdk/pull/19620/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19620=00
Issue:
On Fri, 7 Jun 2024 06:07:17 GMT, Thomas Stuefe wrote:
> "To use these functions safely with plain chars (or signed chars), the
> argument should first be converted to unsigned char"
@tstuefe wow! Okay. That is a surprise to me. A cast to unsigned char doesn't
actually do anything. Every char
On Sat, 8 Jun 2024 00:19:55 GMT, Shaojin Wen wrote:
> After PR #16245, C2 optimizes stores into primitive arrays by combining
> values into larger stores. In the UUID.toString method,
> ByteArrayLittleEndian can be removed, making the code more elegant and faster.
This pull request has now
On Mon, 10 Jun 2024 07:32:26 GMT, Shaojin Wen wrote:
>> After PR #16245, C2 optimizes stores into primitive arrays by combining
>> values into larger stores. In the UUID.toString method,
>> ByteArrayLittleEndian can be removed, making the code more elegant and
>> faster.
>
> Shaojin Wen has
On Mon, 10 Jun 2024 07:15:51 GMT, Alan Bateman wrote:
>> Sets the version to 24/24-ea and the copyright year to 2025.
>>
>> Content changes related to the start of release (e.g. for removed options in
>> java.1) are handled separately.
>>
>> This initial generation also picks up the
On Fri, 7 Jun 2024 18:58:36 GMT, Claes Redestad wrote:
>> This PR refactors type matching in BootstrapMethodInvoker and adds a few
>> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
>> in particular the ProxyGenerator condys generated for e.g. annotation
>>
On Mon, 10 Jun 2024 07:32:26 GMT, Shaojin Wen wrote:
>> After PR #16245, C2 optimizes stores into primitive arrays by combining
>> values into larger stores. In the UUID.toString method,
>> ByteArrayLittleEndian can be removed, making the code more elegant and
>> faster.
>
> Shaojin Wen has
On Sun, 9 Jun 2024 22:45:26 GMT, Shaojin Wen wrote:
>> After PR #16245, C2 optimizes stores into primitive arrays by combining
>> values into larger stores. In the UUID.toString method,
>> ByteArrayLittleEndian can be removed, making the code more elegant and
>> faster.
>
> Shaojin Wen has
> After PR #16245, C2 optimizes stores into primitive arrays by combining
> values into larger stores. In the UUID.toString method,
> ByteArrayLittleEndian can be removed, making the code more elegant and faster.
Shaojin Wen has updated the pull request incrementally with one additional
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote:
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks up the unpublished
On Mon, 10 Jun 2024 03:51:40 GMT, Glavo wrote:
>> Things have changed since https://github.com/openjdk/jdk/pull/14636 was
>> closed, so let me reopen it.
>>
>> https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE
>> caused a startup regression. In order to not have any
99 matches
Mail list logo
