[GitHub] bitblender commented on issue #1335: DRILL-6529: Project Batch Sizing causes two LargeFileCompilation tests to timeout

bitblender commented on issue #1335: DRILL-6529: Project Batch Sizing causes two LargeFileCompilation tests to timeout URL: https://github.com/apache/drill/pull/1335#issuecomment-400823880 @vvysotskyi @ilooner NUM_PROJECT_COLUMNS controls 3 other tests besides testTopN and testExternalSor

[GitHub] vdiravka opened a new pull request #1345: DRILL-6494: Drill Plugins Handler

vdiravka opened a new pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345 - StoragePluginsHandler is added and implementation as StoragePluginsUpdater. It is used in the init() stage of StoragePluginRegistryImpl and updates storage plugi

[GitHub] vdiravka commented on issue #1345: DRILL-6494: Drill Plugins Handler

vdiravka commented on issue #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#issuecomment-400864708 @sohami Please review This is an automated message from the Apache Git Service. To resp

[GitHub] vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198689121 ## File path: pom.xml ## @@ -3334,5 +3351,6 @@ exec drill-yarn distribution +drill-sha

[GitHub] vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198690513 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,147 @@ + + +http://maven.apache.org/POM/4.0

[GitHub] vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198691250 ## File path: drill-shaded/pom.xml ## @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xs

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198701570 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunctions.java

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198711357 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198697870 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198711656 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198702179 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ##

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198698608 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java #

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198712153 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java

[GitHub] jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-400935684 Hello, @arina-ielchiieva : all comment addressed. @vrozov : idem. Please tell me if there i something else to do. r

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198766543 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunct

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198767308 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.j

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198766336 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunct

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-400969030 Me might consider the following as well: 1. Ren

[GitHub] vvysotskyi opened a new pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

vvysotskyi opened a new pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346 - Added new rule `ProjectComplexRexNodeCorrelateTransposeRule` which takes a complex expression from the `Project` below

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198845203 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunctions.java

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198850069 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunctions.java

[GitHub] cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

cgivre commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198850630 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.java #

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198845924 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198860410 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198850903 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198853972 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198843370 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198845852 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198843505 ## File path: distribution/src/resources/storage-plugins-example.conf ## @@ -0,0 +1,66 @@ +# Licensed to the

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198846789 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198856932 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198842531 ## File path: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java ## @@ -36,11 +36,11 @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198851192 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198850089 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198847899 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java ##

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198850354 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsUpdater.java ## @@ -0,

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198844552 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198847564 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -393,7 +393,11 @@ drill.exec: { /

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198853478 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ## @@ -248,6 +248,12 @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198860533 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198848825 ## File path: common/src/main/java/org/apache/drill/common/exceptions/DrillIOException.java ## @@ -19,24 +1

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198849010 ## File path: logical/src/main/java/org/apache/drill/common/config/LogicalPlanPersistence.java ## @@ -37,12

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198842843 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198860138 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginsHandler.java ## @@ -0,

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198845190 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198843228 ## File path: distribution/src/resources/drill-override-example.conf ## @@ -251,6 +251,9 @@ drill.exec: {

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198844976 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginMap.java ## @@ -111,7 +

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198854651 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198844037 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java ## @@

[GitHub] arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198852690 ## File path: common/src/main/java/org/apache/drill/common/config/CommonConstants.java ## @@ -31,4 +31,7 @@

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198861948 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunct

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198863368 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.j

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198863368 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.j

[GitHub] HanumathRao opened a new pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

HanumathRao opened a new pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347 @amansinha100 Please review this PR. This PR includes. 1) Two new Rules for Push Project into lateral join and push project pas

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198882164 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198882619 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198886170 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198896839 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198899847 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetPushDownFilter.j

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198900647 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198907027 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198910736 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198910755 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java #

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198911099 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ###

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198911603 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java #

[GitHub] ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401101245 @Ben-Zvi addressed review comments. please take a look. This is an automate

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198832226 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,133 @@ + + +http://maven.apache.org/POM

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198905422 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,147 @@ + + +http://maven.apache.org/POM

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198904728 ## File path: drill-shaded/pom.xml ## @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198903696 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,133 @@ + + +http://maven.apache.org/POM

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198907077 ## File path: pom.xml ## @@ -3334,5 +3351,6 @@ exec drill-yarn distribution +drill

[GitHub] ilooner-mapr commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

ilooner-mapr commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401113654 Thx @vvysotskyi @arina-ielchiieva. I will do the renam

[GitHub] sohami closed pull request #1323: DRILL-6498: Support for EMIT outcome in ExternalSortBatch

sohami closed pull request #1323: DRILL-6498: Support for EMIT outcome in ExternalSortBatch URL: https://github.com/apache/drill/pull/1323 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] Agirish opened a new pull request #1348: DRILL-6346: Create an Official Drill Docker Container

Agirish opened a new pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348 Added apache-release profile in distribution/pom.xml to build a Docker image once the project is built successfully. While the Docker image can be b

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401134771 @ilooner maybe can consider allowing stout to ease

[GitHub] arina-ielchiieva edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

arina-ielchiieva edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401134771 @ilooner maybe we can consider allowing sto

[GitHub] vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349 @arina-ielchiieva Please review This is an automated message from the A

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198962585 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ##

[GitHub] Agirish opened a new pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

Agirish opened a new pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350 Added an "Export" button to enabled storage plugins to support exporting the configuration into a JSON file. This can be useful to backup

[GitHub] kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199022055 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6 +38,7

[GitHub] kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199022430 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6 +48

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199019017 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LateralJoinP

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199022923 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUti

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199018067 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectL

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199016141 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLateralJo

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199020924 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectP

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199023543 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ###

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026541 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6 +38,7

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026644 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6 +48

[GitHub] Ben-Zvi closed pull request #1340: DRILL-6539: Record count not set for this vector container error

Ben-Zvi closed pull request #1340: DRILL-6539: Record count not set for this vector container error URL: https://github.com/apache/drill/pull/1340 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] Ben-Zvi closed pull request #1341: DRILL-6512: Remove unnecessary processing overhead from RecordBatchSizer

Ben-Zvi closed pull request #1341: DRILL-6512: Remove unnecessary processing overhead from RecordBatchSizer URL: https://github.com/apache/drill/pull/1341 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] HanumathRao commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

HanumathRao commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#discussion_r199027667 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl

[GitHub] HanumathRao commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

HanumathRao commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-401215354 @vvysotskyi Thanks for making the code changes. Code changes look good to me. +1.

[GitHub] chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199033434 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199034500 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6 +48

[GitHub] chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199036078 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199031792 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Va

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198932595 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ##

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198941031 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ba

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198933150 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionMan

  1   2   3   4   5   6   7   8   9   10   >