Re: Release Lucene/Solr 8.9.0 should we have it soon

Thanks Mayya. I took a stab at summarizing Solr highlights in https://cwiki.apache.org/confluence/display/SOLR/ReleaseNote89 Jan > 6. jun. 2021 kl. 16:43 skrev Mayya Sharipova > : > > Hello everyone, I would appreciate help with with following for 8.9 release: > Release Highlights. I gave it

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hello everyone, I would appreciate help with with following for 8.9 release: 1. *Release Highlights*. I gave it a try for Lucene (but I don't have experience to judge what qualifies as a release highlight, so please edit/remove/add). Edits can be done here: Lucene Release Note 8.9

Re: Release Lucene/Solr 8.9.0 should we have it soon

SOLR-15316 / PR 2502 is now merged to branch_8_9 Jan > 3. jun. 2021 kl. 20:53 skrev Mayya Sharipova > : > > I can wait till this PR 2502 is backported (hopefully by tomorrow? and > hopefully will be the last item to wait for). > And tomorrow I will try to build a RC. > > > > On Thu, Jun 3,

Re: Release Lucene/Solr 8.9.0 should we have it soon

I can wait till this PR 2502 is backported (hopefully by tomorrow? and hopefully will be the last item to wait for). And tomorrow I will try to build a RC. On Thu, Jun 3, 2021 at 8:57 AM Cassandra Targett wrote: > It’s OK with me, but I’m not really in a position to understand the > changes

Re: Release Lucene/Solr 8.9.0 should we have it soon

It’s OK with me, but I’m not really in a position to understand the changes and/or test it. And while we have a branch, I’m not clear on when the first RC is planned, so Mayya should weigh in I think. Cassandra On Jun 3, 2021, 5:49 AM -0500, Jan Høydahl , wrote: > Mayya, Cassandra, I'd like to

Re: Release Lucene/Solr 8.9.0 should we have it soon

Mayya, Cassandra, I'd like to merge the Jetty upgrade, SOLR-15316 to branch_8x and branch_8_9. See backport PR https://github.com/apache/lucene-solr/pull/2502 Is that ok? Jan > 2. jun. 2021 kl. 01:00 skrev Jan Høydahl : > > Cassandra, > > Thanks for spotting the Jetty JIRA (SOLR-15316 >

Re: Release Lucene/Solr 8.9.0 should we have it soon

I think jetty 9.4.40.v20210413 wouldbe better，because I found https://github.com/eclipse/jetty.project/issues/6121 may result a search response error. -- Original -- From: Cassandra Targett https://issues.apache.org/jira/browse/SOLR-15316 Sorry, I’m way

Re: Release Lucene/Solr 8.9.0 should we have it soon

Cassandra, Thanks for spotting the Jetty JIRA (SOLR-15316 ). I put up a quck PR for upgrading Jetty to 9.4.41.v20210516. Currently running all tests. Due to the CVEs I think there should not be a new

Re: Release Lucene/Solr 8.9.0 should we have it soon

This is really frustrating. We have a feature that never should have been committed. The behavior and documentation don’t match and the inputs are limited to values that make it unusable. The documentation contains a nonfunctional link. I contribute a patch that implements both the original

Re: Release Lucene/Solr 8.9.0 should we have it soon

I got a question this morning about some Jetty CVEs that look to be fixed with Jetty 9.4.39, and there’s an issue marked as a Blocker (with no version) to upgrade to that version. Is there time to do that for 8.9? Or is it too high risk or would take too long? 

Re: Release Lucene/Solr 8.9.0 should we have it soon

+1 to Jan's comment; no need to hold up the release. I also think we should be open to more releases in the future for 8.x. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, Jun 1, 2021 at 4:55 PM Jan Høydahl wrote: > Let's not hold up the

Re: Release Lucene/Solr 8.9.0 should we have it soon

Let's not hold up the release due to this incomplete PR. It obviously needs more time for completion and there is always a new train to catch. As far as I understand, Circuit breakers are pluggable, so anyone can configure their own implementation in the meantime? Jan > 1. jun. 2021 kl. 22:13

Re: Release Lucene/Solr 8.9.0 should we have it soon

I appreciate you fixing this and adding the new circuit breaker and look forward to having it in the hands of our users soon. However, the current state of PR, with significant API churn for a single change and overlapping code is not yet ready. If this is too much of a rework, I am happy to

Re: Release Lucene/Solr 8.9.0 should we have it soon

I would appreciate a second opinion on the pull request. Substantive issues have been resolved. At this point, the discussion is about code style and coding standards. I don’t have detailed knowledge about the Solr coding style, so I’d appreciate another set of eyes. The current behavior is

Re: Release Lucene/Solr 8.9.0 should we have it soon

As I mentioned in the PR, my two main objections are: 1. Introduction of SolrCore to CircuitBreakerManager. It causes a significant API churn and is not needed by any other circuit breaker. 2. Duplication of code -- there is a significant overlap between the code for the two circuit breakers.

Re: Release Lucene/Solr 8.9.0 should we have it soon

I answered the comments. I don’t see those answers on github, oddly. I’ll re-answer them. Most of your questions are already answered in the discussion on Jira. I central issues is that load average is not always a CPU measure. In some systems, it includes threads in iowait. So it is

Re: Release Lucene/Solr 8.9.0 should we have it soon

Sorry, Walter, that I rushed to create a new branch. Please let me know when your changes are merged to 8.x and 8.9 ( I guess you need to backport to the new 8.9 branch as well), and I will continue the release process from there. On Tue, Jun 1, 2021 at 3:21 PM Atri Sharma wrote: > I tool a

Re: Release Lucene/Solr 8.9.0 should we have it soon

I tool a look at the PR and gave comments for SOLR-15056, and the last I checked, my comments were not addressed? On Wed, 2 Jun 2021, 00:31 Walter Underwood, wrote: > Could someone else please take a look at SOLR-15056? This is a small blast > radius change that improves the circuit breakers.

Re: Release Lucene/Solr 8.9.0 should we have it soon

Could someone else please take a look at SOLR-15056? This is a small blast radius change that improves the circuit breakers. It includes unit tests and documentation and has been ready since January. https://github.com/apache/solr/pull/96/files

Re: Release Lucene/Solr 8.9.0 should we have it soon

Thank you for the update, Houston. I've started the release process, the branch 8.9 is now cut. On Tue, Jun 1, 2021 at 11:21 AM Houston Putman wrote: > Mayya, SOLR-14978 is now in 8.x. So no longer a blocker. > > - Houston > > On Thu, May 27, 2021 at 11:42 PM David Smiley wrote: > >>

Re: Release Lucene/Solr 8.9.0 should we have it soon

Mayya, SOLR-14978 is now in 8.x. So no longer a blocker. - Houston On Thu, May 27, 2021 at 11:42 PM David Smiley wrote: > SOLR-15412 is rather serious as the title suggests. I haven't been > tracking the progress so if it's already resolved, that's unknown to me and > isn't reflected in JIRA.

Re: Release Lucene/Solr 8.9.0 should we have it soon

SOLR-15412 is rather serious as the title suggests. I haven't been tracking the progress so if it's already resolved, that's unknown to me and isn't reflected in JIRA. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Thu, May 27, 2021 at 5:24 PM

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hey Mayya, would you mind to wait until at least Tuesday (6/1)? We are trying to backport SOLR-14978 to 8.x, and would really like it included in 8.9. - Houston On Thu, May 27, 2021 at 5:24 PM Mayya Sharipova wrote: > Hello everyone, > I wonder if everyone is ok for May 31st (Monday) as the

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hello everyone, I wonder if everyone is ok for May 31st (Monday) as the date for the feature freeze date and branch cut? I've noticed that `releaseWizard.py` is also asking for the length of feature freeze. What is the custom length to put there? Looks like Lucene

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hello, Eric was going to have a look at the PR. But if it isn't done in time then I don't think it needs to block the release Thanks On Tue, 25 May 2021 at 15:50, Mayya Sharipova wrote: > Hello Colvin, > I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr > 8.9 release? >

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hello Colvin, I am wondering if you still want to merge SOLR-15410 for the Lucene/Solr 8.9 release? Should we have a deadline for feature freeze? Say May 30th (Sunday)? Thank you. On Tue, May 18, 2021 at 8:49 AM Noble Paul wrote: > +1 > > > On Tue, May 18, 2021 at 9:30 PM Colvin Cowie >

Re: Release Lucene/Solr 8.9.0 should we have it soon

+1 On Tue, May 18, 2021 at 9:30 PM Colvin Cowie wrote: > > Hello, > > I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging when > using new versions of OpenJ9. It's small, so if somebody could have a look at > it in time for 8.9 that would be great > > Thanks, > Colvin > >

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hello, I raised SOLR-15410 yesterday with a PR to fix an issue with GC logging when using new versions of OpenJ9. It's small, so if somebody could have a look at it in time for 8.9 that would be great Thanks, Colvin On Thu, 13 May 2021 at

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hi Mayya, I would like to backport LUCENE-9935 , which enables bulk-merge for stored fields with index sort, to 8.x this weekend. The patch is ready , but we prefer to give CI some cycles before

Re: Release Lucene/Solr 8.9.0 should we have it soon

Perhaps https://issues.apache.org/jira/browse/SOLR-15378 should be investigated before 8.9, maybe make it a blocker? On Thu, May 13, 2021 at 1:35 AM Robert Muir wrote: > Mayya, I created backport for Adrien's issue here, to try to help out: > https://github.com/apache/lucene-solr/pull/2495 > >

Re: Release Lucene/Solr 8.9.0 should we have it soon

Mayya, I created backport for Adrien's issue here, to try to help out: https://github.com/apache/lucene-solr/pull/2495 Personally, I felt that merging non-trivial changes from main branch to 8.x has some additional risks when cherry-picking: * structural changes in main branch making merging more

RE: Release Lucene/Solr 8.9.0 should we have it soon

Høydahl Sent: Wednesday, May 12, 2021 10:21 AM To: dev@lucene.apache.org Subject: Re: Release Lucene/Solr 8.9.0 should we have it soon +1 to a 8.9 release I'm working on a few Solr backports that will land soon. Jan 12. mai 2021 kl. 09:46 skrev Peter Gromov mailto:peter.gro

Re: Release Lucene/Solr 8.9.0 should we have it soon

+1 to a 8.9 release I'm working on a few Solr backports that will land soon. Jan > 12. mai 2021 kl. 09:46 skrev Peter Gromov > : > > I can try backporting Hunspell improvements > (https://issues.apache.org/jira/browse/LUCENE-9687 > ) to

Re: Release Lucene/Solr 8.9.0 should we have it soon

I can try backporting Hunspell improvements ( https://issues.apache.org/jira/browse/LUCENE-9687) to 8.x, unless you think it's too large a change. On Tue, May 11, 2021 at 7:29 PM Mayya Sharipova wrote: > Thanks everyone, > > Adrien, I am happy to try to be a release manager for this release. >

Re: Release Lucene/Solr 8.9.0 should we have it soon

Hi Mayya, How much time would you give us for this release (until feature freeze)? I have some package manager related changes (that might take a week to fully build and test) that need to get into 8x so that users can seamlessly upgrade to 9x. Based on your proposed timeline, I'll work on it

Re: Release Lucene/Solr 8.9.0 should we have it soon

Thanks everyone, Adrien, I am happy to try to be a release manager for this release. Adrien, and Gus, please let me know when your changes are merged to 8.x On Tue, May 11, 2021 at 10:38 AM Gus Heck wrote: > I'm also looking to find time to get >

Re: Release Lucene/Solr 8.9.0 should we have it soon

I'm also looking to find time to get https://issues.apache.org/jira/browse/SOLR-14597 into some sort of 8x. I've recently completed the back port of 2/3 of the lucene tickets that are related, and hope to work on the third tomorrow I had some feedback there, but I think folks were waiting for

Re: Release Lucene/Solr 8.9.0 should we have it soon

I would like to backport LUCENE-9827 before we release 8.9, a performance regression to stored fields merges. I'll work on this as soon as possible. On Thu, May 6, 2021 at 10:28 PM Adrien Grand wrote: > +1 > > Mayya, are you volunteering to be

Re: Release Lucene/Solr 8.9.0 should we have it soon

+1 Mayya, are you volunteering to be the release manager? Le jeu. 6 mai 2021 à 18:06, Ishan Chattopadhyaya a écrit : > +1 > > On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova > wrote: > >> Hello everyone, >> I was wondering if we can have a 8.9.0 release. It has been more than 3 >> months since

Re: Release Lucene/Solr 8.9.0 should we have it soon

+1 On Thu, May 6, 2021 at 7:50 PM Mayya Sharipova wrote: > Hello everyone, > I was wondering if we can have a 8.9.0 release. It has been more than 3 > months since 8.8.0 was released. > 8.9.0 doesn't need to be the last release in the 8.x series. > > Thanks. >