---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21098/#review42250
---
Ship it!
Ship It!
- Vinod Kone
On May 6, 2014, 5:41 a.m
debugged with the help of benm.
https://issues.apache.org/jira/browse/MESOS-1310
On Sun, May 4, 2014 at 10:11 PM, Benjamin Hindman b...@eecs.berkeley.eduwrote:
This is a rather peculiar issue ... has anybody else seen this crash
before?
On Sun, May 4, 2014 at 5:23 PM, Apache Jenkins
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21122/#review42326
---
Ship it!
Ship It!
- Vinod Kone
On May 6, 2014, 6:02 p.m., Ian
/#comment76128
Some one mentioned this on the MesosJenkins GitHub yesterday.
This check for executable no longer works because a new letter [XN] is
appended to the end of the URI.
This should be:
s/token.substr(pos + 1)/token.substr(pos + 1, 1)/
- Vinod Kone
a TODO for now.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18730/#review42577
---
On May 9, 2014, 6:12 p.m., Vinod Kone
/21176/#comment76250
s/Re-start/Restart/
src/tests/master_tests.cpp
https://reviews.apache.org/r/21176/#comment76251
s/WillRepeatedly(Return())/Times(0)/ ?
- Vinod Kone
On May 7, 2014, 11:05 p.m., Ben Mahler wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21180/#review42445
---
Ship it!
Ship It!
- Vinod Kone
On May 7, 2014, 11:05 p.m., Ben
hmm..you should be able to. are you logged in?
On Sun, May 11, 2014 at 11:09 AM, Steven Phung stph...@gmail.com wrote:
Hello,
For some reason I don't have permission to assign tasks to myself. About
two weeks ago when I first joined looking to contribute I did have
permission, could
check
Thanks,
Vinod Kone
/21186/#comment76307
s/Re-start/Restart/
- Vinod Kone
On May 8, 2014, 1:15 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21186
0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
---
make check
Thanks,
Vinod Kone
.
Bugs: MESOS-1234
https://issues.apache.org/jira/browse/MESOS-1234
Repository: mesos-git
Description
---
See summary.
Diffs
-
support/verify-reviews.py 1d6356887b36354069b763771ea86341bd60fb7b
Diff: https://reviews.apache.org/r/20617/diff/
Testing
---
Thanks,
Vinod
the capabilities checked in check()?
- Vinod Kone
On May 9, 2014, 10:27 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21269
/linux/routing/filter/arp.cpp
https://reviews.apache.org/r/20296/#comment76715
new line.
- Vinod Kone
On April 28, 2014, 5:03 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
in the message.
- Vinod Kone
On April 28, 2014, 5:04 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297
dominic, can you triage this?
@vinodkone
On Mon, May 12, 2014 at 6:18 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2119/changes
Changes:
[yujie.jay] Add a return statement to
/20295/#comment76709
Why not take action::Action and use the dynamic cast trick in an earlier
review?
src/linux/routing/filter/icmp.hpp
https://reviews.apache.org/r/20295/#comment76710
No update for Redirect action?
- Vinod Kone
On April 28, 2014, 5:02 p.m., Jie Yu wrote
/#comment76735
How about taking the list of file names to run the linter against as
command line args to mesos-style.py?. I think thats more flexible and lets
users feed it whatever files they want.
e.g., 'git diff --name-only | xargs ./support/mesos-style.py'
- Vinod Kone
On May 13, 2014
here?
src/linux/routing/queueing/internal.hpp
https://reviews.apache.org/r/20781/#comment76702
s/queue/queueing/ ?
src/linux/routing/queueing/internal.hpp
https://reviews.apache.org/r/20781/#comment76703
s/queue/queueing/ ?
- Vinod Kone
On May 9, 2014, 10:27 p.m., Jie Yu wrote
doesnt look this belongs to mesos group. s/mesos/aurora/ ?
On Tue, May 13, 2014 at 10:49 AM, Dominic Hamon dha...@twopensource.comwrote:
---
This is an automatically generated e-mail. To reply, visit:
).
So, updating the terminal task counts with the latter but not the former
seems misleading.
Lets update the counters after we fix the slave to do the right thing.
- Vinod Kone
On May 13, 2014, 7:35 p.m., Dominic Hamon wrote
called after all the pending updates for a task are
ACKed. i think it's better for these counters to reflect when a task
transitions to terminal state instead of when its updates are acked.
- Vinod Kone
On May 12, 2014, 8:53 p.m., Dominic Hamon wrote
or something) that could override the default filtering rules
too if someone needs it.
- Vinod Kone
On May 13, 2014, 9:56 p.m., Steven Phung wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/#comment76725
Why not have remove() return a Future that gets satisfied when the link is
removed. Are there other cases where 'wait' will be used?
Also, if we do we need wait, I would recommend
s/wait/removed/ to be more explicit.
- Vinod Kone
On May 7, 2014, 12:29 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21360/#review42947
---
Ship it!
Ship It!
- Vinod Kone
On May 14, 2014, 4:24 a.m
e-mail. To reply, visit:
https://reviews.apache.org/r/21360/
---
(Updated May 14, 2014, 4:24 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-1349
https://issues.apache.org/jira/browse/MESOS-1349
Repository
check
Thanks,
Vinod Kone
Hamon.
Repository: mesos-git
Description
---
See summary.
Diffs
-
docs/mesos-developers-guide.md d195bded640dd4f55672b75ad1cc5f0ea4aa9fd7
support/hooks/pre-commit PRE-CREATION
Diff: https://reviews.apache.org/r/21439/diff/
Testing
---
Tested locally.
Thanks,
Vinod Kone
On May 14, 2014, 6:07 a.m., Vinod Kone wrote:
Ship It!
Committed this with a minor fix. Thanks Steven.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21360/#review42947
f8ed65bf7b7e4f3c0834c9e22a525137856e9b23
src/tests/mesos.cpp 242d98ad195a8ab1256918c48a2956e2e085d26d
Diff: https://reviews.apache.org/r/21445/diff/
Testing
---
make check
Thanks,
Vinod Kone
.
e.g: s/unregister_slave_messages/messages_unregister_slave/
- Vinod Kone
On May 14, 2014, 5:40 p.m., Jiang Yan Xu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21399
/slave/containerizer/isolators/cgroups/perf_event.cpp
https://reviews.apache.org/r/20963/#comment76987
can you print the cgroup name too?
- Vinod Kone
On May 1, 2014, 6:42 p.m., Ian Downes wrote:
---
This is an automatically generated e
/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
---
make check
Thanks,
Vinod Kone
f461a1515e7bafac677f2d0bcdd499f57ba3f029
src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21175/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21141/#review43074
---
Ship it!
Ship It!
- Vinod Kone
On May 15, 2014, 12:47 a.m., Jie
: https://reviews.apache.org/r/21464/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21182/#review42515
---
Ship it!
Ship It!
- Vinod Kone
On May 8, 2014, 12:56 a.m
://reviews.apache.org/r/21439/#review42994
---
On May 14, 2014, 5:43 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21439
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21464/#review43057
---
On May 14, 2014, 11:06 p.m., Vinod Kone wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21190/#review42527
---
Ship it!
Ship It!
- Vinod Kone
On May 8, 2014, 1:32 a.m., Jie
expectation, that of not
receiving a status update, correct?
- Vinod Kone
On May 9, 2014, 12:06 a.m., Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21249
and see if
it works as expected?
- Vinod Kone
On May 11, 2014, 7:07 p.m., Steven Phung wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21257
---
On May 14, 2014, 11:06 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21464
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21457/#review43032
---
Ship it!
Ship It!
- Vinod Kone
On May 14, 2014, 9:23 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21269/#review43073
---
Ship it!
Ship It!
- Vinod Kone
On May 15, 2014, 12:43 a.m., Jie
, visit:
https://reviews.apache.org/r/21464/#review43067
---
On May 14, 2014, 11:06 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
85c57b29f6a56683e0df9788dea64ebb36e00812
src/tests/slave_tests.cpp 29dc7d434646998b04481e9ae6fe8589d7fed8e7
Diff: https://reviews.apache.org/r/21464/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21462/#review43028
---
Ship it!
Ship It!
- Vinod Kone
On May 14, 2014, 9:31 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20295/#review43017
---
Ship it!
Ship It!
- Vinod Kone
On April 28, 2014, 5:02 p.m
87ea77aa19e482a20f081061e81acc89582eacdd
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
---
make check
Thanks,
Vinod Kone
On May 8, 2014, 5:55 p.m., Vinod Kone wrote:
Title: s/ensure/ensures/ ?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21186/#review42516
/events/Events/
End with a period.
include/mesos/mesos.proto
https://reviews.apache.org/r/21442/#comment77150
s/Epoch/epoch/ ?
include/mesos/mesos.proto
https://reviews.apache.org/r/21442/#comment77152
Why are these doubles instead of uint64?
- Vinod Kone
On May 14, 2014, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21505/#review43195
---
Ship it!
Ship It!
- Vinod Kone
On May 16, 2014, 12:22 a.m., Jie
to enable it.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21439/#review43128
---
On May 14, 2014, 5:43 p.m., Vinod Kone wrote
/#comment77169
Is there a sensible default than empty?
src/slave/flags.hpp
https://reviews.apache.org/r/21451/#comment77170
This should be optional if we want a default of none.
- Vinod Kone
On May 14, 2014, 10:05 p.m., Ian Downes wrote
63b6cdc9634608ac730de7194fb8ed0baadb9a77
src/webui/master/static/home.html ea9444ae966d3fb68e749780c075eea037b2909c
Diff: https://reviews.apache.org/r/21501/diff/
Testing
---
Tested locally w/ and w/o an elected master. Web UI handles electedTime being
None correctly.
Thanks,
Vinod Kone
939a08d0ed25293d103728864c2b5e79f04a1b42
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21175/diff/
Testing
---
make check
Thanks,
Vinod Kone
()) {
...
return;
}
...
...
src/tests/cgroups_tests.cpp
https://reviews.apache.org/r/21443/#comment77164
end with period.
src/tests/isolator_tests.cpp
https://reviews.apache.org/r/21443/#comment77165
Hmm..Does this belong to this review?
- Vinod Kone
On May 14, 2014, 10:05
ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
Hey folks,
We just added a git pre-commit hook to our repo 'support/hooks/pre-commit'
that automates the style check*.
To enable it just do:
$ ln -s ../../support/hooks/pre-commit .git/hooks/pre-commit
Hopefully this will reduce some round trip times on the reviews regarding
style check
,
Vinod Kone
15, 2014, 2:52 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21464/
---
(Updated May 15, 2014, 2:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21562/#review43275
---
Ship it!
Ship It!
- Vinod Kone
On May 16, 2014, 5:56 p.m
/21189/#comment76308
s/Re-start/Restart/
- Vinod Kone
On May 8, 2014, 1:28 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21189
/parse.hpp
a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
3e511355e1faf7160442799e1e08d59b6f3b2f37
Diff: https://reviews.apache.org/r/21590/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
and osx) and sudo make
check (linux).
- Vinod Kone
On May 16, 2014, 11:02 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21585
/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
On May 16, 2014, 5:51 p.m., Vinod Kone wrote:
Hmm. I tested this on a branch with two commits. Neither the diffs nor the
titles seem to be correct. Both the generated reviews had the same diff and
title!?
Steven Phung wrote:
That's not good... let me look into this further
:43 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21501/
---
(Updated May 15, 2014, 10:43 p.m.)
Review
Monit usage for Mesos @Twitter is very basic. For both master and slave,
monit pings a known endpoint (/health or /stats.json) and restarts the
process if it fails to respond within a timeout (with retries).
The motivation for self-healing is that it is co-ordinated via master (as
you alluded
Thanks,
Vinod Kone
, 2014, 1:13 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/
---
(Updated May 17, 2014, 1:13 a.m
On May 18, 2014, 5:01 p.m., Jiang Yan Xu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, lines
81-82
https://reviews.apache.org/r/21565/diff/3/?file=583935#file583935line81
What if it's a relative path? Who should call os::realpath()?
Vinod Kone wrote
a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
/#review43402
---
On May 19, 2014, 9:28 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565
/21721/diff/
Testing
---
libprocess make check
Thanks,
Vinod Kone
---
stout make check
Thanks,
Vinod Kone
a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
---
make check
Thanks,
Vinod Kone
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21665/#review43533
---
Ship it!
- Vinod Kone
On May 19, 2014, 10:09 p.m., Jiang Yan Xu
On May 16, 2014, 5:51 p.m., Vinod Kone wrote:
Hmm. I tested this on a branch with two commits. Neither the diffs nor the
titles seem to be correct. Both the generated reviews had the same diff and
title!?
Steven Phung wrote:
That's not good... let me look into this further
ian, looks like execenv was not added to the distribution/Makefile?
@vinodkone
On Tue, May 20, 2014 at 6:58 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2122/changes
Changes:
[vinod]
-
src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673
src/tests/master_tests.cpp 1ea1da685420aeee4cbed4765d7cfdf31fc7231f
Diff: https://reviews.apache.org/r/21750/diff/
Testing
---
make check
Thanks,
Vinod Kone
://reviews.apache.org/r/21777/#comment77916
What is the exact warning that you are seeing in clang 3.4? Does it fail
compilation?
Also, would it be better to overload the copy constructor of Result for
Unreachable?
- Vinod Kone
On May 21, 2014, 4:24 p.m., Dominic Hamon wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21778/#review43638
---
Ship it!
Ship It!
- Vinod Kone
On May 21, 2014, 4:54 p.m
/21783/#comment77939
It is kinda bad that an invalid hostname would take up to 'timeout' (10s)
for a FATAL error. Too bad the return code of getaddrs() in ZK C client is not
exposed to zookeeper_init(). But oh well, I can't figure out if there is a
better way.
- Vinod Kone
On May
this even compile!?
- Vinod Kone
On May 15, 2014, 6:15 p.m., Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545
?
3rdparty/libprocess/src/tests/metrics_tests.cpp
https://reviews.apache.org/r/20918/#comment77955
yay!
3rdparty/libprocess/src/tests/metrics_tests.cpp
https://reviews.apache.org/r/20918/#comment77956
I'm confused on what this is trying to test. Maybe some comments are in
order?
- Vinod Kone
/#comment77957
In our tests that bring up multiple schedulers (e.g., fault tolerance) is
this safe? Doesn't this metric collide?
- Vinod Kone
On May 16, 2014, 10:33 p.m., Dominic Hamon wrote:
---
This is an automatically generated e-mail
Master stores a cache of completed tasks. Currently the cache capacity
(MAX_COMPLETED_TASKS_PER_FRAMEWORK) is set to 1000 though we could make it
could make it configurable.
On Wed, May 21, 2014 at 2:18 PM, Sharma Podila spod...@netflix.com wrote:
I see that master/state.json has state
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21788/#review43670
---
Ship it!
Ship It!
- Vinod Kone
On May 21, 2014, 10:24 p.m., Ben
Diff: https://reviews.apache.org/r/21590/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
from DEFAULT_CREDENTIAL here?
- Vinod Kone
On May 21, 2014, 10:01 p.m., Jiang Yan Xu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21787
://reviews.apache.org/r/21723/#review43674
---
On May 20, 2014, 8:34 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21723
/src/tests/owned_tests.cpp
234469b5e549fc7345ee2912c32c63aa3bb95a13
Diff: https://reviews.apache.org/r/21721/diff/
Testing
---
libprocess make check
Thanks,
Vinod Kone
Diff: https://reviews.apache.org/r/21590/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
Diff: https://reviews.apache.org/r/21590/diff/
Testing
---
stout make check
Thanks,
Vinod Kone
901 - 1000 of 3317 matches
Mail list logo
