Hi!
I thought about creating some logic to detect if a ExtensionFilter is
configured.
To archive this, I'll add - say in HtmlFormRenderer (dont know the exact
name now, any other component will be fine too) in encodeStart something
like:
if (not checked in session)
{
new
Hi!
Didn't the extensions filter at one time put a flag in the request as it came
in? This would solve both use cases wouldn't it? Then you wouldn't even
need to parse the dd.
Yes, you are right.
So for the use case where the extensionsFilter buffers and parses the
response I can check
Hi!
Could one please review my commit r390142 (see commits@).
It is a try to throw an exception if one add more then one child to a
facet. I've done this after I 2 hours of searching a problem in our
application just to figure out it was due to multiple facet children.
The if (id) stuff is
Hi!
So does anyone have any objections to my new branch creation?
I am fine with it. We use a current snapshot in our production
environment and it works.
---
Mario
Hi!
Modified:
myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/ajax/api/AjaxDecodePhaseListener.java
URL:
Hi!
URL: http://issues.apache.org/jira/browse/TOMAHAWK-195
Could someone with more maven knowledge have a look at it please.
I guess there is some parsing missing.
Thanks!
Ciao,
Mario
tried this yet? Would it be possible, and are there any
pitfalls?
regards,
Jurgen
--
mfg
Mario Ivankovits - OPS EDV Vertriebsges.m.b.H.
Software Engineering
Michael-Bernhard-Gasse 10, A-1120 Wien
Tel.: +43-1-8938810
Fax: +43-1-8938810/3700
E-Mail: [EMAIL PROTECTED]
Skype: mario_ivankovits
[ http://issues.apache.org/jira/browse/MYFACES-1167?page=all ]
Mario Ivankovits resolved MYFACES-1167:
---
Resolution: Fixed
Its fixed in svn head now.
You have to have the tomahawk.jar in your classpath as this functionality is
now exclusively
[ http://issues.apache.org/jira/browse/MYFACES-1167?page=all ]
Mario Ivankovits closed MYFACES-1167:
-
No javascript with MyFaces Facelets
-
Key: MYFACES-1167
URL: http://issues.apache.org
Hi Manfred!
There are actually two questions to solve:
* should we move DummyForm to tomahawk at all?
At least we have to move DummyForm out of shared as it didnt work in
this refactored environment. I already wrote about the problem.
If the answer to the first question is yes the answer
Hi!
Currently the base classes for the command* tags (in shared) implement
the functionality of dummyForm, this is why its not needed to have the
overloaded renderer stuff and why it works with h: and t:
Sorry for being slow-witted.
There is no difference. If the user overwrites the
Hi!
Its again me ... somewhat angry, so sorry *g* I CANT SET A
BREAKPOINT IN SHARED ANY MORE - or I have to do it twice in shared_impl
and shared_tomahawk.
Please lets discuss again why this refactoring is needed - PLEASE !!!
Now I propose to get rid of all those class.getName() (or
Hi!
java.lang.ClassCastException:
org.apache.myfaces.shared_impl.renderkit.html.util.DummyFormRequestInfo
at
org.apache.myfaces.shared_tomahawk.renderkit.html.util.DummyFormUtils.getDummyFormParameters(DummyFormUtils.java:121)
at
Hi!
I'm still very much in favour of *not* shipping a common jar used by
both core and tomahawk (and maybe tobago, ADF, etc); the versioning
issues related to that are nasty.
Why? Once the shared api is stable this should not be a big issue, no?
I've already moved stuff to tomahawk to reach
Hi Martin!
the question is - do we need and want it in impl?
I dont need it there - but it only moves the problem away FOR NOW, it
will arise again - I bet. The interoperability is still broken.
I can refactor (again) to put the dummyForm stuff into tomahawk - Who
needs this nasty dummyForm
Hi Martin!
where things are breaking right now is exactly where we have been too
lenient in the beginning and have made tomahawk to be based on impl
where it shouldn't.
Ok, but then, lets make it clean NOW. On the trunk - once we are
finished we can restart with the release.
Ciao,
Mario
DummyForm was a special feature of MyFaces, that was wrongly put into
the implementation - it should have been put into tomahawk, where it
belongs to.
Right?
+1
As for what that means for the release, I'd say we should get as much
of this refactoring into the release as possible, and
Manfred Geiler schrieb:
Please think of the two libs shared_impl and shared_tomahawk as two
*different* things.
OK, I'll restart my brain and try again ;-)
Let's look at the
key of the problem here: Why is it an issue when shared_impl and
shared_tomahawk have different FQN-Strings during
Hi!
I just want to collect what should be done to make shared clean:
I think the following should be moved to tomahawk:
JavascriptUtils
DummyForm*
MyfacesConfig
What else?
---
Mario
Hi Sean!
NOTE: Crucial fixes should go on the *branches* only. I will merge
them down to the trunk later. The worst thing you can do is fix them
on both.
And here we are again ;-)
As you might have read we still have serious problems with the structure
of shared and have to refactor
Hi!
If a patch is critical enough that it has to be put into a release
branch, then someone needs to make the time to insure it's merged
correctly -- and this hopefully is the exception rather than the rule.
Either that, or a new branch is needed.
Branches should be static once created so
No one?
I just want to collect what should be done to make shared clean:
I think the following should be moved to tomahawk:
JavascriptUtils
DummyForm*
MyfacesConfig
What else?
I see a problem with moving DummyForm out, though, it cant stay there.
Actually the dummyForm stuff works
[
http://issues.apache.org/jira/browse/MYFACES-1143?page=comments#action_12369464
]
Mario Ivankovits commented on MYFACES-1143:
---
could you please double check if there is any old myfaces library in your
classpath e.g myfaces-common which
Hi!
Ok, who would like the one to get the glory for implementing an ajaxed
datatable like the stuff you can see on m$ new search site: www.live.com
You simply scroll up or down while it refetch the data from the server.
Happy coding. - Werner? :-)
Such a beast will be really great to have - ok,
Hi!
Don't see what you're referencing on live.com,
The search result, no?
but I'd help beta-test
a datatable like the following :)
http://openrico.org/rico/livegrid.page
Might make it too, yes ;-)
Ciao,
Mario
Hi!
Currently I put some investigation into the problem that the dummy form
is no longer rendered.
The problem I found is, that some classes use its own class name with
some constant added and but this into e.g. the requestMap.
So in case of the DummyForm this is
Hi!
plugin
groupIdorg.apache.myfaces.maven/groupId
artifactIdwagon-maven-plugin/artifactId
-version1.0.1-SNAPSHOT/version
+version1.0.2-SNAPSHOT/version
Is it possible to use a entity references in an pom.xml?
So we can move all the version stuff
[ http://issues.apache.org/jira/browse/MYFACES-334?page=all ]
Mario Ivankovits updated MYFACES-334:
-
Resolution: Fixed
aliasbean and alias usage in binding
Key: MYFACES-334
URL: http
[ http://issues.apache.org/jira/browse/MYFACES-334?page=all ]
Mario Ivankovits closed MYFACES-334:
aliasbean and alias usage in binding
Key: MYFACES-334
URL: http://issues.apache.org/jira
Hi Sean!
Dennis mentioned that we are not using JDK 1.3 compile option on the
core branch.
Its not only to set the target/source options, but also to
a) set the bootclasspath for the compiler to the jdk1.3 libraries - see:
http://jroller.com/page/scolebourne?entry=compiling_for_older_jdks and
Hi Dennis!
Right now the best solution that I see is to tag shared as close to the core
tag as possible ( speaking of time here ). I am still trying to find
problems with this idea.
As I said, AddResource had a massive bug. It is possible to deliver
responses to other clients than the
Hi Sean!
Martin's last commit appears to make this work.
It doesn't work for me. I get ...
Martins commit wasn't meant to fix this problem.
D:\open-source\myfaces-core-1.1.2\impl\src\main\java\org\apache\myfaces\webapp\f
ilter\_javascript_DetectorFilter.java:[58,23]
Hi!
Our new license boilerplate?
myfaces/tomahawk/trunk/sandbox/core/src/main/resources/org/apache/myfaces/custom/inputsuggestajax/resource/tableSuggest.js
Mon Mar 6 05:25:56 2006
@@ -1,7 +1,15 @@
/**
- * Copyright 2006 The Apache Software Foundation.
*
- * Licensed under the Apache
Hi Sean!
Actually the shared stuff prevents this from being a problem. Since
maven will refactor things into their own packages there is no longer
the potential to have a shared conflict between tomahawk and core.
(non binding) -1 from me, sorry. (Reason: The ExtensionFilter bug)
Please
Hi!
Is the ExtensionFilter bug something that already exists in the
current 1.1.1 release?
IMHO no.
This bug were introduced during the creation of AddResourceFactory which
was 2006-02-08. So after the 1.1.1 release.
If its not a new bug then I don't mind
releasing with the bug in place.
Hi Sean!
Ok so should we create a new myfaces core branch then (off the current
trunk.) That seems like the best option given the choices ...
And here is my +1 for this :-)
---
Mario
Hi Martin!
So blame me! It's my fault!
No need to stand in first line :-)
The bug could have been fixed without tempering the release process.
It was me who started the refactoring at the same time as I wasn't aware
about the slightly different (and lengthy) release process here in
Hi!
I'll invite everyone who has some time to a meeting in vienna/austria.
Location: Ma Pitom
Date: 28.3.2006
Time: 18:30
We have no free stickers, no t-shirts or any other gift, just a meeting
to drink a beer - or two - maximum.
You meet me (if this is of any interest) and some guys from the
Sean Schofield schrieb:
What shared branch? There is only trunk ... did you mean core branch?
Yes, for sure :-o all this shared/core and core/src and so on drives me
crazy :-)
---
Mario
Hi Dennis!
I was under the impression that we were still going w/ one of Sean's ideas.
Basically, if its in the core it should be fixed on the branch .
For sure, in this case it was definitely my fault.
On the other hand, I came across a couple of classes in
core/shared/tomahawk. Doing it
Hi Dennis!
I respect your opinions Mario but I'm afraid we don't see this the same way.
Ok. Its just a discussion :-)
I tend to lean towards *more* time between branch/tag and release. During
that time, no new features - only bug fixes that are moved to trunk after
release (at the latest).
Hi Sean!
So lets fix this mess by creating a branch before Mario's changes. We
can have the core branch work off this new shared branch and then
release shared? Make sense?
The commit where the bad started to happen is r382918, so using one
before might work.
Please do not use any older
Hi!
Look what a co-worker found:
http://amateras.sourceforge.jp/cgi-bin/fswiki_en/wiki.cgi?page=FacesIDE
Looks promising - with el code completion and graphical navigation editor.
Though, the el code completion didnt work here :-( maybe only local
problems.
Unhappily this is exactly my most
Hi Dennis,
didn't you read my mails on [EMAIL PROTECTED] Or is there some spamfilter
discarding them?
Now I send you this via PM too.
After discussion last week on the ML I refactored shared in a way that
the rest is no longer compatible with branch 1.1.2.
I moved some stuff from shared to
Hi!
I know this is not the best timing, but I would like to ask anyway.
Also I havent looked at it in every detail, so I dont know if there is
any technical reason for not doing so.
The question is: Can we move all the AddResource stuff from shared to
tomahawk?
In fact I talk about the whole
Hi Dennis!
The same goes for org.apache.myfaces.shared.webapp.filter.WelcomeFileFilter.
WelcomeFileFilter was moved to commons already.
From impl to commons to tomahawk ... ;-)
A long journey for sure :-)
Are you saying this is back in impl ?
not impl, to tomahawk!
---
Mario
Dennis Byrne schrieb:
The same goes for org.apache.myfaces.shared.webapp.filter.WelcomeFileFilter.
http://issues.apache.org/jira/browse/MYFACES-1112
JavaScriptDetectorFilter stayed in impl because it depends on
ServletExternalContextImpl .
Does this mean we cant move the
Hi!
BTW, shouldnt it be easily possible to get rid of the dependency to
ServletExternalContextImpl?
Its used just to set a session attribute, no?
I think you are correct. If you don't do this soon (yourself), go ahead and
reopen the issue and I'll take a look at it.
I think I
Hi!
I am nearly finished with refactoring
shared/org.apache.myfaces.shared.renderkit.html.util to
tomahawk/org.apache.myfaces.renderkit.html.util
Now I have a problem with AddResource.properties.
Can one please direct me how to bundle this file with maven?
Another problem I have is in directory
Ok, placed it at the wrong position.
Now it works!
---
Mario
Hi!
Ok, the refactoring of
shared/org.apache.myfaces.shared.renderkit.html.util to
tomahawk/org.apache.myfaces.renderkit.html.util is finished.
Tests and examples are still working, so looks promising :-)
Next is the WelcomeFilter.
Ciao,
Mario
[
http://issues.apache.org/jira/browse/TOMAHAWK-170?page=comments#action_12368467
]
Mario Ivankovits commented on TOMAHAWK-170:
---
Do you mean the column footers? I've changed something in this area to suppress
rendering if all facets have
Hi!
It looks like this is not possible, at least I dont see how to do it.
What will be possible is to add myfaces-shared-impl-2.0.0-SNAPSHOT.jar
(the classes) to the classpath
and attach myfaces-shared-impl-2.0.0-SNAPSHOT-sources.jar as source to it.
Yes, that's exactly what I do (ie.
Hi!
It looks like the examples are not correctly deployed.
In my directory I find
~/projects/myfaces/tomahawk/examples/simple/target/myfaces-example-simple/WEB-INF/lib
these three myfaces jars
myfaces-api-1.1.3-SNAPSHOT.jar
myfaces-commons-1.1.3-SNAPSHOT.jar
myfaces-impl-1.1.3-SNAPSHOT.jar
Hi!
I found your files and applied them.
Thanx! :-)
Ciao,
Mario
Hi!
Currently I try to get rid of the buffering of the extension filter. (No
code yet, just many many thoughts about it)
First of all: Who says we have to render the script src= stuff in
html-head?
I tried a short XHTML and checked it on http://validator.w3.org/check -
it didnt complain about
Hi!
i'm not sure and have not tested, but AFAIK the
link rel=stylesheet .. tags don't work outside html-head.
This is where the second idea comes in:
We no longer buffer the jsp page, instead we buffer the css. What does
this mean?
We render a css link in html-head which looks something
Hi!
I got the following error on checkout:
Fetching external item into 'current\commons'
svn: URL 'https://svn.apache.org/repos/asf/myfaces/commons/trunk' doesn't
exist
I removed the external link now.
---
Mario
Hi Manfred!
Is there no easy way to add a jar as Source in eclipse?
It looks like this is not possible, at least I dont see how to do it.
What will be possible is to add myfaces-shared-impl-2.0.0-SNAPSHOT.jar
(the classes) to the classpath
and attach
Hi!
Sorry for the lenghty mail.
I would like to get rid of the ExtensionFilter when it comes to buffer
and parse the response.
Now there are a couple of methods how to archive this:
1) documentTag
Having something like
f:view
t:document
t:documentHead
/t:documentHead
Martin Marinschek schrieb:
in panelLayout you have HTML, HEAD, BODY, FOOT (ok, you get my point ;)
Yes, this is why I put a inc/header.jsp (and footer for sure) outside of
panelLayout.
So I have a header/footer for the content outside of BODY (but for sure,
including the body) and use
Hi!
I think we might end up wanting both - the document based approach,
_and_ your scripts-tag.
What if we implement the state attribute, but having the state optional.
So these tags can work with both scenarios.
We should only make sure, that no one tries to instrument the children
in one
Hi!
It says following way:
org.apache.myfaces.renderkit.html.util.DefaultAddResource
serveResource
SEVERE: Error while serving resource:
calendar.HtmlCalendarRenderer/DB/drop1.gif, message : null
ClientAbortException: java.net.SocketException: Connection reset by peer: socket
[ http://issues.apache.org/jira/browse/TOMAHAWK-62?page=all ]
Mario Ivankovits resolved TOMAHAWK-62:
--
Resolution: Fixed
now if all facet within the header (or footer) have rendered=false (also
throug binding) the header (or footer) wont
[ http://issues.apache.org/jira/browse/TOMAHAWK-62?page=all ]
Mario Ivankovits closed TOMAHAWK-62:
Impossible to hide footer in dataTable
--
Key: TOMAHAWK-62
URL: http://issues.apache.org
[ http://issues.apache.org/jira/browse/MYFACES-334?page=all ]
Mario Ivankovits reopened MYFACES-334:
--
Assign To: Mario Ivankovits
aliasbean and alias usage in binding
Key: MYFACES-334
Hi!
Sorry for all my urgent mails, but I address them so only if I really
think it IS urgent. ;-)
Yes, that is true.
This turned out to be a serious problem here.
Not only the java.lang.StringIndexOutOfBoundsException problem, but also
that it might deliver the content of another request
Hi!
This is what I get if I try to build myfaces with tests enabled:
[ stacktrace ] ---
java.lang.IllegalArgumentException: HTML_BASIC
at
org.apache.shale.test.mock.MockRenderKitFactory.addRenderKit(MockRenderKitFactory.java:69)
Hi Dennis!
Try deleting struts/shale/shale-test.jar in your local repo and running the
tests again.
I already used mvn -U to update the repository, but it looks like you
have to delete it.
Now it works.
Thanks!
Ciao,
Mario
Hi!
new tomahawk branch
Added:
myfaces/tomahawk/branches/1_1_2/
- copied from r380160, myfaces/tomahawk/trunk/
I am already working on a fix for the treading problem with AddResource.
Even in myfaces-commons this will influence tomahawk too (testCase and
extensionFilter)
Without
Hi!
In UIComponentTagUtils the Void-check for the return-type of the
listener cant be evaluated e.g. within an dataTable - or any other
component using a var= attribute.
This is due to the fact that the var= attribute hasnt processed so far
and thus the getType() cant find the method (base is
Hi Volker!
Havend looked into sources yet, but imo we sould not remove this test,
but log at warn level and continue processing.
Please not at warn level. debug should be sufficient.
What should it be good for to log a warning that we cant check the
return type of the listener.
This warning
[ http://issues.apache.org/jira/browse/MYFACES-1127?page=all ]
Mario Ivankovits reopened MYFACES-1127:
---
current solution didnt work if you reference the *listener through the var=
attribute (e.g. within an datatable)
Non-null return types
Bruno Aranda schrieb:
We used the convertedId javax.faces.DoubleTime, due to an error in the
spec (or the javadoc) for JSF 1.1. In JSF 1.2 this has been fixed, but
I suggest to use the wrong converterId in 1.1 to pass the TCK and to
have the same behaviour than the RI...
Ups, sorry! I just
Hi!
As far as I remember, we ran into some issue with the right field...
Can you remove it (the right one) and add some javadoc on that.
JSF 1.2 has been fixed. I think there is a Jira ticket on that...
Ok, I reverted my change - even if its really odd to have to do it ;-)
---
Mario
[
http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367159
]
Mario Ivankovits commented on MYFACES-1146:
---
You could also try to do:
footerClass=#{analyze.footerClass}
where you return the footer class or a class which
[ http://issues.apache.org/jira/browse/MYFACES-1146?page=all ]
Mario Ivankovits reopened MYFACES-1146:
---
Add the attributes renderHeader and renderFooter
Impossible to hide footer in dataTable
Hi Volker!
[
http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367167
]
Volker Weber commented on MYFACES-1146:
---
I prefer to check the rendered attribute of footer/header component over
adding extra attributes to
a year now and
as an ASF member, has agreed to be the mentor for the ADF incubator
project. He has also stated an interest in making the Tomahawk
components compatible with Studio Creator.
Welcome aboard Craig. We're glad to officially have you on the team now.
Sean
--
mfg
Mario
Hi!
why not render a empty panelGroup, if so declared in the jsf source?
IMO it is intuitive that there *is* a empty panel rendered in your example.
So I'll check the rendered attribute of the facet child and if none of
the facets are going to be rendered I'll suppress the footer (header) at
[ http://issues.apache.org/jira/browse/TOMAHAWK-1?page=all ]
Mario Ivankovits resolved TOMAHAWK-1:
-
Resolution: Invalid
Unusefull code
--
Key: TOMAHAWK-1
URL: http://issues.apache.org/jira/browse/TOMAHAWK-1
[ http://issues.apache.org/jira/browse/TOMAHAWK-1?page=all ]
Mario Ivankovits closed TOMAHAWK-1:
---
Unusefull code
--
Key: TOMAHAWK-1
URL: http://issues.apache.org/jira/browse/TOMAHAWK-1
Project: MyFaces
Hi!
I tried to mark
http://issues.apache.org/jira/browse/MYFACES-1002
as fixed but failed due to the absence of any close/fix or whatever link.
Could one please adjust my permissions accordingly. JIRA User: imario
Thanks!
Ciao,
Mario
[
http://issues.apache.org/jira/browse/MYFACES-1023?page=comments#action_12366767
]
Mario Ivankovits commented on MYFACES-1023:
---
Nice to see someone uses my joda converter ;-)
I'll have a look at it.
inputCalendar with CalendarConverter loses
[
http://issues.apache.org/jira/browse/MYFACES-1023?page=comments#action_12366768
]
Mario Ivankovits commented on MYFACES-1023:
---
I think the problem with the joda converter is it do not implement the
DateConverter (also introduced by me
Hi Martin!
I added you to the developers group in jira.
Thanks!
Ciao,
Mario
[ http://issues.apache.org/jira/browse/MYFACES-1028?page=all ]
Mario Ivankovits closed MYFACES-1028:
-
Resolution: Invalid
AjaxDecodePhaseListener no longer uses ComponentUtils and thus its bug is no
longer happening
make autoUpdateDataTable
Hi!
I would like to remove the unused method
tomahawk-sandbox/org.apache.myfaces.custom.util.ComponentUtils.findComponent
its buggy (didnt traverse through facets) and no longer used. So I would
like to get this trap out of line.
Any objections?
Ciao,
Mario
Sean Schofield schrieb:
+1
done so
---
Mario
[EMAIL PROTECTED] schrieb:
fixed class loading issue for WebSphere compatibility
Gratulation!!
Habt ihr es doch noch gefunden.
Ciao,
Mario
smime.p7s
Description: S/MIME Cryptographic Signature
Oops, I wanted to send him per pm but forgot to change the mail address.
Mario was saying...
congrats!!
you found it ...
-Matthias
On 2/16/06, Mario Ivankovits [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] schrieb:
fixed class loading issue for WebSphere compatibility
Hi!
Simon says Thanks to you and all the other MyFaces people for the warm
welcome! - and so do I :-)
Looking forward for a great time here in MyFaces land.
@Manfred: cool subject ;-)
Ciao,
Mario
Hi!
In proposal 2 (see above) the use-data _and_ the structure is
transferred to the client, so by changing the structure, the (hacking)
user can try to recreate and set any properties on any bean on the
server, if no encryption is used.
Regardless of the solution we use, we should
Martin Marinschek schrieb:
Yeah - but where do you store these tinyurls? On the server? In a database?
Yes, in an database.
+1 for making it configurable, -1 for making it the default ;)
+1 - thats exactly what I thought!
Ciao,
Mario
Jessas Maria
For the english ones:
Oh my god!
Heaven!
;-)
---
Mario
Hi!
I don't get it - you usually don't save stuff like id's in the
component tree, so how would it help you to apply an id to an item in
the component tree?
No id?
I talked about the same id (client-id) you use to pass the request POST
parameters into the view.
So I don't talk about
Hi
Now the phase listener has the convention, that foo and bar are
the bean properties
and populates the bean with the given values.
I tried to follow the thread in full, but sometimes I dont get the point
of ones objection.
Sorry, if this has already been discussed, but:
Why cant we use
Hi!
- If the bean is request-scoped, it forces you to get this parameter
into every request - a major challenge for postback in JSF.
Ok, this is really a problem when using param.name
- You have to very carefully check incoming parameter values
for legitimacy (in a way that JSF
Hi!
JSF - minus complete state-saving + GET-processing + binding into the
Navigation-framework of JSF
And then ALLOW_JAVASCRIPT=false will start working again too?
Ciao,
Mario
Hi Martin!
I don't want to access the data-model. I need to access the component
directly, cause I need to access it from another component.
I guess I don't get the difference, maybe I havent learned enough yet.
irc @ #myfaces now ?
---
Mario
801 - 900 of 974 matches
Mail list logo
