Re: Review Request 68317: Sqoop Action should support tez delegation tokens for hive-import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68317/#review207151 ---

Re: Review Request 68102: OOZIE-3193 Applications are not killed when submitted via subworkflow

> On July 30, 2018, 10:46 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > > Lines 708-712 (patched) > > > > > > Please use latest schema version

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

> On June 14, 2018, 7:50 a.m., Peter Cseh wrote: > > mvn clean install -DskipTests fails for me with a ton of checkstyle errors. > > The strange thing is that ./bin/mkdistro.sh -DskipTests does not. Can you > > check on this as well? This is fine with the latest patch, sorry for the false

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204766 ---

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204762 --- mvn clean install -DskipTests fails for me with a ton of

Re: Review Request 64029: OOZIE-2339 Provide an API for writing jobs based on the XSD schemas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64029/#review204761 ---

Re: Review Request 67314: Oozie Sqoop action with command splits the select clause into multiple parts due to delimiter being space

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67314/#review204362 ---

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/#review204339 --- tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java

Re: Review Request 66930: OOZIE-2791 ShareLib installation may fail on busy Hadoop clusters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/#review204336 --- tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java

Re: Review Request 67112: OOZIE-3228 [Spark action] Can't load properties from spark-defaults.conf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67112/#review203207 ---

Re: Review Request 67112: OOZIE-3228 [Spark action] Can't load properties from spark-defaults.conf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67112/#review203009 ---

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59620/#review202546 --- examples/src/main/apps/git/workflow.xml Lines 24-25 (patched)

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59620/#review202545 ---

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59620/#review202124 --- client/src/main/java/org/apache/oozie/cli/OozieCLI.java Lines

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote: > > core/src/main/resources/jetty-logging.properties > > Line 1 (original), 1 (patched) > > > > > > Please leave .properties files intact. ``/**/`` is not a valid

Re: Review Request 66262: [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66262/#review199959 ---

Re: Review Request 66262: [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66262/#review199958 ---

Re: Review Request 66250: [OOZIE-2645] Deprecate Instrumentation in favor of Metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66250/#review199953 --- docs/src/site/twiki/AG_Install.twiki Lines 919-921 (original),

Re: Review Request 66181: OOZIE-3056 Implement new mechanism to specify ShareLibs for workflow actions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66181/ --- (Updated March 23, 2018, 7:47 a.m.) Review request for oozie, András Piros and

Re: Review Request 66181: OOZIE-3056 Implement new mechanism to specify ShareLibs for workflow actions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66181/ --- (Updated March 22, 2018, 2:07 p.m.) Review request for oozie, András Piros and

Re: Review Request 66181: OOZIE-3056 Implement new mechanism to specify ShareLibs for workflow actions

> On March 21, 2018, 1:28 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 1862-1875 (original), 1846-1848 (patched) > > > > > > Remove `catch` block

Review Request 66181: OOZIE-3056 Implement new mechanism to specify ShareLibs for workflow actions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66181/ --- Review request for oozie, András Piros and Attila Sasvari. Bugs: OOZIE-3056

Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66149/#review199552 --- docs/src/site/twiki/WorkflowFunctionalSpec.twiki Line 8

Re: Review Request 66149: OOZIE-2600 OYA: Update Documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66149/#review199531 --- docs/src/site/twiki/AG_Install.twiki Lines 307 (patched)

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote: > > core/src/main/resources/jetty-logging.properties > > Line 1 (original), 1 (patched) > > > > > > Please leave .properties files intact. ``/**/`` is not a valid

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/#review197498 ---

Re: Review Request 65636: OOZIE-3179 - Adding a configurable config-default.xml location to a workflow

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65636/#review197491 ---

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

> On Feb. 12, 2018, 8:05 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > > Lines 1680 (patched) > > > > > > Would give a catchier name and remove

Re: Review Request 65535: OOZIE-3173 Coordinator job with frequency using cron syntax creates only one action in catchup mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65535/#review196925 ---

Re: Review Request 65385: OOZIE-1717 add indices to speed up db queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65385/#review196803 --- Ship it! Ship It! - Peter Cseh On Feb. 5, 2018, 9:52 a.m.,

Re: Review Request 65177: >git status< should be clean after >mvn test< was called

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65177/#review195561 ---

Re: Review Request 65177: >git status< should be clean after >mvn test< was called

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65177/#review195560 --- core/src/test/java/org/apache/oozie/test/XTestCase.java Lines

Re: Review Request 64245: OOZIE-2681 fix javadoc to compile on JDK8 again

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64245/ --- (Updated Dec. 5, 2017, 1:42 p.m.) Review request for oozie. Bugs: OOZIE-2681

Re: Review Request 64245: OOZIE-2681 fix javadoc to compile on JDK8 again

> On Dec. 1, 2017, 3:51 p.m., Peter Bacsko wrote: > > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java > > Line 292 (original), 293 (patched) > > > > > > Nit: this isn't too helpful The function

Review Request 64245: OOZIE-2681 fix javadoc to compile on JDK8 again

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64245/ --- Review request for oozie. Bugs: OOZIE-2681

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/ --- (Updated Nov. 30, 2017, 9:19 p.m.) Review request for oozie. Bugs:

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/ --- (Updated Nov. 30, 2017, 1:18 p.m.) Review request for oozie. Bugs:

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/#review191662 ---

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/#review191334 ---

Re: Review Request 63875: OOZIE-2900 Retrieve tokens for oozie.launcher.mapreduce.job.hdfs-servers before submission

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63875/#review191332 ---

Re: Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

> On Nov. 15, 2017, 2:11 p.m., András Piros wrote: > > Would be advisable to have a test case covering different `needed.for` > > scenarios, that is, the new functionality. > > Peter Cseh wrote: > Yeah, I agree. I'm not sure I can test this properly. I'm opening up a > Jira to create an

Re: Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

> On Nov. 15, 2017, 2:11 p.m., András Piros wrote: > > Would be advisable to have a test case covering different `needed.for` > > scenarios, that is, the new functionality. Yeah, I agree. I'm not sure I can test this properly. I'm opening up a Jira to create an AppSubmissionContextFactory or

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

> On Nov. 16, 2017, 10:18 a.m., András Piros wrote: > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > > Lines 342-343 (patched) > > > > > > Typo: `persisted` Thanks. -

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/ --- (Updated Nov. 16, 2017, 10:04 a.m.) Review request for oozie. Bugs:

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

> On Nov. 15, 2017, 3:29 p.m., András Piros wrote: > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > > Lines 381 (patched) > > > > > > Typo: `Could not...` I really have to

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/ --- (Updated Nov. 15, 2017, 2:55 p.m.) Review request for oozie. Bugs:

Re: Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/ --- (Updated Nov. 15, 2017, 2:54 p.m.) Review request for oozie. Bugs:

Review Request 63837: SparkConfigrationService overwrites properties provided via --properties-file option in SparkAction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/ --- Review request for oozie. Bugs: OOZIE-3112

Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63836/ --- Review request for oozie. Bugs: OOZIE-2869

Re: Review Request 63327: OOZIE-2897 LauncherAM should support ACLs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63327/#review190306 --- Ship it! Ship It! - Peter Cseh On Nov. 7, 2017, 12:36 p.m.,

Re: Review Request 63327: OOZIE-2897 LauncherAM should support ACLs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63327/#review190152 ---

Re: Review Request 63327: OOZIE-2897 LauncherAM should support ACLs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63327/#review189933 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review189412 --- Ship it! Ship It! - Peter Cseh On Oct. 27, 2017, 10:01

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review189406 ---

Re: Review Request 62459: OOZIE-2296: Add an Oozie diagnostic bundle tool

> On Oct. 6, 2017, 12:26 a.m., Robert Kanter wrote: > > tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java > > Lines 173-174 (patched) > > > > > > LogAggregationUtils is marked

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 12, 2017, 11:36 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 1197 (patched) > > > > > > This is fine to leave for a different JIRA,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review187806 ---