Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-05-03 Thread Curtis Olson
Hi Lauri, I've been flying with your new atmospheric scatter shader and it's quite beautiful, great work! I did notice one glitch though. Here is a link to a screen shot: https://dl-web.dropbox.com/get/Photos/fgfs-screen-043.png?w=eba5c12c It's very subtle and if there was any cloud coverage i

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-16 Thread Erik Hofman
On Fri, 2011-04-15 at 11:27 +0200, Erik Hofman wrote: > On Fri, 2011-04-15 at 11:22 +0200, Durk Talsma wrote: > > Like, Christian and Vivian stated earlier, I would also hate to see a patch > > getting lost, especially when it contains promise. This is why I > > originally suggested committing i

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-15 Thread Lauri Peltonen
Hi. Nice to see my shader brought up some discussion :) First, Vivian, I tried to see your screenshots, but the link wasn't working (server down or something?) so I cannot comment them right now. And I didn't mean the bug with sun reflection on the water being misplaced from the real shader, but

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-15 Thread Erik Hofman
On Fri, 2011-04-15 at 11:22 +0200, Durk Talsma wrote: > Like, Christian and Vivian stated earlier, I would also hate to see a patch > getting lost, especially when it contains promise. This is why I originally > suggested committing it. > > I would suggest that (even though it may not be produ

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-15 Thread Durk Talsma
On 15 Apr 2011, at 08:41, Erik Hofman wrote: > On Fri, 2011-04-15 at 00:16 +0200, Christian Schmitt wrote: >> I can only agee with Vivian here: lets get this change into GIT, so that it >> doesn't get lost as so many others in the past. The shader is not perfect >> yet, but that should not hurt

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-15 Thread Arnt Karlsen
On Fri, 15 Apr 2011 08:41:42 +0200, Erik wrote in message <1302849702.1655.1.camel@Raptor>: > On Fri, 2011-04-15 at 00:16 +0200, Christian Schmitt wrote: > > I can only agee with Vivian here: lets get this change into GIT, so > > that it doesn't get lost as so many others in the past. The shader

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Erik Hofman
On Fri, 2011-04-15 at 00:16 +0200, Christian Schmitt wrote: > I can only agee with Vivian here: lets get this change into GIT, so that it > doesn't get lost as so many others in the past. The shader is not perfect > yet, but that should not hurt, as it is disabled as a default. Those who > want

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Christian Schmitt
Erik Hofman wrote: > I'm not sure, it needs time to look after some things. For one it should > be made possible for the shader to adjust the fog color located > under /rendering/fog but at this time values written to it will be > overwritten by the current code. > > Erik > I can only agee with

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Vivian Meazza
Erik wrote > > On Thu, 2011-04-14 at 18:15 +0200, Durk Talsma wrote: > > > > > Okay, thanks for the comments. I'll be holding back on committing. Is > > there any perspective that this patch can be brought to production > > quality? > > I'm not sure, it needs time to look after some things. For

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Erik Hofman
On Thu, 2011-04-14 at 18:15 +0200, Durk Talsma wrote: > > Okay, thanks for the comments. I'll be holding back on committing. Is > there any perspective that this patch can be brought to production > quality? I'm not sure, it needs time to look after some things. For one it should be made possibl

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Curtis Olson
On Thu, Apr 14, 2011 at 11:15 AM, Durk Talsma wrote: > PS: what about the 2.2 release first ? I see plans for lots of code. > > Yeah, we should get back to that. What is the current status? I have spend > a lot of time doing the prepatory work for an eventual release during my > holiday, but appa

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Durk Talsma
On 14 Apr 2011, at 10:30, Frederic Bouvier wrote: > Erik Hofman wrote: > >> >> It's not production ready yet, and it even removes some of the features >> form the old code. I don't seem to see any difference with different >> humidity levels for example. > > > I guess one would have to play w

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Frederic Bouvier
> On Wed, 2011-04-13 at 19:37 +0200, Durk Talsma wrote: > > > Admittedly, I only looked at the corresponding forum topic very > briefly, but the screenshots certainly looked promising. I'd be happy > to commit the corresponding simgear and flightgear patches. > > > > I did see some comments from

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-14 Thread Erik Hofman
On Wed, 2011-04-13 at 19:37 +0200, Durk Talsma wrote: > Admittedly, I only looked at the corresponding forum topic very briefly, but > the screenshots certainly looked promising. I'd be happy to commit the > corresponding simgear and flightgear patches. > > I did see some comments from Fred in

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-13 Thread Durk Talsma
On 13 Apr 2011, at 00:08, Vivian Meazza wrote: > > It's meant to have been fixed. > > I can push the shader and effects file into git - but someone else will have > to pick up the flightgear and simgear patches > Admittedly, I only looked at the corresponding forum topic very briefly, but th

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-12 Thread Heiko Schulz
> It does two things. First I modified the skydome code to be > more > configurable so that the precision could be increased > (number of rings > and bands). Then I implemented the O'Neil's scattering > shader to > showcase the scattering. I know that for the proper effect, > terrain and > other o

Re: [Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-12 Thread Vivian Meazza
Lauri wrote > > Hi, > > I made this patch some time ago, and seems like it is working quite > fine, so I though if it might be possible to add to git (if nothing > more, then maybe for future reference)? > > It does two things. First I modified the skydome code to be more > configurable so that

[Flightgear-devel] Simple atmospheric scattering shader for skydome

2011-04-12 Thread Lauri Peltonen
Hi, I made this patch some time ago, and seems like it is working quite fine, so I though if it might be possible to add to git (if nothing more, then maybe for future reference)? It does two things. First I modified the skydome code to be more configurable so that the precision could be increase