dsmiley commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303806467
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303771997
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1690960147
pushed in some more ideas to discuss :)
I have reinstated the InheritableThreadLocalProvider approach. this time I
am also attempting to create a span if it does not exist. I think this
dsmiley commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303762238
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303750750
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758330#comment-17758330
]
Alex Deparvu commented on SOLR-16938:
-
thanks for confirming [~dsmiley]. I believe we
stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303744008
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
dsmiley commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303741279
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758311#comment-17758311
]
David Smiley commented on SOLR-16938:
-
1. "keeping solr.xml config" -- It exists toda
sandbergja commented on PR #1827:
URL: https://github.com/apache/solr/pull/1827#issuecomment-1690881753
Thank you, @dsmiley ! Could you please change "(Jane Sandberg, David
Smiley)" to "(Christina Chortaria, Max Kadel, Ryan Laddusaw, Jane Sandberg,
David Smiley)"? All four of us here work
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1690788877
@dsmiley did a recap above and pushed a few more commits. I would like to
leave it on by default to catch regressions early, I will disable it if it
turns out to be too noisy.
I think
[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758296#comment-17758296
]
Alex Deparvu commented on SOLR-16938:
-
Sorry for joining this late, I only just saw t
[
https://issues.apache.org/jira/browse/SOLR-16937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758293#comment-17758293
]
Alex Deparvu commented on SOLR-16937:
-
I agree. removing the global reference is not
[
https://issues.apache.org/jira/browse/SOLR-16937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-16937.
-
Resolution: Won't Fix
> Remove use of GlobalOpenTelemetry
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-16935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16935:
Component/s: tracing
> Add spans to cover gaps in query processing
> --
[
https://issues.apache.org/jira/browse/SOLR-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16947:
---
Assignee: Alex Deparvu
> Test to prevent regressions in span data
>
Alex Deparvu created SOLR-16947:
---
Summary: Test to prevent regressions in span data
Key: SOLR-16947
URL: https://issues.apache.org/jira/browse/SOLR-16947
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-15367:
Component/s: tracing
> Convert "rid" functionality into a default Tracer
>
stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303627276
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -567,6 +575,7 @@ public static class NodeConfigBuilder {
private String defaultZkHost;
privat
stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303627276
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -567,6 +575,7 @@ public static class NodeConfigBuilder {
private String defaultZkHost;
privat
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303615766
##
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##
@@ -135,4 +182,8 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex,
Logger log) {
error
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303615333
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -567,6 +575,7 @@ public static class NodeConfigBuilder {
private String defaultZkHost;
private
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303615200
##
solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303614343
##
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##
@@ -28,6 +28,11 @@
public class ResponseUtils {
private ResponseUtils() {}
+ // System propert
[
https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16933.
---
Fix Version/s: 9.4
Assignee: Houston Putman
Resolution: Fixed
> The API Tool
[
https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758247#comment-17758247
]
ASF subversion and git services commented on SOLR-16933:
Commit 5
dsmiley commented on PR #1827:
URL: https://github.com/apache/solr/pull/1827#issuecomment-1690680228
I switched the test to subclass SolrTestCaseJ4 (which 99% of Solr tests
ultimately extend from) as there were mysterious cross-test side-effects when I
didn't. I don't have time today to de
[
https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758241#comment-17758241
]
ASF subversion and git services commented on SOLR-16933:
Commit 5
HoustonPutman commented on PR #1863:
URL: https://github.com/apache/solr/pull/1863#issuecomment-1690609516
Unfortunately the Http2SolrClient does not play nicely with the
NoOpResponseParser for errors, so I switched to using the
JSONMapResponseParser. Though I did make the error handling a
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758219#comment-17758219
]
Paul McArthur commented on SOLR-16946:
--
This issue only affects Solr 9, there should
[
https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758211#comment-17758211
]
ASF subversion and git services commented on SOLR-16933:
Commit f
HoustonPutman merged PR #1863:
URL: https://github.com/apache/solr/pull/1863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303381080
##
solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
HoustonPutman commented on code in PR #1863:
URL: https://github.com/apache/solr/pull/1863#discussion_r1303398270
##
solr/core/src/test/org/apache/solr/cli/ApiToolTest.java:
##
@@ -42,4 +58,48 @@ public void testParsingGetUrl() throws URISyntaxException {
assertEquals("se
renatoh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1690421787
your are welcome. looking at the source code I am seeing a lot of potential
for small refactoring.
most of them just to clean up the code and reduce the number of warnings,
but some of th
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303382150
##
solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303381080
##
solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
gerlowskija commented on PR #1859:
URL: https://github.com/apache/solr/pull/1859#issuecomment-1690318842
Yeah, the diff is large for sure.
I'd argue though that this is pretty deceptive though, re: "verbosity".
This commit adds lines in isolation sure, but if it ultimately lets us d
stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303292779
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -567,6 +575,7 @@ public static class NodeConfigBuilder {
private String defaultZkHost;
privat
stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303284476
##
solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303281456
##
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##
@@ -135,4 +182,8 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex,
Logger log) {
erro
stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1303280414
##
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##
@@ -28,6 +28,11 @@
public class ResponseUtils {
private ResponseUtils() {}
+ // System proper
HoustonPutman commented on code in PR #1863:
URL: https://github.com/apache/solr/pull/1863#discussion_r1303259400
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -61,29 +60,39 @@ public List getOptions() {
@Override
public void runImpl(CommandLine cli) thro
epugh commented on code in PR #1863:
URL: https://github.com/apache/solr/pull/1863#discussion_r1303193644
##
solr/core/src/test/org/apache/solr/cli/ApiToolTest.java:
##
@@ -42,4 +58,48 @@ public void testParsingGetUrl() throws URISyntaxException {
assertEquals("select id
epugh commented on code in PR #1863:
URL: https://github.com/apache/solr/pull/1863#discussion_r1303190761
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -61,29 +60,39 @@ public List getOptions() {
@Override
public void runImpl(CommandLine cli) throws Excep
HoustonPutman opened a new pull request, #1863:
URL: https://github.com/apache/solr/pull/1863
https://issues.apache.org/jira/browse/SOLR-16933
So the initial issue here is that the SolrDocumentList serialization used to
only be really handled by the `SolrRequestWriter` (solr core only
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1690076906
> At the cost of yet another dependency, and to SolrJ at that? I'm sensitive
to dependency sprawl, and in SolrJ in particular.
this argument I agree with. it's awkward to bring in an
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1690068424
In the last commits I re-introduced backward compatibility for configuring
the legacy "CircuitBreakerManager" as a single plugin. I did this by renaming
`CircuitBreakerManager` as `CircuitBre
[
https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758079#comment-17758079
]
Jan Høydahl commented on SOLR-15474:
Feedback welcome on my questions from June.
* H
tpunder commented on code in PR #1861:
URL: https://github.com/apache/solr/pull/1861#discussion_r1303080299
##
solr/solr-ref-guide/modules/configuration-guide/pages/caches-warming.adoc:
##
@@ -343,6 +355,34 @@ A key best practice is to modify these defaults before
taking your a
janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1303062115
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -38,31 +38,24 @@ public class CPUCircuitBreaker extends CircuitBreaker {
private
dsmiley commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1689973250
> I would propose to go for a simpler solution though, first this was
already solved for us by the many #wrap methods on the context and second trace
context is always on, might as well make
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1689922851
> RE ExecutorUtil -- I think you are working around changes you removed in
TracerConfigurator
I agree. I was curious when those will come back. I would propose to go for
a simpler s
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758005#comment-17758005
]
Ishan Chattopadhyaya commented on SOLR-16946:
-
Should we backport to 8.11.x?
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-16946.
---
Resolution: Fixed
> Cluster Singleton stop method sometimes not called on Overseer close
> --
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1689819425
Thanks for these updates! For staight up code refactorings we don't
normally do a CHANGES.txt entry, but I very much appreciate the contribution.
--
This is an automated message from the Ap
epugh merged PR #1834:
URL: https://github.com/apache/solr/pull/1834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1689818267
> I am a bit confused, so why would we need an assert at a place where it is
impossible for the Socket to be null?
Because otherwise precommit fails ;-). We really should figure out wh
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16946:
---
Fix Version/s: 9.4
> Cluster Singleton stop method sometimes not called on Overseer close
> -
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757981#comment-17757981
]
Jan Høydahl commented on SOLR-16946:
[~noble.paul] , remember to close Jira when done
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-16946:
--
Assignee: Noble Paul
> Cluster Singleton stop method sometimes not called on Overseer close
>
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757878#comment-17757878
]
ASF subversion and git services commented on SOLR-16946:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757876#comment-17757876
]
ASF subversion and git services commented on SOLR-16946:
Commit 0
noblepaul merged PR #1862:
URL: https://github.com/apache/solr/pull/1862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
janhoy commented on code in PR #1861:
URL: https://github.com/apache/solr/pull/1861#discussion_r1302625590
##
solr/solr-ref-guide/modules/configuration-guide/pages/caches-warming.adoc:
##
@@ -343,6 +355,34 @@ A key best practice is to modify these defaults before
taking your ap
[
https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757853#comment-17757853
]
Andras Salamon commented on SOLR-16777:
---
Hi, was it fixed int he 8.11 line as well?
66 matches
Mail list logo
