[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14924 Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. IMPALA-9240: add HTTP code handling to THttpClient. Before this

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. IMPALA-9240: add HTTP code handling to THttpClient. Before this

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. IMPALA-9240: add HTTP code handling to THttpClient. Before this

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. Patch Set 3: Code-Review+2 pull forward +2 -- To view, visit

[Impala-ASF-CR] IMPALA-9241: Remove pid files on successful shutdown of minicluster

2019-12-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14950 ) Change subject: IMPALA-9241: Remove pid files on successful shutdown of minicluster .. Patch Set 1: Code-Review+2 LGTM -- To view,

[Impala-ASF-CR] IMPALA-9274: cyclic barrier implementation

2020-01-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14973 ) Change subject: IMPALA-9274: cyclic barrier implementation .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14973/3/b

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-01-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-01-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-01-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 5: Code-Review+1 LGTM, @arawat will review to +2

[Impala-ASF-CR] IMPALA-8852: Skipping short-circuit config check for coordinator only

2020-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only .. Patch Set 2: (5 comments) Thanks for the c

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 3: Code-Review+1 LGTM Giving +1

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 4: Code-Review+2 LGTM, thanks

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by automatically enable live progress in the interactive mode

2020-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 ) Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode .. Patch Se

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 8: Code-Review+2 LGTM thanks Xiaomeng and Abhishek

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for dedicated coordinator

2020-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for dedicated coordinator .. Patch Set 10: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-9389: [DOCS] Support reading zstd text files

2020-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15304 ) Change subject: IMPALA-9389: [DOCS] Support reading zstd text files .. Patch Set 2: (1 comment) I think (Abhishek and Xiaomeng to co

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by automatically enable live progress in the interactive mode

2020-02-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 ) Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode .. Patch Se

[Impala-ASF-CR] IMPALA-9389: [DOCS] Support reading zstd text files

2020-02-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15304 ) Change subject: IMPALA-9389: [DOCS] Support reading zstd text files .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by enabling live progress in interactive mode

2020-03-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 ) Change subject: IMPALA-9384: Improve Impala shell usability by enabling live_progress in interactive mode .. Patch Set 3: (3 comment

[Impala-ASF-CR] IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files

2020-03-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15310 ) Change subject: IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files .. Patch Set 3: (1 comment) A quick c

[Impala-ASF-CR] IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files

2020-03-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15310 ) Change subject: IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files .. Patch Set 5: Code-Review+2 -- To v

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

2020-03-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 ) Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly .. Patch Set 2: (2 comments)

[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.

2020-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15620 Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages. .. Patch Thrift to 0.9.3-p8 to remove a

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

2020-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 ) Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly .. Patch Set 3: Code-Review+2

[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.

2020-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15620 ) Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages. .. Patch Set 1: Verified+1 -- To vie

[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.

2020-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15620 ) Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages. .. Patch Thrift to 0.9.3-p8 to

[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive

2020-04-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15751 Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive .. IMPALA-9666 Correct a log message in TestImpalaShell

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-04-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15752 Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that Imp

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

2020-04-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 ) Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert .. Patch Set 1: Looks good, will wait for bui

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

2020-04-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 ) Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert .. Patch Set 2: Code-Review+2 LGTM -- To vi

[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest

2020-04-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 ) Change subject: IMPALA-9681: Fix LdapImpalaShellTest .. Patch Set 1: Code-Review+2 Thanks for fixing this -- To view, visit http://

[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image

2020-04-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 ) Change subject: IMPALA-9574: support ubuntu 18.04 base image .. Patch Set 2: Code-Review+2 (1 comment) LGTM http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 1: (1 comment

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-05-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that Impa

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-05-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 1: (1 comment

[Impala-ASF-CR] IMPALA-9743: Fix ExprCardinalityTest may not be marked as in test env

2020-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15982 ) Change subject: IMPALA-9743: Fix ExprCardinalityTest may not be marked as in test env .. Patch Set 1: Code-Review+2 LGTM -- To vie

[Impala-ASF-CR] IMPALA-9077: Remove scalable admission control configs

2020-06-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16039 ) Change subject: IMPALA-9077: Remove scalable admission control configs .. Patch Set 4: Code-Review+2 (2 comments) This looks pretty

[Impala-ASF-CR] IMPALA-3695: Remove KUDU IS SUPPORTED

2020-06-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16085 ) Change subject: IMPALA-3695: Remove KUDU_IS_SUPPORTED .. Patch Set 4: Code-Review+2 This looks safe and a good cleanup. I did look fo

[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py

2020-06-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16102 ) Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py .. Patch Set 1: Code-Review+2 LGTM --

[Impala-ASF-CR] IMPALA-9885: debug action for planner

2020-06-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16104 ) Change subject: IMPALA-9885: debug action for planner .. Patch Set 2: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 10: (13 comments) Good change! I like the detailed unit tes

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-9790: option to use resolved hostname everywhere

2020-06-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16108 ) Change subject: IMPALA-9790: option to use resolved hostname everywhere .. Patch Set 2: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that Impa

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that Impa

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that Impa

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 5: Code-Review

[Impala-ASF-CR] IMPALA-10006: handle non-writable /opt/impala/logs

2020-07-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16237 ) Change subject: IMPALA-10006: handle non-writable /opt/impala/logs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16269 Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error code in Impala She

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error code in Impala Shel

[Impala-ASF-CR] IMPALA-10052: Expose daemon health endpoint for statestore and catalog

2020-08-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16295 ) Change subject: IMPALA-10052: Expose daemon health endpoint for statestore and catalog .. Patch Set 2: Code-Review+2 LGTM -- To vi

[Impala-ASF-CR] IMPALA-7714: try to avoid be test crash in statestore

2020-08-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16341 ) Change subject: IMPALA-7714: try to avoid be test crash in statestore .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7714: try to avoid be test crash in statestore

2020-08-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16341 ) Change subject: IMPALA-7714: try to avoid be test crash in statestore .. Patch Set 2: Code-Review+2 LGTM -- To view, visit http://g

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16613 Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10303: Fix warnings from impala-shell with --quiet

2020-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16673 ) Change subject: IMPALA-10303: Fix warnings from impala-shell with --quiet .. Patch Set 2: Code-Review+2 LGTM -- To view, visit http

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

2020-11-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 ) Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4 .. Patch Set 2: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16702 Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a Retry-Af

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16702 ) Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a Retry-Aft

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16702 ) Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a Retry-Aft

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16743 Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. IMPALA-10249: Fix the flaky TestImpalaShell.t

[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000

2020-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16807 ) Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000 .. Patch Set 1: Code-Review+2 LGTM -- To view, visit h

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16966 Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload

2021-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 1: Code-Review+2 (2 comments) LGTM, a few cosme

[Impala-ASF-CR] IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry msg' referenced before assign

2021-03-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17172 ) Change subject: IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry_msg' referenced before assign ..

[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.

2021-03-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17212 Change subject: IMPALA-10592: prevent pytest from hanging at exit. .. IMPALA-10592: prevent pytest from hanging at exit. In TestAdmiss

[Impala-ASF-CR] IMPALA-10397: Fix test single workload

2021-03-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 1: (1 comment) LGTM, does this comment need updating? http://ge

[Impala-ASF-CR] IMPALA-10397: Fix test single workload

2021-03-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-10605: Deflake test refresh native

2021-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17227 ) Change subject: IMPALA-10605: Deflake test_refresh_native .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

2021-03-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 ) Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch .. Patch Set 2: Code-Review+2 LGTM, plus also useful

[Impala-ASF-CR] Only fetch needed branches in compare branches.py

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 ) Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations .. Patch Set 1: Code-Review+2 LGTM -

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 3: (5 comments) Thanks for doing this, I ha

[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 1: (4 comments) I have a few suggestions

[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 2: (4 comments) Thanks, this is looking be

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 4: Code-Review+2 LGTM, thanks for the fixes

[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option

2021-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 3: Code-Review+2 LGTM -- To view, visit h

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://ge

[Impala-ASF-CR] add OSS/JindoFS support, impala with this change will create a dedicate thread pool for this kind of target. By default 16 threads would be craeted

2021-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: add OSS/JindoFS support, impala with this change will create a dedicate thread pool for this kind of target. By default 16 threads would be craeted ..

[Impala-ASF-CR] IMPALA-10695:add OSS/JindoFS support, create a dedicate thread pool for this kind of target, default is 16.

2021-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695:add OSS/JindoFS support, create a dedicate thread pool for this kind of target, default is 16. .. Patch

[Impala-ASF-CR] IMPALA-10695: add dedicated thread pool for OSS/JindoFS.

2021-05-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. .. Patch Set 5: (5 comments) Thanks for the changes, I thin

[Impala-ASF-CR] IMPALA-10695: add dedicated thread pool for OSS/JindoFS.

2021-05-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. .. Patch Set 6: Code-Review+2 Thanks for working through the

[Impala-ASF-CR] IMPALA-8769: [DOCS] Change the shell default

2021-05-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17349 ) Change subject: IMPALA-8769: [DOCS] Change the shell default .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-9155: Add recovery mechanism to admission service

2021-05-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 ) Change subject: IMPALA-9155: Add recovery mechanism to admission service .. Patch Set 1: (3 comments) I read through the code once,

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-05-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 ) Change subject: IMPALA-10720: Add versioning to admission heartbeats .. Patch Set 1: (4 comments) A few nits http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-9155: Add recovery mechanism to admission service

2021-05-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 ) Change subject: IMPALA-9155: Add recovery mechanism to admission service .. Patch Set 1: (10 comments) Some more comments http://ge

[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest

2021-06-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 ) Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest .. Patch Set 2: Code-Review+2 LGTM -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all cooridnators

2021-07-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 ) Change subject: IMPALA-8762: Track host level admission stats across all cooridnators .. Patch Set 1: (6 comments) I did a quick re

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

2021-07-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 ) Change subject: IMPALA-8762: Track host level admission stats across all coordinators .. Patch Set 2: Code-Review+2 (2 comments) LG

[Impala-ASF-CR] IMPALA-10846: Skip Authentication for connection with trusted auth header

2021-08-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 ) Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header .. Patch Set 1: (8 comments) This looks g

  1   2   3   4   5   6   7   >