[kudu-CR] [test] make TestRpcHandlerLatencyMetric more robust

2024-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21055 Change subject: [test] make TestRpcHandlerLatencyMetric more robust .. [test] make TestRpcHandlerLatencyMetric more robust This patch a

[kudu-CR] [rpc] a bit of clean-up on LifoServiceQueue

2024-02-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21049 to look at the new patch set (#2). Change subject: [rpc] a bit of clean-up on LifoServiceQueue ..

[kudu-CR] [rpc] a bit of clean-up on LifoServiceQueue

2024-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21049 Change subject: [rpc] a bit of clean-up on LifoServiceQueue .. [rpc] a bit of clean-up on LifoServiceQueue I was looking at the code in

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21044 ) Change subject: [rpc] fix typo in branch prediction .. [rpc] fix typo in branch prediction This is a follow-up to 3f0c434143ad

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] fix typo in branch prediction .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21044 To unsubscribe, visit http:

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 ) Change subject: [rpc] fix typo in branch prediction .. Patch Set 2: Verified+1 unrelated test failures in ClientTest.ClearCacheAnd

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-21 Thread Alexey Serbin (Code Review)
Hello Zoltan Martonka, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21044 to look at the new patch set (#2). Change subject: [rpc] fix typo in branch prediction .

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] fix typo in branch prediction .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21044 To unsubscribe, visit http:

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 ) Change subject: [rpc] fix typo in branch prediction .. Patch Set 1: Verified+1 Unrelated test failures: CatalogManagerConfigurations/M

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21044 Change subject: [rpc] fix typo in branch prediction .. [rpc] fix typo in branch prediction This is a follow-up to 3f0c434143ad6daa8ed4f

[kudu-CR] [Java] Fix concurrent problem while traversing the traces of KuduRpc.

2024-02-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21041 ) Change subject: [Java] Fix concurrent problem while traversing the traces of KuduRpc. .. Patch Set 8: (2 comments) Thank you for the

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 12: (11 comments) http://gerrit.cloudera.org:8080/#/c/20607/12/src/kudu/u

[kudu-CR] [log block manager-test] Improve random selection

2024-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 ) Change subject: [log_block_manager-test] Improve random selection .. Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4

2024-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 ) Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. Patch Set 2: There are many updates in Scala files. Are these anyho

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 12: (18 comments) I took a quick look and left a few comments. I'm going

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 7: > > Patch Set 6: Code-Review+2 > > > > > P

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 ) Change subject: KUDU-613: Cleanup of cache code .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 6: Code-Review+2 It seems Yingchun on a 10-day

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 6: I had notified Yingchun on the issue, and he

[kudu-CR] Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata"

2024-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 ) Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" .. Patch Set 6: Code-Review+1 -- To view, visit http://gerr

[kudu-CR] [tests] make token signer-itest more robust

2024-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [tests] make token_signer-itest more robust .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21022 To unsubscribe, vis

[kudu-CR] [tests] make token signer-itest more robust

2024-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21022 ) Change subject: [tests] make token_signer-itest more robust .. Patch Set 1: Verified+1 unrelated test failures -- To view, visit htt

[kudu-CR] [tests] make token signer-itest more robust

2024-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21022 ) Change subject: [tests] make token_signer-itest more robust .. Patch Set 1: > LGTM. Maybe a different approach could be to increase >

[kudu-CR] [tests] make token signer-itest more robust

2024-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21022 Change subject: [tests] make token_signer-itest more robust .. [tests] make token_signer-itest more robust This patch updates the scena

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [catalog_manager] Tighten leader UUID fallback .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21004 To unsubscribe,

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21004 ) Change subject: [catalog_manager] Tighten leader UUID fallback .. [catalog_manager] Tighten leader UUID fallback It is safe to

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21004 ) Change subject: [catalog_manager] Tighten leader UUID fallback .. Patch Set 3: Code-Review+2 Thank you for performing the root cause a

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21004 ) Change subject: [catalog_manager] Tighten leader UUID fallback .. Patch Set 3: Verified+1 unrelated test failures -- To view, visit

[kudu-CR](branch-1.17.x) KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21017 ) Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. KUDU-3535 Clear log cache while tombstoning a

[kudu-CR](branch-1.17.x) KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21017 T

[kudu-CR](branch-1.17.x) KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21017 ) Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. Patch Set 1: Verified+1 unrelated test failures --

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21004 ) Change subject: [catalog_manager] Tighten leader UUID fallback .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 10: (4 comments) Just glanced over the tests, and there is one question I

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/uti

[kudu-CR] KUDU-613: Cleanup of cache code

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 ) Change subject: KUDU-613: Cleanup of cache code .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/uti

[kudu-CR](branch-1.17.x) KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21017 Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. KUDU-3535 Clear log cache while tombstoning a tablet re

[kudu-CR] KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20822 ) Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. Patch Set 10: Verified+1 unrelated test failures --

[kudu-CR] KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20822 ) Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. KUDU-3535 Clear log cache while tombstoning a

[kudu-CR] KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20822 T

[kudu-CR] KUDU-3535 Clear log cache while tombstoning a tablet replica.

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20822 ) Change subject: KUDU-3535 Clear log cache while tombstoning a tablet replica. .. Patch Set 10: Code-Review+2 Thank you for the fix!

[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21007 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. KUDU-3549 fix WriteAsPrometheus() for non-arithm

[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21007 To

[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21007 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Verified+1 unrelated test failures -- To

[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-06 Thread Alexey Serbin (Code Review)
Hello Marton Greber, Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21007 to review the following change. Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges ..

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21006 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I

[kudu-CR] [catalog manager] Tighten leader UUID fallback

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21004 ) Change subject: [catalog_manager] Tighten leader UUID fallback .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21006 To unsubsc

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21006 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Verified+1 unrelated test failures -- To view,

[kudu-CR](branch-1.17.x) [test] a small clean-up on StringGaugePrometheusTest

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21006 Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I took a q

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20990 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. KUDU-3549 fix WriteAsPrometheus() for non-arithm

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20990 To

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20990 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Verified+1 unrelated test failures: Enc

[kudu-CR] KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges

2024-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20990 Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gaug

[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest

2024-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20984 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Patch Set 1: Verified+1 unrelated test failures -- To view,

[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest

2024-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20984 ) Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I

[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest

2024-02-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [test] a small clean-up on StringGaugePrometheusTest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20984 To unsubsc

[kudu-CR] [WIP][catalog manager] Skip eviction during bootstrapping

2024-02-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20958 ) Change subject: [WIP][catalog_manager] Skip eviction during bootstrapping .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:808

[kudu-CR] [test] a small clean-up on StringGaugePrometheusTest

2024-02-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20984 Change subject: [test] a small clean-up on StringGaugePrometheusTest .. [test] a small clean-up on StringGaugePrometheusTest I took a q

[kudu-CR] KUDU-613: Scan Resistant Caching

2024-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Scan Resistant Caching .. Patch Set 8: (3 comments) I took a quick look. My request is to split this chang

[kudu-CR] [compaction] Add memory estimation unit test

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20787/6/

[kudu-CR] [compaction] Add tests to generate high memory rowset compaction

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction] Add tests to generate high memory rowset compaction .. [compaction] Add tests to generate high mem

[kudu-CR] [compaction] Add tests to generate high memory rowset compaction

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction] Add tests to generate high memory rowset compaction .. Patch Set 9: Code-Review+2 (1 comment) http://ger

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. KUDU-3527 Fix block manager test

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 15: Verified+1 unrelated test

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: Thank you very much for the contribution! -- To vi

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/18569 To unsubscribe

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 73: Verified+1 unrelated test failures: * CatalogManag

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 72: Code-Review+2 (4 comments) Please address one nit a

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 15: Code-Review+2 (1 comment)

[kudu-CR] [rpc] validate security-related parameters earlier

2024-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20961 Change subject: [rpc] validate security-related parameters earlier .. [rpc] validate security-related parameters earlier This patch mov

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 14: Code-Review+1 (9 comments)

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. [rpc] introduce rpc_listened_socket_rx_queue_size m

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20930 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix CheckHolePunch for bigger than 4k blocks. With the new 64

[kudu-CR] [rpc] introduce rpc pending connections metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] introduce rpc_pending_connections metric .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20949 To unsubscribe,

[kudu-CR] [rpc] introduce rpc pending connections metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20949 ) Change subject: [rpc] introduce rpc_pending_connections metric .. Patch Set 2: Verified+1 unrelated test failure in Java test (TSAN)

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20908 To uns

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 5: Verified+1 unrelated test failure in RaftCons

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#5). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ..

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#4). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ..

[kudu-CR] [rpc] introduce rpc pending connections metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20949 Change subject: [rpc] introduce rpc_pending_connections metric .. [rpc] introduce rpc_pending_connections metric One of the prior patch

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-23 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#3). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ..

[kudu-CR] [docs] Expand master add argument list

2024-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20940 ) Change subject: [docs] Expand master add argument list .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20940/1//COMMI

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2089

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-22 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#2). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20930 To unsubscribe, v

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20930 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 1: Verified+1 unrelated test failure in MasterMigrationTest

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 7: (9 comments) Overall looks good to me, but I thin

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20930 Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix CheckHolePunch for bigger than 4k blocks. With the new 64k ARM cor

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 5: Code-Review+2 Thank you for the fix! I verified it work

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix CheckHolePunch for bigger than 4k blocks. With the new 64

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR](branch-1.17.x) KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR](branch-1.17.x) KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20923 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 1: Verified+1 unrelated test failure

[kudu-CR] Fix typos

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20927 ) Change subject: Fix typos .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20927 To unsubscribe, visit

[kudu-CR] Fix typos

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20927 ) Change subject: Fix typos .. Fix typos Change-Id: I71524db97455bb27db44b5820cbe81fd95e207d9 Reviewed-on: http://gerrit.clouder

[kudu-CR](branch-1.17.x) KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20923 Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. KUDU-3526 [java] Scanner should bind with a tser

<    5   6   7   8   9   10   11   12   13   14   >