Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: replace rpm commandline with rpm-python api in caps.py
..
Patch Set 2: Fails; I would prefer that you didn't submit this
(1 inline comment)
Please verify
Mark Wu has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe, visit http
Yaniv Bronhaim has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 10: Verified
thanks.
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovi
Mark Wu has posted comments on this change.
Change subject: report idle time for multiple vcpus
..
Patch Set 2: (1 inline comment)
I don't know what the idle time of a vm means to engine. It idle time could be
caused by low wo
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 10: Verified
Thanks Yaniv, I always verify the patch before uploading it. I think self
verify is a must,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fail if Password doesn't match
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit http://gerri
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: engine.py: fail if Password doesn't match
..
engine.py: fail if Password doesn't match
Currently, if users in the Node TUI add the password to incl
Yaniv Bronhaim has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 10: Looks good to me, but someone else must approve
did you verify?
--
To view, visit http://gerrit.ovirt.o
Mark Wu has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
'memProcessed' represents the amount of transferred memor
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix the syntax error in the comment of createVolume()
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#840300: setNetworking() return bridge status
..
Patch Set 1:
Yes, I am for stop bootstrap because of *ANY* failure. Major as minor...
--
To view, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#840300: setNetworking() return bridge status
..
Patch Set 1:
Alon, the only difference is that bootstrap's libvirt dependency is a new one...
I would have f
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ829710 Get VMList with oop if necessary
..
BZ829710 Get VMList with oop if necessary
Change-Id: I021e9d03b29dfc9cf1c3b7fa5ec8a302e7912cf7
Signed-off-
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Trigger reboot automatically after upgrade
..
Trigger reboot automatically after upgrade
Depends on related change http://gerrit.ovirt.org/
This pa
Dan Kenigsberg has posted comments on this change.
Change subject: Trigger reboot automatically after upgrade
..
Patch Set 2:
Alon: pure negligence.
--
To view, visit http://gerrit.ovirt.org/7778
To unsubscribe, visit http://g
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe, v
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 1: (2 inline comments)
File vdsm/libvirtvm.py
Line 356:
Line 357:
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 1:
I did not conduct an experiment. I just read the related code you mentioned. It
seems you are right. If memTota
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Please explain why calculation for memProgress i
Mark Wu has abandoned this change.
Change subject: WIP: refactor configNetwork
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/7714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Mark Wu has uploaded a new change for review.
Change subject: Refactor configNetwork.py: add a new class NativeConfigurator
..
Refactor configNetwork.py: add a new class NativeConfigurator
Basically, this patch just adds a new c
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 1:
I migrate to file without full copy of disk.
the guest memory is 1G, and at last the migration file is 221548328.
I
ShaoHe Feng has uploaded a new change for review.
Change subject: fix dataProgress of migration
..
fix dataProgress of migration
even if migeration is finished, dataProcessed may be less than
dataTotal, it will not up to 100%.
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 10: (1 inline comment)
File tests/functional/xmlrpcTe
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 9: (1 inline comment)
File tests/functional/xmlrpcTes
Bala.FA has posted comments on this change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
Patch Set 1: (1 inline comment)
Commit Mess
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Trigger reboot automatically after upgrade
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7778
To unsubscribe, visit http://gerr
Alon Bar-Lev has posted comments on this change.
Change subject: Trigger reboot automatically after upgrade
..
Patch Set 2:
how come this merged downstream and not upstream?
--
To view, visit http://gerrit.ovirt.org/7778
To un
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 6: (1 inline comment)
File vds_bootstrap/vds_boo
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 7: Verified
Incorporated Alon's comment
--
To view, visit http://gerrit.ovirt.org/7072
To unsub
Dafna Ron has posted comments on this change.
Change subject: BZ829710 Get VMList with oop if necessary
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/6867
To unsubscribe, visit http://gerrit.ovirt.org/setti
Dan Kenigsberg has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 9: (1 inline comment)
File tests/functional/xmlrpcTests
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 6: No score
(2 inline comments)
File vds_b
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the syntax error in the comment of createVolume()
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
..
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 6: (3 inline comments)
File vds_bootstrap/vds_bo
Dan Kenigsberg has posted comments on this change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 6: (3 inline comments)
File vds_bootstrap/v
Shu Ming has posted comments on this change.
Change subject: supervdsmServer is down after failed operation
..
Patch Set 3: I would prefer that you didn't submit this
In general, the exception is swallowed in __call__ in this f
Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 7: (1 inline comment)
In general it looks good... a minor comment.
.
Timothy Asir has posted comments on this change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7857
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: [WIP] Remove the domain weakref cache and parallelize
_findDomain
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7511
To unsu
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 6: (6 inline comments)
File vds_bootstrap/vds_bo
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 6: Verified
Addressing Alon's comments..
--
To view, visit http://gerrit.ovirt.org/7072
To unsu
Yaniv Bronhaim has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 9: Verified; Looks good to me, but someone else must approve
Still can't manage to get vm with faqemu to run
Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
..
Patch Set 2: (1 inline comment)
File vdsm/libvirtvm.py
Line 173:
Ayal Baron has posted comments on this change.
Change subject: Fix the check to convert block domains V0 to tag metadata
..
Patch Set 3: (1 inline comment)
File vdsm/storage/
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#840300: setNetworking() return bridge status
..
Patch Set 1:
> the installation semantics should not change just because of an
> irreproducible libvrit bug
I
Ayal Baron has posted comments on this change.
Change subject: Fix the check to convert block domains V0 to tag metadata
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7654
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: replace rpm commandline with rpm-python api in caps.py
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#840300: setNetworking() return bridge status
..
Patch Set 1:
I am uncomfortable with this change, particularly because of its peculiar
reasoning: the instal
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer is down after failed operation
..
Patch Set 3: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/7901
To unsu
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer is down after failed operation
..
Patch Set 2: (2 inline comments)
File vdsm/supervdsm.py
L
Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
..
Patch Set 2: (1 inline comment)
File vdsm/libvirtvm.py
Line 173:
Dan Kenigsberg has posted comments on this change.
Change subject: report idle time for multiple vcpus
..
Patch Set 2: (2 inline comments)
File vdsm/libvirtvm.py
Line 163:
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer is down after failed operation (#846307)
..
Patch Set 2: Verified
(2 inline comments)
I can't add ut for this specific change. This change is n
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer is down after failed operation (#846307)
..
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
Please add a unit test
Timothy Asir has posted comments on this change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerri
Yaniv Bronhaim has uploaded a new change for review.
Change subject: supervdsmServer is down after failed operation (#851832)
..
supervdsmServer is down after failed operation (#851832)
https://bugzilla.redhat.com/show_bug.cgi?i
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#841555 A migration failure with an "AttributeError"
exception.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Barak Azulay has posted comments on this change.
Change subject: BZ#841555 A migration failure with an "AttributeError"
exception.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Barak Azulay has posted comments on this change.
Change subject: BZ#829110 Remove a "Domain not found" error from stats thread.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 5:
The current code assumes that there is dmidecode and it returns .
Anyway, we have many issues wit
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 5: No score
Hi Alon,
Since getHostID() handles the case where getMachineUUID is not available I
Antoni Segura Puimedon has posted comments on this change.
Change subject: report idle time for multiple vcpus
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7892
To un
Laszlo Hornyak has posted comments on this change.
Change subject: report idle time for multiple vcpus
..
Patch Set 1: (1 inline comment)
File vdsm/libvirtvm.py
Line 163:
Antoni Segura Puimedon has posted comments on this change.
Change subject: report idle time for multiple vcpus
..
Patch Set 1: (1 inline comment)
File vdsm/libvirtvm.py
Line
Laszlo Hornyak has uploaded a new change for review.
Change subject: report idle time for multiple vcpus
..
report idle time for multiple vcpus
The idle time is now on a 0-100 scale. If the VM has multiple vcpus and
the load goe
Mark Wu has uploaded a new change for review.
Change subject: Add vdsm-tool/load_needed_modules.py to .gitignore
..
Add vdsm-tool/load_needed_modules.py to .gitignore
When we're adding a new file (*.py.in) using the macro of aut
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 5:
You will also need to modify the getMachineUUID() as you do not have dmidecode
anymore.
--
To vi
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 5: (4 inline comments)
File vds_bootstrap/vds_bo
Dan Kenigsberg has submitted this change and it was merged.
Change subject: glusterHostsList verb uses gluster cli xml output.
..
glusterHostsList verb uses gluster cli xml output.
This eliminates standard output text parsing.
Dan Kenigsberg has posted comments on this change.
Change subject: glusterHostsList verb uses gluster cli xml output.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7617
To unsubscribe, vis
Antoni Segura Puimedon has posted comments on this change.
Change subject: Improve the validation of netmask and gateway
..
Patch Set 4: Looks good to me, but someone else must approve
Looking forward to see it merged.
--
To v
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: perform reboot asynchronously
..
Patch Set 4:
Mike, Fabian,
Maybe you consider taking that approach for the python reboot.
Alon.
--
To view, visit h
Timothy Asir has posted comments on this change.
Change subject: glusterHostsList verb uses gluster cli xml output.
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Dan Kenigsberg has uploaded a new change for review.
Change subject: Factor betterThreading out of Vdsm
..
Factor betterThreading out of Vdsm
Recently, I've spun-off betterThreading as
http://pypi.python.org/pypi/pthreading and
76 matches
Mail list logo
