Re: Review Request 25035: Fix for MESOS-1688
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review53002 --- src/common/resources.cpp https://reviews.apache.org/r/25035/#comment92333 I'm not sure what's happening here. Can you add a comment? src/master/master.cpp https://reviews.apache.org/r/25035/#comment92334 Add a TODO: TODO(martin): Return Error instead of logging a warning in 0.21.0. src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92336 s/with cpus only/using only cpus/ src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92335 s/tasks/task/ src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92337 s/with memory only/using only memory/ src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92338 s/mem/memory/ src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92339 s/tasks/task/ - Vinod Kone On Sept. 10, 2014, 10 p.m., Martin Weindel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 10, 2014, 10 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1688 https://issues.apache.org/jira/browse/MESOS-1688 Repository: mesos-git Description --- As already explained in JIRA MESOS-1688, there are schedulers allocating memory only for the executor and not for tasks. For tasks only CPU resources are allocated in this case. Such a scheduler does not get offered any idle CPUs if the slave has nearly used up all memory. This can easily lead to a dead lock (in the application, not in Mesos). Simple example: 1. Scheduler allocates all memory of a slave for an executor 2. Scheduler launches a task for this executor (allocating 1 CPU) 3. Task finishes: 1 CPU , 0 MB memory allocatable. 4. No offers are made, as no memory is left. Scheduler will wait for offers forever. Dead lock in the application. To fix this problem, offers must be made if CPU resources are allocatable without considering allocatable memory Diffs - src/common/resources.cpp edf36b1 src/master/constants.cpp faa1503 src/master/hierarchical_allocator_process.hpp 34f8cd6 src/master/master.cpp 18464ba src/tests/allocator_tests.cpp 774528a Diff: https://reviews.apache.org/r/25035/diff/ Testing --- Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested running multiple parallel Spark jobs in fine-grained mode to saturate allocatable memory. The jobs run fine now. This load always caused a dead lock in all Spark jobs within one minute with the unpatched Mesos. Thanks, Martin Weindel
Re: Review Request 25035: Fix for MESOS-1688
On Sept. 11, 2014, 5:35 a.m., Vinod Kone wrote: Can you also update the summary of the review to something more meaningful? We typically use the summary to generate the commit message. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review53002 --- On Sept. 10, 2014, 10 p.m., Martin Weindel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 10, 2014, 10 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1688 https://issues.apache.org/jira/browse/MESOS-1688 Repository: mesos-git Description --- As already explained in JIRA MESOS-1688, there are schedulers allocating memory only for the executor and not for tasks. For tasks only CPU resources are allocated in this case. Such a scheduler does not get offered any idle CPUs if the slave has nearly used up all memory. This can easily lead to a dead lock (in the application, not in Mesos). Simple example: 1. Scheduler allocates all memory of a slave for an executor 2. Scheduler launches a task for this executor (allocating 1 CPU) 3. Task finishes: 1 CPU , 0 MB memory allocatable. 4. No offers are made, as no memory is left. Scheduler will wait for offers forever. Dead lock in the application. To fix this problem, offers must be made if CPU resources are allocatable without considering allocatable memory Diffs - src/common/resources.cpp edf36b1 src/master/constants.cpp faa1503 src/master/hierarchical_allocator_process.hpp 34f8cd6 src/master/master.cpp 18464ba src/tests/allocator_tests.cpp 774528a Diff: https://reviews.apache.org/r/25035/diff/ Testing --- Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested running multiple parallel Spark jobs in fine-grained mode to saturate allocatable memory. The jobs run fine now. This load always caused a dead lock in all Spark jobs within one minute with the unpatched Mesos. Thanks, Martin Weindel
Re: Completed tasks remains in TASK_RUNNING when framework is disconnected
The semantics of these changes would have an impact on the upcoming task reconciliation. @BenM: Can you chime in here on how this fits into the task reconciliation work that you've been leading? On Wed, Sep 10, 2014 at 6:12 PM, Adam Bordelon a...@mesosphere.io wrote: I agree with Niklas that if the executor has sent a terminal status update to the slave, then the task is done and the master should be able to recover those resources. Only sending the oldest status update to the master, especially in the case of framework failover, prevents these resources from being recovered in a timely manner. I see a couple of options for getting around this, each with their own disadvantages. 1) Send the entire status update stream to the master. Once the master sees the terminal status update, it will removeTask and recover the resources. Future resends of the update will be forwarded to the scheduler, but the master will ignore (with warning and invalid_update++ metrics) the subsequent updates as far as its own state for the removed task is concerned. Disadvantage: Potentially sends a lot of status update messages until the scheduler reregisters and acknowledges the updates. Disadvantage2: Updates could be sent to the scheduler out of order if some updates are dropped between the slave and master. 2) Send only the oldest status update to the master, but with an annotation of the final/terminal state of the task, if any. That way the master can call removeTask to update its internal state for the task (and update the UI) and recover the resources for the task. While the scheduler is still down, the oldest update will continue to be resent and forwarded, but the master will ignore the update (with a warning as above) as far as its own internal state is concerned. When the scheduler reregisters, the update stream will be forwarded and acknowledged one-at-a-time as before, guaranteeing status update ordering to the scheduler. Disadvantage: Seems a bit hacky to tack a terminal state onto a running update. Disadvantage2: State endpoint won't show all the status updates until the entire stream actually gets forwarded+acknowledged. Thoughts? On Wed, Sep 10, 2014 at 5:55 PM, Vinod Kone vinodk...@gmail.com wrote: The main reason is to keep status update manager simple. Also, it is very easy to enforce the order of updates to the master/framework in this model. If we allow multiple updates for a task to be in flight, it's really hard (impossible?) to ensure that we are not delivering out-of-order updates even in edge cases (failover, network partitions etc). On Wed, Sep 10, 2014 at 5:35 PM, Niklas Nielsen nik...@mesosphere.io wrote: Hey Vinod - thanks for chiming in! Is there a particular reason for only having one status in flight? Or to put it in another way, isn't that too strict behavior taken that the master state could present the most recent known state if the status update manager tried to send more than the front of the stream? Taken very long timeouts, just waiting for those to disappear seems a bit tedious and hogs the cluster. Niklas On 10 September 2014 17:18, Vinod Kone vinodk...@gmail.com wrote: What you observed is expected because of the way the slave (specifically, the status update manager) operates. The status update manager only sends the next update for a task if a previous update (if it exists) has been acked. In your case, since TASK_RUNNING was not acked by the framework, master doesn't know about the TASK_FINISHED update that is queued up by the status update manager. If the framework never comes back, i.e., failover timeout elapses, master shuts down the framework, which releases those resources. On Wed, Sep 10, 2014 at 4:43 PM, Niklas Nielsen nik...@mesosphere.io wrote: Here is the log of a mesos-local instance where I reproduced it: https://gist.github.com/nqn/f7ee20601199d70787c0 (Here task 10 to 19 are stuck in running state). There is a lot of output, so here is a filtered log for task 10: https://gist.github.com/nqn/a53e5ea05c5e41cd5a7d At first glance, it looks like the task can't be found when trying to forward the finish update because the running update never got acknowledged before the framework disconnected. I may be missing something here. Niklas On 10 September 2014 16:09, Niklas Nielsen nik...@mesosphere.io wrote: Hi guys, We have run into a problem that cause tasks which completes, when a framework is disconnected and has a fail-over time, to remain in a running state even though the tasks actually finishes. Here is a test framework we have been able to reproduce the issue with: https://gist.github.com/nqn/9b9b1de9123a6e836f54 It launches many short-lived tasks (1
Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review53100
---
OK. I went through parts of this review but I have a bigger suggestion in mind,
before I get too much into the weeds.
I think it's worthwhile for you to write up a design doc similar to the
framework info doc w.r.t. updating SlaveInfo. This will force you to think
about the repercussions of changing each of the SlaveInfo fields on the Mesos
stack (master/allocator/slave/tasks/executors). Are you game?
src/common/attributes.cpp
https://reviews.apache.org/r/25525/#comment92503
2 blank lines between outer elements.
src/common/attributes.cpp
https://reviews.apache.org/r/25525/#comment92506
Why not just add = and = operator overloads like we did for Resources
instead of adding subset/superset methods?
Also, please add tests for these in attributes_tests.cpp.
src/common/attributes.cpp
https://reviews.apache.org/r/25525/#comment92504
2 blank lines between outer elements.
src/common/attributes.cpp
https://reviews.apache.org/r/25525/#comment92505
2 blank lines between outer elements.
src/common/slaveinfo_utils.hpp
https://reviews.apache.org/r/25525/#comment92510
I think this function name is misleading. It is not reconfiguring a slave,
it is just doing a compatibility test.
Trybool isCompatible(
const mesos::SlaveInfo newInfo,
const mesos::SlaveInfo oldInfo);
You should also add a comment on what this method is doing, when is it
considered compatible etc.
src/common/slaveinfo_utils.cpp
https://reviews.apache.org/r/25525/#comment92514
Typo? This sentence is incomplete.
src/common/slaveinfo_utils.cpp
https://reviews.apache.org/r/25525/#comment92515
Please use camelCase instead of snake case for variable names. There are
only few exceptions in the code base to this rule, but they usually come with a
good reason.
s/attributes_new/newAttributes/
s/resources_new/newResources/
s/resources_old/oldResources/
src/common/slaveinfo_utils.cpp
https://reviews.apache.org/r/25525/#comment92516
you can compare the slave ids directly, instead of strings, if you include
common/type_utils.hpp
Error(SlaveID cannot be changed (old: + stringify(old.id()) + , new:
+ stringify(new.id()) + ))
src/common/slaveinfo_utils.cpp
https://reviews.apache.org/r/25525/#comment92535
I think we have to be careful about allowing 'checkpoint' to be changed.
If you haven't already, please refer to the design doc for updating
FrameworkInfo
(https://docs.google.com/document/d/1vEBuFN9mm3HkrNCmkAuwX-4kNYv0MwjUecLE3Jp_BqE/edit?usp=sharing)
which talks about checkpointing.
In particular what are the semantics for already running tasks/executors if
'checkpoint' is changed?
src/common/slaveinfo_utils.cpp
https://reviews.apache.org/r/25525/#comment92522
also include the new and old attributes in the error message to ease
debugging.
src/common/slaveinfo_utils.cpp
https://reviews.apache.org/r/25525/#comment92523
new line.
also, include the old and new resources in the error message.
src/common/slaveinfo_utils.cpp
https://reviews.apache.org/r/25525/#comment92532
How about:
```
TryNothing isCompatible(const SlaveInfo newSlaveInfo, const SlaveInfo
oldSlaveIfno)
{
// ..
if (!(newSlaveInfo.id() == oldSlaveInfo.id())) {
return Error(...);
}
//...
if (newSlaveInfo.hostname() != oldSlaveInfo.hostname()) {
return Error(...);
}
//...
if (newSlaveInfo.resources() oldSlaveInfo.resources()) {
return Error(...);
}
//...
if (newSlaveInfo.attributes() oldSlaveInfo.attributes()) {
return Error(...);
}
return Nothing();
}
```
src/slave/slave.cpp
https://reviews.apache.org/r/25525/#comment92520
Why is this function returning a Trybool instead of TryNothing? I don't
see how it is using the boolean?
Also,
s/res/compatible/
src/slave/slave.cpp
https://reviews.apache.org/r/25525/#comment92534
I don't think there's much value left with logging the old and new slave
info. The res.error() will pinpoint what the error is.
src/slave/slave.cpp
https://reviews.apache.org/r/25525/#comment92521
You should checkpoint the updated slave info!
- Vinod Kone
On Sept. 11, 2014, 8:13 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/
---
(Updated Sept. 11, 2014, 8:13 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod
Re: Review Request 25549: Basic filesystem isolator for Linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review53126 --- src/common/parse.hpp https://reviews.apache.org/r/25549/#comment92541 s/string/string or file/ src/slave/containerizer/isolators/filesystem/shared.hpp https://reviews.apache.org/r/25549/#comment92549 Can you add a high level comment on what this isolator does? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92550 You should print user.Error(). src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92552 s/container_path/container path/ s/host_path/host path/ here and everywhere else. either that or you need to say 'Volume.container_path' or 'Volume.host_path' which I'm assuming you don't want to do :) src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92551 s/shared/host/ ? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92576 consider creating it if it's a relative path. src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92554 quote the paths here and everywhere else. src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92555 s/other/container_path/ ? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92556 s/host_path/hostPath/ src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92559 hostPath = path::join( directory, strings::remove(...)); src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92560 include the error. src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92561 include chmod.error() src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92565 mind refactoring os::chown() to take uid and gid? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment92557 s/automatically/automatically by the kernel/ ? also, how is the mount namespace destroyed? src/slave/containerizer/linux_launcher.cpp https://reviews.apache.org/r/25549/#comment92548 Kill this TODO? src/slave/containerizer/mesos/containerizer.cpp https://reviews.apache.org/r/25549/#comment92577 I'm assuming we want to support TaskInfo.ContainerInfo.Type() to be MESOS? If yes, this check should be fixed too. src/slave/flags.hpp https://reviews.apache.org/r/25549/#comment92543 I don't think you need this header in this file? src/slave/flags.hpp https://reviews.apache.org/r/25549/#comment92546 What about TaskInfo that doesn't use a ExecutorInfo. Is the default injected into that as well? src/slave/flags.hpp https://reviews.apache.org/r/25549/#comment92545 s/RO/RW/ ? :) src/slave/slave.cpp https://reviews.apache.org/r/25549/#comment92547 How about doing this in Slave::getExecutorInfo() instead? Thats the place we do all sorts of manipulations on ExecutorInfo. src/tests/isolator_tests.cpp https://reviews.apache.org/r/25549/#comment92584 Can you add a comment here on what this test is doing? src/tests/isolator_tests.cpp https://reviews.apache.org/r/25549/#comment92578 s/container_path/containerPath/ src/tests/isolator_tests.cpp https://reviews.apache.org/r/25549/#comment92580 Is this guaranteed to exist on all systems? src/tests/isolator_tests.cpp https://reviews.apache.org/r/25549/#comment92579 s/host_path/hostPath/ src/tests/isolator_tests.cpp https://reviews.apache.org/r/25549/#comment92581 const? src/tests/isolator_tests.cpp https://reviews.apache.org/r/25549/#comment92586 s/sHost/hostStat/ src/tests/isolator_tests.cpp https://reviews.apache.org/r/25549/#comment92587 s/sContainer/containerStat/ - Vinod Kone On Sept. 11, 2014, 6:46 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 11, 2014, 6:46 p.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1586 https://issues.apache.org/jira/browse/MESOS-1586 Repository: mesos-git Description --- Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. This review replaces https://reviews.apache.org/r
Re: Review Request 25549: Basic filesystem isolator for Linux.
On Sept. 11, 2014, 7:13 p.m., Timothy Chen wrote: src/slave/containerizer/isolators/filesystem/shared.cpp, line 125 https://reviews.apache.org/r/25549/diff/1/?file=686147#file686147line125 how about when the host path doesn't start with /? +1 - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review53090 --- On Sept. 11, 2014, 6:46 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 11, 2014, 6:46 p.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1586 https://issues.apache.org/jira/browse/MESOS-1586 Repository: mesos-git Description --- Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. This review replaces https://reviews.apache.org/r/24178/ because of some file renaming. I addressed all comments from earlier reviews. Diffs - include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/linux_launcher.cpp d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95 src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 Diff: https://reviews.apache.org/r/25549/diff/ Testing --- make check # added a test Thanks, Ian Downes
Re: Mesos webcast
+Matt Hey Kamil, Bummed to hear that you weren't able to tune in to the webinar. Matt tells me that the webinar will be posted online soon. Will make sure to ping the dev list when that happens. Cheers, On Thu, Sep 11, 2014 at 11:22 AM, Kamil Domański kdoman...@kdemail.net wrote: Hello Vinod, thank you for doing this. How sweet is the irony of the fact, that this webinar cannot be attended from a Linux machine. If anyone could later post a link to a recording of this webcast, then the magnitude of my gratitude could only be eclipsed by my disappointment with these technical difficulties. Thanks in advance, Kamil On 09/09/2014 07:22 PM, Vinod Kone wrote: Hi folks, I'm doing a webcast on Mesos this thursday (h/t Mesosphere) where I will talk about some of the core features of Mesos (slave recovery, authentication and authorization). At the end, we will have time for QA for any and all questions related to Mesos. More details: https://attendee.gotowebinar.com/register/ 7957587123935365890 Thanks,
Re: 0.20.1 Release Manager
Tim St. Clair or Adam, would you guys be willing to work with Bhuvan to get the release out? On Fri, Sep 12, 2014 at 10:12 AM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hi Bhuvan, that's great! However, doing a release requires commit access. On Sep 12, 2014, at 8:06 AM, Bhuvan Arumugam bhu...@apache.org wrote: I like to volunteer for this role. There are 18 bugs targetted for this release. If we want to target any other bug fixes for this release, please ensure Target version flag is set as 0.20.1 for that bug. https://issues.apache.org/jira/browse/MESOS-1621?jql=project%20%3D%20MESOS%20AND%20%22Target%20Version%2Fs%22%20%3D%200.20.1 15 out of 18 are either resolved/merged or patch in reviewboard. The following 3 bugs are not in progress. If we dont intend to fix these bugs in this release, please remove 0.20.1 from Target version. https://issues.apache.org/jira/browse/MESOS-1776 - --without-PACKAGE will set incorrect dependency prefix https://issues.apache.org/jira/browse/MESOS-1775 - Libprocess wants source for unbundled gmock https://issues.apache.org/jira/browse/MESOS-1741 - mesos-slave shouldn't fail if dockerd is down I'll touch base on IRC when we will be ready to start the voting. /me is bhuvan on IRC On Thu, Sep 11, 2014 at 10:41 PM, Jie Yu yujie@gmail.com wrote: I am a little swamped recently, anyone volunteer for the release manager? - Jie On Thu, Sep 11, 2014 at 6:04 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Do we have a volunteer to be the 0.20.1 release manager? Looks like a number of tickets are being added at this point for 0.20.1: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MESOS%20AND%20%22Target%20Version%2Fs%22%20%3D%200.20.1 -- Regards, Bhuvan Arumugam www.livecipher.com
Re: 0.20.1 Release Manager
awesome. thanks guys! On Fri, Sep 12, 2014 at 12:47 PM, Adam Bordelon a...@mesosphere.io wrote: I can be the release manager, especially if Bhuvan wants to manage some of the administrivia. On Fri, Sep 12, 2014 at 12:23 PM, Tim St Clair tstcl...@redhat.com wrote: I would like to, but this next month is going to be crazy for me. Perhaps the next cycle. Regards, Tim - Original Message - From: Vinod Kone vinodk...@gmail.com To: dev dev@mesos.apache.org Sent: Friday, September 12, 2014 12:22:59 PM Subject: Re: 0.20.1 Release Manager Tim St. Clair or Adam, would you guys be willing to work with Bhuvan to get the release out? On Fri, Sep 12, 2014 at 10:12 AM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hi Bhuvan, that's great! However, doing a release requires commit access. On Sep 12, 2014, at 8:06 AM, Bhuvan Arumugam bhu...@apache.org wrote: I like to volunteer for this role. There are 18 bugs targetted for this release. If we want to target any other bug fixes for this release, please ensure Target version flag is set as 0.20.1 for that bug. https://issues.apache.org/jira/browse/MESOS-1621?jql=project%20%3D%20MESOS%20AND%20%22Target%20Version%2Fs%22%20%3D%200.20.1 15 out of 18 are either resolved/merged or patch in reviewboard. The following 3 bugs are not in progress. If we dont intend to fix these bugs in this release, please remove 0.20.1 from Target version. https://issues.apache.org/jira/browse/MESOS-1776 - --without-PACKAGE will set incorrect dependency prefix https://issues.apache.org/jira/browse/MESOS-1775 - Libprocess wants source for unbundled gmock https://issues.apache.org/jira/browse/MESOS-1741 - mesos-slave shouldn't fail if dockerd is down I'll touch base on IRC when we will be ready to start the voting. /me is bhuvan on IRC On Thu, Sep 11, 2014 at 10:41 PM, Jie Yu yujie@gmail.com wrote: I am a little swamped recently, anyone volunteer for the release manager? - Jie On Thu, Sep 11, 2014 at 6:04 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Do we have a volunteer to be the 0.20.1 release manager? Looks like a number of tickets are being added at this point for 0.20.1: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MESOS%20AND%20%22Target%20Version%2Fs%22%20%3D%200.20.1 -- Regards, Bhuvan Arumugam www.livecipher.com -- Cheers, Timothy St. Clair Red Hat Inc.
Re: Review Request 25565: Added a removeExecutor helper in the Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25565/#review53222 --- Ship it! src/master/master.cpp https://reviews.apache.org/r/25565/#comment92732 We do have a executorLost() callback now! Just send it already and fix MESOS-313? src/master/master.cpp https://reviews.apache.org/r/25565/#comment92733 I think absent in re-registration of slave is a bit unclear for people reading this log line in master logs? How about ...possibly unknown to the slave? I'm assuming you wanted to rephrase because slave could actually know it? - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25565/ --- (Updated Sept. 12, 2014, 2:01 a.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- This adds a removeExecutor helper based on a TODO that I added awhile ago. Much like removeTask, removeExecutor will help avoid future resource accounting bugs. I also cleaned up Master::finalize Diffs - src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 Diff: https://reviews.apache.org/r/25565/diff/ Testing --- no functional change make check Thanks, Ben Mahler
Re: ANN: Mesos bindings for Haskell
Great to see the Haskell bindings Ian! See my answers inline. * It seems like there are portions of mesos.proto that aren’t currently supported by the API yet: in particular, “Credentials”, “ACL”, “ACLS”, “RateLimit”, “RateLimits” don’t seem like they do anything yet. Am I missing something? The protos you mentioned are used by Masters/Slaves. I don't remember off hand why they are in the public mesos.proto instead of the internal messages.proto. If there is no good reason, we should move them to the latter. * Is there a way to add information about additional resources besides CPUs/Mem/Ports? What sort of information? Currently we have isolators for only these resources. If you add new types (e.g., IPs) , Mesos should do the accounting correctly but not provide any isolation. * When an executor sends a message, it’s considered “best effort”– what does that mean in practice? How do people currently use this functionality? I'm assuming you are referring to the Executor::sendFrameworkMessage(). It is best effort in the sense that Mesos doesn't try to retry the message (unlike status updates) if it fails anywhere on the path from slave-master-framework (e.g., due to master failover). Executors could use this to send periodic messages where losing a message is not catastrophic. For example Aurora uses this to do periodic state reconciliation.
Re: Review Request 25604: Fixed the flaky FaultToleranceTest.ReconcilePendingTasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25604/#review53254 --- Ship it! Ship It! - Vinod Kone On Sept. 13, 2014, 12:13 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25604/ --- (Updated Sept. 13, 2014, 12:13 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1786 https://issues.apache.org/jira/browse/MESOS-1786 Repository: mesos-git Description --- On a slow VM, the dispatch did not occur before the test finished, and DROP_DISPATCH triggers a test failure if this is the case. The solution is to wait for the dispatch to occur. Diffs - src/tests/fault_tolerance_tests.cpp 80d7fcff0cac8b862c727706b6931aaeba9e49dd Diff: https://reviews.apache.org/r/25604/diff/ Testing --- Ran this test in repetition. Thanks, Ben Mahler
Re: Contributor role in Jira
Done. On Sun, Sep 14, 2014 at 5:24 PM, Bhuvan Arumugam bhu...@apache.org wrote: Vinod, I'm working with Adam Bordelon to manage 0.20.1 release. Can you grant me Contributor access in jira to manage versions and changelogs? Thank you, -- Regards, Bhuvan Arumugam www.livecipher.com
Re: Review Request 25035: Fix for MESOS-1688
On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote: src/master/hierarchical_allocator_process.hpp, line 837 https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837 What happens in the case where all CPUs are taken but memory is available? It looks like it will return (true), but this should not be possible. I think you want to give an offer in the case where there are CPU resources available, but memory is consumed by the executor. Giving memory only resources is ok as long as it is used for a task and not an executor. See my comments above. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review53343 --- On Sept. 13, 2014, 7:10 p.m., Martin Weindel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 13, 2014, 7:10 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1688 https://issues.apache.org/jira/browse/MESOS-1688 Repository: mesos-git Description --- As already explained in JIRA MESOS-1688, there are schedulers allocating memory only for the executor and not for tasks. For tasks only CPU resources are allocated in this case. Such a scheduler does not get offered any idle CPUs if the slave has nearly used up all memory. This can easily lead to a dead lock (in the application, not in Mesos). Simple example: 1. Scheduler allocates all memory of a slave for an executor 2. Scheduler launches a task for this executor (allocating 1 CPU) 3. Task finishes: 1 CPU , 0 MB memory allocatable. 4. No offers are made, as no memory is left. Scheduler will wait for offers forever. Dead lock in the application. To fix this problem, offers must be made if CPU resources are allocatable without considering allocatable memory Diffs - CHANGELOG a822cc4 src/common/resources.cpp edf36b1 src/master/constants.cpp faa1503 src/master/hierarchical_allocator_process.hpp 34f8cd6 src/master/master.cpp 18464ba src/tests/allocator_tests.cpp 774528a Diff: https://reviews.apache.org/r/25035/diff/ Testing --- Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested running multiple parallel Spark jobs in fine-grained mode to saturate allocatable memory. The jobs run fine now. This load always caused a dead lock in all Spark jobs within one minute with the unpatched Mesos. Thanks, Martin Weindel
Re: Review Request 25035: Fix for MESOS-1688
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review53362 --- Minor nits and we will get this committed. Thanks for your patience Martin. CHANGELOG https://reviews.apache.org/r/25035/#comment93059 Thinking a bit more about this and talking to others. Adding deprecations in a bug fix release is bit weird. 2 options. 1) We can land this feature in 0.21.0 and not 0.20.1. That way we will do deprecation warning in 0.21.0 and disallow cpu/mem only executors in 0.22.0. This is the most straightforward. 2) Land this in 0.20.1, but the deprecation warning, in changelog (and ResourceUsageChecker?), happens in 0.21.0. The disallowing hapens in 0.22.0. This is bit weird but not too bad if you absolutely need this in 0.20.1. Considering 0.21.0 would happen in a month or so, I prefer #1. Does that work for you? src/master/master.cpp https://reviews.apache.org/r/25035/#comment92992 also log the cpu resources used by the executor for easier debugging. e.g., LOG(WARNING) Executor task.executor().executor_id() for task task.task_id() uses less CPUs ( cpus.isSome() ? cpus.get() : none ) than the minimum required ( MIN_CPUS ). Please update src/master/master.cpp https://reviews.apache.org/r/25035/#comment92993 ditto. log requested memory. src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92991 2 blank lines. src/tests/allocator_tests.cpp https://reviews.apache.org/r/25035/#comment92990 2 blank lines. - Vinod Kone On Sept. 13, 2014, 7:10 p.m., Martin Weindel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 13, 2014, 7:10 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1688 https://issues.apache.org/jira/browse/MESOS-1688 Repository: mesos-git Description --- As already explained in JIRA MESOS-1688, there are schedulers allocating memory only for the executor and not for tasks. For tasks only CPU resources are allocated in this case. Such a scheduler does not get offered any idle CPUs if the slave has nearly used up all memory. This can easily lead to a dead lock (in the application, not in Mesos). Simple example: 1. Scheduler allocates all memory of a slave for an executor 2. Scheduler launches a task for this executor (allocating 1 CPU) 3. Task finishes: 1 CPU , 0 MB memory allocatable. 4. No offers are made, as no memory is left. Scheduler will wait for offers forever. Dead lock in the application. To fix this problem, offers must be made if CPU resources are allocatable without considering allocatable memory Diffs - CHANGELOG a822cc4 src/common/resources.cpp edf36b1 src/master/constants.cpp faa1503 src/master/hierarchical_allocator_process.hpp 34f8cd6 src/master/master.cpp 18464ba src/tests/allocator_tests.cpp 774528a Diff: https://reviews.apache.org/r/25035/diff/ Testing --- Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested running multiple parallel Spark jobs in fine-grained mode to saturate allocatable memory. The jobs run fine now. This load always caused a dead lock in all Spark jobs within one minute with the unpatched Mesos. Thanks, Martin Weindel
Re: Review Request 25566: Minor cleanups to the Master code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25566/#review53449 --- Ship it! src/master/master.cpp https://reviews.apache.org/r/25566/#comment93108 - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25566/ --- (Updated Sept. 12, 2014, 2:01 a.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- (1) Updated the Slave struct to avoid counting resources. Rather, when asked, compute resources based on the tasks. This makes it easier to do the resource accounting in https://reviews.apache.org/r/25567/ where we hold on to terminal tasks. (2) Cleaned up the task removal logging, to be inside removeTask(Task*). (3) Consistently use utils::copy instead of keys() / values() when a copy is required to iterate correctly, to make it more explicit to the reader. Diffs - src/master/http.cpp 6dd11fe5297ea68331b5e9f23a6d8590edecedc4 src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 Diff: https://reviews.apache.org/r/25566/diff/ Testing --- no functional change make check Thanks, Ben Mahler
Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25567/#review53450 --- Ship it! src/master/master.hpp https://reviews.apache.org/r/25567/#comment93109 s/updateTaskState/updateTask/ since you are not just updating the state? src/master/master.hpp https://reviews.apache.org/r/25567/#comment93110 s/a/the/ - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25567/ --- (Updated Sept. 12, 2014, 2:01 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-1410 https://issues.apache.org/jira/browse/MESOS-1410 Repository: mesos-git Description --- This is the MESOS-1410 which fixes MESOS-1389. The idea here is that the master needs to hold on to those tasks that are terminal, but have yet to be acknowledged by the scheduler. Otherwise, reconciliation requests could lead to TASK_LOST updates **before** a framework receives a terminal TASK_FINISHED/TASK_FAILED/etc update for the task. Now the master needs to: (1) Remove tasks when an acknowledgement arrives. (2) Recover resources when the task becomes terminal. (3) Omit resources for terminal tasks in the http statistics. Diffs - src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 Diff: https://reviews.apache.org/r/25567/diff/ Testing --- make check Added new tests in https://reviews.apache.org/r/25568/ Thanks, Ben Mahler
Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53484 --- src/tests/master_tests.cpp https://reviews.apache.org/r/25568/#comment93123 Hmm... This is not passed to StartSlave()? src/tests/master_tests.cpp https://reviews.apache.org/r/25568/#comment93124 s/task terminal/task in terminal state/ src/tests/master_tests.cpp https://reviews.apache.org/r/25568/#comment93126 The Ignore subsequent offers comment is incorrect here. src/tests/master_tests.cpp https://reviews.apache.org/r/25568/#comment93127 What is the guarantee that offers2 will be made after task's resources are recovered? src/tests/reconciliation_tests.cpp https://reviews.apache.org/r/25568/#comment93128 s/ensure/ensures/ src/tests/reconciliation_tests.cpp https://reviews.apache.org/r/25568/#comment93129 s/task terminal/task in terminal state/ src/tests/reconciliation_tests.cpp https://reviews.apache.org/r/25568/#comment93131 Why do you want to make sure that master received the reconcile tasks message? Isn't the receipt of the update guarantee that? Actually, thinking a bit more, how do you guarantee that the second update was due to reconcile tasks and not a retry by the slave? - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/ --- (Updated Sept. 12, 2014, 2:01 a.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-1410 https://issues.apache.org/jira/browse/MESOS-1410 Repository: mesos-git Description --- Added two tests: (1) Ensure that reconciliation works for terminal unacknowledged tasks. (2) Ensure that resources are released for terminal unacknowledged tasks. Diffs - src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 src/tests/master_tests.cpp 3d080b2efad5a210353d4cef4c827380d5138d1a src/tests/reconciliation_tests.cpp 1c9e73b0ee99a8a33f663f992b0c9770e83b98c5 Diff: https://reviews.apache.org/r/25568/diff/ Testing --- make check, ran these new tests in repetition Thanks, Ben Mahler
Re: Mesos 0.20.1 release status
On Mon, Sep 15, 2014 at 11:19 PM, Bhuvan Arumugam bhu...@apache.org wrote: I'll cut the tag for RC1 and send for voting, once these issues are reviewed/submitted or 9/15 @6pm PDT, whichever comes first! The open issues (if any) will be moved to next release, at that point in time. You want Adam to do this part because it needs committer access. Thanks for the ticket wrangling by the way!
Re: Review Request 25695: Update to enable systemd control of mesos services
On Sept. 16, 2014, 7:27 p.m., Mesos ReviewBot wrote: Patch looks great! Reviews applied: [25695] All tests passed. I'll let @jieyu comment shepherd this, but I think we should not rush this into 0.20.1 because this is not a bug in 0.20.0. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/#review53571 --- On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25695/ --- (Updated Sept. 16, 2014, 6:19 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1195 https://issues.apache.org/jira/browse/MESOS-1195 Repository: mesos-git Description --- This update enables support for systemd co-managed cgroup controllers Diffs - configure.ac c4b4391 src/linux/cgroups.cpp 5093b4c src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad47 Diff: https://reviews.apache.org/r/25695/diff/ Testing --- systemctl start mesos-master mesos-slave several runs of 'mesos execute' to verify creation and cleanup. systemctl stop mesos-master mesos-slave make check Thanks, Timothy St. Clair
Re: Build failed in Jenkins: mesos-reviewbot #1600
On Wed, Sep 17, 2014 at 9:56 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: ../../src/tests/docker_tests.cpp: In member function 'virtual void DockerTest_ROOT_DOCKER_CheckPortResource_Test::TestBody()': ../../src/tests/docker_tests.cpp:263:28: error: 'AWAIT_EXPECTED_FAILED' was not declared in this scope AWAIT_EXPECTED_FAILED(run); ^ @Tim: Can you fix this?
Re: Review Request 25549: Basic filesystem isolator for Linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review53710 --- I'll take a look once the outstanding issues are addressed. - Vinod Kone On Sept. 15, 2014, 8:01 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 15, 2014, 8:01 p.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1586 https://issues.apache.org/jira/browse/MESOS-1586 Repository: mesos-git Description --- Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. This review replaces https://reviews.apache.org/r/24178/ because of some file renaming. I addressed all comments from earlier reviews. Diffs - include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/linux_launcher.cpp d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95 src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 Diff: https://reviews.apache.org/r/25549/diff/ Testing --- make check # added a test Thanks, Ian Downes
Re: Review Request 25655: Add alternate os::chown taking uid and gid.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25655/#review53714 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 8 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25655/ --- (Updated Sept. 15, 2014, 8 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- Add alternate os::chown taking uid and gid. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5bbf829b3fa5d09a92e1d64c52c1fc7eed73fc91 Diff: https://reviews.apache.org/r/25655/diff/ Testing --- Add alternate os::chown taking uid and gid. Thanks, Ian Downes
Re: Review Request 25261: Check for variadic template support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review53715 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 10:26 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/ --- (Updated Sept. 15, 2014, 10:26 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1752 https://issues.apache.org/jira/browse/MESOS-1752 Repository: mesos-git Description --- add c++11 language features to m4 macro that checks for c++11 support Diffs - docs/mesos-c++-style-guide.md 4381d24412aa3d5a6edd940ea8817515d6339f12 m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b Diff: https://reviews.apache.org/r/25261/diff/ Testing --- built with g++-4.4, the minimum compiler we support. Thanks, Dominic Hamon
Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/#review53718 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 10:20 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/ --- (Updated Sept. 15, 2014, 10:20 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Till Toenshoff. Bugs: MESOS-1793 https://issues.apache.org/jira/browse/MESOS-1793 Repository: mesos-git Description --- Explicitly prohibit the use of namespace aliases. The discussion about using namespace aliases took place in [the other review](https://reviews.apache.org/r/25434/#comment91754). The majority agreed not to introduce them in code. Add a note about allowed C++11 features. This issue was discussed [here](https://mail-archives.apache.org/mod_mbox/mesos-dev/201408.mbox/%3CCA+A2mTvk9RpUY0mFzdQnJTg8sA0nW-51fAwpuPrRjyGp+QV=a...@mail.gmail.com%3E) and has to be officially documented. Diffs - docs/mesos-c++-style-guide.md 4381d24 Diff: https://reviews.apache.org/r/25622/diff/ Testing --- Documentation change, no `make check` needed. Thanks, Alexander Rukletsov
Re: [VOTE] Release Apache Mesos 0.20.1 (rc2)
+1 (binding) make check passes on CentOS 5.5 w/ gcc 4.8.2. On Wed, Sep 17, 2014 at 7:42 PM, Adam Bordelon a...@mesosphere.io wrote: Update: The vote is open until Mon Sep 22 10:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. On Wed, Sep 17, 2014 at 6:27 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following: Minor bug fixes for docker integration, network isolation, etc. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc2 The candidate for Mesos 0.20.1 release is available at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz The tag to be voted on is 0.20.1-rc2: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc2 The MD5 checksum of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.md5 The signature of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.asc The PGP key used to sign the release is here: https://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1034 Please vote on releasing this package as Apache Mesos 0.20.1! The vote is open until and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Mesos 0.20.1 [ ] -1 Do not release this package because ... Thanks, -Adam-
Review Request 25801: Fixed example frameworks to launch tasks based of offered resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25801/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-184 https://issues.apache.org/jira/browse/MESOS-184 Repository: mesos-git Description --- Also cleaned up the example frameworks as part of this: -- logging statements and resource handling is made consistent. -- slaves are started with set resources for consistency Diffs - src/examples/java/TestFramework.java e01b27c6f03b79093e957e85cb3fb32a807ca790 src/examples/low_level_scheduler_libprocess.cpp 9e93bb4df4c2653616caa0351da2edb21c4b9c8e src/examples/low_level_scheduler_pthread.cpp a408571a0255194eed6115cf813da53e310460df src/examples/no_executor_framework.cpp 1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 src/examples/python/test_framework.py 75ca5092d07789aa97e76c2224c86acf83e0d7e3 src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 src/tests/java_framework_test.sh 95a05a636ed74817f02d862a3863cb13285eb0d5 src/tests/low_level_scheduler_libprocess_test.sh eb1736ace5f20ba15c45d58fa263c9bc50876fd7 src/tests/low_level_scheduler_pthread_test.sh 839e8ebb80a4bdb21404c9d7e3c94b2973324284 src/tests/no_executor_framework_test.sh e8d72a3be80cc215576fbf3ecc58d7b25975c0b8 src/tests/python_framework_test.sh a1e36dfd47e7e6a0d2a10382c410780dfe36391e src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a Diff: https://reviews.apache.org/r/25801/diff/ Testing --- make check GTEST_FILTER=*EXAMPLESTEST* Thanks, Vinod Kone
Review Request 25805: Fixed example frameworks to fail fast on an unexpected status udpate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25805/ --- Review request for mesos, Ben Mahler and Jiang Yan Xu. Bugs: MESOS-1813 https://issues.apache.org/jira/browse/MESOS-1813 Repository: mesos-git Description --- Fixed example frameworks to fail fast on an unexpected status udpate. Diffs - src/examples/java/TestExecutor.java 014bc9771afc5118f72a19439c7adf5d05d51168 src/examples/java/TestFramework.java e01b27c6f03b79093e957e85cb3fb32a807ca790 src/examples/low_level_scheduler_libprocess.cpp 9e93bb4df4c2653616caa0351da2edb21c4b9c8e src/examples/low_level_scheduler_pthread.cpp a408571a0255194eed6115cf813da53e310460df src/examples/no_executor_framework.cpp 1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 src/examples/python/test_framework.py 75ca5092d07789aa97e76c2224c86acf83e0d7e3 src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 Diff: https://reviews.apache.org/r/25805/diff/ Testing --- make check GTEST_FILTER=*ExamplesTest* Thanks, Vinod Kone
Re: Review Request 25805: Fixed example frameworks to fail fast on an unexpected status udpate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25805/ --- (Updated Sept. 19, 2014, 12:08 a.m.) Review request for mesos, Ben Mahler and Jiang Yan Xu. Changes --- added depends on. Bugs: MESOS-1813 https://issues.apache.org/jira/browse/MESOS-1813 Repository: mesos-git Description --- Fixed example frameworks to fail fast on an unexpected status udpate. Diffs - src/examples/java/TestExecutor.java 014bc9771afc5118f72a19439c7adf5d05d51168 src/examples/java/TestFramework.java e01b27c6f03b79093e957e85cb3fb32a807ca790 src/examples/low_level_scheduler_libprocess.cpp 9e93bb4df4c2653616caa0351da2edb21c4b9c8e src/examples/low_level_scheduler_pthread.cpp a408571a0255194eed6115cf813da53e310460df src/examples/no_executor_framework.cpp 1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 src/examples/python/test_framework.py 75ca5092d07789aa97e76c2224c86acf83e0d7e3 src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 Diff: https://reviews.apache.org/r/25805/diff/ Testing --- make check GTEST_FILTER=*ExamplesTest* Thanks, Vinod Kone
Re: Review Request 25801: Fixed example frameworks to launch tasks based of offered resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25801/ --- (Updated Sept. 19, 2014, 12:08 a.m.) Review request for mesos, Ben Mahler and Jiang Yan Xu. Changes --- added benm to reviewers. Bugs: MESOS-184 https://issues.apache.org/jira/browse/MESOS-184 Repository: mesos-git Description --- Also cleaned up the example frameworks as part of this: -- logging statements and resource handling is made consistent. -- slaves are started with set resources for consistency Diffs - src/examples/java/TestFramework.java e01b27c6f03b79093e957e85cb3fb32a807ca790 src/examples/low_level_scheduler_libprocess.cpp 9e93bb4df4c2653616caa0351da2edb21c4b9c8e src/examples/low_level_scheduler_pthread.cpp a408571a0255194eed6115cf813da53e310460df src/examples/no_executor_framework.cpp 1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 src/examples/python/test_framework.py 75ca5092d07789aa97e76c2224c86acf83e0d7e3 src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 src/tests/java_framework_test.sh 95a05a636ed74817f02d862a3863cb13285eb0d5 src/tests/low_level_scheduler_libprocess_test.sh eb1736ace5f20ba15c45d58fa263c9bc50876fd7 src/tests/low_level_scheduler_pthread_test.sh 839e8ebb80a4bdb21404c9d7e3c94b2973324284 src/tests/no_executor_framework_test.sh e8d72a3be80cc215576fbf3ecc58d7b25975c0b8 src/tests/python_framework_test.sh a1e36dfd47e7e6a0d2a10382c410780dfe36391e src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a Diff: https://reviews.apache.org/r/25801/diff/ Testing --- make check GTEST_FILTER=*EXAMPLESTEST* Thanks, Vinod Kone
Re: Review Request 25801: Fixed example frameworks to launch tasks based of offered resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25801/ --- (Updated Sept. 19, 2014, 12:09 a.m.) Review request for mesos, Ben Mahler and Jiang Yan Xu. Changes --- fixed bug id. Bugs: MESOS-1814 https://issues.apache.org/jira/browse/MESOS-1814 Repository: mesos-git Description --- Also cleaned up the example frameworks as part of this: -- logging statements and resource handling is made consistent. -- slaves are started with set resources for consistency Diffs - src/examples/java/TestFramework.java e01b27c6f03b79093e957e85cb3fb32a807ca790 src/examples/low_level_scheduler_libprocess.cpp 9e93bb4df4c2653616caa0351da2edb21c4b9c8e src/examples/low_level_scheduler_pthread.cpp a408571a0255194eed6115cf813da53e310460df src/examples/no_executor_framework.cpp 1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 src/examples/python/test_framework.py 75ca5092d07789aa97e76c2224c86acf83e0d7e3 src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 src/tests/java_framework_test.sh 95a05a636ed74817f02d862a3863cb13285eb0d5 src/tests/low_level_scheduler_libprocess_test.sh eb1736ace5f20ba15c45d58fa263c9bc50876fd7 src/tests/low_level_scheduler_pthread_test.sh 839e8ebb80a4bdb21404c9d7e3c94b2973324284 src/tests/no_executor_framework_test.sh e8d72a3be80cc215576fbf3ecc58d7b25975c0b8 src/tests/python_framework_test.sh a1e36dfd47e7e6a0d2a10382c410780dfe36391e src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a Diff: https://reviews.apache.org/r/25801/diff/ Testing --- make check GTEST_FILTER=*EXAMPLESTEST* Thanks, Vinod Kone
Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53902 --- Ship it! src/tests/reconciliation_tests.cpp https://reviews.apache.org/r/25568/#comment93766 s/we do this// ? - Vinod Kone On Sept. 18, 2014, 9:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/ --- (Updated Sept. 18, 2014, 9:30 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-1410 https://issues.apache.org/jira/browse/MESOS-1410 Repository: mesos-git Description --- Added two tests: (1) Ensure that reconciliation works for terminal unacknowledged tasks. (2) Ensure that resources are released for terminal unacknowledged tasks. Diffs - src/master/master.cpp 52a7409f7132f89f4a64e589fa096dd07f527fd9 src/tests/master_tests.cpp ff2b50f517d7c413419e6c7bc823cf5e2cdff1aa src/tests/reconciliation_tests.cpp 1c9e73b0ee99a8a33f663f992b0c9770e83b98c5 Diff: https://reviews.apache.org/r/25568/diff/ Testing --- make check, ran these new tests in repetition Thanks, Ben Mahler
Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25567/#review53904 --- Ship it! Ship It! - Vinod Kone On Sept. 18, 2014, 9:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25567/ --- (Updated Sept. 18, 2014, 9:30 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-1410 https://issues.apache.org/jira/browse/MESOS-1410 Repository: mesos-git Description --- This is the MESOS-1410 which fixes MESOS-1389. The idea here is that the master needs to hold on to those tasks that are terminal, but have yet to be acknowledged by the scheduler. Otherwise, reconciliation requests could lead to TASK_LOST updates **before** a framework receives a terminal TASK_FINISHED/TASK_FAILED/etc update for the task. Now the master needs to: (1) Remove tasks when an acknowledgement arrives. (2) Recover resources when the task becomes terminal. (3) Omit resources for terminal tasks in the http statistics. Diffs - src/master/master.hpp 80d753509be21614325b9492a078350d6cb6641c src/master/master.cpp 52a7409f7132f89f4a64e589fa096dd07f527fd9 Diff: https://reviews.apache.org/r/25567/diff/ Testing --- make check Added new tests in https://reviews.apache.org/r/25568/ Thanks, Ben Mahler
Fwd: New mesos questions for Sep 18 - Stack Exchange
-- Forwarded message -- From: Stack Exchange do-not-re...@stackexchange.com Date: Thu, Sep 18, 2014 at 4:33 PM Subject: New mesos questions for Sep 18 - Stack Exchange To: vi...@twitter.com 1 new question in Mesos Filter filter http://stackexchange.com/filters/139156/mesos-filter on stackexchange.com -- Error building Apache Mesos http://stackoverflow.com/questions/25922613/error-building-apache-mesos I've been trying to build Apache Mesos on Ubuntu 14.04 LTS. I ran the following commands: 1) cd mesos 2) ./bootstrap 3) mkdir build 4) cd build 5) ../configure 6) make When I run make I get the ... Tagged: maven ubuntu-14.04 mesos by Crackej http://stackoverflow.com/users/2869949/crackej on stackoverflow.com -- * Unsubscribe from this filter http://stackexchange.com/email/unsubscribe-filter/368382/285868989?code=oum6mT3keEVxuh9QXTI97q1nlbNMeKZTeAvrDFMkQ24%3d or change your email preferences by visiting your filter subscriptions page on stackexchange.com http://stackexchange.com/users/440840?tab=subscriptions. * -- Questions? Comments? Let us know on our feedback site http://meta.stackexchange.com. If you no longer want to receive mail from Stack Exchange, unsubscribe from all stackexchange.com emails http://stackexchange.com/email/manage/409390/5a59bba2b4e010fc3bb8e1a9238416c32b1ea7a74f58cf0e60526c4ae346a493 . Stack Exchange, Inc. 110 William St, 28th Floor, NY NY 10038 3
Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)
+1 (binding) sudo make check on CentOS 5.5 w/ gcc-4.8.2 On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following: Minor bug fixes for docker integration, network isolation, build, etc. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc3 The candidate for Mesos 0.20.1 release is available at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz The tag to be voted on is 0.20.1-rc3: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc3 The MD5 checksum of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.md5 The signature of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.asc The PGP key used to sign the release is here: https://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1036 Please vote on releasing this package as Apache Mesos 0.20.1! The vote is open until Mon Sep 22 17:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Mesos 0.20.1 [ ] -1 Do not release this package because ... Thanks, Adam and Bhuvan
Re: Review Request 25805: Fixed example frameworks to fail fast on an unexpected status udpate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25805/ --- (Updated Sept. 19, 2014, 1:21 a.m.) Review request for mesos, Ben Mahler and Jiang Yan Xu. Changes --- benm's. NNFR. Bugs: MESOS-1813 https://issues.apache.org/jira/browse/MESOS-1813 Repository: mesos-git Description --- Fixed example frameworks to fail fast on an unexpected status udpate. Diffs (updated) - src/examples/java/TestExecutor.java 014bc9771afc5118f72a19439c7adf5d05d51168 src/examples/java/TestFramework.java e01b27c6f03b79093e957e85cb3fb32a807ca790 src/examples/low_level_scheduler_libprocess.cpp 9e93bb4df4c2653616caa0351da2edb21c4b9c8e src/examples/low_level_scheduler_pthread.cpp a408571a0255194eed6115cf813da53e310460df src/examples/no_executor_framework.cpp 1dd2b99bd3f8817e629b70849d9ea0d3fdb82411 src/examples/python/test_framework.py 75ca5092d07789aa97e76c2224c86acf83e0d7e3 src/examples/test_framework.cpp e6e7137e6d4df40ceae7345500a14e7bee68b2c5 Diff: https://reviews.apache.org/r/25805/diff/ Testing --- make check GTEST_FILTER=*ExamplesTest* Thanks, Vinod Kone
Re: New mesos questions for Sep 18 - Stack Exchange
makes sense. mind commenting on SO? On Thu, Sep 18, 2014 at 6:25 PM, Adam Bordelon a...@mesosphere.io wrote: Probably because they're building Mesos 0.21 and we haven't published anything to the Maven repo for that yet. Should either --disable-java or build a stable release like 0.20. On Thu, Sep 18, 2014 at 5:33 PM, Vinod Kone vinodk...@gmail.com wrote: -- Forwarded message -- From: Stack Exchange do-not-re...@stackexchange.com Date: Thu, Sep 18, 2014 at 4:33 PM Subject: New mesos questions for Sep 18 - Stack Exchange To: vi...@twitter.com 1 new question in Mesos Filter filter http://stackexchange.com/filters/139156/mesos-filter on stackexchange.com -- Error building Apache Mesos http://stackoverflow.com/questions/25922613/error-building-apache-mesos I've been trying to build Apache Mesos on Ubuntu 14.04 LTS. I ran the following commands: 1) cd mesos 2) ./bootstrap 3) mkdir build 4) cd build 5) ../configure 6) make When I run make I get the ... Tagged: maven ubuntu-14.04 mesos by Crackej http://stackoverflow.com/users/2869949/crackej on stackoverflow.com -- * Unsubscribe from this filter http://stackexchange.com/email/unsubscribe-filter/368382/285868989?code=oum6mT3keEVxuh9QXTI97q1nlbNMeKZTeAvrDFMkQ24%3d or change your email preferences by visiting your filter subscriptions page on stackexchange.com http://stackexchange.com/users/440840?tab=subscriptions. * -- Questions? Comments? Let us know on our feedback site http://meta.stackexchange.com. If you no longer want to receive mail from Stack Exchange, unsubscribe from all stackexchange.com emails http://stackexchange.com/email/manage/409390/5a59bba2b4e010fc3bb8e1a9238416c32b1ea7a74f58cf0e60526c4ae346a493 . Stack Exchange, Inc. 110 William St, 28th Floor, NY NY 10038 3
Re: Review Request 25810: Fixed a segfault regression in the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25810/#review53923 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2014, 2:33 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25810/ --- (Updated Sept. 19, 2014, 2:33 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1818 https://issues.apache.org/jira/browse/MESOS-1818 Repository: mesos-git Description --- There was a utils::copy that was missed in the recent master cleanups. Diffs - src/master/master.cpp e64f05f3d928843de12ff3dcb589348e0172f4f2 Diff: https://reviews.apache.org/r/25810/diff/ Testing --- Ran the test in repetition. Thanks, Ben Mahler
Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: OK. I went through parts of this review but I have a bigger suggestion in mind, before I get too much into the weeds. I think it's worthwhile for you to write up a design doc similar to the framework info doc w.r.t. updating SlaveInfo. This will force you to think about the repercussions of changing each of the SlaveInfo fields on the Mesos stack (master/allocator/slave/tasks/executors). Are you game? Cody Maloney wrote: I'll work on a design doc later today. Will let you know when I have it. are you still on track for the design doc? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review53100 --- On Sept. 13, 2014, 12:33 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/ --- (Updated Sept. 13, 2014, 12:33 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod Kone. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Allows attributes and resources to be set to a superset of what they were previously on a slave restart. Incorporates all comments from: https://issues.apache.org/jira/browse/MESOS-1739 and the former review request: https://reviews.apache.org/r/25111/ Diffs - src/Makefile.am 9b973e5 src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/common/slaveinfo_utils.hpp PRE-CREATION src/common/slaveinfo_utils.cpp PRE-CREATION src/master/master.hpp b492600 src/master/master.cpp d5db24e src/slave/slave.cpp 1b3dc73 src/tests/attributes_tests.cpp 240a8ca src/tests/slave_tests.cpp 69be28f Diff: https://reviews.apache.org/r/25525/diff/ Testing --- make check on localhost Thanks, Cody Maloney
Re: Review Request 25218: Updated a comment and some syntax formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25218/#review53976 --- Ship it! Ben, I'll commit this for you. - Vinod Kone On Aug. 31, 2014, 4:51 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25218/ --- (Updated Aug. 31, 2014, 4:51 p.m.) Review request for mesos, Dominic Hamon and Vinod Kone. Repository: mesos-git Description --- The GCC 4.7 comment was not clear to me so I updated it, please let me know if I still don't fully understand. Moreover, there were some syntax formatting that had been missed so I updated that. Diffs - 3rdparty/libprocess/configure.ac 2d13f2ac4184bf07285814ca5809406985da8027 configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089 Diff: https://reviews.apache.org/r/25218/diff/ Testing --- Thanks, Benjamin Hindman
Re: Review Request 25844: Ignore terminal task resources in the Master's Framework struct.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/#review54020 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/ --- (Updated Sept. 19, 2014, 7:57 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- During my refactor to hold on to terminal tasks in the master, I forgot to update the Framework's resource accounting to ignore these terminal tasks. Diffs - src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d Diff: https://reviews.apache.org/r/25844/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54024 --- Ship it! src/master/master.cpp https://reviews.apache.org/r/25843/#comment93904 kill the if. - Vinod Kone On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/ --- (Updated Sept. 19, 2014, 7:57 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1821 https://issues.apache.org/jira/browse/MESOS-1821 Repository: mesos-git Description --- `_reregisterFramework` was not adding empty executors to a newly re-registerd framework. This led to the CHECK failure in MESOS-1821. Diffs - src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25843/diff/ Testing --- Added a test that catches the CHECK failure without the fix. make check Thanks, Ben Mahler
Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs - src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 25867: Updated ping message to embed the slave registered status.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1668 https://issues.apache.org/jira/browse/MESOS-1668 Repository: mesos-git Description --- Embeded slave registration status in ping message to solicit slave re-registration during one way master -- slave partition. Diffs - src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/messages/messages.proto 7cb3ce651997c04ef1ef95539098ed2a99270b11 src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos, Adam B and Ben Mahler. Changes --- rebased. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs (updated) - src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/tests/fault_tolerance_tests.cpp 154386044d0247b39d84719d7ff14250682a0695 Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25867: Updated ping message to embed the slave registered status.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos and Ben Mahler. Changes --- rebased. Bugs: MESOS-1668 https://issues.apache.org/jira/browse/MESOS-1668 Repository: mesos-git Description --- Embeded slave registration status in ping message to solicit slave re-registration during one way master -- slave partition. Diffs (updated) - src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/messages/messages.proto 7cb3ce651997c04ef1ef95539098ed2a99270b11 src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.
On Sept. 21, 2014, 9:20 a.m., Adam B wrote: src/master/master.hpp, lines 947-950 https://reviews.apache.org/r/25866/diff/2/?file=699118#file699118line947 Comment here should be for the Slave. 'active' is set to false if resources from this slave should not be offered. This happens when the slave is disconnected or the master receives a DeactivateSlaveMessage. Do we have a DeactivateSlaveMessage yet? Or does that come with the HTTP endpoint? oops. good catch. fixed. we don't have a DeactivateSlaveMessage yet. not sure when it's going to be introduced. On Sept. 21, 2014, 9:20 a.m., Adam B wrote: src/master/master.cpp, lines 3061-3062 https://reviews.apache.org/r/25866/diff/2/?file=699119#file699119line3061 Why are these CHECKs? How should the master respond if it does receive such a message from a deactivated slave? Should we perhaps be sending a Shutdown[Slave]Message, or some sort of DeactivateSlaveMessage? This is a CHECK because it shouldn't happen with the current design (slave is deactivated only when disconnected). When these semantics change (e.g., introduction of DeactivateSlaveMessage) we'll have to change the CHECK. On Sept. 21, 2014, 9:20 a.m., Adam B wrote: src/master/master.cpp, line 1552 https://reviews.apache.org/r/25866/diff/2/?file=699119#file699119line1552 Can you explain why this TODO is no longer needed? allocator-frameworkActivated calls allocator-allocate, which will sort roles/frameworks and make initial offers based on a stale notion of the newly reactivated framework's outstanding offers. If the resources were recovered first, the allocator would make fairer offers when the framework is first reactivated. It was a bad TODO (on my part) because it doesn't tell me why I didn't fix it in the first place instead of adding a TODO. Maybe I added the TODO as part of some other cleanup and didn't want to change too much in that review. Anyway, now I addressed the TODO now. On Sept. 21, 2014, 9:20 a.m., Adam B wrote: src/master/master.cpp, line 3988 https://reviews.apache.org/r/25866/diff/2/?file=699119#file699119line3988 Ditto. Isn't this TODO still relevant? fixed. see above. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54094 --- On Sept. 20, 2014, 6:46 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs - src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/tests/fault_tolerance_tests.cpp 154386044d0247b39d84719d7ff14250682a0695 Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25866: Updated semantics of disconnected/deactivated slaves/frameworks in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 22, 2014, 11:50 p.m.) Review request for mesos, Adam B and Ben Mahler. Changes --- dominic's and adam's comments. PTAL. Summary (updated) - Updated semantics of disconnected/deactivated slaves/frameworks in master. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs (updated) - src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/tests/fault_tolerance_tests.cpp 154386044d0247b39d84719d7ff14250682a0695 src/tests/master_tests.cpp 8e4ec1d85c4530b5421387de55036f7d40ee3180 Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.
On Sept. 20, 2014, 2:26 p.m., Dominic Hamon wrote: src/master/master.cpp, line 4649 https://reviews.apache.org/r/25866/diff/1/?file=698461#file698461line4649 consider adding gauges for connected/disconnected slaves done. added for frameworks too. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54078 --- On Sept. 20, 2014, 6:46 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 20, 2014, 6:46 p.m.) Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs - src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/tests/fault_tolerance_tests.cpp 154386044d0247b39d84719d7ff14250682a0695 Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25867: Updated ping message to embed the slave registered status.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- (Updated Sept. 22, 2014, 11:51 p.m.) Review request for mesos and Ben Mahler. Changes --- rebased. Bugs: MESOS-1668 https://issues.apache.org/jira/browse/MESOS-1668 Repository: mesos-git Description --- Embeded slave registration status in ping message to solicit slave re-registration during one way master -- slave partition. Diffs (updated) - src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/messages/messages.proto 7cb3ce651997c04ef1ef95539098ed2a99270b11 src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone
Re: Mesos Modules Design
Ok. I finally had a chance to read the design doc, go through the comments on this thread and glance at the review. Here are my comments. I like the concept of dynamic loading of libraries when it comes to making the lives of end users/operators easy, esp when they want to mix and match the modules. I agree with Dominic though that we should make sure to minimize the burden/overhead of core developers when it comes to dealing with modules. FWIW, the implementation that I've seen seems easy enough to deal with and doesn't look like it adds much of a performance overhead. That said, the versioning part seems a bit complicated, as BenH alluded to. Can we come up with something that's simple as the first cut but still extensible? Also, it would be great if interface breakage could be automatically deduced at load time. But I guess we still need a module version to deal with protocol changes without interface changes. To ensure the devs update the versions in module manager, I suggest adding a comment on top of the current components (Allocator, Isolator etc) mentioning that there is a corresponding module that needs to be updated. Better yet, maybe we could use a naming convention (e.g., s/Allocator/AllocatorModule/) for easy visual cue. More importantly, I would like to understand how we are going to ensure the quality of modules being written. In other words how do we, as a community, ensure that a badly written module doesn't leave a bad taste in users adopting Mesos. Should we come up with a test suite (functional and performance) that runs on CI that module writers are required to test against? What is the contract for support when something in modules break? Should the users/operators ask on #mesos and dev lists or module writer's lists? Would the users even know where the problem lies? Would Mesos devs always know? I think this is where most of the burden/overhead lies. Of course, this is the same problem with frameworks, but I think this is much more relevant for modules because they (could) fundamentally change the behavior of Mesos. Even more fundamentally, how are we going to ensure that Mesos core gets better features vs having the cool features developed as (possibly paid) modules? For example, should Kerberos auth and SSL transport be modules or should they be integrated into the core? As an open source project, how do we ensure that the community resources are properly utilized in a fair and neutral manner to help Mesos core grow? Are we going to have guidelines/opinions on what should/could be modularized or is everything fair game? It would be great to understand how other successful open source projects toe this line. Has anyone done any research regarding this? On Tue, Sep 23, 2014 at 9:27 AM, George Sudarkoff geo...@sudarkoff.com wrote: Hello everybody! I'm new here. But why not jump in in the middle of the conversation and voice an opinion anyway, right? :) On 23 Sep 2014, at 09:17, Dominic Hamon dha...@twopensource.com wrote: On Tue, Sep 23, 2014 at 5:57 AM, Tim St Clair tstcl...@redhat.com wrote: - Original Message - From: Benjamin Hindman b...@eecs.berkeley.edu To: dev dev@mesos.apache.org Sent: Tuesday, September 23, 2014 3:14:31 AM Subject: Re: Mesos Modules Design - create abstract classes to define interfaces to objects that should be modular We're all in agreement here! - build modules as static libraries that can be assembled at link time to create custom Mesos builds Okay, but unless I'm missing something here we'll still need a level of indirection to wire everything together. What would that look like? Also, why ask an operator to go through the extra step of relinking Mesos? Asking the operator to relink means they'll need a Mesos build environment, while most folks will likely just have Mesos installed via an RPM (or similar). I'm not convinced that getting a link error will be a better user experience then getting a runtime error that cleanly prints out something along the lines of Version mismatch: the XXYYZZ module is not compatible with this version of Mesos. To ask service operators to re-link and possibly re-deploy mesos is a non-starter imho. One of the goals of enabling plugins around key interfaces is to avoid this type of operation. What, concretely, does a service operator do if they have a bunch of modules that give runtime version errors? What are there options to get a running version? Runtime doesn't necessarily mean four days after you start it. What I'd expect from a piece of software with plugins is to load the plugins and verify the versions/compatibility at launch time. If I drop a new plugin in and restart a client, I know what to do when the client complains about the incompatible versions. -- George -- Cheers, Timothy St. Clair Red Hat Inc. -- Dominic Hamon | @mrdo | Twitter *There are no bad
Re: Review Request 25549: Basic filesystem isolator for Linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review54310 --- src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94405 Should namespaces/pid check be added as part of the pid namespace patch? Did you add it here because the pid patch is independent from this and either could land first? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94406 Can you add some comments on why we need to mount /proc and /sys? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94407 Hmm. How is this possible given you return None() on line #75? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94408 s/container/Container/ src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94409 s/host/Host/ src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94410 s/host_ ath/host_path/ src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94411 s/container_path/container path/ src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94412 include error? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94413 include error? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94414 Where is set -x being added to commands? Should this if block be killed altogether? src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94415 s/mounts done/mounts is/ src/slave/slave.cpp https://reviews.apache.org/r/25549/#comment94418 Is there any particular reason the container was added to ExecutorInfo instead of TaskInfo? - Vinod Kone On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 22, 2014, 6:45 p.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1586 https://issues.apache.org/jira/browse/MESOS-1586 Repository: mesos-git Description --- Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. This review replaces https://reviews.apache.org/r/24178/ because of some file renaming. I addressed all comments from earlier reviews. Diffs - include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/linux_launcher.cpp d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95 src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 Diff: https://reviews.apache.org/r/25549/diff/ Testing --- make check # added a test Thanks, Ian Downes
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2123
ben is this expected?
On Wed, Sep 24, 2014 at 1:34 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2123/changes
Changes:
[yujie.jay] Added support for getting socket diagnosis information.
--
[...truncated 66610 lines...]
I0924 20:33:00.593726 832 leveldb.cpp:306] Persisting metadata (8 bytes)
to leveldb took 327703ns
I0924 20:33:00.593744 832 replica.cpp:342] Persisted promised to 1
I0924 20:33:00.593941 832 coordinator.cpp:230] Coordinator attemping to
fill missing position
I0924 20:33:00.594296 832 replica.cpp:375] Replica received explicit
promise request for position 0 with proposal 2
I0924 20:33:00.594422 832 leveldb.cpp:343] Persisting action (8 bytes)
to leveldb took 107194ns
I0924 20:33:00.594439 832 replica.cpp:676] Persisted action at 0
I0924 20:33:00.594730 832 replica.cpp:508] Replica received write
request for position 0
I0924 20:33:00.594758 832 leveldb.cpp:438] Reading position from leveldb
took 13083ns
I0924 20:33:00.594856 832 leveldb.cpp:343] Persisting action (14 bytes)
to leveldb took 77629ns
I0924 20:33:00.594872 832 replica.cpp:676] Persisted action at 0
I0924 20:33:00.595029 832 replica.cpp:655] Replica received learned
notice for position 0
I0924 20:33:00.595180 832 leveldb.cpp:343] Persisting action (16 bytes)
to leveldb took 134269ns
I0924 20:33:00.595196 832 replica.cpp:676] Persisted action at 0
I0924 20:33:00.595204 832 replica.cpp:661] Replica learned NOP action at
position 0
I0924 20:33:00.595366 832 log.cpp:672] Writer started with ending
position 0
I0924 20:33:00.595626 832 leveldb.cpp:438] Reading position from leveldb
took 9422ns
I0924 20:33:00.598917 830 registrar.cpp:346] Successfully fetched the
registry (0B)
I0924 20:33:00.598953 830 registrar.cpp:422] Attempting to update the
'registry'
I0924 20:33:00.599956 833 network.hpp:424] ZooKeeper group memberships
changed
I0924 20:33:00.600060 833 group.cpp:659] Trying to get
'/znode/log_replicas/00' in ZooKeeper
I0924 20:33:00.600378 834 group.cpp:717] Found non-sequence node
'log_replicas' at '/znode' in ZooKeeper
I0924 20:33:00.600553 845 log.cpp:680] Attempting to append 137 bytes to
the log
I0924 20:33:00.600610 830 coordinator.cpp:340] Coordinator attempting to
write APPEND action at position 1
I0924 20:33:00.600862 841 network.hpp:466] ZooKeeper group PIDs: {
log-replica(423)@67.195.81.190:60680 }
I0924 20:33:00.600909 831 replica.cpp:508] Replica received write
request for position 1
I0924 20:33:00.601269 831 leveldb.cpp:343] Persisting action (156 bytes)
to leveldb took 337675ns
I0924 20:33:00.601289 831 replica.cpp:676] Persisted action at 1
I0924 20:33:00.601471 831 replica.cpp:655] Replica received learned
notice for position 1
I0924 20:33:00.601583 831 leveldb.cpp:343] Persisting action (158 bytes)
to leveldb took 92858ns
I0924 20:33:00.601599 831 replica.cpp:676] Persisted action at 1
I0924 20:33:00.601610 831 replica.cpp:661] Replica learned APPEND action
at position 1
I0924 20:33:00.601862 842 registrar.cpp:479] Successfully updated
'registry'
I0924 20:33:00.601912 842 registrar.cpp:372] Successfully recovered
registrar
I0924 20:33:00.601965 841 log.cpp:699] Attempting to truncate the log to
1
I0924 20:33:00.602013 841 coordinator.cpp:340] Coordinator attempting to
write TRUNCATE action at position 2
I0924 20:33:00.602012 831 master.cpp:1070] Recovered 0 slaves from the
Registry (99B) ; allowing 10mins for slaves to re-register
I0924 20:33:00.602293 836 replica.cpp:508] Replica received write
request for position 2
I0924 20:33:00.602401 836 leveldb.cpp:343] Persisting action (16 bytes)
to leveldb took 88110ns
I0924 20:33:00.602419 836 replica.cpp:676] Persisted action at 2
I0924 20:33:00.602726 843 replica.cpp:655] Replica received learned
notice for position 2
I0924 20:33:00.602864 843 leveldb.cpp:343] Persisting action (18 bytes)
to leveldb took 116799ns
I0924 20:33:00.602893 843 leveldb.cpp:401] Deleting ~1 keys from leveldb
took 13705ns
I0924 20:33:00.602907 843 replica.cpp:676] Persisted action at 2
I0924 20:33:00.602918 843 replica.cpp:661] Replica learned TRUNCATE
action at position 2
2014-09-24 20:33:00,615:816(0x2ba5e6355700):ZOO_INFO@log_env@712: Client
environment:zookeeper.version=zookeeper C client 3.4.5
2014-09-24 20:33:00,615:816(0x2ba5e6355700):ZOO_INFO@log_env@716: Client
environment:host.name=pietas.apache.org
2014-09-24 20:33:00,615:816(0x2ba5e6355700):ZOO_INFO@log_env@723: Client
environment:os.name=Linux
2014-09-24 20:33:00,615:816(0x2ba5e6355700):ZOO_INFO@log_env@724: Client
environment:os.arch=3.13.0-24-generic
2014-09-24 20:33:00,615:816(0x2ba5e6355700):ZOO_INFO@log_env@725: Client
environment:os.version=#47-Ubuntu SMP Fri May 2 23:30:00 UTC 2014
2014-09-24
Re: Review Request 25866: Updated semantics of disconnected/deactivated slaves/frameworks in master.
On Sept. 24, 2014, 11:39 p.m., Ben Mahler wrote: src/master/master.cpp, lines 743-744 https://reviews.apache.org/r/25866/diff/3/?file=700961#file700961line743 Why do we check slave-connected before calling disconnect below, but we don't check framework-connected here? Probably warrants a comment. this was done as part of MESOS-675 (by you :)). Added a comment. On Sept. 24, 2014, 11:39 p.m., Ben Mahler wrote: src/master/master.cpp, lines 1653-1666 https://reviews.apache.org/r/25866/diff/3/?file=700961#file700961line1653 Should this be below deactivateFramework, to keep disconnect and deactivate adjacent (like in the header file)? done. On Sept. 24, 2014, 11:39 p.m., Ben Mahler wrote: src/master/master.cpp, line 1655 https://reviews.apache.org/r/25866/diff/3/?file=700961#file700961line1655 Re: question above Should this be idempotent? i.e. do nothing when already disconnected. Or do you want the caller to never call this when already disconnected? yup, the latter, esp when calling methods that take pointers. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54384 --- On Sept. 22, 2014, 11:50 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 22, 2014, 11:50 p.m.) Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs - src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/tests/fault_tolerance_tests.cpp 154386044d0247b39d84719d7ff14250682a0695 src/tests/master_tests.cpp 8e4ec1d85c4530b5421387de55036f7d40ee3180 Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25867: Updated ping message to embed the slave registered status.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- (Updated Sept. 25, 2014, 8:41 p.m.) Review request for mesos and Ben Mahler. Changes --- BenM's. NNFR. Bugs: MESOS-1668 https://issues.apache.org/jira/browse/MESOS-1668 Repository: mesos-git Description --- Embeded slave registration status in ping message to solicit slave re-registration during one way master -- slave partition. Diffs (updated) - src/Makefile.am b821a3bd6c3bcc3cca9bd7f72f1d7b9fb9c4ff18 src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 src/messages/messages.proto 7cb3ce651997c04ef1ef95539098ed2a99270b11 src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 src/slave/slave.cpp 9a6646f0249fd43ae5d13bd9ee3b5da08412 src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 24177: Pass executor directory to Isolator::prepare().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24177/#review54618 --- Ship it! src/tests/isolator_tests.cpp https://reviews.apache.org/r/24177/#comment94817 probably not part of this review, but we avoid this pattern because it could lead to leaked temp directories if the test fails. since you are already inside a sandbox (because you inherit from TemporaryDirectoryTest), you should use relative paths to create temporary directories. s/os::mkdtemp()/os::mkdtemp(./XX)/ mind adding a TODO? - Vinod Kone On Sept. 23, 2014, 11:42 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24177/ --- (Updated Sept. 23, 2014, 11:42 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- Pass executor directory to Isolator::prepare(). Will be used for FilesystemIsolator. Diffs - src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/slave/containerizer/isolator.cpp 5e61bf2e3cf14be53d41aa657b4a78ab2dd6ecb0 src/slave/containerizer/isolators/cgroups/cpushare.hpp 2187c296ea9b1a7de9ae3f09fdf1983f98a3d01b src/slave/containerizer/isolators/cgroups/cpushare.cpp 7164ecc0f068d4a72248521e3cbd345958efa880 src/slave/containerizer/isolators/cgroups/mem.hpp b1b4f5a2bd9e01b03fdfa74f187f7dee8119b812 src/slave/containerizer/isolators/cgroups/mem.cpp b3d4a5daa90a842e501bc6be2f0cf20fe22906ac src/slave/containerizer/isolators/cgroups/perf_event.hpp f7283d830cd6af7b3c9006c098de0a6ad48b7c82 src/slave/containerizer/isolators/cgroups/perf_event.cpp 4ced508e600e13f3e5ae9d12ea199de743def652 src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8 src/tests/isolator.hpp 89df4c4959c680354b002fa12e3a270a358087af src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 Diff: https://reviews.apache.org/r/24177/diff/ Testing --- make check Thanks, Ian Downes
Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review54619 --- lgtm, modulo comments. i'll let jie give the final shipit. src/slave/containerizer/mesos/containerizer.cpp https://reviews.apache.org/r/25861/#comment94828 s/isolators/isolator/ - Vinod Kone On Sept. 22, 2014, 6:45 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/ --- (Updated Sept. 22, 2014, 6:45 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git Description --- Change from doing in parallel and collect()ing to serial according to the vector of isolators (reversed order for cleanup). Diffs - src/slave/containerizer/mesos/containerizer.hpp bf246ca649ca4a461cebf1aee6908a2d58eec362 src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c Diff: https://reviews.apache.org/r/25861/diff/ Testing --- make check Thanks, Ian Downes
Re: Review Request 25549: Basic filesystem isolator for Linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review54627 --- src/slave/containerizer/isolators/filesystem/shared.cpp https://reviews.apache.org/r/25549/#comment94861 why are the remount commands different for proc and sys? also, why do we need to remount /sys and /proc in the fs isolator? it's not clear to me from the reflect namespace changes for the container processes. maybe expand on the comment? src/slave/containerizer/isolators/network/port_mapping.cpp https://reviews.apache.org/r/25549/#comment94864 Hmm. Instead of returning an error here, how about just adding filesystem/shared isolator to the list of isolators in mesos containerizer, if either of filesystem/shared or network/portmapping is specified in flags? - Vinod Kone On Sept. 24, 2014, 6:09 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 24, 2014, 6:09 p.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1586 https://issues.apache.org/jira/browse/MESOS-1586 Repository: mesos-git Description --- Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. This review replaces https://reviews.apache.org/r/24178/ because of some file renaming. I addressed all comments from earlier reviews. Diffs - include/mesos/mesos.proto be45494b2c2f5c1295409889b70004462c6eba49 src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00ff81dc550c21387f920666f81705db4f0 src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/slave/flags.hpp 32e51d214b0dbbb2f106236c6fa42ddec9774585 src/slave/slave.cpp 9a6646f0249fd43ae5d13bd9ee3b5da08412 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 Diff: https://reviews.apache.org/r/25549/diff/ Testing --- make check # added a test Thanks, Ian Downes
Re: Review Request 25863: Rename stout/os/setns.hpp to namespaces.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25863/#review54630 --- Ship it! Ship It! - Vinod Kone On Sept. 23, 2014, 11:39 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25863/ --- (Updated Sept. 23, 2014, 11:39 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git Description --- Also, added os::getns(pid, ns) to get the namespace inode for comparisons between pids' namespaces. Diffs - 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e 3rdparty/libprocess/3rdparty/stout/include/Makefile.am d4a8ad4e776bcfe1f008e561b5a92340f4d84bd9 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 5278996f201a4a3d69282c1bd7b0d230d0f6cd39 3rdparty/libprocess/3rdparty/stout/tests/os/namespaces_tests.cpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ad8e37aa2f5a29f8b421dde6b7cd5dfe241eabb5 Diff: https://reviews.apache.org/r/25863/diff/ Testing --- Added test to check a clone(NEW_PIDNS) results in a new pid namespace. Thanks, Ian Downes
Re: Review Request 25965: Update libprocess Makefile for setns namechange.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25965/#review54632 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2014, 6:13 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25965/ --- (Updated Sept. 24, 2014, 6:13 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- Update libprocess Makefile for setns namechange. Diffs - src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00ff81dc550c21387f920666f81705db4f0 Diff: https://reviews.apache.org/r/25965/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 25964: Update libprocess Makefile for setns namechange.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25964/#review54631 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2014, 6:14 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25964/ --- (Updated Sept. 24, 2014, 6:14 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- Update libprocess Makefile for setns namechange. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8df0259a318a9171a9c045a223800e64f47 Diff: https://reviews.apache.org/r/25964/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 25865: Pid namespace isolator for the MesosContainerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25865/#review54637 --- src/slave/containerizer/isolators/namespaces/pid.hpp https://reviews.apache.org/r/25865/#comment94869 s/NamespacesPid/PidNamespace/ ? src/slave/containerizer/isolators/namespaces/pid.hpp https://reviews.apache.org/r/25865/#comment94870 kill new line. src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94871 Comment? src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94873 As mentioned in the previous review, instead of requiring users/operators to know this dependency, we should just automatically use fileystem/shared isoator when using pid or network isolation. src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94877 Who is calling this method? src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94882 // Cleanup orphans. ? src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94880 if you use hashset, you can just do !containerers.contain(). src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94883 Why not just call cleanup() here? src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94881 Can you also say why in the comment? Presumably because you dont want containers to see other containers runninng in the system? src/slave/containerizer/isolators/namespaces/pid.cpp https://reviews.apache.org/r/25865/#comment94884 Add a comment that you are doing this for the ability to cleanup orphans during recovery? Also, what is the need for manual cleanup or orphans? src/slave/containerizer/linux_launcher.cpp https://reviews.apache.org/r/25865/#comment94867 why is this pulled out? src/tests/isolator_tests.cpp https://reviews.apache.org/r/25865/#comment94885 s/NamespacesPidIsolatorTest/PidNamespaceIsolatorTest/ src/tests/isolator_tests.cpp https://reviews.apache.org/r/25865/#comment94886 you are writing to files, not stdout and stderr right? - Vinod Kone On Sept. 23, 2014, 11:39 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25865/ --- (Updated Sept. 23, 2014, 11:39 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git Description --- Add namespaces/pid to --isolation slave flag. Places executor into a pid namespace so it and all descendants will be contained in the namespace. Requires the filesystem/shared isolator so /proc and /sys are remounted to reflect the different namespace. Diffs - src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/isolators/namespaces/pid.hpp PRE-CREATION src/slave/containerizer/isolators/namespaces/pid.cpp PRE-CREATION src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 Diff: https://reviews.apache.org/r/25865/diff/ Testing --- Added test that command in pid namespaced container is in a different namespace and that the command is 'init' (verifies remount of /proc). Thanks, Ian Downes
Re: Review Request 25865: Pid namespace isolator for the MesosContainerizer.
On Sept. 26, 2014, 1:17 a.m., Vinod Kone wrote: Can you attach the bug. Also, need documentation. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25865/#review54637 --- On Sept. 23, 2014, 11:39 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25865/ --- (Updated Sept. 23, 2014, 11:39 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git Description --- Add namespaces/pid to --isolation slave flag. Places executor into a pid namespace so it and all descendants will be contained in the namespace. Requires the filesystem/shared isolator so /proc and /sys are remounted to reflect the different namespace. Diffs - src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/isolators/namespaces/pid.hpp PRE-CREATION src/slave/containerizer/isolators/namespaces/pid.cpp PRE-CREATION src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 Diff: https://reviews.apache.org/r/25865/diff/ Testing --- Added test that command in pid namespaced container is in a different namespace and that the command is 'init' (verifies remount of /proc). Thanks, Ian Downes
Re: Review Request 25966: Use pid namespace in LinuxLauncher::destroy().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25966/#review54641 --- src/slave/containerizer/linux_launcher.cpp https://reviews.apache.org/r/25966/#comment94890 do we need to call destroy? how about improving cgroups::remove() to do recursive removal and just calling that here? src/slave/containerizer/linux_launcher.cpp https://reviews.apache.org/r/25966/#comment94887 Tests? - Vinod Kone On Sept. 23, 2014, 11:41 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25966/ --- (Updated Sept. 23, 2014, 11:41 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git Description --- Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer. Diffs - src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b Diff: https://reviews.apache.org/r/25966/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54643 --- Ship it! lgtm modulo comments. - Vinod Kone On Sept. 23, 2014, 11:39 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/ --- (Updated Sept. 23, 2014, 11:39 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git Description --- Polls cgroups.procs until no processes in the cgroup. Poll interval and timeout can be specified. Diffs - src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf src/linux/cgroups.cpp 62df4b7645c6ab061a47634058d79ca849caa6b9 Diff: https://reviews.apache.org/r/25864/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 25549: Basic filesystem isolator for Linux.
On Sept. 25, 2014, 11:56 p.m., Vinod Kone wrote: Mind adding documentation for this? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review54627 --- On Sept. 24, 2014, 6:09 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/ --- (Updated Sept. 24, 2014, 6:09 p.m.) Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-1586 https://issues.apache.org/jira/browse/MESOS-1586 Repository: mesos-git Description --- Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. This review replaces https://reviews.apache.org/r/24178/ because of some file renaming. I addressed all comments from earlier reviews. Diffs - include/mesos/mesos.proto be45494b2c2f5c1295409889b70004462c6eba49 src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00ff81dc550c21387f920666f81705db4f0 src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c src/slave/flags.hpp 32e51d214b0dbbb2f106236c6fa42ddec9774585 src/slave/slave.cpp 9a6646f0249fd43ae5d13bd9ee3b5da08412 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 Diff: https://reviews.apache.org/r/25549/diff/ Testing --- make check # added a test Thanks, Ian Downes
Re: Review Request 25551: Add standard versioning to shared libmesos.so
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25551/#review54699 --- src/Makefile.am https://reviews.apache.org/r/25551/#comment94959 why not just libmesos_la_LDFLAGS = -version-info $(PACKAGE-VERSION) More importantly how do the resulting dylibs (symlink and regular) look like compared to the previous style? Is it backwards compatible or needs re-linking? - Vinod Kone On Sept. 26, 2014, 3:31 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25551/ --- (Updated Sept. 26, 2014, 3:31 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1675 https://issues.apache.org/jira/browse/MESOS-1675 Repository: mesos-git Description --- Add standard -version-info to shared libmesos, it will need to be updated on major modifications. Diffs - configure.ac 86d448c src/Makefile.am 27c42df Diff: https://reviews.apache.org/r/25551/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Regarding adding as a contributor in apache mesos group
Added you as a contributor. Good luck! On Sun, Sep 28, 2014 at 2:24 AM, namrata singh namrata.ii...@gmail.com wrote: respected sir , I would like to introduce myself as Namrata Singh chauhan, a student of IIIT Allahabad, India and a want-to-be a OPW contributor for mesos group , sir I would like to work under your project regarding Getting started page. To start with my application process , I would like you to add me to contributors list so that I can make some small contributions . I shall be highly oblige to you. Thanks and Regards Namrata Singh Chauhan
Re: Review Request 26141: Increased the store timeout for the Registrar tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26141/#review54843 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2014, 6:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26141/ --- (Updated Sept. 29, 2014, 6:30 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- Increased the store timeout for the Registrar tests. Diffs - src/tests/registrar_tests.cpp cd83bf09313db1ee1825c30bb5e07e386622e668 Diff: https://reviews.apache.org/r/26141/diff/ Testing --- make check Thanks, Ben Mahler
Fwd: Regarding OPW mesos project
Hi prospective OPW interns, I've been contacted by quite a few of you regarding Mesos Getting Started Documentation OPW project. So, wanted to send out a list of starter tickets that you can work on. https://issues.apache.org/jira/browse/MESOS-1647 https://issues.apache.org/jira/browse/MESOS-1552 https://issues.apache.org/jira/browse/MESOS-1506 https://issues.apache.org/jira/browse/MESOS-1521 If you would like to be added as a contributor to the project, please respond to this email with your JIRA username and I'll add you. Hope this helps, Vinod
Mesos OPW project
Hi prospective OPW interns, I've been contacted by quite a few of you regarding Mesos Getting Started Documentation OPW project. So, wanted to send out a list of starter tickets that you can work on. https://issues.apache.org/jira/browse/MESOS-1647 https://issues.apache.org/jira/browse/MESOS-1552 https://issues.apache.org/jira/browse/MESOS-1506 https://issues.apache.org/jira/browse/MESOS-1521 If you would like to be added as a contributor to the project, please respond to this email with your JIRA username and I'll add you. Hope this helps, Vinod
Review Request 26144: Fixed AllocatorTest.FrameworkExited test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26144/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1782 https://issues.apache.org/jira/browse/MESOS-1782 Repository: mesos-git Description --- The test had 2 expectations on resourcesAllocated() at the end, but didn't wait for the first one to be satisifed before setting up the more generic second one. As a result, the 2nd one can end up capturing all the resourcesAllocated() dispatches starving the 1st one. Diffs - src/tests/allocator_tests.cpp 9cd5da36daf144ba1c759003bc1376ce74833245 Diff: https://reviews.apache.org/r/26144/diff/ Testing --- Ran the test 500 times in repetition. Thanks, Vinod Kone
Re: Review Request 26149: Remove depreacted webui_hostname and webui_port fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26149/#review54882 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2014, 9:01 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26149/ --- (Updated Sept. 29, 2014, 9:01 p.m.) Review request for mesos, Adam B and Vinod Kone. Repository: mesos-git Description --- These have been deprecated since November 2013, at least Mesos 0.16. Should be safe to remove at this point (People will have to upgrade pre-0.16 to something between 0.16 and 0.20.1 inclusive, before upgrading past 0.20.1). commit 03b94076caddceda4c0a6a03aa44ebe4d64f1acc Author: Benjamin Hindman benjamin.hind...@gmail.com Date: Mon Nov 4 11:51:05 2013 -1000 Re-deprecated 'webui_hostname' as optional (from required). We still need to set the 'webui_hostname' field for now in order for interoperating with code that expects it to be required (e.g., a slave on an older release). After another deprecation cycle we can either remove this field entirely or just keep it around as an artifact so that we don't reuse the ID. Review: https://reviews.apache.org/r/15214 Diffs - include/mesos/mesos.proto be45494b2c2f5c1295409889b70004462c6eba49 src/common/type_utils.cpp e55b1f9beb4c1b7aba2076ce2b15072fd8eec4e3 src/master/registrar.cpp 3f9b9cf8ecc70e51fe41d3ac3993da1398571846 src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed Diff: https://reviews.apache.org/r/26149/diff/ Testing --- make check on ubuntu 14.04 Thanks, Cody Maloney
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2131
https://issues.apache.org/jira/browse/MESOS-1347 On Mon, Sep 29, 2014 at 12:30 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2131/changes Changes: [dlester] Adds OpenCredo and WooRank to PoweredByMesos page. -- [...truncated 20995 lines...] I0929 19:27:33.690207 6617 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 306053ns I0929 19:27:33.690224 6617 replica.cpp:342] Persisted promised to 1 I0929 19:27:33.690493 6614 coordinator.cpp:230] Coordinator attemping to fill missing position I0929 19:27:33.691164 6616 replica.cpp:375] Replica received explicit promise request for position 0 with proposal 2 I0929 19:27:33.691285 6616 leveldb.cpp:343] Persisting action (8 bytes) to leveldb took 101482ns I0929 19:27:33.691304 6616 replica.cpp:676] Persisted action at 0 I0929 19:27:33.691746 6623 replica.cpp:508] Replica received write request for position 0 I0929 19:27:33.691776 6623 leveldb.cpp:438] Reading position from leveldb took 11754ns I0929 19:27:33.691954 6623 leveldb.cpp:343] Persisting action (14 bytes) to leveldb took 154753ns I0929 19:27:33.691972 6623 replica.cpp:676] Persisted action at 0 I0929 19:27:33.692244 6622 replica.cpp:655] Replica received learned notice for position 0 I0929 19:27:33.692389 6622 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 121120ns I0929 19:27:33.692407 6622 replica.cpp:676] Persisted action at 0 I0929 19:27:33.692417 6622 replica.cpp:661] Replica learned NOP action at position 0 I0929 19:27:33.692615 6615 log.cpp:672] Writer started with ending position 0 I0929 19:27:33.693091 6624 leveldb.cpp:438] Reading position from leveldb took 11308ns I0929 19:27:33.694427 6623 registrar.cpp:346] Successfully fetched the registry (0B) I0929 19:27:33.694454 6623 registrar.cpp:422] Attempting to update the 'registry' I0929 19:27:33.695809 6610 log.cpp:680] Attempting to append 142 bytes to the log I0929 19:27:33.695890 6615 coordinator.cpp:340] Coordinator attempting to write APPEND action at position 1 I0929 19:27:33.696285 6622 replica.cpp:508] Replica received write request for position 1 I0929 19:27:33.696734 6622 leveldb.cpp:343] Persisting action (161 bytes) to leveldb took 424360ns I0929 19:27:33.696753 6622 replica.cpp:676] Persisted action at 1 I0929 19:27:33.697084 6613 replica.cpp:655] Replica received learned notice for position 1 I0929 19:27:33.697428 6613 leveldb.cpp:343] Persisting action (163 bytes) to leveldb took 321272ns I0929 19:27:33.697448 6613 replica.cpp:676] Persisted action at 1 I0929 19:27:33.697458 6613 replica.cpp:661] Replica learned APPEND action at position 1 I0929 19:27:33.697747 6615 registrar.cpp:479] Successfully updated 'registry' I0929 19:27:33.697799 6615 registrar.cpp:372] Successfully recovered registrar I0929 19:27:33.697830 6622 log.cpp:699] Attempting to truncate the log to 1 I0929 19:27:33.697904 6611 master.cpp:1099] Recovered 0 slaves from the Registry (104B) ; allowing 10mins for slaves to re-register I0929 19:27:33.698005 6623 coordinator.cpp:340] Coordinator attempting to write TRUNCATE action at position 2 I0929 19:27:33.698477 6624 replica.cpp:508] Replica received write request for position 2 I0929 19:27:33.698654 6624 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 155120ns I0929 19:27:33.698671 6624 replica.cpp:676] Persisted action at 2 I0929 19:27:33.698987 6612 replica.cpp:655] Replica received learned notice for position 2 I0929 19:27:33.699115 6612 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 105299ns I0929 19:27:33.699148 6612 leveldb.cpp:401] Deleting ~1 keys from leveldb took 15614ns I0929 19:27:33.699162 6612 replica.cpp:676] Persisted action at 2 I0929 19:27:33.699170 6612 replica.cpp:661] Replica learned TRUNCATE action at position 2 I0929 19:27:33.710770 6615 slave.cpp:169] Slave started on 46)@ 67.195.81.189:39093 I0929 19:27:33.710803 6615 credentials.hpp:84] Loading credential for authentication from '/tmp/GarbageCollectorIntegrationTest_DiskUsage_5meoSi/credential' I0929 19:27:33.710908 6615 slave.cpp:276] Slave using credential for: test-principal I0929 19:27:33.711005 6615 slave.cpp:289] Slave resources: cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] I0929 19:27:33.711081 6615 slave.cpp:317] Slave hostname: proserpina.apache.org I0929 19:27:33.711098 6615 slave.cpp:318] Slave checkpoint: false I0929 19:27:33.711467 6617 state.cpp:33] Recovering state from '/tmp/GarbageCollectorIntegrationTest_DiskUsage_5meoSi/meta' I0929 19:27:33.711596 6617 status_update_manager.cpp:193] Recovering status update manager I0929 19:27:33.711730 6622 slave.cpp:3277] Finished recovery I0929 19:27:33.712009 6617 slave.cpp:604] New master detected at master@67.195.81.189:39093
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2132
bumped up the inactive timeout from 10min to 30 min to account for build slowness. On Mon, Sep 29, 2014 at 4:48 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2132/changes Changes: [bmahler] Increased the store timeout for the Registrar tests. [dhamon] Switch [stout] to using compiler intrinsics for unreachable, exit, and abort [dhamon] Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort [dhamon] Switch [mesos] to using compiler intrinsics for unreachable, exit, and abort -- [...truncated 2915 lines...] [INFO] Building mesos 0.21.0 [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ mesos --- [INFO] [INFO] --- build-helper-maven-plugin:1.8:add-source (default) @ mesos --- [INFO] Source directory: https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/generated added. [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ mesos --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ mesos --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/classes [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ mesos --- [INFO] Compiling 16 source files to https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ mesos --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ mesos --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ mesos --- [INFO] Tests are skipped. [INFO] [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mesos --- [INFO] Building jar: https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/mesos-0.21.0.jar [INFO] [INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ mesos --- [INFO] [INFO] --- maven-javadoc-plugin:2.8.1:jar (build-and-attach-javadocs) @ mesos --- [INFO] Loading source files for package org.apache.mesos... Loading source files for package org.apache.mesos.state... Loading source files for package org.apache.mesos.containerizer... Constructing Javadoc information... Standard Doclet version 1.6.0_20 Building tree for all the packages and classes... Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Executor.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//ExecutorDriver.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Entry.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.OperationFailedException.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Position.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Reader.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.Writer.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Log.WriterFailedException.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//MesosExecutorDriver.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//MesosSchedulerDriver.html.. . Generating https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src/java/target/apidocs/org/apache/mesos//Scheduler.html.. .
Re: scheduler.killExecutor()
Adding a shutdownExecutor() driver call has been discussed before. https://issues.apache.org/jira/browse/MESOS-330 As a work around, have you considered sending a special kill task as a signal to the executor to commit suicide? On Mon, Sep 29, 2014 at 5:27 PM, Tom Arnfeld t...@duedil.com wrote: Hi, I've been making some modifications to the Hadoop framework recently and have come up against a brick wall. I'm wondering if the concept of killing an executor from a framework has been discussed before? Currently we are launching two tasks for each Hadoop TaskTracker, one that has a bit of CPU and all the memory, and then another with the rest of the CPU. In total this equals the amount of resources we want to give each TaskTracker. This is *kind of* how spark works, ish. The reason we do this is to be able to free up CPU resources and remove slots from a TaskTracker (killing it half dead) but keeping the executor alive. At some undefined point in the future we then want to kill the executor, this happens by killing the other control task. This approach doesn't work very well in practice as a result of https://issues.apache.org/jira/browse/MESOS-1812 which means tasks are not launched in order on the slave, so there is no way to guarantee the control task comes up first, which leads to all sorts of interesting races. Is this is bad road to go down? I can't use framework messages as I don't believe those are a reliable way of sending signals, so not sure where else to turn. Cheers, Tom.
Review Request 26159: Fixed framework logging in master.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26159/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Like we did for slave, wanted to standardize how we log about a framework in master.cpp. Included framework.name() because I think it's more useful for debugging in a multi-framework world. No semantic changes. Diffs - src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26159/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 26163: Fixed AllocatorTest.SlaveLost test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26163/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1844 https://issues.apache.org/jira/browse/MESOS-1844 Repository: mesos-git Description --- Similar to https://issues.apache.org/jira/browse/MESOS-1782 the expectation for 'resourcesRecovered' was not waited for before setting further expectations on it. Diffs - src/tests/allocator_tests.cpp b824f77a0e941ecb623d1e64c2cdebea7871b71a Diff: https://reviews.apache.org/r/26163/diff/ Testing --- Ran the test in a loop ~500 times. Thanks, Vinod Kone
Re: Review Request 26185: Update documentation/flags regarding new default hostname semantics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26185/#review55000 --- looking good. minor fixes and i'll get this committed. docs/configuration.md https://reviews.apache.org/r/26185/#comment95322 s/ip/IP/ here and everywhere else. also, for master: s/on which listening is done/that the master binds to (see --ip flag)/ for slave: s/on which listening is done/that the slave binds to (see --ip flag)/ - Vinod Kone On Sept. 30, 2014, 6:25 p.m., Evelina Dumitrescu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26185/ --- (Updated Sept. 30, 2014, 6:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1506 https://issues.apache.org/jira/browse/MESOS-1506 Repository: mesos-git Description --- Update slave/master documentation and flags to reflect the change for the default hostname semantics Diffs - docs/configuration.md fb92cfaf185ee5daecff54038050bb5894ae92e4 src/master/flags.hpp 507ca60a3569159242367389ed41e415dc1f0e6b src/slave/flags.hpp 32e51d214b0dbbb2f106236c6fa42ddec9774585 Diff: https://reviews.apache.org/r/26185/diff/ Testing --- Thanks, Evelina Dumitrescu
Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26125/#review55009 --- Thanks for the patch Tobi. In the future, I recommend you find a shepherd for a issue you want to work on and get a committment from them to review your code. That ensures reviews don't fall through the cracks. include/mesos/mesos.proto https://reviews.apache.org/r/26125/#comment95335 Add a blurb about it in the comment above? - Vinod Kone On Sept. 28, 2014, 4:28 a.m., Tobi Knaup wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26125/ --- (Updated Sept. 28, 2014, 4:28 a.m.) Review request for mesos. Bugs: MESOS-1828 https://issues.apache.org/jira/browse/MESOS-1828 Repository: mesos-git Description --- Allows frameworks to register a URL to its web UI. Diffs - include/mesos/mesos.proto be45494 src/master/http.cpp 41d91c8 src/webui/master/static/framework.html f6cce02 src/webui/master/static/frameworks.html b11d71a Diff: https://reviews.apache.org/r/26125/diff/ Testing --- Connected a framework with and without webui_url set and checked the web ui. Thanks, Tobi Knaup
Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI
On Sept. 30, 2014, 9:16 p.m., Niklas Nielsen wrote: Vinod Tobi: I can help out landing this if you are interested. I can't claim to be an angular expert though. One high-level comment: how about we write a test so we make sure it works in the future too? A simple framework register + parse state.json would do. SGTM. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26125/#review55010 --- On Sept. 28, 2014, 4:28 a.m., Tobi Knaup wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26125/ --- (Updated Sept. 28, 2014, 4:28 a.m.) Review request for mesos. Bugs: MESOS-1828 https://issues.apache.org/jira/browse/MESOS-1828 Repository: mesos-git Description --- Allows frameworks to register a URL to its web UI. Diffs - include/mesos/mesos.proto be45494 src/master/http.cpp 41d91c8 src/webui/master/static/framework.html f6cce02 src/webui/master/static/frameworks.html b11d71a Diff: https://reviews.apache.org/r/26125/diff/ Testing --- Connected a framework with and without webui_url set and checked the web ui. Thanks, Tobi Knaup
Re: MESOS-1739 Design Document: Allow slave reconfiguration on restart
All our design docs (likely after review phase in google docs) will live here https://cwiki.apache.org/confluence/display/MESOS. We haven't been great about design docs in the past, but we are getting better. On Tue, Sep 30, 2014 at 6:05 PM, Jay Buffington m...@jaybuff.com wrote: Design documents like this are fantastic. Not only do they make it easier to understand justifications for changes, but they help me understand the current state of affairs as well. Keep them coming! Even after the patch is merged this document has a lot of value. Please make sure that the doc lives on as long as the code does and is referenced in the jira and git commit messages that implement this design. Perhaps this design docs like this should be hosted on the ASF's wiki? An index of design docs would also be helpful. Jay On Mon, Sep 29, 2014 at 3:27 PM, Cody Maloney c...@mesosphere.io wrote: I've been working on: MESOS-1739 [1]. Vinod requested that I write up a design document for the changes that will be needed [2]. I'd appreciate any additional comments / review. Cody [1] https://issues.apache.org/jira/browse/MESOS-1739 [2] https://docs.google.com/document/d/1PWv7YIdV3nN2l1oUW7Nybm4KdnxZ7Px2JGc5UM-PKoQ/edit?usp=sharing
Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/#review55092 --- src/slave/slave.cpp https://reviews.apache.org/r/23912/#comment95455 Indentation of . src/slave/slave.cpp https://reviews.apache.org/r/23912/#comment95469 See my comment for this section of code in earlier review. AFAICT, it's not addressed. src/tests/slave_tests.cpp https://reviews.apache.org/r/23912/#comment95457 s/whenToKill/_runTask/ that way it's immediately apparent for someone reading line #1080 what this future represents. src/tests/slave_tests.cpp https://reviews.apache.org/r/23912/#comment95459 We format DoAll like this. DoAll(arg1, arg2, arg3) src/tests/slave_tests.cpp https://reviews.apache.org/r/23912/#comment95467 s/killed/killTask/ src/tests/slave_tests.cpp https://reviews.apache.org/r/23912/#comment95460 ditto. formatting. also, this expectation should be set after driver.launchTasks(). - Vinod Kone On Sept. 18, 2014, 1:47 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23912/ --- (Updated Sept. 18, 2014, 1:47 a.m.) Review request for mesos. Bugs: MESOS-947 https://issues.apache.org/jira/browse/MESOS-947 Repository: mesos-git Description --- Fixes MESOS-947 Slave should properly handle a killTask() that arrives between runTask() and _runTask(). Slave::killTask() did not check for task in question combination to be pending (i.e. Slave::runTask had happened, but Slave::_runTask had not yet) and then erroneously assumed that Slave::runTask() had not been executed. The task was then marked LOST instead of KILLED. But Slave::runTask had already scheduled Slave::_runTask to follow. Now the entry for being pending is removed, and the task is marked KILLED, and _runTask gets informed about this. It checks whether the task in question is currently pending and if it is not, then it infers that the task has been killed and does not erroneously try to complete launching it. Diffs - src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 src/tests/mesos.cpp 3dcb2acd5ad4ab5e3a7b4fe524ee077558112773 src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4 Diff: https://reviews.apache.org/r/23912/diff/ Testing --- Wrote a unit test that reliably created the situation described in the ticket. Observed that TASK_LOST and the listed log output occurred. This pointed directly to the lines in killTask() where the problem is rooted. Ran the test after fixing, it succeeded. Checked the log. It looks like a clean kill now :-) Thanks, Bernd Mathiske
Review Request 26242: Changed checkpoint logging from LOG(INFO) to VLOG(1).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26242/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Also, added a log line for executor launch to log its work directory. Diffs - src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 Diff: https://reviews.apache.org/r/26242/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 26243: Fixed the flaky SlaveRecoverTest.MultipleSlaves.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26243/#review55128 --- Ship it! Ship It! - Vinod Kone On Oct. 1, 2014, 7:20 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26243/ --- (Updated Oct. 1, 2014, 7:20 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1854 https://issues.apache.org/jira/browse/MESOS-1854 Repository: mesos-git Description --- The issue was that the test did not wait for the executor re-registration messages, so sometimes the slave would shutdown the executors. I went through and cleaned up the other slave recovery tests in this respect. Diffs - src/tests/slave_recovery_tests.cpp c7c30d626a431cd2523e68f022bc9bdcc4b18262 Diff: https://reviews.apache.org/r/26243/diff/ Testing --- Ran in repetition. Thanks, Ben Mahler
Re: Review Request 26198: Fixed a log line in the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26198/#review55136 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26198/ --- (Updated Sept. 30, 2014, 11:30 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- Added missing whitespace. Diffs - src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26198/diff/ Testing --- N/A Thanks, Ben Mahler
Re: Review Request 26200: Added validation for missing ExecutorInfo::framework_id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26200/#review55141 --- Ship it! src/master/master.cpp https://reviews.apache.org/r/26200/#comment95524 How about: // Master expects ExecutorInfo.framework_id to be // set even though it is an optional field. Currently the // scheduler driver ensures that the field is set. // But for schedulers not using the driver, we need // to do the validation here. // TODO(bmahler): Set this field in the master instead // of depending on the scheduler driver do it. - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26200/ --- (Updated Sept. 30, 2014, 11:30 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- We set this field on behalf of frameworks within the scheduler driver. When we move away from the scheduler driver, we'll want to consider setting this field on behalf of the framework within the Master. However, for now, since the master will crash if it's unset [1], we should prevent this from occurring. [1] https://github.com/apache/mesos/blob/0.20.1/src/master/master.cpp#L4134 Diffs - src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26200/diff/ Testing --- make check, adding a new test for this requires intercepting and modifying a LaunchTaskMessage, since the driver always sets this field. In the longer term, we should add unit tests for message validators. Thanks, Ben Mahler
Re: Review Request 26201: Properly deprecated ReregisterSlaveMessage::slave_id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26201/#review55144 --- Ship it! src/messages/messages.proto https://reviews.apache.org/r/26201/#comment95528 File a ticket for this? - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26201/ --- (Updated Sept. 30, 2014, 11:30 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- The explicit SlaveID within ReregisterSlaveMessage is redundant: it is also contained within the SlaveInfo. This follows up on the TODO to properly deprecate this. Diffs - src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed Diff: https://reviews.apache.org/r/26201/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 26202: Introduced a version during slave (re-)registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26202/#review55145 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26202/ --- (Updated Sept. 30, 2014, 11:30 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1696 https://issues.apache.org/jira/browse/MESOS-1696 Repository: mesos-git Description --- This is a short term approach to adding versioning, see MESOS-986 for the long term approach. This is needed so that the master can differentiate slaves that support reconciliation, in order to avoid requiring an additional upgrade phase as part of the reconciliation changes. Diffs - src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed Diff: https://reviews.apache.org/r/26202/diff/ Testing --- make check. My later changes rely on this version being set correctly. Thanks, Ben Mahler
Re: Review Request 26203: Removed redundant logging in the Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26203/#review55146 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26203/ --- (Updated Sept. 30, 2014, 11:30 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- See summary, no need to double log during slave (re-)registration. Diffs - src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26203/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 26204: Removed the need for Master::readdSlave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26204/#review55148 --- Ship it! src/master/master.cpp https://reviews.apache.org/r/26204/#comment95531 Pull this down too as you did for _registerSlave() ? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26204/ --- (Updated Sept. 30, 2014, 11:31 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- I wanted to avoid the need for both `addSlave()` and `readdSlave`. Now, the responsibility of `addSlave()` is only to add a `Slave` struct into the master's state. Callers are responsible for telling a slave that is is registered after adding it. This means the `Slave` constructor optionally takes executors and tasks. Diffs - src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26204/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 26205: Cleaned up Master::addFramework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26205/#review55149 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26205/ --- (Updated Sept. 30, 2014, 11:31 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- Similarly to https://reviews.apache.org/r/26204, addFramework only adds the Framework struct into the Master's state. It is the responsibility of the caller to tell the framework it is registered. This allows us the flexibily to fix MESOS-786 without re-factoring. Diffs - src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26205/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 26206: Introduced Master - Slave reconciliation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26206/#review55152 --- Ship it! src/slave/slave.cpp https://reviews.apache.org/r/26206/#comment95533 s/no/no need for/ Can you also add a comment about why this doesn't need to go through the status update manager? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26206/ --- (Updated Sept. 30, 2014, 11:31 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1696 https://issues.apache.org/jira/browse/MESOS-1696 Repository: mesos-git Description --- The master must rely on the slave to reconcile tasks that were missing in the re-registration message. Otherwise, the master may incorrectly send TASK_LOST in the event of a race. See MESOS-1696 for further details. Diffs - src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e src/messages/messages.proto 9ff06b38086010df362036c695a5222371f70f4d src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0 src/slave/slave.cpp c82d99f08cec8959ff9b21e7358401622427f2ed src/tests/fault_tolerance_tests.cpp e8f532232c091849489971d7fc96ae615ffb6de0 Diff: https://reviews.apache.org/r/26206/diff/ Testing --- make check, and modified the test that captured the TASK_LOST case. Added another test in a subsequent review. Thanks, Ben Mahler
Re: Review Request 26207: Split out partition and reconciliation tests from FaultTolerace tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26207/#review55155 --- Ship it! Ship It! - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26207/ --- (Updated Sept. 30, 2014, 11:31 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1696 https://issues.apache.org/jira/browse/MESOS-1696 Repository: mesos-git Description --- This is purely a movement of existing tests. FaultTolerance tests contained partition related tests, so I've moved those out since we now have partition_tests.cpp. Also, I created a file for master - slave reconciliation related tests. Diffs - src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b src/tests/fault_tolerance_tests.cpp e8f532232c091849489971d7fc96ae615ffb6de0 src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION src/tests/partition_tests.cpp 8136a95c421548cd03c4aa2585d79c4b1334641c Diff: https://reviews.apache.org/r/26207/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 26199: Eliminated redundant resource accounting in the master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/#review55156 --- Ship it! src/master/master.cpp https://reviews.apache.org/r/26199/#comment95539 hmmm. slave-used() doesn't really tell what is being returned here. how about calling it slave-resources() instead. do you think that's less confusing? slave-resources() # used resources. slave-info.resources() # total resources. - Vinod Kone On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/ --- (Updated Sept. 30, 2014, 11:30 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- This avoids the need for the per-framework resource accounting in addTask, which is error prone given it may diverge from the slave-used(). Rather, have Slave::used just return this mapping directly. Diffs - src/master/http.cpp 41d91c842456b6d8e23b45be24210c966c287e24 src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26199/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 26208: Added a test for the Master - Slave reconciliation race.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26208/#review55157 --- Ship it! src/tests/master_slave_reconciliation_tests.cpp https://reviews.apache.org/r/26208/#comment95540 s/launch/launch task/ src/tests/master_slave_reconciliation_tests.cpp https://reviews.apache.org/r/26208/#comment95543 Neither the slave nor the master right? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26208/ --- (Updated Sept. 30, 2014, 11:31 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1696 https://issues.apache.org/jira/browse/MESOS-1696 Repository: mesos-git Description --- See summary. Diffs - src/tests/master_slave_reconciliation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26208/diff/ Testing --- Ran this new test in repetition. Thanks, Ben Mahler
Re: Review Request 26199: Eliminated redundant resource accounting in the master.
On Oct. 1, 2014, 11:05 p.m., Vinod Kone wrote: src/master/master.cpp, line 4293 https://reviews.apache.org/r/26199/diff/1/?file=709864#file709864line4293 hmmm. slave-used() doesn't really tell what is being returned here. how about calling it slave-resources() instead. do you think that's less confusing? slave-resources() # used resources. slave-info.resources() # total resources. yea. not a big deal. that's why didn't raise an issue. s/used/allocated/ sounds good though, unless 'used' is already used in that context elsewhere. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/#review55156 --- On Sept. 30, 2014, 11:30 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/ --- (Updated Sept. 30, 2014, 11:30 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- This avoids the need for the per-framework resource accounting in addTask, which is error prone given it may diverge from the slave-used(). Rather, have Slave::used just return this mapping directly. Diffs - src/master/http.cpp 41d91c842456b6d8e23b45be24210c966c287e24 src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e Diff: https://reviews.apache.org/r/26199/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 26256: MESOS-1857 Fix path::join() on older libstdc++ which lack back()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26256/#review55219 --- Ship it! Ship It! - Vinod Kone On Oct. 2, 2014, 1:43 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26256/ --- (Updated Oct. 2, 2014, 1:43 a.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1857 https://issues.apache.org/jira/browse/MESOS-1857 Repository: mesos-git Description --- Hand calculate / retrieve the last character rather than using back() Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 63433ef62fd3d8c14a049d09d510571f45e56095 Diff: https://reviews.apache.org/r/26256/diff/ Testing --- make check on gcc 4.8.2 Thanks, Cody Maloney
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2141
+jake removed ubuntu6 jenkins slave from the labels because it doesn't seem to have libcurl installed. On Thu, Oct 2, 2014 at 10:07 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2141/changes Changes: [vinodkone] MESOS-1857 Fixed path::join() on older libstdc++ which lack back(). -- [...truncated 266 lines...] 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/thread_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/uuid_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/version_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:181: warning: source file '$(STOUT)/tests/proc_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:181: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:181: warning: source file '$(STOUT)/tests/os/setns_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:181: but option 'subdir-objects' is disabled 3rdparty/Makefile.am: installing './depcomp' Makefile.am:32: warning: source file 'src/help.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/http.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/latch.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/metrics/metrics.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/process.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/reap.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/subprocess.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/timeseries.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/decoder_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/encoder_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/http_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/io_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/main.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/mutex_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/metrics_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/owned_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/process_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/queue_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/reap_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/sequence_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/shared_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/statistics_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/subprocess_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled Makefile.am:92: warning: source file 'src/tests/system_tests.cpp' is in a subdirectory, Makefile.am:92: but option 'subdir-objects' is disabled
Re: Review Request 26254: Replaced default port value for mesos master in documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26254/#review55221 --- docs/configuration.md https://reviews.apache.org/r/26254/#comment95613 This section of the document talks about common options between master and slaves. We need to make it clear that the default is 5050 for master and 5051 for slave. - Vinod Kone On Oct. 1, 2014, 11:55 p.m., Evelina Dumitrescu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26254/ --- (Updated Oct. 1, 2014, 11:55 p.m.) Review request for mesos and Jay Buffington. Bugs: MESOS-1834 https://issues.apache.org/jira/browse/MESOS-1834 Repository: mesos-git Description --- Default port for mesos is 5050, but documentation states that it is 5051 Diffs - docs/configuration.md c8b6ca056bcd3b217eee789ad62db52ba4edd8ca Diff: https://reviews.apache.org/r/26254/diff/ Testing --- Thanks, Evelina Dumitrescu
