Re: [VOTE] Apache OFBiz 18.12.08

2023-05-29 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Fri, May 26, 2023 at 3:03 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> This is the vote thread to publish "Apache OFBiz 18.12.08", eighth
> release from the release18.12 branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-18.12.08.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.08.zip.asc: the detached signature file
> * apache-ofbiz-18.12.08.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 18.12.08
> [ -1] do not release
>
> This vote is open for at least 5 days.
>
> For more details about this process please refer to
> http://www.apache.org/foundation/voting.html
>


Re: [VOTE] Apache OFBiz 18.12.07

2023-04-06 Thread Aditya Sharma
+1

Thanks and regards,
Aditya Sharma

On Mon, Apr 3, 2023 at 1:18 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> This is the vote thread to publish "Apache OFBiz 18.12.07", seventh
> and probably final release from the release18.12 branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-18.12.07.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.07.zip.asc: the detached signature file
> * apache-ofbiz-18.12.07.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 18.12.07
> [ -1] do not release
>
> This vote is open for at least 5 days.
>
> For more details about this process please refer to
> http://www.apache.org/foundation/voting.html
>


Re: Welcome to Daniel Watford as new PMC member

2023-01-30 Thread Aditya Sharma
Congratulations Daniel! Welcome aboard.

Thanks and Regards,
Aditya Sharma

On Sat, Jan 28, 2023 at 4:27 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> The OFBiz PMC has invited Daniel Watford as a new PMC member and we
> are glad to announce that Daniel has accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome on board!
>


Re: SonarCloud detecting duplicate code in PR

2022-10-16 Thread Aditya Sharma
Hello Daniel,

> Can anyone confirm that the detected duplication is unrelated to the PR, or
> help me figure out what I might have misunderstood?
That's strange, but yes the duplications detected are indeed from
unrelated changes.


> Do we have a way to prevent SonarCloud from checking sources not maintained
> by ourselves?
I think we could define exclusion in sonarcloud.properties
https://github.com/apache/ofbiz-framework/blob/trunk/.sonarcloud.properties

Refer
https://stackoverflow.com/a/31639014/7130371

> Should files such as themes/common-theme/webapp/common-theme/js/jquery/* be
> in the ofbiz-framework repository at all? I assume they are downloaded from
> NPM during the build process.
We haven't migrated all the libraries to the NPM path yet, but we are
in the process of doing that.

jQuery is done, but not all the jQuery plugins:
https://github.com/apache/ofbiz-framework/blob/trunk/themes/common-theme/webapp/common-theme/js/package.json#L11

--
Thanks and Regards,
Aditya Sharma



On Tue, Oct 4, 2022 at 3:27 PM Daniel Watford  wrote:
>
> Hello,
>
> I've pushed PR549 (https://github.com/apache/ofbiz-framework/pull/549)
> which is flagged as failing SonarCloud's Code Analysis on account of
> duplicated code.
>
> As far as I can tell, the SonarCloud is detecting duplication within the
> javascript files which are not maintained by the OFBiz project.
>
> Can anyone confirm that the detected duplication is unrelated to the PR, or
> help me figure out what I might have misunderstood?
>
> Do we have a way to prevent SonarCloud from checking sources not maintained
> by ourselves?
>
> Should files such as themes/common-theme/webapp/common-theme/js/jquery/* be
> in the ofbiz-framework repository at all? I assume they are downloaded from
> NPM during the build process.
>
> --
> Daniel Watford


Re: Participate in Hacktoberfest 2022

2022-10-07 Thread Aditya Sharma
Hello team,

> 1. Add the “hacktoberfest” topic to the repository to opt-in to Hacktoberfest 
> and indicate we’re looking for contributions.
I have updated OFBiz repositories with the “hacktoberfest” topic
following instructions from INFRA document[1]

https://github.com/apache/ofbiz-framework
https://github.com/apache/ofbiz-plugins

> 2. Apply the “hacktoberfest” label to issues applicable for Hacktoberfest.

Applied label to some of the issue, I will soon add more to it
https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20Hacktoberfest%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC

I would request other community members to apply labels to issues they
find applicable for the Hacktoberfest.

1. 
https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Repositorymetadata

Thanks and Regards,
Aditya Sharma


On Tue, Sep 20, 2022 at 5:25 PM Aditya Sharma  wrote:
>
> Hello team,
>
> Hacktoberfest[1] is a yearly event by DigitalOcean to encourage people to 
> contribute to open source in October. It's a month-long event specially to 
> encourage new contributors. Four quality pull requests must be submitted to 
> public GitHub/Gitlab repositories in order to complete it.
>
> In order to participate we will need the following actions (complete 
> guidelines here[2]):
> 1. Add the “hacktoberfest” topic to the repository to opt-in to Hacktoberfest 
> and indicate we’re looking for contributions.
> 2. Apply the “hacktoberfest” label to issues applicable for Hacktoberfest.
>
> I propose to have Apache OFBiz participation in this event.
>
> If no one is against it, I will move ahead with the process.
>
> 1. https://hacktoberfest.com/
> 2. https://hacktoberfest.com/participation/#maintainers
>
> Thanks and Regards,
> Aditya Sharma
>
>


Re: Welcome to Leila Mekika as new committer

2022-10-03 Thread Aditya Sharma
Felicitations Leila and welcome aboard!!

Thanks and Regards,
Aditya Sharma

On Mon, Oct 3, 2022 at 11:37 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> Welcome Leila!
>
> Jacopo
>
> Il Lun 3 Ott 2022, 14:57 Nicolas Malin  ha
> scritto:
>
> > The OFBiz PMC has invited Leila Mekika as new
> > committer and we are glad to announce that she have accepted the
> > nomination.
> >
> > On behalf of the OFBiz PMC, welcome on board!
> >
> >
> >
>


Participate in Hacktoberfest 2022

2022-09-20 Thread Aditya Sharma
Hello team,

Hacktoberfest[1] is a yearly event by DigitalOcean to encourage people to
contribute to open source in October. It's a month-long event specially to
encourage new contributors. Four quality pull requests must be submitted to
public GitHub/Gitlab repositories in order to complete it.

In order to participate we will need the following actions (complete
guidelines here[2]):
1. Add the “hacktoberfest” topic to the repository to opt-in to
Hacktoberfest and indicate we’re looking for contributions.
2. Apply the “hacktoberfest” label to issues applicable for Hacktoberfest.

I propose to have Apache OFBiz participation in this event.

If no one is against it, I will move ahead with the process.

1. https://hacktoberfest.com/
2. https://hacktoberfest.com/participation/#maintainers

Thanks and Regards,
Aditya Sharma


Re: OFBiz re-architecture thoughts

2022-02-28 Thread Aditya Sharma
Hi Taher,

Thanks for this initiative!

How about incubating it and adopting it as a subproject?

Thanks and Regards,
Aditya Sharma

On Tue, Jan 25, 2022 at 10:28 PM Eugen Stan  wrote:

> Hello Taher,
>
> Thank you for this initiative and sorry for not replying sooner.
> I meant to reply for so long but life ...
>
> I think most / all agrees that change is needed in OFBiz but I guess we
> have different ideas on how to proceed.
>
> I don't think I can add a lot to what was already said.
>
> I do think keeping the current number of git repositories is good.
> More will add overhead.
> I do believe that ofbiz should provide stable extension points so people
> can deploy their own plugins and functionality.
>
> I'm also working on some ideas around OFBiz - I believe I can
> re-implement OFBiz entity engine on top of relational algebra using
> Calcite.
>
> More on this soon on the mailing list.
>
> Looking forward to seeing a PoC from you.
> I hope we do get to improve OFBiz and make it even more appealing.
>
>
> On 25.01.2022 16:29, Taher Alkhateeb wrote:
> > Thank you everyone for your kind feedback and sharing your thoughts on
> > this initiative.
> >
> > I didn't get enough feedback or momentum to give me the impression that
> > this can be a community initiative. I think I made the discussion too
> > early before coming up with a PoC. So I will attempt something privately
> > and come back perhaps when it is in a more ready state and see if it
> > garners any momentum. IF people are interested in collaborating, then
> > perhaps you can approach me and we can team up.
> >
> > Thank you again.
>
> Regards,
>
> --
> Eugen Stan
>
> +40770 941 271  / https://www.netdava.com


Re: [VOTE] Apache OFBiz 18.12.02 (second attempt)

2021-11-21 Thread Aditya Sharma
+1 (Binding)

Thanks and Regards,
Aditya Sharma

On Mon, Nov 22, 2021 at 9:31 AM Ashish Vijaywargiya 
wrote:

> +1
>
> Thanks,
> Ashish Vijaywargiya
>
> On Tue, Nov 16, 2021 at 9:57 PM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> > This is the second vote thread to publish "Apache OFBiz 18.12.02", the
> > second release from the release18.12 branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-18.12.02.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-18.12.02.zip.asc: the detached signature file
> > * apache-ofbiz-18.12.02.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 18.12.02
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
> >
>


Welcome Wiebke Pätzold as new committer!

2021-10-27 Thread Aditya Sharma
The OFBiz PMC has invited Wiebke to become a new committer and we are
pleased to announce that she has accepted the nomination.

Wiebke has been an active contributor to Apache OFBiz since February 2020,
and has made some significant contributions on minilang migration. She has
also been helping out Michael with Apache OFBiz blogs.

Thank you Wiebke for your valuable contributions so far and congratulations
for your new role!

Welcome aboard!

Thanks and Regards,
Aditya Sharma


Re: [VOTE] Apache OFBiz 18.12.01

2021-10-27 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Wed, Oct 27, 2021 at 2:06 PM Deepak Dixit  wrote:

> +1
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Wed, Oct 27, 2021 at 1:06 PM Gil Portenseigne <
> gil.portensei...@nereide.fr> wrote:
>
> > +1
> >
> > Thanks,
> >
> > Gil
> > On Sat, Oct 23, 2021 at 05:08:32PM +0200, Jacopo Cappellato wrote:
> > > This is the vote thread to publish "Apache OFBiz 18.12.01", the first
> > > release from the release17.12 branch.
> > >
> > > The release files can be downloaded from here:
> > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > > and are:
> > > * apache-ofbiz-18.12.01.zip
> > > * KEYS: text file with keys
> > > * apache-ofbiz-18.12.01.zip.asc: the detached signature file
> > > * apache-ofbiz-18.12.01.zip.sha512: checksum file
> > >
> > > Please download and test the zip file and its signatures (for
> > instructions
> > > on testing the signatures see
> > http://www.apache.org/info/verification.html).
> > >
> > > Vote:
> > > [ +1] release as Apache OFBiz 18.12.01
> > > [ -1] do not release
> > >
> > > This vote will be open for 5 days.
> > >
> > > For more details about this process please refer to
> > > http://www.apache.org/foundation/voting.html
> > >
> > > Best Regards,
> > >
> > > Jacopo
> >
>


Re: Introduce a "Good First Issue" Jira Label

2021-06-15 Thread Aditya Sharma
Thanks everyone for your inputs!

I have added following instructions under "How to create a Jira issue" of
OFBiz Contributors Best Practices[1] document:

Add "GoodForNewContributors" label if you think that it can be a good fit
for a new contributor



1.
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices

Thanks and Regards,
Aditya Sharma

On Mon, May 10, 2021 at 1:45 PM Gil Portenseigne <
gil.portensei...@nereide.fr> wrote:

> Hello,
>
> Good idea,
>
> To add some more about GoodForNewContributors, it seems well used in
> GitLab platform :
>
>
> https://gitlab.com/groups/gitlab-org/-/issues?label_name%5B%5D=good+for+new+contributors
>
> So sticking with it seems nice to me.
>
> Thanks
>
> Le 07/05/2021 à 15:53, Aditya Sharma a écrit :
> > Hi team,
> >
> > Good First Issue label can be used to identify any issue to be a good fit
> > for a new contributor. These issues can be a great way to get started
> with
> > a project. Then label is widely used by projects on GitHub[2] and quite
> > useful.
> >
> > I propose to introduce a "Good First Issue" like a label to avail more
> > contributions from new people. I noticed there is already a label for
> > GoodForNewContributors[2] used by some projects. We can use the same or
> > have one created as "Good First Issue" as per the conventions all over
> the
> > world.
> >
> > WDYAT?
> >
> > 1. https://github.com/topics/good-first-issue
> > 2.
> >
> https://issues.apache.org/jira/browse/REEF-21?jql=labels%20%3D%20GoodForNewContributors
> >
> > Thanks and Regards,
> > Aditya Sharma
> >
>


Introduce a "Good First Issue" Jira Label

2021-05-07 Thread Aditya Sharma
Hi team,

Good First Issue label can be used to identify any issue to be a good fit
for a new contributor. These issues can be a great way to get started with
a project. Then label is widely used by projects on GitHub[2] and quite
useful.

I propose to introduce a "Good First Issue" like a label to avail more
contributions from new people. I noticed there is already a label for
GoodForNewContributors[2] used by some projects. We can use the same or
have one created as "Good First Issue" as per the conventions all over the
world.

WDYAT?

1. https://github.com/topics/good-first-issue
2.
https://issues.apache.org/jira/browse/REEF-21?jql=labels%20%3D%20GoodForNewContributors

Thanks and Regards,
Aditya Sharma


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-19 Thread Aditya Sharma
+1

All tests passed on macOS Big Sur 11.2.3, AdoptOpenJDK openjdk version
"1.8.0_282" (build 1.8.0_282-b08)

Thanks and Regards,
Aditya Sharma

On Fri, Mar 19, 2021 at 2:19 PM Suraj Khurana 
wrote:

> +1
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Fri, Mar 19, 2021 at 1:43 PM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> > +1
> >
> > Jacopo
> >
> > On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato
> >  wrote:
> > >
> > > This is the vote thread (second attempt) to release a new bug fix
> > > release for the
> > > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will
> > > supersede all the previous releases from the same branch.
> > >
> > > The release files can be downloaded from here:
> > > https://dist.apache.org/repos/dist/dev/ofbiz/
> > >
> > > and are:
> > > * apache-ofbiz-17.12.06.zip
> > > * KEYS: text file with keys
> > > * apache-ofbiz-17.12.06.zip.asc: the detached signature file
> > > * apache-ofbiz-17.12.06.zip.sha512: checksum file
> > >
> > > Please download and test the zip file and its signatures (for
> > > instructions on testing the signatures see
> > > http://www.apache.org/info/verification.html).
> > >
> > > Vote:
> > > [ +1] release as Apache OFBiz 17.12.06
> > > [ -1] do not release
> > >
> > > This vote will be open for 5 days.
> > > For more details about this process please read
> > > http://www.apache.org/foundation/voting.html
> >
>


Re: Welcome to Priya Sharma as new committer!

2021-03-14 Thread Aditya Sharma
Many Congratulations Priya!!
Welcome aboard.

Thanks and Regards,
Aditya Sharma

On Sun, Mar 14, 2021 at 11:26 PM Suraj Khurana 
wrote:

> Congratulations Priya !! Welcome aboard.
>
> --
>
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Sun, Mar 14, 2021 at 10:20 PM Swapnil Shah <
> swapnil.s...@hotwaxsystems.com> wrote:
>
> > Many Congratulations Priya !!
> >
> > Thanks,
> > Swapnil
> >
> > > -Original Message-
> > > From: Pawan Verma 
> > > Sent: 11 March 2021 18:31
> > > To: Dev list 
> > > Subject: Welcome to Priya Sharma as new committer!
> > >
> > > The OFBiz PMC has invited Priya to become a new committer and we are
> > > pleased to announce that she has accepted the nomination.
> > >
> > > Welcome onboard Priya, more power to you!
> > >
> > >
> > > Pawan
> >
>


Re: Welcome to Martin Becker as new committer!

2021-03-04 Thread Aditya Sharma
Congratulations Martin!!
Welcome Aboard.

Thanks and Regards,
Aditya Sharma

On Thu, Mar 4, 2021 at 2:38 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> Congratulations Martin!!
>
> Jacopo
>
> On Wed, Mar 3, 2021 at 6:29 AM Pawan Verma  wrote:
> >
> > The OFBiz PMC has invited Martin to become a new committer and we are
> > pleased to announce that he has accepted the nomination.
> >
> > Welcome onboard Martin!
> > --
> > Thanks & Regards
> > Pawan Verma
> > ofbiz.apache.org
>


Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-04 Thread Aditya Sharma
+1 for jdk11

Thanks and regards,
Aditya Sharma


On Thu, Feb 4, 2021 at 11:02 AM Suraj Khurana 
wrote:

> Hi,
>
> +1 for jdk11.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Thu, Feb 4, 2021 at 2:30 AM Eugen Stan  wrote:
>
> > +1 for jdk11.
> >
> > We can focus on jdk17 once it's out.
> > The transition will probably require some work.
> >
> > jdk17 is attractive though in terms of language features and
> enhancements.
> >
> > We could use multiple JDK's to build OFBiz .
> > I can set this up in Jenkins or github actions with the community
> > consent / support.
> >
> > Well I kind of did it for jdk8 and jdk11 for both amd64 and arm64 with
> > docker images -
> > https://github.com/ieugen/ofbiz-framework/actions/runs/510286929 .
> >
> > But it's not official and would like to upstream it (hint hint).
> >
> >
> > Regards,
> > --
> > Eugen Stan
> > +40720 898 747 / netdava.com
> >
>


Re: Checkstyle pre-push hook not used when merging PR's

2021-02-04 Thread Aditya Sharma
Hi Michael,

With OFBIZ-11304[1], we introduced a Gradle plugin
git-hooks-gradle-plugin[2]. The plugin generates a pre-push hook on the
developer's local. I think as the plugin persists it should work along with
the forks too. Along with that, we used GitHub action that runs
checkstyleMain task on PRs as discussed here[3].

We only introduced these with ofbiz-framework repository and not with
ofbiz-plugins. We do not have Gradle in place for the ofbiz-plugin
repository so the same arrangement cannot be done and as discussed here[4]
it's checked while checking the trunk in Buildbot.

The new checkstyle issues must be introduced from the plugins I guess.


1. https://issues.apache.org/jira/browse/OFBIZ-11304
2. https://github.com/jakemarsden/git-hooks-gradle-plugin
3.
https://issues.apache.org/jira/browse/OFBIZ-11304?focusedCommentId=17138097&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17138097
4.
https://issues.apache.org/jira/browse/OFBIZ-11251?focusedCommentId=17183889&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17183889

Thanks and regards,
Aditya Sharma

On Thu, Feb 4, 2021 at 4:33 PM Michael Brohl 
wrote:

> Hi Girish,
>
> which githook plugin are you using? I found several, not sure which one
> to choose.
>
> It seems that they do exactly what I described, just have to check. If
> this is the case, I would recommend to use such a Gradle plugin which
> automatically sets up the git hooks in the local repository and closes
> the gap.
>
> I will create a Jira issue for this.
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 04.02.21 um 11:42 schrieb Girish Vasmatkar:
> > Hi Michael/Jacques
> >
> > +1 for the proposal. However, I do not face this issue on my local,
> partly
> > because I never tried to push to the repository without running any
> gradle
> > command. The gitHook gradle plug-in is essentially creating hooks on the
> > local repository that's why when I push to my forked OFBiz repo, pre-push
> > hook always gets executed forcing me to conform to checkstyle standards
> on
> > my forked repo too.
> >
> > Best Regards,
> > Girish
> >
> > On Thu, Feb 4, 2021 at 1:34 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com>
> > wrote:
> >
> >> Le 03/02/2021 à 17:59, Michael Brohl a écrit :
> >>> So I think we should find a way to deploy the hooks to the user's local
> >> repository to make sure they are used there also. Else we would always
> >> chase
> >>> after newly introduced checkstyle problems, especially if we use pull
> >> requests.
> >>> I found a solution here:
> >>
> https://www.viget.com/articles/two-ways-to-share-git-hooks-with-your-team/
> >> (at the bottom of the page). This must be
> >>> adapted for Gradle to be dependend of a build.
> >>>
> >>> This would keep our hooks versioned in the repository and would
> >> automatically install the hooks in the local repository.
> >>> What do you think?
> >> Hi Michael,
> >>
> >> It looks like a good idea to me. A Jira would fit.
> >>
> >> In the meantime you need to fix the checkstyle issues put in with
> >> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1973
> >> details here:
> >>
> >>
> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1973/steps/check/logs/stdio
> >>
> >> TIA
> >>
> >> Jacques
> >>
> >>
>


Re: Welcome Akash Jain as new PMC member

2021-01-28 Thread Aditya Sharma
Congratulations Akash
Welcome aboard!!

Thanks and Regards,
Aditya Sharma

On Fri, Jan 29, 2021 at 11:28 AM Deepak Dixit  wrote:

> Welcome aboard Akash!!
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Thu, Jan 28, 2021 at 10:10 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Akash Jain to become member of the committee
> and
> > we are glad to announce he has accepted the nomination.
> >
> > On behalf of the OFBiz PMC, welcome Akash!
> >
> >
>


Re: Welcome Girish Vasmatkar as new PMC member

2021-01-28 Thread Aditya Sharma
Congratulations Girish
Welcome aboard!!

Thanks and Regards,
Aditya Sharma

On Fri, Jan 29, 2021 at 11:41 AM Suraj Khurana 
wrote:

> Many Congratulations Girish !!
> Welcome aboard.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Fri, Jan 29, 2021 at 11:28 AM Deepak Dixit  wrote:
>
> > Welcome aboard Girish!!
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Thu, Jan 28, 2021 at 10:10 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > The OFBiz PMC has invited Girish Vasmatkar to become member of the
> > > committee and we are glad to announce he has accepted the nomination.
> > >
> > > On behalf of the OFBiz PMC, welcome Girish!
> > >
> > >
> >
>


Re: Remove JQuery UI from OFBiz website

2021-01-05 Thread Aditya Sharma
Thanks, everyone! I have merged the changes.

Let me know if someone faces any issues related to it.

Thanks and Regards,
Aditya Sharma


On Mon, Jan 4, 2021 at 10:23 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> +1
>
> Thanks,
>
> Jacopo
>
>
> On Mon, Jan 4, 2021 at 3:32 PM Aditya Sharma 
> wrote:
>
> > Hi team,
> >
> > While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI
> is
> > no longer used. I propose to remove it with the following PR:
> >
> > https://github.com/apache/ofbiz-site/pull/6/files
> >
> > I haven't found any code reference related to it and the site works well
> > without any console errors. Do let me know if anyone having any idea why
> it
> > was used or if there is something missed at my end.
> >
> > Thanks and regards,
> > Aditya Sharma
> >
>


Remove JQuery UI from OFBiz website

2021-01-04 Thread Aditya Sharma
Hi team,

While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI is
no longer used. I propose to remove it with the following PR:

https://github.com/apache/ofbiz-site/pull/6/files

I haven't found any code reference related to it and the site works well
without any console errors. Do let me know if anyone having any idea why it
was used or if there is something missed at my end.

Thanks and regards,
Aditya Sharma


Re: Welcome to Daniel Watford as new committer!

2021-01-03 Thread Aditya Sharma
Felicitations Daniel
Welcome aboard !!

Thanks and Regards,
Aditya Sharma

On Thu, Dec 31, 2020 at 9:50 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> The OFBiz PMC has invited Daniel to become a new committer and we are
> pleased  to announce that he has accepted the nomination.
>
> Welcome onboard Daniel!
>
> Jacopo
>


Re: Releasing 17.12.05, 18.12.01 and freezing R20

2020-12-22 Thread Aditya Sharma
+1 to the initial proposal of release

3 years of support for r17 and 5 years of support starting with r18
sounds good to me.
I think we can define a policy well stated on our release page

> > with an additional idea: maybe better skip r20 and make a r21 right at
> > the beginning of the year with the chance to release also in 21.
+1. We can think upon defining a timeline for stabilizing new release
branches with a tentative time period like maybe 3-12 months. There
are numerous new features that our users can benefit from and defining
certain timelines may reduce the wait time.

--
Thanks and Regards,
Aditya Sharma

On Tue, Dec 22, 2020 at 4:38 PM Jacques Le Roux
 wrote:
>
> Le 22/12/2020 à 10:08, Jacques Le Roux a écrit :
> > If we don't release R20 it means that we will at best release R21 at the 
> > end of 2021, again a lot of years between 2018 and 2021.
>
> OK forget it, OK this does not make sense, anyway it will be end of 2021, OK 
> for me for a brand new R21 :)
>
> But we need to release R18 ASAP...
>
> Jacques
>


Re: Kickoff Meeting - Apache OFBiz Tutorial Project

2020-12-09 Thread Aditya Sharma
+1

Thanks and regards,
Aditya Sharma

On Wed, Dec 9, 2020 at 1:09 PM Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Hello Tutorial Project Volunteers,
>
> First of all thank you so much for showing interest in volunteering the
> Apache OFBiz Tutorial Project.
>
> With this email I want to propose an online meeting to kickoff the project.
> This meeting will help us in knowing each other. After this meeting we will
> continue doing offline communication on email, OFBiz mailing list, Slack
> Channel to make progress with our work. We can surely plan online meetings
> in future as well as and when needed. This way the community will also be
> updated all the time.
>
> It's a great opportunity for all of us to learn from each other and to also
> prepare some robust content for OFBiz developers/users/evaluators. What
> we'll generate will be a next level set of tutorials and guides for the
> community and will be a proven asset for the project.
>
> How about meeting on this Friday 1:00 PM GMT? Does this day and time work
> for all of you? Please confirm your availability and we'll go from there.
>
> Available: +1
> May be: 0
> Not Available: -1
>
> Kind regards,
> Pranay Pandey
> https://ofbiz.apache.org/
>


Re: Can't build OFBiz

2020-12-07 Thread Aditya Sharma
Hi Tomek,

Your message has been moderated, else it would not have reached this
Mailing List.

Please subscribe to the mailing list, See why here
http://ofbiz.apache.org/mailing-lists.html.

You will get better support, people can answer you on the ML. The wider the
audience the better the answers you might get.

Also, it's more work for moderators who have to accept your messages as
long as you have not subscribed.

I would recommend you to ask such queries on the user mailing as the list
is intended for such a purpose.
http://ofbiz.apache.org/mailing-lists.html

Also, please share some more details about the OFBiz setup like the
version, environment, etc so that others may identify the issue and help
you better.

Thanks and Regards,
Aditya Sharma


On Mon, Dec 7, 2020 at 6:03 PM Tomek  wrote:

> I have tried to build OFBiz and I have two errors in file
> MacroFormRendererTest:
>
> /ofbiz/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java:127:
>
> error: method executeMacro in class FtlWriter cannot be applied to given
> types;
>  ftlWriter.executeMacro(withNotNull(), withNotNull());
>   ^
>required: Appendable,Locale,String
>found: Object,Object
>reason: actual and formal argument lists differ in length
> /ofbiz/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java:1042:
>
> error: method executeMacro in class FtlWriter cannot be applied to given
> types;
>  ftlWriter.executeMacro(withNotNull(),
> withCapture(macros));
>
> Can anybody help me?
>
> Tomek
>
>


Re: Where to put video, result from selenium about functional process

2020-11-30 Thread Aditya Sharma
Hi Olivier,

Thanks for your great efforts in this direction!

I think we can also use the official YouTube channel to keep these videos.
https://www.youtube.com/channel/UCxt1NtEaaeIRhMLHjALRe9w

I can help you out with uploading them if everyone agrees.

Thanks and Regards,
Aditya Sharma


On Mon, Nov 30, 2020 at 8:03 PM Olivier Heintz <
holivier.li...@ofbizextra.org> wrote:

> Hi community,
>
> I have just migrated a wiki page "How to Create the main Company in Party
> Manager" to the user-manual.
>
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_parties_processes
>
> As it describe a process, I have create a selenium webdriver test similar
> to what is described in the doc to
> 1. check all works as it's describe in the doc
> 2. be able to have a video to show the process (with some little comment
> at each step)
> (
> https://video.ploud.fr/videos/watch/d7d00dc4-9ad2-445b-baab-a15cd2ba099b)
>
> So the question, where can I put (or where it's better to put) this video
> and after added a link to it, in the user-manual.
>
> Currently I use a PeerTube server for the 3 first video :
> https://video.ploud.fr/video-channels/ofbizextra_tutorial/videos
>
>


Re: Checkstyle "Utility classes should not have a public or default constructor." error message

2020-11-17 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Thu, Nov 12, 2020 at 2:49 PM Suraj Khurana 
wrote:

> +1
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Thu, Nov 12, 2020 at 12:03 AM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi,
> >
> > Checkstyle returns 222 occurrences of the message "Utility classes should
> > not have a public or default constructor."
> >
> > This is due to
> >
> https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor
> >
> > I don't think we need to follow the "prevents calls from subclass"
> > suggestion  there
> >
> > I rather suggest to comment out the related class in checkstyle.xml:
> >
> > ie 
> >
> > If nobody is against, I'll do so in a week
> >
> > Then should remain only 280 errors and hopefully most will be easy to
> fix.
> > At least they will be easier to spot...
> >
> > Jacques
> >
> >
>


Re: Enable CodeQL scanning for all the OFBiz repositories

2020-10-02 Thread Aditya Sharma
That makes sense Jacques. It is critical.

I tried with one of my repositories and found that Code scanning alerts
under Security are only visible to people with write access i.e.
Committers.

Citation from article Managing code scanning alerts for your repository[1]

*"Anyone with read permission for a repository can see code scanning alerts
on pull requests. However, you need write permission to view a summary of
alerts for repository on the Security tab."*
Though I will spend some more time checking its behavior with other
scenarios like PR.

1.
https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/managing-code-scanning-alerts-for-your-repository#viewing-an-alert

Thanks and Regards,
Aditya Sharma

On Fri, Oct 2, 2020 at 10:19 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Aditya,
>
> We (I at least) receive already security alerts for our website code. It
> notably leaded to https://gitbox.apache.org/repos/asf?p=ofbiz-site.git
>
> As long are we are able to restrict the alerts sending to committers, it's
> OK with me. I'd not like other people to receive zero days information...
>
> Thanks
>
> Jacques
>
> Le 02/10/2020 à 15:06, Aditya Sharma a écrit :
> > Hi team,
> >
> > I think we can enable the code scanning security feature for all the
> OFBiz
> > repositories available with GitHub that helps identifying security
> > vulnerabilities using CodeQL.
> >
> > https://github.com/apache/ofbiz-framework/security/code-scanning
> > https://securitylab.github.com/tools/codeql
> >
> > Citation from
> >
> https://www.infoworld.com/article/3453742/github-makes-codeql-free-for-research-and-open-source.html
> > :
> > *"CodeQL, a semantic code analysis engine and query tool for finding
> > security vulnerabilities across a codebase, has been made available for
> > free by GitHub for anyone to use in research or to analyze open source
> > code."*
> >
> > If no one is against it, I will move ahead with it.
> >
> > Thanks and Regards,
> > Aditya Sharma
>
>


Enable CodeQL scanning for all the OFBiz repositories

2020-10-02 Thread Aditya Sharma
Hi team,

I think we can enable the code scanning security feature for all the OFBiz
repositories available with GitHub that helps identifying security
vulnerabilities using CodeQL.

https://github.com/apache/ofbiz-framework/security/code-scanning
https://securitylab.github.com/tools/codeql

Citation from
https://www.infoworld.com/article/3453742/github-makes-codeql-free-for-research-and-open-source.html
:
*"CodeQL, a semantic code analysis engine and query tool for finding
security vulnerabilities across a codebase, has been made available for
free by GitHub for anyone to use in research or to analyze open source
code."*

If no one is against it, I will move ahead with it.

Thanks and Regards,
Aditya Sharma


Re: Welcome Mridul Pathak as new PMC member!!

2020-09-20 Thread Aditya Sharma
Felicitations Mridul! Welcome aboard.

Thanks and Regards,
Aditya Sharma

On Fri, Sep 18, 2020 at 12:55 PM Ashish Vijaywargiya 
wrote:

> The OFBiz PMC has invited Mridul Pathak to become a member of the committee
> and we are glad to announce that he has accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome on board Mridul!
>


Re: Welcome Swapnil Shah as new PMC member!!

2020-09-20 Thread Aditya Sharma
Felicitations Swapnil! Welcome aboard.

Thanks and Regards,
Aditya Sharma

On Fri, Sep 18, 2020 at 12:56 PM Ashish Vijaywargiya 
wrote:

> The OFBiz PMC has invited Swapnil Shah to become a member of the committee
> and we are glad to announce that he has accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome on board Swapnil!
>


Re: OFBiz site and [ CVE-2017-16011] Cross-Site Scripting in jQuery

2020-09-03 Thread Aditya Sharma
Indeed that makes sense Jacques. I checked we no longer use
bootstrap-select plugin so removed it as an initial step.

https://github.com/apache/ofbiz-site/commit/eec3090d837d6e931271596a48dca6e6c4a9aedb

ofbiz-site passes the checks now
https://github.com/apache/ofbiz-site/network/alerts
https://github.com/apache/ofbiz-site

I further plan to check and upgrade libraries to more recent versions
further.

Thanks and Regards,
Aditya Sharma

On Thu, Sep 3, 2020 at 2:34 PM Jacques Le Roux 
wrote:

> Thanks Aditya,
>
> We could think that it's not a big deal since it's only a static site. But
> if we were defaced that would not look great ;)
>
> Jacques
>
> Le 03/09/2020 à 08:24, Aditya Sharma a écrit :
> > Hi Jacques,
> >
> > I think the dependency is related to bootstrap-select plugin.
> >
> https://github.com/apache/ofbiz-site/network/alert/js/plugins/bootstrap-select/package.json/jquery/open
> >
> > We might not be affected, though I will have a deeper look into it soon.
> >
> > Thanks and regards,
> > Aditya Sharma
> >
> >
> > On Wed, Sep 2, 2020 at 10:53 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Hi,
> >>
> >> I received an alert from GitHub Advisory <https://github.com/advisories
> >
> >> about OFBiz site and [CVE-2017-16011] "Cross-Site Scripting in jQuery"
> >>
> >> Could someone test if updating to jQuery 1.9 would work?
> >>
> >> I could then, or anyone ready for that, upgrade the OFBiz site to use
> >> jQuery 1.9
> >>
> >> Thanks
> >>
> >> Jacques
> >>
> >>
>


Re: OFBiz site and [ CVE-2017-16011] Cross-Site Scripting in jQuery

2020-09-02 Thread Aditya Sharma
Hi Jacques,

I think the dependency is related to bootstrap-select plugin.
https://github.com/apache/ofbiz-site/network/alert/js/plugins/bootstrap-select/package.json/jquery/open

We might not be affected, though I will have a deeper look into it soon.

Thanks and regards,
Aditya Sharma


On Wed, Sep 2, 2020 at 10:53 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> I received an alert from GitHub Advisory <https://github.com/advisories>
> about OFBiz site and [CVE-2017-16011] "Cross-Site Scripting in jQuery"
>
> Could someone test if updating to jQuery 1.9 would work?
>
> I could then, or anyone ready for that, upgrade the OFBiz site to use
> jQuery 1.9
>
> Thanks
>
> Jacques
>
>


Re: Headless Commerce Plugin for OFBiz

2020-08-19 Thread Aditya Sharma
+1 Thanks Arpit for bringing this up.

I have some prior experience working on a similar assignment. Please count
me in for the development and planning efforts.

Thanks and regards,
Aditya Sharma


On Tue, Aug 18, 2020 at 8:52 PM Arpit Mor 
wrote:

> Hi Devs,
>
> Hope everyone is safe and healthy amidst Covid-19 pandemic
>
> Most of you might have heard about “Headless Commerce” or API first
> commerce, but in case you haven’t, here is a brief summary of what headless
> commerce is and why it is the need of the hour.
>
> What is Headless Commerce?
> In its simplest form, headless commerce is the decoupling of the
> presentation layer (frontend) of an eCommerce from backend such that both
> are able to function independently. This decoupling is achieved by using
> APIs to expose core backend functionalities.
>
> Why Headless Commerce?
> Today, customers are consuming context from various channels and
> touch-points. Gone are the days when customers primarily needed to visit a
> website to buy online. With the rise of smartphones and the Internet of
> Things (IoT), customers can now shop from multiple channels like IoT
> devices, progressive web apps (PWAs), social media platforms, mobile apps,
> smart assistants, smart TV, kiosks, and many more.
> By decoupling frontend from backend - user interface, social commerce,
> mobile apps, IoT, and many more – can be changed or updated individually,
> without interfering with backend. Data is available to separate frontend
> applications via API calls and the backend runs invisibly in the
> background.
>
> Benefits of Headless Commerce
> Unlimited Channels and Touchpoints: With API first Headless Commerce,
> integration with the new channels and touchpoints becomes easy, economical,
> and quick.
>
> Innovation and Engaging User Experience: With traditional monolithic
> Commerce, making user-centric changes to your website requires both a front
> and backend transformation. But with headless commerce, all the
> frontend/app developers have to focus on is user experience,
> personalization, and consistency without having to worry about changes to
> the backend.
>
> Easy-to-Manage Integrations: Headless commerce not only includes providing
> API support to the frontend, but it also includes communication between
> various components (like ERP, WMS, OMS, CRM, POS, etc.) via APIs. This will
> reduce the complexity of the integration and its maintenance.
>
> Business Agility & less time to market: Companies must be able to respond
> quickly to new market opportunities by constantly releasing new features.
> In traditional commerce, each component is tightly coupled with another
> which makes changes a complex task. But with Headless commerce different
> components communicate via APIs, which make changes to one component easy
> without having to worry about changes to other components.
>
> I’d like to put forward a suggestion for developing a headless commerce
> plugin, to keep the competitive edge of OFBiz with the rapidly changing
> technological trends by exposing core backend functionalities via APIs (The
> REST capabilities are already added to OFBiz recently).
>
> Looking forward to suggestions and feedback.
>
> Thanks & Regards
> Arpit Mor
>


Re: Welcome to Devanshu Vyas as new committer!

2020-08-19 Thread Aditya Sharma
Many Congratulations Devanshu! Welcome aboard.

Thanks and Regards,
Aditya Sharma

On Wed, Aug 19, 2020 at 2:32 PM Pawan Verma  wrote:

> The OFBiz PMC has invited Devanshu Vyas to become a new committer and we
> are happy to announce that he has accepted this role.
>
> Some of the reasons for inviting Devanshu Vyas include:
>
> - He is invested in the OFBiz project and has been a member for many years
> - He is taking an initiative towards improving the system
> - He has functional experience in various areas of the framework
> - He enjoys working with the community and collaborating with others
>
> Please join me in welcoming and congratulating Devanshu!
>
> Cheers
> Pawan Verma
> ofbiz.apache.org
>


Re: Replace Mask Js

2020-08-18 Thread Aditya Sharma
+1, Thanks James
Compatible MIT License and a good community.

Thanks and regards,
Aditya Sharma

On Wed, Aug 19, 2020 at 5:16 AM James Yong  wrote:

> Thanks Jacques.
>
> Created OFBIZ-11964 for it.
>
> Regards,
> James
>
> On 2020/08/18 14:59:45, Jacques Le Roux 
> wrote:
> > +1
> >
> > I see no problems with that
> >
> > Jacques
> >
> > Le 18/08/2020 à 15:08, James Yong a écrit :
> > > Hi all,
> > >
> > > Would like to propose replacing
> > > github.com/igorescobar/jQuery-Mask-Plugin
> > > with
> > > https://github.com/RobinHerbots/Inputmask
> > >
> > > With the current library, I am not able to load using the new
> importLibrary function in ofbizUtil.js.
> > > The mask function seems only used in the page at
> /example/control/FormWidgetExamples
> > >
> > > Their respective demo page is at
> > > https://igorescobar.github.io/jQuery-Mask-Plugin/
> > > and
> > > https://robinherbots.github.io/Inputmask/
> > >
> > > Regards,
> > > James
> >
> >
>


Re: JavaScript Source Maps

2020-08-17 Thread Aditya Sharma
Hi Jacques, everyone,

I have created OFBIZ-11960[1] in this direction. Initially, I have kept it
very simple, JS dependencies will be downloaded through NPM and used from
the same downloaded path throughout. I will soon create a PR for the same.


1. https://issues.apache.org/jira/browse/OFBIZ-11960

Thanks and Regards,
Aditya Sharma

On Mon, Aug 10, 2020 at 8:14 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> I have decided to let down my work at
> https://github.com/JacquesLeRoux/gradle-js-plugin
>
> I have put a sentence about
> https://plugins.gradle.org/plugin/com.github.node-gradle.node in the
> Alert of the wiki page
>
> Jacques
>
> Le 27/07/2020 à 13:07, Jacques Le Roux a écrit :
> > Hi Aditya,
> >
> > Maybe it will be easier to indeed use the node Gradle plugin.
> >
> > Though I'm not much versed in node, then I guess following the steps I
> put in the alert at
> >
> > https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js
> >
> > Would be easier? Notably
> > https://github.com/mozilla/source-map
> >
> https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map
> >
> > Thanks
> >
> > Jacques
> >
> > Le 27/07/2020 à 09:48, Aditya Sharma a écrit :
> >> Hi Jacques,
> >>
> >> We should definitely care about JavaScript source maps as it is a great
> >> addon to debugging.
> >>
> >> I think gradle-js-plugin is indeed a great tool but due to a dead
> >> community, it always made me reluctant to use it. Thanks for your
> efforts
> >> towards its update. I still want to understand how it will be further
> >> maintained.
> >>
> >> As I get some time I will try to come up with some solution using the
> >> requirejs, node, etc to ease these things.
> >> https://plugins.gradle.org/plugin/com.github.node-gradle.node
> >>
> >>>> So I want to change it to "org.apache.ofbiz" to be able to publish. I
> >> guess I also need to change the package names (not yet sure about that)
> >> I think we will only have to change the id I guess and we have the
> option
> >> to configure the implementationClass
> >>
> >>
> https://guides.gradle.org/publishing-plugins-to-gradle-plugin-portal/#configure_the_plugin_publishing_plugin
> >>
> >>>> Now we also know (thanks to Suraj) that "We will get source map URL in
> >> most of the libraries except jQuery, we will have to manually add it"[8]
> >> Aditya :D
> >>
> >>
> >> Thanks and regards,
> >> Aditya Sharma
> >>
> >>
> >> On Sun, Jul 26, 2020 at 8:48 PM Jacques Le Roux <
> >> jacques.le.r...@les7arts.com> wrote:
> >>
> >>> Le 26/07/2020 à 11:44, Jacques Le Roux a écrit :
> >>>> There was a good old time when this was available[1]. But with Gradle
> >>> upgrades these plugins were slowly abandoned by their creator, eg[2]
> >>>> Some forks where done, eg[3][4]. Seems that their creators could not
> get
> >>> PRs merged. So I don't know how/if they are published and used.
> >>>
> >>> I somehow actually answered to myself with
> >>>
> >>>> [2] https://github.com/eriwen/gradle-css-plugin/issues/58
> >>> I read it there and forgot:
> >>>
> >>>  /< it in
> >>> the plugin block it will not work.//
> >>>  //The change is actually fixed in master but without a release
> >>> everyone is forced to manually build the plugin by himself and import
> the
> >>> jar the
> >>>  classpath.//>>/
> >>>
> >>> So that's how people are poorly handling it :/
> >>>
> >>> Jacques
> >>>
> >>>
>


Re: Welcome Pawan Verma as new PMC member

2020-07-28 Thread Aditya Sharma
Felicitation Pawan!!

Thanks and Regards,
Aditya Sharma

On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> The OFBiz PMC has invited Pawan Verma to become member of the committee
> and we are glad to announce that he has accepted the nomination.
>
> On behalf of the OFBiz PMC, welcome on board Pawan!
>
>


Re: JavaScript Source Maps

2020-07-27 Thread Aditya Sharma
Hi Jacques,

We should definitely care about JavaScript source maps as it is a great
addon to debugging.

I think gradle-js-plugin is indeed a great tool but due to a dead
community, it always made me reluctant to use it. Thanks for your efforts
towards its update. I still want to understand how it will be further
maintained.

As I get some time I will try to come up with some solution using the
requirejs, node, etc to ease these things.
https://plugins.gradle.org/plugin/com.github.node-gradle.node

>> So I want to change it to "org.apache.ofbiz" to be able to publish. I
guess I also need to change the package names (not yet sure about that)
I think we will only have to change the id I guess and we have the option
to configure the implementationClass

https://guides.gradle.org/publishing-plugins-to-gradle-plugin-portal/#configure_the_plugin_publishing_plugin

>>Now we also know (thanks to Suraj) that "We will get source map URL in
most of the libraries except jQuery, we will have to manually add it"[8]
Aditya :D


Thanks and regards,
Aditya Sharma


On Sun, Jul 26, 2020 at 8:48 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 26/07/2020 à 11:44, Jacques Le Roux a écrit :
> > There was a good old time when this was available[1]. But with Gradle
> upgrades these plugins were slowly abandoned by their creator, eg[2]
> >
> > Some forks where done, eg[3][4]. Seems that their creators could not get
> PRs merged. So I don't know how/if they are published and used.
>
> I somehow actually answered to myself with
>
> > [2] https://github.com/eriwen/gradle-css-plugin/issues/58
>
> I read it there and forgot:
>
> /< the plugin block it will not work.//
> //The change is actually fixed in master but without a release
> everyone is forced to manually build the plugin by himself and import the
> jar the
> classpath.//>>/
>
> So that's how people are poorly handling it :/
>
> Jacques
>
>


Re: JavaScript Source Maps

2020-07-24 Thread Aditya Sharma
That's great Jacques.

Just for reference, another fork of gradle js plugin which was updated in
May 2019.
https://plugins.gradle.org/plugin/eu.butter.gradle.js
https://github.com/tbutter/gradle-js-plugin/

Thanks and regards,

Aditya Sharma

On Thu, Jul 23, 2020 at 2:00 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi All,
>
> Backport done, I have created a fork of gradle-js-plugin and it works with
> Gradle 6.3. I'll tell you more when I'll get a chance :)
>
> Jacques
>
> Le 19/07/2020 à 16:08, Jacques Le Roux a écrit :
> > Thanks Aditya,
> >
> > @All, without more answers I'll exceptionally use a lazy consensus to
> backport changes in minified and add of maps files down to R17 in a week
> from
> > "16/07/2020 à 15:01"
> >
> > This because, even if the Jiras are registered as improvements and we
> can't see anything in UI and OFBiz logs, there are 404 and lack of help in
> > browser log.
> >
> > Thanks to Alex for the help!
> >
> > Jacques
> >
> > Le 17/07/2020 à 14:41, Aditya Sharma a écrit :
> >> Thank you, Jacques and Alex, for bringing this up. I think source maps
> can
> >> be a great aid for debugging. I am willing to give a hand.
> >>
> >> Thanks and regards,
> >> Aditya Sharma
> >>
> >> On Thu, Jul 16, 2020 at 8:36 PM Jacques Le Roux <
> >> jacques.le.r...@les7arts.com> wrote:
> >>
> >>> Le 16/07/2020 à 15:01, Jacques Le Roux a écrit :
> >>>> https://issues.apache.org/jira/issues/?jql=project %3D OFBIZ AND
> text ~
> >>> "map alex"
> >>> This url is easier to use: https://s.apache.org/xzdtx
> >>>
> >>>
>


Re: JavaScript Source Maps

2020-07-17 Thread Aditya Sharma
Thank you, Jacques and Alex, for bringing this up. I think source maps can
be a great aid for debugging. I am willing to give a hand.

Thanks and regards,
Aditya Sharma

On Thu, Jul 16, 2020 at 8:36 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 16/07/2020 à 15:01, Jacques Le Roux a écrit :
> > https://issues.apache.org/jira/issues/?jql=project %3D OFBIZ AND text ~
> "map alex"
> This url is easier to use: https://s.apache.org/xzdtx
>
>


Re: Welcome Aditya Sharma as new PMC member

2020-07-11 Thread Aditya Sharma
Thank you everyone for your kind wishes!
It's always a pleasure working with the OFBiz community.
Looking forward to more amazing experiences.

Thanks and Regards,
Aditya Sharma


On Wed, Jul 8, 2020 at 11:12 AM Ravi Lodhi  wrote:

> Many Congratulations Aditya!!
>
> Kind regards,
> --
> Ravi Lodhi
>
> On Sun, Jul 5, 2020 at 10:24 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Aditya Sharma to become member of the committee
> > and we are glad to announce that he has accepted the nomination.
> >
> > On behalf of the OFBiz PMC, welcome on board Aditya!
> >
> >
>


Re: Welcome Arun Patidar as new PMC member

2020-07-11 Thread Aditya Sharma
Many Congratulations Arun!

Thanks and Regards,
Aditya Sharma

On Wed, Jul 8, 2020 at 11:13 AM Ravi Lodhi  wrote:

> Many Congratulations Arun!
>
> Kind regards
> --
> Ravi Lodhi
>
> On Mon, Jul 6, 2020 at 12:30 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Arun Patidar to become member of the committee
> > and we are glad to announce that he has accepted the nomination.
> >
> > On behalf of the OFBiz PMC, welcome on board Arun!
> >
> >
>


Re: Welcome Suraj Khurana as new PMC member

2020-07-11 Thread Aditya Sharma
Many Congratulations Suraj!

Thanks and Regards,
Aditya Sharma

On Wed, Jul 8, 2020 at 11:14 AM Ravi Lodhi  wrote:

> Many Congratulations Suraj!
>
> Kind regards,
> --
> Ravi Lodhi
>
> On Sat, Jul 4, 2020 at 5:22 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com>
> wrote:
>
> > The OFBiz PMC has invited Suraj Khurana to become member of the committee
> > and we are glad to announce that he has accepted the nomination.
> >
> > On behalf of the OFBiz PMC, welcome on board Suraj!
> >
> >
>


Re: Check Style on release branches?

2020-07-11 Thread Aditya Sharma
Hi Jacques,

Thanks for initiating the discussion. Considering the lazy consensus, I
reopen OFBIZ-11251 <https://issues.apache.org/jira/browse/OFBIZ-11251>

Thanks and Regards,
Aditya Sharma

On Wed, Jun 17, 2020 at 1:44 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> While discussing with Aditya at OFBIZ-11304 I asked
>
> < but not checkstyle>>
>
> He suggested, and I tend to agree:
>
> < major change to OFBiz rather it is an add-on to the development process.
> Wdyt?>>
>
> What are your opinions? There are more information if needed at OFBIZ-11304
>
> Thanks
>
> Jacques
>
>


Re: Add CHANGELOG.md file

2020-06-17 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma


On Wed, Jun 17, 2020 at 12:57 PM Carsten Schinzer <
cars...@dcs-verkaufssysteme.de> wrote:

> +1 for a CHANGELOG.md
>
> Would this be maintained for all official release branches + trunk, right?
> Or official release branches only.
> Regards
>
> Carsten
>
>


Re: [PROPOSAL] First Data Payment Gateway Integration

2020-06-16 Thread Aditya Sharma
+1 Nicolas. Thanks Pritam for the proposal.

Thanks and regards,
Aditya Sharma


On Tue, Jun 16, 2020 at 1:44 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> +1, Pierre Smits proposed that long ago, created Jira(s?) and even
> contributed for at least one plugin
>
> That can be found in Jira I hope Pierre will follow and gave required
> information
>
> Jacques
>
> Le 16/06/2020 à 07:32, Suraj Khurana a écrit :
> > +1 Nicolas.
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> >
> > On Mon, Jun 15, 2020 at 8:23 PM Nicolas Malin 
> > wrote:
> >
> >> Hi Pritam,
> >>
> >> My preference go to move all gateway to plugin, to keep OFBiz framework
> >> slim and the connector quality high.
> >>
> >> If all third payment gateway are in plugin system, we are sure that the
> >> framework contains correct standard call in function process, and we 're
> >> not tempted (to go fast) to introduce bad hook to support a specific
> >> case needed by the gateway.
> >>
> >> That being said, your proposal to introduce this gateway payment are
> >> welcome :)
> >>
> >> Nicolas
> >>
> >> On 15/06/2020 15:15, Pritam Kute wrote:
> >>> Hello Devs,
> >>>
> >>> I hope everyone is safe and well.
> >>>
> >>> Apache OFBiz has OOTB integrations for most of the widely used payment
> >>> gateways around the world.
> >>>
> >>> We are working on integrating First Data Payment Gateway for one of the
> >>> websites. The First Data payment gateway is quite popular and comes in
> >> the
> >>> list of top payment gateways around the globe  We would like to
> >> contribute
> >>> the basic payment gateway integration of First Data into Apache OFBiz.
> We
> >>> would like to know your thoughts on this.
> >>>
> >>> We would also like your opinion on contributing the gateway code in
> >>> applications/accounting component vs a separate plugin.
> >>>
> >>> After approval from the community, we will create detailed tickets in
> >> JIRA
> >>> and contribute the patch accordingly.
> >>>
> >>> Thanks!
> >>>
> >>> Kind Regards,
> >>> --
> >>> Pritam Kute
> >>>
>


Re: OFBIZ-8459 and plugins as a submodule

2020-06-08 Thread Aditya Sharma
>> I'd like to know if we all agree that plugins dir is not a submodule of
ofbiz-framework.
+1

Thanks and Regards,
Aditya Sharma

On Mon, Jun 8, 2020 at 5:19 PM Olivier Heintz 
wrote:

> +1 for plugins dir is not a submodule of ofbiz-framework
>
> Le 07/06/2020 à 17:52, Jacques Le Roux a écrit :
> > Hi,
> >
> > While checking OFBIZ-11745, I found several commits done with OFBIZ-8459
> where the plugins dir was successively added, reverted and added again as a
> > submodule of ofbiz-framework.
> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b39c179
> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3a4d22
> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bda6192
> >
> > I guess we all missed it and have removed it. I'd like to know if we all
> agree that plugins dir is not a submodule of ofbiz-framework.
> >
> > Thanks
> >
> > Jacques
> >
> >
>


Re: IMPROVEMENT: Checkstyle formatting issues

2020-06-01 Thread Aditya Sharma
+1

Thanks and regards,
Aditya Sharma

On Mon, Jun 1, 2020 at 5:09 PM Suraj Khurana 
wrote:

> Hello Michael,
>
> Just the very last commit on that particular line that we check while
> annotating. Nothing else. As Jacques mentioned most of the time the history
> can be rebuilt with blame using lines around.
>
> --
> Best Regards,
> Suraj Khurana
> SENIOR TECHNICAL CONSULTANT
> mobile: +91 9669750002
> email: suraj.khur...@hotwax.co
> *www.hotwax.co <http://www.hotwax.co/>*
>
>
> On Mon, Jun 1, 2020 at 2:43 PM Michael Brohl 
> wrote:
>
> > Hi Suraj,
> >
> > +1 for the refactoring in general. What history do we lose while
> > refactoring?
> >
> > Thanks,
> >
> > Michael
> >
> >
> > Am 30.05.20 um 18:25 schrieb Suraj Khurana:
> > > Hello Devs,
> > >
> > > Hope you are doing good !!
> > >
> > > Currently, there are many checkstyle issues in code base which are due
> to
> > > formatting best practices, like indentation, using spaces before/after
> > > symbols etc.
> > >
> > > We can solve many thousands of such issues by correcting all such
> > > occurrences. Please share your thoughts on this.
> > >
> > > A known thing is that we will lose the last history of such codebase
> > while
> > > doing this re-factoring.
> > >
> > > Any other ideas to solve the problem are most welcome.
> > > --
> > > Best Regards,
> > > Suraj Khurana
> > > Senior Technical Consultant
> > >
> >
> >
>


Re: Removal of Price information from Pick Sheet Report

2020-06-01 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Mon, Jun 1, 2020 at 5:06 PM Jacques Le Roux 
wrote:

> Thanks Pawan,
>
> I agree with Pierre's concern and yours: +1 to simplify
>
> Jacques
>
> Le 01/06/2020 à 11:39, Pawan Verma a écrit :
> > Hello Devs,
> >
> > While working on OFBIZ-11781, issue of the distorted currency symbol.
> > Pierre asked: Are we confident that prices and currency symbols are a
> > requirement for a pick sheet?
> >
> > The important information for picket is Item, quantity, and location.
> > Pickers really don't need the unit price, subtotal, or other
> price-related
> > information.
> >
> > Should we remove the unit price and subtotal information from a pick
> sheet
> > report? Or should we fix OFBIZ-11781 only?
> >
> > Your suggestions are appreciated!
>
>


Re: Github PR template

2020-05-30 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Sat, May 30, 2020 at 10:43 PM Suraj Khurana 
wrote:

> Hello team,
>
> IMO, we should imply these changes to plugins repository as well.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Sat, May 30, 2020 at 1:29 PM Suraj Khurana 
> wrote:
>
> > This is awesome.
> >
> > Thanks everyone involved in this effort.
> >
> > --
> >
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> >
> > On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Le 28/05/2020 à 07:45, Aditya Sharma a écrit :
> >> > I think this might not be a problem until you got to change it;)
> >>
> >> Thanks Aditya,
> >>
> >> Actually I simply forgot to commit from my Linux VM :)
> >>
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0
> >>
> >> Jacques
> >>
> >>
>


Re: Adopting Github Workflow

2020-05-27 Thread Aditya Sharma
>> So maybe Infra can use the description there
+1 for using the description

>> For the link to Jira it depends on README.adoc. But if we put a link to
OFBiz site then the link to Jira is there.
Makes sense

Thanks and regards,
Aditya Sharma

On Tue, May 26, 2020 at 7:22 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks All,
>
> I will put the wiki page in Attic.
>
> I totally agree Aditya, good idea. It seems we need to ask Infra for that.
> I see no way to do it ourselves. Also it seems the "labels" comes from
> doap_OFBiz.rdf under site repo.
> So maybe Infra can use the description there or, as you suggest, something
> more elaborated to welcome users that we would define (tht maybe put in
> doap_OFBiz.rdf) with a link to OFBiz site
>
> For the link to Jira it depends on README.adoc. But if we put a link to
> OFBiz site then the link to Jira is there.
>
> Opinions?
>
> Jacques
>
> Le 26/05/2020 à 14:25, Aditya Sharma a écrit :
> > +1 Jacques. I think we are good with Jira for now and if needed we can
> add
> > a link to Jira in description like Apache Arrow[1]
> > Also, I would suggest that we should change the description of the
> > repository[2] from "Mirror of Apache OFBiz Framework" to a description of
> > OFBiz and the official website link similar to Apache Arrow.
> >
> > 1. https://github.com/apache/arrow#getting-involved
> > 2. https://github.com/apache/ofbiz-framework
> >
> > Thanks and Regards,
> > Aditya Sharma
> >
> > On Tue, May 26, 2020 at 5:42 PM Michael Brohl 
> > wrote:
> >
> >> +1
> >>
> >> Thanks Jacques,
> >>
> >> Michael Brohl
> >>
> >> ecomify GmbH - www.ecomify.de
> >>
> >>
> >> Am 25.05.20 um 18:53 schrieb Jacques Le Roux:
> >>> Hi All,
> >>>
> >>> I believe we are now pragmatically using JIRA + Patch, or GH + PR.
> >>>
> >>> Remains the question about allowing the creation of issues in GH. It
> >>> seems to me that nobody actually asked for that since Jira is enough
> >>> for our needs.
> >>>
> >>> So I should not need more than what we use currently and can put
> >>>
> >>
> https://cwiki.apache.org/confluence/display/OFBIZ/Question%3A+GitHub+or+Jira+or+both
> >>> in Attic now, right?
> >>>
> >>> Jacques
> >>>
> >>> Le 18/03/2020 à 18:22, Michael Brohl a écrit :
> >>>> +1 James!
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Michael
> >>>>
> >>>>
> >>>> Am 18.03.20 um 17:13 schrieb James Yong:
> >>>>> Hi all,
> >>>>>
> >>>>> I personally feel we should allow both JIRA and Github for issue
> >>>>> management, and let contributers use their own judgement on which
> >>>>> one to use. JIRA contains wealth of information and many open issues
> >>>>> for review, while Github allows easier review of source codes.
> >>>>> So do either JIRA + Patch, or GH + PR.
> >>>>>
> >>>>> Regards,
> >>>>> James
> >>>>>
> >>>>> On 2020/03/14 10:43:31, Jacques Le Roux
> >>>>>  wrote:
> >>>>>> Hi Benjamin, All,
> >>>>>>
> >>>>>> That's a good point indeed. And we 1st need to clearly define what
> >>>>>> are the old and the new processes. Here is a try:
> >>>>>>
> >>>>>> The "old process" (not so old, changed with Git replacing Svn,
> >>>>>> hence the discussion) is
> >>>>>>
> >>>>>> * use Jira to create issues with possibly attached patches and
> >>>>>> discussion there. With all what Jira affords...
> >>>>>> * You can also link a GH PR from Jira. And have a patch, then it
> >>>>>> begins to be confusing (which one is the later, etc.)
> >>>>>> * You can create a PR in GH and discuss it there, nothing else.
> >>>>>> There should not be crossed discussions in Jira and GH
> >>>>>> * I certainly miss other points, that's the gist
> >>>>>>
> >>>>>> The new process is not clearly defined, here are 2 possible
> versions:
> >>>>>>
> >>>>>> * Jira is

Re: Github PR template

2020-05-27 Thread Aditya Sharma
Thanks Jacques! It works I tried creating a PR by comparing trunk to my
fork branches and content from template show up.

>> I don't think it's a problem, since it's only related to GH, but I don't
see .github in Windows.
I think this might not be a problem until you got to change it ;)

Thanks and Regards,
Aditya Sharma

On Wed, May 27, 2020 at 7:57 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Note (also added as a comment in OFBIZ-11722):
>
> As the Github PR template is not related to OFBiz I followed this GH
> advice:
>
> To store your file in a hidden directory, name the pull request
> template .github/pull_request_template.md.
>
> I don't think it's a problem, since it's only related to GH, but I don't
> see .github in Windows. Using Git Bash:
>
> Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk)
> $ git pull
> Current branch trunk is up to date.
>
> Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk)
> $ cd .github
> bash: cd: .github: No such file or directory
>
> Jacques
>
> Le 27/05/2020 à 11:04, Jacques Le Roux a écrit :
> > Done, please review and amend if necessary
> >
> > Le 22/05/2020 à 12:45, Jacques Le Roux a écrit :
> >> I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that
> >>
> >> Jacques
> >>
> >> Le 13/05/2020 à 12:13, Jacques Le Roux a écrit :
> >>> Hi Deepak,
> >>>
> >>> Agreed, we had this discussion earlier:
> https://markmail.org/message/3l6dwx4vkknmovew
> >>>
> >>> We just miss a sub-task under
> https://issues.apache.org/jira/browse/OFBIZ-11268
> >>>
> >>> HTH
> >>>
> >>> Jacques
> >>>
> >>> Le 13/05/2020 à 12:06, Pierre Smits a écrit :
> >>>> +1.  And our current contributor pages in the wiki should be updated
> >>>> accordingly.
> >>>>
> >>>> Met vriendelijke groet,
> >>>>
> >>>> Pierre Smits
> >>>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/>
> since
> >>>> 2008 (without privileges)
> >>>>
> >>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> >>>> *Apache Directory <https://directory.apache.org>, PMC Member*
> >>>> Apache Incubator <https://incubator.apache.org>, committer
> >>>> Apache Steve <https://steve.apache.org>, committer
> >>>>
> >>>>
> >>>> On Wed, May 13, 2020 at 12:02 PM Deepak Dixit 
> wrote:
> >>>>
> >>>>> Hi Dev,
> >>>>>
> >>>>> I think we should add the github PR request [1] template for ofbiz
> >>>>> repositories.
> >>>>> It will help to guide new contributors to follow our practices and
> we will
> >>>>> have a generic template for PR.
> >>>>>
> >>>>> [1]
> >>>>>
> >>>>>
> https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository
> >>>>>
> >>>>> Thanks & Regards
> >>>>> --
> >>>>> Deepak Dixit
> >>>>> ofbiz.apache.org
> >>>>>
>


Re: Adopting Github Workflow

2020-05-26 Thread Aditya Sharma
+1 Jacques. I think we are good with Jira for now and if needed we can add
a link to Jira in description like Apache Arrow[1]
Also, I would suggest that we should change the description of the
repository[2] from "Mirror of Apache OFBiz Framework" to a description of
OFBiz and the official website link similar to Apache Arrow.

1. https://github.com/apache/arrow#getting-involved
2. https://github.com/apache/ofbiz-framework

Thanks and Regards,
Aditya Sharma

On Tue, May 26, 2020 at 5:42 PM Michael Brohl 
wrote:

> +1
>
> Thanks Jacques,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 25.05.20 um 18:53 schrieb Jacques Le Roux:
> > Hi All,
> >
> > I believe we are now pragmatically using JIRA + Patch, or GH + PR.
> >
> > Remains the question about allowing the creation of issues in GH. It
> > seems to me that nobody actually asked for that since Jira is enough
> > for our needs.
> >
> > So I should not need more than what we use currently and can put
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/Question%3A+GitHub+or+Jira+or+both
> > in Attic now, right?
> >
> > Jacques
> >
> > Le 18/03/2020 à 18:22, Michael Brohl a écrit :
> >> +1 James!
> >>
> >> Thanks,
> >>
> >> Michael
> >>
> >>
> >> Am 18.03.20 um 17:13 schrieb James Yong:
> >>> Hi all,
> >>>
> >>> I personally feel we should allow both JIRA and Github for issue
> >>> management, and let contributers use their own judgement on which
> >>> one to use. JIRA contains wealth of information and many open issues
> >>> for review, while Github allows easier review of source codes.
> >>> So do either JIRA + Patch, or GH + PR.
> >>>
> >>> Regards,
> >>> James
> >>>
> >>> On 2020/03/14 10:43:31, Jacques Le Roux
> >>>  wrote:
> >>>> Hi Benjamin, All,
> >>>>
> >>>> That's a good point indeed. And we 1st need to clearly define what
> >>>> are the old and the new processes. Here is a try:
> >>>>
> >>>> The "old process" (not so old, changed with Git replacing Svn,
> >>>> hence the discussion) is
> >>>>
> >>>>* use Jira to create issues with possibly attached patches and
> >>>> discussion there. With all what Jira affords...
> >>>>* You can also link a GH PR from Jira. And have a patch, then it
> >>>> begins to be confusing (which one is the later, etc.)
> >>>>* You can create a PR in GH and discuss it there, nothing else.
> >>>> There should not be crossed discussions in Jira and GH
> >>>>* I certainly miss other points, that's the gist
> >>>>
> >>>> The new process is not clearly defined, here are 2 possible versions:
> >>>>
> >>>>* Jira is only used for history reason, no more issue creations
> >>>> allowed
> >>>>* GH is used not only for PR but also to create issues (needs a
> >>>> PMC agreement). It's then a replacement of Jira and we need to be
> >>>> quite careful
> >>>>  doing so.
> >>>>
> >>>>* Jira continues to be used as is. With IMO some restrictions,
> >>>> like: if you have a patch you don't create a PR, it's one or the
> >>>> other way.
> >>>>* GH is used not only for PR but also to create issues (needs a
> >>>> PMC agreement) an discuss them there. PR or attached patch can be
> >>>> used to contribute.
> >>>>
> >>>> As you see, for me the question is not  "GitHub or Jira" but
> >>>> "GitHub or Jira or both" I have changed the title of the related
> >>>> wiki page accordingly:
> >>>>
> >>>>
> https://cwiki.apache.org/confluence/display/OFBIZ/Question%3A+GitHub+or+Jira+or+both
> >>>>
> >>>>
> >>>> HTH
> >>>>
> >>>> Jacques
> >>>>
> >>>> Le 13/03/2020 à 17:41, Benjamin Jugl a écrit :
> >>>>> I have been following this discussion for a while.  However, I
> >>>>> still wonder if this discussion is about which of the two options
> >>>>> is the better one.
> >>>>> In my opinion, the discussion should rather be about whether the
> >>>>> potential benefits of a new process justify the effort to change
> >>>>> the old one. It
> >>>>> seems to me at least that this aspect is being neglected a bit.
> >>>>>
> >>>>> Am 13.03.20 um 10:24 schrieb Michael Brohl:
> >>>>>> Hi all,
> >>>>>>
> >>>>>> I'd like to encourage everyone to visit the wiki page
> >>>>>>
> https://cwiki.apache.org/confluence/display/OFBIZ/GITHUB+plus+GIT+VS+JIRA+plus+GIT,
>
> >>>>>> read
> >>>>>> carefully, check, dicuss and ask questions to get to a good
> >>>>>> information base for an important decision to make.
> >>>>>>
> >>>>>> Thanks everyone,
> >>>>>>
> >>>>>> Michael Brohl
> >>>>>>
> >>>>>> ecomify GmbH - www.ecomify.de
> >>>>>>
> >>>>>>
> >>>>>> Am 12.03.20 um 17:28 schrieb Jacques Le Roux:
> >>>>>>> You are all invited to review, discuss in comments and possibly
> >>>>>>> add pro and cons on this page
> >>>>>>>
> >>>>>>>
> https://cwiki.apache.org/confluence/display/OFBIZ/GITHUB+plus+GIT+VS+JIRA+plus+GIT
> >>>>>>>
> >>>>>>>
> >>>>>>> It would else become unreadable here...
> >>>>>>>
> >>>>>>> Hopefully we will get to a consensus...
> >>>>>>>
> >>>>>>> Jacques
> >>>>>>>
> >>>>>>>
> >>
>
>


Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-25 Thread Aditya Sharma
Sure Jacques. I will add them to the given task.

Thanks and Regards,
Aditya Sharma

On Sun, May 24, 2020 at 4:02 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Guys,
>
> We have already https://issues.apache.org/jira/browse/OFBIZ-11304
>
> Please Aditya add your references there, we need to handle that before we
> decide to abandon it...
>
> Jacques
>
> Le 23/05/2020 à 16:53, Suraj Khurana a écrit :
> > +1 Aditya
> >
> > If we can do that, that would be great.
> >
> > --
> > Suraj khurana
> >
> >
> > On Sat 23 May, 2020, 6:55 PM Aditya Sharma, 
> wrote:
> >
> >> Hi Jacques,
> >>
> >> I think *check styles* plugin is important for us and we should think of
> >> introducing a pre-commit hook that checks only for the staged changes.
> This
> >> will help developers to know about the lint issues before the commit
> >> itself.
> >>
> >> Some reference I found that achieves the above case. Though I didn't try
> >> any of these solutions.
> >>
> >>
> >>
> https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e
> >>
> >>
> https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs
> >>
> >>
> https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/
> >>
> >> What do you think?
> >>
> >> Thanks and Regards,
> >> Aditya Sharma
> >>
> >> On Sat, May 23, 2020 at 6:44 PM Pawan Verma <
> pawan.ve...@hotwaxsystems.com
> >> wrote:
> >>
> >>> Hi Jacques,
> >>>
> >>> I care for the *checkstyle* issues but I also feel we should abandon
> it.
> >>>
> >>> --
> >>> Thanks & Regards
> >>> Pawan Verma
> >>> Technical Consultant
> >>> *HotWax Systems*
> >>> *Enterprise open source experts*
> >>> http://www.hotwaxsystems.com
> >>>
> >>>
> >>> On Sat, May 23, 2020 at 6:08 PM Jacques Le Roux <
> >>> jacques.le.r...@les7arts.com> wrote:
> >>>
> >>>> Ha wait I confused w/ something else.
> >>>>
> >>>> Aas I said when starting this thread
> >>>>
> >>>>  "this is a *checkstyle* issue. It's not clear to me why it
> >> happened."
> >>>> Currently BuildBot makes erratic exceptions trying to pull. I have
> >>> created
> >>>> for that (and just updated)
> >>>> https://issues.apache.org/jira/browse/INFRA-20303
> >>>>
> >>>> So it's maybe not only your commit which increased the style errors...
> >>>>
> >>>> Unfortunately in this case, as it's then difficult to know form where
> >>>> comes the errors (they can be cumulated commit after commit), the
> >> easier
> >>>> issue
> >>>> is to set tasks.checkstyleMain.maxErrors to the last reported errors
> :/
> >>>>
> >>>> Now I have also mentioned in the 1st msg of this thread:
> >>>>
> >>>>  "Also I begin to wonder if the community really cares about
> >>>> *checkstyle* issues..."
> >>>>
> >>>> I mean we could maybe abandon it since it seems I'm the only one to
> >>> care...
> >>>> HTH
> >>>>
> >>>> Jacques
> >>>>
> >>>> Le 23/05/2020 à 14:23, Jacques Le Roux a écrit :
> >>>>> Thanks Suraj!
> >>>>>
> >>>>> Jacques
> >>>>>
> >>>>> Le 23/05/2020 à 14:04, Suraj Khurana a écrit :
> >>>>>> Hello team,
> >>>>>>
> >>>>>> All tests passed on my local machine.
> >>>>>>
> >>>>>> I used: ./gradlew testIntegration
> >>>>>>
> >>>>>> --
> >>>>>> Best Regards,
> >>>>>> Suraj Khurana
> >>>>>> Senior Technical Consultant
> >>>>>>
> >>>>>>
> >>>>>> On Sat, May 23, 2020 at 5:17 PM  wrote:
> >>>>>>
> >>>>>>> The Buildbot has detected a new failure on builder
> >>>>>>> ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full
> >>>> details are
> >>>>>>> available at:
> >>>>>>>
> >>> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1396
> >>>>>>> Buildbot URL: https://ci.apache.org/
> >>>>>>>
> >>>>>>> Buildslave for this Build: asf947_ubuntu
> >>>>>>>
> >>>>>>> Build Reason: downstream
> >>>>>>> Build Source Stamp: [branch trunk]
> >>>> 8bdb6c99856fd4ae17a95ccb0f661a256caaab13
> >>>>>>> Blamelist: Suraj Khurana <
> >>>> 64310724+surajkhur...@users.noreply.github.com>,Suraj
> >>>>>>> Khurana 
> >>>>>>>
> >>>>>>> BUILD FAILED: failed shell_2
> >>>>>>>
> >>>>>>> Sincerely,
> >>>>>>>-The Buildbot
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
>


Re: LineLength for checkstyle

2020-05-24 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Sat, May 23, 2020 at 10:16 PM Pawan Verma  wrote:

> +1
>
> Pawan
>


Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Aditya Sharma
Hi Jacques,

I think *check styles* plugin is important for us and we should think of
introducing a pre-commit hook that checks only for the staged changes. This
will help developers to know about the lint issues before the commit itself.

Some reference I found that achieves the above case. Though I didn't try
any of these solutions.

https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e
https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs
https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/

What do you think?

Thanks and Regards,
Aditya Sharma

On Sat, May 23, 2020 at 6:44 PM Pawan Verma 
wrote:

> Hi Jacques,
>
> I care for the *checkstyle* issues but I also feel we should abandon it.
>
> --
> Thanks & Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> http://www.hotwaxsystems.com
>
>
> On Sat, May 23, 2020 at 6:08 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Ha wait I confused w/ something else.
> >
> > Aas I said when starting this thread
> >
> > "this is a *checkstyle* issue. It's not clear to me why it happened."
> >
> > Currently BuildBot makes erratic exceptions trying to pull. I have
> created
> > for that (and just updated)
> > https://issues.apache.org/jira/browse/INFRA-20303
> >
> > So it's maybe not only your commit which increased the style errors...
> >
> > Unfortunately in this case, as it's then difficult to know form where
> > comes the errors (they can be cumulated commit after commit), the easier
> > issue
> > is to set tasks.checkstyleMain.maxErrors to the last reported errors :/
> >
> > Now I have also mentioned in the 1st msg of this thread:
> >
> > "Also I begin to wonder if the community really cares about
> > *checkstyle* issues..."
> >
> > I mean we could maybe abandon it since it seems I'm the only one to
> care...
> >
> > HTH
> >
> > Jacques
> >
> > Le 23/05/2020 à 14:23, Jacques Le Roux a écrit :
> > > Thanks Suraj!
> > >
> > > Jacques
> > >
> > > Le 23/05/2020 à 14:04, Suraj Khurana a écrit :
> > >> Hello team,
> > >>
> > >> All tests passed on my local machine.
> > >>
> > >> I used: ./gradlew testIntegration
> > >>
> > >> --
> > >> Best Regards,
> > >> Suraj Khurana
> > >> Senior Technical Consultant
> > >>
> > >>
> > >> On Sat, May 23, 2020 at 5:17 PM  wrote:
> > >>
> > >>> The Buildbot has detected a new failure on builder
> > >>> ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full
> > details are
> > >>> available at:
> > >>>
> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1396
> > >>>
> > >>> Buildbot URL: https://ci.apache.org/
> > >>>
> > >>> Buildslave for this Build: asf947_ubuntu
> > >>>
> > >>> Build Reason: downstream
> > >>> Build Source Stamp: [branch trunk]
> > 8bdb6c99856fd4ae17a95ccb0f661a256caaab13
> > >>> Blamelist: Suraj Khurana <
> > 64310724+surajkhur...@users.noreply.github.com>,Suraj
> > >>> Khurana 
> > >>>
> > >>> BUILD FAILED: failed shell_2
> > >>>
> > >>> Sincerely,
> > >>>   -The Buildbot
> > >>>
> > >>>
> > >>>
> > >>>
> >
>


Re: @deprecated No replacement

2020-05-23 Thread Aditya Sharma
+1 Thanks Jacques!

Thanks and Regards,
Aditya Sharma

On Sat, May 23, 2020 at 12:13 PM Pierre Smits 
wrote:

> +1 forellen removing refs
>
> Op za 23 mei 2020 08:27 schreef Devanshu Vyas :
>
> > +1 to remove references.
> >
> > Thanks & Regards,
> > Devanshu Vyas.
> >
> >
> > On Sat, May 23, 2020 at 11:54 AM Mridul Pathak <
> > mridul.pat...@hotwaxsystems.com> wrote:
> >
> > > +1 to remove references.
> > >
> > > Thanks.
> > > --
> > > Mridul Pathak
> > >
> > >
> > > > On 22-May-2020, at 1:03 PM, Jacques Le Roux <
> > > jacques.le.r...@les7arts.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > We have 5, 8 years old, , "@deprecated No replacement" references in
> > > Java code:
> > > >
> > https://ofbiz.markmail.org/search/?q=%22%40deprecated+No+replacement%22
> > > >
> > > > It seems they are all related to Minilang.  I think we should either
> > > remove the concerned methods.
> > > >
> > > > Or rather, easier, remove the "@deprecated No replacement" references
> > > since anyway Minilang is deprecated as a whole.
> > > >
> > > > I'm for the later and will do so in a week if nobody is against.
> > > >
> > > > Jacques
> > > >
> > >
> > >
> >
>


Re: Welcome Swapnil M Mane as new PMC member

2020-04-26 Thread Aditya Sharma
Congratulations Swapnil!

Thanks and Regards,
Aditya Sharma

On Sat, Apr 25, 2020 at 9:58 PM Mohammad Kathawala <
mohammad.kathaw...@hotwaxsystems.com> wrote:

> Many Congratulations Swapnil!
> Kind Regards,
> Mohammad Kathawala
> Senior Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> cell: +91-7772858789
> office: 0731-409-3684
> http://www.hotwaxsystems.com
>
>
> On Sat, Apr 25, 2020 at 7:19 PM Pranay Pandey <
> pranay.pan...@hotwaxsystems.com> wrote:
>
> > Swapnil M,
> >
> > Congratulations and welcome.
> > Looking forward to a wonderful journey together.
> >
> > Best regards,
> > Pranay Pandey
> >
> >
> > On Thu, Apr 23, 2020 at 5:02 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > The OFBiz PMC has invited Swapnil M Mane to become member of the
> > committee
> > > and we are glad to announce that he has accepted the nomination.
> > >
> > > On behalf of the OFBiz PMC, welcome on board!
> > >
> > >
> >
>


Re: OFBiz-Shopify Integration

2020-04-26 Thread Aditya Sharma
+1. Thanks for the initiative Ritesh!

Thanks and Regards,
Aditya Sharma

On Sun, Apr 26, 2020 at 10:45 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> +1
>
> just wonder about the REST and GraphQL part. GirishI know you have some
> knowledge about that. What do you think?
>
> Jacques
>
> Le 26/04/2020 à 17:29, Girish Vasmatkar a écrit :
> > Hi Ritesh -
> >
> > This is certainly going to be a great initiative. +1
> >
> > Best,
> > Girish
> >
> >
> >
> >
> >
> > On Sun, Apr 26, 2020 at 8:49 PM Suraj Khurana 
> > wrote:
> >
> >> +1 for creating a new plugin.
> >>
> >> --
> >> Best Regards,
> >> Suraj Khurana
> >> SENIOR TECHNICAL CONSULTANT
> >> mobile: +91 9669750002
> >> email: suraj.khur...@hotwax.co
> >> *www.hotwax.co <http://www.hotwax.co/>*
> >>
> >>
> >> On Sun, Apr 26, 2020 at 10:00 AM Ritesh Kumar <
> >> ritesh.ku...@hotwaxsystems.com> wrote:
> >>
> >>> Hello team,
> >>>
> >>> Let me start by giving you heads up on Shopify.
> >>>
> >>> Shopify is a renowned eCommerce platform for building online retail
> >>> businesses. A large number of businesses are moving to the world of
> >> hosted
> >>> eCommerce platforms and Shopify seems to be, if not the best, one of
> the
> >>> best platforms available in the market today. Over a million merchants
> >> use
> >>> Shopify to run their businesses. They come in all sizes, from all
> around
> >>> the world, and each one is different. One can easily set up a store and
> >> go
> >>> online.
> >>>
> >>> Owing to such a large user base, there could be many merchants
> interested
> >>> in integrating their online sales with a powerful ERP system for the
> >>> backend processes such as order fulfilment, accounting, customer
> service,
> >>> etc.
> >>>
> >>> Shopify provides both REST and GraphQL APIs. APIs are richly
> documented.
> >> We
> >>> can further discuss the integration details.
> >>>
> >>> I do believe this integration will positively add to feature set
> already
> >>> available in OFBiz and can become a major adoption factor.
> >>>
> >>> Here are the references,
> >>> Shopify developer introduction
> >>> <https://shopify.dev/concepts/shopify-introduction>
> >>> Shopify storefront API <https://shopify.dev/docs/storefront-api>
> >>>
> >>> Please, let me know your thoughts on this.
> >>>
> >>> Best,
> >>>
> >>> --
> >>> Ritesh Kumar
> >>>
>


Re: Welcome James Young as new PMC member

2020-04-22 Thread Aditya Sharma
Congratulations James!

Thanks and regards,
Aditya Sharma

On Wed, Apr 22, 2020 at 7:34 PM Swapnil M Mane 
wrote:

> Congratulations James!
>
> - Best regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Wed, Apr 22, 2020 at 3:58 PM James Yong  wrote:
>
> > Hi all,
> >
> > Thank you for your words of congratulations.
> > Hope everyone is well and safe.
> > Also thanks PMC for the kind invitation.
> > Looking forward to deeper collaboration.
> >
> > Regards,
> > James
> >
> > On 2020/04/22 10:16:36, Deepak Nigam  wrote:
> > > Congratulations James!!!
> > >
> > > Regards
> > > --
> > > Deepak Nigam
> > >
> > >
> > >
> > > On Wed, Apr 22, 2020, 3:25 PM Pawan Verma  wrote:
> > >
> > > > Congratulations James!
> > > > --
> > > > Thanks & Regards
> > > > Pawan Verma
> > > > ofbiz.apache.org
> > > >
> > > >
> > > > On Wed, Apr 22, 2020 at 3:16 PM Suraj Khurana <
> suraj.khur...@hotwax.co
> > >
> > > > wrote:
> > > >
> > > > > Congratulations James !!
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > Suraj Khurana
> > > > > Senior Technical Consultant
> > > > >
> > > > >
> > > > > On Wed, Apr 22, 2020 at 3:15 PM Ashish Vijaywargiya <
> > > > > ashish.vijaywarg...@hotwaxsystems.com> wrote:
> > > > >
> > > > > > Congrats James!
> > > > > >
> > > > > > --
> > > > > > Kind Regards,
> > > > > > Ashish Vijaywargiya
> > > > > > Vice President of Operations
> > > > > > *HotWax Systems*
> > > > > > *Enterprise open source experts*
> > > > > > cell: +91-9893479711
> > > > > > http://www.hotwaxsystems.com
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Wed, Apr 22, 2020 at 2:08 PM Jacques Le Roux <
> > > > > > jacques.le.r...@les7arts.com> wrote:
> > > > > >
> > > > > > > The OFBiz PMC has invited James Young to become member of the
> > > > committee
> > > > > > > and we are glad to announce that he has accepted the
> nomination.
> > > > > > >
> > > > > > > On behalf of the OFBiz PMC, welcome on board!
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>


Re: Welcome to Girish Vasmatkar as new committer!

2020-04-22 Thread Aditya Sharma
Congratulations Girish!

Thanks and regards,
Aditya Sharma

On Wed, Apr 22, 2020 at 7:35 PM Swapnil M Mane 
wrote:

> Congratulations Girish!
>
> - Best regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Wed, Apr 22, 2020 at 5:55 PM Girish Vasmatkar <
> girish.vasmat...@hotwaxsystems.com> wrote:
>
> > Hi All
> >
> > Thanks for your continuous support in this journey. I am honoured and
> > privileged to be part of this community. Sure, the committership comes
> with
> > great responsibilities and I hope to back it up with even more commitment
> > from my side.
> >
> > Thanks once again!
> >
> > Best,
> > Girish
> >
> >
> > On Wed, Apr 22, 2020 at 5:36 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > Sorry I missed Girish 1st name in subject :/
> > >
> > > Le 22/04/2020 à 11:37, Jacques Le Roux a écrit :
> > > > The OFBiz PMC has invited Girish to become a new committer and we are
> > > pleased  to announce that he has accepted.
> > > >
> > > > Girish is part of the community for near 2 years and has proposed
> > > several smart propositions notably related to security and GraphQL, but
> > not
> > > only.
> > > >
> > > > Please join me in welcoming and congratulating Girish.
> > > >
> > > > Jacques
> > > >
> > > >
> > >
> >
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.03

2020-04-21 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Wed, Apr 22, 2020 at 5:10 AM Anil Patel 
wrote:

> +1
>
>
> Thanks and Regards
> Anil Patel
> COO
> HotWax Systems
> http://www.hotwaxsystems.com
> Cell: + 1 509 398 3120
>
>
> On Mon, Apr 20, 2020 at 5:04 AM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> > This is the vote thread to release a new bug fix release for the
> > release17.12 branch. This new release, "Apache OFBiz 17.12.03" will
> > supersede the previous release from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-17.12.03.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.03.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.03.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 17.12.03
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
> >
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.02

2020-04-13 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Mon, Apr 13, 2020 at 3:27 PM Swapnil M Mane 
wrote:

> +1
>
> - Best regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Fri, Apr 10, 2020 at 3:36 PM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> >  This is the vote thread to release a new bug fix release for the
> > release17.12 branch. This new release, "Apache OFBiz 17.12.02" will
> > supersede the previous release from the same branch.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> > and are:
> > * apache-ofbiz-17.12.02.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.02.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.02.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 17.12.02
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Best Regards,
> >
> > Jacopo
> >
>


Re: Demo instance for OFBiz 17.12 release and remove 13.07 demo

2020-03-09 Thread Aditya Sharma
+1 Thanks Swapnil

Thanks and Regards,
Aditya Sharma

On Sun, Mar 8, 2020 at 4:17 PM Michael Brohl 
wrote:

> +1
>
> Thanks Swapnil,
>
> Michael
>
>
> Am 06.03.20 um 10:34 schrieb Swapnil M Mane:
> > Hello team,
> > Current we have three demo instances [1] for OFBiz.
> >
> > -- Current Stable Release 16.11 - Demo
> > https://demo-stable.ofbiz.apache.org/ordermgr/control/main
> >
> > -- Developer Trunk - Demo
> > https://demo-trunk.ofbiz.apache.org/ordermgr/control/main
> >
> > -- Previous Stable Release 13.07 - Demo
> > https://demo-old.ofbiz.apache.org/ordermgr/control/main
> >
> > As we have our new OFBiz release 17.12, should we think of taking the
> > following actions:
> >
> > 1. The 'Current Stable Release' instance should have release 17.12
> > i.e. demo-stable.ofbiz.apache.org should deploy on release 17.12
> >
> > 2. The 'Previous Stable Release' instance should have release 16.11
> > i.e. demo-old.ofbiz.apache.org should deploy on 16.11
> >
> > After this migration, we will *no longer have 13.07 - Demo* instance.
> >
> > Here are some more details about the 13.07 demo instance.
> > The 13.07 instance gets down abruptly very frequently.
> > After this, it requires manual interaction to restart, in recent times
> > Jacques and I manually restarted it many times.
> > Looking at the current scenarios, it seems our users are also not
> > using 13.07 demo instance on a frequent basis, because no one from our
> > users reports us when it is down ;-)
> >
> > [1] https://ofbiz.apache.org/ofbiz-demos.html
> >
> > Best regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
>
>


Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Aditya Sharma
+1

Thanks and regards,
Aditya Sharma

On Fri, Feb 28, 2020 at 3:17 PM Michael Brohl 
wrote:

> There is no impersonation functionality in 17.12. The findings are
> either documentation or "constants" which do not affect the functionality.
>
> For 17.12.02 we should remove the documentation artefacts for the
> impersonation feature, but IMO this is no showstopper for the 17.12.01
> release.
>
> Michael
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 28.02.20 um 09:21 schrieb Pierre Smits:
> > I found 3 artefacts relating to the impersonation aspects.
> >
> > - CommonEvents.java
> > - security.adoc
> > - sy-impersonation.adoc
> >
> >
> >
> > Met vriendelijke groet,
> >
> > Pierre Smits
>
>


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

2020-02-03 Thread Aditya Sharma
+1

Signature Verified and integrations passed.
Seems the NOTICE file in release files have Copyright 2001-2016, hope it is
fine.

Thanks and regards,
Aditya Sharma

On Mon, Feb 3, 2020 at 2:40 PM Akash Jain 
wrote:

> +1
>
> Thanks and Regards
> --
> Akash Jain
>
> On Thu, Jan 30, 2020 at 7:43 PM Jacopo Cappellato <
> jacopo.cappell...@gmail.com> wrote:
>
> >  This is the vote thread to release a new bug fix release for the
> > release16.11 branch. This new release, "Apache OFBiz 16.11.07" will
> > supersede all the previous releases from the same branch.
> > Please consider that this may be the last release in the 16.11 series and
> > in the future releases will be published from the newer series only.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-16.11.07.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-16.11.07.zip.asc: the detached signature file
> > * apache-ofbiz-16.11.07.zip.sha512: checksum file
> >
> > Please download and test the zip file and its signatures (for
> instructions
> > on testing the signatures see
> http://www.apache.org/info/verification.html
> > ).
> >
> > Vote:
> > [ +1] release as Apache OFBiz 16.11.07
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> > For more details about this process refer to
> > http://www.apache.org/foundation/voting.html
> >
> > Kind Regards,
> >
> > Jacopo
> >
>


Re: Migrate all docbook files to asciidoc ?

2020-01-28 Thread Aditya Sharma
+1

Thanks Olivier for the initiative!

Thanks and Regards,
Aditya Sharma


On Wed, Jan 29, 2020, 12:11 PM Michael Brohl 
wrote:

> +1
>
> Thanks,
>
> Michael
>
>
> Am 29.01.20 um 05:55 schrieb Swapnil M Mane:
> > Thank you so much Olivier for this initiative, indeed the documentation
> is
> > a critical part for a successful open source project.
> > I am inclined with the Taher's input here.
> >
> >
> > - Best regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Wed, Jan 29, 2020 at 1:25 AM Taher Alkhateeb <
> slidingfilame...@gmail.com>
> > wrote:
> >
> >> It sounds like a good initiative to me. I would be careful about pure
> >> converting without reviewing. Some of the documentation is quite
> outdated
> >> and so maybe convert + review is a reasonable approach.
> >>
> >> On Tue, Jan 28, 2020, 9:52 PM Olivier Heintz 
> wrote:
> >>
> >>> Hi everyone,
> >>>
> >>> I wanted to make progress on the OFBiz documentation, and thus continue
> >>> the existing tasks, at first the one on the accounting component.
> >>>
> >>> It's a bit painful to have to work between the old files in docbook and
> >>> the new ones in asciidoc.
> >>> For me it would be simpler to migrate all the docbooks first, and then
> >>> rework the result.
> >>>
> >>> Does this process bother anyone ?
> >>>
> >>> Olivier
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
>
>


Re: [VOTE] Do not release R17 and directly publish R18 instead.

2020-01-27 Thread Aditya Sharma
-1

Thanks and Regards,
Aditya Sharma

On Mon, Jan 27, 2020 at 4:02 PM James Yong  wrote:

> +1
>
> Regards,
> James
>
> On 2020/01/24 10:27:15, Jacques Le Roux 
> wrote:
> > Hi,
> >
> > R16 is now an old distribution and has almost reached its end of
> support. We can soon expect a last release but we need to think about the
> next to be
> > released package
> >
> > Some would prefer to release R17 before releasing R18, some would prefer
> to bypass R17 release and directly publish R18 instead.
> >
> > Vote:
> > [ +1] Do not release R17 and directly publish R18 instead.
> > [ -1]  Release R17 before releasing R18
> >
> > We had already 3 months to discuss without reaching a consensus, so this
> vote will be only open for a week.
> >
> > Note that it's not a formal vote to release R17 or R18, as that is
> another process documented at
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
> >
> > Thank you for your attention
> >
> > Jacques
> >
> >
>


Re: svn commit: r1869039 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java

2019-10-30 Thread Aditya Sharma
Makes sense to me. Thanks Jacques, Mathieu, and Jacopo for the
clarification :)

Thanks and regards,
Aditya Sharma

On Tue, Oct 29, 2019 at 10:15 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> On Tue, Oct 29, 2019 at 2:18 PM Aditya Sharma 
> wrote:
>
> > Hi team,
> >
> > Just to clarify, as per commit message template document[1] the template
> is
> >
> > [Implemented|Improved|Fixed|Completed|Documented|Reverted]: [Jira
> > title|Free text]
> >
> > Can we use "Free text" instead of "Jira title" when committing
> specifically
> > for any Jira?
> >
> >
> My interpretation is that the | symbol means OR: "Jira title" OR "Free
> text".
> I think it is completely fine (or even preferable) to provide a free text
> to describe a commit done for a Jira ticket (according to the template, the
> ticket id can be provided in the parenthesis).
>
> Jacopo
>


Re: svn commit: r1869039 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java

2019-10-29 Thread Aditya Sharma
Hi team,

Just to clarify, as per commit message template document[1] the template is

[Implemented|Improved|Fixed|Completed|Documented|Reverted]: [Jira
title|Free text]

Can we use "Free text" instead of "Jira title" when committing specifically
for any Jira?

1.
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template


Thanks and Regards,
Aditya Sharma


On Sun, Oct 27, 2019 at 8:59 PM  wrote:

> Author: mthl
> Date: Sun Oct 27 15:29:10 2019
> New Revision: 1869039
>
> URL: http://svn.apache.org/viewvc?rev=1869039&view=rev
> Log:
> Fixed: Fix javadoc build
> (OFBIZ-11007)
>
> This fixes the javadoc errors introduced in revision 1868963.
>
> Modified:
>
> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java?rev=1869039&r1=1869038&r2=1869039&view=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
> Sun Oct 27 15:29:10 2019
> @@ -99,10 +99,10 @@ public class ControlServlet extends Http
>  /**
>   * Invokes {@link RequestHandler#doRequest} with error handling.
>   *
> - * @param req  an {@link HttpServletRequest} object that contains the
> request
> - * the client has made of the servlet
> - * @param resp  an {@link HttpServletResponse} object that contains
> the response
> - *  the servlet sends to the client
> + * @param request  an {@link HttpServletRequest} object that contains
> the request
> + * the client has made of the servlet
> + * @param response an {@link HttpServletResponse} object that
> contains the response
> + * the servlet sends to the client
>   * @throws IOException if an output error is detected when trying to
> write on the response.
>   */
>  public void handle(HttpServletRequest request, HttpServletResponse
> response) throws IOException {
>
>
>


Re: svn commit: r1867666 - in /ofbiz/ofbiz-framework/trunk/applications: accounting/src/main/groovy/org/apache/ofbiz/accounting/ accounting/testdef/data/ order/src/main/groovy/org/apache/ofbiz/order/

2019-09-30 Thread Aditya Sharma
Hi Pawan,

Thanks for your efforts in this direction, it seems the commit message
should be something like this:

===
Improved: Added Unit test case
(OFBIZ-8936)(OFBIZ-8874)(OFBIZ-8873)(OFBIZ-8872)(OFBIZ-8871)(OFBIZ-8870)(OFBIZ-8866)

Added Unit test case for following services
- createSimpleTextContentForInvoice
- processWaitReplacementReturn
- processWaitReplacementReservedReturn
- processSubscriptionReturn
- processReplacementReturn
- processReplaceImmediatelyReturn
- processRefundOnlyReturn


Thanks, Deepak Nigam, Avnindra Sharma and Anushi Gupta for your
contribution.
===

See Example 3 with details and multiple Jira references
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template

Thanks & Regards,
Aditya Sharma

On Sat, Sep 28, 2019 at 5:38 PM  wrote:

> Author: pawan
> Date: Sat Sep 28 12:08:46 2019
> New Revision: 1867666
>
> URL: http://svn.apache.org/viewvc?rev=1867666&view=rev
> Log:
> Improved: Added Unit test case for following services
> - createSimpleTextContentForInvoice
> - processWaitReplacementReturn
> - processWaitReplacementReservedReturn
> - processSubscriptionReturn
> - processReplacementReturn
> - processReplaceImmediatelyReturn
> - processRefundOnlyReturn
>
> (OFBIZ-8936)(OFBIZ-8874)(OFBIZ-8873)(OFBIZ-8872)(OFBIZ-8871)(OFBIZ-8870)(OFBIZ-8866)
>
> Thanks, Deepak Nigam, Avnindra Sharma and Anushi Gupta for your
> contribution.
>
> Modified:
>
> ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgInvoiceTests.groovy
>
> ofbiz/ofbiz-framework/trunk/applications/accounting/testdef/data/AccountingTestsData.xml
>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
>
> Modified:
> ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgInvoiceTests.groovy
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgInvoiceTests.groovy?rev=1867666&r1=1867665&r2=1867666&view=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgInvoiceTests.groovy
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgInvoiceTests.groovy
> Sat Sep 28 12:08:46 2019
> @@ -52,4 +52,30 @@ class AutoAcctgInvoiceTests extends OFBi
>
>  assert invoiceContent.contentId == serviceResult.contentId
>  }
> +void testCreateSimpleTextContentForInvoice() {
> +def userLogin = EntityQuery.use(delegator).from('UserLogin')
> +.where('userLoginId', 'system')
> +.cache()
> +.queryOne()
> +
> +Map serviceCtx = [
> +invoiceId: '1009',
> +contentId: '1001',
> +contentTypeId: 'DOCUMENT',
> +invoiceContentTypeId: 'COMMENTS',
> +text: 'Content for invoice # 1009',
> +fromDate: UtilDateTime.nowTimestamp(),
> +userLogin: userLogin
> +]
> +Map serviceResult =
> dispatcher.runSync('createSimpleTextContentForInvoice', serviceCtx)
> +assert ServiceUtil.isSuccess(serviceResult)
> +
> +GenericValue invoiceContent =
> EntityQuery.use(delegator).from('InvoiceContent')
> +.where('invoiceId', '1009',
> +'contentId', '1001',
> +'invoiceContentTypeId', 'DOCUMENT')
> +.queryFirst()
> +
> +assert invoiceContent != null
> +}
>  }
>
> Modified:
> ofbiz/ofbiz-framework/trunk/applications/accounting/testdef/data/AccountingTestsData.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/testdef/data/AccountingTestsData.xml?rev=1867666&r1=1867665&r2=1867666&view=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/applications/accounting/testdef/data/AccountingTestsData.xml
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/applications/accounting/testdef/data/AccountingTestsData.xml
> Sat Sep 28 12:08:46 2019
> @@ -99,6 +99,8 @@ under the License.
>   statusId="INVOICE_IN_PROCESS" partyIdFrom="DEMO_COMPANY"
> partyId="DEMO_COMPANY1" invoiceDate="2016-11-03 00:00:00"/>
>  
&g

Re: Adding a CONTRIBUTING.adoc file to the “ofbiz-framework” repository (was: svn commit: r1867663 …)

2019-09-29 Thread Aditya Sharma
+1. Thank you Mathieu!

Thanks and regards,
Aditya Sharma

On Mon, Sep 30, 2019 at 11:44 AM Pawan Verma 
wrote:

> +1
> --
> Thanks & Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> http://www.hotwaxsystems.com
>
>
> On Mon, Sep 30, 2019 at 10:57 AM Swapnil M Mane 
> wrote:
>
> > +1 Mathieu for documenting these rules/conventions, thank you!
> >
> > Best regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Sun, Sep 29, 2019 at 5:08 PM Mathieu Lirzin <
> mathieu.lir...@nereide.fr>
> > wrote:
> >
> > > Hello,
> > >
> > > Pierre Smits  writes:
> > >
> > > > Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’.
> As
> > > per
> > > > established conventions.
> > >
> > > From what I understood from the examples and common practice [1], this
> > > is only partially true.  Improvement tickets can be associated with
> both
> > > ‘Implemented:’ and ‘Improved:’ commits depending on the type of
> > > improvement:
> > >
> > >- Refactoring => “Improved:”
> > >- New feature => “Implemented:”
> > >
> > > [1]
> > >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> > >
> > > > On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane  >
> > > wrote:
> > > >
> > > >> Hi Deepak,
> > > >>
> > > >> Happy to see your commits in action. :)
> > > >> Just a minor suggestion, we put Jira ticket ID in separate line in
> > > commit
> > > >> log.
> > > >> Also, add colon ':' in Thanks statement.
> > > >> And since the ticket type is 'Improvement', it seems to me, we
> should
> > > use
> > > >> 'Improved' instead of 'Fixed'.
> > > >>
> > > >> Here is commit template for your quick reference
> > > >>
> > > >>
> > >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> > > >>
> > > >> Following commit log template will help us in producing the monthly
> > blog
> > > >> development details.
> > >
> > > As a general rule, I would say that working on a “bug” ticket implies
> at
> > > least one “Fixed:” commit, but it is possible to associate a
> > > complementary refactoring “Improved:” commit to a “bug” ticket.  On the
> > > other hand an “improvement” ticket can not be associated with a
> “Fixed:”
> > > commit.
> > >
> > > What about adding a CONTRIBUTING.adoc file the repository stating those
> > > rules?  This would make things far more visible and explicit than on
> > > Confluence which is not very visible (I often to keep bookmarks to
> > > retrieve some information) and far from the code.
> > >
> > > What do people think?
> > >
> > > --
> > > Mathieu Lirzin
> > > GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> > >
> >
>


Re: Welcome Pranay Pandey as a new PMC member

2019-09-24 Thread Aditya Sharma
Felicitations Pranay !!

Thanks and Regards,
Aditya Sharma

On Wed, Sep 25, 2019 at 10:44 AM Suraj Khurana 
wrote:

> Many Congratulations Pranay !!
>
> --
> Best Regards,
> Suraj Khurana
> Technical Consultant
>
>
>
>
>
> On Wed, Sep 25, 2019 at 10:14 AM Ashish Vijaywargiya <
> ashish.vijaywarg...@hotwaxsystems.com> wrote:
>
> > Many congratulations Pranay!!
> >
> > --
> > Kind Regards,
> > Ashish Vijaywargiya
> > Vice President of Operations
> > *HotWax Systems*
> > *Enterprise open source experts*
> > cell: +91-9893479711
> > http://www.hotwaxsystems.com
> >
> >
> >
> > On Tue, Sep 24, 2019 at 9:07 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > The OFBiz PMC has invited Pranay Pandey to become a new member of the
> > > committee and we are glad to announce that he has accepted the
> > nomination.
> > >
> > > Welcome on board Pranay!
> > >
> > > Jacques (on behalf of the OFBiz PMC)
> > >
> > >
> >
>


Re: Not able to edit pages under OFBiz End-User Documentation

2019-09-14 Thread Aditya Sharma
Thanks Jacques for looking into it. I will raise the Jira.

Thanks and regards,
Aditya Sharma

On Fri, Sep 13, 2019 at 3:08 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Mmm, I can't do that. I can add and modify but not remove an user. And
> it's maybe confusing in your case. We need to ask Infra for that. A Jira
> fits.
>
> There are maybe other cases like your, if I'm not wrong with my
> hypothesis...
>
> Le 13/09/2019 à 11:31, Jacques Le Roux a écrit :
> > Hi Aditya,
> >
> > It seems you are using your ASF username (adityasharma) in Confluence
> which is good.
> >
> > However you were still in the list of contributors there when you are
> now a committer.
> >
> > Maybe you used the same username (adityasharma) previously hence the
> confusion.
> >
> > Anyway I have removed you from this list, please try if it works
> >
> > Thanks
> >
> > Jacques
> >
> > Le 19/08/2019 à 15:05, Aditya Sharma a écrit :
> >> Hi team,
> >>
> >> I am unable to edit pages (no edit button available) under OFBENDUSER[1]
> >> while it works well for pages under OFBIZ[2].
> >> Does that require any specific permissions or am I missing something?
> >>
> >> 1. https://cwiki.apache.org/confluence/display/OFBENDUSER/
> >> 2. https://cwiki.apache.org/confluence/display/OFBIZ
> >>
> >> Thanks and regards,
> >> Aditya Sharma
> >>
> >
>


Re: [VOTE] [RELEASE] Apache OFBiz 16.11.06 - second attempt

2019-08-28 Thread Aditya Sharma
+1

--
Thanks and Regards,
Aditya Sharma

On Thu, Aug 29, 2019 at 10:52 AM Suraj Khurana  wrote:

> +1
>
> --
> Best Regards,
> Suraj Khurana
> Technical Consultant
>
>
>
>
>
>
>
> On Wed, Aug 28, 2019 at 1:20 PM Nicolas Malin 
> wrote:
>
> > same here
> >
> > +1
> >
> > On 8/28/19 9:25 AM, Swapnil M Mane wrote:
> > > +1, thank you Jacopo!
> > >
> > > Everything seems good -
> > >
> > > 1. Checksums and signing certificate
> > > $  ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-16.11.06.zip
> > > sha check of file: apache-ofbiz-16.11.06.zip
> > > Using sha file: apache-ofbiz-16.11.06.zip.sha512
> > > apache-ofbiz-16.11.06.zip: 407F03CF C0A60B0F 363E83FC 55C0D301 DDF323DC
> > > 016B2C96 CA624791 046E8367 AE629A38 F4CE597F AE1E1F2E C504E895 D22E6C6A
> > > 4FA2E958 30F1EB3F 62A81E01
> > > apache-ofbiz-16.11.06.zip: 407F03CF C0A60B0F 363E83FC 55C0D301 DDF323DC
> > > 016B2C96 CA624791 046E8367 AE629A38 F4CE597F AE1E1F2E C504E895 D22E6C6A
> > > 4FA2E958 30F1EB3F 62A81E01
> > > sha checksum OK
> > >
> > > GPG verification output
> > > gpg: Signature made Tue Aug 27 15:05:16 2019 IST
> > > gpg:using RSA key 7A580908847AF9E0
> > > gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <
> > > jaco...@apache.org>"
> > >
> > > 2. Initializing gradle wrapper, build, and tests are successful, the
> > steps
> > > followed are as follows (using macOS Mojave OS) -
> > > -- Unzip apache-ofbiz-16.11.06.zip
> > > -- Executed the ./gradle/init-gradle-wrapper cmd
> > > -- Executed load and test command
> > > $ ./gradlew loadDefault testIntegration
> > > BUILD SUCCESSFUL
> > >
> > >
> > > Best regards,
> > > Swapnil M Mane,
> > > ofbiz.apache.org
> > >
> > >
> > >
> > > On Tue, Aug 27, 2019 at 3:18 PM Jacopo Cappellato <
> > > jacopo.cappell...@gmail.com> wrote:
> > >
> > >> This is the second vote thread to release a new bug fix release for
> the
> > >> release16.11 branch.
> > >> This new release, "Apache OFBiz 16.11.06" will supersede all the
> > previous
> > >> releases from the same branch.
> > >> The release files can be downloaded from here:
> > >>
> > >> https://dist.apache.org/repos/dist/dev/ofbiz/
> > >>
> > >> and are:
> > >>
> > >> * apache-ofbiz-16.11.06.zip
> > >> * KEYS: text file with keys
> > >> * apache-ofbiz-16.11.06.zip.asc: the detached signature file
> > >> * apache-ofbiz-16.11.06.zip.sha512: checksum file
> > >>
> > >> Please download and test the zip file and its signatures (for
> > instructions
> > >> on testing the signatures see
> > http://www.apache.org/info/verification.html
> > >> ).
> > >>
> > >> The preview of the Release Notes can be found at:
> > >> https://ofbiz.apache.org/release-notes-16.11.06.html
> > >>
> > >> Vote:
> > >> [ +1] release as Apache OFBiz 16.11.06
> > >> [ -1] do not release
> > >>
> > >> In order to provide enough time to discuss and test the candidate
> files,
> > >> this vote will be open for at least 10 days.
> > >>
> > >> For more details about this process please read
> > >> http://www.apache.org/foundation/voting.html
> > >>
> > >> Best Regards,
> > >> Jacopo Cappellato
> > >>
> >
>


Not able to edit pages under OFBiz End-User Documentation

2019-08-19 Thread Aditya Sharma
Hi team,

I am unable to edit pages (no edit button available) under OFBENDUSER[1]
while it works well for pages under OFBIZ[2].
Does that require any specific permissions or am I missing something?

1. https://cwiki.apache.org/confluence/display/OFBENDUSER/
2. https://cwiki.apache.org/confluence/display/OFBIZ

Thanks and regards,
Aditya Sharma


Re: svn commit: r1863965 - /ofbiz/ofbiz-framework/trunk/applications/order/template/order/FindOrders.ftl

2019-08-01 Thread Aditya Sharma
Hi Jacques,

It seems ticket ID (OFBIZ-6) is missing in commit message :-)

Thanks and Regards,
Aditya Sharma

On Mon, Jul 29, 2019 at 11:38 PM  wrote:

> Author: jleroux
> Date: Mon Jul 29 18:08:45 2019
> New Revision: 1863965
>
> URL: http://svn.apache.org/viewvc?rev=1863965&view=rev
> Log:
> Improved: Improper alignment of Status, OrderDate and PartyId column
> header on
> Find Orders page
> (OFBIZ-)
>
> Steps to regenerate:
>
> 1. Go to the order component (ordermgr/control/main)
> 2. Click on Find Orders submenu (ordermgr/control/findorders)
> 3. Click on Find button.
> 4. Last 3 column headers of the table are not aligned properly.
>
> Thanks: Humera Khan for report and Ashish Kumar Pandey for the fix
>
> Modified:
>
> ofbiz/ofbiz-framework/trunk/applications/order/template/order/FindOrders.ftl
>
> Modified:
> ofbiz/ofbiz-framework/trunk/applications/order/template/order/FindOrders.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/template/order/FindOrders.ftl?rev=1863965&r1=1863964&r2=1863965&view=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/applications/order/template/order/FindOrders.ftl
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/applications/order/template/order/FindOrders.ftl
> Mon Jul 29 18:08:45 2019
> @@ -544,22 +544,22 @@ document.lookuporder.orderId.focus();
>${uiLabelMap.OrderOrderId}
>${uiLabelMap.OrderOrderName}
>${uiLabelMap.PartyName}
> -  ${uiLabelMap.OrderSurvey}
> -  ${uiLabelMap.OrderItemsOrdered}
> -  ${uiLabelMap.OrderItemsBackOrdered}
> -  ${uiLabelMap.OrderItemsReturned}
> -  ${uiLabelMap.OrderRemainingSubTotal}
> -  ${uiLabelMap.OrderOrderTotal}
> +  ${uiLabelMap.OrderSurvey}
> +  ${uiLabelMap.OrderItemsOrdered}
> +  ${uiLabelMap.OrderItemsBackOrdered}
> +  ${uiLabelMap.OrderItemsReturned}
> +  ${uiLabelMap.OrderRemainingSubTotal}
> +  ${uiLabelMap.OrderOrderTotal}
> +
>  <#if ("Y" ==
> requestParameters.filterInventoryProblems?default("N")) || ("Y" ==
> requestParameters.filterPOsOpenPastTheirETA?default("N")) || ("Y" ==
> requestParameters.filterPOsWithRejectedItems?default("N")) || ("Y" ==
> requestParameters.filterPartiallyReceivedPOs?default("N"))>
>${uiLabelMap.CommonStatus}
>${uiLabelMap.CommonFilter}
>  <#else>
> +  
>${uiLabelMap.CommonStatus}
>  
>${uiLabelMap.OrderDate}
>${uiLabelMap.PartyPartyId}
> -  
> -  
>  
>  <#if orderList?has_content>
><#assign alt_row = false>
>
>
>


Re: [DISCUSSION] Remove the "Resolved" resolution type from Jira workflow

2019-07-23 Thread Aditya Sharma
+1

Thanks and Regards,
Aditya Sharma

On Tue, Jul 23, 2019 at 12:11 PM Pawan Verma 
wrote:

> +1,
>
> "Resolved" Seems unused to me also.
> --
> Thanks & Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> http://www.hotwaxsystems.com
>
>
> On Mon, Jul 22, 2019 at 1:25 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi,
> >
> > After a short discussion with Mathieu at OFBIZ-11140, we both suggest
> that
> > we remove the "Resolved" resolution type from Jira workflow.
> >
> > If nobody disagree I'll do so in a week
> >
> > Jacques
> >
> >
>


Re: weird behavior in reply lately

2019-07-18 Thread Aditya Sharma
Here is the Jira: https://issues.apache.org/jira/browse/INFRA-18768

Thanks and regards,
Aditya Sharma

On Wed, Jul 17, 2019 at 5:39 PM Aditya Sharma 
wrote:

> I went through the post shared by Mathieu, Jacques along with this post[1]
> that shows both the sides vividly and it all makes sense.
> Different people may have different preferences for it but we have to
> choose what favors the community.
> I can see many instances on lists where users replied to the personal
> email and we cannot really restrict anyone to use reply or reply-all.
> I will create a Jira at infra so that previous arrangement is restored.
>
> 1. https://www.gnu.org/software/mailman/mailman-admin/node11.html
>
> Thanks and regards,
> Aditya Sharma
>
> On Sun, Jun 30, 2019 at 8:23 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> Le 30/06/2019 à 16:08, Mathieu Lirzin a écrit :
>> > Hello Jacques
>> >
>> > Jacques Le Roux  writes:
>> >
>> >> The question is should we vote?
>> >>
>> >> So far it all depends on me and my -0.2 added to Paul's -0.8 after
>> >> Mathieu convinced me that it would be better do to otherwise.
>> >>
>> >> If Mathieu does not want to use his veto, I'll not apply mine. It was
>> >> like that for years and it seems everybody was happy, including
>> >> Mathieu, Paul and I, we never complained.
>> > I am not familiar with Apache voting policies, However according to [1]
>> > it seems that people are not expected to use their veto for procedural
>> > issues.
>> >
>> > Most people in this conversation have already expressed their opinion in
>> > favour of the ‘reply-to’ munging and have not been convinced by my
>> > arguments, so I don't think we need to formally vote.
>> >
>> > [1] https://www.apache.org/foundation/voting.html
>>
>> That's simpler indeed. We could argue that it's code and a vote could be
>> done. But it's not OFBiz code so I I guess it would be far fetched and most
>> would not agree.
>>
>> Anyway, I'll continue to use Reply-to-list, and we will not receive
>> unwanted copies, it's OK with me.
>>
>> Jacques
>>
>>


Re: weird behavior in reply lately

2019-07-17 Thread Aditya Sharma
I went through the post shared by Mathieu, Jacques along with this post[1]
that shows both the sides vividly and it all makes sense.
Different people may have different preferences for it but we have to
choose what favors the community.
I can see many instances on lists where users replied to the personal email
and we cannot really restrict anyone to use reply or reply-all.
I will create a Jira at infra so that previous arrangement is restored.

1. https://www.gnu.org/software/mailman/mailman-admin/node11.html

Thanks and regards,
Aditya Sharma

On Sun, Jun 30, 2019 at 8:23 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 30/06/2019 à 16:08, Mathieu Lirzin a écrit :
> > Hello Jacques
> >
> > Jacques Le Roux  writes:
> >
> >> The question is should we vote?
> >>
> >> So far it all depends on me and my -0.2 added to Paul's -0.8 after
> >> Mathieu convinced me that it would be better do to otherwise.
> >>
> >> If Mathieu does not want to use his veto, I'll not apply mine. It was
> >> like that for years and it seems everybody was happy, including
> >> Mathieu, Paul and I, we never complained.
> > I am not familiar with Apache voting policies, However according to [1]
> > it seems that people are not expected to use their veto for procedural
> > issues.
> >
> > Most people in this conversation have already expressed their opinion in
> > favour of the ‘reply-to’ munging and have not been convinced by my
> > arguments, so I don't think we need to formally vote.
> >
> > [1] https://www.apache.org/foundation/voting.html
>
> That's simpler indeed. We could argue that it's code and a vote could be
> done. But it's not OFBiz code so I I guess it would be far fetched and most
> would not agree.
>
> Anyway, I'll continue to use Reply-to-list, and we will not receive
> unwanted copies, it's OK with me.
>
> Jacques
>
>


Re: Getting Started with Apache OFBiz Manufacturing in 5 Easy Steps

2019-06-25 Thread Aditya Sharma
Thanks Sharan. It will definitely add a lot of value.

Thanks everyone involved in the effort.

Thanks and regards,
Aditya Sharma

On Tue, Jun 25, 2019 at 2:58 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Sharan, and thanks to All involved in this effort!
>
> Jacques
>
> Le 25/06/2019 à 06:50, Swapnil M Mane a écrit :
> > Thanks so much, Sharan for this valuable contribution, highly
> appreciated!!
> >
> > @Team,
> > We are making slight changes (creating confluence document from PDF,
> > updating the screenshots, etc.) in original PDF document to sync with the
> > latest OFBiz release.
> > Here is the initial version of improved document [1], currently in WIP,
> > will be completed soon.
> > (Thanks to Archana Asthana for participating in the effort of syncing the
> > document with the latest release)
> >
> > [1] https://cwiki.apache.org/confluence/x/Pw3HBg
> >
> >
> > - Best Regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Tue, Jun 25, 2019 at 2:34 AM Sharan Foga  wrote:
> >
> >> Hi All
> >>
> >> I saw a note about the Getting Started with Apache OFBiz Manufacturing &
> >> MRP in 5 Easy Steps tutorial document that I wrote a while ago that is
> >> being added to the wiki as individual pages. The original pdf tutorial
> >> document I contributed included a copyright notice which is probably
> why my
> >> name was included in the title.
> >>
> >> Swapnil has already followed up with me and I am happy to release the
> >> copyright for this tutorial document and fully contribute it back to
> under
> >> ASL v2 so the project so the community is free to use, change or update
> it
> >> as needed.
> >>
> >> Thanks
> >> Sharan
> >>
> >>
>


Re: svn commit: r1861841 - /ofbiz/branches/release16.11/

2019-06-25 Thread Aditya Sharma
Hi Jacques,

See inline

>>Please I don't how you (and I must say some of your colleagues at Hotwax)
do that, but I often (almost always) receive copies of dev mails also
>>addressed directly to me.
>>
>>Could you please investigate why?
>>
>>BTW it seems it's only a Hotwax things.
I think everyone using Gmail (or any mailing client not custom configured
for mailing list) must be facing the same issue. Gmail web client only
offer 3 buttons for the email namely reply, reply-all and forward. We no
more have reply-to header, so using reply we will have personal email,
forward doesn't apply and reply-all adds all the senders and dev list. User
has to manually remove all the personal emails from the To fields.
See these threads, you can see similar behavior frpm other users as well:
1. https://markmail.org/message/lf6bbnq735orsyec
2. https://markmail.org/message/53fmknnj7vfk63ds

>>And sorry no, this is not the answer (to Taher) https://s.apache.org/lS4c.
It seems there is some misunderstanding here. What I intend to say there is
as far as technical aspect is concerned it is due to missing reply to
headers. It is changed now as the previous behavior was reply button was
sending to the mailing list. I shared the link of discussion to get more
insights. My sincere apologies if I misinterpreted it or it was visible
negative in any ways.

>>Please re-read the thread you addressed to Taher, and there Mathieu's,
Paul's and I conclusions. I know it's a lot in articles to read (before our
own
>>conclusions). But it's an important thing... I guess, as a team at
Hotwax, you can handle that :)
I am reading the links shared and some more articles & will revert on that
soon.


Thanks and regards,
Aditya Sharma
Sr. Enterprise Software Engineer
*HotWax Systems*
*Enterprise open source experts*
office: 0731-409-3684
http://www.hotwaxsystems.com




On Tue, Jun 25, 2019 at 12:33 PM Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:

> Hi Jacques,
>
> I think it's not specific to HotWax things :)
> its a default behavior of Gmail
>
> https://theorangerider.wordpress.com/2011/12/13/gmail-google-groups-and-reply-all/
>
> I think adding proper reply-to header will solve this problem.
> Like in commit emails proper reply-to header is set so it's working as
> expected.
>
>
> Kind Regards,
> *Deepak Dixit* | Manager,
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P 452010
> Linkedin: *Deepak Dixit <https://www.linkedin.com/in/dixitdeepak/>*
>
>
>
> On Mon, Jun 24, 2019 at 4:35 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi Suraj, Hotwax team,
> >
> > Please I don't how you (and I must say some of your colleagues at Hotwax)
> > do that, but I often (almost always) receive copies of dev mails also
> > addressed directly to me.
> >
> > Could you please investigate why?
> >
> > BTW it seems it's only a Hotwax things.
> >
> > And sorry no, this is not the answer (to Taher)
> https://s.apache.org/lS4c.
> >
> > Please re-read the thread you addressed to Taher, and there Mathieu's,
> > Paul's and I conclusions. I know it's a lot in articles to read (before
> our
> > own
> > conclusions). But it's an important thing... I guess, as a team at
> Hotwax,
> > you can handle that :)
> >
> > If Hotwax differs in conclusion we need to know it and why.
> >
> > Thanks
> >
> > Jacques
> >
> > Le 24/06/2019 à 09:35, Suraj Khurana a écrit :
> > > Oops, I checked the repo, code exists there, after research I come to
> > know that was committed at rev#1860800, with another commit.
> > >
> > > My bad !! I will revert and take care of it in separate commits.
> > >
> > > Thanks Jacques for pointing this out.
> > > --
> > > Best Regards,
> > > Suraj Khurana
> > > Technical Consultant
> > > HotWax Systems
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Sun, Jun 23, 2019 at 2:39 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com <mailto:jacques.le.r...@les7arts.com>>
> wrote:
> > >
> > > Hi Suraj,
> > >
> > > It seems nothing really happened here, only props changes
> > >
> > > Jacques
> > >
> > > Le 22/06/2019 à 12:38, sur...@apache.org <mailto:sur...@apache.org
> >
> >

Re: weird behavior in reply lately

2019-06-23 Thread Aditya Sharma
Hi Taher,

It's due to missing reply-to headers.

See the mail thread *Reply-to address missing for dev and user mailing
list* : https://markmail.org/message/l6z542dowhpl3t36

Thanks and regards,
Aditya Sharma

On Sun, Jun 23, 2019, 9:10 PM Taher Alkhateeb 
wrote:

> Hi folks,
>
> I'm not sure if something is wrong, but lately I keep replying to
> individuals instead of the mailing list (or sometimes both). Did
> something change in our mailing servers? Or could it be that gmail
> changed its behavior perhaps?
>


Re: Content of the NOTICE file is not apt

2019-06-19 Thread Aditya Sharma
Thanks Jacques :)
Done
Trunk at r1861615
R18.12 at r1861616
R17.12 at r1861617
R16.11 at r1861618

Thanks and regards,
Aditya Sharma

On Tue, Jun 18, 2019 at 2:46 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 18/06/2019 à 10:38, Aditya Sharma a écrit :
> > Hi Team,
> >
> > The line in the NOTICE[1] file:
> >
> > *This product includes software developed by*
> >
> > should be
> >
> > *This product includes software developed at*
> >
> > as per the ASF Source Header and Copyright Notice Policy[2]. Though small
> > but it changes the meaning.
> >
> > Should I create a Jira and fix it?
> >
> >
> > 1. https://svn.apache.org/repos/asf/ofbiz/branches/release16.11/NOTICE
> > 2. https://www.apache.org/legal/src-headers.html#notice
> >
> > Thanks and Regards,
> > Aditya Sharma
>
> Well spoted Aditya,
>
> I'm not sure a Jira is required but the change is for sure
>
> Thanks
>
> Jacques
>
>


Content of the NOTICE file is not apt

2019-06-18 Thread Aditya Sharma
Hi Team,

The line in the NOTICE[1] file:

*This product includes software developed by*

should be

*This product includes software developed at*

as per the ASF Source Header and Copyright Notice Policy[2]. Though small
but it changes the meaning.

Should I create a Jira and fix it?


1. https://svn.apache.org/repos/asf/ofbiz/branches/release16.11/NOTICE
2. https://www.apache.org/legal/src-headers.html#notice

Thanks and Regards,
Aditya Sharma


Re: Reply-to address missing for dev and user mailing list

2019-06-14 Thread Aditya Sharma
>> Answering myself: maybe we can ask infra to add reply-to as in
INFRA-18478 while we discuss a better solution.
+1

>> For instance, I received 2 versions (one to the dev ML, one directly to
me) from (almost?) all people welcoming Pawan and Deepak.
>> As it does not make sense to filter emails sent directly to me, all
those messages (both of them) end in my main inbox folder and I have to put
them manually in OFBiz.
Exactly. This way, we cannot ensure that people will exclude personal email
ids from reply-all and using reply it will always send the email
personally.

The sole purpose of the mailing list is served only when the emails are
sent on the list so reply being its primary action need to point to the
list only.

My 2 cents
Thanks and regards,
Aditya Sharma

On Fri, Jun 14, 2019 at 1:30 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Mathieu, All,
>
> I think it's an important discussion, but I fear there will be a lot of
> bikeshedding too
>
> Le 13/06/2019 à 15:19, Mathieu Lirzin a écrit :
> > Jacques Le Roux  writes:
> >
> >> Le 13/06/2019 à 13:02, Mathieu Lirzin a écrit :
> >> Actually we should never use “Replying all” when replying to an ML.
> >> Else you get these useless and annoying duplicates not filtered, that's
> what I meant.
> > If you have duplicates, then it's a bug in the mailing-list software
> > that should be reported to INFRA.  The right thing would be to not
> > resend an email to user both present in the recipients and subscribed to
> > a list (GNU Mailman is doing that).
>
> By duplicates I mean emails sent to the dev ML and to me directly. That
> depends mostly on sender I guess.
>
> For instance, I received 2 versions (one to the dev ML, one directly to
> me) from (almost?) all people welcoming Pawan and Deepak.
> As it does not make sense to filter emails sent directly to me, all those
> messages (both of them) end in my main inbox folder and I have to put them
> manually in OFBiz.
> I'd prefer to remove the duplicates (the ones sent directly to me) but
> it's too much work.
> So I now have twice the size in this folder. As I keep archives of all
> messages for easier later searches it's a real problem for future (13.8 Go,
> for
> all msgs today)
>
>
> >
> >> We should use "Replied to List" when it exists. It appears for me in
> Thunderbird when fitting.
> >> I hope other email clients and webmails are allowing the same.
> >> I guess for that the reply-to value must be set to dev@ofbiz.apache.org
> and Infra can handle that.
> >> It was working for a very long time and I suddenly these burst of
> duplicates, as Aditya found, don't you?
> > Asking people to use “Reply to list” would be acceptable if we were
> > assuming that everybody participating in the discussion is subscribed to
> > the mailing-list which is only partially true in our case, given our
> > current process which consist of accepting email from non-subscribed
> > users but yelling at them for not not being subscribed.
>
> As a moderator I think we don't chastise enough people sending mails to
> the MLs w/o being subscribed! :D
>
> Joke aside, I understand the "duplicates" issue depends on senders.
> And (it seems?) only people using Thunderbird have the opportunity to have
> a Reply-to-list button, based on List-Post header[1][2] So when they reply
> using Reply-to they send 2 emails.
>
> [1] https://www.ietf.org/rfc/rfc2369.txt
> [2] https://github.com/k9mail/k-9/issues/2588
>
> The ASF uses ezmlm, http://untroubled.org recommends (
> https://untroubled.org/ezmlmmanual/Replying.html)
>
> < function of your mail reader>>
>
> I'm unsure, but it seems to me that I used “Reply-to” for years to send
> back only to the OFBiz MLs, before I had to turn to Reply to List and
> “Reply-to-all” (which fits to me. For me the problem is others senders)
> So I guess then we had the setting "Reply-To: list@host" maybe as (not
> recommended) in[3] and as suggested by Deepak.
>
> [3]
> http://untroubled.org/ezmlm/faq/Setting-Reply_002dTo-list_0040host.html#Setting-Reply_002dTo-list_0040host
>
>
> >>> Please configure your email client to add “Reply-to:
> dev@ofbiz.apache.org”
> >>> in the header of the messages you are sending to that list. That will
> >>> allow other email clients to automatically respect your personnal
> >>> preferences.
>
> You mean that I do it once for a message to a list and then it's OK for
> all further messages to this list?
> I'm not even sure how to do that in Thunderbird :/
> And I want something

Re: Reply-to address missing for dev and user mailing list

2019-06-13 Thread Aditya Sharma
>>It was working for a very long time and I suddenly these burst of
duplicates, as Aditya found, don't you?
Exactly

>> Yes that's it. Who will handle it?
I will raise a Jira at infra if it's fine.

On Thu, Jun 13, 2019 at 5:55 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Matthieu,
>
> Le 13/06/2019 à 14:08, Mathieu Lirzin a écrit :
> > Hello Deepak,
> >
> > Deepak Dixit  writes:
> >
> >> On Thu, Jun 13, 2019 at 4:14 PM Mathieu Lirzin <
> mathieu.lir...@nereide.fr> wrote:
> >>
> >>   Hello Aditya,
> >>
> >>   Aditya Sharma  writes:
> >>
> >>   > We can configure reply-to email address for the mailing list which
> means
> >>   > when the user clicks the reply button, the specified email address
> will be
> >>   > automatically in the *To* field.
> >>
> >>   I know some people here prefer their personal email address to not
> >>   appear in the ‘To’ header when replying to them and the mailing-list
> but
> >>   that's a personnal preference that can/should be defined only by the
> >>   sender of a message not the administrators of a mailing-list. [1]
> >>
> >>   Please configure your email client to add the ‘Reply-to’ header
> >>   accordingly, but let others have different preferences. :-)
> >>
> >> I think if we are doing communication on the mailing list, its good to
> >> have mailing list address in reply-to irrespective personal
> >> preference.  We can ask infra for the same.
> > I will answer to you by using a citation from
> > <http://www.unicom.com/pw/reply-to-harmful.html>
> >
> > --8<---cut here---start->8---
> > Some administrators justify Reply-To munging by saying, "All responses
> > should go directly to the list anyway." This is arrogant. You should
> > allow me to decide exactly how I wish to respond to a message. If I feel
> > a public response is justified, I'll hit the "g" key and tell Elm to do
> > a group-reply. If I believe a private response is more appropriate, I'll
> > use "r" to send one. Please allow me the freedom to decide how to handle
> > a message.
> > --8<---cut here---end--->8---
> >
> > Please read the arguments provided by this short article. I hope it will
> > let you understand the drawbacks of what you are proposing.
> >
> > Thanks.
>
> Then we should ask what Infra was doing before and discuss about it.
> I hope that we will find a consensus and in the process discover why this
> changed recently. I like the way it worked so far
>
> Jacques
>
>


Re: Reply-to address missing for dev and user mailing list

2019-06-13 Thread Aditya Sharma
Sorry for bothering you for that Jacques. Even I like my inbox clean and it
bothers me when any filtered email finds it's way to my inbox. Anyways I
will be more careful further.
But yes we cannot expect everyone using the mailing list making sure to use
the right way (manually removing the personal email ids).

Thanks Deepak for sharing the ticket :)

Thanks and Regards,
Aditya Sharma

On Thu, Jun 13, 2019 at 5:00 PM Deepak Dixit  wrote:

> On Thu, Jun 13, 2019 at 4:14 PM Mathieu Lirzin 
> wrote:
>
> > Hello Aditya,
> >
> > Aditya Sharma  writes:
> >
> > > We can configure reply-to email address for the mailing list which
> means
> > > when the user clicks the reply button, the specified email address will
> > be
> > > automatically in the *To* field.
> >
> > I know some people here prefer their personal email address to not
> > appear in the ‘To’ header when replying to them and the mailing-list but
> > that's a personnal preference that can/should be defined only by the
> > sender of a message not the administrators of a mailing-list. [1]
> >
> > Please configure your email client to add the ‘Reply-to’ header
> > accordingly, but let others have different preferences. :-)
> >
>
> I think if we are doing communication on the mailing list, its good to have
> mailing list address in reply-to irrespective personal preference.
> We can ask infra for the same.
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> >
> > > When you click on the reply button for notifications or commits emails
> it
> > > automatically adds dev@ofbiz.apache.org as *To *field but in case of
> > dev or
> > > user list, the sender's email address is added.
> >
> > If things are properly configured then the ‘reply-to’ is set by
> > ‘svnmailer’ (the program sending commit emails) not the mailing list
> > administrator.
> >
> > > If I am replying to an email sent by you, only your email will be
> > > added to *To* field. Thus more chances of skipping the mailing list.
> > [...]
> > > We will now have to use reply-all every time.
> >
> > Yes, this is how it is supposed to work, you should use "Reply all" when
> > communicating with a group of people.
> >
> > [1] http://www.unicom.com/pw/reply-to-harmful.html
> >
> > --
> > Mathieu Lirzin
> > GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> >
>


Re: Reply-to address missing for dev and user mailing list

2019-06-13 Thread Aditya Sharma
Hi Jacques,

We can configure reply-to email address for the mailing list which means
when the user clicks the reply button, the specified email address will be
automatically in the *To* field.

When you click on the reply button for notifications or commits emails it
automatically adds dev@ofbiz.apache.org as *To *field but in case of dev or
user list, the sender's email address is added. If I am replying to an
email sent by you, only your email will be added to *To* field. Thus more
chances of skipping the mailing list.
You can see reply-to email address using the show details. I have attached
some screenshots.

 Screenshot from 2019-06-13 14-41-14.png
<https://drive.google.com/a/hotwaxsystems.com/file/d/13oRTEZr3825jYMXK8mx4F_He9BhzHy4I/view?usp=drive_web>
 Screenshot from 2019-06-13 14-44-23.png
<https://drive.google.com/a/hotwaxsystems.com/file/d/15OEB-nBQIVkb6RN4E_06da3Pdw1az5fN/view?usp=drive_web>

Earlier it was working fine(It works right see email titled Re:
[DISCUSSION] Having to use parent tickets to group tickets).
 Screenshot from 2019-06-13 15-03-37.png
<https://drive.google.com/a/hotwaxsystems.com/file/d/1AuKUmI3f2ewTlccHUqTmh5mSvH1vx922/view?usp=drive_web>

We will now have to use reply-all every time.


On Thu, Jun 13, 2019 at 2:30 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Aditya,
>
> I don't clearly understand the problem. I can see the thread < support for global "ofbiz-containers.xml">> on both
>
> Markmail https://s.apache.org/H751 (needs Flash)
>
> and
>
> lists.apache.org: https://s.apache.org/X5If
>
> I can also respond to either dev ML, Mathieu or both from the initial
> Mathieu's message (only Michael did so far)
>
> Jacques
>
> Le 13/06/2019 à 07:22, Aditya Sharma a écrit :
> > Hi team,
> > It seems reply-to address configuration is missing for some emails from
> dev
> > and user mailing list (for reference see *Removing support for global
> > "ofbiz-containers.xml"*) while I can still find it on the notifications
> > mailing list.
> > Anyone having any idea about it?
> >
> > Thanks and regards,
> > Aditya Sharma
> >
>


Re: Welcome to Pawan Verma as new committer!

2019-06-12 Thread Aditya Sharma
Welcome aboard!
Felicitations Pawan Verma!

Thanks & Regards
Aditya Sharma

On Thu, Jun 13, 2019 at 11:36 AM Suraj Khurana 
wrote:

> Welcome, Abroad Pawan Verma!!
> Many congratulations to you !!
>
> --
> Thanks & Regards
> Best Regards,
> Suraj Khurana
>
>
>
>
>
>
>
> On Thu, Jun 13, 2019 at 11:34 AM Divesh Dutta <
> divesh.du...@hotwaxsystems.com> wrote:
>
> > Welcome aboard Pawan.
> >
> > Thanks
> > --
> > Divesh Dutta
> >
> >
> >
> >
> > On Thu, Jun 13, 2019 at 11:20 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > The OFBiz PMC has invited Pawan to become a new committer and we are
> > > pleased  to announce that he has accepted.
> > >
> > > Pawan is part of the community for 2 years and has being quite active
> and
> > > proficient, notably these last times with several smart propositions.
> > >
> > > He also helps a lot of Jiras and answers properly on MLs.
> > >
> > > Please join me in welcoming and congratulating Pawan.
> > >
> > > Jacques
> > >
> > >
> >
>


Re: Welcome to Deepak Nigam as new committer!

2019-06-12 Thread Aditya Sharma
Welcome aboard!
Felicitations Deepak Nigam!

Thanks & Regards
Aditya Sharma

On Thu, Jun 13, 2019 at 11:35 AM Suraj Khurana 
wrote:

> Many Congratulations Deepak Nigam !!
> Looking forward to work with you !!
>
> --
> Best Regards,
> Suraj Khurana
> Technical Consultant
>
>
>
>
>
>
> On Thu, Jun 13, 2019 at 11:25 AM Deepak Dixit  wrote:
>
> > Welcome, Abroad Deepak Nigam!!
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > ofbiz.apache.org
> >
> >
> > On Thu, Jun 13, 2019 at 11:20 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> > > The OFBiz PMC has invited Deepak to become a new committer and we are
> > > pleased  to announce that he has accepted.
> > >
> > > Deepak  is part of the community since January 2016 and has proved to
> be
> > > committed since.
> > >
> > > He notably made a great work for OFBIZ-10518 "Inventory (Supply)
> > > Allocation Planning "
> > >
> > > He not only worked in Jira,  but also answered accurately on MLs where
> he
> > > supported our users.
> > >
> > > Please join me in welcoming and congratulating Deepak.
> > >
> > > Jacques
> > >
> > >
> >
>


Reply-to address missing for dev and user mailing list

2019-06-12 Thread Aditya Sharma
Hi team,
It seems reply-to address configuration is missing for some emails from dev
and user mailing list (for reference see *Removing support for global
"ofbiz-containers.xml"*) while I can still find it on the notifications
mailing list.
Anyone having any idea about it?

Thanks and regards,
Aditya Sharma


Re: Releasing 16.11.06 and vulnerable js libs

2019-06-06 Thread Aditya Sharma
Hi Jacques,

I am up for it.

Thanks and Regards
Aditya Sharma

On Thu, Jun 6, 2019, 7:16 PM Jacques Le Roux 
wrote:

> Hi,
>
> The PMC wants to release the 16.11.06 version "soon" (ASAP actually). For
> that some points need to be done.
>
> One notably is OFBIZ-10678 "Check embedded Javascript libs vulnerabilities
> using retire.js"
>
> I had a look today and there are no high vulnerabilities which is good.
>
> There are few medium and low and it would be better to fix them. Notably
> because 16.11.06 will certainly be our last R16 version.
>
> I expect to work on it but I have other important tasks to do before we
> can release (removing Gradle and OFBIZ-10427 come to mind) and all help
> would
> be appreciated
>
> TIA
>
> Jacques
>
>


Re: Improve steps on Mailing Lists page

2019-06-05 Thread Aditya Sharma
Thanks everyone for the inputs, soon I will share the screenshots of the
possible UI after the change.

Deepak, Thanks for sharing the Jira ticket I will continue with the same.

--
Thanks & Regards
Aditya Sharma

On Wed, Jun 5, 2019 at 5:20 PM Swapnil M Mane 
wrote:

> +1, thanks Aditya.
>
>
>
> - Best Regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Wed, Jun 5, 2019 at 10:49 AM Aditya Sharma 
> wrote:
>
> > Hello everyone,
> >
> > The current steps for subscribing on Mailing lists page[1]:
> > 1. Click the button of the mailing list you want to subscribe to
> > 2. On the following page, click the 'Subscribe' button
> > 3. Send the automatically created email from your email client
> > 4. You will receive an email about the mailing list manager program
> (EZMLM)
> > Congratulations! You are now subscribed
> >
> > The issue with current steps is on list page[2] when user clicks
> subscribe
> > button it opens up the email client but it is not necessary that user
> uses
> > any email client. I think we should also add direct steps as available
> for
> > unsubscribing.
> >
> > To subscribe from any of the following lists, please send an empty,
> > subjectless email to mailing list subscribe addresses.
> >
> >-  user-subscr...@ofbiz.apache.org
> >-  dev-subscr...@ofbiz.apache.org
> >-  commits-subscr...@ofbiz.apache.org
> >-  notifications-subscr...@ofbiz.apache.org
> >
> > 1. https://ofbiz.apache.org/mailing-lists.html
> > 2. https://lists.apache.org/list.html?u...@ofbiz.apache.org
> >
> > Thanks and Regards
> > Aditya Sharma
> >
>


Improve steps on Mailing Lists page

2019-06-04 Thread Aditya Sharma
Hello everyone,

The current steps for subscribing on Mailing lists page[1]:
1. Click the button of the mailing list you want to subscribe to
2. On the following page, click the 'Subscribe' button
3. Send the automatically created email from your email client
4. You will receive an email about the mailing list manager program (EZMLM)
Congratulations! You are now subscribed

The issue with current steps is on list page[2] when user clicks subscribe
button it opens up the email client but it is not necessary that user uses
any email client. I think we should also add direct steps as available for
unsubscribing.

To subscribe from any of the following lists, please send an empty,
subjectless email to mailing list subscribe addresses.

   -  user-subscr...@ofbiz.apache.org
   -  dev-subscr...@ofbiz.apache.org
   -  commits-subscr...@ofbiz.apache.org
   -  notifications-subscr...@ofbiz.apache.org

1. https://ofbiz.apache.org/mailing-lists.html
2. https://lists.apache.org/list.html?u...@ofbiz.apache.org

Thanks and Regards
Aditya Sharma


Re: Missing microseconds support in date-time picker

2019-05-27 Thread Aditya Sharma
Indeed. I have already started working on OFBIZ-10782 but if the community
decides we can include that with the current work.

1. https://issues.apache.org/jira/browse/OFBIZ-10782

Thanks and regards,
Aditya Sharma
Enterprise Software Engineer
*HotWax Systems*
*Enterprise open source experts*
office: 0731-409-3684
http://www.hotwaxsystems.com




On Mon, May 27, 2019 at 12:34 PM Deepak Dixit 
wrote:

> I'd like to add support in date-time picker for microseconds, As it's
> possible that data generated at runtime may contain microseconds.
> Removing microsecond from the demo is not a proper solution.
> As per current implementation, we are using Date.parseExact in
> OfbizUtil.js, and Date.parse does not support the microseconds. We can use
> the moment js to format date in the proper format.
>
>
> Kind Regards,
> Deepak Dixit
> DIRECTOR OF PRODUCT ENGINEERING
> mobile: +91 9826754548
> email: deepak.di...@hotwax.co
> *www.hotwax.co <http://www.hotwax.co/>*
>
>
> On Sat, May 25, 2019 at 7:09 PM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Le 25/05/2019 à 14:22, Pawan Verma a écrit :
> > > Hello Devs,
> > >
> > > While working on OFBIZ-11022, I have found that current date-time
> picker
> > > does not have support for microseconds.
> > > In existing demo data for WebSitePathAlias, we have microseconds in it.
> > But
> > > on Edit webSitePathAlias screen date-time picker does not pass
> > microseconds
> > > and due to this system can not find the exact record for update.
> > >
> > > Should we add support in date-time picker for microseconds or remove it
> > > from demo data?
> > >
> > > Suggestions and thoughts are welcome. Thanks!
> >
> > Hi Pawan,
> >
> > I'd be more inclined to remove microseconds from demo data
> >
> > Thanks
> >
> > Jacques
> >
> >
>


Re: OFBiz Statistics in monthly blog entries

2019-05-19 Thread Aditya Sharma
Indeed! Looks Great. Thanks Pierre for your efforts. We will see to it if
we can utilize some information from it.

Thanks and Regards,
*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Aditya Sharma* <https://www.linkedin.com/in/aditya-p-sharma/>



On Mon, May 20, 2019 at 10:30 AM Pritam Kute 
wrote:

> That's cool Pierre. Thanks for your efforts.
>
> Kind Regards,
> --
> Pritam Kute
>
>
> On Sat, May 18, 2019 at 12:37 PM Pierre Smits 
> wrote:
>
> > Hi all,
> >
> > I finally got an OFBiz dashboard working. See
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603
> >
> > Best regards,
> >
> > Pierre Smits
> >
> > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > *Apache Directory <https://directory.apache.org>, PMC Member*
> > Apache Incubator <https://incubator.apache.org>, committer
> > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> > since 2008*
> > Apache Steve <https://steve.apache.org>, committer
> >
> >
> > On Mon, May 6, 2019 at 9:22 AM Aditya Sharma 
> > wrote:
> >
> > > Thank you Suraj for your input!
> > >
> > > Thank you Jacques for sharing the insights.
> > >
> > > Thank you Pierre for your inputs. Initially, we will be adding basic
> > > statistics (just like February 2018 blog) but definitely, we will look
> > into
> > > the possibility of enriching it with more useful information.
> > >
> > > Thank you Sharan for your inputs. We will definitely ensure that it
> > doesn't
> > > get into that direction. Thank you for your efforts in Kibble. Indeed,
> > It's
> > > an amazing tool.
> > >
> > > --
> > > Thanks and Regards,
> > > Aditya Sharma
> > >
> > > On Sun, May 5, 2019 at 4:57 PM Pierre Smits 
> > > wrote:
> > >
> > > > I truly appreciate initiatives like kibble, the various reporter
> > > functions
> > > > and other stuff that work towards showing the health of projects.
> > > > Unfortunately these initiatives still have miles to go towards
> > providing
> > > > more meaning. Showing number of tickets opened and closed is nice,
> but
> > > that
> > > > has been available since the availability of JIRA. Showing the number
> > of
> > > > mails threads started (and or continued) and number of people
> involved
> > is
> > > > also nice.
> > > >
> > > > But what I deem more important are the various engagement factors
> when
> > > > talking about the health of the project, like
> > > >
> > > >- when looking at the number of subscribers per mailing list, how
> is
> > > the
> > > >diversity (meaning how many PMC Members, Committers,
> non-privileged
> > > >contributors and others have subscribed);
> > > >- when looking the threads per mailing list, how is the diversity
> > > among
> > > >the participants - and who are in the top 5/10 of each segment
> > (again
> > > > PMC
> > > >Member, Committers, no-privileged contributors)
> > > >- When looking at tickets and commits, again showing insights per
> > > >diversity segments and interactions between ;
> > > >
> > > >
> > > > I would say all the data is there, yet very much still in silos.
> > > >
> > > > Best regards,
> > > >
> > > > Pierre Smits
> > > >
> > > > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > > > *Apache Directory <https://directory.apache.org>, PMC Member*
> > > > Apache Incubator <https://incubator.apache.org>, committer
> > > > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> > > privileges)
> > > > since 2008*
> > > > Apache Steve <https://steve.apache.org>, committer
> > > >
> > > >
> > > > On Sun, May 5, 2019 at 12:19 PM Jacques Le Roux <
> > > > jacques.le.r...@les7arts.com> wrote:
> > > >
> > > > > Le 05/05/2019 à 11:58, Sharan Foga a écrit :
> > > > > > You can probably see that I'm a little Kibble focussed at the
> > > moment:-)
> > > > > >
> > > > > > Thanks
> > > > > > Sharan
> > > > >
> > > > > Yes I know that Sharan, I also follow Kibble
> > > > >
> > > > > Thanks for your efforts there and elsewhere :)
> > > > >
> > > > > Jacques
> > > > >
> > > > >
> > > >
> > >
> >
>


Re: [jira] [Updated] (OFBIZ-11031) Improve SalesOrderItemFact table

2019-05-16 Thread Aditya Sharma
Hi Pierre,
It seems work is related to Business Intelligence[1] work. Thanks for your
efforts in this direction.

I would suggest that it would be much better if you could have a parent
ticket for all these tasks that define the plan and purpose. It would quite
easy to track the progress if the tickets are grouped together.

1. https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence

On Thu, May 16, 2019 at 4:12 PM Pierre Smits (JIRA)  wrote:

>
>  [
> https://issues.apache.org/jira/browse/OFBIZ-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Pierre Smits updated OFBIZ-11031:
> -
> Labels: Fact SalesOrder SalesOrderItemFact birt dwh  (was: dwh)
>
> > Improve SalesOrderItemFact table
> > 
> >
> > Key: OFBIZ-11031
> > URL: https://issues.apache.org/jira/browse/OFBIZ-11031
> > Project: OFBiz
> >  Issue Type: Improvement
> >  Components: bi
> >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
> >Reporter: Pierre Smits
> >Priority: Major
> >  Labels: Fact, SalesOrder, SalesOrderItemFact, birt, dwh
> >
> > Improve the SalesOrderFactTable to include additional dimensions
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>


  1   2   >