Re: [PHP-DOC] Patch backlog on en

[Chris Wright]

That's great Peter, thanks

Apologies, I should have mentioned that I too had noticed the couple
of issues you mentioned with the first patch, and I will certainly
correct them before (if) I apply it. I have not tested build with it yet
either, so there would be some auditing to do before it could be submitted,
The issue I'm most concerned with at the moment is the content.

Thanks for sorting out the other two, hopefully in the next couple of days
we'll have a clean slate to work with :-)

On 31 August 2013 10:08, Peter Cowburn  wrote:
> Hi Chris,
>
> On 31 August 2013 00:56, Chris Wright  wrote:
>>
>> Hi list
>>
>> Over the last few days I've been pushing to clear out the backlog of
>> patches
>> for review under en and I'm down to 3 remaining:
>>
>> - #911 is pgsql related, a subject on which I'm not particularly well
>> versed.
>>   I'd appreciate it if someone knowledgeable on the subject could review
>>   it and take the appropriate action.
>
>
> Unfortunately, I don't have the availability to review the patch at the
> moment. From a very quick glance (literally, just that) there are a few
> markup issues like wrapping  around multiple words, and the use of
> "you" (which we frown upon).
>
>>
>>
>> The other two were created by users with VCS access as as such I am
>> unable to clear them, if someone with admin karma/generally the ability
>> to do so could handle them I would appreciate it:
>>
>> - #927 - I have spoken to the original author and have been informed that
>>   the patch is invalid. It just needs reverting.
>
>
> I've deleted this patch.
>
>>
>>
>> - #896 - I am still researching the validity of this patch. If anyone can
>> give
>>   it an instant yay/nay that would be good, also Is there anything that
>> can
>>   be done to unlock it so that when I have reached a conclusion I am able
>>   to handle it?
>
>
> I have set you as the file owner so you should be able to make any further
> changes that you want.
>
>>
>>
>> I would like to get the backlog cleared out asap, in an effort to make the
>> "contributions are ready for review" automated emails to the list a bit
>> more
>> useful (i.e. they only get sent out when there's a new patch, rather than
>> the patches that have been hanging around for months).
>>
>> Thanks for any assistance you can offer on this
>
>
> Thank you!
>
>>
>>
>> ---
>>
>> Chris Wright (DaveRandom)
>
>

Re: [PHP-DOC] Patch backlog on en

[Peter Cowburn]

Hi Chris,

On 31 August 2013 00:56, Chris Wright  wrote:

> Hi list
>
> Over the last few days I've been pushing to clear out the backlog of
> patches
> for review under en and I'm down to 3 remaining:
>
> - #911 is pgsql related, a subject on which I'm not particularly well
> versed.
>   I'd appreciate it if someone knowledgeable on the subject could review
>   it and take the appropriate action.
>

Unfortunately, I don't have the availability to review the patch at the
moment. From a very quick glance (literally, just that) there are a few
markup issues like wrapping  around multiple words, and the use
of "you" (which we frown upon).


>
> The other two were created by users with VCS access as as such I am
> unable to clear them, if someone with admin karma/generally the ability
> to do so could handle them I would appreciate it:
>
> - #927 - I have spoken to the original author and have been informed that
>   the patch is invalid. It just needs reverting.
>

I've deleted this patch.


>
> - #896 - I am still researching the validity of this patch. If anyone can
> give
>   it an instant yay/nay that would be good, also Is there anything that can
>   be done to unlock it so that when I have reached a conclusion I am able
>   to handle it?
>

I have set you as the file owner so you should be able to make any further
changes that you want.


>
> I would like to get the backlog cleared out asap, in an effort to make the
> "contributions are ready for review" automated emails to the list a bit
> more
> useful (i.e. they only get sent out when there's a new patch, rather than
> the patches that have been hanging around for months).
>
> Thanks for any assistance you can offer on this
>

Thank you!


>
> ---
>
> Chris Wright (DaveRandom)
>

[PHP-DOC] Patch backlog on en

[Chris Wright]

Hi list

Over the last few days I've been pushing to clear out the backlog of patches
for review under en and I'm down to 3 remaining:

- #911 is pgsql related, a subject on which I'm not particularly well versed.
  I'd appreciate it if someone knowledgeable on the subject could review
  it and take the appropriate action.

The other two were created by users with VCS access as as such I am
unable to clear them, if someone with admin karma/generally the ability
to do so could handle them I would appreciate it:

- #927 - I have spoken to the original author and have been informed that
  the patch is invalid. It just needs reverting.

- #896 - I am still researching the validity of this patch. If anyone can give
  it an instant yay/nay that would be good, also Is there anything that can
  be done to unlock it so that when I have reached a conclusion I am able
  to handle it?

I would like to get the backlog cleared out asap, in an effort to make the
"contributions are ready for review" automated emails to the list a bit more
useful (i.e. they only get sent out when there's a new patch, rather than
the patches that have been hanging around for months).

Thanks for any assistance you can offer on this

---

Chris Wright (DaveRandom)

Re: [PHP-DOC] Patch submission - curl_unescape, curl_strerror, curl_reset, fix for curl_escape

[Adam Kazimierczak]

On 06/14/2013 02:16 PM, Peter Cowburn wrote:

Hi Adam,

On 14 June 2013 10:29, Adam Kazimierczak > wrote:


Try running this code:
var_dump(curl_escape(0, 'test'), curl_unescape(0, 'test'));

Both results are NULL and throws E_WARNINGs:
Warning: curl_escape() expects parameter 1 to be resource, integer
given


This falls under the "garbage in, garbage out" rule that we 
historically don't document. When given incorrect arguments, most PHP 
functions will return NULL and raise a warning. See the note about 
this on http://php.net/functions.internal
That explains everything. At first I thought that NULL can be the result 
of incorrect arguments, but I was not sure. I tested this with 
fseek(0,0) which returned false and that was a thing that had mislead me.


Thank you very much for that information, now everything is clear for me.



NULL as return on failure is also documented in libcurl docs:
http://curl.haxx.se/libcurl/c/curl_escape.html


If you check php-src, you'll see the functions return FALSE when 
cURL's curl_easy_(un)escape() returns null.



Yes, I found it. Next time when I will be unsure, I will check php-src.

As I said, they're minor issues and you look to be getting the hang of 
how things work. I would support giving you commit karma, to be able 
to push these changes to the docs yourself.



Thank you very much.


Cheers,
Adam

Re: [PHP-DOC] Patch submission - curl_unescape, curl_strerror, curl_reset, fix for curl_escape

[Peter Cowburn]

Hi Adam,

On 14 June 2013 10:29, Adam Kazimierczak  wrote:
>
> Try running this code:
> var_dump(curl_escape(0, 'test'), curl_unescape(0, 'test'));
>
> Both results are NULL and throws E_WARNINGs:
> Warning: curl_escape() expects parameter 1 to be resource, integer given
>

This falls under the "garbage in, garbage out" rule that we historically
don't document. When given incorrect arguments, most PHP functions will
return NULL and raise a warning. See the note about this on
http://php.net/functions.internal

NULL as return on failure is also documented in libcurl docs:
> http://curl.haxx.se/libcurl/c/**curl_escape.html
>

If you check php-src, you'll see the functions return FALSE when cURL's
curl_easy_(un)escape() returns null.

As I said, they're minor issues and you look to be getting the hang of how
things work. I would support giving you commit karma, to be able to push
these changes to the docs yourself.

Cheers,
Peter

Re: [PHP-DOC] Patch submission - curl_unescape, curl_strerror, curl_reset, fix for curl_escape

[Adam Kazimierczak]

On 06/14/2013 10:12 AM, Peter Cowburn wrote:

Hi Adam,

On 12 June 2013 22:11, Adam Kazimierczak > wrote:


Hello Mailing List,

I am attaching a few new patches. Please let me know what do you
think about them.


There are a few *minor* issues, but overall they are looking good.

Hi Peter,
Thank you for finding out these things.


curl-reset.xml.patch => typos on line 26 and 41
curl-strerror.xml.patch => See Also, do the (raw)urldecode functions 
need to be there? Were they copied from curl_(un)escape?
Yes, you are right. I am copying s from other pages because I 
don't know the structures yet. I had to miss these two functions after 
updating the XML. I will need to be more careful in the future.



curl-escape.xml.patch => The function returns false on failure
curl-unescape.xml.patch => Again, this returns false on failure


Try running this code:
var_dump(curl_escape(0, 'test'), curl_unescape(0, 'test'));

Both results are NULL and throws E_WARNINGs:
Warning: curl_escape() expects parameter 1 to be resource, integer given

NULL as return on failure is also documented in libcurl docs: 
http://curl.haxx.se/libcurl/c/curl_escape.html

Re: [PHP-DOC] Patch submission - curl_unescape, curl_strerror, curl_reset, fix for curl_escape

[Peter Cowburn]

Hi Adam,

On 12 June 2013 22:11, Adam Kazimierczak  wrote:

> Hello Mailing List,
>
> I am attaching a few new patches. Please let me know what do you think
> about them.
>

There are a few *minor* issues, but overall they are looking good.

curl-reset.xml.patch => typos on line 26 and 41
curl-strerror.xml.patch => See Also, do the (raw)urldecode functions need
to be there? Were they copied from curl_(un)escape?
curl-escape.xml.patch => The function returns false on failure
curl-unescape.xml.patch => Again, this returns false on failure



>
> Cheers,
> Adam
>

Re: [PHP-DOC] Patch submission - curl_escape()

[Philip Olson]

On Jun 11, 2013, at 2:43 PM, Adam Kazimierczak  wrote:

> On 06/11/2013 12:08 AM, Hannes Magnusson wrote:
>> On Mon, Jun 10, 2013 at 1:57 PM, Adam Kazimierczak  
>> wrote:
>>> Hello Mailing List,
>>> 
>>> This is my first contribution for the documentation project. I would ask you
>>> to review my patch and give me some tips for the future.
>>> 
>>> The patch is for curl function curl_escape, located in
>>> /en/reference/curl/functions/.
>>> 
>>> Using an occasion I would to ask a question - in the future should I divide
>>> patches into separate emails or rather put them into a single email?
>> Hah. I see you are already up and running, fantastic!
>> 
>> I've committed your first patch, it looks great and follows all our
>> current guidelines :D
>> 
>> In the future, if you plan on becoming regular contributor I'd say you
>> can just fill out the account request form once you've sent in a
>> handful of other patches. Then you can commit them yourself rather
>> then needing to mail them here.
>> 
>> In the meantime, separate patches for different things (i.e. fixing a
>> bug in the docs vs document new thing), but it can all be in the same
>> mail.
>> 
>> -Hannes
> 
> Thank you for the response and the commit.
> 
> It's great that everything is correct. Soon I will try to submit more patches.

Hello Adam,

The patches look good, please apply for an account and commit them yourself. :)

  http://www.php.net/git-php.php

Regards,
Philip

[PHP-DOC] Patch submission - curl_unescape, curl_strerror, curl_reset, fix for curl_escape

[Adam Kazimierczak]

Hello Mailing List,

I am attaching a few new patches. Please let me know what do you think 
about them.


Cheers,
Adam
Index: en/reference/curl/functions/curl-reset.xml
===
--- en/reference/curl/functions/curl-reset.xml	(revision 330487)
+++ en/reference/curl/functions/curl-reset.xml	(working copy)
@@ -14,11 +14,9 @@
resourcech
   
   
-
+   This function re-initializes all options set on the given cURL handle to the default values.
   
 
-  &warn.undocumented.func;
-
  
 
  
@@ -35,6 +33,54 @@
   
  
 
+ 
+  &reftitle.examples;
+  
+   
+curl_escape example
+
+
+
+   
+  
+ 
+
+ 
+  &reftitle.notes;
+  
+   
+curl_reset also resets the URL given as the curl_init parameter.
+   
+  
+ 
+
+ 
+  &reftitle.seealso;
+  
+   
+curl_setopt
+   
+  
+ 
+
 
 
 

Re: [PHP-DOC] Patch submission - curl_escape()

[Adam Kazimierczak]

On 06/11/2013 12:08 AM, Hannes Magnusson wrote:

On Mon, Jun 10, 2013 at 1:57 PM, Adam Kazimierczak  wrote:

Hello Mailing List,

This is my first contribution for the documentation project. I would ask you
to review my patch and give me some tips for the future.

The patch is for curl function curl_escape, located in
/en/reference/curl/functions/.

Using an occasion I would to ask a question - in the future should I divide
patches into separate emails or rather put them into a single email?

Hah. I see you are already up and running, fantastic!

I've committed your first patch, it looks great and follows all our
current guidelines :D

In the future, if you plan on becoming regular contributor I'd say you
can just fill out the account request form once you've sent in a
handful of other patches. Then you can commit them yourself rather
then needing to mail them here.

In the meantime, separate patches for different things (i.e. fixing a
bug in the docs vs document new thing), but it can all be in the same
mail.

-Hannes


Thank you for the response and the commit.

It's great that everything is correct. Soon I will try to submit more 
patches.


Cheers,
Adam

Re: [PHP-DOC] Patch submission - curl_escape()

[Hannes Magnusson]

On Mon, Jun 10, 2013 at 1:57 PM, Adam Kazimierczak  wrote:
> Hello Mailing List,
>
> This is my first contribution for the documentation project. I would ask you
> to review my patch and give me some tips for the future.
>
> The patch is for curl function curl_escape, located in
> /en/reference/curl/functions/.
>
> Using an occasion I would to ask a question - in the future should I divide
> patches into separate emails or rather put them into a single email?

Hah. I see you are already up and running, fantastic!

I've committed your first patch, it looks great and follows all our
current guidelines :D

In the future, if you plan on becoming regular contributor I'd say you
can just fill out the account request form once you've sent in a
handful of other patches. Then you can commit them yourself rather
then needing to mail them here.

In the meantime, separate patches for different things (i.e. fixing a
bug in the docs vs document new thing), but it can all be in the same
mail.

-Hannes

[PHP-DOC] Patch submission - curl_escape()

[Adam Kazimierczak]

Hello Mailing List,

This is my first contribution for the documentation project. I would ask 
you to review my patch and give me some tips for the future.


The patch is for curl function curl_escape, located in 
/en/reference/curl/functions/.


Using an occasion I would to ask a question - in the future should I 
divide patches into separate emails or rather put them into a single email?


Best regards,
Adam
Index: curl-escape.xml
===
--- curl-escape.xml	(revision 330473)
+++ curl-escape.xml	(working copy)
@@ -15,11 +15,9 @@
stringstr
   
   
-
+   This function URL encodes the given string according to RFC 3986.
   
 
-  &warn.undocumented.func;
-
  
 
  
@@ -30,7 +28,7 @@
 str
 
  
-  
+  The string to be encoded.
  
 

@@ -44,6 +42,49 @@
   
  
 
+ 
+  &reftitle.examples;
+  
+   
+curl_escape example
+
+
+
+   
+  
+ 
+
+ 
+  &reftitle.seealso;
+  
+   
+curl_unescape
+urlencode
+rawurlencode
+RFC 3986
+   
+  
+ 
+
 
 
 

Re: [PHP-DOC] Patch for bringing memcached extension docs up to date.

[Hannes Magnusson]

Okidokei :)

Let me know if you change your mind, or when you'd like to give the
docs another round of pokes. Its usually easier to update things
incrementally rather then in one giant patch :]

-Hannes

On Tue, Jan 8, 2013 at 7:21 PM, David Terei  wrote:
> Thanks. I may do some more work on the memcached docs but that would
> be it as I have a vested interest in the memcached docs. Probably not
> a huge amount of work as my last patch gets them to a decent state.
>
> So commit karma would be nice but i dont know if I'd really be doing
> enough to benefit from it (or you from it).
>
> On 8 January 2013 22:07, Hannes Magnusson  wrote:
>> On Thu, Jan 3, 2013 at 7:47 PM, David Terei  wrote:
>>> Hi,
>>>
>>> Please review the patch below that brings the memcached extension docs
>>> up to date with the functionality in 2.0.0 and later.
>>>
>>> http://davidterei.com/downloads/phpdoc-memcached.patch
>>
>> Nice work!
>>
>> Interested in continuing working on the docs? (read; do you want
>> commit karma?) :)
>>
>> -Hannes

Re: [PHP-DOC] Patch for bringing memcached extension docs up to date.

[David Terei]

Thanks. I may do some more work on the memcached docs but that would
be it as I have a vested interest in the memcached docs. Probably not
a huge amount of work as my last patch gets them to a decent state.

So commit karma would be nice but i dont know if I'd really be doing
enough to benefit from it (or you from it).

On 8 January 2013 22:07, Hannes Magnusson  wrote:
> On Thu, Jan 3, 2013 at 7:47 PM, David Terei  wrote:
>> Hi,
>>
>> Please review the patch below that brings the memcached extension docs
>> up to date with the functionality in 2.0.0 and later.
>>
>> http://davidterei.com/downloads/phpdoc-memcached.patch
>
> Nice work!
>
> Interested in continuing working on the docs? (read; do you want
> commit karma?) :)
>
> -Hannes

Re: [PHP-DOC] Patch for bringing memcached extension docs up to date.

[Hannes Magnusson]

On Thu, Jan 3, 2013 at 7:47 PM, David Terei  wrote:
> Hi,
>
> Please review the patch below that brings the memcached extension docs
> up to date with the functionality in 2.0.0 and later.
>
> http://davidterei.com/downloads/phpdoc-memcached.patch

Nice work!

Interested in continuing working on the docs? (read; do you want
commit karma?) :)

-Hannes

Re: [PHP-DOC] Patch for bringing memcached extension docs up to date.

[Sherif Ramadan]

On Thu, Jan 3, 2013 at 10:47 PM, David Terei  wrote:

> Hi,
>
> Please review the patch below that brings the memcached extension docs
> up to date with the functionality in 2.0.0 and later.
>
> http://davidterei.com/downloads/phpdoc-memcached.patch
>
> Cheers,
> David
>


Looks good to me. If no one that's working on memcached sees any mistakes
I'll patch this on Monday.

Thank you for your contribution and for making the documentation better :)

Re: [PHP-DOC] Patch for MongoBinData

[Hannes Magnusson]

On Tue, Jul 3, 2012 at 8:53 PM, Jeremy Mikola  wrote:
> On Tue, Jul 3, 2012 at 5:06 AM, Hannes Magnusson
>  wrote:
>>
>>
>> Are you planning on contributing more to the docs (i.e. do you need
>> vcs account?) or should we just commit these for you?
>
>
> I'm going to be working quite a bit on the Mongo extension documentation (at
> least), so a VCS account would be great. If you want to hold off on the two
> patches I've submitted, I can commit them myself.


Then please read through and fill out http://uk.php.net/git-php.php

-Hannes

Re: [PHP-DOC] Patch for MongoBinData

[Jeremy Mikola]

On Tue, Jul 3, 2012 at 5:06 AM, Hannes Magnusson  wrote:

>
> Are you planning on contributing more to the docs (i.e. do you need
> vcs account?) or should we just commit these for you?
>

I'm going to be working quite a bit on the Mongo extension documentation
(at least), so a VCS account would be great. If you want to hold off on the
two patches I've submitted, I can commit them myself.

-- 
jeremy mikola

Re: [PHP-DOC] Patch for MongoBinData

[Hannes Magnusson]

On Mon, Jul 2, 2012 at 9:40 PM, Jeremy Mikola  wrote:
> https://jira.mongodb.org/browse/PHP-406
>

Looks fine (hard to break anything there with so 'large' patch), and
the MongoCollection::ensureIndex looks fine too.


Are you planning on contributing more to the docs (i.e. do you need
vcs account?) or should we just commit these for you?

-Hannes

[PHP-DOC] Patch for MongoBinData

[Jeremy Mikola]

https://jira.mongodb.org/browse/PHP-406

-- 
jeremy mikola
Index: en/reference/mongo/mongobindata.xml
===
--- en/reference/mongo/mongobindata.xml (revision 326383)
+++ en/reference/mongo/mongobindata.xml (working copy)
@@ -158,7 +158,7 @@
  
  
   MongoBinData::CUSTOM
-  0xf0
+  0x80
   

 User-defined type.

[PHP-DOC] Patch for MongoCollection::ensureIndex()

[Jeremy Mikola]

https://jira.mongodb.org/browse/PHP-393

-- 
jeremy mikola
Index: doc-base/entities/global.ent
===
--- doc-base/entities/global.ent(revision 326383)
+++ doc-base/entities/global.ent(working copy)
@@ -330,6 +330,7 @@
 http://dochub.mongodb.org/core/getlasterror";>
 http://dochub.mongodb.org/core/gridfs";>
 http://dochub.mongodb.org/core/indexes";>
+http://www.mongodb.org/display/DOCS/Building+indexes+with+replica+sets";>
 http://dochub.mongodb.org/core/insert";>
 http://dochub.mongodb.org/core/limit";>
 http://dochub.mongodb.org/core/mapreduce";>
Index: en/reference/mongo/mongocollection/ensureindex.xml
===
--- en/reference/mongo/mongocollection/ensureindex.xml  (revision 326383)
+++ en/reference/mongo/mongocollection/ensureindex.xml  (working copy)
@@ -80,11 +80,20 @@
   "background"
  
  
-  If you are using MongoDB version 1.3.2+, you can create indexes in 
the
-  background while other operations are taking place.  By default, 
index
-  creation happens synchronously.  If you specify &true; with this 
-  option, index creation will be asynchronous.
+  By default, index creation is a blocking operation and will stop 
other
+  operations on the database from proceeding until completed. If you
+  specify &true; for this option, the index will be created in the
+  background while other operations are taking place.
  
+ 
+  
+   Prior to MongoDB 2.1.0, the index build operation is not a 
background
+   build when it replicates to secondaries, irrespective of this 
option.
+   See
+   Building Indexes 
with Replica Sets
+   for more information.
+  
+ 
 
 
  

[PHP-DOC] Patch files: isCopyrighted and isProtectionEnabled

[Jesús Ruiz García]

Hello and thanks for reading this message.

I created two patch files, because I think there information incorrect on
the label  in the files:
isCopyrighted and isProtectionEnabled, in the directory reference/ktaglib/
audioproperties.

Attached the two patch files, if any of you want to review it.

A greeting and thanks.


patch-1332468139.patch
Description: Binary data


patch-1332468164.patch
Description: Binary data

[PHP-DOC] Patch for the broken documentation build (pt_BR translation)

[Klaus Silveira]

Well, the current build of the pt_BR translation is broken. After messing
around, i came up with this small patch to get the build going again. The
build has been broken for weeks now, maybe months. This is terrible for
people who want to contribute, since it looks like the translation is
abandoned. There are also many anonymous commits waiting/begging to be
analyzed.

Can anyone please step up and help? No one answered the last emails in the
pt_BR translation mailing list, so i'm requesting aid from other
translations or the official doc team. Thanks in advance, guys!

-- 
Klaus Silveira
(011) 8564-2492
www.klaussilveira.com
Index: pt_BR/language/oop5.xml
===
--- pt_BR/language/oop5.xml (revision 319071)
+++ pt_BR/language/oop5.xml (working copy)
@@ -40,6 +40,7 @@
   &language.oop5.static;
   &language.oop5.abstract;
   &language.oop5.interfaces;
+  &language.oop5.traits;
   &language.oop5.overloading;
   &language.oop5.iterations;
   &language.oop5.patterns;
@@ -51,6 +52,7 @@
   &language.oop5.late-static-bindings;
   &language.oop5.references;
   &language.oop5.serialization;
+  &language.oop5.changelog;
 
  
 

Re: [PHP-DOC] Patch for __destruct page

[Daniel Convissor]

Hi Folks:

On Mon, Sep 19, 2011 at 03:01:57PM +0200, Nikita Popov wrote:
> I think the "when that object is explicitly destroyed" part should be
> removed altogether. Objects are destroyed if there are no more
> references, not when there are no more references AND you explicitly
> destroy them.

+1.

--Dan

-- 
 T H E   A N A L Y S I S   A N D   S O L U T I O N S   C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
 4015 7th Ave #4, Brooklyn NY 11232  v: 718-854-0335 f: 718-854-0409

Re: [PHP-DOC] Patch for __destruct page

[Nikita Popov]

I think the "when that object is explicitly destroyed" part should be
removed altogether. Objects are destroyed if there are no more
references, not when there are no more references AND you explicitly
destroy them.

Nikita

On Mon, Sep 19, 2011 at 12:50 PM, Hannes Magnusson
 wrote:
> On Sat, Sep 17, 2011 at 00:23, Rob Allen  wrote:
>> Hi,
>>
>> Please find attached a patch for http://uk3.php.net/__destruct to hopefully 
>> make it a little clearer.
>>
>> I tried to use edit.php.net, but it told me that this file had been modified 
>> by "Anonymous #2095", so I couldn't save it there.
>>
>
> Thanks, comitted.
>
> Regarding the error in the OE.. there seem to be some "race
> conditions" when more then one person have opened/modified files
> there.. :]
> I believe yannick is aware of the issue.
>
> -Hannes
>

Re: [PHP-DOC] Patch for __destruct page

[Hannes Magnusson]

On Sat, Sep 17, 2011 at 00:23, Rob Allen  wrote:
> Hi,
>
> Please find attached a patch for http://uk3.php.net/__destruct to hopefully 
> make it a little clearer.
>
> I tried to use edit.php.net, but it told me that this file had been modified 
> by "Anonymous #2095", so I couldn't save it there.
>

Thanks, comitted.

Regarding the error in the OE.. there seem to be some "race
conditions" when more then one person have opened/modified files
there.. :]
I believe yannick is aware of the issue.

-Hannes

[PHP-DOC] Patch for __destruct page

[Rob Allen]

Hi,

Please find attached a patch for http://uk3.php.net/__destruct to hopefully 
make it a little clearer. 

I tried to use edit.php.net, but it told me that this file had been modified by 
"Anonymous #2095", so I couldn't save it there.


In case the attachment doesn't work, the diff text is:

Index: language/oop5/decon.xml
===
--- language/oop5/decon.xml (revision 316864)
+++ language/oop5/decon.xml (working copy)
@@ -94,8 +94,9 @@

 PHP 5 introduces a destructor concept similar to that of other
 object-oriented languages, such as C++. The destructor method will be
-called as soon as all references to a particular object are removed or when
-the object is explicitly destroyed or in any order in shutdown sequence.
+called as soon as there are no other references to a particular object
+when that object is explicitly destroyed, or in any order during the 
+shutdown sequence.


 Destructor Example



Basically, the current text implies that explicitly destroying the object will 
call __destruct() regardless of whether there are any other references to it, 
which is not how it works as unset() will only call __destruct() if there are 
no other references to the object.

Regards,

Rob…

Index: language/oop5/decon.xml
===
--- language/oop5/decon.xml (revision 316864)
+++ language/oop5/decon.xml (working copy)
@@ -94,8 +94,9 @@

 PHP 5 introduces a destructor concept similar to that of other
 object-oriented languages, such as C++. The destructor method will be
-called as soon as all references to a particular object are removed or when
-the object is explicitly destroyed or in any order in shutdown sequence.
+called as soon as there are no other references to a particular object
+when that object is explicitly destroyed, or in any order during the 
+shutdown sequence.


 Destructor Example

Re: [PHP-DOC] Patch to Add AMQP Examples

[Bradley Holt]

On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson  wrote:
>
> On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote:
>
>> Hi,
>>
>> Attached is a patch to add examples to the documentation for
>> AMQPQueue::get and AMQPQueue::ack.
>
>
> Hello Bradley,
>
> Looks good. A few minor issues:
>
>  - Use  for all methods. Sometimes you used .
>   Both work but, well, I did say "minor" issues :)
>  - PHP code indentation should be 4 spaces instead of the XML
>   friendly 1
>

These examples (with the above changes) have been added in r315574.

> Also, your SVN account request has been approved with phpdoc karma
> granted, welcome to the PHP Documentation team! :)
>
> Regards,
> Philip
>
>
>

Re: [PHP-DOC] Patch for AMQP Documentation Errors

[Bradley Holt]

On Thu, Aug 25, 2011 at 10:35 AM, Philip Olson  wrote:
>
> On Aug 24, 2011, at 12:52 PM, Bradley Holt wrote:
>
>> Hi,
>>
>> Attached is a small patch for a couple of errors/omissions in the AMQP
>> documentation. This is my first documentation patch, so please let me
>> know if there's a better procedure I should follow for sending in a
>> patch.
>
>
> Greetings Bradley,
>
> Looks good, and this is the proper procedure. Also, I remember stealing
> from your blog for the AMQP documentation a few weeks ago, so it's great
> to see you fixing the documentation :) If you're interested in committing
> this and future documentation yourself then please have a look here:
>
>  https://wiki.php.net/doc/howto/gettingstarted
>
> Are you interested? :)
>

This patch has been applied in r315571.

Thanks,
Bradley

> Regards,
> Philip
>

Re: [PHP-DOC] Patch to Add AMQP Examples

[Peter Cowburn]

On 26 August 2011 17:05, Bradley Holt  wrote:
> Philip,
>
> On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson  wrote:
>>
>> On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote:
>>
>>> Hi,
>>>
>>> Attached is a patch to add examples to the documentation for
>>> AMQPQueue::get and AMQPQueue::ack.
>>
>>
>> Hello Bradley,
>>
>> Looks good. A few minor issues:
>>
>>  - Use  for all methods. Sometimes you used .
>>   Both work but, well, I did say "minor" issues :)
>>  - PHP code indentation should be 4 spaces instead of the XML
>>   friendly 1
>>
>
> Got it. I was following the examples set elsewhere in AMQP
> documentation. I guess updating those to follow the proper standard is
> another task that could be done :-)

Absolutely. :)

>
>> Also, your SVN account request has been approved with phpdoc karma
>> granted, welcome to the PHP Documentation team! :)
>>
>
> Woo-hoo!
>
> Should I apply these last couple of patches that I've sent in, now
> that I've got commit access?

Yes! That's what the karma is there for.  Any questions just ask, here
or on IRC.  Welcome to the documentation team!

>
> Thanks,
> Bradley
>
>> Regards,
>> Philip
>>
>>
>>
>

Re: [PHP-DOC] Patch to Add AMQP Examples

[Bradley Holt]

Philip,

On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson  wrote:
>
> On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote:
>
>> Hi,
>>
>> Attached is a patch to add examples to the documentation for
>> AMQPQueue::get and AMQPQueue::ack.
>
>
> Hello Bradley,
>
> Looks good. A few minor issues:
>
>  - Use  for all methods. Sometimes you used .
>   Both work but, well, I did say "minor" issues :)
>  - PHP code indentation should be 4 spaces instead of the XML
>   friendly 1
>

Got it. I was following the examples set elsewhere in AMQP
documentation. I guess updating those to follow the proper standard is
another task that could be done :-)

> Also, your SVN account request has been approved with phpdoc karma
> granted, welcome to the PHP Documentation team! :)
>

Woo-hoo!

Should I apply these last couple of patches that I've sent in, now
that I've got commit access?

Thanks,
Bradley

> Regards,
> Philip
>
>
>

Re: [PHP-DOC] Patch to Add AMQP Examples

[Philip Olson]

On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote:

> Hi,
> 
> Attached is a patch to add examples to the documentation for
> AMQPQueue::get and AMQPQueue::ack.


Hello Bradley,

Looks good. A few minor issues:

 - Use  for all methods. Sometimes you used . 
   Both work but, well, I did say "minor" issues :)
 - PHP code indentation should be 4 spaces instead of the XML 
   friendly 1

Also, your SVN account request has been approved with phpdoc karma 
granted, welcome to the PHP Documentation team! :)

Regards,
Philip

Re: [PHP-DOC] Patch to Add AMQP Examples

[Bradley Holt]

On Thu, Aug 25, 2011 at 4:31 PM, Peter Cowburn  wrote:
> Hi Bradley,
>
> On 25 August 2011 19:14, Bradley Holt  wrote:
>> Hi,
>>
>> Attached is a patch to add examples to the documentation for
>> AMQPQueue::get and AMQPQueue::ack.
>
> Would you mind attaching future patches as .txt files? Gmail lets me
> view those in the browser, but requires me to download .patch files
> before viewing them.
>

Will do.

> (And, I thought only .txt files were accepted on the list. But that's
> clearly not the case!)
>
>>
>> Thanks,
>> Bradley
>>
>

Re: [PHP-DOC] Patch to Add AMQP Examples

[Peter Cowburn]

Hi Bradley,

On 25 August 2011 19:14, Bradley Holt  wrote:
> Hi,
>
> Attached is a patch to add examples to the documentation for
> AMQPQueue::get and AMQPQueue::ack.

Would you mind attaching future patches as .txt files? Gmail lets me
view those in the browser, but requires me to download .patch files
before viewing them.

(And, I thought only .txt files were accepted on the list. But that's
clearly not the case!)

>
> Thanks,
> Bradley
>

[PHP-DOC] Patch to Add AMQP Examples

[Bradley Holt]

Hi,

Attached is a patch to add examples to the documentation for
AMQPQueue::get and AMQPQueue::ack.

Thanks,
Bradley


amqp-examples.patch
Description: Binary data

Re: [PHP-DOC] Patch for AMQP Documentation Errors

[Hannes Magnusson]

On Thu, Aug 25, 2011 at 17:12, Bradley Holt  wrote:
> Ferenc,
>
> On Thu, Aug 25, 2011 at 11:04 AM, Ferenc Kovacs  wrote:
>>>
>>> I've read through the wiki page you linked to. I'd love to be able to
>>> commit documentation fixes myself! I've created a wiki account with
>>> the username of "bradley" (not sure if this gets linked to svn
>>> accounts in any way).
>>>
>>
>> the wiki authenticates against the master.php.net first then against
>> it's own user database if needed, so if you have an svn account, you
>> can log in to the wiki with that account, but there are no other
>> connection between the wiki and the master/svn auth database.
>
> Got it. So, how do I get an svn account? :-)

Send more patches, and then fillout php.net/svn-php

-Hannes

Re: [PHP-DOC] Patch for AMQP Documentation Errors

[Bradley Holt]

Ferenc,

On Thu, Aug 25, 2011 at 11:04 AM, Ferenc Kovacs  wrote:
>>
>> I've read through the wiki page you linked to. I'd love to be able to
>> commit documentation fixes myself! I've created a wiki account with
>> the username of "bradley" (not sure if this gets linked to svn
>> accounts in any way).
>>
>
> the wiki authenticates against the master.php.net first then against
> it's own user database if needed, so if you have an svn account, you
> can log in to the wiki with that account, but there are no other
> connection between the wiki and the master/svn auth database.

Got it. So, how do I get an svn account? :-)

> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
>

Re: [PHP-DOC] Patch for AMQP Documentation Errors

[Ferenc Kovacs]

>
> I've read through the wiki page you linked to. I'd love to be able to
> commit documentation fixes myself! I've created a wiki account with
> the username of "bradley" (not sure if this gets linked to svn
> accounts in any way).
>

the wiki authenticates against the master.php.net first then against
it's own user database if needed, so if you have an svn account, you
can log in to the wiki with that account, but there are no other
connection between the wiki and the master/svn auth database.
-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

Re: [PHP-DOC] Patch for AMQP Documentation Errors

[Bradley Holt]

Philip,

On Thu, Aug 25, 2011 at 10:35 AM, Philip Olson  wrote:
>
> On Aug 24, 2011, at 12:52 PM, Bradley Holt wrote:
>
>> Hi,
>>
>> Attached is a small patch for a couple of errors/omissions in the AMQP
>> documentation. This is my first documentation patch, so please let me
>> know if there's a better procedure I should follow for sending in a
>> patch.
>
>
> Greetings Bradley,
>
> Looks good, and this is the proper procedure. Also, I remember stealing
> from your blog for the AMQP documentation a few weeks ago, so it's great
> to see you fixing the documentation :) If you're interested in committing
> this and future documentation yourself then please have a look here:
>
>  https://wiki.php.net/doc/howto/gettingstarted
>
> Are you interested? :)
>

I've read through the wiki page you linked to. I'd love to be able to
commit documentation fixes myself! I've created a wiki account with
the username of "bradley" (not sure if this gets linked to svn
accounts in any way).

Thanks,
Bradley

> Regards,
> Philip
>

Re: [PHP-DOC] Patch for AMQP Documentation Errors

[Philip Olson]

On Aug 24, 2011, at 12:52 PM, Bradley Holt wrote:

> Hi,
> 
> Attached is a small patch for a couple of errors/omissions in the AMQP
> documentation. This is my first documentation patch, so please let me
> know if there's a better procedure I should follow for sending in a
> patch.


Greetings Bradley,

Looks good, and this is the proper procedure. Also, I remember stealing
from your blog for the AMQP documentation a few weeks ago, so it's great
to see you fixing the documentation :) If you're interested in committing
this and future documentation yourself then please have a look here:

 https://wiki.php.net/doc/howto/gettingstarted

Are you interested? :)

Regards,
Philip

[PHP-DOC] Patch for AMQP Documentation Errors

[Bradley Holt]

Hi,

Attached is a small patch for a couple of errors/omissions in the AMQP
documentation. This is my first documentation patch, so please let me
know if there's a better procedure I should follow for sending in a
patch.

Thanks,
Bradley


amqp.patch
Description: Binary data

Re: [PHP-DOC] Patch to PhD for PHPDOC CHM building to use new scheme.

[Richard Quadling]

On 8 January 2011 12:50, Hannes Magnusson  wrote:
> On Wed, Jan 5, 2011 at 15:10, Richard Quadling  wrote:
>> Hi.
>>
>> I've built a CHM file using the new styling.
>>
>
>
> Isn't it a bit early to distribute CHM using the new styles? Its not
> production quality yet, and may even change drastically..
>
> -Hannes
>

It is just an FYI rather than a commit.

-- 
Richard Quadling
Twitter : EE : Zend
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY

Re: [PHP-DOC] Patch to PhD for PHPDOC CHM building to use new scheme.

[Hannes Magnusson]

On Wed, Jan 5, 2011 at 15:10, Richard Quadling  wrote:
> Hi.
>
> I've built a CHM file using the new styling.
>


Isn't it a bit early to distribute CHM using the new styles? Its not
production quality yet, and may even change drastically..

-Hannes

[PHP-DOC] Patch to PhD for PHPDOC CHM building to use new scheme.

[Richard Quadling]

Hi.

I've built a CHM file using the new styling.

It is a bit of a hack as rather than just a single CSS file, 3 are
required and also an additional class attribute.

The css class "docs" is not known in the CHM html files.

I've set that on  and that seems to be good.

It seems IE is making a right pig of the new styling at the moment,
though in the CHM reader, things look quite good.

>From what I can see, alternate row colouring and last column styling
is unsupported by IE in the current form (just using CSS).

Richard.

-- 
Richard Quadling
Twitter : EE : Zend
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY
Index: phpdotnet/phd/Package/PHP/CHM.php
===
--- phpdotnet/phd/Package/PHP/CHM.php   (revision 307074)
+++ phpdotnet/phd/Package/PHP/CHM.php   (working copy)
@@ -238,7 +238,12 @@
 $this->hhcStream = fopen($this->chmdir . "php_manual_{$lang}.hhc", 
"w");
 $this->hhkStream = fopen($this->chmdir . "php_manual_{$lang}.hhk", 
"w");
 
-file_put_contents($this->outputdir . "style.css", 
$this->fetchStylesheet() . PHP_EOL . 'body { padding : 3px;}');
+file_put_contents($this->outputdir . "style.css",
+   $this->fetchStylesheet('reset.css') . PHP_EOL .
+   $this->fetchStylesheet('theme.css') . PHP_EOL .
+   $this->fetchStylesheet('doc.css') . PHP_EOL .
+   'body { padding : 3px;}'
+   );
 
 self::headerChm();
 break;
@@ -391,11 +396,16 @@
 
 public function header($id) {
 $header = parent::header($id);
-// Add CSS link to 
-$pattern = '/(.*)(\r|\n|\r\n|\n\r)(.*)<\/head>/';
-$replacement = '$1  $2$3';
-
-$header = preg_replace($pattern, $replacement, $header);
+
+$patterns = array(
+'/(.*)(\r|\n|\r\n|\n\r)(.*)<\/head>/', // Add CSS link to 
+'/($2$3',
+'$1 class="docs"',
+);
+$header = preg_replace($patterns, $replacements, $header);
 return $header;
 }
 
@@ -412,8 +422,11 @@
 }
 
 protected function fetchStylesheet($name = null) {
-$stylesheet = file_get_contents("http://www.php.net/styles/site.css";);
-if ($stylesheet) return $stylesheet;
+$stylesheet = file_get_contents("http://www.php.net/styles/"; . 
(is_null($name) ? "site.css" : $name));
+if ($stylesheet) {
+v("Loaded $name stylesheet.", VERBOSE_MESSAGES);
+return $stylesheet;
+}
 else {
 v("Stylesheet not fetched. Uses default rendering style.", 
E_USER_WARNING);
 return "";

[PHP-DOC] Patch for fixing empty body messages in RU mailing list

[Alexey Shein]

There is a bug with hiding mail body messages on ru mailing list, like
these ones: http://news.php.net/php.doc.ru/1205,
http://news.php.net/php.doc.ru/1196,
http://news.php.net/php.doc.ru/1198.
So it seems i fixed it, but have no karma to commit it myself, so
here's the patch (quite trivial). Please commit it or give me the
karma so I can commit it myself.

-- 
Regards,
Shein Alexey
Index: article.php
===
--- article.php	(revision 306852)
+++ article.php	(working copy)
@@ -161,7 +161,7 @@
 
 		$line = $linebuf . $line;
 
-		if (substr($line, -2) == "\r\n") {
+		if (substr($line, -1) == "\n") {
 		   $linebuf = '';
 		} else {
 		   $linebuf = $line;

Re: [PHP-DOC] [Patch] - Per Package CLI Options in PhD

[Richard Quadling]

On 25 August 2010 03:42, Moacir de Oliveira
 wrote:
> Hi Daniel,
>
> 2010/8/24 Daniel Convissor 
>>
>> Hi Moacir:
>>
>> On Sat, Aug 21, 2010 at 02:24:40AM -0400, Moacir de Oliveira wrote:
>>
>> > Some options in PhD are specific for rendering the PHP Manual (--notoc,
>> > --lang). These options make no effect if used with the other packages,
>> > so
>> > would be interesting extract them from the core of PhD and implement
>> > these
>> > options within the PHP package.
>> >
>> > Syntax:
>> > $ phd --- 
>>
>> Having generic options and package options is cool.  Naming the options
>> for the package feels a bit clunky.  Some options may not be used in
>> another package now, but could in the future, so it will lead to lots of
>> duplication (--php-foo --pear-foo --etc-foo) and extra typing.
>
> The idea is to use the package options just for really specific options. I
> think that options that could be used for more than one package should be
> written as a core option.
> I agree that typing --php-foo --pear-foo --etc-foo... is painful but I'm not
> sure if is already possible to render more than one package at once, I think
> it only works for formats that exist in all packages passed.
>
> The old options were not changed (so $ phd -d .manual.xml -f xhtml -P PHP
> stills working fine)
>
>>
>> Perhaps leave the option named --foo, but have it only available inside
>> the packages that use it?  When used for a package that doesn't utilize
>> that option, a warning could be issued.
>>
>
> The syntax --- is to prevent duplication, it makes all
> options unique for PhD. Using just --foo is also a possibility, but I think
> it's not so clear for the user to know which package will handle it.
>
> let's discuss it
>
>
> --Moacir de Oliveira
>
>

The PEAR approach for this (via the Console_CommandLine package [1])
is to have "commands"

So something like ...

script.php --generic-option command --command-option sub-command
--sub-command-option

can be fully realized.

When building the command line rules, a subcommand and command
specific options can be attached to any command.

For example, the -h/--help option exists for all commands/subcommands.

script.php --help
script.php command --help
script.php command subcommand --help

each will give appropriate help for the level being used (generic,
command and then subcommand).

Sub-commands and command-options can be used across any number of
"commands" and to any depth.

Obviously, a "package" isn't necessarily a "command" and PhD doesn't
use PEAR (except for CS).

But that's how PEAR handles this.

-- 
Richard Quadling.

[1] http://pear.php.net/package/Console_CommandLine

Re: [PHP-DOC] [Patch] - Per Package CLI Options in PhD

[Moacir de Oliveira]

Hi Daniel,

2010/8/24 Daniel Convissor 

> Hi Moacir:
>
> On Sat, Aug 21, 2010 at 02:24:40AM -0400, Moacir de Oliveira wrote:
>
> > Some options in PhD are specific for rendering the PHP Manual (--notoc,
> > --lang). These options make no effect if used with the other packages, so
> > would be interesting extract them from the core of PhD and implement
> these
> > options within the PHP package.
> >
> > Syntax:
> > $ phd --- 
>
> Having generic options and package options is cool.  Naming the options
> for the package feels a bit clunky.  Some options may not be used in
> another package now, but could in the future, so it will lead to lots of
> duplication (--php-foo --pear-foo --etc-foo) and extra typing.
>

The idea is to use the package options just for really specific options. I
think that options that could be used for more than one package should be
written as a core option.
I agree that typing --php-foo --pear-foo --etc-foo... is painful but I'm not
sure if is already possible to render more than one package at once, I think
it only works for formats that exist in all packages passed.

The old options were not changed (so $ phd -d .manual.xml -f xhtml -P PHP
stills working fine)


>
> Perhaps leave the option named --foo, but have it only available inside
> the packages that use it?  When used for a package that doesn't utilize
> that option, a warning could be issued.
>
>
The syntax --- is to prevent duplication, it makes all
options unique for PhD. Using just --foo is also a possibility, but I think
it's not so clear for the user to know which package will handle it.

let's discuss it


--Moacir de Oliveira

Re: [PHP-DOC] [Patch] - Per Package CLI Options in PhD

[Daniel Convissor]

Hi Moacir:

On Sat, Aug 21, 2010 at 02:24:40AM -0400, Moacir de Oliveira wrote:

> Some options in PhD are specific for rendering the PHP Manual (--notoc,
> --lang). These options make no effect if used with the other packages, so
> would be interesting extract them from the core of PhD and implement these
> options within the PHP package.
> 
> Syntax:
> $ phd --- 

Having generic options and package options is cool.  Naming the options 
for the package feels a bit clunky.  Some options may not be used in 
another package now, but could in the future, so it will lead to lots of 
duplication (--php-foo --pear-foo --etc-foo) and extra typing.

Perhaps leave the option named --foo, but have it only available inside 
the packages that use it?  When used for a package that doesn't utilize 
that option, a warning could be issued.

These are just thoughts.  Take them or leave them.  No big deal.

Thanks,

--Dan

-- 
 T H E   A N A L Y S I S   A N D   S O L U T I O N S   C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
 4015 7th Ave #4, Brooklyn NY 11232  v: 718-854-0335 f: 718-854-0409

Re: [PHP-DOC] [Patch] - Per Package CLI Options in PhD

[Hannes Magnusson]

On Sat, Aug 21, 2010 at 08:24, Moacir de Oliveira
 wrote:
> hey guys,
>
>
> I just wrote a patch that allows the separation of package specific cli
> options from the core of PhD. It's just a first idea so let me know what you

Hah. Awesome. I once had a semi-working patch for it, but have since lost it :P

The Package_Generic_OptionsHandler file is missing from the patch, and
IOptionsHandler doesn't follow the PEAR naming conventions.

Haven't tried out the patch, but it does seem ok.

-Hannes

[PHP-DOC] [Patch] - Per Package CLI Options in PhD

[Moacir de Oliveira]

hey guys,


I just wrote a patch that allows the separation of package specific cli
options from the core of PhD. It's just a first idea so let me know what you
think.

Motivation:
Some options in PhD are specific for rendering the PHP Manual (--notoc,
--lang). These options make no effect if used with the other packages, so
would be interesting extract them from the core of PhD and implement these
options within the PHP package.

Syntax:
$ phd --- 

Examples:
$ phd -d path/to/.manual.xml -P PHP -f php --php-toc=true
$ phd --generic-version
$ phd --ide-help

Limitations:
  - Only long options available
  - getopt() based: so you have to use "--" before the options


Implementation Details:

I divided the BuildOptionsParser class in two other classes OptionsParser
and OptionsHandler. The OptionsHandler class will list the options and the
functions to handle those options. The OptionsParser loads all options (core
and per package) and parse them with getopt().

To add options in a package you have to implement a class (that implements
IOptionsHandler) and register in the factory

class Package_Generic_OptionsHandler implements IOptionsHandler {

public function optionList() {
return array(
'foo:',
'bar::',
);
}

public function option_foo($k, $v) {
//do something
}
...

And then use: phd --generic-foo value --generic-bar=false



--Moacir de Oliveira
Index: render.php
===
--- render.php  (revisão 301979)
+++ render.php  (cópia de trabalho)
@@ -23,7 +23,7 @@
 Config::init(array());
 }
 
-BuildOptionsParser::getopt();
+OptionsParser::getopt();
 
 /* If no docbook file was passed, die */
 if (!is_dir(Config::xml_root()) || !is_file(Config::xml_file())) {
Index: phpdotnet/phd/OptionsHandler.php
===
--- phpdotnet/phd/OptionsHandler.php(revisão 301979)
+++ phpdotnet/phd/OptionsHandler.php(cópia de trabalho)
@@ -2,7 +2,7 @@
 namespace phpdotnet\phd;
 /* $Id$ */
 
-class BuildOptionsParser
+class OptionsHandler implements IOptionsHandler
 {
 public function __construct()
 {
@@ -14,7 +14,7 @@
 }
 }
 
-public function getOptionList()
+public function optionList()
 {
 return array(
 'format:'  => 'f:',// The format to render (xhtml, 
pdf...)
@@ -393,35 +393,6 @@
 exit(0);
 }
 
-public function handlerForOption($opt)
-{
-if (method_exists($this, "option_{$opt}")) {
-return array($this, "option_{$opt}");
-} else {
-return NULL;
-}
-}
-
-public static function getopt()
-{
-$bop = new self;
-$opts = $bop->getOptionList();
-$args = getopt(implode('', array_values($opts)), array_keys($opts));
-if ($args === false) {
-trigger_error("Something happend with getopt(), please report a 
bug", E_USER_ERROR);
-}
-
-foreach ($args as $k => $v) {
-$handler = $bop->handlerForOption($k);
-if (is_callable($handler)) {
-call_user_func($handler, $k, $v);
-} else {
-var_dump($k, $v);
-trigger_error("Hmh, something weird has happend, I don't know 
this option", E_USER_ERROR);
-}
-}
-}
-
 /**
  * Makes a string into a boolean (i.e. on/off, yes/no, ..)
  *
Index: phpdotnet/phd/Format/Factory.php
===
--- phpdotnet/phd/Format/Factory.php(revisão 301979)
+++ phpdotnet/phd/Format/Factory.php(cópia de trabalho)
@@ -5,6 +5,7 @@
 abstract class Format_Factory {
 private $formats = array();
 private $packageName = "";
+private $optionsHandler = null;
 
 public final function getOutputFormats() {
 return array_keys($this->formats);
@@ -14,6 +15,14 @@
 $this->formats = $formats;
 }
 
+public final function getOptionsHandler() {
+return $this->optionsHandler;
+}
+
+public final function registerOptionsHandler(IOptionsHandler 
$optionsHandler) {
+$this->optionsHandler = $optionsHandler;
+}
+
 protected final function setPackageName($name) {
 if (!is_string($name)) {
 throw new \Exception("Package names must be strings..");
Index: phpdotnet/phd/IOptionsHandler.php
===
--- phpdotnet/phd/IOptionsHandler.php   (revisão 0)
+++ phpdotnet/phd/IOptionsHandler.php   (revisão 0)
@@ -0,0 +1,14 @@
+formats);
+parent::registerOptionsHandler(new Package_Generic_OptionsHandler());
 }
 }
 
Index: phpdotnet/phd/OptionsParser.php
===
--- phpdotnet/phd/OptionsParser.php (revisão 0)
+++ phpdotnet/phd/OptionsParser.php (revisão 0)
@@ -0,0 +1,91 @@

Re: [PHP-DOC] [patch] curl_setopt - add example for HTTPHEADER option

[Hannes Magnusson]

On Wed, Apr 21, 2010 at 18:35, Patrick van Staveren
 wrote:
> It's not clearly specified whether to use an array with formatted headers or
> an associative array (ala HttpRequest::addHeaders()) and I figure this is
> worth an example for clarity.
>

Kudos, thanks for the patch.

-Hannes

Re: [PHP-DOC] [patch] curl_setopt option table headings

[Hannes Magnusson]

Has this been committed yet?

-Hannes


On Wed, Apr 21, 2010 at 18:31, Patrick van Staveren
 wrote:
> I've been using this function reference for years, and was surprised to find
> that if I read closely, above each table for the various values to pass in,
> the type of the value is specified.  I'd never read the page closely enough
> to realize that the options are grouped by type; I think it might be common
> for readers to skim like this.
>
> I think it'll be more obvious to the reader if the types are specified as a
> title of each table.
>
> This is my first foray into docbook, so comments on how to achieve this are
> appreciated!
>
> Cheers,
> Patrick
>

Re: [PHP-DOC] [patch] curl_setopt option table headings

[Daniel Egeberg]

On Wed, Apr 21, 2010 at 18:31, Patrick van Staveren
 wrote:
> I've been using this function reference for years, and was surprised to find
> that if I read closely, above each table for the various values to pass in,
> the type of the value is specified.  I'd never read the page closely enough
> to realize that the options are grouped by type; I think it might be common
> for readers to skim like this.
>
> I think it'll be more obvious to the reader if the types are specified as a
> title of each table.
>
> This is my first foray into docbook, so comments on how to achieve this are
> appreciated!

Hi Patrick,

Overall the patch looks good, and it certainly makes the output nicer
and more readable.

On the callback section, however, it would be better if you used
callback, which would link to the documentation on
callbacks [1] rather than trying to describe it in the title. Besides,
your description of a callback doesn't catch all the types of
callbacks someone might use anyway.

[1] http://www.php.net/manual/en/language.pseudo-types.php

-- 
Daniel Egeberg

[PHP-DOC] [patch] curl_setopt - add example for HTTPHEADER option

[Patrick van Staveren]

It's not clearly specified whether to use an array with formatted 
headers or an associative array (ala HttpRequest::addHeaders()) and I 
figure this is worth an example for clarity.


Cheers,
Patrick
Index: reference/curl/functions/curl-setopt.xml
===
--- reference/curl/functions/curl-setopt.xml	(revision 298223)
+++ reference/curl/functions/curl-setopt.xml	(working copy)
@@ -1062,7 +1062,10 @@
   
CURLOPT_HTTPHEADER

-An array of HTTP header fields to set.
+An array of HTTP header fields to set, in the format
+
+ array('Content-type: text/plain', 'Content-length: 100')
+

[PHP-DOC] [patch] curl_setopt option table headings

[Patrick van Staveren]

I've been using this function reference for years, and was surprised to 
find that if I read closely, above each table for the various values to 
pass in, the type of the value is specified.  I'd never read the page 
closely enough to realize that the options are grouped by type; I think 
it might be common for readers to skim like this.


I think it'll be more obvious to the reader if the types are specified 
as a title of each table.


This is my first foray into docbook, so comments on how to achieve this 
are appreciated!


Cheers,
Patrick
Index: reference/curl/functions/curl-setopt.xml
===
--- reference/curl/functions/curl-setopt.xml	(revision 298223)
+++ reference/curl/functions/curl-setopt.xml	(working copy)
@@ -36,12 +36,13 @@
  value
  
   
-   The value to be set on option.
+   The value to be set on option.  The type of
+   value varies based on
+   option as specified in the table below.
   
   
-   value should be a bool for the
-   following values of the option parameter:
-   
+   
+Boolean options
 
  
   
@@ -378,12 +379,11 @@
   
  
 
-   
+   
   
   
-   value should be an integer for the
-   following values of the option parameter:
-   
+   
+Integer parameters
 
  
   
@@ -706,12 +706,11 @@
   
  
 
-   
+   
   
   
-   value should be a string for the
-   following values of the option parameter:
-   
+   
+String parameters
 
  
   
@@ -1034,12 +1033,11 @@
   
  
 
-   
+   
   
   
-   value should be an array for the
-   following values of the option parameter:
-   
+   
+Array parameters
 
  
   
@@ -1087,13 +1085,12 @@
   
  
 
-   
+   
   
   
-   value should be a stream resource (using
-   fopen, for example) for the following values of the
-   option parameter:
-   
+   
+Stream resource options (using fopen, for
+example)
 
  
   
@@ -1130,13 +1127,12 @@
   
  
 
-   
+   
   
   
-   value should be a string that is the name of a valid
-   callback function for the following values of the
-   option parameter:
-   
+   
+Callback function options, which are strings that name a valid
+callback function
 
  
   
@@ -1195,7 +1191,7 @@
   
  
 
-   
+   
   
  
 

Re: [PHP-DOC] Patch PhD - Add links to atom feeds in the PHP format.

[Hannes Magnusson]

On Wed, Dec 16, 2009 at 11:58, Moacir de Oliveira
 wrote:
> 2009/12/15 Hannes Magnusson 
>>
>> On Tue, Dec 15, 2009 at 12:04, Moacir de Oliveira
>>  wrote:
>>
>> > Patch for PhD:
>> > http://pastie.org/743735
>>
>> Remove the count(), if getChildren() will return "true" if there are
>> children, no need to count them.
>>
>> Also, I don't actually know if  applies to > href=""> values, so you may need to specify
>> /full/path/to/lang/feed/id.atom, especially since we define the 
>> long after we print out the s.
>> Otherwise the feed link from http://php.net/strpos for example wont be
>> correct.
>>
>
> Patch fixed:
> http://pastie.org/745439
>
> PHPWeb:
> http://pastie.org/743733

Looks good.
There are couple of issues (I guess we should file bug report about them)
 - Config::language() uses whatever the user passed in as --lang.
   We should be detecting the language from the xml:lang in the XML
   Detecting it ourselves makes it also possible for the indexer to be
multilanguage, and therefore useful for the main phpweb search
 - The language name itself is not necessarily the folder name in
phpweb. I think pt-br for example is the problem maker (pt_BR, pt-br,
pt_Br or however it was).

It doesn't look like the phpweb patch breaks the existing manual (i.e.
built with PhD without the patch), so feel free to commit that (guess
Philip can give you karma if you don't have it already).
The PhD patch can also be committed so we can test it on docs.php.net

-Hannes

Re: [PHP-DOC] Patch PhD - Add links to atom feeds in the PHP format.

[Moacir de Oliveira]

2009/12/15 Hannes Magnusson 

> On Tue, Dec 15, 2009 at 12:04, Moacir de Oliveira
>  wrote:
>
> > Patch for PhD:
> > http://pastie.org/743735
>
> Remove the count(), if getChildren() will return "true" if there are
> children, no need to count them.
>
> Also, I don't actually know if  applies to  href=""> values, so you may need to specify
> /full/path/to/lang/feed/id.atom, especially since we define the 
> long after we print out the s.
> Otherwise the feed link from http://php.net/strpos for example wont be
> correct.
>
>
Patch fixed:
http://pastie.org/745439

PHPWeb:
http://pastie.org/743733


--Moacir de Oliveira

Re: [PHP-DOC] Patch PhD - Add links to atom feeds in the PHP format.

[Hannes Magnusson]

On Tue, Dec 15, 2009 at 12:04, Moacir de Oliveira
 wrote:
> Hey guys,
>
> Some patches to add links to feeds in the PHP format of the PHP Package.
>
> Patch for PhD:
> http://pastie.org/743735

Remove the count(), if getChildren() will return "true" if there are
children, no need to count them.

Also, I don't actually know if  applies to  values, so you may need to specify
/full/path/to/lang/feed/id.atom, especially since we define the 
long after we print out the s.
Otherwise the feed link from http://php.net/strpos for example wont be correct.

> Patch for PHPWeb (Thanks Hannes):
> http://pastie.org/743733


I didn't actually try it.. did you? :)

-Hannes

[PHP-DOC] Patch PhD - Add links to atom feeds in the PHP format.

[Moacir de Oliveira]

Hey guys,

Some patches to add links to feeds in the PHP format of the PHP Package.

Patch for PhD:
http://pastie.org/743735

Patch for PHPWeb (Thanks Hannes):
http://pastie.org/743733


--Moacir de Oliveira

RE: [PHP-DOC] Patch for the Windows Installation docs on php.net

[Ruslan Yakushev]

Ok. I will update the patch as per suggestions below and then try to check in. 
If there are any other corrections or suggestions with regards to the patch or 
the content of the updates - please let me know.

> -Original Message-
> From: Richard Quadling [mailto:rquadl...@googlemail.com]
> Sent: Wednesday, October 14, 2009 12:33 PM
> To: Ruslan Yakushev
> Cc: PHP Documentation ML
> Subject: Re: [PHP-DOC] Patch for the Windows Installation docs on
> php.net
> 
> 2009/10/14 Ruslan Yakushev :
> > Thanks Richard,
> >
> > Do you want me to produce an updated patch, or you can make these
> minor changes yourself before submitting?
> >
> >
> >
> >> -Original Message-
> >> From: Richard Quadling [mailto:rquadl...@googlemail.com]
> >> Sent: Wednesday, October 14, 2009 2:23 AM
> >> To: Ruslan Yakushev
> >> Cc: PHP Documentation ML
> >> Subject: Re: [PHP-DOC] Patch for the Windows Installation docs on
> >> php.net
> >>
> >> 2009/10/13 Ruslan Yakushev :
> >> > Hello phpdoc team,
> >> >
> >> > The first patch for the windows specific docs on php.net is ready.
> >> The patch is available here:
> http://ruslany.net/download/phpdocs.zip.
> >> It contains the following changes:
> >> >
> >> > 1. New article "Microsoft IIS 5.1 and IIS 6.0"
> >> > 2. New article "Microsoft IIS 7.0 and later"
> >> > 3. Updated article "Manual Installation Steps"
> >> > 4. Removed article "Microsoft IIS"
> >> >
> >> > Also the package contains the "screenshots" folder that needs to
> be
> >> placed into the en\install\windows directory before the docs are
> built.
> >> >
> >> > I would appreciate any feedback and suggestions related to the
> >> content of the patch. If the patch looks good - what is the process
> for
> >> submitting the changes?
> >> >
> >> > Thanks,
> >> > Ruslan
> >> >
> >>
> >> Hi.
> >>
> >> A couple of minor things ...
> >>
> >> 1 - BOM is present. Shouldn't be an issue, but is normally not used.
> >>
> >> 2 - For the VIM block at the bottom of the file ...
> >>
> >> sgml-default-dtd-file:"../../manual.ced"
> >>
> >> is now ...
> >>
> >> sgml-default-dtd-file:"~/.phpdoc/manual.ced"
> >>
> >>
> >> 3 - The screenshots folder is called figures for all the other
> >> extensions. As the images are copied to a single location, it may
> not
> >> make any difference, but for consistency ... (I like consistency).
> >>
> >>
> >> 4 - In en/install/windows/index.xml, the line &install.windows.iis;
> >> should be removed.
> >>
> >>
> >>
> >> But, I added the patch to my checkout, edited the index.xml file and
> >> successfully built the CHM file.
> >>
> >>
> >>
> >>
> >> As for submitting it, I can do that, but I'll wait to see if Hannes,
> >> et al has anything additional to say.
> >>
> >>
> >> Regards,
> >>
> >> Richard.
> >> --
> >> -
> >> Richard Quadling
> >> "Standing on the shoulders of some very clever giants!"
> >> EE : http://www.experts-exchange.com/M_248814.html
> >> Zend Certified Engineer :
> >> http://zend.com/zce.php?c=ZEND002498&r=213474731
> >> ZOPA : http://uk.zopa.com/member/RQuadling
> >
> >
> 
> You've got the power!
> 
> --
> -
> Richard Quadling
> "Standing on the shoulders of some very clever giants!"
> EE : http://www.experts-exchange.com/M_248814.html
> Zend Certified Engineer :
> http://zend.com/zce.php?c=ZEND002498&r=213474731
> ZOPA : http://uk.zopa.com/member/RQuadling

Re: [PHP-DOC] Patch for the Windows Installation docs on php.net

[Richard Quadling]

2009/10/14 Ruslan Yakushev :
> Thanks Richard,
>
> Do you want me to produce an updated patch, or you can make these minor 
> changes yourself before submitting?
>
>
>
>> -Original Message-
>> From: Richard Quadling [mailto:rquadl...@googlemail.com]
>> Sent: Wednesday, October 14, 2009 2:23 AM
>> To: Ruslan Yakushev
>> Cc: PHP Documentation ML
>> Subject: Re: [PHP-DOC] Patch for the Windows Installation docs on
>> php.net
>>
>> 2009/10/13 Ruslan Yakushev :
>> > Hello phpdoc team,
>> >
>> > The first patch for the windows specific docs on php.net is ready.
>> The patch is available here: http://ruslany.net/download/phpdocs.zip.
>> It contains the following changes:
>> >
>> > 1. New article "Microsoft IIS 5.1 and IIS 6.0"
>> > 2. New article "Microsoft IIS 7.0 and later"
>> > 3. Updated article "Manual Installation Steps"
>> > 4. Removed article "Microsoft IIS"
>> >
>> > Also the package contains the "screenshots" folder that needs to be
>> placed into the en\install\windows directory before the docs are built.
>> >
>> > I would appreciate any feedback and suggestions related to the
>> content of the patch. If the patch looks good - what is the process for
>> submitting the changes?
>> >
>> > Thanks,
>> > Ruslan
>> >
>>
>> Hi.
>>
>> A couple of minor things ...
>>
>> 1 - BOM is present. Shouldn't be an issue, but is normally not used.
>>
>> 2 - For the VIM block at the bottom of the file ...
>>
>> sgml-default-dtd-file:"../../manual.ced"
>>
>> is now ...
>>
>> sgml-default-dtd-file:"~/.phpdoc/manual.ced"
>>
>>
>> 3 - The screenshots folder is called figures for all the other
>> extensions. As the images are copied to a single location, it may not
>> make any difference, but for consistency ... (I like consistency).
>>
>>
>> 4 - In en/install/windows/index.xml, the line &install.windows.iis;
>> should be removed.
>>
>>
>>
>> But, I added the patch to my checkout, edited the index.xml file and
>> successfully built the CHM file.
>>
>>
>>
>>
>> As for submitting it, I can do that, but I'll wait to see if Hannes,
>> et al has anything additional to say.
>>
>>
>> Regards,
>>
>> Richard.
>> --
>> -
>> Richard Quadling
>> "Standing on the shoulders of some very clever giants!"
>> EE : http://www.experts-exchange.com/M_248814.html
>> Zend Certified Engineer :
>> http://zend.com/zce.php?c=ZEND002498&r=213474731
>> ZOPA : http://uk.zopa.com/member/RQuadling
>
>

You've got the power!

-- 
-
Richard Quadling
"Standing on the shoulders of some very clever giants!"
EE : http://www.experts-exchange.com/M_248814.html
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
ZOPA : http://uk.zopa.com/member/RQuadling

Re: [PHP-DOC] Patch for the Windows Installation docs on php.net

[Philip Olson]

On Oct 14, 2009, at 10:08 AM, Ruslan Yakushev wrote:


Thanks Richard,

Do you want me to produce an updated patch, or you can make these  
minor changes yourself before submitting?


Greetings Ruslan,

Are you interested in committing these and future docs? If so, please  
apply for a SVN account:


 - http://php.net/svn-php

Regards,
Philip

RE: [PHP-DOC] Patch for the Windows Installation docs on php.net

[Ruslan Yakushev]

Thanks Richard,

Do you want me to produce an updated patch, or you can make these minor changes 
yourself before submitting?



> -Original Message-
> From: Richard Quadling [mailto:rquadl...@googlemail.com]
> Sent: Wednesday, October 14, 2009 2:23 AM
> To: Ruslan Yakushev
> Cc: PHP Documentation ML
> Subject: Re: [PHP-DOC] Patch for the Windows Installation docs on
> php.net
> 
> 2009/10/13 Ruslan Yakushev :
> > Hello phpdoc team,
> >
> > The first patch for the windows specific docs on php.net is ready.
> The patch is available here: http://ruslany.net/download/phpdocs.zip.
> It contains the following changes:
> >
> > 1. New article "Microsoft IIS 5.1 and IIS 6.0"
> > 2. New article "Microsoft IIS 7.0 and later"
> > 3. Updated article "Manual Installation Steps"
> > 4. Removed article "Microsoft IIS"
> >
> > Also the package contains the "screenshots" folder that needs to be
> placed into the en\install\windows directory before the docs are built.
> >
> > I would appreciate any feedback and suggestions related to the
> content of the patch. If the patch looks good - what is the process for
> submitting the changes?
> >
> > Thanks,
> > Ruslan
> >
> 
> Hi.
> 
> A couple of minor things ...
> 
> 1 - BOM is present. Shouldn't be an issue, but is normally not used.
> 
> 2 - For the VIM block at the bottom of the file ...
> 
> sgml-default-dtd-file:"../../manual.ced"
> 
> is now ...
> 
> sgml-default-dtd-file:"~/.phpdoc/manual.ced"
> 
> 
> 3 - The screenshots folder is called figures for all the other
> extensions. As the images are copied to a single location, it may not
> make any difference, but for consistency ... (I like consistency).
> 
> 
> 4 - In en/install/windows/index.xml, the line &install.windows.iis;
> should be removed.
> 
> 
> 
> But, I added the patch to my checkout, edited the index.xml file and
> successfully built the CHM file.
> 
> 
> 
> 
> As for submitting it, I can do that, but I'll wait to see if Hannes,
> et al has anything additional to say.
> 
> 
> Regards,
> 
> Richard.
> --
> -
> Richard Quadling
> "Standing on the shoulders of some very clever giants!"
> EE : http://www.experts-exchange.com/M_248814.html
> Zend Certified Engineer :
> http://zend.com/zce.php?c=ZEND002498&r=213474731
> ZOPA : http://uk.zopa.com/member/RQuadling

Re: [PHP-DOC] Patch for the Windows Installation docs on php.net

[Richard Quadling]

2009/10/13 Ruslan Yakushev :
> Hello phpdoc team,
>
> The first patch for the windows specific docs on php.net is ready. The patch 
> is available here: http://ruslany.net/download/phpdocs.zip. It contains the 
> following changes:
>
> 1. New article "Microsoft IIS 5.1 and IIS 6.0"
> 2. New article "Microsoft IIS 7.0 and later"
> 3. Updated article "Manual Installation Steps"
> 4. Removed article "Microsoft IIS"
>
> Also the package contains the "screenshots" folder that needs to be placed 
> into the en\install\windows directory before the docs are built.
>
> I would appreciate any feedback and suggestions related to the content of the 
> patch. If the patch looks good - what is the process for submitting the 
> changes?
>
> Thanks,
> Ruslan
>

Hi.

A couple of minor things ...

1 - BOM is present. Shouldn't be an issue, but is normally not used.

2 - For the VIM block at the bottom of the file ...

sgml-default-dtd-file:"../../manual.ced"

is now ...

sgml-default-dtd-file:"~/.phpdoc/manual.ced"


3 - The screenshots folder is called figures for all the other
extensions. As the images are copied to a single location, it may not
make any difference, but for consistency ... (I like consistency).


4 - In en/install/windows/index.xml, the line &install.windows.iis;
should be removed.



But, I added the patch to my checkout, edited the index.xml file and
successfully built the CHM file.




As for submitting it, I can do that, but I'll wait to see if Hannes,
et al has anything additional to say.


Regards,

Richard.
-- 
-
Richard Quadling
"Standing on the shoulders of some very clever giants!"
EE : http://www.experts-exchange.com/M_248814.html
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
ZOPA : http://uk.zopa.com/member/RQuadling

[PHP-DOC] Patch for the Windows Installation docs on php.net

[Ruslan Yakushev]

Hello phpdoc team,

The first patch for the windows specific docs on php.net is ready. The patch is 
available here: http://ruslany.net/download/phpdocs.zip. It contains the 
following changes:

1. New article "Microsoft IIS 5.1 and IIS 6.0"
2. New article "Microsoft IIS 7.0 and later"
3. Updated article "Manual Installation Steps"
4. Removed article "Microsoft IIS"

Also the package contains the "screenshots" folder that needs to be placed into 
the en\install\windows directory before the docs are built.

I would appreciate any feedback and suggestions related to the content of the 
patch. If the patch looks good - what is the process for submitting the changes?

Thanks,
Ruslan

Re: [PHP-DOC] Patch for the Bug 49743

[Hannes Magnusson]

On Fri, Oct 2, 2009 at 18:42, Moacir de Oliveira
 wrote:
> Patch for the Bug #49743 http://bugs.php.net/bug.php?id=49743
>
> http://pastie.org/639588
>
> This patch modify the structure of the table ids of the Indexer, a new auto
> increment primary key is used instead of the docbook_id, and now the xml:ids
> with multiple sdesc will be stored in the database.

The patch looks good (took a while to read the insert statement though ;)).
But, is there any need for a primary key at all?

Chunks which do not have xml:id, will they continue to work?

Could you write a test case so we dont break this again? :)

-Hannes

Re: [PHP-DOC] PATCH: Apache 2.0 -> 2.2

[Philip Olson]

On Oct 2, 2009, at 8:59 AM, Rich Bowen wrote:

The attached patch modifies the links in the global entities files  
to point to the version of the Apache HTTP Server that the Apache  
Software Foundation recommends - that is, 2.2, rather than 2.0. 2.2  
is a mature product, has been available for three years, and is a  
vastly better product than 2.0. And the docs are much more actively  
maintained, and so are better, more readable, better laid out, and  
have better examples.


Sounds good, as unfortunately the current documentation here is so  
2.0.x specific. Although only changing the links may add a slight  
amount of confusion, it's certainly a step in the right direction and  
committable. Feel free to commit anything you wish. :)


Also, this changes the Apache httpd download link to something more  
useful than the front page of the ASF website, from where folks  
would have to hunt for the actual download page.


Good idea.

Regards,
Philip

[PHP-DOC] PATCH: Installing on Apache 2.x

[Rich Bowen]

Attached is a patch for the document regarding installing on Apache 2.
In addition to some general grammatical changes, all references to 2.0  
are replaced by references to 2.x, since the latest, and recommended,  
version is now 2.2, but the instructions work for 2.0 and 2.2


--
Rich Bowen
rbo...@rcbowen.com




apache2.diff
Description: Binary data

Re: [PHP-DOC] PATCH - Unix Installation doc

[Philip Olson]

On Oct 2, 2009, at 6:55 AM, Rich Bowen wrote:

So, I've been on the list for more than a year now, and so far  
haven't done anything useful. I used the excuse that I didn't have a  
doc build environment set up, but that was, of course, a pretty lame  
excuse. So this morning, bjori removed my last remaining excuse, and  
here's a patch.


Excellent!

It's a pretty trivial one, and more of a shot across the bow to let  
you know that I'm here, and finally planning to start attempting to  
do something useful.


Cool, looking forward to seeing your name all over the doc-cvs mailing  
list. :)


My only concern is that httpd-php-source doesn't seem like part of a  
standard install to me, but since it's already in there this seems  
fine (and is of course an improvement to the current). Likely one day  
it'll be totally rewritten, and developmental/production  
configurations will be separated.


Regards,
Philip

[PHP-DOC] Patch for the Bug 49743

[Moacir de Oliveira]

Patch for the Bug #49743 http://bugs.php.net/bug.php?id=49743

http://pastie.org/639588

This patch modify the structure of the table ids of the Indexer, a new auto
increment primary key is used instead of the docbook_id, and now the xml:ids
with multiple sdesc will be stored in the database.


--Moacir

[PHP-DOC] PATCH: Apache 2.0 -> 2.2

[Rich Bowen]

The attached patch modifies the links in the global entities files to  
point to the version of the Apache HTTP Server that the Apache  
Software Foundation recommends - that is, 2.2, rather than 2.0. 2.2 is  
a mature product, has been available for three years, and is a vastly  
better product than 2.0. And the docs are much more actively  
maintained, and so are better, more readable, better laid out, and  
have better examples.


Also, this changes the Apache httpd download link to something more  
useful than the front page of the ASF website, from where folks would  
have to hunt for the actual download page.



--
Rich Bowen
rbo...@rcbowen.com




2.0-2.2.diff
Description: Binary data

[PHP-DOC] PATCH - Unix Installation doc

[Rich Bowen]

So, I've been on the list for more than a year now, and so far haven't  
done anything useful. I used the excuse that I didn't have a doc build  
environment set up, but that was, of course, a pretty lame excuse. So  
this morning, bjori removed my last remaining excuse, and here's a  
patch.


It's a pretty trivial one, and more of a shot across the bow to let  
you know that I'm here, and finally planning to start attempting to do  
something useful.


--
Rich Bowen
rbo...@rcbowen.com




phps.diff
Description: Binary data

Re: [PHP-DOC] Patch for the bugs #47406 and #48264

[Hannes Magnusson]

On Wed, Sep 16, 2009 at 05:04, Moacir de Oliveira
 wrote:
> Hey guys,
>
> Here a patch for the bugs #47406 and #48264.
> Both bugs are about using an external CSS in the xhtml based formats in PhD,
> so the patch implements the --css option.
>
> comments?

For the Bightml format, I don't think we should  to the stylesheet.
Reading the file and write out the content in a 

[PHP-DOC] Patch for the bugs #47406 and #48264

[Moacir de Oliveira]

Hey guys,

Here a patch for the bugs #47406 and #48264.
Both bugs are about using an external CSS in the xhtml based formats in PhD,
so the patch implements the --css option.

comments?

--Moacir
Index: phpdotnet/phd/Package/Generic/XHTML.php
===
--- phpdotnet/phd/Package/Generic/XHTML.php (revision 288345)
+++ phpdotnet/phd/Package/Generic/XHTML.php (working copy)
@@ -432,6 +432,8 @@
 'dbhtml'=> 'PI_DBHTMLHandler',
 );
 
+protected $stylesheets = array();
+
 public function __construct() {
 parent::__construct();
 $this->registerPIHandlers($this->pihandlers);
@@ -514,6 +516,30 @@
 return $retval;
 }
 
+protected function fetchStylesheet() {
+$stylesDir = $this->getOutputDir();
+if (!$stylesDir) {
+$stylesDir = Config::output_dir();
+}
+$stylesDir .= 'styles/';
+if (file_exists($stylesDir)) {
+if (!is_dir($stylesDir)) {
+v("The styles/ directory is a file?", E_USER_ERROR);
+}
+} else {
+if (!mkdir($stylesDir)) {
+v("Can't create the styles/ directory", E_USER_ERROR);
+}
+}
+foreach ((array)Config::css() as $css) {
+$dest = $stylesDir . basename($css);
+if (@copy($css, $dest)) {
+$this->stylesheets[] = basename($css);
+} else {
+v(sprintf('Impossible to copy the %s file.', $css), 
E_USER_WARNING);
+}
+}
+}
  
 /* Functions format_* */ 
 public function format_suppressed_tags($open, $name, $attrs, $props) {
Index: phpdotnet/phd/Package/Generic/BigXHTML.php
===
--- phpdotnet/phd/Package/Generic/BigXHTML.php  (revision 288345)
+++ phpdotnet/phd/Package/Generic/BigXHTML.php  (working copy)
@@ -36,6 +36,10 @@
 
 public function header() {
 $root = Format::getRootIndex();
+$cssLinks = '';
+foreach ((array)$this->stylesheets as $css) {
+$cssLinks .= "\n";
+}
 return <
@@ -43,6 +47,7 @@
 
 
 {$root["ldesc"]}
+{$cssLinks}
 
 
 HEADER;
@@ -74,9 +79,12 @@
 if ($val) {
 if (!is_resource($this->getFileStream())) {
 $filename = Config::output_dir() . 
strtolower($this->getFormatName()) . '.' . $this->getExt();
+$this->postConstruct();
+if (Config::css()) {
+$this->fetchStylesheet();
+}
 $this->setFileStream(fopen($filename, "w+"));
 fwrite($this->getFileStream(), $this->header());
-$this->postConstruct();
 }
 } 
 break;
Index: phpdotnet/phd/Package/Generic/ChunkedXHTML.php
===
--- phpdotnet/phd/Package/Generic/ChunkedXHTML.php  (revision 288345)
+++ phpdotnet/phd/Package/Generic/ChunkedXHTML.php  (working copy)
@@ -78,6 +78,9 @@
 v("Can't create output directory", E_USER_ERROR);
 }
 }
+if (Config::css()) {
+$this->fetchStylesheet();
+}
 break;
 case Render::VERBOSE:
v("Starting %s rendering", $this->getFormatName(), 
VERBOSE_FORMAT_RENDERING);
@@ -90,6 +93,11 @@
 $lang = Config::language();
 $root = Format::getRootIndex();
 
+$cssLinks = '';
+foreach ((array)$this->stylesheets as $css) {
+$cssLinks .= "\n";
+}
+
 $prev = $next = $parent = array("href" => null, "desc" => null);
 
 if ($parentId = $this->getParent($id)) {
@@ -112,6 +120,7 @@
 
 
 '.(($title != $root["ldesc"]) ? $root["ldesc"].': ' : 
"").$title.'
+'.$cssLinks.'
 
 
 
Index: phpdotnet/phd/Config.php
===
--- phpdotnet/phd/Config.php(revision 288345)
+++ phpdotnet/phd/Config.php(working copy)
@@ -36,6 +36,7 @@
 "package"   => array(
 "Generic",
 ),
+'css'   => array(),
 );
 
 public static function init(array $a) {
Index: phpdotnet/phd/BuildOptionsParser.php
===
--- phpdotnet/phd/BuildOptionsParser.php(revision 288345)
+++ phpdotnet/phd/BuildOptionsParser.php(working copy)
@@ -24,6 +24,7 @@
 "version"  => "V", // Print out version information
 "help" => "h", // Print out help
 "package:" => "P:",// The package of formats   
 
+"css:" => "C:",// External CSS 
 );
 }

Re: [PHP-DOC] Patch for bug 49117

[Hannes Magnusson]

On Tue, Aug 4, 2009 at 12:18, Niel Archer wrote:
> H all,
>
> This patch addresses http://bugs.php.net/bug.php?id=49117 and adds
> details for use of mysqlnd

You had me very confused there for a while, could not possibly
understand how the heck this had any relations to mysqlnd (which it
doesn't, two totally separated issues) :D

Committed, thanks for the patch!

-Hannes

[PHP-DOC] Patch for bug 49117

[Niel Archer]

H all,

This patch addresses http://bugs.php.net/bug.php?id=49117 and adds
details for use of mysqlnd
--
Niel Archer


appendices_migration53.xml.diff.txt
Description: Binary data

Re: [PHP-DOC] Patch bugs #49005 and #49006

[Hannes Magnusson]

On Thu, Jul 23, 2009 at 17:34, Moacir de
Oliveira wrote:
> Patch for the bugs:
>
> http://bugs.php.net/bug.php?id=49006
> http://bugs.php.net/bug.php?id=49005
>

-"initializer" => "");
+"initializer" => "",
+"reference" => false);
 }
Could you end the array with comma, and have the parentheses on its own line?
I.e.

"initializer" => "",
"reference" => false,
);

I don't know the man format, but I assume you have tested this? :)

-Hannes

[PHP-DOC] Patch bugs #49005 and #49006

[Moacir de Oliveira]

Patch for the bugs:

http://bugs.php.net/bug.php?id=49006
http://bugs.php.net/bug.php?id=49005
Index: phpdotnet/phd/Package/Default/Manpage.php
===
--- phpdotnet/phd/Package/Default/Manpage.php   (revision 284228)
+++ phpdotnet/phd/Package/Default/Manpage.php   (working copy)
@@ -100,7 +100,7 @@
 'paramdef'  => 'format_suppressed_tags',
 'parameter' => array(
 /* DEFAULT */  'format_suppressed_tags',
-'methodparam'   => 'format_suppressed_tags',
+'methodparam'   => 'format_parameter_method',
 'code'  => '\\fI',
 ),
 'productname'   => 'format_suppressed_tags',
@@ -303,7 +303,7 @@
 }
 
 public function format_parameter_text($value, $tag) {
-return "\n\\fI$" . $value . "\\fP";
+return "\n\\fI" . ((isset($value[0]) && $value[0] == "$") ? "" : "$") 
. $value . "\\fP";
 }
 
 public function format_parameter_term_text($value, $tag) {
@@ -379,7 +379,8 @@
 "optional" => $opt,
 "type" => "",
 "name" => "",
-"initializer" => "");
+"initializer" => "",
+"reference" => false);
 }
 return "";
 }
@@ -390,7 +391,8 @@
 "optional" => false,
 "type" => "void",
 "name" => "",
-"initializer" => "");
+"initializer" => "",
+"reference" => false);
 }
 return "";
 }
@@ -400,6 +402,13 @@
 return "";
 }
 
+public function format_parameter_method($open, $name, $attrs, $props) {
+if ($open && isset($attrs[Reader::XMLNS_DOCBOOK]["role"]) && 
$attrs[Reader::XMLNS_DOCBOOK]["role"] == "reference") {
+
$this->cchunk['methodsynopsis']['params'][count($this->cchunk['methodsynopsis']['params'])-1]['reference']
 = true;
+}
+return "";
+}
+
 public function format_parameter_method_text($value, $tag) {
 
$this->cchunk['methodsynopsis']['params'][count($this->cchunk['methodsynopsis']['params'])-1]['name']
 = $value;
 return "";
@@ -430,9 +439,14 @@
 return "\n.br";
 $params = array();
 // write the formatted synopsis
-foreach ($this->cchunk['methodsynopsis']['params'] as $parameter)
-array_push( $params, ($parameter['optional'] ? "[" : "") . 
$parameter['type'] .
-($parameter['name'] ? " \\fI$" . $parameter['name'] . "\\fP" : 
"") . ($parameter['initializer'] ? " = " . $parameter['initializer'] : "") . 
($parameter['optional'] ? "]" : "") );
+foreach ($this->cchunk['methodsynopsis']['params'] as $parameter) {
+array_push($params, ($parameter['optional'] ? "[" : "") 
+. $parameter['type'] 
+. ($parameter['reference'] ? " \\fI&\\fP" : " ") 
+. ($parameter['name'] ? "\\fI$" . $parameter['name'] . 
"\\fP" : "") 
+. ($parameter['initializer'] ? " = " . 
$parameter['initializer'] : "") 
+. ($parameter['optional'] ? "]" : "") );
+}
 $ret = "\n(" . join($params, ", ") . ")";
 $this->cchunk['methodsynopsis']['params'] = array();
 

Re: [PHP-DOC] Patch Bug 48953

[Hannes Magnusson]

On Sat, Jul 18, 2009 at 07:42, Moacir de
Oliveira wrote:
> Patch for the bug: http://bugs.php.net/bug.php?id=48953
>
> The method getDescription should return false or ""?

I don't think that matters really...

However, shouldn't we throw some sort of verbosity warning?
(VERBOSE_MISSING_IDREF?)

-Hannes

[PHP-DOC] Patch Bug 48953

[Moacir de Oliveira]

Patch for the bug: http://bugs.php.net/bug.php?id=48953

The method getDescription should return false or ""?

--Moacir
Index: include/PhDHelper.class.php
===
--- include/PhDHelper.class.php (revision 284228)
+++ include/PhDHelper.class.php (working copy)
@@ -73,6 +73,9 @@
 }
 
 final public function getDescription($id, $long = false) {
+if (!isset($this->IDs[$id])) {
+return "";
+}
 return $long ?
 ($this->IDs[$id]["ldesc"] ? $this->IDs[$id]["ldesc"] : 
$this->IDs[$id]["sdesc"]) :
 ($this->IDs[$id]["sdesc"] ? $this->IDs[$id]["sdesc"] : 
$this->IDs[$id]["ldesc"]);
@@ -89,7 +92,7 @@
 */
 final public function getChildren($id)
 {
-return $this->IDs[$id]["children"];
+return isset($this->IDs[$id]) ? $this->IDs[$id]["children"] : array();
 }
 
 /**
@@ -117,7 +120,7 @@
 */
 final public function getParent($id)
 {
-return $this->IDs[$id]["parent"];
+return isset($this->IDs[$id]) ? $this->IDs[$id]["parent"] : false;
 }
 
 /**

Re: [PHP-DOC] Patch for doc-base/README

[Niel Archer]

Forgot to mention, the HOWTO page refereed to in the README
(http://doc.php.net/php/dochowto/) is not available (404 error)

[PHP-DOC] Patch for doc-base/README

[Niel Archer]

Hi

Mostly SVN related. One typo and some white space fixes (spaces/tabs in
blank lines) also.

doc-base_README.diff
Description: Binary data

Re: [PHP-DOC] Patch Review

[Hannes Magnusson]

On Thu, Jul 2, 2009 at 15:31, Moacir de
Oliveira wrote:
> Hi guys,
>
> can you review this patch?
>
> do you think I should use aggregators or just use elseif sections in the
> function SQLiteIndex?

Is there any performance difference?

I think having their own functions is more readable..

-Hannes

[PHP-DOC] Patch Review

[Moacir de Oliveira]

Hi guys,

can you review this patch?

do you think I should use aggregators or just use elseif sections in the
function SQLiteIndex?

thx

--Moacir
Index: Format.php
===
RCS file: /repository/phd/phpdotnet/phd/Format.php,v
retrieving revision 1.4
diff -u -r1.4 Format.php
--- Format.php  22 Jun 2009 01:22:52 -  1.4
+++ Format.php  2 Jul 2009 05:09:49 -
@@ -14,6 +14,10 @@
 protected $indexes = array();
 protected $childrens = array();
 
+protected $refs = array();
+protected $vars = array();
+protected $classes = array();
+
 private static $autogen = array();
 
 /* PhDHelper */
@@ -37,8 +41,14 @@
 public function sortIDs() {
 $this->sqlite->createAggregate("indexes", array($this, "SQLiteIndex"), 
array($this, "SQLiteFinal"), 8);
 $this->sqlite->createAggregate("childrens", array($this, 
"SQLiteChildrens"), array($this, "SQLiteFinal"), 2);
+$this->sqlite->createAggregate("refname", array($this, 
"SQLiteRefname"), array($this, "SQLiteFinal"), 2);
+$this->sqlite->createAggregate("varname", array($this, 
"SQLiteVarname"), array($this, "SQLiteFinal"), 2);
+$this->sqlite->createAggregate("classname", array($this, 
"SQLiteClassname"), array($this, "SQLiteFinal"), 2);
 $this->sqlite->query('SELECT indexes(docbook_id, filename, parent_id, 
sdesc, ldesc, element, previous, next) FROM ids');
 $this->sqlite->query('SELECT childrens(docbook_id, parent_id) FROM 
ids');
+$this->sqlite->query('SELECT refname(docbook_id, sdesc) FROM ids WHERE 
element=\'refentry\'');
+$this->sqlite->query('SELECT varname(docbook_id, sdesc) FROM ids WHERE 
element=\'phpdoc:varentry\'');
+$this->sqlite->query('SELECT classname(docbook_id, sdesc) FROM ids 
WHERE element=\'phpdoc:exceptionref\' OR element=\'phpdoc:classref\'');
 }
 
 public function SQLiteIndex(&$context, $index, $id, $filename, $parent, 
$sdesc, $ldesc, $element, $previous, $next) {
@@ -52,10 +62,6 @@
 "previous"   => $previous,
 "next"   => $next
 );
+/*
+if ($element == "refentry") {
+$ref = strtolower(str_replace(array("_", "::", "->"), array("-", 
"-", "-"), $sdesc));
+$this->refs[$sdesc] = $id;
+} elseif ($element == "phpdoc:varentry") {
+$this->vars[$sdesc] = $id;
+} elseif ($element == "phpdoc:exceptionref" || element == 
"phpdoc:classref") {
+$this->classes[strtolower($sdesc)] = $id;
+}
+*/
 }
 
 public function SQLiteChildrens(&$context, $index, $id, $parent) {
@@ -65,6 +71,19 @@
 $this->childrens[$parent][] = $id;
 }
 
+public function SQLiteRefname(&$context, $index, $id, $sdesc) {
+$ref = strtolower(str_replace(array("_", "::", "->"), array("-", "-", 
"-"), $sdesc));
+$this->refs[$ref] = $id;
+}
+
+public function SQLiteVarname(&$context, $index, $id, $sdesc) {
+$this->vars[$sdesc] = $id;
+}
+
+public function SQLiteClassname(&$context, $index, $id, $sdesc) {
+$this->classes[strtolower($sdesc)] = $id;
+}
+
 public static function SQLiteFinal(&$context) {
 return $context;
 }
@@ -75,6 +94,19 @@
 $format->update($event, $val);
 }
 }
+
+function getRefnameLink($ref) {
+return isset($this->refs[$ref]) ? $this->refs[$ref] : null;
+}
+
+public function getClassnameLink($class) {
+return isset($this->classes[$class]) ? $this->classes[$class] : null;
+}
+
+public function getVarnameLink($var) {
+return isset($this->vars[$var]) ? $this->vars[$var] : null;
+}
+
 final public function registerElementMap(array $map) {
 $this->elementmap = $map;
 }

Re: [PHP-DOC] [Patch] Re: [PHP-DOC] ncurses documentation

[Keito Uchiyama]

Hannes Magnusson wrote:

Awesome work.
One thing I would update: +   Returns 0 on success, -1 if the color
table could not be allocated
(and all similar), use 0, -1..
it makes it more clear that these are actual return values.

-Hannes


Thanks Hannes! I've posted an updated patch with that change, and a few 
more improvements: 


Keito

Re: [PHP-DOC] [Patch] Re: [PHP-DOC] ncurses documentation

[Hannes Magnusson]

On Sun, Apr 5, 2009 at 08:56, Keito Uchiyama  wrote:
> Philip Olson wrote:
>>
>> Nice! :) But please post the patch as an attachment or a link online as it
>> gets altered in email. And if you're planning on documenting more then a CVS
>> account is appropriate:
>>
>>  - http://php.net/cvs-php
>>
>> As for the markup, the only problems I see are whitespace issues because
>> for XML it should be one space indention. It may seem strict but overall it
>> makes for clean source files. And wrapping should be around 72 characters
>> but that number is flexible.
>
> Hi Philip,
>
> Thanks! :) I've posted an updated version of the patch at
> .

Awesome work.
One thing I would update: +   Returns 0 on success, -1 if the color
table could not be allocated
(and all similar), use 0, -1..
it makes it more clear that these are actual return values.

-Hannes

Re: [PHP-DOC] [Patch] Re: [PHP-DOC] ncurses documentation

[Keito Uchiyama]

Philip Olson wrote:
Nice! :) But please post the patch as an attachment or a link online as 
it gets altered in email. And if you're planning on documenting more 
then a CVS account is appropriate:


  - http://php.net/cvs-php

As for the markup, the only problems I see are whitespace issues because 
for XML it should be one space indention. It may seem strict but overall 
it makes for clean source files. And wrapping should be around 72 
characters but that number is flexible.


Hi Philip,

Thanks! :) I've posted an updated version of the patch at 
.


Keito

Re: [PHP-DOC] [Patch] Re: [PHP-DOC] ncurses documentation

[Philip Olson]

> Agreed, and I think it would be well worth it to document this  
extension.


I've gone ahead and documented the color-related functions in the  
ncurses extension, for starters.


Please let me know if there's anything I should fix!


Hello Keito,

Nice! :) But please post the patch as an attachment or a link online  
as it gets altered in email. And if you're planning on documenting  
more then a CVS account is appropriate:


  - http://php.net/cvs-php

As for the markup, the only problems I see are whitespace issues  
because for XML it should be one space indention. It may seem strict  
but overall it makes for clean source files. And wrapping should be  
around 72 characters but that number is flexible.


Regards,
Philip

[PHP-DOC] [Patch] Re: [PHP-DOC] ncurses documentation

[Keito Uchiyama]

Philip Olson wrote:

> Agreed, and I think it would be well worth it to document this extension.


I've gone ahead and documented the color-related functions in the 
ncurses extension, for starters.


Please let me know if there's anything I should fix!

Thanks,

Keito
Index: constants.xml
===
RCS file: /repository/phpdoc/en/reference/ncurses/constants.xml,v
retrieving revision 1.6
diff -u -r1.6 constants.xml
--- constants.xml   26 Jan 2008 14:49:36 -  1.6
+++ constants.xml   5 Apr 2009 04:52:29 -
@@ -6,7 +6,7 @@
  
   Error codes

-On error ncurses functions return NCURSES_ERR.
+On error ncurses functions return -1.

  
   
Index: versions.xml
===
RCS file: /repository/phpdoc/en/reference/ncurses/versions.xml,v
retrieving revision 1.1
diff -u -r1.1 versions.xml
--- versions.xml2 Nov 2008 04:50:40 -   1.1
+++ versions.xml5 Apr 2009 04:52:29 -
@@ -4,166 +4,166 @@
   Do NOT translate this file
 -->
 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
- 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
 
 
 

Re: [PHP-DOC] [Patch] SimpleXMLIterator docs

[Juliette]

2009/3/27 Hannes Magnusson 
>
> After slightly better review, could you add  tags around
> "SimpleXMLIterator" in paragraphs, and use &null; rather then NULL?
> -Hannes
>

Attached is the updated patch.

I'll make you a deal; if you document another class and then submit
>
http://php.net/cvs-php, you'll have phpdoc karma as soon as Philip
> wakes up.. :)
> -Hannes


ok. :)

Juliette
Index: en/reference/spl/simplexmliterator.xml
===
RCS file: /repository/phpdoc/en/reference/spl/simplexmliterator.xml,v
retrieving revision 1.4
diff -u -u -r1.4 simplexmliterator.xml
--- en/reference/spl/simplexmliterator.xml  23 Aug 2008 14:09:15 -  
1.4
+++ en/reference/spl/simplexmliterator.xml  28 Mar 2009 06:00:21 -
@@ -10,7 +10,7 @@
   
&reftitle.intro;

-...
+The SimpleXMLIterator provides recursive iteration over all nodes of a 
SimpleXMLElement object.

   
 
Index: en/reference/spl/simplexmliterator/current.xml
===
RCS file: /repository/phpdoc/en/reference/spl/simplexmliterator/current.xml,v
retrieving revision 1.4
diff -u -u -r1.4 current.xml
--- en/reference/spl/simplexmliterator/current.xml  20 Mar 2008 01:25:04 
-  1.4
+++ en/reference/spl/simplexmliterator/current.xml  28 Mar 2009 06:00:21 
-
@@ -3,7 +3,7 @@
 http://docbook.org/ns/docbook";>
  
   SimpleXMLIterator::current
-  Return current SimpleXML entry
+  Returns the current element
  
  
   &reftitle.description;
@@ -11,9 +11,9 @@
mixedSimpleXMLIterator::current

   
-
-  &warn.undocumented.func;
-
+  
+   This method returns the current element as a 
SimpleXMLIterator object or &null;.
+  
  
 
  
@@ -24,7 +24,37 @@
  
   &reftitle.returnvalues;
   
-   The current SimpleXML entry.
+   Returns the current element as a SimpleXMLIterator 
object or &null; on failure.
+  
+ 
+
+ 
+  &reftitle.examples;
+  
+   
+Return the current element
+
+
+
+&example.outputs;
+
+
+
+   
   
  
 
Index: en/reference/spl/simplexmliterator/getchildren.xml
===
RCS file: 
/repository/phpdoc/en/reference/spl/simplexmliterator/getchildren.xml,v
retrieving revision 1.4
diff -u -u -r1.4 getchildren.xml
--- en/reference/spl/simplexmliterator/getchildren.xml  20 Mar 2008 01:25:04 
-  1.4
+++ en/reference/spl/simplexmliterator/getchildren.xml  28 Mar 2009 06:00:21 
-
@@ -3,7 +3,7 @@
 http://docbook.org/ns/docbook";>
  
   SimpleXMLIterator::getChildren
-  Returns an iterator for the current entry if it is a SimpleXML 
object
+  Returns a SimpleXMLIterator object containing the sub-elements 
of the current element
  
  
   &reftitle.description;
@@ -11,9 +11,9 @@
objectSimpleXMLIterator::getChildren

   
-
-  &warn.undocumented.func;
-
+  
+   This method returns a SimpleXMLIterator object 
containing the sub-elements of the current 
SimpleXMLIterator element.
+  
  
 
  
@@ -24,7 +24,44 @@
  
   &reftitle.returnvalues;
   
-   An iterator for the current entry, if it is a SimpleXML object.
+   Returns a SimpleXMLIterator object containing the 
sub-elements of the current element.
+  
+ 
+
+ 
+  &reftitle.examples;
+  
+   
+Return the sub-elements of the current element
+
+
+
+&example.outputs;
+
+
+
+   
   
  
 
Index: en/reference/spl/simplexmliterator/haschildren.xml
===
RCS file: 
/repository/phpdoc/en/reference/spl/simplexmliterator/haschildren.xml,v
retrieving revision 1.4
diff -u -u -r1.4 haschildren.xml
--- en/reference/spl/simplexmliterator/haschildren.xml  20 Mar 2008 01:25:04 
-  1.4
+++ en/reference/spl/simplexmliterator/haschildren.xml  28 Mar 2009 06:00:21 
-
@@ -3,7 +3,7 @@
 http://docbook.org/ns/docbook";>
  
   SimpleXMLIterator::hasChildren
-  Returns whether current entry is a SimpleXML object
+  Checks whether the current element has sub elements.
  
  
   &reftitle.description;
@@ -11,9 +11,9 @@
boolSimpleXMLIterator::hasChildren

   
-
-   &warn.undocumented.func;
-
+  
+   This method checks whether the current 
SimpleXMLIterator element has sub-elements.
+  
  
 
  
@@ -24,7 +24,49 @@
  
   &reftitle.returnvalues;
   
-   &true; if the current entry is a SimpleXML object, otherwise &false;
+   &true; if the current element has sub-elements, otherwise &false;
+  
+ 
+
+ 
+  &reftitle.examples;
+  
+   
+Check whether the current element has sub-elements
+
+
+
+&example.outputs;
+
+
+
+   
   
  
 
Index: en/reference/spl/simplexmliterator/key.xml
===
RCS file: /repository/phpdoc/en/reference/spl/simplexmliterator/key.xml,v
retrieving revision 1.4
diff -u -u -r1.4 key.xml
--- en/reference/spl/simplexmliterator/key.xml  20 Mar 2008 01:25:04 -  
1.4
+++ en/referenc

Re: [PHP-DOC] [Patch] SimpleXMLIterator docs

[Hannes Magnusson]

On Thu, Mar 26, 2009 at 14:26, Hannes Magnusson
 wrote:
> On Thu, Mar 26, 2009 at 13:56, Juliette  wrote:
>> Hi,
>> As mentioned earlier, here's a patch for the SimpleXMLiterator docs.
>> Suggestions for improvements welcomed. :)
>
> Quickly scanning over the patch, looks very good.

After slightly better review, could you add  tags around
"SimpleXMLIterator" in paragraphs, and use &null; rather then NULL?

-Hannes

Re: [PHP-DOC] [Patch] SimpleXMLIterator docs

[Hannes Magnusson]

On Thu, Mar 26, 2009 at 14:58, Juliette  wrote:
>
> 2009/3/27 Hannes Magnusson 
>>
>> Quickly scanning over the patch, looks very good.
>> Interested in continuing documenting various parts of PHP?
>> -Hannes
>
> Thanks Hannes, and yes I am interested in doing more documenting.

I'll make you a deal; if you document another class and then submit
http://php.net/cvs-php, you'll have phpdoc karma as soon as Philip
wakes up.. :)

-Hannes

Re: [PHP-DOC] [Patch] SimpleXMLIterator docs

[Juliette]

2009/3/27 Hannes Magnusson 
>
>
> Quickly scanning over the patch, looks very good.
> Interested in continuing documenting various parts of PHP?
> -Hannes
>

Thanks Hannes, and yes I am interested in doing more documenting.

- Juliette

Re: [PHP-DOC] [Patch] SimpleXMLIterator docs

[Hannes Magnusson]

On Thu, Mar 26, 2009 at 13:56, Juliette  wrote:
> Hi,
> As mentioned earlier, here's a patch for the SimpleXMLiterator docs.
> Suggestions for improvements welcomed. :)

Quickly scanning over the patch, looks very good.

Interested in continuing documenting various parts of PHP?

-Hannes

[PHP-DOC] [Patch] SimpleXMLIterator docs

[Juliette]

Hi,

As mentioned earlier, here's a patch for the SimpleXMLiterator docs.

Suggestions for improvements welcomed. :)


Thanks,

Juliette
Index: en/reference/spl/simplexmliterator.xml
===
RCS file: /repository/phpdoc/en/reference/spl/simplexmliterator.xml,v
retrieving revision 1.4
diff -u -u -r1.4 simplexmliterator.xml
--- en/reference/spl/simplexmliterator.xml  23 Aug 2008 14:09:15 -  
1.4
+++ en/reference/spl/simplexmliterator.xml  26 Mar 2009 12:31:37 -
@@ -10,7 +10,7 @@
   
&reftitle.intro;

-...
+The SimpleXMLIterator provides recursive iteration over all nodes of a 
SimpleXMLElement object.

   
 
Index: en/reference/spl/simplexmliterator/current.xml
===
RCS file: /repository/phpdoc/en/reference/spl/simplexmliterator/current.xml,v
retrieving revision 1.4
diff -u -u -r1.4 current.xml
--- en/reference/spl/simplexmliterator/current.xml  20 Mar 2008 01:25:04 
-  1.4
+++ en/reference/spl/simplexmliterator/current.xml  26 Mar 2009 12:31:37 
-
@@ -3,7 +3,7 @@
 http://docbook.org/ns/docbook";>
  
   SimpleXMLIterator::current
-  Return current SimpleXML entry
+  Returns the current element
  
  
   &reftitle.description;
@@ -11,9 +11,9 @@
mixedSimpleXMLIterator::current

   
-
-  &warn.undocumented.func;
-
+  
+   This method returns the current element as a SimpleXMLIterator object or 
NULL.
+  
  
 
  
@@ -24,7 +24,37 @@
  
   &reftitle.returnvalues;
   
-   The current SimpleXML entry.
+   Returns the current element as a SimpleXMLIterator object or NULL on 
failure.
+  
+ 
+
+ 
+  &reftitle.examples;
+  
+   
+Return the current element
+
+
+
+&example.outputs;
+
+
+
+   
   
  
 
Index: en/reference/spl/simplexmliterator/getchildren.xml
===
RCS file: 
/repository/phpdoc/en/reference/spl/simplexmliterator/getchildren.xml,v
retrieving revision 1.4
diff -u -u -r1.4 getchildren.xml
--- en/reference/spl/simplexmliterator/getchildren.xml  20 Mar 2008 01:25:04 
-  1.4
+++ en/reference/spl/simplexmliterator/getchildren.xml  26 Mar 2009 12:31:37 
-
@@ -3,7 +3,7 @@
 http://docbook.org/ns/docbook";>
  
   SimpleXMLIterator::getChildren
-  Returns an iterator for the current entry if it is a SimpleXML 
object
+  Returns a SimpleXMLIterator object containing the sub-elements 
of the current element
  
  
   &reftitle.description;
@@ -11,9 +11,9 @@
objectSimpleXMLIterator::getChildren

   
-
-  &warn.undocumented.func;
-
+  
+   This method returns a SimpleXMLIterator object containing the sub-elements 
of the current SimpleXMLIterator element.
+  
  
 
  
@@ -24,7 +24,44 @@
  
   &reftitle.returnvalues;
   
-   An iterator for the current entry, if it is a SimpleXML object.
+   Returns a SimpleXMLIterator object containing the sub-elements of the 
current element.
+  
+ 
+
+ 
+  &reftitle.examples;
+  
+   
+Return the sub-elements of the current element
+
+
+
+&example.outputs;
+
+
+
+   
   
  
 
Index: en/reference/spl/simplexmliterator/haschildren.xml
===
RCS file: 
/repository/phpdoc/en/reference/spl/simplexmliterator/haschildren.xml,v
retrieving revision 1.4
diff -u -u -r1.4 haschildren.xml
--- en/reference/spl/simplexmliterator/haschildren.xml  20 Mar 2008 01:25:04 
-  1.4
+++ en/reference/spl/simplexmliterator/haschildren.xml  26 Mar 2009 12:31:37 
-
@@ -3,7 +3,7 @@
 http://docbook.org/ns/docbook";>
  
   SimpleXMLIterator::hasChildren
-  Returns whether current entry is a SimpleXML object
+  Checks whether the current element has sub elements.
  
  
   &reftitle.description;
@@ -11,9 +11,9 @@
boolSimpleXMLIterator::hasChildren

   
-
-   &warn.undocumented.func;
-
+  
+   This method checks whether the current SimpleXMLIterator element has 
sub-elements.
+  
  
 
  
@@ -24,7 +24,49 @@
  
   &reftitle.returnvalues;
   
-   &true; if the current entry is a SimpleXML object, otherwise &false;
+   &true; if the current element has sub-elements, otherwise &false;
+  
+ 
+
+ 
+  &reftitle.examples;
+  
+   
+Check whether the current element has sub-elements
+
+
+
+&example.outputs;
+
+
+
+   
   
  
 
Index: en/reference/spl/simplexmliterator/key.xml
===
RCS file: /repository/phpdoc/en/reference/spl/simplexmliterator/key.xml,v
retrieving revision 1.4
diff -u -u -r1.4 key.xml
--- en/reference/spl/simplexmliterator/key.xml  20 Mar 2008 01:25:04 -  
1.4
+++ en/reference/spl/simplexmliterator/key.xml  26 Mar 2009 12:31:37 -
@@ -3,7 +3,7 @@
 http://docbook.org/ns/docbook";>
  
   SimpleXMLIterator::key
-  Return current SimpleXML key
+  Return current key
  
  
   &reftitle.description;
@@ -11,8 +11,9 @@
mixedSi

Re: [PHP-DOC] Patch for Bug #46474

[Hannes Magnusson]

On Tue, Nov 4, 2008 at 22:18, Lars Torben Wilson <[EMAIL PROTECTED]> wrote:
> 2008/11/4 Hannes Magnusson <[EMAIL PROTECTED]>:
>> On Tue, Nov 4, 2008 at 18:05, Lars Torben Wilson <[EMAIL PROTECTED]> wrote:
>>> One thing though: I've long since forgotten my CVS password (and it
>>> was several computers ago); if you could reset it for me and email me
>>> off-list that would be grand.
>>
>> Filling out https://master.php.net/forgot.php (your username is
>> "torben") will send instructions on how to reset your password to
>> [EMAIL PROTECTED]
>>
>> -Hannes
>
> Thanks Hannes! I realized that just after I got the 'forgot password'
> email; I suppose Philip filled it out for me.

Yeah, he poked me on IRC after I replied and told me :)

Philip: Keep it "online"! :)

-Hannes

Re: [PHP-DOC] Patch for Bug #46474

[Lars Torben Wilson]

2008/11/4 Hannes Magnusson <[EMAIL PROTECTED]>:
> On Tue, Nov 4, 2008 at 18:05, Lars Torben Wilson <[EMAIL PROTECTED]> wrote:
>> One thing though: I've long since forgotten my CVS password (and it
>> was several computers ago); if you could reset it for me and email me
>> off-list that would be grand.
>
> Filling out https://master.php.net/forgot.php (your username is
> "torben") will send instructions on how to reset your password to
> [EMAIL PROTECTED]
>
> -Hannes

Thanks Hannes! I realized that just after I got the 'forgot password'
email; I suppose Philip filled it out for me.


Regards,

Torben

Re: [PHP-DOC] Patch for Bug #46474

[Hannes Magnusson]

On Tue, Nov 4, 2008 at 18:05, Lars Torben Wilson <[EMAIL PROTECTED]> wrote:
> One thing though: I've long since forgotten my CVS password (and it
> was several computers ago); if you could reset it for me and email me
> off-list that would be grand.

Filling out https://master.php.net/forgot.php (your username is
"torben") will send instructions on how to reset your password to
[EMAIL PROTECTED]

-Hannes

Re: [PHP-DOC] Patch for Bug #46474

[Lars Torben Wilson]

2008/11/4 Philip Olson <[EMAIL PROTECTED]>:
>
> On 3 Nov 2008, at 23:26, Lars Torben Wilson wrote:
>
>> Hi all,
>>
>> This is a patch to address an error I made in the documentation for
>> the Variables section:
>
> Hello Torben!
>
> Feel free to commit anything you wish... your old CVS user account still
> works and welcome back! :)
>
> Regards,
> Philip

Hi Philip!

Long time no see. Sorry for my 5-year absence; life happened in odd
ways for a while there. I'm hoping to be a good docs contributor once
again.

One thing though: I've long since forgotten my CVS password (and it
was several computers ago); if you could reset it for me and email me
off-list that would be grand.

Looks like the docs have come a long way and they're looking really
good. I like what I've seen of the new build system and it looks like
there's a good doc crew on board too--even still a few of the old
friendly faces. :)


Cheers,

Torben

Re: [PHP-DOC] Patch for Bug #46474

[Philip Olson]

On 3 Nov 2008, at 23:26, Lars Torben Wilson wrote:


Hi all,

This is a patch to address an error I made in the documentation for
the Variables section:


Hello Torben!

Feel free to commit anything you wish... your old CVS user account  
still works and welcome back! :)


Regards,
Philip