On Mon, 18 Mar 2024 09:04:05 GMT, rjolly wrote:
>> @rjolly Thank you for your contribution. Could you provide more details
>> about the issue? The PR needs to be linked to a JBS issue. I'll create one
>> for you after I get a more detailed description of the problem from you.
>>
>> A test
On Thu, 22 Feb 2024 13:15:49 GMT, rjolly wrote:
>> ChangedCharSetException is used to amend the charset during read according
>> to html directives. Currently it causes immediate exit of the method which
>> in turn causes failure to load html documents with charset directives (even
>> if the
On Fri, 22 Mar 2024 21:05:09 GMT, Sergey Bylokhov wrote:
> > Instantiating JFileChooser on EDT adds complexity for no benefit. The
> > JFileChooser is still accessed concurrently from several threads, including
> > Swing internal thread.
>
> But still, this is a common requirement to create
On Fri, 22 Mar 2024 15:20:02 GMT, Alexey Ivanov wrote:
> I somewhat dislike that the test completes too quickly when I use my mouse.
> Yes, you warn the tester the test is semi-automatic, yet I'd prefer giving
> the tester more time.
>
> Technically, one event with `e.getWheel
On Fri, 22 Mar 2024 16:54:49 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR
On Fri, 22 Mar 2024 17:17:17 GMT, Phil Race wrote:
>> This previously closed test is cleaned up, opened and fixed to work on hidpi
>> at fractional scales.
>> It has unrelated problems on macOS 14 and is problem listed there (as it was
>> when it was a closed test).
>
> Phil Race has updated
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
Looks good to me.
I agree
On Thu, 21 Mar 2024 19:53:48 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR
On Thu, 21 Mar 2024 19:53:48 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR
On Thu, 21 Mar 2024 17:56:14 GMT, Phil Race wrote:
>> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
>> line 110:
>>
>>> 108: } catch (UnsupportedFlavorException | IOException e) {
>>> 109: e.printStackTrace();
>>> 110: }
>>
On Thu, 21 Mar 2024 17:19:25 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisp
On Thu, 21 Mar 2024 17:36:24 GMT, Damon Nguyen wrote:
>> Do we need an occasional _Skip_ button? Yet adding such a button to throw
>> `jtreg.SkippedException` will introduce a transitive dependency on the
>> library which contains the `SkippedException`.
>
> I'm OK with either direction. To
On Thu, 21 Mar 2024 17:40:55 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
>> test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Thu, 21 Mar 2024 17:34:19 GMT, Damon Nguyen wrote:
>> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 79:
>>
>>> 77: and Mission Control behavior.
>>> 78:
>>> 79: Close the windows.
>>
>> Won't it fail the test?
>
> This was a part of the
On Thu, 21 Mar 2024 17:13:34 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisp
On Thu, 21 Mar 2024 16:51:36 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
>> test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Thu, 21 Mar 2024 16:08:48 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
>> using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replace canvas
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote:
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre
On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov wrote:
> This is to simplify `TrayIconScalingTest.java`.
>
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more
> specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with
On Wed, 20 Mar 2024 18:57:37 GMT, Phil Race wrote:
>> Convert this applet based test to a main program
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8328301
On Thu, 21 Mar 2024 01:13:50 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR
On Thu, 21 Mar 2024 14:41:50 GMT, Prasanta Sadhukhan
wrote:
>> Couple closed manual applet text/html/CSS tests are converted to main based
>> and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review
On Thu, 21 Mar 2024 01:13:50 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR
On Thu, 21 Mar 2024 11:34:39 GMT, Prasanta Sadhukhan
wrote:
>> Couple closed manual applet text/html/CSS tests are converted to main based
>> and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> library
On Fri, 15 Mar 2024 15:00:40 GMT, Joel Uckelman wrote:
>> So, changing the condition in the `if`-block from `special1 || special2` to
>> `special1 && special2` makes the sorting order consistent because the
>> relation is now *transitive*:
>>
>>
>> a < b & b < c therefore a < c
>
> Hi, I'm
On Fri, 15 Mar 2024 15:00:40 GMT, Joel Uckelman wrote:
>> So, changing the condition in the `if`-block from `special1 || special2` to
>> `special1 && special2` makes the sorting order consistent because the
>> relation is now *transitive*:
>>
>>
>> a < b & b < c therefore a < c
>
> Hi, I'm
On Thu, 21 Mar 2024 11:48:28 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 662:
>>
>>> 660: button = new
>>> JButton(TimeoutHandlerPanel.PAUSE_BUTTON_LABEL);
>>> 661:
>>> 662: button.setFocusPainted(false);
>>
>> I
On Thu, 21 Mar 2024 11:51:43 GMT, Alexander Zvegintsev
wrote:
>>> we need to add next to Pass/Fail a "Pause Timer" button, that
>> (a) stops the count down
>> (b) changes the Pause Timer to "Resume Timer"
>> ~~(c) disables Pass/Fail until the timer is resumed~~
>> the test will not have to
On Wed, 20 Mar 2024 22:16:36 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
>> using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add new line
On Thu, 21 Mar 2024 11:24:45 GMT, Prasanta Sadhukhan
wrote:
>> The tests were probably written before Java 5, even tests written later
>> could still use `getContentPane` so that the test could be run with previous
>> versions of Java. Yet it's irrelevant now.
>>
>> The Java Tutorials have
On Wed, 20 Mar 2024 20:25:33 GMT, Alexander Zvegintsev
wrote:
>>> we need to add next to Pass/Fail a "Pause Timer" button, that
>> (a) stops the count down
>> (b) changes the Pause Timer to "Resume Timer"
>> ~~(c) disables Pass/Fail until the timer is resumed~~
>> the test will not have to
On Thu, 21 Mar 2024 01:16:03 GMT, Harshitha Onkar wrote:
>> I think we should update the instructions.
>>
>> A high resolution mouse produces events like this:
>>
>>
On Thu, 21 Mar 2024 03:28:56 GMT, Prasanta Sadhukhan
wrote:
>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove getContentPane from
On Thu, 21 Mar 2024 03:13:45 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JFrame/bug4419914.java line 71:
>>
>>> 69: frame.enableInputMethods(false);
>>> 70:
>>> frame.getContentPane().setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
>>> 71:
On Tue, 19 Mar 2024 08:58:35 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath
On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev
wrote:
>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or
On Wed, 20 Mar 2024 17:13:34 GMT, Harshitha Onkar wrote:
>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - minor fix
> - instruction line-lengths
On Wed, 20 Mar 2024 17:29:58 GMT, Harshitha Onkar wrote:
>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - frame.setSize() used
> - review update
> -
On Tue, 19 Mar 2024 21:07:44 GMT, Harshitha Onkar wrote:
>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with one
> additional commit since the last revision:
>
> instructions updated
Changes requested by aivanov
On Wed, 20 Mar 2024 16:46:45 GMT, Prasanta Sadhukhan
wrote:
>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> REview update
Marked as
On Tue, 19 Mar 2024 20:39:07 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49:
>>
>>> 47: below the instruction window.
>>> 48: Please make sure that some of the messages have non-zero
>>> 'wheelRotation' value,
>>> 49:
On Wed, 20 Mar 2024 10:18:43 GMT, Prasanta Sadhukhan
wrote:
>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> spacing
Changes requested by
On Tue, 19 Mar 2024 17:37:26 GMT, Harshitha Onkar wrote:
>> Win32 is not that old… Java still uses these APIs in 64-bit world.
>>
>> I haven't run the test myself (yet). I suggest replacing _Win32_ with
>> _Windows_. Is image under cursor visible when you drag'n'drop on Windows? It
>> should
On Mon, 18 Mar 2024 17:27:43 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR
On Tue, 19 Mar 2024 12:13:43 GMT, Abhishek Kumar wrote:
>> I agree with @azvegint, since it has @requires check in jtreg and the test
>> will mainly be run using jtreg framework , the OS check is not strictly
>> required.
>
> Fair enough.
I agree. Adding an explicit OS check adds one more
On Thu, 14 Mar 2024 19:54:19 GMT, Harshitha Onkar wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor changes
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 47:
>
>> 45:
On Thu, 14 Mar 2024 22:44:24 GMT, Harshitha Onkar wrote:
>> Following test is converted to main using PassFailJFrame.
>
> test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56:
>
>> 54: In WIN32 systems the image under cursor would be visible
>> ONLY over
>>
On Mon, 18 Mar 2024 15:09:20 GMT, Christoph Langer wrote:
> > Yes, it's running in 21 and 22 as well, so we'll see what happens there.
>
> We got the following, once in jdk21u and once in jdk21u-dev on macintelx64
> through the weekend:
Thank you, Christoph! @RealCLanger. At least one failure
On Fri, 15 Mar 2024 11:17:08 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java
>> line 211:
>>
>>> 209: private static void deleteFile(final Path file) {
>>> 210: try {
>>> 211:
On Tue, 19 Mar 2024 01:08:25 GMT, Sergey Bylokhov wrote:
>> I don't think it matters here… The test does not rely on even processing on
>> EDT, no state of `JFileChooser` is modified except for calling
>> `rescanCurrentDirectory`. Technically, I am not allowed to do so either. But
>> if I
On Thu, 14 Mar 2024 16:56:03 GMT, Alexey Ivanov wrote:
>> It is well described in a [JBS
>> comment](https://bugs.openjdk.org/browse/JDK-8305072?focusedId=14610400=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14610400)
>> by the submitter.
>
On Fri, 15 Mar 2024 15:21:23 GMT, Alexander Zvegintsev
wrote:
>> It could be obvious from the usage… so we may skip the header altogether… if
>> it's mentioned in the instructions, which should still be mentioned to let
>> the test know they need to look for the messages.
>
>> Placeholder
On Fri, 15 Mar 2024 15:34:27 GMT, lawrence.andrews wrote:
>> How about having a clear log button. Just an idea
>> Example :
>> I have a mouse event test & I am using the logArea to add all the events
>> into it. But when I have to file a bug & I wanted to show only the required
>> log in the
On Fri, 15 Mar 2024 14:15:12 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 489:
>>
>>> 487:
>>> 488: buttonsLogPanel.add(buttonsPanel);
>>> 489: buttonsLogPanel.add(new JScrollPane(logArea));
>>
>> Suggestion:
>>
>>
On Fri, 15 Mar 2024 12:13:52 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath
On Fri, 15 Mar 2024 14:59:07 GMT, Alexey Ivanov wrote:
>> This doesn't look good to me
>> 
>>
>> So how about a placeholder text? It will not take up any of the height of
>&
oncurrentModificationException` seen in
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in
> PR #18109.
Alexey Ivanov has updated the pull request incrementally with one additional
commit s
e.
>
> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does
> not reproduce the issue.
>
> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is
> because all the File Loading Threads are serialised on the COM thread,
> `ShellFolder.invo
On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev
wrote:
> Often manual tests have a text area in the instruction window to print
> feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these
> changes a standard
On Fri, 15 Mar 2024 13:11:06 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 406:
>>
>>> 404:rows, columns,
>>> 405:
On Fri, 15 Mar 2024 04:40:35 GMT, Alexander Zvegintsev
wrote:
>> Often manual tests have a text area in the instruction window to print
>> feedback from the test to be evaluated by a tester.
>> I stumbled across another test that needed this, so I decided to make these
>> changes a standard
On Thu, 14 Mar 2024 19:57:06 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Store the size of fileCache inside synchronized block
>
> src/java.desktop/share/
On Thu, 14 Mar 2024 19:37:30 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add copyright header
>
> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/Concu
On Thu, 14 Mar 2024 19:38:48 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add copyright header
>
> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/Concu
e.
>
> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does
> not reproduce the issue.
>
> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is
> because all the File Loading Threads are serialised on the COM thread,
> `ShellFolder.invo
On Fri, 15 Mar 2024 10:53:14 GMT, Tejesh R wrote:
>> @TejeshR13 What do you mean? What kind of line spacing would be nice here?
>
> Line spacing between JTREG tag and class.
It's not needed… but most people add it. And we cannot agree on *a common
style*, unfortunately.
These jtreg tags are
On Thu, 14 Mar 2024 19:37:48 GMT, Sergey Bylokhov wrote:
>> I'm adding a regression test for
>> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
>> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
>> regression test for
>>
On Fri, 15 Mar 2024 07:17:59 GMT, Christoph Langer wrote:
> I added it to our testing. Results early next week.
@RealCLanger Thank you. I'm more interested in the failing case. How reliable
does the test reproduce the problem?
-
PR Comment:
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath
On Fri, 15 Mar 2024 03:33:50 GMT, Tejesh R wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Added summary
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
>
>> 43: * @build
On Fri, 15 Mar 2024 06:45:57 GMT, Tejesh R wrote:
>> Most of the test with PassFailJFrame instruction stored as string inside
>> class, what additional benefit will get keeping it inside Main ?
>
> When it can become local variable then why to keep it in class? Not like
> significant benefit
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath
On Wed, 13 Mar 2024 18:49:03 GMT, Harshitha Onkar wrote:
> This test was previously problemlisted on macOS. When tested on macOS, the
> problem still exists…
I wonder if it depends on the font used. Is the selected font available on
macOS?
-
PR Comment:
On Wed, 13 Mar 2024 18:49:03 GMT, Harshitha Onkar wrote:
> java/awt/font/TextLayout/TestJustification.html is converted to main manual
> test using PassFailJFrame.
>
> This test was previously problemlisted on macOS. When tested on macOS, the
> problem still exists and not all lines are
On Thu, 14 Mar 2024 16:26:06 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated
On Thu, 14 Mar 2024 16:23:20 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 44:
>>
>>> 42: 0. There is a test window with a "Press" button,
>>> 43: Its original bounds should be printed in the text area
>>> below.
>>> 44:
On Thu, 14 Mar 2024 16:49:39 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java
>> line 525:
>>
>>> 523: boolean special2 = sf2.isSpecial();
>>> 524:
>>> 525: if (specia
On Tue, 12 Mar 2024 19:35:30 GMT, Phil Race wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Handle fakePersonal on Windows 10
>>
>> The desktop folder on Windows 1
On Thu, 29 Feb 2024 15:13:16 GMT, Alexey Ivanov wrote:
> A trivial change in a comment: consequent → _consecutive_ positions.
>
> This was found in [a code
> review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for
> [JDK-8285306](https://bugs.openjdk.org/bro
On Tue, 12 Mar 2024 13:35:33 GMT, Alexey Ivanov wrote:
> The test is converted to use `PassFailJFrame`.
>
> I confirmed the updated test reproduce the original problem described in
> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
> displayed as
On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame with information panel, earlier
> this was informed through terminal.
> Please review and let me know your suggestions if any.
Marked as reviewed by aivanov
On Wed, 13 Mar 2024 16:56:39 GMT, Alexander Zvegintsev
wrote:
>> @azvegint, yes, we can support both. But I didn't test it thoroughly, so I
>> decided it was safer to add this.
>>
>> Please, don't modify `PassFailJFrame` together with tests unless it's
>> strictly required… It is for the
On Wed, 13 Mar 2024 19:01:27 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> extract logFrameBounds,
On Thu, 14 Mar 2024 11:43:44 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 97:
>>
>>> 95: .testTimeOut(8)
>>> 96: .rows(25)
>>> 97: .columns(70
On Wed, 13 Mar 2024 22:04:00 GMT, Phil Race wrote:
>> Alexey Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> te
thod shows all the
> registered windows on the screen, including the instruction frame. Since
> there's no secondary UI, the instructions remain in the centre of the screen.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The pull request no
thod shows all the
> registered windows on the screen, including the instruction frame. Since
> there's no secondary UI, the instructions remain in the centre of the screen.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental we
On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov wrote:
> The `Builder` class in `PassFailJFrame` is public and has a public
> constructor. At the same time, a better design would be to hide all the
> Builder constructors and rely on the `builder()` method which returns an
&
arting it here.
>> All comments from the previous review are addressed.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/javax/swing/JEditorPane/bug4325606.java
>
> Co-autho
On Thu, 14 Mar 2024 09:25:29 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>
>> Co-auth
On Thu, 14 Mar 2024 06:51:47 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Marked
On Thu, 14 Mar 2024 06:48:08 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/border/Test4129681.java line 43:
>>
>>> 41: public static void main(String[] args) throws Exception {
>>> 42: String testInstructions = """
>>> 43: Turn on the checkbox to disable the label.
>>
On Wed, 13 Mar 2024 20:51:18 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 74:
>>
>>> 72: String html = " " +
>>> 73: "" +
>>> 74: "" +
>>
>> Suggestion:
>>
>> "" +
>>
>> Isn't it enough?
On Wed, 13 Mar 2024 20:49:19 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 64:
>>
>>> 62: } catch (IOException ioe){
>>> 63: throw new RuntimeException("Could not create html file to
>>> embed", ioe);
>>> 64: }
>>
>> Move
On Wed, 13 Mar 2024 19:57:08 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4325606.java line 84:
>>
>>> 82: robo.setAutoDelay(100);
>>> 83: robo.delay(1000);
>>> 84: Point p = frame.getLocationOnScreen();
>>
>> Technically,
arting it here.
>> All comments from the previous review are addressed.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>
> Co-authored-by: Alexey
On Wed, 13 Mar 2024 19:40:16 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 99:
>>
>>> 97: bug4773378.this.wait();
>>> 98: }
>>> 99: }
>>
>> Suggestion:
>>
>> frameActivated.await();
>>
>>
>> Using
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` threa
201 - 300 of 1956 matches
Mail list logo
