Re: 2.2.0rc2 Monday?

2012-10-25 Thread Andrew Grieve
I still need to re-tag android. Just finishing up fixes for CB-1744 and CB-1745 On Thu, Oct 25, 2012 at 2:45 PM, Filip Maj f...@adobe.com wrote: Cordova-mac, docs and WP7 are all that¹s left On 10/25/12 11:44 AM, Herm Wong kingoftheo...@hotmail.com wrote: webOS tagged 2.2.0rc2. From:

Re: 2.2.0rc2 Monday?

2012-10-25 Thread Andrew Grieve
that commit at all. Is someone going to do that? And then will the rc2 tag on this repo include this refresh? Thanks! -- Marcel Kinard On 10/25/2012 4:03 PM, Andrew Grieve wrote: Okay. I'll co-ordinate with Simon on the re-tagging. He's still working through one of the bugs

Re: firing more ontouchmove javascript events on android? Higher resolution / precision for ontouchmove?

2012-10-30 Thread Andrew Grieve
The Android bridge is about 25X faster in the 2.2.0 release candidate. 2.2.0 final should be released in the next couple of days, so I'd try your test again with that. I'd definitely like to know if piping the events through yourself ends up being faster than the browser events. On Mon, Oct 29,

Re: 2.2.0 tagging?

2012-10-30 Thread Andrew Grieve
There's nothing outstanding that I'm aware of for iOS / Android. This release is going to be solid! On Tue, Oct 30, 2012 at 7:42 PM, Shazron shaz...@gmail.com wrote: iOS issues all resolved or punted to 2.3.0. Can the js be tagged? On Tue, Oct 30, 2012 at 1:25 PM, Joe Bowser

Re: firing more ontouchmove javascript events on android? Higher resolution / precision for ontouchmove?

2012-10-31 Thread Andrew Grieve
The 25x is based on the mobile-spec benchmark Braden mentioned. That's for non-synchronous plugins. There are lots of details in the bug ( issues.cordova.io/638). The 25x is based on the PROMPT+HANGING_GET number in this

Re: iOS: Why does the cordova.js filename change?

2012-11-05 Thread Andrew Grieve
, Andrew Grieve agri...@chromium.org wrote: It actually does bother me a little bit too, to have the file name have a version in it when we're developing. I don't really care where we put the file so long as there is only one copy of it and not multiple. On Wed, Oct 31, 2012 at 4:22 PM

Re: Whitelist defaults

2012-11-06 Thread Andrew Grieve
Adding * by default SGTM. Having separate debug/release whitelists sounds dangerous though. You don't want your app to work in debug mode and then be broken when you release it. On Mon, Nov 5, 2012 at 7:26 PM, Anis KADRI anis.ka...@gmail.com wrote: I confirm that Android also uses config.xml.

Re: iOS 4.3 support, do we need it?

2012-11-06 Thread Andrew Grieve
+1. This will let us use weak refs as well! On Tue, Nov 6, 2012 at 6:24 PM, Brion Vibber br...@pobox.com wrote: +1 for moving to 5.0 minimum. We're planning to drop 4.3 support from the next major release of the Wikipedia app as 4.x is just so buggy, and now anybody who can download our

Re: 2.3.0 major new features

2012-11-07 Thread Andrew Grieve
seen any issues debugging, can you elaborate? Some example code would help to make sure we are all using the same terms. thanks, -becky On Tue, Nov 6, 2012 at 11:54 PM, Andrew Grieve agri...@chromium.org wrote: Here's my list of things I want to see done / plan on doing: Bigger

Re: online/offline Events

2012-11-07 Thread Andrew Grieve
Here's the Android impl: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=blob;f=framework/src/org/apache/cordova/NetworkManager.java;h=5d8791809227877d604c98cf029c26242d9642b8;hb=HEAD The JS performs a Connection.getConnectionInfo(), and then the native plugin returns

Re: [Android] ./bin/emulate + debug script behavior

2012-11-07 Thread Andrew Grieve
Here's a proposal for getting rid of our existing scripts, and starting with some new ones (CB-1668): - build --clean == clean first --debug == build in DEBUG mode (default) --release == build in RELEASE mode - run --nobuild == don't run the build command first --debug /

Re: iOS: Why does the cordova.js filename change?

2012-11-07 Thread Andrew Grieve
Created bug: https://issues.apache.org/jira/browse/CB-1822 On Mon, Nov 5, 2012 at 3:03 PM, Shazron shaz...@gmail.com wrote: I'm thinking we only update: CordovaLib/cordova.ios.js with the latest from cordova-js I think we could do this without the explicit step. Ok.

Re: [Android] ./bin/emulate + debug script behavior

2012-11-07 Thread Andrew Grieve
I don't like the word deploy since that might imply uploading to app-store kind of things. Any beef with my build / run / package proposal? +1 to no user interaction by default. Maybe have an --interactive flag to enable it if we want it. On Wed, Nov 7, 2012 at 3:10 PM, Filip Maj f...@adobe.com

Re: iOS' device API

2012-11-07 Thread Andrew Grieve
I like the idea of at least removing this from the start-up path. If users want to know about the device, they could always call exec() themselves. On Wed, Nov 7, 2012 at 4:57 PM, Shazron shaz...@gmail.com wrote: Also, if we remove the device API like Brian suggested, it would be good in the

Re: [Android] - State, Plugins and the Android Lifecycle

2012-11-08 Thread Andrew Grieve
Yeah, I don't think this can be done without putting onus on the JS for storing restoring its own state. We could maybe put the callback result of the exec() call that triggered the activity change in the start-up info when restoring (e.g. pass the service, action, result to onDeviceReady)? On

iOS 6 Messes up Timers when Scrolling

2012-11-09 Thread Andrew Grieve
Just thought I'd bring this up to raise awareness. There is a work-around here: https://gist.github.com/3755461 Of course, being a native wrapper we could also work around this by re-implementing timers. Not sure that we should jump to fixing this in Cordova right away, but maybe it's worth

Re: iOS 6 Messes up Timers when Scrolling

2012-11-09 Thread Andrew Grieve
http://wiki.apache.org/cordova/MobilePolyfills On Fri, Nov 9, 2012 at 10:26 AM, Andrew Grieve agri...@google.com wrote: Just thought I'd bring this up to raise awareness. There is a work-around here: https://gist.github.com/3755461 Of course, being a native wrapper we could also work

Re: Query regarding Storage Class...

2012-11-12 Thread Andrew Grieve
Hi Kumail, try a Google search for phonegap sqllite plugin. Looks like one already exists. On Thu, Nov 8, 2012 at 6:50 AM, Kumail Raza smkrn...@hotmail.com wrote: Hi! Dear, First of all thanks to all the team mate of Apache Cordova Library, thats really a great piece of work due to which

Re: InAppBrowser api questions

2012-11-12 Thread Andrew Grieve
On Mon, Nov 12, 2012 at 2:11 PM, Shazron shaz...@gmail.com wrote: Bump. These questions below still need some discussion and consensus before the InAppBrowser implementation can be complete. On Fri, Nov 9, 2012 at 9:43 AM, Shazron shaz...@gmail.com wrote: WIki page:

CLA Confirmations

2012-11-13 Thread Andrew Grieve
I think I've heard that sometimes when people send in their CLAs that they don't make it to this page: https://people.apache.org/committer-index.html#unlistedclas Is there someone that we should email in this case? Seems it's happened to Kevin :(

Re: online/offline Events

2012-11-13 Thread Andrew Grieve
...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Mittwoch, 7. November 2012 16:27 To: dev Subject: Re: online/offline Events Here's the Android impl: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=blob;f=framework/src/org/apache/cordova

Re: [Android] Feedback requested on our camera

2012-11-14 Thread Andrew Grieve
Yep, got it working by adding that line to the manifest. My impression is the same as Simon just said. The stock Camera on 4.2 is really nice, so taking this away is a bit sad. I understand the motivation behind wanting this when other stock cameras are buggy though, and there are certainly many

Re: [Android] Can everyone run the tests?

2012-11-14 Thread Andrew Grieve
Tried to follow the command-line instructions but get: agrieve@dhcp-172-23-181-44 ~/git/incubator-cordova-android/framework (asdf) $ adb shell am instrument -w com.phonegap/android.test.InstrumentationTestRunner INSTRUMENTATION_STATUS: id=ActivityManagerService INSTRUMENTATION_STATUS:

Re: CLA Confirmations

2012-11-14 Thread Andrew Grieve
bump On Tue, Nov 13, 2012 at 12:06 PM, Andrew Grieve agri...@chromium.orgwrote: I think I've heard that sometimes when people send in their CLAs that they don't make it to this page: https://people.apache.org/committer-index.html#unlistedclas Is there someone that we should email

Re: Changes to the JS?

2012-11-15 Thread Andrew Grieve
Oh! This reminds me... When I was doing the navigator.connection work, I had a tough time figuring out how to get the builder to do the correct thing. It's a bit confusing because module.exports.objects in common.js don't clobber, but module.exports.objects in platform.js *do* clobber. I wanted

Type checking in Cordova JS plugins

2012-11-15 Thread Andrew Grieve
There's very little consistency when it comes to checking params in plugin code. globalization.jshttps://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=blob;f=lib/common/plugin/globalization.js;h=a57062ce8b1e0cc95dde54f8ca600f6ee4876bfd;hb=HEAD: checks every args. logs errors and

Re: Changes to the JS?

2012-11-15 Thread Andrew Grieve
letting them know everything is back to normal. Simon Mac Donald http://hi.im/simonmacdonald On Thu, Nov 15, 2012 at 4:20 PM, Andrew Grieve agri...@chromium.orgwrote: Okay, just pushed and have run spec tests before / after changes. They File ones failed before and are fixed now. I'm seeing

Re: [Android] Can everyone run the tests?

2012-11-16 Thread Andrew Grieve
JUnit Tests in Eclipse is pretty trivial, as is running these from the command line. I just tried it and here's the command: adb shell am instrument -w org.apache.cordova.test/android.test.InstrumentationTestRunner On Thu, Nov 15, 2012 at 7:32 PM, Andrew Grieve agri...@chromium.org

Re: [Android] Can everyone run the tests?

2012-11-16 Thread Andrew Grieve
Okay, actually, command line instructions were a bit off, (framework directory --- test directory) + need to adb update project. I'll (update wiki) But! Tests all passed for me except on my 4.0.1 emulator. On Fri, Nov 16, 2012 at 2:58 PM, Andrew Grieve agri...@chromium.org wrote: Thanks Joe

Re: [Android] Can everyone run the tests?

2012-11-16 Thread Andrew Grieve
I think you need to run it so that it sets the SDK path in local.properties. On Fri, Nov 16, 2012 at 4:23 PM, Joe Bowser bows...@gmail.com wrote: The project should be updated. Do you have the latest code? On Fri, Nov 16, 2012 at 12:40 PM, Andrew Grieve agri...@chromium.org wrote: Okay

Re: iOS: Can we clean up the view lifecycle in 2.3?

2012-11-21 Thread Andrew Grieve
Finally got these patches merged in. Thanks for spearheading this Kevin! On Thu, Nov 8, 2012 at 5:00 PM, Kevin Hawkins kevin.hawkins.cord...@gmail.com wrote: I'll add the corresponding JIRA tasks, and put some pull requests together. Not a lot of code changes involved. Thanks, Kevin

Re: Type checking in Cordova JS plugins

2012-11-21 Thread Andrew Grieve
be cordova.isArray() ... Cheers, Jesse Sent from my iPhone5 On 2012-11-15, at 12:16 PM, Andrew Grieve agri...@google.com wrote: There's very little consistency when it comes to checking params in plugin code. globalization.js https://git-wip-us.apache.org/repos/asf?p=incubator

Re: [iOS] Cordova.plist to config.xml - deprecation

2012-11-21 Thread Andrew Grieve
Made a bug for this: https://issues.apache.org/jira/browse/CB-1893 On Thu, Nov 8, 2012 at 2:12 PM, Shazron shaz...@gmail.com wrote: It won't have to special case dealing with some stupid .plist format. And the rest of your args have been clarified by Fil. On Thu, Nov 8, 2012 at 10:35 AM,

Re: InAppBrowser - events

2012-11-21 Thread Andrew Grieve
Both Chrome and Firefox are working on similar APIs, but I don't think there's much progress towards standardizing yet. Firefox's is documented here: https://wiki.mozilla.org/WebAPI/BrowserAPI Chrome doesn't have docs for it yet, but use them in a sample app:

Re: InAppBrowser - events

2012-11-21 Thread Andrew Grieve
); } // Chrome function handleLoadStop(e) { console.log('location changed to: ' + e.url); } On Wed, Nov 21, 2012 at 1:32 PM, Andrew Grieve agri...@chromium.org wrote: https://github.com/GoogleChrome/chrome-app-samples/blob/master/browser/browser.js

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
depending on this other repo. Cheers, Jesse Sent from my iPhone, forgive fat fingers. On 2012-11-22, at 6:55 AM, Andrew Grieve agri...@chromium.org wrote: Good point Patrick. I'll go with a console.log + exception. On Thu, Nov 22, 2012 at 9:01 AM, Patrick Mueller pmue...@gmail.com

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
, Andrew Grieve agri...@chromium.org wrote: There's a good amount of code that currently check types on the public API. My goal here is to shrink that code because it seems repetitive. Checking the types passed to exec may be useful in some cases too, but we don't currently do that. Probably

Re: Fast edit-refresh cycles

2012-11-22 Thread Andrew Grieve
something that we should vote on before developing further if the goal is inclusion in cordova. Cheers, Jesse On Thu, Nov 22, 2012 at 2:34 AM, Brian LeRoux b...@brian.io wrote: super interesting. I like where this is going. On Thu, Nov 22, 2012 at 3:42 AM, Andrew Grieve agri

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
...@gmail.com wrote: Nevermind then, guess it's in ... On Thu, Nov 22, 2012 at 12:51 PM, Andrew Grieve agri...@chromium.org wrote: I just checked in argscheck.js and refactored all applicable lower-case plugin/*.js files to use it. It trims 4k off of cordova.ios.js and git tells me

Re: Android WebView

2012-11-22 Thread Andrew Grieve
Yeah, a lot of those changes seem risky. The invalidate for sure, but also making every div in your app hw-accelerated will work only for extremely small DOMs, and in the average case cause more harm than good. That said, carefully selecting which elements to apply that to goes a long way. Upping

Re: InAppBrowser - events

2012-11-22 Thread Andrew Grieve
/simonmacdonald On Wed, Nov 21, 2012 at 11:30 PM, Shazron shaz...@gmail.com wrote: Great! Let's stick with one API, since we have Chrome members on the Cordova team the choice is obvious :) On Wed, Nov 21, 2012 at 8:06 PM, Andrew Grieve agri...@chromium.org wrote: Looks

iOS Changes to InAppBrowser

2012-11-22 Thread Andrew Grieve
Just pushed a few. Let me know if you have concerns about any of them. 1. I changed the User-Agent from appending a GUID to appending the VC's memory location I was hoping this would let me get rid of the vc header field in the bridge all together, but it turns out that the User-Agent isn't being

Re: Fast edit-refresh cycles

2012-11-23 Thread Andrew Grieve
22, 2012 at 9:18 PM, Andrew Grieve agri...@chromium.org wrote: On Thu, Nov 22, 2012 at 3:36 PM, Gord Tanner gtan...@gmail.com wrote: This also is feeding into some of the work we are doing with ripple. Ripple will serve up the app and host it kind of like

Re: [iOS] Cordova.plist to config.xml - deprecation

2012-11-29 Thread Andrew Grieve
Copying from the JIRA issue to this thread: I think supporting both was one of the things that upset users when Android made the switch (at least, it upset me). What happened was that I ended up having both files present, and the code was silently using one and not the other, and I couldn't

Re: Determining if you're in cordova

2012-12-03 Thread Andrew Grieve
I don't really understand using cordova.js outside of Cordova. There's one for every platform, so which one gets included in the web version? It's a neat idea to have a web-platform that just has things like cordova/util in it, or that has everything except an exec() implementation in it... Maybe

Re: [iOS] Cordova.plist to config.xml - deprecation

2012-12-04 Thread Andrew Grieve
The step of having to update the project reference would probably still been confusing / annoying. I've just enhanced the script so that it converts the file and also updates your project file. The upgrade instructions will now be: 1. Drop in new CordovaLib 2. Drop in updated cordova.js 3. Run

Re: Android Cordova FileTransfer.upload generates 503 errors with some web servers.

2012-12-05 Thread Andrew Grieve
I looked at switching to HttpClient when fixing some of the Android FT bugs a while ago. According to this blog post (by an Android dev), HttpURLConnection is recommended for gingerbread+. http://android-developers.blogspot.ca/2011/09/androids-http-clients.html On Wed, Dec 5, 2012 at 9:55 PM,

Re: [Android] Chrome Content Shell

2012-12-07 Thread Andrew Grieve
That's great that you got it running Joe! I know that there has been a good amount of webview activity within the chrome repo lately. My understanding is that it's still pretty rough / crashy though. I'm planning on playing around with it around the feb/march timeframe (and hoping that it will be

Re: [Android] Explicitly writing to the jail

2012-12-07 Thread Andrew Grieve
I really like this idea of using LocalFileSystem.APP (and maybe LocalFileSystem.ASSETS). I don't know if it's a good idea to eventually merge APP with PERSISTENT though. Spec-wise, it's my understanding that PERSISTENT is supposed to give you a sandboxed place to keep files, and so it wouldn't

Re: Android changes for 2.3.0?

2012-12-18 Thread Andrew Grieve
LGTM On Tue, Dec 18, 2012 at 12:16 PM, Simon MacDonald simon.macdon...@gmail.com wrote: Anything I'm missing here before I post it? *1. InAppBrowser – includes events* More details here http://shazronatadobe.wordpress.com/2012/11/21/inappbrowser-based-on-childbrowser-in-cordova-2-3-0/

Re: mobile-spec failures on iOS 6.0.0

2012-12-19 Thread Andrew Grieve
I committed this. On Fri, Dec 14, 2012 at 2:43 PM, Shazron shaz...@gmail.com wrote: For review -- cordova-js pull request filed: https://github.com/apache/cordova-js/pull/3 On Fri, Dec 14, 2012 at 11:17 AM, Shazron shaz...@gmail.com wrote: Instead of doing the tag and test dance again

Re: too long to package a release?

2012-12-20 Thread Andrew Grieve
I definitely think we'd get more done if we didn't have such a long code-freeze. I'm not sure this is the same as what you were suggesting, but have a script/tool to branch all of the platforms into an rc branch. Then, each platform can fix themselves up a bit and tag their RC. Meanwhile, dev can

Re: too long to package a release?

2013-01-03 Thread Andrew Grieve
On Wed, Jan 2, 2013 at 11:05 PM, Michal Mocny mmo...@chromium.org wrote: On Wed, Jan 2, 2013 at 7:27 PM, Andrew Grieve agri...@chromium.org wrote: From my understanding of git, there's nothing special about the master branch, except that it's what gets checked out when someone doesn't

Re: content for 2.4?

2013-01-04 Thread Andrew Grieve
I'm planning to focus on bug fixes as well as working on support for JS within plugins (e.g. following up on my food for thought email). On Thu, Jan 3, 2013 at 3:19 PM, Brian LeRoux b...@brian.io wrote: This requires a new thread to garner some consensus. Gonna kick that up. (Stoked that

Re: Revert CLI tools to using git

2013-01-07 Thread Andrew Grieve
Makes perfect sense to me. We shouldn't be depending on github when our code lives on Apache servers. git is a pretty easy dependency to install, and I also think the versioning / tags use-case is important. Brian, what's your concern with using git? On Mon, Jan 7, 2013 at 5:21 PM, Filip Maj

Re: (CB-2164) Revert CLI tools to using git

2013-01-07 Thread Andrew Grieve
Okay, replied to the other thread before seeing this. I think this thinking is good. Start with git for now, and once everything is working well, add the option to download snapshots. On Mon, Jan 7, 2013 at 6:52 PM, Filip Maj f...@adobe.com wrote: Fair enough. Ill slowly chip away at it..

Re: Slicing files on iOS and Android

2013-01-07 Thread Andrew Grieve
Right, what Becky said. It might be worth looking into having the iOS bridge take care of international characters directly instead of special-casing the FileReader. We should be able to escape characters using \u instead of percent escaping them. If you're interested in looking into this,

Re: Binary data across exec bridge

2013-01-08 Thread Andrew Grieve
Rather than binary data, I think we should focus strictly on ArrayBuffer. I think the only other binary data concept is Blob, and Blob is easy to create from an ArrayBuffer. As for how to have one of these show up in a JSON object, I think it will be tough to make this work. Most platforms assume

Re: Binary data across exec bridge

2013-01-09 Thread Andrew Grieve
On Wed, Jan 9, 2013 at 10:15 AM, Michal Mocny mmo...@chromium.org wrote: On Tue, Jan 8, 2013 at 10:22 PM, Andrew Grieve agri...@chromium.org wrote: Rather than binary data, I think we should focus strictly on ArrayBuffer. I think the only other binary data concept is Blob, and Blob

Re: Moving plugin JS files around

2013-01-09 Thread Andrew Grieve
/foo/js/blackberry/qnx.js What does a plugin (native and js code) folder structure look like? On Wed, Jan 9, 2013 at 9:42 AM, Andrew Grieve agri...@google.com wrote: I'd like to take a first step towards moving plugin JS into separate repos by first

Blog Points out Cordova's Weak Spots

2013-01-10 Thread Andrew Grieve
http://engblog.polyvore.com/2012/12/web-developer-admits-objective-c-html.html?m=1 I think I agree with the author. I do still believe the mobile web will be better in the future though :)

Re: Cordova Activity Code Changes

2013-01-10 Thread Andrew Grieve
I'd like to verify if this is the scenario: 1. We invoke an intent that causes another app to take the foreground. 2. Our app is forced to close by the OS due to memory pressures 3. The other app finishes and sends an intent back to us 4. Our app re-initializes, finds the plugin that started the

Re: Moving plugin JS files around

2013-01-10 Thread Andrew Grieve
: require('cordovaplugin/keychain/keychain') In terms of changes to the builder, we'd need to add the idea of multiple roots. Instead of just 'lib', there will also be 'plugin' as a root. On Wed, Jan 9, 2013 at 9:42 AM, Andrew Grieve agri...@google.com wrote: I'd like to take a first step

Re: Should Automatic Reference Counting be on?

2013-01-11 Thread Andrew Grieve
This caught me off-guard as well, and I filed an issue to fix it up: https://issues.apache.org/jira/browse/CB-2180 I don't think it'll be entirely straight-forward though, because some plugins still do not support ARC. What are everyone's thoughts on how to address this? One option is to have

Re: too long to package a release?

2013-01-11 Thread Andrew Grieve
? Or would those be created only as necessary when we needed a point release? On Thu, Jan 10, 2013 at 9:05 PM, Andrew Grieve agri...@chromium.org wrote: I'm not clear on the difference between dev and unstable. If something is so shaky that we're considering not putting it in the next release

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
. I am completely open to further discussion on the point. Cheers, Jesse Sent from my iPhone5 On 2013-01-10, at 8:09 PM, Andrew Grieve agri...@chromium.org wrote: On Wed, Jan 9, 2013 at 10:28 AM, Gord Tanner gtan...@gmail.com wrote: Ideally the require paths should stay true

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
Created a bug for the file moving part (CB-2214), but we can continue discussing here. On Mon, Jan 14, 2013 at 2:39 PM, Andrew Grieve agri...@chromium.org wrote: Jesse, thanks for the explanation. Certainly my experience is just with Android iOS, so it's good to get opinions from the other

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
use sync. XHRs), and I think would have negative effects on performance. On Mon, Jan 14, 2013 at 3:41 PM, Jesse purplecabb...@gmail.com wrote: Comments inline below. On Mon, Jan 14, 2013 at 11:43 AM, Andrew Grieve agri...@chromium.org wrote: Created a bug for the file moving

Re: Moving plugin JS files around

2013-01-14 Thread Andrew Grieve
On Mon, Jan 14, 2013 at 3:41 PM, Jesse purplecabb...@gmail.com wrote: Comments inline below. On Mon, Jan 14, 2013 at 11:43 AM, Andrew Grieve agri...@chromium.org wrote: Created a bug for the file moving part (CB-2214), but we can continue discussing here. On Mon, Jan 14, 2013 at 2

Re: too long to package a release?

2013-01-14 Thread Andrew Grieve
On Mon, Jan 14, 2013 at 4:54 PM, Filip Maj f...@adobe.com wrote: But do Canonical branches merge into each other? I'm thinking no. My understanding: - work goes into feature branches - when contributor(s) deem feature is ready, merge into Unstable, which then gets vetted (test!) - at

Re: [BENCHMARKS] (CB-2216) Create Mobile Spec Test to benchmark ArrayBuffer exec bridge

2013-01-14 Thread Andrew Grieve
From doing the exec bridge benchmark: - Joe wrote a version of it that used Jasmine, but it didn't show the same timing results as the hand-coded one. I don't think Jasmine is a good option for benchmarks - I wrote a version of the exec benchmark that used benchmark.js. Found it worked really well

Symbol Mapping in Cordova

2013-01-15 Thread Andrew Grieve
Sorry to dump another large email on the list, but I'm hoping this one is at least less controversial :). I wrote up a plan for moving module-symbol mapping out of common.js platform.js and into individual plugins. If you have feedback/comments, let me know. * Goals: - Change from listing

Android Bug with File API

2013-01-16 Thread Andrew Grieve
https://issues.apache.org/jira/browse/CB-2208 Wondering if anyone knows if just adding a try/catch is the proper fix? 01-11 14:34:23.028: I/dalvikvm(1465): java.lang.UnsupportedOperationException: Unknown URI: content://media/external/images/media match: 1 01-11 14:34:23.028: I/dalvikvm(1465):

Re: Symbol Mapping in Cordova

2013-01-17 Thread Andrew Grieve
/CB-2227 On Wed, Jan 16, 2013 at 4:35 PM, Andrew Grieve agri...@chromium.org wrote: Branch started! I've completed steps 1 2. https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=shortlog;h=refs/heads/symbolmapping On Wed, Jan 16, 2013 at 1:39 PM, Filip Maj f...@adobe.com wrote

Re: Cordova-CLI: Version handling

2013-01-17 Thread Andrew Grieve
Looking at iOS as an example: To do an upgrade: 1. Close xcode 2. Delete CordovaLib CordovaLib.xcodeproj 3. Copy in new CordovaLib CordovaLib.xcodeproj Sometimes: - Add extra frameworks to your App's target The thing I'd be afraid of with a script, is if they've modified their CordovaLib or

Re: Cordova-CLI: Version handling

2013-01-17 Thread Andrew Grieve
On Thu, Jan 17, 2013 at 3:17 PM, Filip Maj f...@adobe.com wrote: On 1/17/13 11:57 AM, Andrew Grieve agri...@chromium.org wrote: Looking at iOS as an example: To do an upgrade: 1. Close xcode 2. Delete CordovaLib CordovaLib.xcodeproj 3. Copy in new CordovaLib CordovaLib.xcodeproj

Cygwin for Windows

2013-01-20 Thread Andrew Grieve
I'm sure this has come up some time in the past, but why not require cygwin so that our scripts will work on windows? Cygwin has been a requirement of most of the windows projects I've worked on in the past (when at different companies).

Re: Cygwin for Windows

2013-01-21 Thread Andrew Grieve
/kerrishotts Apps on the Apple Store: https://itunes.apple.com/us/artist/photokandy-studios-llc/id498577828 On Jan 20, 2013, at 8:14, Andrew Grieve agri...@google.com wrote: I'm sure this has come up some time in the past, but why not require cygwin so that our scripts will work

Re: Intro + First contribution

2013-01-21 Thread Andrew Grieve
Hi Yaniv! Very excited to see new contributors! I think what you propose sounds great. If you haven't seen it yet, be sure to give this wiki page a read through: http://wiki.apache.org/cordova/ContributorWorkflow You'll need to sign an ICLA before committing any code. Had a look at your

Re: Media APIs - some research and discussion

2013-01-21 Thread Andrew Grieve
Yeah, I believe that's the case as well. I'm not sure what the replacement is though :( On Mon, Jan 21, 2013 at 9:01 AM, Brian LeRoux b...@brian.io wrote: I think that spec is defunct and the functionality was removed from Chrome recently. =.( On Sun, Jan 20, 2013 at 10:29 PM, Simon

Re: Issues with Mobile-spec on iOS

2013-01-21 Thread Andrew Grieve
Just to close the loop on this. I believe this to be fixed with (CB-2094). Please report if it's still happening. On Thu, Jan 3, 2013 at 7:12 PM, Shazron shaz...@gmail.com wrote: Amended: If you have a multi-page app, and you use InAppBrowser, and you use iOS 6, you must use iframe bridge

Re: Should Automatic Reference Counting be on?

2013-01-21 Thread Andrew Grieve
supported ARC or not. (I would think this should be determined in the metadata somewhere? Perhaps defaulting to no-ARC if there's no metadata saying one way or the other?) On Jan 11, 2013, at 9:14 AM, Andrew Grieve agri...@chromium.org javascript:; wrote: This caught me off-guard

Re: navigator.onLine

2013-01-21 Thread Andrew Grieve
Most mobile browsers now do support online/offline events + navigator.onLine out-of-the box. The thing Cordova adds ontop of this is the navigator.connection.type API. We override onLine by default to ensure that it stays in sync with what connection.type reports. It's up to each platform to

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Andrew Grieve
Fil, is there any way on ci.cordova.io to see which tests are failing and on which devices? AFAIK, the slice() tests that braden added *should* be passing on both iOS Android. If they are not, we should fix them. I added one test that checks that native Blob objects still work with FileReader.

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Andrew Grieve
One tough thing about this is knowing when you have agreement or not. E.g. for adding File.slice(), Braden sent out an email on the 7th saying that he'd like to add it for iOS Android. Simon gave it a +1, and no one else responded. He then implemented the feature in a feature branch and then

Re: CordovaJS is broken on Android 2.x, rollback and re-tag?

2013-01-21 Thread Andrew Grieve
Yikes, I somehow missed that we're trying to do a 2.4 release. I see now that there were bugs created for it, but was there any kind of hey, let's do a release-type email? I thought we'd at least figure out this master vs dev/Next/Stable branch thing before we cut a 2.4. I think the JS fix should

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Andrew Grieve
On Mon, Jan 21, 2013 at 4:24 PM, Joe Bowser bows...@gmail.com wrote: On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve agri...@chromium.org wrote: One tough thing about this is knowing when you have agreement or not. E.g. for adding File.slice(), Braden sent out an email on the 7th saying

Re: Can we talk about large features before they arrive in master?

2013-01-22 Thread Andrew Grieve
ReviewBoard seems like a great fit to me! Let's try it out! On Mon, Jan 21, 2013 at 8:43 PM, Brian M Dube bd...@apache.org wrote: On 01/21/2013 01:24 PM, Joe Bowser wrote: On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve agri...@chromium.org wrote: As for code reviews: I'd certainly

Re: too long to package a release?

2013-01-22 Thread Andrew Grieve
Michal's attending hackathons for the week, and I'm not sure we need to do a hang-out for this, as I think we really are quite close to resolving this. I'd really like to resolve this ASAP so that we don't need to have a code-freeze for this release. Here's a proposal: Cordova repositories have

Re: Can we talk about large features before they arrive in master?

2013-01-22 Thread Andrew Grieve
Michal wrote. It started working, so I cleaned up my debugging and pushed. That was premature, since I broke some of the tests and hadn't run the automatic tests. Gomen nasai. Braden On Tue, Jan 22, 2013 at 10:59 AM, Andrew Grieve agri...@chromium.org wrote: ReviewBoard seems like a great

Re: too long to package a release?

2013-01-22 Thread Andrew Grieve
/11844581/git-delete-and-recreate-branch On Tue, Jan 22, 2013 at 11:31 AM, Andrew Grieve agri...@chromium.org wrote: Michal's attending hackathons for the week, and I'm not sure we need to do a hang-out for this, as I think we really are quite close to resolving this. I'd really like

Re: too long to package a release?

2013-01-22 Thread Andrew Grieve
I won't be at ApacheCon. Don't think Michal/Max/Braden had plans to go either... On Tue, Jan 22, 2013 at 3:32 PM, Andrew Grieve agri...@chromium.org wrote: In google doc form: https://docs.google.com/document/d/1s617PCwJm_lOjybHAnkgm5WdoDdU113fkGBCrlPghxE/edit On Tue, Jan 22, 2013 at 3:29

Re: Are we in bugfix mode?

2013-01-23 Thread Andrew Grieve
but the second one probably no. On Wed, Jan 23, 2013 at 1:23 PM, Shazron shaz...@gmail.com wrote: I'm still unclear on what was decided :/ On Wed, Jan 23, 2013 at 10:15 AM, Andrew Grieve agri...@chromium.org wrote: Max has had his changes to support asset URLs pending since last week

Re: 2.4.0rc1

2013-01-23 Thread Andrew Grieve
+1. Nothing too broken right now that I'm aware of :) On Wed, Jan 23, 2013 at 1:48 PM, Jesse purplecabb...@gmail.com wrote: +1 Do it and move on to the next one. On Wed, Jan 23, 2013 at 10:35 AM, Brian LeRoux b...@brian.io wrote: Lets do it. On Wed, Jan 23, 2013 at 12:27 PM, Filip

Re: Getting Started

2013-01-23 Thread Andrew Grieve
Indeed! Welcome Matt! On Wed, Jan 23, 2013 at 4:54 PM, Michael Brooks mich...@michaelbrooks.cawrote: Welcome to the community Matt, it's awesome to hear from you again! I imagine Becky would be excited to have your support. Feel free to chime in on the thread. Michael On Wed, Jan 23,

Re: too long to package a release?

2013-01-24 Thread Andrew Grieve
, Jan 23, 2013 at 1:19 PM, Filip Maj f...@adobe.com wrote: Looks great Andrew! If everyone's on board, how are we going to test run this? Flip a switch at a certain point, give it a shot with one repo for one RC? On 1/22/13 12:29 PM, Andrew Grieve agri...@chromium.org wrote

Re: [Android] Explicitly writing to the jail

2013-01-24 Thread Andrew Grieve
I've written summaries on the bug of storage locations that exist on iOS Android. I'm wondering if any other platforms want to participate in this discussion before we start proposing new (maybe platform-specific) LocalFileSystem constants? On Tue, Jan 22, 2013 at 9:58 AM, Andrew Grieve agri

Re: too long to package a release?

2013-01-24 Thread Andrew Grieve
, Andrew Grieve agri...@chromium.org wrote: On Wed, Jan 23, 2013 at 4:58 PM, Michael Brooks mich...@michaelbrooks.ca wrote: Before we move forward, I have a few questions about the no master approach. There is *no* master branch, so that community-driven

Re: too long to package a release?

2013-01-24 Thread Andrew Grieve
' if we are inReleaseMode and it is a bug fix? if(inReleaseMode isBugFix) { commitToBranch('next'); mergeBranch('next').into('master'); } else { commitToBranch('master'); } On Thu, Jan 24, 2013 at 12:29 PM, Andrew Grieve agri...@chromium.org wrote: Just to clarify

Re: Testing 2.4.0rc1 on iOS - 2 possible failures

2013-01-25 Thread Andrew Grieve
Yeah, the BlobConstructor one is a test that only passes on iOS6. I think probably we should add logic to disable it on iOS5, but haven't gotten to it yet. On Fri, Jan 25, 2013 at 3:51 PM, Max Woghiren m...@google.com wrote: I'm not seeing the FileTransfer error on an iPad2 / iOS 6.0. I am

  1   2   3   4   5   6   7   8   9   10   >