Re: Review Request 26163: Fixed AllocatorTest.SlaveLost test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26163/#review54947 --- Ship it! Ship It! - Ben Mahler On Sept. 30, 2014, 2:46 a.m

Re: Review Request 26152: Remove unused stout tuples/ folder

stout (which are actually used), but this is for libprocess. - Ben Mahler On Sept. 29, 2014, 9:55 p.m., Cody Maloney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 26144: Fixed AllocatorTest.FrameworkExited test.

tps://reviews.apache.org/r/26144/#comment95190> Can you include a comment like the one above? // The framework does not use all the resources. - Ben Mahler On Sept. 29, 2014, 7:28 p.m., Vinod Kone wrote: > > --- > This is an automati

Review Request 26141: Increased the store timeout for the Registrar tests.

--- Increased the store timeout for the Registrar tests. Diffs - src/tests/registrar_tests.cpp cd83bf09313db1ee1825c30bb5e07e386622e668 Diff: https://reviews.apache.org/r/26141/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 96-99 > > <https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96> > > > > Why would the iterator be called `containerizer`? > > > >

Re: Review Request 25986: Added reconcileTasks to python scheduler.

needed for MESOS-1461, I'll assign that to you. Can you link the ticket into this review? - Ben Mahler On Sept. 24, 2014, 6:02 a.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

altogether and we'll extend _Abort when the need arises. - Ben Mahler On Sept. 25, 2014, 7:34 p.m., Patrick Reilly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 25945: Pass Promise to DispatchEvent to correctly discard on rejection.

iting some simple libprocess tests that demonstrate the added semantics of dispatch: (1) Process terminated: discarded. (2) Non-existent UPID: discarded. - Ben Mahler On Sept. 23, 2014, 5:24 p.m., Dominic Hamon wrote: > >

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 96-99 > > <https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96> > > > > Why would the iterator be called `containerizer`? > > > >

Re: Review Request 25867: Updated ping message to embed the slave registered status.

<https://reviews.apache.org/r/25867/#comment94647> Couldn't you just expect the dispatch on SlaveObserver::disconnect, instead of the allocator dispatch + clock::settle? - Ben Mahler On Sept. 22, 2014, 11:51 p.

Re: Review Request 25866: Updated semantics of disconnected/deactivated slaves/frameworks in master.

/reviews.apache.org/r/25866/#comment94623> What about saying that we don't expect a slave to be connected and deactivated? Ditto below. src/master/master.cpp <https://reviews.apache.org/r/25866/#comment94620> Looks like connected = true doesn't need to be do

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

Info, directory) .then(bind(::accumulate, l, lambda::_1)); } prepare(...) { Future>> f = list>(); foreach (Owned isolator, isolators) { f = f.then(bind(::prepare, lambda::_1, isolator, containerId, executorInfo, directory); } f.then(_prepare) } ``` - Ben Mahler On

Re: Review Request 25864: Add 'Future cgroups::empty()'.

> On Sept. 22, 2014, 7:12 p.m., Ben Mahler wrote: > > Why do you need this? > > > > Seems like one would only watch for cgroup emptiness when destroying a > > cgroup, in which case, why split emptiness waiting from a successful > > destroy? > > Ian

Re: Review Request 25947: Dynamically change reap poll interval.

e nice to have the linear interpolation logic in one place, instead of defining the "gain" constant up above. - Ben Mahler On Sept. 24, 2014, 12:26 a.m., Ian Downes wrote: > > --- > This is an automatically gener

Re: Review Request 25569: Refactor test environment validations

- > > (Updated Sept. 23, 2014, 10:02 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > --- > > Review: https://reviews.apache.org/r/25569 >

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 96-99 > > <https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96> > > > > Why would the iterator be called `containerizer`? > > > >

Re: Review Request 25569: Refactor test environment validations

/ ? src/tests/environment.cpp <https://reviews.apache.org/r/25569/#comment94349> Looks like you're always adding two colons because of the outer strings::join(). You shouldn't need the ":" here anymore, right? How about the following to be con

Re: Review Request 25569: Refactor test environment validations

you needed to rebase against master. - Ben Mahler On Sept. 22, 2014, 9:17 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 96-99 > > <https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96> > > > > Why would the iterator be called `containerizer`? > > > >

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

> On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 96-99 > > <https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96> > > > > Why would the iterator be called `containerizer`? > > > >

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

622/#comment94168> Why would the iterator be called `containerizer`? s/containerizer/iterator/ ? docs/mesos-c++-style-guide.md <https://reviews.apache.org/r/25622/#comment94170> Will >> work with gcc 4.4+? :) - Ben Mahler On Sept. 22, 2014, 1:10 p.m., Alexand

Re: Review Request 25864: Add 'Future cgroups::empty()'.

emptiness when destroying a cgroup, in which case, why split emptiness waiting from a successful destroy? - Ben Mahler On Sept. 22, 2014, 6:46 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 25868: Refactor Libprocess: class ProcessReference

> On Sept. 20, 2014, 7:22 p.m., Ben Mahler wrote: > > Thanks Joris! > > > > Any reason you want this exposed in the public include/ folder of > > libprocess, as opposed to an internal header inside src/? Don't think we'd > > want this in the

Re: Review Request 25868: Refactor Libprocess: class ProcessReference

include/ folder of libprocess, as opposed to an internal header inside src/? Don't think we'd want this in the public includes. - Ben Mahler On Sept. 20, 2014, 12:58 a.m., Joris Van Remoortere wrote: > > --- > This

Re: Review Request 25569: Refactor test environment validations

abledTest/filtered/ ? If disabledTest() returned a vector of strings as before you can do the following here: ``` disabled += strings::join(":", filtered(unitTest, filters); ``` No clunky

Re: Review Request 25819: post-reviews.py: use --no-color with git log.

- > > (Updated Sept. 19, 2014, 5:20 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > --- > > Force git log to never emit colored output (for setups with colored output > enabled by default)

Review Request 25843: Fixed an executor accounting bug in framework re-registration.

src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25843/diff/ Testing --- Added a test that catches the CHECK failure without the fix. make check Thanks, Ben

Review Request 25844: Ignore terminal task resources in the Master's Framework struct.

r.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d Diff: https://reviews.apache.org/r/25844/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 25810: Fixed a segfault regression in the master.

--- Ran the test in repetition. Thanks, Ben Mahler

Re: Review Request 25805: Fixed example frameworks to fail fast on an unexpected status udpate.

ples/test_framework.cpp <https://reviews.apache.org/r/25805/#comment93776> Ditto here. - Ben Mahler On Sept. 19, 2014, 12:08 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 25801: Fixed example frameworks to launch tasks based of offered resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25801/#review53906 --- Ship it! - Ben Mahler On Sept. 19, 2014, 12:09 a.m., Vinod Kone

Re: Review Request 25569: Refactor test environment validations

ent.cpp <https://reviews.apache.org/r/25569/#comment93755> How about s/testFilter/filters/ ? :) src/tests/environment.cpp <https://reviews.apache.org/r/25569/#comment93754> Since this is a .cpp file, you can add a using clause for process::Owned so that you don't nee

Re: Review Request 25755: Replace os::Release with Version.

tps://reviews.apache.org/r/25755/#comment93738> I'll add a newline here before I commit, since it was lost during your change. - Ben Mahler On Sept. 18, 2014, 3:04 p.m., Kapil Arya wrote: > > --- > This is an automatica

Re: Review Request 25780: Mesos: Replace os::Release with Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25780/#review53876 --- Ship it! Ship It! - Ben Mahler On Sept. 18, 2014, 3:07 p.m

Re: Review Request 25755: Replace os::Release with Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25755/#review53875 --- Ship it! Ship It! - Ben Mahler On Sept. 18, 2014, 3:04 p.m

Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

https://reviews.apache.org/r/25567/diff/ Testing --- make check Added new tests in https://reviews.apache.org/r/25568/ Thanks, Ben Mahler

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

> Diffs > - > > src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 > src/tests/master_tests.cpp 3d080b2efad5a210353d4cef4c827380d5138d1a > src/tests/reconciliation_tests.cpp 1c9e73b0ee99a8a33f663f992b0c9770e83b98c5 > > Diff: https://reviews.apache.org/r/25568/diff/ > > > Testing > --- > > make check, ran these new tests in repetition > > > Thanks, > > Ben Mahler > >

Re: Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

b98c5 Diff: https://reviews.apache.org/r/25568/diff/ Testing --- make check, ran these new tests in repetition Thanks, Ben Mahler

Re: Review Request 25755: Replace os::Release with Version.

> On Sept. 17, 2014, 11:20 p.m., Ben Mahler wrote: > > Whoops, looks like the test fails for me. Since we need to fix it, can you > > split the patch while you're at it? > > > > I think the parsing needs to be more advanced to handle OSes with labels on > &g

Re: Review Request 25755: Replace os::Release with Version.

[ RUN ] OsTest.release ../../../../3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp:270: Failure info: Version string has 4 components; maximum 3 components allowed $ uname -a 2.6.44-LABEL.el5 #1 SMP Tue May 13 15:46:59 PDT 2014 x86_64 x86_64 x86_64 GNU/Linux -

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

? It's hard to tell. - Ben Mahler On Sept. 17, 2014, 10:26 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 25755: Replace os::Release with Version.

patch for you across stout and mesos this time. We split our reviews across stout/libprocess/mesos because the former two are still considered separate libraries. :) - Ben Mahler On Sept. 17, 2014, 10:50 p.m., Kapil Arya wrote

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

duplicated code between Group and ZooKeeperStorage, we already solved this problem in ZooKeeperStorage! ;) - Ben Mahler On Sept. 17, 2014, 7:26 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 25565: Added a removeExecutor helper in the Master.

executor" inside removeExecutor(). I've re-phrased per your comment and left a NOTE about the current issues around MESOS-1466, MESOS-1800, and MESOS-1720. - Ben --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 25565: Added a removeExecutor helper in the Master.

aster::finalize Diffs (updated) - src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 src/master/master.cpp 41dcc462f04ee44ab16cde2c542a7bf27e46a913 Diff: https://reviews.apache.org/r/25565/diff/ Testing --- no functional change make check Thanks, Ben Mahler

Re: Review Request 25035: Fix for MESOS-1688

> On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote: > > src/master/hierarchical_allocator_process.hpp, line 837 > > > > > > What happens in the case where all CPUs are taken but memory is > > available? It looks

Re: Review Request 25597: Added a version checker class to stout.

> On Sept. 16, 2014, 9:05 p.m., Ben Mahler wrote: > > Thanks Kapil, looks great! I will get this committed for you shortly, I'll > > just add a TODO per your comments on more than 3 version components and > > I'll remove the single quotes per my com

Re: Review Request 25597: Added a version checker class to stout.

quotes here are unnecessary since these are just numbers? We could say: "maximum 3 components allowed" instead of using the colon, does that read a little better? - Ben Mahler On Sept. 16, 2014, 8

Re: Review Request 25597: Added a version checker class to stout.

> On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34 > > <https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32> > > > > The program will crash if the split is

Re: Review Request 25597: Added a version checker class to stout.

rror.get() << "."; ``` 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp <https://reviews.apache.org/r/25597/#comment93269> Two newlines between top level definitions. 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp <https://reviews.apache.org/r/25597/

Re: Review Request 25597: Added a version checker class to stout.

> On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, lines 32-34 > > <https://reviews.apache.org/r/25597/diff/3/?file=688423#file688423line32> > > > > The program will crash if the split is

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

ure > data? Or should we consider wrapping our things in some kind of ZKOperation which lets us look at the various error cases? Happy to chat further! - Ben Mahler On Sept. 15, 2014, 9:24 p.m., Jiang Yan Xu wrote: > >

Re: Review Request 25597: Added a version checker class to stout.

https://reviews.apache.org/r/25597/#comment93248> Missing include? 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp <https://reviews.apache.org/r/25597/#comment93249> Some error cases would be great here! - Ben Mahler On Sept. 16, 2014, 5:11 a.m., Kapil Arya wrote:

Re: Review Request 25614: Safer handling of futures in JNI state abstraction

> On Sept. 15, 2014, 9:17 p.m., Jie Yu wrote: > > This more looks like a bug somewhere. Let's try to find out the true root > > cause first. > > Niklas Nielsen wrote: > True - but throwing the result away from await() seems silly/unsafe too > (rather on relying on the await to have complet

Re: Review Request 25597: Added a version checker class to stout.

> On Sept. 15, 2014, 6:46 p.m., Ben Mahler wrote: > > Thanks for adding this Kapil! > > > > I made a few notes for cleanup, in particular, about: > > > > (1) The consolidation with os::Release, which implements ~ the same thing. > > (2) Leveraging stringi

Re: Review Request 25597: Added a version checker class to stout.

y/libprocess/3rdparty/stout/tests/version_tests.cpp <https://reviews.apache.org/r/25597/#comment93005> You're not using this? 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp <https://reviews.apache.org/r/25597/#comment93006> Not using this? - Ben Mahl

Review Request 25604: Fixed the flaky FaultToleranceTest.ReconcilePendingTasks.

/fault_tolerance_tests.cpp 80d7fcff0cac8b862c727706b6931aaeba9e49dd Diff: https://reviews.apache.org/r/25604/diff/ Testing --- Ran this test in repetition. Thanks, Ben Mahler

Re: Review Request 25569: Only perform docker validation once for tests

Error()) { std::cerr << ... << std::endl; } // Unfortunately there is no Result constructor yet that takes a Try. docker = docker_.isSome() ? docker_.get() : Try::error(docker_.error()); } if (docker.isError()) { return fa

Re: Review Request 25079: Replaced macro expansion with variadic template

> On Sept. 12, 2014, 7:03 p.m., Ben Mahler wrote: > > Thanks for doing this! A few higher level comments: > > > > (1) We have strings::join in stout. Have you considered implementing this > > TLineHelper as a generic Joiner in stout/strings.hpp? Seems like it belo

Re: Review Request 25079: Replaced macro expansion with variadic template

e writing both C++11/non-C++11 code paths in stout/libprocess due to the complexity and the maintenance burden, but that's a decision we should seek benh's input on. For now, the #ifdef is certainly a safe way to go. - Ben Mahler On Aug. 28, 2014, 4:24 p.m.,

Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

://reviews.apache.org/r/25568/ Thanks, Ben Mahler

Review Request 25568: Added tests for terminal unacknowledged tasks in the Master.

repetition Thanks, Ben Mahler

Review Request 25566: Minor cleanups to the Master code.

b4926001178ebb00b34b0b7e03f491d4a800afc2 src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 Diff: https://reviews.apache.org/r/25566/diff/ Testing --- no functional change make check Thanks, Ben Mahler

Review Request 25565: Added a removeExecutor helper in the Master.

/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 Diff: https://reviews.apache.org/r/25565/diff/ Testing --- no functional change make check Thanks, Ben Mahler

Re: Review Request 25511: Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the shutdown call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25511/#review52999 --- Ship it! Ship It! - Ben Mahler On Sept. 10, 2014, 6:02 p.m

Re: Review Request 25487: Increased session timeouts for ZooKeeper related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25487/#review52998 --- Ship it! Ship It! - Ben Mahler On Sept. 10, 2014, 6 p.m., Jiang

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

ly generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/#review52518 ----------- On Sept. 9, 2014, 12:43 a.m., Ben Mahler wrote: > > --- > Th

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

dated) - src/tests/fault_tolerance_tests.cpp b0e74b94db8a68cd676569d42b2ccd120f12b9d3 Diff: https://reviews.apache.org/r/25373/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/#review52611 ------- On Sept. 9, 2014, 12:43 a.m., Ben Mahler wrote: > > --

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

s.hpp b31c347299707cba242619c3dc6915f295bee9cb src/tests/mesos.cpp 0f759a70b457561bc878fa62b819142a064d5ea4 src/tests/reconciliation_tests.cpp 8c66659982ceff37572a89628221c40be1c59406 Diff: https://reviews.apache.org/r/25372/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

src/tests/mesos.cpp 0f759a70b457561bc878fa62b819142a064d5ea4 src/tests/reconciliation_tests.cpp 8c66659982ceff37572a89628221c40be1c59406 Diff: https://reviews.apache.org/r/25372/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

cleaned these up as well. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/#review52518 --- On Sept. 5,

Re: Review Request 25371: Send pending tasks during re-registration.

5fa51bf1c100805ebd997c20ce020d4ca11664be src/tests/slave_recovery_tests.cpp 357edfc134e825036aeea58ca0b66bb48f3d08e9 Diff: https://reviews.apache.org/r/25371/diff/ Testing --- Test added in the review chain. Thanks, Ben Mahler

Re: Review Request 25371: Send pending tasks during re-registration.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25371/#review52511 --- On Sept. 9, 2014, 12:41 a.m., Ben Mahler wrote: > > --- >

Re: Review Request 22066: Added timeout to rescind unused offers

e slave is expecting to hear back from the master within 75 seconds, otherwise it re-registers. At that point, the master rescinds the offers. I'll update these tests to use a 30 second timeout for now. src/tests/master_tests.cpp <https://reviews.apache.org/r/22066/#comment91286&g

Review Request 25372: Made the GarbageCollector injectable into the Slave.

/reconciliation_tests.cpp 8c66659982ceff37572a89628221c40be1c59406 Diff: https://reviews.apache.org/r/25372/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 25373: Added a test for sending pending tasks during re-registration.

://reviews.apache.org/r/25373/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 25371: Send pending tasks during re-registration.

357edfc134e825036aeea58ca0b66bb48f3d08e9 Diff: https://reviews.apache.org/r/25371/diff/ Testing --- Test added in the review chain. Thanks, Ben Mahler

Re: Review Request 25344: Improved the error message when destroying a container.

ps://reviews.apache.org/r/25344/#comment91158> s/_future/future_/ akin to prime notation - Ben Mahler On Sept. 4, 2014, 11:47 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 25344: Improved the error message when destroying a container.

<https://reviews.apache.org/r/25344/#comment91151> Could you use an Owned to avoid the need for deleting the promise explicitly? - Ben Mahler On Sept. 4, 2014, 11:12 p.m., Jie Yu wrote: > > --- > This is an automatical

Review Request 25306: Flattened the executor resoures when launching executors.

check Thanks, Ben Mahler

Review Request 25304: Removed an unnecessarily introduced Option.

p.cpp 39f840026595547c36f2c8b630ea8bcfc7b8dfbc src/slave/slave.hpp 9d4607ef126f40ade9c861e3ea0eb41f10a3dff9 src/slave/slave.cpp 5c76dd1b9d3f7d262053aa4c20ebc2e8a00a0f4e Diff: https://reviews.apache.org/r/25304/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 25303: Fixed a bug in the staging tasks metric.

/25303/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 25302: Count pending tasks as staging in the slave.

://issues.apache.org/jira/browse/MESOS-1716 Repository: mesos-git Description --- See summary. Diffs - src/slave/slave.cpp 5c76dd1b9d3f7d262053aa4c20ebc2e8a00a0f4e Diff: https://reviews.apache.org/r/25302/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 25079: Replaced macro expansion with variadic template

require C++11. We're not yet able to assume C++11: https://issues.apache.org/jira/browse/MESOS-750 - Ben Mahler On Aug. 26, 2014, 9:44 p.m., Patrick Reilly wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 25055: Added logging when master/slaves/frameworks bind to loopback address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25055/#review51491 --- Ship it! Ship It! - Ben Mahler On Aug. 26, 2014, 2:49 a.m

Review Request 24877: Refactored the JSON output streaming.

ut/json.hpp d98d953957e3bca11d311d570ccad0f306cc43c7 Diff: https://reviews.apache.org/r/24877/diff/ Testing --- make check Thanks, Ben Mahler

Review Request 25053: Adjustments for new JSON streaming.

--- This is needed for libprocess to compile with the new changse in r/24877. Diffs - 3rdparty/libprocess/include/process/http.hpp 6358e331ae1256b19d52a6803875d2b64d75eb69 Diff: https://reviews.apache.org/r/25053/diff/ Testing --- make check Thanks, Ben Mahler

Re: Review Request 22066: Added timeout to rescind unused offers

n Duration::zero(). - Ben Mahler On Aug. 20, 2014, 1:54 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 22066: Added timeout to rescind unused offers

> On Aug. 19, 2014, 10:21 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 2134-2136 > > <https://reviews.apache.org/r/22066/diff/4/?file=662801#file662801line2134> > > > > This comment is no longer relevant, and we can remove the Clock::resume

Re: Review Request 24753: Moved 'mesos::internal::logging::installSignalFailureHandler()' to stout/logging.hpp.

> On Aug. 18, 2014, 5:54 p.m., Ben Mahler wrote: > > Whoops, this change mixes stout / libprocess / mesos code! > > > > Probably our CHECK logic should eventually move inside a glog.hpp header as > > well to isolate the glog dependency in stout. ping :) Looks like

Re: Review Request 24635: Updated command executor to use the new CommandInfo.

up? src/launcher/executor.cpp <https://reviews.apache.org/r/24635/#comment89823> This doesn't print correctly when there are no arguments: [value, ] src/slave/slave.cpp <https://reviews.apache.org/r/24635/#comment89824> Ditto here. - Ben Mahler On Aug. 1

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/#review51472 --- Ship it! Ship It! - Ben Mahler On Aug. 22, 2014, 1:29 p.m

Re: Review Request 22066: Added timeout to rescind unused offers

ter_tests.cpp <https://reviews.apache.org/r/22066/#comment88935> It's not the slave that declines, it's the framework. How about: "Wait for the framework to decline the offers." src/tests/master_tests.cpp <https://reviews.apache.org/r/220

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

therefore XSI applications should check whether si_code has the value SI_USER or SI_QUEUE or is less than or equal to 0 to tell whether si_pid and si_uid are valid.** - Ben Mahler On Aug. 18, 2014, 11:33 a.m., Alexandra Sava wrote: > > --

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: > > I don't think that si_uid can give something interesting because it can be > > either 0 or UID of receiving process. How about logging si_pid too? > > Ben Mahler wrote: > si_uid represents the user id

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

> On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: > > I don't think that si_uid can give something interesting because it can be > > either 0 or UID of receiving process. How about logging si_pid too? > > Ben Mahler wrote: > si_uid represents the user id

Re: Review Request 24753: Moved 'mesos::internal::logging::installSignalFailureHandler()' to stout/logging.hpp.

/stout/include/stout/logging.hpp <https://reviews.apache.org/r/24753/#comment88784> Any reason this isn't inside a namespace like 'glog' or 'logging'? - Ben Mahler On Aug. 15, 2014, 11:31 p.m., Vinod Kone wrote: > > -

Re: Review Request 24687: Added support for disabling glog initialization.

for the library entry points (executor / scheduler drivers), for other components (master / slave) it is ignored completely. - Ben Mahler On Aug. 14, 2014, 1:19 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

tps://reviews.apache.org/r/24700/ > --- > > (Updated Aug. 14, 2014, 3:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1567 > https://issues.apache.org/jira/browse/MESOS-1567 > > > Reposi

<    3   4   5   6   7   8   9   10   11   12   >